Timeline



Jun 25, 2011:

11:33 PM Changeset in webkit [89764] by abarth@webkit.org
  • 4 edits in trunk

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::queueLoad):
10:43 PM Changeset in webkit [89763] by pfeldman@chromium.org
  • 13 edits
    10 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: new chromium baselines.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt: Added.
9:33 PM Changeset in webkit [89762] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

  • fast/dom/shadow/frameless-media-element-crash.html: Added.
  • fast/dom/shadow/frameless-media-element-crash-expected.txt: Added.

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
in the calling code.

Test: fast/dom/shadow/frameless-media-element-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created. (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation. (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
  • html/HTMLMediaElement.h: Adjusted def.
9:09 PM Changeset in webkit [89761] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
9:04 PM Changeset in webkit [89760] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Fix some minor style issues
https://bugs.webkit.org/show_bug.cgi?id=63391

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): The explicit WebCore namespace usage can be dropped.
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): Use ASSERT_UNUSED for a parameter that we want to ASSERT on for a debug build, but is UNUSED in a release build.
5:39 PM Changeset in webkit [89759] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

Unreviewed build correction after r89426.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Link with Cairo DLL for new functionality.
  • WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility code for snprintf.
5:36 PM Changeset in webkit [89758] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.

  • Shared/API/c/cairo/WKImageCairo.h: Declare cairo type as struct (in keeping with other declarations).
  • win/WebKit2.vcproj: Add new WKImageCairo.cpp file to WinCairo build.
5:22 PM Changeset in webkit [89757] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89503.
See http://trac.webkit.org/changeset/89503. The modifications
to the WebKit2.def need to be mirrored in WebKit2CFLite.def.

  • win/WebKit2CFLite.def: Add new exported symbol for isPreloaded.
4:32 PM Changeset in webkit [89756] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix.

Use UNUSED_PARAM on the correct param!

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
4:10 PM Changeset in webkit [89755] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.
See http://trac.webkit.org/changeset/89426. The new WebKit2
header file (WKImageCairo.h) is needed.

  • win/WebKit2Generated.make: Make sure to copy the WKImageCairo.h

header file to the WebKit2 API directory after building.

4:01 PM Changeset in webkit [89754] by Joseph Pecoraro
  • 22 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 2: Only adjust for the FrameView's scroll position when
the localToAbsolute mapping did not end with fixed content.
Content that is inside of a fixed position container is already
adjusted for the FrameView's scrollPosition when RenderView
maps local to container.

This patch uses a "wasFixed" out parameter to determine if
the localToAbsolute transformation ended inside a fixed block,
and if so does not apply the scroll position.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): Respect wasFixed as described above.
  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): This is the only time that "fixed" ever changed. So when fixed changes, update the optional wasFixed out parameter.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): Ignore wasFixed by default, but pipe it though where needed.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): This is the final recursive call, so wasFixed goes no further. We sanity check its value in debug builds.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
  • rendering/RenderInline.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
  • rendering/svg/SVGRenderSupport.h: Pipe wasFixed through where needed.
4:01 PM Changeset in webkit [89753] by Joseph Pecoraro
  • 8 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 1: Provide FloatQuad versions of convertFromRenderer,
convertToContainingView, and convertChildToSelf, so that we
can get the fully transformed quad of a renderer all the
way up to the root widget.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf):
  • platform/Widget.h:
  • platform/Widget.cpp: (WebCore::Widget::convertToContainingView): Provide FloatQuad versions of these already existing functions.

(WebCore::Widget::convertToRootContainingView):
Provide a helper conversion function to recursively
convert a given FloatQuad up to the root widget.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): Use the new methods to convert the FloatQuad for the highlighted node to the root container, without losing transformation information. Add a FIXME for SVG, which is still broken.
  • WebCore.exp.in: Export the new Widget functions so WebKit can link properly.
3:16 PM Changeset in webkit [89752] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-25 Dirk Schulze <krit@webkit.org>

Unreviewed build fix.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
3:08 PM Changeset in webkit [89751] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Remove ifdefs around these two functions because
we're not planning to move them. This patch makes WebFrameImpl.h
consistent with WebFrame.h so we can build with the new API
configuration.

  • src/WebFrameImpl.h:
3:02 PM Changeset in webkit [89750] by krit@webkit.org
  • 15 edits
    7 adds in trunk

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumberList.


Animations of attributes with type SVGNumberList can be interpolated now.

Tests: svg/animations/svgnumberlist-animation-1.html

svg/animations/svgnumberlist-animation-2.html

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedNumber): Made method static for reuse in SVGAnimatedNumberList (and SVGAnimatedNumberOptionalNumber later). (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): Use new static function.
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.cpp: Added. New animator for SVGNumberList. (WebCore::SVGAnimatedNumberListAnimator::SVGAnimatedNumberListAnimator): (WebCore::SVGAnimatedNumberListAnimator::constructFromString): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberListAnimator::calculateDistance):
  • svg/SVGAnimatedNumberList.h: (WebCore::SVGAnimatedNumberListAnimator::~SVGAnimatedNumberListAnimator):
  • svg/SVGAnimatedType.cpp: Use new Animator. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberList): (WebCore::SVGAnimatedType::numberList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

Test animation of attributes with type SVGNumberList.

  • svg/animations/script-tests/svgnumberlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberlist-animation-1-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-1.html: Added.
  • svg/animations/svgnumberlist-animation-2-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-2.html: Added.
2:36 PM Changeset in webkit [89749] by zimmermann@webkit.org
  • 16 edits
    2 adds in trunk/Source/WebCore

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336

Convert <animate attributeName="d"> parsing to the new SVGAnimatorFactory concept, removing
the last special data types from SVGAnimateElement: SVGPathByteStream m_fromPath/m_toPath/m_animatedPath.
All existing non-string primitives have been converted to the new concept.

Doesn't change any functionality.

  • CMakeLists.txt: Added SVGAnimatedPath.*.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedPath.cpp: Added. (WebCore::SVGAnimatedPathAnimator::SVGAnimatedPathAnimator): (WebCore::SVGAnimatedPathAnimator::constructFromString): (WebCore::SVGAnimatedPathAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPathAnimator::calculateDistance):
  • svg/SVGAnimatedPath.h: Added. (WebCore::SVGAnimatedPathAnimator::~SVGAnimatedPathAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPath): (WebCore::SVGAnimatedType::path): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::initializeFrom):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
2:20 PM Changeset in webkit [89748] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-25 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

SOFT_LINK_POINTER_OPTIONAL isn't optional.
https://bugs.webkit.org/show_bug.cgi?id=63378

Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.

  • platform/mac/SoftLinking.h:
12:02 PM Changeset in webkit [89747] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening.
Skip css3/flexbox tests on Qt since ENABLE(CSS3_FLEXBOX) is disabled.

  • platform/qt/Skipped:
11:53 AM Changeset in webkit [89746] by Dimitri Glazkov
  • 2 edits in trunk/Tools

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

run-bindings-tests does not work on Chromium Windows.
https://bugs.webkit.org/show_bug.cgi?id=63382

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
11:41 AM Changeset in webkit [89745] by rwlbuis@webkit.org
  • 12 edits
    6 adds in trunk

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Allow navigating to internal <view> targets. When choosing Back ensure
the <svg> current view is initialized correctly.

Tests: svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg

svg/custom/linking-uri-01-b.svg

  • page/FrameView.cpp: Delegate to setupInitialView. (WebCore::FrameView::scrollToAnchor):
  • svg/SVGAElement.cpp: Allow navigating to internal <view> targets. (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setupInitialView): Initialize current view depending on fragment identifier. (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Add a test for navigating to an inner <view> anchor. The changed test results
are improvements.

  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/custom/linking-uri-01-b-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg: Added.
  • svg/custom/linking-uri-01-b.svg: Added.
10:44 AM Changeset in webkit [89744] by robert@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Duplicate entry in context menu
https://bugs.webkit.org/show_bug.cgi?id=62139

contextMenuController()->populate() is called from
ContextMenuController::handleContextMenuEvent() so
QWebPage::updatePositionDependentActions() does not need
to call it independently.

Related changesets:

http://trac.webkit.org/changeset/73535
http://trac.webkit.org/changeset/32389

  • Api/qwebpage.cpp: (QWebPage::updatePositionDependentActions):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy): (tst_QWebPage::contextMenuPopulatedOnce):
10:21 AM Changeset in webkit [89743] by Dimitri Glazkov
  • 3 edits
    1 delete in trunk/LayoutTests

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r89732.
https://bugs.webkit.org/show_bug.cgi?id=59085

  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium/test_expectations.txt:
10:04 AM Changeset in webkit [89742] by Dimitri Glazkov
  • 7 edits in trunk

2011-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
  • fast/css/unknown-pseudo-element-matching.html: Added more tests.

2011-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement. (WebCore::CSSStyleSelector::pushParent): Ditto.
  • dom/Node.cpp: (WebCore::Node::parentOrHostElement): Added.
  • dom/Node.h:
8:15 AM Writing Layout Tests for DumpRenderTree edited by dominicc@chromium.org
Documents window.internals. (diff)
3:20 AM Changeset in webkit [89741] by pfeldman@chromium.org
  • 2 edits
    18 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: chromium rebaselines.

  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-linux/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:43 AM Changeset in webkit [89740] by zimmermann@webkit.org
  • 17 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update gtk baseline. The rebaselines should be done now.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt:
  • platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/text/text-text-04-t-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/text/text-text-06-t-expected.txt:
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
1:01 AM Changeset in webkit [89739] by zimmermann@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update win baseline.

  • platform/win-wk2/Skipped: Skip newly added svg/text test just like in mac-wk2.
  • platform/win-xp/svg/custom: Added.
  • platform/win-xp/svg/custom/svg-fonts-fallback-expected.txt: Added. XP has different metrics here.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Update result from Win7 slave.
12:44 AM Changeset in webkit [89738] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Skip svg/text/select-text-svgfont.html on mac-wk2, just like the other svg/text tests.

  • platform/mac-wk2/Skipped:
12:36 AM Changeset in webkit [89737] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

http/tests/inspector/network/network-iframe-load-and-delete.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63379

http/tests/navigation/anchor-basic.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63380

Skip last two tests that kept Leopard red, should turn green again now.

  • platform/mac-leopard/Skipped:
12:34 AM Changeset in webkit [89736] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on Leopard/SnowLeopard release
https://bugs.webkit.org/show_bug.cgi?id=63169

Skip failing test for mac, to turn bots green again.

  • platform/mac/Skipped:
12:31 AM Changeset in webkit [89735] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update a stale Leopard result.

  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
12:02 AM Changeset in webkit [89734] by mitz@apple.com
  • 3 edits in trunk/Tools

Try to fix the Qt and Chromium builds.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setEncodedAudioData):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

Jun 24, 2011:

11:49 PM Changeset in webkit [89733] by mitz@apple.com
  • 51 edits
    4 adds in trunk

Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363

Reviewed by Anders Carlsson.

Source/WebCore:

Restored most of text rounding hacks which were removed in r78846, with a global flag to control
whether rounding hacks are allowed, which defaults to false.

Test: platform/mac/fast/text/rounding-hacks.html

  • CMakeLists.txt: Added TextRun.cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.exp.in: Export new TextRun function and global and updated StringTruncator functions.
  • WebCore.gypi: Added TextRun.cpp.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Disable rounding hacks in the one place
they used to be disabled.

  • platform/graphics/Font.cpp: Re-added the rounding character table.
  • platform/graphics/Font.h:

(WebCore::Font::isRoundingHackCharacter): Re-added.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Account for final rounding width.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::adjustedSpaceWidth): Re-added.

  • platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth): Re-added disableRoundingHacks parameter.
(WebCore::truncateString): Ditto.
(WebCore::StringTruncator::centerTruncate): Added EnableRoundingHacksOrNot parameter.
(WebCore::StringTruncator::rightTruncate): Ditto.
(WebCore::StringTruncator::width): Ditto.

  • platform/graphics/StringTruncator.h:
  • platform/graphics/TextRun.cpp: Added.

(WebCore::TextRun::setAllowsRoundingHacks): Added.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added RoundingHacks parameter to the constructors, used to initialize
the m_applyRunRounding and m_applyWordRounding member variables, subject to rounding hacks being allowed.
(WebCore::TextRun::applyRunRounding): Re-added this accessor.
(WebCore::TextRun::applyWordRounding): Ditto.
(WebCore::TextRun::disableRoundingHacks): Re-added.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Re-added code to apply rounding hacks.
(WebCore::WidthIterator::advance): Ditto.

  • platform/graphics/WidthIterator.h:
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ceilCGFloat): Re-added.
(WebCore::ComplexTextController::ComplexTextController): Re-added code to apply rounding hacks.
(WebCore::ComplexTextController::advance): Ditto.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::finalRoundingWidth): Re-added this accessor.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Accound for final rounding width.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • platform/mac/DragImageMac.mm:

(WebCore::widthWithFont): Disable rounding hacks when measuring.
(WebCore::drawAtPoint): Disable rounding hacks when drawing.

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink): Enable rounding hacks in the string truncator.

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::WebCoreTextFloatWidth): Ditto.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Disable rounding hacks.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth): Ditto.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Disabled rounding hacks.

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::constructTextRun): Ditto.

Source/WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
Disabled rounding hacks.
(-[NSString _web_widthWithFont:]): Ditto.

  • WebView/WebView.mm:

(+[WebView _setAllowsRoundingHacks:]): Added this setter.

  • WebView/WebViewPrivate.h:

Source/WebKit/win:

  • WebKitGraphics.cpp:

(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.

Tools:

Added layoutTestController.allowRoundingHacks() and implemented it
on OS X.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::allowRoundingHacks):

LayoutTests:

  • platform/mac/fast/text/rounding-hacks.html: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Added.
11:28 PM Changeset in webkit [89732] by zimmermann@webkit.org
  • 141 edits
    23 adds in trunk

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.png:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.png: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png: Added.
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/svg-features-expected.png: Added.
  • platform/qt/svg/custom/svg-features-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-in-html-expected.png:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • svg/custom/resources/ABCFont.svg:
  • svg/custom/svg-fonts-fallback.xhtml: Added.
  • svg/custom/svg-fonts-segmented.xhtml: Added.
  • svg/custom/svg-fonts-word-spacing.html: Added.
  • svg/text/select-text-svgfont-expected.txt: Added.
  • svg/text/select-text-svgfont.html: Added.
  • svg/text/text-overflow-ellipsis-svgfont.html: Added.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

  • wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)

svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

This makes text selection using SVG Fonts possible again.

  • features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
  • page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
  • platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well. (WebCore::Font::drawText): (WebCore::Font::drawEmphasisMarks): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition): (WebCore::Font::codePath):
  • platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair

std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
handle font fallback glyph matching for SVG Fonts..

(WebCore::Font::fontList): Add FontFallbackList accessor.

  • platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext. (WebCore::FontFallbackList::glyphPageZero): (WebCore::FontFallbackList::glyphPages): (WebCore::FontFallbackList::setGlyphPageZero): (WebCore::FontFallbackList::setGlyphPages):
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here. (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer. (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case. (WebCore::Font::drawGlyphBuffer): Ditto.
  • platform/graphics/FontMetrics.h: (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
  • platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int. (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData. (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
  • platform/graphics/TextRun.h:
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::glyphDataForCharacter): (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)

and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).

(WebCore::WidthIterator::run):
(WebCore::WidthIterator::runWidthSoFar):
(WebCore::WidthIterator::lastGlyphName):
(WebCore::WidthIterator::setLastGlyphName):
(WebCore::WidthIterator::arabicForms):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
  • platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
  • rendering/svg/SVGTextMetrics.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont. (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects. (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun. (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength(). (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method. (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths. (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
  • rendering/svg/SVGTextRunRenderingContext.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData): Changed font size from int to float. (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width. (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code. (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font. (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation. (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage. (WebCore::SVGFontElement::ensureGlyphCache):
  • svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly. (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone. (WebCore::SVGGlyphMap::collectGlyphsForString):
  • svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
7:42 PM Changeset in webkit [89731] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Replace ";" with space in FEATURE_DEFINES macro
https://bugs.webkit.org/show_bug.cgi?id=62211

html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
as separator. So, let the html.css to use new feature macro with space separator.

  • CMakeLists.txt:
7:26 PM Changeset in webkit [89730] by Lucas Forschler
  • 1 copy in tags/Safari-534.50

New tag.

7:15 PM Changeset in webkit [89729] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
https://bugs.webkit.org/show_bug.cgi?id=63345

The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
return 9 and 10 bit quantities, therefore changed their return type from
uint8_t to uint16_t. Also casted the places where they are used as they
are currently shifted and used as 7 or 8 bit values.

These methods are currently used for literals for stack offsets,
including creating and destroying stack frames. The prior truncation of
the upper bits caused stack frames to be too small, thus allowing a
JIT'ed function to access and overwrite stack space outside of the
incorrectly sized stack frame.

  • assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::getUInt9): (JSC::ARMThumbImmediate::getUInt10): (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S):
7:14 PM Changeset in webkit [89728] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge 89714.

7:12 PM Changeset in webkit [89727] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source/WebKit2

89706.

7:05 PM Changeset in webkit [89726] by Lucas Forschler
  • 4 edits in tags/Safari-534.48.3/Source/WebKit2

Merge 89706.

7:01 PM Changeset in webkit [89725] by Lucas Forschler
  • 5 edits in tags/Safari-534.48.3/Source

Versioning.

7:00 PM Changeset in webkit [89724] by Lucas Forschler
  • 1 copy in tags/Safari-534.48.3

New tag.

6:55 PM Changeset in webkit [89723] by Lucas Forschler
  • 2 edits in tags/Safari-534.48.2/Source/WebCore

Merge r89714.

6:38 PM Changeset in webkit [89722] by Lucas Forschler
  • 5 edits in tags/Safari-534.48.2/Source

Versioning.

6:21 PM Changeset in webkit [89721] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove ewk_frame_theme_get/set.
https://bugs.webkit.org/show_bug.cgi?id=63370

Remove ewk_frame_theme_get/set to avoid confusion.
Setting theme on each frame is meaningless and ewk_view_thjeme_set can
do same thing.

  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.cpp: (ewk_view_theme_set):
5:45 PM Changeset in webkit [89720] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Drag-and-drop tab in same window makes web process falsely report unresponsiveness
https://bugs.webkit.org/show_bug.cgi?id=63369
<rdar://problem/9673120>

If the view becomes invisible, stop the responsiveness timer, because we might not get any
messages that will cause it to stop (such as painting notifications since we don't paint
when we're not visible).

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
5:39 PM Changeset in webkit [89719] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Gavin Peters <gavinp@chromium.org>

Reviewed by Darin Adler.

fix possible race in LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=63360

In chromium bug 80729
http://code.google.com/p/chromium/issues/detail?id=80729 I am
seeing some kind of double triggering of the timer; I am concerned
that it is possible that a Link element errors out or succeeds,
sets a timer, and shortly before the timer is triggered it is
editted, launches another request. After that, the first timer
triggers, zeroing out m_cachedResource. Then, the second load
finishes, and *crash*. If this is the case, this fix should stop
it.

No new tests; I haven't reproduced this. I hope chrome's crash
telemetry will give good feedback; this crash is occuring many times a
day so the difference should be obvious.

  • loader/LinkLoader.cpp: (WebCore::LinkLoader::LinkLoader): (WebCore::LinkLoader::linkLoadTimerFired): (WebCore::LinkLoader::linkLoadingErrorTimerFired): (WebCore::LinkLoader::notifyFinished):
  • loader/LinkLoader.h:
5:16 PM Changeset in webkit [89718] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-24 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332
<rdar://problem/9661650>

No new tests; Only affects machines with QTKit < 7.6.3 installed.

Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
as it is only defined in QTKit >= 7.6.3. If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys. To avoid ASSERTs when running
debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
  • platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.
5:13 PM Changeset in webkit [89717] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Windows build failure.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.

5:11 PM Changeset in webkit [89716] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
https://bugs.webkit.org/show_bug.cgi?id=63015

Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList(). These
adjustments are a bug. These need to reflect the pages that are released
in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
Made ReleaseFreeList a member of TCMalloc_PageHeap in the process. Updated
Check() and helper method CheckList() to check the number of actual free pages
with free_committed_pages_.

The symptom of the problem of the existing code is that the scavenger may
run unneccesarily without any real work to do, i.e. pages on the free lists.
The scanvenger would also end up freeing too many pages, that is going below
the current 528 target free pages.

Note that the style of the changes was kept consistent with the
existing style.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::TCMalloc_PageHeap::ReleaseFreeList):
5:09 PM Changeset in webkit [89715] by darin@apple.com
  • 9 edits in trunk/Source/WebCore

2011-06-23 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Remove some unneeded functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=63295

Removing 7 of the functions in FrameLoader.h is probably a step
in the right direction.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::handledOnloadEvents): Moved the call to stopDeferringEvents in here from FrameLoader.
  • loader/DocumentLoader.h: Ditto.
  • loader/DocumentWriter.h: Fixed a typo.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to use a non-recursive tree walk instead of recursion. (WebCore::FrameLoader::stopAllLoaders): Moved the code from stopLoadingSubframes inline, since it's only two lines of code. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved the code from markLoadComplete inline, since it's only one line. (WebCore::FrameLoader::checkLoadComplete): Changed this to use a non-recursive tree walk instead of recursion, eliminating the recursiveCheckLoadComplete function completely. (WebCore::FrameLoader::handledOnloadEvents): Moved the call to stopDeferringEvents into DocumentLoader.
  • loader/FrameLoader.h: Removed unneeded forward declarations, and now-unneeded functions setupForReplaceByMIMEType, isStopping, isLoadingFromCachedPage, stopLoadingSubframes, markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete. Also made allChildrenAreComplete private.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Call DocumentLoader::isStopping so we can remove the function from FrameLoader that just calls through. Other call sites were using DocumentLoader::isStopping directly. (WebCore::MainResourceLoader::didReceiveResponse): Call DocumentLoader::setupForReplaceByMIMEType so we can remove the function from FrameLoader that just calls through. This was the only call site.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Call the ResourceLoader::cancelledError function instead of calling directly to FrameLoader.
  • loader/ResourceLoader.h: Made response an inline function.
5:03 PM Changeset in webkit [89714] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Maciej Stachowiak.

REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix for bug 62764.
4:50 PM Changeset in webkit [89713] by Lucas Forschler
  • 1 copy in tags/Safari-534.48.2

New tag.

4:39 PM Changeset in webkit [89712] by tony@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

  • css3/flexbox/display-property-expected.txt: Added.
  • css3/flexbox/display-property.html: Added.
  • css3/flexbox/script-tests/display-property.js: Added. (testFlex):

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

Test: css3/flexbox/display-property.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSValueKeywords.in:
4:06 PM Changeset in webkit [89711] by hclam@chromium.org
  • 19 edits
    5 deletes in trunk/Source/WebCore

2011-06-24 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Carlson.

Loading out-of-band text track files from <track>.
https://bugs.webkit.org/show_bug.cgi?id=62881

Uses the src attribute of <track> urls to load out-of-band text track
files using ThreadableLoader. Also removes TextTrackPrivateInterface
(as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.

No new tests because feature is hidden behind VIDEO_TRACK feature
define, which is turned off.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:
  • html/LoadableTextTrack.h:
  • html/LoadableTextTrackImpl.cpp: Removed.
  • html/LoadableTextTrackImpl.h: Removed.
  • html/MutableTextTrack.cpp:
  • html/MutableTextTrack.h:
  • html/MutableTextTrackImpl.cpp: Removed.
  • html/MutableTextTrackImpl.h: Removed.
  • html/TextTrack.cpp:
  • html/TextTrack.h:
  • html/TextTrackPrivate.h: Removed.
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
3:32 PM Changeset in webkit [89710] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Rob Buis <rbuis@rim.com>

Rubber-stamped by Nikolas Zimmermann.

All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Do not use writing mode aware code for SVG Text.

No new tests needed.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
3:15 PM Changeset in webkit [89709] by enne@google.com
  • 13 edits in trunk/LayoutTests

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63343

These tests were failing since they were introduced in r89687. The
layerTreeAsText dump on the iframe document was causing the outer
layerTreeAsText dump to be affected by font metrics. Fixed in this
case by not putting layerTreeAsText output in an element when inside
an iframe.

  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative.html:
3:07 PM Changeset in webkit [89708] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Darin Adler.

Change NDEBUG to !LOG_DISABLED macro in databases for logging.
https://bugs.webkit.org/show_bug.cgi?id=63346

Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
This change resolves also build break in Release build when logging enabled.

No new tests because there is no new behavior or feature exposed.

  • loader/icon/IconDatabase.cpp: Macro fixes. (WebCore::IconDatabase::iconDatabaseSyncThread): (WebCore::IconDatabase::syncThreadMainLoop): (WebCore::IconDatabase::readFromDatabase): (WebCore::IconDatabase::writeToDatabase): (WebCore::IconDatabase::cleanupSyncThread):
  • storage/AbstractDatabase.h: Macro fixes.
  • storage/DatabaseTask.cpp: Macro fixes.
  • storage/DatabaseTask.h: Macro fixes.
  • storage/SQLTransaction.cpp: Macro fixes.
  • storage/SQLTransaction.h: Macro fixes.
3:05 PM Changeset in webkit [89707] by tony@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Pass Strings by const reference to functions
https://bugs.webkit.org/show_bug.cgi?id=63341

Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not

change the value of the passed in String.

  • loader/FrameLoader.h:
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::setFileDescriptorData):
  • platform/win/ClipboardUtilitiesWin.h:
  • storage/DatabaseTracker.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
  • storage/IDBSQLiteBackingStore.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::getOpenDatabases):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
  • svg/SVGPaint.h:
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
3:03 PM Changeset in webkit [89706] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Not possible for plug-ins to override the internal PDF viewer
https://bugs.webkit.org/show_bug.cgi?id=63356
<rdar://problem/9673382>

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Pass the entire resource response to shouldUseCustomRepresentationForResponse.
  • WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ask for the plug-in path for a plug-in that can handle the given resource response. If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in that can handle it.

(WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
a plug-in that can handle the given response. If that is the case, it should have precedence over
the custom representation.

  • WebProcess/WebProcess.h: Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.
2:45 PM Changeset in webkit [89705] by inferno@chromium.org
  • 10 edits
    2 adds in trunk

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Match other clampTo* functions in style with clampToInteger(float)
function.
https://bugs.webkit.org/show_bug.cgi?id=53449

  • wtf/MathExtras.h: (clampToInteger): (clampToFloat): (clampToPositiveInteger):

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Add clamping for CSSPrimitiveValues and SVGInlineText font size.
https://bugs.webkit.org/show_bug.cgi?id=53449

Test: svg/text/svg-zoom-large-value.xhtml

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the number created is valid.
  • css/CSSPrimitiveValue.h: add clamping checks to prevent overflows. (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two static functions, one specific to CSSStyleSelector and other generic to help in clamping font size for other callers like svg text, etc.
  • css/CSSStyleSelector.h:
  • platform/graphics/FontDescription.h: add asserts to detect if the new font size is valid. (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize):
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper from CSSStyleSelector to help in clamping new scaled font size. do not use "smart minimum" since svg allows really small unreadable fonts (tested by existing layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon check in CSSStyleSelector function should still hold for svg.

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that font size for svg text zoom is clamped and we do not
crash on ASSERT(isfinite(s)) in FontDescription.h
https://bugs.webkit.org/show_bug.cgi?id=53449

  • svg/text/svg-zoom-large-value-expected.txt: Added.
  • svg/text/svg-zoom-large-value.xhtml: Added.
2:22 PM Changeset in webkit [89704] by jchaffraix@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Remove unsafe static_cast inside the InlineBox hierarchy
https://bugs.webkit.org/show_bug.cgi?id=63077

Refactoring only, no new test.

  • rendering/InlineFlowBox.h: (WebCore::toInlineFlowBox):
  • rendering/InlineTextBox.h: (WebCore::toInlineTextBox): Added the proper cast methods to those 2 classes from an InlineBox.
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): (WebCore::InlineFlowBox::addToLine): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::placeBoxesInInlineDirection): (WebCore::InlineFlowBox::requiresIdeographicBaseline): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild): (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): (WebCore::RenderText::positionLineBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ascentAndDescentForBox): (WebCore::RootInlineBox::includeFontForBox): (WebCore::RootInlineBox::includeGlyphsForBox): Replaced the static_cast in those previous call sites with the new cast methods.
1:54 PM Changeset in webkit [89703] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix.

Build fix on Linux when using the GStreamer backend.

No new tests, just a build fix.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::keyPressEvent):
1:54 PM Changeset in webkit [89702] by Adam Roben
  • 3 edits in trunk/Tools

Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.

1:53 PM Changeset in webkit [89701] by Adam Roben
  • 3 edits in trunk/Tools

Include links to Trac in bugs filed from TestFailures

Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.

1:46 PM Changeset in webkit [89700] by nduca@chromium.org
  • 19 edits
    9 deletes in trunk

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebKit.gypi:
  • public/WebWidget.h: (WebKit::WebWidget::animate): (WebKit::WebWidget::composite):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererViewport): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Removed.
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
1:33 PM Changeset in webkit [89699] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Fix Chromium Linux Build
https://bugs.webkit.org/show_bug.cgi?id=63349

  • WebCore.gyp/WebCore.gyp:
12:56 PM Changeset in webkit [89698] by Adam Roben
  • 2 edits in trunk/Tools

Fix typos introduced in r89696

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.

12:49 PM Changeset in webkit [89697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Henry Song <hsong@sisa.samsung.com>

Reviewed by Martin Robinson.

Correct _sharedTimer value in SharedTimerEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=62380

SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
timerEvent(), we have observed addNewTimer() can be triggered
by either inside timerFunction() or others that are not within
timerFunction(). We have observed the following case:

  1. add a new Timer within timerFunction()
  2. timerFunction returns, set _sharedTimer = 0
  3. addNewTimer() is triggered again within webkit, don't know it triggers this.
  4. because at this moment, _sharedTimer == 0, the previous registered timer (in step 1) did not get removed.
  5. Now in ecore_timer, there are two timers with same callbacks
  6. From now on, timerFunction() will be called twice back-to-back in each ecore_timer loop. To correct this, we should set _sharedTimer = 0 before timerFunction() so that when addNewTimer() triggered within, we have a valid timer object.
  • platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent):
12:37 PM Changeset in webkit [89696] by Adam Roben
  • 2 edits in trunk/Tools

Make TestFailures correctly remember whether old-run-webkit-tests exited early

Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.

12:36 PM Changeset in webkit [89695] by Adam Roben
  • 3 edits
    1 add in trunk/Tools

Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.

(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

12:29 PM Changeset in webkit [89694] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
12:20 PM Changeset in webkit [89693] by crogers@google.com
  • 3 edits in trunk/Source

2011-06-24 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Enable Web Audio for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=63338

  • features.gypi:
12:16 PM Changeset in webkit [89692] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Adrienne Walker <enne@google.com>

Unreviewed, remove assertion about root layers in RenderLayerBacking.
https://bugs.webkit.org/show_bug.cgi?id=60741

This was added in r89687, but somehow is not true on Safari Leopard.
However, as the tests that were added with that revision are passing
correctly, the assertion is most likely not correct.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
12:11 PM Changeset in webkit [89691] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Unreviewed: Skipping failing progress-clone.html on win.

r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
on win, but it should stay skipped because there is no progress
element on win (bug 49769)

  • platform/win/Skipped:
11:48 AM Changeset in webkit [89690] by zimmermann@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/Source/WebCore

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor text iterator code respecting surrogate pairs from WidthIterator
https://bugs.webkit.org/show_bug.cgi?id=63319

WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:

UChar32 character = 0;
unsigned clusterLength = 0;

SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
while (textIterator.consume(character, clusterLength)) {

Either clusterLength is 1 and UChar32 fits into a single UChar.
Or clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
...


textIterator.advance(clusterLength);

}

SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
Doesn't affect any tests, just refactoring.

  • CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
  • platform/graphics/SurrogatePairAwareTextIterator.h: Added. (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h:
11:47 AM Changeset in webkit [89689] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix after r89685

  • WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.
11:43 AM Changeset in webkit [89688] by jberlin@webkit.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.

  • fast/css/font-face-in-shadow-DOM.html: Removed.
  • fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
  • platform/win-xp/fast/css: Removed.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.
11:35 AM Changeset in webkit [89687] by enne@google.com
  • 5 edits
    42 adds in trunk

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.

The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.

  • compositing/rtl/rtl-absolute-expected.png: Added.
  • compositing/rtl/rtl-absolute-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-absolute-overflow.html: Added.
  • compositing/rtl/rtl-absolute.html: Added.
  • compositing/rtl/rtl-fixed-expected.png: Added.
  • compositing/rtl/rtl-fixed-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-fixed-overflow.html: Added.
  • compositing/rtl/rtl-fixed.html: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
  • compositing/rtl/rtl-iframe-absolute.html: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
  • compositing/rtl/rtl-iframe-fixed.html: Added.
  • compositing/rtl/rtl-iframe-relative-expected.png: Added.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • compositing/rtl/rtl-iframe-relative.html: Added.
  • compositing/rtl/rtl-relative-expected.png: Added.
  • compositing/rtl/rtl-relative-expected.txt: Added.
  • compositing/rtl/rtl-relative.html: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.

Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html

compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
11:24 AM Changeset in webkit [89686] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Add expected (failing?) results for win-xp to get the bots green.

  • platform/win-xp/fast/css: Added.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
11:09 AM Changeset in webkit [89685] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make the web process pause dialog look better on Vista/7 and robust against executable renames

Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7

Reviewed by Brian Weinstein.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.

10:52 AM Changeset in webkit [89684] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
Adding new platform specific results since the new layout in the tests changes the render tree spew.
Pixel tests are still good.

  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
10:45 AM Changeset in webkit [89683] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Add BeforeChildren and AfterChildren to the Position's anchor types
https://bugs.webkit.org/show_bug.cgi?id=63100

Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
firstPositionInNode and lastPositionInNode.

These new types of positions will let us express the first and the last positions in a non-text node in O(1).

No new tests because there is no new behavior or feature exposed.

  • dom/Position.cpp: (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes. (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node. (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and the offset in the anchor node for AfterChildren. (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren. (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick for table and ignored contents like before or after anchor. (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of the anchor node for AfterChildren. (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children. (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type is AfterChildren. (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
  • dom/Position.h: (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren. (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren. (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node, the anchor type shouldn't be BeforeChildren or AfterChildren.
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset on BeforeChildren or AfterChildren position.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder after paragraphs below the block is moved into, it needs to be the position after the current last child in the block instead of after children in the block; otherwise the position will move to the end of block.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after children or before/after anchor, just return null for these anchor types.
10:37 AM Changeset in webkit [89682] by dominicc@chromium.org
  • 68 edits in trunk

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • Source/autotools/symbols.filter: Export symbols for GTK.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Update tests to use internals.{ensureShadowRoot, shadowRoot,
shadowPseudoId, removeShadowRoot} instead of layoutTestController.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLProgressElement/progress-clone-expected.txt:
  • fast/dom/HTMLProgressElement/progress-clone.html:
  • fast/dom/shadow/activeelement-should-be-shadowhost.html:
  • fast/dom/shadow/create-content-element.html:
  • fast/dom/shadow/gc-shadow-expected.txt:
  • fast/dom/shadow/gc-shadow.html:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/nodetype.html:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:
  • fast/events/shadow-boundary-crossing.html:
  • fast/forms/resources/common.js: (getValidationMessageBubbleNode):
  • fast/html/clone-keygen-expected.txt:
  • fast/html/clone-keygen.html:
  • fast/html/clone-range-expected.txt:
  • fast/html/clone-range.html:
  • fast/html/details-clone.html:
  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-override.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/media-controls.js: (mediaControlsButtonCoordinates):
  • media/video-controls-in-media-document.html:
  • platform/win/Skipped: shadowRoot and friends now available on win.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
  • testing/Internals.cpp: The new home of shadowRoot and friends. (WebCore::Internals::ensureShadowRoot): (WebCore::Internals::shadowRoot): (WebCore::Internals::removeShadowRoot): (WebCore::Internals::shadowPseudoId):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Chromium API. These are not
required any more.

  • public/WebElement.h:
  • src/WebElement.cpp:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from GTK DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Mac API. These are not
required any more.

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow-DOM related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from Qt DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from WebKit2 API. These are not
required any more.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
  • win/WebKit2CFLite.def: Same for Cairo.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
removeShadowRoot from layoutTestController; these have been
replaced by equivalents in window.internals instead.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
9:57 AM Changeset in webkit [89681] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
https://bugs.webkit.org/show_bug.cgi?id=63327

  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
  • transforms/3d/point-mapping/3d-point-mapping.html:
9:35 AM Changeset in webkit [89680] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Refactor creation of primitive values in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=63270

Covered by existing tests.

  • css/CSSParser.cpp: (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values

to keep the cast in one place.

(WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.h: (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference
9:28 AM Changeset in webkit [89679] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.

  • platform/win-wk2/fast/forms: Added.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
9:26 AM Changeset in webkit [89678] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[X11] Do not call NPP_SetWindow with a null window handle on destroy
https://bugs.webkit.org/show_bug.cgi?id=62981

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::destroy):
9:09 AM Changeset in webkit [89677] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add (failing?) expected results for mac-wk2 to get the bots green.

  • platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.
8:59 AM Changeset in webkit [89676] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-06-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.


Exit immediately if the last condition tested fails.

Make <video> app cache test exit immediately on failure
https://bugs.webkit.org/show_bug.cgi?id=63323

8:54 AM Changeset in webkit [89675] by Carlos Garcia Campos
  • 2 edits in trunk

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add more debug options to compilation
https://bugs.webkit.org/show_bug.cgi?id=63318

Add --enable-debug-symbols to enable/disable compilation with
debug symbols and --enable-debug-features to enable/disable debug
features. Both options are unconditionally enabled for debug
builds.

  • configure.ac:
8:43 AM Changeset in webkit [89674] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325

Skip those tests to get the bots green.

  • platform/mac-wk2/Skipped:
8:42 AM Changeset in webkit [89673] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix runtime critical warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63256

Check whether there's a view widget before trying to use it in
PlatformScreenGtk. If there isn't a view widget, which is the case
in WebKit2, try to use the default GdkScreen and monitor.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getToplevel): Helper function to get the toplevel widget. (WebCore::getVisual): Use getToplevel(). (WebCore::getScreen): Helper funtion to get the screen of a widget. (WebCore::screenRect): Use getToplevel() and getScreen().
7:14 AM Changeset in webkit [89672] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

  • platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.
6:10 AM Changeset in webkit [89671] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed.
Remove non-existent items from the qt-wk2 skipped list.

  • platform/qt-wk2/Skipped:
5:37 AM Changeset in webkit [89670] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320

Reviewed by Dirk Schulze.

  • Scripts/run-bindings-tests:
5:18 AM Changeset in webkit [89669] by yutak@chromium.org
  • 14 edits in trunk/Source

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Add a flag in Setting so that WebSocket protocols can be switched
dynamically. The protocol we have implemented so far is based on
older Hixie-76 specification. A new protocol is being discussed in
IETF HyBi working group, and I'm planning to implement the new protocol
behind this Settings flag.

I will add a method to LayoutTestController which flips this flag in
a later patch. In this way, we can put tests for both protocols in
the same place and test implementation for both protocols at the same time.

This patch only adds a flag. The flag is not used yet, thus there is
no change in functionality. Therefore, no tests were added.

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseHixie76WebSocketProtocol): (WebCore::Settings::useHixie76WebSocketProtocol):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setHixie76WebSocketProtocolEnabled): (WebPreferences::hixie76WebSocketProtocolEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
5:02 AM Changeset in webkit [89668] by tkent@chromium.org
  • 7 edits
    2 adds
    17 deletes in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Clean up some tests for search cancel buttons.
https://bugs.webkit.org/show_bug.cgi?id=63121

  • Introduce a function to retrieve a reliable position of a search cancel button.
  • Convert two tests to dumpAsText().
  • fast/forms/resources/common.js: (searchCancelButtonPosition): Added.
  • fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
  • fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
  • fast/forms/search-transformed-expected.txt: Added.
  • fast/forms/search-transformed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • fast/forms/search-zoomed-expected.txt: Added.
  • fast/forms/search-zoomed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • platform/chromium/test_expectation.txt: search-transformed.html should pass.
  • platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.png: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.txt: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/qt/fast/forms/search-transformed-expected.txt: Removed.
  • platform/qt/fast/forms/search-zoomed-expected.txt: Removed.
4:52 AM Changeset in webkit [89667] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Remove an JavaScript error in media-controls-clone.html.
https://bugs.webkit.org/show_bug.cgi?id=63195

  • media/media-controls-clone.html: Remove run() call.
  • platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
  • platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
  • platform/mac/media/media-controls-clone-expected.txt: ditto.
  • platform/win/media/media-controls-clone-expected.txt: ditto.
4:47 AM Changeset in webkit [89666] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/utilities.js: ():
4:18 AM Changeset in webkit [89665] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: uncommenting chromium devtools tests.

  • platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:17 AM Changeset in webkit [89664] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add ewk_auth.h to EWebKit.h
https://bugs.webkit.org/show_bug.cgi?id=63311

  • ewk/EWebKit.h: Add ewk_auth.h
3:42 AM Changeset in webkit [89663] by morrita@google.com
  • 3 edits in trunk/Tools

2011-06-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=63216

Deleted m_webViewHost which looks leaked.

  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell):
3:39 AM Changeset in webkit [89662] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: HTML preview should delete old iframe on show().
https://bugs.webkit.org/show_bug.cgi?id=63170

  • inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype._createIFrame):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
3:21 AM Changeset in webkit [89661] by krit@webkit.org
  • 13 edits
    1 add in trunk/Source/WebCore

2011-06-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Convert AnimatedString to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63296

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.

No new tests added. No change of functionality.

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedString.cpp: Added. Animator for SVGString. (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator): (WebCore::SVGAnimatedStringAnimator::constructFromString): (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedStringAnimator::calculateDistance):
  • svg/SVGAnimatedString.h: (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createString): (WebCore::SVGAnimatedType::string): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
2:06 AM Changeset in webkit [89660] by mario@webkit.org
  • 5 edits in trunk

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Unskip accessibility test that will be passing from now on.

  • platform/gtk/Skipped: Unskipped passing test.

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Hide row objects in tables in GTK's accessibility wrapper.

This is a different approach in the way WebCore's accessible
rows are exposed to assistive technologies in the GTK port,
since from now on those objects are kept in WebCore (they do not
declare to ignore accessibility) and just bypassed in the mapping
to ATK, allowing to hide them in the ATK hierarchy while, at the
same time, keeping them internally to be able to provide enough
information to determine tables related information, such as rows
counting or finding an cell for specific coordinates.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Do not ignore accessibility for table rows here.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Bypass rows when needed. (getNChildrenForTable): New, find the number of children for a table, which will be the addition of all cells for its rows. (webkit_accessible_get_n_children): Call to getNChildrenForTable for accessibility tables if needed. (getChildForTable): New, bypass rows when needed, retrieving cells as if they were direct children for tables. (webkit_accessible_ref_child): Call to refChildForTable if needed. (getIndexInParentForCellInRow): New, get the index for a given cell in its parent table, considering other rows' cells. (webkit_accessible_get_index_in_parent): Call to getIndexInParentForCellInRow if needed.
1:43 AM Changeset in webkit [89659] by caseq@chromium.org
  • 12 edits in trunk

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype.createClientIframe):
  • inspector/front-end/inspector.css: (iframe.extension): (iframe.panel.extension):

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel): ():
  • http/tests/inspector/inspector-test.js: ():
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (dumpObject): (dumpArray): (evaluateOnFrontend.callbackWrapper): (evaluateOnFrontend): ():
  • http/tests/inspector/resources/extension-panel.html:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
1:25 AM Changeset in webkit [89658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Darin Fisher.

Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
https://bugs.webkit.org/show_bug.cgi?id=62396

  • public/WebURLError.h: (WebKit::WebURLError::WebURLError):
  • src/WebURLError.cpp: (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
1:24 AM Changeset in webkit [89657] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 David Grogan <dgrogan@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
https://bugs.webkit.org/show_bug.cgi?id=61653

roll out r86838

No new tests - refactoring.

  • dom/Document.h:
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::create): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::~EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
  • dom/EventQueue.h:
1:02 AM Changeset in webkit [89656] by caseq@chromium.org
  • 7 edits in trunk/LayoutTests

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
https://bugs.webkit.org/show_bug.cgi?id=63160

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest._replyToExtension): (initialize_ExtensionsTest):
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (onError): (onTestsDone):
  • inspector/extensions/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions.html:
12:43 AM Changeset in webkit [89655] by commit-queue@webkit.org
  • 14 edits
    3 deletes in trunk/Source

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Removed.
  • wtf/unicode/ScriptCodesFromICU.h: Removed.
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • icu/unicode/uscript.h: Removed.

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • WebCore.exp.in:
  • icu/unicode/uscript.h:
  • page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
12:09 AM Changeset in webkit [89654] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build.

  • WebKitTestRunner/GNUmakefile.am:

Jun 23, 2011:

11:43 PM Changeset in webkit [89653] by tony@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-06-23 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

Pass Strings by const reference in bindings code
https://bugs.webkit.org/show_bug.cgi?id=63302

Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.

  • bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): (WebCore::::allowSettingSrcToJavascriptURL):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): (WebCore::SerializedScriptValue::create):
  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::setString):
10:42 PM Changeset in webkit [89652] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-06-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide context menu item for enabling native worker inspection
https://bugs.webkit.org/show_bug.cgi?id=63258

Added context menu checkbox item that allows to enable inspection of
native workers. The value will be persisted as other inspector settings
and will be restored after frontend/breowser reopening.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::restore): (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles): (WebInspector.ScriptsPanel.prototype._contextMenu.enableWorkerInspection): (WebInspector.ScriptsPanel.prototype._contextMenu):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.didCreateWorker): (WebInspector.didDestroyWorker):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):

2011-06-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide context menu item for enabling native worker inspection
https://bugs.webkit.org/show_bug.cgi?id=63258

  • src/js/DevTools.js: ():
10:30 PM Changeset in webkit [89651] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

2011-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Need to turn off default animations for anchorPointZ in PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=63159

When the z-component of transform-origin changed, we ran an implicit
animation of anchorPointZ on the CALayer. Turn this off.

Test: transforms/3d/general/transform-origin-z-change.html

  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (nullActionsDictionary):
6:53 PM Changeset in webkit [89650] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Limit WebGL internal drawingBuffer size to 4k x 4k
https://bugs.webkit.org/show_bug.cgi?id=63304

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.
6:35 PM Changeset in webkit [89649] by morrita@google.com
  • 43 edits
    2 adds
    1 delete in trunk

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[ShadowContentElement] should layout child whitespace between span.
https://bugs.webkit.org/show_bug.cgi?id=62202

  • Added a new test case.
  • Updated expectations, which missed necessary RnederText objects.
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/details-add-child-2-expected.txt:
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-remove-child-2-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-add-details-child-2-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/html/details-remove-child-2-expected.txt:
  • platform/qt/fast/html/details-replace-text-expected.txt:
  • fast/dom/shadow/create-content-element-expected.txt: Added.
  • fast/dom/shadow/create-content-element.html: Added.

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[ShadowContentElement] should layout child whitespace between span.
https://bugs.webkit.org/show_bug.cgi?id=62202

NodeRenderingContext::nextRenderer() and previousRenderer()
ignored forwarded content tree hierarchies and used render-object
hierarchies instead, that caused some wrong Text node rendering.

This change uses ShadowContentElement::m_inclusions for the lookup.
In this way, these methods can reflect hierarchies of forward light tree.

  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::nextRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::previousRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
  • dom/NodeRenderingContext.h:
  • dom/ShadowContentElement.h: (ShadowContentElement::inclusionIndexOf): Added.
  • dom/ShadowContentSelector.cpp: (WebCore::ShadowContentSelector::activeElement):
  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::activeContentElement):
  • dom/ShadowRoot.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Fixed an apparent bug introduced at r89230.
6:28 PM WebKit Team edited by ryuan.choi@samsung.com
(diff)
6:22 PM Changeset in webkit [89648] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
6:17 PM Changeset in webkit [89647] by jamesr@google.com
  • 12 edits in trunk/Source/WebCore

2011-05-25 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fix ownership of PlatformImage for ImageLayerChromiums
https://bugs.webkit.org/show_bug.cgi?id=61099

For a composited image, both the ImageLayerChromium and its associated LayerTilerChromium need access to a
PlatformImage - the ImageLayerChromium has to update the PlatformImage's contents and the LayerTilerChromium has
to upload pixels from it. This patch makes the ImageLayerTextureUpdater have exclusive ownership of the
PlatformImage and moves ownership of the LayerTextureUpdater from the LayerTilerChromium to the owner of the
tiler. The updater is passed in as a parameter to the relevant tiler calls.

Patch also fixes a number of minor style issues (missing explicit keyword on constructor, etc).

Refactor only, no new tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::create): (WebCore::ContentLayerPainter::ContentLayerPainter): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::create): (WebCore::ImageLayerTextureUpdater::updateFromImage): (WebCore::ImageLayerTextureUpdater::imageSize): (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerChromium::~ImageLayerChromium): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::setLayerRenderer): (WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ImageLayerChromium::layerBounds):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h: (WebCore::LayerTextureUpdater::LayerTextureUpdater):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::create): (WebCore::LayerTextureUpdaterSkPicture::create):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h:
6:11 PM Changeset in webkit [89646] by nduca@chromium.org
  • 2 edits in trunk/Tools

2011-06-23 Nat Duca <nduca@chromium.org>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
5:59 PM Changeset in webkit [89645] by enne@google.com
  • 5 edits
    42 deletes in trunk

2011-06-23 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r89632 and r89640.
http://trac.webkit.org/changeset/89632
http://trac.webkit.org/changeset/89640
https://bugs.webkit.org/show_bug.cgi?id=60741

Breaks ancestor-overflow-change unexpectedly

  • compositing/rtl/rtl-absolute-expected.png: Removed.
  • compositing/rtl/rtl-absolute-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Removed.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-absolute-overflow.html: Removed.
  • compositing/rtl/rtl-absolute.html: Removed.
  • compositing/rtl/rtl-fixed-expected.png: Removed.
  • compositing/rtl/rtl-fixed-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Removed.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-fixed-overflow.html: Removed.
  • compositing/rtl/rtl-fixed.html: Removed.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Removed.
  • compositing/rtl/rtl-iframe-absolute.html: Removed.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Removed.
  • compositing/rtl/rtl-iframe-fixed.html: Removed.
  • compositing/rtl/rtl-iframe-relative-expected.png: Removed.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-relative.html: Removed.
  • compositing/rtl/rtl-relative-expected.png: Removed.
  • compositing/rtl/rtl-relative-expected.txt: Removed.
  • compositing/rtl/rtl-relative.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-23 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r89632 and r89640.
http://trac.webkit.org/changeset/89632
http://trac.webkit.org/changeset/89640
https://bugs.webkit.org/show_bug.cgi?id=60741

Breaks ancestor-overflow-change unexpectedly

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
5:51 PM Changeset in webkit [89644] by commit-queue@webkit.org
  • 1 edit
    4 moves
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5026848-1.html to dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=63289

Renamed editing/deleting/5026848* to editing/deleting/delete-across-editable-content-boundaries*,
and converted editing/deleting/delete-across-editable-content-boundaries-1 to a dump-as-markup test.
Removed old png/txt test results, and added new result. Also included radr number.

  • editing/deleting/delete-across-editable-content-boundaries-1.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-1-expected.txt: Added.
  • editing/deleting/delete-across-editable-content-boundaries-2.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-2-expected.txt: Added.
  • editing/deleting/delete-across-editable-content-boundaries-3.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-3-expected.txt: Added.
  • editing/deleting/5026848-1.html: Removed.
  • editing/deleting/5026848-2.html: Removed.
  • editing/deleting/5026848-2-expected.txt: Removed.
  • editing/deleting/5026848-3.html: Removed.
  • editing/deleting/5026848-3-expected.txt: Removed.
  • platform/chromium-linux/editing/deleting/5026848-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5026848-1-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-1-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-1-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-1-expected.txt: Removed.
5:40 PM Changeset in webkit [89643] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-23 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal
https://bugs.webkit.org/show_bug.cgi?id=63173

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
5:33 PM Changeset in webkit [89642] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: move http locking code into manager
https://bugs.webkit.org/show_bug.cgi?id=63103

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
5:28 PM Changeset in webkit [89641] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Qt again.

5:22 PM Changeset in webkit [89640] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-06-23 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, mark a few tests failing on OSX after r89632.
https://bugs.webkit.org/show_bug.cgi?id=60741

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [89639] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

GTK Rebaseline after r89627.

  • platform/gtk/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
5:18 PM Changeset in webkit [89638] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Qt Build

5:16 PM Changeset in webkit [89637] by slewis@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.

Reviewed by Darin Adler.

  • wtf/BlockStack.h:

(WTF::::~BlockStack):
(WTF::::grow):
(WTF::::shrink):

5:15 PM Changeset in webkit [89636] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WKTR: eventSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 skipped list.

  • platform/mac-wk2/Skipped:
5:11 PM Changeset in webkit [89635] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost.
https://bugs.webkit.org/show_bug.cgi?id=63189
The main bug fix is to only set/wait latches if the child context has no errors.
Additionally, the LayerChromium classes needed to be modified to not continue drawing when
their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::isCompositorContextLost):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::updateCompositorResources): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost
https://bugs.webkit.org/show_bug.cgi?id=63189

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
4:47 PM Changeset in webkit [89634] by alokp@chromium.org
  • 16 edits
    1 add in trunk/Source/WebCore

2011-06-23 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Red and Blue channels are swapped in images with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=61442

We were uploading BGRA pixels into RGBA textures and swapping the components in the pixel shader.
This strategy does not work with accelerated drawing because we are directly rendering to the texture, not uploading pixels.
This patch uses BGRA textures if available. If not it falls back to the original scheme of swapping the components in the pixel shader.

Tests: compositing/color-matching/image-color-matching.html (existing)

  • WebCore.gypi:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::sampledTexelFormat): (WebCore::ImageLayerTextureUpdater::updateTextureRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::skiaContext): (WebCore::LayerRendererChromium::tilerProgram): (WebCore::LayerRendererChromium::tilerProgramSwizzle): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTexture.h: (WebCore::LayerTexture::format):
  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTiles): (WebCore::LayerTilerChromium::drawTexturedQuad):
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/PlatformColor.h: Added. (WebCore::PlatformColor::format): (WebCore::PlatformColor::bestTextureFormat): (WebCore::PlatformColor::sameComponentOrder):
  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderRGBATexSwizzleAlpha::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
4:19 PM Changeset in webkit [89633] by oliver@apple.com
  • 2 edits in trunk

Qt build-fix: remove warning that no other platform appears to use.
Someone can add it back if they really feel it's needed.

4:13 PM Changeset in webkit [89632] by enne@google.com
  • 5 edits
    43 adds in trunk

2011-06-23 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.

The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.

  • compositing/rtl/rtl-absolute-expected.png: Added.
  • compositing/rtl/rtl-absolute-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-absolute-overflow.html: Added.
  • compositing/rtl/rtl-absolute.html: Added.
  • compositing/rtl/rtl-fixed-expected.png: Added.
  • compositing/rtl/rtl-fixed-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-fixed-overflow.html: Added.
  • compositing/rtl/rtl-fixed.html: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
  • compositing/rtl/rtl-iframe-absolute.html: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
  • compositing/rtl/rtl-iframe-fixed.html: Added.
  • compositing/rtl/rtl-iframe-relative-expected.png: Added.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • compositing/rtl/rtl-iframe-relative.html: Added.
  • compositing/rtl/rtl-relative-expected.png: Added.
  • compositing/rtl/rtl-relative-expected.txt: Added.
  • compositing/rtl/rtl-relative.html: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-23 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.

Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html

compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4:00 PM Changeset in webkit [89631] by jberlin@webkit.org
  • 1 edit
    6 moves in trunk/LayoutTests

compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests have been flaking on multiple platforms, so disable the tests in order to get
the bots green.

  • compositing/tiling/huge-layer-add-remove-child.html: Removed.
  • compositing/tiling/huge-layer-add-remove-child.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child.html.
  • compositing/tiling/huge-layer-img.html: Removed.
  • compositing/tiling/huge-layer-img.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-img.html.
  • compositing/tiling/huge-layer-resize.html: Removed.
  • compositing/tiling/huge-layer-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-resize.html.
  • compositing/tiling/huge-layer-with-layer-children-resize.html: Removed.
  • compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize.html.
  • compositing/tiling/huge-layer-with-layer-children.html: Removed.
  • compositing/tiling/huge-layer-with-layer-children.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html.
  • compositing/tiling/huge-layer.html: Removed.
  • compositing/tiling/huge-layer.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer.html.
3:47 PM Changeset in webkit [89630] by oliver@apple.com
  • 15 edits
    1 add in trunk/Source/JavaScriptCore

2011-06-23 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add the ability to dynamically modify linked call sites
https://bugs.webkit.org/show_bug.cgi?id=63291

Add JITWriteBarrier as a writebarrier class that allows
reading and writing directly into the code stream.

This required adding logic to all the assemblers to allow
us to read values back out of the instruction stream.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMAssembler.h: (JSC::ARMAssembler::readPointer):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::readPointer): (JSC::ARMv7Assembler::readInt32): (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmFirst): (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmSecond):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::readPointer):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::readInt32): (JSC::MIPSAssembler::readPointer):
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::readPCrelativeAddress): (JSC::SH4Assembler::readPointer): (JSC::SH4Assembler::readInt32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::readPointer):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
  • heap/MarkStack.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITWriteBarrier.h: Added. (JSC::JITWriteBarrierBase::operator UnspecifiedBoolType*): (JSC::JITWriteBarrierBase::operator!): (JSC::JITWriteBarrierBase::setFlagOnBarrier): (JSC::JITWriteBarrierBase::isFlagged): (JSC::JITWriteBarrierBase::setLocation): (JSC::JITWriteBarrierBase::location): (JSC::JITWriteBarrierBase::JITWriteBarrierBase): (JSC::JITWriteBarrierBase::set): (JSC::JITWriteBarrierBase::get): (JSC::JITWriteBarrier::JITWriteBarrier): (JSC::JITWriteBarrier::set): (JSC::JITWriteBarrier::get): (JSC::MarkStack::append):
3:35 PM Changeset in webkit [89629] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

compositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel Release
(WebKit2 Tests) since introduction.
https://bugs.webkit.org/show_bug.cgi?id=59864

Update the mac-wk2 results to contain the transform line and get the bots green.

  • platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
3:30 PM Changeset in webkit [89628] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
3:20 PM Changeset in webkit [89627] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

Add a test for vertical caret movements inside transform
https://bugs.webkit.org/show_bug.cgi?id=62834

Add regression tests for vertical caret movements inside rotated contents.

  • editing/selection/extend-inside-transforms-backward.html: Added.
  • editing/selection/extend-inside-transforms-forward.html: Added.
  • platform/chromium/test_expectations.txt: Added test expectations to keep bots green until we rebaseline these tests on Chromium.
  • platform/mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/mac/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/mac/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
3:19 PM Changeset in webkit [89626] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Gregg Tavares <gman@google.com>

Reviewed by Kenneth Russell.

add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
https://bugs.webkit.org/show_bug.cgi?id=63278

  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [89625] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

FloatRect should implement the same methods as IntRect
https://bugs.webkit.org/show_bug.cgi?id=63273

Add missing methods from IntRect to FloatRect in preparation for moving
the rendering tree over to floats.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::expandedTo): (WebCore::FloatPoint::transposedPoint):
  • platform/graphics/FloatRect.h: (WebCore::FloatRect::move): (WebCore::FloatRect::expand): (WebCore::FloatRect::contract): (WebCore::FloatRect::shiftXEdgeTo): (WebCore::FloatRect::shiftMaxXEdgeTo): (WebCore::FloatRect::shiftYEdgeTo): (WebCore::FloatRect::shiftMaxYEdgeTo): (WebCore::FloatRect::minXMinYCorner): (WebCore::FloatRect::maxXMinYCorner): (WebCore::FloatRect::minXMaxYCorner): (WebCore::FloatRect::maxXMaxYCorner): (WebCore::FloatRect::transposedRect):
  • platform/graphics/FloatSize.h: (WebCore::FloatSize::expand): (WebCore::FloatSize::transposedSize):
3:13 PM Changeset in webkit [89624] by eae@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

input/textarea onchange doesn't fire if value is set in key listener
https://bugs.webkit.org/show_bug.cgi?id=63092

Add test for text field onchange when setting the value in a key listener.

  • fast/events/onchange-setvalue-expected.txt: Added.
  • fast/events/onchange-setvalue.html: Added.

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

input/textarea onchange doesn't fire if value is set in key listener
https://bugs.webkit.org/show_bug.cgi?id=63092

Change setValue implementation of HTMLInputElement and HTMLTextAreaElement to
not call setTextAsOfLastFormControlChangeEvent unless the value truly changed.
Thus element.value = element.value will no longer reset the state
m_textAsOfLastFormControlChangeEvent field and suppress the change event.

Test: fast/events/onchange-setvalue.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): (WebCore::HTMLTextAreaElement::setValueCommon):
3:11 PM Changeset in webkit [89623] by commit-queue@webkit.org
  • 3 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/delete-select-all-00* to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63193

converted editing/deleting/delete-select-all-002/003 to
runDumpAsTextEditingTest(true), removed old test files (including a
superfluous expected file for 001 on qt), and added new test files.

  • editing/deleting/delete-select-all-002-expected.txt: Added.
  • editing/deleting/delete-select-all-002.html:
  • editing/deleting/delete-select-all-003-expected.txt: Added.
  • editing/deleting/delete-select-all-003.html:
3:04 PM Changeset in webkit [89622] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows Tests] http/tests/media/video-cross-site.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=62024

Skip the test on Windows to get the bots green.

  • platform/win/Skipped:
3:02 PM Changeset in webkit [89621] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200

Revert r87060 as it broke compatibility with QtWebKit 2.1 release
and add some newly introduce symbols.

  • symbian/eabi/QtWebKitu.def:
2:55 PM Changeset in webkit [89620] by alokp@chromium.org
  • 3 edits in trunk/Tools

2011-06-23 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Add support for running layout tests with accelerated rendering
https://bugs.webkit.org/show_bug.cgi?id=63274

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:47 PM Changeset in webkit [89619] by Adam Roben
  • 2 edits in trunk/Tools

Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

As of r89610, results.html includes information about whether old-run-webkit-tests exited
early, so we don't need to look at JSON data to get this information for builds newer than
that.

Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
which is slow and limits history to the last build master restart

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
function. If we're dealing with a build that has early-exit information in results.html,
don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
(as before).

2:43 PM Changeset in webkit [89618] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriffbot can no longer restart
https://bugs.webkit.org/show_bug.cgi?id=63221

Fixed and unit tested.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2:42 PM Changeset in webkit [89617] by alexis.menard@openbossa.org
  • 16 edits
    2 adds in trunk/Source

2011-06-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Implement fullscreen support on Mac with the QuickTime backend.
https://bugs.webkit.org/show_bug.cgi?id=61728

Implement fullscreen support for Qt when using the QuickTime backend.
We mostly use what is already done for the Mac port.

  • DerivedSources.pro: We use the mac files and they have <WebCore/x> type of includes. We need to generate those headers.
  • WebCore.pro:
  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/qt/WebCoreSystemInterface.h:
  • platform/qt/WebCoreSystemInterface.mm:

2011-06-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Implement fullscreen support on Mac with the QuickTime backend.
https://bugs.webkit.org/show_bug.cgi?id=61728

Implement fullscreen support for Qt when using the QuickTime backend.
We mostly use what is already done for the Mac port.

  • QtWebKit.pro:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
  • WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added. (QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler): (QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler): (QTKitFullScreenVideoHandler::enterFullScreen): (QTKitFullScreenVideoHandler::exitFullScreen):
  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2:41 PM Changeset in webkit [89616] by mrobinson@webkit.org
  • 3 edits in trunk/Tools

2011-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=63287

Send the path to the TestNetscapePlugin to the WKTR via an environment variable
so that the plugin loads properly.

  • Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
  • WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some of the work for getting an environment variable and converting it to UTF-8. (WTR::TestController::initializeInjectedBundlePath): Use the helper. (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
2:36 PM Changeset in webkit [89615] by eric.carlson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Add a test with a single <source> element
https://bugs.webkit.org/show_bug.cgi?id=63285

  • media/video-single-valid-source-expected.txt: Added.
  • media/video-single-valid-source.html: Added.
2:35 PM Changeset in webkit [89614] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=61585
Crash running regexp /(?:(?=g))|(?:m).{2147483648,}/

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is due to use of int instead of unsigned, bad math around
the 231 boundary.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

  • Change some uses of int to unsigned, refactor compare logic to restrict to the range 0..232-1 (rather than -232-1..232-1).
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):

  • Ditto.

LayoutTests:

Add regression tests where an alterative has a size of ~231.

  • fast/regex/overflow-expected.txt: Added.
  • fast/regex/overflow.html: Added.
  • fast/regex/script-tests/overflow.js: Added.
2:30 PM Changeset in webkit [89613] by darin@apple.com
  • 17 edits in trunk/Source/WebCore

2011-06-23 Darin Adler <darin@apple.com>

Reviewed by Ryosuke Niwa.

RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955

  • dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
  • dom/DataTransferItem.h:
  • dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
  • dom/DataTransferItems.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
  • editing/CompositeEditCommand.h:
  • page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
  • page/WebKitAnimationList.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
  • svg/graphics/filters/SVGFilterBuilder.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.
2:10 PM Changeset in webkit [89612] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Snow Leopard WebKit2 Tests] http/tests/appcache/interrupted-update.html failing, probably
since introduction in r86478.
https://bugs.webkit.org/show_bug.cgi?id=63288

Add expected failing results in order to get the bots green.

  • platform/mac-wk2/http/tests/appcache/interrupted-update-expected.txt: Added.
2:04 PM Changeset in webkit [89611] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63218
DFG JIT - remove machine type guarantees from graph

Reviewed by Sam Weinig.

The DFG JIT currently makes assumptions about the types of machine registers
that certain nodes will be loaded into. This will be broken as we generate
nodes to produce both integer and double code paths. Remove int<->double
conversions nodes. This design decision also gave rise to multiple types of
constant nodes, requiring separate handling for each type. Merge these back
into JSConstant.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getToNumber):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::isDoubleConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfDoubleConstant):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::predictInt32):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isJSConstant):
(JSC::DFG::JITCodeGenerator::isDoubleConstant):
(JSC::DFG::JITCodeGenerator::valueOfJSConstantAsImmPtr):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::notTakenBytecodeOffset):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):

1:29 PM Changeset in webkit [89610] by Adam Roben
  • 2 edits in trunk/Tools

Record whether old-run-webkit-tests aborted early in results.html

Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
old-run-webkit-tests stopped running tests early

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(top level): Switched to heredoc syntax for printing the start of results.html for clarity.
Added a <style> element with some styles for the new message. If we stopped running early,
put the reason why at the top of results.html.
(stopRunningTestsEarlyIfNeeded): Store the message we print in the new
$stoppedRunningEarlyMessage global.

1:24 PM Changeset in webkit [89609] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89591 and r89593.
http://trac.webkit.org/changeset/89591
http://trac.webkit.org/changeset/89593
https://bugs.webkit.org/show_bug.cgi?id=63279

Caused test crashes in SL and Chromium (Requested by dimich_
on #webkit).

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89591 and r89593.
http://trac.webkit.org/changeset/89591
http://trac.webkit.org/changeset/89593
https://bugs.webkit.org/show_bug.cgi?id=63279

Caused test crashes in SL and Chromium (Requested by dimich_
on #webkit).

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged):
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::childrenChanged):
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::childrenChanged):
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::childrenChanged):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::startOfContinuations): (WebCore::AccessibilityRenderObject::updateAccessibilityRole): (WebCore::AccessibilityRenderObject::childrenChanged):
  • accessibility/AccessibilityRenderObject.h:
1:22 PM Changeset in webkit [89608] by eric.carlson@apple.com
  • 5 edits in trunk/LayoutTests

2011-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Incorrect MIME type used for some media layout tests
https://bugs.webkit.org/show_bug.cgi?id=63275

  • media/video-can-play-type-expected.txt: video/mpeg -> video/mp4
  • media/video-can-play-type.html: Ditto.
  • media/video-source-error.html: Ditto.
  • media/video-source-type.html: Ditto.
1:21 PM Changeset in webkit [89607] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[WebKit2 Tests] svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html failing since
introduction in r88913.
https://bugs.webkit.org/show_bug.cgi?id=63277

Add the (failing?) expected results in order to get the WK2 bots green.

  • platform/mac-wk2/svg: Added.
  • platform/mac-wk2/svg/zoom: Added.
  • platform/mac-wk2/svg/zoom/page: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
1:04 PM Changeset in webkit [89606] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-23 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Unbreak simple font fast-path after QRawFont API changes.
https://bugs.webkit.org/show_bug.cgi?id=63272

In the Qt 4.8 branch, the QGlyphs class has been renamed to
QGlyphRun, and some other small things have been tweaked.

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::rawFontForCharacters):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawGlyphs):
12:54 PM Changeset in webkit [89605] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

2011-06-23 Jamie Cooley <james.cooley@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Qt port needs load-from-history implementation
https://bugs.webkit.org/show_bug.cgi?id=57784

Created "random access" BackForwardHistory public API method,
QWKHistory::goToItemAt(int)

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItem::QWKHistoryItem::itemRef): Added access method to fetch WKBackForwardListRef

(QWKHistoryPrivate::QWKHistoryPrivate):
(QWKHistoryPrivate::createHistory):
Updated createHistory method and QWKHistoryPrivate constructor to take a pointer
to the owning QWKPage in addition to the WebBackForwardList. This will be saved so that the
new API can ask the page to load a HistoryItem.

(QWKHistory::goToItemAt):
New Public API. Like QWKHistory::itemAt, callee gives an integer.
<0 means jump back to that item, 0 means the current item, >0 means jump forwards.
If an out-of-range index is given, the function silently fails.
This will invoke WKPageGoToBackForwardListItem.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): Update instantiation of QWKHistory to include QWKPage.
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: (tst_QWKHistory::historyForwardBackTest_data): (tst_QWKHistory::historyForwardBackTest): Add test content for the new API
12:53 PM Changeset in webkit [89604] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Tony Chang <tony@chromium.org>

Reviewed by Andreas Kling.

Pass Strings as const references in NetworkResourcesData.h
https://bugs.webkit.org/show_bug.cgi?id=63271

  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::setFrameId): (WebCore::NetworkResourcesData::ResourceData::setUrl): (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
12:52 PM Changeset in webkit [89603] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added expected results for Snow Leopard and earlier.

  • platform/mac-snowleopard/platform/mac/fast/text: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
12:50 PM Changeset in webkit [89602] by jberlin@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Disable the test. I was wrong in thinking that the win skipped list inherits from mac.

  • http/tests/multipart/win-boundary-crash.html: Removed.
  • http/tests/multipart/win-boundary-crash.html-disabled: Copied from LayoutTests/http/tests/multipart/win-boundary-crash.html.
  • platform/mac/Skipped:
12:49 PM Changeset in webkit [89601] by Adam Roben
  • 4 edits
    1 add in trunk/Tools

Cache some of the TestFailures page's data in localStorage

This makes reloading TestFailures much faster. Right now we only store the number of failing
tests and the list of failing tests for each build. We may choose to store more later, but
it's easy to run up against quota limits.

Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
APIs (or similar) to improve loading performance

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
(Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
fetching data to the callback.
(Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
store the tests in the cache just before calling the callback. (The previous code in this
function relied on being able to modify the tests object after storing it in the cache and
having the cached version be updated. This worked while it was a non-serialized cache, but
PersistentCache uses serialization.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.

(PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
values, and stores the date that each value was initially stored along with it. This is
later used for pruning the cache.
(PersistentCache.contains): Checks whether the key exists in localStorage.
(PersistentCache.get): Fetch the string we stored in localStorage and extract the original
value out of it.
(PersistentCache.set): Serialize the value, add the date to it, and store it in
localStorage. If this fails due to quota limits, empty the whole cache and try again.
(PersistentCache.prune): Delete any cached data that is deemed old enough.
(PersistentCache._addDateToJSONString): Prepend the current date to the string.
(PersistentCache._emptyCache): Delete everything from localStorage.
(PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
return them.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change to callback signature. When
we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
where we'd never show the new bug link for tests for which we couldn't determine a passing
revision.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

PersistentCache.js.

12:32 PM Changeset in webkit [89600] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

The flakiness is happening on mac as well, move it to the mac skipped list.

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:29 PM Changeset in webkit [89599] by jcivelli@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-23 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Fixing the SharedBufferChunkReader API so it works correctly with
binary data (non printable characters).
Also adding a method to peek at the data (this is needed for MHTML
with binary parts).
https://bugs.webkit.org/show_bug.cgi?id=63231

  • loader/archive/mhtml/MHTMLParser.cpp: (WebCore::skipLinesUntilBoundaryFound): (WebCore::MHTMLParser::parseNextPart):
  • loader/archive/mhtml/MHTMLParser.h:
  • platform/SharedBufferChunkReader.cpp: (WebCore::SharedBufferChunkReader::SharedBufferChunkReader): (WebCore::SharedBufferChunkReader::setSeparator): (WebCore::SharedBufferChunkReader::nextChunk): (WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback): (WebCore::SharedBufferChunkReader::peek):
  • platform/SharedBufferChunkReader.h:
  • platform/network/MIMEHeader.cpp: (WebCore::retrieveKeyValuePairs):
12:13 PM Changeset in webkit [89598] by Nate Chapin
  • 8 edits in trunk

2011-06-23 Nate Chapin <Nate Chapin>

Unreviewed.

Revert production code part of r89503, since it's causing
crashes on WebKit2/mac and failures on qt.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::dispatchWindowLoadEvent):
  • dom/Document.h: (WebCore::Document::processingLoadEvent):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
12:11 PM Changeset in webkit [89597] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-23 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
https://bugs.webkit.org/show_bug.cgi?id=63152

The pausing conditions are modified. Now it accepts the infinite-iteration-count,
but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

  • animations/keyframes-infinite-iterations-expected.txt: Added.
  • animations/keyframes-infinite-iterations.html: Added.

2011-06-23 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
https://bugs.webkit.org/show_bug.cgi?id=63152

The pausing conditions are modified. Now it accepts the infinite-iteration-count,
but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

Test: animations/keyframes-infinite-iterations.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime):
11:42 AM Changeset in webkit [89596] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Add it to the Windows skipped list to get the bots green.

  • platform/win/Skipped:
11:30 AM Changeset in webkit [89595] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that we do not crash when doing a media query match.
https://bugs.webkit.org/show_bug.cgi?id=63264

  • fast/css/media-query-evaluator-crash-expected.txt: Added.
  • fast/css/media-query-evaluator-crash.html: Added.

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

RefPtr m_style in MediaQueryEvaluator in case of callers like
MediaQueryMatcher::prepareEvaluator that do not retain its reference.
https://bugs.webkit.org/show_bug.cgi?id=63264

Test: fast/css/media-query-evaluator-crash.html

  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryEvaluator.h:
11:23 AM Changeset in webkit [89594] by jshin@chromium.org
  • 14 edits
    3 adds in trunk/Source

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)

http://bugs.webkit.org/show_bug.cgi?id=20797

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Added for UScriptCode enum.
  • wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same
file was added to JavaScriptCore/icu/unicode.

http://bugs.webkit.org/show_bug.cgi?id=20797

  • icu/unicode/uscript.h: Added.

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Allow generic font family settings per script code.
https://bugs.webkit.org/show_bug.cgi?id=20797

Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.

uscript.h has been updated to that of ICU 3.6 (the version of ICU on
Mac OS 10.5)

There should be no change in layout and no new layout test
is added.

  • WebCore.exp.in:
  • icu/unicode/uscript.h: updated to ICU 4.6
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
11:04 AM Changeset in webkit [89593] by Chris Fleizach
  • 1 edit
    2 adds in trunk/LayoutTests

Make line breaking obey the -webkit-locale property
https://bugs.webkit.org/show_bug.cgi?id=63209

Patch by Dan Bernstein <mitz@apple.com> on 2011-06-23
Reviewed by Alexey Proskuryakov.

  • platform/mac/fast/text/line-break-locale.html: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.txt: Added.
11:02 AM Changeset in webkit [89592] by mitz@apple.com
  • 10 edits
    3 adds in trunk

Make line breaking obey the -webkit-locale property
https://bugs.webkit.org/show_bug.cgi?id=63209

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: platform/mac/fast/text/line-break-locale.html

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator): Take an optional locale identifier and
initialize the m_locale member.
(WebCore::LazyLineBreakIterator::get): Pass the locale to acquireLineBreakIterator().
(WebCore::LazyLineBreakIterator::reset): Pass the locale to releaseLineBreakIterator() and update
the m_locale member.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::LineBreakIteratorPool::sharedPool): Return a shared instance.
(WebCore::LineBreakIteratorPool::take): Returns a text iterator for the given locale, either a newly-
created one, or an existing one from the pool.
(WebCore::LineBreakIteratorPool::put): Puts an iterator back into the pool, removing the least-recently used
one if needed.
(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
(WebCore::acquireLineBreakIterator): Changed to take an optional local identifier, and to use the pool.
(WebCore::releaseLineBreakIterator): Changed to use the pool.

  • platform/text/brew/TextBreakIteratorBrew.cpp:

(WebCore::acquireLineBreakIterator): Updated for new parameter.

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use the locale from the style for the line break
iterator.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Ditto.

LayoutTests:

  • platform/mac/fast/text/line-break-locale.html: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.txt: Added.
10:59 AM Changeset in webkit [89591] by Chris Fleizach
  • 11 edits in trunk

ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289

Reviewed by Darin Adler.

Source/WebCore:

If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, I think the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.

Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.

Test: platform/mac/accessibility/aria-liveregion-without-element-access.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::childrenChanged):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):

This changed exposed a case where an object was inlineElementContinuation, but not renderInlined,
which led to an assert.

(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
10:53 AM Changeset in webkit [89590] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: marking debugger test as slow in chromium expectations.

  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [89589] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac rebaseline.

  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
10:44 AM Changeset in webkit [89588] by Adam Roben
  • 5 edits in trunk/Tools

Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing

One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
contain titles that are so long they are rejected by Bugzilla

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:

(Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
using a query string on the URL. If the search query is very long, using a query string can
cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
(Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.new-bug-form): Hide the form that we secretly use to file a new bug.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(fetchResource): Added. Code came from getResource. If we're using a GET request, add the
query parameters to the URL. Otherwise, send them as the body of the request along with the
appropriate headers.
(getResource): Now just calls through to fetchResource.
(urlEncodedQueryParameters): Added. Moved some code here...
(addQueryParametersToURL): ...from here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
number of failing tests if mentioning all the tests would make the title too long. Improved
the description for large numbers of failures by listing the tests one-per-line instead of
just having them be comma-separated, which was hard to read. Use a form to file the new bug
instead of a link so that we can POST the form data. (Using a URL with a query string can
result in the URL being too long.) The new bug link now just submits the form.

10:42 AM Changeset in webkit [89587] by krit@webkit.org
  • 25 edits
    2 adds in trunk/Source/WebCore

2011-06-23 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Convert SVGColor to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63246

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGColor.

Changed constructors of animators to take the animation element SVGAnimationsElement as new argument. Removed attribute name argument instead.
This information is already exposed by the animation element. The animators store the pointer of the animation element, so that it is not
necessary to pass it as argument to the functions calculateDistance, calculateAnimatedValue.


Replace all SVGSMILElement references by SVGAnimationsElement - the common base class of all animation elements.

Added a new method in SVGAnimateElement to determine the property value type of CSS properties (regular value type, inherit or currentColor).
The other two new methods fromPropertyValueType() and toPropertyValueType() avoid passing boolean arguments in calculateAnimatedValue().

No new tests added. Current tests cover the changes.

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Use Animator for SVGColor. (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::determinePropertyValueTypes): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance): (WebCore::SVGAnimateElement::ensureAnimator): Pass the animation element as pointer to animator.
  • svg/SVGAnimateElement.h: Removed unnecessary includes. Some cleanup. (WebCore::SVGAnimateElement::fromPropertyValueType): Get property value type of 'from' property. (WebCore::SVGAnimateElement::toPropertyValueType): Get property value type of 'to' property.
  • svg/SVGAnimatedAngle.cpp: (WebCore::SVGAnimatedAngleAnimator::SVGAnimatedAngleAnimator): Added SVGSMILElement as new argument, removed attributeName. (WebCore::SVGAnimatedAngleAnimator::calculateFromAndToValues): Determine property value type. (WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues): Ditto. (WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue): Use new functions of SVGAnimateElement for handling of 'inherit'.

And removed unnecessary arguments.

(WebCore::SVGAnimatedAngleAnimator::calculateDistance): Removed animation element argument.

  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedColor.cpp: Added. (WebCore::SVGAnimatedColorAnimator::SVGAnimatedColorAnimator): Ditto. (WebCore::SVGAnimatedColorAnimator::constructFromString): (WebCore::SVGAnimatedColorAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedColorAnimator::calculateDistance):
  • svg/SVGAnimatedColor.h: Added. (WebCore::SVGAnimatedColorAnimator::~SVGAnimatedColorAnimator):
  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): Ditto. (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::SVGAnimatedNumberAnimator): Ditto. (WebCore::SVGAnimatedNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberAnimator::calculateDistance):
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedPointList.cpp: (WebCore::SVGAnimatedPointListAnimator::SVGAnimatedPointListAnimator): Ditto. (WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPointListAnimator::calculateDistance):
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedRect.cpp: (WebCore::SVGAnimatedRectAnimator::SVGAnimatedRectAnimator): Ditto. (WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedRectAnimator::calculateDistance):
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedType.cpp: Added handling of Color values. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createColor): (WebCore::SVGAnimatedType::color): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
10:38 AM Changeset in webkit [89586] by jam@chromium.org
  • 2 edits in branches/chromium/782/Source/WebKit/chromium/src

Merge 89584 - 2011-06-23 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
https://bugs.webkit.org/show_bug.cgi?id=63260

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::visibleHeight): (WebKit::WebScrollbarImpl::visibleWidth): (WebKit::WebScrollbarImpl::contentsSize): (WebKit::WebScrollbarImpl::overhangAmount):
  • src/WebScrollbarImpl.h:

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/7248010

10:35 AM Changeset in webkit [89585] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

remove references to dump-as-markup in editing/deleting/delete-by-word tests
https://bugs.webkit.org/show_bug.cgi?id=62903

Each of these files had '../../../resources/dump-as-markup.js' referenced, which was broken.
Neither of them was using dump-as-markup, so it did not break anything - this fix just removes
the unused broken references.

  • editing/deleting/delete-by-word-001.html:
  • editing/deleting/delete-by-word-002.html:
10:35 AM Changeset in webkit [89584] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-23 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
https://bugs.webkit.org/show_bug.cgi?id=63260

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::visibleHeight): (WebKit::WebScrollbarImpl::visibleWidth): (WebKit::WebScrollbarImpl::contentsSize): (WebKit::WebScrollbarImpl::overhangAmount):
  • src/WebScrollbarImpl.h:
10:13 AM Changeset in webkit [89583] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: marking debugger test as slow in chromium expectations.

  • platform/chromium/test_expectations.txt:
10:06 AM Changeset in webkit [89582] by yael.aharon@nokia.com
  • 19 edits
    3 adds in trunk/Source

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Add convenience methods to allow encoding/decoding of DragData.
Move the call to dragEnded() to DragClient, to make WebKit1 and WebKit2
consistent.

  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • platform/DragData.h: (WebCore::DragData::flags): (WebCore::DragData::DragData): (WebCore::DragData::operator =):

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Call dragEnded from the DragClient to make WebKit1 and WebKit2 consistent.

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Added missing pieces to add support for DnD in QtWebKit.

  • Shared/qt/ArgumentCodersQt.cpp: Added. (CoreIPC::::encode): (CoreIPC::::decode):
  • Shared/qt/ArgumentCodersQt.h: Added. Encode DragData so that we can transfer the QMimeData between the WebProcess and the UI Process. I encode the DragData and not QMimeData directly because we don't have an associated QMimeData for each message.
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::init): (QGraphicsWKView::dragEnterEvent): (QGraphicsWKView::dragLeaveEvent): (QGraphicsWKView::dragMoveEvent): (QGraphicsWKView::dropEvent):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (dropActionToDragOperation): (dragOperationToDropAction): (dragOperationToDropActions): (QWKPagePrivate::dragEnterEvent): (QWKPagePrivate::dragLeaveEvent): (QWKPagePrivate::dragMoveEvent): (QWKPagePrivate::dropEvent): (QWKPagePrivate::startDrag):

Send drag-and-drop related events to WebKit.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::performDragControllerAction): (WebKit::WebPageProxy::startDrag):
  • UIProcess/WebPageProxy.h:

Start the HTML5 drag operation from the UI process, because QDrag
needs a handle to the QWidget under the mouse.

  • UIProcess/WebPageProxy.messages.in:

Add message type that takes DragData as a parameter.

  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Added. (WebKit::convertImageToBitmap): (WebKit::WebDragClient::startDrag):

Send a message to the UI process to start the HTML5 drag operation.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add message type that takes DragData as a parameter.

10:02 AM Changeset in webkit [89581] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[EFL][WK2] Add PLATFORM(EFL) to use UNIX_DOMAIN_SOCKETS.
https://bugs.webkit.org/show_bug.cgi?id=63228

  • wtf/Platform.h: Add PLATFORM(EFL) guard.
9:41 AM Changeset in webkit [89580] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-23 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[UNIX] Fix compile warnings in NetscapePluginX11.cpp
https://bugs.webkit.org/show_bug.cgi?id=63249

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setXButtonEventFields): (WebKit::NetscapePlugin::platformHandleMouseEvent):
9:35 AM Changeset in webkit [89579] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
9:02 AM Changeset in webkit [89578] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

8:56 AM Changeset in webkit [89577] by commit-queue@webkit.org
  • 14 edits
    2 copies in trunk/Source/WebCore

2011-06-23 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Show "no content" message in network panel when resource does not have content available.
https://bugs.webkit.org/show_bug.cgi?id=63007

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype._updateWithCookies):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/EmptyView.js: Added. (WebInspector.EmptyView): (WebInspector.EmptyView.prototype.show): (WebInspector.EmptyView.prototype.set text):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.ResourceContentView): (WebInspector.ResourceContentView.prototype.hasContent): (WebInspector.ResourceContentView.prototype.get sourceView): (WebInspector.ResourceContentView.prototype.show): (WebInspector.ResourceContentView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourceContentView.prototype._ensureInnerViewShown): (WebInspector.ResourceContentView.prototype.contentLoaded):
  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.show):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView): (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/ResourceResponseView.js: Added. (WebInspector.ResourceResponseView): (WebInspector.ResourceResponseView.prototype.get sourceView): (WebInspector.ResourceResponseView.prototype.contentLoaded):
  • inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.prototype.show):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.StorageCategoryView): (WebInspector.StorageCategoryView.prototype.setText):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:53 AM Changeset in webkit [89576] by kbalazs@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-23 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

PluginView::dispatchNPEvent is deceptive
https://bugs.webkit.org/show_bug.cgi?id=63243

Straighten the inverted logic of dispatchNPEvent
and it's callers.

No change in behaviour so no new tests.
Existing plugin tests cover this.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
8:48 AM Changeset in webkit [89575] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in
r88679.
https://bugs.webkit.org/show_bug.cgi?id=63205

This test does not fail on Windows, so add back in the passing expected results to get the
bots green.

  • platform/win-wk2/plugins/npruntime: Added.
  • platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
8:44 AM Changeset in webkit [89574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Export files under Symbian Qt WebKit build
https://bugs.webkit.org/show_bug.cgi?id=61207

Export files for the Symbian platform as this is needed by the
production build system.

Janne Koskinen provided the suggestion to use target_predeps,
which is an improvement over the originally suggested patch.

8:27 AM Changeset in webkit [89573] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=63122

Fixing broken makefile.

  • GNUmakefile.list.am:
8:20 AM Changeset in webkit [89572] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Crash when running EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62628

Call DocumentWriter::setEncoding when FrameLoaderClientEfl::finishedLoading()
like other ports.
It will clear parser not to crash when called endIfNotLoadingMainResource().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): (WebCore::FrameLoaderClientEfl::makeRepresentation): (WebCore::FrameLoaderClientEfl::revertToProvisionalState): (WebCore::FrameLoaderClientEfl::finishedLoading):
  • WebCoreSupport/FrameLoaderClientEfl.h:
8:19 AM Changeset in webkit [89571] by Adam Roben
  • 4 edits in trunk/Tools

Show closed bugs on the TestFailures page in addition to open ones

Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:

(Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
returned data.
(Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
the associated bug is still open.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(addQueryParametersToURL): Add a missing semicolon.
(Node.prototype.appendChildren): New function, like appendChild but takes an array-like
object and appends each of the values stored within.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
bugs will be included in the results. Split the returned bugs into two sets: those which are
open, and those which are closed. Put the open bugs at the top level of the list, and the
closed bugs in a second level.

7:58 AM Changeset in webkit [89570] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt
https://bugs.webkit.org/show_bug.cgi?id=63178

  • platform/qt/Skipped: Skip http/tests/inspector/extensions-resources-redirect.html until fix.
7:46 AM Changeset in webkit [89569] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r89503): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255

  • platform/qt/Skipped: Skip failing tests until fix.
7:34 AM Changeset in webkit [89568] by Adam Roben
  • 2 edits in trunk/Tools

Don't count new tests as failures on the TestFailures page

Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
they aren't

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
of failures.

7:23 AM Changeset in webkit [89567] by commit-queue@webkit.org
  • 22 edits
    10 moves in trunk/Source/WebCore

2011-06-23 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=63122

No new tests since no code has actually changed.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toMediaStream): (WebCore::EventTarget::toLocalMediaStream):
  • dom/EventTarget.h:
  • dom/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/GeneratedStream.cpp. (WebCore::LocalMediaStream::DispatchUpdateTask::create): (WebCore::LocalMediaStream::DispatchUpdateTask::performTask): (WebCore::LocalMediaStream::DispatchUpdateTask::DispatchUpdateTask): (WebCore::LocalMediaStream::create): (WebCore::LocalMediaStream::LocalMediaStream): (WebCore::LocalMediaStream::~LocalMediaStream): (WebCore::LocalMediaStream::toLocalMediaStream): (WebCore::LocalMediaStream::detachEmbedder): (WebCore::LocalMediaStream::streamEnded): (WebCore::LocalMediaStream::audioTracks): (WebCore::LocalMediaStream::videoTracks): (WebCore::LocalMediaStream::stop): (WebCore::LocalMediaStream::onStop):
  • dom/LocalMediaStream.h: Renamed from Source/WebCore/dom/GeneratedStream.h.
  • dom/LocalMediaStream.idl: Renamed from Source/WebCore/dom/GeneratedStream.idl.
  • dom/MediaStream.cpp: Renamed from Source/WebCore/dom/Stream.cpp. (WebCore::MediaStream::create): (WebCore::MediaStream::MediaStream): (WebCore::MediaStream::~MediaStream): (WebCore::MediaStream::toMediaStream): (WebCore::MediaStream::streamEnded): (WebCore::MediaStream::scriptExecutionContext): (WebCore::MediaStream::eventTargetData): (WebCore::MediaStream::ensureEventTargetData):
  • dom/MediaStream.h: Renamed from Source/WebCore/dom/Stream.h. (WebCore::MediaStream::readyState): (WebCore::MediaStream::label): (WebCore::MediaStream::refEventTarget): (WebCore::MediaStream::derefEventTarget):
  • dom/MediaStream.idl: Renamed from Source/WebCore/dom/Stream.idl.
  • dom/MediaStreamContainer.h: Renamed from Source/WebCore/dom/StreamContainer.h. (WebCore::MediaStreamContainer::create): (WebCore::MediaStreamContainer::~MediaStreamContainer): (WebCore::MediaStreamContainer::length): (WebCore::MediaStreamContainer::item): (WebCore::MediaStreamContainer::add): (WebCore::MediaStreamContainer::remove): (WebCore::MediaStreamContainer::contains): (WebCore::MediaStreamContainer::get): (WebCore::MediaStreamContainer::MediaStreamContainer):
  • dom/MediaStreamList.cpp: Renamed from Source/WebCore/dom/StreamList.cpp. (WebCore::MediaStreamList::create): (WebCore::MediaStreamList::MediaStreamList): (WebCore::MediaStreamList::~MediaStreamList): (WebCore::MediaStreamList::length): (WebCore::MediaStreamList::item):
  • dom/MediaStreamList.h: Renamed from Source/WebCore/dom/StreamList.h.
  • dom/MediaStreamList.idl: Renamed from Source/WebCore/dom/StreamList.idl.
  • dom/StreamEvent.cpp: (WebCore::StreamEvent::create): (WebCore::StreamEvent::StreamEvent): (WebCore::StreamEvent::initStreamEvent): (WebCore::StreamEvent::stream):
  • dom/StreamEvent.h: (WebCore::StreamEvent::isMediaStreamEvent):
  • dom/StreamEvent.idl:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::getStreamFromLabel): (WebCore::MediaStreamFrameController::stopGeneratedStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::audioTrackFailed): (WebCore::MediaStreamFrameController::videoTrackFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::isMediaStream): (WebCore::MediaStreamFrameController::ClientBase::isLocalMediaStream): (WebCore::MediaStreamFrameController::MediaStreamClient::MediaStreamClient): (WebCore::MediaStreamFrameController::MediaStreamClient::~MediaStreamClient): (WebCore::MediaStreamFrameController::MediaStreamClient::isMediaStream): (WebCore::MediaStreamFrameController::MediaStreamClient::isLocalMediaStream):
  • page/NavigatorUserMediaSuccessCallback.h:
  • page/NavigatorUserMediaSuccessCallback.idl:
7:02 AM Changeset in webkit [89566] by yurys@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89547.
http://trac.webkit.org/changeset/89547
https://bugs.webkit.org/show_bug.cgi?id=63252

"Chrmium crash on start" (Requested by yurys on #webkit).

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
  • wtf/DynamicAnnotations.h:
6:51 AM Changeset in webkit [89565] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for a newish accessibility test

The failure is tracked by <http://webkit.org/b/63191>.

  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
6:36 AM Changeset in webkit [89564] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: updated chromium expectations.

  • platform/chromium/test_expectations.txt:
6:31 AM Changeset in webkit [89563] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Inspector may close at the start of the next inspector test in DRT
https://bugs.webkit.org/show_bug.cgi?id=60881

  • platform/qt/Skipped: Unskip inspector tests after fix, skip still failing tests.
5:51 AM Changeset in webkit [89562] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
https://bugs.webkit.org/show_bug.cgi?id=63250

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):
5:48 AM Changeset in webkit [89561] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237

  • tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.

(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):

5:45 AM Changeset in webkit [89560] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245

  • tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.

(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):

5:26 AM Changeset in webkit [89559] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix conflicting chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:22 AM Changeset in webkit [89558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HTML preview in network panel should take 100% of resource view height.
https://bugs.webkit.org/show_bug.cgi?id=63167

  • inspector/front-end/inspector.css: (.resource-view.html iframe):
5:19 AM Changeset in webkit [89557] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: brush up chromium inspector expectations.

  • http/tests/inspector/inspector-test.js:
  • platform/chromium/test_expectations.txt:
5:02 AM Changeset in webkit [89556] by zherczeg@webkit.org
  • 4 edits in trunk

Inspector may close at the start of the next inspector test in DRT
https://bugs.webkit.org/show_bug.cgi?id=60881

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-23
Reviewed by Pavel Feldman.

Source/WebCore:

Add a new function to the inspector, which tests whether the
dispatch queue is empty.

  • inspector/front-end/inspector.js:

(WebInspector.dispatchQueueIsEmpty):

LayoutTests:

The didEvaluateForTestInFrontend function call is postponed until
all messages in the dispatch queue is processed.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.completeTest):

4:52 AM Changeset in webkit [89555] by sergio@webkit.org
  • 1 edit
    82 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, final round of baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-min-max-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/width-replaced-element-001-expected.txt: Added.
4:44 AM Changeset in webkit [89554] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Unexpected passes in chromium expectations removed from excludes.

  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:27 AM Changeset in webkit [89553] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Chromium test expectations updated.

  • platform/chromium/test_expectations.txt:
4:14 AM Changeset in webkit [89552] by sergio@webkit.org
  • 1 edit
    124 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-011-expected.txt: Added.
3:59 AM Changeset in webkit [89551] by sergio@webkit.org
  • 1 edit
    104 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, more GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-017-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-024-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-030-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-031-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-020-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-027-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-034-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-036-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-041-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-043-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-048-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-050-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-055-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-057-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-062-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-064-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-069-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-071-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-076-expected.txt: Added.
3:44 AM Changeset in webkit [89550] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

2011-06-23 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Nikolas Zimmermann.

Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Added tests to make sure fallback color is used properly with invalid gradients.

  • svg/custom/invalid-gradient-with-xlink-expected.png: Added.
  • svg/custom/invalid-gradient-with-xlink-expected.txt: Added.
  • svg/custom/invalid-gradient-with-xlink.svg: Added.
  • svg/custom/xlink-to-invalid-gradient-expected.png: Added.
  • svg/custom/xlink-to-invalid-gradient-expected.txt: Added.
  • svg/custom/xlink-to-invalid-gradient.svg: Added.

2011-06-23 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Nikolas Zimmermann.

Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Added a check for gradient rendering contexts. If the contexts can't be found, the gradient must be in an invalid location, so we use the fallback color instead.

Tests: svg/custom/invalid-gradient-with-xlink.svg

svg/custom/xlink-to-invalid-gradient.svg

  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes):
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes):
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGRadialGradientElement.h:
3:35 AM Changeset in webkit [89549] by sergio@webkit.org
  • 1 edit
    48 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, another bunch of GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-017-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-020-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-024-expected.txt: Added.
3:24 AM Changeset in webkit [89548] by sergio@webkit.org
  • 1 edit
    49 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, add GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt: Added.
2:55 AM Changeset in webkit [89547] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-23 Timur Iskhodzhanov <timurrrr@google.com>

Reviewed by David Levin.

Make dynamic annotations weak symbols and prevent identical code folding by the linker
https://bugs.webkit.org/show_bug.cgi?id=62443

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
  • wtf/DynamicAnnotations.h:
2:54 AM Changeset in webkit [89546] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, rebaseline a couple of SVG tests for GTK+.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/gtk/svg/custom/pointer-events-text-expected.txt:
2:47 AM Changeset in webkit [89545] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating chromium expectations.

  • platform/chromium/fast/js/parser-xml-close-comment-expected.txt:
  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [89544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Dmitriy Vyukov <dvyukov@google.com>

Reviewed by David Levin.

Fix incorrect usage of a condition variable.
https://bugs.webkit.org/show_bug.cgi?id=63127

No new tests. This does not affect existing
functionality.

  • storage/DatabaseTask.cpp: (WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
1:24 AM Changeset in webkit [89543] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Add new "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2 skipped list.

  • platform/mac-wk2/Skipped:
1:02 AM Changeset in webkit [89542] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: make TestInput objects printable
https://bugs.webkit.org/show_bug.cgi?id=63225

This makes debugging slighlty easier.

  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
12:20 AM Changeset in webkit [89541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 David Grogan <dgrogan@chromium.org>

Reviewed by Eric Seidel.

IndexedDB: add detail to an ASSERT error message
https://bugs.webkit.org/show_bug.cgi?id=60407

No new tests, this is just a debug ASSERT.

  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Jun 22, 2011:

11:58 PM Changeset in webkit [89540] by pfeldman@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaseline chromium expectation.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:46 PM Changeset in webkit [89539] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[UNIX] Increment/decrement module load conter in NetscapePluginModule::getPluginInfo()
https://bugs.webkit.org/show_bug.cgi?id=63150

Since the method is static, we are using
NetscapePluginModule::getOrCreate() to get the module. If it's
created, the load counter is 0, so that when module is deleted,
shutdown() hasn't been called and the destructor crashes in the
assert that checks the module has been removed from the
initialized module list. We should increment the load counter, and
decrement it before getPluginInfo() returns, so that
decrementLoadCount() will call shutdown() if counter is 0 and the
module will be deleted from the list.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::NetscapePluginModule::getPluginInfo):
11:46 PM Changeset in webkit [89538] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium/test_expectations.txt:
11:44 PM Changeset in webkit [89537] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs
https://bugs.webkit.org/show_bug.cgi?id=63149

NetscapePlugin::fromNPP() shouldn't be called with a null npp, it
contains an assert that make it crash when building with debug enabled.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue):
11:31 PM Changeset in webkit [89536] by krit@webkit.org
  • 14 edits
    8 adds
    3 deletes in trunk

2011-06-22 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

Convert SVGPointList to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63171

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGPointList.

Added support for from-by animations of SVGPointLists.

Tests: svg/animations/svgpointlist-animation-1.html

svg/animations/svgpointlist-animation-2.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Added SVGAnimatedPointList.cpp
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedPointList.cpp: Added. (WebCore::SVGAnimatedPointListAnimator::SVGAnimatedPointListAnimator): (WebCore::SVGAnimatedPointListAnimator::constructFromString): (WebCore::SVGAnimatedPointListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPointListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPointListAnimator::calculateDistance):
  • svg/SVGAnimatedPointList.h: Added. (WebCore::SVGAnimatedPointListAnimator::~SVGAnimatedPointListAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPointList): (WebCore::SVGAnimatedType::pointList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):

2011-06-22 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

Convert SVGPointList to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63171

Renamed test animate-points to svgpointlist-animation-1 and cleaned it up.
svgpointlist-animation-2 checks from-by animations of SVGPointLists.

  • svg/animations/animate-points-expected.txt: Removed.
  • svg/animations/animate-points.html: Removed.
  • svg/animations/script-tests/animate-points.js: Removed.
  • svg/animations/script-tests/svgpointlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgpointlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgpointlist-animation-1-expected.txt: Added.
  • svg/animations/svgpointlist-animation-1.html: Added.
  • svg/animations/svgpointlist-animation-2-expected.txt: Added.
  • svg/animations/svgpointlist-animation-2.html: Added.
11:04 PM Changeset in webkit [89535] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-06-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Move file-choosing and icon-loading management to FileInputType
https://bugs.webkit.org/show_bug.cgi?id=62069

1) Moved the duties of FileChooserClient and FileIconLoaderClient from
RenderFileUploadControl to FileInputType, along with all of the
supporting functions.

2) Moved Icon ownership to FileInputType and exposed accessor on
HTMInputElement to allow RenderFileUploadControl to query current icon.

As a result, RenderFileUploadControl is now completely stateless, which is
neat and clean.

Refactoring, covered by existing tests.

  • html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Moved logic here from RenderFileUploadControl. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto. (WebCore::FileInputType::receiveDropForDirectoryUpload): Ditto. (WebCore::FileInputType::updateRendering): Ditto. (WebCore::FileInputType::chrome): Ditto. (WebCore::FileInputType::receiveDroppedFiles): Ditto. (WebCore::FileInputType::icon): Added.
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer): Updated comment. (WebCore::HTMLInputElement::receiveDroppedFiles): Added to replace setFileListFromRenderer. (WebCore::HTMLInputElement::icon): Added.
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::receiveDroppedFiles): Added. (WebCore::InputType::icon): Added.
  • html/InputType.h:
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Changed to use HTMLInputElement. Ahh, nice and clean!
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed code that is no longer necessary. (WebCore::RenderFileUploadControl::updateFromElement): Ditto. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use HTMLInputElement icon accessor. (WebCore::RenderFileUploadControl::paintObject): Ditto.
  • rendering/RenderFileUploadControl.h:
11:00 PM Changeset in webkit [89534] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-22 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

Add NSError wrapper functions in ResourceError when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63155

Add wrapper functions to ResourceError when building with USE(CFNETWORK). We need to create
a new NSError in ResourceError::nsError() since Safari has category methods on NSError and
passing a CFErrorRef back does not work even though CFErrorRef/NSErrror are toll-free
bridged.

No tests because no change in functionality.

  • WebCore.exp.in:
  • platform/network/cf/ResourceError.h:
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::nsError): (WebCore::ResourceError::operator NSError *):
10:59 PM Changeset in webkit [89533] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium/test_expectations.txt:
10:33 PM Changeset in webkit [89532] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-06-22 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

test-webkitpy --all errors out because scm_unittest.py can't find module checkout
https://bugs.webkit.org/show_bug.cgi?id=62943

Remove "from .checkout import Checkout" from scm_unittest.py since it's included
by Scripts/webkitpy/common/checkout/init.py.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
10:25 PM Changeset in webkit [89531] by Lucas Forschler
  • 1 copy in tags/Safari-534.49

New tag.

10:09 PM Changeset in webkit [89530] by dominicc@chromium.org
  • 16 edits in trunk

2011-06-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Mark Rowe.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html

2011-06-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Mark Rowe.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • Configurations/WebCoreTestSupport.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

2011-06-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Mark Rowe.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport

2011-06-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Mark Rowe.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9:54 PM Changeset in webkit [89529] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

[chromium] Remove calls to Position::deprecatedNode
https://bugs.webkit.org/show_bug.cgi?id=63226

Call containerNode instead of deprecatedNode.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType):
9:19 PM Changeset in webkit [89528] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r89436.

9:18 PM Changeset in webkit [89527] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r89398.

8:55 PM Changeset in webkit [89526] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-06-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient.
https://bugs.webkit.org/show_bug.cgi?id=63224

Refactoring, covered by existing tests.

  • platform/FileIconLoader.cpp: (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Changed to discard loader. (WebCore::FileIconLoaderClient::newFileIconLoader): Added. (WebCore::FileIconLoaderClient::discardLoader): Added.
  • platform/FileIconLoader.h: Updated defs.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed initialization of icon loader. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Remove discarding of loader. (WebCore::RenderFileUploadControl::requestIcon): Changed to use newFileIconLoader.
  • rendering/RenderFileUploadControl.h: Updated defs.
8:49 PM Changeset in webkit [89525] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Another unreviewed build fix after r89472.

No new tests, just a build fix.

  • rendering/svg/SVGResources.cpp:
8:26 PM Changeset in webkit [89524] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r89472.

No new tests, just a build fix.

  • rendering/InlineBox.cpp:
  • rendering/RenderCounter.cpp:
8:07 PM Changeset in webkit [89523] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-06-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Add a helper function to FileList to retrieve a list of filenames.
https://bugs.webkit.org/show_bug.cgi?id=63222

Refactoring, covered by existing tests.

  • fileapi/FileList.cpp: (WebCore::FileList::filenames): Added.
  • fileapi/FileList.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use newly added helper. (WebCore::RenderFileUploadControl::click): Ditto. (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
7:31 PM Changeset in webkit [89522] by weinig@apple.com
  • 5 edits
    6 deletes in trunk

Lower HTML parser DOM depth limit to 2048
https://bugs.webkit.org/show_bug.cgi?id=63219

Reviewed by Adam Barth.

Source/WebCore:

Lower the default depth limit from 4096 to 2048. There isn't a good
reason to have such pathologically nested content, and by-and-large,
the rendering code is not setup to support it that well. Adding this
aggressive limit now will allow us to see if anything breaks in the
nightlies.

  • page/Settings.h:

LayoutTests:

Update nest test to reflect new limit and remove tests that were
testing specific behaviors of the old parser.

  • fast/parser/block-nesting-cap-expected.txt:
  • fast/parser/block-nesting-cap-table-expected.txt: Removed.
  • fast/parser/block-nesting-cap-table.html: Removed.
  • fast/parser/element-nesting-cap-expected.txt: Removed.
  • fast/parser/element-nesting-cap.html: Removed.
  • fast/parser/script-tests/block-nesting-cap-table.js: Removed.
  • fast/parser/script-tests/block-nesting-cap.js:
  • fast/parser/script-tests/element-nesting-cap.js: Removed.
7:26 PM Changeset in webkit [89521] by jchaffraix@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-22 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Dimitri Glazkov.

Tighten type usage in the Shadow tree code
https://bugs.webkit.org/show_bug.cgi?id=63210

Refactoring only, no new test required.

  • dom/Document.cpp: (WebCore::Document::buildAccessKeyMap):
  • dom/Document.h: Changed the argument of buildAccessKeyMap to TreeScope.
  • dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::removeShadowRoot):
  • html/ColorInputType.cpp: (WebCore::ColorInputType::shadowColorSwatch):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::shadowSelect):
  • html/shadow/SliderThumbElement.cpp: (WebCore::sliderThumbElementOf): Use ShadowRoot for the previous call sites as this is what is returned by shadowRoot().
  • dom/Node.cpp: (WebCore::traverseTreeAndMark): Renamed the parameter here as it is not expected to be a shadow object. Just the rootNode of our traversal.
  • dom/ShadowRoot.h: Made attach() public as it is public in ContainerNode and we would do some casting to avoid the private attribute in ShadowRoot.
7:14 PM Changeset in webkit [89520] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107

itertools.chain.from_iterable is new in 2.6,
use itertools.chain(*list) for 2.5 compat.

  • Scripts/webkitpy/tool/bot/irc_command.py:
7:09 PM Changeset in webkit [89519] by tkent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-22 Kent Tamura <tkent@chromium.org>

[Win] media/media-controls-clone.html failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63195

  • platform/win/media/media-controls-clone-expected.txt: Added.
6:44 PM Changeset in webkit [89518] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make sheriff-bot robust against exceptions from commands
https://bugs.webkit.org/show_bug.cgi?id=63211

sheriff-bot was acting strange this afternoon.
We don't know if this will fix the cause, but
at least it adds some unit tests and catches
one possible cause.

  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
6:43 PM Changeset in webkit [89517] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-06-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Remove comment about pages with frames not being page-cachable
https://bugs.webkit.org/show_bug.cgi?id=63207

This comment was out of date. Caching pages with Frames in
the PageCache has worked since 2009:
<http://webkit.org/b/13631> Page Cache should support pages with frames

  • history/PageCache.cpp: (WebCore::PageCache::canCache):
6:36 PM Changeset in webkit [89516] by yael.aharon@nokia.com
  • 7 edits in trunk/Source

2011-06-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113

  • wtf/Platform.h:

2011-06-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113

No new tests. If this new flag was set by default, we could unskip
existing xmlviewer tests.

  • CodeGenerators.pri:
  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
6:34 PM Changeset in webkit [89515] by mrowe@apple.com
  • 2 edits in trunk/Tools

<http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287

Reviewed by David Levin.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to

be relative to the built products directory rather than using a hard-coded path. Remove the
explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
rather than in the .xcodeproj directly.

6:27 PM Changeset in webkit [89514] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Yet another build fix after r89472.

  • html/parser/HTMLFormattingElementList.cpp:
6:20 PM Changeset in webkit [89513] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Another build fix after r89472.

  • dom/DocumentMarkerController.cpp:
6:17 PM Changeset in webkit [89512] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-06-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: remove obsolete port.shut_down_http_server method
https://bugs.webkit.org/show_bug.cgi?id=59993

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
6:15 PM Changeset in webkit [89511] by mdelaney@apple.com
  • 3 edits
    1 move
    3 adds in trunk/LayoutTests

2011-06-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by James Robinson.

Fixing test spanOverlapsCanvas.html to properly use layer tree text and rebaselining test off that for windows and mac.
https://bugs.webkit.org/show_bug.cgi?id=63190

  • compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • compositing/layer-creation/spanOverlapsCanvas.html:
  • platform/mac-snowleopard/compositing: Added.
  • platform/mac-snowleopard/compositing/layer-creation: Added.
  • platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
6:10 PM Changeset in webkit [89510] by macpherson@chromium.org
  • 2 edits in trunk/Tools

2011-06-22 Luke Macpherson <macpherson@chromium.org>

Reviewed by Andreas Kling.

Move macpherson from contributor list to committer list.
https://bugs.webkit.org/show_bug.cgi?id=63179

  • Scripts/webkitpy/common/config/committers.py: Move macpherson from contributor list to committer list.
6:07 PM Changeset in webkit [89509] by commit-queue@webkit.org
  • 6 edits in trunk

2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120

ADD ENABLE_DEVICE_ORIENTATION.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120

  • CMakeListsEfl.txt: Add files to build with ENABLE_DEVICE_ORIENTATION.
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): Create DeviceOrientationClientEfl and DeviceMotionClientEfl.
6:05 PM Changeset in webkit [89508] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-06-22 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
https://bugs.webkit.org/show_bug.cgi?id=63204

  • Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined with similar code for the parameter checking.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from those done for single lines since they don't make sense in that case (variable decls look like function decls). Removed some redundant comments (one of which was slightly wrong). Added checks for the new functionality and minor other test changes.
6:05 PM Changeset in webkit [89507] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Build fix after r89472.

  • css/CSSStyleDeclaration.cpp:
5:57 PM Changeset in webkit [89506] by commit-queue@webkit.org
  • 7 edits in trunk

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110

  • storage/indexeddb/database-name-undefined-expected.txt:
  • storage/indexeddb/database-name-undefined.html: removed some code here because it's duplicated in the mozilla/open-database-null-name test
  • storage/indexeddb/mozilla/open-database-null-name-expected.txt:
  • storage/indexeddb/mozilla/open-database-null-name.html: fixed expected behavior (db.name ends up as four-character string "null")

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110

  • storage/IDBFactory.idl: remove ConvertNullToNullString flag on name argument, let IDL code generator stringify null value to "null"
5:45 PM Changeset in webkit [89505] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Add a Position constructor that takes (Text*, unsigned offset)
https://bugs.webkit.org/show_bug.cgi?id=63181

Added Position::Position(PassRefPtr<Text*>, unsigned offset) and deployed in a couple of places
by replacing the calls to the old constructor.

  • dom/Position.cpp: (WebCore::Position::Position): Added.
  • dom/Position.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceSelectedTextInNode): Calls new constructor; extracted from InsertTextCommand::performTrivialReplace and ReplaceSelectionCommand::performTrivialReplace. (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Calls new constructor
  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): Calls replaceSelectedTextInNode. (WebCore::InsertTextCommand::input): Calls new constructor. (WebCore::InsertTextCommand::insertTab): Use RefPtr instead of a raw pointer.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
  • editing/visible_units.cpp: (WebCore::startPositionForLine): Calls new constructor.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex): Calls new constructor; calls endPosition on Range instead of avoid manually constructing a VisiblePosition out of endContainer and endOffset.
5:39 PM Changeset in webkit [89504] by abarth@webkit.org
  • 10 edits in trunk/Source

2011-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831

  • dom/Document.cpp: (WebCore::Document::openSearchDescriptionURL):
    • This function exists to service a Chromium WebKit API, but it's generally purpose and might be useful to other ports. The algorithm has some strange early exits, which I've marked with FIXME comments.
  • dom/Document.h:

2011-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831

The next phase will be to change all the callers and then remove all
the code inside the ifdef.

  • public/WebDocument.h:
    • Add new APIs.
  • public/WebFrame.h:
    • These two APIs were too disgusting. I could not, in good conscience, touch them.
  • public/WebSecurityOrigin.h:
    • Turns out this API is supposed to be on WebSecurityOrigin, not WebDocument.
  • src/WebDocument.cpp:
    • Implement the APIs.

(WebKit::WebDocument::url):
(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::encoding):
(WebKit::WebDocument::openSearchDescriptionURL):
(WebKit::WebDocument::forms):
(WebKit::WebDocument::insertStyleText):

  • src/WebFrameImpl.cpp:
    • Change these implements to just be stubs that call into the real implementations in WebDocument.

(WebKit::WebFrameImpl::url):
(WebKit::WebFrameImpl::openSearchDescriptionURL):
(WebKit::WebFrameImpl::encoding):
(WebKit::WebFrameImpl::forms):
(WebKit::WebFrameImpl::securityOrigin):
(WebKit::WebFrameImpl::grantUniversalAccess):
(WebKit::WebFrameImpl::insertStyleText):
(WebKit::WebFrameImpl::contentAsMarkup):

  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::grantUniversalAccess):
5:28 PM Changeset in webkit [89503] by Nate Chapin
  • 27 edits
    1 delete in trunk

2011-06-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Add symbols required for window.internals.
https://bugs.webkit.org/show_bug.cgi?id=62066

  • Source/autotools/symbols.filter:

2011-06-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066.

  • fast/preloader/scan-body-from-head-import.html: Use window.internals.
  • fast/preloader/scan-body-from-head-script.html: Use window.internals.
  • http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
  • http/tests/loading/cross-origin-XHR-willLoadRequest.html:
  • http/tests/loading/preload-append-scan-expected.txt:
  • http/tests/loading/preload-append-scan.php: Use window.internals.
  • http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt:
  • http/tests/misc/link-rel-icon-beforeload-expected.txt:
  • platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt: Removed.

2011-06-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Don't let all subresources keep isLoadingInAPISense() from
returning false, only requests that affect
CachedResourceRequest::requestCount().

Also, add a callback to Internals to determine whether
a resource has been preloaded.

https://bugs.webkit.org/show_bug.cgi?id=62066

  • WebCore.exp.in:
  • dom/Document.cpp: Add m_loadEventFinished.
  • dom/Document.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::isPreloaded):
  • loader/cache/CachedResourceLoader.h:
  • testing/Internals.cpp: (WebCore::Internals::isPreloaded):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-06-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Add win symbols for new window.internals functionality.
https://bugs.webkit.org/show_bug.cgi?id=62066

  • win/WebKit2.def:

2011-06-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Add libsoup to libWebCoreInternals build.
https://bugs.webkit.org/show_bug.cgi?id=62066

  • GNUmakefile.am:
5:18 PM Changeset in webkit [89502] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027

We had reverted the change in r89414, so this adds it back in
(modifying check_sys_deps() in port/base.py to check for an
installed web server).

This change then fixes the change in r89414 to stub out the
check_sys_deps() in the test port so that the unit tests run correctly.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
5:17 PM Changeset in webkit [89501] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Roll out r89469 (Add preference for setting the html parser depth limit)

The preference is not needed at this time, so there is no reason to expose it.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

5:16 PM Changeset in webkit [89500] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in
r88679.
https://bugs.webkit.org/show_bug.cgi?id=63205

Add expected failing result in order to get the bots green.

  • platform/mac-wk2/plugins: Added.
  • platform/mac-wk2/plugins/npruntime: Added.
  • platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
5:01 PM Changeset in webkit [89499] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-22 Chris Rogers <crogers@google.com>

Reviewed by David Levin.

Use create() method for AsyncAudioDecoder::DecodingTask
https://bugs.webkit.org/show_bug.cgi?id=63198

No new tests. This doesn't change any JS API.

  • webaudio/AsyncAudioDecoder.cpp: (WebCore::AsyncAudioDecoder::decodeAsync): (WebCore::AsyncAudioDecoder::DecodingTask::create):
  • webaudio/AsyncAudioDecoder.h:
4:57 PM Changeset in webkit [89498] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Ojan Vafai <ojan@chromium.org>

Update listing for perf tests to list each individual test.
A number of the tests in this directory are not flaky.

  • platform/chromium/test_expectations.txt:
4:56 PM Changeset in webkit [89497] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-06-22 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
https://bugs.webkit.org/show_bug.cgi?id=63188

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
4:55 PM Changeset in webkit [89496] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203

Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).

  • wtf/Platform.h:

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203

Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • loader/cache/CachedFont.cpp:
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203

Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebCommon.h:
4:53 PM Changeset in webkit [89495] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-22 Luke Macpherson <macpherson@chromium.org>

Reviewed by James Robinson.

Remove comment that snuck in via copy & paste.
https://bugs.webkit.org/show_bug.cgi?id=63177

No new tests / no code changes.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator short): Removed incorrect comment.
4:51 PM Changeset in webkit [89494] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, baseline for a new test added in http://trac.webkit.org/changeset/89490

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
4:43 PM Changeset in webkit [89493] by dimich@chromium.org
  • 4 edits
    1 add in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/

  • platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png:
4:18 PM Changeset in webkit [89492] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-06-22 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594

Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
and places the cursor in the correct position.

  • editing/inserting/return-key-before-br-in-span-expected.txt: Added.
  • editing/inserting/return-key-before-br-in-span.html: Added.
  • editing/inserting/return-key-middle-of-span-expected.txt: Added.
  • editing/inserting/return-key-middle-of-span.html: Added.

2011-06-22 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594

When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
split at to be at the end of a text node. The code assumes the position is at the start of the node, so
pass the correct node into splitTreeToNode() in that case.

Tests: editing/inserting/return-key-before-br-in-span.html

editing/inserting/return-key-middle-of-span.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
4:09 PM Changeset in webkit [89491] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2
Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
3:42 PM Changeset in webkit [89490] by rwlbuis@webkit.org
  • 5 edits
    5 adds in trunk

2011-06-22 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109

  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg: Added.
  • svg/custom/pointer-events-invalid-fill-expected.txt: Added.
  • svg/custom/pointer-events-invalid-fill.svg: Added.

2011-06-22 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109

Properly detect fill/stroke properties of type SVG_PAINTTYPE_URI_NONE, store it in SVGPaint
and don't apply the paint if the uri lookup fails.

Tests: svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg

svg/custom/pointer-events-invalid-fill.svg

  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • rendering/svg/RenderSVGResource.cpp: (WebCore::requestPaintingResource):
  • svg/SVGPaint.h: (WebCore::SVGPaint::createURIAndNone):
3:35 PM Changeset in webkit [89489] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-22 Cary Clark <caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-22 Cary Clark <caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-22 Cary Clark <caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
3:28 PM Changeset in webkit [89488] by mdelaney@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Adam Roben.

Setting expected results for platform/win
https://bugs.webkit.org/show_bug.cgi?id=63190

  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
3:27 PM Changeset in webkit [89487] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows expected results for some new tests from r87779

These differ from Mac due to some small rounding differences in a path.

  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
3:12 PM Changeset in webkit [89486] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-06-22 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62891

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:07 PM Changeset in webkit [89485] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some flaky animation tests on Windows

See <http://webkit.org/b/62561> and <http://webkit.org/b/62569>.

  • platform/win/Skipped: Added animations/animation-direction-normal.html and

animations/play-state-paused.html.

3:02 PM Changeset in webkit [89484] by Adam Roben
  • 5 edits
    7 moves in trunk/LayoutTests

Disable zoom-svg-through-object-with-*.xhtml

These tests are flaky. See <http://webkit.org/b/63186>.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

Removed mentions of these tests.

  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml.
2:52 PM Changeset in webkit [89483] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: don't look for http lock when running the test port
https://bugs.webkit.org/show_bug.cgi?id=63158

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
2:40 PM Changeset in webkit [89482] by kbalazs@webkit.org
  • 6 edits in trunk

2011-06-22 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066

  • platform/qt-wk2/Skipped: Unskip passing plugin tests and create a new group for those that still fail for some reason.

2011-06-22 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Force windowless mode for the test plugin because we don't support windowed plugins yet.

2011-06-22 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::initializeTestPluginDirectory): Use the QTWEBKIT_PLUGIN_PATH environment variable as the path of the test plugin like DRT does.
2:38 PM Changeset in webkit [89481] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197

Add more tests that use layoutTestController.overridePreference to the WK2 Skipped list.

  • platform/mac-wk2/Skipped:
2:33 PM Changeset in webkit [89480] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107

It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
into urls myself. So I have now fixed its "preparing" message to include a url.

I also figured that I should make the messages mention all of the responsible parties
so that rollouts are never surprises. If you're in the channel and were involved
in a patch, you will see if someone is using sheriff-bot to rollout a patch.

As part of doing this I also changed (and tested) _parse_args to fail-fast
when given invalid args.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2:23 PM Changeset in webkit [89479] by commit-queue@webkit.org
  • 5 edits in trunk

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114

  • storage/indexeddb/mozilla/create-index-null-name-expected.txt:
  • storage/indexeddb/mozilla/create-index-null-name.html:

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114

  • storage/IDBObjectStore.idl: remove ConvertNullToNullString flag so null values will be stringified as "null", as per WebIDL spec.
2:14 PM Changeset in webkit [89478] by crogers@google.com
  • 7 edits
    4 adds in trunk/Source/WebCore

2011-06-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

AudioContext needs non-blocking call to create AudioBuffer from audio file data
https://bugs.webkit.org/show_bug.cgi?id=61947

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • webaudio/AsyncAudioDecoder.cpp: Added. (WebCore::AsyncAudioDecoder::AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::decodeAsync): (WebCore::AsyncAudioDecoder::threadEntry): (WebCore::AsyncAudioDecoder::runLoop): (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask): (WebCore::AsyncAudioDecoder::DecodingTask::decode): (WebCore::AsyncAudioDecoder::DecodingTask::notifyCompleteDispatch): (WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete):
  • webaudio/AsyncAudioDecoder.h: Added. (WebCore::AsyncAudioDecoder::DecodingTask::audioData): (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate): (WebCore::AsyncAudioDecoder::DecodingTask::successCallback): (WebCore::AsyncAudioDecoder::DecodingTask::errorCallback): (WebCore::AsyncAudioDecoder::DecodingTask::audioBuffer):
  • webaudio/AudioBufferCallback.h: Added. (WebCore::AudioBufferCallback::~AudioBufferCallback):
  • webaudio/AudioBufferCallback.idl: Added.
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::decodeAudioData):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
1:55 PM Changeset in webkit [89477] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
SnowLeopard Intel Release (Tests), Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63178

Add failing expected results in order to get the bots green.

  • platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
1:44 PM Changeset in webkit [89476] by tony@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-06-22 Tony Chang <tony@chromium.org>

Add test that got renamed. Should have been included with r89466.

  • storage/indexeddb/keypath-basics.html: Renamed from LayoutTests/storage/indexeddb/keypath-as-array.html.
1:43 PM Changeset in webkit [89475] by bdakin@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=63174
Don't draw the borders as one path unless there really are 4 borders
-and corresponding-
<rdar://problem/9457997>

Reviewed by Simon Fraser.

Source/WebCore:

If any of the border edges have no width, then allEdgesVisible should be set to
false since borders without width will not be visible.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

  • fast/borders/only-one-border-with-width.html: Added.
  • platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
1:39 PM Changeset in webkit [89474] by mdelaney@apple.com
  • 3 edits
    4 adds in trunk

2011-06-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161

Test: compositing/layer-creation/spanOverlapsCanvas.html

  • rendering/RenderLayer.cpp: Added checks for canvas to be layered properly. (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):

2011-06-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161

  • compositing/layer-creation/spanOverlapsCanvas.html: Added.
  • platform/mac/compositing/layer-creation: Added.
  • platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
1:35 PM Changeset in webkit [89473] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
SnowLeopard Intel Release (Tests) and Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63175

Add platform-specific results to in order to get the bots green.

  • platform/mac/inspector/console: Added.
  • platform/mac/inspector/console/console-trace-in-eval-expected.txt: Added.
1:29 PM Changeset in webkit [89472] by ggaren@apple.com
  • 9 edits in trunk/Source

Source/JavaScriptCore: * interpreter/RegisterFile.h: Removed unnecessary #include <stdio.h>.

Reviewed by Oliver Hunt.

Source/WebKit2: Removed unnecessary #include <stdio.h>.

Reviewed by Oliver Hunt.

  • PluginProcess/mac/PluginProcessMainMac.mm:
  • Shared/WebMemorySampler.cpp:
  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
  • WebProcess/mac/WebProcessMac.mm: Added #include back to places where it

was needed.

1:17 PM Changeset in webkit [89471] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

AudioContext noteGrainOn() method should not apply explicit windowing
https://bugs.webkit.org/show_bug.cgi?id=63005

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::readFromBuffer):
  • webaudio/AudioBufferSourceNode.h:
1:15 PM Changeset in webkit [89470] by jamesr@google.com
  • 18 edits
    48 deletes in branches/chromium/782

Revert 87526 - 2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
  • http/tests/misc/resources/embedded.svg: Added.
  • http/tests/misc/resources/svg-slow.pl: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • svg/custom/object-no-size-attributes.xhtml: Added.
  • svg/custom/object-sizing-explicit-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width.xhtml: Added.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
  • svg/custom/object-sizing-no-width-height.xhtml: Added.
  • svg/custom/object-sizing.xhtml: Added.
  • svg/custom/resources/embedded.svg: Added.
  • svg/custom/resources/red-circle.svg: Added.
  • svg/in-html/by-reference-expected.png:
  • svg/wicd: Added.
  • svg/wicd/resources: Added.
  • svg/wicd/resources/a.svg: Added.
  • svg/wicd/resources/bcde.svg: Added.
  • svg/wicd/resources/empty1.svg: Added.
  • svg/wicd/resources/empty2.svg: Added.
  • svg/wicd/resources/empty3.svg: Added.
  • svg/wicd/resources/f.svg: Added.
  • svg/wicd/resources/g.svg: Added.
  • svg/wicd/resources/h.svg: Added.
  • svg/wicd/resources/i.svg: Added.
  • svg/wicd/resources/j.svg: Added.
  • svg/wicd/resources/k.svg: Added.
  • svg/wicd/resources/l.svg: Added.
  • svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
  • svg/wicd/resources/mnop.svg: Added.
  • svg/wicd/resources/q.svg: Added.
  • svg/wicd/resources/r.svg: Added.
  • svg/wicd/resources/s.svg: Added.
  • svg/wicd/resources/t.svg: Added.
  • svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
  • svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
  • svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
  • svg/wicd/rightsizing-grid.xhtml: Added.
  • svg/wicd/test-rightsizing-a.xhtml: Added.
  • svg/wicd/test-rightsizing-b.xhtml: Added.
  • svg/zoom/page/resources: Added.
  • svg/zoom/page/resources/absolute-sized-svg.png: Added.
  • svg/zoom/page/resources/absolute-sized-svg.svg: Added.
  • svg/zoom/page/resources/huge-rect.svg: Added.
  • svg/zoom/page/resources/percentage-sized-svg.png: Added.
  • svg/zoom/page/resources/percentage-sized-svg.svg: Added.
  • svg/zoom/page/resources/text.svg: Added.
  • svg/zoom/page/resources/tux.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.

If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml

svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/Length.h: (WebCore::Length::isSpecified):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h:

BUG=86700
TBR=zimmermann@webkit.org

1:13 PM Changeset in webkit [89469] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit/mac

2011-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Add preference for setting the html parser depth limit
https://bugs.webkit.org/show_bug.cgi?id=63163

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]): (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]): Add private preference for setting the parser depth limit.
1:12 PM Changeset in webkit [89468] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=42331

Add another test that uses dumpFrameLoadCallbacks to the WK2 Skipped list.

  • platform/mac-wk2/Skipped:
1:11 PM Changeset in webkit [89467] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r89461.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformSetFocus):
Forgot to name the parameter, fix it.

1:09 PM Changeset in webkit [89466] by commit-queue@webkit.org
  • 5 edits
    1 add
    1 delete in trunk

2011-06-22 Kentaro Hara <haraken@google.com>

Reviewed by Tony Chang.

Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054

At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.

  • storage/indexeddb/keypath-as-array-expected.txt: Removed.
  • storage/indexeddb/keypath-as-array.html: Removed.
  • storage/indexeddb/keypath-basics-expected.txt: Added.
  • storage/indexeddb/keypath-basics.html: Added.

2011-06-22 Kentaro Hara <haraken@google.com>

Reviewed by Tony Chang.

Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054

At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.

Tests: storage/indexeddb/keypath-basics.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBKeyPath.cpp: (WebCore::IDBIsValidKeyPath):
  • storage/IDBKeyPath.h:
1:07 PM Changeset in webkit [89465] by ggaren@apple.com
  • 12 edits in trunk

Removed the conceit that global variables are local variables when running global code
https://bugs.webkit.org/show_bug.cgi?id=63106

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is required for write barrier correctness.

SunSpider reports about a 0.5% regression, mostly from bitops-bitwise-and.js.
I was able to reduce the regression with a tiny peephole optimization in
the bytecompiler, but not eliminate it. I'm committing this assuming
that turning on generational GC will win back at least 0.5%.

(FWIW, the DFG JIT can easily eliminate any regression by sharing loads of
the global object's var storage. I considered doing the same kind of
optimization in the existing JIT, but it seemed like moving in the wrong
direction.)

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator): Don't give global variables
negative indices, since they're no longer negatively offset from the
current stack frame.

Do give global variables monotonically increasing positive indices, since
that's much easier to work with.

Don't limit the number of optimizable global variables, since it's no
longer limited by the register file, since they're no longer stored in
the register file.

(JSC::BytecodeGenerator::registerFor): Global code never has any local
registers because a var in global code is actually a property of the
global object.

(JSC::BytecodeGenerator::constRegisterFor): Ditto.

(JSC::BytecodeGenerator::emitResolve): Did a tiny bit of constant
propagation and dead code elimination to speed up our compiles and
reduce WTFs / minute.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::registerFor): Removed special handling of globals.

(JSC::BytecodeGenerator::shouldOptimizeLocals): Don't optimize locals in
global code, since there are none.

(JSC::BytecodeGenerator::canOptimizeNonLocals): Do optimize non-locals
in global code (i.e., global vars), since there are some.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):

  • interpreter/Interpreter.h: Updated for deleted / renamed code.
  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):
(JSC::RegisterFile::releaseExcessCapacity): Updated for deleted / renamed
data members.

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::begin):
(JSC::RegisterFile::size):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink): Removed all code and comments dealing with
global variables stored in the register file.

(JSC::RegisterFile::grow): Updated for same.

Also, a slight correctness fix: Test the VM commit end, and not just the
in-use end, when checking for stack overflow. In theory, it's invalid to
commit past the end of your allocation, even if you never touch that
memory. This makes the usable size of the stack slightly smaller. No test
because we don't know of any case in practice where this crashes.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Updated for changes above.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::resizeRegisters):
(JSC::JSGlobalObject::addStaticGlobals):

  • runtime/JSGlobalObject.h: Simplified globals to have monotonically

increasing indexes, always located in our external storage.

LayoutTests:

  • fast/js/recursion-limit-equal-expected.txt: Updated to reflect slightly

changed recursion limit.

1:06 PM Changeset in webkit [89464] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing
on SnowLeopard Intel Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63169

Add (failing?) expected results to get the bots green.

  • platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added.
1:04 PM Changeset in webkit [89463] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Added.
  • platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Added.
12:57 PM Changeset in webkit [89462] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-22 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303

When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.

The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.

  • animations/multiple-animations-timing-function-expected.txt: Added.
  • animations/multiple-animations-timing-function.html: Added.

2011-06-22 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303

When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.

The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.

Test: animations/multiple-animations-timing-function.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::getAnimationFromStyleByName): (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
12:55 PM Changeset in webkit [89461] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-22 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Darin Adler.

[X11][WK2] Implement NetscapePlugin::platformSetFocus
https://bugs.webkit.org/show_bug.cgi?id=63154

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformSetFocus): Implement focus setting based on the WebKit1 path.
12:55 PM Changeset in webkit [89460] by commit-queue@webkit.org
  • 86 edits
    1 delete in trunk

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89407, r89409, r89410, and r89411.
http://trac.webkit.org/changeset/89407
http://trac.webkit.org/changeset/89409
http://trac.webkit.org/changeset/89410
http://trac.webkit.org/changeset/89411
https://bugs.webkit.org/show_bug.cgi?id=63168

Broke Chromium tests for Forms and Autofill (Requested by
dimich on #webkit).

  • fast/css/text-input-with-webkit-border-radius-expected.txt:
  • fast/forms/search-abs-pos-cancel-button.html:
  • fast/forms/search-cancel-button-mouseup.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/placeholder-set-value-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/win/media/media-controls-clone-expected.txt: Removed.

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89407, r89409, r89410, and r89411.
http://trac.webkit.org/changeset/89407
http://trac.webkit.org/changeset/89409
http://trac.webkit.org/changeset/89410
http://trac.webkit.org/changeset/89411
https://bugs.webkit.org/show_bug.cgi?id=63168

Broke Chromium tests for Forms and Autofill (Requested by
dimich on #webkit).

  • css/html.css: (input[type="search"]::-webkit-search-cancel-button): (input[type="search"]::-webkit-search-decoration): (input[type="search"]::-webkit-search-results-decoration): (input[type="search"]::-webkit-search-results-button): (input::-webkit-inner-spin-button): (input::-webkit-input-speech-button):
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/InputType.h:
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): (WebCore::SearchInputType::createShadowSubtree): (WebCore::SearchInputType::destroyShadowSubtree):
  • html/SearchInputType.h: (WebCore::SearchInputType::innerBlockElement):
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::destroyShadowSubtree):
  • html/TextFieldInputType.h: (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::innerTextElement): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
  • rendering/RenderTextControlSingleLine.h:
12:52 PM Changeset in webkit [89459] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-06-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

run-webkit-websocketserver fails to stop websocket server
https://bugs.webkit.org/show_bug.cgi?id=63123

There's a ten-character change in new-run-webkit-websocketserver
that fixes the actual bug, and then we update the code in
new-run-webkit-httpd to do the actual stop call, and add more tests
(refactoring the existing test code so that it is shared).

  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
12:47 PM Changeset in webkit [89458] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit/efl

2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=63125

Add dummy files to build with ENABLE_DEVICE_ORIENTATION.

  • WebCoreSupport/DeviceMotionClientEfl.cpp: Added. (WebCore::DeviceMotionClientEfl::DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::~DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientEfl::setController): (WebCore::DeviceMotionClientEfl::startUpdating): (WebCore::DeviceMotionClientEfl::stopUpdating): (WebCore::DeviceMotionClientEfl::currentDeviceMotion):
  • WebCoreSupport/DeviceMotionClientEfl.h: Added.
  • WebCoreSupport/DeviceOrientationClientEfl.cpp: Added. (WebCore::DeviceOrientationClientEfl::DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::~DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientEfl::setController): (WebCore::DeviceOrientationClientEfl::startUpdating): (WebCore::DeviceOrientationClientEfl::stopUpdating): (WebCore::DeviceOrientationClientEfl::lastOrientation):
  • WebCoreSupport/DeviceOrientationClientEfl.h: Added.
12:39 PM Changeset in webkit [89457] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Improve speed of heap profiles dominators view.
https://bugs.webkit.org/show_bug.cgi?id=62979

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice.prototype.item): (WebInspector.HeapSnapshotArraySlice.prototype.slice): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode): (WebInspector.HeapSnapshot.prototype._buildReverseIndex.var): (WebInspector.HeapSnapshot.prototype._buildReverseIndex): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshot.prototype._buildDominatedNodes): (WebInspector.HeapSnapshot.prototype._getDominatedIndex): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): (WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get length): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotNodesProvider):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
12:26 PM Changeset in webkit [89456] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-22 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Restore console messages when restoring inspector state
https://bugs.webkit.org/show_bug.cgi?id=63146

No new tests (no change in functionality, only in display).

  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::restore):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
12:10 PM WikiStart edited by rniwa@webkit.org
Added an entry for WebAPIReviewChecklist (diff)
12:09 PM WebAPIReviewChecklist edited by rniwa@webkit.org
(diff)
12:07 PM WebAPIReviewChecklist created by rniwa@webkit.org
Add WebAPIReviewChecklist
12:02 PM Changeset in webkit [89455] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-22 Adam Barth <abarth@webkit.org>

Attempt to fix the GTK build after my incomplete rollout of 88332.

  • GNUmakefile.list.am:
11:57 AM Changeset in webkit [89454] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

2011-06-22 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Holger Freyther.

[Qt] Fix Qt namespace on QDeclarativeWebView autotest
https://bugs.webkit.org/show_bug.cgi?id=63147

Applications (such as the test runner) are not supposed to be wrapped
by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
QtWebKit) with a specific namespace won't work (will result in main
being undefined).

This was the only test wrapped by these macros, all others are fine.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove namespace macros.
11:26 AM Changeset in webkit [89453] by weinig@apple.com
  • 14 edits in trunk

2011-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

HTML parser should limit element depth of produced tree
https://bugs.webkit.org/show_bug.cgi?id=63082

Test by:

fast/parser/block-nesting-cap.html
fast/parser/element-nesting-cap.html

  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::HTMLConstructionSite):
  • html/parser/HTMLConstructionSite.h: Limit the DOM tree depth by turning attempts to add a child passed a certain threshold (configurable by Settings::maximumDOMTreeDepth) into a sibling.
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::maximumDOMTreeDepth):
  • html/parser/HTMLDocumentParser.h: Pass the maximumDOMTreeDepth to the TreeBuilder.
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonTopCommon):
  • html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::size): Keep track of the size of the element stack.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create): Pass the maximumDOMTreeDepth to the construction site.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setMaximumHTMLParserDOMTreeDepth): (WebCore::Settings::maximumHTMLParserDOMTreeDepth): Add a setting to control the maximum DOM tree depth that the parser will produce.

2011-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

HTML parser should limit element depth of produced tree
https://bugs.webkit.org/show_bug.cgi?id=63082

  • fast/parser/block-nesting-cap-expected.txt:
  • fast/parser/element-nesting-cap-expected.txt: Update expectations for new parser depth limit.
11:12 AM Changeset in webkit [89452] by abarth@webkit.org
  • 27 edits
    9 deletes in trunk

2011-06-22 Adam Barth <abarth@webkit.org>

Rollout 88332.

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebRuntimeFeatures.cpp:

2011-06-22 Adam Barth <abarth@webkit.org>

Rollout 88332. As discussed on webkit-dev, we'd like to iterate on
both the API and it's implementation a bit.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::activeMatch):
  • dom/DocumentMarkerController.cpp:
  • dom/DocumentMarkerController.h:
  • html/HTMLDivElement.cpp:
  • html/HTMLDivElement.h:
  • html/HTMLDivElement.idl:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.idl:
  • html/SpellcheckRange.cpp: Removed.
  • html/SpellcheckRange.h: Removed.
  • html/SpellcheckRange.idl: Removed.
  • html/SpellcheckRangeList.cpp: Removed.
  • html/SpellcheckRangeList.h: Removed.
  • html/SpellcheckRangeList.idl: Removed.
  • rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): (WebCore::InlineTextBox::paintDocumentMarkers):

2011-06-22 Adam Barth <abarth@webkit.org>

Rollout 88332.

  • editing/spelling/spellcheck-api-expected.txt: Removed.
  • editing/spelling/spellcheck-api-pixel.html: Removed.
  • editing/spelling/spellcheck-api.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:03 AM Changeset in webkit [89451] by commit-queue@webkit.org
  • 13 edits
    12 copies in trunk

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: fix multiple issues in IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=63140

  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt: Added.
  • storage/indexeddb/createObjectStore-name-argument-required.html: Added.
  • storage/indexeddb/createObjectStore-null-name-expected.txt: Added.
  • storage/indexeddb/createObjectStore-null-name.html: Added.
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt: Added.
  • storage/indexeddb/deleteObjectStore-name-argument-required.html: Added.
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt: Added.
  • storage/indexeddb/deleteObjectStore-null-name.html: Added.
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/setVersion-null-expected.txt: Added.
  • storage/indexeddb/setVersion-null.html: Added.
  • storage/indexeddb/setVersion-undefined-expected.txt:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-storeNames-required-expected.txt: Added.
  • storage/indexeddb/transaction-storeNames-required.html: Added.

2011-06-22 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: fix multiple issues in IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=63140

Tests: storage/indexeddb/createObjectStore-name-argument-required.html

storage/indexeddb/createObjectStore-null-name.html
storage/indexeddb/deleteObjectStore-name-argument-required.html
storage/indexeddb/deleteObjectStore-null-name.html
storage/indexeddb/setVersion-null.html
storage/indexeddb/transaction-storeNames-required.html

  • storage/IDBDatabase.idl: remove LegacyDefaultOptionalArguments so all functions will throw TypeError when called with too few arguments, as per WebIDL spec. Also remove ConvertNullToNullString flags so null values are stringified as "null" (also as per WebIDL spec).
10:53 AM Changeset in webkit [89450] by mdelaney@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Adding a mac platform expected result for webgl test to help fix burning bot.
Filed https://bugs.webkit.org/show_bug.cgi?id=63151 for a real fix

  • platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Added.
10:51 AM Changeset in webkit [89449] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-22 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
10:42 AM Changeset in webkit [89448] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-22 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.
https://bugs.webkit.org/show_bug.cgi?id=62964

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h: Support cast to/from short.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to short to allow CSSPropertWidows and CSSPropertyOrphans to use existing macro.
10:27 AM Changeset in webkit [89447] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Add links to existing bugs related to failing tests on TestFailures page

I changed the layout of the page a little to make it easier to read with all the new
information. Passing/failing revisions have been moved down below the list of tests to be
closer to the existing bugs and the new bug link. And each set of tests and its relevant
information is in a light gray box.

Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
possible

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.

(Bugzilla): This new class represents a single Bugzilla instance.
(Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
passing the resulting bug titles and URLs to the callback when complete. If called multiple
times with the same query before the query returns, caches the callbacks so that only one
query is sent over the wire. When the query completes, all pending callbacks are called.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history): Reduce the margin/padding on the top-level list a bit.
(#failure-history > li): Put each set of tests in a gray box, and indent most information
inside the box.
(.test-list): Unindent the list of failing tests so it is visually at the top level.
(.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
each box isn't a big empty space.
(.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
quite long.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(addQueryParametersToURL): New function extracted from
ViewController.prototype._domForNewAndExistingBugs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Take and store an optional Bugzilla instance.
(ViewController.prototype._displayBuilder): Give the top-level list an id for styling
purposes and move the list of failing tests above all other information. Only show bug
information once we've determined the most-recent passing revision for a set of tests. It's
not that useful to file a new bug before this information has been determined, and searching
for existing bugs before we've figured out which tests started failing at the same time
would end up giving you information about a bunch of unrelated tests.
(ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
failing tests, and adds links to the bugs when the search completes.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a

Bugzilla instance for bugs.webkit.org to the ViewController.

10:19 AM Changeset in webkit [89446] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-22 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline
https://bugs.webkit.org/show_bug.cgi?id=23753

The bug got fixed, so landing the test case.

  • fast/dom/legend-display-inline-expected.txt: Added.
  • fast/dom/legend-display-inline.html: Added.
10:17 AM Changeset in webkit [89445] by jchaffraix@webkit.org
  • 3 edits
    2 copies in branches/chromium/782

Merge 89183 - 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884

  • svg/custom/assert-empty-layout-attributes-expected.txt: Added.
  • svg/custom/assert-empty-layout-attributes.svg: Added.

2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884

Test: svg/custom/assert-empty-layout-attributes.svg

  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here. It is not needed to do the text layout algorithm if you don't have any layout information as your size is (0, 0) anyway.

TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/7231014

10:14 AM Changeset in webkit [89444] by mdelaney@apple.com
  • 2 edits in trunk/LayoutTests

Undoing possibly incorrect rebaseline from r89434 for webgl test. Filed follow up bug.

10:13 AM Changeset in webkit [89443] by jchaffraix@webkit.org
  • 3 edits
    2 copies in branches/chromium/782

Merge 88474 - 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

  • fast/css/webkit-keyframes-crash-expected.txt: Added.
  • fast/css/webkit-keyframes-crash.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

Test: fast/css/webkit-keyframes-crash.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.

TBR=jchaffraix@webkit.org
Review URL: http://codereview.chromium.org/7231013

9:57 AM Changeset in webkit [89442] by commit-queue@webkit.org
  • 10 edits
    1 move
    1 add in trunk/Source

2011-06-22 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Martin Robinson.

Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62848

This patch will make GtkWidgetBackingStore shareable with EFL port.
It is a preparation to integrate WebKit2's BackingStoreGtk.cpp and
BackingStoreEfl.cpp as a BackingStoreCairo.cpp.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyRectFromOneSurfaceToAnother):
  • platform/graphics/cairo/CairoUtilities.h:
  • platform/cairo/WidgetBackingStore.h: Added.
  • platform/gtk/GtkWidgetBackingStore.h: Removed.
  • platform/gtk/GtkWidgetBackingStoreCairo.cpp: (WebCore::createSurfaceForBackingStore): (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll):
  • platform/gtk/GtkWidgetBackingStoreX11.cpp: (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::~WidgetBackingStorePrivate): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll):

2011-06-22 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Martin Robinson.

Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62848

Change GtkWidgetBackingStore to WidgetBackingStore in the BackingStore.h and
gtk/BackingStoreGtk.cpp.

  • UIProcess/BackingStore.h:
  • UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::incorporateUpdate):
9:46 AM Changeset in webkit [89441] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Update position, bounds and anchor point in GraphicsLayerCA all at once
https://bugs.webkit.org/show_bug.cgi?id=63148

Since position, bounds and anchor point are inter-dependent, avoid
redundant work by simply updating them all at the same time.

No behavior changes, so no new tests.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setPosition): (WebCore::GraphicsLayerCA::setAnchorPoint): (WebCore::GraphicsLayerCA::setSize): (WebCore::GraphicsLayerCA::setBoundsOrigin): (WebCore::GraphicsLayerCA::setAllowTiledLayer): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateGeometry): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  • platform/graphics/ca/GraphicsLayerCA.h:
9:45 AM Changeset in webkit [89440] by rniwa@webkit.org
  • 18 edits in trunk/Source

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Make instantiation of legacy editing position more explicit
https://bugs.webkit.org/show_bug.cgi?id=63037

Create new positions since we can't create a legacy editing position outside of WebCore anymore.

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.

2011-06-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Make instantiation of legacy editing position more explicit
https://bugs.webkit.org/show_bug.cgi?id=63037

Replaced the constructor of Position class that used to instantiate a legacy editing position
by a function called createLegacyEditingPosition.

  • WebCore.exp.in: Removed the constructor from the list.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData): Calls createLegacyEditingPosition.
  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): No longer uses Positions to instantiate a range.
  • dom/Position.cpp: (WebCore::Position::Position): New constructor takes LegacyEditingOffset, which can only be instantiated by createLegacyEditingPosition. (WebCore::Position::previous): Calls createLegacyEditingPosition. (WebCore::Position::next): Ditto. (WebCore::Position::upstream): Ditto. (WebCore::Position::downstream): Ditto.
  • dom/Position.h: Added new Position::LegacyEditingOffset class to hide the legacy constructor from the world. (WebCore::Position::LegacyEditingOffset::value): Added. (WebCore::Position::LegacyEditingOffset::LegacyEditingOffset): Added. (WebCore::createLegacyEditingPosition): Added.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Calls createLegacyEditingPosition.
  • dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::toPosition): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): Instantiates new Position instead of old one; this is always safe since the anchor node is always a text node.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Calls createLegacyEditingPosition. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::renderedText): Ditto.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Ditto. (WebCore::previousLinePosition): Ditto. (WebCore::nextLinePosition): Ditto.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): Ditto. (WebCore::DOMSelection::setBaseAndExtent): Ditto. (WebCore::DOMSelection::setPosition): Ditto. (WebCore::DOMSelection::extend): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): Calls Position() instead of Position(0, 0).
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Calls createLegacyEditingPosition.s
9:24 AM Changeset in webkit [89439] by pfeldman@chromium.org
  • 8 edits in trunk

2011-06-22 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138

  • inspector/elements/set-attribute.html:
  • inspector/elements/set-attribute-expected.txt:

2011-06-22 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributeValue): (WebCore::InspectorDOMAgent::setAttributesText):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.setAttributeValue):
9:21 AM Changeset in webkit [89438] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Apply current view settings to newly created views in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63142

  • GtkLauncher/main.c: (createWebViewCb):
9:20 AM Changeset in webkit [89437] by mdelaney@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Added rev to ChangeLog for tree burning fix.

9:11 AM Changeset in webkit [89436] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't use an alpha channel when drawing the web page on Windows

We never use the alpha channel in the end anyway (because we never render into a layered
window, which is the only kind of window that supports alpha). And using an alpha channel is
tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
channel).

Fixes <http://webkit.org/b/63075> <rdar://problem/9648113> REGRESSION (r88978): Text inside
form controls looks really awful on Windows XP

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp:

(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
to the GraphicsContext constructor.

9:03 AM Changeset in webkit [89435] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-06-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

video-loop.html sometimes fails on slow system
https://bugs.webkit.org/show_bug.cgi?id=63143

  • media/video-loop.html: Don't seek if an exception will be generated.
8:57 AM Changeset in webkit [89434] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

Fixing burning mac SL trees. These tests's expected results needed
updating after parts of them were fixed recently.

8:44 AM Changeset in webkit [89433] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination()
https://bugs.webkit.org/show_bug.cgi?id=61627

Don't use Connection::setShouldCloseConnectionOnProcessTermination() for the
GTK port, when the process finishes the connection is closed and
the other process is already notified. We still need to monitor
the child process so that it doesn't become a zombie when it dntabi

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::childFinishedFunction): (WebKit::ProcessLauncher::launchProcess):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching):
8:27 AM Changeset in webkit [89432] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use GOption to parse main arguments in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63060

Instead of getting the settings from the view, create a new
settings object not associated with any view so that we can parse
the command line arguments before creating the view. It will also
allows to use the same settings for more than one view if we
eventually support passing more than one uri from the command
line.

  • GtkLauncher/main.c: (parseOptionEntryCallback): Make this function static. Also use g_ascii_strtoll/g_ascii_strtod to parse int/float values instead of atoi/atof to provide better error messages. And always fill the error struct when the function fails. (getOptionEntriesFromWebKitWebSettings): Use an array of GOptionEntry structs instead of a GArray, since that is what g_option_group_add_entries() expects and the array size doesn't change. (addWebSettingsGroupToContext): Helper function to add the websettings group to the option context. (main): Create the option context to parse command line arguments.
8:24 AM Changeset in webkit [89431] by krit@webkit.org
  • 16 edits
    7 adds in trunk

2011-06-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Animate viewBox attribute in SVG
https://bugs.webkit.org/show_bug.cgi?id=20057

Test SVGRect animation with from-to and from-by animations.

  • svg/animations/script-tests/svgrect-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgrect-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgrect-animation-1-expected.txt: Added.
  • svg/animations/svgrect-animation-1.html: Added.
  • svg/animations/svgrect-animation-2-expected.txt: Added.
  • svg/animations/svgrect-animation-2.html: Added.

2011-06-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Animate viewBox attribute in SVG
https://bugs.webkit.org/show_bug.cgi?id=20057

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGRect. With the new animator we support
interpolation between SVGRects. A feature that can be used to get smooth zooming animations for SVGs.


Added parseRect() to SVGParserUtilities for parsing Strings to FloatRects.

Tests: svg/animations/svgrect-animation-1.html

svg/animations/svgrect-animation-2.html

  • CMakeLists.txt: Added new file SVGAnimatedRect.cpp to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/FloatRect.h: Added new operators + and +=. (WebCore::operator+=): (WebCore::operator+):
  • svg/SVGAllInOne.cpp: Added SVGAnimatedRect.cpp for Win build.
  • svg/SVGAnimateElement.cpp: Handle AnimatedRect explicitly. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): Ditto. (WebCore::SVGAnimateElement::calculateAnimatedValue): Ditto. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
  • svg/SVGAnimatedRect.cpp: Added. The new Animator for SVGRect. (WebCore::SVGAnimatedRectAnimator::SVGAnimatedRectAnimator): (WebCore::SVGAnimatedRectAnimator::constructFromString): (WebCore::SVGAnimatedRectAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedRectAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedRectAnimator::calculateDistance):
  • svg/SVGAnimatedRect.h: (WebCore::SVGAnimatedRectAnimator::~SVGAnimatedRectAnimator):
  • svg/SVGAnimatedType.cpp: Support for FloatRect. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createRect): (WebCore::SVGAnimatedType::rect): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGParserUtilities.cpp: Parse String as FloatRect. (WebCore::parseRect):
  • svg/SVGParserUtilities.h:
7:38 AM Changeset in webkit [89430] by Dimitri Glazkov
  • 25 edits in trunk/Source

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

1) Introduce FileChooserSettings to decouple setting querying from
FileChooser. It's a simple copyable settings object, which allows us
to capture the settings atomically and treat them as discardable data.

2) Encapsulate lifetime management of FileChooser entirely in
FileChooserClient. It's now a "smart" client, and allows us to
completely remove FileChooser management concerns from a FileChooserClient
implementor.

3) Change creation of FileChooser to be on-demand, only when we actually
need to choose file.

4) Rearrange calling of dispatchFormControlChangeEvent to be at the end
of a function and remove "am-I-dead" checks that are now unnecessary.

5) Clean up directory upload code a bit, and make use of FileChooserSettings
to pass directory name.

Refactoring, covered by existing tests.

  • WebCore.exp.in: Removed unneeded export.
  • loader/EmptyClients.h: Removed now-unneded param. (WebCore::EmptyChromeClient::enumerateChosenDirectory): Ditto.
  • page/Chrome.cpp: (WebCore::Chrome::enumerateChosenDirectory): Ditto.
  • page/Chrome.h: Ditto.
  • page/ChromeClient.h: Ditto.
  • platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient): Added discarding of chooser. (WebCore::FileChooserClient::newFileChooser): Added. (WebCore::FileChooserClient::discardChooser): Added. (WebCore::FileChooser::FileChooser): Changed to use FileChooserSettings. (WebCore::FileChooser::create): Ditto. (WebCore::FileChooser::~FileChooser): Removed unneeded code. (WebCore::FileChooser::chooseFiles): Changed to pass results to the client.
  • platform/FileChooser.h: (WebCore::FileChooser::settings): Added.
  • rendering/RenderFileUploadControl.cpp: (WebCore::filenamesFromFileList): Added a helper. (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use the helper, removed

chooser initialization code.

(WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed disconnection code, now

handled in FileChooserClient.

(WebCore::RenderFileUploadControl::filesChosen): Renamed from valueChanged, rearranged to

fire dispatchFormControlChangeEvent last.

(WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): Changed to use settings.
(WebCore::RenderFileUploadControl::click): Ditto.
(WebCore::RenderFileUploadControl::updateFromElement): Removed now-unneeded check.
(WebCore::RenderFileUploadControl::receiveDroppedFiles): Changed to avoid using the chooser, since

it is not necessary.

(WebCore::RenderFileUploadControl::fileTextValue): Changed to use input data, not chooser data.

  • rendering/RenderFileUploadControl.h: Updated decls.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel): Changed to use settings. (WebKit::ChromeClientImpl::enumerateChosenDirectory): Updated decls.
  • src/ChromeClientImpl.h:

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel): Changed to use settings.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel): Changed to use settings.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): Changed to use settings.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): Changed to use settings.

2011-06-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::runOpenPanel): Changed to use settings.
7:13 AM Changeset in webkit [89429] by pfeldman@chromium.org
  • 14 edits in trunk/Source/WebCore

2011-06-22 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: DOMAgent.resolveNode should receive objectGroup.
https://bugs.webkit.org/show_bug.cgi?id=63137

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapNode):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resume):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (.): ():
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
7:08 AM Changeset in webkit [89428] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix exceptions in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62865

Resource.requestContent callback may be fired after navigation when scripts panel
is already reset.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged): (WebInspector.DebuggerPresentationModel.prototype._addScript):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory): (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.reload):
7:01 AM Changeset in webkit [89427] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Yuta Kitamura <yutak@chromium.org>

Unreviewed, apply a couple of Chromium test expectation changes to test_expectations.txt.

  • platform/chromium/test_expectations.txt:
6:49 AM Changeset in webkit [89426] by commit-queue@webkit.org
  • 11 edits
    1 copy
    1 move
    2 adds in trunk

2011-06-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242

  • GNUmakefile.am: Reference the new ImageDiff GNUmakefile.

2011-06-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242

  • GNUmakefile.am: Added new Cairo specific image handling files to the build.
  • Shared/API/c/cairo/WKImageCairo.cpp: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp. (WKImageCreateCairoSurface): Added (WKImageCreateFromCairoSurface): Added
  • Shared/API/c/cairo/WKImageCairo.h: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp.

2011-06-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] Implement pixel dump support for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=58242

  • DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
  • GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
  • Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
  • WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
  • WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent file so that we can share it across platforms. (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
  • WebKitTestRunner/TestInvocation.h: Updated method list.
  • WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
6:34 AM Changeset in webkit [89425] by msaboff@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-21 Michael Saboff <msaboff@apple.com>

Reviewed by Adam Roben.

REGRESSION (r88260): Assertion failure in FontCache::getCachedFontData when typing in Safari's address field
https://bugs.webkit.org/show_bug.cgi?id=63078

Added FontCachePurgePreventer in WebCore::WebCoreTextFloatWidth to handle
assertion failure when typing in address field on windows. Investigated
other possible code paths that need purge prevention. Added
FontCachePurgeProtection to WebCore::createDragImageForLink and
WebCore::doDrawTextAtPoint.

No change to functionality, therefore no new tests.

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageForLink):
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint): (WebCore::WebCoreTextFloatWidth):
5:31 AM Changeset in webkit [89424] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

A couple setTextAsOfLastFormControlChangeEvent tweaks
https://bugs.webkit.org/show_bug.cgi?id=63108

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): Use emptyString() instead of String("") because it is better style and faster.
  • html/HTMLFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent non-virtual so it actually gets inlined, since there are no overrides of it. Also make it take a const String& to avoid unnecessary reference count churn.
4:47 AM Changeset in webkit [89423] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific exprected results after r89367 and r89381.

  • platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-expected.png:
  • platform/qt/svg/custom/pointer-events-text-expected.txt:
4:25 AM Changeset in webkit [89422] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Yuta Kitamura <yutak@chromium.org>

Unreviewed, fix a syntax error in the last change in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
4:22 AM Changeset in webkit [89421] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89414.
http://trac.webkit.org/changeset/89414
https://bugs.webkit.org/show_bug.cgi?id=63130

It broke webkitpy tests (Requested by Ossy on #webkit).

  • Scripts/webkitpy/layout_tests/port/base.py:
4:15 AM Changeset in webkit [89420] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89402.
http://trac.webkit.org/changeset/89402
https://bugs.webkit.org/show_bug.cgi?id=63129

It made 6 tests crash (Requested by Ossy on #webkit).

  • dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
  • dom/DataTransferItem.h:
  • dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
  • dom/DataTransferItems.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
  • editing/CompositeEditCommand.h:
  • page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
  • page/WebKitAnimationList.h: (WebCore::WebKitAnimationList::create):
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
  • svg/graphics/filters/SVGFilterBuilder.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::Peer::create):
4:10 AM Changeset in webkit [89419] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89368.
http://trac.webkit.org/changeset/89368
https://bugs.webkit.org/show_bug.cgi?id=63128

It made http/tests/inspector/extensions-resources-
redirect.html crash (Requested by Ossy on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
3:52 AM Changeset in webkit [89418] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test expectations for tests started to fail since V8 3.4.5.1 roll.

  • platform/chromium/test_expectations.txt:
3:22 AM Changeset in webkit [89417] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
https://bugs.webkit.org/show_bug.cgi?id=63124

Fixes a crash when building with --enable-debug.

  • webkit/webkitsoupauthdialog.h: Define LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY before including libsoup.h.
3:16 AM Changeset in webkit [89416] by yutak@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

2011-06-22 Yuta Kitamura <yutak@chromium.org>

Unreviewed, check in new Chromium-Leopard baselines.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/pointer-events-text-expected.png: Added.
2:35 AM Changeset in webkit [89415] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use stack trace to create anchors for console messages.
https://bugs.webkit.org/show_bug.cgi?id=62856

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._completions.reportCompletions): (WebInspector.ConsoleView.prototype._completions): (WebInspector.ConsoleMessage.prototype._formatMessage):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createAnchor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.createAnchor): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._updateAnchor):
  • inspector/front-end/inspector.js: (WebInspector.linkifyResourceAsNode): (WebInspector.linkifyCallFrameAsNode):
1:22 AM Changeset in webkit [89414] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-22 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Dirk Pranke.

[NRWT] Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=62027

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
12:12 AM Changeset in webkit [89413] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-22 Dirk Pranke <dpranke@chromium.org>

Unreviewed, whitespace expectations change to trigger a round of
builds.

  • platform/chromium/test_expectations.txt:

Jun 21, 2011:

11:37 PM Changeset in webkit [89412] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-21 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.
Fix crashes in new-run-webkit-tests resulting from the
change to the http_server logic in r89400. Python 2.5
on Mac 10.5 has some weird error paths.

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/common/system/executive.py:
11:07 PM Changeset in webkit [89411] by tkent@chromium.org
  • 2 edits
    1 copy in trunk/LayoutTests

2011-06-21 Kent Tamura <tkent@chromium.org>

[Win][Mac] Correct an accidental change in r89410.

  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/win/media/media-controls-clone-expected.txt: Copied from LayoutTests/platform/mac/media/media-controls-clone-expected.txt.
10:43 PM Changeset in webkit [89410] by tkent@chromium.org
  • 30 edits in trunk/LayoutTests

2011-06-21 Kent Tamura <tkent@chromium.org>

[Win][GTK] Test expectation update for r89407.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
10:08 PM Changeset in webkit [89409] by tkent@chromium.org
  • 14 edits in trunk/LayoutTests

2011-06-21 Kent Tamura <tkent@chromium.org>

[Qt] Test expectation update for r89407.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/placeholder-set-value-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
10:03 PM Changeset in webkit [89408] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectation for some speech tests.

  • platform/chromium/test_expectations.txt:
9:36 PM Changeset in webkit [89407] by tkent@chromium.org
  • 45 edits in trunk

2011-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

Update tests including <input type=search> or <input type=number>. Their
internal structures are changed.
Slight position changes for search result buttons and search cancel
buttons are expected.

  • fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • fast/forms/search-cancel-button-mouseup.html: Adjust click position for the cancel button.
  • fast/forms/search-abs-pos-cancel-button.html: ditto.

2011-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

If a text field has a search results button, a search cancel
button, a speech button, or a spin button, the editable inner text
element and they are wrapped by a flexible box container, and the
editable inner text element has flexibility.
As the result of applying the flexible box, we don't need any
horizontal layout code in RenderTextControlSingleLine except the
inner spin button.

Also, we remove custom hit-testing code in nodeAtPoint(). If a
user clicks on a position left of the inner editable text but not
on the search results button, the search results button doesn't
work though it worked.

  • css/html.css: (input::-webkit-textfield-decoration-container): New style definition for the "container" element. (input[type="search"]::-webkit-search-cancel-button): It should be a block element because it's a child of the flexible box. Also, this doesn't have flexibility. (input[type="search"]::-webkit-search-decoration): ditto. (input[type="search"]::-webkit-search-results-decoration): ditto. (input[type="search"]::-webkit-search-results-button): ditto. (input::-webkit-inner-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::containerElement): Add an accessor of the flexible box container. It just calls InputType::containerElement().
  • html/HTMLInputElement.h: Declare it.
  • html/InputType.h: (WebCore::InputType::containerElement): New accessor for a shadow element.
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): m_innerBlock is moved to TextFieldInputType. (WebCore::SearchInputType::needsContainer): A search field always needs the flexible box container because of the results button and the cancel button. (WebCore::SearchInputType::createShadowSubtree): Use TextFieldInputType::createShadowSubtree(), then modify the tree. (WebCore::SearchInputType::destroyShadowSubtree): m_innerBlock is moved to TextFieldInputType.
  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initialize the new members. (WebCore::TextFieldInputType::needsContainer): Returns true if x-webkit-speech. We check a spin button separately. (WebCore::TextFieldInputType::createShadowSubtree): Wrap everything with the flexible box container if needsContainer() or we need a spin button. (WebCore::TextFieldInputType::containerElement): Added an accessor. (WebCore::TextFieldInputType::innerBlockElement): ditto. (WebCore::TextFieldInputType::innerTextElement): ditto. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear references to new shadow nodes.
  • html/TextFieldInputType.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::containerElement): Added an accessor. (WebCore::RenderTextControlSingleLine::innerTextElement): (WebCore::RenderTextControlSingleLine::layout):
    • Correct heights check Comparing with height(), not contentHeigth(), was incorrect.
    • Adjust the container height like the editable inner text.
    • Remove width adjustment
    • Remove the speech button layout code The flexible box layout is enough.

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

Remove custom code for results/cancel/speech buttons, and
Simplify comments.

(WebCore::RenderTextControlSingleLine::forwardEvent):

Remove custom forwarding code for results/cancel buttons.

(WebCore::RenderTextControlSingleLine::styleDidChange):

Clear the style of the container because we update it in layout().

(WebCore::RenderTextControlSingleLine::hasControlClip):

Decoration buttons should be clipped by the container.

(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

We don't need to use display:inline-block any more.

(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):

The text wrapper element should have flexibility.

(WebCore::RenderTextControlSingleLine::textBlockInsetTop):

Updated for the tree structure change.

  • rendering/RenderTextControlSingleLine.h:
9:15 PM Changeset in webkit [89406] by morrita@google.com
  • 25 edits in trunk

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • configure.ac:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • Configurations/FeatureDefines.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • Configurations/FeatureDefines.xcconfig:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • Configurations/FeatureDefines.xcconfig:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • Scripts/build-webkit:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2011-06-21 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970

Breaks mac build and mistakenly enables the spellcheck API

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
9:00 PM Changeset in webkit [89405] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Yuta Kitamura <yutak@chromium.org>

Unreviewed, remove duplicate Chromium test expectation.

  • platform/chromium/test_expectations.txt:
8:41 PM Changeset in webkit [89404] by yutak@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-21 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Chromium test expectations and baselines.

  • platform/chromium-win/fast/css/color-leakage-expected.png: Added.
  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [89403] by tkent@chromium.org
  • 6 edits in trunk

2011-06-21 Kent Tamura <tkent@chromium.org>

[Mac] Sort Xcode project files.

2011-06-21 Kent Tamura <tkent@chromium.org>

[Mac] Sort Xcode project files.

  • WebCore.xcodeproj/project.pbxproj:

2011-06-21 Kent Tamura <tkent@chromium.org>

[Mac] Sort Xcode project files.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7:36 PM Changeset in webkit [89402] by darin@apple.com
  • 17 edits in trunk/Source/WebCore

2011-06-21 Darin Adler <darin@apple.com>

Reviewed by Ryosuke Niwa.

RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955

  • dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
  • dom/DataTransferItem.h:
  • dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
  • dom/DataTransferItems.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
  • editing/CompositeEditCommand.h:
  • page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
  • page/WebKitAnimationList.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
  • svg/graphics/filters/SVGFilterBuilder.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.
7:27 PM Changeset in webkit [89401] by morrita@google.com
  • 23 edits in trunk

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

  • configure.ac:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

No new tests, changing only build related files

  • Configurations/FeatureDefines.xcconfig:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

No new tests, changing only build related files

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

No new tests, changing only build related files

  • Configurations/FeatureDefines.xcconfig:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

No new tests, changing only build related files

  • Configurations/FeatureDefines.xcconfig:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

  • Scripts/build-webkit:

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
7:20 PM Changeset in webkit [89400] by dpranke@chromium.org
  • 9 edits
    1 add in trunk/Tools

2011-06-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: attempt #3 at fixing server startup/shutdown
https://bugs.webkit.org/show_bug.cgi?id=62829

Attempt yet again to make starting and stopping servers
reliable. It turns out that apache has races between when the
ctl process exists and when it writes/removes the pid file.
This change accounts for the races.

  • Scripts/new-run-webkit-httpd:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
6:04 PM Changeset in webkit [89399] by abarth@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

bugs.webkit.org should use Strict-Transport-Security
https://bugs.webkit.org/show_bug.cgi?id=63097

Strict-Transport-Security forces all connections to bugs.webkit.org to
use HTTPS, preventing sslstrip and other attacks.

  • .htaccess:
5:50 PM Changeset in webkit [89398] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-21 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
https://bugs.webkit.org/show_bug.cgi?id=63098
<rdar://problem/9645393>

Force a repaint after completing entering full-screen mode only after the notification
is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
layer again during the repaint.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
5:40 PM Changeset in webkit [89397] by mdelaney@apple.com
  • 3 edits
    3 adds in trunk

2011-06-21 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093

Test: fast/css/color-leakage.html

  • platform/graphics/cg/GraphicsContextCG.cpp: Swap out CGContextSave/Restore with GraphicsContext::save/restore to keep the context in sync with its CG context (WebCore::GraphicsContext::beginTransparencyLayer): Added save(), removed redundant calls. (WebCore::GraphicsContext::endTransparencyLayer): Added restore(), removed redundant calls.

2011-06-21 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093

  • fast/css/color-leakage.html: Added pixel regression test that previously would have the border's color spilling into the text.
  • platform/mac/fast/css/color-leakage-expected.png: Added.
  • platform/mac/fast/css/color-leakage-expected.txt: Added.
5:26 PM Changeset in webkit [89396] by tony@chromium.org
  • 17 edits
    8 adds in trunk

2011-06-21 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050

Add a new script-test, but skip it on all platforms since we don't
build with ENABLE_CSS3_FLEXBOX anywhere.

  • css3/flexbox/flex-parsing-expected.txt: Added.
  • css3/flexbox/flex-parsing.html: Added.
  • css3/flexbox/script-tests/TEMPLATE.html: Added.
  • css3/flexbox/script-tests/flex-parsing.js: Added. (testFlex):
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-21 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050

Test: css3/flexbox/flex-parsing.html

  • CMakeLists.txt: Add CSSFlexValue.*
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSFlexValue.cpp: Added. (WebCore::CSSFlexValue::~CSSFlexValue): (WebCore::CSSFlexValue::cssText):
  • css/CSSFlexValue.h: Added. (WebCore::CSSFlexValue::create): Hold positive flex, negative flex and sizing. (WebCore::CSSFlexValue::CSSFlexValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValidPrimitive): Pull out code from parseValue. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFlex): Parse the different version of flex().
  • css/CSSParser.h:

2011-06-21 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050

  • features.gypi: Add a gyp flag (enable_css3_flexbox) for setting ENABLE_CSS3_FLEXBOX.
5:09 PM Changeset in webkit [89395] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Ryosuke Niwa <rniwa@webkit.org>

Remove failing test expectations from various tests for Chromium Windows.

  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [89394] by enne@google.com
  • 4 edits
    3 adds in trunk

2011-06-21 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181

  • compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-transformed-layer.html: Added.

2011-06-21 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMapRecursive): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  • rendering/RenderLayerCompositor.h:
4:46 PM Changeset in webkit [89393] by zmo@google.com
  • 13 edits
    4 adds in trunk

2011-06-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497

  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Test drawingBufferWidth/Height attributes.
  • fast/canvas/webgl/canvas-zero-size-expected.txt:
  • fast/canvas/webgl/canvas-zero-size.html: Added.
  • fast/canvas/webgl/drawingbuffer-test-expected.txt:
  • fast/canvas/webgl/drawingbuffer-test.html: Added.

2011-06-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497

  • src/GraphicsContext3DChromium.cpp: Make getInternalFramebufferSize method const. (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize): (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • src/GraphicsContext3DInternal.h:

2011-06-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497

  • html/canvas/WebGLRenderingContext.cpp: Add drawingBufferWidth/Height method and call getInternalFramebufferSize(). (WebCore::WebGLRenderingContext::drawingBufferWidth): (WebCore::WebGLRenderingContext::drawingBufferHeight):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl: Add readonly attributes drawingBufferWidth/Height.
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Make getInternalFramebufferSize const. (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto. (WebCore::GraphicsContext3D::getInternalFramebufferSize):
4:39 PM Changeset in webkit [89392] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved 'const' off the global-variable-as-local-variable crack pipe
https://bugs.webkit.org/show_bug.cgi?id=63105


This is necessary for moving the rest of the code off of same.


Many problems remain in our handling of const. I have fixed none of them.

  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::scopeChain): New accessor, needed to enable const to directly implement its unique scoping rules.
  • bytecompiler/NodesCodegen.cpp: (JSC::PrefixResolveNode::emitBytecode): Do specify that our resolve is for writing, so we don't overwrite const variables.

(JSC::ConstDeclNode::emitCodeSingle): Don't assume that all declared const
variables are available as local variables, since this won't be the case
once global variables are not available as local variables. Instead, use
put_scoped_var in the case where there is no local variable. Like a local
variable, put_scoped_var succeeds even though const properties are
read-only, since put_scoped_var skips read-only checks. (Yay?)

4:12 PM Changeset in webkit [89391] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [89390] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-06-21 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
This moves StringCache into V8BindingPerIsolateData.

  • bindings/v8/V8Binding.cpp: (WebCore::cachedStringCallback): (WebCore::StringCache::remove): (WebCore::StringCache::v8ExternalStringSlow):
  • bindings/v8/V8Binding.h: (WebCore::StringCache::StringCache): (WebCore::StringCache::v8ExternalString): (WebCore::StringCache::clearOnGC): (WebCore::V8BindingPerIsolateData::stringCache): (WebCore::v8ExternalString):
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):

2011-06-21 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate

  • src/WebKit.cpp: (WebKit::initialize): Initialize V8PerIsolateBindingData eagerly
  • src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode): StringCache is now per-isolate, so ok in multithreaded contexts.
3:51 PM Changeset in webkit [89389] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Stephen White <senorblanco@chromium.org>

Unreviewed.

Adjust some GPU test expectations to match bot reality.

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [89388] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Clang build fix.

  • platform/mac/WebCoreSystemInterface.h: Give the enum a name.
3:35 PM Changeset in webkit [89387] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Mac build in some configurations.

  • platform/mac/WebCoreSystemInterface.h: Added an enum matching WKSI one, since we cannot use WKSI in WebCore.
  • platform/mac/WebVideoFullscreenHUDWindowController.mm: Removed an include of WebKitSystemInterface.h. It's not meant to be used from WebCore, and if included, a wrong copy may be used. (createControlWithMediaUIControlType): Added a FIXME about problems with Leopard build. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Ditto. Switched enum values to WCSI style (lower level "wk").
3:31 PM Changeset in webkit [89386] by rniwa@webkit.org
  • 27 edits
    1 delete in trunk

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099

Broke tests on Mac (Requested by rniwa on #webkit).

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099

Broke tests on Mac (Requested by rniwa on #webkit).

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::destroyInspectorView):
  • WebCoreSupport/WebInspectorClient.h:
  • WebInspector.cpp: (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::webViewClosed): (WebInspector::showConsole): (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript): (WebInspector::isProfilingJavaScript): (WebInspector::toggleProfilingJavaScript): (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled): (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
  • WebInspector.h:
  • WebView.cpp: (WebView::WebView): (WebView::close): (WebView::initWithFrame): (WebView::inspector):
  • WebView.h:

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099

Broke tests on Mac (Requested by rniwa on #webkit).

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099

Broke tests on Mac (Requested by rniwa on #webkit).

  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js: Removed.
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._enableProfiling):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:28 PM Changeset in webkit [89385] by dimich@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations after r89381.

  • platform/chromium-linux/svg/custom/pointer-events-text-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
2:31 PM Changeset in webkit [89384] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Add an internal API for accessing the QGraphicsView.
https://bugs.webkit.org/show_bug.cgi?id=63095

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::ownerWidget):

  • UIProcess/API/qt/qwkpage_p.h:
2:20 PM Changeset in webkit [89383] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087

  • storage/indexeddb/objectStore-required-arguments-expected.txt: Added.
  • storage/indexeddb/objectStore-required-arguments.html: Added.

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087

Test: storage/indexeddb/objectStore-required-arguments.html

  • storage/IDBObjectStore.idl: Remove LegacyDefaultOptionalArguments flag so missing required arguments will throw TypeError, as per WebIDL spec.
2:18 PM Changeset in webkit [89382] by commit-queue@webkit.org
  • 2 edits
    1 add
    7 deletes in trunk/LayoutTests

2011-06-21 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/delete-3608430-fix.html to DumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=62823

Fixed a superfluous quote, added a doctype, fixed a broken reference to 'abe.gif'
(now points to abe.png, in the correct location), added a description, and converted
to a DumpAsTextEditingTest. This test checks that deletion over an image will correctly
remove an empty element before the image.

  • editing/deleting/delete-3608430-fix-expected.txt: Added.
  • editing/deleting/delete-3608430-fix.html:
  • platform/chromium-linux/editing/deleting/delete-3608430-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-3608430-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-3608430-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-3608430-fix-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-3608430-fix-expected.txt: Removed.
2:13 PM Changeset in webkit [89381] by rwlbuis@webkit.org
  • 6 edits in trunk

2011-06-21 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Update test results (improvement).

  • platform/mac/svg/custom/pointer-events-text-expected.png:
  • platform/mac/svg/custom/pointer-events-text-expected.txt:

2011-06-21 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Use PointerEventsHitRules to make hit-testing for SVG text inline boxes work.

No new tests; covered by existing test pointer-events-text.svg.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
  • rendering/svg/SVGInlineTextBox.h:
2:09 PM Changeset in webkit [89380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085

  • storage/indexeddb/keyrange-required-arguments-expected.txt: Added.
  • storage/indexeddb/keyrange-required-arguments.html: Added.

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Adam Barth.

IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085

Test: storage/indexeddb/keyrange-required-arguments.html

  • storage/IDBKeyRange.idl: remove LegacyDefaultOptionalArguments flag so missing required arguments throw TypeError, as per WebIDL spec.
2:08 PM Changeset in webkit [89379] by dimich@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed, updating test expectations after r89367,
fixing typo in test_expectations.txt

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [89378] by commit-queue@webkit.org
  • 5 edits in trunk

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065

  • storage/indexeddb/database-name-undefined-expected.txt:
  • storage/indexeddb/database-name-undefined.html:

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065

  • storage/IDBFactory.idl: remove LegacyDefaultOptionalArguments flag and fix function argument flags
1:57 PM Changeset in webkit [89377] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079

  • storage/indexeddb/index-get-key-argument-required-expected.txt: Added.
  • storage/indexeddb/index-get-key-argument-required.html: Added.

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079

Test: storage/indexeddb/index-get-key-argument-required.html

  • storage/IDBIndex.idl: remove LegacyDefaultOptionalArguments flag so missing required arguments throw a TypeError as per WebIDL spec.
1:54 PM Changeset in webkit [89376] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-21 Chris Evans <cevans@chromium.org>

Reviewed by Darin Fisher.

Wire in checkIfRunInsecureContent to the chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=63026

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::checkIfRunInsecureContent): add in basic plumbing.
  • src/WebFrameImpl.h:
1:42 PM Changeset in webkit [89375] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032

  • storage/indexeddb/cursor-update-value-argument-required-expected.txt: Added.
  • storage/indexeddb/cursor-update-value-argument-required.html: Added.

2011-06-21 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032

Test: storage/indexeddb/cursor-update-value-argument-required.html

  • storage/IDBCursor.idl: remove LegacyDefaultOptionalArguments flag so calling functions with missing required arguments will raise a TypeError
1:30 PM Changeset in webkit [89374] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045

  • platform/gtk/Skipped: Unskip tests that are now passing.

2011-06-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045

Use prepareForFilling and prepareForStroking when rendering the shadowed
image of a path. This ensures that the shadowed image has the proper alpha.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): Properly prepare the shadow image.
12:58 PM Changeset in webkit [89373] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-21 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=63080
Unit-tests step on test-only bot is broken.
Removing the step until run-api-tests is fixed.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:52 PM Changeset in webkit [89372] by mnaganov@chromium.org
  • 14 edits
    1 delete in trunk

2011-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049

  • inspector/profiler/detailed-heapshots-test.js:

2011-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.get profile): (WebInspector.DetailedHeapshotView.prototype.get baseProfile): (WebInspector.DetailedHeapshotView.prototype._profiles): (WebInspector.DetailedHeapshotProfileType): (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/HeapSnapshotView.js: Removed.
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/heapProfiler.css:
  • inspector/front-end/inspector.html:
12:30 PM Changeset in webkit [89371] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-21 Oliver Hunt <oliver@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63052

Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.

  • parser/JSParser.cpp: (JSC::JSParser::updateErrorMessage): (JSC::JSParser::updateErrorWithNameAndMessage):
12:29 PM Changeset in webkit [89370] by dimich@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-06-21 Dmitry Titov <dimich@chromium.org>

[Chromium] Not reviewed, updating expectations for a flaky test.

  • platform/chromium/test_expectations.txt:
12:18 PM Changeset in webkit [89369] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-06-21 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004

Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can
be accepted by QDrag.
Call event->accepted() and not event->acceptProposedAction(), because the
later ignores the dropAction specified in JavaScript.

Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
and did not see any issue.
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
and they all pass.

  • Api/qwebpage.cpp: (dropActionToDragOp): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent):
11:16 AM Changeset in webkit [89368] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResources):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent):
11:14 AM Changeset in webkit [89367] by krit@webkit.org
  • 7 edits
    3 adds in trunk

2011-06-21 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085

Check for AnimatedString, AnimatedBoolean and AnimatedEnumeration on 'values' calculation.
If the property type matches one of the above values, fallback to discrete animation.

The patch also changes behavior for String animation. The animation code doesn't handle inheritance
for strings anymore. This is done by the CSS parser itself now, we just need to handle inheritance
on animations that interpolate between two values like for calcMode="linear".

Test: svg/animations/svgstring-animation-fallback-to-discrete.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

2011-06-21 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085


Added new test to check fallback to discrete animations on string values. One
test needed rebaseline. Even if we do not pass the test it is still a progression.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgstring-animation-fallback-to-discrete-expected.txt: Added.
  • svg/animations/svgstring-animation-fallback-to-discrete.html: Added.
11:05 AM Changeset in webkit [89366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-21 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Update GraphicsContextSkia when the Chromium platform is Mac
https://bugs.webkit.org/show_bug.cgi?id=62867

No new tests. This does not modify existing code;
there is no change in functionality.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::drawOuterPath): (WebCore::drawInnerPath): (WebCore::getFocusRingOutset): (WebCore::GraphicsContext::drawFocusRing): The OS X framework draws a fatter focus ring than the Chromium port. Increase the diameter, and add an inner stroke with more transparency, to match the look of Chromium on Mac when Skia is the rendering engine.

(WebCore::deviceRGBColorSpaceRef):
Add deviceRGBColorSpaceRef, a static cache of
CGColorSpaceCreateDeviceRGB(). This is called by
the Mac-specific UI when Skia is the rendering engine.

11:04 AM Changeset in webkit [89365] by leviw@chromium.org
  • 3 edits
    3 copies in branches/chromium/782

Merge 87846 - 2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

Test: svg/text/scaling-font-with-geometric-precision.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • svg/text/scaling-font-with-geometric-precision.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/7218014

11:03 AM Changeset in webkit [89364] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-21 Tony Chang <tony@chromium.org>

Try to fix WinCE build. Replace cat with perl -ne "print".

  • CMakeLists.txt:
10:47 AM Changeset in webkit [89363] by mdelaney@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-21 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Adding version of fast/events/offsetX-offsetY.html without text run or line height deps
https://bugs.webkit.org/show_bug.cgi?id=63073

  • fast/events/document-elementFromPoint-expected.txt: Added.
  • fast/events/document-elementFromPoint.html: Added.
10:32 AM Changeset in webkit [89362] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

2011-06-21 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Tony Chang.

"WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should take ENABLE_ flags into account
https://bugs.webkit.org/show_bug.cgi?id=62114

Changed the line commenting style in WebCore/css/*.in files from "#" prefixed to "" prefixed.
That's needed because we now pre-process the files with the C++ pre-processor. Also, there's
no need to manually strip the comments anymore.

Moved the duplication checks from project files to makeprop.pl and makevalues.pl.
In addition makevalues.pl will also lower case the values.

This is a build script refactoring, so no tests are provided.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_csspropertynames.py:
  • WebCore.gyp/scripts/action_cssvaluekeywords.py:
  • css/CSSPropertyNames.in: comment style only
  • css/CSSValueKeywords.in: comment style only
  • css/SVGCSSPropertyNames.in: comment style only
  • css/SVGCSSValueKeywords.in: comment style only
  • css/WCSSValueKeywords.in: comment style only
  • css/makeprop.pl:
  • css/makevalues.pl:
10:30 AM Changeset in webkit [89361] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-21 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
9:59 AM Changeset in webkit [89360] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-06-21 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Sam Weinig.

[GTK] [WK2] WebKit2 build break fixes.
https://bugs.webkit.org/show_bug.cgi?id=62950

When building WebKit2 for GTK there are few build breaks connected with missing include files.

  • Platform/unix/SharedMemoryUnix.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • UIProcess/API/gtk/PageClientImpl.cpp:
9:00 AM Changeset in webkit [89359] by pvarga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-21 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

[Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
https://bugs.webkit.org/show_bug.cgi?id=61187

No new tests needed.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
8:58 AM Changeset in webkit [89358] by pvarga@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-21 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

[Qt][V8] Enable marking objects with complex GC rules
https://bugs.webkit.org/show_bug.cgi?id=61291

No new tests needed.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
8:17 AM Changeset in webkit [89357] by loislo@chromium.org
  • 1 edit in branches/chromium/782/Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Merge 89344 - 2011-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix path finding to window objects.
https://bugs.webkit.org/show_bug.cgi?id=63051

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/7224001

8:11 AM Changeset in webkit [89356] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Stephen White <senorblanco@chromium.org>

Unreviewed.

Remove a now-passing test from chromium's text_expectations. Also
comment out expectations for a few newly-added tests which were
removed by a revert. This makes lint-test-files run cleanly.

  • platform/chromium/test_expectations.txt:
7:45 AM Changeset in webkit [89355] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Stephen White <senorblanco@chromium.org>

Unreviewed.

Removing a now-passing test from chromium's test_expectations.

  • platform/chromium/test_expectations.txt:
7:32 AM Changeset in webkit [89354] by pfeldman@chromium.org
  • 27 edits
    1 add in trunk

2011-06-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

2011-06-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::isDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::setDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::startProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::evaluateAsBoolean): (WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js: Added. (InspectorFrontendAPI.isDebuggingEnabled): (InspectorFrontendAPI.setDebuggingEnabled): (InspectorFrontendAPI.isJavaScriptProfilingEnabled): (InspectorFrontendAPI.setJavaScriptProfilingEnabled): (InspectorFrontendAPI.isTimelineProfilingEnabled): (InspectorFrontendAPI.setTimelineProfilingEnabled): (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript): (InspectorFrontendAPI.setAttachedWindow):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.isRecordingProfile): (WebInspector.CPUProfileType.prototype.startRecordingProfile): (WebInspector.CPUProfileType.prototype.stopRecordingProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get profilerEnabled): (WebInspector.ProfilesPanel.prototype.enableProfiler): (WebInspector.ProfilesPanel.prototype.disableProfiler):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get debuggingEnabled): (WebInspector.ScriptsPanel.prototype.enableDebugging): (WebInspector.ScriptsPanel.prototype.disableDebugging): (WebInspector.ScriptsPanel.prototype.toggleDebugging):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected): (WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled): (WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

2011-06-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

2011-06-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

  • WebInspector.cpp: (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::webViewClosed): (WebInspector::showConsole): (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript): (WebInspector::isProfilingJavaScript): (WebInspector::toggleProfilingJavaScript): (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled): (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
  • WebInspector.h:
  • WebView.cpp: (WebView::WebView): (WebView::close): (WebView::initWithFrame): (WebView::inspector):
  • WebView.h:
7:28 AM Changeset in webkit [89353] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068

For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).

  • bindings/v8/V8Binding.cpp: (WebCore::enableStringImplCache): (WebCore::getStringCache): (WebCore::cachedStringCallback): (WebCore::v8ExternalStringSlow):
  • bindings/v8/V8Binding.h: (WebCore::v8ExternalString):
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue):

2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068

For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).

  • src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
7:16 AM Changeset in webkit [89352] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Stephen White <senorblanco@chromium.org>

Unreviewed.

Skip a test that takes too long on the GPU.

  • platform/chromium/test_expectations.txt:
6:49 AM Changeset in webkit [89351] by senorblanco@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-20 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

New test for patch introduced in r89250
https://bugs.webkit.org/show_bug.cgi?id=63016

  • fast/canvas/script-tests/text-globalAlpha.js: Added.
  • fast/canvas/text-globalAlpha-expected.txt: Added.
  • fast/canvas/text-globalAlpha.html: Added.
6:25 AM Changeset in webkit [89350] by pfeldman@chromium.org
  • 14 edits in trunk/Source/WebCore

2011-06-21 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename editScriptSource to setScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=63059

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setScriptSource):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setScriptSource):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setScriptSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setScriptSource):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.setScriptSource): (WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.editSource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.editContent): (WebInspector.SourceFrameDelegate.prototype.setScriptSource):
6:00 AM Changeset in webkit [89349] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992

  • http/tests/inspector/network/network-cachedresources-with-same-urls.html: Added.
  • http/tests/inspector/network/resources/resource.php:

2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992

Test: http/tests/inspector/network/network-cachedresources-with-same-urls.html

  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResourceContent):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::addCachedResource):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::cachedResource): (WebCore::NetworkResourcesData::ResourceData::setCachedResource):
5:38 AM Changeset in webkit [89348] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-21 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Attached state changes do not affect the drawer height
https://bugs.webkit.org/show_bug.cgi?id=63061

5:29 AM Changeset in webkit [89347] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Chromium layout test failure after r89317
https://bugs.webkit.org/show_bug.cgi?id=63031

Event Listener sidebar output prints out the full path
to the source file in the sourceName property. For testing
purposes, since the path will be different per system,
clip the early part of the path and leave the expected part.

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementEventListeners): (initialize_ElementTest.InspectorTest.dumpObjectPropertySection):
  • platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:
3:30 AM Changeset in webkit [89346] by podivilov@chromium.org
  • 6 edits in trunk

2011-06-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
  • inspector/debugger/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger/debugger-pause-on-breakpoint.html:

2011-06-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
2:58 AM Changeset in webkit [89345] by yurys@chromium.org
  • 15 edits
    3 adds in trunk

2011-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996

  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt: Added.
  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html: Added.
  • http/tests/inspector-enabled/resources/console-clear-arguments-iframe.html: Added.

2011-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996

When DOMWindow is detached from its frame run through all console messages and clear
their arguments and ScriptState references. The message text in this case will be
the first argument serialized to string.

Test: http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

  • bindings/js/ScriptState.cpp: (WebCore::domWindowFromScriptState):
  • bindings/js/ScriptState.h:
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::domWindow): (WebCore::domWindowFromScriptState):
  • bindings/v8/ScriptState.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::windowCleared):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::discardInjectedScriptsFor):
  • inspector/InjectedScriptManager.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::domWindowCleared):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::pageDestroyedImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::pageDestroyed):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::pageDestroyed):
2:51 AM Changeset in webkit [89344] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix path finding to window objects.
https://bugs.webkit.org/show_bug.cgi?id=63051

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
1:56 AM Changeset in webkit [89343] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-21 Yuta Kitamura <yutak@chromium.org>

Unreviewed, update Chromium test expectations for some flaky tests.

  • platform/chromium/test_expectations.txt:
1:43 AM Changeset in webkit [89342] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hovering over linkified nodes
in the UI does not highlight elements on the page.
https://bugs.webkit.org/show_bug.cgi?id=60630

  • inspector/front-end/inspector.js: (WebInspector.wireElementWithDOMNode):
12:10 AM Changeset in webkit [89341] by Csaba Osztrogonác
  • 68 edits
    9 deletes in trunk/LayoutTests

[Qt] Unreviewed rollout r89237, r89238 and part of r89243,
because the original patch r89233 was rolled out by r89320.

Note: See TracTimeline for information about the timeline view.