Timeline



Jun 27, 2011:

11:46 PM Changeset in webkit [89897] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89881.
http://trac.webkit.org/changeset/89881
https://bugs.webkit.org/show_bug.cgi?id=63513

Makes Qt massively slow (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:02 PM Changeset in webkit [89896] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 89780
BUG=86648
Review URL: http://codereview.chromium.org/7273023

10:55 PM Changeset in webkit [89895] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Source/JavaScriptCore: Build fix attempt after r89885.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-06-27

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=50554
RegExp.prototype.toString does not escape slashes

Reviewed by Darin Adler & Oliver Hunt.

The problem here is that we don't escape forwards slashes when converting
a RegExp to a string. This means that RegExp("/").toString() is "/",
which is not a valid RegExp literal. Also, we return an invalid literal
for RegExp.prototype.toString() ("
", which is an empty single-line comment).

From ES5:
"NOTE: The returned String has the form of a RegularExpressionLiteral that
evaluates to another RegExp object with the same behaviour as this object."

Added test cases.

  • fast/regex/script-tests/toString.js: Added.

(testFwdSlash):

  • fast/regex/toString-expected.txt: Added.
  • fast/regex/toString.html: Added.
10:39 PM Changeset in webkit [89894] by yutak@chromium.org
  • 5 edits in trunk/Source/WebKit2

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

[WebKit2] Add hixie76WebSocketProtocolEnabled flag to WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=63447

Make a new flag added in WebCore::Settings (useHixie76WebSocketProtocol)
switchable from WebPage and WebPreferences.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetHixie76WebSocketProtocolEnabled): (WKPreferencesGetHixie76WebSocketProtocolEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
10:35 PM Changeset in webkit [89893] by cevans@google.com
  • 1 edit
    36 copies in branches/chromium/782

Merge 89836
BUG=87148
Review URL: http://codereview.chromium.org/7253035

10:13 PM Changeset in webkit [89892] by cevans@google.com
  • 2 edits
    3 copies in branches/chromium/782

Merge 89782
BUG=87339
Review URL: http://codereview.chromium.org/7273022

10:08 PM Changeset in webkit [89891] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium baselines update.

  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
10:02 PM Changeset in webkit [89890] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error related to wrong include order.

  • platform/graphics/efl/ImageEfl.cpp:
9:30 PM Changeset in webkit [89889] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

[chromium] editing/style/smoosh-styles-003.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=63509

Don't let spellcheck kick in this test because it's nothing to do with spellcheck.

  • editing/style/smoosh-styles-003.html:
9:19 PM Changeset in webkit [89888] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
8:43 PM WebAPIReviewChecklist edited by rniwa@webkit.org
(diff)
7:30 PM Changeset in webkit [89887] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Build fix attempt after r89885.

7:19 PM Changeset in webkit [89886] by rniwa@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Fix r89879.

  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt.
6:32 PM Changeset in webkit [89885] by oliver@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

2011-06-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Support throwing away non-running code even while other code is running
https://bugs.webkit.org/show_bug.cgi?id=63485

Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.

The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls): (JSC::CodeBlock::clearEvalCache):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::unlink):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::clear):
  • heap/Heap.cpp: (JSC::Heap::getConservativeRegisterRoots):
  • heap/Heap.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
  • jit/JITWriteBarrier.h: (JSC::JITWriteBarrierBase::clear):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionReleaseExecutableMemory):
  • runtime/Executable.cpp: (JSC::EvalExecutable::unlinkCalls): (JSC::ProgramExecutable::unlinkCalls): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::unlinkCalls):
  • runtime/Executable.h:
  • runtime/JSGlobalData.cpp: (JSC::SafeRecompiler::returnValue): (JSC::SafeRecompiler::operator()): (JSC::JSGlobalData::releaseExecutableMemory):
6:16 PM Changeset in webkit [89884] by leviw@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Renaming incorrectly named linux test expectation.

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png.
6:12 PM Changeset in webkit [89883] by commit-queue@webkit.org
  • 1 edit
    2 moves
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5156801-2.html to dumpAsText and rename
https://bugs.webkit.org/show_bug.cgi?id=63359

converted editing/deleting/5156801-2.html to dump-as-markup test, with
new results. Renamed 5156801.html to delete-node-after-DOMNodeRemoved,
and 5156801-2.html to delete-table-cell-contents.html; they were only
noticeably related by their rdar number, which is now included in each.

  • editing/deleting/5156801.html: Removed.
  • editing/deleting/5156801-expected.txt: Removed.
  • editing/deleting/5156801-2.html: Removed.
  • editing/deleting/delete-node-after-DOMNodeRemoved.html: Added.
  • editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt: Added.
  • editing/deleting/delete-table-cell-contents.html: Added.
  • editing/deleting/delete-table-cell-contents-expected.txt: Added.
  • platform/chromium-linux/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.png: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.txt: Removed.
5:34 PM Changeset in webkit [89882] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63497
Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:33 PM Changeset in webkit [89881] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
5:15 PM Changeset in webkit [89880] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the WebCore vcproj file after r89851.

  • WebCore.vcproj/WebCore.vcproj:
5:08 PM Changeset in webkit [89879] by leviw@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Windows rebaseline for my commit r89864.

  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
4:57 PM Changeset in webkit [89878] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Allow non-main thread text drawing in ICU ports
https://bugs.webkit.org/show_bug.cgi?id=63482

Some ports allow multiple threads to draw strings.
LineBreakIteratorPool is not thread safe and the existing
ASSERT caught cases where multiple threads were trying
to access the shared pool. This makes the pool a lazily
created per-thread pool to allow for thread safe pool use.

  • platform/ThreadGlobalData.h:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): start with null. (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create. (WebCore::ThreadGlobalData::destroy): delete. Manage the lifetime of the per-thread pool instance.
  • platform/text/LineBreakIteratorPoolICU.h: (WebCore::LineBreakIteratorPool::sharedPool): Use the per-thread pool instance and remove the ASSERT that this needs to be on the main thread.

(WebCore::LineBreakIteratorPool::create):
Create a PassOwnPtr so we can use OwnPtr on pools.

(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
Private now that there is a public create function.

4:50 PM Changeset in webkit [89877] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89864

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Added.
4:26 PM Changeset in webkit [89876] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Tests that a plugin of a swf file in a hidden iframe will not
crash. This test required more than 1 content file and a
timeout or else it would not repeat the error condition.

This test will only crash on platforms (like Symbian) that
don't allow nonvirtual functions to have a null this pointer.

  • plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
  • plugins/hidden-iframe-with-swf-plugin.html: Added.
  • plugins/resources/iframe-content-with-swf-plugin.html: Added.

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".

Test: plugins/hidden-iframe-with-swf-plugin.html

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
4:16 PM Changeset in webkit [89875] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Juan C. Montemayor <jmont@apple.com>

Reviewed by Mark Rowe.

Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
https://bugs.webkit.org/show_bug.cgi?id=63392

When both TextPosition.h and XPathGrammar.h are included a compile-error
is caused, since XPathGrammar.h defines a macro called NUMBER and
TextPosition has a typedef named NUMBER.

  • wtf/text/TextPosition.h: (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition):
4:09 PM Changeset in webkit [89874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Raymes Khoury <raymes@chromium.org>

Reviewed by Tony Chang.

WebCore fails to compile in thumb mode when neon instructions are
enabled.

There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
which fail to build when -mthumb is passed to gcc. These contain inline
assembly for neon instructions on arm. This patch forces the -marm flag
to be passed when compiling these files to work around this.

https://bugs.webkit.org/show_bug.cgi?id=62916

Built WebKit in Chromium and checked that -marm is passed
only when building these files.

https://bugs.webkit.org/show_bug.cgi?id=62916

  • WebCore.gyp/WebCore.gyp:
4:05 PM Changeset in webkit [89873] by abarth@webkit.org
  • 7 edits in trunk

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

NRWT used to have a different name for crash logs. I've changed the
name to patch ORWT.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3:52 PM Changeset in webkit [89872] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
3:51 PM Changeset in webkit [89871] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

  • platform/chromium/fast/js/recursion-limit-equal-expected.txt: Rebaseline after r89842.
3:31 PM Changeset in webkit [89870] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
https://bugs.webkit.org/show_bug.cgi?id=63486

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
3:18 PM Changeset in webkit [89869] by jcivelli@chromium.org
  • 12 edits
    2 adds in trunk

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • mhtml/multi_frames_binary.mht: Added.
  • platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::MHTMLArchive::generateMHTMLData): (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp: (WebCore::MHTMLParser::parseNextPart):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:
  • platform/network/MIMEHeader.cpp: (WebCore::MIMEHeader::parseContentTransferEncoding):
  • platform/network/MIMEHeader.h:

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML): (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):
3:17 PM Changeset in webkit [89868] by eric@webkit.org
  • 16 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
3:15 PM Changeset in webkit [89867] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Really fix the revision number in the last entry

3:14 PM Changeset in webkit [89866] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix revision number that I referenced in my last checkin

3:11 PM Changeset in webkit [89865] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process always pauses on launch
https://bugs.webkit.org/show_bug.cgi?id=63487

Reviewed by Oliver Hunt.

In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
web process to pause if the shift and alt keys were not held down.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Add some parentheses.

3:01 PM Changeset in webkit [89864] by leviw@chromium.org
  • 9 edits
    4 adds in trunk

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949
Adding support for the 'plaintext' mode of unicode-bidi.

  • fast/text/international/unicode-bidi-plaintext.html: Added.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: added
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949

Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
of the Unicode BiDi algorithm on each paragraph of a block with that style.
This is similar to dir=auto but done per-paragraph instead of per element.

Test: fast/text/international/unicode-bidi-plaintext.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Added plaintext.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • html/HTMLElement.cpp: (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto to their proper unicode-bidi attribute. (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea when dir=auto.
  • platform/text/UnicodeBidi.h: Added plaintext.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::determineParagraphDirection): Determines the direction of a paragraph based on the first strong character. Stops at first paragraph separator. (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection when in unicode-bidi: plaintext mode (and operating at the block's BidiContext) to set each paragraph to the proper base BidiContext. (WebCore::RenderBlock::determineStartPosition): Ditto.
  • rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate for plaintext.
2:45 PM Changeset in webkit [89863] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89745.

I checked these results with Rob - they are not failing expected results.

  • platform/win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/win/svg/custom/linking-uri-01-b-expected.txt: Added.
2:38 PM Changeset in webkit [89862] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/whitespace-pre-1.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63372

converted editing/deleting/whitespace-pre-1.html to dump-as-markup, removed
old baselines, and added the new one.

  • editing/deleting/whitespace-pre-1-expected.txt: Added.
  • editing/deleting/whitespace-pre-1.html:
  • platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.txt: Removed.
2:38 PM Changeset in webkit [89861] by commit-queue@webkit.org
  • 12 edits in trunk/Source/JavaScriptCore

2011-06-27 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform put_by_id caching.
https://bugs.webkit.org/show_bug.cgi?id=63409

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchByIdSelfAccess): (JSC::DFG::tryCacheGetByID): (JSC::DFG::appropriatePutByIdFunction): (JSC::DFG::tryCachePutByID): (JSC::DFG::dfgRepatchPutByID):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
2:32 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:27 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:24 PM Changeset in webkit [89860] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

2:23 PM Changeset in webkit [89859] by Lucas Forschler
  • 1 copy in tags/Safari-534.50.1

New tag.

2:23 PM Changeset in webkit [89858] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

No new tests, it's just a little cosmetic change.

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

  • WebCoreSupport/QTKitFullScreenVideoHandler.mm:
2:22 PM Changeset in webkit [89857] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r89748.

2:21 PM Changeset in webkit [89856] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89769.

I checked these results with Dan - they are not failing expected results.

  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
2:20 PM Changeset in webkit [89855] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r89718.

2:20 PM Changeset in webkit [89854] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests does not report stderr output
https://bugs.webkit.org/show_bug.cgi?id=37739

Almost all the infrastructure appears to be in place to report stderr
in results.html. We just need to wire up a bool to tell results.html
to create the hyperlink.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
2:19 PM Changeset in webkit [89853] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

2:18 PM Changeset in webkit [89852] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

webkitpy unit tests should have more descriptive names than just "Test"
https://bugs.webkit.org/show_bug.cgi?id=63479

Luckily we kept these classes in separate namespaces in the harness so
we were actually running them all even though they had the same name.

  • Scripts/webkitpy/common/system/stack_utils_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2:09 PM Changeset in webkit [89851] by Joseph Pecoraro
  • 6 edits
    1 add in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Extract LineBreakIteratorPool class into its own file
https://bugs.webkit.org/show_bug.cgi?id=63471

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add the new file to builds that used TextBreakIteratorPoolICU.h.
  • platform/text/LineBreakIteratorPoolICU.h: Added. (WebCore::LineBreakIteratorPool::sharedPool): (WebCore::LineBreakIteratorPool::LineBreakIteratorPool): Expose the constructor so it can be used by others.
  • platform/text/TextBreakIteratorICU.cpp: Remove the old LineBreakIteratorPool implementation.
1:57 PM Changeset in webkit [89850] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implemenation of allowRoundingHacks.
https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks.html to the mac-wk2 skipped list to get the bots
green.

  • platform/mac-wk2/Skipped:
1:57 PM Changeset in webkit [89849] by leviw@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Greg Simon <gregsimon@chromium.org>

No review necessary.

Add email addr to contributor list
https://bugs.webkit.org/show_bug.cgi?id=63478

  • Scripts/webkitpy/common/config/committers.py:
1:53 PM Changeset in webkit [89848] by commit-queue@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89834.
http://trac.webkit.org/changeset/89834
https://bugs.webkit.org/show_bug.cgi?id=63476

Broke test-webkitpy (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/system/outputcapture.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
1:18 PM Changeset in webkit [89847] by jeffm@apple.com
  • 4 edits in trunk/Tools

2011-06-27 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Stop copying obsolete WebKit libraries on Windows
https://bugs.webkit.org/show_bug.cgi?id=63474


Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.

  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  • MiniBrowser/MiniBrowserPostBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1:14 PM Changeset in webkit [89846] by inferno@chromium.org
  • 1 edit
    48 adds in trunk/LayoutTests

2011-06-27 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89836.

  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
12:39 PM Changeset in webkit [89845] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Add Wyatt Carss to the list of non-committer contributors.

  • Scripts/webkitpy/common/config/committers.py:
12:08 PM Changeset in webkit [89844] by justin.garcia@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Justin Garcia <justin.garcia@apple.com>

Reviewed by Ryosuke Niwa.

CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
https://bugs.webkit.org/show_bug.cgi?id=62921

  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
11:47 AM Changeset in webkit [89843] by abarth@webkit.org
  • 6 edits
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkitpy should understand crash logs
https://bugs.webkit.org/show_bug.cgi?id=63468

We're planning to use this functionality to upload crash logs along
with test results for new-run-webkit-tests.

  • Scripts/webkitpy/common/system/crashlog.py: Added.
  • Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:40 AM Changeset in webkit [89842] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

The fast/js/recursion-limit-equal test is too fragile
https://bugs.webkit.org/show_bug.cgi?id=63352

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-27
Reviewed by Gavin Barraclough.

  • fast/js/recursion-limit-equal-expected.txt:
  • fast/js/script-tests/recursion-limit-equal.js:
11:36 AM Changeset in webkit [89841] by Adam Roben
  • 2 edits in trunk/Tools

Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
old-run-webkit-tests exited early after reload

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
old-run-webkit-tests exited early due to too many failures in PersistentCache.

11:28 AM Changeset in webkit [89840] by Adam Roben
  • 3 edits in trunk/Tools

Make TestFailures load build names from build.webkit.org/old-results too

Build results are periodically moved from results to old-results. This change makes those
builds still visible to TestFailures.

Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
have been moved to build.webkit.org/old-results

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Extracted code to parse build names from a
build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
we now only include directory entries whose names are parseable as build names (since
old-results sometimes contains other random files/directories from who knows what). We now
fetch both results and old-results (with a FIXME about loading old-results on demand),
extract build names from each, and concatenate the two sets of names.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:

(WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
parseable, rather than throwing an exception.

11:28 AM Changeset in webkit [89839] by Adam Roben
  • 2 edits in trunk/Tools

Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache

It seems silly to have a whole generic cache just to store a single object.

Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
need one

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
(LayoutTestHistoryAnalyzer.prototype.start): Ditto.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
no-longer-needed history argument.

11:27 AM Changeset in webkit [89838] by Adam Roben
  • 4 edits
    2 adds in trunk/Tools

Move some inappropriate code out of Builder

Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
isn't really about a builder

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
called by other objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

Added. Code came from Builder.
(LayoutTestHistoryAnalyzer):
(LayoutTestHistoryAnalyzer.prototype.start):
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

Added. Code came from Builder.
(LayoutTestResultsLoader):
(LayoutTestResultsLoader.prototype.start):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new

scripts.

11:05 AM Changeset in webkit [89837] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
10:48 AM Changeset in webkit [89836] by inferno@chromium.org
  • 3 edits
    36 adds in trunk

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Fix removal of overhanging floats on style changes to absolute/fixed position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  1. If we are not currently positioned.
  2. And we are not floating. (If we are floating, then this will be automatically done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
  3. And we have overhanging floats from previous sibling blocks.
  4. And our new new style tells that we will have absolute or fixed position.

Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.

Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html

fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that overhanging floats are removed during style changes to absolute/fixed
position and gets added back when coming back to static position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
10:44 AM Changeset in webkit [89835] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

Add chromium mac failure after r89733.

  • platform/chromium/test_expectations.txt:
10:43 AM Changeset in webkit [89834] by eric@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
10:33 AM Changeset in webkit [89833] by krit@webkit.org
  • 14 edits
    4 adds in trunk

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Test for animation of SVGPreserveAspectRatio.

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgPreserveAspectRatio-animation-1-expected.txt: Added.
  • svg/animations/svgPreserveAspectRatio-animation-1.html: Added.

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedPreserveAspectRatio.


The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgPreserveAspectRatio-animation-1.html

  • CMakeLists.txt: Added new file.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Handle AnimatedPreserveAspectRatio. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.cpp: Added. New animator for SVGAnimatedPreserveAspectRatio. (WebCore::SVGAnimatedPreserveAspectRatioAnimator::SVGAnimatedPreserveAspectRatioAnimator): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.h: (WebCore::SVGAnimatedPreserveAspectRatioAnimator::~SVGAnimatedPreserveAspectRatioAnimator):
  • svg/SVGAnimatedType.cpp: Support for SVGPreserveAspectRatio. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPreserveAspectRatio): (WebCore::SVGAnimatedType::preserveAspectRatio): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): (WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
10:26 AM Changeset in webkit [89832] by alexis.menard@openbossa.org
  • 11 edits
    2 deletes in trunk

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remvove from the build.

  • Source/WebKit.pri:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.

  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon related stuff.

  • docs/qtwebkit.qdocconf:
  • qt_webkit_version.pri:
10:21 AM Changeset in webkit [89831] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.

Also add more assertions to help detecting similar bugs.

Test: editing/text-iterator/first-letter-rtl-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::emitText):

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
with first-letter rule applied where letters are not contiguous.

  • editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
  • editing/text-iterator/first-letter-rtl-crash.html: Added.
10:18 AM Changeset in webkit [89830] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

This patch is based on Noam Rosenthal original patch in the same bug.

When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason why we have the implicit conversion.

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::overloadedSlots): Remove expected failure and fix the comment.
10:16 AM Changeset in webkit [89829] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Put a failing test to the mac list because all wk2 platforms are affected.
Move the group to the section where the items have bug report.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
10:04 AM Changeset in webkit [89828] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

Some missing files in ANGLE are just added to fix build-break.

No test reqired

  • GNUmakefile.list.am:

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl

  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
9:57 AM Changeset in webkit [89827] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Martin Robinson.

[EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
https://bugs.webkit.org/show_bug.cgi?id=62959

Add PLATFORM(EFL) ifdefs to use GraphicsContextInternal.

  • platform/graphics/GraphicsContext3D.h:
9:55 AM Changeset in webkit [89826] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

  • fast/css/div_plus_nav_bug47971-expected.txt: Added.
  • fast/css/div_plus_nav_bug47971.html: Added.

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

Added a new state in css/tokenizer.flex for the "nth" rule. The state begins
at nth-*( functions and ends at the first ")". It avoids parsing selectors
like "#div+nav" as: "#div" "+n" "av".

Test: fast/css/div_plus_nav_bug47971.html

  • css/maketokenizer:
  • css/tokenizer.flex:
9:32 AM Changeset in webkit [89825] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

[WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
https://bugs.webkit.org/show_bug.cgi?id=63457

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
8:51 AM Changeset in webkit [89824] by commit-queue@webkit.org
  • 11 edits in trunk

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
8:37 AM Changeset in webkit [89823] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Adam Roben.

Send keypress events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63144

No new tests. Covered by existing windowless plugin tests plugins/mouse-events.html
and plugins/keyboard-events.html. Both are not yet working as desired because focus
events are not being fowarded to windowed plugins on the win port (bug 62375). Test
plugin logging on the win port was added in bug 61721. New failing expectations for
plugins/keyboard-events.html were subsequently added in bug 33973 so there's no need
to update test expectations in this patch.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::handleKeyboardEvent): Add an ASSERT(m_plugin && !m_isWindowed)
to indicate that the routine is for windowless plugins. Remove trailing whitespace.
Add handling for keyPress events (map to WM_CHAR).
(WebCore::PluginView::handleMouseEvent): Add the ASSERT to indicate that the routine
is for windowless plugins. Add FIXME note. Remove trailing whitespace.

8:33 AM Changeset in webkit [89822] by apavlov@chromium.org
  • 11 edits in trunk

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
8:12 AM Changeset in webkit [89821] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
It will be plugged into the build system as soon as the rest of the
DRT code is fully upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=63086

  • DumpRenderTree/efl/DumpRenderTreeView.cpp: Added. (onConsoleMessage): (onJavaScriptAlert): (onJavaScriptConfirm): (onJavaScriptPrompt): (drtViewTiledAdd):
  • DumpRenderTree/efl/DumpRenderTreeView.h: Added.
8:10 AM Changeset in webkit [89820] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add an EventSender implementation to EFL's DumpRenderTree along
with support files.
Build system changes will be made as soon as the whole DumpRenderTree
is upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=61962

  • DumpRenderTree/efl/EventSender.cpp: Added. (setEvasModifiers): (translateMouseButtonNumber): (sendMouseEvent): (sendClick): (scheduleAsynchronousClickCallback): (updateClickCount): (modifierFromJSValue): (modifiersFromJSValue): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (evasMouseEventFromHorizontalAndVerticalOffsets): (mouseScrollByCallback): (continuousMouseScrollByCallback): (keyPadNameFromJSValue): (keyNameFromJSValue): (keyDownCallback): (scalePageByCallback): (getClass): (makeEventSender):
  • DumpRenderTree/efl/EventSender.h: Added.
7:38 AM Changeset in webkit [89819] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r89817.

7:36 AM Changeset in webkit [89818] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove private header files from EWebKit_HEADERS.
https://bugs.webkit.org/show_bug.cgi?id=63441

Remove ewk_tiled_private.h, ewk_tiled_backing_store.h, ewk_tiled_matrix.h,
ewk_tiled_model.h and check WTF_USE_SOUP to remove ewk_auth_soup.h.

  • CMakeListsEfl.txt:
7:31 AM Changeset in webkit [89817] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. One more filed missing during distcheck, for
the MIPS build.

  • GNUmakefile.list.am:
7:08 AM Changeset in webkit [89816] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating chromium expectations.

  • platform/chromium/test_expectations.txt:
4:54 AM Changeset in webkit [89815] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight
https://bugs.webkit.org/show_bug.cgi?id=63405

We should not call layout from paint.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
  • inspector/DOMNodeHighlighter.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::drawNodeHighlight):
4:33 AM Changeset in webkit [89814] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Daily gardening.

Remove non-existent svg/animations/animate-points.html from the Skipped list.

  • platform/mac-wk2/Skipped:
4:32 AM Changeset in webkit [89813] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: naive approach to fixing flaky inspector tests.

  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
3:45 AM Changeset in webkit [89812] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

2011-06-27 Jongseok Yang <js45.yang@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use accept attribute when executing the file picker for input element
https://bugs.webkit.org/show_bug.cgi?id=63063

This patch:

  • remove the argument "suggested_filenames" from ewk_view_run_open_panel
  • add the argument "accept" to ewk_view_run_open_panel
  • get the accept attribute and pass to ewk_view_run_open_panel within runOpenPanel
  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel):
  • ewk/ewk_view.cpp: (ewk_view_run_open_panel):
  • ewk/ewk_view.h
3:44 AM Changeset in webkit [89811] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

Remove meaningless parameter from WebCoreSupport's header files.

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::scrollRectIntoView):
  • WebCoreSupport/DragClientEfl.h:
  • WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::setWebFrame):
3:18 AM Changeset in webkit [89810] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error in EFL port.

  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/efl/SharedBufferEfl.cpp:
1:51 AM Changeset in webkit [89809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove ewk_tile_matrix_updates_process() call from _ewk_tiled_backing_store_item_process_idler_cb().
https://bugs.webkit.org/show_bug.cgi?id=62963

As repaint_process on ewk_view_tiled already takes care of dirty area in visible area
and in order to let pre-render work more efficiently,
_ewk_tiled_backing_store_item_process_idler_cb() better not call ewk_tile_matrix_updates_process().

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb):
1:41 AM Changeset in webkit [89808] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove evil uses of hasattr
https://bugs.webkit.org/show_bug.cgi?id=63430

For some reason these classes believe that they may be called with
various flavors of "option" elements and so carefully check to make
sure that the options element has their option before checking it.

We had a set_option_default method which was never called, so I made it
do what callsites seemed to want it to do and replaced 3 callers
who previously used hasattr manually to use set_option_default instead.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:37 AM Changeset in webkit [89807] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

  • platform/qt-mac/Skipped: Skip fast/css/custom-font-xheight.html.
1:35 AM Changeset in webkit [89806] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
1:34 AM Changeset in webkit [89805] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip new tests introduced in r89783.
1:15 AM Changeset in webkit [89804] by pfeldman@chromium.org
  • 30 edits in trunk

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.waitForStyles): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.nodeSelected): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.stylesUpdated): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles):
  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/metrics-box-sizing.html:
  • inspector/styles/parse-utf8-bom.html:
  • inspector/styles/styles-add-blank-property.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-source-lines-inline.html:
  • inspector/styles/styles-source-lines.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:
  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateStyles): (WebInspector.ElementsPanel.prototype._stylesUpdated):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
1:10 AM Changeset in webkit [89803] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::innerBottomRight): (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::innerBottomRight): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):
1:07 AM Changeset in webkit [89802] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] WebViewHost should be destructed before LayoutTestController, etc.
https://bugs.webkit.org/show_bug.cgi?id=63427

~WebViewHost() navigates to about:blank, so it calls some
callbacks and LayoutTestController functions.

  • DumpRenderTree/chromium/TestShell.h: Move m_printer upper and move m_webViewHost lower.
1:04 AM Changeset in webkit [89801] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move server config files to webkitpy.layout_tests.servers
https://bugs.webkit.org/show_bug.cgi?id=63436

The config files belong with the servers.

  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
  • Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
1:01 AM Changeset in webkit [89800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item's update field.
https://bugs.webkit.org/show_bug.cgi?id=62967

As some code do not affect any logical flow of tiled backing store except condition check,
I would like to clean dead code related with Ewk_Tiled_Backing_Store_Item's update field
and Ewk_Tiled_Backing_Store_Data's queue field

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del):
12:59 AM Changeset in webkit [89799] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip a new test.
12:59 AM Changeset in webkit [89798] by abarth@webkit.org
  • 7 edits
    4 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move websocket_server and http_server to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63434

These classes do not represent ports. They represent servers.

  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
12:54 AM Changeset in webkit [89797] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=63428

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
12:46 AM Changeset in webkit [89796] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results after r89745.

  • platform/qt/Skipped: Revert accidentally committed (r89732) changes.
  • platform/qt/svg/custom/linking-a-03-b-all-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
12:43 AM Changeset in webkit [89795] by abarth@webkit.org
  • 2 edits
    1 move
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move apache_http_server.py to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63433

The apache_http_server.py is a server, not a port.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/servers: Added.
  • Scripts/webkitpy/layout_tests/servers/init.py: Added.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
12:34 AM Changeset in webkit [89794] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63432

This code isn't in the dependency cone of new-run-webkit-tests. It's
unclear what it's final home should be, but this patch moves it out of
layout_tests to simply the package.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
12:20 AM Changeset in webkit [89793] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63429

This package as nothing to do with the layout_tests package.

  • Scripts/update-webgl-conformance-tests:
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
12:11 AM Changeset in webkit [89792] by yutak@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

[Chromium] Add useHixie76WebSocketProtocol to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=63424

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHixie76WebSocketProtocolEnabled):
  • src/WebSettingsImpl.h:
12:10 AM Changeset in webkit [89791] by abarth@webkit.org
  • 3 edits
    2 moves
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move deduplicate_tests.py into webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63426

deduplicate_tests.py doesn't haven anything to do with layout tests.
It's really a separate script. This patch moves it to the (new)
to_be_moved package so that it doesn't distract us when working on NRWT.

  • Scripts/deduplicate-tests:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
  • Scripts/webkitpy/to_be_moved: Added.
  • Scripts/webkitpy/to_be_moved/init.py: Added.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.

Jun 26, 2011:

11:50 PM Changeset in webkit [89790] by mrowe@apple.com
  • 4 edits in trunk/Source

Use a separate file name for Lion's WebKitSystemInterface.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:
11:49 PM Changeset in webkit [89789] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from WebAudio IDL files
https://bugs.webkit.org/show_bug.cgi?id=63416

WebAudio isn't that widely used, so it's seems somewhat safe to remove
legacy code generation hacks. I'm not an expert on WebAudio, but the
API doesn't appear to need many optional arguments.

There are a bunch of APIs that have custom bindings that look like they
could be autogenerated. I've added FIXME comments where appropriate.

  • webaudio/AudioBuffer.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioListener.idl:
  • webaudio/AudioNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioParam.idl:
  • webaudio/RealtimeAnalyserNode.idl:
11:40 PM Changeset in webkit [89788] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2011-06-26 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Remove empty directory.

  • Scripts/webkitpy/layout_tests/test_types: Removed.
11:40 PM Changeset in webkit [89787] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
https://bugs.webkit.org/show_bug.cgi?id=63421

Show generic sidebar menu only if no pane-specific menu has been shown.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
11:39 PM Changeset in webkit [89786] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Build fix for clang. Apparently clang doesn't want us to use the std
namespace in headers, which makes sense.

  • svg/SVGAnimatedType.h:
11:31 PM Changeset in webkit [89785] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
https://bugs.webkit.org/show_bug.cgi?id=63418

The XMLHttpRequest.idl interface used to implement the new behavior
manually using the RequiresAllArguments attribute. Now that we have
that behavior by default, we can simply remove the
LegacyDefaultOptionalArguments attribute.

  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
11:22 PM Changeset in webkit [89784] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.

Rubber-stamped by Maciej Stachowiak.

  • WebProcess/mac/WebProcessMac.mm:
11:16 PM Changeset in webkit [89783] by krit@webkit.org
  • 15 edits
    13 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399


Test animations of attributes with type SVGLengthList.

  • svg/animations/script-tests/svglengthlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svglengthlist-animation-1-expected.txt: Added.
  • svg/animations/svglengthlist-animation-1.html: Added.
  • svg/animations/svglengthlist-animation-2-expected.txt: Added.
  • svg/animations/svglengthlist-animation-2.html: Added.
  • svg/animations/svglengthlist-animation-3-expected.txt: Added.
  • svg/animations/svglengthlist-animation-3.html: Added.
  • svg/animations/svglengthlist-animation-4-expected.txt: Added.
  • svg/animations/svglengthlist-animation-4.html: Added.

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.


Interpolated animations of glyph positions are possible now.

Tests: svg/animations/svglengthlist-animation-1.html

svg/animations/svglengthlist-animation-2.html
svg/animations/svglengthlist-animation-3.html
svg/animations/svglengthlist-animation-4.html

  • CMakeLists.txt: Add new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList. (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator): (WebCore::SVGAnimatedLengthListAnimator::constructFromString): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
  • svg/SVGAnimatedLengthList.h: (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
  • svg/SVGAnimatedType.cpp: Add SVGLengthList. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createLengthList): (WebCore::SVGAnimatedType::lengthList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value. (WebCore::SVGLength::SVGLength):
  • svg/SVGLength.h:
9:49 PM Changeset in webkit [89782] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

  • http/tests/security/location-prototype-expected.txt: Added.
  • http/tests/security/location-prototype.html: Added.
  • http/tests/security/resources/location-prototype-overwrite.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

This patch corrects the prototype chain for Location, but we really
should do a complete cleanup of the prototype chain generation, like we
did for JavaScriptCore.

Test: http/tests/security/location-prototype.html

  • bindings/scripts/CodeGeneratorV8.pm:
9:45 PM Changeset in webkit [89781] by abarth@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add [Optional] attributes where appropriate for addEventListener and removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=63417

This patch doesn't actually change behavior because these interfaces
have the LegacyDefaultOptionalArguments attribute. This patch paves
the way to removing LegacyDefaultOptionalArguments from some of these
interfaces as well as making the project safer for copy-and-pasting
these methods into new IDL files that don't have the
LegacyDefaultOptionalArguments attribute.

  • bindings/scripts/test/TestObj.idl:
  • dom/EventTarget.idl:
  • dom/MediaStream.idl:
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • storage/IDBRequest.idl:
  • storage/IDBTransaction.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
8:43 PM Changeset in webkit [89780] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

  • fast/forms/form-associated-element-crash3-expected.txt: Added.
  • fast/forms/form-associated-element-crash3.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

Test: fast/forms/form-associated-element-crash3.html

  • dom/Document.h:
8:34 PM Changeset in webkit [89779] by takano.naoki@gmail.com
  • 2 edits in trunk/Tools

Change committers entry.w

8:15 PM Changeset in webkit [89778] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove WebSecurityOrigin::grantUniversalAccess
https://bugs.webkit.org/show_bug.cgi?id=63415

This function has no callers and is downright dangerous.

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp:
6:47 PM Changeset in webkit [89777] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-06-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

FileList::filenames should be FileList::paths, because it's more accurate.
https://bugs.webkit.org/show_bug.cgi?id=63414

Refactoring, no change in behavior.

  • fileapi/FileList.cpp: (WebCore::FileList::paths): Renamed from filenames.
  • fileapi/FileList.h:
  • html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
5:31 PM Changeset in webkit [89776] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-06-26 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API.
https://bugs.webkit.org/show_bug.cgi?id=62688

Move functions which use Ewk_View_Private_Data and may not be required by
applications to ewk_private.h.

  • ewk/ewk_private.h:
  • ewk/ewk_view.h:
4:06 PM Changeset in webkit [89775] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Baselines for new test.

  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
2:26 PM Changeset in webkit [89774] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
1:21 PM Changeset in webkit [89773] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove code behind WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63402

These old APIs are no longer needed.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:30 PM Changeset in webkit [89772] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-26 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
https://bugs.webkit.org/show_bug.cgi?id=63347

  • dfg/DFGNonSpeculativeJIT.cpp:
    • Changed arithmetic operations to speculate in favor of integers.

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
    • Added slow-path routines for arithmetic that perform no speculation; the non-speculative JIT will generate calls to these in cases where its speculation fails.
  • dfg/DFGOperations.h:
10:17 AM Changeset in webkit [89771] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't use a Mutex for protecting access to the connection queue clients
https://bugs.webkit.org/show_bug.cgi?id=63403

Make sure to only access the queue client vector from the connection work queue.
This gets rid of a lock and ensures that adding/removing clients from callbacks works correctly.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::addQueueClientOnWorkQueue): (CoreIPC::Connection::removeQueueClientOnWorkQueue): (CoreIPC::Connection::processIncomingMessage):
  • Platform/CoreIPC/Connection.h:
10:04 AM Changeset in webkit [89770] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Darn. Need BUGWG to make the file parse.

  • platform/chromium/test_expectations.txt:
9:09 AM Changeset in webkit [89769] by mitz@apple.com
  • 3 edits
    3 adds in trunk

With word-break: break-all, words do not break correctly before a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=63401

Reviewed by Darin Adler.

Source/WebCore:

The code to check for mid-word breaks accumulates width one character at a time. It was actually
measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
Fixed by checking for surrogate pairs and measuring the pair as one unit.

Test: fast/text/midword-break-before-surrogate-pair.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/text/midword-break-before-surrogate-pair.html: Added.
7:22 AM Changeset in webkit [89768] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Note that this test ASSERTs on Linux Debug.

  • platform/chromium/test_expectations.txt:
6:12 AM Changeset in webkit [89767] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Skip new tests that depend on pause API. Put them to the
mac list that is used by all WebKit2 platforms.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
4:24 AM Changeset in webkit [89766] by krit@webkit.org
  • 13 edits
    14 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.


Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
growing shadows with feGaussianBlur, feDropShadow or other filter effects.

Tests: svg/animations/svgnumberoptionalnumber-animation-1.html

svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.h: Added. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
  • svg/SVGAnimatedType.cpp: Added new type: pair<float, float>. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberOptionalNumber): (WebCore::SVGAnimatedType::numberOptionalNumber): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: Add new animator to factory. (WebCore::SVGAnimatorFactory::create):

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Test animation of SVGNumberOptionalNumber values with and without optional number, as well as 'to' and 'by' animations.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-1.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4.html: Added.
2:35 AM Changeset in webkit [89765] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed. Skip failing tests.

[Qt][WK2] svgnumberlist-animation-[1,2] fails since added
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/qt-wk2/Skipped:

Jun 25, 2011:

11:33 PM Changeset in webkit [89764] by abarth@webkit.org
  • 4 edits in trunk

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::queueLoad):
10:43 PM Changeset in webkit [89763] by pfeldman@chromium.org
  • 13 edits
    10 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: new chromium baselines.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt: Added.
9:33 PM Changeset in webkit [89762] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

  • fast/dom/shadow/frameless-media-element-crash.html: Added.
  • fast/dom/shadow/frameless-media-element-crash-expected.txt: Added.

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
in the calling code.

Test: fast/dom/shadow/frameless-media-element-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created. (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation. (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
  • html/HTMLMediaElement.h: Adjusted def.
9:09 PM Changeset in webkit [89761] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
9:04 PM Changeset in webkit [89760] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Fix some minor style issues
https://bugs.webkit.org/show_bug.cgi?id=63391

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): The explicit WebCore namespace usage can be dropped.
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): Use ASSERT_UNUSED for a parameter that we want to ASSERT on for a debug build, but is UNUSED in a release build.
5:39 PM Changeset in webkit [89759] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

Unreviewed build correction after r89426.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Link with Cairo DLL for new functionality.
  • WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility code for snprintf.
5:36 PM Changeset in webkit [89758] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.

  • Shared/API/c/cairo/WKImageCairo.h: Declare cairo type as struct (in keeping with other declarations).
  • win/WebKit2.vcproj: Add new WKImageCairo.cpp file to WinCairo build.
5:22 PM Changeset in webkit [89757] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89503.
See http://trac.webkit.org/changeset/89503. The modifications
to the WebKit2.def need to be mirrored in WebKit2CFLite.def.

  • win/WebKit2CFLite.def: Add new exported symbol for isPreloaded.
4:32 PM Changeset in webkit [89756] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix.

Use UNUSED_PARAM on the correct param!

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
4:10 PM Changeset in webkit [89755] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.
See http://trac.webkit.org/changeset/89426. The new WebKit2
header file (WKImageCairo.h) is needed.

  • win/WebKit2Generated.make: Make sure to copy the WKImageCairo.h

header file to the WebKit2 API directory after building.

4:01 PM Changeset in webkit [89754] by Joseph Pecoraro
  • 22 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 2: Only adjust for the FrameView's scroll position when
the localToAbsolute mapping did not end with fixed content.
Content that is inside of a fixed position container is already
adjusted for the FrameView's scrollPosition when RenderView
maps local to container.

This patch uses a "wasFixed" out parameter to determine if
the localToAbsolute transformation ended inside a fixed block,
and if so does not apply the scroll position.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): Respect wasFixed as described above.
  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): This is the only time that "fixed" ever changed. So when fixed changes, update the optional wasFixed out parameter.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): Ignore wasFixed by default, but pipe it though where needed.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): This is the final recursive call, so wasFixed goes no further. We sanity check its value in debug builds.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
  • rendering/RenderInline.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
  • rendering/svg/SVGRenderSupport.h: Pipe wasFixed through where needed.
4:01 PM Changeset in webkit [89753] by Joseph Pecoraro
  • 8 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 1: Provide FloatQuad versions of convertFromRenderer,
convertToContainingView, and convertChildToSelf, so that we
can get the fully transformed quad of a renderer all the
way up to the root widget.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf):
  • platform/Widget.h:
  • platform/Widget.cpp: (WebCore::Widget::convertToContainingView): Provide FloatQuad versions of these already existing functions.

(WebCore::Widget::convertToRootContainingView):
Provide a helper conversion function to recursively
convert a given FloatQuad up to the root widget.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): Use the new methods to convert the FloatQuad for the highlighted node to the root container, without losing transformation information. Add a FIXME for SVG, which is still broken.
  • WebCore.exp.in: Export the new Widget functions so WebKit can link properly.
3:16 PM Changeset in webkit [89752] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-25 Dirk Schulze <krit@webkit.org>

Unreviewed build fix.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
3:08 PM Changeset in webkit [89751] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Remove ifdefs around these two functions because
we're not planning to move them. This patch makes WebFrameImpl.h
consistent with WebFrame.h so we can build with the new API
configuration.

  • src/WebFrameImpl.h:
3:02 PM Changeset in webkit [89750] by krit@webkit.org
  • 15 edits
    7 adds in trunk

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumberList.


Animations of attributes with type SVGNumberList can be interpolated now.

Tests: svg/animations/svgnumberlist-animation-1.html

svg/animations/svgnumberlist-animation-2.html

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedNumber): Made method static for reuse in SVGAnimatedNumberList (and SVGAnimatedNumberOptionalNumber later). (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): Use new static function.
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.cpp: Added. New animator for SVGNumberList. (WebCore::SVGAnimatedNumberListAnimator::SVGAnimatedNumberListAnimator): (WebCore::SVGAnimatedNumberListAnimator::constructFromString): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberListAnimator::calculateDistance):
  • svg/SVGAnimatedNumberList.h: (WebCore::SVGAnimatedNumberListAnimator::~SVGAnimatedNumberListAnimator):
  • svg/SVGAnimatedType.cpp: Use new Animator. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberList): (WebCore::SVGAnimatedType::numberList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

Test animation of attributes with type SVGNumberList.

  • svg/animations/script-tests/svgnumberlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberlist-animation-1-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-1.html: Added.
  • svg/animations/svgnumberlist-animation-2-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-2.html: Added.
2:36 PM Changeset in webkit [89749] by zimmermann@webkit.org
  • 16 edits
    2 adds in trunk/Source/WebCore

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336

Convert <animate attributeName="d"> parsing to the new SVGAnimatorFactory concept, removing
the last special data types from SVGAnimateElement: SVGPathByteStream m_fromPath/m_toPath/m_animatedPath.
All existing non-string primitives have been converted to the new concept.

Doesn't change any functionality.

  • CMakeLists.txt: Added SVGAnimatedPath.*.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedPath.cpp: Added. (WebCore::SVGAnimatedPathAnimator::SVGAnimatedPathAnimator): (WebCore::SVGAnimatedPathAnimator::constructFromString): (WebCore::SVGAnimatedPathAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPathAnimator::calculateDistance):
  • svg/SVGAnimatedPath.h: Added. (WebCore::SVGAnimatedPathAnimator::~SVGAnimatedPathAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPath): (WebCore::SVGAnimatedType::path): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::initializeFrom):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
2:20 PM Changeset in webkit [89748] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-25 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

SOFT_LINK_POINTER_OPTIONAL isn't optional.
https://bugs.webkit.org/show_bug.cgi?id=63378

Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.

  • platform/mac/SoftLinking.h:
12:02 PM Changeset in webkit [89747] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening.
Skip css3/flexbox tests on Qt since ENABLE(CSS3_FLEXBOX) is disabled.

  • platform/qt/Skipped:
11:53 AM Changeset in webkit [89746] by Dimitri Glazkov
  • 2 edits in trunk/Tools

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

run-bindings-tests does not work on Chromium Windows.
https://bugs.webkit.org/show_bug.cgi?id=63382

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
11:41 AM Changeset in webkit [89745] by rwlbuis@webkit.org
  • 12 edits
    6 adds in trunk

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Allow navigating to internal <view> targets. When choosing Back ensure
the <svg> current view is initialized correctly.

Tests: svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg

svg/custom/linking-uri-01-b.svg

  • page/FrameView.cpp: Delegate to setupInitialView. (WebCore::FrameView::scrollToAnchor):
  • svg/SVGAElement.cpp: Allow navigating to internal <view> targets. (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setupInitialView): Initialize current view depending on fragment identifier. (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Add a test for navigating to an inner <view> anchor. The changed test results
are improvements.

  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/custom/linking-uri-01-b-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg: Added.
  • svg/custom/linking-uri-01-b.svg: Added.
10:44 AM Changeset in webkit [89744] by robert@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Duplicate entry in context menu
https://bugs.webkit.org/show_bug.cgi?id=62139

contextMenuController()->populate() is called from
ContextMenuController::handleContextMenuEvent() so
QWebPage::updatePositionDependentActions() does not need
to call it independently.

Related changesets:

http://trac.webkit.org/changeset/73535
http://trac.webkit.org/changeset/32389

  • Api/qwebpage.cpp: (QWebPage::updatePositionDependentActions):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy): (tst_QWebPage::contextMenuPopulatedOnce):
10:21 AM Changeset in webkit [89743] by Dimitri Glazkov
  • 3 edits
    1 delete in trunk/LayoutTests

2011-06-25 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r89732.
https://bugs.webkit.org/show_bug.cgi?id=59085

  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium/test_expectations.txt:
10:04 AM Changeset in webkit [89742] by Dimitri Glazkov
  • 7 edits in trunk

2011-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
  • fast/css/unknown-pseudo-element-matching.html: Added more tests.

2011-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement. (WebCore::CSSStyleSelector::pushParent): Ditto.
  • dom/Node.cpp: (WebCore::Node::parentOrHostElement): Added.
  • dom/Node.h:
8:15 AM Writing Layout Tests for DumpRenderTree edited by dominicc@chromium.org
Documents window.internals. (diff)
3:20 AM Changeset in webkit [89741] by pfeldman@chromium.org
  • 2 edits
    18 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: chromium rebaselines.

  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-linux/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:43 AM Changeset in webkit [89740] by zimmermann@webkit.org
  • 17 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update gtk baseline. The rebaselines should be done now.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt:
  • platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/text/text-text-04-t-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/text/text-text-06-t-expected.txt:
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
1:01 AM Changeset in webkit [89739] by zimmermann@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update win baseline.

  • platform/win-wk2/Skipped: Skip newly added svg/text test just like in mac-wk2.
  • platform/win-xp/svg/custom: Added.
  • platform/win-xp/svg/custom/svg-fonts-fallback-expected.txt: Added. XP has different metrics here.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Update result from Win7 slave.
12:44 AM Changeset in webkit [89738] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Skip svg/text/select-text-svgfont.html on mac-wk2, just like the other svg/text tests.

  • platform/mac-wk2/Skipped:
12:36 AM Changeset in webkit [89737] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

http/tests/inspector/network/network-iframe-load-and-delete.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63379

http/tests/navigation/anchor-basic.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63380

Skip last two tests that kept Leopard red, should turn green again now.

  • platform/mac-leopard/Skipped:
12:34 AM Changeset in webkit [89736] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on Leopard/SnowLeopard release
https://bugs.webkit.org/show_bug.cgi?id=63169

Skip failing test for mac, to turn bots green again.

  • platform/mac/Skipped:
12:31 AM Changeset in webkit [89735] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update a stale Leopard result.

  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
12:02 AM Changeset in webkit [89734] by mitz@apple.com
  • 3 edits in trunk/Tools

Try to fix the Qt and Chromium builds.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setEncodedAudioData):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

Jun 24, 2011:

11:49 PM Changeset in webkit [89733] by mitz@apple.com
  • 51 edits
    4 adds in trunk

Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363

Reviewed by Anders Carlsson.

Source/WebCore:

Restored most of text rounding hacks which were removed in r78846, with a global flag to control
whether rounding hacks are allowed, which defaults to false.

Test: platform/mac/fast/text/rounding-hacks.html

  • CMakeLists.txt: Added TextRun.cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.exp.in: Export new TextRun function and global and updated StringTruncator functions.
  • WebCore.gypi: Added TextRun.cpp.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Disable rounding hacks in the one place
they used to be disabled.

  • platform/graphics/Font.cpp: Re-added the rounding character table.
  • platform/graphics/Font.h:

(WebCore::Font::isRoundingHackCharacter): Re-added.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Account for final rounding width.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::adjustedSpaceWidth): Re-added.

  • platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth): Re-added disableRoundingHacks parameter.
(WebCore::truncateString): Ditto.
(WebCore::StringTruncator::centerTruncate): Added EnableRoundingHacksOrNot parameter.
(WebCore::StringTruncator::rightTruncate): Ditto.
(WebCore::StringTruncator::width): Ditto.

  • platform/graphics/StringTruncator.h:
  • platform/graphics/TextRun.cpp: Added.

(WebCore::TextRun::setAllowsRoundingHacks): Added.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added RoundingHacks parameter to the constructors, used to initialize
the m_applyRunRounding and m_applyWordRounding member variables, subject to rounding hacks being allowed.
(WebCore::TextRun::applyRunRounding): Re-added this accessor.
(WebCore::TextRun::applyWordRounding): Ditto.
(WebCore::TextRun::disableRoundingHacks): Re-added.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Re-added code to apply rounding hacks.
(WebCore::WidthIterator::advance): Ditto.

  • platform/graphics/WidthIterator.h:
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ceilCGFloat): Re-added.
(WebCore::ComplexTextController::ComplexTextController): Re-added code to apply rounding hacks.
(WebCore::ComplexTextController::advance): Ditto.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::finalRoundingWidth): Re-added this accessor.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Accound for final rounding width.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • platform/mac/DragImageMac.mm:

(WebCore::widthWithFont): Disable rounding hacks when measuring.
(WebCore::drawAtPoint): Disable rounding hacks when drawing.

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink): Enable rounding hacks in the string truncator.

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::WebCoreTextFloatWidth): Ditto.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Disable rounding hacks.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth): Ditto.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Disabled rounding hacks.

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::constructTextRun): Ditto.

Source/WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
Disabled rounding hacks.
(-[NSString _web_widthWithFont:]): Ditto.

  • WebView/WebView.mm:

(+[WebView _setAllowsRoundingHacks:]): Added this setter.

  • WebView/WebViewPrivate.h:

Source/WebKit/win:

  • WebKitGraphics.cpp:

(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.

Tools:

Added layoutTestController.allowRoundingHacks() and implemented it
on OS X.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::allowRoundingHacks):

LayoutTests:

  • platform/mac/fast/text/rounding-hacks.html: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Added.
11:28 PM Changeset in webkit [89732] by zimmermann@webkit.org
  • 141 edits
    23 adds in trunk

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.png:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.png: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png: Added.
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/svg-features-expected.png: Added.
  • platform/qt/svg/custom/svg-features-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-in-html-expected.png:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • svg/custom/resources/ABCFont.svg:
  • svg/custom/svg-fonts-fallback.xhtml: Added.
  • svg/custom/svg-fonts-segmented.xhtml: Added.
  • svg/custom/svg-fonts-word-spacing.html: Added.
  • svg/text/select-text-svgfont-expected.txt: Added.
  • svg/text/select-text-svgfont.html: Added.
  • svg/text/text-overflow-ellipsis-svgfont.html: Added.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

  • wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)

svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

This makes text selection using SVG Fonts possible again.

  • features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
  • page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
  • platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well. (WebCore::Font::drawText): (WebCore::Font::drawEmphasisMarks): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition): (WebCore::Font::codePath):
  • platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair

std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
handle font fallback glyph matching for SVG Fonts..

(WebCore::Font::fontList): Add FontFallbackList accessor.

  • platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext. (WebCore::FontFallbackList::glyphPageZero): (WebCore::FontFallbackList::glyphPages): (WebCore::FontFallbackList::setGlyphPageZero): (WebCore::FontFallbackList::setGlyphPages):
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here. (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer. (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case. (WebCore::Font::drawGlyphBuffer): Ditto.
  • platform/graphics/FontMetrics.h: (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
  • platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int. (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData. (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
  • platform/graphics/TextRun.h:
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::glyphDataForCharacter): (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)

and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).

(WebCore::WidthIterator::run):
(WebCore::WidthIterator::runWidthSoFar):
(WebCore::WidthIterator::lastGlyphName):
(WebCore::WidthIterator::setLastGlyphName):
(WebCore::WidthIterator::arabicForms):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
  • platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
  • rendering/svg/SVGTextMetrics.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont. (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects. (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun. (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength(). (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method. (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths. (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
  • rendering/svg/SVGTextRunRenderingContext.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData): Changed font size from int to float. (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width. (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code. (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font. (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation. (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage. (WebCore::SVGFontElement::ensureGlyphCache):
  • svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly. (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone. (WebCore::SVGGlyphMap::collectGlyphsForString):
  • svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
7:42 PM Changeset in webkit [89731] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Replace ";" with space in FEATURE_DEFINES macro
https://bugs.webkit.org/show_bug.cgi?id=62211

html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
as separator. So, let the html.css to use new feature macro with space separator.

  • CMakeLists.txt:
7:26 PM Changeset in webkit [89730] by Lucas Forschler
  • 1 copy in tags/Safari-534.50

New tag.

7:15 PM Changeset in webkit [89729] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
https://bugs.webkit.org/show_bug.cgi?id=63345

The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
return 9 and 10 bit quantities, therefore changed their return type from
uint8_t to uint16_t. Also casted the places where they are used as they
are currently shifted and used as 7 or 8 bit values.

These methods are currently used for literals for stack offsets,
including creating and destroying stack frames. The prior truncation of
the upper bits caused stack frames to be too small, thus allowing a
JIT'ed function to access and overwrite stack space outside of the
incorrectly sized stack frame.

  • assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::getUInt9): (JSC::ARMThumbImmediate::getUInt10): (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S):
7:14 PM Changeset in webkit [89728] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge 89714.

7:12 PM Changeset in webkit [89727] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source/WebKit2

89706.

7:05 PM Changeset in webkit [89726] by Lucas Forschler
  • 4 edits in tags/Safari-534.48.3/Source/WebKit2

Merge 89706.

7:01 PM Changeset in webkit [89725] by Lucas Forschler
  • 5 edits in tags/Safari-534.48.3/Source

Versioning.

7:00 PM Changeset in webkit [89724] by Lucas Forschler
  • 1 copy in tags/Safari-534.48.3

New tag.

6:55 PM Changeset in webkit [89723] by Lucas Forschler
  • 2 edits in tags/Safari-534.48.2/Source/WebCore

Merge r89714.

6:38 PM Changeset in webkit [89722] by Lucas Forschler
  • 5 edits in tags/Safari-534.48.2/Source

Versioning.

6:21 PM Changeset in webkit [89721] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove ewk_frame_theme_get/set.
https://bugs.webkit.org/show_bug.cgi?id=63370

Remove ewk_frame_theme_get/set to avoid confusion.
Setting theme on each frame is meaningless and ewk_view_thjeme_set can
do same thing.

  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.cpp: (ewk_view_theme_set):
5:45 PM Changeset in webkit [89720] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Drag-and-drop tab in same window makes web process falsely report unresponsiveness
https://bugs.webkit.org/show_bug.cgi?id=63369
<rdar://problem/9673120>

If the view becomes invisible, stop the responsiveness timer, because we might not get any
messages that will cause it to stop (such as painting notifications since we don't paint
when we're not visible).

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
5:39 PM Changeset in webkit [89719] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Gavin Peters <gavinp@chromium.org>

Reviewed by Darin Adler.

fix possible race in LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=63360

In chromium bug 80729
http://code.google.com/p/chromium/issues/detail?id=80729 I am
seeing some kind of double triggering of the timer; I am concerned
that it is possible that a Link element errors out or succeeds,
sets a timer, and shortly before the timer is triggered it is
editted, launches another request. After that, the first timer
triggers, zeroing out m_cachedResource. Then, the second load
finishes, and *crash*. If this is the case, this fix should stop
it.

No new tests; I haven't reproduced this. I hope chrome's crash
telemetry will give good feedback; this crash is occuring many times a
day so the difference should be obvious.

  • loader/LinkLoader.cpp: (WebCore::LinkLoader::LinkLoader): (WebCore::LinkLoader::linkLoadTimerFired): (WebCore::LinkLoader::linkLoadingErrorTimerFired): (WebCore::LinkLoader::notifyFinished):
  • loader/LinkLoader.h:
5:16 PM Changeset in webkit [89718] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-24 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332
<rdar://problem/9661650>

No new tests; Only affects machines with QTKit < 7.6.3 installed.

Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
as it is only defined in QTKit >= 7.6.3. If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys. To avoid ASSERTs when running
debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
  • platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.
5:13 PM Changeset in webkit [89717] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Windows build failure.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.

5:11 PM Changeset in webkit [89716] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
https://bugs.webkit.org/show_bug.cgi?id=63015

Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList(). These
adjustments are a bug. These need to reflect the pages that are released
in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
Made ReleaseFreeList a member of TCMalloc_PageHeap in the process. Updated
Check() and helper method CheckList() to check the number of actual free pages
with free_committed_pages_.

The symptom of the problem of the existing code is that the scavenger may
run unneccesarily without any real work to do, i.e. pages on the free lists.
The scanvenger would also end up freeing too many pages, that is going below
the current 528 target free pages.

Note that the style of the changes was kept consistent with the
existing style.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::TCMalloc_PageHeap::ReleaseFreeList):
5:09 PM Changeset in webkit [89715] by Darin Adler
  • 9 edits in trunk/Source/WebCore

2011-06-23 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Remove some unneeded functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=63295

Removing 7 of the functions in FrameLoader.h is probably a step
in the right direction.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::handledOnloadEvents): Moved the call to stopDeferringEvents in here from FrameLoader.
  • loader/DocumentLoader.h: Ditto.
  • loader/DocumentWriter.h: Fixed a typo.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to use a non-recursive tree walk instead of recursion. (WebCore::FrameLoader::stopAllLoaders): Moved the code from stopLoadingSubframes inline, since it's only two lines of code. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved the code from markLoadComplete inline, since it's only one line. (WebCore::FrameLoader::checkLoadComplete): Changed this to use a non-recursive tree walk instead of recursion, eliminating the recursiveCheckLoadComplete function completely. (WebCore::FrameLoader::handledOnloadEvents): Moved the call to stopDeferringEvents into DocumentLoader.
  • loader/FrameLoader.h: Removed unneeded forward declarations, and now-unneeded functions setupForReplaceByMIMEType, isStopping, isLoadingFromCachedPage, stopLoadingSubframes, markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete. Also made allChildrenAreComplete private.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Call DocumentLoader::isStopping so we can remove the function from FrameLoader that just calls through. Other call sites were using DocumentLoader::isStopping directly. (WebCore::MainResourceLoader::didReceiveResponse): Call DocumentLoader::setupForReplaceByMIMEType so we can remove the function from FrameLoader that just calls through. This was the only call site.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Call the ResourceLoader::cancelledError function instead of calling directly to FrameLoader.
  • loader/ResourceLoader.h: Made response an inline function.
5:03 PM Changeset in webkit [89714] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Maciej Stachowiak.

REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix for bug 62764.
4:50 PM Changeset in webkit [89713] by Lucas Forschler
  • 1 copy in tags/Safari-534.48.2

New tag.

4:39 PM Changeset in webkit [89712] by tony@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

  • css3/flexbox/display-property-expected.txt: Added.
  • css3/flexbox/display-property.html: Added.
  • css3/flexbox/script-tests/display-property.js: Added. (testFlex):

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

Test: css3/flexbox/display-property.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSValueKeywords.in:
4:06 PM Changeset in webkit [89711] by hclam@chromium.org
  • 19 edits
    5 deletes in trunk/Source/WebCore

2011-06-24 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Carlson.

Loading out-of-band text track files from <track>.
https://bugs.webkit.org/show_bug.cgi?id=62881

Uses the src attribute of <track> urls to load out-of-band text track
files using ThreadableLoader. Also removes TextTrackPrivateInterface
(as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.

No new tests because feature is hidden behind VIDEO_TRACK feature
define, which is turned off.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:
  • html/LoadableTextTrack.h:
  • html/LoadableTextTrackImpl.cpp: Removed.
  • html/LoadableTextTrackImpl.h: Removed.
  • html/MutableTextTrack.cpp:
  • html/MutableTextTrack.h:
  • html/MutableTextTrackImpl.cpp: Removed.
  • html/MutableTextTrackImpl.h: Removed.
  • html/TextTrack.cpp:
  • html/TextTrack.h:
  • html/TextTrackPrivate.h: Removed.
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
3:32 PM Changeset in webkit [89710] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Rob Buis <rbuis@rim.com>

Rubber-stamped by Nikolas Zimmermann.

All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Do not use writing mode aware code for SVG Text.

No new tests needed.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
3:15 PM Changeset in webkit [89709] by enne@google.com
  • 13 edits in trunk/LayoutTests

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63343

These tests were failing since they were introduced in r89687. The
layerTreeAsText dump on the iframe document was causing the outer
layerTreeAsText dump to be affected by font metrics. Fixed in this
case by not putting layerTreeAsText output in an element when inside
an iframe.

  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative.html:
3:07 PM Changeset in webkit [89708] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Darin Adler.

Change NDEBUG to !LOG_DISABLED macro in databases for logging.
https://bugs.webkit.org/show_bug.cgi?id=63346

Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
This change resolves also build break in Release build when logging enabled.

No new tests because there is no new behavior or feature exposed.

  • loader/icon/IconDatabase.cpp: Macro fixes. (WebCore::IconDatabase::iconDatabaseSyncThread): (WebCore::IconDatabase::syncThreadMainLoop): (WebCore::IconDatabase::readFromDatabase): (WebCore::IconDatabase::writeToDatabase): (WebCore::IconDatabase::cleanupSyncThread):
  • storage/AbstractDatabase.h: Macro fixes.
  • storage/DatabaseTask.cpp: Macro fixes.
  • storage/DatabaseTask.h: Macro fixes.
  • storage/SQLTransaction.cpp: Macro fixes.
  • storage/SQLTransaction.h: Macro fixes.
3:05 PM Changeset in webkit [89707] by tony@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Pass Strings by const reference to functions
https://bugs.webkit.org/show_bug.cgi?id=63341

Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not

change the value of the passed in String.

  • loader/FrameLoader.h:
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::setFileDescriptorData):
  • platform/win/ClipboardUtilitiesWin.h:
  • storage/DatabaseTracker.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
  • storage/IDBSQLiteBackingStore.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::getOpenDatabases):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
  • svg/SVGPaint.h:
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
3:03 PM Changeset in webkit [89706] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Not possible for plug-ins to override the internal PDF viewer
https://bugs.webkit.org/show_bug.cgi?id=63356
<rdar://problem/9673382>

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Pass the entire resource response to shouldUseCustomRepresentationForResponse.
  • WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ask for the plug-in path for a plug-in that can handle the given resource response. If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in that can handle it.

(WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
a plug-in that can handle the given response. If that is the case, it should have precedence over
the custom representation.

  • WebProcess/WebProcess.h: Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.
2:45 PM Changeset in webkit [89705] by inferno@chromium.org
  • 10 edits
    2 adds in trunk

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Match other clampTo* functions in style with clampToInteger(float)
function.
https://bugs.webkit.org/show_bug.cgi?id=53449

  • wtf/MathExtras.h: (clampToInteger): (clampToFloat): (clampToPositiveInteger):

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Add clamping for CSSPrimitiveValues and SVGInlineText font size.
https://bugs.webkit.org/show_bug.cgi?id=53449

Test: svg/text/svg-zoom-large-value.xhtml

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the number created is valid.
  • css/CSSPrimitiveValue.h: add clamping checks to prevent overflows. (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two static functions, one specific to CSSStyleSelector and other generic to help in clamping font size for other callers like svg text, etc.
  • css/CSSStyleSelector.h:
  • platform/graphics/FontDescription.h: add asserts to detect if the new font size is valid. (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize):
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper from CSSStyleSelector to help in clamping new scaled font size. do not use "smart minimum" since svg allows really small unreadable fonts (tested by existing layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon check in CSSStyleSelector function should still hold for svg.

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that font size for svg text zoom is clamped and we do not
crash on ASSERT(isfinite(s)) in FontDescription.h
https://bugs.webkit.org/show_bug.cgi?id=53449

  • svg/text/svg-zoom-large-value-expected.txt: Added.
  • svg/text/svg-zoom-large-value.xhtml: Added.
2:22 PM Changeset in webkit [89704] by jchaffraix@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Remove unsafe static_cast inside the InlineBox hierarchy
https://bugs.webkit.org/show_bug.cgi?id=63077

Refactoring only, no new test.

  • rendering/InlineFlowBox.h: (WebCore::toInlineFlowBox):
  • rendering/InlineTextBox.h: (WebCore::toInlineTextBox): Added the proper cast methods to those 2 classes from an InlineBox.
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): (WebCore::InlineFlowBox::addToLine): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::placeBoxesInInlineDirection): (WebCore::InlineFlowBox::requiresIdeographicBaseline): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild): (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): (WebCore::RenderText::positionLineBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ascentAndDescentForBox): (WebCore::RootInlineBox::includeFontForBox): (WebCore::RootInlineBox::includeGlyphsForBox): Replaced the static_cast in those previous call sites with the new cast methods.
1:54 PM Changeset in webkit [89703] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix.

Build fix on Linux when using the GStreamer backend.

No new tests, just a build fix.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::keyPressEvent):
1:54 PM Changeset in webkit [89702] by Adam Roben
  • 3 edits in trunk/Tools

Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.

1:53 PM Changeset in webkit [89701] by Adam Roben
  • 3 edits in trunk/Tools

Include links to Trac in bugs filed from TestFailures

Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.

1:46 PM Changeset in webkit [89700] by nduca@chromium.org
  • 19 edits
    9 deletes in trunk

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebKit.gypi:
  • public/WebWidget.h: (WebKit::WebWidget::animate): (WebKit::WebWidget::composite):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererViewport): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Removed.
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
1:33 PM Changeset in webkit [89699] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Fix Chromium Linux Build
https://bugs.webkit.org/show_bug.cgi?id=63349

  • WebCore.gyp/WebCore.gyp:
12:56 PM Changeset in webkit [89698] by Adam Roben
  • 2 edits in trunk/Tools

Fix typos introduced in r89696

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.

12:49 PM Changeset in webkit [89697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Henry Song <hsong@sisa.samsung.com>

Reviewed by Martin Robinson.

Correct _sharedTimer value in SharedTimerEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=62380

SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
timerEvent(), we have observed addNewTimer() can be triggered
by either inside timerFunction() or others that are not within
timerFunction(). We have observed the following case:

  1. add a new Timer within timerFunction()
  2. timerFunction returns, set _sharedTimer = 0
  3. addNewTimer() is triggered again within webkit, don't know it triggers this.
  4. because at this moment, _sharedTimer == 0, the previous registered timer (in step 1) did not get removed.
  5. Now in ecore_timer, there are two timers with same callbacks
  6. From now on, timerFunction() will be called twice back-to-back in each ecore_timer loop. To correct this, we should set _sharedTimer = 0 before timerFunction() so that when addNewTimer() triggered within, we have a valid timer object.
  • platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent):
12:37 PM Changeset in webkit [89696] by Adam Roben
  • 2 edits in trunk/Tools

Make TestFailures correctly remember whether old-run-webkit-tests exited early

Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.

12:36 PM Changeset in webkit [89695] by Adam Roben
  • 3 edits
    1 add in trunk/Tools

Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.

(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

12:29 PM Changeset in webkit [89694] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
12:20 PM Changeset in webkit [89693] by crogers@google.com
  • 3 edits in trunk/Source

2011-06-24 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Enable Web Audio for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=63338

  • features.gypi:
12:16 PM Changeset in webkit [89692] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Adrienne Walker <enne@google.com>

Unreviewed, remove assertion about root layers in RenderLayerBacking.
https://bugs.webkit.org/show_bug.cgi?id=60741

This was added in r89687, but somehow is not true on Safari Leopard.
However, as the tests that were added with that revision are passing
correctly, the assertion is most likely not correct.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
12:11 PM Changeset in webkit [89691] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Unreviewed: Skipping failing progress-clone.html on win.

r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
on win, but it should stay skipped because there is no progress
element on win (bug 49769)

  • platform/win/Skipped:
11:48 AM Changeset in webkit [89690] by zimmermann@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/Source/WebCore

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor text iterator code respecting surrogate pairs from WidthIterator
https://bugs.webkit.org/show_bug.cgi?id=63319

WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:

UChar32 character = 0;
unsigned clusterLength = 0;

SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
while (textIterator.consume(character, clusterLength)) {

Either clusterLength is 1 and UChar32 fits into a single UChar.
Or clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
...


textIterator.advance(clusterLength);

}

SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
Doesn't affect any tests, just refactoring.

  • CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
  • platform/graphics/SurrogatePairAwareTextIterator.h: Added. (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h:
11:47 AM Changeset in webkit [89689] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix after r89685

  • WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.
11:43 AM Changeset in webkit [89688] by jberlin@webkit.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.

  • fast/css/font-face-in-shadow-DOM.html: Removed.
  • fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
  • platform/win-xp/fast/css: Removed.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.
11:35 AM Changeset in webkit [89687] by enne@google.com
  • 5 edits
    42 adds in trunk

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.

The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.

  • compositing/rtl/rtl-absolute-expected.png: Added.
  • compositing/rtl/rtl-absolute-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-absolute-overflow.html: Added.
  • compositing/rtl/rtl-absolute.html: Added.
  • compositing/rtl/rtl-fixed-expected.png: Added.
  • compositing/rtl/rtl-fixed-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-fixed-overflow.html: Added.
  • compositing/rtl/rtl-fixed.html: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
  • compositing/rtl/rtl-iframe-absolute.html: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
  • compositing/rtl/rtl-iframe-fixed.html: Added.
  • compositing/rtl/rtl-iframe-relative-expected.png: Added.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • compositing/rtl/rtl-iframe-relative.html: Added.
  • compositing/rtl/rtl-relative-expected.png: Added.
  • compositing/rtl/rtl-relative-expected.txt: Added.
  • compositing/rtl/rtl-relative.html: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.

Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html

compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
11:24 AM Changeset in webkit [89686] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Add expected (failing?) results for win-xp to get the bots green.

  • platform/win-xp/fast/css: Added.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
11:09 AM Changeset in webkit [89685] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make the web process pause dialog look better on Vista/7 and robust against executable renames

Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7

Reviewed by Brian Weinstein.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.

10:52 AM Changeset in webkit [89684] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
Adding new platform specific results since the new layout in the tests changes the render tree spew.
Pixel tests are still good.

  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
10:45 AM Changeset in webkit [89683] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Add BeforeChildren and AfterChildren to the Position's anchor types
https://bugs.webkit.org/show_bug.cgi?id=63100

Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
firstPositionInNode and lastPositionInNode.

These new types of positions will let us express the first and the last positions in a non-text node in O(1).

No new tests because there is no new behavior or feature exposed.

  • dom/Position.cpp: (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes. (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node. (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and the offset in the anchor node for AfterChildren. (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren. (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick for table and ignored contents like before or after anchor. (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of the anchor node for AfterChildren. (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children. (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type is AfterChildren. (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
  • dom/Position.h: (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren. (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren. (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node, the anchor type shouldn't be BeforeChildren or AfterChildren.
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset on BeforeChildren or AfterChildren position.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder after paragraphs below the block is moved into, it needs to be the position after the current last child in the block instead of after children in the block; otherwise the position will move to the end of block.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after children or before/after anchor, just return null for these anchor types.
10:37 AM Changeset in webkit [89682] by dominicc@chromium.org
  • 68 edits in trunk

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • Source/autotools/symbols.filter: Export symbols for GTK.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Update tests to use internals.{ensureShadowRoot, shadowRoot,
shadowPseudoId, removeShadowRoot} instead of layoutTestController.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLProgressElement/progress-clone-expected.txt:
  • fast/dom/HTMLProgressElement/progress-clone.html:
  • fast/dom/shadow/activeelement-should-be-shadowhost.html:
  • fast/dom/shadow/create-content-element.html:
  • fast/dom/shadow/gc-shadow-expected.txt:
  • fast/dom/shadow/gc-shadow.html:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/nodetype.html:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:
  • fast/events/shadow-boundary-crossing.html:
  • fast/forms/resources/common.js: (getValidationMessageBubbleNode):
  • fast/html/clone-keygen-expected.txt:
  • fast/html/clone-keygen.html:
  • fast/html/clone-range-expected.txt:
  • fast/html/clone-range.html:
  • fast/html/details-clone.html:
  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-override.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/media-controls.js: (mediaControlsButtonCoordinates):
  • media/video-controls-in-media-document.html:
  • platform/win/Skipped: shadowRoot and friends now available on win.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
  • testing/Internals.cpp: The new home of shadowRoot and friends. (WebCore::Internals::ensureShadowRoot): (WebCore::Internals::shadowRoot): (WebCore::Internals::removeShadowRoot): (WebCore::Internals::shadowPseudoId):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Chromium API. These are not
required any more.

  • public/WebElement.h:
  • src/WebElement.cpp:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from GTK DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Mac API. These are not
required any more.

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow-DOM related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from Qt DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from WebKit2 API. These are not
required any more.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
  • win/WebKit2CFLite.def: Same for Cairo.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
removeShadowRoot from layoutTestController; these have been
replaced by equivalents in window.internals instead.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
9:57 AM Changeset in webkit [89681] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
https://bugs.webkit.org/show_bug.cgi?id=63327

  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
  • transforms/3d/point-mapping/3d-point-mapping.html:
9:35 AM Changeset in webkit [89680] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Refactor creation of primitive values in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=63270

Covered by existing tests.

  • css/CSSParser.cpp: (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values

to keep the cast in one place.

(WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.h: (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference
9:28 AM Changeset in webkit [89679] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.

  • platform/win-wk2/fast/forms: Added.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
9:26 AM Changeset in webkit [89678] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[X11] Do not call NPP_SetWindow with a null window handle on destroy
https://bugs.webkit.org/show_bug.cgi?id=62981

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::destroy):
9:09 AM Changeset in webkit [89677] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add (failing?) expected results for mac-wk2 to get the bots green.

  • platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.
8:59 AM Changeset in webkit [89676] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-06-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.


Exit immediately if the last condition tested fails.

Make <video> app cache test exit immediately on failure
https://bugs.webkit.org/show_bug.cgi?id=63323

8:54 AM Changeset in webkit [89675] by Carlos Garcia Campos
  • 2 edits in trunk

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add more debug options to compilation
https://bugs.webkit.org/show_bug.cgi?id=63318

Add --enable-debug-symbols to enable/disable compilation with
debug symbols and --enable-debug-features to enable/disable debug
features. Both options are unconditionally enabled for debug
builds.

  • configure.ac:
8:43 AM Changeset in webkit [89674] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325

Skip those tests to get the bots green.

  • platform/mac-wk2/Skipped:
8:42 AM Changeset in webkit [89673] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix runtime critical warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63256

Check whether there's a view widget before trying to use it in
PlatformScreenGtk. If there isn't a view widget, which is the case
in WebKit2, try to use the default GdkScreen and monitor.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getToplevel): Helper function to get the toplevel widget. (WebCore::getVisual): Use getToplevel(). (WebCore::getScreen): Helper funtion to get the screen of a widget. (WebCore::screenRect): Use getToplevel() and getScreen().
7:14 AM Changeset in webkit [89672] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

  • platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.
6:10 AM Changeset in webkit [89671] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed.
Remove non-existent items from the qt-wk2 skipped list.

  • platform/qt-wk2/Skipped:
5:37 AM Changeset in webkit [89670] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320

Reviewed by Dirk Schulze.

  • Scripts/run-bindings-tests:
5:18 AM Changeset in webkit [89669] by yutak@chromium.org
  • 14 edits in trunk/Source

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Add a flag in Setting so that WebSocket protocols can be switched
dynamically. The protocol we have implemented so far is based on
older Hixie-76 specification. A new protocol is being discussed in
IETF HyBi working group, and I'm planning to implement the new protocol
behind this Settings flag.

I will add a method to LayoutTestController which flips this flag in
a later patch. In this way, we can put tests for both protocols in
the same place and test implementation for both protocols at the same time.

This patch only adds a flag. The flag is not used yet, thus there is
no change in functionality. Therefore, no tests were added.

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseHixie76WebSocketProtocol): (WebCore::Settings::useHixie76WebSocketProtocol):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setHixie76WebSocketProtocolEnabled): (WebPreferences::hixie76WebSocketProtocolEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
5:02 AM Changeset in webkit [89668] by tkent@chromium.org
  • 7 edits
    2 adds
    17 deletes in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Clean up some tests for search cancel buttons.
https://bugs.webkit.org/show_bug.cgi?id=63121

  • Introduce a function to retrieve a reliable position of a search cancel button.
  • Convert two tests to dumpAsText().
  • fast/forms/resources/common.js: (searchCancelButtonPosition): Added.
  • fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
  • fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
  • fast/forms/search-transformed-expected.txt: Added.
  • fast/forms/search-transformed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • fast/forms/search-zoomed-expected.txt: Added.
  • fast/forms/search-zoomed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • platform/chromium/test_expectation.txt: search-transformed.html should pass.
  • platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.png: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.txt: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/qt/fast/forms/search-transformed-expected.txt: Removed.
  • platform/qt/fast/forms/search-zoomed-expected.txt: Removed.
4:52 AM Changeset in webkit [89667] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Remove an JavaScript error in media-controls-clone.html.
https://bugs.webkit.org/show_bug.cgi?id=63195

  • media/media-controls-clone.html: Remove run() call.
  • platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
  • platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
  • platform/mac/media/media-controls-clone-expected.txt: ditto.
  • platform/win/media/media-controls-clone-expected.txt: ditto.
4:47 AM Changeset in webkit [89666] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/utilities.js: ():
4:18 AM Changeset in webkit [89665] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: uncommenting chromium devtools tests.

  • platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:17 AM Changeset in webkit [89664] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add ewk_auth.h to EWebKit.h
https://bugs.webkit.org/show_bug.cgi?id=63311

  • ewk/EWebKit.h: Add ewk_auth.h
3:42 AM Changeset in webkit [89663] by morrita@google.com
  • 3 edits in trunk/Tools

2011-06-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=63216

Deleted m_webViewHost which looks leaked.

  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell):
3:39 AM Changeset in webkit [89662] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: HTML preview should delete old iframe on show().
https://bugs.webkit.org/show_bug.cgi?id=63170

  • inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype._createIFrame):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
3:21 AM Changeset in webkit [89661] by krit@webkit.org
  • 13 edits
    1 add in trunk/Source/WebCore

2011-06-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Convert AnimatedString to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63296

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.

No new tests added. No change of functionality.

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedString.cpp: Added. Animator for SVGString. (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator): (WebCore::SVGAnimatedStringAnimator::constructFromString): (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedStringAnimator::calculateDistance):
  • svg/SVGAnimatedString.h: (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createString): (WebCore::SVGAnimatedType::string): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
2:06 AM Changeset in webkit [89660] by mario@webkit.org
  • 5 edits in trunk

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Unskip accessibility test that will be passing from now on.

  • platform/gtk/Skipped: Unskipped passing test.

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Hide row objects in tables in GTK's accessibility wrapper.

This is a different approach in the way WebCore's accessible
rows are exposed to assistive technologies in the GTK port,
since from now on those objects are kept in WebCore (they do not
declare to ignore accessibility) and just bypassed in the mapping
to ATK, allowing to hide them in the ATK hierarchy while, at the
same time, keeping them internally to be able to provide enough
information to determine tables related information, such as rows
counting or finding an cell for specific coordinates.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Do not ignore accessibility for table rows here.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Bypass rows when needed. (getNChildrenForTable): New, find the number of children for a table, which will be the addition of all cells for its rows. (webkit_accessible_get_n_children): Call to getNChildrenForTable for accessibility tables if needed. (getChildForTable): New, bypass rows when needed, retrieving cells as if they were direct children for tables. (webkit_accessible_ref_child): Call to refChildForTable if needed. (getIndexInParentForCellInRow): New, get the index for a given cell in its parent table, considering other rows' cells. (webkit_accessible_get_index_in_parent): Call to getIndexInParentForCellInRow if needed.
1:43 AM Changeset in webkit [89659] by caseq@chromium.org
  • 12 edits in trunk

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype.createClientIframe):
  • inspector/front-end/inspector.css: (iframe.extension): (iframe.panel.extension):

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel): ():
  • http/tests/inspector/inspector-test.js: ():
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (dumpObject): (dumpArray): (evaluateOnFrontend.callbackWrapper): (evaluateOnFrontend): ():
  • http/tests/inspector/resources/extension-panel.html:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
1:25 AM Changeset in webkit [89658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Darin Fisher.

Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
https://bugs.webkit.org/show_bug.cgi?id=62396

  • public/WebURLError.h: (WebKit::WebURLError::WebURLError):
  • src/WebURLError.cpp: (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
1:24 AM Changeset in webkit [89657] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 David Grogan <dgrogan@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
https://bugs.webkit.org/show_bug.cgi?id=61653

roll out r86838

No new tests - refactoring.

  • dom/Document.h:
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::create): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::~EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
  • dom/EventQueue.h:
1:02 AM Changeset in webkit [89656] by caseq@chromium.org
  • 7 edits in trunk/LayoutTests

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
https://bugs.webkit.org/show_bug.cgi?id=63160

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest._replyToExtension): (initialize_ExtensionsTest):
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (onError): (onTestsDone):
  • inspector/extensions/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions.html:
12:43 AM Changeset in webkit [89655] by commit-queue@webkit.org
  • 14 edits
    3 deletes in trunk/Source

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Removed.
  • wtf/unicode/ScriptCodesFromICU.h: Removed.
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • icu/unicode/uscript.h: Removed.

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • WebCore.exp.in:
  • icu/unicode/uscript.h:
  • page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
12:09 AM Changeset in webkit [89654] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build.

  • WebKitTestRunner/GNUmakefile.am:

Jun 23, 2011:

11:43 PM Changeset in webkit [89653] by tony@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-06-23 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

Pass Strings by const reference in bindings code
https://bugs.webkit.org/show_bug.cgi?id=63302

Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.

  • bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): (WebCore::::allowSettingSrcToJavascriptURL):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): (WebCore::SerializedScriptValue::create):
  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::setString):
10:42 PM Changeset in webkit [89652] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-06-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide context menu item for enabling native worker inspection
https://bugs.webkit.org/show_bug.cgi?id=63258

Added context menu checkbox item that allows to enable inspection of
native workers. The value will be persisted as other inspector settings
and will be restored after frontend/breowser reopening.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::restore): (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles): (WebInspector.ScriptsPanel.prototype._contextMenu.enableWorkerInspection): (WebInspector.ScriptsPanel.prototype._contextMenu):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.didCreateWorker): (WebInspector.didDestroyWorker):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):

2011-06-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide context menu item for enabling native worker inspection
https://bugs.webkit.org/show_bug.cgi?id=63258

  • src/js/DevTools.js: ():
10:30 PM Changeset in webkit [89651] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

2011-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Need to turn off default animations for anchorPointZ in PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=63159

When the z-component of transform-origin changed, we ran an implicit
animation of anchorPointZ on the CALayer. Turn this off.

Test: transforms/3d/general/transform-origin-z-change.html

  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (nullActionsDictionary):
6:53 PM Changeset in webkit [89650] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Limit WebGL internal drawingBuffer size to 4k x 4k
https://bugs.webkit.org/show_bug.cgi?id=63304

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.
6:35 PM Changeset in webkit [89649] by morrita@google.com
  • 43 edits
    2 adds
    1 delete in trunk

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[ShadowContentElement] should layout child whitespace between span.
https://bugs.webkit.org/show_bug.cgi?id=62202

  • Added a new test case.
  • Updated expectations, which missed necessary RnederText objects.
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/details-add-child-2-expected.txt:
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-remove-child-2-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-add-details-child-2-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/html/details-remove-child-2-expected.txt:
  • platform/qt/fast/html/details-replace-text-expected.txt:
  • fast/dom/shadow/create-content-element-expected.txt: Added.
  • fast/dom/shadow/create-content-element.html: Added.

2011-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[ShadowContentElement] should layout child whitespace between span.
https://bugs.webkit.org/show_bug.cgi?id=62202

NodeRenderingContext::nextRenderer() and previousRenderer()
ignored forwarded content tree hierarchies and used render-object
hierarchies instead, that caused some wrong Text node rendering.

This change uses ShadowContentElement::m_inclusions for the lookup.
In this way, these methods can reflect hierarchies of forward light tree.

  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::nextRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::previousRendererOf): Added. This traverses content element's children for searching neighboring renderer. (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
  • dom/NodeRenderingContext.h:
  • dom/ShadowContentElement.h: (ShadowContentElement::inclusionIndexOf): Added.
  • dom/ShadowContentSelector.cpp: (WebCore::ShadowContentSelector::activeElement):
  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::activeContentElement):
  • dom/ShadowRoot.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Fixed an apparent bug introduced at r89230.
6:28 PM WebKit Team edited by ryuan.choi@samsung.com
(diff)
6:22 PM Changeset in webkit [89648] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
6:17 PM Changeset in webkit [89647] by jamesr@google.com
  • 12 edits in trunk/Source/WebCore

2011-05-25 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fix ownership of PlatformImage for ImageLayerChromiums
https://bugs.webkit.org/show_bug.cgi?id=61099

For a composited image, both the ImageLayerChromium and its associated LayerTilerChromium need access to a
PlatformImage - the ImageLayerChromium has to update the PlatformImage's contents and the LayerTilerChromium has
to upload pixels from it. This patch makes the ImageLayerTextureUpdater have exclusive ownership of the
PlatformImage and moves ownership of the LayerTextureUpdater from the LayerTilerChromium to the owner of the
tiler. The updater is passed in as a parameter to the relevant tiler calls.

Patch also fixes a number of minor style issues (missing explicit keyword on constructor, etc).

Refactor only, no new tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::create): (WebCore::ContentLayerPainter::ContentLayerPainter): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::create): (WebCore::ImageLayerTextureUpdater::updateFromImage): (WebCore::ImageLayerTextureUpdater::imageSize): (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerChromium::~ImageLayerChromium): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::setLayerRenderer): (WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ImageLayerChromium::layerBounds):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h: (WebCore::LayerTextureUpdater::LayerTextureUpdater):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::create): (WebCore::LayerTextureUpdaterSkPicture::create):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h:
6:11 PM Changeset in webkit [89646] by nduca@chromium.org
  • 2 edits in trunk/Tools

2011-06-23 Nat Duca <nduca@chromium.org>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
5:59 PM Changeset in webkit [89645] by enne@google.com
  • 5 edits
    42 deletes in trunk

2011-06-23 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r89632 and r89640.
http://trac.webkit.org/changeset/89632
http://trac.webkit.org/changeset/89640
https://bugs.webkit.org/show_bug.cgi?id=60741

Breaks ancestor-overflow-change unexpectedly

  • compositing/rtl/rtl-absolute-expected.png: Removed.
  • compositing/rtl/rtl-absolute-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Removed.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-absolute-overflow.html: Removed.
  • compositing/rtl/rtl-absolute.html: Removed.
  • compositing/rtl/rtl-fixed-expected.png: Removed.
  • compositing/rtl/rtl-fixed-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Removed.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-fixed-overflow.html: Removed.
  • compositing/rtl/rtl-fixed.html: Removed.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Removed.
  • compositing/rtl/rtl-iframe-absolute.html: Removed.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Removed.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Removed.
  • compositing/rtl/rtl-iframe-fixed.html: Removed.
  • compositing/rtl/rtl-iframe-relative-expected.png: Removed.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
  • compositing/rtl/rtl-iframe-relative.html: Removed.
  • compositing/rtl/rtl-relative-expected.png: Removed.
  • compositing/rtl/rtl-relative-expected.txt: Removed.
  • compositing/rtl/rtl-relative.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-23 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r89632 and r89640.
http://trac.webkit.org/changeset/89632
http://trac.webkit.org/changeset/89640
https://bugs.webkit.org/show_bug.cgi?id=60741

Breaks ancestor-overflow-change unexpectedly

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
5:51 PM Changeset in webkit [89644] by commit-queue@webkit.org
  • 1 edit
    4 moves
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5026848-1.html to dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=63289

Renamed editing/deleting/5026848* to editing/deleting/delete-across-editable-content-boundaries*,
and converted editing/deleting/delete-across-editable-content-boundaries-1 to a dump-as-markup test.
Removed old png/txt test results, and added new result. Also included radr number.

  • editing/deleting/delete-across-editable-content-boundaries-1.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-1-expected.txt: Added.
  • editing/deleting/delete-across-editable-content-boundaries-2.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-2-expected.txt: Added.
  • editing/deleting/delete-across-editable-content-boundaries-3.html: Added.
  • editing/deleting/delete-across-editable-content-boundaries-3-expected.txt: Added.
  • editing/deleting/5026848-1.html: Removed.
  • editing/deleting/5026848-2.html: Removed.
  • editing/deleting/5026848-2-expected.txt: Removed.
  • editing/deleting/5026848-3.html: Removed.
  • editing/deleting/5026848-3-expected.txt: Removed.
  • platform/chromium-linux/editing/deleting/5026848-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5026848-1-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-1-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-1-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-1-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-1-expected.txt: Removed.
5:40 PM Changeset in webkit [89643] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-23 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal
https://bugs.webkit.org/show_bug.cgi?id=63173

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
5:33 PM Changeset in webkit [89642] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: move http locking code into manager
https://bugs.webkit.org/show_bug.cgi?id=63103

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
5:28 PM Changeset in webkit [89641] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Qt again.

5:22 PM Changeset in webkit [89640] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-06-23 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, mark a few tests failing on OSX after r89632.
https://bugs.webkit.org/show_bug.cgi?id=60741

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [89639] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

GTK Rebaseline after r89627.

  • platform/gtk/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/gtk/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
5:18 PM Changeset in webkit [89638] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Qt Build

5:16 PM Changeset in webkit [89637] by slewis@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.

Reviewed by Darin Adler.

  • wtf/BlockStack.h:

(WTF::::~BlockStack):
(WTF::::grow):
(WTF::::shrink):

5:15 PM Changeset in webkit [89636] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WKTR: eventSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 skipped list.

  • platform/mac-wk2/Skipped:
5:11 PM Changeset in webkit [89635] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost.
https://bugs.webkit.org/show_bug.cgi?id=63189
The main bug fix is to only set/wait latches if the child context has no errors.
Additionally, the LayerChromium classes needed to be modified to not continue drawing when
their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::isCompositorContextLost):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::updateCompositorResources): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost
https://bugs.webkit.org/show_bug.cgi?id=63189

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
4:47 PM Changeset in webkit [89634] by alokp@chromium.org
  • 16 edits
    1 add in trunk/Source/WebCore

2011-06-23 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Red and Blue channels are swapped in images with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=61442

We were uploading BGRA pixels into RGBA textures and swapping the components in the pixel shader.
This strategy does not work with accelerated drawing because we are directly rendering to the texture, not uploading pixels.
This patch uses BGRA textures if available. If not it falls back to the original scheme of swapping the components in the pixel shader.

Tests: compositing/color-matching/image-color-matching.html (existing)

  • WebCore.gypi:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::sampledTexelFormat): (WebCore::ImageLayerTextureUpdater::updateTextureRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::skiaContext): (WebCore::LayerRendererChromium::tilerProgram): (WebCore::LayerRendererChromium::tilerProgramSwizzle): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTexture.h: (WebCore::LayerTexture::format):
  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTiles): (WebCore::LayerTilerChromium::drawTexturedQuad):
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/PlatformColor.h: Added. (WebCore::PlatformColor::format): (WebCore::PlatformColor::bestTextureFormat): (WebCore::PlatformColor::sameComponentOrder):
  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderRGBATexSwizzleAlpha::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
4:19 PM Changeset in webkit [89633] by oliver@apple.com
  • 2 edits in trunk

Qt build-fix: remove warning that no other platform appears to use.
Someone can add it back if they really feel it's needed.

4:13 PM Changeset in webkit [89632] by enne@google.com
  • 5 edits
    43 adds in trunk

2011-06-23 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.

The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.

  • compositing/rtl/rtl-absolute-expected.png: Added.
  • compositing/rtl/rtl-absolute-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-absolute-overflow.html: Added.
  • compositing/rtl/rtl-absolute.html: Added.
  • compositing/rtl/rtl-fixed-expected.png: Added.
  • compositing/rtl/rtl-fixed-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-fixed-overflow.html: Added.
  • compositing/rtl/rtl-fixed.html: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
  • compositing/rtl/rtl-iframe-absolute.html: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
  • compositing/rtl/rtl-iframe-fixed.html: Added.
  • compositing/rtl/rtl-iframe-relative-expected.png: Added.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • compositing/rtl/rtl-iframe-relative.html: Added.
  • compositing/rtl/rtl-relative-expected.png: Added.
  • compositing/rtl/rtl-relative-expected.txt: Added.
  • compositing/rtl/rtl-relative.html: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-23 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.

Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html

compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4:00 PM Changeset in webkit [89631] by jberlin@webkit.org
  • 1 edit
    6 moves in trunk/LayoutTests

compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests have been flaking on multiple platforms, so disable the tests in order to get
the bots green.

  • compositing/tiling/huge-layer-add-remove-child.html: Removed.
  • compositing/tiling/huge-layer-add-remove-child.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child.html.
  • compositing/tiling/huge-layer-img.html: Removed.
  • compositing/tiling/huge-layer-img.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-img.html.
  • compositing/tiling/huge-layer-resize.html: Removed.
  • compositing/tiling/huge-layer-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-resize.html.
  • compositing/tiling/huge-layer-with-layer-children-resize.html: Removed.
  • compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize.html.
  • compositing/tiling/huge-layer-with-layer-children.html: Removed.
  • compositing/tiling/huge-layer-with-layer-children.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html.
  • compositing/tiling/huge-layer.html: Removed.
  • compositing/tiling/huge-layer.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer.html.
3:47 PM Changeset in webkit [89630] by oliver@apple.com
  • 15 edits
    1 add in trunk/Source/JavaScriptCore

2011-06-23 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add the ability to dynamically modify linked call sites
https://bugs.webkit.org/show_bug.cgi?id=63291

Add JITWriteBarrier as a writebarrier class that allows
reading and writing directly into the code stream.

This required adding logic to all the assemblers to allow
us to read values back out of the instruction stream.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMAssembler.h: (JSC::ARMAssembler::readPointer):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::readPointer): (JSC::ARMv7Assembler::readInt32): (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmFirst): (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmSecond):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::readPointer):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::readInt32): (JSC::MIPSAssembler::readPointer):
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::readPCrelativeAddress): (JSC::SH4Assembler::readPointer): (JSC::SH4Assembler::readInt32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::readPointer):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
  • heap/MarkStack.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITWriteBarrier.h: Added. (JSC::JITWriteBarrierBase::operator UnspecifiedBoolType*): (JSC::JITWriteBarrierBase::operator!): (JSC::JITWriteBarrierBase::setFlagOnBarrier): (JSC::JITWriteBarrierBase::isFlagged): (JSC::JITWriteBarrierBase::setLocation): (JSC::JITWriteBarrierBase::location): (JSC::JITWriteBarrierBase::JITWriteBarrierBase): (JSC::JITWriteBarrierBase::set): (JSC::JITWriteBarrierBase::get): (JSC::JITWriteBarrier::JITWriteBarrier): (JSC::JITWriteBarrier::set): (JSC::JITWriteBarrier::get): (JSC::MarkStack::append):
3:35 PM Changeset in webkit [89629] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

compositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel Release
(WebKit2 Tests) since introduction.
https://bugs.webkit.org/show_bug.cgi?id=59864

Update the mac-wk2 results to contain the transform line and get the bots green.

  • platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
3:30 PM Changeset in webkit [89628] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
3:20 PM Changeset in webkit [89627] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

Add a test for vertical caret movements inside transform
https://bugs.webkit.org/show_bug.cgi?id=62834

Add regression tests for vertical caret movements inside rotated contents.

  • editing/selection/extend-inside-transforms-backward.html: Added.
  • editing/selection/extend-inside-transforms-forward.html: Added.
  • platform/chromium/test_expectations.txt: Added test expectations to keep bots green until we rebaseline these tests on Chromium.
  • platform/mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/mac/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/mac/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
3:19 PM Changeset in webkit [89626] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Gregg Tavares <gman@google.com>

Reviewed by Kenneth Russell.

add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
https://bugs.webkit.org/show_bug.cgi?id=63278

  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [89625] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

FloatRect should implement the same methods as IntRect
https://bugs.webkit.org/show_bug.cgi?id=63273

Add missing methods from IntRect to FloatRect in preparation for moving
the rendering tree over to floats.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::expandedTo): (WebCore::FloatPoint::transposedPoint):
  • platform/graphics/FloatRect.h: (WebCore::FloatRect::move): (WebCore::FloatRect::expand): (WebCore::FloatRect::contract): (WebCore::FloatRect::shiftXEdgeTo): (WebCore::FloatRect::shiftMaxXEdgeTo): (WebCore::FloatRect::shiftYEdgeTo): (WebCore::FloatRect::shiftMaxYEdgeTo): (WebCore::FloatRect::minXMinYCorner): (WebCore::FloatRect::maxXMinYCorner): (WebCore::FloatRect::minXMaxYCorner): (WebCore::FloatRect::maxXMaxYCorner): (WebCore::FloatRect::transposedRect):
  • platform/graphics/FloatSize.h: (WebCore::FloatSize::expand): (WebCore::FloatSize::transposedSize):
3:13 PM Changeset in webkit [89624] by eae@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

input/textarea onchange doesn't fire if value is set in key listener
https://bugs.webkit.org/show_bug.cgi?id=63092

Add test for text field onchange when setting the value in a key listener.

  • fast/events/onchange-setvalue-expected.txt: Added.
  • fast/events/onchange-setvalue.html: Added.

2011-06-23 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

input/textarea onchange doesn't fire if value is set in key listener
https://bugs.webkit.org/show_bug.cgi?id=63092

Change setValue implementation of HTMLInputElement and HTMLTextAreaElement to
not call setTextAsOfLastFormControlChangeEvent unless the value truly changed.
Thus element.value = element.value will no longer reset the state
m_textAsOfLastFormControlChangeEvent field and suppress the change event.

Test: fast/events/onchange-setvalue.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): (WebCore::HTMLTextAreaElement::setValueCommon):
3:11 PM Changeset in webkit [89623] by commit-queue@webkit.org
  • 3 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/delete-select-all-00* to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63193

converted editing/deleting/delete-select-all-002/003 to
runDumpAsTextEditingTest(true), removed old test files (including a
superfluous expected file for 001 on qt), and added new test files.

  • editing/deleting/delete-select-all-002-expected.txt: Added.
  • editing/deleting/delete-select-all-002.html:
  • editing/deleting/delete-select-all-003-expected.txt: Added.
  • editing/deleting/delete-select-all-003.html:
3:04 PM Changeset in webkit [89622] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows Tests] http/tests/media/video-cross-site.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=62024

Skip the test on Windows to get the bots green.

  • platform/win/Skipped:
3:02 PM Changeset in webkit [89621] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200

Revert r87060 as it broke compatibility with QtWebKit 2.1 release
and add some newly introduce symbols.

  • symbian/eabi/QtWebKitu.def:
2:55 PM Changeset in webkit [89620] by alokp@chromium.org
  • 3 edits in trunk/Tools

2011-06-23 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Add support for running layout tests with accelerated rendering
https://bugs.webkit.org/show_bug.cgi?id=63274

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:47 PM Changeset in webkit [89619] by Adam Roben
  • 2 edits in trunk/Tools

Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

As of r89610, results.html includes information about whether old-run-webkit-tests exited
early, so we don't need to look at JSON data to get this information for builds newer than
that.

Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
which is slow and limits history to the last build master restart

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
function. If we're dealing with a build that has early-exit information in results.html,
don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
(as before).

2:43 PM Changeset in webkit [89618] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriffbot can no longer restart
https://bugs.webkit.org/show_bug.cgi?id=63221

Fixed and unit tested.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2:42 PM Changeset in webkit [89617] by alexis.menard@openbossa.org
  • 16 edits
    2 adds in trunk/Source

2011-06-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Implement fullscreen support on Mac with the QuickTime backend.
https://bugs.webkit.org/show_bug.cgi?id=61728

Implement fullscreen support for Qt when using the QuickTime backend.
We mostly use what is already done for the Mac port.

  • DerivedSources.pro: We use the mac files and they have <WebCore/x> type of includes. We need to generate those headers.
  • WebCore.pro:
  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/qt/WebCoreSystemInterface.h:
  • platform/qt/WebCoreSystemInterface.mm:

2011-06-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Implement fullscreen support on Mac with the QuickTime backend.
https://bugs.webkit.org/show_bug.cgi?id=61728

Implement fullscreen support for Qt when using the QuickTime backend.
We mostly use what is already done for the Mac port.

  • QtWebKit.pro:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
  • WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added. (QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler): (QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler): (QTKitFullScreenVideoHandler::enterFullScreen): (QTKitFullScreenVideoHandler::exitFullScreen):
  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2:41 PM Changeset in webkit [89616] by mrobinson@webkit.org
  • 3 edits in trunk/Tools

2011-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=63287

Send the path to the TestNetscapePlugin to the WKTR via an environment variable
so that the plugin loads properly.

  • Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
  • WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some of the work for getting an environment variable and converting it to UTF-8. (WTR::TestController::initializeInjectedBundlePath): Use the helper. (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
2:36 PM Changeset in webkit [89615] by eric.carlson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Add a test with a single <source> element
https://bugs.webkit.org/show_bug.cgi?id=63285

  • media/video-single-valid-source-expected.txt: Added.
  • media/video-single-valid-source.html: Added.
2:35 PM Changeset in webkit [89614] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=61585
Crash running regexp /(?:(?=g))|(?:m).{2147483648,}/

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is due to use of int instead of unsigned, bad math around
the 231 boundary.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

  • Change some uses of int to unsigned, refactor compare logic to restrict to the range 0..232-1 (rather than -232-1..232-1).
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):

  • Ditto.

LayoutTests:

Add regression tests where an alterative has a size of ~231.

  • fast/regex/overflow-expected.txt: Added.
  • fast/regex/overflow.html: Added.
  • fast/regex/script-tests/overflow.js: Added.
2:30 PM Changeset in webkit [89613] by Darin Adler
  • 17 edits in trunk/Source/WebCore

2011-06-23 Darin Adler <Darin Adler>

Reviewed by Ryosuke Niwa.

RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955

  • dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem):
  • dom/DataTransferItem.h:
  • dom/DataTransferItems.cpp: (WebCore::DataTransferItems::DataTransferItems):
  • dom/DataTransferItems.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
  • editing/CompositeEditCommand.h:
  • page/WebKitAnimationList.cpp: (WebCore::WebKitAnimationList::append): (WebCore::WebKitAnimationList::insertAnimation):
  • page/WebKitAnimationList.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
  • svg/graphics/filters/SVGFilterBuilder.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.
2:10 PM Changeset in webkit [89612] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Snow Leopard WebKit2 Tests] http/tests/appcache/interrupted-update.html failing, probably
since introduction in r86478.
https://bugs.webkit.org/show_bug.cgi?id=63288

Add expected failing results in order to get the bots green.

  • platform/mac-wk2/http/tests/appcache/interrupted-update-expected.txt: Added.
2:04 PM Changeset in webkit [89611] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63218
DFG JIT - remove machine type guarantees from graph

Reviewed by Sam Weinig.

The DFG JIT currently makes assumptions about the types of machine registers
that certain nodes will be loaded into. This will be broken as we generate
nodes to produce both integer and double code paths. Remove int<->double
conversions nodes. This design decision also gave rise to multiple types of
constant nodes, requiring separate handling for each type. Merge these back
into JSConstant.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getToNumber):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::isDoubleConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfDoubleConstant):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::predictInt32):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isJSConstant):
(JSC::DFG::JITCodeGenerator::isDoubleConstant):
(JSC::DFG::JITCodeGenerator::valueOfJSConstantAsImmPtr):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::notTakenBytecodeOffset):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):

1:29 PM Changeset in webkit [89610] by Adam Roben
  • 2 edits in trunk/Tools

Record whether old-run-webkit-tests aborted early in results.html

Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
old-run-webkit-tests stopped running tests early

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(top level): Switched to heredoc syntax for printing the start of results.html for clarity.
Added a <style> element with some styles for the new message. If we stopped running early,
put the reason why at the top of results.html.
(stopRunningTestsEarlyIfNeeded): Store the message we print in the new
$stoppedRunningEarlyMessage global.

1:24 PM Changeset in webkit [89609] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89591 and r89593.
http://trac.webkit.org/changeset/89591
http://trac.webkit.org/changeset/89593
https://bugs.webkit.org/show_bug.cgi?id=63279

Caused test crashes in SL and Chromium (Requested by dimich_
on #webkit).

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89591 and r89593.
http://trac.webkit.org/changeset/89591
http://trac.webkit.org/changeset/89593
https://bugs.webkit.org/show_bug.cgi?id=63279

Caused test crashes in SL and Chromium (Requested by dimich_
on #webkit).

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged):
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::childrenChanged):
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::childrenChanged):
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::childrenChanged):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::startOfContinuations): (WebCore::AccessibilityRenderObject::updateAccessibilityRole): (WebCore::AccessibilityRenderObject::childrenChanged):
  • accessibility/AccessibilityRenderObject.h:
1:22 PM Changeset in webkit [89608] by eric.carlson@apple.com
  • 5 edits in trunk/LayoutTests

2011-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Incorrect MIME type used for some media layout tests
https://bugs.webkit.org/show_bug.cgi?id=63275

  • media/video-can-play-type-expected.txt: video/mpeg -> video/mp4
  • media/video-can-play-type.html: Ditto.
  • media/video-source-error.html: Ditto.
  • media/video-source-type.html: Ditto.
1:21 PM Changeset in webkit [89607] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[WebKit2 Tests] svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html failing since
introduction in r88913.
https://bugs.webkit.org/show_bug.cgi?id=63277

Add the (failing?) expected results in order to get the WK2 bots green.

  • platform/mac-wk2/svg: Added.
  • platform/mac-wk2/svg/zoom: Added.
  • platform/mac-wk2/svg/zoom/page: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
1:04 PM Changeset in webkit [89606] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-23 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Unbreak simple font fast-path after QRawFont API changes.
https://bugs.webkit.org/show_bug.cgi?id=63272

In the Qt 4.8 branch, the QGlyphs class has been renamed to
QGlyphRun, and some other small things have been tweaked.

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::rawFontForCharacters):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawGlyphs):
12:54 PM Changeset in webkit [89605] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

2011-06-23 Jamie Cooley <james.cooley@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Qt port needs load-from-history implementation
https://bugs.webkit.org/show_bug.cgi?id=57784

Created "random access" BackForwardHistory public API method,
QWKHistory::goToItemAt(int)

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItem::QWKHistoryItem::itemRef): Added access method to fetch WKBackForwardListRef

(QWKHistoryPrivate::QWKHistoryPrivate):
(QWKHistoryPrivate::createHistory):
Updated createHistory method and QWKHistoryPrivate constructor to take a pointer
to the owning QWKPage in addition to the WebBackForwardList. This will be saved so that the
new API can ask the page to load a HistoryItem.

(QWKHistory::goToItemAt):
New Public API. Like QWKHistory::itemAt, callee gives an integer.
<0 means jump back to that item, 0 means the current item, >0 means jump forwards.
If an out-of-range index is given, the function silently fails.
This will invoke WKPageGoToBackForwardListItem.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): Update instantiation of QWKHistory to include QWKPage.
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: (tst_QWKHistory::historyForwardBackTest_data): (tst_QWKHistory::historyForwardBackTest): Add test content for the new API
12:53 PM Changeset in webkit [89604] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Tony Chang <tony@chromium.org>

Reviewed by Andreas Kling.

Pass Strings as const references in NetworkResourcesData.h
https://bugs.webkit.org/show_bug.cgi?id=63271

  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::setFrameId): (WebCore::NetworkResourcesData::ResourceData::setUrl): (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
12:52 PM Changeset in webkit [89603] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added expected results for Snow Leopard and earlier.

  • platform/mac-snowleopard/platform/mac/fast/text: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
12:50 PM Changeset in webkit [89602] by jberlin@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Disable the test. I was wrong in thinking that the win skipped list inherits from mac.

  • http/tests/multipart/win-boundary-crash.html: Removed.
  • http/tests/multipart/win-boundary-crash.html-disabled: Copied from LayoutTests/http/tests/multipart/win-boundary-crash.html.
  • platform/mac/Skipped:
12:49 PM Changeset in webkit [89601] by Adam Roben
  • 4 edits
    1 add in trunk/Tools

Cache some of the TestFailures page's data in localStorage

This makes reloading TestFailures much faster. Right now we only store the number of failing
tests and the list of failing tests for each build. We may choose to store more later, but
it's easy to run up against quota limits.

Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
APIs (or similar) to improve loading performance

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
(Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
fetching data to the callback.
(Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
store the tests in the cache just before calling the callback. (The previous code in this
function relied on being able to modify the tests object after storing it in the cache and
having the cached version be updated. This worked while it was a non-serialized cache, but
PersistentCache uses serialization.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.

(PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
values, and stores the date that each value was initially stored along with it. This is
later used for pruning the cache.
(PersistentCache.contains): Checks whether the key exists in localStorage.
(PersistentCache.get): Fetch the string we stored in localStorage and extract the original
value out of it.
(PersistentCache.set): Serialize the value, add the date to it, and store it in
localStorage. If this fails due to quota limits, empty the whole cache and try again.
(PersistentCache.prune): Delete any cached data that is deemed old enough.
(PersistentCache._addDateToJSONString): Prepend the current date to the string.
(PersistentCache._emptyCache): Delete everything from localStorage.
(PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
return them.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change to callback signature. When
we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
where we'd never show the new bug link for tests for which we couldn't determine a passing
revision.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

PersistentCache.js.

12:32 PM Changeset in webkit [89600] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

The flakiness is happening on mac as well, move it to the mac skipped list.

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:29 PM Changeset in webkit [89599] by jcivelli@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-23 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Fixing the SharedBufferChunkReader API so it works correctly with
binary data (non printable characters).
Also adding a method to peek at the data (this is needed for MHTML
with binary parts).
https://bugs.webkit.org/show_bug.cgi?id=63231

  • loader/archive/mhtml/MHTMLParser.cpp: (WebCore::skipLinesUntilBoundaryFound): (WebCore::MHTMLParser::parseNextPart):
  • loader/archive/mhtml/MHTMLParser.h:
  • platform/SharedBufferChunkReader.cpp: (WebCore::SharedBufferChunkReader::SharedBufferChunkReader): (WebCore::SharedBufferChunkReader::setSeparator): (WebCore::SharedBufferChunkReader::nextChunk): (WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback): (WebCore::SharedBufferChunkReader::peek):
  • platform/SharedBufferChunkReader.h:
  • platform/network/MIMEHeader.cpp: (WebCore::retrieveKeyValuePairs):
12:13 PM Changeset in webkit [89598] by Nate Chapin
  • 8 edits in trunk

2011-06-23 Nate Chapin <Nate Chapin>

Unreviewed.

Revert production code part of r89503, since it's causing
crashes on WebKit2/mac and failures on qt.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::dispatchWindowLoadEvent):
  • dom/Document.h: (WebCore::Document::processingLoadEvent):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
12:11 PM Changeset in webkit [89597] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-23 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
https://bugs.webkit.org/show_bug.cgi?id=63152

The pausing conditions are modified. Now it accepts the infinite-iteration-count,
but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

  • animations/keyframes-infinite-iterations-expected.txt: Added.
  • animations/keyframes-infinite-iterations.html: Added.

2011-06-23 Young Han Lee <joybro@company100.net>

Reviewed by Simon Fraser.

runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
https://bugs.webkit.org/show_bug.cgi?id=63152

The pausing conditions are modified. Now it accepts the infinite-iteration-count,
but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

Test: animations/keyframes-infinite-iterations.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime):
11:42 AM Changeset in webkit [89596] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Add it to the Windows skipped list to get the bots green.

  • platform/win/Skipped:
11:30 AM Changeset in webkit [89595] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that we do not crash when doing a media query match.
https://bugs.webkit.org/show_bug.cgi?id=63264

  • fast/css/media-query-evaluator-crash-expected.txt: Added.
  • fast/css/media-query-evaluator-crash.html: Added.

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

RefPtr m_style in MediaQueryEvaluator in case of callers like
MediaQueryMatcher::prepareEvaluator that do not retain its reference.
https://bugs.webkit.org/show_bug.cgi?id=63264

Test: fast/css/media-query-evaluator-crash.html

  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryEvaluator.h:
11:23 AM Changeset in webkit [89594] by jshin@chromium.org
  • 14 edits
    3 adds in trunk/Source

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)

http://bugs.webkit.org/show_bug.cgi?id=20797

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Added for UScriptCode enum.
  • wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same
file was added to JavaScriptCore/icu/unicode.

http://bugs.webkit.org/show_bug.cgi?id=20797

  • icu/unicode/uscript.h: Added.

2011-06-23 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Allow generic font family settings per script code.
https://bugs.webkit.org/show_bug.cgi?id=20797

Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.

uscript.h has been updated to that of ICU 3.6 (the version of ICU on
Mac OS 10.5)

There should be no change in layout and no new layout test
is added.

  • WebCore.exp.in:
  • icu/unicode/uscript.h: updated to ICU 4.6
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
11:04 AM Changeset in webkit [89593] by Chris Fleizach
  • 1 edit
    2 adds in trunk/LayoutTests

Make line breaking obey the -webkit-locale property
https://bugs.webkit.org/show_bug.cgi?id=63209

Patch by Dan Bernstein <mitz@apple.com> on 2011-06-23
Reviewed by Alexey Proskuryakov.

  • platform/mac/fast/text/line-break-locale.html: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.txt: Added.
11:02 AM Changeset in webkit [89592] by mitz@apple.com
  • 10 edits
    3 adds in trunk

Make line breaking obey the -webkit-locale property
https://bugs.webkit.org/show_bug.cgi?id=63209

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: platform/mac/fast/text/line-break-locale.html

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator): Take an optional locale identifier and
initialize the m_locale member.
(WebCore::LazyLineBreakIterator::get): Pass the locale to acquireLineBreakIterator().
(WebCore::LazyLineBreakIterator::reset): Pass the locale to releaseLineBreakIterator() and update
the m_locale member.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::LineBreakIteratorPool::sharedPool): Return a shared instance.
(WebCore::LineBreakIteratorPool::take): Returns a text iterator for the given locale, either a newly-
created one, or an existing one from the pool.
(WebCore::LineBreakIteratorPool::put): Puts an iterator back into the pool, removing the least-recently used
one if needed.
(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
(WebCore::acquireLineBreakIterator): Changed to take an optional local identifier, and to use the pool.
(WebCore::releaseLineBreakIterator): Changed to use the pool.

  • platform/text/brew/TextBreakIteratorBrew.cpp:

(WebCore::acquireLineBreakIterator): Updated for new parameter.

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::acquireLineBreakIterator): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use the locale from the style for the line break
iterator.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Ditto.

LayoutTests:

  • platform/mac/fast/text/line-break-locale.html: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/mac/platform/mac/fast/text/line-break-locale-expected.txt: Added.
10:59 AM Changeset in webkit [89591] by Chris Fleizach
  • 11 edits in trunk

ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289

Reviewed by Darin Adler.

Source/WebCore:

If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, I think the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.

Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.

Test: platform/mac/accessibility/aria-liveregion-without-element-access.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::childrenChanged):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::childrenChanged):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):

This changed exposed a case where an object was inlineElementContinuation, but not renderInlined,
which led to an assert.

(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
10:53 AM Changeset in webkit [89590] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: marking debugger test as slow in chromium expectations.

  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [89589] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac rebaseline.

  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
10:44 AM Changeset in webkit [89588] by Adam Roben
  • 5 edits in trunk/Tools

Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing

One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
contain titles that are so long they are rejected by Bugzilla

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:

(Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
using a query string on the URL. If the search query is very long, using a query string can
cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
(Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.new-bug-form): Hide the form that we secretly use to file a new bug.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(fetchResource): Added. Code came from getResource. If we're using a GET request, add the
query parameters to the URL. Otherwise, send them as the body of the request along with the
appropriate headers.
(getResource): Now just calls through to fetchResource.
(urlEncodedQueryParameters): Added. Moved some code here...
(addQueryParametersToURL): ...from here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
number of failing tests if mentioning all the tests would make the title too long. Improved
the description for large numbers of failures by listing the tests one-per-line instead of
just having them be comma-separated, which was hard to read. Use a form to file the new bug
instead of a link so that we can POST the form data. (Using a URL with a query string can
result in the URL being too long.) The new bug link now just submits the form.

10:42 AM Changeset in webkit [89587] by krit@webkit.org
  • 25 edits
    2 adds in trunk/Source/WebCore

2011-06-23 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Convert SVGColor to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63246

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGColor.

Changed constructors of animators to take the animation element SVGAnimationsElement as new argument. Removed attribute name argument instead.
This information is already exposed by the animation element. The animators store the pointer of the animation element, so that it is not
necessary to pass it as argument to the functions calculateDistance, calculateAnimatedValue.


Replace all SVGSMILElement references by SVGAnimationsElement - the common base class of all animation elements.

Added a new method in SVGAnimateElement to determine the property value type of CSS properties (regular value type, inherit or currentColor).
The other two new methods fromPropertyValueType() and toPropertyValueType() avoid passing boolean arguments in calculateAnimatedValue().

No new tests added. Current tests cover the changes.

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Use Animator for SVGColor. (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::determinePropertyValueTypes): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance): (WebCore::SVGAnimateElement::ensureAnimator): Pass the animation element as pointer to animator.
  • svg/SVGAnimateElement.h: Removed unnecessary includes. Some cleanup. (WebCore::SVGAnimateElement::fromPropertyValueType): Get property value type of 'from' property. (WebCore::SVGAnimateElement::toPropertyValueType): Get property value type of 'to' property.
  • svg/SVGAnimatedAngle.cpp: (WebCore::SVGAnimatedAngleAnimator::SVGAnimatedAngleAnimator): Added SVGSMILElement as new argument, removed attributeName. (WebCore::SVGAnimatedAngleAnimator::calculateFromAndToValues): Determine property value type. (WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues): Ditto. (WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue): Use new functions of SVGAnimateElement for handling of 'inherit'.

And removed unnecessary arguments.

(WebCore::SVGAnimatedAngleAnimator::calculateDistance): Removed animation element argument.

  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedColor.cpp: Added. (WebCore::SVGAnimatedColorAnimator::SVGAnimatedColorAnimator): Ditto. (WebCore::SVGAnimatedColorAnimator::constructFromString): (WebCore::SVGAnimatedColorAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedColorAnimator::calculateDistance):
  • svg/SVGAnimatedColor.h: Added. (WebCore::SVGAnimatedColorAnimator::~SVGAnimatedColorAnimator):
  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): Ditto. (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::SVGAnimatedNumberAnimator): Ditto. (WebCore::SVGAnimatedNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberAnimator::calculateDistance):
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedPointList.cpp: (WebCore::SVGAnimatedPointListAnimator::SVGAnimatedPointListAnimator): Ditto. (WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPointListAnimator::calculateDistance):
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedRect.cpp: (WebCore::SVGAnimatedRectAnimator::SVGAnimatedRectAnimator): Ditto. (WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedRectAnimator::calculateDistance):
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedType.cpp: Added handling of Color values. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createColor): (WebCore::SVGAnimatedType::color): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
10:38 AM Changeset in webkit [89586] by jam@chromium.org
  • 2 edits in branches/chromium/782/Source/WebKit/chromium/src

Merge 89584 - 2011-06-23 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
https://bugs.webkit.org/show_bug.cgi?id=63260

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::visibleHeight): (WebKit::WebScrollbarImpl::visibleWidth): (WebKit::WebScrollbarImpl::contentsSize): (WebKit::WebScrollbarImpl::overhangAmount):
  • src/WebScrollbarImpl.h:

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/7248010

10:35 AM Changeset in webkit [89585] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

remove references to dump-as-markup in editing/deleting/delete-by-word tests
https://bugs.webkit.org/show_bug.cgi?id=62903

Each of these files had '../../../resources/dump-as-markup.js' referenced, which was broken.
Neither of them was using dump-as-markup, so it did not break anything - this fix just removes
the unused broken references.

  • editing/deleting/delete-by-word-001.html:
  • editing/deleting/delete-by-word-002.html:
10:35 AM Changeset in webkit [89584] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-23 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
https://bugs.webkit.org/show_bug.cgi?id=63260

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::visibleHeight): (WebKit::WebScrollbarImpl::visibleWidth): (WebKit::WebScrollbarImpl::contentsSize): (WebKit::WebScrollbarImpl::overhangAmount):
  • src/WebScrollbarImpl.h:
10:13 AM Changeset in webkit [89583] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: marking debugger test as slow in chromium expectations.

  • platform/chromium/test_expectations.txt:
10:06 AM Changeset in webkit [89582] by yael.aharon@nokia.com
  • 19 edits
    3 adds in trunk/Source

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Add convenience methods to allow encoding/decoding of DragData.
Move the call to dragEnded() to DragClient, to make WebKit1 and WebKit2
consistent.

  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • platform/DragData.h: (WebCore::DragData::flags): (WebCore::DragData::DragData): (WebCore::DragData::operator =):

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Call dragEnded from the DragClient to make WebKit1 and WebKit2 consistent.

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):

2011-06-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=62838

Added missing pieces to add support for DnD in QtWebKit.

  • Shared/qt/ArgumentCodersQt.cpp: Added. (CoreIPC::::encode): (CoreIPC::::decode):
  • Shared/qt/ArgumentCodersQt.h: Added. Encode DragData so that we can transfer the QMimeData between the WebProcess and the UI Process. I encode the DragData and not QMimeData directly because we don't have an associated QMimeData for each message.
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::init): (QGraphicsWKView::dragEnterEvent): (QGraphicsWKView::dragLeaveEvent): (QGraphicsWKView::dragMoveEvent): (QGraphicsWKView::dropEvent):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (dropActionToDragOperation): (dragOperationToDropAction): (dragOperationToDropActions): (QWKPagePrivate::dragEnterEvent): (QWKPagePrivate::dragLeaveEvent): (QWKPagePrivate::dragMoveEvent): (QWKPagePrivate::dropEvent): (QWKPagePrivate::startDrag):

Send drag-and-drop related events to WebKit.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::performDragControllerAction): (WebKit::WebPageProxy::startDrag):
  • UIProcess/WebPageProxy.h:

Start the HTML5 drag operation from the UI process, because QDrag
needs a handle to the QWidget under the mouse.

  • UIProcess/WebPageProxy.messages.in:

Add message type that takes DragData as a parameter.

  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Added. (WebKit::convertImageToBitmap): (WebKit::WebDragClient::startDrag):

Send a message to the UI process to start the HTML5 drag operation.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add message type that takes DragData as a parameter.

10:02 AM Changeset in webkit [89581] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[EFL][WK2] Add PLATFORM(EFL) to use UNIX_DOMAIN_SOCKETS.
https://bugs.webkit.org/show_bug.cgi?id=63228

  • wtf/Platform.h: Add PLATFORM(EFL) guard.
9:41 AM Changeset in webkit [89580] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-23 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[UNIX] Fix compile warnings in NetscapePluginX11.cpp
https://bugs.webkit.org/show_bug.cgi?id=63249

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setXButtonEventFields): (WebKit::NetscapePlugin::platformHandleMouseEvent):
9:35 AM Changeset in webkit [89579] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-23 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
9:02 AM Changeset in webkit [89578] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

8:56 AM Changeset in webkit [89577] by commit-queue@webkit.org
  • 14 edits
    2 copies in trunk/Source/WebCore

2011-06-23 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Show "no content" message in network panel when resource does not have content available.
https://bugs.webkit.org/show_bug.cgi?id=63007

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype._updateWithCookies):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/EmptyView.js: Added. (WebInspector.EmptyView): (WebInspector.EmptyView.prototype.show): (WebInspector.EmptyView.prototype.set text):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.ResourceContentView): (WebInspector.ResourceContentView.prototype.hasContent): (WebInspector.ResourceContentView.prototype.get sourceView): (WebInspector.ResourceContentView.prototype.show): (WebInspector.ResourceContentView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourceContentView.prototype._ensureInnerViewShown): (WebInspector.ResourceContentView.prototype.contentLoaded):
  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.show):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView): (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/ResourceResponseView.js: Added. (WebInspector.ResourceResponseView): (WebInspector.ResourceResponseView.prototype.get sourceView): (WebInspector.ResourceResponseView.prototype.contentLoaded):
  • inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.prototype.show):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.StorageCategoryView): (WebInspector.StorageCategoryView.prototype.setText):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:53 AM Changeset in webkit [89576] by kbalazs@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-23 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

PluginView::dispatchNPEvent is deceptive
https://bugs.webkit.org/show_bug.cgi?id=63243

Straighten the inverted logic of dispatchNPEvent
and it's callers.

No change in behaviour so no new tests.
Existing plugin tests cover this.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
8:48 AM Changeset in webkit [89575] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in
r88679.
https://bugs.webkit.org/show_bug.cgi?id=63205

This test does not fail on Windows, so add back in the passing expected results to get the
bots green.

  • platform/win-wk2/plugins/npruntime: Added.
  • platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
8:44 AM Changeset in webkit [89574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Export files under Symbian Qt WebKit build
https://bugs.webkit.org/show_bug.cgi?id=61207

Export files for the Symbian platform as this is needed by the
production build system.

Janne Koskinen provided the suggestion to use target_predeps,
which is an improvement over the originally suggested patch.

8:27 AM Changeset in webkit [89573] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=63122

Fixing broken makefile.

  • GNUmakefile.list.am:
8:20 AM Changeset in webkit [89572] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Crash when running EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62628

Call DocumentWriter::setEncoding when FrameLoaderClientEfl::finishedLoading()
like other ports.
It will clear parser not to crash when called endIfNotLoadingMainResource().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): (WebCore::FrameLoaderClientEfl::makeRepresentation): (WebCore::FrameLoaderClientEfl::revertToProvisionalState): (WebCore::FrameLoaderClientEfl::finishedLoading):
  • WebCoreSupport/FrameLoaderClientEfl.h:
8:19 AM Changeset in webkit [89571] by Adam Roben
  • 4 edits in trunk/Tools

Show closed bugs on the TestFailures page in addition to open ones

Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:

(Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
returned data.
(Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
the associated bug is still open.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(addQueryParametersToURL): Add a missing semicolon.
(Node.prototype.appendChildren): New function, like appendChild but takes an array-like
object and appends each of the values stored within.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
bugs will be included in the results. Split the returned bugs into two sets: those which are
open, and those which are closed. Put the open bugs at the top level of the list, and the
closed bugs in a second level.

7:58 AM Changeset in webkit [89570] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt
https://bugs.webkit.org/show_bug.cgi?id=63178

  • platform/qt/Skipped: Skip http/tests/inspector/extensions-resources-redirect.html until fix.
7:46 AM Changeset in webkit [89569] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r89503): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255

  • platform/qt/Skipped: Skip failing tests until fix.
7:34 AM Changeset in webkit [89568] by Adam Roben
  • 2 edits in trunk/Tools

Don't count new tests as failures on the TestFailures page

Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
they aren't

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
of failures.

7:23 AM Changeset in webkit [89567] by commit-queue@webkit.org
  • 22 edits
    10 moves in trunk/Source/WebCore

2011-06-23 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

MediaStream API: Rename Stream, GeneratedStream and StreamRecorder to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=63122

No new tests since no code has actually changed.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toMediaStream): (WebCore::EventTarget::toLocalMediaStream):
  • dom/EventTarget.h:
  • dom/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/GeneratedStream.cpp. (WebCore::LocalMediaStream::DispatchUpdateTask::create): (WebCore::LocalMediaStream::DispatchUpdateTask::performTask): (WebCore::LocalMediaStream::DispatchUpdateTask::DispatchUpdateTask): (WebCore::LocalMediaStream::create): (WebCore::LocalMediaStream::LocalMediaStream): (WebCore::LocalMediaStream::~LocalMediaStream): (WebCore::LocalMediaStream::toLocalMediaStream): (WebCore::LocalMediaStream::detachEmbedder): (WebCore::LocalMediaStream::streamEnded): (WebCore::LocalMediaStream::audioTracks): (WebCore::LocalMediaStream::videoTracks): (WebCore::LocalMediaStream::stop): (WebCore::LocalMediaStream::onStop):
  • dom/LocalMediaStream.h: Renamed from Source/WebCore/dom/GeneratedStream.h.
  • dom/LocalMediaStream.idl: Renamed from Source/WebCore/dom/GeneratedStream.idl.
  • dom/MediaStream.cpp: Renamed from Source/WebCore/dom/Stream.cpp. (WebCore::MediaStream::create): (WebCore::MediaStream::MediaStream): (WebCore::MediaStream::~MediaStream): (WebCore::MediaStream::toMediaStream): (WebCore::MediaStream::streamEnded): (WebCore::MediaStream::scriptExecutionContext): (WebCore::MediaStream::eventTargetData): (WebCore::MediaStream::ensureEventTargetData):
  • dom/MediaStream.h: Renamed from Source/WebCore/dom/Stream.h. (WebCore::MediaStream::readyState): (WebCore::MediaStream::label): (WebCore::MediaStream::refEventTarget): (WebCore::MediaStream::derefEventTarget):
  • dom/MediaStream.idl: Renamed from Source/WebCore/dom/Stream.idl.
  • dom/MediaStreamContainer.h: Renamed from Source/WebCore/dom/StreamContainer.h. (WebCore::MediaStreamContainer::create): (WebCore::MediaStreamContainer::~MediaStreamContainer): (WebCore::MediaStreamContainer::length): (WebCore::MediaStreamContainer::item): (WebCore::MediaStreamContainer::add): (WebCore::MediaStreamContainer::remove): (WebCore::MediaStreamContainer::contains): (WebCore::MediaStreamContainer::get): (WebCore::MediaStreamContainer::MediaStreamContainer):
  • dom/MediaStreamList.cpp: Renamed from Source/WebCore/dom/StreamList.cpp. (WebCore::MediaStreamList::create): (WebCore::MediaStreamList::MediaStreamList): (WebCore::MediaStreamList::~MediaStreamList): (WebCore::MediaStreamList::length): (WebCore::MediaStreamList::item):
  • dom/MediaStreamList.h: Renamed from Source/WebCore/dom/StreamList.h.
  • dom/MediaStreamList.idl: Renamed from Source/WebCore/dom/StreamList.idl.
  • dom/StreamEvent.cpp: (WebCore::StreamEvent::create): (WebCore::StreamEvent::StreamEvent): (WebCore::StreamEvent::initStreamEvent): (WebCore::StreamEvent::stream):
  • dom/StreamEvent.h: (WebCore::StreamEvent::isMediaStreamEvent):
  • dom/StreamEvent.idl:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::getStreamFromLabel): (WebCore::MediaStreamFrameController::stopGeneratedStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::audioTrackFailed): (WebCore::MediaStreamFrameController::videoTrackFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::isMediaStream): (WebCore::MediaStreamFrameController::ClientBase::isLocalMediaStream): (WebCore::MediaStreamFrameController::MediaStreamClient::MediaStreamClient): (WebCore::MediaStreamFrameController::MediaStreamClient::~MediaStreamClient): (WebCore::MediaStreamFrameController::MediaStreamClient::isMediaStream): (WebCore::MediaStreamFrameController::MediaStreamClient::isLocalMediaStream):
  • page/NavigatorUserMediaSuccessCallback.h:
  • page/NavigatorUserMediaSuccessCallback.idl:
7:02 AM Changeset in webkit [89566] by yurys@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89547.
http://trac.webkit.org/changeset/89547
https://bugs.webkit.org/show_bug.cgi?id=63252

"Chrmium crash on start" (Requested by yurys on #webkit).

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
  • wtf/DynamicAnnotations.h:
6:51 AM Changeset in webkit [89565] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for a newish accessibility test

The failure is tracked by <http://webkit.org/b/63191>.

  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
6:36 AM Changeset in webkit [89564] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: updated chromium expectations.

  • platform/chromium/test_expectations.txt:
6:31 AM Changeset in webkit [89563] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Inspector may close at the start of the next inspector test in DRT
https://bugs.webkit.org/show_bug.cgi?id=60881

  • platform/qt/Skipped: Unskip inspector tests after fix, skip still failing tests.
5:51 AM Changeset in webkit [89562] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
https://bugs.webkit.org/show_bug.cgi?id=63250

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):
5:48 AM Changeset in webkit [89561] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237

  • tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.

(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):

5:45 AM Changeset in webkit [89560] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245

  • tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.

(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):

5:26 AM Changeset in webkit [89559] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix conflicting chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:22 AM Changeset in webkit [89558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HTML preview in network panel should take 100% of resource view height.
https://bugs.webkit.org/show_bug.cgi?id=63167

  • inspector/front-end/inspector.css: (.resource-view.html iframe):
5:19 AM Changeset in webkit [89557] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: brush up chromium inspector expectations.

  • http/tests/inspector/inspector-test.js:
  • platform/chromium/test_expectations.txt:
5:02 AM Changeset in webkit [89556] by zherczeg@webkit.org
  • 4 edits in trunk

Inspector may close at the start of the next inspector test in DRT
https://bugs.webkit.org/show_bug.cgi?id=60881

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-23
Reviewed by Pavel Feldman.

Source/WebCore:

Add a new function to the inspector, which tests whether the
dispatch queue is empty.

  • inspector/front-end/inspector.js:

(WebInspector.dispatchQueueIsEmpty):

LayoutTests:

The didEvaluateForTestInFrontend function call is postponed until
all messages in the dispatch queue is processed.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.completeTest):

4:52 AM Changeset in webkit [89555] by sergio@webkit.org
  • 1 edit
    82 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, final round of baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-block-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/inline-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/replaced-min-max-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/width-replaced-element-001-expected.txt: Added.
4:44 AM Changeset in webkit [89554] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Unexpected passes in chromium expectations removed from excludes.

  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:27 AM Changeset in webkit [89553] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Chromium test expectations updated.

  • platform/chromium/test_expectations.txt:
4:14 AM Changeset in webkit [89552] by sergio@webkit.org
  • 1 edit
    124 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-non-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/float-replaced-width-011-expected.txt: Added.
3:59 AM Changeset in webkit [89551] by sergio@webkit.org
  • 1 edit
    104 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, more GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-017-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-024-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-030-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-031-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-020-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-027-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-034-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-036-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-041-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-043-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-048-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-050-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-055-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-057-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-062-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-064-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-069-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-071-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-replaced-width-076-expected.txt: Added.
3:44 AM Changeset in webkit [89550] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

2011-06-23 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Nikolas Zimmermann.

Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Added tests to make sure fallback color is used properly with invalid gradients.

  • svg/custom/invalid-gradient-with-xlink-expected.png: Added.
  • svg/custom/invalid-gradient-with-xlink-expected.txt: Added.
  • svg/custom/invalid-gradient-with-xlink.svg: Added.
  • svg/custom/xlink-to-invalid-gradient-expected.png: Added.
  • svg/custom/xlink-to-invalid-gradient-expected.txt: Added.
  • svg/custom/xlink-to-invalid-gradient.svg: Added.

2011-06-23 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Nikolas Zimmermann.

Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Added a check for gradient rendering contexts. If the contexts can't be found, the gradient must be in an invalid location, so we use the fallback color instead.

Tests: svg/custom/invalid-gradient-with-xlink.svg

svg/custom/xlink-to-invalid-gradient.svg

  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes):
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes):
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGRadialGradientElement.h:
3:35 AM Changeset in webkit [89549] by sergio@webkit.org
  • 1 edit
    48 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, another bunch of GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-016-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-017-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-020-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-022-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-width-024-expected.txt: Added.
3:24 AM Changeset in webkit [89548] by sergio@webkit.org
  • 1 edit
    49 adds in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, add GTK+ baselines for the new CSS2.1 tests added in r88913.

  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-height-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/gtk/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt: Added.
2:55 AM Changeset in webkit [89547] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-23 Timur Iskhodzhanov <timurrrr@google.com>

Reviewed by David Levin.

Make dynamic annotations weak symbols and prevent identical code folding by the linker
https://bugs.webkit.org/show_bug.cgi?id=62443

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
  • wtf/DynamicAnnotations.h:
2:54 AM Changeset in webkit [89546] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, rebaseline a couple of SVG tests for GTK+.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/gtk/svg/custom/pointer-events-text-expected.txt:
2:47 AM Changeset in webkit [89545] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating chromium expectations.

  • platform/chromium/fast/js/parser-xml-close-comment-expected.txt:
  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [89544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 Dmitriy Vyukov <dvyukov@google.com>

Reviewed by David Levin.

Fix incorrect usage of a condition variable.
https://bugs.webkit.org/show_bug.cgi?id=63127

No new tests. This does not affect existing
functionality.

  • storage/DatabaseTask.cpp: (WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
1:24 AM Changeset in webkit [89543] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Add new "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2 skipped list.

  • platform/mac-wk2/Skipped:
1:02 AM Changeset in webkit [89542] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: make TestInput objects printable
https://bugs.webkit.org/show_bug.cgi?id=63225

This makes debugging slighlty easier.

  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
12:20 AM Changeset in webkit [89541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-23 David Grogan <dgrogan@chromium.org>

Reviewed by Eric Seidel.

IndexedDB: add detail to an ASSERT error message
https://bugs.webkit.org/show_bug.cgi?id=60407

No new tests, this is just a debug ASSERT.

  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
Note: See TracTimeline for information about the timeline view.