Timeline


and

06/28/11:

23:54 Changeset [89993] by krit@webkit.org
  • 16 edits
    4 adds in trunk

2011-06-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGBoolean animation
https://bugs.webkit.org/show_bug.cgi?id=63529

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGBoolean.


The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgboolean-animation-1.html

  • CMakeLists.txt: Add new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedBoolean. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedBoolean.cpp: Added. New animator for SVGBoolean. (WebCore::SVGAnimatedBooleanAnimator::SVGAnimatedBooleanAnimator): (WebCore::SVGAnimatedBooleanAnimator::constructFromString): (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedBooleanAnimator::calculateDistance):
  • svg/SVGAnimatedBoolean.h: (WebCore::SVGAnimatedBooleanAnimator::~SVGAnimatedBooleanAnimator):
  • svg/SVGAnimatedType.cpp: Use bool for SVGBoolean. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createBoolean): (WebCore::SVGAnimatedType::boolean): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: New crate function for SVGAnimatedSVGBooleanAnimator. (WebCore::SVGAnimatorFactory::create):

2011-06-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGBoolean animation
https://bugs.webkit.org/show_bug.cgi?id=63529


Test animation of SVGBoolean. Add the test to the skip list of wk2.
Convert animate-number-calcMode-discrete-keyTimes to common style, no change
on the test itself.

  • platform/mac-wk2/Skipped:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html:
  • svg/animations/script-tests/svgboolean-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgboolean-animation-1-expected.txt: Added.
  • svg/animations/svgboolean-animation-1.html: Added.
23:46 Changeset [89992] by dglazkov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Make applyAuthorSheets settable on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=63599

Refactoring and adding not-yet used function, tests to follow when API lands.

  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): Added initializer. (WebCore::ShadowRoot::applyAuthorSheets): Made to use member variable. (WebCore::ShadowRoot::setApplyAuthorSheets): Added.
  • dom/ShadowRoot.h: Tweaked, added decls.
23:35 Changeset [89991] by isherman@chromium.org
  • 22 edits
    2 adds in trunk

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • fast/forms/autocomplete-expected.txt: Added.
  • fast/forms/autocomplete.html: Added.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
Rename the autoComplete() method for HTMLFormElement, HTMLFormControlElementWithState, and HTMLInputElement to shouldAutocomplete()
Add the autocomplete attribute to HTMLFormElement.idl and HTMLInputElement.idl
https://bugs.webkit.org/show_bug.cgi?id=35823

Test: fast/forms/autocomplete.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldAutocomplete): Renamed from ::autoComplete() (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Update callsite.
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): Update callsite. (WebCore::HTMLFormElement::parseMappedAttribute): Update callsite. (WebCore::HTMLFormElement::documentDidBecomeActive): Update callsite. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Update callsite. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Update callsite. (WebCore::HTMLFormElement::shouldAutocomplete): Renamed from ::autoComplete()
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl: Bind the autocomplete attribute to a JavaScript property.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldAutocomplete): Renamed from ::autoComplete()
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Bind the autocomplete attribute to a JavaScript property.
  • WebCore.exp.in: Updated autoComplete() -> shouldAutocomplete()

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): Update callsite.
  • src/WebFormElement.cpp: (WebKit::WebFormElement::autoComplete): Update callsite.
  • src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete): Update callsite.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Updated callsite.
23:06 Changeset [89990] by rolandsteiner@chromium.org
  • 15 edits
    8 deletes in trunk/LayoutTests

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: change URLs in ruby layout tests to lower case in order
to avoid having to have separate Chromium expectations.

  • fast/ruby/after-block-doesnt-crash-expected.txt:
  • fast/ruby/after-block-doesnt-crash.html:
  • fast/ruby/after-table-doesnt-crash-expected.txt:
  • fast/ruby/after-table-doesnt-crash.html:
  • fast/ruby/before-block-doesnt-crash-expected.txt:
  • fast/ruby/before-block-doesnt-crash.html:
  • fast/ruby/before-table-doesnt-crash-expected.txt:
  • fast/ruby/before-table-doesnt-crash.html:
  • fast/ruby/generated-after-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-after-counter-doesnt-crash.html:
  • fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-before-and-after-counter-doesnt-crash.html:
  • fast/ruby/generated-before-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-before-counter-doesnt-crash.html:
  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
23:05 Changeset [89989] by dglazkov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

Store shadowPseudoId in ElementRareData.
https://bugs.webkit.org/show_bug.cgi?id=63604

No new tests, because the code isn't yet used.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper.
  • css/CSSSelector.h: Added decl.
  • dom/Element.cpp: (WebCore::Element::shadowPseudoId): Changed to use ElementRareData. (WebCore::Element::setShadowPseudoId): Ditto.
  • dom/Element.h: Added decls.
  • dom/ElementRareData.h: Added a member to keep shadowPseudoId.
23:01 Changeset [89988] by bashi@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-28 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

[Chromium] Remove dependencies on harfbuzz from FontPlatformDataLinux and FontLinux
https://bugs.webkit.org/show_bug.cgi?id=62530

  • Moved codes of FontLinux which depend on harfbuzz APIs to ComplexTextController. Removed Some methods of ComplexTextController(advances() and logClusters()) since they are no longer needed.
  • Moved RefCountedHarfbuzzFace from FontPlatformDataLinux to HarfbuzzSkia and renamed it to HarfbuzzFace.

No new tests because there is no behavior change (The existing tests should cover the changes).

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): Added arguments so eliminating setter invocations. (WebCore::ComplexTextController::setupForRTL): Added. (WebCore::ComplexTextController::setupFontForScriptRun): Adopt the change of HarfbuzzFace class. (WebCore::ComplexTextController::setGlyphPositions): Use m_item.log_clusters instead of removed method. (WebCore::ComplexTextController::glyphIndexForXPositionInScriptRun): Added. (WebCore::ComplexTextController::offsetForPosition): Ditto. (WebCore::ComplexTextController::selectionRect): Ditto.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::width):
  • platform/graphics/chromium/FontLinux.cpp: Removed truncateFixedPointToInteger(). (WebCore::Font::drawComplexText): Removed setter invocations of ComplexTextController. (WebCore::Font::floatWidthForComplexText): Ditto. (WebCore::Font::offsetForPositionForComplexText): Moved harfbuzz dependent code to ComplexTextController. (WebCore::Font::selectionRectForComplexText): Ditto.
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::harfbuzzFace): Wrapped up HB_FaceRec in HarfbuzzFace class.
  • platform/graphics/chromium/FontPlatformDataLinux.h: Moved RefCountedHarfbuzzFace class and renamed to HarfbuzzFace.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::allocHarfbuzzFont): Moved from ComplexTextControllerLinux.cpp. (WebCore::HarfbuzzFace::HarfbuzzFace): Added. (WebCore::HarfbuzzFace::~HarfbuzzFace): Added.
  • platform/graphics/chromium/HarfbuzzSkia.h: (WebCore::HarfbuzzFace::create): Added. (WebCore::HarfbuzzFace::face): Added.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::substituteWithVerticalGlyphs): Adopt the change of HarfbuzzFace class.
23:00 Writing Layout Tests for DumpRenderTree edited by dominicc@chromium.org
Documented overridePreference. (diff)
21:34 Changeset [89987] by rolandsteiner@chromium.org
  • 3 edits
    6 adds in trunk

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930

Test that a generated block child + counter within a <ruby> doesn't crash.
(Test as provided by original reporter).

  • fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-after-counter-doesnt-crash.html: Added.
  • fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
  • fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-before-counter-doesnt-crash.html: Added.

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930

Don't set style type BEFORE/AFTER on anonymous wrapper block.
Rather, check style type on generated wrapped child.

Tests: fast/ruby/generated-after-counter-doesnt-crash.html

fast/ruby/generated-before-and-after-counter-doesnt-crash.html
fast/ruby/generated-before-counter-doesnt-crash.html

  • rendering/RenderRuby.cpp: (WebCore::isAnonymousRubyInlineBlock): (WebCore::isRubyBeforeBlock): (WebCore::isRubyAfterBlock): (WebCore::rubyBeforeBlock): (WebCore::rubyAfterBlock): (WebCore::createAnonymousRubyInlineBlock): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsBlock::addChild):
20:18 Changeset [89986] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT lacks array.length caching.
https://bugs.webkit.org/show_bug.cgi?id=63505

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::tryAllocate):
(JSC::DFG::JITCodeGenerator::selectScratchGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::tryAllocate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

19:41 Changeset [89985] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Pierre Rossi <pierre.rossi@gmail.com>

Reviewed by Eric Seidel.

Warnings in JSC's JIT on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=63259

Fairly straightforward, just use ASSERT_JIT_OFFSET_UNUSED when it applies.

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
18:28 Changeset [89984] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-28 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer position/size to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63578

Switch location and size methods for RenderLayer over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::offsetFromResizeCorner):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::location): (WebCore::RenderLayer::setLocation): (WebCore::RenderLayer::size): (WebCore::RenderLayer::setSize): (WebCore::RenderLayer::rect): (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::visibleHeight): (WebCore::RenderListBox::visibleWidth):
  • rendering/RenderListBox.h:
18:06 Changeset [89983] by leviw@chromium.org
  • 23 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintObject and paintReplaced to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63585

Switching paintObject and paintReplaced to layout type abstractions from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderImage.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
  • rendering/RenderListBox.h:
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::paintReplaced):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintObject):
  • rendering/RenderTextControl.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
  • rendering/RenderVideo.h:
18:03 Changeset [89982] by agl@chromium.org
  • 3 edits
    6 adds in trunk

2011-06-28 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Skip cache validation on back with HTTPS.
https://bugs.webkit.org/show_bug.cgi?id=63537

  • http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt: Added.
  • http/tests/cache/history-only-cached-subresource-loads-max-age-https.html: Added.
  • http/tests/cache/resources/max-age-resource-forward.html: Added.
  • http/tests/cache/resources/max-age-resource-next.html: Added.
  • http/tests/cache/resources/max-age-resource.html: Added.
  • http/tests/cache/resources/random-max-age.cgi: Added.

2011-06-28 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Skip cache validation on back with HTTPS.
https://bugs.webkit.org/show_bug.cgi?id=63537

For back navigations over HTTP, WebKit sets a flag to use cached data
irrespective of whether it has expired. However, this isn't currently
done for HTTPS.

The logic in question was added in
https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been
precautionary. However, both Firefox and IE will use this back
navigation trick for HTTPS as well and so we should probably behave
likewise.

Test: http/tests/cache/history-only-cached-subresource-loads-max-age-https.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
17:58 Changeset [89981] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Remove errant isShadowBoundary on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=63588

Removing dead code, no tests for that.

  • dom/ShadowRoot.h: Removed a function that's no longer used.
17:57 Changeset [89980] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Zeng Huiqing <huiqing.zeng@intel.com>

Reviewed by Kenneth Russell.

[chromium]Optimize GraphicsLayerChromium::setChildren()
https://bugs.webkit.org/show_bug.cgi?id=62837

No new tests.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
17:53 Changeset [89979] by leviw@chromium.org
  • 14 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxShadow and paintBoxDecorations to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63577

Switching paintBoxShadow and paintBoxDecorations to layout type abstraction
from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFieldset.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
17:49 Changeset [89978] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
17:44 WebKit Team edited by gavinp@chromium.org
add moi (diff)
17:40 WebKit Team edited by bweinstein@apple.com
(diff)
16:56 Changeset [89977] by eae@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-28 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBox position/size to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63571

Switch location and size methods for RenderBox over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderVideo.cpp:
  • rendering/RenderVideo.h:
16:52 Changeset [89976] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed build correction. Link to correct library for
the zlib1.dll.

  • win/tools/vsprops/WinCairo.vsprops: Don't link to the static

zlib.lib when building for WinCairo.

16:39 Changeset [89975] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • wtf/Platform.h:

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • WebCore.gyp/WebCore.gyp:
  • loader/cache/CachedFont.cpp:
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebCommon.h:
16:36 Changeset [89974] by leviw@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch PaintMask* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63576

Switching paintMask* to layout type abstraction from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBox.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask):
  • rendering/RenderTableCell.h:
16:26 Changeset [89973] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Fix sampling build
https://bugs.webkit.org/show_bug.cgi?id=63579

Gets opcode sampling building again, doesn't seem to work alas

  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::notifyOfScope):
  • bytecode/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::enableSampler):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable):
16:11 Changeset [89972] by diegohcg@webkit.org
  • 7 edits in trunk

2011-06-27 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=63496

Unskipped:

fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-attach-assertion.html
fast/forms/interactive-validation-assertion-by-validate-twice.html
fast/forms/interactive-validation-select-crash.html
fast/forms/interactive-validation-crash-by-style-override.html

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

LayoutTests:

  • platform/qt/Skipped:
16:06 Changeset [89971] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make new-run-webkit-tests -2 actually use WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=63572

new-run-webkit-tests -2 works with this change. However a zillion
tests fail since it can't find the right skipped lists for wk2.
The Skipped-list fixing is covered in bug 63501.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:41 Changeset [89970] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFillLayer* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63570

Switching painFillLayer* to layout type abstraction from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
15:33 Changeset [89969] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Use appropriate macro for CSSPropertyWebkitAppearance in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=63197

No new tests / no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro and delete duplicate code.
15:27 Changeset [89968] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
15:15 Changeset [89967] by japhet@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2011-06-28 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium test update for r89951.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
15:09 Changeset [89966] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Roben.

Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63500

Added google-mac-3 and google-mac-4.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:06 Changeset [89965] by eric@webkit.org
  • 10 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Dirk Pranke.

Remove webkitpy's tiger support now that WebKit no longer supports tiger
https://bugs.webkit.org/show_bug.cgi?id=63568

I don't think our support actually fully worked anyway. Regardless
tiger is dead now (thankfully)!

I also unwrapped some short lines and added a couple FIXMEs while
touring the code.

No new tests, only removing old ones which tested our Tiger support.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
14:51 Changeset [89964] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ASSERT when launching debug builds with interpreter and jit enabled
https://bugs.webkit.org/show_bug.cgi?id=63566

Add appropriate guards to the various Executable's memory reporting
logic.

  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
14:51 Changeset [89963] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing a typo.

Fix misspellings of "thead" to "thread".

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:44 Changeset [89962] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

This was accidentally fixed in bug 63501 as well.
The root problem here was that the webkit unit tests were not using
enough mocks. I've fixed them here to use more mocks
which should unbreak windows.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
14:33 Changeset [89961] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63563
DFG JIT - add support for double arith to speculative path

Reviewed by Oliver Hunt.

Add integer support for div & mod, add double support for div, mod,
add, sub & mul, dynamically selecting based on operand types.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::assembler):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::~SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::index):
(JSC::DFG::SpeculateDoubleOperand::fpr):

14:28 Changeset [89960] by jamesr@google.com
  • 10 edits in branches/chromium/782/Source

Merge 89635 - 2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost.
https://bugs.webkit.org/show_bug.cgi?id=63189
The main bug fix is to only set/wait latches if the child context has no errors.
Additionally, the LayerChromium classes needed to be modified to not continue drawing when
their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::isCompositorContextLost):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::updateCompositorResources): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost
https://bugs.webkit.org/show_bug.cgi?id=63189

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

BUG=84065
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7274032

14:18 Changeset [89959] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix interpreter build.

14:13 Changeset [89958] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
https://bugs.webkit.org/show_bug.cgi?id=63562

Some Qt auto-tests rely on <QtX/x.h> types of includes.

  • Api/qwebkitplatformplugin.h:
  • symbian/platformplugin/qwebkitplatformplugin.h:
14:06 Changeset [89957] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63561
DFG JIT - don't always assume integer in relational compare

Reviewed by Oliver Hunt.

If neither operand is known integer, or either is in double representation,
then at least use a function call (don't bail off the speculative path).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isDataFormatDouble):
(JSC::DFG::SpeculativeJIT::compareIsInteger):

13:47 Changeset [89956] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Patch by Oliver Hunt <oliver@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addConstantBuffer):
(JSC::CodeBlock::constantBuffer):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addConstantBuffer):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitNewArray):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

13:34 Changeset [89955] by japhet@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-28 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium test update for r89946.

  • platform/chromium/fast/regex: Added.
  • platform/chromium/fast/regex/constructor-expected.txt: Added.
13:21 Changeset [89954] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::addConstantBuffer): (JSC::CodeBlock::constantBuffer):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstantBuffer): (JSC::BytecodeGenerator::addStringConstant): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
13:09 Changeset [89953] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
13:09 QtWebKitContrib edited by ademar.reis@openbossa.org
(diff)
13:07 Changeset [89952] by rniwa@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Stop instantiating Position with PositionIsOffsetInAnchor in various files
https://bugs.webkit.org/show_bug.cgi?id=63384

Refactoring.

Removed many if conditions that compared the anchor type to Position::PositionIsOffsetInAnchor
because there were also checking that containerNode is a text node.

Also added Position::containerText() to avoid manually casting containerNode().

  • dom/Position.cpp: (WebCore::Position::Position): Added an assertion to ensure BeforeChildren/AfterChildren anchor type won't be used for a node whose contents is ignored by editing. (WebCore::Position::containerText): Added.
  • dom/Position.h:
  • editing/ApplyBlockElementCommand.cpp: (WebCore::isNewLineAtPosition): Removed a redundant comparison of anchor type. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Since containerNode is always a text node when renderStyleOfEnclosingTextNode returns a render style, use new Position constructor that takes Text* and offset. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Removed redundant comparison of anchor type and use new Position constructor that takes Text* and offset.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::splitTextAtStart): Replaced an assertion that compared anchor type by an assertion that the container node is a text node; use new constructor. (WebCore::ApplyStyleCommand::splitTextAtEnd): Ditto; also added early exits in the case script modified DOM. (WebCore::ApplyStyleCommand::splitTextElementAtStart): Ditto. (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto. (WebCore::ApplyStyleCommand::joinChildTextNodes): Use new constructor.
  • editing/CompositeEditCommand.cpp: (WebCore::Editor::replaceSelectedTextInNode): Calls containerText instead of manually casting containerNode.
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange): Call Range::startPosition instead of manually instantiating Position by calling startContainer and startOffset.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelectedRange): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls containerText instead of manually casting containerNode.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Calls containerText instead of manually casting containerNode.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Removed a redundant anchor type comparison. (WebCore::startVisiblePosition): Call Range::startPosition instead of startContainer and startOffset. (WebCore::endVisiblePosition): Call Range::endPosition instead of endContainer and endOffset.
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Call containerNode() to address <rdar://problem/5027702>. (WebCore::lastInSpecialElement): Ditto; use new constructor.
  • editing/visible_units.cpp: (WebCore::endPositionForLine): Use new constructor. (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
13:04 Changeset [89951] by rwlbuis@webkit.org
  • 6 edits
    19 adds in trunk

2011-06-28 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test text-tref-03-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63390

Support tref on forward referenced content by listening to DOMSubtreeModified events. This also
allows updating after modifications in the referenced content subtree.

Tests: svg/W3C-SVG-1.1-SE/text-tref-03-b.svg

svg/custom/text-tref-03-b-change-href-dom.svg
svg/custom/text-tref-03-b-change-href.svg
svg/custom/text-tref-03-b-dynamic.svg
svg/custom/text-tref-03-b-dynamic2.svg
svg/custom/text-tref-03-b-referenced-element-removal.svg
svg/custom/text-tref-03-b-tref-removal.svg

  • svg/SVGTRefElement.cpp: (WebCore::SubtreeModificationEventListener::create): (WebCore::SubtreeModificationEventListener::cast): (WebCore::SubtreeModificationEventListener::removeFromTarget): (WebCore::SubtreeModificationEventListener::SubtreeModificationEventListener): (WebCore::SubtreeModificationEventListener::operator==): (WebCore::SubtreeModificationEventListener::handleEvent): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::parseMappedAttribute): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::buildPendingResource): (WebCore::SVGTRefElement::removedFromDocument):
  • svg/SVGTRefElement.h:

2011-06-28 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test text-tref-03-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63390

  • text-tref-03-b.svg, the w3c SVG1.1 testcase mentioned in the bug.
  • text-tref-03-b-dynamic.svg, tests dynamically adding the tref.
  • text-tref-03-b-dynamic2.svg, tests dynamically adding the referenced content.
  • text-tref-03-b-tref-removal.svg, tests removal of tref.
  • text-tref-03-b-referenced-element-removal.svg, tests removal of referenced content.
  • text-tref-03-b-change-href.svg, tests changing href attribute dynamically through setAttribute.
  • text-tref-03-b-change-href-dom.svg, tests changing href attribute dynamically through href animated property.
  • foreignObject/text-tref-02-b.svg has improved result, but is still not perfect.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • svg/W3C-SVG-1.1-SE/text-tref-03-b.svg: Added.
  • svg/custom/text-tref-03-b-change-href-dom.svg: Added.
  • svg/custom/text-tref-03-b-change-href.svg: Added.
  • svg/custom/text-tref-03-b-dynamic-expected.txt: Added.
  • svg/custom/text-tref-03-b-dynamic.svg: Added.
  • svg/custom/text-tref-03-b-dynamic2-expected.txt: Added.
  • svg/custom/text-tref-03-b-dynamic2.svg: Added.
  • svg/custom/text-tref-03-b-referenced-element-removal.svg: Added.
  • svg/custom/text-tref-03-b-tref-removal.svg: Added.
12:37 Changeset [89950] by inferno@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Anders Carlsson.

Split the string creation into a local (while creating text runs)
so that it is not destroyed prematurely.
https://bugs.webkit.org/show_bug.cgi?id=63543

Run fast/forms/text-control-intrinsic-widths.html under valgrind/ASAN.

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::computePreferredLogicalWidths): this one is just done for caution, in case, we don't do the same mistake when adding legacy rounding hacks option.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
12:33 Changeset [89949] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests should not run mthml tests when MHTML support is disabled
https://bugs.webkit.org/show_bug.cgi?id=63549

This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
I happen to go looking for what code was deciding that .mht was a supported
extension, found test_files.py and then removed some redundant doc-strings and
if branching.

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:19 Changeset [89948] by commit-queue@webkit.org
  • 11 edits in trunk

2011-06-28 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Update migration LayoutTest to include indexes and successful migration.
https://bugs.webkit.org/show_bug.cgi?id=62780

  • storage/indexeddb/migrate-basics-expected.txt:
  • storage/indexeddb/migrate-basics.html:

2011-06-28 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Migrate SQLite backing store to LevelDB backing store for Indexeddb.
https://bugs.webkit.org/show_bug.cgi?id=62780

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::computeFileIdentifier): (WebCore::computeUniqueIdentifier): (WebCore::IDBFactoryBackendImpl::open): (WebCore::migrateObjectStores): (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::populateIndex):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h:
12:01 Changeset [89947] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-28 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Random crashes in fast/frames/ tests
https://bugs.webkit.org/show_bug.cgi?id=63459

Investigation on the crashes has revealed that sometimes, a frame could
have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
The root cause lies in the fact that the order of the two contiguous asynchronous
messages may not be respected on the receiving side. And it is Qt's implementation,
which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.

  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWork):
11:35 Changeset [89946] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=55040
RegExp constructor returns the argument regexp instead of a new object

Reviewed by Oliver Hunt.

Per 15.10.3.1, our current behaviour is correct if called as a function,
but incorrect when called as a constructor.

Source/JavaScriptCore:

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):

  • runtime/RegExpConstructor.h:

LayoutTests:

  • fast/regex/constructor-expected.txt: Added.
  • fast/regex/constructor.html: Added.
  • fast/regex/script-tests/constructor.js: Added.
11:31 Changeset [89945] by leviw@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Create intermediate classes as a path towards getting off of pixel offsets
https://bugs.webkit.org/show_bug.cgi?id=61896

Creating three intermediate typedefs to aid in moving layout and hit testing from integers
to floats. We'll transition the render tree over to these intermediate types and add
infrastructure to support the new types behind USE(FLOAT_LAYOUT_OFFSETS). This allows the ultimate
changeover to be easier.

Switching LayoutState over to this abstraction to verify it works correctly.

No new tests since this is creating a new abstraction, not changing current behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): (WebCore::LayoutState::pageLogicalOffset): (WebCore::LayoutState::addForcedColumnBreak):
  • rendering/LayoutState.h:
  • rendering/LayoutTypes.h: Added.
11:29 Changeset [89944] by rolandsteiner@chromium.org
  • 2 edits in trunk/Tools

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Tony Chang.

Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
https://bugs.webkit.org/show_bug.cgi?id=63514

  • change write_text_file to write_binary_file
  • check that text_path and binary_path are actually existant files
  • change cleanup block from 'except' to 'finally'
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
11:26 Changeset [89943] by macpherson@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Clean up integer clamping functions in MathExtras.h and support arbitrary numeric types and limits.
https://bugs.webkit.org/show_bug.cgi?id=63469

  • wtf/MathExtras.h: (defaultMinimumForClamp): Version of std::numeric_limits::min() that returns the largest negative value for floating point types. (defaultMaximumForClamp): Symmetric alias for std::numeric_limits::max() (clampTo): New templated clamping function that supports arbitrary output types. (clampToInteger): Use new clampTo template. (clampToFloat): Use new clampTo template. (clampToPositiveInteger): Use new clampTo template.
11:24 Changeset [89942] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
Looks like Visual Studio also re-sorted one more file since my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
11:21 Changeset [89941] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
10:55 Changeset [89940] by joone.hur@collabora.co.uk
  • 4 edits in trunk

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Rename 3D transforms to 3D rendering
https://bugs.webkit.org/show_bug.cgi?id=63508

WebKitGtk+ provides the 3D transforms feature, but it was
renamed to 3D Rendering. This features supports CSS 3D trasnforms.

  • configure.ac: Rename ENABLE_3D_TRANSFORMS to ENABLE_3D_RENDERING.

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Rename 3D transforms to 3D rendering
https://bugs.webkit.org/show_bug.cgi?id=63508

This patch allows to include ENABLE_3D_RENDERING to build WebKitGtk+.

  • GNUmakefile.am: Add ENABLE_3D_RENDERING
09:58 Changeset [89939] by jhawkins@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-27 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pass an optional WebNode that is the node receiving the context menu action.
https://bugs.webkit.org/show_bug.cgi?id=63503

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin):
  • src/WebFrameImpl.h:
09:48 Changeset [89938] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use column numbers when linking to script location in timeline and console.
https://bugs.webkit.org/show_bug.cgi?id=63126

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
09:27 Changeset [89937] by joone.hur@collabora.co.uk
  • 5 edits
    3 adds in trunk/Source

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Allow to build WebKitGtk+ with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=63404

WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

  • GNUmakefile.list.am:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp: Added. (WebCore::GraphicsLayer::create): Not implemented yet. (WebCore::GraphicsLayerClutter::GraphicsLayerClutter): (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter): (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto. (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
  • platform/graphics/clutter/GraphicsLayerClutter.h: Added.

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Allow to build WebKitGtk+ with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=63404

WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet. (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto. (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto. (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
  • WebCoreSupport/ChromeClientGtk.h:
09:23 Changeset [89936] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Better Windows rebaseline for the changes in r89864, with pixel results, to get the bots
green.

  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt:
09:08 Changeset [89935] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs to implement undo client (Windows).
https://bugs.webkit.org/show_bug.cgi?id=58103

Add another undo test to the win-wk2 skipped list to get the bots green.

  • platform/win-wk2/Skipped:
09:01 Changeset [89934] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Stephen White <senorblanco@chromium.org>

Unreviewed.

Remove some now-passing tests from Chromium's test expectations.

  • platform/chromium/test_expectations.txt:
08:56 Changeset [89933] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63512

Reviewed by Darin Adler.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
before this function is called.

08:42 Changeset [89932] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

2011-06-27 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Avoid attempt to create a zero-size DIB.
https://bugs.webkit.org/show_bug.cgi?id=63484.

  • WebNodeHighlight.cpp: (WebNodeHighlight::update): Check for zero-height (or zero-width) region for DIB, and exit early if attempting to create a zero-size DIB/BITMAP.
08:24 Changeset [89931] by caseq@chromium.org
  • 4 edits
    1 delete in trunk

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt
https://bugs.webkit.org/show_bug.cgi?id=63178

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
  • platform/qt/Skipped:
08:15 Changeset [89930] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Fix the test added by the previous commit. Also add it to the WebKit2's skipped list
since it uses a eventSender method that hasn't been implemented by TestRunner.

  • fast/events/selectstart-prevent-selection-on-right-click.html:
  • platform/mac-wk2/Skipped:
08:09 Changeset [89929] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Add a test for canceling selectstart when a word is selected by right click
https://bugs.webkit.org/show_bug.cgi?id=63530

Add a regression now that the bug no longer reproduces.

  • fast/events/selectstart-prevent-selection-on-right-click-expected.txt: Added.
  • fast/events/selectstart-prevent-selection-on-right-click.html: Added.
07:51 Changeset [89928] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Stephen White <senorblanco@chromium.org>

Unreviewed.

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
07:39 Changeset [89927] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows Debug build fix after r89885

JSGlobalData::releaseExecutableMemory for jsc.exe's benefit.

07:39 Changeset [89926] by aroben@apple.com
  • 4 edits in trunk/Tools

Roll out r89924 and r89925

I didn't mean to commit them!

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
07:34 Changeset [89925] by aroben@apple.com
  • 2 edits in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures

Keep track of all builds

07:33 Changeset [89924] by aroben@apple.com
  • 3 edits in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures

Start categorizing flaky tests

07:22 Changeset [89923] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
https://bugs.webkit.org/show_bug.cgi?id=63533

We need to use the new QtQuick 1.x imports rather than the old deprecated
version.

  • tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
  • tests/qdeclarativewebview/resources/webviewtest.qml:
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml:
05:07 Changeset [89922] by apavlov@chromium.org
  • 11 edits in trunk

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
04:42 Changeset [89921] by kbalazs@webkit.org
  • 4 edits in trunk

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] X error with plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63520

  • platform/qt-wk2/Skipped:

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] X error with plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63520

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Never create a pixmap with (0,0) dimensions. (WebKit::NetscapePlugin::platformGeometryDidChange): (WebKit::NetscapePlugin::platformPaint):
04:38 Changeset [89920] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

2011-06-28 Michal Pakula vel Rutka <m.pakula@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement EditorClientEfl::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=63525

This patch:

  • implements EditorClientEfl::respondToChangedSelection,
  • adds ewk_frame_editor_client_selection_changed and
  • ewk_view_editor_client_selection_changed
  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::respondToChangedSelection):
  • ewk/ewk_frame.cpp: (ewk_frame_editor_client_selection_changed):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_editor_client_selection_changed):
02:59 Changeset [89919] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Verify cloning elements with validation messages works.
https://bugs.webkit.org/show_bug.cgi?id=61988

  • fast/forms/validation-message-clone-expected.txt: Added.
  • fast/forms/validation-message-clone.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
02:54 Changeset [89918] by commit-queue@webkit.org
  • 1 edit
    1 move
    1 add
    11 deletes in trunk/LayoutTests

2011-06-28 Wyatt Carss <wcarss@chromium.org>

Reviewed by Hajime Morita.

convert editing/deleting/4845371.html to runDumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=63214

Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents.html
and converted editing/deleting/delete-cell-contents.html to runDumpAsTextEditingTest; left
it without a doctype, etc, because they changed functionality of the image test. Also
added the rdar number.

  • editing/deleting/delete-cell-contents-expected.txt: Added.
  • editing/deleting/delete-cell-contents.html: Added.
  • editing/deleting/4845371.html: Removed.
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-win/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-win/editing/deleting/4845371-expected.txt: Removed.
  • platform/gtk/editing/deleting/4845371-expected.png: Removed.
  • platform/gtk/editing/deleting/4845371-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/4845371-expected.png: Removed.
  • platform/mac/editing/deleting/4845371-expected.png: Removed.
  • platform/mac/editing/deleting/4845371-expected.txt: Removed.
  • platform/qt/editing/deleting/4845371-expected.png: Removed.
  • platform/qt/editing/deleting/4845371-expected.txt: Removed.
02:53 Changeset [89917] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Fix a build error on Mac by r89907.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::endListChanged):
02:52 Changeset [89916] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] SELECT or autofill popup is trimmed by screen edge on Windows
https://bugs.webkit.org/show_bug.cgi?id=63438

If the popup is calculated to be trimmed by a screen edge, an attempt is made
to alter its vertical edge alignment (set to the right edge for LTR or to the left edge for RTL)
to see if the trimmed portion becomes smaller than that with the original layout.
The change involves remembering the original frameRect for the popup and restoring it in refresh().
This is due to the fact that the frameRect originally set in showInRect() is overwritten
by layoutAndGetRTLOffset(), which breaks the originally requested popup container layout metrics.
The max width is reset on every layoutAndCalculateWidgetRect(), as it can be constrained by the screen edge,
and thus should be re-checked every time the popup is displayed, in case the browser window has been moved.

Tests: manual-tests/popup-width-restriction-within-screen.html partly covers the fix (should not regress).
Other than that, there is no way to unit-test the platform-specific native code.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setMaxWidth): Added. Avoid duplicate popup content layouts (in contrast with setMaxWidthAndLayout()). (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Attempt a left-right popup alignment inversion to minimize the trimmed content. Also restore a default max popup width. (WebCore::PopupContainer::layoutAndGetRTLOffset): Always return the popup listbox offset for the RTL (right alignment) case. The method rename is due to the return value semantics change. (WebCore::PopupContainer::showInRect): Store the originally requested frameRect for the popup. (WebCore::PopupContainer::refresh): Restore the original popup frameRect to avoid layout artifacts on refresh. (WebCore::PopupContainer::isRTL): This check should be made by the layoutAndGetRTLOffset() clients.
  • platform/chromium/PopupMenuChromium.h:
02:46 Changeset [89915] by commit-queue@webkit.org
  • 8 edits in trunk

2011-06-28 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Allow spaces between e-mail addresses in 'email' input type.
https://bugs.webkit.org/show_bug.cgi?id=55987

Allowed spaces between e-mail addresses in 'email' input type,
e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
value sanitization algorithm for an e-mail value. Added more unit
tests that check the e-mail value parser.

  • fast/forms/ValidityState-typeMismatch-email-expected.txt:
  • fast/forms/resources/ValidityState-typeMismatch-email.js:

2011-06-28 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Allow spaces between e-mail addresses in 'email' input type.
https://bugs.webkit.org/show_bug.cgi?id=55987

Allowed spaces between e-mail addresses in 'email' input type,
e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
value sanitization algorithm for an e-mail value. Added more unit
tests that check the e-mail value parser.

Test: fast/forms/ValidityState-typeMismatch-email.html

  • html/EmailInputType.cpp: (WebCore::EmailInputType::typeMismatchFor): (WebCore::EmailInputType::sanitizeValue):
  • html/EmailInputType.h:
  • html/parser/HTMLParserIdioms.cpp: (WebCore::stripHTMLLineBreaks):
  • html/parser/HTMLParserIdioms.h: (WebCore::isHTMLLineBreak):
02:44 Changeset [89914] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Qt specific results committed in r89901, but some of them fail on Qt-WK2 and/or Qt-Mac platform

  • platform/qt-mac/Skipped: Skip failing tests and typo fix.
  • platform/qt-wk2/Skipped: Skip failing tests.
02:30 Changeset [89913] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Refactor RenderTextControl::text().
https://bugs.webkit.org/show_bug.cgi?id=63519

No new tests because this is just a refactoring.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): Resuce the number of text() calls. (WebCore::finishText):
    • Use StringBuilder.
    • Make this a static function. This function doesn't access anything of RenderTextControl.

(WebCore::RenderTextControl::text):

Use emptyString() and StringBuilder.

(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.

  • rendering/RenderTextControl.h: Remove finishText().
02:28 Changeset [89912] by yurys@chromium.org
  • 5 edits in trunk

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console.group messages should never be coalesced
https://bugs.webkit.org/show_bug.cgi?id=63521

  • inspector/console/console-nested-group-expected.txt:
  • inspector/console/console-nested-group.html:

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console.group messages should never be coalesced
https://bugs.webkit.org/show_bug.cgi?id=63521

  • inspector/InspectorConsoleAgent.cpp: (WebCore::isGroupMessage): (WebCore::InspectorConsoleAgent::addConsoleMessage):
02:26 Changeset [89911] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console group boundaries should be more distinct in UI
https://bugs.webkit.org/show_bug.cgi?id=63455

Show grey bracket to on the left side of a console group message to highlight
the group extent.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup):
  • inspector/front-end/inspector.css: (#console-prompt): (.console-message, .console-user-command): (.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before): (.console-group-title::before): (.console-group): (.console-group-bracket): (.console-group.collapsed > .console-group-bracket):
02:20 Changeset [89910] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Use RefPtr for the HTMLElement data members of TextFieldInptType
and SearchInputType.
https://bugs.webkit.org/show_bug.cgi?id=63511

No new tests because of no behavior change.

  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): No need to initialize the element members explicitly because RefPtr constructor works well. (WebCore::SearchInputType::createShadowSubtree): Substitute an element to a data member, and don't call RefPtr<>::release(). (WebCore::SearchInputType::innerBlockElement): Moved from the header file, and adjustment for RefPtr<>. (WebCore::SearchInputType::resultsButtonElement): ditto. (WebCore::SearchInputType::cancelButtonElement): ditto. (WebCore::SearchInputType::destroyShadowSubtree): Adjustment for RefPtr<>.
  • html/SearchInputType.h:
    • Move accessor functions to the cpp file because they are virtual.
    • Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): No need to initialize the element members explicitly because RefPtr constructor works well. (WebCore::TextFieldInputType::~TextFieldInputType): Explicityly defines the destructor in the cpp file to avoid to make it implicitly in the header file. If the destructor was made in the header file, we would need to include HTMLElement.h in the header file. (WebCore::TextFieldInputType::createShadowSubtree):
  • Don't call RenderTheme::themeForPage().
  • Substitute an element to a data member, and don't call RefPtr<>::release(). (WebCore::TextFieldInputType::setInnerTextElement): Moved from the header file to avoid to include HTMLElement.h. (WebCore::TextFieldInputType::setSpeechButtonElement): ditto. (WebCore::TextFieldInputType::innerTextElement): Moved from the header file, and adjustment for RefPtr<>. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Adjustment for RefPtr<>.
  • html/TextFieldInputType.h:
    • Move accessor functions to the cpp file because they are virtual.
    • Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
02:19 Changeset [89909] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Pavel Feldman <pfeldman@google.com>

Not reviewed: added chromium test suppression.

  • platform/chromium/test_expectations.txt:
02:12 Changeset [89908] by kbalazs@webkit.org
  • 4 edits in trunk

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] plugins/plugin-javascript-access fails
https://bugs.webkit.org/show_bug.cgi?id=63464

  • platform/qt-wk2/Skipped:

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] plugins/plugin-javascript-access fails
https://bugs.webkit.org/show_bug.cgi?id=63464

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Determine the name of the plugin.
01:58 Changeset [89907] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-28 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation flickers when restarting
https://bugs.webkit.org/show_bug.cgi?id=18450

Add new parameter to the following methods. The new parameter is the time of adding a "begin" or "end" time to the SVG animation.

  • WebCore::SVGSMILElement::addBeginTime
  • WebCore::SVGSMILElement::beginListChanged
  • WebCore::SVGSMILElement::addEndTime
  • WebCore::SVGSMILElement::endListChanged

In case of beginTime and beginListChanged it's necessary, because the delay between the event of adding a new begin time
(in WebCore::SVGAnimationElement::beginElementAt) and the actual processing (in WebCore::SVGSMILElement::endListChanged)
is significant. In lack of event time we can't decide that we should consider the new time or not.
If the new begin time is smaller than the event time, we musn't begin the animation, else we shoud do further calculations.

The following methods just modified for consistency:

  • WebCore::SVGSMILElement::addEndTime
  • WebCore::SVGSMILElement::endListChanged

No new tests, because currently there is no way to test SVG flickering at zero time.

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElementAt):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::attributeChanged): (WebCore::SVGSMILElement::addBeginTime): (WebCore::SVGSMILElement::addEndTime): (WebCore::SVGSMILElement::beginListChanged): (WebCore::SVGSMILElement::endListChanged): The body changed:
    • Use new parameter, the time of adding the new begin time.
    • Cancel some incorrect optimalization. We should also do further calculations when elapsed >= m_intervalBegin.

(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
(WebCore::SVGSMILElement::handleConditionEvent):
(WebCore::SVGSMILElement::beginByLinkActivation):

  • svg/animation/SVGSMILElement.h:
01:53 Changeset [89906] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-28 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

Add const to show() method in WTFString and AtomicString.
https://bugs.webkit.org/show_bug.cgi?id=63515

The lack of const in show() method is painful when
doing something like printf-debug.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::show):
  • wtf/text/AtomicString.h:
  • wtf/text/WTFString.cpp: (String::show):
  • wtf/text/WTFString.h:
01:48 Changeset [89905] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Change permission of some ewk files.
https://bugs.webkit.org/show_bug.cgi?id=63517

Change some file's permission same with other file's.

  • ewk/ewk_tiled_backing_store.c:
  • ewk/ewk_tiled_model.c:
  • ewk/ewk_view_single.c:
01:46 Changeset [89904] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

Reviewed by Andreas Kling.

  • features.pri: Disable MHTML on Qt by default in a proper way.
01:46 Changeset [89903] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove ENABLE_XBL, because there aren't ENABLE(XBL) macros anymore.

Reviewed by Andreas Kling.

  • features.pri:
01:02 Changeset [89902] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/link-rel-icon-beforeload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=63518

  • platform/qt/Skipped: Add http/tests/misc/link-rel-icon-beforeload.html until fix.
00:55 Changeset [89901] by ossy@webkit.org
  • 2 edits
    30 adds in trunk/LayoutTests

[Qt] Unreviewed daily gardening. Add platform specific expected files
for new passing tests and add failing new tests to the Skipped list.

  • platform/qt/Skipped:
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/qt/fast/css/color-leakage-expected.png: Added.
  • platform/qt/fast/css/color-leakage-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/qt/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/qt/svg/custom/invalid-dasharray-expected.txt: Added.
  • platform/qt/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/qt/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
00:35 Changeset [89900] by kbalazs@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

WebKitTestRunner needs layoutTestController.setCallCloseOnWebViews
https://bugs.webkit.org/show_bug.cgi?id=46714

Skip these tests via the mac list to make them skipped on every wk2 platform.

  • platform/mac-wk2/Skipped:
  • platform/win-wk2/Skipped:
00:30 Changeset [89899] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
00:25 Changeset [89898] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 89595
BUG=87227
Review URL: http://codereview.chromium.org/7274018

06/27/11:

23:46 Changeset [89897] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89881.
http://trac.webkit.org/changeset/89881
https://bugs.webkit.org/show_bug.cgi?id=63513

Makes Qt massively slow (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
23:02 Changeset [89896] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 89780
BUG=86648
Review URL: http://codereview.chromium.org/7273023

22:55 Changeset [89895] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Source/JavaScriptCore: Build fix attempt after r89885.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-06-27

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=50554
RegExp.prototype.toString does not escape slashes

Reviewed by Darin Adler & Oliver Hunt.

The problem here is that we don't escape forwards slashes when converting
a RegExp to a string. This means that RegExp("/").toString() is "/",
which is not a valid RegExp literal. Also, we return an invalid literal
for RegExp.prototype.toString() ("
", which is an empty single-line comment).

From ES5:
"NOTE: The returned String has the form of a RegularExpressionLiteral that
evaluates to another RegExp object with the same behaviour as this object."

Added test cases.

  • fast/regex/script-tests/toString.js: Added.

(testFwdSlash):

  • fast/regex/toString-expected.txt: Added.
  • fast/regex/toString.html: Added.
22:39 Changeset [89894] by yutak@chromium.org
  • 5 edits in trunk/Source/WebKit2

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

[WebKit2] Add hixie76WebSocketProtocolEnabled flag to WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=63447

Make a new flag added in WebCore::Settings (useHixie76WebSocketProtocol)
switchable from WebPage and WebPreferences.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetHixie76WebSocketProtocolEnabled): (WKPreferencesGetHixie76WebSocketProtocolEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
22:35 Changeset [89893] by cevans@google.com
  • 1 edit
    36 copies in branches/chromium/782

Merge 89836
BUG=87148
Review URL: http://codereview.chromium.org/7253035

22:13 Changeset [89892] by cevans@google.com
  • 2 edits
    3 copies in branches/chromium/782

Merge 89782
BUG=87339
Review URL: http://codereview.chromium.org/7273022

22:08 Changeset [89891] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium baselines update.

  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
22:02 Changeset [89890] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error related to wrong include order.

  • platform/graphics/efl/ImageEfl.cpp:
21:30 Changeset [89889] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

[chromium] editing/style/smoosh-styles-003.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=63509

Don't let spellcheck kick in this test because it's nothing to do with spellcheck.

  • editing/style/smoosh-styles-003.html:
21:19 Changeset [89888] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
20:43 WebAPIReviewChecklist edited by rniwa@webkit.org
(diff)
19:30 Changeset [89887] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Build fix attempt after r89885.

19:19 Changeset [89886] by rniwa@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Fix r89879.

  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt.
18:32 Changeset [89885] by oliver@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

2011-06-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Support throwing away non-running code even while other code is running
https://bugs.webkit.org/show_bug.cgi?id=63485

Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.

The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls): (JSC::CodeBlock::clearEvalCache):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::unlink):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::clear):
  • heap/Heap.cpp: (JSC::Heap::getConservativeRegisterRoots):
  • heap/Heap.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
  • jit/JITWriteBarrier.h: (JSC::JITWriteBarrierBase::clear):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionReleaseExecutableMemory):
  • runtime/Executable.cpp: (JSC::EvalExecutable::unlinkCalls): (JSC::ProgramExecutable::unlinkCalls): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::unlinkCalls):
  • runtime/Executable.h:
  • runtime/JSGlobalData.cpp: (JSC::SafeRecompiler::returnValue): (JSC::SafeRecompiler::operator()): (JSC::JSGlobalData::releaseExecutableMemory):
18:16 Changeset [89884] by leviw@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Renaming incorrectly named linux test expectation.

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png.
18:12 Changeset [89883] by commit-queue@webkit.org
  • 1 edit
    2 moves
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5156801-2.html to dumpAsText and rename
https://bugs.webkit.org/show_bug.cgi?id=63359

converted editing/deleting/5156801-2.html to dump-as-markup test, with
new results. Renamed 5156801.html to delete-node-after-DOMNodeRemoved,
and 5156801-2.html to delete-table-cell-contents.html; they were only
noticeably related by their rdar number, which is now included in each.

  • editing/deleting/5156801.html: Removed.
  • editing/deleting/5156801-expected.txt: Removed.
  • editing/deleting/5156801-2.html: Removed.
  • editing/deleting/delete-node-after-DOMNodeRemoved.html: Added.
  • editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt: Added.
  • editing/deleting/delete-table-cell-contents.html: Added.
  • editing/deleting/delete-table-cell-contents-expected.txt: Added.
  • platform/chromium-linux/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.png: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.txt: Removed.
17:34 Changeset [89882] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63497
Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:33 Changeset [89881] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
17:15 Changeset [89880] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the WebCore vcproj file after r89851.

  • WebCore.vcproj/WebCore.vcproj:
17:08 Changeset [89879] by leviw@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Windows rebaseline for my commit r89864.

  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
16:57 Changeset [89878] by joepeck@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Allow non-main thread text drawing in ICU ports
https://bugs.webkit.org/show_bug.cgi?id=63482

Some ports allow multiple threads to draw strings.
LineBreakIteratorPool is not thread safe and the existing
ASSERT caught cases where multiple threads were trying
to access the shared pool. This makes the pool a lazily
created per-thread pool to allow for thread safe pool use.

  • platform/ThreadGlobalData.h:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): start with null. (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create. (WebCore::ThreadGlobalData::destroy): delete. Manage the lifetime of the per-thread pool instance.
  • platform/text/LineBreakIteratorPoolICU.h: (WebCore::LineBreakIteratorPool::sharedPool): Use the per-thread pool instance and remove the ASSERT that this needs to be on the main thread.

(WebCore::LineBreakIteratorPool::create):
Create a PassOwnPtr so we can use OwnPtr on pools.

(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
Private now that there is a public create function.

16:50 Changeset [89877] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89864

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Added.
16:26 Changeset [89876] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Tests that a plugin of a swf file in a hidden iframe will not
crash. This test required more than 1 content file and a
timeout or else it would not repeat the error condition.

This test will only crash on platforms (like Symbian) that
don't allow nonvirtual functions to have a null this pointer.

  • plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
  • plugins/hidden-iframe-with-swf-plugin.html: Added.
  • plugins/resources/iframe-content-with-swf-plugin.html: Added.

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".

Test: plugins/hidden-iframe-with-swf-plugin.html

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
16:16 Changeset [89875] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Juan C. Montemayor <jmont@apple.com>

Reviewed by Mark Rowe.

Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
https://bugs.webkit.org/show_bug.cgi?id=63392

When both TextPosition.h and XPathGrammar.h are included a compile-error
is caused, since XPathGrammar.h defines a macro called NUMBER and
TextPosition has a typedef named NUMBER.

  • wtf/text/TextPosition.h: (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition):
16:09 Changeset [89874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Raymes Khoury <raymes@chromium.org>

Reviewed by Tony Chang.

WebCore fails to compile in thumb mode when neon instructions are
enabled.

There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
which fail to build when -mthumb is passed to gcc. These contain inline
assembly for neon instructions on arm. This patch forces the -marm flag
to be passed when compiling these files to work around this.

https://bugs.webkit.org/show_bug.cgi?id=62916

Built WebKit in Chromium and checked that -marm is passed
only when building these files.

https://bugs.webkit.org/show_bug.cgi?id=62916

  • WebCore.gyp/WebCore.gyp:
16:05 Changeset [89873] by abarth@webkit.org
  • 7 edits in trunk

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

NRWT used to have a different name for crash logs. I've changed the
name to patch ORWT.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
15:52 Changeset [89872] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
15:51 Changeset [89871] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations update.

  • platform/chromium/fast/js/recursion-limit-equal-expected.txt: Rebaseline after r89842.
15:31 Changeset [89870] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
https://bugs.webkit.org/show_bug.cgi?id=63486

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
15:18 Changeset [89869] by jcivelli@chromium.org
  • 12 edits
    2 adds in trunk

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • mhtml/multi_frames_binary.mht: Added.
  • platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::MHTMLArchive::generateMHTMLData): (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp: (WebCore::MHTMLParser::parseNextPart):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:
  • platform/network/MIMEHeader.cpp: (WebCore::MIMEHeader::parseContentTransferEncoding):
  • platform/network/MIMEHeader.h:

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML): (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):
15:17 Changeset [89868] by eric@webkit.org
  • 16 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
15:15 Changeset [89867] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Really fix the revision number in the last entry

15:14 Changeset [89866] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix revision number that I referenced in my last checkin

15:11 Changeset [89865] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process always pauses on launch
https://bugs.webkit.org/show_bug.cgi?id=63487

Reviewed by Oliver Hunt.

In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
web process to pause if the shift and alt keys were not held down.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Add some parentheses.

15:01 Changeset [89864] by leviw@chromium.org
  • 9 edits
    4 adds in trunk

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949
Adding support for the 'plaintext' mode of unicode-bidi.

  • fast/text/international/unicode-bidi-plaintext.html: Added.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: added
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949

Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
of the Unicode BiDi algorithm on each paragraph of a block with that style.
This is similar to dir=auto but done per-paragraph instead of per element.

Test: fast/text/international/unicode-bidi-plaintext.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Added plaintext.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • html/HTMLElement.cpp: (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto to their proper unicode-bidi attribute. (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea when dir=auto.
  • platform/text/UnicodeBidi.h: Added plaintext.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::determineParagraphDirection): Determines the direction of a paragraph based on the first strong character. Stops at first paragraph separator. (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection when in unicode-bidi: plaintext mode (and operating at the block's BidiContext) to set each paragraph to the proper base BidiContext. (WebCore::RenderBlock::determineStartPosition): Ditto.
  • rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate for plaintext.
14:45 Changeset [89863] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89745.

I checked these results with Rob - they are not failing expected results.

  • platform/win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/win/svg/custom/linking-uri-01-b-expected.txt: Added.
14:38 Changeset [89862] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/whitespace-pre-1.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63372

converted editing/deleting/whitespace-pre-1.html to dump-as-markup, removed
old baselines, and added the new one.

  • editing/deleting/whitespace-pre-1-expected.txt: Added.
  • editing/deleting/whitespace-pre-1.html:
  • platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.txt: Removed.
14:38 Changeset [89861] by commit-queue@webkit.org
  • 12 edits in trunk/Source/JavaScriptCore

2011-06-27 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform put_by_id caching.
https://bugs.webkit.org/show_bug.cgi?id=63409

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchByIdSelfAccess): (JSC::DFG::tryCacheGetByID): (JSC::DFG::appropriatePutByIdFunction): (JSC::DFG::tryCachePutByID): (JSC::DFG::dfgRepatchPutByID):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
14:32 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
14:27 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
14:24 Changeset [89860] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

14:23 Changeset [89859] by lforschler@apple.com
  • 1 copy in tags/Safari-534.50.1

New tag.

14:23 Changeset [89858] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

No new tests, it's just a little cosmetic change.

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

  • WebCoreSupport/QTKitFullScreenVideoHandler.mm:
14:22 Changeset [89857] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r89748.

14:21 Changeset [89856] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89769.

I checked these results with Dan - they are not failing expected results.

  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
14:20 Changeset [89855] by lforschler@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r89718.

14:20 Changeset [89854] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests does not report stderr output
https://bugs.webkit.org/show_bug.cgi?id=37739

Almost all the infrastructure appears to be in place to report stderr
in results.html. We just need to wire up a bool to tell results.html
to create the hyperlink.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
14:19 Changeset [89853] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

14:18 Changeset [89852] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

webkitpy unit tests should have more descriptive names than just "Test"
https://bugs.webkit.org/show_bug.cgi?id=63479

Luckily we kept these classes in separate namespaces in the harness so
we were actually running them all even though they had the same name.

  • Scripts/webkitpy/common/system/stack_utils_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
14:09 Changeset [89851] by joepeck@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Extract LineBreakIteratorPool class into its own file
https://bugs.webkit.org/show_bug.cgi?id=63471

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add the new file to builds that used TextBreakIteratorPoolICU.h.
  • platform/text/LineBreakIteratorPoolICU.h: Added. (WebCore::LineBreakIteratorPool::sharedPool): (WebCore::LineBreakIteratorPool::LineBreakIteratorPool): Expose the constructor so it can be used by others.
  • platform/text/TextBreakIteratorICU.cpp: Remove the old LineBreakIteratorPool implementation.
13:57 Changeset [89850] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implemenation of allowRoundingHacks.
https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks.html to the mac-wk2 skipped list to get the bots
green.

  • platform/mac-wk2/Skipped:
13:57 Changeset [89849] by leviw@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Greg Simon <gregsimon@chromium.org>

No review necessary.

Add email addr to contributor list
https://bugs.webkit.org/show_bug.cgi?id=63478

  • Scripts/webkitpy/common/config/committers.py:
13:53 Changeset [89848] by commit-queue@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89834.
http://trac.webkit.org/changeset/89834
https://bugs.webkit.org/show_bug.cgi?id=63476

Broke test-webkitpy (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/system/outputcapture.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
13:18 Changeset [89847] by jeffm@apple.com
  • 4 edits in trunk/Tools

2011-06-27 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Stop copying obsolete WebKit libraries on Windows
https://bugs.webkit.org/show_bug.cgi?id=63474


Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.

  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  • MiniBrowser/MiniBrowserPostBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
13:14 Changeset [89846] by inferno@chromium.org
  • 1 edit
    48 adds in trunk/LayoutTests

2011-06-27 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89836.

  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
12:39 Changeset [89845] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Add Wyatt Carss to the list of non-committer contributors.

  • Scripts/webkitpy/common/config/committers.py:
12:08 Changeset [89844] by justin.garcia@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Justin Garcia <justin.garcia@apple.com>

Reviewed by Ryosuke Niwa.

CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
https://bugs.webkit.org/show_bug.cgi?id=62921

  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
11:47 Changeset [89843] by abarth@webkit.org
  • 6 edits
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkitpy should understand crash logs
https://bugs.webkit.org/show_bug.cgi?id=63468

We're planning to use this functionality to upload crash logs along
with test results for new-run-webkit-tests.

  • Scripts/webkitpy/common/system/crashlog.py: Added.
  • Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:40 Changeset [89842] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

The fast/js/recursion-limit-equal test is too fragile
https://bugs.webkit.org/show_bug.cgi?id=63352

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-27
Reviewed by Gavin Barraclough.

  • fast/js/recursion-limit-equal-expected.txt:
  • fast/js/script-tests/recursion-limit-equal.js:
11:36 Changeset [89841] by aroben@apple.com
  • 2 edits in trunk/Tools

Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
old-run-webkit-tests exited early after reload

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
old-run-webkit-tests exited early due to too many failures in PersistentCache.

11:28 Changeset [89840] by aroben@apple.com
  • 3 edits in trunk/Tools

Make TestFailures load build names from build.webkit.org/old-results too

Build results are periodically moved from results to old-results. This change makes those
builds still visible to TestFailures.

Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
have been moved to build.webkit.org/old-results

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Extracted code to parse build names from a
build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
we now only include directory entries whose names are parseable as build names (since
old-results sometimes contains other random files/directories from who knows what). We now
fetch both results and old-results (with a FIXME about loading old-results on demand),
extract build names from each, and concatenate the two sets of names.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:

(WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
parseable, rather than throwing an exception.

11:28 Changeset [89839] by aroben@apple.com
  • 2 edits in trunk/Tools

Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache

It seems silly to have a whole generic cache just to store a single object.

Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
need one

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
(LayoutTestHistoryAnalyzer.prototype.start): Ditto.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
no-longer-needed history argument.

11:27 Changeset [89838] by aroben@apple.com
  • 4 edits
    2 adds in trunk/Tools

Move some inappropriate code out of Builder

Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
isn't really about a builder

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
called by other objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

Added. Code came from Builder.
(LayoutTestHistoryAnalyzer):
(LayoutTestHistoryAnalyzer.prototype.start):
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

Added. Code came from Builder.
(LayoutTestResultsLoader):
(LayoutTestResultsLoader.prototype.start):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new

scripts.

11:05 Changeset [89837] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
10:48 Changeset [89836] by inferno@chromium.org
  • 3 edits
    36 adds in trunk

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Fix removal of overhanging floats on style changes to absolute/fixed position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  1. If we are not currently positioned.
  2. And we are not floating. (If we are floating, then this will be automatically done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
  3. And we have overhanging floats from previous sibling blocks.
  4. And our new new style tells that we will have absolute or fixed position.

Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.

Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html

fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that overhanging floats are removed during style changes to absolute/fixed
position and gets added back when coming back to static position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
10:44 Changeset [89835] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium expectations update.

Add chromium mac failure after r89733.

  • platform/chromium/test_expectations.txt:
10:43 Changeset [89834] by eric@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
10:33 Changeset [89833] by krit@webkit.org
  • 14 edits
    4 adds in trunk

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Test for animation of SVGPreserveAspectRatio.

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgPreserveAspectRatio-animation-1-expected.txt: Added.
  • svg/animations/svgPreserveAspectRatio-animation-1.html: Added.

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedPreserveAspectRatio.


The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgPreserveAspectRatio-animation-1.html

  • CMakeLists.txt: Added new file.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Handle AnimatedPreserveAspectRatio. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.cpp: Added. New animator for SVGAnimatedPreserveAspectRatio. (WebCore::SVGAnimatedPreserveAspectRatioAnimator::SVGAnimatedPreserveAspectRatioAnimator): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.h: (WebCore::SVGAnimatedPreserveAspectRatioAnimator::~SVGAnimatedPreserveAspectRatioAnimator):
  • svg/SVGAnimatedType.cpp: Support for SVGPreserveAspectRatio. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPreserveAspectRatio): (WebCore::SVGAnimatedType::preserveAspectRatio): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): (WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
10:26 Changeset [89832] by alexis.menard@openbossa.org
  • 11 edits
    2 deletes in trunk

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remvove from the build.

  • Source/WebKit.pri:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.

  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon related stuff.

  • docs/qtwebkit.qdocconf:
  • qt_webkit_version.pri:
10:21 Changeset [89831] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.

Also add more assertions to help detecting similar bugs.

Test: editing/text-iterator/first-letter-rtl-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::emitText):

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
with first-letter rule applied where letters are not contiguous.

  • editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
  • editing/text-iterator/first-letter-rtl-crash.html: Added.
10:18 Changeset [89830] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

This patch is based on Noam Rosenthal original patch in the same bug.

When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason why we have the implicit conversion.

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::overloadedSlots): Remove expected failure and fix the comment.
10:16 Changeset [89829] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Put a failing test to the mac list because all wk2 platforms are affected.
Move the group to the section where the items have bug report.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
10:04 Changeset [89828] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 ChangSeok Oh <shivamidow@gmail.com>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

Some missing files in ANGLE are just added to fix build-break.

No test reqired

  • GNUmakefile.list.am:

2011-06-27 ChangSeok Oh <shivamidow@gmail.com>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl

  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
09:57 Changeset [89827] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Martin Robinson.

[EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
https://bugs.webkit.org/show_bug.cgi?id=62959

Add PLATFORM(EFL) ifdefs to use GraphicsContextInternal.

  • platform/graphics/GraphicsContext3D.h:
09:55 Changeset [89826] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-27 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

  • fast/css/div_plus_nav_bug47971-expected.txt: Added.
  • fast/css/div_plus_nav_bug47971.html: Added.

2011-06-27 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

Added a new state in css/tokenizer.flex for the "nth" rule. The state begins
at nth-*( functions and ends at the first ")". It avoids parsing selectors
like "#div+nav" as: "#div" "+n" "av".

Test: fast/css/div_plus_nav_bug47971.html

  • css/maketokenizer:
  • css/tokenizer.flex:
09:32 Changeset [89825] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

[WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
https://bugs.webkit.org/show_bug.cgi?id=63457

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
08:51 Changeset [89824] by commit-queue@webkit.org
  • 11 edits in trunk

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
08:37 Changeset [89823] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Adam Roben.

Send keypress events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63144

No new tests. Covered by existing windowless plugin tests plugins/mouse-events.html
and plugins/keyboard-events.html. Both are not yet working as desired because focus
events are not being fowarded to windowed plugins on the win port (bug 62375). Test
plugin logging on the win port was added in bug 61721. New failing expectations for
plugins/keyboard-events.html were subsequently added in bug 33973 so there's no need
to update test expectations in this patch.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::handleKeyboardEvent): Add an ASSERT(m_plugin && !m_isWindowed)
to indicate that the routine is for windowless plugins. Remove trailing whitespace.
Add handling for keyPress events (map to WM_CHAR).
(WebCore::PluginView::handleMouseEvent): Add the ASSERT to indicate that the routine
is for windowless plugins. Add FIXME note. Remove trailing whitespace.

08:33 Changeset [89822] by apavlov@chromium.org
  • 11 edits in trunk

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
08:12 Changeset [89821] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
It will be plugged into the build system as soon as the rest of the
DRT code is fully upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=63086

  • DumpRenderTree/efl/DumpRenderTreeView.cpp: Added. (onConsoleMessage): (onJavaScriptAlert): (onJavaScriptConfirm): (onJavaScriptPrompt): (drtViewTiledAdd):
  • DumpRenderTree/efl/DumpRenderTreeView.h: Added.
08:10 Changeset [89820] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add an EventSender implementation to EFL's DumpRenderTree along
with support files.
Build system changes will be made as soon as the whole DumpRenderTree
is upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=61962

  • DumpRenderTree/efl/EventSender.cpp: Added. (setEvasModifiers): (translateMouseButtonNumber): (sendMouseEvent): (sendClick): (scheduleAsynchronousClickCallback): (updateClickCount): (modifierFromJSValue): (modifiersFromJSValue): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (evasMouseEventFromHorizontalAndVerticalOffsets): (mouseScrollByCallback): (continuousMouseScrollByCallback): (keyPadNameFromJSValue): (keyNameFromJSValue): (keyDownCallback): (scalePageByCallback): (getClass): (makeEventSender):
  • DumpRenderTree/efl/EventSender.h: Added.
07:38 Changeset [89819] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r89817.

07:36 Changeset [89818] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove private header files from EWebKit_HEADERS.
https://bugs.webkit.org/show_bug.cgi?id=63441

Remove ewk_tiled_private.h, ewk_tiled_backing_store.h, ewk_tiled_matrix.h,
ewk_tiled_model.h and check WTF_USE_SOUP to remove ewk_auth_soup.h.

  • CMakeListsEfl.txt:
07:31 Changeset [89817] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. One more filed missing during distcheck, for
the MIPS build.

  • GNUmakefile.list.am:
07:08 Changeset [89816] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating chromium expectations.

  • platform/chromium/test_expectations.txt:
04:54 Changeset [89815] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight
https://bugs.webkit.org/show_bug.cgi?id=63405

We should not call layout from paint.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
  • inspector/DOMNodeHighlighter.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::drawNodeHighlight):
04:33 Changeset [89814] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Daily gardening.

Remove non-existent svg/animations/animate-points.html from the Skipped list.

  • platform/mac-wk2/Skipped:
04:32 Changeset [89813] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: naive approach to fixing flaky inspector tests.

  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
03:45 Changeset [89812] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

2011-06-27 Jongseok Yang <js45.yang@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use accept attribute when executing the file picker for input element
https://bugs.webkit.org/show_bug.cgi?id=63063

This patch:

  • remove the argument "suggested_filenames" from ewk_view_run_open_panel
  • add the argument "accept" to ewk_view_run_open_panel
  • get the accept attribute and pass to ewk_view_run_open_panel within runOpenPanel
  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel):
  • ewk/ewk_view.cpp: (ewk_view_run_open_panel):
  • ewk/ewk_view.h
03:44 Changeset [89811] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

Remove meaningless parameter from WebCoreSupport's header files.

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::scrollRectIntoView):
  • WebCoreSupport/DragClientEfl.h:
  • WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::setWebFrame):
03:18 Changeset [89810] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error in EFL port.

  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/efl/SharedBufferEfl.cpp:
01:51 Changeset [89809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove ewk_tile_matrix_updates_process() call from _ewk_tiled_backing_store_item_process_idler_cb().
https://bugs.webkit.org/show_bug.cgi?id=62963

As repaint_process on ewk_view_tiled already takes care of dirty area in visible area
and in order to let pre-render work more efficiently,
_ewk_tiled_backing_store_item_process_idler_cb() better not call ewk_tile_matrix_updates_process().

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb):
01:41 Changeset [89808] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove evil uses of hasattr
https://bugs.webkit.org/show_bug.cgi?id=63430

For some reason these classes believe that they may be called with
various flavors of "option" elements and so carefully check to make
sure that the options element has their option before checking it.

We had a set_option_default method which was never called, so I made it
do what callsites seemed to want it to do and replaced 3 callers
who previously used hasattr manually to use set_option_default instead.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
01:37 Changeset [89807] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

  • platform/qt-mac/Skipped: Skip fast/css/custom-font-xheight.html.
01:35 Changeset [89806] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
01:34 Changeset [89805] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip new tests introduced in r89783.
01:15 Changeset [89804] by pfeldman@chromium.org
  • 30 edits in trunk

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.waitForStyles): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.nodeSelected): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.stylesUpdated): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles):
  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/metrics-box-sizing.html:
  • inspector/styles/parse-utf8-bom.html:
  • inspector/styles/styles-add-blank-property.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-source-lines-inline.html:
  • inspector/styles/styles-source-lines.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:
  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateStyles): (WebInspector.ElementsPanel.prototype._stylesUpdated):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
01:10 Changeset [89803] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::innerBottomRight): (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::innerBottomRight): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):
01:07 Changeset [89802] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] WebViewHost should be destructed before LayoutTestController, etc.
https://bugs.webkit.org/show_bug.cgi?id=63427

~WebViewHost() navigates to about:blank, so it calls some
callbacks and LayoutTestController functions.

  • DumpRenderTree/chromium/TestShell.h: Move m_printer upper and move m_webViewHost lower.
01:04 Changeset [89801] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move server config files to webkitpy.layout_tests.servers
https://bugs.webkit.org/show_bug.cgi?id=63436

The config files belong with the servers.

  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
  • Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
01:01 Changeset [89800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item's update field.
https://bugs.webkit.org/show_bug.cgi?id=62967

As some code do not affect any logical flow of tiled backing store except condition check,
I would like to clean dead code related with Ewk_Tiled_Backing_Store_Item's update field
and Ewk_Tiled_Backing_Store_Data's queue field

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del):
00:59 Changeset [89799] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip a new test.
00:59 Changeset [89798] by abarth@webkit.org
  • 7 edits
    4 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move websocket_server and http_server to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63434

These classes do not represent ports. They represent servers.

  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
00:54 Changeset [89797] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=63428

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
00:46 Changeset [89796] by ossy@webkit.org
  • 8 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results after r89745.

  • platform/qt/Skipped: Revert accidentally committed (r89732) changes.
  • platform/qt/svg/custom/linking-a-03-b-all-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
00:43 Changeset [89795] by abarth@webkit.org
  • 2 edits
    1 move
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move apache_http_server.py to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63433

The apache_http_server.py is a server, not a port.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/servers: Added.
  • Scripts/webkitpy/layout_tests/servers/init.py: Added.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
00:34 Changeset [89794] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63432

This code isn't in the dependency cone of new-run-webkit-tests. It's
unclear what it's final home should be, but this patch moves it out of
layout_tests to simply the package.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
00:20 Changeset [89793] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63429

This package as nothing to do with the layout_tests package.

  • Scripts/update-webgl-conformance-tests:
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
00:11 Changeset [89792] by yutak@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

[Chromium] Add useHixie76WebSocketProtocol to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=63424

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHixie76WebSocketProtocolEnabled):
  • src/WebSettingsImpl.h:
00:10 Changeset [89791] by abarth@webkit.org
  • 3 edits
    2 moves
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move deduplicate_tests.py into webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63426

deduplicate_tests.py doesn't haven anything to do with layout tests.
It's really a separate script. This patch moves it to the (new)
to_be_moved package so that it doesn't distract us when working on NRWT.

  • Scripts/deduplicate-tests:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
  • Scripts/webkitpy/to_be_moved: Added.
  • Scripts/webkitpy/to_be_moved/init.py: Added.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.

06/26/11:

23:50 Changeset [89790] by mrowe@apple.com
  • 4 edits in trunk/Source

Use a separate file name for Lion's WebKitSystemInterface.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:
23:49 Changeset [89789] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from WebAudio IDL files
https://bugs.webkit.org/show_bug.cgi?id=63416

WebAudio isn't that widely used, so it's seems somewhat safe to remove
legacy code generation hacks. I'm not an expert on WebAudio, but the
API doesn't appear to need many optional arguments.

There are a bunch of APIs that have custom bindings that look like they
could be autogenerated. I've added FIXME comments where appropriate.

  • webaudio/AudioBuffer.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioListener.idl:
  • webaudio/AudioNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioParam.idl:
  • webaudio/RealtimeAnalyserNode.idl:
23:40 Changeset [89788] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2011-06-26 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Remove empty directory.

  • Scripts/webkitpy/layout_tests/test_types: Removed.
23:40 Changeset [89787] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
https://bugs.webkit.org/show_bug.cgi?id=63421

Show generic sidebar menu only if no pane-specific menu has been shown.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
23:39 Changeset [89786] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Build fix for clang. Apparently clang doesn't want us to use the std
namespace in headers, which makes sense.

  • svg/SVGAnimatedType.h:
23:31 Changeset [89785] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
https://bugs.webkit.org/show_bug.cgi?id=63418

The XMLHttpRequest.idl interface used to implement the new behavior
manually using the RequiresAllArguments attribute. Now that we have
that behavior by default, we can simply remove the
LegacyDefaultOptionalArguments attribute.

  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
23:22 Changeset [89784] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.

Rubber-stamped by Maciej Stachowiak.

  • WebProcess/mac/WebProcessMac.mm:
23:16 Changeset [89783] by krit@webkit.org
  • 15 edits
    13 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399


Test animations of attributes with type SVGLengthList.

  • svg/animations/script-tests/svglengthlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svglengthlist-animation-1-expected.txt: Added.
  • svg/animations/svglengthlist-animation-1.html: Added.
  • svg/animations/svglengthlist-animation-2-expected.txt: Added.
  • svg/animations/svglengthlist-animation-2.html: Added.
  • svg/animations/svglengthlist-animation-3-expected.txt: Added.
  • svg/animations/svglengthlist-animation-3.html: Added.
  • svg/animations/svglengthlist-animation-4-expected.txt: Added.
  • svg/animations/svglengthlist-animation-4.html: Added.

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.


Interpolated animations of glyph positions are possible now.

Tests: svg/animations/svglengthlist-animation-1.html

svg/animations/svglengthlist-animation-2.html
svg/animations/svglengthlist-animation-3.html
svg/animations/svglengthlist-animation-4.html

  • CMakeLists.txt: Add new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList. (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator): (WebCore::SVGAnimatedLengthListAnimator::constructFromString): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
  • svg/SVGAnimatedLengthList.h: (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
  • svg/SVGAnimatedType.cpp: Add SVGLengthList. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createLengthList): (WebCore::SVGAnimatedType::lengthList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value. (WebCore::SVGLength::SVGLength):
  • svg/SVGLength.h:
21:49 Changeset [89782] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

  • http/tests/security/location-prototype-expected.txt: Added.
  • http/tests/security/location-prototype.html: Added.
  • http/tests/security/resources/location-prototype-overwrite.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

This patch corrects the prototype chain for Location, but we really
should do a complete cleanup of the prototype chain generation, like we
did for JavaScriptCore.

Test: http/tests/security/location-prototype.html

  • bindings/scripts/CodeGeneratorV8.pm:
21:45 Changeset [89781] by abarth@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add [Optional] attributes where appropriate for addEventListener and removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=63417

This patch doesn't actually change behavior because these interfaces
have the LegacyDefaultOptionalArguments attribute. This patch paves
the way to removing LegacyDefaultOptionalArguments from some of these
interfaces as well as making the project safer for copy-and-pasting
these methods into new IDL files that don't have the
LegacyDefaultOptionalArguments attribute.

  • bindings/scripts/test/TestObj.idl:
  • dom/EventTarget.idl:
  • dom/MediaStream.idl:
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • storage/IDBRequest.idl:
  • storage/IDBTransaction.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
20:43 Changeset [89780] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

  • fast/forms/form-associated-element-crash3-expected.txt: Added.
  • fast/forms/form-associated-element-crash3.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

Test: fast/forms/form-associated-element-crash3.html

  • dom/Document.h:
20:34 Changeset [89779] by takano.naoki@gmail.com
  • 2 edits in trunk/Tools

Change committers entry.w

20:15 Changeset [89778] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove WebSecurityOrigin::grantUniversalAccess
https://bugs.webkit.org/show_bug.cgi?id=63415

This function has no callers and is downright dangerous.

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp:
18:47 Changeset [89777] by dglazkov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

FileList::filenames should be FileList::paths, because it's more accurate.
https://bugs.webkit.org/show_bug.cgi?id=63414

Refactoring, no change in behavior.

  • fileapi/FileList.cpp: (WebCore::FileList::paths): Renamed from filenames.
  • fileapi/FileList.h:
  • html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
17:31 Changeset [89776] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-06-26 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API.
https://bugs.webkit.org/show_bug.cgi?id=62688

Move functions which use Ewk_View_Private_Data and may not be required by
applications to ewk_private.h.

  • ewk/ewk_private.h:
  • ewk/ewk_view.h:
16:06 Changeset [89775] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Baselines for new test.

  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
14:26 Changeset [89774] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
13:21 Changeset [89773] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove code behind WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63402

These old APIs are no longer needed.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:30 Changeset [89772] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-26 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
https://bugs.webkit.org/show_bug.cgi?id=63347

  • dfg/DFGNonSpeculativeJIT.cpp:
    • Changed arithmetic operations to speculate in favor of integers.

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
    • Added slow-path routines for arithmetic that perform no speculation; the non-speculative JIT will generate calls to these in cases where its speculation fails.
  • dfg/DFGOperations.h:
10:17 Changeset [89771] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't use a Mutex for protecting access to the connection queue clients
https://bugs.webkit.org/show_bug.cgi?id=63403

Make sure to only access the queue client vector from the connection work queue.
This gets rid of a lock and ensures that adding/removing clients from callbacks works correctly.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::addQueueClientOnWorkQueue): (CoreIPC::Connection::removeQueueClientOnWorkQueue): (CoreIPC::Connection::processIncomingMessage):
  • Platform/CoreIPC/Connection.h:
10:04 Changeset [89770] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Darn. Need BUGWG to make the file parse.

  • platform/chromium/test_expectations.txt:
09:09 Changeset [89769] by mitz@apple.com
  • 3 edits
    3 adds in trunk

With word-break: break-all, words do not break correctly before a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=63401

Reviewed by Darin Adler.

Source/WebCore:

The code to check for mid-word breaks accumulates width one character at a time. It was actually
measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
Fixed by checking for surrogate pairs and measuring the pair as one unit.

Test: fast/text/midword-break-before-surrogate-pair.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/text/midword-break-before-surrogate-pair.html: Added.
07:22 Changeset [89768] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Note that this test ASSERTs on Linux Debug.

  • platform/chromium/test_expectations.txt:
06:12 Changeset [89767] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Skip new tests that depend on pause API. Put them to the
mac list that is used by all WebKit2 platforms.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
04:24 Changeset [89766] by krit@webkit.org
  • 13 edits
    14 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.


Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
growing shadows with feGaussianBlur, feDropShadow or other filter effects.

Tests: svg/animations/svgnumberoptionalnumber-animation-1.html

svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.h: Added. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
  • svg/SVGAnimatedType.cpp: Added new type: pair<float, float>. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberOptionalNumber): (WebCore::SVGAnimatedType::numberOptionalNumber): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: Add new animator to factory. (WebCore::SVGAnimatorFactory::create):

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Test animation of SVGNumberOptionalNumber values with and without optional number, as well as 'to' and 'by' animations.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-1.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4.html: Added.
02:35 Changeset [89765] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed. Skip failing tests.

[Qt][WK2] svgnumberlist-animation-[1,2] fails since added
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/qt-wk2/Skipped:

06/25/11:

23:33 Changeset [89764] by abarth@webkit.org
  • 4 edits in trunk

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):

2011-06-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63394

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::queueLoad):
22:43 Changeset [89763] by pfeldman@chromium.org
  • 13 edits
    10 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: new chromium baselines.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt: Added.
21:33 Changeset [89762] by dglazkov@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

  • fast/dom/shadow/frameless-media-element-crash.html: Added.
  • fast/dom/shadow/frameless-media-element-crash-expected.txt: Added.

2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Crash in frameless document with media element.
https://bugs.webkit.org/show_bug.cgi?id=63393

Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
in the calling code.

Test: fast/dom/shadow/frameless-media-element-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created. (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation. (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
  • html/HTMLMediaElement.h: Adjusted def.
21:09 Changeset [89761] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
21:04 Changeset [89760] by joepeck@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Fix some minor style issues
https://bugs.webkit.org/show_bug.cgi?id=63391

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): The explicit WebCore namespace usage can be dropped.
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): Use ASSERT_UNUSED for a parameter that we want to ASSERT on for a debug build, but is UNUSED in a release build.
17:39 Changeset [89759] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

Unreviewed build correction after r89426.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Link with Cairo DLL for new functionality.
  • WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility code for snprintf.
17:36 Changeset [89758] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.

  • Shared/API/c/cairo/WKImageCairo.h: Declare cairo type as struct (in keeping with other declarations).
  • win/WebKit2.vcproj: Add new WKImageCairo.cpp file to WinCairo build.
17:22 Changeset [89757] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89503.
See http://trac.webkit.org/changeset/89503. The modifications
to the WebKit2.def need to be mirrored in WebKit2CFLite.def.

  • win/WebKit2CFLite.def: Add new exported symbol for isPreloaded.
16:32 Changeset [89756] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <joepeck@webkit.org>

Unreviewed build fix.

Use UNUSED_PARAM on the correct param!

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
16:10 Changeset [89755] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction after r89426.
See http://trac.webkit.org/changeset/89426. The new WebKit2
header file (WKImageCairo.h) is needed.

  • win/WebKit2Generated.make: Make sure to copy the WKImageCairo.h

header file to the WebKit2 API directory after building.

16:01 Changeset [89754] by joepeck@webkit.org
  • 22 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 2: Only adjust for the FrameView's scroll position when
the localToAbsolute mapping did not end with fixed content.
Content that is inside of a fixed position container is already
adjusted for the FrameView's scrollPosition when RenderView
maps local to container.

This patch uses a "wasFixed" out parameter to determine if
the localToAbsolute transformation ended inside a fixed block,
and if so does not apply the scroll position.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): Respect wasFixed as described above.
  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): This is the only time that "fixed" ever changed. So when fixed changes, update the optional wasFixed out parameter.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): Ignore wasFixed by default, but pipe it though where needed.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): This is the final recursive call, so wasFixed goes no further. We sanity check its value in debug builds.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
  • rendering/RenderInline.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
  • rendering/svg/SVGRenderSupport.h: Pipe wasFixed through where needed.
16:01 Changeset [89753] by joepeck@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Simon Fraser.

Inspector highlight rect is wrong for contents of transformed iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Part 1: Provide FloatQuad versions of convertFromRenderer,
convertToContainingView, and convertChildToSelf, so that we
can get the fully transformed quad of a renderer all the
way up to the root widget.

  • page/FrameView.cpp: (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf):
  • platform/Widget.h:
  • platform/Widget.cpp: (WebCore::Widget::convertToContainingView): Provide FloatQuad versions of these already existing functions.

(WebCore::Widget::convertToRootContainingView):
Provide a helper conversion function to recursively
convert a given FloatQuad up to the root widget.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): Use the new methods to convert the FloatQuad for the highlighted node to the root container, without losing transformation information. Add a FIXME for SVG, which is still broken.
  • WebCore.exp.in: Export the new Widget functions so WebKit can link properly.
15:16 Changeset [89752] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-25 Dirk Schulze <krit@webkit.org>

Unreviewed build fix.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
15:08 Changeset [89751] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-25 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Remove ifdefs around these two functions because
we're not planning to move them. This patch makes WebFrameImpl.h
consistent with WebFrame.h so we can build with the new API
configuration.

  • src/WebFrameImpl.h:
15:02 Changeset [89750] by krit@webkit.org
  • 15 edits
    7 adds in trunk

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumberList.


Animations of attributes with type SVGNumberList can be interpolated now.

Tests: svg/animations/svgnumberlist-animation-1.html

svg/animations/svgnumberlist-animation-2.html

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedNumber): Made method static for reuse in SVGAnimatedNumberList (and SVGAnimatedNumberOptionalNumber later). (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): Use new static function.
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.cpp: Added. New animator for SVGNumberList. (WebCore::SVGAnimatedNumberListAnimator::SVGAnimatedNumberListAnimator): (WebCore::SVGAnimatedNumberListAnimator::constructFromString): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberListAnimator::calculateDistance):
  • svg/SVGAnimatedNumberList.h: (WebCore::SVGAnimatedNumberListAnimator::~SVGAnimatedNumberListAnimator):
  • svg/SVGAnimatedType.cpp: Use new Animator. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberList): (WebCore::SVGAnimatedType::numberList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):

2011-06-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberList animation
https://bugs.webkit.org/show_bug.cgi?id=63387

Test animation of attributes with type SVGNumberList.

  • svg/animations/script-tests/svgnumberlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberlist-animation-1-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-1.html: Added.
  • svg/animations/svgnumberlist-animation-2-expected.txt: Added.
  • svg/animations/svgnumberlist-animation-2.html: Added.
14:36 Changeset [89749] by zimmermann@webkit.org
  • 16 edits
    2 adds in trunk/Source/WebCore

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336

Convert <animate attributeName="d"> parsing to the new SVGAnimatorFactory concept, removing
the last special data types from SVGAnimateElement: SVGPathByteStream m_fromPath/m_toPath/m_animatedPath.
All existing non-string primitives have been converted to the new concept.

Doesn't change any functionality.

  • CMakeLists.txt: Added SVGAnimatedPath.*.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedPath.cpp: Added. (WebCore::SVGAnimatedPathAnimator::SVGAnimatedPathAnimator): (WebCore::SVGAnimatedPathAnimator::constructFromString): (WebCore::SVGAnimatedPathAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPathAnimator::calculateDistance):
  • svg/SVGAnimatedPath.h: Added. (WebCore::SVGAnimatedPathAnimator::~SVGAnimatedPathAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPath): (WebCore::SVGAnimatedType::path): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::initializeFrom):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
14:20 Changeset [89748] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-25 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

SOFT_LINK_POINTER_OPTIONAL isn't optional.
https://bugs.webkit.org/show_bug.cgi?id=63378

Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.

  • platform/mac/SoftLinking.h:
12:02 Changeset [89747] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening.
Skip css3/flexbox tests on Qt since ENABLE(CSS3_FLEXBOX) is disabled.

  • platform/qt/Skipped:
11:53 Changeset [89746] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

run-bindings-tests does not work on Chromium Windows.
https://bugs.webkit.org/show_bug.cgi?id=63382

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
11:41 Changeset [89745] by rwlbuis@webkit.org
  • 12 edits
    6 adds in trunk

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Allow navigating to internal <view> targets. When choosing Back ensure
the <svg> current view is initialized correctly.

Tests: svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg

svg/custom/linking-uri-01-b.svg

  • page/FrameView.cpp: Delegate to setupInitialView. (WebCore::FrameView::scrollToAnchor):
  • svg/SVGAElement.cpp: Allow navigating to internal <view> targets. (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setupInitialView): Initialize current view depending on fragment identifier. (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:

2011-06-25 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test linking-uri-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63322

Add a test for navigating to an inner <view> anchor. The changed test results
are improvements.

  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/mac/svg/custom/linking-uri-01-b-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg: Added.
  • svg/custom/linking-uri-01-b.svg: Added.
10:44 Changeset [89744] by robert@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Duplicate entry in context menu
https://bugs.webkit.org/show_bug.cgi?id=62139

contextMenuController()->populate() is called from
ContextMenuController::handleContextMenuEvent() so
QWebPage::updatePositionDependentActions() does not need
to call it independently.

Related changesets:

http://trac.webkit.org/changeset/73535
http://trac.webkit.org/changeset/32389

  • Api/qwebpage.cpp: (QWebPage::updatePositionDependentActions):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy): (tst_QWebPage::contextMenuPopulatedOnce):
10:21 Changeset [89743] by dglazkov@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Update expectations after r89732.
https://bugs.webkit.org/show_bug.cgi?id=59085

  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium/test_expectations.txt:
10:04 Changeset [89742] by dglazkov@chromium.org
  • 7 edits in trunk

2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
  • fast/css/unknown-pseudo-element-matching.html: Added more tests.

2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement. (WebCore::CSSStyleSelector::pushParent): Ditto.
  • dom/Node.cpp: (WebCore::Node::parentOrHostElement): Added.
  • dom/Node.h:
08:15 Writing Layout Tests for DumpRenderTree edited by dominicc@chromium.org
Documents window.internals. (diff)
03:20 Changeset [89741] by pfeldman@chromium.org
  • 2 edits
    18 adds in trunk/LayoutTests

2011-06-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: chromium rebaselines.

  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-linux/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:43 Changeset [89740] by zimmermann@webkit.org
  • 17 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update gtk baseline. The rebaselines should be done now.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt:
  • platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
  • platform/gtk/svg/text/text-text-04-t-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/text/text-text-06-t-expected.txt:
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
01:01 Changeset [89739] by zimmermann@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update win baseline.

  • platform/win-wk2/Skipped: Skip newly added svg/text test just like in mac-wk2.
  • platform/win-xp/svg/custom: Added.
  • platform/win-xp/svg/custom/svg-fonts-fallback-expected.txt: Added. XP has different metrics here.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Update result from Win7 slave.
00:44 Changeset [89738] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Skip svg/text/select-text-svgfont.html on mac-wk2, just like the other svg/text tests.

  • platform/mac-wk2/Skipped:
00:36 Changeset [89737] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

http/tests/inspector/network/network-iframe-load-and-delete.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63379

http/tests/navigation/anchor-basic.html fails on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63380

Skip last two tests that kept Leopard red, should turn green again now.

  • platform/mac-leopard/Skipped:
00:34 Changeset [89736] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Gardening.

REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on Leopard/SnowLeopard release
https://bugs.webkit.org/show_bug.cgi?id=63169

Skip failing test for mac, to turn bots green again.

  • platform/mac/Skipped:
00:31 Changeset [89735] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Update a stale Leopard result.

  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
00:02 Changeset [89734] by mitz@apple.com
  • 3 edits in trunk/Tools

Try to fix the Qt and Chromium builds.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setEncodedAudioData):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

06/24/11:

23:49 Changeset [89733] by mitz@apple.com
  • 51 edits
    4 adds in trunk

Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363

Reviewed by Anders Carlsson.

Source/WebCore:

Restored most of text rounding hacks which were removed in r78846, with a global flag to control
whether rounding hacks are allowed, which defaults to false.

Test: platform/mac/fast/text/rounding-hacks.html

  • CMakeLists.txt: Added TextRun.cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.exp.in: Export new TextRun function and global and updated StringTruncator functions.
  • WebCore.gypi: Added TextRun.cpp.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Disable rounding hacks in the one place
they used to be disabled.

  • platform/graphics/Font.cpp: Re-added the rounding character table.
  • platform/graphics/Font.h:

(WebCore::Font::isRoundingHackCharacter): Re-added.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Account for final rounding width.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::adjustedSpaceWidth): Re-added.

  • platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth): Re-added disableRoundingHacks parameter.
(WebCore::truncateString): Ditto.
(WebCore::StringTruncator::centerTruncate): Added EnableRoundingHacksOrNot parameter.
(WebCore::StringTruncator::rightTruncate): Ditto.
(WebCore::StringTruncator::width): Ditto.

  • platform/graphics/StringTruncator.h:
  • platform/graphics/TextRun.cpp: Added.

(WebCore::TextRun::setAllowsRoundingHacks): Added.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added RoundingHacks parameter to the constructors, used to initialize
the m_applyRunRounding and m_applyWordRounding member variables, subject to rounding hacks being allowed.
(WebCore::TextRun::applyRunRounding): Re-added this accessor.
(WebCore::TextRun::applyWordRounding): Ditto.
(WebCore::TextRun::disableRoundingHacks): Re-added.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Re-added code to apply rounding hacks.
(WebCore::WidthIterator::advance): Ditto.

  • platform/graphics/WidthIterator.h:
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ceilCGFloat): Re-added.
(WebCore::ComplexTextController::ComplexTextController): Re-added code to apply rounding hacks.
(WebCore::ComplexTextController::advance): Ditto.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::finalRoundingWidth): Re-added this accessor.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Accound for final rounding width.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • platform/mac/DragImageMac.mm:

(WebCore::widthWithFont): Disable rounding hacks when measuring.
(WebCore::drawAtPoint): Disable rounding hacks when drawing.

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink): Enable rounding hacks in the string truncator.

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::WebCoreTextFloatWidth): Ditto.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Disable rounding hacks.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth): Ditto.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Enabled rounding hacks in the string truncator.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Disabled rounding hacks.

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::constructTextRun): Ditto.

Source/WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
Disabled rounding hacks.
(-[NSString _web_widthWithFont:]): Ditto.

  • WebView/WebView.mm:

(+[WebView _setAllowsRoundingHacks:]): Added this setter.

  • WebView/WebViewPrivate.h:

Source/WebKit/win:

  • WebKitGraphics.cpp:

(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.

Tools:

Added layoutTestController.allowRoundingHacks() and implemented it
on OS X.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::allowRoundingHacks):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::allowRoundingHacks):

LayoutTests:

  • platform/mac/fast/text/rounding-hacks.html: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Added.
23:28 Changeset [89732] by zimmermann@webkit.org
  • 141 edits
    23 adds in trunk

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.png:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.png: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png: Added.
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/svg-features-expected.png: Added.
  • platform/qt/svg/custom/svg-features-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-in-html-expected.png:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • svg/custom/resources/ABCFont.svg:
  • svg/custom/svg-fonts-fallback.xhtml: Added.
  • svg/custom/svg-fonts-segmented.xhtml: Added.
  • svg/custom/svg-fonts-word-spacing.html: Added.
  • svg/text/select-text-svgfont-expected.txt: Added.
  • svg/text/select-text-svgfont.html: Added.
  • svg/text/text-overflow-ellipsis-svgfont.html: Added.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

  • wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608

Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460

With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227

When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236

SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840

REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934

Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)

svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)

Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

This makes text selection using SVG Fonts possible again.

  • features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
  • page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
  • platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well. (WebCore::Font::drawText): (WebCore::Font::drawEmphasisMarks): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition): (WebCore::Font::codePath):
  • platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair

std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
handle font fallback glyph matching for SVG Fonts..

(WebCore::Font::fontList): Add FontFallbackList accessor.

  • platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext. (WebCore::FontFallbackList::glyphPageZero): (WebCore::FontFallbackList::glyphPages): (WebCore::FontFallbackList::setGlyphPageZero): (WebCore::FontFallbackList::setGlyphPages):
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here. (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer. (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case. (WebCore::Font::drawGlyphBuffer): Ditto.
  • platform/graphics/FontMetrics.h: (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
  • platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int. (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData. (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
  • platform/graphics/TextRun.h:
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::glyphDataForCharacter): (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)

and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).

(WebCore::WidthIterator::run):
(WebCore::WidthIterator::runWidthSoFar):
(WebCore::WidthIterator::lastGlyphName):
(WebCore::WidthIterator::setLastGlyphName):
(WebCore::WidthIterator::arabicForms):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
  • platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
  • rendering/svg/SVGTextMetrics.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont. (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects. (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun. (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength(). (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method. (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths. (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
  • rendering/svg/SVGTextRunRenderingContext.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData): Changed font size from int to float. (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width. (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code. (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font. (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation. (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage. (WebCore::SVGFontElement::ensureGlyphCache):
  • svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly. (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone. (WebCore::SVGGlyphMap::collectGlyphsForString):
  • svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
19:42 Changeset [89731] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Replace ";" with space in FEATURE_DEFINES macro
https://bugs.webkit.org/show_bug.cgi?id=62211

html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
as separator. So, let the html.css to use new feature macro with space separator.

  • CMakeLists.txt:
19:26 Changeset [89730] by lforschler@apple.com
  • 1 copy in tags/Safari-534.50

New tag.

19:15 Changeset [89729] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
https://bugs.webkit.org/show_bug.cgi?id=63345

The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
return 9 and 10 bit quantities, therefore changed their return type from
uint8_t to uint16_t. Also casted the places where they are used as they
are currently shifted and used as 7 or 8 bit values.

These methods are currently used for literals for stack offsets,
including creating and destroying stack frames. The prior truncation of
the upper bits caused stack frames to be too small, thus allowing a
JIT'ed function to access and overwrite stack space outside of the
incorrectly sized stack frame.

  • assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::getUInt9): (JSC::ARMThumbImmediate::getUInt10): (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S):
19:14 Changeset [89728] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge 89714.

19:12 Changeset [89727] by lforschler@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebKit2

89706.

19:05 Changeset [89726] by lforschler@apple.com
  • 4 edits in tags/Safari-534.48.3/Source/WebKit2

Merge 89706.

19:01 Changeset [89725] by lforschler@apple.com
  • 5 edits in tags/Safari-534.48.3/Source

Versioning.

19:00 Changeset [89724] by lforschler@apple.com
  • 1 copy in tags/Safari-534.48.3

New tag.

18:55 Changeset [89723] by lforschler@apple.com
  • 2 edits in tags/Safari-534.48.2/Source/WebCore

Merge r89714.

18:38 Changeset [89722] by lforschler@apple.com
  • 5 edits in tags/Safari-534.48.2/Source

Versioning.

18:21 Changeset [89721] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove ewk_frame_theme_get/set.
https://bugs.webkit.org/show_bug.cgi?id=63370

Remove ewk_frame_theme_get/set to avoid confusion.
Setting theme on each frame is meaningless and ewk_view_thjeme_set can
do same thing.

  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.cpp: (ewk_view_theme_set):
17:45 Changeset [89720] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Drag-and-drop tab in same window makes web process falsely report unresponsiveness
https://bugs.webkit.org/show_bug.cgi?id=63369
<rdar://problem/9673120>

If the view becomes invisible, stop the responsiveness timer, because we might not get any
messages that will cause it to stop (such as painting notifications since we don't paint
when we're not visible).

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
17:39 Changeset [89719] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Gavin Peters <gavinp@chromium.org>

Reviewed by Darin Adler.

fix possible race in LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=63360

In chromium bug 80729
http://code.google.com/p/chromium/issues/detail?id=80729 I am
seeing some kind of double triggering of the timer; I am concerned
that it is possible that a Link element errors out or succeeds,
sets a timer, and shortly before the timer is triggered it is
editted, launches another request. After that, the first timer
triggers, zeroing out m_cachedResource. Then, the second load
finishes, and *crash*. If this is the case, this fix should stop
it.

No new tests; I haven't reproduced this. I hope chrome's crash
telemetry will give good feedback; this crash is occuring many times a
day so the difference should be obvious.

  • loader/LinkLoader.cpp: (WebCore::LinkLoader::LinkLoader): (WebCore::LinkLoader::linkLoadTimerFired): (WebCore::LinkLoader::linkLoadingErrorTimerFired): (WebCore::LinkLoader::notifyFinished):
  • loader/LinkLoader.h:
17:16 Changeset [89718] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-24 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332
<rdar://problem/9661650>

No new tests; Only affects machines with QTKit < 7.6.3 installed.

Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
as it is only defined in QTKit >= 7.6.3. If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys. To avoid ASSERTs when running
debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
  • platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.
17:13 Changeset [89717] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Windows build failure.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.

17:11 Changeset [89716] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
https://bugs.webkit.org/show_bug.cgi?id=63015

Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList(). These
adjustments are a bug. These need to reflect the pages that are released
in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
Made ReleaseFreeList a member of TCMalloc_PageHeap in the process. Updated
Check() and helper method CheckList() to check the number of actual free pages
with free_committed_pages_.

The symptom of the problem of the existing code is that the scavenger may
run unneccesarily without any real work to do, i.e. pages on the free lists.
The scanvenger would also end up freeing too many pages, that is going below
the current 528 target free pages.

Note that the style of the changes was kept consistent with the
existing style.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::TCMalloc_PageHeap::ReleaseFreeList):
17:09 Changeset [89715] by darin@apple.com
  • 9 edits in trunk/Source/WebCore

2011-06-23 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Remove some unneeded functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=63295

Removing 7 of the functions in FrameLoader.h is probably a step
in the right direction.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::handledOnloadEvents): Moved the call to stopDeferringEvents in here from FrameLoader.
  • loader/DocumentLoader.h: Ditto.
  • loader/DocumentWriter.h: Fixed a typo.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to use a non-recursive tree walk instead of recursion. (WebCore::FrameLoader::stopAllLoaders): Moved the code from stopLoadingSubframes inline, since it's only two lines of code. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved the code from markLoadComplete inline, since it's only one line. (WebCore::FrameLoader::checkLoadComplete): Changed this to use a non-recursive tree walk instead of recursion, eliminating the recursiveCheckLoadComplete function completely. (WebCore::FrameLoader::handledOnloadEvents): Moved the call to stopDeferringEvents into DocumentLoader.
  • loader/FrameLoader.h: Removed unneeded forward declarations, and now-unneeded functions setupForReplaceByMIMEType, isStopping, isLoadingFromCachedPage, stopLoadingSubframes, markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete. Also made allChildrenAreComplete private.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Call DocumentLoader::isStopping so we can remove the function from FrameLoader that just calls through. Other call sites were using DocumentLoader::isStopping directly. (WebCore::MainResourceLoader::didReceiveResponse): Call DocumentLoader::setupForReplaceByMIMEType so we can remove the function from FrameLoader that just calls through. This was the only call site.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Call the ResourceLoader::cancelledError function instead of calling directly to FrameLoader.
  • loader/ResourceLoader.h: Made response an inline function.
17:03 Changeset [89714] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Maciej Stachowiak.

REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix for bug 62764.
16:50 Changeset [89713] by lforschler@apple.com
  • 1 copy in tags/Safari-534.48.2

New tag.

16:39 Changeset [89712] by tony@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

  • css3/flexbox/display-property-expected.txt: Added.
  • css3/flexbox/display-property.html: Added.
  • css3/flexbox/script-tests/display-property.js: Added. (testFlex):

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

Test: css3/flexbox/display-property.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSValueKeywords.in:
16:06 Changeset [89711] by hclam@chromium.org
  • 19 edits
    5 deletes in trunk/Source/WebCore

2011-06-24 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Carlson.

Loading out-of-band text track files from <track>.
https://bugs.webkit.org/show_bug.cgi?id=62881

Uses the src attribute of <track> urls to load out-of-band text track
files using ThreadableLoader. Also removes TextTrackPrivateInterface
(as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.

No new tests because feature is hidden behind VIDEO_TRACK feature
define, which is turned off.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:
  • html/LoadableTextTrack.h:
  • html/LoadableTextTrackImpl.cpp: Removed.
  • html/LoadableTextTrackImpl.h: Removed.
  • html/MutableTextTrack.cpp:
  • html/MutableTextTrack.h:
  • html/MutableTextTrackImpl.cpp: Removed.
  • html/MutableTextTrackImpl.h: Removed.
  • html/TextTrack.cpp:
  • html/TextTrack.h:
  • html/TextTrackPrivate.h: Removed.
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
15:32 Changeset [89710] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Rob Buis <rbuis@rim.com>

Rubber-stamped by Nikolas Zimmermann.

All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Do not use writing mode aware code for SVG Text.

No new tests needed.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
15:15 Changeset [89709] by enne@google.com
  • 13 edits in trunk/LayoutTests

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63343

These tests were failing since they were introduced in r89687. The
layerTreeAsText dump on the iframe document was causing the outer
layerTreeAsText dump to be affected by font metrics. Fixed in this
case by not putting layerTreeAsText output in an element when inside
an iframe.

  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative.html:
15:07 Changeset [89708] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Darin Adler.

Change NDEBUG to !LOG_DISABLED macro in databases for logging.
https://bugs.webkit.org/show_bug.cgi?id=63346

Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
This change resolves also build break in Release build when logging enabled.

No new tests because there is no new behavior or feature exposed.

  • loader/icon/IconDatabase.cpp: Macro fixes. (WebCore::IconDatabase::iconDatabaseSyncThread): (WebCore::IconDatabase::syncThreadMainLoop): (WebCore::IconDatabase::readFromDatabase): (WebCore::IconDatabase::writeToDatabase): (WebCore::IconDatabase::cleanupSyncThread):
  • storage/AbstractDatabase.h: Macro fixes.
  • storage/DatabaseTask.cpp: Macro fixes.
  • storage/DatabaseTask.h: Macro fixes.
  • storage/SQLTransaction.cpp: Macro fixes.
  • storage/SQLTransaction.h: Macro fixes.
15:05 Changeset [89707] by tony@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Pass Strings by const reference to functions
https://bugs.webkit.org/show_bug.cgi?id=63341

Note that since Strings hold a RefPtr to StringImpl, passing Strings
by value isn't horrible, but it does cause ref count churn and using
const references is more consistent with the rest of the code base.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not

change the value of the passed in String.

  • loader/FrameLoader.h:
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::setFileDescriptorData):
  • platform/win/ClipboardUtilitiesWin.h:
  • storage/DatabaseTracker.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
  • storage/IDBSQLiteBackingStore.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::getOpenDatabases):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
  • svg/SVGPaint.h:
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
15:03 Changeset [89706] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-06-24 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Not possible for plug-ins to override the internal PDF viewer
https://bugs.webkit.org/show_bug.cgi?id=63356
<rdar://problem/9673382>

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Pass the entire resource response to shouldUseCustomRepresentationForResponse.
  • WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ask for the plug-in path for a plug-in that can handle the given resource response. If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in that can handle it.

(WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
a plug-in that can handle the given response. If that is the case, it should have precedence over
the custom representation.

  • WebProcess/WebProcess.h: Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.
14:45 Changeset [89705] by inferno@chromium.org
  • 10 edits
    2 adds in trunk

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Match other clampTo* functions in style with clampToInteger(float)
function.
https://bugs.webkit.org/show_bug.cgi?id=53449

  • wtf/MathExtras.h: (clampToInteger): (clampToFloat): (clampToPositiveInteger):

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Add clamping for CSSPrimitiveValues and SVGInlineText font size.
https://bugs.webkit.org/show_bug.cgi?id=53449

Test: svg/text/svg-zoom-large-value.xhtml

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the number created is valid.
  • css/CSSPrimitiveValue.h: add clamping checks to prevent overflows. (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two static functions, one specific to CSSStyleSelector and other generic to help in clamping font size for other callers like svg text, etc.
  • css/CSSStyleSelector.h:
  • platform/graphics/FontDescription.h: add asserts to detect if the new font size is valid. (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize):
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper from CSSStyleSelector to help in clamping new scaled font size. do not use "smart minimum" since svg allows really small unreadable fonts (tested by existing layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon check in CSSStyleSelector function should still hold for svg.

2011-06-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that font size for svg text zoom is clamped and we do not
crash on ASSERT(isfinite(s)) in FontDescription.h
https://bugs.webkit.org/show_bug.cgi?id=53449

  • svg/text/svg-zoom-large-value-expected.txt: Added.
  • svg/text/svg-zoom-large-value.xhtml: Added.
14:22 Changeset [89704] by jchaffraix@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Remove unsafe static_cast inside the InlineBox hierarchy
https://bugs.webkit.org/show_bug.cgi?id=63077

Refactoring only, no new test.

  • rendering/InlineFlowBox.h: (WebCore::toInlineFlowBox):
  • rendering/InlineTextBox.h: (WebCore::toInlineTextBox): Added the proper cast methods to those 2 classes from an InlineBox.
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): (WebCore::InlineFlowBox::addToLine): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::placeBoxesInInlineDirection): (WebCore::InlineFlowBox::requiresIdeographicBaseline): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild): (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): (WebCore::RenderText::positionLineBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ascentAndDescentForBox): (WebCore::RootInlineBox::includeFontForBox): (WebCore::RootInlineBox::includeGlyphsForBox): Replaced the static_cast in those previous call sites with the new cast methods.
13:54 Changeset [89703] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix.

Build fix on Linux when using the GStreamer backend.

No new tests, just a build fix.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::keyPressEvent):
13:54 Changeset [89702] by aroben@apple.com
  • 3 edits in trunk/Tools

Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.

13:53 Changeset [89701] by aroben@apple.com
  • 3 edits in trunk/Tools

Include links to Trac in bugs filed from TestFailures

Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.

13:46 Changeset [89700] by nduca@chromium.org
  • 19 edits
    9 deletes in trunk

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • WebKit.gypi:
  • public/WebWidget.h: (WebKit::WebWidget::animate): (WebKit::WebWidget::composite):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererViewport): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Removed.
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-06-24 Nat Duca <nduca@chromium.org>

Unreviewed, rolling out r89694.
http://trac.webkit.org/changeset/89694
https://bugs.webkit.org/show_bug.cgi?id=58408

Test shell still not ready for animate changes.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
13:33 Changeset [89699] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Fix Chromium Linux Build
https://bugs.webkit.org/show_bug.cgi?id=63349

  • WebCore.gyp/WebCore.gyp:
12:56 Changeset [89698] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix typos introduced in r89696

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.

12:49 Changeset [89697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Henry Song <hsong@sisa.samsung.com>

Reviewed by Martin Robinson.

Correct _sharedTimer value in SharedTimerEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=62380

SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
timerEvent(), we have observed addNewTimer() can be triggered
by either inside timerFunction() or others that are not within
timerFunction(). We have observed the following case:

  1. add a new Timer within timerFunction()
  2. timerFunction returns, set _sharedTimer = 0
  3. addNewTimer() is triggered again within webkit, don't know it triggers this.
  4. because at this moment, _sharedTimer == 0, the previous registered timer (in step 1) did not get removed.
  5. Now in ecore_timer, there are two timers with same callbacks
  6. From now on, timerFunction() will be called twice back-to-back in each ecore_timer loop. To correct this, we should set _sharedTimer = 0 before timerFunction() so that when addNewTimer() triggered within, we have a valid timer object.
  • platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent):
12:37 Changeset [89696] by aroben@apple.com
  • 2 edits in trunk/Tools

Make TestFailures correctly remember whether old-run-webkit-tests exited early

Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.

12:36 Changeset [89695] by aroben@apple.com
  • 3 edits
    1 add in trunk/Tools

Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.

(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

12:29 Changeset [89694] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
12:20 Changeset [89693] by crogers@google.com
  • 3 edits in trunk/Source

2011-06-24 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Enable Web Audio for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=63338

  • features.gypi:
12:16 Changeset [89692] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-24 Adrienne Walker <enne@google.com>

Unreviewed, remove assertion about root layers in RenderLayerBacking.
https://bugs.webkit.org/show_bug.cgi?id=60741

This was added in r89687, but somehow is not true on Safari Leopard.
However, as the tests that were added with that revision are passing
correctly, the assertion is most likely not correct.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
12:11 Changeset [89691] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Unreviewed: Skipping failing progress-clone.html on win.

r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
on win, but it should stay skipped because there is no progress
element on win (bug 49769)

  • platform/win/Skipped:
11:48 Changeset [89690] by zimmermann@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/Source/WebCore

2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor text iterator code respecting surrogate pairs from WidthIterator
https://bugs.webkit.org/show_bug.cgi?id=63319

WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:

UChar32 character = 0;
unsigned clusterLength = 0;

SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
while (textIterator.consume(character, clusterLength)) {

Either clusterLength is 1 and UChar32 fits into a single UChar.
Or clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
...


textIterator.advance(clusterLength);

}

SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
Doesn't affect any tests, just refactoring.

  • CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
  • platform/graphics/SurrogatePairAwareTextIterator.h: Added. (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • platform/graphics/WidthIterator.h:
11:47 Changeset [89689] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix after r89685

  • WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.
11:43 Changeset [89688] by jberlin@webkit.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.

  • fast/css/font-face-in-shadow-DOM.html: Removed.
  • fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
  • platform/win-xp/fast/css: Removed.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.
11:35 Changeset [89687] by enne@google.com
  • 5 edits
    42 adds in trunk

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Add a number of composited positioning tests on pages with dir=rtl.
The reference images are all identical to what the non-composited path
generates.

The overflow-scrolled tests on Safari do not generate the right images
due to bug 63284, but the layer tree is correct so they are not
skipped.

  • compositing/rtl/rtl-absolute-expected.png: Added.
  • compositing/rtl/rtl-absolute-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-absolute-overflow.html: Added.
  • compositing/rtl/rtl-absolute.html: Added.
  • compositing/rtl/rtl-fixed-expected.png: Added.
  • compositing/rtl/rtl-fixed-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-fixed-overflow.html: Added.
  • compositing/rtl/rtl-fixed.html: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
  • compositing/rtl/rtl-iframe-absolute.html: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
  • compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
  • compositing/rtl/rtl-iframe-fixed.html: Added.
  • compositing/rtl/rtl-iframe-relative-expected.png: Added.
  • compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • compositing/rtl/rtl-iframe-relative.html: Added.
  • compositing/rtl/rtl-relative-expected.png: Added.
  • compositing/rtl/rtl-relative-expected.txt: Added.
  • compositing/rtl/rtl-relative.html: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-06-24 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Incorrect RenderLayer transforms on overflow RTL pages
https://bugs.webkit.org/show_bug.cgi?id=60741

Fix positioning of the root graphics layer for RTL pages. The fact
that the left side of the page is negative for pages with overflow is
not taken into account when calculating the position. This negative
value ends up being double-counted for the root graphics layer (once
in the position and once in the offset) and it shifts child layers
into the wrong place.

Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html

compositing/rtl/rtl-absolute-overflow.html
compositing/rtl/rtl-absolute.html
compositing/rtl/rtl-fixed-overflow-scrolled.html
compositing/rtl/rtl-fixed-overflow.html
compositing/rtl/rtl-fixed.html
compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
compositing/rtl/rtl-iframe-absolute-overflow.html
compositing/rtl/rtl-iframe-absolute.html
compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
compositing/rtl/rtl-iframe-fixed-overflow.html
compositing/rtl/rtl-iframe-fixed.html
compositing/rtl/rtl-iframe-relative.html
compositing/rtl/rtl-relative.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
11:24 Changeset [89686] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Add expected (failing?) results for win-xp to get the bots green.

  • platform/win-xp/fast/css: Added.
  • platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
11:09 Changeset [89685] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Make the web process pause dialog look better on Vista/7 and robust against executable renames

Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7

Reviewed by Brian Weinstein.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.

10:52 Changeset [89684] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
Adding new platform specific results since the new layout in the tests changes the render tree spew.
Pixel tests are still good.

  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
10:45 Changeset [89683] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-06-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Add BeforeChildren and AfterChildren to the Position's anchor types
https://bugs.webkit.org/show_bug.cgi?id=63100

Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
firstPositionInNode and lastPositionInNode.

These new types of positions will let us express the first and the last positions in a non-text node in O(1).

No new tests because there is no new behavior or feature exposed.

  • dom/Position.cpp: (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes. (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node. (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and the offset in the anchor node for AfterChildren. (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren. (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick for table and ignored contents like before or after anchor. (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of the anchor node for AfterChildren. (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children. (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type is AfterChildren. (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
  • dom/Position.h: (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren. (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren. (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node, the anchor type shouldn't be BeforeChildren or AfterChildren.
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset on BeforeChildren or AfterChildren position.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder after paragraphs below the block is moved into, it needs to be the position after the current last child in the block instead of after children in the block; otherwise the position will move to the end of block.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after children or before/after anchor, just return null for these anchor types.
10:37 Changeset [89682] by dominicc@chromium.org
  • 68 edits in trunk

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • Source/autotools/symbols.filter: Export symbols for GTK.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Update tests to use internals.{ensureShadowRoot, shadowRoot,
shadowPseudoId, removeShadowRoot} instead of layoutTestController.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLProgressElement/progress-clone-expected.txt:
  • fast/dom/HTMLProgressElement/progress-clone.html:
  • fast/dom/shadow/activeelement-should-be-shadowhost.html:
  • fast/dom/shadow/create-content-element.html:
  • fast/dom/shadow/gc-shadow-expected.txt:
  • fast/dom/shadow/gc-shadow.html:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/nodetype.html:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:
  • fast/events/shadow-boundary-crossing.html:
  • fast/forms/resources/common.js: (getValidationMessageBubbleNode):
  • fast/html/clone-keygen-expected.txt:
  • fast/html/clone-keygen.html:
  • fast/html/clone-range-expected.txt:
  • fast/html/clone-range.html:
  • fast/html/details-clone.html:
  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-override.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/media-controls.js: (mediaControlsButtonCoordinates):
  • media/video-controls-in-media-document.html:
  • platform/win/Skipped: shadowRoot and friends now available on win.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

  • WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
  • testing/Internals.cpp: The new home of shadowRoot and friends. (WebCore::Internals::ensureShadowRoot): (WebCore::Internals::shadowRoot): (WebCore::Internals::removeShadowRoot): (WebCore::Internals::shadowPseudoId):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Chromium API. These are not
required any more.

  • public/WebElement.h:
  • src/WebElement.cpp:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from GTK DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from Mac API. These are not
required any more.

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow-DOM related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow-DOM related methods from Qt DRT API. These are not
required any more.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove shadow DOM-related methods from WebKit2 API. These are not
required any more.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
  • win/WebKit2CFLite.def: Same for Cairo.

2011-06-24 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Convert shadow DOM-related tests to use window.internals
https://bugs.webkit.org/show_bug.cgi?id=61671

Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
removeShadowRoot from layoutTestController; these have been
replaced by equivalents in window.internals instead.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
09:57 Changeset [89681] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
https://bugs.webkit.org/show_bug.cgi?id=63327

  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
  • transforms/3d/point-mapping/3d-point-mapping.html:
09:35 Changeset [89680] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Refactor creation of primitive values in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=63270

Covered by existing tests.

  • css/CSSParser.cpp: (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values

to keep the cast in one place.

(WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.h: (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference
09:28 Changeset [89679] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.

  • platform/win-wk2/fast/forms: Added.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
09:26 Changeset [89678] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[X11] Do not call NPP_SetWindow with a null window handle on destroy
https://bugs.webkit.org/show_bug.cgi?id=62981

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::destroy):
09:09 Changeset [89677] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add (failing?) expected results for mac-wk2 to get the bots green.

  • platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.
08:59 Changeset [89676] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-06-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.


Exit immediately if the last condition tested fails.

Make <video> app cache test exit immediately on failure
https://bugs.webkit.org/show_bug.cgi?id=63323

08:54 Changeset [89675] by carlosgc@webkit.org
  • 2 edits in trunk

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add more debug options to compilation
https://bugs.webkit.org/show_bug.cgi?id=63318

Add --enable-debug-symbols to enable/disable compilation with
debug symbols and --enable-debug-features to enable/disable debug
features. Both options are unconditionally enabled for debug
builds.

  • configure.ac:
08:43 Changeset [89674] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325

Skip those tests to get the bots green.

  • platform/mac-wk2/Skipped:
08:42 Changeset [89673] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix runtime critical warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63256

Check whether there's a view widget before trying to use it in
PlatformScreenGtk. If there isn't a view widget, which is the case
in WebKit2, try to use the default GdkScreen and monitor.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getToplevel): Helper function to get the toplevel widget. (WebCore::getVisual): Use getToplevel(). (WebCore::getScreen): Helper funtion to get the screen of a widget. (WebCore::screenRect): Use getToplevel() and getScreen().
07:14 Changeset [89672] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

  • platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.
06:10 Changeset [89671] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-24 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed.
Remove non-existent items from the qt-wk2 skipped list.

  • platform/qt-wk2/Skipped:
05:37 Changeset [89670] by ossy@webkit.org
  • 2 edits in trunk/Tools

Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320

Reviewed by Dirk Schulze.

  • Scripts/run-bindings-tests:
05:18 Changeset [89669] by yutak@chromium.org
  • 14 edits in trunk/Source

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Add a flag in Setting so that WebSocket protocols can be switched
dynamically. The protocol we have implemented so far is based on
older Hixie-76 specification. A new protocol is being discussed in
IETF HyBi working group, and I'm planning to implement the new protocol
behind this Settings flag.

I will add a method to LayoutTestController which flips this flag in
a later patch. In this way, we can put tests for both protocols in
the same place and test implementation for both protocols at the same time.

This patch only adds a flag. The flag is not used yet, thus there is
no change in functionality. Therefore, no tests were added.

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseHixie76WebSocketProtocol): (WebCore::Settings::useHixie76WebSocketProtocol):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

2011-06-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348

Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setHixie76WebSocketProtocolEnabled): (WebPreferences::hixie76WebSocketProtocolEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
05:02 Changeset [89668] by tkent@chromium.org
  • 7 edits
    2 adds
    17 deletes in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Clean up some tests for search cancel buttons.
https://bugs.webkit.org/show_bug.cgi?id=63121

  • Introduce a function to retrieve a reliable position of a search cancel button.
  • Convert two tests to dumpAsText().
  • fast/forms/resources/common.js: (searchCancelButtonPosition): Added.
  • fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
  • fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
  • fast/forms/search-transformed-expected.txt: Added.
  • fast/forms/search-transformed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • fast/forms/search-zoomed-expected.txt: Added.
  • fast/forms/search-zoomed.html:
    • Use searchCancelButtonPosition().
    • Convert to dumpAsText().
  • platform/chromium/test_expectation.txt: search-transformed.html should pass.
  • platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.png: Removed.
  • platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
  • platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.png: Removed.
  • platform/mac/fast/forms/search-transformed-expected.txt: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.png: Removed.
  • platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
  • platform/qt/fast/forms/search-transformed-expected.txt: Removed.
  • platform/qt/fast/forms/search-zoomed-expected.txt: Removed.
04:52 Changeset [89667] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2011-06-24 Kent Tamura <tkent@chromium.org>

Remove an JavaScript error in media-controls-clone.html.
https://bugs.webkit.org/show_bug.cgi?id=63195

  • media/media-controls-clone.html: Remove run() call.
  • platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
  • platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
  • platform/mac/media/media-controls-clone-expected.txt: ditto.
  • platform/win/media/media-controls-clone-expected.txt: ditto.
04:47 Changeset [89666] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/utilities.js: ():
04:18 Changeset [89665] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: uncommenting chromium devtools tests.

  • platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
04:17 Changeset [89664] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add ewk_auth.h to EWebKit.h
https://bugs.webkit.org/show_bug.cgi?id=63311

  • ewk/EWebKit.h: Add ewk_auth.h
03:42 Changeset [89663] by morrita@google.com
  • 3 edits in trunk/Tools

2011-06-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=63216

Deleted m_webViewHost which looks leaked.

  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell):
03:39 Changeset [89662] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: HTML preview should delete old iframe on show().
https://bugs.webkit.org/show_bug.cgi?id=63170

  • inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype._createIFrame):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
03:21 Changeset [89661] by krit@webkit.org
  • 13 edits
    1 add in trunk/Source/WebCore

2011-06-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Convert AnimatedString to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63296

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.

No new tests added. No change of functionality.

  • CMakeLists.txt: Added new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedString.cpp: Added. Animator for SVGString. (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator): (WebCore::SVGAnimatedStringAnimator::constructFromString): (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedStringAnimator::calculateDistance):
  • svg/SVGAnimatedString.h: (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createString): (WebCore::SVGAnimatedType::string): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
02:06 Changeset [89660] by mario@webkit.org
  • 5 edits in trunk

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Unskip accessibility test that will be passing from now on.

  • platform/gtk/Skipped: Unskipped passing test.

2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Consider rows being ignored when adding children to tables
https://bugs.webkit.org/show_bug.cgi?id=62718

Hide row objects in tables in GTK's accessibility wrapper.

This is a different approach in the way WebCore's accessible
rows are exposed to assistive technologies in the GTK port,
since from now on those objects are kept in WebCore (they do not
declare to ignore accessibility) and just bypassed in the mapping
to ATK, allowing to hide them in the ATK hierarchy while, at the
same time, keeping them internally to be able to provide enough
information to determine tables related information, such as rows
counting or finding an cell for specific coordinates.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Do not ignore accessibility for table rows here.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Bypass rows when needed. (getNChildrenForTable): New, find the number of children for a table, which will be the addition of all cells for its rows. (webkit_accessible_get_n_children): Call to getNChildrenForTable for accessibility tables if needed. (getChildForTable): New, bypass rows when needed, retrieving cells as if they were direct children for tables. (webkit_accessible_ref_child): Call to refChildForTable if needed. (getIndexInParentForCellInRow): New, get the index for a given cell in its parent table, considering other rows' cells. (webkit_accessible_get_index_in_parent): Call to getIndexInParentForCellInRow if needed.
01:43 Changeset [89659] by caseq@chromium.org
  • 12 edits in trunk

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype.createClientIframe):
  • inspector/front-end/inspector.css: (iframe.extension): (iframe.panel.extension):

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension panel iframes do not span entire panel client area
https://bugs.webkit.org/show_bug.cgi?id=63165

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel): ():
  • http/tests/inspector/inspector-test.js: ():
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (dumpObject): (dumpArray): (evaluateOnFrontend.callbackWrapper): (evaluateOnFrontend): ():
  • http/tests/inspector/resources/extension-panel.html:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
01:25 Changeset [89658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Darin Fisher.

Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
https://bugs.webkit.org/show_bug.cgi?id=62396

  • public/WebURLError.h: (WebKit::WebURLError::WebURLError):
  • src/WebURLError.cpp: (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
01:24 Changeset [89657] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-24 David Grogan <dgrogan@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
https://bugs.webkit.org/show_bug.cgi?id=61653

roll out r86838

No new tests - refactoring.

  • dom/Document.h:
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::create): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::~EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
  • dom/EventQueue.h:
01:02 Changeset [89656] by caseq@chromium.org
  • 7 edits in trunk/LayoutTests

2011-06-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
https://bugs.webkit.org/show_bug.cgi?id=63160

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest._replyToExtension): (initialize_ExtensionsTest):
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/extension-main.js: (onError): (onTestsDone):
  • inspector/extensions/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions.html:
00:43 Changeset [89655] by commit-queue@webkit.org
  • 14 edits
    3 deletes in trunk/Source

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Removed.
  • wtf/unicode/ScriptCodesFromICU.h: Removed.
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • icu/unicode/uscript.h: Removed.

2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316

It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).

  • WebCore.exp.in:
  • icu/unicode/uscript.h:
  • page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
00:09 Changeset [89654] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build.

  • WebKitTestRunner/GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.