Timeline


and

07/03/11:

22:59 Changeset [90352] by barraclough@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63879
Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.

Reviewed by Sam Weinig.

There is a lot of copy & paste code here; we can reduce duplication by making
a shared implementation.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::commute):

  • Make these function platform agnostic.
  • assembler/MacroAssemblerX86Common.h:
    • Moved branch32/commute up to MacroAssembler.
  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):

  • Add an implementation matching that for op_loop_if_less, which just calls op_jless.
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

  • Common implmentations of these methods for JSVALUE64 & JSVALUE32_64.

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE64.
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE32_64.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
    • Remove old implementation of emit_op_loop_if_lesseq.
22:56 Changeset [90351] by dominicc@chromium.org
  • 5 edits in trunk

2011-07-03 Dominic Cooney <dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Updates test result, and adds a test for setting value < 0.

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:

2011-07-03 Dominic Cooney <dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Test: fast/dom/HTMLProgressElement/set-progress-properties.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::value):
22:20 Changeset [90350] by yutak@chromium.org
  • 8 edits in trunk/LayoutTests

2011-07-03 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: pywebsocket handlers should raise exception to abort the connection
https://bugs.webkit.org/show_bug.cgi?id=63794

pywebsocket automatically sends handshake response when web_socket_do_extra_handshake()
finishes, and starts closing handshake (sends a close frame and waits for client's response)
after web_socket_transfer_data() exits. To stop this behavior, a handler must raise an
exception.

Some of our handlers send broken handshake in web_socket_do_extra_handshake(). If this handler
function exits without raising an exception, pywebsocket automatically sends another handshake
response, which is not really necessary. Normally this extra handshake message is not a problem,
because the client does not read any data beyond the end of the first (broken) handshake if
the client is working correctly. However, if the client erroneously accepts the first handshake,
it will be hard to diagnose the problem because of the extra message. The same can happen for
web_socket_transfer_data().

Generally, pywebsocket handlers should raise an exception if they do not want to send any more
data. However, this fact has been overlooked in past changes, and handlers in many tests exit
normally where they should raise an exception. This change fix these errors.

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Do not need to cycle until disconnection.
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Some ports (Chromium) intercept handshake messages and do not pass server's response to WebCore until they find the end of handshake response (i.e. "\r\n\r\n" and 16-byte data). If the handler aborts the connection without sending this end-of-response marker, entire response is ignored, which causes the test to fail.
20:54 Changeset [90349] by tkent@chromium.org
  • 7 edits
    3 deletes in trunk

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • fast/js/number-toString-expected.txt:

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/BigInteger.h: Removed.
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToPrecision): (JSC::numberProtoFuncToString):
  • runtime/Uint16WithFraction.h: Removed.
  • wtf/MathExtras.h:

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
19:01 Changeset [90348] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-07-03 Daniel Bates <dbates@webkit.org>

Import Checkout in scm_unittests.py and logging in svn.py to fix
Python missing global variable errors

Rubber-stamped by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
  • Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
15:27 Changeset [90347] by barraclough@apple.com
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
13:34 Changeset [90346] by robert@webkit.org
  • 4 edits
    8 adds in trunk

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
13:22 Changeset [90345] by krit@webkit.org
  • 4 edits
    3 adds in trunk

2011-07-03 Dirk Schulze <krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


Test accumulate=sum on SVGAnimateTransform. The animation shouldn't start with initial value
on every repeat for accumulation.

  • svg/animations/script-tests/svgtransform-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgtransform-animation-1-expected.txt: Added.
  • svg/animations/svgtransform-animation-1.html: Added.

2011-07-03 Dirk Schulze <krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
the first repeat, from 200% on the second and so on.

Test: svg/animations/svgtransform-animation-1.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
11:29 Changeset [90344] by commit-queue@webkit.org
  • 4 edits
    8 deletes in trunk

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
http://trac.webkit.org/changeset/90342
https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Removed.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-location-reload.html: Removed.

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
http://trac.webkit.org/changeset/90342
https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
  • loader/NavigationScheduler.cpp:
10:42 Changeset [90343] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-03 Robert Hogan <robert@webkit.org>

Skip Qt platform-specific test after r90341
https://bugs.webkit.org/show_bug.cgi?id=45455

Unreviewed, skip test.

The Skipped list needs the platform-specific path of the test.

  • platform/qt/Skipped:
10:27 Changeset [90342] by robert@webkit.org
  • 4 edits
    8 adds in trunk

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
10:14 Changeset [90341] by robert@webkit.org
  • 15 edits
    6 adds in trunk

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

Add a new test and move third-party cookie tests to 'pending
unskipping' for when bots move to 4.8.

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

https://bugs.webkit.org/show_bug.cgi?id=45455

  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html: Added.
  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking-expected.txt: Added. This test is a stricter version of third-party-cookie-relaxing.html with the expected behaviour that all third-party cookies are blocked.
  • platform/qt/Skipped: Prepare tests for unskipping on Qt-4.8.
  • platform/qt/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added. Qt returns cookie lists in a different order from other ports.

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

Identifying third-party cookies is facilitated by API new to QUrl from
Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
list to determine the top-level registry-controlled domain of the Url.

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

Test: http/tests/cookies/strict-third-party-cookie-blocking.html

  • WebCore.pro:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/qt/ThirdPartyCookiesQt.cpp: Added. (WebCore::cookieJar): (WebCore::isFirstPartyCookie): (WebCore::cookieAllowed): (WebCore::allowThirdPartyCookies):
  • platform/qt/ThirdPartyCookiesQt.h: Added.

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

This adds new API to QWebSettings that allows clients to
select one of three third-party cookie blocking policies:

AlwaysAllowThirdPartyCookies
AlwaysBlockThirdPartyCookies
AllowThirdPartyWithExistingCookies

The first two are self-explanatory, the third mimics Safari's
default behaviour of permitting third-party cookies when the user
already has cookies from the third-party site. This was
introduced to allow third-party cookie blocking to play well with
facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.

There is scope for adding an 'exceptions' list API and clients would
struggle to implement it themselves given the paucity of information
available from setCookiesForUrl().

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

https://bugs.webkit.org/show_bug.cgi?id=45455

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setThirdPartyCookiePolicy): (QWebSettings::thirdPartyCookiePolicy):
  • Api/qwebsettings.h:

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setAlwaysBlockCookies):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
08:58 Changeset [90340] by vsevik@chromium.org
  • 6 edits in trunk

2011-07-03 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
https://bugs.webkit.org/show_bug.cgi?id=63712

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:

2011-07-03 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
https://bugs.webkit.org/show_bug.cgi?id=63712

Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
08:51 Changeset [90339] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-07-03 Robert Hogan <robert@webkit.org>

Add platform-specific results after r90338

Unreviewed, add platform-specific results for new rendertree test.
https://bugs.webkit.org/show_bug.cgi?id=30355

http://trac.webkit.org/changeset/90338

  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
08:04 Changeset [90338] by robert@webkit.org
  • 6 edits
    3 adds in trunk

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

Unfortunately this has to be a rendertree test, as there is no rendertext way of
determining if a selection is still highlighted.

  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection.html: Added.

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

Test: plugins/mouse-click-plugin-clears-selection.html

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebCore.exp.in: Add symbol for FocusController::setFocusedNode
  • plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
redundant, since it calls both.

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebProcess/Plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() redundant, since the
former calls it.

04:09 Changeset [90337] by abarth@webkit.org
  • 3 edits
    1 move
    1 add in trunk/Tools

2011-07-03 Adam Barth <abarth@webkit.org>

Factor ReflectionHandler out of the rebaseline server. Just code motion.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
03:45 Changeset [90336] by abarth@webkit.org
  • 2 edits
    6 moves
    5 adds in trunk/Tools

2011-07-03 Adam Barth <abarth@webkit.org>

Move the rebaseline server out of the commands package and into the
(new) servers package. This patch prepares for refactoring this code
to share server infrastructure with the (forthcoming) garden-o-matic
command.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/init.py: Added.
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.

07/02/11:

21:02 Changeset [90335] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Remove failing expectation for fast/events/panScroll-click-hyperlink.html
(Chromium still doesn't pass the test, since it doesn't have pan
scrolling enabled, but r90235 added failing expectations for the Windows
port, which Chromium Win and Linux pick up)

Also remove flaky expectations for some tests that have not failed as
far back as the flakiness dashboard has data for.

  • platform/chromium/test_expectations.txt:
19:26 Changeset [90334] by mjs@apple.com
  • 6 edits in trunk/PerformanceTests/SunSpider

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Update SunSpider versioning to 1.0
https://bugs.webkit.org/show_bug.cgi?id=63870

Reviewed by Dan Bernstein.

  • hosted/sunspider.html:
  • hosted/versions.html:
  • resources/driver-TEMPLATE.html:
  • resources/results-TEMPLATE.html:
  • sunspider:
18:35 Changeset [90333] by mjs@apple.com
  • 3 edits in trunk/PerformanceTests/SunSpider

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Sunspider 0.9.1 harness doesn't actually close() its test documents
https://bugs.webkit.org/show_bug.cgi?id=47045

Reviewed by Daniel Bates.

  • hosted/versions.html:
  • resources/driver-TEMPLATE.html:
18:19 Changeset [90332] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Have another go at fixing the Windows build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

18:15 Changeset [90331] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-07-02 Anders Carlsson <andersca@apple.com>

Null out the plug-in controller after destroying the plug-in.
https://bugs.webkit.org/show_bug.cgi?id=63869

Reviewed by Maciej Stachowiak.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::destroy): Call destroyPlugin.
  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::destroyPlugin): Call destroy and null out the plug-in controller.
  • WebProcess/Plugins/Plugin.h: Add destroyPlugin, make destroy private.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Call destroyPlugin.
17:57 Changeset [90330] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Update skipped list.

  • platform/wk2/Skipped:
17:51 Changeset [90329] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build for real.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):

16:55 Changeset [90328] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-07-02 Anders Carlsson <andersca@apple.com>

Implement NPN_PluginThreadAsyncCall
https://bugs.webkit.org/show_bug.cgi?id=63868

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PluginThreadAsyncCall): Call NetscapePlugin::pluginThreadAsyncCall.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginThreadAsyncCall): Schedule a work item to call the function on the main run loop.

(WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
If the plug-in is still running, run the function.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Add new member function.
  • WebProcess/Plugins/Plugin.h: Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially ref the plug-in from other threads.
16:41 Changeset [90327] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

16:40 Changeset [90326] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-07-02 Anders Carlsson <andersca@apple.com>

Move the plug-in controller member variable up to the shared Plugin base class
https://bugs.webkit.org/show_bug.cgi?id=63867

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Remove m_pluginController.

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::userAgent):
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::setStatusbarText):
(WebKit::NetscapePlugin::evaluate):
(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
(WebKit::NetscapePlugin::tryToShortCircuitInvoke):
(WebKit::NetscapePlugin::cancelStreamLoad):
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
(WebKit::NetscapePlugin::getAuthenticationInfo):
Use controller() instead of m_pluginController.

(WebKit::NetscapePlugin::initialize):
This doesn't take a PluginController parameter anymore.

(WebKit::NetscapePlugin::destroy):
No need to null out the plug-in controller.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Remove m_pluginController member variable.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::windowFocusChanged): Use controller() instead of m_pluginController.


  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Plugin): Initialize m_pluginController.

(WebKit::Plugin::initialize):
New function that initializes the plug-in controller and then calls the real
virtual initialize member function.

  • WebProcess/Plugins/Plugin.h: Add m_pluginController member variable and a new initialize virtual member function that doesn't take a PluginController parameter. Make the "old" initialize member function set up the plug-in controller.

(WebKit::Plugin::controller):
This is now a simple getter.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::PluginProxy): Remove m_pluginController.

(WebKit::PluginProxy::pluginProcessCrashed):
Use controller(), remove a bogus null check.

(WebKit::PluginProxy::initialize):
This doesn't take a PluginController parameter now.

(WebKit::PluginProxy::destroy):
No need to null out the plug-in controller member variable.

(WebKit::PluginProxy::loadURL):
(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
(WebKit::PluginProxy::getAuthenticationInfo):
(WebKit::PluginProxy::windowNPObjectID):
(WebKit::PluginProxy::getPluginElementNPObject):
(WebKit::PluginProxy::evaluate):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):
(WebKit::PluginProxy::setComplexTextInputEnabled):
(WebKit::PluginProxy::update):
Use controller() instead of m_pluginController.


  • WebProcess/Plugins/PluginProxy.h: Remove m_pluginController.
16:20 Changeset [90325] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Remove Chromium Leopard failing expectations for two tests (fast/dom/
HTMLMeterElement/meter-writing-mode.html and fast/images/
imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.

  • platform/chromium/test_expectations.txt:
16:08 Changeset [90324] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof

Reviewed by Sam Weinig.

Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jitAssertIsCell):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::jitAssertIsCell):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:59 Changeset [90323] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Meant to actually remove expectations in r90322, not just comment them
out.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [90322] by mihaip@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
since the regular Mac baselines can't be used due to single-pixel
differences in character rendering (presumably caused by 32-bit vs.
64-bit binaries).

  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:12 Changeset [90321] by mjs@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

Not Reviewed.

Fix obviou typo in previous commit.

  • tests/sunspider-1.0/bitops-bitwise-and.js:
14:11 Changeset [90320] by mihaip@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Chromium expectations update:

  • Add failing expectation for fast/css/last-of-type-pseudo-class.html, which fails in debug only.
  • Remove Chromium-specific baselines for fast/js/reserved-words.html, the test now passes with the regular baselines.
  • platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
  • platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:09 Changeset [90319] by mjs@apple.com
  • 5 edits in trunk/PerformanceTests/SunSpider

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

SunSpider: all four bitops benchmarks can be replaced with NOP
https://bugs.webkit.org/show_bug.cgi?id=38446

  • tests/sunspider-1.0/bitops-3bit-bits-in-byte.js: (TimeFunc): Save the result.
  • tests/sunspider-1.0/bitops-bits-in-byte.js: (TimeFunc): Save the result.
  • tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly save the results.
  • tests/sunspider-1.0/bitops-nsieve-bits.js: (sieve): Save the result.
13:57 Changeset [90318] by mjs@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

2011-07-02 Maciej Stachowiak <mjs@apple.com>

SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
https://bugs.webkit.org/show_bug.cgi?id=60937

Reviewed by Dan Bernstein.

  • tests/sunspider-1.0/string-validate-input.js: (doTest): Rename the variable to username
13:45 Changeset [90317] by mjs@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

SunSpider: The main function of math-cordic is dead code
https://bugs.webkit.org/show_bug.cgi?id=63863


Try to prevent math-cordic from being eliminated as dead code or
compiled down to a constant.

  • tests/sunspider-1.0/math-cordic.js: (cordicsincos): (cordic):
10:26 Changeset [90316] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Update the header file too.

  • WebKitSystemInterface.h:
09:25 Changeset [90315] by mrowe@apple.com
  • 3 edits
    1 add in trunk/WebKitLibraries

Update WebKitSystemInterface binaries.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a: Added.
  • libWebKitSystemInterfaceSnowLeopard.a:
03:46 Changeset [90314] by tkent@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[GTK] Update expectation of fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=49245

  • platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt:

07/01/11:

23:00 Changeset [90313] by tkent@chromium.org
  • 10 edits in trunk

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733

Also, input-file-label.html passes now.

  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733

  • DEPS: Update chromium revision to 91405 to have "Choose Files" string.
21:47 Changeset [90312] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Update the expectation of search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787

  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium/test_expectations.txt:
21:45 Changeset [90311] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Remove GTK baseline added in r90294 since the test was fixed in r90309.
(File name was wrong. It was supposed to be -expected.txt)

  • platform/gtk/editing/selection/directionality-after-undo-replace.html: Removed.
19:38 Changeset [90310] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Fix typo in master.cfg, hoping to trigger a master restart.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
19:34 Changeset [90309] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

[GTK] editing/selection/directionality-after-undo-replace.html is failing
https://bugs.webkit.org/show_bug.cgi?id=63853

Reviewed by Ojan Vafai.

Don't do leapForward between mouseDown and mouseUp so that GTK recognizes the double-click.

  • editing/selection/directionality-after-undo-replace.html:
19:20 Changeset [90308] by michaeln@google.com
  • 9 edits in trunk/Source

2011-07-01 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] FileSystem API can be used to learn about installed software on the user's computer
https://bugs.webkit.org/show_bug.cgi?id=63220

  • public/WebMimeRegistry.h: (WebKit::WebMimeRegistry::wellKnownMimeTypeForExtension):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::wellKnownMimeTypeForExtension):

2011-07-01 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] FileSystem API can be used to learn about installed software on the user's computer.
Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
without consulting the OS/registry.
https://bugs.webkit.org/show_bug.cgi?id=63220

No new tests, existing layout tests that invoke file.type apply.

  • fileapi/File.cpp: Refactored the factory methods. (WebCore::createBlobDataForFileWithType): (WebCore::createBlobDataForFile): (WebCore::createBlobDataForFileSystemFile): (WebCore::File::File):
  • platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::mediaMIMETypeMap): (WebCore::findMimeType): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
  • platform/MIMETypeRegistry.h:
  • platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): (WebCore::findMimeType):
  • platform/chromium/PlatformBridge.h:
18:05 Changeset [90307] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-01 Tim Horton <timothy_horton@apple.com>

Reviewed by Darin Adler.

SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
https://bugs.webkit.org/show_bug.cgi?id=54325

Add image/svg+xml to the list of acceptable MIME types for the Image type.

17:55 Changeset [90306] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-07-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

Use common functions in fast/forms/search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787

  • fast/forms/search-rtl.html: Use searchCancelButtonPosition() to make this work on Chromium Windows and Chromium Linux.
  • platform/chromium/test_expectations.txt:
17:45 Changeset [90305] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Turn off new-run-webkit-tests and remove some debug logging.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
17:43 Changeset [90304] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-07-01 Tim Horton <timothy_horton@apple.com>

Reviewed by Darin Adler.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599

Add SVGElement::reportAttributeParsingError, which will
write a Web Inspector console message if passed an SVGParsingError
and the attribute which was being applied, only in the case where
there is actually an error.

Include the SVG document's URI when writing to the Web Inspector
console, so that the UI displays both the filename and the line number.

  • svg/SVGDocumentExtensions.cpp: (WebCore::reportMessage):
  • svg/SVGElement.cpp: (WebCore::SVGElement::reportAttributeParsingError):
  • svg/SVGElement.h:
17:26 Changeset [90303] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-07-01 Scott Byer <scottbyer@chromium.org>

Reviewed by Adam Barth.

Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770

Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace

Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.

  • platform/ScrollAnimatorNone.cpp: (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters): (WebCore::ScrollAnimatorNone::scroll):

2011-07-01 Scott Byer <scottbyer@chromium.org>

Reviewed by Adam Barth.

Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770

Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.

  • tests/ScrollAnimatorNoneTest.cpp: (ScrollAnimatorNoneTest::updateDataFromParameters): (TEST_F):
17:16 Changeset [90302] by leviw@chromium.org
  • 22 edits in trunk/Source/WebCore

2011-07-01 Levi Weintraub <leviw@chromium.org>

Switch primary virtual layout functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63852

Reviewed by Eric Seidel.

Switching the primary overloaded layout functions over to the new layout unit abstraction.

No new tests, no functionality changes.

  • html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::layout):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
  • rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::layout):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/RenderView.cpp: (WebCore::RenderView::layout):
  • rendering/RenderView.h: (WebCore::RenderView::layoutDelta): (WebCore::RenderView::addLayoutDelta):
  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout):
  • rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::layout):
  • rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::layout):
  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::layout):
  • rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout):
17:09 Changeset [90301] by weinig@apple.com
  • 5 edits in trunk

2011-07-01 Sam Weinig <sam@webkit.org>

Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856

Reviewed by Dan Bernstein.

Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
the nesting cap to 512 to cover more cases where rending recursion was biting us.

  • page/Settings.h: Reduce the nesting cap to 512.

2011-07-01 Sam Weinig <sam@webkit.org>

Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856

Update test for new cap.

  • fast/parser/block-nesting-cap-expected.txt:
  • fast/parser/script-tests/block-nesting-cap.js:
17:09 Changeset [90300] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Add some more debug logging to try to understand why we're getting
stuck acquring the HTTP lock.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
17:05 Changeset [90299] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=63855

Reviewed by Ryosuke Niwa.

Allow a trailing whitespace in the expected result, since Windows
has different word iterating behavior.

  • editing/selection/directionality-after-undo-replace.html:
16:45 Changeset [90298] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
16:41 Changeset [90297] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Remove Chromium Windows 7 and Vista media test expectations, since
clobbering the bots appears to have fixed the timeouts and failures.

  • platform/chromium/test_expectations.txt:
16:30 Changeset [90296] by lforschler@apple.com
  • 5 edits in tags/Safari-534.50.2/Source

Versioning

16:24 Changeset [90295] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Add change accidentally left out of last commit.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
backing scale.

16:19 Changeset [90294] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853.

  • platform/gtk/editing/selection/after-line-break-expected.txt: Added.
  • platform/gtk/editing/selection/directionality-after-undo-replace.html: Added.
16:13 Changeset [90293] by darin@apple.com
  • 6 edits in trunk/Source

2011-07-01 Darin Adler <darin@apple.com>

Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848

Reviewed by Simon Fraser.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::clampedContentsScaleForScale): Increased the maximum scale since scale factor can now include both page contents scale and backing scale.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the backing scale as well as the page contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageContentsScale): Added. (WebCore::RenderLayerBacking::backingScale): Added.
  • rendering/RenderLayerBacking.h: Added new private functions.

2011-07-01 Darin Adler <darin@apple.com>

Consider backing scale factor when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848

Reviewed by Simon Fraser.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): Set contents scale on the non-composited content layer based on the backing scale factor. (WebKit::LayerTreeHostCA::createPageOverlayLayer): Set contents scale on the page overlay layer based on the backing scale factor.
16:09 Changeset [90292] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Nate Chapin <japhet@chromium.org>

Unreviewed, remove extraneous newlines from
expected results for fast/workers/worker-finish-crash.html.

  • fast/workers/worker-finish-crash-expected.txt:
16:06 Changeset [90291] by darin@apple.com
  • 3 edits in trunk/LayoutTests

The commit-bot checked in files without Subversion properties, so adding them now.

  • fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added property svn:eol-style.
  • fast/loader/create-frame-in-DOMContentLoaded.html: Added properties svn:mime-type and svn:eol-style.
16:02 Changeset [90290] by adele@apple.com
  • 4 edits in trunk/Source

../WebCore: WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body

Reviewed by Darin Adler.

No new tests. I tried to make a test in DumpRenderTree with an editable WebView,
but was unsuccessful in getting the crash to happen in that instance.

  • editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT.

../WebKit/mac: WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body

Reviewed by Darin Adler.

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
space, and after-white-space properties to subframes in the editable document.

15:43 Changeset [90289] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner.

  • platform/wk2/Skipped:
15:31 Changeset [90288] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-07-01 Levi Weintraub <leviw@chromium.org>

Switch overflow and collapsedMargins to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63840

Reviewed by Eric Seidel.

Switching overflow and collapsedMargins over to the new layout unit abstraction.

Also removing an unused function: blockDirectionOverflow

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapsedMarginBeforeForChild): (WebCore::RenderBlock::collapsedMarginAfterForChild):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::collapsedMarginBefore): (WebCore::RenderBlock::collapsedMarginAfter):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
  • rendering/RenderBox.h: (WebCore::RenderBox::layoutOverflowRect): (WebCore::RenderBox::minYLayoutOverflow): (WebCore::RenderBox::maxYLayoutOverflow): (WebCore::RenderBox::minXLayoutOverflow): (WebCore::RenderBox::maxXLayoutOverflow): (WebCore::RenderBox::maxLayoutOverflow): (WebCore::RenderBox::logicalLeftLayoutOverflow): (WebCore::RenderBox::logicalRightLayoutOverflow): (WebCore::RenderBox::visualOverflowRect): (WebCore::RenderBox::minYVisualOverflow): (WebCore::RenderBox::maxYVisualOverflow): (WebCore::RenderBox::minXVisualOverflow): (WebCore::RenderBox::maxXVisualOverflow): (WebCore::RenderBox::logicalLeftVisualOverflow): (WebCore::RenderBox::logicalRightVisualOverflow): (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::collapsedMarginBefore): (WebCore::RenderBox::collapsedMarginAfter):
  • rendering/RenderOverflow.h: (WebCore::RenderOverflow::RenderOverflow): (WebCore::RenderOverflow::minYLayoutOverflow): (WebCore::RenderOverflow::maxYLayoutOverflow): (WebCore::RenderOverflow::minXLayoutOverflow): (WebCore::RenderOverflow::maxXLayoutOverflow): (WebCore::RenderOverflow::minYVisualOverflow): (WebCore::RenderOverflow::maxYVisualOverflow): (WebCore::RenderOverflow::minXVisualOverflow): (WebCore::RenderOverflow::maxXVisualOverflow): (WebCore::RenderOverflow::setMinYLayoutOverflow): (WebCore::RenderOverflow::setMaxYLayoutOverflow): (WebCore::RenderOverflow::setMinXLayoutOverflow): (WebCore::RenderOverflow::setMaxXLayoutOverflow): (WebCore::RenderOverflow::setMinYVisualOverflow): (WebCore::RenderOverflow::setMaxYVisualOverflow): (WebCore::RenderOverflow::setMinXVisualOverflow): (WebCore::RenderOverflow::setMaxXVisualOverflow): (WebCore::RenderOverflow::layoutOverflowRect): (WebCore::RenderOverflow::visualOverflowRect): (WebCore::RenderOverflow::move): (WebCore::RenderOverflow::addLayoutOverflow): (WebCore::RenderOverflow::addVisualOverflow): (WebCore::RenderOverflow::setLayoutOverflow): (WebCore::RenderOverflow::setVisualOverflow): (WebCore::RenderOverflow::resetLayoutOverflow):
15:30 Changeset [90287] by hans@chromium.org
  • 4 edits in trunk

2011-07-01 Hans Wennborg <hans@chromium.org>

IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817

Reviewed by Tony Chang.

Disable IndexedDB quota teset since quota enforcement is not yet
supported by the LevelDB back-end.

  • platform/chromium/test_expectations.txt:

2011-07-01 Hans Wennborg <hans@chromium.org>

IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817

Reviewed by Tony Chang.

Use LevelDB as the default back-end.

Covered by existing layout tests for indexeddb, which will now be
using the LevelDB back-end.

  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
15:25 Changeset [90286] by mihaip@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
(r90261 added a Leopard expectation for the Mac port, but Chromium
Leopard can pass with the default baseline).

  • platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
15:11 Changeset [90285] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-07-01 Eric Seidel <eric@webkit.org>

new-run-webkit-tests results does not understand that mac uses test_expectations files
https://bugs.webkit.org/show_bug.cgi?id=63838

Reviewed by Adam Barth.

We've decided to "enable" test_expectations for the Mac port for now.
It makes the results.html results much more confusing to read, but at least they're
no longer lying to us.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
15:06 Changeset [90284] by japhet@chromium.org
  • 4 edits
    2 adds in trunk

2011-07-01 Nate Chapin <japhet@chromium.org>

Test for https://bugs.webkit.org/show_bug.cgi?id=63835.

Reviewed by Dmitry Titov.

  • fast/workers/worker-finish-crash-expected.txt: Added.
  • fast/workers/worker-finish-crash.html: Added.

2011-07-01 Nate Chapin <japhet@chromium.org>

Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
https://bugs.webkit.org/show_bug.cgi?id=63835

Reviewed by Dmitry Titov.

Test: fast/workers/worker-finish-crash.html

  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::notifyFinished):
  • workers/WorkerScriptLoader.h:
15:04 Changeset [90283] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-07-01 Adrienne Walker <enne@google.com>

[chromium] Upload root layer textures first so that it is less likely to be skipped
https://bugs.webkit.org/show_bug.cgi?id=63850

Reviewed by James Robinson.

This is a tiny follow-on patch to bug 63760. If the root layer is not
uploaded first, then it may not have enough space to fit into texture
memory and might be skipped, leaving a blue background.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
15:02 Changeset [90282] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-01 Oliver Hunt <oliver@apple.com>

IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=63732

Reviewed by Gavin Barraclough.

Initialise the memory at the head of the new storage so that
GC is safe if triggered by reportExtraMemoryCost.

  • runtime/JSArray.cpp: (JSC::JSArray::increaseVectorPrefixLength):
15:02 Changeset [90281] by mihaip@chromium.org
  • 3 edits
    4 adds in trunk

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

  • fast/history/location-replace-hash-expected.txt: Added.
  • fast/history/location-replace-hash.html: Added.
  • fast/history/resources/location-replace-hash-1.html: Added.
  • fast/history/resources/location-replace-hash-2.html: Added.

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

location.replace('#foo') would not update the HistoryItem with the
new URL, thus navigating back to the page would use the previous
URL, even though it had been replaced. Make
HistoryController::updateForSameDocumentNavigation mirror
HistoryController::replaceState.

Test: fast/history/location-replace-hash.html

  • loader/HistoryController.cpp: (WebCore::HistoryController::updateForSameDocumentNavigation):
15:01 Changeset [90280] by rniwa@webkit.org
  • 4 edits
    6 copies in trunk/LayoutTests

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Fix expected results after r90275. I checked in Mac-specific results for these tests.
Move them to platform/mac and revert the changes in platform-independent results.
Also copy results to platform/win because they fallback to Mac by default.

  • editing/deleting/delete-br-011-expected.txt:
  • editing/selection/anchor-focus2-expected.txt:
  • editing/selection/anchor-focus3-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
  • platform/mac/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
  • platform/mac/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
  • platform/win/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
  • platform/win/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
  • platform/win/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
14:47 Changeset [90279] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Temporarily disable waiting for ReportCrash to see how this code
affects performance on the bots.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
14:44 Changeset [90278] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-07-01 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=63818
Test bots shouldn't attempt to build TestWebKitAPI on Windows.
TestWebKitAPI builds as a part of general webkit build and is a
part of build products archive.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-api-tests:
14:21 Changeset [90277] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837

Reviewed by Eric Seidel.

Instead, we should move this check to worker.py.

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
14:09 Changeset [90276] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-07-01 Jade Han <jade.han@nokia.com>

[Qt][Symbian] Update .def file for Symbian to build Tools
https://bugs.webkit.org/show_bug.cgi?id=61200

Reviewed by Laszlo Gombos.

Add newly introduced symbols to fix building the Tools directory for Symbian.

  • symbian/eabi/QtWebKitu.def:
14:07 Changeset [90275] by rniwa@webkit.org
  • 43 edits
    2 adds in trunk

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Added a test to ensure WebKit preserves non-directional selection after undo on Mac.

The directionality of selection is still lost after undoing DeleteSelectionCommand or TypingCommand
and this will be fixed in follow up patches.

  • editing/deleting/delete-br-011-expected.txt:
  • editing/selection/after-line-break-expected.txt:
  • editing/selection/anchor-focus2-expected.txt:
  • editing/selection/anchor-focus3-expected.txt:
  • editing/selection/directionality-after-undo-replace-expected.txt: Added.
  • editing/selection/directionality-after-undo-replace.html: Added.
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-01-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-02-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/fake-drag-expected.txt:
  • platform/mac/editing/selection/move-by-word-001-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Don't pass MakeNonDirectionalSelection to setSelection since no other port does this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectRange):

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Move m_isDirectional from FrameSelection to VisibleSelection.

Also fixed a bug that WebKit does not preserve non-directional selection after undo.

Test: editing/selection/directionality-after-undo-replace.html

  • WebCore.exp.in: Updated the signature of setSelection.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional. (WebCore::shouldAlwaysUseDirectionalSelection): Added. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy. Calls setIsDirectional(true) when the platform doesn't support non-directional selection. Passes align and granularity to setSelection of the base end point as expected. No longer updates granularity when updating the selection of a different frame. (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional(). (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional because the directionality is passed from m_selection automatically. Also calls shouldAlwaysUseDirectionalSelection.
  • editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true. This should be changed to false to fix the bug 60529.
  • editing/VisibleSelection.h: (WebCore::VisibleSelection::isDirectional): Added. (WebCore::VisibleSelection::setIsDirectional): Added.
  • page/EventHandler.cpp: (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of calling setSelection with MakeNonDirectionalSelection. (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional because it already calls setNonDirectionalSelectionIfNeeded.
13:52 Changeset [90274] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add more Chromium flaky expectations.

  • platform/chromium/test_expectations.txt:
13:45 Changeset [90273] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-07-01 Oliver Hunt <oliver@apple.com>

GC sweep can occur before an object is completely initialised
https://bugs.webkit.org/show_bug.cgi?id=63836

Reviewed by Gavin Barraclough.

In rare cases it's possible for a GC sweep to occur while a
live, but not completely initialised object is on the stack.
In such a case we may incorrectly choose to mark it, even
though it has no children that need marking.

We resolve this by always zeroing out the structure of any
value returned from JSCell::operator new(), and making the
markstack tolerant of a null structure.

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell): (JSC::JSCell::JSCell::operator new):
  • runtime/Structure.h: (JSC::MarkStack::internalAppend):
13:42 Changeset [90272] by lforschler@apple.com
  • 2 edits in tags/Safari-534.50.2/Source/WebKit/mac

Merge 90223.

13:29 Changeset [90271] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-07-01 Tony Chang <tony@chromium.org>

cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=63827

Reviewed by Ojan Vafai.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::boxAlign): (WebCore::InheritedFlags::boxFlex): (WebCore::InheritedFlags::boxFlexGroup): (WebCore::InheritedFlags::boxLines): (WebCore::InheritedFlags::boxOrdinalGroup): (WebCore::InheritedFlags::boxOrient): (WebCore::InheritedFlags::boxPack): (WebCore::InheritedFlags::marqueeIncrement): (WebCore::InheritedFlags::marqueeSpeed): (WebCore::InheritedFlags::marqueeLoopCount): (WebCore::InheritedFlags::marqueeBehavior): (WebCore::InheritedFlags::marqueeDirection): (WebCore::InheritedFlags::setBoxAlign): (WebCore::InheritedFlags::setBoxFlex): (WebCore::InheritedFlags::setBoxFlexGroup): (WebCore::InheritedFlags::setBoxLines): (WebCore::InheritedFlags::setBoxOrdinalGroup): (WebCore::InheritedFlags::setBoxOrient): (WebCore::InheritedFlags::setBoxPack): (WebCore::InheritedFlags::setMarqueeIncrement): (WebCore::InheritedFlags::setMarqueeSpeed): (WebCore::InheritedFlags::setMarqueeDirection): (WebCore::InheritedFlags::setMarqueeBehavior): (WebCore::InheritedFlags::setMarqueeLoopCount):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:

flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee

13:27 Changeset [90270] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-07-01 Mike Reed <reed@google.com>

Stop using deprecated SkDeviceFactory API
https://bugs.webkit.org/show_bug.cgi?id=63488

Reviewed by James Robinson.

No new tests. Check-point for removing Factory API from Skia

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
13:08 Changeset [90269] by commit-queue@webkit.org
  • 12 edits
    6 moves
    1 add in trunk/Source/WebCore

2011-07-01 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Adam Barth.

Move XMLDocumentParser to new folder xml/parser/
https://bugs.webkit.org/show_bug.cgi?id=63666

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::insert): (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::detach): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::XMLDocumentParser::finishWasCalled): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing): (WebCore::XMLDocumentParser::parseDocumentFragment):
  • xml/parser/XMLDocumentParser.h: (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::create): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
  • xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::create): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::switchToUTF16): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getParser): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
  • xml/parser/XMLDocumentParserQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
  • xml/parser/XMLDocumentParserScope.cpp: (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
13:04 Changeset [90268] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-01 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT always performs slow C calls for div and mod.
https://bugs.webkit.org/show_bug.cgi?id=63684

  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
12:54 Changeset [90267] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add more failing test expectations for Chromium media tests on Windows 7
and Vista.

  • platform/chromium/test_expectations.txt:
12:49 Changeset [90266] by tony@chromium.org
  • 2 edits in trunk

2011-07-01 Tony Chang <tony@chromium.org>

Add chromium sql directory to git ignore.

  • .gitignore:
12:47 Changeset [90265] by commit-queue@webkit.org
  • 45 edits in trunk

2011-07-01 Juan C. Montemayor <jmont@apple.com>

Reviewed by Oliver Hunt.

Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340

Updated expected test results.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/kde/parse-expected.txt:
  • fast/js/kde/string-1-n-expected.txt:
  • fast/js/kde/string-2-n-expected.txt:
  • fast/js/numeric-escapes-in-string-literals-expected.txt:
  • fast/js/removing-Cf-characters-expected.txt:
  • fast/regex/non-pattern-characters-expected.txt:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • loader/reload-subresource-when-type-changes-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.1_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T2-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T2-expected.txt:

2011-07-01 Juan C. Montemayor <jmont@apple.com>

Reviewed by Oliver Hunt.

Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340

Added error messages for the Lexer. These messages will be displayed
instead of the lexer error messages from the parser that are currently
shown.

  • parser/Lexer.cpp: (JSC::Lexer::getInvalidCharMessage): (JSC::Lexer::setCode): (JSC::Lexer::parseString): (JSC::Lexer::lex): (JSC::Lexer::clear):
  • parser/Lexer.h: (JSC::Lexer::getErrorMessage): (JSC::Lexer::setOffset):
  • parser/Parser.cpp: (JSC::Parser::parse):
12:39 Changeset [90264] by aroben@apple.com
  • 2 edits in trunk/Tools

Stop setting unsafe headers on POSTs via XHR from TestFailures page

Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
Inspector's console about unsafe headers

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(fetchResource): Removed unnecessary code to set Content-Length and Connection headers.

12:36 Changeset [90263] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786

We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.

If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).

  • Scripts/run-webkit-tests:
12:33 Changeset [90262] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Add a compat shim for --leaks. Support for --leaks will be added in
https://bugs.webkit.org/show_bug.cgi?id=63832.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:25 Changeset [90261] by aroben@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Leopard expected failure result for media/media-blocked-by-beforeload.html

The failure is tracked by <http://webkit.org/b/63829>.

  • platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
12:24 Changeset [90260] by vangelis@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-07-01 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Reserve all tile textures at layer update time to guarantee
that they will be available at draw time.
https://bugs.webkit.org/show_bug.cgi?id=63760

In addition, this patch unreserves textures used by RenderSurface's
right after the RenderSurface has been used to free up memory for
subsequent RenderSurfaces.

This patch also "fixes" the pages that display a blue background when
running out of texture memory as the root layer tiles get reserved first
and are guaranteed to get textures.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::setIsMask):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::unreserve):
  • platform/graphics/chromium/LayerTexture.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::drawTiles):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::releaseContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectTexture):
  • platform/graphics/chromium/TextureManager.h:
12:23 Changeset [90259] by jshin@chromium.org
  • 14 edits
    3 adds in trunk/Source

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)

http://bugs.webkit.org/show_bug.cgi?id=20797

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Added for UScriptCode enum.
  • wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same
file was added to JavaScriptCore/icu/unicode.

http://bugs.webkit.org/show_bug.cgi?id=20797

  • icu/unicode/uscript.h: Added.

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Allow generic font family settings per script code.
https://bugs.webkit.org/show_bug.cgi?id=20797

Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.

uscript.h has been updated to that of ICU 3.6 (the version of ICU on
Mac OS 10.5)

There should be no change in layout and no new layout test
is added.

  • WebCore.exp.in:
  • icu/unicode/uscript.h: updated to ICU 4.6
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
12:14 Changeset [90258] by kbalazs@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Reviewed by Andreas Kling.

[Qt][WK2] netscape-dom-access.html needs new result
https://bugs.webkit.org/show_bug.cgi?id=63454

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
12:10 Changeset [90257] by kbalazs@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90254.
http://trac.webkit.org/changeset/90254
https://bugs.webkit.org/show_bug.cgi?id=63825

"committed with a totally broken changelog" (Requested by
kbalazs on #webkit).

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed.
11:55 Changeset [90256] by lforschler@apple.com
  • 5 edits in tags/Safari-534.50.2/Source

Versioning.

11:54 Changeset [90255] by lforschler@apple.com
  • 1 copy in tags/Safari-534.50.2

New tag.

11:53 Changeset [90254] by kbalazs@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
11:50 Changeset [90253] by tony@chromium.org
  • 11 edits
    2 moves in trunk/Source/WebCore

2011-07-01 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData
https://bugs.webkit.org/show_bug.cgi?id=63773

We will have a similar struct to hold CSS3 flexible box data, so
this makes way for the new class.
I will rename the member variable in RenderStyle.h in a follow up
change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleAllInOne.cpp:
  • rendering/style/StyleDeprecatedFlexibleBoxData.cpp: (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): (WebCore::StyleDeprecatedFlexibleBoxData::operator==):
  • rendering/style/StyleDeprecatedFlexibleBoxData.h: (WebCore::StyleDeprecatedFlexibleBoxData::create): (WebCore::StyleDeprecatedFlexibleBoxData::copy): (WebCore::StyleDeprecatedFlexibleBoxData::operator!=):
  • rendering/style/StyleRareNonInheritedData.h:
11:40 Changeset [90252] by hans@chromium.org
  • 6 edits in trunk

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
constants. Douglas Stockwell pointed out that these were reverse
of what the spec says.

  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
11:39 Changeset [90251] by paroga@webkit.org
  • 2 edits in trunk

2011-07-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Daniel Bates.

[CMake] Add cpu detection for MIPS
https://bugs.webkit.org/show_bug.cgi?id=63693

  • Source/CMakeLists.txt:
11:33 Changeset [90250] by leviw@chromium.org
  • 22 edits in trunk/Source/WebCore

2011-07-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch positionForPoint to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63774

Switching positionForPoint functions to new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
  • rendering/RenderReplaced.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
  • rendering/RenderText.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint):
  • rendering/svg/RenderSVGText.h:
11:30 Changeset [90249] by scherkus@chromium.org
  • 4 edits in trunk/Source

2011-07-01 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Fisher.

Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783

  • features.gypi:

2011-07-01 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Fisher.

Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783

  • WebCore.gyp/WebCore.gyp:
11:19 Changeset [90248] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Daniel Bates.

[CMake] Don't compile unused bindings
https://bugs.webkit.org/show_bug.cgi?id=63741

  • UseJSC.cmake: Added IF (ENABLE_XXX) around files.
11:19 Changeset [90247] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!

  • runtime/RegExpObject.cpp:

(JSC::regExpObjectSource):

LayoutTests:

Add tests with multiple forward slashes.

  • fast/regex/script-tests/toString.js:
  • fast/regex/toString-expected.txt:
11:14 Changeset [90246] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ReportCrash destabilizes new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63795

ReportCrash chews up too many system resources that it destablizes
tests run concurrently. This patch causes us to spin down all the
worker processes when ReportCrash is running.

Also, this patch causes the master process to tell the user we're
waiting for the crash reporter rather than having that be the worker's
job. This stops the user from getting spammed with too many "waiting
for crash reporter" messages and also cleans up some minor UI issues
with the meter.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
10:57 Changeset [90245] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-01 Tony Chang <tony@chromium.org>

Fix the chromium build. sql is a new top level directory.

  • DEPS:
10:36 Changeset [90244] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
10:29 Changeset [90243] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add failing test expectations for Chromium media tests on Windows 7 and
Vista.

  • platform/chromium/test_expectations.txt:
09:56 Changeset [90242] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Clean up skipped list
https://bugs.webkit.org/show_bug.cgi?id=61644

  • platform/qt-wk2/Skipped: Remove everything that we skip via the common wk2 list.
09:56 Changeset [90241] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-01 Adam Roben <aroben@apple.com>

Roll out r90194
http://trac.webkit.org/changeset/90194
https://bugs.webkit.org/show_bug.cgi?id=63778

Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing
assertions in WriteBarrierBase<JSC::Structure>::get

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell):
09:56 Changeset [90240] by joone.hur@collabora.co.uk
  • 7 edits
    4 adds in trunk

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add configure option to enable/disable DeviceOrientation feature.

  • configure.ac:

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.

  • GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.

  • GNUmakefile.am:
  • WebCoreSupport/DeviceMotionClientGtk.cpp: Added. (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientGtk::setController): (WebCore::DeviceMotionClientGtk::startUpdating): (WebCore::DeviceMotionClientGtk::stopUpdating): (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
  • WebCoreSupport/DeviceMotionClientGtk.h: Added.
  • WebCoreSupport/DeviceOrientationClientGtk.cpp: Added. (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientGtk::setController): (WebCore::DeviceOrientationClientGtk::startUpdating): (WebCore::DeviceOrientationClientGtk::stopUpdating): (WebCore::DeviceOrientationClientGtk::lastOrientation):
  • WebCoreSupport/DeviceOrientationClientGtk.h: Added.
  • webkit/webkitwebview.cpp: (webkit_web_view_init):
09:54 Changeset [90239] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach webkitpy about the new format of our ChangeLog template

r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
template. But webkitpy didn't know this, so the various rollout-related commands were
leaving that line in the ChangeLog.

Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
rollout are broken

Reviewed by Dan Bates.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
description and bug URL" line instead of the "Reviewed by" line as the first line of the
ChangeLog template.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
generates.

09:51 Changeset [90238] by bweinstein@apple.com
  • 4 edits in trunk

WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=63753

Reviewed by Darin Adler.

Source/WebKit2:

When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

LayoutTests:

Unskip WebKit2 tests that now pass.

  • platform/wk2/Skipped:
09:33 Changeset [90237] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757

Relanding as a Mac only patch.

This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
  • assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr):
  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble):
  • jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator):
  • jit/ThunkGenerators.h:
09:22 Changeset [90236] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip one asserting and one timing-out test on Windows

Failures are tracked by <http://webkit.org/b/63806> and <http://webkit.org/b/63807>.

  • platform/win/Skipped: Added

http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and
fast/loader/create-frame-in-DOMContentLoaded.html.

09:21 Changeset [90235] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html

The failure is tracked by <http://webkit.org/b/63809>.

  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt:
09:21 Changeset [90234] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Land new expected (failure?) results for an accessibility test on Windows

The failure is tracked by <http://webkit.org/b/63811>.

  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
09:21 Changeset [90233] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results after r90159

Fixes <http://webkit.org/b/63810> REGRESSION (r90159): fast/events/window-onerror5.html
failing

  • fast/events/window-onerror5-expected.txt: Updated for progression.
09:18 Changeset [90232] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp

Fixes the following build error in clang:

JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);


JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);


( )

fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);

~

1 error generated.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary expression evaluate first.

09:17 Changeset [90231] by kbalazs@webkit.org
  • 4 edits in trunk

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239

  • platform/qt-wk2/Skipped:

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
08:55 Changeset [90230] by aroben@apple.com
  • 2 edits in trunk/Tools

Make TestFailures stop loading old builds once we've explained all current failures

We used to do this, but some refactoring in r90165 broke this logic.

Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.

08:21 Changeset [90229] by aroben@apple.com
  • 3 edits in trunk/Tools

commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804

Reviewed by Darin Adler.

commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
commit message in order to make git-based tools, which expect the first line of the commit
message to be a summary of the change, to work better. But this reordering of the ChangeLog
entry was unpredictable and unexpected.

I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
try to move them.

  • Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"

line and try to move it down below the bug title and URL. The order of the text in the
ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
by" line in cases where the committer and author are not the same person.

  • Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
07:51 Changeset [90228] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Adam Roben.

[CSSRegions] Add build slave
https://bugs.webkit.org/show_bug.cgi?id=62372

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of Mac.
07:29 Changeset [90227] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-07-01 Jade Han <jade.han@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=61200

Add newly introduced symbols to fix the Symbian build.

  • symbian/eabi/QtWebKitu.def:
07:18 Changeset [90226] by commit-queue@webkit.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2011-07-01 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Adam Roben.

accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=63191

  • accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
  • accessibility/aria-labelledby-overrides-aria-label.html:
  • platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
06:58 Changeset [90225] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-07-01 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709

Added a test that checks whether the content in 'search' input forms with 'disabled' attribute
or 'readonly' attribute is cleared or not, when an [X] button is clicked.

  • fast/forms/search-disabled-readonly-expected.txt: Added.
  • fast/forms/search-disabled-readonly.html: Added.

2011-07-01 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709

Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
'readonly' attribute is set to the input form.

Test: fast/forms/search-disabled-readonly.html

  • html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
06:25 Changeset [90224] by mrowe@apple.com
  • 9 edits in trunk/Source/WebKit2

Unreviewed due to fixing of a broken world.

REGRESSION (r90163): WebKit2 bot is failing 100% of the tests.

r90163 bumped the version of the WKBundlePageLoaderClient passed in by WebKitTestRunner from 0 to 1.
This made it run in to the ad-hoc client version checking implemented directly in WKBundlePageSetPageLoaderClient,
resulting in no client being set. After r90162 the ad-hoc checking is not necessary as the APIClient
template takes care of the relevant version checks.

  • Shared/APIClient.h:

(WebKit::APIClient::initialize): Fix a bug I noticed along the way: don't attempt to copy anything if
the client version is newer than what we support. This matches the behavior of the ad-hoc version checking.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient): Drop the ad-hoc version checking.
(WKContextSetHistoryClient): Ditto.
(WKContextSetDownloadClient): Ditto.

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient): Ditto.

  • UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider): Ditto.

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient): Ditto.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient): Ditto.
(WKPageSetPageFindClient): Ditto.
(WKPageSetPageFormClient): Ditto.
(WKPageSetPageLoaderClient): Ditto.
(WKPageSetPagePolicyClient): Ditto.
(WKPageSetPageResourceLoadClient): Ditto.
(WKPageSetPageUIClient): Ditto.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient): Ditto.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient): Ditto.
(WKBundlePageSetEditorClient): Ditto.
(WKBundlePageSetFormClient): Ditto.
(WKBundlePageSetPageLoaderClient): Ditto.
(WKBundlePageSetResourceLoadClient): Ditto.
(WKBundlePageSetPolicyClient): Ditto.
(WKBundlePageSetUIClient): Ditto.
(WKBundlePageSetFullScreenClient): Ditto.

05:51 Changeset [90223] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-07-01 Andy Estes <aestes@apple.com>

Reviewed by Mark Rowe.

Simplify MailQuirksUserScript.js
https://bugs.webkit.org/show_bug.cgi?id=63800


MailQuirksUserScript.js is injected into WebViews in Mail.app on
Leopard to resolve an incompatibility between it and the HTML5 parser.
It did so by taking all nodes in the document between <html> and <body>
and moving them to be children of <body>. This maintains Mail.app's
assumption that document.firstChild.firstChild == document.body.


While this script fixed a specific issue with the Signature panel in
Mail.app, it caused regressions in other WebViews. Since the issue with
the Signature panel is with the empty <head> node implicitly created by
the parser, we can simplify this script by removing this implicit
<head> in the case it has no attributes and no children. This fixes the
Signature panel without affecting other WebViews that have non-trivial
<head> nodes.

  • Misc/MailQuirksUserScript.js: If <head> exists but has no attributes and no children, remove it.
04:29 Changeset [90222] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
https://bugs.webkit.org/show_bug.cgi?id=63703

  • inspector/front-end/HeapSnapshotWorker.js: (.Function.prototype.bind.return.bound): (.Function.prototype.bind):
03:38 Changeset [90221] by mjs@apple.com
  • 2 edits
    1 copy in trunk/PerformanceTests/SunSpider

2011-06-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Create sunspider-1.0 directory in preparation for fixing a bunch of bugs
https://bugs.webkit.org/show_bug.cgi?id=63782

  • make-hosted: Learn about the new directory.
  • tests/sunspider-1.0: Copied from PerformanceTests/SunSpider/tests/sunspider-0.9.1.
02:03 Changeset [90220] by tkent@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Update text expectation for Vista.

  • platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
01:51 Changeset [90219] by krit@webkit.org
  • 7 edits
    6 adds in trunk

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705

Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
necessary.

SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.

Tests: svg/animations/svglength-animation-unitType.html

svg/animations/svglengthlist-animation-5.html

  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
  • svg/SVGAnimatedLengthList.cpp: Add support for additive animations. (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
  • svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
  • svg/SVGLength.h:

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705

Tests additive animations for SVGLengthLists as well as unit animations on SVGLength.

  • svg/animations/script-tests/svglength-animation-unitType.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-5.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svglength-animation-unitType-expected.txt: Added.
  • svg/animations/svglength-animation-unitType.html: Added.
  • svg/animations/svglengthlist-animation-5-expected.txt: Added.
  • svg/animations/svglengthlist-animation-5.html: Added.
01:37 Changeset [90218] by krit@webkit.org
  • 14 edits
    4 adds in trunk

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789


Test animation of SVGAnimatedInteger. Added the test to the wk2 skip list.

  • platform/mac-wk2/Skipped:
  • svg/animations/script-tests/svginteger-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svginteger-animation-1-expected.txt: Added.
  • svg/animations/svginteger-animation-1.html: Added.

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.


SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.

Test: svg/animations/svginteger-animation-1.html

  • CMakeLists.txt: Added file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedInteger. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger. (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator): (WebCore::SVGAnimatedIntegerAnimator::constructFromString): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
  • svg/SVGAnimatedInteger.h: (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
  • svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createInteger): (WebCore::SVGAnimatedType::integer): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
00:52 Changeset [90217] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90213.
http://trac.webkit.org/changeset/90213
https://bugs.webkit.org/show_bug.cgi?id=63792

The SL bot has an errant HTTP server holding port 8080
(Requested by abarth on #webkit).

  • Scripts/run-webkit-tests:
00:50 Changeset [90216] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r90163.

  • MiniBrowser/gtk/WebBundle/WebBundleMain.c: (didCreatePage):
00:47 Changeset [90215] by commit-queue@webkit.org
  • 14 edits in trunk/Source/JavaScriptCore

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90177 and r90179.
http://trac.webkit.org/changeset/90177
http://trac.webkit.org/changeset/90179
https://bugs.webkit.org/show_bug.cgi?id=63790

It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::sqrtDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::sqrtDouble):
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
  • create_hash_table:
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp:
  • jit/ThunkGenerators.h:
00:39 Changeset [90214] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Adam Barth <abarth@webkit.org>

Exit faster when we get a keyboard interrupt. Previously, we'd open
Safari if you C NRWT after it found a failure.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
00:31 Changeset [90213] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786

We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.

If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).

  • Scripts/run-webkit-tests:
00:28 Changeset [90212] by tkent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] More test expectation update for r90089

Need to update a Windows XP expectation because the corresponding
chromium-win expectation was updated.

  • platform/chromium-win-xp/fast/forms/search-styled-expected.png: Added.
00:13 Changeset [90211] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90192.
http://trac.webkit.org/changeset/90192
https://bugs.webkit.org/show_bug.cgi?id=63788

Appears to have caused NRWT on Chromium WebKit Vista to hang
(Requested by abarth on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
00:01 Changeset [90210] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Mac][Chromium] Update test expectations for r90089

The placeholder position changes are expected because we respect
paddings for text fields.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:

06/30/11:

23:50 Changeset [90209] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-30 Eugene Klyuchnikov <eustas.bug@gmail.com>

Reviewed by Pavel Feldman.

WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

  • inspector/editor/text-editor-model-replace-tabs-expected.txt: Added.
  • inspector/editor/text-editor-model-replace-tabs.html: Added.

2011-06-30 Eugene Klyuchnikov <eustas.bug@gmail.com>

Reviewed by Pavel Feldman.

WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

Test: inspector/editor/text-editor-model-replace-tabs.html

  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings
23:36 Changeset [90208] by tkent@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Update test expectations.

  • platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium/test_expectations.txt:
23:34 Changeset [90207] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove the concept of "being wedged" from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63767

Worker processes shouldn't ever become wedged. My understanding is
that this code was originally motivated by the old threading-based
design but no longer servers any purpose.

Note: If we actually have a problem with the test harness getting
stuck, buildbot will kill us.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
23:06 Changeset [90206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-30 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

[Chromium] Remove WebBindings::makeNode.
https://bugs.webkit.org/show_bug.cgi?id=63613

Dead code elimination. No change in behaviour, so no new tests.

  • public/WebBindings.h:
  • src/WebBindings.cpp:
22:47 Changeset [90205] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

The win32 implementation of fork is sad about forking test-webkitpy.
Hopefully this will heal the bot.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
22:44 Changeset [90204] by tkent@chromium.org
  • 50 edits
    2 copies
    13 adds
    2 deletes in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectation files for r90089.

  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/searchfield-heights-expected.txt.
  • platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-value-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png: Added.
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
22:07 Changeset [90203] by tkent@chromium.org
  • 7 edits
    3 adds
    5 deletes in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium-Mac] Update test expectation files.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
21:59 Styling Form Controls edited by tkent@chromium.org
Add another example of validation bubble styling (diff)
21:54 validation-bubble-styled.png attached to Styling Form Controls by tkent@chromium.org
20:54 Changeset [90202] by tkent@chromium.org
  • 4 edits in trunk

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697

  • platform/chromium/test_expectations.txt: Some tests need new expectation images.

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697

http://trac.webkit.org/changeset/86261 added a thumb flipping code
for Mac-WebKit2. Chromium also needs it.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
20:31 Changeset [90201] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update new-run-webkit-tests now that the wk2 shared skipped list has moved
https://bugs.webkit.org/show_bug.cgi?id=63780

The shared list was moved from mac-wk2 to wk2 as part of
http://trac.webkit.org/changeset/90125.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
20:28 Changeset [90200] by bashi@chromium.org
  • 3 edits
    13 adds in trunk

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Simon Fraser.

[Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
https://bugs.webkit.org/show_bug.cgi?id=63698

Added a test which ensures text stroke is rendered with non-zero width border.

  • platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium/fast/text/text-stroke-with-border.html: Added.

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Simon Fraser.

[Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
https://bugs.webkit.org/show_bug.cgi?id=63698

Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.

Test: platform/chromium/fast/text/text-stroke-with-border.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.
20:06 Changeset [90199] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed.

Rebaselining video-currentTime-set.html for Chromium due to FFmpeg update.

  • platform/chromium-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
20:06 Changeset [90198] by darin@apple.com
  • 12 edits in trunk/Source/WebKit2

2011-06-30 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[WebKit2] Consider scale factor when allocating backing store
https://bugs.webkit.org/show_bug.cgi?id=63766

This is the first step in considering scale factor. It considers
scale factor for the primary backing store, not graphics layers,
and for CG only.

  • Platform/cg/CGUtilities.cpp: (WebKit::paintImage): Added a scale factor argument. (WebKit::paintBitmapContext): Pass 1 for scale factor.
  • Platform/cg/CGUtilities.h: Updated for above.
  • Shared/ShareableBitmap.h: Added an overload of paint that can handle a scale factor.
  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): Encode scale factor. (WebKit::UpdateInfo::decode): Decode scale factor.
  • Shared/UpdateInfo.h: Added scale factor.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::paint): Added the overload that can handle a scale factor.
  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Take a scale factor. (WebKit::BackingStore::BackingStore): Store the scale factor. (WebKit::BackingStore::incorporateUpdate): Consider the scale factor when asserting the size is correct.
  • UIProcess/BackingStore.h: Add a scale factor.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Check the scale factor too when deciding whether to reuse a backing store. (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass in the scale factor when creating a backing store.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Take the scale factor into account when painting.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Put the scale factor into the UpdateInfo. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto. (WebKit::DrawingAreaImpl::display): Take the scale factor into account when allocating the bitmap and creating a graphics context for it.
19:59 Changeset [90197] by bashi@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Darin Adler.

Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
https://bugs.webkit.org/show_bug.cgi?id=62022

Adds XcodeProjectFileChecker to check removal of "developmentRegion".

  • Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
  • Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
  • Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.
19:55 Changeset [90196] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
https://bugs.webkit.org/show_bug.cgi?id=63704

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py: Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Content of web_socket_transfer_data() is completely bogus. It's not necessary.
19:52 Changeset [90195] by tkent@chromium.org
  • 5 edits in trunk

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

  • platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

  • public/WebLocalizedString.h: Add new key.
  • src/LocalizedStrings.cpp: Call query() with the new key. (WebCore::defaultDetailsSummaryText):
19:42 Changeset [90194] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Beth Dakin.

Make GC validation clear cell structure on destruction
https://bugs.webkit.org/show_bug.cgi?id=63778

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell):
19:17 Changeset [90193] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Added write barrier that was missing from put_by_id_transition
https://bugs.webkit.org/show_bug.cgi?id=63775

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a MacroAssembler& argument so our patching functions could use it.

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.
  • dfg/DFGRepatch.cpp: (JSC::DFG::tryCachePutByID): Missing barrier!
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile): Updated for signature change.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier because its meaning isn't clear -- maybe in the future we'll have a clear way to pass all stores through a common function that guarantees a write barrier, but that's not the case right now.
19:10 Changeset [90192] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: make sharding tests needing locks less hard-coded
https://bugs.webkit.org/show_bug.cgi?id=63112

This change also changes the manager logic so that it will
drop the server lock as soon as all of the shards requiring
the lock have completed.

This change includes some minor namespace/import changes in the
unit tests, and also makes the Manager a new-style object, which
it should've been all along.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
18:55 Changeset [90191] by abarth@webkit.org
  • 11 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove threaded mode from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63771

This mode is not used and is buggy. Rather than carry around a bunch
of unused buggy code, we should rip it out and focus on the
multiprocess implementation.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
18:33 Changeset [90190] by scherkus@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed.

Temporarily disabling WTF_USE_WEBAUDIO_FFMPEG due to FFmpeg update.

  • features.gypi:
18:04 Changeset [90189] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT does not reuse registers when compiling comparisons.
https://bugs.webkit.org/show_bug.cgi?id=63565

  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::knownConstantArithOp): (JSC::DFG::NonSpeculativeJIT::basicArithOp): (JSC::DFG::NonSpeculativeJIT::compare):
17:28 Changeset [90188] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Gwang Yoon Hwang <ryumiel@company100.net>

Reviewed by Nate Chapin.

[V8] Add ENABLE(INSPECTOR) guards around v8 custom bindings.
https://bugs.webkit.org/show_bug.cgi?id=63442

No new tests needed.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
17:17 BuildingGtk edited by mrobinson@webkit.org
(diff)
17:10 Changeset [90187] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Added empty write barrier stubs in all the right places in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=63764


SunSpider thinks this might be a 0.5% speedup. Meh.

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::writeBarrier): Le stub.

(JSC::DFG::JITCodeGenerator::cachedPutById): Don't do anything special
for the case where base == scratch, since we now require base and scratch
to be not equal, for the sake of the write barrier.

  • dfg/DFGJITCodeGenerator.h: Le stub.
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): Don't reuse the base register as the scratch register, since that's incompatible with the write barrier, which needs a distinct base and scratch.


Do put the global object into a register before loading its var storage,
since it needs to be in a register for the write barrier to operate on it.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitWriteBarrier): Second verse, same as the first.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more places.

(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more places.

(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.

  • runtime/JSVariableObject.h: (JSC::JSVariableObject::offsetOfRegisters): Now used by the JIT, since we put the global object in a register and only then load its var storage by offset.

(JSC::JIT::emitWriteBarrier):

16:48 Changeset [90186] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Remove positionForCoordinates
https://bugs.webkit.org/show_bug.cgi?id=63765

Removing positionForCoordinate. We should always use positionForPoint. Also cleaning up
RenderBox's implementation of positionForPoint.

No new tests, there should be no functionality changes.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): Removing dead, or at least untested, code and adding an ASSERT_NOT_REACHED. (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): cleaning up some ugly code.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
16:46 Changeset [90185] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-30 John Bates <jbates@google.com>

Reviewed by James Robinson.

Chromium bug: Compositing on a lost context causes latch deadlocks.
The cause of deadlock was that a setLatch command is added to the lost
compositor GL context, and a waitLatch would never complete on a child context.
This change checks whether the compositor context is in error state before
doing the compositing.
https://bugs.webkit.org/show_bug.cgi?id=63681

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
16:40 Changeset [90184] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Clean up output from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63759

Printing messages from the child process looks super ugly because of
the way the pretty-printer works. Printing a blank line first is a
hack, but it makes things at least partially sane.

Also, handle the case where calling sample throws an exception.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
16:39 Changeset [90183] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.4.2

Tagging the 1.4.2 release of WebKitGTK+

16:37 Changeset [90182] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the library and libtool version in preparation for the 1.4.2 release.

  • configure.ac: Update versions.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the news in preparation for the 1.4.2 release.

  • NEWS: Update news.
16:30 Changeset [90181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

This test required a security origin with granted permission to request local resources.
By default, only local files can load local resources. So modified baseUrl to be a local file.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::renderGeometry):
16:24 Changeset [90180] by zmo@google.com
  • 11 edits in trunk

2011-06-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Improve WebGL object lifetime management in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=63635

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html: Fix a bug so getFramebufferAtatchmentParameter generates an error if nothing is attached and something other than TYPE is queried.
  • fast/canvas/webgl/object-deletion-behaviour-expected.txt:
  • fast/canvas/webgl/object-deletion-behaviour.html: Ditto.
  • fast/canvas/webgl/program-test.html: Fix the test so the order of shaders returned by getAttachedShaders doesn't matter.

2011-06-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Improve WebGL object lifetime management in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=63635

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Use cached objects instead of querying the underlying GL. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto. (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): Multiple loop because objects might be removed from the table within an iteration.
  • html/canvas/WebGLRenderingContext.h:
16:20 Changeset [90179] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix ARMv6 build

16:09 Changeset [90178] by diegohcg@webkit.org
  • 9 edits in trunk

2011-06-27 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
https://bugs.webkit.org/show_bug.cgi?id=63489

Unskipped:

loader/navigation-while-deferring-loads.html

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setDefersLoading): (DumpRenderTreeSupportQt::goBack):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
16:08 Changeset [90177] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757

This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
  • assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr):
  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble):
  • jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator):
  • jit/ThunkGenerators.h:
16:07 Changeset [90176] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests should stop when I C it
https://bugs.webkit.org/show_bug.cgi?id=63763

It still doesn't stop fast enough, but at least with this patch it
doesn't run more tests.

Also, I tweaked the UI that happens when there's a keyboard interrupt
to not be amazingly ugly. There's still a garbage "Te" left on the
console, but that's a problem for another day.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
16:05 Changeset [90175] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-06-30 Alan Stearns <stearns@adobe.com>

Reviewed by Tony Chang.

Modify Skipped files so that future css exclusions LayoutTests are
skipped by default.

[CSSExclusions] Add test and skip entries
https://bugs.webkit.org/show_bug.cgi?id=63751

  • fast/exclusions/triangle-exclusion.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
15:39 Changeset [90174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
https://bugs.webkit.org/show_bug.cgi?id=63747

Removed reference to ElementShadowPseudoId.h that no longer exists.

  • WebCore.pro:
15:29 Changeset [90173] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
its complete constructor can never be called and clang has stopped emitting it altogether.

  • WebCore.exp.in:
15:28 Changeset [90172] by aroben@apple.com
  • 3 edits in trunk/Tools

Make TestFailures never treat a too-many-failures build as a last-passing build for a test

Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
the last passing build for a test, when in fact the test wasn't run due to too many failures
causing old-run-webkit-tests to exit early

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
failures in this build, assume that all the tests failed in the last build would have failed
in this build, too, had they been run. Introduced some new local variables to reduce typing,
and used them throughout.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
correctly remember whether old-run-webkit-tests exited early due to too many failures for
builds older than r89610. Also removed an unused parameter while I was at it.

15:28 Changeset [90171] by cevans@google.com
  • 4 edits
    4 copies in branches/chromium/782

Merge 90068
BUG=78841
Review URL: http://codereview.chromium.org/7292017

15:17 Changeset [90170] by cevans@google.com
  • 7 edits
    2 copies in branches/chromium/782

Merge 89705
BUG=86609

15:15 Changeset [90169] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintingRootRect and RenderObject repaint methods to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63746

Switching paintingRootRect and RenderObject repaint functions over to the
new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::paint): (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintDuringLayoutIfMoved):
  • rendering/RenderObject.h:
15:10 Changeset [90168] by mrowe@apple.com
  • 5 edits in trunk/Source/WebKit2

Fix the Windows build.

  • UIProcess/API/C/win/WKTextChecker.h:
  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebTextCheckerClient.h:
  • UIProcess/win/WebUndoClient.h:
15:00 Changeset [90167] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
14:51 Changeset [90166] by jchaffraix@webkit.org
  • 5 edits
    3 adds in trunk

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Update SVG position values on SVG DOM updates
https://bugs.webkit.org/show_bug.cgi?id=62439

  • svg/custom/crash-textPath-attributes-expected.txt: Added.
  • svg/custom/crash-textPath-attributes.html: Added.
  • svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Update SVG position values on SVG DOM updates
https://bugs.webkit.org/show_bug.cgi?id=62439

Test: svg/custom/crash-textPath-attributes.html

  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs to update its positioning information.
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear our cached layout attributes every time we invalidate them. This avoids keeping stale attribute that have a backpointer to a RenderObject.
14:49 Changeset [90165] by aroben@apple.com
  • 3 edits in trunk/Tools

Make TestFaiulres only load old-results directories as needed

Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
calls through to _getBuildNamesFromResultsDirectory.
(Builder.prototype.getOldBuildNames): Added. Just calls through to
_getBuildNamesFromResultsDirectory.
(Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
takes the directory URL as an argument and only fetches that single URL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
(LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
changes are just indentation.) Now takes a callback to call when we've finished analyzing
all builds in buildNames so that we can try to fetch more build names if needed.

14:46 Changeset [90164] by commit-queue@webkit.org
  • 14 edits
    16 adds in trunk

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Adds Chromium-specific test expectations that show alerts in unload
handlers being replaced by console messages.

  • fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
  • fast/loader/page-dismissal-modal-dialogs.html: Added.
  • fast/loader/resources/page-dismissal-modal-dialogs-iframe.html: Added.
  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt: Added.
  • platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
  • platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt: Added.
  • platform/chromium/fast/events/onunload-expected.txt: Added.
  • platform/chromium/fast/events/onunload-not-on-body-expected.txt: Added.
  • platform/chromium/fast/events/onunload-window-property-expected.txt: Added.
  • platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt: Added.
  • platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
  • platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
  • platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt: Added.

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Allows clients to specify whether to show alerts during unload handlers.
When checking for whether a page dismissal event is being dispatched,
it's important to check all frames on the page (otherwise it becomes a
loophole easily exploited).

Test: fast/loader/page-dismissal-modal-dialogs.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::fireBeforeUnloadEvent):
  • loader/FrameLoader.h: (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestImage):
  • page/Chrome.cpp: (WebCore::canRunModalIfDuringPageDismissal): (WebCore::Chrome::canRunModalNow): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::showModalDialog):

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Implementation of the new shouldRunModalDialogDuringPageDismissal() API
to block alerts during unload handlers. Logs such events to the console
and updates histograms.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
  • src/ChromeClientImpl.h:
14:46 Changeset [90163] by mrowe@apple.com
  • 11 edits in trunk/Tools

Update MiniBrowser and WebKitTestRunner to use the client version constants.

Reviewed by Anders Carlsson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowLoaderClientInit):
(browserWindowUIClientInit):

  • MiniBrowser/gtk/WebBundle/WebBundleMain.c:

(didCreatePage):
(WKBundleInitialize):

  • MiniBrowser/gtk/main.c:

(createWKContextWithInjectedBundle):

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

14:46 Changeset [90162] by mrowe@apple.com
  • 7 edits
    2 copies in trunk/Source/WebKit2

Teach APIClient to correctly handle multiple versions of a client interface.

Reviewed by Anders Carlsson.

If a client struct is not the current version then we can't copy it via assignment
since that will read past the end of the smaller, older struct. To deal with this
APIClient needs to be aware of the sizes of the older client version structs so that
it can copy only the appropriate amount of the struct.

  • Shared/APIClient.h:

(WebKit::APIClient::initialize): Assign through to our client if the new in client is the
latest version. If an older client version was passed then we zero out our client and memcpy
the appropriate number of bytes in to it. This ensures that any new members in the client
are initialized to 0.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h: Client interfaces are the size of their struct unless otherwise stated.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Bump the version and add comments indicating

which components belong to which versions.

14:46 Changeset [90161] by mrowe@apple.com
  • 25 edits in trunk/Source/WebKit2

Make the APIClient template aware of the latest client interface version number.

Reviewed by Anders Carlsson.

This will be used in an upcoming patch.

  • Shared/APIClient.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebCookieManagerProxyClient.h:
  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebDownloadClient.h:
  • UIProcess/WebFindClient.h:
  • UIProcess/WebFormClient.h:
  • UIProcess/WebGeolocationProvider.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebIconDatabaseClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebResourceLoadClient.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
14:46 Changeset [90160] by mrowe@apple.com
  • 10 edits in trunk/Source/WebKit2

WebKit2 client interfaces should have constant declaring latest version.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKCookieManager.h:
  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/API/C/WKIconDatabase.h:
  • UIProcess/API/C/WKPage.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
14:41 Changeset [90159] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-06-30 Juan C. Montemayor <jmont@apple.com>

Reviewed by Geoffrey Garen.

Web Inspector fails to display source for eval with syntax error
https://bugs.webkit.org/show_bug.cgi?id=63583

Added new LayoutTest to check that the correct line number is added to a
syntax error inside an eval statement.

  • fast/js/eval-contained-syntax-error-expected.txt: Added.
  • fast/js/eval-contained-syntax-error.html: Added.
  • fast/js/script-tests/eval-contained-syntax-error.js: Added.
  • platform/chromium/fast/js/eval-contained-syntax-error-expected.txt: Added.

2011-06-30 Juan C. Montemayor <jmont@apple.com>

Reviewed by Geoffrey Garen.

Web Inspector fails to display source for eval with syntax error
https://bugs.webkit.org/show_bug.cgi?id=63583

Web Inspector now displays a link to an eval statement that contains
a syntax error.

  • parser/Parser.h: (JSC::isEvalNode): (JSC::EvalNode): (JSC::Parser::parse):
14:37 Changeset [90158] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium test update after r90148.

  • platform/chromium/test_expectations.txt:
14:30 Changeset [90157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

X86Assembler does not encode byte registers in 64-bit mode correctly.
https://bugs.webkit.org/show_bug.cgi?id=63665

  • assembler/X86Assembler.h: (JSC::X86Assembler::testb_rr): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):
13:50 Changeset [90156] by jchaffraix@webkit.org
  • 6 edits
    4 adds in trunk

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076

  • svg/custom/crash-text-in-textpath-expected.txt: Added.
  • svg/custom/crash-text-in-textpath.svg: Added. Original crashing test case.
  • svg/custom/text-node-in-text-invalidated-expected.txt: Added.
  • svg/custom/text-node-in-text-invalidated.svg: Added. This test case was not crashing. However it is good to make sure this change did not regress that.

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076

Tests: svg/custom/crash-text-in-textpath.svg

svg/custom/text-node-in-text-invalidated.svg

The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
doing our layout, we would not update the attributes on our SVGRenderInlineText as
we would not lay it out.

This was caused by childrenChanged being overridden on SVGTextPositioningElement but
not on SVGTextPathElement.

As both classes shared the same mother class, it made sense to move the logic here.
There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
are the only classes deriving from SVGTextContentElement.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
  • svg/SVGTextPositioningElement.h:
13:22 Changeset [90155] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::enclosingScrollableArea):

13:17 Changeset [90154] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for !ENABLE(DATABASE) after r84789.

  • bindings/js/JSDOMBinding.cpp:
13:03 Changeset [90153] by aroben@apple.com
  • 5 edits in trunk/Tools

Identify revisions that modified failing tests on TestFailures page

Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
a failure by looking at commit logs

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
revisions list, too.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac): Initialize our memory cache.
(Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
then parses out the revision number, Trac's idea of the commit title, and the files modified
by the commit. (To get the modified files, we rely on the commit message including a
prepare-ChangeLog-style file list.)
(Trac.prototype.logURL): Added a new formatAsRSS parameter.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(removePathExtension): Added. Returns a new string with the last dot and everything after it
removed.
(sorted): Added sortFunction parameter.
(Node.prototype.removeAllChildren): Added. Does what it says.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
(ViewController.prototype._domForRegressionRange): Changed argument order to match
_domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
which revisions modified the failing tests and displays the suspect revisions in a list.

12:40 Changeset [90152] by andersca@apple.com
  • 17 edits in trunk/Source

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

Add an enclosingScrollableArea stub.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::enclosingScrollableArea):
  • src/WebScrollbarImpl.h:

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

  • WebScrollBar.h: (WebScrollBar::enclosingScrollableArea): Always return 0, WebScrollbar has no concept of an enclosing scrollable area.

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

Add a way to get the enclosing scrollable area for a given scrollable area.
Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.

  • page/FrameView.cpp: (WebCore::FrameView::enclosingScrollableArea): Return 0 for now.
  • page/FrameView.h: Add FrameView::enclosingScrollableArea.
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta): Return whether the area is pinned in the direction of the scroll delta.
  • platform/ScrollableArea.h: Add new member functions.
  • platform/chromium/FramelessScrollView.cpp: (WebCore::FramelessScrollView::enclosingScrollableArea):
  • platform/chromium/FramelessScrollView.h: Add stub.
  • platform/win/PopupMenuWin.h: (WebCore::PopupMenuWin::enclosingScrollableArea): Always return 0.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingScrollableLayer): Add helper function.

(WebCore::RenderLayer::scrollByRecursively):
Use the new enclosingScrollableLayer helper function.

(WebCore::RenderLayer::enclosingScrollableArea):
Return the enclosing scrollable area.

  • rendering/RenderLayer.h: Add new member function.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::enclosingScrollableArea): Return 0 for now.


  • rendering/RenderListBox.h: Add new member function.
12:34 Changeset [90151] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=63743

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
12:32 Changeset [90150] by mrobinson@webkit.org
  • 7 edits
    4 adds in releases/WebKitGTK/webkit-1.4

Merging r90148

12:31 Changeset [90149] by mrobinson@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r90041

12:31 Changeset [90148] by mrobinson@webkit.org
  • 7 edits
    4 adds in trunk

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Added a test which verifies that WebKit does not crash when InvalidateRect
is called with a null instance.

  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Added.
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Added.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Test: plugins/invalidate-rect-with-null-npp-argument.html

  • plugins/npapi.cpp: (NPN_InvalidateRect): Guard against null instances here.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_InvalidateRect): Guard against null instances here.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Added a TestNetscapePlugin test which verifies that WebKit properly
handles situations where InvalidateRect is called with a null instance.

  • DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added. (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument): (CallInvalidateRectWithNullNPPArgument::NPP_New):
  • GNUmakefile.am: Add the new file to sources list.
12:26 Changeset [90147] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r89265

12:25 Changeset [90146] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r89319

12:18 Changeset [90145] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84022

12:16 Changeset [90144] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63671

Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::availableLogicalWidthForLine): (WebCore::RenderBlock::availableLogicalWidth):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::startOffsetForLine):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::availableLogicalHeight): (WebCore::RenderBox::availableLogicalHeightUsing):
  • rendering/RenderBox.h: (WebCore::RenderBox::availableLogicalWidth): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::availableHeight):
12:16 Changeset [90143] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r83107

12:15 Changeset [90142] by mrobinson@webkit.org
  • 15 edits in releases/WebKitGTK/webkit-1.4/Source

Merging r81904

12:07 Changeset [90141] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Adam Barth <abarth@webkit.org>

Remove useless ASSERT that breaks the build.

  • dom/StyledElement.cpp: (WebCore::parseColorStringWithCrazyLegacyRules):
11:56 Changeset [90140] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove redundant tests in TestFailuresTest
https://bugs.webkit.org/show_bug.cgi?id=63742

These tests are all already covered by TestFailuresTest.test_loads.
I also added the missing "T" from TestFailuresest. :)

  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
11:41 Changeset [90139] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-30 Tab Atkins <jackalmage@gmail.com>

Reviewed by Adam Barth.

Fix legacy color attribute parsing to match HTML spec
https://bugs.webkit.org/show_bug.cgi?id=63029

Tests <body bgcolor> parsing.

  • fast/dom/attribute-legacy-colors-expected.txt: Added.
  • fast/dom/attribute-legacy-colors.html: Added.
  • fast/dom/script-tests/attribute-legacy-colors.js: Added.

2011-06-30 Tab Atkins <jackalmage@gmail.com>

Reviewed by Adam Barth.

Fix legacy color attribute parsing to match HTML spec
https://bugs.webkit.org/show_bug.cgi?id=63029

Relevant spec link: http://www.whatwg.org/specs/web-apps/current-work/complete/common-microsyntaxes.html#rules-for-parsing-a-legacy-color-value
Fix legacy color attribute parsing (<body bgcolor>, <font color>, etc.) to match the HTML spec and more closely match other browsers.

Test: fast/dom/attribute-legacy-colors.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
11:37 Changeset [90138] by abarth@webkit.org
  • 12 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist
https://bugs.webkit.org/show_bug.cgi?id=63494

This patch does two things:

1) Refactor diff_image to return the image diff instead of writing the
diff to a file. This fixes a bunch of hacks and disentangles a bunch
of code.

2) When there's a checksum mismatch but not image diff, we no longer
report an IMAGE failure to results.html. That fixes the bug in
question because results.html won't try to link to a non-existent image
diff.

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
11:32 Changeset [90137] by hans@chromium.org
  • 9 edits in trunk

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

Migration of data from SQLite to LevelDB must be done before the
m_backingStore map is checked for an open LevelDB, because if a
previous layout test has used LevelDB, it will be in the
m_backingStore map.

Covered by existing layout tests.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

WebIDBFactory should decide what DefaultBackingStore means.
Also fix handling of layout test and incognito mode properly.

  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

The TestShell must always provide a temporary folder for LevelDB,
not just when the backing store type is overridden.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h:
11:22 Changeset [90136] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-06-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce "filter" icons for timeline panel and elements sidebar.
https://bugs.webkit.org/show_bug.cgi?id=63731

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/Images/paneFilterButtons.png: Added.
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css: (.pane > .title > select): (.pane > .title > select.select-settings): (.pane > .title > select.select-filter): (.timeline-filter-status-bar-item .glyph):
11:16 Changeset [90135] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Support for deleteIndex with LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=63539

Covered by storage/indexeddb/mozilla/remove-index.html.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::deleteIndex):
10:57 Changeset [90134] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <japhet@chromium.org>

Unreviewed, remove passing tests from chromium test expectations.

  • platform/chromium/test_expectations.txt:
10:38 Changeset [90133] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Reinstate WKSecurityOriginGetHost and WKSecurityOriginGetProtocol as wrappers around the correctly-named functions.

Reviewed by Anders Carlsson.

They're needed for ABI compatibility.

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginGetHost):
(WKSecurityOriginGetProtocol):

10:24 Changeset [90132] by abarth@webkit.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Expanding lines "below" does not remove purple context line
https://bugs.webkit.org/show_bug.cgi?id=63695

Honestly, this is the last bug in the review tool that bothers me.

  • PrettyPatch/PrettyPatch.rb:
    • Jump straight to version 42, because, well, you know.
  • code-review.js:
    • In addition to removing the context bar when we expand all, we now remove it when we expand below (but not when we expand above).
10:04 Changeset [90131] by mrowe@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE shouldn't try to use internal SDKs. It doesn't need them!

Rubber-stamped by Dan Bernstein.

  • Configurations/Base.xcconfig:
10:00 Changeset [90130] by inferno@chromium.org
  • 4 edits
    4 adds in trunk

2011-06-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650

Convert a few nodes to RefPtrs and add commonRoot verification checks
for Range::processContents.

Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html

fast/dom/Range/range-extract-contents-event-fire-crash2.html

  • dom/Range.cpp: (WebCore::childOfCommonRootBeforeOffset): (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets): (WebCore::Range::processAncestorsAndTheirSiblings):

2011-06-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650

  • fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash.html: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash2.html: Added.
  • fast/dom/Range/range-extractContents.html: remove the appending of fragment in this crasher test since we now refptr the nodes and leftContents will be visible. This crasher test does not need to show the extractContents fragment.
09:53 Changeset [90129] by mitz@apple.com
  • 7 edits in trunk/Source

Add +[WebView _allowsRoundingHacks]
https://bugs.webkit.org/show_bug.cgi?id=63734

Reviewed by Adele Peterson.

Source/WebCore:

  • WebCore.exp.in: Export TextRun::allowsRoundingHacks().
  • platform/graphics/TextRun.cpp:

(WebCore::TextRun::allowsRoundingHacks): Added this accessor.

  • platform/graphics/TextRun.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _allowsRoundingHacks]): Added this accessor.

  • WebView/WebViewPrivate.h:
09:52 Changeset [90128] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium test expectations update after r90101.

  • platform/chromium/test_expectations.txt:
09:48 Changeset [90127] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Don't redefine the keyboard codes
https://bugs.webkit.org/show_bug.cgi?id=63726

Only define the codes when undefined.
r64957 fixed this problem for COMPILER(MINGW) but not for OS(WINCE).

  • platform/WindowsKeyboardCodes.h:
09:39 Changeset [90126] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: hide "Enabled background events collection" option in context menu until the setting is persisted
https://bugs.webkit.org/show_bug.cgi?id=63708

The option has no much sense if it is not preserved between browser restarts.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
09:28 Changeset [90125] by ossy@webkit.org
  • 4 edits
    1 copy
    1 add in trunk

Tools: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
https://bugs.webkit.org/show_bug.cgi?id=61785

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-30
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:

LayoutTests: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Common Skipped list copied from LayoutTests/platform/mac-wk2/Skipped.
https://bugs.webkit.org/show_bug.cgi?id=61785

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-30
Reviewed by Csaba Osztrogonác.

  • platform/mac-wk2/Skipped:
  • platform/wk2/Skipped: Copied from LayoutTests/platform/mac-wk2/Skipped.
09:05 Changeset [90124] by paroga@webkit.org
  • 26 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Remove dependnecy on IDL generation for disabled features in JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=63718

Move the #if ENABLE() line directly after #include "config.h".
This enables us to compile all files even when we don't generate the IDL output.

  • bindings/js/IDBBindingUtilities.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDeviceMotionEventCustom.cpp:
  • bindings/js/JSDeviceOrientationEventCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • bindings/js/JSSQLTransactionSyncCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSTouchCustom.cpp:
  • bindings/js/JSTouchListCustom.cpp:
  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptGCEvent.cpp:
  • bindings/js/ScriptProfile.cpp:
  • bindings/js/WorkerScriptDebugServer.cpp:
08:30 Changeset [90123] by aroben@apple.com
  • 2 edits in trunk/Tools

Use a colon to separate test names from failure info on TestFailures

This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
failure info itself includes parentheses.

Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
double parentheses

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
info in parentheses.

08:30 Changeset [90122] by aroben@apple.com
  • 2 edits in trunk/Tools

Robustify PersistentCache against cached data that contains the string ': '

Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
passing a bad string to JSON.parse

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:

(PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
using indexOf and substring. (String.prototype.split always splits on all instances of the
separator.)

08:30 Changeset [90121] by aroben@apple.com
  • 4 edits in trunk/Tools

Include the crashing symbol in crash logs links on TestFailures

Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
the crashing symbol (like links in results.html do)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
it now returns more than just the test names. Specifically, it now looks for crash log links
and extracts the crashing symbol name from them. Updated callers of parseResultTable to
match its new behavior. Changed to store the crashing symbol along with the failure type in
the data we pass to the callback for tests which crashed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(code): Make <code> elements a little smaller because their contents can be quite long.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
<code> element in the link, if there is a crashing symbol.

08:30 Changeset [90120] by aroben@apple.com
  • 5 edits in trunk/Tools

Use objects instead of strings to represent a test result in TestFailures code

This will eventually allow us to store more than just the type of failure for each test.
(E.g., we can store the name of the crashing symbol for tests which crashed.)

Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
include the crashing symbol (like links in results.html do)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
instead of just a failureType string.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
testResult-like object for passing tests.
(FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
so we can throw away cached data that's in an old format. Store a testResult object for each
test instead of just its failure type.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailedTest):
(ViewController.prototype._domForFailureDiagnosis):
Changed to expect testResult objects instead of failureType strings.

07:45 Changeset [90119] by apavlov@chromium.org
  • 5 edits in trunk/Source

2011-06-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Autofill suggestions appear in upper left corner after input change
https://bugs.webkit.org/show_bug.cgi?id=63702

This change fixes a few popup layout issues, some of which have existed for quite a while:

  • the absence of the ChromeClientImpl::screenToWindow() implementation (the method used to always return (0, 0));
  • the confusion of window and screen coordinates passed into the autofill popup client's setWindowRect() method;
  • the use of the current frameRect() width as the target element's width (which was wrong when refreshing a popup resized during the initial layout (e.g. made wider than the target element)).

No new tests, as this is a change to platform-specific widget code. The test case is provided in the bug description.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndGetRTLOffset): Use original target element width, not frameRect().width(), since the latter gets updated if the popup is not the same width as the target element. (WebCore::PopupContainer::refresh): Restore only the popup bounds rather than its original rectangle, since it sometimes breaks the invalidation region and layout.

2011-06-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Autofill suggestions appear in upper left corner after input change
https://bugs.webkit.org/show_bug.cgi?id=63702

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::screenToWindow): Implemented.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::refreshAutoFillPopup): Pass screen (not window) coordinates into setWindowRect().
07:30 Changeset [90118] by aroben@apple.com
  • 3 edits in trunk/Tools

Show full commit logs when visiting Trac from TestFailures page

Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
should show full commit logs

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
verbose=on to the log URL to tell Trac to show full commit logs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.

07:11 Changeset [90117] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90102.
http://trac.webkit.org/changeset/90102
https://bugs.webkit.org/show_bug.cgi?id=63714

Lots of tests asserting beneath
SVGSMILElement::findInstanceTime (Requested by aroben on
#webkit).

  • wtf/StdLibExtras.h: (WTF::binarySearch):

2011-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90102.
http://trac.webkit.org/changeset/90102
https://bugs.webkit.org/show_bug.cgi?id=63714

Lots of tests asserting beneath
SVGSMILElement::findInstanceTime (Requested by aroben on
#webkit).

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::findInstanceTime):
07:03 Changeset [90116] by caseq@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebCore

2011-06-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove ExtensionAPISchema.json
https://bugs.webkit.org/show_bug.cgi?id=63687

  • inspector/front-end/ExtensionAPISchema.json: Removed.
07:00 Changeset [90115] by aroben@apple.com
  • 3 edits in trunk/Tools

Add a link to file a bug about TestFailures to the TestFailures page

Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
about TestFailures itself

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(aside): Added some styles for the new link. It is positioned in the upper-right and
hopefully not to glaringly obvious.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.loaded): Set up our main content element and auxiliary UI.

(ViewController.prototype._displayBuilder):
(ViewController.prototype._displayTesters):
Modify the main content element instead of the entire body, as there are other things in the
body that we want to preserve.

(ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
that contains a link to file a bug about the TestFailures page.

07:00 Changeset [90114] by aroben@apple.com
  • 3 edits in trunk/Tools

Ignore callbacks that correspond to old navigations of the TestFailures page

Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
navigations

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
callback returns false, stop fetching more data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Initialize new _navigationID member. This member is used to assign each
navigation by the user a unique ID.
(ViewController.prototype.parseHash): Increment the navigation ID.

(ViewController.prototype._displayBuilder):
(ViewController.prototype._displayTesters):
At the start of these functions, record the current navigation ID. Bail out from callbacks
if the navigation ID has changed, indicating that the user has navigated elsewhere.

06:59 Changeset [90113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] QML Webview causes performance drops
https://bugs.webkit.org/show_bug.cgi?id=57554

Remove tiledBackingStoreEnabled from QML WebView.

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage):
06:43 Changeset [90112] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for chromium.

  • inspector/CodeGeneratorInspector.pm:
06:38 Changeset [90111] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for mac.

  • inspector/CodeGeneratorInspector.pm:
06:22 Changeset [90110] by loislo@chromium.org
  • 6 edits in trunk

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol: error object needs some improvement.
https://bugs.webkit.org/show_bug.cgi?id=63707

Current implementation is not useful in the code.
We need to have toString implementation with nice formatting
I'd like to use error.message property as the main place for the error's text.

  • inspector/elements/set-attribute.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol: error object needs some improvement.
https://bugs.webkit.org/show_bug.cgi?id=63707

Current implementation is not useful in the code.
We need to have toString implementation with nice formatting
I'd like to use error.message property as the main place for the error's text.

  • inspector/CodeGeneratorInspector.pm:
06:02 Changeset [90109] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add back/forward menu to MiniBrowser toolbar
https://bugs.webkit.org/show_bug.cgi?id=63445

  • MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Use a GtkMenuToolButton for navigation widgets. (browserWindowConstructed): Get the page BackForwardList. (browserWindowHistoryItemActivated): Go to activated history item. (browserWindowHistoryItemSelected): Show the url of currently selected history item in the statusbar. (createGtkActionFromBackForwardItem): Create a GtkAction from a WKBackForwardListItemRef. (browserWindowCreateMenuItemFromBackForwardItem): Create a GtkMenuItem from a WKBackForwardListItemRef. (browserWindowCreateBackForwardMenu): Create a GtkMenu with the given history items. (browserWindowUpdateNavigationActions): Update navigation widgets sensitivity and history menus. (didChangeBackForwardList): Call browserWindowUpdateNavigationActions(). (browserWindowLoaderClientInit): Add didChangeBackForwardList callback.
05:55 Changeset [90108] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=63660
This enables unit-tests step on Windows and MacOS SnowLeopard.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
05:10 Changeset [90107] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Support annotations for arrays in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63690

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
04:41 Changeset [90106] by paroga@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r88663, r89187, r89220, r89431 and r89661.

  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
04:19 Changeset [90105] by loki@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Fixed several style and typo issues after r90091.
https://bugs.webkit.org/show_bug.cgi?id=63692

Rename yStart to extremaStartY during computing extremas

  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyGeneric):
  • platform/graphics/filters/FEMorphology.h:
04:08 Changeset [90104] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip a failing media test on GTK because of
https://bugs.webkit.org/show_bug.cgi?id=63699

  • platform/gtk/Skipped: skip media/media-blocked-by-willsendrequest.html
04:00 Changeset [90103] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Resolve a conflict.

  • platform/chromium/test_expectations.txt:
03:56 Changeset [90102] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-30 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h: (WTF::binarySearch):

2011-06-30 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp: (WebCore::extractTimeFromVector): (WebCore::SVGSMILElement::findInstanceTime):
03:40 Changeset [90101] by commit-queue@webkit.org
  • 31 edits
    2 adds in trunk

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.
input-file-label.html is a test that checks a label of the file chooser
with/without 'multiple' attribute. input-file-label.html will fail in Chromium
until a planned Chromium patch is landed. input-file-re-render.html will
also fail in Chromium, gtk and MacLeopard until we update the expected images
for the test.

  • fast/forms/input-file-label-expected.txt: Added.
  • fast/forms/input-file-label.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-file-re-render-expected.png:
  • platform/mac/fast/forms/input-file-re-render-expected.txt:

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • English.lproj/Localizable.strings:
  • html/FileInputType.cpp: (WebCore::UploadButtonElement::createForMultiple): Constructs a multiple file chooser button. (WebCore::FileInputType::createShadowSubtree): Constructs a single/multiple file chooser button depending on 'multiple' attribute. (WebCore::FileInputType::multipleAttributeChanged): Updates the label of the file chooser button.
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Updates the shadow tree of the file chooser button when 'multiple' attribute is set or unset.
  • html/InputType.cpp: (WebCore::InputType::multipleAttributeChanged): Virtual method to be overridden by FileInputType.
  • html/InputType.h:
  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::fileButtonChooseFileLabel): Updated the description for "Choose File". (WebCore::DefaultLocalizationStrategy::fileButtonChooseMultipleFilesLabel): Returns a string "Choose Files".
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Wrapper method for getting the "Choose Files" label.
  • platform/LocalizedStrings.h:
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • DEPS:
  • public/WebLocalizedString.h: Depends on chromium_rev>=91051.
  • src/LocalizedStrings.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::fileButtonChooseFileLabel): Updated the description for "Choose File". (WebPlatformStrategies::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • WebCoreSupport/WebPlatformStrategies.h:

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::fileButtonChooseFileLabel): Updated the description for "Choose File". (PlatformStrategiesWinCE::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • WebCoreSupport/PlatformStrategiesWinCE.h:
02:31 Changeset [90100] by yutak@chromium.org
  • 32 edits
    32 deletes in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Don't use script-tests for WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=63691

Move content of script-tests/XXX.js into XXX.html.

No changes were made to script code. Hence, these tests are not using
window.jsTestAsync and finishJSTest() for now. I will fix this later.

  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/script-tests/TEMPLATE.html: Removed.
  • http/tests/websocket/tests/script-tests/alert-in-event-handler.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-handshake-crash.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
  • http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
  • http/tests/websocket/tests/script-tests/cross-origin.js: Removed.
  • http/tests/websocket/tests/script-tests/error-detect.js: Removed.
  • http/tests/websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
  • http/tests/websocket/tests/script-tests/frame-length-skip.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-error.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
  • http/tests/websocket/tests/script-tests/long-invalid-header.js: Removed.
  • http/tests/websocket/tests/script-tests/null-character.js: Removed.
  • http/tests/websocket/tests/script-tests/send-throw.js: Removed.
  • http/tests/websocket/tests/script-tests/send.js: Removed.
  • http/tests/websocket/tests/script-tests/simple.js: Removed.
  • http/tests/websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
  • http/tests/websocket/tests/script-tests/sub-protocol.js: Removed.
  • http/tests/websocket/tests/script-tests/unicode.js: Removed.
  • http/tests/websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
  • http/tests/websocket/tests/script-tests/url-parsing.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-credential.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-empty-query.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-query.js: Removed.
  • http/tests/websocket/tests/script-tests/websocket-event-target.js: Removed.
  • http/tests/websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
02:22 Changeset [90099] by yutak@chromium.org
  • 18 edits in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Fix style issues of pywebsocket handlers
https://bugs.webkit.org/show_bug.cgi?id=63689

Fix minor style errors such as wrong indentation or wrong number of blank lines.

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/close-on-unload_wsh.py:
  • http/tests/websocket/tests/echo-challenge_wsh.py:
  • http/tests/websocket/tests/echo-cookie_wsh.py:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/frame-length-skip_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Use sequence repetition pattern instead of a loop.
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hanging-handshake_wsh.py:
  • http/tests/websocket/tests/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/send2_wsh.py:
  • http/tests/websocket/tests/unknown-frame-type_wsh.py:
  • http/tests/websocket/tests/workers/resources/echo-challenge_wsh.py:
02:14 Changeset [90098] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-30 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
https://bugs.webkit.org/show_bug.cgi?id=63672

Replaced isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&).
Also added a safe toTextFormControl to HTMLFormControlElement.h.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Calls enclosingTextFormControl instead of manually checking the tag name of shadowAncestorNode.
  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Rewritten using enclosingTextFormControl and toTextFormControl. (WebCore::Editor::cut): Calls enclosingTextFormControl instead of isNodeInTextFormControl. (WebCore::Editor::copy): Ditto. (WebCore::Editor::setBaseWritingDirection): Calls toTextFormControl instead of manually checking tag name.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::isInPasswordField): Calls enclosingTextFormControl.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
  • editing/htmlediting.cpp: (WebCore::enclosingTextFormControl): Added.
  • editing/htmlediting.h:
  • html/HTMLFormControlElement.h: (WebCore::toTextFormControl): Added.
  • page/DragController.cpp: (WebCore::DragController::startDrag): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
02:08 Changeset [90097] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Mac-wk2] Update expectation files for r90089.
https://bugs.webkit.org/show_bug.cgi?id=61415

  • platform/mac-wk2/fast/forms/textfield-overflow-expected.txt:
01:18 Changeset [90096] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: source code is not highlighted after drawer height animations.
https://bugs.webkit.org/show_bug.cgi?id=62860

  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight):
01:00 Changeset [90095] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Implement the rest of WTR::PlatformWebView
https://bugs.webkit.org/show_bug.cgi?id=63630

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame):
00:43 Changeset [90094] by morrita@google.com
  • 11 edits
    2 adds in trunk

2011-06-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Crash if ShadowRoot has a text node.
https://bugs.webkit.org/show_bug.cgi?id=63607

  • fast/dom/shadow/shadow-root-text-child-expected.txt: Added.
  • fast/dom/shadow/shadow-root-text-child.html: Added.

2011-06-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Crash if ShadowRoot has a text node.
https://bugs.webkit.org/show_bug.cgi?id=63607

Node::styleForRenderer() for Text node wasn't shadow-aware.
This change allow styleForRenderer() to know its visual parent by
passing NodeRenderingContext.

Changes other than NodeRenderingContext and Element is just a
follow up for change above.

  • dom/Element.cpp: use NodeRenderingContext to resolve parent node. (WebCore::Element::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::styleForRenderer): Added NodeRenderingContext as a parameter.
  • dom/Node.h:
  • dom/NodeRenderingContext.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::textWithDirection):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::styleForRenderer): (WebCore::TextControlInnerTextElement::styleForRenderer):
  • html/shadow/TextControlInnerElements.h:

Test: fast/dom/shadow/shadow-root-text-child.html

00:42 Changeset [90093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

2011-06-30 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

generate-webkitversion.pl should not "use Switch"
https://bugs.webkit.org/show_bug.cgi?id=63628

Switch got deprecated on recent Perl versions and the script wasn't
using the switch statement.

  • scripts/generate-webkitversion.pl: Remove "use Switch;" line.
00:42 Changeset [90092] by tkent@chromium.org
  • 30 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[GTK][Mac][Win] Update expectation files for r90089.

  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/block/float/032-expected.txt:
  • platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
00:20 Changeset [90091] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Piroska András <Piroska.Andras@stud.u-szeged.hu>

Reviewed by Dirk Schulze.

Apply the ParallelJobs support to FEMorphology
https://bugs.webkit.org/show_bug.cgi?id=63064

The FEMorphology filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-25% on dual-core machines.

  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyGeneric): Apply the filter between yStart and yEnd interval (WebCore::FEMorphology::platformApplyWorker): Call the generic apply from a parallel worker (WebCore::FEMorphology::platformApply): (WebCore::FEMorphology::apply): Move the functionality into platformApply (WebCore::FEMorphology::externalRepresentation): Remove whitespaces
  • platform/graphics/filters/FEMorphology.h:
00:14 Changeset [90090] by ossy@webkit.org
  • 14 edits
    9 adds in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected files after r90089.

  • platform/qt/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/qt/fast/forms/placeholder-set-value-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png: Added.
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png: Added.
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png: Added.
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:

06/29/11:

23:30 Changeset [90089] by tkent@chromium.org
  • 41 edits in trunk

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

Update tests including <input type=search> or <input type=number>. Their
internal structures are changed.
Slight position changes for search result buttons and search cancel
buttons are expected.

  • fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

If a text field has a search results button, a search cancel
button, a speech button, or a spin button, the editable inner text
element and the buttons are wrapped by a flexible box container,
and the editable inner text element has flexibility. As the result
of applying the flexible box, we don't need any horizontal layout
code in RenderTextControlSingleLine except the inner spin button.

Also, we remove custom hit-testing code in nodeAtPoint(). If a
user clicks on a position left of the inner editable text but not
on the search results button, the search results button doesn't
work though it worked.

  • css/html.css: (input::-webkit-textfield-decoration-container): New style definition for the "container" element. (input[type="search"]::-webkit-search-cancel-button): It should be a block element because it's a child of the flexible box. Also, this doesn't have flexibility. (input[type="search"]::-webkit-search-decoration): ditto. (input[type="search"]::-webkit-search-results-decoration): ditto. (input[type="search"]::-webkit-search-results-button): ditto. (input::-webkit-inner-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::containerElement): Add an accessor of the flexible box container. It just calls InputType::containerElement().
  • html/HTMLInputElement.h: Declare it.
  • html/InputType.h: (WebCore::InputType::containerElement): New accessor for a shadow element.
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): m_innerBlock is moved to TextFieldInputType. (WebCore::SearchInputType::needsContainer): A search field always needs the flexible box container because of the results button and the cancel button. (WebCore::SearchInputType::createShadowSubtree): Use TextFieldInputType::createShadowSubtree(), then modify the tree. (WebCore::SearchInputType::destroyShadowSubtree): m_innerBlock is moved to TextFieldInputType.
  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initialize the new members. (WebCore::TextFieldInputType::needsContainer): Returns true if x-webkit-speech. We check a spin button separately. (WebCore::TextFieldInputType::createShadowSubtree): Wrap everything with the flexible box container if needsContainer() or we need a spin button. (WebCore::TextFieldInputType::containerElement): Added an accessor. (WebCore::TextFieldInputType::innerBlockElement): ditto. (WebCore::TextFieldInputType::innerTextElement): ditto. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear references to new shadow nodes.
  • html/TextFieldInputType.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::containerElement): Added an accessor. (WebCore::RenderTextControlSingleLine::innerTextElement): (WebCore::RenderTextControlSingleLine::layout):
    • Correct heights check Comparing with height(), not contentHeigth(), was incorrect.
    • Adjust the container height like the editable inner text.
    • Remove width adjustment
    • Remove the speech button layout code The flexible box layout is enough.

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

Remove custom code for results/cancel/speech buttons, and
Simplify comments.

(WebCore::RenderTextControlSingleLine::forwardEvent):

Remove custom forwarding code for results/cancel buttons.

(WebCore::RenderTextControlSingleLine::styleDidChange):

Clear the style of the container because we update it in layout().

(WebCore::RenderTextControlSingleLine::hasControlClip):

Decoration buttons should be clipped by the container.

(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

We don't need to use display:inline-block any more.

(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):

The text wrapper element should have flexibility.

(WebCore::RenderTextControlSingleLine::textBlockInsetTop):

Updated for the tree structure change.

  • rendering/RenderTextControlSingleLine.h:
22:39 Changeset [90088] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Kent Tamura <tkent@chromium.org>

[Mac] Attempt to fix Leopard build.

  • platform/mac/CursorMac.mm: (WebCore::Cursor::ensurePlatformCursor):
22:12 Changeset [90087] by darin@apple.com
  • 11 edits
    2 deletes in trunk/Source

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added WKCursor.

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • Resources/crossHairCursor.png: Removed.
  • Resources/notAllowedCursor.png: Removed.
  • WebCore.exp.in: Added wkCursor.
  • WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/mac/CursorMac.mm: (WebCore::Cursor::ensurePlatformCursor): Use NSCursor API for Cross, Hand, VerticalText, ContextMenu, Copy, and NotAllowed. Use wkCursor for Move, Alias, Progress, and the resize and panning cursors.
  • platform/mac/WebCoreSystemInterface.h: Added wkCursor.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added WKCursor.
21:16 Changeset [90086] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

test-webkitpy is spamming lots of messages about updating test expectations
https://bugs.webkit.org/show_bug.cgi?id=63680

This patch changes the passing_run() function to capture the
output to stdout and stderr and assert that it is empty, and
also specifies --no-new-test-results by default to avoid getting
"generating baseline" messages for the expected-missing results.

Also check that we are logging messages when we generate new
baselines.

Also fix a minor bug in the way test_tolerance() was
checking for whether the tests were passing or not.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20:40 Changeset [90085] by yutak@chromium.org
  • 6 edits in trunk/Tools

2011-06-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63532

LayoutTestController::overridePreference() will be used to change the value of
the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
at least we need to reset preference values in DumpRenderTree every time we start
a new test because preference values changed in some test should not be leaked
to the next test.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Set the default value. This will be called from TestShell::resetTestController(). (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Set the default value.
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Ditto.
20:34 Changeset [90084] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2011-06-29 Simon Fraser <simon.fraser@apple.com>

Fix the test description.

  • fast/layers/negative-scroll-positions-expected.txt:
  • fast/layers/script-tests/negative-scroll-positions.js:
20:07 Changeset [90083] by bashi@chromium.org
  • 3 edits in trunk/Tools

2011-06-29 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Adam Barth.

check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
https://webkit.org/b/57360

Modify the regular expression to match https scheme.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
  • Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
20:05 Changeset [90082] by keishi@webkit.org
  • 6 edits
    3 adds in trunk

2011-06-29 Keishi Hattori <keishi@webkit.org>

Reviewed by Adam Barth.

Remove extra space at EOL in view source mode
https://bugs.webkit.org/show_bug.cgi?id=63620

  • fast/frames/resources/viewsource-frame-5.html: Added.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Regenerated.
  • fast/frames/viewsource-linebreak-expected.txt: Added.
  • fast/frames/viewsource-linebreak.html: Added. Test that there are no extra spaces at EOL. And that the multiple consecutive line breaks are maintained in the frame.

2011-06-29 Keishi Hattori <keishi@webkit.org>

Reviewed by Adam Barth.

Remove extra space at EOL in view source mode
https://bugs.webkit.org/show_bug.cgi?id=63620

Test: fast/frames/viewsource-linebreak.html

  • css/view-source.css: (tbody:last-child .webkit-line-content:empty:before): If we don't do this the last line will be empty and the height will be shorter than the rest.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addSource): If source file is empty, add an empty line. (WebCore::HTMLViewSourceDocument::finishLine): Call when you are done with the current line. Adds a BR element if the line is empty and sets current to tbody. (WebCore::HTMLViewSourceDocument::addText):
  • html/HTMLViewSourceDocument.h:
19:30 Changeset [90081] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: images page switch actual and expected images before they're loaded
https://bugs.webkit.org/show_bug.cgi?id=63199

We now preload the images and keep the DOM nodes in memory instead of
going back to the MemoryCache all the time. (Also, remove some nutty
</img> HTML.)

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
19:06 Changeset [90080] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-29 Kangil Han <kangil.han@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add APIs to get/set view mode
https://bugs.webkit.org/show_bug.cgi?id=63229

Implement public API for getting/setting the view-mode media feature as specified in W3C.

  • ewk/ewk_view.cpp: (ewk_view_mode_set): (ewk_view_mode_get):
  • ewk/ewk_view.h:
19:02 Changeset [90079] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should tell you when it creates new expectations
https://bugs.webkit.org/show_bug.cgi?id=63675

Unforunately, this patch creates a bunch of test-webkitpy spam because
we don't understand how Python logging works well enough to stop the
spam. :(

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
18:48 Changeset [90078] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Refactor WebKitDriver.run_test into smaller pieces
https://bugs.webkit.org/show_bug.cgi?id=63673

There is no functional change here. Just moving code around.
This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess

  • Scripts/webkitpy/layout_tests/port/webkit.py:
18:36 Changeset [90077] by eric@webkit.org
  • 15 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify skipped file finding in preparation for adding wk2 skipped list fallback
https://bugs.webkit.org/show_bug.cgi?id=63501

Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
the rebaselineserver unit tests. Also fixed nits brought up by Dirk after previous landing.

The goal was to add support for wk2 skipped lists.
However, I found that our skipped list computation was a
manual hack (which only worked for the mac port).

So I fixed a FIXME to move the skipped list finding
into WebKitPort instead of MacPort.
Doing so required the concept of a "port_name", since previously
the only name accessible from a port object was name()
which includes many things beyond "mac" or "chromium", etc.

Eventually I believe we'll want to re-think the way that we pass
in a port_name argument to Port subclasses and expect them to parse
it. But for now I just added a cls.port_name variable which contains
the static information needed to compute wk2 names as well as
compute Skipped list fallback which works for Mac/Win/Qt and Gtk.

In order to test my new _skipped_file_search_paths method, I
fixed another FIXME by making it return relative paths.

I also fixed the test_expectations_path code in WebKitPort to use port_name.
It was using name() which would return PORT-VERSION so MacPort was overriding
it to use just PORT. After fixing test_expectations_path to use port_name
(and making it aware of webkit2) I was able to remove the MacPort implementation.

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add port_name() to access "mac", since name() returns "mac-leopard" etc.
    • Document that real_name() seems to have no purpose.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
    • Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Move Skipped-file finding code down to WebKitPort
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
18:11 Changeset [90076] by commit-queue@webkit.org
  • 14 edits in trunk/Tools

2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90070.
http://trac.webkit.org/changeset/90070
https://bugs.webkit.org/show_bug.cgi?id=63676

Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
#webkit).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
17:46 Changeset [90075] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCE] Correct logical state of WINCE test.

  • platform/win/ScrollbarThemeWin.cpp: The #if OS(WINCE) should have been #if !OS(WINCE)

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

  • rendering/RenderThemeWin.cpp: ditto.

(WebCore::drawControl):

17:42 Changeset [90074] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests doesn't support sample-on-timeout
https://bugs.webkit.org/show_bug.cgi?id=56731

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:30 Changeset [90073] by justin.garcia@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Enrica Casucci.


I forgot to include these (reviewed) style fix-ups in my previous check-in.

  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): (WebCore::visiblePositionForIndex):
17:10 Changeset [90072] by justin.garcia@apple.com
  • 6 edits in trunk/Source/WebCore

2011-06-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Enrica Casucci.

https://bugs.webkit.org/show_bug.cgi?id=62922
indexForVisiblePosition(const VisiblePosition& visiblePosition) does not consider shadow content


VisiblePositions can be inside web form text regions, which use shadow trees. Made indexForVisiblePosition
aware of this, and added a new parameter to obtain the scope for a VisiblePosition, in addition to its index.


Added visiblePositionForIndex to go in the opposite direction, taking into account the scope
used to compute the index.


These two functions use TextIterators to convert between VisiblePositions and indices. But
TextIterator iteration using TextIteratorEmitsCharactersBetweenAllVisiblePositions does not
exactly match VisiblePosition iteration, so using them to preserve a selection during an
editing operation is unreliable. This can be seen in the expected results for:


editing/execCommand/indent-pre-list.html
editing/execCommand/crash-indenting-list-item.html


TextIterator's TextIteratorEmitsCharactersBetweenAllVisiblePositions mode needs to be fixed, or
these functions need to be changed to iterate using actual VisiblePositions. See:


https://bugs.webkit.org/show_bug.cgi?id=63590
TextIterators in TextIteratorEmitsCharactersBetweenAllVisiblePositions do not exactly match VisiblePositions


Also:


https://bugs.webkit.org/show_bug.cgi?id=63592
Use visiblePositionForIndex and indexForVisiblePosition everywhere that TextIterators are used to convert between VisiblePositions and indices


No new tests added because indexForVisiblePosition is currently only used for editing operations
that cannot be performed inside web form fields.

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): (WebCore::visiblePositionForIndex):
  • editing/htmlediting.h:
17:03 Changeset [90071] by dglazkov@chromium.org
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-06-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

Remove ElementWithPseudoId, since now an Element can store it all by itself.
https://bugs.webkit.org/show_bug.cgi?id=63657

Refactoring, covered by existing tests.

  • CMakeLists.txt: Removed ElementWithPseudoId from build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/ColorInputType.cpp: (WebCore::ColorInputType::createShadowSubtree): Changed to use plain-old HTMLDivElement.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Ditto.
  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Ditto.
  • html/shadow/ElementWithPseudoId.cpp: Removed.
  • html/shadow/ElementWithPseudoId.h: Removed.
17:02 Changeset [90070] by eric@webkit.org
  • 14 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify skipped file finding in preparation for adding wk2 skipped list fallback
https://bugs.webkit.org/show_bug.cgi?id=63501

The goal was to add support for wk2 skipped lists.
However, I found that our skipped list computation was a
manual hack (which only worked for the mac port).

So I fixed a FIXME to move the skipped list finding
into WebKitPort instead of MacPort.
Doing so required the concept of a "port_name", since previously
the only name accessible from a port object was name()
which includes many things beyond "mac" or "chromium", etc.

Eventually I believe we'll want to re-think the way that we pass
in a port_name argument to Port subclasses and expect them to parse
it. But for now I just added a cls.port_name variable which contains
the static information needed to compute wk2 names as well as
compute Skipped list fallback which works for Mac/Win/Qt and Gtk.

In order to test my new _skipped_file_search_paths method, I
fixed another FIXME by making it return relative paths.

I also fixed the test_expectations_path code in WebKitPort to use port_name.
It was using name() which would return PORT-VERSION so MacPort was overriding
it to use just PORT. After fixing test_expectations_path to use port_name
(and making it aware of webkit2) I was able to remove the MacPort implementation.

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add port_name() to access "mac", since name() returns "mac-leopard" etc.
    • Document that real_name() seems to have no purpose.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
    • Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Move Skipped-file finding code down to WebKitPort
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
16:59 Changeset [90069] by leviw@chromium.org
  • 24 edits in trunk/Source/WebCore

2011-06-29 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch computeWidth and computeHeight functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63655

Switch computeWidth and computeHeight functions over to the new layout unit abstraction.

Making a point to mark rounding that should eventually be removed by linking to a new
tracking bug: 63645.

No new tests, no functionality changes.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::computePreferredLogicalWidths):
  • rendering/FixedTableLayout.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::computePreferredLogicalWidths): (WebCore::RenderBlock::computeInlinePreferredLogicalWidths): (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeLogicalWidthUsing): (WebCore::RenderBox::computeLogicalHeight): (WebCore::RenderBox::computeLogicalHeightUsing): (WebCore::RenderBox::computePercentageLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalWidth): (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): (WebCore::RenderBox::computeReplacedLogicalWidthUsing): (WebCore::RenderBox::computeReplacedLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight): (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
  • rendering/RenderBox.h:
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::computeLogicalWidth):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::computeReplacedLogicalWidth): (WebCore::RenderImage::computeReplacedLogicalHeight):
  • rendering/RenderImage.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computePreferredLogicalWidths):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::computePreferredLogicalWidths):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight): (WebCore::RenderReplaced::computePreferredLogicalWidths):
  • rendering/RenderReplaced.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::computePreferredLogicalWidths):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::computePreferredLogicalWidths):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::computeReplacedLogicalWidth): (WebCore::RenderVideo::computeReplacedLogicalHeight):
  • rendering/RenderVideo.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::computeLogicalWidth): (WebCore::RenderSVGForeignObject::computeLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computePreferredLogicalWidths): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
16:58 Changeset [90068] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

In RenderBlock, RenderWidget and RenderReplaced destroy functions,
call dirtyLinesFromChangedChild to tell our parent that we are going away.
https://bugs.webkit.org/show_bug.cgi?id=60307

Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html

fast/block/block-not-removed-from-parent-lineboxes-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::destroy):
  • rendering/RenderReplaced.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when failing to remove the linebreak
object(widget, block, replaced, etc) from parent block lineboxes. The
testcase tries to fuzz over the list of html and svg tags.
https://bugs.webkit.org/show_bug.cgi?id=60307

  • fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
  • fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added.
  • fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
  • fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added.
16:54 Changeset [90067] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-06-29 Alan Stearns <stearns@adobe.com>

Reviewed by Tony Chang.

Modify Skipped files so that future css regions layout tests are
skipped by default.

[CSS Regions] Add support for skipped tests
https://bugs.webkit.org/show_bug.cgi?id=63632

  • fast/regions/flow-content-basic.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
16:52 Changeset [90066] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction.

  • rendering/RenderThemeWin.cpp:

(WebCore::drawControl): Don't call setRGBABitmapAlpha

for WinCE case.

16:50 Changeset [90065] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63669
DFG JIT - fix spectral-norm regression

Reviewed by Geoff Garen.

The problem is a mis-speculation leading to us falling off the speculative path.
Make the speculation logic slightly smarter, don't predict int if one of the
operands is already loaded as a double (we use this logic already for compares).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

16:45 Changeset [90064] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=63668

We need to assert the offset to be zero only when the position is NOT offset in node.

  • editing/visible_units.cpp: (WebCore::startOfParagraph):
16:45 Changeset [90063] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-29 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not do put_by_id transition caching.
https://bugs.webkit.org/show_bug.cgi?id=63662

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess):
  • dfg/DFGRepatch.cpp: (JSC::DFG::testPrototype): (JSC::DFG::tryCachePutByID):
16:42 Changeset [90062] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90057.

  • CMakeListsWinCE.txt: Roll back r90061, since GetWorldTransform is not available in WinCE.
  • platform/win/ScrollbarThemeWin.cpp: Conditionally exclude calls to DIBPixelData::setRGBABitmapAlpha for WinCE.

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

16:27 Changeset [90061] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90057.

  • CMakeListsWinCE.txt: Add missing DIBPixelData.cpp to

WinCE build to support setting bitmap image alpha value.

16:11 Changeset [90060] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Added a dummy write barrier emitting function in all the right places in the old JIT
https://bugs.webkit.org/show_bug.cgi?id=63667


SunSpider reports no change.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_put_scoped_var): Do it.

(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.

(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_put_scoped_var): Do it.

(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.

(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!

15:56 Changeset [90059] by simon.fraser@apple.com
  • 6 edits
    5 adds in trunk

2011-06-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Lay some groundwork for rubber-banding in overflow:scroll divs
https://bugs.webkit.org/show_bug.cgi?id=63654

Make it possible for scrollTop and scrollLeft on a RenderLayer to be
set to negative values, which we will do during rubber-banding in
future. Continue to clamp programmatic scrolls, and scroll positions
set by layout between 0 and the max value.

Test: fast/layers/negative-scroll-positions.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollTo):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::scrollToXOffset): (WebCore::RenderLayer::scrollToYOffset):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
15:53 Changeset [90058] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-29 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

RenderLayer::maximumScrollPosition() is wrong
https://bugs.webkit.org/show_bug.cgi?id=62667

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition): (WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition): Add these for good measure; they will be needed in an upcoming patch.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::maximumScrollPosition): Subtract the visible content rect, including the scroll bars.
15:52 Changeset [90057] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90053.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::inTransparencyLayer): Provide
stub implementation for 'inTransparencyLayer'.

15:42 Changeset [90056] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 Skipped list.

  • platform/mac-wk2/Skipped:
15:25 Changeset [90055] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
https://bugs.webkit.org/show_bug.cgi?id=38063

This patch changes new-run-webkit-tests to match old-run-webkit-tests
in generating new expected results when the expected results are
missing.

There are still a couple details that are different:

1) Image baselines aren't generated unless you run with -p.
2) Render tree dumps are places in the cross-platform directory instead
of the platform-specific directory.

I'm inclined to deal with both of these issues in follow-up patches.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
15:24 Changeset [90054] by aroben@apple.com
  • 5 edits
    1 add in trunk/Tools

Teach TestFailures to detect possibly flaky tests and list them separately

Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
arbitrary revisions for breaking flaky tests

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.

(FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
from various builds (in reverse-chronological order).
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
(FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
and puts them in an array in reverse-chronological order.
(FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
to be possibly flaky.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Initialize new members.
(LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
properties: history and possiblyFlaky. history holds the data this function used to pass to
the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
flakiness. Updated documentation comment to match.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
removed from the failure history, since when they started failing is no longer meaningful.
We tell our caller to keep calling until all current failures have been explained and we've
gone through 5 builds without any new flaky tests being identified.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(sorted): New helper function to return a sorted copy of an array.
(Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
that matches the predicate.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
the analyzer. Now puts the list of possibly flaky tests after the failure history.
(ViewController.prototype._domForFailedTest): Moved some code from here...
(ViewController.prototype._domForFailureDiagnosis): ...to here.
(ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
possibly flaky tests and examples of their flakiness and returns it.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

FlakyLayoutTestDetector.js.

15:11 Changeset [90053] by bfulgham@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-29 Xu Fan <qifuren1985@gmail.com>

Reviewed by Brent Fulgham.

Fix Scrollbars Transparent in Windows XP if WebKit is using Layered Window
https://bugs.webkit.org/show_bug.cgi?id=61136

  • platform/graphics/win/DIBPixelData.h: add a static method setRGBABitmapAlpha
  • platform/graphics/win/DIBPixelData.cpp: add implementation
  • platform/win/ScrollbarThemeWin.cpp: fix scroolbar transparent
  • rendering/RenderThemeWin.cpp: fix textbox and button transparent
15:04 Changeset [90052] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Adam says cowboys don't review (or unit test).

  • Scripts/webkitpy/tool/commands/download.py:
14:56 Changeset [90051] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make port/config.py mockable for easier unit testing
https://bugs.webkit.org/show_bug.cgi?id=63661

Fix an exception from the unit tests.

  • Scripts/webkitpy/layout_tests/port/config.py:
14:48 Changeset [90050] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

2011-06-29 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Link against zlib1.dll, not the static zlib.lib.
14:41 Changeset [90049] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-29 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBoxModelObject::margin* and setMargin* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63652

Switch margin methods for render tree over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderText.h:
14:33 Changeset [90048] by leviw@chromium.org
  • 52 edits in trunk/Source/WebCore

2011-06-29 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paint to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63645

Switch vanilla paint function over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderBox.h:
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.h:
14:29 Changeset [90047] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:

Link against zlib1.dll, not the static zlib.lib.

14:28 Changeset [90046] by jianli@chromium.org
  • 5 edits
    3 deletes in trunk

WebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html
https://bugs.webkit.org/show_bug.cgi?id=63151

Reviewed by Kenneth Russell.

Source/WebCore:

The fix is to change to throw TypeError in custom JS/V8 bindings.

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):
(WebCore::setDataViewMember):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):

LayoutTests:

Updated the expected result and removed the rebaselined files that are not needed.

  • fast/canvas/webgl/data-view-test-expected.txt:
  • platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.
14:25 Changeset [90045] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Convert uses of computeLengthIntForLength() to computeLength<Length>()
https://bugs.webkit.org/show_bug.cgi?id=63641

No new tests / refactoring only.

  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition):
14:25 Changeset [90044] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Jeff Timanus <twiz@chromium.org>

Reviewed by Stephen White.

[Chromium] Remove flakiness marker from fast/canvas/canvas-longlived-context.html
https://bugs.webkit.org/show_bug.cgi?id=63649

  • platform/chromium/test_expectations.txt:
14:22 Changeset [90043] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove duplicate methods in filesystem.py
https://bugs.webkit.org/show_bug.cgi?id=63658

Looks like there was a bad merge at some point.

I also removed a bunch of redundant docstrings.

  • Scripts/webkitpy/common/system/filesystem.py:
14:20 Changeset [90042] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Simplify AudioBufferSourceNode rendering
https://bugs.webkit.org/show_bug.cgi?id=63586

No new tests since this doesn't change API.

  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::renderFromBuffer): (WebCore::AudioBufferSourceNode::reset): (WebCore::AudioBufferSourceNode::setBuffer): (WebCore::AudioBufferSourceNode::noteOn): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::totalPitchRate):
  • webaudio/AudioBufferSourceNode.h:
14:03 Changeset [90041] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Many tests report ERROR: Failed to get glyph page zero.
https://bugs.webkit.org/show_bug.cgi?id=63498

Instead of conditionally instantiating the m_scaledFont member of FontPlatformData,
always instantiate it. For times when the size is 0 and the instantiation would lead
to a Cairo error, we use size 1 and just make operations which would fail conditional
on the m_size > 0.

No new tests. This change is covered by existing tests. We should
observe no errors on the bots after landing.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): Instead of looking at whether or not there is a scaled font to determine whether to draw, just look at the size.
  • platform/graphics/freetype/FontPlatformData.h: Remove the m_font member.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Always instantiate a scaled font member and remove references to m_font. If we are instantiating a scaled font for a 0 size font, instantiate a size 1 font, so that we can still use Cairo to query font properties.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): We can assume there is always a scaled font now.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Ditto. (WebCore::SimpleFontData::createScaledFontData): Ditto. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
13:55 Changeset [90040] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Pass --no-new-test-results to NRWT on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=63653

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:52 Changeset [90039] by eric.carlson@apple.com
  • 5 edits
    4 adds in trunk

2011-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media element loads blocked by a resource load delegate do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

Tests: media/media-blocked-by-beforeload.html

media/media-blocked-by-willsendrequest.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Call mediaLoadingFailed instead of noneSupported

so all failures follow the same code path.

(WebCore::HTMLMediaElement::loadResource): Call mediaLoadingFailed when there is no frame, when

the loader delegate rejects the url, or when MediaPlayer doesn't find a media engine that
supports the type.

(WebCore::HTMLMediaElement::selectNextSourceChild): Fix incorrect logging.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Change name of parameter from "state" to

"error" to make its purpose obvious.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Return a bool indicating whether or not the url was given to

a media engine.

(WebCore::MediaPlayer::loadWithNextMediaEngine): Add some logging.

  • platform/graphics/MediaPlayer.h:

2011-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media element loads blocked by a resource load delegate do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

  • media/media-blocked-by-beforeload-expected.txt: Added.
  • media/media-blocked-by-beforeload.html: Added.
  • media/media-blocked-by-willsendrequest-expected.txt: Added.
  • media/media-blocked-by-willsendrequest.html: Added.
13:46 Changeset [90038] by darin@apple.com
  • 5 edits
    2 adds in trunk

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

  • fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added.
  • fast/loader/create-frame-in-DOMContentLoaded.html: Added.

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

Test: fast/loader/create-frame-in-DOMContentLoaded.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Added an assertion. (WebCore::FrameLoader::finishedLoadingDocument): Removed a non-helpful #if statement. The rule that we do not call the client when creating the initial empty document was nominally specific to Windows and Chromium but is needed for all platforms.

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame): Added a check for null when creating a frame. Also added a check that was in the WebKit1 code, but not here. Strangely, the comment from the second check was still here, but not the code.
13:14 Changeset [90037] by enne@google.com
  • 1 edit
    3 copies in branches/chromium/782

Merge 88698 - 2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

  • compositing/layer-creation/overlap-child-layer-expected.png: Added.
  • compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-child-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.

Test: compositing/layer-creation/overlap-animated-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):

TBR=enne@google.com

12:47 Changeset [90036] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

[GTK] overlapping drag&drop tests fail on NRWT
https://bugs.webkit.org/show_bug.cgi?id=57640

Make a GTK test driver that spawns one Xvfb instance per
thread. This avoids bad interactions in DnD tests between threads.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:46 Changeset [90035] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

2011-06-29 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform get_by_id self list caching.
https://bugs.webkit.org/show_bug.cgi?id=63605

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDList): (JSC::DFG::dfgBuildGetByIDList):
  • dfg/DFGRepatch.h:
12:46 QtWebKitRelease20 edited by ademar.reis@openbossa.org
(diff)
12:45 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
12:20 Changeset [90034] by nduca@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Nat Duca <nduca@chromium.org>

[chromium] Unreviewed, mark fast/canvas/webgl/context-lost-restored failing
https://bugs.webkit.org/show_bug.cgi?id=63643

  • platform/chromium/test_expectations.txt:
12:18 Changeset [90033] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-29 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Add Qt dependencies in QtWebKit's main pro file.
https://bugs.webkit.org/show_bug.cgi?id=63639

syncqt, the script which generates the headers inside Qt parses
the main pro file of QtWebKit to check the Qt dependencies. It used
to be WebCore.pro but after the build reorganization QtWebKit.pro is
the new main pro file so we need to add the network dependency just like
we did in WebCore.pro.

12:07 Changeset [90032] by nduca@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Nat Duca <nduca@chromium.org>

[chromium] Unreviewed, mark index-validation-with-resized-buffer as failing.
https://bugs.webkit.org/show_bug.cgi?id=63638

  • platform/chromium/test_expectations.txt:
11:58 Changeset [90031] by commit-queue@webkit.org
  • 2 edits
    1 move
    9 deletes in trunk/LayoutTests

2011-06-29 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/paragraph-in-preserveNewline.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63362

Converted editing/deleting/paragraph-in-preserveNewline.html to dump-as-markup,
added doctype, added new baseline, and removed old baselines.

  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/paragraph-in-preserveNewline-expected.html: Added.
  • platform/chromium-linux/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
  • platform/gtk/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac-leopard/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
11:58 Changeset [90030] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Switch hitTestColumns/Contents/Floats to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63589

Switch location and size methods for RenderBox over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/ColumnInfo.h: (WebCore::ColumnInfo::desiredColumnWidth): (WebCore::ColumnInfo::setDesiredColumnWidth): (WebCore::ColumnInfo::columnHeight): (WebCore::ColumnInfo::setColumnCountAndHeight): (WebCore::ColumnInfo::setColumnHeight): (WebCore::ColumnInfo::updateMinimumColumnHeight): (WebCore::ColumnInfo::minimumColumnHeight):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromChildren): (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::columnRectAt):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::xPositionForFloatIncludingMargin): (WebCore::RenderBlock::yPositionForFloatIncludingMargin):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderLayer.h:
11:30 Changeset [90029] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-29 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Divide by zero in TilingData
https://bugs.webkit.org/show_bug.cgi?id=63305

Add safety checks for empty layers.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::updateRect):
11:21 Changeset [90028] by japhet@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-29 Nate Chapin <japhet@chromium.org>

Unreviewed, more chromium test updates.

  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
10:57 Changeset [90027] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-06-29 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Darin Adler.

Add note about cases where enums are preferred over bools on function parameters.
https://bugs.webkit.org/show_bug.cgi?id=63564

This matches the outcome of this webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015192.html

  • coding/coding-style.html:
10:46 Changeset [90026] by dglazkov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Extract setShadowRoot function, harden it in preparation to be exposed to script.
https://bugs.webkit.org/show_bug.cgi?id=63596

Refactoring, covered by existing tests.

  • dom/Element.cpp: (WebCore::validateShadowRoot): Added. (WebCore::Element::setShadowRoot): Extracted from ensureShadowRoot. (WebCore::Element::ensureShadowRoot): Changed to use setShadowRoot.
  • dom/Element.h: Added decl.
10:44 Changeset [90025] by jhawkins@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-29 James Hawkins <jhawkins@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix a crash on when executeCommand(copy) is called on a null node.
https://bugs.webkit.org/show_bug.cgi?id=63626

  • src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode):
10:42 Changeset [90024] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89888.
http://trac.webkit.org/changeset/89888
https://bugs.webkit.org/show_bug.cgi?id=63609

"Seems to be causing merging issues on the dashboard, e.g.

http://test-
results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
(Requested by aboxhall on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:34 Changeset [90023] by japhet@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-06-29 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium test updates.

  • platform/chromium-mac-leopard/svg/foreignObject: Added.
  • platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium/test_expectations.txt:
09:22 Changeset [90022] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631

  • http/tests/inspector/network/network-request-revision-content-expected.txt: Added.
  • http/tests/inspector/network/network-request-revision-content.html: Added.
  • http/tests/inspector/network/resources/script.js: Added.

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631

Test: http/tests/inspector/network/network-request-revision-content.html

  • inspector/front-end/Resource.js: (WebInspector.ResourceRevision.prototype.requestContent):
09:15 Changeset [90021] by kbalazs@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-06-29 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] plugins/document-open.html need new result for wk2
https://bugs.webkit.org/show_bug.cgi?id=63633

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/document-open-expected.txt: Added.
08:56 Changeset [90020] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-29 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::clipToImageBuffer does not support scale transformation
https://bugs.webkit.org/show_bug.cgi?id=63555

Scale alphaMask if GraphicsContext is scaled

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pushTransparencyLayerInternal):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::clip):
08:20 Changeset [90019] by loislo@chromium.org
  • 3 edits in branches/chromium/782/Source/WebCore/inspector/front-end

Merge 89666 - 2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/utilities.js: ():

TBR=mnaganov@chromium.org
BUG=87584
Review URL: http://codereview.chromium.org/7218041

08:17 Changeset [90018] by loislo@chromium.org
  • 3 edits in branches/chromium/782

Merge 90013 - 2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesText):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

TBR=pfeldman@chromium.org
BUG=87895
Review URL: http://codereview.chromium.org/7280007

07:38 Changeset [90017] by caseq@chromium.org
  • 9 edits in trunk/Source

2011-06-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
https://bugs.webkit.org/show_bug.cgi?id=62894

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setAgentProcessIdentifier):
  • inspector/InspectorController.h:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::setAgentIdentifier): (WebCore::InspectorPageAgent::createIdentifier): (WebCore::InspectorPageAgent::frameForId): (WebCore::InspectorPageAgent::frameId): (WebCore::InspectorPageAgent::frameDestroyed):
  • inspector/InspectorPageAgent.h:

2011-06-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
https://bugs.webkit.org/show_bug.cgi?id=62894

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setAgentProcessIdentifier):
  • src/WebDevToolsAgentImpl.h:
07:18 Changeset [90016] by philn@webkit.org
  • 2 edits in trunk/Tools

Reviewed by Martin Robinson.

[webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
https://bugs.webkit.org/show_bug.cgi?id=63624

  • Scripts/webkitpy/common/system/executive.py: In some cases the ps output lines can contain one or more leading white-spaces, so strip it before splitting the pid and command name.
07:12 Changeset [90015] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-29 Michal Pakula vel Rutka <m.pakula@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add ewk_frame_text_selection_type_get function
https://bugs.webkit.org/show_bug.cgi?id=63462

Add a method to obtain current WebCore::VisibleSelection text
selection type.

  • ewk/ewk_frame.cpp: (ewk_frame_text_selection_type_get):
  • ewk/ewk_frame.h:
06:58 Changeset [90014] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels.
https://bugs.webkit.org/show_bug.cgi?id=63450

Buttons should be created in code, not in HTML. Also making Inspect Element
action available on all panels (as an experiment).

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.hide):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.updateFocusedNode): (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
  • inspector/front-end/inspector.css: (button.dock-status-bar-item.status-bar-item .glyph): (button.dock-status-bar-item.status-bar-item.toggled-on .glyph): (.console-status-bar-item .glyph):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector.set attached):
06:47 Changeset [90013] by pfeldman@chromium.org
  • 6 edits in trunk

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesText):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
06:42 Changeset [90012] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove erroneous test name from GTK Skipped list.

  • platform/gtk/Skipped:
06:13 Changeset [90011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Inspector failing to load resource content after navigation. Safari.
https://bugs.webkit.org/show_bug.cgi?id=63480

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
05:43 Changeset [90010] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk

2011-06-29 Mike West <mkwst@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Setting correct expectations for the following fields newly added to
the HAR implementation:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Added.
  • http/tests/inspector/resource-har-headers.html: Added.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-06-29 Mike West <mkwst@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Specifically, this patch adds:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression

Tests: http/tests/inspector/resource-har-conversion.html

http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html

04:44 Changeset [90009] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 acid tests on GTK due to bug 54119. They were
failing only in 32-Bits Release though.

  • platform/gtk/Skipped:
04:05 Changeset [90008] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Qt specific results committed in r90007, but fail on Qt-Mac platform

  • platform/qt-mac/Skipped: Skip failing tests.
03:44 Changeset [90007] by ossy@webkit.org
  • 3 edits
    10 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.

  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
03:24 Changeset [90006] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Kent Tamura.

[Chromium] [DRT] ImageDiff should compile in VS2010
https://bugs.webkit.org/show_bug.cgi?id=63614

  • DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
02:58 Changeset [90005] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of 2 more tests.

  • inspector/console/console-trace-in-eval-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
02:39 Changeset [90004] by hayato@chromium.org
  • 5 edits
    2 adds in trunk

2011-06-29 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
https://bugs.webkit.org/show_bug.cgi?id=62358.

This patch doesn't take an effect on the following elements to keep a compatibility.

  • <input>, <textarea>, <video> and <audio> elements We'll address these elements separately after re-targeting focus events (bug 61421) is implemented.

A shadow root's <content> is not considered in this patch.
That should be addressed in another patch. See bug 63522.

  • fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Added.
  • fast/dom/shadow/shadow-host-transfer-focus.html: Added.

2011-06-29 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
https://bugs.webkit.org/show_bug.cgi?id=62358.

This patch doesn't take an effect on the following elements to keep a compatibility.

  • <input>, <textarea>, <video> and <audio> elements We'll address these elements separately after re-targeting focus events (bug 61421) is implemented.

A shadow root's <content> is not considered in this patch.
That should be addressed in another patch. See bug 63522.

Test: fast/dom/shadow/shadow-host-transfer-focus.html

  • dom/Element.cpp: (WebCore::Element::focus):
  • page/FocusController.cpp: (WebCore::shadowRoot): (WebCore::isTreeScopeOwner): (WebCore::FocusController::transferFocusToElementInShadowRoot): (WebCore::hasCustomFocusLogic): (WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::ownerOfTreeScope): (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
  • page/FocusController.h:
02:32 Changeset [90003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Dirk Schulze.

SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
https://bugs.webkit.org/show_bug.cgi?id=61600

Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()

No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
02:29 Changeset [90002] by rolandsteiner@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: last last ruby expectations for WebKit2 Win.

  • platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
02:22 Changeset [90001] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip
http/tests/history/cross-origin-replace-history-object-child.html
on GTK, due to bug 61937.

  • platform/gtk/Skipped:
02:18 Changeset [90000] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.

  • platform/gtk/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
01:59 Changeset [89999] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of
fast/html/details-open-javascript.html

  • platform/gtk/fast/html/details-open-javascript-expected.txt:
01:30 Changeset [89998] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip crashing tests on GTK because of
https://bugs.webkit.org/show_bug.cgi?id=63611

  • platform/gtk/Skipped: skip 5 editing tests
00:57 Changeset [89997] by rolandsteiner@chromium.org
  • 5 edits in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update the (hopefully) last ruby expectation stragglers in WebKit2

  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt:
00:31 Changeset [89996] by loislo@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/inspector/front-end

Merge 89562 - 2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
https://bugs.webkit.org/show_bug.cgi?id=63250

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):

TBR=mnaganov@chromium.org
BUG=87583
Review URL: http://codereview.chromium.org/7280004

00:21 Changeset [89995] by rolandsteiner@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: more juggling with ruby expectation files, trying to
find my way out of the expectations dependency jungle...

  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
00:11 Changeset [89994] by darin@apple.com
  • 4 edits
    3 moves in trunk/LayoutTests

2011-06-29 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Consolidate the fast/loader and fast/loading directories
https://bugs.webkit.org/show_bug.cgi?id=63587

  • fast/loader/resources/subframe-that-removes-itself.html: Copied from LayoutTests/fast/loading/resources/subframe-that-removes-itself.html.
  • fast/loader/subframe-removes-itself-expected.txt: Copied from LayoutTests/fast/loading/subframe-removes-itself-expected.txt.
  • fast/loader/subframe-removes-itself.html: Copied from LayoutTests/fast/loading/subframe-removes-itself.html.
  • fast/loading/resources/subframe-that-removes-itself.html: Removed.
  • fast/loading/subframe-removes-itself-expected.txt: Removed.
  • fast/loading/subframe-removes-itself.html: Removed.
  • platform/gtk/Skipped: Updated for new location of test.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt-wk2/Skipped: Ditto.
Note: See TracTimeline for information about the timeline view.