Timeline


and

07/05/11:

23:59 Changeset [90440] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Re-enable NRWT on Leopard now that bug 63973 is fixed.

Reviewed by Adam Barth.

I also made the should-enable expression a black-list instead
of a white-list since every bot on build.webkit.org is
now using NRWT except windows and WebKit2 bots.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
23:55 Changeset [90439] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Perl string concat failure on Leopard (causes NRWT to fail)
https://bugs.webkit.org/show_bug.cgi?id=63973

Reviewed by Daniel Bates.

Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
thus the version parsing logic in webkitdirs.pm seems to fail.

Default to "3.0" instead of undef when we can't parse the version number.
This should send us down the correct path for Leopard.

  • Scripts/webkitdirs.pm: (determineBaseProductDir):
23:36 Changeset [90438] by commit-queue@webkit.org

2011-07-05 Kentaro Hara <haraken@google.com>

Trigger a 'change' event whenever selected files are changed
https://bugs.webkit.org/show_bug.cgi?id=63929

Reviewed by Kent Tamura.

Record previously selected files and then compare them with newly selected files.
If the previously selected files and their order are not equal to those of
the newly selected files, we trigger the 'change' event.

  • fast/forms/file-input-change-event-expected.txt: Added.
  • fast/forms/file-input-change-event.html: Added.

2011-07-05 Kentaro Hara <haraken@google.com>

Trigger a 'change' event whenever selected files are changed
https://bugs.webkit.org/show_bug.cgi?id=63929

Reviewed by Kent Tamura.

Record previously selected files and then compare them with newly selected files.
If the previously selected files and their order are not equal to those of
the newly selected files, we trigger the 'change' event.

Test: fast/forms/file-input-change-event.html

  • html/FileInputType.cpp: (WebCore::FileInputType::filesChosen): Calls dispathChangeEvent() only when the previously selected files are different from the newly selected files
23:35 Changeset [90437] by commit-queue@webkit.org

2011-07-05 Filip Pizlo <fpizlo@apple.com>

DFG JIT virtual call implementation is inefficient.
https://bugs.webkit.org/show_bug.cgi?id=63974

Reviewed by Gavin Barraclough.

  • dfg/DFGOperations.cpp:
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeForCallWithArityCheck): (JSC::ExecutableBase::generatedJITCodeForConstructWithArityCheck): (JSC::ExecutableBase::generatedJITCodeWithArityCheckFor): (JSC::ExecutableBase::hasJITCodeForCall): (JSC::ExecutableBase::hasJITCodeForConstruct): (JSC::ExecutableBase::hasJITCodeFor):
  • runtime/JSFunction.h: (JSC::JSFunction::scopeUnchecked):
22:29 Changeset [90436] by tkent@chromium.org

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573

  • fast/forms/input-appearance-range.html: Give a focus on a slider to check focus appearance.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-range-expected.png:

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): Need to pass the RenderObject of the owner <input> because updateFocusedState() checks the outline style of the specified renderer, and we'd like to make a slider thumb reflect the owner focus style.
21:36 Changeset [90435] by kevino@webkit.org

[wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.

21:24 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
21:11 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
21:00 Changeset [90434] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
20:50 Changeset [90433] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (runningOnBuildBot):
20:44 Changeset [90432] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Add results_unittests.js to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63971

Reviewed by Eric Seidel.

Adding these unit tests forced me to commit to an API for the results
module. I'm not sure if this is the API we'll end up with, but it's
something not entirely unreasonable.

Also, I've changed results.js over to WebKit style, as discussed previously.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
20:34 Changeset [90431] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests:
20:15 Changeset [90430] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Add first unit tests for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63969

Reviewed by Eric Seidel.

I've also reformated base.js to match WebKit style, as discussed in the
previous bug.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
20:11 Changeset [90429] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Move Qt, Gtk and Leopard to NRWT.

We'll roll out any of these if we see problems.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
19:32 Changeset [90428] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

garden-o-matic should understand which tests have unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=63965

Reviewed by Eric Seidel.

Currently, this code just logs the list of unexpected failures to the
console. A future patch will do something useful with this
information. A testing harness will also come in the next patch.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
19:30 Changeset [90427] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Import qunit JavaScript unit testing framework
https://bugs.webkit.org/show_bug.cgi?id=63967

Reviewed by Eric Seidel.

We're going to use this unit testing framework to test garden-o-matic.

  • qunit: Added.
18:30 Changeset [90426] by oliver@apple.com

2011-07-05 Oliver Hunt <oliver@apple.com>

Force inlining of simple functions that show up as not being inlined
https://bugs.webkit.org/show_bug.cgi?id=63964

Reviewed by Gavin Barraclough.

Looking at profile data indicates the gcc is failing to inline a
number of trivial functions. This patch hits the ones that show
up in profiles with the ALWAYS_INLINE hammer.

We also replace the memcpy() call in linking with a manual loop.
Apparently memcpy() is almost never faster than an inlined loop.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::add_S): (JSC::ARMv7Assembler::ARM_and): (JSC::ARMv7Assembler::asr): (JSC::ARMv7Assembler::b): (JSC::ARMv7Assembler::blx): (JSC::ARMv7Assembler::bx): (JSC::ARMv7Assembler::clz): (JSC::ARMv7Assembler::cmn): (JSC::ARMv7Assembler::cmp): (JSC::ARMv7Assembler::eor): (JSC::ARMv7Assembler::it): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::ldrCompact): (JSC::ARMv7Assembler::ldrh): (JSC::ARMv7Assembler::ldrb): (JSC::ARMv7Assembler::lsl): (JSC::ARMv7Assembler::lsr): (JSC::ARMv7Assembler::movT3): (JSC::ARMv7Assembler::mov): (JSC::ARMv7Assembler::movt): (JSC::ARMv7Assembler::mvn): (JSC::ARMv7Assembler::neg): (JSC::ARMv7Assembler::orr): (JSC::ARMv7Assembler::orr_S): (JSC::ARMv7Assembler::ror): (JSC::ARMv7Assembler::smull): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S): (JSC::ARMv7Assembler::tst): (JSC::ARMv7Assembler::linkRecordSourceComparator): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Reg3Imm8): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Imm5Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp7Reg3Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8Imm8): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8RegReg143): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp9Imm7): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp10Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4FourFours): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16FourFours): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16Op16): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4Reg4Imm12): (JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp): (JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::linkCode):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::moveWithPatch): (JSC::MacroAssemblerARMv7::branchPtrWithPatch): (JSC::MacroAssemblerARMv7::storePtrWithPatch): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeTailRecursiveCall): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::makeBranch):
18:20 Changeset [90425] by commit-queue@webkit.org

2011-07-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Make "Add optimised paths for a few maths functions" work on Qt
https://bugs.webkit.org/show_bug.cgi?id=63893

Reviewed by Oliver Hunt.

Move the generated code to the .text section instead of .data section.
Fix alignment for the 32 bit thunk code.

  • jit/ThunkGenerators.cpp:
18:18 Changeset [90424] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

garden-o-matic should know how to fetch test results from the (NRWT) bots
https://bugs.webkit.org/show_bug.cgi?id=63959

Reviewed by Eric Seidel.

Currently, this code just fetches the results and expectations JSON
blob for Linux from the server and logs it to the console.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
17:56 Changeset [90423] by commit-queue@webkit.org

2011-07-05 Filip Pizlo <fpizlo@apple.com>

DFG JIT does not implement op_call.
https://bugs.webkit.org/show_bug.cgi?id=63858

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::setNumberOfCallLinkInfos): (JSC::CodeBlock::numberOfCallLinkInfos):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitConstruct):
  • dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::lookupGetByVal): (JSC::DFG::AliasTracker::recordCall): (JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (JSC::DFG::ByteCodeParser::getLocal): (JSC::DFG::ByteCodeParser::getArgument): (JSC::DFG::ByteCodeParser::toInt32): (JSC::DFG::ByteCodeParser::addToGraph): (JSC::DFG::ByteCodeParser::addVarArgChild): (JSC::DFG::ByteCodeParser::predictInt32): (JSC::DFG::ByteCodeParser::parseBlock): (JSC::DFG::ByteCodeParser::processPhiStack): (JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::opName): (JSC::DFG::Graph::dump): (JSC::DFG::Graph::refChildren):
  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::useChildren): (JSC::DFG::JITCodeGenerator::emitCall):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::addressOfCallData):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::CallRecord::CallRecord): (JSC::DFG::JITCompiler::notifyCall): (JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck): (JSC::DFG::JITCompiler::addJSCall): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord): (JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
  • dfg/DFGNode.h: (JSC::DFG::Node::Node): (JSC::DFG::Node::child1): (JSC::DFG::Node::child2): (JSC::DFG::Node::child3): (JSC::DFG::Node::firstChild): (JSC::DFG::Node::numChildren):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::basicArithOp): (JSC::DFG::NonSpeculativeJIT::compare): (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgLinkCall):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch): (JSC::DFG::SpeculativeJIT::compilePeepHoleCall): (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
  • interpreter/CallFrame.h: (JSC::ExecState::calleeAsValue):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
  • jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::jitType): (JSC::JITCode::HostFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h:
17:33 Changeset [90422] by dpranke@chromium.org

2011-07-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Python tests are failing on leopard
https://bugs.webkit.org/show_bug.cgi?id=63842

Fix the missing flush() call that appears to be needed by the
logging package in python 2.5. Also fix the regressions
introduced in the run_webkit_test tests when we switched from
thread to processes (since processes aren't available on 2.5).

Also fix a missing "from future import with_statement' in
testfilehandler (unreviewed).

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • TestResultServer/handlers/testfilehandler.py:
17:31 Changeset [90421] by oliver@apple.com

Initialize new MarkStack member

17:16 Changeset [90420] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
now that we believe the stray http-server issue to be solved.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
17:12 Changeset [90419] by dpranke@chromium.org

2011-07-05 Dirk Pranke <dpranke@chromium.org>

nrwt: allow for multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=63116

Reviewed by Tony Chang.

This modifies the sharding logic to support multiple http
shards, but for now we clamp to one shard until we can test
perf impact and flakiness impact.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
17:08 Changeset [90418] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Turns out we need to support numerals too because that's what jQuery
uses by default.

  • TestResultServer/handlers/testfilehandler.py:
17:07 Changeset [90417] by dpranke@chromium.org

2011-07-05 Dirk Pranke <dpranke@chromium.org>

Re-land nrwt: make sharding tests needing locks less hard-coded
https://bugs.webkit.org/show_bug.cgi?id=63112

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
16:56 Changeset [90416] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

TestResultServer should support callback parameter for JSON
https://bugs.webkit.org/show_bug.cgi?id=63961

Reviewed by Ojan Vafai.

This makes using jQuery.ajax so much more pleasant.

  • TestResultServer/handlers/testfilehandler.py:
16:55 Changeset [90415] by oliver@apple.com

2011-07-05 Oliver Hunt <oliver@apple.com>

Don't throw out compiled code repeatedly
https://bugs.webkit.org/show_bug.cgi?id=63960

Reviewed by Gavin Barraclough.

Stop throwing away all compiled code every time
we're told to do a full GC. Instead unlink all
callsites during such GC passes to maximise the
number of collectable functions, but otherwise
leave compiled functions alone.

  • API/JSBase.cpp: (JSGarbageCollect):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • heap/Heap.cpp: (JSC::Heap::collectAllGarbage):
  • heap/MarkStack.h: (JSC::MarkStack::shouldUnlinkCalls): (JSC::MarkStack::setShouldUnlinkCalls):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::recompileAllJSFunctions): (JSC::JSGlobalData::releaseExecutableMemory):
  • runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::invalidateCode):
  • runtime/RegExp.h:
16:18 Changeset [90414] by commit-queue@webkit.org

2011-07-05 Filip Pizlo <fpizlo@apple.com>

JSC JIT has code duplication for the handling of call and construct
https://bugs.webkit.org/show_bug.cgi?id=63957

Reviewed by Gavin Barraclough.

  • jit/JIT.cpp: (JSC::JIT::linkFor):
  • jit/JIT.h:
  • jit/JITStubs.cpp: (JSC::jitCompileFor): (JSC::DEFINE_STUB_FUNCTION): (JSC::arityCheckFor): (JSC::lazyLinkFor):
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeFor): (JSC::FunctionExecutable::compileFor): (JSC::FunctionExecutable::isGeneratedFor): (JSC::FunctionExecutable::generatedBytecodeFor): (JSC::FunctionExecutable::generatedJITCodeWithArityCheckFor):
16:16 Changeset [90413] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

buildbot needs to understand whether NRWT exited early after having too many failures
https://bugs.webkit.org/show_bug.cgi?id=63839

Reviewed by Adam Barth.

Teach the new results.html how to display a warning when testing exited early.
The warning isn't quite as nice as ORWT since I couldn't figure out how to
find the total tests run, or total unexpected crashes. I figure
this is enough to get us going and we can refine it further.

  • fast/harness/results.html:

2011-07-05 Eric Seidel <eric@webkit.org>

buildbot needs to understand whether NRWT exited early after having too many failures
https://bugs.webkit.org/show_bug.cgi?id=63839

Reviewed by Adam Barth.

Fix-up the exited early messages printed by NRWT so that
the buildbot can parse them as expected.
It looks for lines using "if line.find('Exiting early') >= 0:"

I also plumbed the "early exit" status through to results.json
in the form of an "interrupted" bool. It was unclear to me
if results.json already had enough information to compute this bool
itself. It's possible Ojan could come up with a better fix.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
15:59 Changeset [90412] by eric@webkit.org

2011-07-05 Eric Seidel <eric@webkit.org>

new-run-webkit-tests fails to start http server if one is already running
https://bugs.webkit.org/show_bug.cgi?id=63956

Reviewed by Adam Barth.

  • BuildSlaveSupport/kill-old-processes:
    • Removed M line endings and sorted the process names.
    • There are no functional changes to this file. (except that now that its using unix line endings it can be executed directly!)
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
    • Change the name to 'httpd' to match old-run-webkit-test paths.
15:54 Changeset [90411] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Add basic ajax support to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63874

Reviewed by Eric Seidel.

This patch adds some basic infrastructure to garden-o-matic.
Currently, the infrastructure is just used to make the "quit" command
use Ajax, but in the future, this infrastructure will be used to do
more sophistocated remote proceedure calls.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
15:52 Changeset [90410] by abarth@webkit.org

2011-07-05 Adam Barth <abarth@webkit.org>

Add trivial garden-o-matic command (with server)
https://bugs.webkit.org/show_bug.cgi?id=63872

Reviewed by Eric Seidel.

This patch adds a trivial "Hello, world" garden-o-matic command,
complete with an HTTP server. This command re-uses a bunch of code
from the existing rebaseline-server command. Over time, this command
will grow to be a tool useful for gardening the WebKit tree.

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
  • Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
15:20 Changeset [90409] by aroben@apple.com

Make prepare-ChangeLog include modified Perl functions in its ChangeLog template

This is a very simple first cut. Functions must start with a line that starts with "sub "
and end with a line that starts with a closing brace. No leading whitespace is allowed.
Package names aren't parsed at all.

Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
Perl files

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when

searching for function line ranges. This is already done inside the get_function_line_ranges
function.
(get_function_line_ranges): Cleaned up coding style a little bit. Call
get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
unknown extension or no extension, read the shebang line to try to determine the script
interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
(get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
lines starting with "sub " or "}".

15:20 Changeset [90408] by aroben@apple.com

Clean up run-api-tests output on Windows

We were mixing run-api-tests output with gtest output, and the result was a mess.

Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows

Reviewed by Dan Bates.

  • Scripts/run-api-tests:

(runTest):
(populateTests):
Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
the only Mac-specific thing in these functions. Some other platform-specific code was moved
from here...

(prepareEnvironmentForRunningTestTool):
(testToolPath):
...to here.

15:13 Changeset [90407] by hans@chromium.org

2011-07-05 Hans Wennborg <hans@chromium.org>

[V8][Chromium] Remove use of OwnHandle from V8LocalContext
https://bugs.webkit.org/show_bug.cgi?id=63925

Reviewed by Adam Barth.

Replace the OwnHandle<> member in V8LocalContext with
v8::Persistent<v8::Context>.
The code that used OwnHandle<> would not correctly Dispose
of the Context, which would cause the memory to fill up when creating
and destructing many V8LocalContext objects, such as in the case
of IndexedDB.

  • bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
  • bindings/v8/V8Utilities.h:
14:29 Changeset [90406] by commit-queue@webkit.org

2011-07-05 Igor Oliveira <igor.oliveira@openbossa.org>

[Qt] Add ShadowBlur support
https://bugs.webkit.org/show_bug.cgi?id=62997

Use ShadowBlur instead of ContextShadow to handle canvas and css shadows. ShadowBlur is
a newer and platform independent shadow implementation.
Qt QPainter does not have support for shadows so is necessary to create a layer support
to draw complex shapes and fonts. The beginShadowLayer creates a temporary shadow buffer
where the canvas can draw onto and endShadowLayer applies the blur filter, colors the
shadow buffer and draw the final shadow to the graphics context.

Reviewed by Andreas Kling.

  • WebCore.pro:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::setShadowValues): (WebCore::ShadowBlur::updateShadowBlurValues): (WebCore::ShadowBlur::clear): (WebCore::ShadowBlur::blurAndColorShadowBuffer): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer):
  • platform/graphics/ShadowBlur.h: (WebCore::ShadowBlur::type):
  • platform/graphics/qt/ContextShadowQt.cpp: Removed.
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawGlyphs):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::mustUseShadowBlur): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::shadowBlur): (WebCore::GraphicsContext::clipBounds): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
13:51 Changeset [90405] by weinig@apple.com

2011-07-05 Sam Weinig <sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Test: fast/events/custom-event-uninitialized.html

  • bindings/scripts/CodeGeneratorJS.pm: Guard against uninitialized script value.

2011-07-05 Sam Weinig <sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Add test which exercises an initialized details property on
a CustomEvent instance.

  • fast/events/custom-event-uninitialized-expected.txt: Added.
  • fast/events/custom-event-uninitialized.html: Added.
13:09 Changeset [90404] by barraclough@apple.com

Build fix following last patch.

  • runtime/JSFunction.cpp:

(JSC::createPrototypeProperty):

12:45 Changeset [90403] by commit-queue@webkit.org

2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>

[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Modified baseUrl to be a local file in order to get a security origin
that is allowed to request local resources. Removed QSignalSpy from it
as loadFinished always happens, and the original test was split into two.

Reviewed by Benjamin Poulain.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setHtmlWithImageResource): (tst_QWebFrame::setHtmlWithStylesheetResource): (tst_QWebFrame::setHtmlWithBaseURL):
12:02 Changeset [90402] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63947
ASSERT running Object.preventExtensions(Math.sin)

Reviewed by Oliver Hunt.

This is due to calling scope() on a hostFunction as a part of
calling createPrototypeProperty to reify the prototype property.
But host functions don't have a prototype property anyway!

Source/JavaScriptCore:

Prevent callling createPrototypeProperty on a host function.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):

LayoutTests:

Add test case for calling preventExtensions on a host function.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
12:01 Changeset [90401] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63880
Evaluation order of conversions of operands to >, >= incorrect.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add 'leftFirst' parameter to jsLess, jsLessEq matching that described in the ES5
spec. This allows these methods to be reused to perform >, >= relational compares
with correct ordering of type conversions.

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Operations.h:

(JSC::jsLess):
(JSC::jsLessEq):

LayoutTests:

Updated layout test results. Two of these tests now pass, however for
the third we now need to check in failing results, since the test is
incorrect!

The problem if that the test author has made the mistake of thinking
that the evaluation order for the operands to '>' is RHS then LHS.
This is due to a quirk in the way the spec is written. The greater
than opeator is defined to call the abstract relational comparison
algorithm with 'leftFirst' set to false, and as such conversion is
performed on the second operand ('y') first (see 11.8.5). However
the abstract relational comparison algorith is performing a less
than comaprison, and the greater than operator calls this algorithm
with the operands to the greater than operator reversed (see 11.8.2).
As such, the second operand to the abstract comaparison is the LHS
of the greater than. This bug also affects the corresponding less
than or equals test, where we already we have failing results checked
in, and again it is the test that is wrong (for the same reason).

  • fast/js/exception-sequencing-binops2-expected.txt:
  • sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1-expected.txt:
  • sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1-expected.txt:
10:34 Changeset [90400] by psolanki@apple.com

2011-07-05 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Coalesce data array into one NSData before calling didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=63916
<rdar://problem/9715181>

Instead of calling didReceiveData multiple times with smaller chunks of data, we merge the
data buffers into one and call it once.

No new tests because the flag isn't enabled yet.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
09:07 Changeset [90399] by commit-queue@webkit.org

2011-07-05 Tamas Czene <Czene.Tamas@stud.u-szeged.hu>

Reviewed by Simon Fraser.

Remove virtual functions from StyleImage.
https://bugs.webkit.org/show_bug.cgi?id=63909

We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
Some profile data shows this part is significant, especially in small CSS-based sites.
Removing the virtual functions - removing the calls - makes a small performance progression on this part.

  • rendering/style/StyleCachedImage.h: (WebCore::StyleCachedImage::StyleCachedImage):
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::StyleGeneratedImage):
  • rendering/style/StyleImage.h: (WebCore::StyleImage::isCachedImage): (WebCore::StyleImage::isPendingImage): (WebCore::StyleImage::isGeneratedImage): (WebCore::StyleImage::StyleImage):
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::StylePendingImage):
09:01 Changeset [90398] by yurys@chromium.org

2011-07-05 Yury Semikhatsky <yurys@chromium.org>

[Chromium] Web Inspector: extend WebSharedWorker with inspector transport methods
https://bugs.webkit.org/show_bug.cgi?id=63942

Added methods for connecting inspector to shared worker and for passing
messages between shared worker inspector and corresponding inspector frontend.

Reviewed by Pavel Feldman.

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
  • public/WebSharedWorker.h: (WebKit::WebSharedWorker::attachDevTools): (WebKit::WebSharedWorker::detachDevTools): (WebKit::WebSharedWorker::dispatchDevToolsMessage):
  • public/WebWorkerClient.h:
  • src/WebSharedWorkerImpl.cpp: (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebSharedWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebSharedWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
08:35 Changeset [90397] by pfeldman@chromium.org

2011-07-05 Pavel Feldman <pfeldman@google.com>

Web Inspector: add "element state" setting to the styles section title.
https://bugs.webkit.org/show_bug.cgi?id=63932

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/front-end/Images/paneElementStateButtons.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.muteEventListener): (WebInspector.StylesSidebarPane): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts): (WebInspector.StylesSidebarPane.prototype._toggleElementStatePane): (WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener): (WebInspector.StylesSidebarPane.prototype._createElementStatePane.createCheckbox): (WebInspector.StylesSidebarPane.prototype._createElementStatePane):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.pane > .title > .pane-title-button:active, .pane > .title > .pane-title-button.toggled): (.pane > .title > .pane-title-button.element-state): (.styles-element-state-pane): (.styles-element-state-pane.expanded): (.styles-element-state-pane > table): (.styles-element-state-pane input):
07:03 clutter edited by kov@webkit.org
(diff)
06:59 WebKit Team edited by siddharth.mathur@nokia.com
added Siddharth Mathur to committer list (diff)
06:41 Changeset [90396] by caseq@chromium.org

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Marked css2.1/20110323/replaced-intrinsic-ratio-001.htm as flaky on mac.

  • platform/chromium/test_expectations.txt:
06:31 Changeset [90395] by podivilov@chromium.org

2011-06-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract duplicated code that deals with source mappings.
https://bugs.webkit.org/show_bug.cgi?id=63139

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleMessage.prototype.get stackTrace):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation): (WebInspector.DebuggerPresentationModel.prototype._updateAnchor): (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation): (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.updateSourceFileBreakpointsAndDispatchEvent): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didGetUILocation): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.PresenationCallFrame): (WebInspector.PresenationCallFrame.prototype.sourceLine):
06:10 Changeset [90394] by loislo@chromium.org

2011-07-05 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: WebInspector frontend reports a protocol error in remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=63935

it was error generated for obsolete message "loaded" which was sent from frontend to backend.

Reviewed by Yury Semikhatsky.

05:50 Changeset [90393] by caseq@chromium.org

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
https://bugs.webkit.org/show_bug.cgi?id=63913

Reviewed by Yury Semikhatsky.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._createTable):
  • inspector/front-end/networkPanel.css: (.network-log-grid): (.network-log-grid table.data): (.network-log-grid.small table.data): (.network-log-grid td): (.network-log-grid.small td): (.network-log-grid th): (.network-log-grid.small th): (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending): (.network-log-grid .data-container): (.network-log-grid.small .data-container): (.network-log-grid select): (.network-log-grid.small tr.offscreen): (.network-log-grid tr.offscreen): (.network-log-grid tr.offscreen td): (.network-log-grid tr.filler): (.network-log-grid tr:not(.filler) td.name-column): (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover): (.network-log-grid td.time-column): (.network-log-grid.small .network-graph-side): (.network-log-grid th.sortable:active): (.network-log-grid tr.selected .network-cell-subtitle): (.network-log-grid .icon): (.network-log-grid.small .icon): (.network-log-grid .network-category-scripts .icon): (.network-log-grid.small .network-category-scripts .icon): (.network-log-grid .network-category-documents .icon): (.network-log-grid.small .network-category-documents .icon): (.network-log-grid .network-category-stylesheets .icon): (.network-log-grid.small .network-category-stylesheets .icon): (.network-log-grid .network-category-images .icon): (.network-log-grid.small .network-category-images .icon): (.network-log-grid .image-network-icon-preview): (.network-log-grid.small .image-network-icon-preview): (.network-timeline-grid.small .network-event-divider): (.network-log-grid .resources-dividers): (.network-log-grid .resources-dividers-label-bar): (.network-timeline-grid.small .resources-dividers-label-bar): (.network-timeline-grid .resources-divider-label): (.network-timeline-grid .resources-dividers-label-bar .resources-divider): (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network-timeline-grid .resources-divider.first .resources-divider-label): (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first): (.network-timeline-grid tr.filler td): (.network-summary-bar td): (.network.panel.viewing-resource .network-log-grid th): (.network-log-grid.full-grid-mode .viewer-column): (.network-log-grid.brief-grid-mode .time-column): (.network-log-grid.viewing-resource-mode .timeline-column): (.network.panel .sidebar): (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):
05:49 Changeset [90392] by commit-queue@webkit.org

2011-07-05 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Simon Hausmann.

[Qt] "cat" is not available when building.
https://bugs.webkit.org/show_bug.cgi?id=63924

Changed 'cat' to 'perl -ne \"print $1\"' because 'cat' is not available on Windows with
MSVC toolchain. It passed the Qt buildbots, because they run with cygwin.

Project file change. No tests needed.

04:12 Changeset [90391] by caseq@chromium.org

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Removed custom chromium-linux baselines for
navigator-detached-no-crash.html & register-protocol-handler.html

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/register-protocol-handler-expected.txt: Removed.
03:36 Changeset [90390] by vsevik@chromium.org

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Unreviewed; Qt Linux Release minimal compile fix.

  • testing/Internals.h: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.idl:
03:16 Changeset [90389] by vsevik@chromium.org

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added GTK symbols for new window.internals methods.

Reviewed by Pavel Feldman.

  • Source/autotools/symbols.filter:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added tests for plugin content saving and replacing in NetworkResourcesData.
Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
to ensure NetworkResourcesData is in the correct state before test.

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-embed.html: Added.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Added.
  • http/tests/inspector/network/network-embed-expected.txt: Added.
  • http/tests/inspector/network/network-embed.html: Added.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Added.
  • http/tests/inspector/network/resources/plugin-data.php: Added.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Added.
  • platform/chromium/test_expectations.txt:

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Now the data from didReceiveData callback is passed to inspector.
It is then saved in NetworkResourcesData structure for plugin requests.
Added window.internals.setInspectorResourcesDataSizeLimits() method
for testing replacement logic.

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/network/network-content-replacement-embed.html

http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/network-embed.html

  • WebCore.exp.in:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::setContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::ResourceData::createDecoder): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::decoder): (WebCore::NetworkResourcesData::ResourceData::buffer): (WebCore::NetworkResourcesData::ResourceData::setBuffer): (WebCore::NetworkResourcesData::ResourceData::hasData):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentEncoded):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createEmptyView): (WebInspector.ResourcePreviewView.prototype._createPreviewView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveData): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added win symbols for new window.internals methods.

Reviewed by Pavel Feldman.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
02:31 Changeset [90388] by tkent@chromium.org

2011-07-05 Kent Tamura <tkent@chromium.org>

Add an assertion that percent height box is unregistered correctly.
https://bugs.webkit.org/show_bug.cgi?id=62792

Reviewed by Hajime Morita.

No new tests. This won't change behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasPercentHeightDescendant): Added.
  • rendering/RenderBlock.h: Declare hasPercentHeightDescendant().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Assert !hasPercentHeightDescendant().
01:44 Changeset [90387] by pfeldman@chromium.org

2011-07-04 Pavel Feldman <pfeldman@google.com>

Web Inspector: Enable settings screen with settings for console and elements panels.
https://bugs.webkit.org/show_bug.cgi?id=62853

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen.prototype.hide):
  • inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createRadioSetting.clickListener): (WebInspector.SettingsScreen.prototype._createRadioSetting.get for):
  • inspector/front-end/ShortcutsScreen.js: (WebInspector.ShortcutsScreen.prototype.hide):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._colorFormatSettingChanged): (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter.get var): (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
  • inspector/front-end/inspector.css: (#counters):
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._toggleSettings): (WebInspector._showShortcutsScreen): (WebInspector._hideShortcutsScreen): (WebInspector._showSettingsScreen.onhide): (WebInspector._showSettingsScreen): (WebInspector._hideSettingsScreen): (WebInspector.documentKeyDown):
01:35 Changeset [90386] by kinuko@chromium.org

2011-07-04 Kinuko Yasuda <kinuko@chromium.org>

[Chromium] LayoutTests/fast/filesystem/workers/simple-persistent-sync.html is failing on chromium worker tests
https://bugs.webkit.org/show_bug.cgi?id=63906

The expected text file needs to be updated to reflect the recent API change for adding the prefix vendor (i.e. requestFileSystem -> webkitRequestFileSystem).

Unreviewed; chromium test expectations change.

  • fast/filesystem/workers/simple-persistent-sync-expected.txt:
00:18 Changeset [90385] by commit-queue@webkit.org

2011-07-05 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

The default step is used when the step attribute of input[type='number'] is "any".
https://bugs.webkit.org/show_bug.cgi?id=57723

Changed Layout tests to use the default step when the step attribute of
input[type='number'] is "any".

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Regenerated.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:

2011-07-05 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

The default step is used when attribute step of input[type='number'] is "any".
https://bugs.webkit.org/show_bug.cgi?id=57723

When step is "any", 0 was chosen as step, but this is not intuitive.
So changed to use the default step.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::getAllowedValueStep): Calls getAllowedValueStepWithDecimalPlaces with RejectAny. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Takes a new arugument AnyStepHandling. If it is AnyIsDefaultStep, this method allows "step" attribute to take a value "any" to use the default step as step value. Otherwise, INVALID_STATE_ERR will be returned if "step" is "any". (WebCore::HTMLInputElement::applyStep): ditto. (WebCore::HTMLInputElement::stepUp): Calls applyStep with RejectAny. (WebCore::HTMLInputElement::stepDown): ditto. (WebCore::HTMLInputElement::stepUpFromRenderer): Removes a check that step is "any". It is checked in getAllowedValueStepWithDecimalPlaces.
  • html/HTMLInputElement.h:

07/04/11:

21:21 Changeset [90384] by dominicc@chromium.org

2011-07-04 Dominic Cooney <dominicc@chromium.org>

Simplify <progress> element's isDeterminate logic.
https://bugs.webkit.org/show_bug.cgi?id=63889

Reviewed by Hajime Morita.

Covered by existing tests
fast/dom/HTMLProgressElement/indeterminate-progress-*.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
  • html/HTMLProgressElement.h:
19:59 Changeset [90383] by barraclough@apple.com

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
19:19 Changeset [90382] by gyuyoung.kim@samsung.com

2011-07-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=63884

As MediaControlRootElement decides whether it will display timeline
according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
RenderThemeEfl has to implement this function.

Existing tests cover the visibility of the controls.

  • platform/efl/RenderThemeEfl.h: (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
19:18 Changeset [90381] by mihaip@chromium.org

2011-07-04 Mihai Parparita <mihaip@chromium.org>

As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
pass in Chromium, just like other platform-specific tests.

  • platform/chromium/test_expectations.txt:
18:54 Changeset [90380] by mitz@apple.com

Moved handling of frame size changes into its own method.

Reviewed by Oliver Hunt.

  • WebView/WebFrameView.mm:

(-[WebFrameView _frameSizeChanged]): Added. Moved code here...
(-[WebFrameView setFrameSize:]): ...from here.

  • WebView/WebFrameViewInternal.h:
18:27 Changeset [90379] by tkent@chromium.org

2011-07-04 Kent Tamura <tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

  • fast/forms/textfield-overflow-by-value-update.html: Added.
  • platform/chromium/test_expectations.txt: Add textfield-overflow-by-value-update.html.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.

2011-07-04 Kent Tamura <tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

Since r87067, the RenderStyle for the inner text element is reset
by the value update, but the renderer for the inner text element
keeps to have metrics calculated by the previous style. So
RenderTextControlSingleLine::layout() didn't set a desired height
to the renderer for the inner text element.

This patch changes the style creation code so that it has the
desired height initially.

Test: fast/forms/textfield-overflow-by-value-update.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Initialize m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::layout): Update m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::styleDidChange): Reset m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Sets the height if m_desiredInnerTextHeight has a concrete value.
  • rendering/RenderTextControlSingleLine.h: Declare m_desiredInnerTextHeight.
18:11 Changeset [90378] by morrita@google.com

2011-07-04 MORITA Hajime <morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
http://webkit.org/b/63798

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/shadow-root-node-list-expected.txt: Added.
  • fast/dom/shadow/shadow-root-node-list.html: Added.

2011-07-04 MORITA Hajime <morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
http://webkit.org/b/63798

The TreeScope destructor did clear the reference to TreeScope,
then the Node destructor accessing treeScope(), which results
an inconsistent state during the NodeList cache cleanup.

This change clears NodeList cache during the TreeScope destructor.
The Node destructor no longer does problematic NodeList cache
manipulation.

Test: fast/dom/shadow/shadow-root-node-list.html

Reviewed by Dimitri Glazkov.

  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::clearRareData):
  • dom/Node.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::~TreeScope):
14:30 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
14:22 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
13:29 Changeset [90377] by senorblanco@chromium.org

2011-07-04 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations change.

Mark four tests as passing on the GPU step.

  • platform/chromium/test_expectations.txt:
13:28 Changeset [90376] by vsevik@chromium.org

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
https://bugs.webkit.org/show_bug.cgi?id=63873

Reviewed by Alexey Proskuryakov.

  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
13:26 Changeset [90375] by commit-queue@webkit.org

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • Source/autotools/symbols.filter:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-embed.html: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
  • http/tests/inspector/network/network-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-embed.html: Removed.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Removed.
  • http/tests/inspector/network/resources/plugin-data.php: Removed.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Removed.
  • platform/chromium/test_expectations.txt:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::appendContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::addResourceContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged): (WebCore::NetworkResourcesData::ResourceData::textEncodingName): (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
13:17 Changeset [90374] by andersca@apple.com

Try to fix Qt build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
13:07 Changeset [90373] by vsevik@chromium.org

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • Source/autotools/symbols.filter:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-embed.html: Added.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Added.
  • http/tests/inspector/network/network-embed-expected.txt: Added.
  • http/tests/inspector/network/network-embed.html: Added.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Added.
  • http/tests/inspector/network/resources/plugin-data.php: Added.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Added.
  • platform/chromium/test_expectations.txt:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/network/network-content-replacement-embed.html

http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/network-embed.html

  • WebCore.exp.in:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::setContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::ResourceData::createDecoder): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::decoder): (WebCore::NetworkResourcesData::ResourceData::buffer): (WebCore::NetworkResourcesData::ResourceData::setBuffer): (WebCore::NetworkResourcesData::ResourceData::hasData):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentEncoded):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createEmptyView): (WebInspector.ResourcePreviewView.prototype._createPreviewView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveData): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
12:58 Changeset [90372] by andersca@apple.com

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::deleteProperty): Call NP_RemoveProperty on the NPObject.
  • WebProcess/Plugins/Netscape/JSNPObject.h: Add deleteProperty.

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Add a test. I made this Mac-WebKit2 specific for now since no other plug-in implementations support this,
and there doesn't seem to be a way to make a WebKit2 specific test.

  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript-expected.txt: Added.
  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript.html: Added.

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_IdentifierIsString): (PluginTest::NPN_UTF8FromIdentifier): (PluginTest::NPN_IntFromIdentifier): (PluginTest::NPN_RetainObject): (PluginTest::NPN_ReleaseObject):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: (PluginTest::Object::removeProperty): (PluginTest::Object::identifierIs): (PluginTest::Object::NP_RemoveProperty): (PluginTest::Object::npClass):
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: (NPRuntimeRemoveProperty::TestObject::TestObject): (NPRuntimeRemoveProperty::TestObject::hasProperty): (NPRuntimeRemoveProperty::TestObject::getProperty): (NPRuntimeRemoveProperty::TestObject::removeProperty): (NPRuntimeRemoveProperty::PluginObject::PluginObject): (NPRuntimeRemoveProperty::PluginObject::~PluginObject): (NPRuntimeRemoveProperty::PluginObject::hasMethod): (NPRuntimeRemoveProperty::PluginObject::invoke): (NPRuntimeRemoveProperty::PluginObject::hasProperty): (NPRuntimeRemoveProperty::PluginObject::getProperty): (NPRuntimeRemoveProperty::NPP_GetValue):
12:26 Changeset [90371] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63881
Need separate bytecodes for handling >, >= comparisons.

Reviewed by Oliver Hunt.

This clears the way to fix Bug#63880. We currently handle greater-than comparisons
as being using the corresponding op_less, etc opcodes. This is incorrect with
respect to evaluation ordering of the implicit conversions performed on operands -
we should be calling ToPrimitive on the LHS and RHS operands to the greater than,
but instead convert RHS then LHS.

This patch adds opcodes for greater-than comparisons mirroring existing ones used
for less-than.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_greater):
(JSC::JIT::emitSlow_op_loop_if_greater):
(JSC::JIT::emit_op_loop_if_greatereq):
(JSC::JIT::emitSlow_op_loop_if_greatereq):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitBinaryDoubleOp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • parser/NodeConstructors.h:

(JSC::GreaterNode::GreaterNode):
(JSC::GreaterEqNode::GreaterEqNode):

  • parser/Nodes.h:
11:25 Changeset [90370] by senorblanco@chromium.org

2011-07-04 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations change.


Mark two tests as failing on the GPU step.

  • platform/chromium/test_expectations.txt:
11:16 Changeset [90369] by commit-queue@webkit.org

2011-07-04 Jeff Timanus <twiz@chromium.org>

Reviewed by Stephen White.

Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
https://bugs.webkit.org/show_bug.cgi?id=63756

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
11:03 Changeset [90368] by commit-queue@webkit.org

2011-07-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] r90148 did not apply to X11 platforms in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=63862

Correct the guard for an X11 specific piece of code. TARGET(X11) not
defined for the GTK+ port.

No new tests. This is covered by an existing test.

  • plugins/npapi.cpp: Correct the X11 guard. (NPN_InvalidateRect):
08:53 Changeset [90367] by vsevik@chromium.org

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: network-preflight-options.html test is flaky.
https://bugs.webkit.org/show_bug.cgi?id=63904

Unreviewed test fix.

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:
  • platform/qt/Skipped:
08:31 Changeset [90366] by abecsi@webkit.org

2011-07-04 Andras Becsi <abecsi@webkit.org>

[Qt] http/tests/inspector/network-preflight-options.html fails frequently
https://bugs.webkit.org/show_bug.cgi?id=63910

Unreviewed.

  • platform/qt/Skipped: Skip http/tests/inspector/network-preflight-options.html.
07:48 Changeset [90365] by pfeldman@chromium.org

2011-07-04 Pavel Feldman <pfeldman@google.com>

Web Inspector: implement settings panel.
https://bugs.webkit.org/show_bug.cgi?id=63907

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction): (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype): ():
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype.hide): (WebInspector.HelpScreen.prototype._onKeyDown):
  • inspector/front-end/NetworkItemView.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.saveSidebarWidth):
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Setting): (WebInspector.Setting.prototype.addChangeListener): (WebInspector.Setting.prototype.removeChangeListener): (WebInspector.Setting.prototype.get var): (WebInspector.Setting.prototype): (WebInspector.Setting.prototype.set if):
  • inspector/front-end/SettingsScreen.js: Added. (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._appendSection): (WebInspector.SettingsScreen.prototype._columnElement): (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener): (WebInspector.SettingsScreen.prototype._createRadioSetting):
  • inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js. (WebInspector.ShortcutsScreen):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WatchExpressionsSidebarPane.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-content): (.help-close-button): (body.attached .help-close-button): (body.attached .help-content): (.help-table): (body.platform-mac .help-key): (.help-combine-keys): (.help-content p): (.help-content fieldset): (.help-content fieldset p): (.help-content p.help-section): (.help-section-title): (.help-content input[type=checkbox]):
  • inspector/front-end/inspector.css: (button.settings-status-bar-item): (.settings-status-bar-item .glyph):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._toggleAttach): (WebInspector._toggleSettings): (WebInspector._registerShortcuts): (WebInspector.documentKeyDown):
07:09 Changeset [90364] by vsevik@chromium.org

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
https://bugs.webkit.org/show_bug.cgi?id=63701

Added a test that checks mime type when resources are loaded from cache by InspectorPageAgent.

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/resource-tree/resource-tree-mimetype-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html: Added.
  • http/tests/inspector/resource-tree/resources/empty.png: Added.

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
https://bugs.webkit.org/show_bug.cgi?id=63701

Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.

Reviewed by Yury Semikhatsky.

Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype._createResource):
06:29 Changeset [90363] by bulach@chromium.org

2011-07-04 Marcus Bulach <bulach@chromium.org>

[chromium] Updates expectations for failures on svg/animations/svgtransform-animation-1.html
https://bugs.webkit.org/show_bug.cgi?id=63902

Unreviewed expectations fix.

  • platform/chromium/test_expectations.txt:
05:50 Changeset [90362] by yurys@chromium.org

2011-07-04 Yury Semikhatsky <yurys@chromium.org>

Web Inspector: repeated message counter should be aligned with other message icons
https://bugs.webkit.org/show_bug.cgi?id=63901

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css: (.console-message .bubble):
05:18 Changeset [90361] by commit-queue@webkit.org

2011-07-04 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add LayoutTestControllerEfl.
https://bugs.webkit.org/show_bug.cgi?id=61974

Only the core features are implemented. Most functions are actually
stubs and will be implemented as soon as its features are needed.
Build system changes will be made as soon as DRT is completely
upstreamed.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added. (LayoutTestController::~LayoutTestController): (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::copyDecodedHostName): (LayoutTestController::copyEncodedHostName): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::display): (LayoutTestController::counterValueForElementById): (LayoutTestController::keepWebHistory): (LayoutTestController::computedStyleIncludingVisitedInfo): (LayoutTestController::nodesFromRect): (LayoutTestController::layerTreeAsText): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages): (LayoutTestController::pageProperty): (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageSizeAndMarginsInPixels): (LayoutTestController::webHistoryItemCount): (LayoutTestController::workerThreadCount): (LayoutTestController::notifyDone): (LayoutTestController::pathToLocalResource): (LayoutTestController::queueLoad): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::addOriginAccessWhitelistEntry): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setValueForUser): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setWindowIsKey): (LayoutTestController::setSmartInsertDeleteEnabled): (waitToDumpWatchdogFired): (LayoutTestController::setWaitToDump): (LayoutTestController::windowCount): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setSpatialNavigationEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setAutofilled): (LayoutTestController::disableImageLoading): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setGeolocationPermission): (LayoutTestController::numberOfPendingGeolocationPermissionRequests): (LayoutTestController::addMockSpeechInputResult): (LayoutTestController::setIconDatabaseEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::setPluginsEnabled): (LayoutTestController::elementDoesAutoCompleteForElementWithId): (LayoutTestController::execCommand): (LayoutTestController::findString): (LayoutTestController::isCommandEnabled): (LayoutTestController::setCacheModel): (LayoutTestController::setPersistentUserStyleSheetLocation): (LayoutTestController::clearPersistentUserStyleSheet): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota): (LayoutTestController::clearApplicationCacheForOrigin): (LayoutTestController::localStorageDiskUsageForOrigin): (LayoutTestController::originsWithApplicationCache): (LayoutTestController::applicationCacheDiskUsageForOrigin): (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::syncLocalStorage): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): (LayoutTestController::setAppCacheMaximumSize): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations): (LayoutTestController::overridePreference): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::setAsynchronousSpellCheckingEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::evaluateScriptInIsolatedWorld): (LayoutTestController::removeAllVisitedLinks): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::apiTestNewWindowDataLoadBaseURL): (LayoutTestController::apiTestGoToCurrentBackForwardItem): (LayoutTestController::setWebViewEditable): (LayoutTestController::markerTextForListItem): (LayoutTestController::authenticateSession): (LayoutTestController::setEditingBehavior): (LayoutTestController::abortModal): (LayoutTestController::hasSpellingMarker): (LayoutTestController::hasGrammarMarker): (LayoutTestController::dumpConfigurationForViewport): (LayoutTestController::setSerializeHTTPLoads): (LayoutTestController::setMinimumTimerInterval): (LayoutTestController::setTextDirection): (LayoutTestController::allowRoundingHacks):
04:55 Changeset [90360] by apavlov@chromium.org

2011-07-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Adding new CSS rules should be more discoverable in the UI
https://bugs.webkit.org/show_bug.cgi?id=63803

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):
03:56 Changeset [90359] by commit-queue@webkit.org

2011-07-04 Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>

[Qt] Fixing build with --media-stream flag enabled
https://bugs.webkit.org/show_bug.cgi?id=63831

Reviewed by Benjamin Poulain.

  • features.pri: Adding support to ENABLE_MEDIA_STREAM flag.
03:07 Changeset [90358] by vsevik@chromium.org

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
02:51 Changeset [90357] by bulach@chromium.org

2011-07-04 Marcus Bulach <bulach@chromium.org>

[chromium] Rebaseline following r90338
https://bugs.webkit.org/show_bug.cgi?id=63896

Unreviewed rebaseline.

  • platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
02:36 Changeset [90356] by vsevik@chromium.org

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Update network resource url from response data.
https://bugs.webkit.org/show_bug.cgi?id=63736

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
02:20 Changeset [90355] by caseq@chromium.org

2011-07-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits.html:

2011-07-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.AuditResultImpl):
02:18 Changeset [90354] by yutak@chromium.org

2011-07-04 Yuta Kitamura <yutak@chromium.org>

WebSocket: Use jsTestIsAsync and finishJSTest() wherever possible in WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=63892

Reviewed by Kent Tamura.

Use jsTestIsAsync and finishJSTest() in WebSocket tests which are run asynchronously.
Script tags loading js-test-post-function.js must be removed, and instead js-test-post.js
must be loaded after each test.

  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html: This test is done synchronously, thus there is no need to use jsTestIsAsync and finishJSTest(). As we are moving away from js-test-post-function.js, isSuccessfullyParsed() should not be used anymore.
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/close-before-open.html:
  • http/tests/websocket/tests/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/close-on-unload.html:
  • http/tests/websocket/tests/close-unref-websocket.html:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-overflow.html: Add close tags for <body> and <html> elements which were not present for some reason.
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/reload-crash.html:
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
00:49 Changeset [90353] by kbalazs@webkit.org

2011-07-03 Balazs Kelemen <kbalazs@webkit.org>

[Qt][WK2] Remove passing tests from the qt-wk2 list
https://bugs.webkit.org/show_bug.cgi?id=63877

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-wk2/Skipped:

07/03/11:

22:59 Changeset [90352] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63879
Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.

Reviewed by Sam Weinig.

There is a lot of copy & paste code here; we can reduce duplication by making
a shared implementation.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::commute):

  • Make these function platform agnostic.
  • assembler/MacroAssemblerX86Common.h:
    • Moved branch32/commute up to MacroAssembler.
  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):

  • Add an implementation matching that for op_loop_if_less, which just calls op_jless.
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

  • Common implmentations of these methods for JSVALUE64 & JSVALUE32_64.

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE64.
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):

  • Internal implmementation of jless etc for JSVALUE32_64.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
    • Remove old implementation of emit_op_loop_if_lesseq.
22:56 Changeset [90351] by dominicc@chromium.org

2011-07-03 Dominic Cooney <dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Updates test result, and adds a test for setting value < 0.

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:

2011-07-03 Dominic Cooney <dominicc@chromium.org>

The value property of an indeterminate progress element should be zero
https://bugs.webkit.org/show_bug.cgi?id=63861

Reviewed by Kent Tamura.

Test: fast/dom/HTMLProgressElement/set-progress-properties.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::value):
22:20 Changeset [90350] by yutak@chromium.org

2011-07-03 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: pywebsocket handlers should raise exception to abort the connection
https://bugs.webkit.org/show_bug.cgi?id=63794

pywebsocket automatically sends handshake response when web_socket_do_extra_handshake()
finishes, and starts closing handshake (sends a close frame and waits for client's response)
after web_socket_transfer_data() exits. To stop this behavior, a handler must raise an
exception.

Some of our handlers send broken handshake in web_socket_do_extra_handshake(). If this handler
function exits without raising an exception, pywebsocket automatically sends another handshake
response, which is not really necessary. Normally this extra handshake message is not a problem,
because the client does not read any data beyond the end of the first (broken) handshake if
the client is working correctly. However, if the client erroneously accepts the first handshake,
it will be hard to diagnose the problem because of the extra message. The same can happen for
web_socket_transfer_data().

Generally, pywebsocket handlers should raise an exception if they do not want to send any more
data. However, this fact has been overlooked in past changes, and handlers in many tests exit
normally where they should raise an exception. This change fix these errors.

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Do not need to cycle until disconnection.
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Some ports (Chromium) intercept handshake messages and do not pass server's response to WebCore until they find the end of handshake response (i.e. "\r\n\r\n" and 16-byte data). If the handler aborts the connection without sending this end-of-response marker, entire response is ignored, which causes the test to fail.
20:54 Changeset [90349] by tkent@chromium.org

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • fast/js/number-toString-expected.txt:

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/BigInteger.h: Removed.
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToPrecision): (JSC::numberProtoFuncToString):
  • runtime/Uint16WithFraction.h: Removed.
  • wtf/MathExtras.h:

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886

Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
19:01 Changeset [90348] by dbates@webkit.org

2011-07-03 Daniel Bates <dbates@webkit.org>

Import Checkout in scm_unittests.py and logging in svn.py to fix
Python missing global variable errors

Rubber-stamped by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
  • Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
15:27 Changeset [90347] by barraclough@apple.com

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
13:34 Changeset [90346] by robert@webkit.org

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
13:22 Changeset [90345] by krit@webkit.org

2011-07-03 Dirk Schulze <krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


Test accumulate=sum on SVGAnimateTransform. The animation shouldn't start with initial value
on every repeat for accumulation.

  • svg/animations/script-tests/svgtransform-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgtransform-animation-1-expected.txt: Added.
  • svg/animations/svgtransform-animation-1.html: Added.

2011-07-03 Dirk Schulze <krit@webkit.org>

SVGAnimateTransform accumulate=sum restarts on every repeat
https://bugs.webkit.org/show_bug.cgi?id=63876

Reviewed by Nikolas Zimmermann.


We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
the first repeat, from 200% on the second and so on.

Test: svg/animations/svgtransform-animation-1.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
11:29 Changeset [90344] by commit-queue@webkit.org

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
http://trac.webkit.org/changeset/90342
https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Removed.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Removed.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Removed.
  • http/tests/navigation/scrollstate-after-location-reload.html: Removed.

2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90342.
http://trac.webkit.org/changeset/90342
https://bugs.webkit.org/show_bug.cgi?id=63875

Newly added tests fail on Mac, GTK, and Win7 (Requested by
abarth on #webkit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
  • loader/NavigationScheduler.cpp:
10:42 Changeset [90343] by robert@webkit.org

2011-07-03 Robert Hogan <robert@webkit.org>

Skip Qt platform-specific test after r90341
https://bugs.webkit.org/show_bug.cgi?id=45455

Unreviewed, skip test.

The Skipped list needs the platform-specific path of the test.

  • platform/qt/Skipped:
10:27 Changeset [90342] by robert@webkit.org

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

  • http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
  • http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
  • http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
  • http/tests/navigation/scrollstate-after-location-reload.html: Added.

2011-07-03 Robert Hogan <robert@webkit.org>

Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482

If a <meta http-equiv="refresh"> directive schedules a page reload rather than
a redirect restore the scroll position after the reload. Do the same on location.reload().

Reviewed by Adam Barth.

Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html

http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
http/tests/navigation/scrollstate-after-http-equiv-refresh.html
http/tests/navigation/scrollstate-after-location-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*. FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload() and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading the same page again, e.g. by clicking a link.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
10:14 Changeset [90341] by robert@webkit.org

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

Add a new test and move third-party cookie tests to 'pending
unskipping' for when bots move to 4.8.

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

https://bugs.webkit.org/show_bug.cgi?id=45455

  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html: Added.
  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking-expected.txt: Added. This test is a stricter version of third-party-cookie-relaxing.html with the expected behaviour that all third-party cookies are blocked.
  • platform/qt/Skipped: Prepare tests for unskipping on Qt-4.8.
  • platform/qt/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added. Qt returns cookie lists in a different order from other ports.

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

Identifying third-party cookies is facilitated by API new to QUrl from
Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
list to determine the top-level registry-controlled domain of the Url.

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

Test: http/tests/cookies/strict-third-party-cookie-blocking.html

  • WebCore.pro:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/qt/ThirdPartyCookiesQt.cpp: Added. (WebCore::cookieJar): (WebCore::isFirstPartyCookie): (WebCore::cookieAllowed): (WebCore::allowThirdPartyCookies):
  • platform/qt/ThirdPartyCookiesQt.h: Added.

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients

This adds new API to QWebSettings that allows clients to
select one of three third-party cookie blocking policies:

AlwaysAllowThirdPartyCookies
AlwaysBlockThirdPartyCookies
AllowThirdPartyWithExistingCookies

The first two are self-explanatory, the third mimics Safari's
default behaviour of permitting third-party cookies when the user
already has cookies from the third-party site. This was
introduced to allow third-party cookie blocking to play well with
facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.

There is scope for adding an 'exceptions' list API and clients would
struggle to implement it themselves given the paucity of information
available from setCookiesForUrl().

See also: http://gitorious.org/qt/qt/merge_requests/1205

(commit 154402f56dcf8303a6ce601a52215226af8d31ba)

http://bugreports.qt.nokia.com/browse/QTBUG-13601

https://bugs.webkit.org/show_bug.cgi?id=45455

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setThirdPartyCookiePolicy): (QWebSettings::thirdPartyCookiePolicy):
  • Api/qwebsettings.h:

2011-04-02 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setAlwaysBlockCookies):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
08:58 Changeset [90340] by vsevik@chromium.org

2011-07-03 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
https://bugs.webkit.org/show_bug.cgi?id=63712

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:

2011-07-03 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
https://bugs.webkit.org/show_bug.cgi?id=63712

Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
08:51 Changeset [90339] by robert@webkit.org

2011-07-03 Robert Hogan <robert@webkit.org>

Add platform-specific results after r90338

Unreviewed, add platform-specific results for new rendertree test.
https://bugs.webkit.org/show_bug.cgi?id=30355

http://trac.webkit.org/changeset/90338

  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
08:04 Changeset [90338] by robert@webkit.org

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

Unfortunately this has to be a rendertree test, as there is no rendertext way of
determining if a selection is still highlighted.

  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • plugins/mouse-click-plugin-clears-selection.html: Added.

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

Test: plugins/mouse-click-plugin-clears-selection.html

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebCore.exp.in: Add symbol for FocusController::setFocusedNode
  • plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
redundant, since it calls both.

2011-06-23 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355

PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).

  • WebProcess/Plugins/PluginView.cpp: (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes

the call to FocusController:setFocusedFrame() redundant, since the
former calls it.

04:09 Changeset [90337] by abarth@webkit.org

2011-07-03 Adam Barth <abarth@webkit.org>

Factor ReflectionHandler out of the rebaseline server. Just code motion.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
03:45 Changeset [90336] by abarth@webkit.org

2011-07-03 Adam Barth <abarth@webkit.org>

Move the rebaseline server out of the commands package and into the
(new) servers package. This patch prepares for refactoring this code
to share server infrastructure with the (forthcoming) garden-o-matic
command.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/init.py: Added.
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.

07/02/11:

21:02 Changeset [90335] by mihaip@chromium.org

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Remove failing expectation for fast/events/panScroll-click-hyperlink.html
(Chromium still doesn't pass the test, since it doesn't have pan
scrolling enabled, but r90235 added failing expectations for the Windows
port, which Chromium Win and Linux pick up)

Also remove flaky expectations for some tests that have not failed as
far back as the flakiness dashboard has data for.

  • platform/chromium/test_expectations.txt:
19:26 Changeset [90334] by mjs@apple.com

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Update SunSpider versioning to 1.0
https://bugs.webkit.org/show_bug.cgi?id=63870

Reviewed by Dan Bernstein.

  • hosted/sunspider.html:
  • hosted/versions.html:
  • resources/driver-TEMPLATE.html:
  • resources/results-TEMPLATE.html:
  • sunspider:
18:35 Changeset [90333] by mjs@apple.com

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Sunspider 0.9.1 harness doesn't actually close() its test documents
https://bugs.webkit.org/show_bug.cgi?id=47045

Reviewed by Daniel Bates.

  • hosted/versions.html:
  • resources/driver-TEMPLATE.html:
18:19 Changeset [90332] by andersca@apple.com

Have another go at fixing the Windows build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

18:15 Changeset [90331] by andersca@apple.com

2011-07-02 Anders Carlsson <andersca@apple.com>

Null out the plug-in controller after destroying the plug-in.
https://bugs.webkit.org/show_bug.cgi?id=63869

Reviewed by Maciej Stachowiak.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::destroy): Call destroyPlugin.
  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::destroyPlugin): Call destroy and null out the plug-in controller.
  • WebProcess/Plugins/Plugin.h: Add destroyPlugin, make destroy private.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Call destroyPlugin.
17:57 Changeset [90330] by andersca@apple.com

Update skipped list.

  • platform/wk2/Skipped:
17:51 Changeset [90329] by andersca@apple.com

Fix Windows build for real.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):

16:55 Changeset [90328] by andersca@apple.com

2011-07-02 Anders Carlsson <andersca@apple.com>

Implement NPN_PluginThreadAsyncCall
https://bugs.webkit.org/show_bug.cgi?id=63868

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PluginThreadAsyncCall): Call NetscapePlugin::pluginThreadAsyncCall.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginThreadAsyncCall): Schedule a work item to call the function on the main run loop.

(WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
If the plug-in is still running, run the function.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Add new member function.
  • WebProcess/Plugins/Plugin.h: Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially ref the plug-in from other threads.
16:41 Changeset [90327] by andersca@apple.com

Fix Windows build.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

16:40 Changeset [90326] by andersca@apple.com

2011-07-02 Anders Carlsson <andersca@apple.com>

Move the plug-in controller member variable up to the shared Plugin base class
https://bugs.webkit.org/show_bug.cgi?id=63867

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Remove m_pluginController.

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::userAgent):
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::setStatusbarText):
(WebKit::NetscapePlugin::evaluate):
(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
(WebKit::NetscapePlugin::tryToShortCircuitInvoke):
(WebKit::NetscapePlugin::cancelStreamLoad):
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
(WebKit::NetscapePlugin::getAuthenticationInfo):
Use controller() instead of m_pluginController.

(WebKit::NetscapePlugin::initialize):
This doesn't take a PluginController parameter anymore.

(WebKit::NetscapePlugin::destroy):
No need to null out the plug-in controller.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Remove m_pluginController member variable.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::windowFocusChanged): Use controller() instead of m_pluginController.


  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Plugin): Initialize m_pluginController.

(WebKit::Plugin::initialize):
New function that initializes the plug-in controller and then calls the real
virtual initialize member function.

  • WebProcess/Plugins/Plugin.h: Add m_pluginController member variable and a new initialize virtual member function that doesn't take a PluginController parameter. Make the "old" initialize member function set up the plug-in controller.

(WebKit::Plugin::controller):
This is now a simple getter.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::PluginProxy): Remove m_pluginController.

(WebKit::PluginProxy::pluginProcessCrashed):
Use controller(), remove a bogus null check.

(WebKit::PluginProxy::initialize):
This doesn't take a PluginController parameter now.

(WebKit::PluginProxy::destroy):
No need to null out the plug-in controller member variable.

(WebKit::PluginProxy::loadURL):
(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
(WebKit::PluginProxy::getAuthenticationInfo):
(WebKit::PluginProxy::windowNPObjectID):
(WebKit::PluginProxy::getPluginElementNPObject):
(WebKit::PluginProxy::evaluate):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):
(WebKit::PluginProxy::setComplexTextInputEnabled):
(WebKit::PluginProxy::update):
Use controller() instead of m_pluginController.


  • WebProcess/Plugins/PluginProxy.h: Remove m_pluginController.
16:20 Changeset [90325] by mihaip@chromium.org

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Remove Chromium Leopard failing expectations for two tests (fast/dom/
HTMLMeterElement/meter-writing-mode.html and fast/images/
imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.

  • platform/chromium/test_expectations.txt:
16:08 Changeset [90324] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof

Reviewed by Sam Weinig.

Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jitAssertIsCell):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::jitAssertIsCell):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:59 Changeset [90323] by mihaip@chromium.org

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Meant to actually remove expectations in r90322, not just comment them
out.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [90322] by mihaip@chromium.org

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
since the regular Mac baselines can't be used due to single-pixel
differences in character rendering (presumably caused by 32-bit vs.
64-bit binaries).

  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:12 Changeset [90321] by mjs@apple.com

Not Reviewed.

Fix obviou typo in previous commit.

  • tests/sunspider-1.0/bitops-bitwise-and.js:
14:11 Changeset [90320] by mihaip@chromium.org

2011-07-02 Mihai Parparita <mihaip@chromium.org>

Chromium expectations update:

  • Add failing expectation for fast/css/last-of-type-pseudo-class.html, which fails in debug only.
  • Remove Chromium-specific baselines for fast/js/reserved-words.html, the test now passes with the regular baselines.
  • platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
  • platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:09 Changeset [90319] by mjs@apple.com

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

SunSpider: all four bitops benchmarks can be replaced with NOP
https://bugs.webkit.org/show_bug.cgi?id=38446

  • tests/sunspider-1.0/bitops-3bit-bits-in-byte.js: (TimeFunc): Save the result.
  • tests/sunspider-1.0/bitops-bits-in-byte.js: (TimeFunc): Save the result.
  • tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly save the results.
  • tests/sunspider-1.0/bitops-nsieve-bits.js: (sieve): Save the result.
13:57 Changeset [90318] by mjs@apple.com

2011-07-02 Maciej Stachowiak <mjs@apple.com>

SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
https://bugs.webkit.org/show_bug.cgi?id=60937

Reviewed by Dan Bernstein.

  • tests/sunspider-1.0/string-validate-input.js: (doTest): Rename the variable to username
13:45 Changeset [90317] by mjs@apple.com

2011-07-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

SunSpider: The main function of math-cordic is dead code
https://bugs.webkit.org/show_bug.cgi?id=63863


Try to prevent math-cordic from being eliminated as dead code or
compiled down to a constant.

  • tests/sunspider-1.0/math-cordic.js: (cordicsincos): (cordic):
10:26 Changeset [90316] by mrowe@apple.com

Update the header file too.

  • WebKitSystemInterface.h:
09:25 Changeset [90315] by mrowe@apple.com

Update WebKitSystemInterface binaries.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a: Added.
  • libWebKitSystemInterfaceSnowLeopard.a:
03:46 Changeset [90314] by tkent@chromium.org

[GTK] Update expectation of fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=49245

  • platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt:

07/01/11:

23:00 Changeset [90313] by tkent@chromium.org

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733

Also, input-file-label.html passes now.

  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Rebaseline for fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=63733

  • DEPS: Update chromium revision to 91405 to have "Choose Files" string.
21:47 Changeset [90312] by tkent@chromium.org

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Update the expectation of search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787

  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium/test_expectations.txt:
21:45 Changeset [90311] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Remove GTK baseline added in r90294 since the test was fixed in r90309.
(File name was wrong. It was supposed to be -expected.txt)

  • platform/gtk/editing/selection/directionality-after-undo-replace.html: Removed.
19:38 Changeset [90310] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Fix typo in master.cfg, hoping to trigger a master restart.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
19:34 Changeset [90309] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

[GTK] editing/selection/directionality-after-undo-replace.html is failing
https://bugs.webkit.org/show_bug.cgi?id=63853

Reviewed by Ojan Vafai.

Don't do leapForward between mouseDown and mouseUp so that GTK recognizes the double-click.

  • editing/selection/directionality-after-undo-replace.html:
19:20 Changeset [90308] by michaeln@google.com

2011-07-01 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] FileSystem API can be used to learn about installed software on the user's computer
https://bugs.webkit.org/show_bug.cgi?id=63220

  • public/WebMimeRegistry.h: (WebKit::WebMimeRegistry::wellKnownMimeTypeForExtension):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::wellKnownMimeTypeForExtension):

2011-07-01 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] FileSystem API can be used to learn about installed software on the user's computer.
Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
without consulting the OS/registry.
https://bugs.webkit.org/show_bug.cgi?id=63220

No new tests, existing layout tests that invoke file.type apply.

  • fileapi/File.cpp: Refactored the factory methods. (WebCore::createBlobDataForFileWithType): (WebCore::createBlobDataForFile): (WebCore::createBlobDataForFileSystemFile): (WebCore::File::File):
  • platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::mediaMIMETypeMap): (WebCore::findMimeType): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
  • platform/MIMETypeRegistry.h:
  • platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): (WebCore::findMimeType):
  • platform/chromium/PlatformBridge.h:
18:05 Changeset [90307] by commit-queue@webkit.org

2011-07-01 Tim Horton <timothy_horton@apple.com>

Reviewed by Darin Adler.

SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
https://bugs.webkit.org/show_bug.cgi?id=54325

Add image/svg+xml to the list of acceptable MIME types for the Image type.

17:55 Changeset [90306] by tkent@chromium.org

2011-07-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

Use common functions in fast/forms/search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787

  • fast/forms/search-rtl.html: Use searchCancelButtonPosition() to make this work on Chromium Windows and Chromium Linux.
  • platform/chromium/test_expectations.txt:
17:45 Changeset [90305] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Turn off new-run-webkit-tests and remove some debug logging.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
17:43 Changeset [90304] by commit-queue@webkit.org

2011-07-01 Tim Horton <timothy_horton@apple.com>

Reviewed by Darin Adler.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599

Add SVGElement::reportAttributeParsingError, which will
write a Web Inspector console message if passed an SVGParsingError
and the attribute which was being applied, only in the case where
there is actually an error.

Include the SVG document's URI when writing to the Web Inspector
console, so that the UI displays both the filename and the line number.

  • svg/SVGDocumentExtensions.cpp: (WebCore::reportMessage):
  • svg/SVGElement.cpp: (WebCore::SVGElement::reportAttributeParsingError):
  • svg/SVGElement.h:
17:26 Changeset [90303] by commit-queue@webkit.org

2011-07-01 Scott Byer <scottbyer@chromium.org>

Reviewed by Adam Barth.

Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770

Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace

Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.

  • platform/ScrollAnimatorNone.cpp: (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters): (WebCore::ScrollAnimatorNone::scroll):

2011-07-01 Scott Byer <scottbyer@chromium.org>

Reviewed by Adam Barth.

Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770

Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.

  • tests/ScrollAnimatorNoneTest.cpp: (ScrollAnimatorNoneTest::updateDataFromParameters): (TEST_F):
17:16 Changeset [90302] by leviw@chromium.org

2011-07-01 Levi Weintraub <leviw@chromium.org>

Switch primary virtual layout functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63852

Reviewed by Eric Seidel.

Switching the primary overloaded layout functions over to the new layout unit abstraction.

No new tests, no functionality changes.

  • html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::layout):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
  • rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::layout):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/RenderView.cpp: (WebCore::RenderView::layout):
  • rendering/RenderView.h: (WebCore::RenderView::layoutDelta): (WebCore::RenderView::addLayoutDelta):
  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout):
  • rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::layout):
  • rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::layout):
  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::layout):
  • rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout):
17:09 Changeset [90301] by weinig@apple.com

2011-07-01 Sam Weinig <sam@webkit.org>

Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856

Reviewed by Dan Bernstein.

Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
the nesting cap to 512 to cover more cases where rending recursion was biting us.

  • page/Settings.h: Reduce the nesting cap to 512.

2011-07-01 Sam Weinig <sam@webkit.org>

Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856

Update test for new cap.

  • fast/parser/block-nesting-cap-expected.txt:
  • fast/parser/script-tests/block-nesting-cap.js:
17:09 Changeset [90300] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Add some more debug logging to try to understand why we're getting
stuck acquring the HTTP lock.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
17:05 Changeset [90299] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=63855

Reviewed by Ryosuke Niwa.

Allow a trailing whitespace in the expected result, since Windows
has different word iterating behavior.

  • editing/selection/directionality-after-undo-replace.html:
16:45 Changeset [90298] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
16:41 Changeset [90297] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Remove Chromium Windows 7 and Vista media test expectations, since
clobbering the bots appears to have fixed the timeouts and failures.

  • platform/chromium/test_expectations.txt:
16:30 Changeset [90296] by lforschler@apple.com

Versioning

16:24 Changeset [90295] by darin@apple.com

Add change accidentally left out of last commit.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
backing scale.

16:19 Changeset [90294] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853.

  • platform/gtk/editing/selection/after-line-break-expected.txt: Added.
  • platform/gtk/editing/selection/directionality-after-undo-replace.html: Added.
16:13 Changeset [90293] by darin@apple.com

2011-07-01 Darin Adler <darin@apple.com>

Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848

Reviewed by Simon Fraser.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::clampedContentsScaleForScale): Increased the maximum scale since scale factor can now include both page contents scale and backing scale.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the backing scale as well as the page contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageContentsScale): Added. (WebCore::RenderLayerBacking::backingScale): Added.
  • rendering/RenderLayerBacking.h: Added new private functions.

2011-07-01 Darin Adler <darin@apple.com>

Consider backing scale factor when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848

Reviewed by Simon Fraser.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): Set contents scale on the non-composited content layer based on the backing scale factor. (WebKit::LayerTreeHostCA::createPageOverlayLayer): Set contents scale on the page overlay layer based on the backing scale factor.
16:09 Changeset [90292] by japhet@chromium.org

2011-07-01 Nate Chapin <japhet@chromium.org>

Unreviewed, remove extraneous newlines from
expected results for fast/workers/worker-finish-crash.html.

  • fast/workers/worker-finish-crash-expected.txt:
16:06 Changeset [90291] by darin@apple.com

The commit-bot checked in files without Subversion properties, so adding them now.

  • fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added property svn:eol-style.
  • fast/loader/create-frame-in-DOMContentLoaded.html: Added properties svn:mime-type and svn:eol-style.
16:02 Changeset [90290] by adele@apple.com

../WebCore: WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body

Reviewed by Darin Adler.

No new tests. I tried to make a test in DumpRenderTree with an editable WebView,
but was unsuccessful in getting the crash to happen in that instance.

  • editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT.

../WebKit/mac: WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
<rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body

Reviewed by Darin Adler.

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
space, and after-white-space properties to subframes in the editable document.

15:43 Changeset [90289] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner.

  • platform/wk2/Skipped:
15:31 Changeset [90288] by leviw@chromium.org

2011-07-01 Levi Weintraub <leviw@chromium.org>

Switch overflow and collapsedMargins to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63840

Reviewed by Eric Seidel.

Switching overflow and collapsedMargins over to the new layout unit abstraction.

Also removing an unused function: blockDirectionOverflow

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapsedMarginBeforeForChild): (WebCore::RenderBlock::collapsedMarginAfterForChild):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::collapsedMarginBefore): (WebCore::RenderBlock::collapsedMarginAfter):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
  • rendering/RenderBox.h: (WebCore::RenderBox::layoutOverflowRect): (WebCore::RenderBox::minYLayoutOverflow): (WebCore::RenderBox::maxYLayoutOverflow): (WebCore::RenderBox::minXLayoutOverflow): (WebCore::RenderBox::maxXLayoutOverflow): (WebCore::RenderBox::maxLayoutOverflow): (WebCore::RenderBox::logicalLeftLayoutOverflow): (WebCore::RenderBox::logicalRightLayoutOverflow): (WebCore::RenderBox::visualOverflowRect): (WebCore::RenderBox::minYVisualOverflow): (WebCore::RenderBox::maxYVisualOverflow): (WebCore::RenderBox::minXVisualOverflow): (WebCore::RenderBox::maxXVisualOverflow): (WebCore::RenderBox::logicalLeftVisualOverflow): (WebCore::RenderBox::logicalRightVisualOverflow): (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::collapsedMarginBefore): (WebCore::RenderBox::collapsedMarginAfter):
  • rendering/RenderOverflow.h: (WebCore::RenderOverflow::RenderOverflow): (WebCore::RenderOverflow::minYLayoutOverflow): (WebCore::RenderOverflow::maxYLayoutOverflow): (WebCore::RenderOverflow::minXLayoutOverflow): (WebCore::RenderOverflow::maxXLayoutOverflow): (WebCore::RenderOverflow::minYVisualOverflow): (WebCore::RenderOverflow::maxYVisualOverflow): (WebCore::RenderOverflow::minXVisualOverflow): (WebCore::RenderOverflow::maxXVisualOverflow): (WebCore::RenderOverflow::setMinYLayoutOverflow): (WebCore::RenderOverflow::setMaxYLayoutOverflow): (WebCore::RenderOverflow::setMinXLayoutOverflow): (WebCore::RenderOverflow::setMaxXLayoutOverflow): (WebCore::RenderOverflow::setMinYVisualOverflow): (WebCore::RenderOverflow::setMaxYVisualOverflow): (WebCore::RenderOverflow::setMinXVisualOverflow): (WebCore::RenderOverflow::setMaxXVisualOverflow): (WebCore::RenderOverflow::layoutOverflowRect): (WebCore::RenderOverflow::visualOverflowRect): (WebCore::RenderOverflow::move): (WebCore::RenderOverflow::addLayoutOverflow): (WebCore::RenderOverflow::addVisualOverflow): (WebCore::RenderOverflow::setLayoutOverflow): (WebCore::RenderOverflow::setVisualOverflow): (WebCore::RenderOverflow::resetLayoutOverflow):
15:30 Changeset [90287] by hans@chromium.org

2011-07-01 Hans Wennborg <hans@chromium.org>

IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817

Reviewed by Tony Chang.

Disable IndexedDB quota teset since quota enforcement is not yet
supported by the LevelDB back-end.

  • platform/chromium/test_expectations.txt:

2011-07-01 Hans Wennborg <hans@chromium.org>

IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817

Reviewed by Tony Chang.

Use LevelDB as the default back-end.

Covered by existing layout tests for indexeddb, which will now be
using the LevelDB back-end.

  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
15:25 Changeset [90286] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
(r90261 added a Leopard expectation for the Mac port, but Chromium
Leopard can pass with the default baseline).

  • platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
15:11 Changeset [90285] by eric@webkit.org

2011-07-01 Eric Seidel <eric@webkit.org>

new-run-webkit-tests results does not understand that mac uses test_expectations files
https://bugs.webkit.org/show_bug.cgi?id=63838

Reviewed by Adam Barth.

We've decided to "enable" test_expectations for the Mac port for now.
It makes the results.html results much more confusing to read, but at least they're
no longer lying to us.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
15:06 Changeset [90284] by japhet@chromium.org

2011-07-01 Nate Chapin <japhet@chromium.org>

Test for https://bugs.webkit.org/show_bug.cgi?id=63835.

Reviewed by Dmitry Titov.

  • fast/workers/worker-finish-crash-expected.txt: Added.
  • fast/workers/worker-finish-crash.html: Added.

2011-07-01 Nate Chapin <japhet@chromium.org>

Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
https://bugs.webkit.org/show_bug.cgi?id=63835

Reviewed by Dmitry Titov.

Test: fast/workers/worker-finish-crash.html

  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::notifyFinished):
  • workers/WorkerScriptLoader.h:
15:04 Changeset [90283] by enne@google.com

2011-07-01 Adrienne Walker <enne@google.com>

[chromium] Upload root layer textures first so that it is less likely to be skipped
https://bugs.webkit.org/show_bug.cgi?id=63850

Reviewed by James Robinson.

This is a tiny follow-on patch to bug 63760. If the root layer is not
uploaded first, then it may not have enough space to fit into texture
memory and might be skipped, leaving a blue background.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
15:02 Changeset [90282] by oliver@apple.com

2011-07-01 Oliver Hunt <oliver@apple.com>

IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=63732

Reviewed by Gavin Barraclough.

Initialise the memory at the head of the new storage so that
GC is safe if triggered by reportExtraMemoryCost.

  • runtime/JSArray.cpp: (JSC::JSArray::increaseVectorPrefixLength):
15:02 Changeset [90281] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

  • fast/history/location-replace-hash-expected.txt: Added.
  • fast/history/location-replace-hash.html: Added.
  • fast/history/resources/location-replace-hash-1.html: Added.
  • fast/history/resources/location-replace-hash-2.html: Added.

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

location.replace('#foo') would not update the HistoryItem with the
new URL, thus navigating back to the page would use the previous
URL, even though it had been replaced. Make
HistoryController::updateForSameDocumentNavigation mirror
HistoryController::replaceState.

Test: fast/history/location-replace-hash.html

  • loader/HistoryController.cpp: (WebCore::HistoryController::updateForSameDocumentNavigation):
15:01 Changeset [90280] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Fix expected results after r90275. I checked in Mac-specific results for these tests.
Move them to platform/mac and revert the changes in platform-independent results.
Also copy results to platform/win because they fallback to Mac by default.

  • editing/deleting/delete-br-011-expected.txt:
  • editing/selection/anchor-focus2-expected.txt:
  • editing/selection/anchor-focus3-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
  • platform/mac/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
  • platform/mac/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
  • platform/win/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt.
  • platform/win/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt.
  • platform/win/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt.
14:47 Changeset [90279] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Temporarily disable waiting for ReportCrash to see how this code
affects performance on the bots.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
14:44 Changeset [90278] by commit-queue@webkit.org

2011-07-01 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=63818
Test bots shouldn't attempt to build TestWebKitAPI on Windows.
TestWebKitAPI builds as a part of general webkit build and is a
part of build products archive.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-api-tests:
14:21 Changeset [90277] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837

Reviewed by Eric Seidel.

Instead, we should move this check to worker.py.

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
14:09 Changeset [90276] by commit-queue@webkit.org

2011-07-01 Jade Han <jade.han@nokia.com>

[Qt][Symbian] Update .def file for Symbian to build Tools
https://bugs.webkit.org/show_bug.cgi?id=61200

Reviewed by Laszlo Gombos.

Add newly introduced symbols to fix building the Tools directory for Symbian.

  • symbian/eabi/QtWebKitu.def:
14:07 Changeset [90275] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Added a test to ensure WebKit preserves non-directional selection after undo on Mac.

The directionality of selection is still lost after undoing DeleteSelectionCommand or TypingCommand
and this will be fixed in follow up patches.

  • editing/deleting/delete-br-011-expected.txt:
  • editing/selection/after-line-break-expected.txt:
  • editing/selection/anchor-focus2-expected.txt:
  • editing/selection/anchor-focus3-expected.txt:
  • editing/selection/directionality-after-undo-replace-expected.txt: Added.
  • editing/selection/directionality-after-undo-replace.html: Added.
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-01-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-02-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/fake-drag-expected.txt:
  • platform/mac/editing/selection/move-by-word-001-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Don't pass MakeNonDirectionalSelection to setSelection since no other port does this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectRange):

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Move m_isDirectional from FrameSelection to VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=63473

Move m_isDirectional from FrameSelection to VisibleSelection.

Also fixed a bug that WebKit does not preserve non-directional selection after undo.

Test: editing/selection/directionality-after-undo-replace.html

  • WebCore.exp.in: Updated the signature of setSelection.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional. (WebCore::shouldAlwaysUseDirectionalSelection): Added. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy. Calls setIsDirectional(true) when the platform doesn't support non-directional selection. Passes align and granularity to setSelection of the base end point as expected. No longer updates granularity when updating the selection of a different frame. (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional(). (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional because the directionality is passed from m_selection automatically. Also calls shouldAlwaysUseDirectionalSelection.
  • editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields. (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true. This should be changed to false to fix the bug 60529.
  • editing/VisibleSelection.h: (WebCore::VisibleSelection::isDirectional): Added. (WebCore::VisibleSelection::setIsDirectional): Added.
  • page/EventHandler.cpp: (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of calling setSelection with MakeNonDirectionalSelection. (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional because it already calls setNonDirectionalSelectionIfNeeded.
13:52 Changeset [90274] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add more Chromium flaky expectations.

  • platform/chromium/test_expectations.txt:
13:45 Changeset [90273] by oliver@apple.com

2011-07-01 Oliver Hunt <oliver@apple.com>

GC sweep can occur before an object is completely initialised
https://bugs.webkit.org/show_bug.cgi?id=63836

Reviewed by Gavin Barraclough.

In rare cases it's possible for a GC sweep to occur while a
live, but not completely initialised object is on the stack.
In such a case we may incorrectly choose to mark it, even
though it has no children that need marking.

We resolve this by always zeroing out the structure of any
value returned from JSCell::operator new(), and making the
markstack tolerant of a null structure.

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell): (JSC::JSCell::JSCell::operator new):
  • runtime/Structure.h: (JSC::MarkStack::internalAppend):
13:42 Changeset [90272] by lforschler@apple.com

Merge 90223.

13:29 Changeset [90271] by tony@chromium.org

2011-07-01 Tony Chang <tony@chromium.org>

cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=63827

Reviewed by Ojan Vafai.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::boxAlign): (WebCore::InheritedFlags::boxFlex): (WebCore::InheritedFlags::boxFlexGroup): (WebCore::InheritedFlags::boxLines): (WebCore::InheritedFlags::boxOrdinalGroup): (WebCore::InheritedFlags::boxOrient): (WebCore::InheritedFlags::boxPack): (WebCore::InheritedFlags::marqueeIncrement): (WebCore::InheritedFlags::marqueeSpeed): (WebCore::InheritedFlags::marqueeLoopCount): (WebCore::InheritedFlags::marqueeBehavior): (WebCore::InheritedFlags::marqueeDirection): (WebCore::InheritedFlags::setBoxAlign): (WebCore::InheritedFlags::setBoxFlex): (WebCore::InheritedFlags::setBoxFlexGroup): (WebCore::InheritedFlags::setBoxLines): (WebCore::InheritedFlags::setBoxOrdinalGroup): (WebCore::InheritedFlags::setBoxOrient): (WebCore::InheritedFlags::setBoxPack): (WebCore::InheritedFlags::setMarqueeIncrement): (WebCore::InheritedFlags::setMarqueeSpeed): (WebCore::InheritedFlags::setMarqueeDirection): (WebCore::InheritedFlags::setMarqueeBehavior): (WebCore::InheritedFlags::setMarqueeLoopCount):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:

flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee

13:27 Changeset [90270] by commit-queue@webkit.org

2011-07-01 Mike Reed <reed@google.com>

Stop using deprecated SkDeviceFactory API
https://bugs.webkit.org/show_bug.cgi?id=63488

Reviewed by James Robinson.

No new tests. Check-point for removing Factory API from Skia

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
13:08 Changeset [90269] by commit-queue@webkit.org

2011-07-01 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Adam Barth.

Move XMLDocumentParser to new folder xml/parser/
https://bugs.webkit.org/show_bug.cgi?id=63666

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::insert): (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::detach): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::XMLDocumentParser::finishWasCalled): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing): (WebCore::XMLDocumentParser::parseDocumentFragment):
  • xml/parser/XMLDocumentParser.h: (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::create): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
  • xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::create): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::switchToUTF16): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getParser): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
  • xml/parser/XMLDocumentParserQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::supportsXMLVersion): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::XMLDocumentParser::appendFragmentSource): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
  • xml/parser/XMLDocumentParserScope.cpp: (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
13:04 Changeset [90268] by commit-queue@webkit.org

2011-07-01 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT always performs slow C calls for div and mod.
https://bugs.webkit.org/show_bug.cgi?id=63684

  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
12:54 Changeset [90267] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add more failing test expectations for Chromium media tests on Windows 7
and Vista.

  • platform/chromium/test_expectations.txt:
12:49 Changeset [90266] by tony@chromium.org

2011-07-01 Tony Chang <tony@chromium.org>

Add chromium sql directory to git ignore.

  • .gitignore:
12:47 Changeset [90265] by commit-queue@webkit.org

2011-07-01 Juan C. Montemayor <jmont@apple.com>

Reviewed by Oliver Hunt.

Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340

Updated expected test results.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/kde/parse-expected.txt:
  • fast/js/kde/string-1-n-expected.txt:
  • fast/js/kde/string-2-n-expected.txt:
  • fast/js/numeric-escapes-in-string-literals-expected.txt:
  • fast/js/removing-Cf-characters-expected.txt:
  • fast/regex/non-pattern-characters-expected.txt:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • loader/reload-subresource-when-type-changes-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.1_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T2-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T1-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T2-expected.txt:

2011-07-01 Juan C. Montemayor <jmont@apple.com>

Reviewed by Oliver Hunt.

Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340

Added error messages for the Lexer. These messages will be displayed
instead of the lexer error messages from the parser that are currently
shown.

  • parser/Lexer.cpp: (JSC::Lexer::getInvalidCharMessage): (JSC::Lexer::setCode): (JSC::Lexer::parseString): (JSC::Lexer::lex): (JSC::Lexer::clear):
  • parser/Lexer.h: (JSC::Lexer::getErrorMessage): (JSC::Lexer::setOffset):
  • parser/Parser.cpp: (JSC::Parser::parse):
12:39 Changeset [90264] by aroben@apple.com

Stop setting unsafe headers on POSTs via XHR from TestFailures page

Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
Inspector's console about unsafe headers

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(fetchResource): Removed unnecessary code to set Content-Length and Connection headers.

12:36 Changeset [90263] by abarth@webkit.org

2011-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786

We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.

If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).

  • Scripts/run-webkit-tests:
12:33 Changeset [90262] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Add a compat shim for --leaks. Support for --leaks will be added in
https://bugs.webkit.org/show_bug.cgi?id=63832.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:25 Changeset [90261] by aroben@apple.com

Add Leopard expected failure result for media/media-blocked-by-beforeload.html

The failure is tracked by <http://webkit.org/b/63829>.

  • platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
12:24 Changeset [90260] by vangelis@chromium.org

2011-07-01 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Reserve all tile textures at layer update time to guarantee
that they will be available at draw time.
https://bugs.webkit.org/show_bug.cgi?id=63760

In addition, this patch unreserves textures used by RenderSurface's
right after the RenderSurface has been used to free up memory for
subsequent RenderSurfaces.

This patch also "fixes" the pages that display a blue background when
running out of texture memory as the root layer tiles get reserved first
and are guaranteed to get textures.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::setIsMask):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::unreserve):
  • platform/graphics/chromium/LayerTexture.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::drawTiles):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::releaseContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectTexture):
  • platform/graphics/chromium/TextureManager.h:
12:23 Changeset [90259] by jshin@chromium.org

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)

http://bugs.webkit.org/show_bug.cgi?id=20797

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • icu/unicode/uscript.h: Added for UScriptCode enum.
  • wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/brew/UnicodeBrew.h:
  • wtf/unicode/glib/UnicodeGLib.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWinCE.h:

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Add uscript.h to icu/unicode to get JavaScriptGlue get built. The same
file was added to JavaScriptCore/icu/unicode.

http://bugs.webkit.org/show_bug.cgi?id=20797

  • icu/unicode/uscript.h: Added.

2011-07-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

Allow generic font family settings per script code.
https://bugs.webkit.org/show_bug.cgi?id=20797

Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.

uscript.h has been updated to that of ICU 3.6 (the version of ICU on
Mac OS 10.5)

There should be no change in layout and no new layout test
is added.

  • WebCore.exp.in:
  • icu/unicode/uscript.h: updated to ICU 4.6
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): helper to set generic family per script (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily. (WebCore::Settings::standardFontFamily): (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::fantasyFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
12:14 Changeset [90258] by kbalazs@webkit.org

Reviewed by Andreas Kling.

[Qt][WK2] netscape-dom-access.html needs new result
https://bugs.webkit.org/show_bug.cgi?id=63454

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
12:10 Changeset [90257] by kbalazs@webkit.org

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90254.
http://trac.webkit.org/changeset/90254
https://bugs.webkit.org/show_bug.cgi?id=63825

"committed with a totally broken changelog" (Requested by
kbalazs on #webkit).

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed.
11:55 Changeset [90256] by lforschler@apple.com

Versioning.

11:54 Changeset [90255] by lforschler@apple.com

New tag.

11:53 Changeset [90254] by kbalazs@webkit.org

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
11:50 Changeset [90253] by tony@chromium.org

2011-07-01 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData
https://bugs.webkit.org/show_bug.cgi?id=63773

We will have a similar struct to hold CSS3 flexible box data, so
this makes way for the new class.
I will rename the member variable in RenderStyle.h in a follow up
change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleAllInOne.cpp:
  • rendering/style/StyleDeprecatedFlexibleBoxData.cpp: (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): (WebCore::StyleDeprecatedFlexibleBoxData::operator==):
  • rendering/style/StyleDeprecatedFlexibleBoxData.h: (WebCore::StyleDeprecatedFlexibleBoxData::create): (WebCore::StyleDeprecatedFlexibleBoxData::copy): (WebCore::StyleDeprecatedFlexibleBoxData::operator!=):
  • rendering/style/StyleRareNonInheritedData.h:
11:40 Changeset [90252] by hans@chromium.org

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:

2011-07-01 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754

Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
constants. Douglas Stockwell pointed out that these were reverse
of what the spec says.

  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
11:39 Changeset [90251] by paroga@webkit.org

2011-07-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Daniel Bates.

[CMake] Add cpu detection for MIPS
https://bugs.webkit.org/show_bug.cgi?id=63693

  • Source/CMakeLists.txt:
11:33 Changeset [90250] by leviw@chromium.org

2011-07-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch positionForPoint to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63774

Switching positionForPoint functions to new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
  • rendering/RenderReplaced.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
  • rendering/RenderText.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint):
  • rendering/svg/RenderSVGText.h:
11:30 Changeset [90249] by scherkus@chromium.org

2011-07-01 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Fisher.

Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783

  • features.gypi:

2011-07-01 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Fisher.

Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783

  • WebCore.gyp/WebCore.gyp:
11:19 Changeset [90248] by paroga@webkit.org

2011-07-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Daniel Bates.

[CMake] Don't compile unused bindings
https://bugs.webkit.org/show_bug.cgi?id=63741

  • UseJSC.cmake: Added IF (ENABLE_XXX) around files.
11:19 Changeset [90247] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!

  • runtime/RegExpObject.cpp:

(JSC::regExpObjectSource):

LayoutTests:

Add tests with multiple forward slashes.

  • fast/regex/script-tests/toString.js:
  • fast/regex/toString-expected.txt:
11:14 Changeset [90246] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ReportCrash destabilizes new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63795

ReportCrash chews up too many system resources that it destablizes
tests run concurrently. This patch causes us to spin down all the
worker processes when ReportCrash is running.

Also, this patch causes the master process to tell the user we're
waiting for the crash reporter rather than having that be the worker's
job. This stops the user from getting spammed with too many "waiting
for crash reporter" messages and also cleans up some minor UI issues
with the meter.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
10:57 Changeset [90245] by tony@chromium.org

2011-07-01 Tony Chang <tony@chromium.org>

Fix the chromium build. sql is a new top level directory.

  • DEPS:
10:36 Changeset [90244] by rniwa@webkit.org

2011-07-01 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
10:29 Changeset [90243] by mihaip@chromium.org

2011-07-01 Mihai Parparita <mihaip@chromium.org>

Add failing test expectations for Chromium media tests on Windows 7 and
Vista.

  • platform/chromium/test_expectations.txt:
09:56 Changeset [90242] by kbalazs@webkit.org

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Clean up skipped list
https://bugs.webkit.org/show_bug.cgi?id=61644

  • platform/qt-wk2/Skipped: Remove everything that we skip via the common wk2 list.
09:56 Changeset [90241] by aroben@apple.com

2011-07-01 Adam Roben <aroben@apple.com>

Roll out r90194
http://trac.webkit.org/changeset/90194
https://bugs.webkit.org/show_bug.cgi?id=63778

Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing
assertions in WriteBarrierBase<JSC::Structure>::get

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell):
09:56 Changeset [90240] by joone.hur@collabora.co.uk

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add configure option to enable/disable DeviceOrientation feature.

  • configure.ac:

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.

  • GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.

2011-07-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
https://bugs.webkit.org/show_bug.cgi?id=63720

Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.

  • GNUmakefile.am:
  • WebCoreSupport/DeviceMotionClientGtk.cpp: Added. (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientGtk::setController): (WebCore::DeviceMotionClientGtk::startUpdating): (WebCore::DeviceMotionClientGtk::stopUpdating): (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
  • WebCoreSupport/DeviceMotionClientGtk.h: Added.
  • WebCoreSupport/DeviceOrientationClientGtk.cpp: Added. (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientGtk::setController): (WebCore::DeviceOrientationClientGtk::startUpdating): (WebCore::DeviceOrientationClientGtk::stopUpdating): (WebCore::DeviceOrientationClientGtk::lastOrientation):
  • WebCoreSupport/DeviceOrientationClientGtk.h: Added.
  • webkit/webkitwebview.cpp: (webkit_web_view_init):
09:54 Changeset [90239] by aroben@apple.com

Teach webkitpy about the new format of our ChangeLog template

r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
template. But webkitpy didn't know this, so the various rollout-related commands were
leaving that line in the ChangeLog.

Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
rollout are broken

Reviewed by Dan Bates.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
description and bug URL" line instead of the "Reviewed by" line as the first line of the
ChangeLog template.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
generates.

09:51 Changeset [90238] by bweinstein@apple.com

WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=63753

Reviewed by Darin Adler.

Source/WebKit2:

When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

LayoutTests:

Unskip WebKit2 tests that now pass.

  • platform/wk2/Skipped:
09:33 Changeset [90237] by oliver@apple.com

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757

Relanding as a Mac only patch.

This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
  • assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr):
  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble):
  • jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator):
  • jit/ThunkGenerators.h:
09:22 Changeset [90236] by aroben@apple.com

Skip one asserting and one timing-out test on Windows

Failures are tracked by <http://webkit.org/b/63806> and <http://webkit.org/b/63807>.

  • platform/win/Skipped: Added

http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and
fast/loader/create-frame-in-DOMContentLoaded.html.

09:21 Changeset [90235] by aroben@apple.com

Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html

The failure is tracked by <http://webkit.org/b/63809>.

  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt:
09:21 Changeset [90234] by aroben@apple.com

Land new expected (failure?) results for an accessibility test on Windows

The failure is tracked by <http://webkit.org/b/63811>.

  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
09:21 Changeset [90233] by aroben@apple.com

Update expected results after r90159

Fixes <http://webkit.org/b/63810> REGRESSION (r90159): fast/events/window-onerror5.html
failing

  • fast/events/window-onerror5-expected.txt: Updated for progression.
09:18 Changeset [90232] by ddkilzer@apple.com

<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp

Fixes the following build error in clang:

JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);


JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);


( )

fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3]

map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);

~

1 error generated.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary expression evaluate first.

09:17 Changeset [90231] by kbalazs@webkit.org

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239

  • platform/qt-wk2/Skipped:

2011-07-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
08:55 Changeset [90230] by aroben@apple.com

Make TestFailures stop loading old builds once we've explained all current failures

We used to do this, but some refactoring in r90165 broke this logic.

Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.

08:21 Changeset [90229] by aroben@apple.com

commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804

Reviewed by Darin Adler.

commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
commit message in order to make git-based tools, which expect the first line of the commit
message to be a summary of the change, to work better. But this reordering of the ChangeLog
entry was unpredictable and unexpected.

I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
try to move them.

  • Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"

line and try to move it down below the bug title and URL. The order of the text in the
ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
by" line in cases where the committer and author are not the same person.

  • Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
07:51 Changeset [90228] by commit-queue@webkit.org

2011-07-01 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Adam Roben.

[CSSRegions] Add build slave
https://bugs.webkit.org/show_bug.cgi?id=62372

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of Mac.
07:29 Changeset [90227] by commit-queue@webkit.org

2011-07-01 Jade Han <jade.han@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=61200

Add newly introduced symbols to fix the Symbian build.

  • symbian/eabi/QtWebKitu.def:
07:18 Changeset [90226] by commit-queue@webkit.org

2011-07-01 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Adam Roben.

accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=63191

  • accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
  • accessibility/aria-labelledby-overrides-aria-label.html:
  • platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
06:58 Changeset [90225] by commit-queue@webkit.org

2011-07-01 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709

Added a test that checks whether the content in 'search' input forms with 'disabled' attribute
or 'readonly' attribute is cleared or not, when an [X] button is clicked.

  • fast/forms/search-disabled-readonly-expected.txt: Added.
  • fast/forms/search-disabled-readonly.html: Added.

2011-07-01 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
https://bugs.webkit.org/show_bug.cgi?id=63709

Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
'readonly' attribute is set to the input form.

Test: fast/forms/search-disabled-readonly.html

  • html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
06:25 Changeset [90224] by mrowe@apple.com

Unreviewed due to fixing of a broken world.

REGRESSION (r90163): WebKit2 bot is failing 100% of the tests.

r90163 bumped the version of the WKBundlePageLoaderClient passed in by WebKitTestRunner from 0 to 1.
This made it run in to the ad-hoc client version checking implemented directly in WKBundlePageSetPageLoaderClient,
resulting in no client being set. After r90162 the ad-hoc checking is not necessary as the APIClient
template takes care of the relevant version checks.

  • Shared/APIClient.h:

(WebKit::APIClient::initialize): Fix a bug I noticed along the way: don't attempt to copy anything if
the client version is newer than what we support. This matches the behavior of the ad-hoc version checking.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient): Drop the ad-hoc version checking.
(WKContextSetHistoryClient): Ditto.
(WKContextSetDownloadClient): Ditto.

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient): Ditto.

  • UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider): Ditto.

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient): Ditto.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient): Ditto.
(WKPageSetPageFindClient): Ditto.
(WKPageSetPageFormClient): Ditto.
(WKPageSetPageLoaderClient): Ditto.
(WKPageSetPagePolicyClient): Ditto.
(WKPageSetPageResourceLoadClient): Ditto.
(WKPageSetPageUIClient): Ditto.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient): Ditto.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient): Ditto.
(WKBundlePageSetEditorClient): Ditto.
(WKBundlePageSetFormClient): Ditto.
(WKBundlePageSetPageLoaderClient): Ditto.
(WKBundlePageSetResourceLoadClient): Ditto.
(WKBundlePageSetPolicyClient): Ditto.
(WKBundlePageSetUIClient): Ditto.
(WKBundlePageSetFullScreenClient): Ditto.

05:51 Changeset [90223] by aestes@apple.com

2011-07-01 Andy Estes <aestes@apple.com>

Reviewed by Mark Rowe.

Simplify MailQuirksUserScript.js
https://bugs.webkit.org/show_bug.cgi?id=63800


MailQuirksUserScript.js is injected into WebViews in Mail.app on
Leopard to resolve an incompatibility between it and the HTML5 parser.
It did so by taking all nodes in the document between <html> and <body>
and moving them to be children of <body>. This maintains Mail.app's
assumption that document.firstChild.firstChild == document.body.


While this script fixed a specific issue with the Signature panel in
Mail.app, it caused regressions in other WebViews. Since the issue with
the Signature panel is with the empty <head> node implicitly created by
the parser, we can simplify this script by removing this implicit
<head> in the case it has no attributes and no children. This fixes the
Signature panel without affecting other WebViews that have non-trivial
<head> nodes.

  • Misc/MailQuirksUserScript.js: If <head> exists but has no attributes and no children, remove it.
04:29 Changeset [90222] by mnaganov@chromium.org

2011-06-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
https://bugs.webkit.org/show_bug.cgi?id=63703

  • inspector/front-end/HeapSnapshotWorker.js: (.Function.prototype.bind.return.bound): (.Function.prototype.bind):
03:38 Changeset [90221] by mjs@apple.com

2011-06-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Create sunspider-1.0 directory in preparation for fixing a bunch of bugs
https://bugs.webkit.org/show_bug.cgi?id=63782

  • make-hosted: Learn about the new directory.
  • tests/sunspider-1.0: Copied from PerformanceTests/SunSpider/tests/sunspider-0.9.1.
02:03 Changeset [90220] by tkent@chromium.org

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] Update text expectation for Vista.

  • platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
01:51 Changeset [90219] by krit@webkit.org

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705

Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
necessary.

SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.

Tests: svg/animations/svglength-animation-unitType.html

svg/animations/svglengthlist-animation-5.html

  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
  • svg/SVGAnimatedLengthList.cpp: Add support for additive animations. (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
  • svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
  • svg/SVGLength.h:

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedLengthListAnimator does not take additive="sum" into accout
https://bugs.webkit.org/show_bug.cgi?id=63705

Tests additive animations for SVGLengthLists as well as unit animations on SVGLength.

  • svg/animations/script-tests/svglength-animation-unitType.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-5.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svglength-animation-unitType-expected.txt: Added.
  • svg/animations/svglength-animation-unitType.html: Added.
  • svg/animations/svglengthlist-animation-5-expected.txt: Added.
  • svg/animations/svglengthlist-animation-5.html: Added.
01:37 Changeset [90218] by krit@webkit.org

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789


Test animation of SVGAnimatedInteger. Added the test to the wk2 skip list.

  • platform/mac-wk2/Skipped:
  • svg/animations/script-tests/svginteger-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svginteger-animation-1-expected.txt: Added.
  • svg/animations/svginteger-animation-1.html: Added.

2011-07-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.


SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.

Test: svg/animations/svginteger-animation-1.html

  • CMakeLists.txt: Added file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedInteger. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger. (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator): (WebCore::SVGAnimatedIntegerAnimator::constructFromString): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
  • svg/SVGAnimatedInteger.h: (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
  • svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createInteger): (WebCore::SVGAnimatedType::integer): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
00:52 Changeset [90217] by commit-queue@webkit.org

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90213.
http://trac.webkit.org/changeset/90213
https://bugs.webkit.org/show_bug.cgi?id=63792

The SL bot has an errant HTTP server holding port 8080
(Requested by abarth on #webkit).

  • Scripts/run-webkit-tests:
00:50 Changeset [90216] by carlosgc@webkit.org

2011-07-01 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r90163.

  • MiniBrowser/gtk/WebBundle/WebBundleMain.c: (didCreatePage):
00:47 Changeset [90215] by commit-queue@webkit.org

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90177 and r90179.
http://trac.webkit.org/changeset/90177
http://trac.webkit.org/changeset/90179
https://bugs.webkit.org/show_bug.cgi?id=63790

It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::sqrtDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::sqrtDouble):
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
  • create_hash_table:
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp:
  • jit/ThunkGenerators.h:
00:39 Changeset [90214] by abarth@webkit.org

2011-07-01 Adam Barth <abarth@webkit.org>

Exit faster when we get a keyboard interrupt. Previously, we'd open
Safari if you C NRWT after it found a failure.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
00:31 Changeset [90213] by abarth@webkit.org

2011-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786

We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.

If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).

  • Scripts/run-webkit-tests:
00:28 Changeset [90212] by tkent@chromium.org

2011-07-01 Kent Tamura <tkent@chromium.org>

[Chromium] More test expectation update for r90089

Need to update a Windows XP expectation because the corresponding
chromium-win expectation was updated.

  • platform/chromium-win-xp/fast/forms/search-styled-expected.png: Added.
00:13 Changeset [90211] by commit-queue@webkit.org

2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90192.
http://trac.webkit.org/changeset/90192
https://bugs.webkit.org/show_bug.cgi?id=63788

Appears to have caused NRWT on Chromium WebKit Vista to hang
(Requested by abarth on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
00:01 Changeset [90210] by tkent@chromium.org

2011-06-30 Kent Tamura <tkent@chromium.org>

[Mac][Chromium] Update test expectations for r90089

The placeholder position changes are expected because we respect
paddings for text fields.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:
Note: See TracTimeline for information about the timeline view.