Timeline


and

07/08/11:

23:05 Changeset [90676] by krit@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactoring luminance code in RenderSVGResourceMasker
https://bugs.webkit.org/show_bug.cgi?id=64146

Reviewed by Simon Fraser.

Moved luminance calculcation code to ImageBuffer. The code is doing pixel manipulations and can now get replaced
by platform specific algorithms in the ImmageBuffer*.cpp files.

No change of functionality. No new tests.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):
(WebCore::ImageBuffer::genericConvertToLuminanceMask):
(WebCore::ImageBuffer::convertToLuminanceMask):

  • platform/graphics/ImageBuffer.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

17:43 Changeset [90675] by simon.fraser@apple.com
  • 42 edits in trunk/Source/WebCore

2011-07-08 Simon Fraser <simon.fraser@apple.com>

Clean up RenderWidget::destroy() to share more code
https://bugs.webkit.org/show_bug.cgi?id=64138

Reviewed by James Robinson.

RenderWidget::destroy() copied code from various other
destroy() methods, which made code maintenance in this
area very risky.

Fix by adding a virtual willBeDestroyed() method, which
replaces most instances of destroy(). Now, only RenderWidget
and RenderObject implement destroy(), and each just calls
willBeDestroyed(). Code duplication is averted.

No behavior change, so no tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::willBeDestroyed):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::willBeDestroyed):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::willBeDestroyed):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::willBeDestroyed): (RenderFullScreen::willBeDestroyed):
  • rendering/RenderFullScreen.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::willBeDestroyed):
  • rendering/RenderInline.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::willBeDestroyed):
  • rendering/RenderListItem.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::willBeDestroyed):
  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::willBeDestroyed):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::willBeDestroyed):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::willBeDestroyed):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::willBeDestroyed):
  • rendering/RenderText.h:
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::willBeDestroyed):
  • rendering/RenderTextFragment.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::willBeDestroyed): (WebCore::RenderWidget::destroy):
  • rendering/RenderWidget.h:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::willBeDestroyed):
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::willBeDestroyed):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::willBeDestroyed):
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::willBeDestroyed):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::willBeDestroyed):
  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::willBeDestroyed):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/SVGResourcesCache.h:
17:39 WikiStart edited by dpranke@chromium.org
(diff)
17:02 Changeset [90674] by ojan@chromium.org
  • 6 edits
    14 adds
    4 deletes in trunk/Tools

pull static dashboard files into the appengine server from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=64208

Reviewed by Dirk Pranke.

These files belong in the WebKit repo since they are tied primarily to the webkit tests.
They have some extra bits to support chromium's gtests, but that seems fine.
Mainly, this will allow other WebKit hackers to hack on the dashboards.

As a nice side-effect, we can now push the dashboard files when we do appengine pushes
instead of the weird thing we used to do of pulling them from the Chromium repository
and storing them in the appengine datastore. This allows for cleaning up a lot of code
and will likely make the dashboards load a bit faster.

The new JS files don't fully match WebKit style, but I'd like to clean that up in a
followup patch if possible to maintain my sanity with this patch.

  • TestResultServer/app.yaml:
  • TestResultServer/handlers/dashboardhandler.py: Removed.
  • TestResultServer/handlers/menu.py:
  • TestResultServer/main.py:
  • TestResultServer/model/dashboardfile.py: Removed.
  • TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
  • TestResultServer/static-dashboards/README.dygraph.txt: Added.
  • TestResultServer/static-dashboards/README.webtreemap.txt: Added.
  • TestResultServer/static-dashboards/aggregate_results.html: Added.
  • TestResultServer/static-dashboards/builders.js: Added.
  • TestResultServer/static-dashboards/dashboard_base.js: Added.
  • TestResultServer/static-dashboards/dygraph-combined.js: Added.
  • TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
  • TestResultServer/static-dashboards/timeline_explorer.html: Added.
  • TestResultServer/static-dashboards/treemap.html: Added.
  • TestResultServer/static-dashboards/webtreemap.css: Added.
  • TestResultServer/static-dashboards/webtreemap.js: Added.
  • TestResultServer/stylesheets/dashboardfile.css: Removed.
  • TestResultServer/stylesheets/menu.css:
  • TestResultServer/templates/dashboardfilelist.html: Removed.
  • TestResultServer/templates/menu.html:
16:40 Changeset [90673] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=64181
REGRESSION (r90602): Gmail doesn't load

Rolling out r90601, r90602.

  • dfg/DFGAliasTracker.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::dfgLinkCall):

  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):

16:35 Changeset [90672] by aroben@apple.com
  • 3 edits in trunk/Tools

Make TestFailures's list of flaky tests look more like the list of non-flaky tests

Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.

15:57 Changeset [90671] by abarth@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r90662.
http://trac.webkit.org/changeset/90662
https://bugs.webkit.org/show_bug.cgi?id=64210

Introduced regressions in Chromium browser tests (Requested by
rniwa on #webkit).

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::selectionChanged):

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::selectionStart):
(WebCore::RenderTextControl::selectionEnd):
(WebCore::RenderTextControl::hasVisibleTextArea):
(WebCore::setSelectionRange):
(WebCore::setContainerAndOffsetForRange):
(WebCore::RenderTextControl::selection):

  • rendering/RenderTextControl.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

15:32 Changeset [90670] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make GL context current before updating layer texture using skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=64206

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-08
Reviewed by James Robinson.

Covered by existing tests (when accelerated drawing and compositing are on).

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

15:25 Changeset [90669] by jpfau@apple.com
  • 2 edits in trunk/Tools

2011-07-08 Jeffrey Pfau <jpfau@apple.com>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
15:15 Changeset [90668] by tony@chromium.org
  • 8 edits in trunk/Source/WebCore

Refactor override size to be a size rather than just an int
https://bugs.webkit.org/show_bug.cgi?id=64195

Reviewed by David Hyatt.

Also convert to LayoutSize and LayoutUnit.

Covered by existing tests.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideSize): Pass in a LayoutSize.
(WebCore::RenderBox::setOverrideSize):
(WebCore::RenderBox::clearOverrideSize): New method for clearing the

override size (previous we would pass in -1)

(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideSizeFromRowHeight):

  • rendering/RenderTableCell.h: Remove setOverrideSize since it was

only called in one place to clear the override size. Inline this
logic instead.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::destroy):

15:01 Changeset [90667] by eae@chromium.org
  • 16 edits in trunk/Source/WebCore

Switch pointInContainer and accumulatedOffset to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64112

Reviewed by Eric Seidel.

Convert remaining IntPoint versions of the pointInContainer and
accumulatedOffset arguments to the new layout abstraction.

No new tests, no functionality changes.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/HitTestResult.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isPointInOverflowControl):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):

  • rendering/RenderBox.h:
  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderLineBoxList.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::hitTest):

  • rendering/RenderObject.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

14:50 Changeset [90666] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed; new chromium GPU pixel results for overflow-scroll-expected.

  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
14:18 Changeset [90665] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

TestResultsServer should keep old test results
https://bugs.webkit.org/show_bug.cgi?id=64199

Reviewed by Ojan Vafai.

Having historical data will help us do failure archeology.

  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/model/testfile.py:
  • TestResultServer/templates/showfilelist.jsonp: Added.
13:58 Changeset [90664] by aroben@apple.com
  • 2 edits in trunk/Tools

Remove commit-log-editor's dependency on Module::Load::Conditional

This module isn't available in Perl 5.8.8 (the version used on Leopard).

Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
webkitpy.common.checkout.checkout_unittest failing on Leopard

Reviewed by Daniel Bates.

  • Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of

Module::Load::Conditional::can_load.
(loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.

13:37 Changeset [90663] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip all HTMLProgressElement tests on Windows

<http://webkit.org/b/49769> tracks implementing this element on Windows. For now it's just a
source of failing tests.

  • platform/win/Skipped: Skip the entire HTMLProgressElement directory so we don't have to

keep adding new tests one-by-one.

13:30 Changeset [90662] by rniwa@webkit.org
  • 9 edits in trunk/Source

Move selection related code from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64133

Reviewed by Dimitri Glazkov.

Source/WebCore:

Moved selectionStart, selectionEnd, hasVisibleTextArea, setSelectionRange, setContainerAndOffsetForRange
and selection from RenderTextControl.cpp to HTMLFormControlElement.cpp.

This refactoring removes RenderTextControl's dependency on FrameSelection.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText): Calls HTMLTextFromControl::selectedText.
(WebCore::AccessibilityRenderObject::selectedTextRange): Calls selectionStart and selectionEnd.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText): Extracted from AccessibilityRenderObject::selectedText.
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange): Merged with the function of the same name in
RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionStart): Ditto.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::setContainerAndOffsetForRange): Moved from RenderTextControl.cpp
(WebCore::HTMLTextFormControlElement::selection): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls selectionStart and selectionEnd.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Moved from HTMLFormControlElement.cpp now that
all functions are self-contained in HTMLTextFormControlElement.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Calls setSelectionRange.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Added.

  • rendering/RenderTextControl.h:

Source/WebKit/qt:

Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

13:28 Changeset [90661] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

remove (empty) indirection between GraphicsContextPlatformPrivate and PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=64178

Patch by Mike Reed <reed@google.com> on 2011-07-08
Reviewed by Stephen White.

No new tests. no functionality change, other than removing an indirection that is not needed

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextPlatformPrivate.h: Removed.
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):

13:28 Changeset [90660] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Add some MAC GPU failing tests from r90464.

  • platform/chromium/test_expectations.txt:
13:02 Changeset [90659] by aroben@apple.com
  • 2 edits in trunk/Tools

Make checkout_unittest more robust against files moving around

Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
Scripts directory

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
object and use it to get the path to the Scripts directory, rather than hard-coding the
relative path from this file to Scripts.

13:01 Changeset [90658] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Add some WIN GPU failing tests from r90464 to test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:54 Changeset [90657] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test rebaseline.

New baseline for a failing test on GPU linux introduced in r90646.

  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
12:51 Changeset [90656] by aroben@apple.com
  • 2 edits in trunk/Tools

Make TestFailures remember that run-webkit-tests timed out, even across reloads

Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
When true, it indicates that there was an error retrieving the results for this build and
that the errorCallback should be called.

12:47 Changeset [90655] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations cleanup.

Removed some duplicate expectations.

  • platform/chromium/test_expectations.txt:
12:31 Changeset [90654] by jpfau@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

Add framework for a new/dummy XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=63955

Reviewed by Adam Barth.

Added a dummy framework NewXMLDocumentParser

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::createParser):

  • xml/parser/NewXMLDocumentParser.cpp: Added.

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):
(WebCore::NewXMLDocumentParser::insert):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::detach):
(WebCore::NewXMLDocumentParser::hasInsertionPoint):
(WebCore::NewXMLDocumentParser::finishWasCalled):
(WebCore::NewXMLDocumentParser::processingData):
(WebCore::NewXMLDocumentParser::prepareToStopParsing):
(WebCore::NewXMLDocumentParser::stopParsing):
(WebCore::NewXMLDocumentParser::isWaitingForScripts):
(WebCore::NewXMLDocumentParser::isExecutingScript):
(WebCore::NewXMLDocumentParser::executeScriptsWaitingForStylesheets):

  • xml/parser/NewXMLDocumentParser.h: Added.

(WebCore::NewXMLDocumentParser::create):

12:27 Changeset [90653] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused function parameters.

Patch by David Reveman <reveman@chromium.org> on 2011-07-08
Reviewed by Ryosuke Niwa.

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::textureOffset):

12:26 Changeset [90652] by abarth@webkit.org
  • 9 edits in trunk/Tools

Teach garden-o-matic how to display test results
https://bugs.webkit.org/show_bug.cgi?id=64141

Reviewed by Ojan Vafai.

This patch includes basic infrastructure for probing build.chromium.org
for test results. We only handle text and image tests, not anything
complicated like reftests. Also, we're using the revision/build
independent results store on the server, so we're avoiding that
complication for now.

It's slightly hacky that we need to probe the server to see what kinds
of results exist. A better solution would be to add CORS support to
the server or to use the local server to help.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
12:21 Changeset [90651] by dpranke@chromium.org
  • 3 edits in trunk/Tools

REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
https://bugs.webkit.org/show_bug.cgi?id=64092

Reviewed by Tony Chang.

The code was incorrectly creating empty shards in the
shard_in_two case.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
12:05 Changeset [90650] by aroben@apple.com
  • 2 edits in trunk/Tools

Teach buildbot to figure out how many webkitpy/webkitperl tests failed

Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
tests failed when looking at build.webkit.org

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestWithFailureCount): New class that represents a test build step which has an associated
failure count. Eventually we should move more of our test classes to deriving from this.
(TestWithFailureCount.countFailures): Method for subclasses to override to say how many
failures occurred.

(TestWithFailureCount.commandComplete):
(TestWithFailureCount.evaluateCommand):
(TestWithFailureCount.getText):
(TestWithFailureCount.getText2):
These were all based on RunGtkAPITests.

(RunPythonTests): Changed to inherit from TestWithFailureCount.
(RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
failures.
(RunPerlTests): Changed to inherit from TestWithFailureCount.
(RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
failures.

11:59 Changeset [90649] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Patch by Kalev Lember <kalev@smartlink.ee> on 2011-07-08
Reviewed by Adam Roben.

Add missing _WIN32_WINNT and WINVER definitions
https://bugs.webkit.org/show_bug.cgi?id=59702

Moved _WIN32_WINNT and WINVER definitions to config.h so that they are
available for all source files.

In particular, wtf/FastMalloc.cpp uses CreateTimerQueueTimer and
DeleteTimerQueueTimer which are both guarded by
#if (_WIN32_WINNT >= 0x0500)
in MinGW headers.

  • config.h:
  • wtf/Assertions.cpp:
11:47 Changeset [90648] by aroben@apple.com
  • 2 edits in trunk/Tools

Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration

Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
bots due to commit-log-editor errors

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
$CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
commit-log-editor can find a value for the committer's email, and that the committer and
author email addresses match, which will prevent commit-log-editor from inserting a "Patch
by" line in the commit message.

11:37 Changeset [90647] by andreas.kling@nokia.com
  • 16 edits
    2 adds in trunk

[Qt][WK2] Views should expose QActions for basic navigation.
https://bugs.webkit.org/show_bug.cgi?id=64174

Source/WebKit2:

Add navigationAction() methods to the views to provide default
QActions for Back, Forward, Stop and Reload.

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::navigationAction):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::navigationAction):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebkittypes.h: Added.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::triggerNavigationAction):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/html/basic_page2.html: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::navigationAction):

  • UIProcess/qt/QtWebPageProxy.h:
  • WebKit2API.pri:

Tools:

Reviewed by Benjamin Poulain.

Bring the toolbar in Qt's MiniBrowser back to life.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::navigationAction):

  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

11:33 Changeset [90646] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk

Patch by David Reveman <reveman@chromium.org> on 2011-07-08
Reviewed by Stephen White.

[Chromium] Edge anti-aliasing for composited layers.
https://bugs.webkit.org/show_bug.cgi?id=61388

Source/WebCore:

Add transparent outer border to tiled layers and adjust vertex
coordinates so that use of a bilinear filter creates a smooth
layer edge.

Tests: platform/chromium/compositing/tiny-layer-rotated.html

platform/chromium/compositing/huge-layer-rotated.html (existing)
TilingDataTest in webkit_unit_tests

  • platform/graphics/chromium/ContentLayerChromium.cpp:

Change maxUntiledSize to 510 to ensure that tiles are not greater
than 512 with outer borders.
(WebCore::ContentLayerChromium::updateLayerSize): We can't use the
layer size as tile size when we want to avoid tiling as this will
not be enough space to include possible outer borders. We instead use
an empty size, which allows the tiler to automatically adjust the
tile size to be large enough for the layer to fit in one tile.
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::setIsMask): Don't use border texels
for layer used as mask.

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::m_borderTexels) Added.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::tileTexRect): Added.
(WebCore::LayerTilerChromium::tileLayerRect): m_tileSize is no
longer the correct layer size. Size of bounds with border should
be the correct layer size.
(WebCore::LayerTilerChromium::growLayerToContain): Adjust texture
size to include outer borders and handle empty m_tileSize.
(WebCore::LayerTilerChromium::invalidateRect): Use size of rectangle
returned by tileTexRect instead of m_tileSize for texture size.
(WebCore::LayerTilerChromium::prepareToUpdate): Ditto.
(WebCore::LayerTilerChromium::draw): Compute and intersect tile edges
instead of using tile coordinates directly. Edges are adjusted to
include outer borders and make sure all partially covered pixels are
processed.
(WebCore::LayerTilerChromium::drawTexturedQuad): Pass quad to
shader using point uniform.
(WebCore::LayerTilerChromium::invalidateRect): Invalidate old layer
area to clear any contents left from previous layer size.

  • platform/graphics/chromium/LayerTilerChromium.h:

(WebCore::LayerTilerChromium::tileTexRect) Added.
(WebCore::LayerTilerChromium::drawTexturedQuad): Add quad parameter.

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::getShaderString) Get X/Y vertex
components from point uniform.
(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform)
Added point uniform.
(WebCore::VertexShaderPosTexTransform::init) Ditto.
(WebCore::VertexShaderPosTexTransform::pointLocation) Added.

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexTransform::pointLocation) Added.

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBoundsWithOuterBorder): Added.
(WebCore::TilingData::computeNumTiles): Adjust for outer border.
(WebCore::TilingData::tileXIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileYIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileSizeX): Ditto.
(WebCore::TilingData::tileSizeY): Ditto.
(WebCore::TilingData::intersectDrawQuad): Ditto.
(WebCore::TilingData::textureOffset): Ditto.

  • platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::tileBoundsWithOuterBorder): Added.

Source/WebKit:

Track changes to TilingData class which now uses an outer border.

  • chromium/tests/TilingDataTest.cpp:

LayoutTests:

  • platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/tiny-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/tiny-layer-rotated.html: Added.
  • platform/chromium/test_expectations.txt:
11:13 Changeset [90645] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[skia] don't rely on lockPixels failure to detect gpu-backed device (in prep for skia roll)
https://bugs.webkit.org/show_bug.cgi?id=64162

Patch by Mike Reed <reed@google.com> on 2011-07-08
Reviewed by Stephen White.

No new tests. preparing for skia roll, where lockPixels always succeeds (but slowly for gpu-backed)

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):

11:06 Changeset [90644] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] Get rid of the check for TILED_BACKING_STORE in Qt
https://bugs.webkit.org/show_bug.cgi?id=64175

Reviewed by Kenneth Rohde Christiansen.

Qt no longer supports building WebKit2 without TILED_BACKING_STORE.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::onScaleChanged):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setResizesToContentsUsingLayoutSize):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:
10:54 Changeset [90643] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Source/JavaScriptCore: Rename "makeSecure" to "fill" and remove the support for displaying last character
to avoid layering violatation.
https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

(WTF::StringImpl::fill):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:

(WTF::String::fill):

Source/WebCore: Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

No new tests, just refactoring.

  • editing/visible_units.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setTextInternal):

Source/WebKit/win: Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

  • WebKitGraphics.cpp:

(WebDrawText):

10:51 WebKit2 edited by andreas.kling@nokia.com
(diff)
10:29 Changeset [90642] by commit-queue@webkit.org
  • 12 edits
    3 adds in trunk

[CSSRegions]Parse content: -webkit-from-flow
https://bugs.webkit.org/show_bug.cgi?id=63133

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-08
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/content-webkit-from-flow-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFromFlowContent):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionThread):
(WebCore::InheritedFlags::setRegionThread):
(WebCore::InheritedFlags::initialRegionThread):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
  • fast/regions/content-webkit-from-flow-parsing.html: Added.
  • fast/regions/script-tests/content-webkit-from-flow-parsing.js: Added.
10:24 Changeset [90641] by japhet@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Check activeDocumentLoader() in
WebFrameImpl::currentHistoryItem() and return
early if null, since that should mean we're
shutting down.
https://bugs.webkit.org/show_bug.cgi?id=52923

Reviewed by Darin Fisher.

No known repro, so no new test.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::currentHistoryItem):

09:13 Changeset [90640] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

REGRESSION (r90557): http/tests/inspector/network/network-embed.html fails
https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed test fix (typo).

  • http/tests/inspector/network/network-embed.html:
09:09 Changeset [90639] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach TestFailures how to find test names in commit-log-editor-style commit messages

TestFailures was relying on Trac turning the list of modified files in our commit messages
into an HTML list. But Trac only does this when the list of modified files is indented.
commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
list, which was confusing TestFailures.

TestFailures now does much simpler parsing of the commit message (i.e., just a substring
search) without relying at all on its structure.

Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
fast/dom/HTMLProgressElement/progress-element-markup.html on Windows

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
message, just return its text.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForRegressionRange): Instead of searching for test names in
each commit's list of modified files, just search for test names anywhere in the commit's
message.

09:04 Changeset [90638] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Web Inspector: styles-disable-then-delete was flaky.
https://bugs.webkit.org/show_bug.cgi?id=64170

Reviewed by Yury Semikhatsky.

  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-disable-then-delete.html:
09:01 Changeset [90637] by vsevik@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Web Inspector: inspector/styles/styles-url-linkify.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=64171

Added image files because the behavior differs when they are not available.

Unreviewed test fix: added image files.

  • inspector/styles/resources/fromcss.png: Added.
  • inspector/styles/resources/iframed.png: Added.
  • inspector/styles/styles-url-linkify-expected.txt:
08:58 Changeset [90636] by abarth@webkit.org
  • 3 edits in trunk/Tools

sheriffbot is too spammy in IRC
https://bugs.webkit.org/show_bug.cgi?id=64153

Reviewed by Eric Seidel.

Reporting failures in IRC worked well when the tree was greener than it
is today. Nowadays, this feature mostly just results in spam about
false positives. If we reach a greener state, we can bring this code
back.

(Another possibility is to restrict this feature to builder bots,
rather than including testers, as we did before this patch.)

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
08:53 Changeset [90635] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: NetworkPanel search failed if the matched sting is in the query part of url
https://bugs.webkit.org/show_bug.cgi?id=64167

Reviewed by Yury Semikhatsky.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._matchResource):
(WebInspector.NetworkPanel.prototype._highlightNthMatchedResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get folder):

08:50 Changeset [90634] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Enable HTTP Pipelining by default
https://bugs.webkit.org/show_bug.cgi?id=64169

Reviewed by Andreas Kling.

QNetworkAccessManager disables HTTP pipelining by default. We enable it by
setting an attribute on the request.

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

08:46 Changeset [90633] by abecsi@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168

Unreviewed gardening.

The cause of the crash revealed itself as a side effect thus
it is better to expect the test to CRASH rather than skipping it.

  • platform/qt/Skipped: Unskip test.
  • platform/qt/test_expectations.txt: Mark as CRASH
08:22 Changeset [90632] by aroben@apple.com
  • 2 edits in trunk/Tools

Ensure commit-log-editor adds a "Patch by" line when the author and committer are different

Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
by" line. But some patches (like rollout patches) don't contain that line. Now we always add
"Patch by" to the commit log regardless of the ChangeLog's contents.

Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
should have been abarth@webkit.org

Reviewed by Anders Carlsson.

  • Scripts/commit-log-editor:

(createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
before. If there is no "Reviewed by" line, try to put it just above the first modified file.
If all else fails, put it at the end of the commit message.
(patchAuthorshipString): Added. Code came from createCommitMessage.

07:58 Changeset [90631] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168

Unreviewed gardening.

  • platform/qt/Skipped: Skip the test.
07:51 Changeset [90630] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: CSS inspector gets confused about specificity of !important properties
https://bugs.webkit.org/show_bug.cgi?id=64074

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._markUsedProperties):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/resources/elements-panel-styles.css:

(#container .foo):
(.foo):

07:42 Changeset [90629] by benjamin.poulain@nokia.com
  • 7 edits in trunk/Source

[WK2] Do not forward touch events to the web process when it does not need them
https://bugs.webkit.org/show_bug.cgi?id=64164

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

Add a convenience function to obtain a reference to the last element of a Deque.

  • wtf/Deque.h:

(WTF::Deque::last):

Source/WebKit2:

The call to ChromeClient::needTouchEvent() is now forwarded to the WebPageProxy
to change the way events are delivered.

When the WebPage does not need touch events, and there is no queued touch events,
the incoming events just bounce back through PageClient::doneWithTouchEvent().

In the case when new events come to WebPageProxy and there are still touch events
incoming from the WebProcess, the new events are deferred with the corresponding
pending touch events.
Deferring the new events iafter the corresponding forwarded event ensure
the delivery is always done in order when PageClient::doneWithTouchEvent()
is called.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::needTouchEvents):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit::QueuedTouchEvents:::forwardedEvent):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::needTouchEvents):

07:34 Changeset [90628] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed, clang build fix.

  • inspector/InspectorStyleTextEditor.h:
06:51 TestExpectations edited by aroben@apple.com
A few small formatting tweaks, and replaced the Contents section with a … (diff)
06:44 NewRunWebKitTests edited by aroben@apple.com
Just a few formatting tweaks, and replaced the Contents section with an … (diff)
06:42 Changeset [90627] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
https://bugs.webkit.org/show_bug.cgi?id=64159

Rework the icon-uri change test so that the condition for quitting
the mainloop is the icon-uri change itself, along with a timeout
to avoid taking too long in case of failure. Since the conditions
for considering a page loaded were changed we can't rely on that
for this test anymore.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-07-08
Reviewed by Xan Lopez.

  • tests/testwebview.c:

(timeout_cb): error out if it takes too long for the icon-uri
change to happen.
(icon_uri_changed_cb): quit the loop here instead of waiting on
the page being loaded.
(test_webkit_web_view_icon_uri):

06:25 Changeset [90626] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: add support for drag'n'drop of non-elements (comments, text, etc.)
https://bugs.webkit.org/show_bug.cgi?id=64163

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::moveTo):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):

06:21 Changeset [90625] by caseq@chromium.org
  • 6 edits in trunk

2011-07-08 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):

2011-07-08 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

  • inspector/extensions/extensions.html: add explicit base paths to extension resource being loaded.
06:19 Changeset [90624] by zherczeg@webkit.org
  • 2 edits in trunk/Tools

Reviewed by Andreas Kling.

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
05:55 Changeset [90623] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Add BUG modifier which was accidentally removed in the previous commit

Unreviewed.

  • platform/qt/test_expectations.txt:
05:29 Changeset [90622] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002

Unreviewed gardening.

  • platform/qt/test_expectations.txt: Skip fast/forms/textfield-overflow-by-value-update.html

because it sometimes does not produce any output.

04:56 Changeset [90621] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r90615.
http://trac.webkit.org/changeset/90615
https://bugs.webkit.org/show_bug.cgi?id=64158

broke inspector/extensions/extensions.html (Requested by caseq
on #webkit).

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):

04:53 Changeset [90620] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline expected file after r90567

Unreviewed.

  • inspector/styles/styles-url-linkify-expected.txt:
04:32 Changeset [90619] by apavlov@chromium.org
  • 14 edits
    4 adds in trunk

Web Inspector: Adding CSS properties results in messy style rules
https://bugs.webkit.org/show_bug.cgi?id=63622

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/styles-formatting.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPropertySourceData.cpp:

(WebCore::SourceRange::length):

  • css/CSSPropertySourceData.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyle::applyStyleText):
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleTextEditor.cpp: Added.

(WebCore::InspectorStyleTextEditor::InspectorStyleTextEditor):
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::replaceProperty):
(WebCore::InspectorStyleTextEditor::removeProperty):
(WebCore::InspectorStyleTextEditor::enableProperty):
(WebCore::InspectorStyleTextEditor::disableProperty):
(WebCore::InspectorStyleTextEditor::disabledIndexByOrdinal):
(WebCore::InspectorStyleTextEditor::shiftDisabledProperties):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):

  • inspector/InspectorStyleTextEditor.h: Added.

(WebCore::InspectorStyleTextEditor::styleText):

LayoutTests:

  • inspector/styles/styles-formatting-expected.txt: Added.
  • inspector/styles/styles-formatting.html: Added.
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
04:25 Changeset [90618] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Add basic support for panning gestures to the QTouchWebView
https://bugs.webkit.org/show_bug.cgi?id=64105

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-08
Reviewed by Kenneth Rohde Christiansen.

This patch adds basic support for the panning gesture on the UI process side.

The events coming back from the WebProcess are processed through
the QtPanGestureRecognizer to recognize the pan gesture. When the
gesture is recognized, the actions are performed on the view through
the TouchViewInterface.

Currently, the viewport just move the page around without limit.
This will be improved when a physics engine is integrated.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp: Added.

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
(WebKit::QtPanGestureRecognizer::reset):

  • UIProcess/qt/QtPanGestureRecognizer.h: Added.
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureStarted):
(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::panGestureEnded):
(WebKit::TouchViewInterface::panGestureCancelled):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
(QTouchWebPageProxy::processDidCrash):
(QTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
04:16 Changeset [90617] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Quotes are rendered as &quot; in the DOM tree
https://bugs.webkit.org/show_bug.cgi?id=64154

Reviewed by Yury Semikhatsky.

Source/WebCore:

Since we currently rely on setting textContent rather than innerHTML for the DOM tree elements,
escapeHTML() calls unnecessarily HTML-escape certain characters in the DOM tree contents.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
():

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
04:03 Changeset [90616] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unused code from InspectorAgent.h.
https://bugs.webkit.org/show_bug.cgi?id=64120

Reviewed by Joseph Pecoraro.

  • inspector/InspectorAgent.h:
03:39 Changeset [90615] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-08 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):
03:12 Changeset [90614] by yurys@chromium.org
  • 3 edits
    3 adds in trunk

Web Inspector: typing undefined = 1 in console crashes browser
https://bugs.webkit.org/show_bug.cgi?id=64155

Source/WebCore:

Do not access undefined value directly when producing JSON objects as undefined
may be overriden by the inspected page.

Reviewed by Pavel Feldman.

Test: inspector/console/console-eval-undefined-override.html

  • inspector/InjectedScriptSource.js:

(.):
():

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/console/console-eval-undefined-override-expected.txt: Added.
  • inspector/console/console-eval-undefined-override.html: Added.
  • platform/chromium/inspector/console/console-eval-undefined-override-expected.txt: Added.
01:37 Changeset [90613] by caseq@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-07-08 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Moving test expectation from platform-specific to generic.

  • fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt.

07/07/11:

23:41 Changeset [90612] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

WebSocket: Clear cookies after test in httponly-cookie.pl
https://bugs.webkit.org/show_bug.cgi?id=64145

Reviewed by Kent Tamura.

This test leaks cookies, which would cause a test failure if we put
a copy of this test under http/tests/websocket/tests.

To avoid this issue, cookies should be removed before the test ends.

  • http/tests/websocket/tests/hixie76/httponly-cookie.pl:

After the test, send an XHR request to itself with a query parameter,
which erases cookies used in this test by setting "Max-Age=0".

21:59 Changeset [90611] by kevino@webkit.org
  • 2 edits
    1 delete in trunk/Tools

[wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.

21:53 Changeset [90610] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, more fixes for install name issues.

20:53 Changeset [90609] by tkent@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

[Chromium] Update baseline files for input-appearance-range.html.

  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png:
  • platform/chromium/test_expectations.txt:
19:46 Changeset [90608] by morrita@google.com
  • 8 edits
    4 adds in trunk/LayoutTests

dump-as-markup.js should support shadow tree
https://bugs.webkit.org/show_bug.cgi?id=62447

Reviewed by Ryosuke Niwa.

  • Added shadow support to Markup._get()
  • Updated expectations caused by this change.
  • Added explanatory test cases for shadows.
  • editing/inserting/5607069-2-expected.txt:
  • editing/inserting/5607069-3-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup-form-text-expected.txt:
  • fast/parser/object-with-textarea-fallback-expected.txt:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-markup.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-markup.html: Added.
  • fast/dom/HTMLMeterElement/meter-element-markup.html:
  • fast/dom/HTMLProgressElement/progress-element-markup.html:
  • resources/dump-as-markup.js:

(Markup._get):

19:22 Changeset [90607] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy fails on chromium win
https://bugs.webkit.org/show_bug.cgi?id=64137

Reviewed by Eric Seidel.

test-webkitpy doesn't play nicely with the multiprocessing
module on win32. An earlier change actually reenabled the tests
on win32 by mistake.

This patch also fixes a few cases where path names will trip
things up on win32 (e.g., by testing unix paths on windows).
We do not lose any real coverage here with those fixes.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19:13 Changeset [90606] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[ImageDiff] Calculate/print difference right after reading baseline image.
https://bugs.webkit.org/show_bug.cgi?id=64117

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

Otherwise, ImageDiff will block on fgets() until the universe ends or you C
it. Whichever happens first.

  • DumpRenderTree/efl/ImageDiff.cpp:

(main):

18:16 Changeset [90605] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
https://bugs.webkit.org/show_bug.cgi?id=64107

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

The pointer is later managed by BitmapContext, but it was being
de-refed and deleted earlier by our RefPtr, causing crashes in all
pixel tests.

We now call leakRef() to make sure it is not removed when our
createBitmapContextFromWebView goes out of context.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

17:49 Changeset [90604] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl
https://bugs.webkit.org/show_bug.cgi?id=64087

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hixie76/httponly-cookie.pl:
17:17 Changeset [90603] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Switch HitTestResult to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64131

Reviewed by Eric Seidel.

No new tests, no functionality changes.

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::localPoint):

  • page/MouseEventWithHitTestResults.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::point):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setPoint):
(WebCore::HitTestResult::setLocalPoint):
(WebCore::HitTestResult::rectForPoint):

16:54 Changeset [90602] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordConstruct):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:48 Changeset [90601] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement get_by_id prototype caching.
https://bugs.webkit.org/show_bug.cgi?id=64077

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):

  • runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyAtOffset):

16:35 LayoutTestResultFallbackOrder edited by dpranke@chromium.org
(diff)
16:35 LayoutTestResultFallbackOrder edited by dpranke@chromium.org
(diff)
16:18 LayoutTestsSearchPath edited by dpranke@chromium.org
(diff)
16:17 Changeset [90600] by leviw@chromium.org
  • 37 edits in trunk/Source/WebCore

Switch remaining paint functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64116

Reviewed by Eric Seidel.

Switching all functions with IntPoint paintOffsets to the new Layout types.

No new tests, no functionality changes.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):

  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintCustomHighlight):

  • rendering/InlineTextBox.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintCaret):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::paintSelection):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintCustomHighlight):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLayer.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::paintOutline):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):

  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::paintPlaceholder):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::paint):

  • rendering/RootInlineBox.h:
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):

16:16 Changeset [90599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Work around Skia PDF's lack of inverted path support.
https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

16:07 Changeset [90598] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT method_check implementation does not link to optimized get_by_id
slow path.
https://bugs.webkit.org/show_bug.cgi?id=64073

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):

15:58 TestExpectations edited by dpranke@chromium.org
(diff)
15:58 TestExpectations edited by dpranke@chromium.org
(diff)
15:55 TestExpectations edited by dpranke@chromium.org
(diff)
15:45 Changeset [90597] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Add text baseline for spanOverlapsCanvas

  • platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:37 Changeset [90596] by eae@chromium.org
  • 16 edits in trunk/Source/WebCore

Switch rendering tree selection code to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63762

Reviewed by Eric Seidel.

Switch selection getters and selection gap calculation methods over to
new layout abstraction.

No new tests, no functionality changes.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionTop):
(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::selectionHeight):
(WebCore::InlineTextBox::isSelected):

  • rendering/InlineTextBox.h:
  • rendering/RenderBR.h:

(WebCore::RenderBR::selectionRectForRepaint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::desiredColumnWidth):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::selectionRectForRepaint):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

  • rendering/RenderListMarker.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::selectionRect):
(WebCore::RenderObject::selectionRectForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::RenderSelectionInfo):

  • rendering/RenderText.cpp:

(WebCore::RenderText::selectionRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::selectionHeight):

15:29 Changeset [90595] by gavinp@chromium.org
  • 7 edits
    2 adds in trunk

Reviewed by Alexey Proskuryakov.

fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60097

The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher. This patch
uses a CachedResourceHandle to keep the CachedResource alive.

Source/WebCore:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

LayoutTests:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.

  • fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
15:20 Changeset [90594] by aroben@apple.com
  • 2 edits in trunk/Tools

Update TestFailures's title and header immediately upon navigation

Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
title.
(ViewController.prototype._displayBuilder): Set the page's title and clear out any old
content immediately instead of waiting for the first set of results for the history
analyzer. As we receive new results from the analyzer we'll just clear out the main content
area and replace it with the new info.
(ViewController.prototype._displayTesters): Set the page's title and clear out any old
content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
in a little use of our removeAllChildren helper, too.
(ViewController.prototype._setTitle): Added. Set's the page's title and the header text.

15:14 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
15:12 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
15:11 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
15:09 Changeset [90593] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Patch by Jeff Timanus <twiz@chromium.org> on 2011-07-07
Reviewed by Stephen White.

Mark layout tests as failing in Chromium after skia roll r1799:r1814
https://bugs.webkit.org/show_bug.cgi?id=64121

  • platform/chromium/test_expectations.txt:
15:09 Changeset [90592] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

Patch by James Robinson <jamesr@chromium.org> on 2011-07-07
Reviewed by Kenneth Russell.

Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=42912

This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
garbage collection heuristics can account for the memory held by these objects. On the new test page, this
reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to <300MB.

Test: WebCore/manual-tests/array-buffer-memory.html

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

15:05 TestExpectations edited by dpranke@chromium.org
(diff)
15:05 TestExpectations edited by dpranke@chromium.org
(diff)
15:04 TestExpectations edited by dpranke@chromium.org
(diff)
15:04 TestExpectations edited by dpranke@chromium.org
(diff)
15:00 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
14:52 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
14:52 HackingOnNewRunWebKitTests created by dpranke@chromium.org
14:50 LayoutTestsSearchPath created by dpranke@chromium.org
14:49 HackingOnNRWT created by dpranke@chromium.org
14:48 TestExpectations created by dpranke@chromium.org
14:47 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
14:45 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
14:44 NewRunWebKitTests created by dpranke@chromium.org
14:37 WikiStart edited by dpranke@chromium.org
(diff)
14:37 Changeset [90591] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Move all code related to cachedSelection to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64118

Reviewed by Alexey Proskuryakov.

Moved m_cachedSelectionStart and m_cachedSelectionEnd from HTMLInputElement
and HTMLTextAreaElement to HTMLTextFormControlElement

Also removed cached selection related functions from RenderTextControl,
RenderTextControlSingleLine, and RenderTextControlMultiLine because they were
merely providing wrapper functions to enable polymorphism between
input and textarea elements and their WML equivalents.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::notifyRendererOfSelectionChange): Calls HTMLTextFormControlElement's
selectionChanged instead of RenderTextControl's.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initialize
m_cachedSelectionStart and m_cachedSelectionEnd.
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Added.
(WebCore::HTMLTextFormControlElement::selectionChanged): Extracted from
RenderTextControl::selectionChanged.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Extracted from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionStart): Added.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionEnd): Added.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::updateFocusAppearance):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::updateFocusAppearance):

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::isEmptyValue):

  • rendering/RenderTextControl.cpp:

(WebCore::setSelectionRange):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:
14:16 Changeset [90590] by eae@chromium.org
  • 19 edits in trunk/Source/WebCore

Switch addFocusRingRects to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64114

Reviewed by Eric Seidel.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h:

(WebCore::flooredLayoutPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addFocusRingRects):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::addFocusRingRects):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects):

  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::addFocusRingRects):

  • rendering/svg/RenderSVGPath.h:
14:06 Changeset [90589] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
https://bugs.webkit.org/show_bug.cgi?id=64052

Reviewed by James Robinson.

Layers and surfaces that are entirely transparent are now skipped.
Parent scissor rects are now applied to the content rect of surfaces
so that offscreen surfaces can be skipped.

Landing this for vangelis@chromium.org.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::calculateVisibleRect):
(WebCore::calculateVisibleLayerRect):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

13:45 Changeset [90588] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r90581.
http://trac.webkit.org/changeset/90581
https://bugs.webkit.org/show_bug.cgi?id=64124

Broke a bunch of inspector tests (Requested by ojan on
#webkit).

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):

13:37 Changeset [90587] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix crash when compositing gets disabled mid-paint
https://bugs.webkit.org/show_bug.cgi?id=64119

Reviewed by James Robinson.

WebKit paint can disable compositing and call setRootLayer(0). Adding
a check for this in drawLayers prevents a null pointer deref.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

13:26 Changeset [90586] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Encode jump and link sizes into the appropriate enums
https://bugs.webkit.org/show_bug.cgi?id=64123

Reviewed by Sam Weinig.

Finally kill off the out of line jump and link size arrays,
so we can avoid icky loads and constant fold the linking arithmetic.

  • assembler/ARMv7Assembler.cpp:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::computeJumpType):

13:17 Changeset [90585] by krit@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-07-07 Dirk Schulze <krit@webkit.org>

SVGAnimateTransform does not support calcMode=discrete
https://bugs.webkit.org/show_bug.cgi?id=63914

Reviewed by Rob Buis.

CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation.
Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation,
we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on
all other animations as well as on other SVG viewers.

Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104.

  • manual-tests/svg-animateTransform-calcMode-discrete.svg: Added.
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
12:13 Changeset [90584] by aroben@apple.com
  • 3 edits in trunk/Tools

Make Checkout use SCM's Executive instead of conjuring up its own

This will improve integration with the rest of webkitpy, particularly when invoked via
webkit-patch.

Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
Executive inappropriately

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
our own use. SCM might have some super-special Executive that it uses under the covers, and
we want to use it, too!

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
method to call through to Executive.run_command.

11:47 Changeset [90583] by aroben@apple.com
  • 2 edits in trunk/Tools

Make Term/ReadKey.pm an optional dependency of commit-log-editor

When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.

Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
Term/ReadKey.pm module

Reviewed by Xan Lopez.

  • Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load

Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
that existing commit messages will be preserved. (Users can manually remove existing commit
messages using git-reset.)

11:43 Changeset [90582] by krit@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by Rob Buis.

Source/WebCore:

SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865

Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.

Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment.

Test: svg/animations/svgpath-animation-1.html

  • svg/SVGAnimateElement.cpp:

(WebCore::getPropertyValue):
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::adjustForCurrentColor):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):

LayoutTests:

SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865

Test fallback to 'to' animation for 'by' animated SVGPath.

  • svg/animations/script-tests/svgpath-animation-1.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/svgpath-animation-1-expected.txt: Added.
  • svg/animations/svgpath-animation-1.html: Added.
11:38 Changeset [90581] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath):
11:33 CommitterTips edited by adele@apple.com
(diff)
11:15 Changeset [90580] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-07 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed.

Re-skip the inspector tests, they are still timing out on the
release bot for some reason.

  • platform/gtk/Skipped:
11:02 Changeset [90579] by aroben@apple.com
  • 2 edits in trunk/Tools

Keep testing that commit messages containing Unicode are handled properly by webkitpy

Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
correctly handle Unicode in commit messages

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in

places in the ChangeLog that will end up being included in the commit message.

10:45 Changeset [90578] by andreas.kling@nokia.com
  • 15 edits
    1 delete in trunk

[Qt][WK2] Remove Symbian code.
https://bugs.webkit.org/show_bug.cgi?id=64101

Reviewed by Benjamin Poulain.

Source/WebKit2:

  • DerivedSources.pro:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/SharedMemory.h:
  • Platform/qt/SharedMemorySymbian.cpp: Removed.
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebProcess.pro:
  • config.h:

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

10:43 Changeset [90577] by andreas.kling@nokia.com
  • 13 edits in trunk

[Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
https://bugs.webkit.org/show_bug.cgi?id=64099

Reviewed by Benjamin Poulain.

Source/WebKit2:

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::registerEditCommand):
(QtWebPageProxy::clearAllEditCommands):
(QtWebPageProxy::canUndoRedo):
(QtWebPageProxy::executeUndoRedo):
(QtWebPageProxy::updateAction):
(QtWebPageProxy::webActionTriggered):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didChangeCursor):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/WebUndoCommandQt.cpp:

(WebUndoCommandQt::WebUndoCommandQt):

  • UIProcess/qt/WebUndoCommandQt.h:
  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::WebDragClient::startDrag):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::openFile):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):

10:39 Changeset [90576] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip another test that uses beginDragWithFiles on Windows

  • platform/win/Skipped: Added fast/forms/file-input-change-event.html.
10:33 Changeset [90575] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Updated change log

10:29 Changeset [90574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.
https://bugs.webkit.org/show_bug.cgi?id=63313

Patch by Kyusun Kim <maniagoon@company100.net> on 2011-07-07
Reviewed by Eric Seidel.

  • platform/posix/SharedBufferPOSIX.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

10:27 Changeset [90573] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
https://bugs.webkit.org/show_bug.cgi?id=64102

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
'-webkit-column-break-inside: avoid' was specified.

LayoutTests:

  • fast/multicol/break-properties-expected.txt:
  • fast/multicol/break-properties.html:
10:27 Changeset [90572] by andreas.kling@nokia.com
  • 8 edits in trunk/Source/WebKit2

[Qt][WK2] Views should know about WebProcess crash/relaunch.
https://bugs.webkit.org/show_bug.cgi?id=64093

Reviewed by Benjamin Poulain.

Add processDidCrash() and didRelaunchProcess() to ViewInterface.

QDesktopWebView now displays a simple sad smiley ":(" when the
web process crashes.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(paintCrashedPage):
(QDesktopWebView::paint):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::showContextMenu):
(WebKit::TouchViewInterface::hideContextMenu):
(WebKit::TouchViewInterface::processDidCrash):
(WebKit::TouchViewInterface::didRelaunchProcess):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
10:18 Changeset [90571] by aroben@apple.com
  • 2 edits in trunk/Tools

Completely ignore too-many-failures builds in TestFailures in most circumstances

Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
really use them to perform regression analysis. The only time we want to pay attention to
too-many-failures builds is when we're trying to explain when the current bout of
too-many-failures started.

Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
in a build that didn't even run it (because it exited early due to too many failues)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
too-many-failures handling that would cause us to blame builds that didn't even run a given
test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
build was itself a too-many-failures build.

10:17 Changeset [90570] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255

Unreviewed gardening.

  • platform/qt/Skipped: Skip tests.
10:15 Changeset [90569] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: visual regressions in network panel
https://bugs.webkit.org/show_bug.cgi?id=64089

Reviewed by Pavel Feldman.

  • inspector/front-end/networkPanel.css:

(.data-grid.network-log-grid tr.filler td):
(.network.panel .sidebar):

10:05 Changeset [90568] by jchaffraix@webkit.org
  • 3 edits
    6 adds in trunk

Patch by Julien Chaffraix <jchaffraix@webkit.org> on 2011-07-07
Reviewed by David Hyatt.

Partial layout when a flex-box has visibility: collapse
https://bugs.webkit.org/show_bug.cgi?id=63776

Source/WebCore:

Tests: fast/flexbox/crash-button-input-autofocus.html

fast/flexbox/crash-button-keygen.html
fast/flexbox/crash-button-relayout.html

The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.

LayoutTests:

Those tests checks some variation of the same underlying issue.

  • fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
  • fast/flexbox/crash-button-input-autofocus.html: Added.
  • fast/flexbox/crash-button-keygen-expected.txt: Added.
  • fast/flexbox/crash-button-keygen.html: Added.
  • fast/flexbox/crash-button-relayout-expected.txt: Added.
  • fast/flexbox/crash-button-relayout.html: Added.
09:53 Changeset [90567] by vsevik@chromium.org
  • 5 edits in trunk

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
09:52 Changeset [90566] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(90557) http/tests/inspector/network/network-embed.html fails
https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed gardening.

  • platform/qt/Skipped: Skip test.
09:48 Changeset [90565] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: active panel does not receive resize event when drawer is resized
https://bugs.webkit.org/show_bug.cgi?id=64094

Reviewed by Pavel Feldman.

  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._statusBarDragging):
09:36 Changeset [90564] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach webkitpy's Checkout class to use commit-log-editor to create commit messages

Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
the modified ChangeLogs, to generate the commit message, rather than trying to generate one
ourselves.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message

to match commit-log-editor's format.
(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
directories so we can see how the various entries get labeled in the commit message.
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
instance that knows how to find commit-log-editor and pass it to our Checkout instance.
Don't bother capturing output, since there shouldn't be any.

09:36 Changeset [90563] by aroben@apple.com
  • 2 edits in trunk/Tools

Add a --print-log option to commit-log-editor

When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
generates a commit message from those ChangeLogs, prints it to stdout, and exits.

Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log

option, which calls through to createCommitMessage, prints the result, and exits.
(printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.

09:35 Changeset [90562] by aroben@apple.com
  • 2 edits in trunk/Tools

Extract commit-log-editor's commit-message-generation code into a separate function

As a bonus, we now skip a bunch of work in the case where we are generating a commit message
for staged git changes.

Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the

file so that it will be defined even if we aren't operating on an existing log message.
Moved a bunch of top-level code to generate the commit message from here...
(createCommitMessage): ...to here.

09:20 Changeset [90561] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Pavel Feldman <pfeldman@chromium.org>

Web Inspector: prevent default action during drag'n'drop in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=64081

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragend):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromPoint):
07:18 Changeset [90560] by zimmermann@webkit.org
  • 26 edits in trunk/Source/WebCore

2011-07-07 Nikolas Zimmermann <nzimmermann@rim.com>

Move remaining enums out of SVG*Element classes
https://bugs.webkit.org/show_bug.cgi?id=64075

Reviewed by Dirk Schulze.

Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
Also move the SVGPropertyTraits template specializations for enum types before the class
definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString
in the DECLARE_ANIMATED* macros, which is needed soon.

No new tests, just refactoring.

  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation):
  • rendering/svg/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::markerUnits):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeCommonGradientProperties):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::orientTypeAnimated):
  • svg/SVGMarkerElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
  • svg/SVGTextPathElement.h:
06:47 Changeset [90559] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-07 Xan Lopez <xlopez@igalia.com>

Unreviewed.

Enable inspector tests again (they should work now), and skip test
that is timing out in all GTK+ bots.

  • platform/gtk/Skipped:
06:44 Changeset [90558] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: Protocol: pointers to optional "in" parameters passing to the
backend methods should be NULL if they are not specified in the message.
https://bugs.webkit.org/show_bug.cgi?id=64083

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm: (generateBackendFunction): (generateArgumentGetters):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
06:12 Changeset [90557] by vsevik@chromium.org
  • 12 edits in trunk/LayoutTests

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing.
https://bugs.webkit.org/show_bug.cgi?id=64078

Reviewed by Pavel Feldman.

  • http/tests/inspector/network-test.js: (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep): (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData): (resetInspectorResourcesData):
  • http/tests/inspector/network/network-clear-cache-expected.txt:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies-expected.txt:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-embed-expected.txt:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
05:06 Changeset [90556] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: Searching on the Network panel doesn't do anything?
https://bugs.webkit.org/show_bug.cgi?id=55489

This is initial implementation of search in Network panel.
It is pretty simple search only for names and paths.

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkPanel.prototype._matchResource): (WebInspector.NetworkPanel.prototype._clearSearchMatchedList): (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource): (WebInspector.NetworkPanel.prototype.performSearch): (WebInspector.NetworkDataGridNode.prototype.createCells):
  • inspector/front-end/utilities.js: (String.prototype.escapeHTML): ():
04:33 Changeset [90555] by vsevik@chromium.org
  • 4 edits
    4 adds in trunk

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

  • http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
  • http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
  • http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
  • http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added. (body):

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.appendResource):
04:18 Changeset [90554] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

GTK: media/video-src-invalid-poster.html Failed
https://bugs.webkit.org/show_bug.cgi?id=61160

Wait for loadstart event to check the poster dimensions and avoid a
potential timeout of the test.

  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-poster.html:
  • platform/gtk/Skipped:
03:47 Changeset [90553] by vsevik@chromium.org
  • 16 edits
    6 adds in trunk

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Added clear cache and cookies tests. Since no port currently supports
this functionality, the tests are disabled.

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-clear-cache-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cache.html-disabled: Added.
  • http/tests/inspector/network/network-clear-cookies-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cookies.html-disabled: Added.
  • http/tests/inspector/network/resources/random-cached.php: Added.
  • http/tests/inspector/network/resources/set-cookie.php: Added.

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
  • inspector/front-end/Settings.js:

2011-07-07 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies):
  • src/WebDevToolsAgentImpl.h:
03:37 Changeset [90552] by commit-queue@webkit.org
  • 5 edits in trunk

2011-07-07 Shinya Kawanaka <shinyak@google.com>

Added more key bindings for input[type=range].
https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings tests for input[type=range].

Reviewed by Kent Tamura.

  • fast/forms/range-keyoperation-expected.txt: Regenerated.
  • fast/forms/range-keyoperation.html: Added more key bindings tests.

2011-07-07 Shinya Kawanaka <shinyak@google.com>

Added more key bindings for input[type=range].
https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings for input[type=range].
PageUp/PageDown change value by about 10%.
Home/End change value to minimum/maximum.

Reviewed by Kent Tamura.

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added key bindings.
03:29 Changeset [90551] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-07-07 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=63988

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (decidePolicyForNavigationAction): Ignore the action if a link is clicked with the middle buttonm and open the link in a new window. (browserWindowPolicyClientInit):
02:06 Changeset [90550] by commit-queue@webkit.org
  • 11 edits
    2 copies in trunk/Source/WebKit2

2011-07-07 Benjamin Poulain <benjamin@webkit.org>

[Qt] [WK2] Improve the handling of touch events to use them as main input
https://bugs.webkit.org/show_bug.cgi?id=63991

Reviewed by Kenneth Rohde Christiansen.

Promote touch event for use as primary input.

The touch events now use the responsiveness timer like the other input events.

The touch events also have a callback to the UI signaling if the event was used
or not: PageClient::doneWithTouchEvent().
This is similar to what is done with key events (PageClient::doneWithKeyEvent()).

  • Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::nativeEvent):
  • Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
  • Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent):
  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): (WebKit::WebPageProxy::didReceiveEvent):
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp: (QDesktopWebPageProxy::doneWithTouchEvent):
  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::doneWithTouchEvent): (QTouchWebPageProxy::touchEvent):
  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
01:03 Changeset [90549] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Tools

2011-07-07 Adam Barth <abarth@webkit.org>

Remove style_references.py
https://bugs.webkit.org/show_bug.cgi?id=64070

Reviewed by Eric Seidel.

We never really adopted the _references design, and this file is a bit
of an orphan at this point.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/python.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/style/main_unittest.py:
  • Scripts/webkitpy/style_references.py: Removed.
00:44 Changeset [90548] by eric@webkit.org
  • 2 edits
    1 add in trunk/Tools

2011-07-07 Eric Seidel <eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=64056

Unreviewed.

I had written this unittest prior to landing my change, but
had named it qt_unitest.py, so it wasn't running (nor was
it added to my git repo).

Once I fixe the name of the unittest file, it was very easy
to fix the error in webkit.py (which already had a FIXME).

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
00:26 Changeset [90547] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-07-07 Eric Seidel <eric@webkit.org>

Unreviewed. Add more debug logging about which test expectations we're using.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
00:25 Changeset [90546] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Remove unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=64065

Reviewed by Eric Seidel.

No one should be using this file any more. This patch removes it from
the face of the earth. This patch also removes two NRWT-specific
command line options that were implemented using
unexpected_results.json.

  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
00:16 Changeset [90545] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-07 Adam Barth <abarth@webkit.org>

REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
https://bugs.webkit.org/show_bug.cgi?id=64067

Reviewed by Eric Seidel.

The author of r90520 forgot to change the chromium_gpu.py implemenation
of this method as well.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
00:07 Changeset [90544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-07 Oleg Romashin <romaxa@gmail.com>

Fix InspectorInstrumentation compilation.
https://bugs.webkit.org/show_bug.cgi?id=64033

Reviewed by Yury Semikhatsky.

No new tests. just compile fix.

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):

07/06/11:

23:56 Changeset [90543] by eric@webkit.org
  • 13 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=64056

Reviewed by Adam Barth.

This fixes the MacPort's version of baseline_search_path to include
wk2 fallback like WebKitPort's does. This also re-works the QtPort
to set self._name (as other ports do) so that WebKitPort's default
implementations will understand Qt operating system flavors correctly
(including when running wk2 tests).

In trying to test this, I realized that nearly all of our port-tests
use the default FileSystem(), User() and Executive() objects, which
is really bad, because they expose details of your system in the unittest results!

Once I fixed many of the Port() calls to pass MockFileSystem(), then
MacPort.test_tests_for_other_platforms started failing, and I had to
teach MockFileSystem.glob how to handle directories to make it work again.

I removed the useless PortTestCase.test_baseline_search_path and replaced
it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
  • Scripts/webkitpy/tool/mocktool.py:
23:19 Changeset [90542] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Wean rebaseline-server off unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=64063

Reviewed by Eric Seidel.

In the process of changing this code to use full_results.json, I
noticed that the code was broken (because it wasn't tested). This
patch also adds test coverage for the broken code.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
22:36 Changeset [90541] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk

2011-07-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by David Hyatt.

[CSSRegions] Parse flow property
https://bugs.webkit.org/show_bug.cgi?id=61730

  • fast/regions/script-tests/TEMPLATE.html: Added.
  • fast/regions/script-tests/webkit-flow-parsing.js: Added. (test): (testComputedStyle): (testNotInherited):
  • fast/regions/webkit-flow-parsing-expected.txt: Added.
  • fast/regions/webkit-flow-parsing.html: Added.

2011-07-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by David Hyatt.

[CSSRegions] Parse flow property
https://bugs.webkit.org/show_bug.cgi?id=61730

Test: fast/regions/webkit-flow-parsing.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFlowThread):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::flowThread): (WebCore::InheritedFlags::setFlowThread): (WebCore::InheritedFlags::initialFlowThread):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
22:24 Changeset [90540] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-06 Adam Barth <abarth@webkit.org>

Unreviewed. Rolled DEPS.

  • DEPS:
22:24 Changeset [90539] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Wean resultsjsonparser off unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=64061

Reviewed by Eric Seidel.

We're about to delete unexpected_results.json, so we need to remove all
the users.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
21:42 Changeset [90538] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Cleanup result_summary.py
https://bugs.webkit.org/show_bug.cgi?id=64057

Reviewed by Eric Seidel.

This class had a bunch of out-of-date docstrings that no longer make
any sense.

  • Scripts/webkitpy/layout_tests/models/result_summary.py:
21:33 Changeset [90537] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
patches can be landed by the commit-queue.

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
21:22 Changeset [90536] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-07-06 MORITA Hajime <morrita@google.com>

[ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
https://bugs.webkit.org/show_bug.cgi?id=63977

Reviewed by Dimitri Glazkov.

This test have two set of fixture DOM tree:
One is for shadow tree which has one content element,
another is for light DOM tree, whose root is to have a shadow DOM.

Then the test makes 2 complete DOM trees (DOM tree with shadow and
flattened dom) for each combination of the fixture items. And
compare their layout result.

  • fast/dom/shadow/content-element-renderers-expected.txt: Added.
  • fast/dom/shadow/content-element-renderers.html: Added.

2011-07-06 MORITA Hajime <morrita@google.com>

[ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
https://bugs.webkit.org/show_bug.cgi?id=63977

Reviewed by Dimitri Glazkov.

NodeRenderingContext::nextRenderer() and previousRenderer() didn't work well
when it crosses content elements:

  • It doesn't step into forwarded children of ShadowContentElement.
  • It doesn't step out from traversing forwarded children to neighbors of the content element of that forwarded chidren.

This change makes it to step into and out from content element.

Test: fast/dom/shadow/content-element-renderers.html

  • dom/NodeRenderingContext.cpp: (WebCore::firstRendererOf): Added (WebCore::lastRendererOf): Added (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
21:20 Changeset [90535] by commit-queue@webkit.org
  • 15 edits
    4 adds in trunk

2011-07-06 Juan C. Montemayor <jmont@apple.com>

ASSERT_NOT_REACHED running test 262
https://bugs.webkit.org/show_bug.cgi?id=63951

Added a test to check compliance with reserved words in strict mode.
Updated test results.

Reviewed by Gavin Barraclough.

  • fast/js/kde/parse-expected.txt:
  • fast/js/reserved-words-as-property-expected.txt:
  • fast/js/reserved-words-strict-expected.txt: Added.
  • fast/js/reserved-words-strict.html: Added.
  • fast/js/script-tests/reserved-words-strict.js: Added. (isReserved):
  • platform/chromium/fast/js/reserved-words-strict-expected.txt: Added.
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:

2011-07-06 Juan C. Montemayor <jmont@apple.com>

ASSERT_NOT_REACHED running test 262
https://bugs.webkit.org/show_bug.cgi?id=63951

Added a case to the switch statement where the code was failing. Fixed
some logic as well that gave faulty error messages.

Reviewed by Gavin Barraclough.

  • parser/JSParser.cpp: (JSC::JSParser::getTokenName): (JSC::JSParser::updateErrorMessageSpecialCase): (JSC::JSParser::updateErrorMessage):
21:11 Changeset [90534] by abarth@webkit.org
  • 31 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Normalize callers of logging.getLogger to use name
https://bugs.webkit.org/show_bug.cgi?id=64054

Reviewed by Eric Seidel.

Most callers were already using name. This patch makes everyone
consistent.

  • Scripts/webkitpy/common/checkout/diff_parser.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/file_lock.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/models/result_summary.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  • Scripts/webkitpy/layout_tests/views/printing.py:
  • Scripts/webkitpy/python24/versioning.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/patchreader.py:
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
21:04 Changeset [90533] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <fpizlo@apple.com>

DFG JIT implementation of op_call results in regressions on sunspider
controlflow-recursive.
https://bugs.webkit.org/show_bug.cgi?id=64039

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::isSmallInt32Constant): (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::isInteger):
20:55 Changeset [90532] by abarth@webkit.org
  • 24 edits
    8 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Move model classes out of layout_package and into models
https://bugs.webkit.org/show_bug.cgi?id=64053

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/models: Added.
  • Scripts/webkitpy/layout_tests/models/init.py: Added.
  • Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
  • Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
  • Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/views/printing.py:
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
20:49 Changeset [90531] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

2011-07-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

[EFL] Add Fullscreen API feature
https://bugs.webkit.org/show_bug.cgi?id=63975

This is just to add disabled ENABLE_FULLSCREEN_API to OptionEFl.cmake.
ENABLE_FULLSCREEN_API will be enabled after finishing missing implementations.

Reviewed by Adam Barth.

  • Source/cmake/OptionsEfl.cmake: Add disabled ENABLE_FULLSCREEN_API feature.
  • Source/cmakeconfig.h.cmake: ditto.

2011-07-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

[EFL] Add Fullscreen API feature
https://bugs.webkit.org/show_bug.cgi?id=63975

Add needed files for enabling ENABLE_FULLSCREEN_API feature.

Reviewed by Adam Barth.

  • CMakeLists.txt: Add RenderFullScreen.cpp, fullscreen.css
20:48 Changeset [90530] by eae@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <eae@chromium.org>

Switch absoluteRects to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64035

Reviewed by Eric Seidel.

Move absoluteRects over to new layout unit abstraction.
Add flooredLayoutPoint, mapped to flooredIntPoint.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::flooredLayoutPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects):
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects):
  • rendering/svg/RenderSVGModelObject.h:
20:42 Changeset [90529] by commit-queue@webkit.org
  • 17 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <fpizlo@apple.com>

DFG JIT does not support method_check
https://bugs.webkit.org/show_bug.cgi?id=63972

Reviewed by Gavin Barraclough.

  • assembler/CodeLocation.h: (JSC::CodeLocationPossiblyNearCall::CodeLocationPossiblyNearCall):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
  • dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::recordGetMethod):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById): (JSC::DFG::JITCodeGenerator::cachedGetMethod):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addMethodGet): (JSC::DFG::JITCompiler::MethodGetRecord::MethodGetRecord):
  • dfg/DFGNode.h: (JSC::DFG::Node::hasIdentifier):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchGetMethodFast): (JSC::DFG::tryCacheGetMethod): (JSC::DFG::dfgRepatchGetMethod):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • jit/JITWriteBarrier.h: (JSC::JITWriteBarrier::set):
20:18 Changeset [90528] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-07-06 Dirk Pranke <dpranke@chromium.org>

nrwt: fix typo preventing http startup on windows
https://bugs.webkit.org/show_bug.cgi?id=64050

Reviewed by Eric Siedel.

NRWT checks whether it needs to start the servers by looking
for "/http/" in the test names. After r90520, the leading slash
is not present, so the check isn't quite right.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
19:49 Changeset [90527] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-07-06 Dirk Pranke <dpranke@chromium.org>

nrwt: remove --use-apache from the command line
https://bugs.webkit.org/show_bug.cgi?id=63358

Reviewed by Adam Barth.

Re-land the fix in bug 63358 - the prior fix was flawed in that
we were trying to start the http server during check_sys_deps()
but not actually setting up the environment properly. This
broken prior to this change, but exposed by it, since the patch
changes the chromium port to call the base class's checks.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:45 Changeset [90526] by abarth@webkit.org
  • 6 edits
    4 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Move view-related code out of layout_package and into views
https://bugs.webkit.org/show_bug.cgi?id=64051

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/views: Added.
  • Scripts/webkitpy/layout_tests/views/init.py: Added.
  • Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
  • Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
19:32 Changeset [90525] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch offsetFromContainer and related to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63659

Switch offsetFromContainer and related mapping methods to new layout unit
abstraction.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::enclosingLayoutRect): (WebCore::roundedLayoutPoint): (WebCore::roundedLayoutUnit): Add LayoutUnit versions of enclosingIntRect, roundedIntPoint and lroundf. For now these map to their int counterpart but once we switch to float or fixed point they'll be no-ops and eventually will be removed.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): (WebCore::RenderBox::offsetFromContainer):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::offsetFromContainer): (WebCore::RenderInline::mapLocalToContainer): (WebCore::RenderInline::mapAbsoluteToLocalPoint): (WebCore::RenderInline::relativePositionedInlineOffset):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::offsetFromAncestorContainer):
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::offsetFromContainer):
  • rendering/RenderTableCell.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::convertToPaintingRect):
19:24 Changeset [90524] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Add goofy comments to explain why we have these files.

  • Scripts/webkitpy/layout_tests/controllers/init.py:
  • Scripts/webkitpy/layout_tests/layout_package/init.py:
19:16 Changeset [90523] by abarth@webkit.org
  • 3 edits
    8 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
https://bugs.webkit.org/show_bug.cgi?id=64048

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers: Added.
  • Scripts/webkitpy/layout_tests/controllers/init.py: Added.
  • Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
  • Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:10 Changeset [90522] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-06 Levi Weintraub <leviw@chromium.org>

Switch FrameSelection to new Layout Types
https://bugs.webkit.org/show_bug.cgi?id=64043

Reviewed by Eric Seidel.

Switching the selection classes to the new layout types. Changing
NoXPosForVerticalArrowNavigation to a static inline since as it stood it violated
our global initializer rule when converted to numeric_limits from INT_MIN.

No new tests, no functionality changes.

  • editing/FrameSelection.cpp: (WebCore::FrameSelection::modify): (WebCore::absoluteCaretY): (WebCore::FrameSelection::lineDirectionPointForBlockDirectionNavigation): (WebCore::CaretBase::clearCaretRect): (WebCore::CaretBase::updateCaretRect): (WebCore::FrameSelection::localCaretRect): (WebCore::CaretBase::absoluteBoundsForLocalRect): (WebCore::FrameSelection::absoluteCaretBounds): (WebCore::repaintRectForCaret): (WebCore::CaretBase::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::FrameSelection::contains): (WebCore::DragCaretController::paintDragCaret): (WebCore::FrameSelection::bounds): (WebCore::FrameSelection::revealSelection):
  • editing/FrameSelection.h: (WebCore::CaretBase::localCaretRectWithoutUpdate):
18:50 Changeset [90521] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Attempt to fix unittest on Leopard. Let's enumerate the keys in sorted
order so the test results are predictable.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
18:22 Changeset [90520] by dpranke@chromium.org
  • 35 edits in trunk/Tools

2011-07-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

nrwt: make the code be consistent about using test names instead of filenames or paths

https://bugs.webkit.org/show_bug.cgi?id=63597

It can be hard to figure out where in the code we're assuming
test names are listed as unix-style relative filenames and where
they are either absolute paths or relative paths following the
host filesystem convention.

This patch changes things so that everything outside of the
Port object uses (and must assume) unix-style relative
filenames (with one exception, which is specifying host-local
filenames as a list of test arguments on the command line).

This should make things clearer and more consistent, and also
removes a lot of path conversion calls.

The changes in this patch outside of port/base.py are largely
cosmetic changes of "filename" to "test". We add a few routines
to the base Port implementation to manipulate test names to
split them, figure out if we're referring to a directory of
tests, etc.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
17:36 Changeset [90519] by ctguil@chromium.org
  • 2 edits in trunk/Tools

2011-07-06 Chris Guillory <ctguil@chromium.org>

No review necessary.

Adding myself to committers list in committers.py.
https://bugs.webkit.org/show_bug.cgi?id=63478

  • Scripts/webkitpy/common/config/committers.py:
17:09 Changeset [90518] by jnd@chromium.org
  • 7 edits in trunk

2011-07-06 Johnny Ding <jnd@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=63857
Remove some crash expectation after implementing "createPopupMenu"

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:

2011-07-06 Johnny Ding <jnd@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=63857
Check WebWidgetClient before calling it to close widget.

Reviewed by Tony Chang.

  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::popupClosed):

2011-07-06 Johnny Ding <jnd@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=63857
Implement createPopupMenu for Chromium DRT.

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createPopupMenu): (WebViewHost::~WebViewHost):
  • DumpRenderTree/chromium/WebViewHost.h:
16:55 Changeset [90517] by leviw@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-07-06 Levi Weintraub <leviw@chromium.org>

Switch Overflow and FrameRect methods in InlineBox to Layout Units
https://bugs.webkit.org/show_bug.cgi?id=64034

Reviewed by Eric Seidel.

Switching Overflow and FrameRect methods on InlineBox to new Layout Unit abstraction and
cleaning up some compilation errors that crop up when building with floating point layout units.

No new tests, no functionality changes.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
  • dom/Document.h:
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
  • platform/ScrollView.h: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::visibleHeight): (WebCore::ScrollableArea::visibleWidth):
  • platform/graphics/FloatPoint.h: Adding FloatPoint and FloatSize move[By] functions (WebCore::FloatPoint::move): (WebCore::FloatPoint::moveBy):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::layout):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::logicalLeftLayoutOverflow): (WebCore::InlineFlowBox::logicalRightLayoutOverflow): (WebCore::InlineFlowBox::logicalTopLayoutOverflow): (WebCore::InlineFlowBox::logicalBottomLayoutOverflow): (WebCore::InlineFlowBox::logicalLayoutOverflowRect): (WebCore::InlineFlowBox::visualOverflowRect): (WebCore::InlineFlowBox::logicalLeftVisualOverflow): (WebCore::InlineFlowBox::logicalRightVisualOverflow): (WebCore::InlineFlowBox::logicalTopVisualOverflow): (WebCore::InlineFlowBox::logicalBottomVisualOverflow): (WebCore::InlineFlowBox::logicalVisualOverflowRect): (WebCore::InlineFlowBox::frameRectIncludingLineHeight): (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault): (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault): (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault): (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
16:49 Changeset [90516] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Update Chromium GPU expectations with downstream changes
(http://crrev.com/91625/).

  • platform/chromium/test_expectations.txt:
16:38 Changeset [90515] by eae@chromium.org
  • 48 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch nodeAtPoint to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63663

No new tests, no functionality changes.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/LayoutTypes.h: (WebCore::toLayoutSize): (WebCore::toLayoutPoint): (WebCore::roundedLayoutPoint): (WebCore::roundedLayoutUnit):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::nodeAtPoint):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
  • rendering/svg/SVGInlineTextBox.h:
16:37 Changeset [90514] by mihaip@chromium.org
  • 9 edits in trunk/Tools

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Unreviewed, rolling out r90503.
http://trac.webkit.org/changeset/90503
https://bugs.webkit.org/show_bug.cgi?id=63358

Makes Chromium Windows canary bots hang.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:34 Changeset [90513] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Move buildbot URL in webkitpy to config.urls
https://bugs.webkit.org/show_bug.cgi?id=64041

Reviewed by Eric Seidel.

This patch prepares for using the buildbot class to talk to the
Chromium buildbots.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
16:25 Changeset [90512] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Sreeram Ramachandran <sreeram@chromium.org>

Fix fast/loader/page-dismissal-modal-dialogs.html.
https://bugs.webkit.org/show_bug.cgi?id=64020

Fix by removing an unnecessary call to setPopupBlockingEnabled() (which
doesn't seem to be implemented in WebKit2's layoutTestController).

Reviewed by Adam Roben.

  • fast/loader/page-dismissal-modal-dialogs.html:
16:21 Changeset [90511] by jamesr@google.com
  • 2 edits in branches/chromium/782/Source/WebKit/chromium

Merge 90185 - 2011-06-30 John Bates <jbates@google.com>

Reviewed by James Robinson.

Chromium bug: Compositing on a lost context causes latch deadlocks.
The cause of deadlock was that a setLatch command is added to the lost
compositor GL context, and a waitLatch would never complete on a child context.
This change checks whether the compositor context is in error state before
doing the compositing.
https://bugs.webkit.org/show_bug.cgi?id=63681

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

TBR=commit-queue@webkit.org
BUG=87996
Review URL: http://codereview.chromium.org/7316012

16:14 Changeset [90510] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, add the correct path to the waf build settings.

16:13 Changeset [90509] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

[wx] Unreviewed build fix. Don't expose the kit function to the swig wrappers.

16:09 Changeset [90508] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Add missing include.

  • Scripts/webkitpy/tool/bot/irc_command.py:
15:49 Changeset [90507] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Add roll-chromium-deps command to sheriff-bot
https://bugs.webkit.org/show_bug.cgi?id=64037

Reviewed by Eric Seidel.

Lo, and the DEPS were rolled on command.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/roll_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
15:34 Changeset [90506] by eric@webkit.org
  • 13 edits
    1 add in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

Split Driver, DriverOutput and DriverInput out into a new driver.py file
https://bugs.webkit.org/show_bug.cgi?id=64031

Reviewed by Adam Barth.

This ended up kinda large and I'm happy to break it up if desired.

As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
out into its own driver.py file.

I also cleaned up how we import Port objects, by making port/init.py
expose Port, Driver, DriverInput, and DriverOutput. I removed exposure of
some various test objects as they were causing circular dependencies.
base.py is now an implementation detail of port. No longer is "base" referenced
anywhere in the code.

I also made Driver.init non-virtual so that sub-classers could all share
the data storage on Driver. This more closely matches how other subclasses
work throughout our python code.

Standard line-unwrapping and doc-string removal as I went through the code.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/driver.py: Added.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
15:33 Changeset [90505] by enne@google.com
  • 9 edits in trunk/Source

2011-07-06 Adrienne Walker <enne@google.com>

[chromium] Add compositor texture manager soft limits and lost focus reclaiming
https://bugs.webkit.org/show_bug.cgi?id=64009

Reviewed by James Robinson.

Add a soft limit for texture memory. Unprotected textures will get
reclaimed when above this limit. Increase the hard limit for maximum
texture memory as well, now that there is a better heuristic and
textures are reclaimed from tabs without focus.

Landing this for vangelis@chromium.org.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::releaseTextures): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::protectTileTextures):
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::requestTexture):
  • platform/graphics/chromium/TextureManager.h: (WebCore::TextureManager::create):

2011-07-06 Adrienne Walker <enne@google.com>

[chromium] Add compositor texture manager soft limits and lost focus reclaiming
https://bugs.webkit.org/show_bug.cgi?id=64009

Reviewed by James Robinson.

Reclaim textures when the tab loses focus.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):
14:57 Changeset [90504] by aroben@apple.com
  • 2 edits in trunk/Tools

Clear TestFailures's getNumberOfFailingTests cache

Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
have been cached by old versions of TestFailures.

Fixes <http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
used it recently

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
that must match the current version. Otherwise we'll ignore the cached data.

14:46 Changeset [90503] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-06-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

nrwt: remove --use-apache from the command line
https://bugs.webkit.org/show_bug.cgi?id=63358

This change removes the --use-apache command line argument. It
was initially put in when we were trying to get the cygwin
apache instance to work with Chromium win, but that code has
bitrotted and doesn't work at all now.

Arguably we should remove all of the code to allow for a choice
of web servers, but since we may still want to switch off of
LigHTTPd at some point on Windows, I'll leave the rest in for
now (or at least yank it in a different change.)

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:40 Changeset [90502] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <fpizlo@apple.com>

DFG JIT op_call implementation will flush registers even when those registers are dead
https://bugs.webkit.org/show_bug.cgi?id=64023

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::emitCall):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::integerResult): (JSC::DFG::JITCodeGenerator::noResult): (JSC::DFG::JITCodeGenerator::cellResult): (JSC::DFG::JITCodeGenerator::jsValueResult): (JSC::DFG::JITCodeGenerator::doubleResult):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
14:39 Changeset [90501] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Fix duplicate Chromium expectations from r90500 and add additional flakiness
expectations.

  • platform/chromium/test_expectations.txt:
14:20 Changeset [90500] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Add Chromium Windows 7 timeout expectations.

  • platform/chromium/test_expectations.txt:
14:19 Changeset [90499] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Web Inspector: fixing typo introduced in the r90397.

  • inspector/front-end/StylesSidebarPane.js:
14:16 Changeset [90498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-07-06 Mike Reed <reed@google.com>

[skia] don't include deprecated header
https://bugs.webkit.org/show_bug.cgi?id=64025

Reviewed by James Robinson.

No new tests. Just removing #include of an unused header that will be gone soon

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp:
14:13 Changeset [90497] by cdn@chromium.org
  • 10 edits in trunk/Source

2011-06-30 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Fisher.

Add versioning to Chromium clipboard and prevent polling from inside events.
https://bugs.webkit.org/show_bug.cgi?id=63738

  • public/WebClipboard.h: (WebKit::WebClipboard::getSequenceNumber):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardGetSequenceNumber):

2011-06-30 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Fisher.

Add versioning to Chromium clipboard and prevent polling from inside events.
https://bugs.webkit.org/show_bug.cgi?id=63738

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::getSequenceNumber):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::platformClipboardChanged):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
  • platform/chromium/PlatformBridge.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
14:10 Changeset [90496] by dglazkov@chromium.org
  • 4 edits
    2 adds in trunk/Tools

2011-07-06 Dimitri Glazkov <dglazkov@chromium.org>

garden-o-matic should use a favicon to indicate current state.
https://bugs.webkit.org/show_bug.cgi?id=64027

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
14:09 Changeset [90495] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Daniel Bates <dbates@rim.com>

Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing
parameter to _fetch_file_from_results lamdba function.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
13:58 Changeset [90494] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Add Chromium flaky expectations.

  • platform/chromium/test_expectations.txt:
13:58 Changeset [90493] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.

13:56 Changeset [90492] by jamesr@google.com
  • 17 edits in trunk/Source/WebCore

2011-07-01 James Robinson <jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Externalize layer visibility calculation
https://bugs.webkit.org/show_bug.cgi?id=63847

This moves the layer visibility calculation from the layer itself out to LayerRendererChromium, like the other
calculated properties. Previously, we were doing this calculating at paint time and again at draw time and
relying on the fact that this produced the same value. This avoids the redundant calculation.

Covered by existing compositing/ layout tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::tilingTransform): (WebCore::ContentLayerChromium::contentBounds): (WebCore::ContentLayerChromium::updateLayerSize): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::setTilingOption): (WebCore::ContentLayerChromium::setIsMask):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::contentBounds):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentBounds): (WebCore::LayerChromium::visibleLayerRect): (WebCore::LayerChromium::setVisibleLayerRect): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::calculateVisibleLayerRect): (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::contentBounds): (WebCore::CCLayerImpl::setContentBounds): (WebCore::CCLayerImpl::visibleLayerRect): (WebCore::CCLayerImpl::setVisibleLayerRect): (WebCore::CCLayerImpl::doubleSided): (WebCore::CCLayerImpl::setDoubleSided):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::draw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
13:50 Changeset [90491] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

[GTK] Only set env. variables in start when strictly needed
https://bugs.webkit.org/show_bug.cgi?id=64026

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/gtk.py: add a setup_environ_for_server method in GtkPort and set as many env. variables as possible there.
13:49 Changeset [90490] by rniwa@webkit.org
  • 1 edit
    18 copies
    1 add in trunk/LayoutTests

2011-07-06 Ryosuke Niwa <rniwa@webkit.org>

REGRESSION (r90275): 18 editing tests failing on Windows 7 Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=64019

These tests just need rebaselines. While Windows WebKit port ignores editing delegate dumps, Windows WebKit2 does not.
Since rebaselined in r90275 should only affect Mac port, we need to undo rebaselines done in r90275 for Windows port.

  • platform/win/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
  • platform/win/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
  • platform/win/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
  • platform/win/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
  • platform/win/editing/deleting/delete-br-009-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-009-expected.txt.
  • platform/win/editing/deleting/delete-br-010-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-010-expected.txt.
  • platform/win/editing/inserting/insert-3800346-fix-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-3800346-fix-expected.txt.
  • platform/win/editing/inserting/insert-at-end-01-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-at-end-01-expected.txt.
  • platform/win/editing/inserting/insert-at-end-02-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-at-end-02-expected.txt.
  • platform/win/editing/inserting/insert-div-010-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-010-expected.txt.
  • platform/win/editing/inserting/insert-div-013-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.txt.
  • platform/win/editing/inserting/insert-div-015-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.txt.
  • platform/win/editing/inserting/insert-div-019-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-019-expected.txt.
  • platform/win/editing/inserting/insert-paragraph-03-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-paragraph-03-expected.txt.
  • platform/win/editing/selection/4932260-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4932260-1-expected.txt.
  • platform/win/editing/selection/move-by-word-001-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/move-by-word-001-expected.txt.
  • platform/win/editing/selection/triple-click-in-pre-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/triple-click-in-pre-expected.txt.
  • platform/win/editing/style: Added.
  • platform/win/editing/style/create-block-for-style-008-expected.txt: Copied from LayoutTests/platform/mac/editing/style/create-block-for-style-008-expected.txt.
13:42 Changeset [90489] by aroben@apple.com
  • 5 edits
    1 add in trunk/Tools

Teach TestFailures how to load, parse, and interpret NRWT test results

Fixes <http://webkit.org/b/61877> TestFailures page doesn't show testers that use
new-run-webkit-tests

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
pixel tests at all currently).
(Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
of failing tests from the buildbot output. Make sure not to count "new passes" (a new
category introduced by NRWT) as failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
_fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
to loading ORWT results.
(LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
parse the full_results.json file for the given build.
(LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
Fixed a bug along the way where we were sometimes calling the error callback instead of the
success callback when all tests passed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.

(NRWTResultsParser): Do-nothing constructor.
(NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
JS string, then iterates over all the tests in the results data and builds up a data
structure matching what ORWTResultsParser returns.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(Array.prototype.contains):
(String.prototype.contains):
Added these simple helper functions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

NRWTResultsParser.js.

13:42 Changeset [90488] by aroben@apple.com
  • 3 edits
    1 add in trunk/Tools

Extract code to parse ORWT's results.html file into its own class

Prep work for fixing <http://webkit.org/b/61877> TestFailures page doesn't show testers that
use new-run-webkit-tests

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.

(ORWTResultsParser):
(ORWTResultsParser.prototype.parse):
...to here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

ORWTResultsParser.js.

13:40 Changeset [90487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <fpizlo@apple.com>

DFG speculative JIT may crash when speculating int on a non-int JSConstant.
https://bugs.webkit.org/show_bug.cgi?id=64017

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): (JSC::DFG::SpeculativeJIT::compile):
13:27 Changeset [90486] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

IconDatabase::synchronousIconForPageURL() has inconsistent API when no custom icon is available
<https://bugs.webkit.org/show_bug.cgi?id=64015>
<rdar://problem/9706277>

For some URLs it would return a particular size of default icon; for other
URLs it would return 0.

Reviewed by Ada Chan.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
Return 0 in all cases where there is no custom icon.

13:20 Changeset [90485] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer::hitTest* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63640

Switch hit testing and supporting methods for RenderLayer over to the new
layout unit abstraction.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::roundedLayoutPoint): Add roundedLayoutPoint abstraction, calls roundedIntPoint now but will be a no-op (and eventually go away) once we switch to float or fixed point.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::hitTestList): (WebCore::RenderLayer::hitTestPaginatedChildLayer): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h:
13:15 Changeset [90484] by simon.fraser@apple.com
  • 6 edits in trunk/Source/WebCore

2011-07-06 Simon Fraser <simon.fraser@apple.com>

Have RenderLayerCompositor take care of clearing backing store when entering the page cache
https://bugs.webkit.org/show_bug.cgi?id=64018

Reviewed by Joseph Pecoraro.

Move responsibility for tearing down all RenderLayer backing stores from
RenderLayer itself to RenderLayerCompositor, since RenderLayerCompositor
manages backing store creation and destruction in general.

  • page/FrameView.cpp: (WebCore::FrameView::clearBackingStores):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants): (WebCore::RenderLayerCompositor::clearBackingForAllLayers):
  • rendering/RenderLayerCompositor.h:
12:52 Changeset [90483] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

Unreviewed. Fix a unittest from hitting the network. :)

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12:45 Changeset [90482] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

Unreviewed. Fixing an exception in test-webkitpy, caused by bug 64006.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12:21 Changeset [90481] by kov@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.com>

Run an Xvfb instance to run the API tests on, like we do for the
layout tests.

Reviewed by Xan Lopez.

  • Scripts/run-gtk-tests:
12:10 Changeset [90480] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Daniel Bates <dbates@webkit.org>

Make SCM unit tests faster
https://bugs.webkit.org/show_bug.cgi?id=63883

Speeds up the SCM unit tests by a factor of 4. Currently, we create a
mock SVN repo for each test_ method in SVNTest and GitTest and creating
this repo is expensive.

Instead, it is significantly faster to create the mock SVN repo once
and then perform a filesystem copy of it for each test_ method.

Note, Python 2.7's unittest module implements support for per class and
per module setup and tear down methods which could be used to implement
similar functionality. At the time of writing, test-webkitpy is designed
to support Python 2.5. So, we can't take advantage of these Python 2.7
features :(

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
12:07 Changeset [90479] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Remove unused parameter from _add_test in test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=64008

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
12:04 Changeset [90478] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-07-06 Ryuan Choi <ryuan.choi@samsung.com>

[Performance] Only call sendContentResizeNotification when the scrollbar actually did change
https://bugs.webkit.org/show_bug.cgi?id=47320

Reviewed by Eric Seidel.

Move avoidScrollbarCreation checking code from setHasHorizontalScrollbar
and setHasVerticalScrollbar to their caller in order to keep sendContentResizedNotification
false in case scrollbar is not really changed.
As a result, it will remove unnecessary relayout in the above case.

No new tests as this is very hard to write tests for. The bug only
occured when scrolling the sites which contain frame in browser with
frameFlattening. This should not change functionality in other case.

  • platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars):
11:58 Changeset [90477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-06 Dmitriy Vyukov <dvyukov@google.com>

Reviewed by David Levin.

Allow substitution of dynamic annotations and prevent identical code folding by the linker.
https://bugs.webkit.org/show_bug.cgi?id=62443

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
11:58 Changeset [90476] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Use old-run-webkit-tests when --leaks is present
https://bugs.webkit.org/show_bug.cgi?id=64012

Reviewed by Adam Roben.

We'll remove this branch once support of --leaks is added to
new-run-webkit-tests.

  • Scripts/run-webkit-tests:
11:41 Changeset [90475] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Tools

[Qt] [WK2] Add touch mocking to Qt's MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=63995

Reviewed by Andreas Kling.

The mouse events are intercepted through QCoreApplication::notify(),
and fake touch events are generated for mouse events when necessary.

If touch events are received from the platform, we assume the current
hardware has a touch screen and we stop generating fake events.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(isTouchEvent):
(isMouseEvent):
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
11:31 Changeset [90474] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
11:26 Changeset [90473] by mihaip@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Remove Chromium Mac failing expectation for fast/text/font-size-zero.html
(fixed by r89933)

Add Chromium Windows and Linux baselines for
fast/forms/textfield-overflow-by-value-update.html (needed due to
different form control metrics).

Remove a bunch of commented out test expectations.

  • platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:13 Changeset [90472] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

webkit-patch failure-reason does not understand NRWT results
https://bugs.webkit.org/show_bug.cgi?id=64006

Reviewed by Adam Barth.

Adam Barth tells me failure-reason should be deleted soon,
but aroben's fancy new TestFailures/ page doesn't work for
NRWT yet, and I needed to know when
third-party-cookie-relaxing started failing.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:59 Changeset [90471] by japhet@chromium.org
  • 8 edits in trunk

2011-07-06 Nate Chapin <japhet@chromium.org>

Don't let all subresources keep isLoadingInAPISense() from
returning false, only requests that affect
CachedResourceRequest::requestCount().
https://bugs.webkit.org/show_bug.cgi?id=62066

Reviewed by Adam Barth.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::dispatchWindowLoadEvent):
  • dom/Document.h: (WebCore::Document::loadEventFinished):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
10:57 Changeset [90470] by mihaip@chromium.org
  • 2 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-07-06 Mihai Parparita <mihaip@chromium.org>

Rebaseline some imagemap focus ring tests for Chromium Mac (mainly for
Leopard, due to text anti-aliasing differences).

  • platform/chromium-mac/fast/images/imagemap-case-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/images/imagemap-case-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
10:11 Changeset [90469] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

[GTK] Add missing environment variables in NWRT
https://bugs.webkit.org/show_bug.cgi?id=64004

Reviewed by Gustavo Noronha Silva.

Add missing environment variables needed by the GTK+ port.

  • Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
10:04 Changeset [90468] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-06 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
09:59 Changeset [90467] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] Seems that I still don't get the syntax right

Unreviewed.

  • platform/qt/test_expectations.txt: Use BUGWK instead of BUG.
09:56 Changeset [90466] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Fixed test_expectations syntax.

  • platform/chromium/test_expectations.txt:
09:50 Changeset [90465] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Marked media/video-delay-load-event.html as flaky on mac.

  • platform/chromium/test_expectations.txt:
09:42 Changeset [90464] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] Fix the syntax of test_expectations.txt

Unreviewed gardening.

  • platform/qt/test_expectations.txt: Add a bug for the flaky tests.
09:35 Changeset [90463] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <caseq@chromium.org>

Unreviewed, mark fast/events/click-focus-anchor.html as flaky.

  • platform/chromium/test_expectations.txt:
08:48 Changeset [90462] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] Try to make the bot green by marking tests flaky.

Rubber-stamped by Andreas Kling.

  • platform/qt/test_expectations.txt:
08:44 Changeset [90461] by aroben@apple.com
  • 2 edits in trunk/Tools

Make run-api-tests output intelligible on the bots

run-api-tests's output on the bots was very hard to read for two reasons:

1) It was mixing its own output with gtest's
2) It was using ANSI escape sequences to print colored text, but the bots don't support

that

Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
output will not be obscured. We still print "Timeout" messages even in verbose mode, since
gtest doesn't have any native support for timeouts. Also, when our output is being
redirected to a file, we don't print ANSI escape sequences.

Fixes <http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots

Reviewed by Sam Weinig.

  • Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to

use the colored function instead.
(runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
context that they aren't needed.
(runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
that for us. Also, use the new possiblyColored function instead of always coloring output.
(possiblyColored): Added. When printing to a tty, returns the string with the appropriate
ANSI color escape sequences added. Otherwise just returns the string unmodified.

08:25 Changeset [90460] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-07-06 Pavel Feldman <pfeldman@google.com>

Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
https://bugs.webkit.org/show_bug.cgi?id=63990

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::moveTo):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._removeChild): (WebInspector.DOMNode.prototype.ownerDocumentElement): (WebInspector.DOMNode.prototype.moveTo): (WebInspector.DOMAgent.prototype._childNodeRemoved):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragleave): (WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget): (WebInspector.ElementsTreeOutline.prototype._ondragend.callback): (WebInspector.ElementsTreeOutline.prototype._ondragend): (WebInspector.ElementsTreeOutline.prototype._clearDragOverTreeElementMarker): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu.focusElement): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.onattach):
  • inspector/front-end/inspector.css: (.outline-disclosure li.elements-drag-over .selection):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromEvent):
08:25 Changeset [90459] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Launch Xvfb (mostly) the same way we were launching it in the
bots, for maximum compatibility.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
08:22 Changeset [90458] by andreas.kling@nokia.com
  • 23 edits
    42 adds
    26 deletes in trunk

2011-07-06 Andreas Kling <kling@webkit.org>

[Qt][WK2] Split Qt API into two different web views (touch and desktop)
https://bugs.webkit.org/show_bug.cgi?id=63950

Co-authored with Benjamin Poulain <benjamin@webkit.org>.

Reviewed by Kenneth Rohde Christiansen.

Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.

The Qt MiniBrowser now defaults to QDesktopWebView but can be started
in QTouchWebView mode by passing -touch on the command line.

A lot of functionality has been removed and/or disabled from
MiniBrowser until we reintroduce the necessary API's.

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): (BrowserView::~BrowserView): (BrowserView::load): (BrowserView::view): (BrowserView::touchWebView): (BrowserView::desktopWebView):
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow): (BrowserWindow::webView): (BrowserWindow::newWindow): (BrowserWindow::showUserAgentDialog): (BrowserWindow::updateUserAgentList):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
  • MiniBrowser/qt/UrlLoader.cpp: (UrlLoader::UrlLoader):
  • MiniBrowser/qt/main.cpp: (main):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::wkView): (WTR::WebView::pageRef): (WTR::WebView::WebView): (WTR::PlatformWebView::page): (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame):

2011-07-06 Andreas Kling <kling@webkit.org>

[Qt][WK2] Split Qt API into two different web views (touch and desktop)
https://bugs.webkit.org/show_bug.cgi?id=63950

Co-authored with Benjamin Poulain <benjamin@webkit.org>.

Reviewed by Kenneth Rohde Christiansen.

Replace the QGraphicsWKView/QWKPage mess with QDesktopWebView and QTouchWebView.

QDesktopWebView is a traditional web view, similar to QGraphicsWebView. It will
will have the expected "desktop" behavior for things like subframes and
fixed-position elements.

QTouchWebView is intended for use on touch devices, and will manage the viewport,
gestures, tiled rendering, and other things that the user should never have to
worry about. It will use "resize to contents" and frame flattening by default.

API-wise, the biggest difference between the two is that QTouchWebView is really
a viewport that contains a QTouchWebPage. These are decoupled for flexibility in
UI design. This decoupling is not necessary for the desktop use-case, and so
QDesktopWebView is the only class we need.

Much of the Qt/WebKit2 API has been removed (snapshots, history, preferences..)
but will be re-added incrementally in a way that fits the new API vision.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp: Added. (QDesktopWebViewPrivate::QDesktopWebViewPrivate): (QDesktopWebViewPrivate::setViewNeedsDisplay): (QDesktopWebViewPrivate::drawingAreaSize): (QDesktopWebViewPrivate::contentSizeChanged): (QDesktopWebViewPrivate::isActive): (QDesktopWebViewPrivate::hasFocus): (QDesktopWebViewPrivate::isVisible): (QDesktopWebViewPrivate::startDrag): (QDesktopWebViewPrivate::didChangeUrl): (QDesktopWebViewPrivate::didChangeTitle): (QDesktopWebViewPrivate::didChangeToolTip): (QDesktopWebViewPrivate::didChangeStatusText): (QDesktopWebViewPrivate::didChangeCursor): (QDesktopWebViewPrivate::loadDidBegin): (QDesktopWebViewPrivate::loadDidSucceed): (QDesktopWebViewPrivate::didChangeLoadProgress): (QDesktopWebViewPrivate::showContextMenu): (QDesktopWebViewPrivate::hideContextMenu): (QDesktopWebView::QDesktopWebView): (QDesktopWebView::init): (QDesktopWebView::~QDesktopWebView): (QDesktopWebView::load): (QDesktopWebView::url): (QDesktopWebView::title): (QDesktopWebView::resizeEvent): (QDesktopWebView::paint): (QDesktopWebView::event): (QDesktopWebView::pageRef):
  • UIProcess/API/qt/qdesktopwebview.h: Added.
  • UIProcess/API/qt/qdesktopwebview_p.h: Added.
  • UIProcess/API/qt/qgraphicswkview.cpp: Removed.
  • UIProcess/API/qt/qgraphicswkview.h: Removed.
  • UIProcess/API/qt/qtouchwebpage.cpp: Added. (QTouchWebPage::QTouchWebPage): (QTouchWebPage::~QTouchWebPage): (QTouchWebPage::paint): (QTouchWebPage::load): (QTouchWebPage::url): (QTouchWebPage::title): (QTouchWebPage::focusNextPrevChildCallback): (QTouchWebPage::focusNextPrevChild): (QTouchWebPage::event): (QTouchWebPage::timerEvent): (QTouchWebPage::resizeEvent): (QTouchWebPagePrivate::QTouchWebPagePrivate): (QTouchWebPage::visibleRect): (QTouchWebPagePrivate::prepareScaleChange): (QTouchWebPagePrivate::commitScaleChange): (QTouchWebPagePrivate::onScaleChanged): (QTouchWebPagePrivate::setPage):
  • UIProcess/API/qt/qtouchwebpage.h: Added.
  • UIProcess/API/qt/qtouchwebpage_p.h: Added. (QTouchWebPagePrivate::getPageViewPrivate):
  • UIProcess/API/qt/qtouchwebview.cpp: Added. (QTouchWebViewPrivate::QTouchWebViewPrivate): (QTouchWebView::QTouchWebView): (QTouchWebView::~QTouchWebView): (QTouchWebView::page):
  • UIProcess/API/qt/qtouchwebview.h: Added.
  • UIProcess/API/qt/qtouchwebview_p.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: Removed.
  • UIProcess/API/qt/qwkpage.h: Removed.
  • UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Added.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Added. (tst_CommonViewTests::init): (tst_CommonViewTests::cleanup): (tst_CommonViewTests::baseUrl): (tst_CommonViewTests::loadEmptyUrl): (tst_CommonViewTests::loadEmptyPageViewVisible): (tst_CommonViewTests::loadEmptyPageViewHidden): (tst_CommonViewTests::show):
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Added. (WebViewAbstraction::WebViewAbstraction): (WebViewAbstraction::show): (WebViewAbstraction::hide): (WebViewAbstraction::load): (WebViewAbstraction::url): (WebViewAbstraction::touchViewLoadStarted): (WebViewAbstraction::desktopViewLoadStarted): (WebViewAbstraction::touchViewLoadSucceeded): (WebViewAbstraction::desktopViewLoadSucceeded): (WebViewAbstraction::touchWebView): (WebViewAbstraction::desktopWebView):
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Copied from Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp.
  • UIProcess/API/qt/tests/html/a.htm: Removed.
  • UIProcess/API/qt/tests/html/b.htm: Removed.
  • UIProcess/API/qt/tests/html/c.htm: Removed.
  • UIProcess/API/qt/tests/html/d.htm: Removed.
  • UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro.
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp. (tst_QDesktopWebView::init): (tst_QDesktopWebView::cleanup): (tst_QDesktopWebView::webView):
  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Removed.
  • UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro.
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Added. (tst_QTouchWebView::tst_QTouchWebView): (tst_QTouchWebView::init): (tst_QTouchWebView::cleanup): (tst_QTouchWebView::webView): (tst_QTouchWebView::accessPage):
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Removed.
  • UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Removed.
  • UIProcess/API/qt/tests/tests.pro:
  • UIProcess/API/qt/tests/testwindow.h: Added. (TestWindow::TestWindow): (TestWindow::resizeEvent):
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/qt/ClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/ClientImpl.cpp. (toQWKContext): (toQtWebPageProxy): (loadFinished): (qt_wk_didStartProvisionalLoadForFrame): (qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame): (qt_wk_didFailProvisionalLoadWithErrorForFrame): (qt_wk_didCommitLoadForFrame): (qt_wk_didFinishDocumentLoadForFrame): (qt_wk_didFinishLoadForFrame): (qt_wk_didFailLoadWithErrorForFrame): (qt_wk_didReceiveTitleForFrame): (qt_wk_didFirstLayoutForFrame): (qt_wk_didRemoveFrameFromHierarchy): (qt_wk_didFirstVisuallyNonEmptyLayoutForFrame): (qt_wk_didStartProgress): (qt_wk_didChangeProgress): (qt_wk_didFinishProgress): (qt_wk_didBecomeUnresponsive): (qt_wk_didBecomeResponsive): (qt_wk_createNewPage): (qt_wk_showPage): (qt_wk_close): (qt_wk_takeFocus): (qt_wk_runJavaScriptAlert): (qt_wk_setStatusText): (qt_wk_didSameDocumentNavigationForFrame): (qt_wk_didChangeIconForPageURL): (qt_wk_didRemoveAllIcons):
  • UIProcess/qt/ClientImpl.h: Renamed from Source/WebKit2/UIProcess/API/qt/ClientImpl.h.
  • UIProcess/qt/QtWebPageProxy.cpp: Added. (defaultWKContext): (contextMenuActionForWebAction): (dragOperationToDropActions): (dropActionToDragOperation): (QtWebPageProxy::QtWebPageProxy): (QtWebPageProxy::init): (QtWebPageProxy::~QtWebPageProxy): (QtWebPageProxy::handleEvent): (QtWebPageProxy::handleKeyPressEvent): (QtWebPageProxy::handleKeyReleaseEvent): (QtWebPageProxy::handleFocusInEvent): (QtWebPageProxy::handleFocusOutEvent): (QtWebPageProxy::setCursor): (QtWebPageProxy::setViewNeedsDisplay): (QtWebPageProxy::displayView): (QtWebPageProxy::scrollView): (QtWebPageProxy::viewSize): (QtWebPageProxy::isViewWindowActive): (QtWebPageProxy::isViewFocused): (QtWebPageProxy::isViewVisible): (QtWebPageProxy::isViewInWindow): (QtWebPageProxy::enterAcceleratedCompositingMode): (QtWebPageProxy::exitAcceleratedCompositingMode): (QtWebPageProxy::pageDidRequestScroll): (QtWebPageProxy::didChangeContentsSize): (QtWebPageProxy::toolTipChanged): (QtWebPageProxy::registerEditCommand): (QtWebPageProxy::clearAllEditCommands): (QtWebPageProxy::canUndoRedo): (QtWebPageProxy::executeUndoRedo): (QtWebPageProxy::convertToDeviceSpace): (QtWebPageProxy::screenToWindow): (QtWebPageProxy::windowToScreen): (QtWebPageProxy::convertToUserSpace): (QtWebPageProxy::selectionChanged): (QtWebPageProxy::doneWithKeyEvent): (QtWebPageProxy::createPopupMenuProxy): (QtWebPageProxy::createContextMenuProxy): (QtWebPageProxy::setFindIndicator): (QtWebPageProxy::didCommitLoadForMainFrame): (QtWebPageProxy::didFinishLoadingDataForCustomRepresentation): (QtWebPageProxy::flashBackingStoreUpdates): (QtWebPageProxy::pageRef): (QtWebPageProxy::didChangeUrl): (QtWebPageProxy::didChangeTitle): (QtWebPageProxy::didChangeStatusText): (QtWebPageProxy::showContextMenu): (QtWebPageProxy::hideContextMenu): (QtWebPageProxy::loadDidBegin): (QtWebPageProxy::loadDidSucceed): (QtWebPageProxy::didChangeLoadProgress): (QtWebPageProxy::paint): (QtWebPageProxy::updateAction): (QtWebPageProxy::updateNavigationActions): (QtWebPageProxy::webActionTriggered): (QtWebPageProxy::didRelaunchProcess): (QtWebPageProxy::processDidCrash): (QtWebPageProxy::setActualVisibleContentsRect): (QtWebPageProxy::preferences): (QtWebPageProxy::setCreateNewPageFunction): (QtWebPageProxy::setCustomUserAgent): (QtWebPageProxy::customUserAgent): (QtWebPageProxy::load): (QtWebPageProxy::url): (QtWebPageProxy::title): (QtWebPageProxy::setDrawingAreaSize): (QtWebPageProxy::textZoomFactor): (QtWebPageProxy::setTextZoomFactor): (QtWebPageProxy::pageZoomFactor): (QtWebPageProxy::setPageZoomFactor): (QtWebPageProxy::setPageAndTextZoomFactors): (QtWebPageProxy::history): (QtWebPageProxy::setResizesToContentsUsingLayoutSize): (QtWebPageProxy::triggerAction): (QtWebPageProxy::action): (QtWebPageProxy::findZoomableAreaForPoint): (QtWebPageProxy::didFindZoomableArea): (QtWebPageProxy::startDrag): (QtWebPageProxy::viewportVisibleRect): (QtWebPageProxy::isConnectedToEngine): (QtWebPageProxy::setPageIsVisible):
  • UIProcess/qt/QtWebPageProxy.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpage_p.h. (QtWebPageProxy::pageClosed): (QtWebPageProxy::customRepresentationZoomFactor): (QtWebPageProxy::setCustomRepresentationZoomFactor): (QtWebPageProxy::didChangeScrollbarsForMainFrame): (QtWebPageProxy::findStringInCustomRepresentation): (QtWebPageProxy::countStringMatchesInCustomRepresentation): (QtWebPageProxy::userSpaceScaleFactor): (QtWebPageProxy::createNewPageFunction):
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::page):
  • UIProcess/qt/TouchViewInterface.cpp: Added. (WebKit::TouchViewInterface::TouchViewInterface): (WebKit::TouchViewInterface::setViewNeedsDisplay): (WebKit::TouchViewInterface::drawingAreaSize): (WebKit::TouchViewInterface::contentSizeChanged): (WebKit::TouchViewInterface::isActive): (WebKit::TouchViewInterface::hasFocus): (WebKit::TouchViewInterface::isVisible): (WebKit::TouchViewInterface::startDrag): (WebKit::TouchViewInterface::didChangeUrl): (WebKit::TouchViewInterface::didChangeTitle): (WebKit::TouchViewInterface::didChangeToolTip): (WebKit::TouchViewInterface::didChangeStatusText): (WebKit::TouchViewInterface::didChangeCursor): (WebKit::TouchViewInterface::loadDidBegin): (WebKit::TouchViewInterface::loadDidSucceed): (WebKit::TouchViewInterface::didChangeLoadProgress): (WebKit::TouchViewInterface::showContextMenu): (WebKit::TouchViewInterface::hideContextMenu):
  • UIProcess/qt/TouchViewInterface.h: Added. (WebKit::TouchViewInterface::pageView):
  • UIProcess/qt/ViewInterface.cpp: Added. (WebKit::ViewInterface::ownerWidget):
  • UIProcess/qt/ViewInterface.h: Added.
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp: Added. (dragOperationToDropAction): (QDesktopWebPageProxy::QDesktopWebPageProxy): (QDesktopWebPageProxy::createDrawingAreaProxy): (QDesktopWebPageProxy::paintContent): (QDesktopWebPageProxy::setViewportArguments): (QDesktopWebPageProxy::handleEvent): (QDesktopWebPageProxy::handleMouseMoveEvent): (QDesktopWebPageProxy::handleMousePressEvent): (QDesktopWebPageProxy::handleMouseReleaseEvent): (QDesktopWebPageProxy::handleMouseDoubleClickEvent): (QDesktopWebPageProxy::handleWheelEvent): (QDesktopWebPageProxy::handleHoverMoveEvent): (QDesktopWebPageProxy::handleDragEnterEvent): (QDesktopWebPageProxy::handleDragLeaveEvent): (QDesktopWebPageProxy::handleDragMoveEvent): (QDesktopWebPageProxy::handleDropEvent): (QDesktopWebPageProxy::timerEvent):
  • UIProcess/qt/qdesktopwebpageproxy.h: Added.
  • UIProcess/qt/qtouchwebpageproxy.cpp: Added. (QTouchWebPageProxy::QTouchWebPageProxy): (QTouchWebPageProxy::createDrawingAreaProxy): (QTouchWebPageProxy::paintContent): (QTouchWebPageProxy::setViewportArguments): (QTouchWebPageProxy::handleEvent): (QTouchWebPageProxy::touchEvent):
  • UIProcess/qt/qtouchwebpageproxy.h: Added. (QTouchWebPageProxy::touchViewInterface): (QTouchWebPageProxy::pageView):
  • UIProcess/qt/qwkcontext.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext.cpp. (initializePlatformStrategiesIfNeeded): (QWKContextPrivate::QWKContextPrivate): (QWKContextPrivate::~QWKContextPrivate): (QWKContext::QWKContext): (QWKContext::~QWKContext): (QWKContext::setIconDatabasePath): (QWKContext::iconForPageURL):
  • UIProcess/qt/qwkcontext.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext.h.
  • UIProcess/qt/qwkcontext_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext_p.h.
  • UIProcess/qt/qwkhistory.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory.cpp. (QWKHistoryItemPrivate::QWKHistoryItemPrivate): (QWKHistoryItemPrivate::~QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::QWKHistoryItem::operator=): (QWKHistoryItem::~QWKHistoryItem): (QWKHistoryItem::title): (QWKHistoryItem::url): (QWKHistoryPrivate::QWKHistoryPrivate): (QWKHistoryPrivate::createHistory): (QWKHistoryPrivate::~QWKHistoryPrivate): (QWKHistory::QWKHistory): (QWKHistory::~QWKHistory): (QWKHistory::backListCount): (QWKHistory::forwardListCount): (QWKHistory::count): (QWKHistory::currentItem): (QWKHistory::backItem): (QWKHistory::forwardItem): (QWKHistory::itemAt): (QWKHistory::goToItemAt): (QWKHistory::backItems): (QWKHistory::forwardItems):
  • UIProcess/qt/qwkhistory.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory.h.
  • UIProcess/qt/qwkhistory_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory_p.h.
  • UIProcess/qt/qwkpreferences.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences.cpp. (QWKPreferencesPrivate::createPreferences): (QWKPreferencesPrivate::createSharedPreferences): (QWKPreferences::sharedPreferences): (QWKPreferences::QWKPreferences): (QWKPreferences::~QWKPreferences): (QWKPreferences::setFontFamily): (QWKPreferences::fontFamily): (QWKPreferences::testAttribute): (QWKPreferences::setAttribute): (QWKPreferences::setFontSize): (QWKPreferences::fontSize):
  • UIProcess/qt/qwkpreferences.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences.h.
  • UIProcess/qt/qwkpreferences_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences_p.h.
  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
07:24 Changeset [90457] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WKPageCopyStandardUserAgentWithApplicationName
https://bugs.webkit.org/show_bug.cgi?id=63953

Reviewed by Adam Roben.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyStandardUserAgentWithApplicationName): Added.

  • UIProcess/API/C/WKPagePrivate.h: Added WKPageCopyStandardUserAgentWithApplicationName().
  • UIProcess/WebPageProxy.h: Make standardUserAgent() public.
06:45 Changeset [90456] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <abecsi@webkit.org>

Fix "warning: a `;' might be needed at the end of action code"

Unreviewed gardening.

No new tests needed.

  • css/CSSGrammar.y: Future versions of Bison will not add the ';' so add it.
06:41 Changeset [90455] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] DumpRenderTree needs a beginDragWithFiles implementation
https://bugs.webkit.org/show_bug.cgi?id=50902

Unreviewed gardening.

  • platform/qt/Skipped: Skip failing test added in r90438.
06:17 Changeset [90454] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] Revome unused but set shadowBlur variable after r90406.

Unreviewed build fix.

No new tests needed.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): Use the GraphicsContext brush.
05:18 Changeset [90453] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <xlopez@igalia.com>

Unreviewed.

Remove non-existing test from Skipped.

  • platform/gtk/Skipped:
05:13 Changeset [90452] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <xlopez@igalia.com>

Unreviewed.

Missed these inspector tests before.

  • platform/gtk/Skipped:
04:34 Changeset [90451] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <xlopez@igalia.com>

Unreviewed.

Skip inspector tests while we figure why they fail in the
NWRT/debug bots.

  • platform/gtk/Skipped:
04:15 Changeset [90450] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <abecsi@webkit.org>

[Qt] Remove duplicate entries of ShadowBlur sources from project file.

Rubber-stamped by Csaba Osztrogonác.

No new tests needed.

  • WebCore.pro: These files were already added in r84410.
04:03 Changeset [90449] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

Unreviewed..

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
    • Fix the pass-thru of --gtk and --qt for old-run-webkit-tests, it was previously broken by the existence of isGtk/isQt checks which removed the --gtk/--qt args from @ARGV.
03:28 Changeset [90448] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-07-06 Eric Seidel <eric@webkit.org>

new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
https://bugs.webkit.org/show_bug.cgi?id=63983

Reviewed by Xan Lopez.

All WebKit ports want to use a 35s timeout. Only chromium currently
uses a 6s timeout. Eventually we'll move all WebKit ports to 6s too
to further speed up new-run-webkit-tests runs, but that's going to be a while.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
03:13 Changeset [90447] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

Unreviewed.

NWRT actually seems to work locally, so it should work in the bots
as long as we take care of the TIMEOUT issue (which is being fixed
as I write this). Let's give this another shot and fix whatever
breaks.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
02:14 Changeset [90446] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <xlopez@igalia.com>

Unreviewed.

Disable NWRT on GTK. At the very least it needs an updated exected
results file since NWRT is more sensitive to timeouts, not sure
what the exact problem is.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
01:06 Changeset [90445] by yutak@chromium.org
  • 6 edits
    160 moves
    9 adds
    1 delete in trunk/LayoutTests

2011-07-05 Yuta Kitamura <yutak@chromium.org>

WebSocket: Move current WebSocket tests to a new directory
https://bugs.webkit.org/show_bug.cgi?id=63931

Reviewed by Kent Tamura.

In order to put tests for new WebSocket protocol, existing tests for the old protocol
need to be moved to a subdirectory (namely "hixie76").

Minimum changes have been made to tests and test results, such as:

  • Update links to resource files (e.g. "../../../js-test-pre.js" to "../../../../js-test-pre.js"), and
  • Update WebSocket URLs in the tests (i.e. adding "hixie76/" to ws:// and wss:// URLs).

Skipped and test_expectations.txt are also updated accordingly.

  • http/tests/websocket/tests/handler_map.txt: This is the only file left in the current directory. This file defines the handler location to which accesses to the root directory (e.g. "ws://example.com/") are redirected, and cannot be moved.
  • http/tests/websocket/tests/hixie76/alert-in-event-handler-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/alert-in-event-handler-expected.txt.
  • http/tests/websocket/tests/hixie76/alert-in-event-handler.html: Renamed from LayoutTests/http/tests/websocket/tests/alert-in-event-handler.html.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash.html.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash_wsh.py.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-control-chars.html.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-empty-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-empty.html.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-non-ascii.html.
  • http/tests/websocket/tests/hixie76/bufferedAmount-after-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bufferedAmount-after-close-expected.txt.
  • http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html: Renamed from LayoutTests/http/tests/websocket/tests/bufferedAmount-after-close.html.
  • http/tests/websocket/tests/hixie76/client-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/client-close-expected.txt.
  • http/tests/websocket/tests/hixie76/client-close.html: Renamed from LayoutTests/http/tests/websocket/tests/client-close.html.
  • http/tests/websocket/tests/hixie76/client-close_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/client-close_wsh.py.
  • http/tests/websocket/tests/hixie76/close-before-open-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-before-open-expected.txt.
  • http/tests/websocket/tests/hixie76/close-before-open.html: Renamed from LayoutTests/http/tests/websocket/tests/close-before-open.html.
  • http/tests/websocket/tests/hixie76/close-event-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-event-expected.txt.
  • http/tests/websocket/tests/hixie76/close-event.html: Renamed from LayoutTests/http/tests/websocket/tests/close-event.html.
  • http/tests/websocket/tests/hixie76/close-on-navigate-new-location-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-navigate-new-location-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-navigate-new-location.html.
  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-and-force-gc-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-and-force-gc.html.
  • http/tests/websocket/tests/hixie76/close-on-unload-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-reference-in-parent.html.
  • http/tests/websocket/tests/hixie76/close-on-unload.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload.html.
  • http/tests/websocket/tests/hixie76/close-on-unload_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload_wsh.py.
  • http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-unref-websocket-expected.txt.
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html: Renamed from LayoutTests/http/tests/websocket/tests/close-unref-websocket.html.
  • http/tests/websocket/tests/hixie76/cross-origin-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/cross-origin-expected.txt.
  • http/tests/websocket/tests/hixie76/cross-origin.html: Renamed from LayoutTests/http/tests/websocket/tests/cross-origin.html.
  • http/tests/websocket/tests/hixie76/echo-challenge_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-challenge_wsh.py.
  • http/tests/websocket/tests/hixie76/echo-cookie_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-cookie_wsh.py.
  • http/tests/websocket/tests/hixie76/echo-location_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-location_wsh.py.
  • http/tests/websocket/tests/hixie76/echo_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo_wsh.py.
  • http/tests/websocket/tests/hixie76/error-detect-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/error-detect-expected.txt.
  • http/tests/websocket/tests/hixie76/error-detect.html: Renamed from LayoutTests/http/tests/websocket/tests/error-detect.html.
  • http/tests/websocket/tests/hixie76/fixed-origin_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/fixed-origin_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer.html.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-overflow-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-overflow.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow.html.
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-skip-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-skip.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip.html.
  • http/tests/websocket/tests/hixie76/frame-length-skip_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-lengths-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-lengths-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-lengths.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-lengths.html.
  • http/tests/websocket/tests/hixie76/handshake-challenge-randomness-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-challenge-randomness-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-challenge-randomness.html.
  • http/tests/websocket/tests/hixie76/handshake-error-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-error.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error.html.
  • http/tests/websocket/tests/hixie76/handshake-error_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-cross-origin.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html.
  • http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/hanging-handshake_wsh.py.
  • http/tests/websocket/tests/hixie76/httponly-cookie-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/httponly-cookie-expected.txt.
  • http/tests/websocket/tests/hixie76/httponly-cookie.pl: Renamed from LayoutTests/http/tests/websocket/tests/httponly-cookie.pl.
  • http/tests/websocket/tests/hixie76/long-invalid-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header-expected.txt.
  • http/tests/websocket/tests/hixie76/long-invalid-header.html: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header.html.
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header_wsh.py.
  • http/tests/websocket/tests/hixie76/multiple-connections-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/multiple-connections-expected.txt.
  • http/tests/websocket/tests/hixie76/multiple-connections.html: Renamed from LayoutTests/http/tests/websocket/tests/multiple-connections.html.
  • http/tests/websocket/tests/hixie76/no-query_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/no-query_wsh.py.
  • http/tests/websocket/tests/hixie76/null-character-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/null-character-expected.txt.
  • http/tests/websocket/tests/hixie76/null-character.html: Renamed from LayoutTests/http/tests/websocket/tests/null-character.html.
  • http/tests/websocket/tests/hixie76/origin-test_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/origin-test_wsh.py.
  • http/tests/websocket/tests/hixie76/protocol-test_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/protocol-test_wsh.py.
  • http/tests/websocket/tests/hixie76/reload-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/reload-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/reload-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/reload-crash.html.
  • http/tests/websocket/tests/hixie76/resources/close-on-unload-iframe-reference-in-parent.html: Renamed from LayoutTests/http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html.
  • http/tests/websocket/tests/hixie76/resources/close-on-unload-iframe.html: Renamed from LayoutTests/http/tests/websocket/tests/resources/close-on-unload-iframe.html.
  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html: Added.
  • http/tests/websocket/tests/hixie76/send-after-close-on-unload-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-after-close-on-unload-expected.txt.
  • http/tests/websocket/tests/hixie76/send-after-close-on-unload.html: Renamed from LayoutTests/http/tests/websocket/tests/send-after-close-on-unload.html.
  • http/tests/websocket/tests/hixie76/send-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-expected.txt.
  • http/tests/websocket/tests/hixie76/send-throw-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-throw-expected.txt.
  • http/tests/websocket/tests/hixie76/send-throw.html: Renamed from LayoutTests/http/tests/websocket/tests/send-throw.html.
  • http/tests/websocket/tests/hixie76/send.html: Renamed from LayoutTests/http/tests/websocket/tests/send.html.
  • http/tests/websocket/tests/hixie76/send2_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/send2_wsh.py.
  • http/tests/websocket/tests/hixie76/send_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/send_wsh.py.
  • http/tests/websocket/tests/hixie76/server-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/server-close-expected.txt.
  • http/tests/websocket/tests/hixie76/server-close.html: Renamed from LayoutTests/http/tests/websocket/tests/server-close.html.
  • http/tests/websocket/tests/hixie76/server-close_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/server-close_wsh.py.
  • http/tests/websocket/tests/hixie76/simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/simple-expected.txt.
  • http/tests/websocket/tests/hixie76/simple-stress-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/simple-stress-expected.txt.
  • http/tests/websocket/tests/hixie76/simple-stress.html: Renamed from LayoutTests/http/tests/websocket/tests/simple-stress.html.
  • http/tests/websocket/tests/hixie76/simple.html: Renamed from LayoutTests/http/tests/websocket/tests/simple.html.
  • http/tests/websocket/tests/hixie76/simple_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/simple_wsh.py.
  • http/tests/websocket/tests/hixie76/sub-protocol-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-expected.txt.
  • http/tests/websocket/tests/hixie76/sub-protocol-with-space-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-with-space-expected.txt.
  • http/tests/websocket/tests/hixie76/sub-protocol-with-space.html: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-with-space.html.
  • http/tests/websocket/tests/hixie76/sub-protocol.html: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol.html.
  • http/tests/websocket/tests/hixie76/unicode-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/unicode-expected.txt.
  • http/tests/websocket/tests/hixie76/unicode.html: Renamed from LayoutTests/http/tests/websocket/tests/unicode.html.
  • http/tests/websocket/tests/hixie76/unicode_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/unicode_wsh.py.
  • http/tests/websocket/tests/hixie76/unknown-frame-type_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/unknown-frame-type_wsh.py.
  • http/tests/websocket/tests/hixie76/url-no-trailing-slash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-no-trailing-slash-expected.txt.
  • http/tests/websocket/tests/hixie76/url-no-trailing-slash.html: Renamed from LayoutTests/http/tests/websocket/tests/url-no-trailing-slash.html.
  • http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-parsing-expected.txt.
  • http/tests/websocket/tests/hixie76/url-parsing.html: Renamed from LayoutTests/http/tests/websocket/tests/url-parsing.html.
  • http/tests/websocket/tests/hixie76/url-with-credential-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-credential-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-credential.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-credential.html.
  • http/tests/websocket/tests/hixie76/url-with-empty-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-empty-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-empty-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-empty-query.html.
  • http/tests/websocket/tests/hixie76/url-with-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-for-no-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-for-no-query.html.
  • http/tests/websocket/tests/hixie76/url-with-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query.html.
  • http/tests/websocket/tests/hixie76/websocket-event-target-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-event-target-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-event-target.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-event-target.html.
  • http/tests/websocket/tests/hixie76/websocket-pending-activity-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-pending-activity-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-pending-activity.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-pending-activity.html.
  • http/tests/websocket/tests/hixie76/websocket-protocol-ignored-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-protocol-ignored-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-protocol-ignored.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-onmessage-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-onmessage-crash.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-shared-worker-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-shared-worker-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-shared-worker.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-worker-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-worker-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-worker.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-worker.html.
  • http/tests/websocket/tests/hixie76/workers/resources/close-in-onmessage-crash.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/close-in-onmessage-crash.js. (runTests.try.ws.onopen): (runTests.try.ws.onmessage): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/close-in-worker.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/close-in-worker.js. (handleConnect.self.postMessage): (handleConnect): (runTests.try.ws.onopen): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/echo-challenge_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/echo-challenge_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/echo_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/echo_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/simple_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/simple_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/worker-handshake-challenge-randomness.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/worker-handshake-challenge-randomness.js. (endTest): (runTests.try.ws1.onmessage): (runTests.try.ws1.onclose.ws2.onmessage): (runTests.try.ws1.onclose.ws2.onclose): (runTests.try.ws1.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/worker-simple.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/worker-simple.js. (handleConnect.self.postMessage): (handleConnect): (runTests.try.ws.onopen): (runTests.try.ws.onmessage): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/shared-worker-simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/shared-worker-simple-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/shared-worker-simple.html.
  • http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html.
  • http/tests/websocket/tests/hixie76/workers/worker-simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-simple-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/worker-simple.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-simple.html.
  • http/tests/websocket/tests/resources/reload-crash-iframe.html: Removed.
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/qt-arm/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt.
  • platform/win/Skipped:
00:56 Changeset [90444] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

Fix global variable leak detected by noglobals.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
00:44 Changeset [90443] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Calls on 32 bit machines are failed after r90423
https://bugs.webkit.org/show_bug.cgi?id=63980

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-07-06
Reviewed by Gavin Barraclough.

Copy the necessary lines from JITCall.cpp.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

00:39 Changeset [90442] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <abarth@webkit.org>

garden-o-matic shouldn't show flaky tests by default
https://bugs.webkit.org/show_bug.cgi?id=63979

Reviewed by Ojan Vafai.

If any of the actual test results are PASS, the test is flaky and we
can ignore it (at least for now). If we get awesome at dealing with
failing tests, we might want to tackle flaky tests by refering the user
to the flakiness dashboard, which is way more awesome at dealing with
flaky tests that this tool ever will be.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
00:04 Changeset [90441] by abarth@webkit.org
  • 7 edits
    3 adds in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

garden-o-matic should list the failing tests
https://bugs.webkit.org/show_bug.cgi?id=63978

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

07/05/11:

23:59 Changeset [90440] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Re-enable NRWT on Leopard now that bug 63973 is fixed.

Reviewed by Adam Barth.

I also made the should-enable expression a black-list instead
of a white-list since every bot on build.webkit.org is
now using NRWT except windows and WebKit2 bots.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
23:55 Changeset [90439] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Perl string concat failure on Leopard (causes NRWT to fail)
https://bugs.webkit.org/show_bug.cgi?id=63973

Reviewed by Daniel Bates.

Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
thus the version parsing logic in webkitdirs.pm seems to fail.

Default to "3.0" instead of undef when we can't parse the version number.
This should send us down the correct path for Leopard.

  • Scripts/webkitdirs.pm: (determineBaseProductDir):
23:36 Changeset [90438] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-07-05 Kentaro Hara <haraken@google.com>

Trigger a 'change' event whenever selected files are changed
https://bugs.webkit.org/show_bug.cgi?id=63929

Reviewed by Kent Tamura.

Record previously selected files and then compare them with newly selected files.
If the previously selected files and their order are not equal to those of
the newly selected files, we trigger the 'change' event.

  • fast/forms/file-input-change-event-expected.txt: Added.
  • fast/forms/file-input-change-event.html: Added.

2011-07-05 Kentaro Hara <haraken@google.com>

Trigger a 'change' event whenever selected files are changed
https://bugs.webkit.org/show_bug.cgi?id=63929

Reviewed by Kent Tamura.

Record previously selected files and then compare them with newly selected files.
If the previously selected files and their order are not equal to those of
the newly selected files, we trigger the 'change' event.

Test: fast/forms/file-input-change-event.html

  • html/FileInputType.cpp: (WebCore::FileInputType::filesChosen): Calls dispathChangeEvent() only when the previously selected files are different from the newly selected files
23:35 Changeset [90437] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-07-05 Filip Pizlo <fpizlo@apple.com>

DFG JIT virtual call implementation is inefficient.
https://bugs.webkit.org/show_bug.cgi?id=63974

Reviewed by Gavin Barraclough.

  • dfg/DFGOperations.cpp:
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeForCallWithArityCheck): (JSC::ExecutableBase::generatedJITCodeForConstructWithArityCheck): (JSC::ExecutableBase::generatedJITCodeWithArityCheckFor): (JSC::ExecutableBase::hasJITCodeForCall): (JSC::ExecutableBase::hasJITCodeForConstruct): (JSC::ExecutableBase::hasJITCodeFor):
  • runtime/JSFunction.h: (JSC::JSFunction::scopeUnchecked):
22:29 Changeset [90436] by tkent@chromium.org
  • 6 edits in trunk

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573

  • fast/forms/input-appearance-range.html: Give a focus on a slider to check focus appearance.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-range-expected.png:

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): Need to pass the RenderObject of the owner <input> because updateFocusedState() checks the outline style of the specified renderer, and we'd like to make a slider thumb reflect the owner focus style.
21:36 Changeset [90435] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.

21:24 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
21:11 EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
21:00 Changeset [90434] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
20:50 Changeset [90433] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (runningOnBuildBot):
20:44 Changeset [90432] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

Add results_unittests.js to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63971

Reviewed by Eric Seidel.

Adding these unit tests forced me to commit to an API for the results
module. I'm not sure if this is the API we'll end up with, but it's
something not entirely unreasonable.

Also, I've changed results.js over to WebKit style, as discussed previously.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
20:34 Changeset [90431] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests:
20:15 Changeset [90430] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

Add first unit tests for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63969

Reviewed by Eric Seidel.

I've also reformated base.js to match WebKit style, as discussed in the
previous bug.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
20:11 Changeset [90429] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Move Qt, Gtk and Leopard to NRWT.

We'll roll out any of these if we see problems.

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
19:32 Changeset [90428] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

garden-o-matic should understand which tests have unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=63965

Reviewed by Eric Seidel.

Currently, this code just logs the list of unexpected failures to the
console. A future patch will do something useful with this
information. A testing harness will also come in the next patch.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
19:30 Changeset [90427] by abarth@webkit.org
  • 1 edit
    15 adds in trunk/Source/ThirdParty

2011-07-05 Adam Barth <abarth@webkit.org>

Import qunit JavaScript unit testing framework
https://bugs.webkit.org/show_bug.cgi?id=63967

Reviewed by Eric Seidel.

We're going to use this unit testing framework to test garden-o-matic.

  • qunit: Added.
18:30 Changeset [90426] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-07-05 Oliver Hunt <oliver@apple.com>

Force inlining of simple functions that show up as not being inlined
https://bugs.webkit.org/show_bug.cgi?id=63964

Reviewed by Gavin Barraclough.

Looking at profile data indicates the gcc is failing to inline a
number of trivial functions. This patch hits the ones that show
up in profiles with the ALWAYS_INLINE hammer.

We also replace the memcpy() call in linking with a manual loop.
Apparently memcpy() is almost never faster than an inlined loop.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::add): (JSC::ARMv7Assembler::add_S): (JSC::ARMv7Assembler::ARM_and): (JSC::ARMv7Assembler::asr): (JSC::ARMv7Assembler::b): (JSC::ARMv7Assembler::blx): (JSC::ARMv7Assembler::bx): (JSC::ARMv7Assembler::clz): (JSC::ARMv7Assembler::cmn): (JSC::ARMv7Assembler::cmp): (JSC::ARMv7Assembler::eor): (JSC::ARMv7Assembler::it): (JSC::ARMv7Assembler::ldr): (JSC::ARMv7Assembler::ldrCompact): (JSC::ARMv7Assembler::ldrh): (JSC::ARMv7Assembler::ldrb): (JSC::ARMv7Assembler::lsl): (JSC::ARMv7Assembler::lsr): (JSC::ARMv7Assembler::movT3): (JSC::ARMv7Assembler::mov): (JSC::ARMv7Assembler::movt): (JSC::ARMv7Assembler::mvn): (JSC::ARMv7Assembler::neg): (JSC::ARMv7Assembler::orr): (JSC::ARMv7Assembler::orr_S): (JSC::ARMv7Assembler::ror): (JSC::ARMv7Assembler::smull): (JSC::ARMv7Assembler::str): (JSC::ARMv7Assembler::sub): (JSC::ARMv7Assembler::sub_S): (JSC::ARMv7Assembler::tst): (JSC::ARMv7Assembler::linkRecordSourceComparator): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Reg3Imm8): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Imm5Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp7Reg3Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8Imm8): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8RegReg143): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp9Imm7): (JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp10Reg3Reg3): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4FourFours): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16FourFours): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16Op16): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm): (JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4Reg4Imm12): (JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp): (JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::linkCode):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::moveWithPatch): (JSC::MacroAssemblerARMv7::branchPtrWithPatch): (JSC::MacroAssemblerARMv7::storePtrWithPatch): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeTailRecursiveCall): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::makeBranch):
18:20 Changeset [90425] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Make "Add optimised paths for a few maths functions" work on Qt
https://bugs.webkit.org/show_bug.cgi?id=63893

Reviewed by Oliver Hunt.

Move the generated code to the .text section instead of .data section.
Fix alignment for the 32 bit thunk code.

  • jit/ThunkGenerators.cpp:
18:18 Changeset [90424] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

garden-o-matic should know how to fetch test results from the (NRWT) bots
https://bugs.webkit.org/show_bug.cgi?id=63959

Reviewed by Eric Seidel.

Currently, this code just fetches the results and expectations JSON
blob for Linux from the server and logs it to the console.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
17:56 Changeset [90423] by commit-queue@webkit.org
  • 26 edits in trunk/Source/JavaScriptCore

2011-07-05 Filip Pizlo <fpizlo@apple.com>

DFG JIT does not implement op_call.
https://bugs.webkit.org/show_bug.cgi?id=63858

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::setNumberOfCallLinkInfos): (JSC::CodeBlock::numberOfCallLinkInfos):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitConstruct):
  • dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::lookupGetByVal): (JSC::DFG::AliasTracker::recordCall): (JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (JSC::DFG::ByteCodeParser::getLocal): (JSC::DFG::ByteCodeParser::getArgument): (JSC::DFG::ByteCodeParser::toInt32): (JSC::DFG::ByteCodeParser::addToGraph): (JSC::DFG::ByteCodeParser::addVarArgChild): (JSC::DFG::ByteCodeParser::predictInt32): (JSC::DFG::ByteCodeParser::parseBlock): (JSC::DFG::ByteCodeParser::processPhiStack): (JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::opName): (JSC::DFG::Graph::dump): (JSC::DFG::Graph::refChildren):
  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::useChildren): (JSC::DFG::JITCodeGenerator::emitCall):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::addressOfCallData):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::CallRecord::CallRecord): (JSC::DFG::JITCompiler::notifyCall): (JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck): (JSC::DFG::JITCompiler::addJSCall): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord): (JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
  • dfg/DFGNode.h: (JSC::DFG::Node::Node): (JSC::DFG::Node::child1): (JSC::DFG::Node::child2): (JSC::DFG::Node::child3): (JSC::DFG::Node::firstChild): (JSC::DFG::Node::numChildren):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::basicArithOp): (JSC::DFG::NonSpeculativeJIT::compare): (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgLinkCall):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch): (JSC::DFG::SpeculativeJIT::compilePeepHoleCall): (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
  • interpreter/CallFrame.h: (JSC::ExecState::calleeAsValue):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
  • jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::jitType): (JSC::JITCode::HostFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h:
17:33 Changeset [90422] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-07-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Python tests are failing on leopard
https://bugs.webkit.org/show_bug.cgi?id=63842

Fix the missing flush() call that appears to be needed by the
logging package in python 2.5. Also fix the regressions
introduced in the run_webkit_test tests when we switched from
thread to processes (since processes aren't available on 2.5).

Also fix a missing "from future import with_statement' in
testfilehandler (unreviewed).

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • TestResultServer/handlers/testfilehandler.py:
17:31 Changeset [90421] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Initialize new MarkStack member

17:16 Changeset [90420] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
now that we believe the stray http-server issue to be solved.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
17:12 Changeset [90419] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-07-05 Dirk Pranke <dpranke@chromium.org>

nrwt: allow for multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=63116

Reviewed by Tony Chang.

This modifies the sharding logic to support multiple http
shards, but for now we clamp to one shard until we can test
perf impact and flakiness impact.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
17:08 Changeset [90418] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

Turns out we need to support numerals too because that's what jQuery
uses by default.

  • TestResultServer/handlers/testfilehandler.py:
17:07 Changeset [90417] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-07-05 Dirk Pranke <dpranke@chromium.org>

Re-land nrwt: make sharding tests needing locks less hard-coded
https://bugs.webkit.org/show_bug.cgi?id=63112

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
16:56 Changeset [90416] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

TestResultServer should support callback parameter for JSON
https://bugs.webkit.org/show_bug.cgi?id=63961

Reviewed by Ojan Vafai.

This makes using jQuery.ajax so much more pleasant.

  • TestResultServer/handlers/testfilehandler.py:
16:55 Changeset [90415] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-07-05 Oliver Hunt <oliver@apple.com>

Don't throw out compiled code repeatedly
https://bugs.webkit.org/show_bug.cgi?id=63960

Reviewed by Gavin Barraclough.

Stop throwing away all compiled code every time
we're told to do a full GC. Instead unlink all
callsites during such GC passes to maximise the
number of collectable functions, but otherwise
leave compiled functions alone.

  • API/JSBase.cpp: (JSGarbageCollect):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • heap/Heap.cpp: (JSC::Heap::collectAllGarbage):
  • heap/MarkStack.h: (JSC::MarkStack::shouldUnlinkCalls): (JSC::MarkStack::setShouldUnlinkCalls):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::recompileAllJSFunctions): (JSC::JSGlobalData::releaseExecutableMemory):
  • runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::invalidateCode):
  • runtime/RegExp.h:
16:18 Changeset [90414] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-07-05 Filip Pizlo <fpizlo@apple.com>

JSC JIT has code duplication for the handling of call and construct
https://bugs.webkit.org/show_bug.cgi?id=63957

Reviewed by Gavin Barraclough.

  • jit/JIT.cpp: (JSC::JIT::linkFor):
  • jit/JIT.h:
  • jit/JITStubs.cpp: (JSC::jitCompileFor): (JSC::DEFINE_STUB_FUNCTION): (JSC::arityCheckFor): (JSC::lazyLinkFor):
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeFor): (JSC::FunctionExecutable::compileFor): (JSC::FunctionExecutable::isGeneratedFor): (JSC::FunctionExecutable::generatedBytecodeFor): (JSC::FunctionExecutable::generatedJITCodeWithArityCheckFor):
16:16 Changeset [90413] by eric@webkit.org
  • 7 edits in trunk

2011-07-05 Eric Seidel <eric@webkit.org>

buildbot needs to understand whether NRWT exited early after having too many failures
https://bugs.webkit.org/show_bug.cgi?id=63839

Reviewed by Adam Barth.

Teach the new results.html how to display a warning when testing exited early.
The warning isn't quite as nice as ORWT since I couldn't figure out how to
find the total tests run, or total unexpected crashes. I figure
this is enough to get us going and we can refine it further.

  • fast/harness/results.html:

2011-07-05 Eric Seidel <eric@webkit.org>

buildbot needs to understand whether NRWT exited early after having too many failures
https://bugs.webkit.org/show_bug.cgi?id=63839

Reviewed by Adam Barth.

Fix-up the exited early messages printed by NRWT so that
the buildbot can parse them as expected.
It looks for lines using "if line.find('Exiting early') >= 0:"

I also plumbed the "early exit" status through to results.json
in the form of an "interrupted" bool. It was unclear to me
if results.json already had enough information to compute this bool
itself. It's possible Ojan could come up with a better fix.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
15:59 Changeset [90412] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-07-05 Eric Seidel <eric@webkit.org>

new-run-webkit-tests fails to start http server if one is already running
https://bugs.webkit.org/show_bug.cgi?id=63956

Reviewed by Adam Barth.

  • BuildSlaveSupport/kill-old-processes:
    • Removed M line endings and sorted the process names.
    • There are no functional changes to this file. (except that now that its using unix line endings it can be executed directly!)
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
    • Change the name to 'httpd' to match old-run-webkit-test paths.
15:54 Changeset [90411] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

Add basic ajax support to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=63874

Reviewed by Eric Seidel.

This patch adds some basic infrastructure to garden-o-matic.
Currently, the infrastructure is just used to make the "quit" command
use Ajax, but in the future, this infrastructure will be used to do
more sophistocated remote proceedure calls.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
15:52 Changeset [90410] by abarth@webkit.org
  • 4 edits
    5 adds in trunk/Tools

2011-07-05 Adam Barth <abarth@webkit.org>

Add trivial garden-o-matic command (with server)
https://bugs.webkit.org/show_bug.cgi?id=63872

Reviewed by Eric Seidel.

This patch adds a trivial "Hello, world" garden-o-matic command,
complete with an HTTP server. This command re-uses a bunch of code
from the existing rebaseline-server command. Over time, this command
will grow to be a tool useful for gardening the WebKit tree.

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
  • Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
15:20 Changeset [90409] by aroben@apple.com
  • 2 edits in trunk/Tools

Make prepare-ChangeLog include modified Perl functions in its ChangeLog template

This is a very simple first cut. Functions must start with a line that starts with "sub "
and end with a line that starts with a closing brace. No leading whitespace is allowed.
Package names aren't parsed at all.

Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
Perl files

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when

searching for function line ranges. This is already done inside the get_function_line_ranges
function.
(get_function_line_ranges): Cleaned up coding style a little bit. Call
get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
unknown extension or no extension, read the shebang line to try to determine the script
interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
(get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
lines starting with "sub " or "}".

15:20 Changeset [90408] by aroben@apple.com
  • 2 edits in trunk/Tools

Clean up run-api-tests output on Windows

We were mixing run-api-tests output with gtest output, and the result was a mess.

Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows

Reviewed by Dan Bates.

  • Scripts/run-api-tests:

(runTest):
(populateTests):
Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
the only Mac-specific thing in these functions. Some other platform-specific code was moved
from here...

(prepareEnvironmentForRunningTestTool):
(testToolPath):
...to here.

15:13 Changeset [90407] by hans@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-05 Hans Wennborg <hans@chromium.org>

[V8][Chromium] Remove use of OwnHandle from V8LocalContext
https://bugs.webkit.org/show_bug.cgi?id=63925

Reviewed by Adam Barth.

Replace the OwnHandle<> member in V8LocalContext with
v8::Persistent<v8::Context>.
The code that used OwnHandle<> would not correctly Dispose
of the Context, which would cause the memory to fill up when creating
and destructing many V8LocalContext objects, such as in the case
of IndexedDB.

  • bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
  • bindings/v8/V8Utilities.h:
14:29 Changeset [90406] by commit-queue@webkit.org
  • 10 edits
    1 delete in trunk/Source/WebCore

2011-07-05 Igor Oliveira <igor.oliveira@openbossa.org>

[Qt] Add ShadowBlur support
https://bugs.webkit.org/show_bug.cgi?id=62997

Use ShadowBlur instead of ContextShadow to handle canvas and css shadows. ShadowBlur is
a newer and platform independent shadow implementation.
Qt QPainter does not have support for shadows so is necessary to create a layer support
to draw complex shapes and fonts. The beginShadowLayer creates a temporary shadow buffer
where the canvas can draw onto and endShadowLayer applies the blur filter, colors the
shadow buffer and draw the final shadow to the graphics context.

Reviewed by Andreas Kling.

  • WebCore.pro:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::setShadowValues): (WebCore::ShadowBlur::updateShadowBlurValues): (WebCore::ShadowBlur::clear): (WebCore::ShadowBlur::blurAndColorShadowBuffer): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer):
  • platform/graphics/ShadowBlur.h: (WebCore::ShadowBlur::type):
  • platform/graphics/qt/ContextShadowQt.cpp: Removed.
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawGlyphs):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::mustUseShadowBlur): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::shadowBlur): (WebCore::GraphicsContext::clipBounds): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
13:51 Changeset [90405] by weinig@apple.com
  • 3 edits
    2 adds in trunk

2011-07-05 Sam Weinig <sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Test: fast/events/custom-event-uninitialized.html

  • bindings/scripts/CodeGeneratorJS.pm: Guard against uninitialized script value.

2011-07-05 Sam Weinig <sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Add test which exercises an initialized details property on
a CustomEvent instance.

  • fast/events/custom-event-uninitialized-expected.txt: Added.
  • fast/events/custom-event-uninitialized.html: Added.
13:09 Changeset [90404] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix following last patch.

  • runtime/JSFunction.cpp:

(JSC::createPrototypeProperty):

12:45 Changeset [90403] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>

[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Modified baseUrl to be a local file in order to get a security origin
that is allowed to request local resources. Removed QSignalSpy from it
as loadFinished always happens, and the original test was split into two.

Reviewed by Benjamin Poulain.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setHtmlWithImageResource): (tst_QWebFrame::setHtmlWithStylesheetResource): (tst_QWebFrame::setHtmlWithBaseURL):
12:02 Changeset [90402] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=63947
ASSERT running Object.preventExtensions(Math.sin)

Reviewed by Oliver Hunt.

This is due to calling scope() on a hostFunction as a part of
calling createPrototypeProperty to reify the prototype property.
But host functions don't have a prototype property anyway!

Source/JavaScriptCore:

Prevent callling createPrototypeProperty on a host function.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):

LayoutTests:

Add test case for calling preventExtensions on a host function.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
12:01 Changeset [90401] by barraclough@apple.com
  • 9 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=63880
Evaluation order of conversions of operands to >, >= incorrect.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add 'leftFirst' parameter to jsLess, jsLessEq matching that described in the ES5
spec. This allows these methods to be reused to perform >, >= relational compares
with correct ordering of type conversions.

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Operations.h:

(JSC::jsLess):
(JSC::jsLessEq):

LayoutTests:

Updated layout test results. Two of these tests now pass, however for
the third we now need to check in failing results, since the test is
incorrect!

The problem if that the test author has made the mistake of thinking
that the evaluation order for the operands to '>' is RHS then LHS.
This is due to a quirk in the way the spec is written. The greater
than opeator is defined to call the abstract relational comparison
algorithm with 'leftFirst' set to false, and as such conversion is
performed on the second operand ('y') first (see 11.8.5). However
the abstract relational comparison algorith is performing a less
than comaprison, and the greater than operator calls this algorithm
with the operands to the greater than operator reversed (see 11.8.2).
As such, the second operand to the abstract comaparison is the LHS
of the greater than. This bug also affects the corresponding less
than or equals test, where we already we have failing results checked
in, and again it is the test that is wrong (for the same reason).

  • fast/js/exception-sequencing-binops2-expected.txt:
  • sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1-expected.txt:
  • sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1-expected.txt:
10:34 Changeset [90400] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-07-05 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Coalesce data array into one NSData before calling didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=63916
<rdar://problem/9715181>

Instead of calling didReceiveData multiple times with smaller chunks of data, we merge the
data buffers into one and call it once.

No new tests because the flag isn't enabled yet.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
09:07 Changeset [90399] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-07-05 Tamas Czene <Czene.Tamas@stud.u-szeged.hu>

Reviewed by Simon Fraser.

Remove virtual functions from StyleImage.
https://bugs.webkit.org/show_bug.cgi?id=63909

We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
Some profile data shows this part is significant, especially in small CSS-based sites.
Removing the virtual functions - removing the calls - makes a small performance progression on this part.

  • rendering/style/StyleCachedImage.h: (WebCore::StyleCachedImage::StyleCachedImage):
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::StyleGeneratedImage):
  • rendering/style/StyleImage.h: (WebCore::StyleImage::isCachedImage): (WebCore::StyleImage::isPendingImage): (WebCore::StyleImage::isGeneratedImage): (WebCore::StyleImage::StyleImage):
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::StylePendingImage):
09:01 Changeset [90398] by yurys@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-07-05 Yury Semikhatsky <yurys@chromium.org>

[Chromium] Web Inspector: extend WebSharedWorker with inspector transport methods
https://bugs.webkit.org/show_bug.cgi?id=63942

Added methods for connecting inspector to shared worker and for passing
messages between shared worker inspector and corresponding inspector frontend.

Reviewed by Pavel Feldman.

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
  • public/WebSharedWorker.h: (WebKit::WebSharedWorker::attachDevTools): (WebKit::WebSharedWorker::detachDevTools): (WebKit::WebSharedWorker::dispatchDevToolsMessage):
  • public/WebWorkerClient.h:
  • src/WebSharedWorkerImpl.cpp: (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebSharedWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebSharedWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
08:35 Changeset [90397] by pfeldman@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-07-05 Pavel Feldman <pfeldman@google.com>

Web Inspector: add "element state" setting to the styles section title.
https://bugs.webkit.org/show_bug.cgi?id=63932

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/front-end/Images/paneElementStateButtons.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.muteEventListener): (WebInspector.StylesSidebarPane): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts): (WebInspector.StylesSidebarPane.prototype._toggleElementStatePane): (WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener): (WebInspector.StylesSidebarPane.prototype._createElementStatePane.createCheckbox): (WebInspector.StylesSidebarPane.prototype._createElementStatePane):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.pane > .title > .pane-title-button:active, .pane > .title > .pane-title-button.toggled): (.pane > .title > .pane-title-button.element-state): (.styles-element-state-pane): (.styles-element-state-pane.expanded): (.styles-element-state-pane > table): (.styles-element-state-pane input):
07:03 clutter edited by kov@webkit.org
(diff)
06:59 WebKit Team edited by siddharth.mathur@nokia.com
added Siddharth Mathur to committer list (diff)
06:41 Changeset [90396] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Marked css2.1/20110323/replaced-intrinsic-ratio-001.htm as flaky on mac.

  • platform/chromium/test_expectations.txt:
06:31 Changeset [90395] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract duplicated code that deals with source mappings.
https://bugs.webkit.org/show_bug.cgi?id=63139

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleMessage.prototype.get stackTrace):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation): (WebInspector.DebuggerPresentationModel.prototype._updateAnchor): (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation): (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.updateSourceFileBreakpointsAndDispatchEvent): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didGetUILocation): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.PresenationCallFrame): (WebInspector.PresenationCallFrame.prototype.sourceLine):
06:10 Changeset [90394] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-05 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: WebInspector frontend reports a protocol error in remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=63935

it was error generated for obsolete message "loaded" which was sent from frontend to backend.

Reviewed by Yury Semikhatsky.

05:50 Changeset [90393] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
https://bugs.webkit.org/show_bug.cgi?id=63913

Reviewed by Yury Semikhatsky.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._createTable):
  • inspector/front-end/networkPanel.css: (.network-log-grid): (.network-log-grid table.data): (.network-log-grid.small table.data): (.network-log-grid td): (.network-log-grid.small td): (.network-log-grid th): (.network-log-grid.small th): (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending): (.network-log-grid .data-container): (.network-log-grid.small .data-container): (.network-log-grid select): (.network-log-grid.small tr.offscreen): (.network-log-grid tr.offscreen): (.network-log-grid tr.offscreen td): (.network-log-grid tr.filler): (.network-log-grid tr:not(.filler) td.name-column): (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover): (.network-log-grid td.time-column): (.network-log-grid.small .network-graph-side): (.network-log-grid th.sortable:active): (.network-log-grid tr.selected .network-cell-subtitle): (.network-log-grid .icon): (.network-log-grid.small .icon): (.network-log-grid .network-category-scripts .icon): (.network-log-grid.small .network-category-scripts .icon): (.network-log-grid .network-category-documents .icon): (.network-log-grid.small .network-category-documents .icon): (.network-log-grid .network-category-stylesheets .icon): (.network-log-grid.small .network-category-stylesheets .icon): (.network-log-grid .network-category-images .icon): (.network-log-grid.small .network-category-images .icon): (.network-log-grid .image-network-icon-preview): (.network-log-grid.small .image-network-icon-preview): (.network-timeline-grid.small .network-event-divider): (.network-log-grid .resources-dividers): (.network-log-grid .resources-dividers-label-bar): (.network-timeline-grid.small .resources-dividers-label-bar): (.network-timeline-grid .resources-divider-label): (.network-timeline-grid .resources-dividers-label-bar .resources-divider): (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network-timeline-grid .resources-divider.first .resources-divider-label): (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first): (.network-timeline-grid tr.filler td): (.network-summary-bar td): (.network.panel.viewing-resource .network-log-grid th): (.network-log-grid.full-grid-mode .viewer-column): (.network-log-grid.brief-grid-mode .time-column): (.network-log-grid.viewing-resource-mode .timeline-column): (.network.panel .sidebar): (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):
05:49 Changeset [90392] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-05 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Simon Hausmann.

[Qt] "cat" is not available when building.
https://bugs.webkit.org/show_bug.cgi?id=63924

Changed 'cat' to 'perl -ne \"print $1\"' because 'cat' is not available on Windows with
MSVC toolchain. It passed the Qt buildbots, because they run with cygwin.

Project file change. No tests needed.

04:12 Changeset [90391] by caseq@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-07-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Removed custom chromium-linux baselines for
navigator-detached-no-crash.html & register-protocol-handler.html

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/register-protocol-handler-expected.txt: Removed.
03:36 Changeset [90390] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Unreviewed; Qt Linux Release minimal compile fix.

  • testing/Internals.h: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.idl:
03:16 Changeset [90389] by vsevik@chromium.org
  • 33 edits
    9 adds in trunk

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added GTK symbols for new window.internals methods.

Reviewed by Pavel Feldman.

  • Source/autotools/symbols.filter:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added tests for plugin content saving and replacing in NetworkResourcesData.
Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
to ensure NetworkResourcesData is in the correct state before test.

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-embed.html: Added.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Added.
  • http/tests/inspector/network/network-embed-expected.txt: Added.
  • http/tests/inspector/network/network-embed.html: Added.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Added.
  • http/tests/inspector/network/resources/plugin-data.php: Added.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Added.
  • platform/chromium/test_expectations.txt:

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Now the data from didReceiveData callback is passed to inspector.
It is then saved in NetworkResourcesData structure for plugin requests.
Added window.internals.setInspectorResourcesDataSizeLimits() method
for testing replacement logic.

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/network/network-content-replacement-embed.html

http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/network-embed.html

  • WebCore.exp.in:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::setContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::ResourceData::createDecoder): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::decoder): (WebCore::NetworkResourcesData::ResourceData::buffer): (WebCore::NetworkResourcesData::ResourceData::setBuffer): (WebCore::NetworkResourcesData::ResourceData::hasData):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentEncoded):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createEmptyView): (WebInspector.ResourcePreviewView.prototype._createPreviewView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveData): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Added win symbols for new window.internals methods.

Reviewed by Pavel Feldman.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
02:31 Changeset [90388] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-05 Kent Tamura <tkent@chromium.org>

Add an assertion that percent height box is unregistered correctly.
https://bugs.webkit.org/show_bug.cgi?id=62792

Reviewed by Hajime Morita.

No new tests. This won't change behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasPercentHeightDescendant): Added.
  • rendering/RenderBlock.h: Declare hasPercentHeightDescendant().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Assert !hasPercentHeightDescendant().
01:44 Changeset [90387] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-07-04 Pavel Feldman <pfeldman@google.com>

Web Inspector: Enable settings screen with settings for console and elements panels.
https://bugs.webkit.org/show_bug.cgi?id=62853

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen.prototype.hide):
  • inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createRadioSetting.clickListener): (WebInspector.SettingsScreen.prototype._createRadioSetting.get for):
  • inspector/front-end/ShortcutsScreen.js: (WebInspector.ShortcutsScreen.prototype.hide):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._colorFormatSettingChanged): (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter.get var): (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
  • inspector/front-end/inspector.css: (#counters):
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._toggleSettings): (WebInspector._showShortcutsScreen): (WebInspector._hideShortcutsScreen): (WebInspector._showSettingsScreen.onhide): (WebInspector._showSettingsScreen): (WebInspector._hideSettingsScreen): (WebInspector.documentKeyDown):
01:35 Changeset [90386] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Kinuko Yasuda <kinuko@chromium.org>

[Chromium] LayoutTests/fast/filesystem/workers/simple-persistent-sync.html is failing on chromium worker tests
https://bugs.webkit.org/show_bug.cgi?id=63906

The expected text file needs to be updated to reflect the recent API change for adding the prefix vendor (i.e. requestFileSystem -> webkitRequestFileSystem).

Unreviewed; chromium test expectations change.

  • fast/filesystem/workers/simple-persistent-sync-expected.txt:
00:18 Changeset [90385] by commit-queue@webkit.org
  • 6 edits in trunk

2011-07-05 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

The default step is used when the step attribute of input[type='number'] is "any".
https://bugs.webkit.org/show_bug.cgi?id=57723

Changed Layout tests to use the default step when the step attribute of
input[type='number'] is "any".

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Regenerated.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:

2011-07-05 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

The default step is used when attribute step of input[type='number'] is "any".
https://bugs.webkit.org/show_bug.cgi?id=57723

When step is "any", 0 was chosen as step, but this is not intuitive.
So changed to use the default step.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::getAllowedValueStep): Calls getAllowedValueStepWithDecimalPlaces with RejectAny. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Takes a new arugument AnyStepHandling. If it is AnyIsDefaultStep, this method allows "step" attribute to take a value "any" to use the default step as step value. Otherwise, INVALID_STATE_ERR will be returned if "step" is "any". (WebCore::HTMLInputElement::applyStep): ditto. (WebCore::HTMLInputElement::stepUp): Calls applyStep with RejectAny. (WebCore::HTMLInputElement::stepDown): ditto. (WebCore::HTMLInputElement::stepUpFromRenderer): Removes a check that step is "any". It is checked in getAllowedValueStepWithDecimalPlaces.
  • html/HTMLInputElement.h:

07/04/11:

21:21 Changeset [90384] by dominicc@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-04 Dominic Cooney <dominicc@chromium.org>

Simplify <progress> element's isDeterminate logic.
https://bugs.webkit.org/show_bug.cgi?id=63889

Reviewed by Hajime Morita.

Covered by existing tests
fast/dom/HTMLProgressElement/indeterminate-progress-*.html

  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
  • html/HTMLProgressElement.h:
19:59 Changeset [90383] by barraclough@apple.com
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • runtime/NumberPrototype.cpp:

(JSC::decomposeDouble):

  • helper function to extract sign, exponent, mantissa from IEEE doubles.

(JSC::Uint16WithFraction::Uint16WithFraction):

  • helper class, u16int with infinite precision fraction, used to convert the fractional part of the number to a string.

(JSC::Uint16WithFraction::operator*=):

  • Multiply by a uint16.

(JSC::Uint16WithFraction::operator<):

  • Compare two Uint16WithFractions.

(JSC::Uint16WithFraction::floorAndSubtract):

  • Extract the integer portion of the number, and subtract it (clears the integer portion).

(JSC::Uint16WithFraction::comparePoint5):

  • Compare to 0.5.

(JSC::Uint16WithFraction::sumGreaterThanOne):

  • Passed a second Uint16WithFraction, returns true if the result of adding the two values would be greater than one.

(JSC::Uint16WithFraction::isNormalized):

  • Used by ASSERTs to consistency check internal representation.

(JSC::BigInteger::BigInteger):

  • helper class, unbounded integer value, used to convert the integer part of the number to a string.

(JSC::BigInteger::divide):

  • Divide this value through by a uint32.

(JSC::BigInteger::operator!):

  • test for zero.

(JSC::toStringWithRadix):

  • Performs number to string conversion, with the given radix (2..36).

(JSC::numberProtoFuncToString):

  • Changed to use toStringWithRadix.

Tools:

Added forwarding header.

  • DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

  • fast/js/number-toString-expected.txt:
    • Update expected results from FAIL to PASS.
19:19 Changeset [90382] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-07-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=63884

As MediaControlRootElement decides whether it will display timeline
according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
RenderThemeEfl has to implement this function.

Existing tests cover the visibility of the controls.

  • platform/efl/RenderThemeEfl.h: (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
19:18 Changeset [90381] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Mihai Parparita <mihaip@chromium.org>

As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
pass in Chromium, just like other platform-specific tests.

  • platform/chromium/test_expectations.txt:
18:54 Changeset [90380] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Moved handling of frame size changes into its own method.

Reviewed by Oliver Hunt.

  • WebView/WebFrameView.mm:

(-[WebFrameView _frameSizeChanged]): Added. Moved code here...
(-[WebFrameView setFrameSize:]): ...from here.

  • WebView/WebFrameViewInternal.h:
18:27 Changeset [90379] by tkent@chromium.org
  • 5 edits
    3 adds in trunk

2011-07-04 Kent Tamura <tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

  • fast/forms/textfield-overflow-by-value-update.html: Added.
  • platform/chromium/test_expectations.txt: Add textfield-overflow-by-value-update.html.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.

2011-07-04 Kent Tamura <tkent@chromium.org>

REGRESSION (r87067): Text overflows from short height text field.
https://bugs.webkit.org/show_bug.cgi?id=61768

Reviewed by Dimitri Glazkov.

Since r87067, the RenderStyle for the inner text element is reset
by the value update, but the renderer for the inner text element
keeps to have metrics calculated by the previous style. So
RenderTextControlSingleLine::layout() didn't set a desired height
to the renderer for the inner text element.

This patch changes the style creation code so that it has the
desired height initially.

Test: fast/forms/textfield-overflow-by-value-update.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Initialize m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::layout): Update m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::styleDidChange): Reset m_desiredInnerTextHeight. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Sets the height if m_desiredInnerTextHeight has a concrete value.
  • rendering/RenderTextControlSingleLine.h: Declare m_desiredInnerTextHeight.
18:11 Changeset [90378] by morrita@google.com
  • 5 edits
    2 adds in trunk

2011-07-04 MORITA Hajime <morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
http://webkit.org/b/63798

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/shadow-root-node-list-expected.txt: Added.
  • fast/dom/shadow/shadow-root-node-list.html: Added.

2011-07-04 MORITA Hajime <morrita@google.com>

Accessing ShadowRoot.nodeList causes an assertion failure.
http://webkit.org/b/63798

The TreeScope destructor did clear the reference to TreeScope,
then the Node destructor accessing treeScope(), which results
an inconsistent state during the NodeList cache cleanup.

This change clears NodeList cache during the TreeScope destructor.
The Node destructor no longer does problematic NodeList cache
manipulation.

Test: fast/dom/shadow/shadow-root-node-list.html

Reviewed by Dimitri Glazkov.

  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::clearRareData):
  • dom/Node.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::~TreeScope):
14:30 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
14:22 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
13:29 Changeset [90377] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations change.

Mark four tests as passing on the GPU step.

  • platform/chromium/test_expectations.txt:
13:28 Changeset [90376] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
https://bugs.webkit.org/show_bug.cgi?id=63873

Reviewed by Alexey Proskuryakov.

  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
13:26 Changeset [90375] by commit-queue@webkit.org
  • 33 edits
    9 deletes in trunk

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • Source/autotools/symbols.filter:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-embed.html: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
  • http/tests/inspector/network/network-embed-expected.txt: Removed.
  • http/tests/inspector/network/network-embed.html: Removed.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Removed.
  • http/tests/inspector/network/resources/plugin-data.php: Removed.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Removed.
  • platform/chromium/test_expectations.txt:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::appendContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::addResourceContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged): (WebCore::NetworkResourcesData::ResourceData::textEncodingName): (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90373.
http://trac.webkit.org/changeset/90373
https://bugs.webkit.org/show_bug.cgi?id=63917

Breaks Qt Linux Release minimal (Requested by vsevik on
#webkit).

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
13:17 Changeset [90374] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix Qt build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
13:07 Changeset [90373] by vsevik@chromium.org
  • 33 edits
    9 adds in trunk

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • Source/autotools/symbols.filter:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-embed.html: Added.
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-content-replacement-xhr.html: Added.
  • http/tests/inspector/network/network-embed-expected.txt: Added.
  • http/tests/inspector/network/network-embed.html: Added.
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/resources/cp1251.xml: Added.
  • http/tests/inspector/network/resources/plugin-data.php: Added.
  • http/tests/inspector/network/resources/resource.php:
  • http/tests/inspector/network/resources/utf8.xml: Added.
  • platform/chromium/test_expectations.txt:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/network/network-content-replacement-embed.html

http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/network-embed.html

  • WebCore.exp.in:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::setContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::ResourceData::createDecoder): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureNoDataForIdentifier): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::decoder): (WebCore::NetworkResourcesData::ResourceData::buffer): (WebCore::NetworkResourcesData::ResourceData::setBuffer): (WebCore::NetworkResourcesData::ResourceData::hasData):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentEncoded):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded): (WebInspector.ResourcePreviewView.prototype._createEmptyView): (WebInspector.ResourcePreviewView.prototype._createPreviewView):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveData): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • testing/Internals.cpp: (WebCore::Internals::setInspectorResourcesDataSizeLimits):
  • testing/Internals.h:
  • testing/Internals.idl:

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080

Reviewed by Pavel Feldman.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
12:58 Changeset [90372] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::deleteProperty): Call NP_RemoveProperty on the NPObject.
  • WebProcess/Plugins/Netscape/JSNPObject.h: Add deleteProperty.

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Add a test. I made this Mac-WebKit2 specific for now since no other plug-in implementations support this,
and there doesn't seem to be a way to make a WebKit2 specific test.

  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript-expected.txt: Added.
  • platform/mac-wk2/plugins/npruntime/remove-property-from-javascript.html: Added.

2011-07-04 Anders Carlsson <andersca@apple.com>

NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=63915
<rdar://problem/7124300>

Reviewed by Sam Weinig.

Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_IdentifierIsString): (PluginTest::NPN_UTF8FromIdentifier): (PluginTest::NPN_IntFromIdentifier): (PluginTest::NPN_RetainObject): (PluginTest::NPN_ReleaseObject):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: (PluginTest::Object::removeProperty): (PluginTest::Object::identifierIs): (PluginTest::Object::NP_RemoveProperty): (PluginTest::Object::npClass):
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: (NPRuntimeRemoveProperty::TestObject::TestObject): (NPRuntimeRemoveProperty::TestObject::hasProperty): (NPRuntimeRemoveProperty::TestObject::getProperty): (NPRuntimeRemoveProperty::TestObject::removeProperty): (NPRuntimeRemoveProperty::PluginObject::PluginObject): (NPRuntimeRemoveProperty::PluginObject::~PluginObject): (NPRuntimeRemoveProperty::PluginObject::hasMethod): (NPRuntimeRemoveProperty::PluginObject::invoke): (NPRuntimeRemoveProperty::PluginObject::hasProperty): (NPRuntimeRemoveProperty::PluginObject::getProperty): (NPRuntimeRemoveProperty::NPP_GetValue):
12:26 Changeset [90371] by barraclough@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63881
Need separate bytecodes for handling >, >= comparisons.

Reviewed by Oliver Hunt.

This clears the way to fix Bug#63880. We currently handle greater-than comparisons
as being using the corresponding op_less, etc opcodes. This is incorrect with
respect to evaluation ordering of the implicit conversions performed on operands -
we should be calling ToPrimitive on the LHS and RHS operands to the greater than,
but instead convert RHS then LHS.

This patch adds opcodes for greater-than comparisons mirroring existing ones used
for less-than.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emit_op_loop_if_greater):
(JSC::JIT::emitSlow_op_loop_if_greater):
(JSC::JIT::emit_op_loop_if_greatereq):
(JSC::JIT::emitSlow_op_loop_if_greatereq):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitBinaryDoubleOp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • parser/NodeConstructors.h:

(JSC::GreaterNode::GreaterNode):
(JSC::GreaterEqNode::GreaterEqNode):

  • parser/Nodes.h:
11:25 Changeset [90370] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations change.


Mark two tests as failing on the GPU step.

  • platform/chromium/test_expectations.txt:
11:16 Changeset [90369] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Jeff Timanus <twiz@chromium.org>

Reviewed by Stephen White.

Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
https://bugs.webkit.org/show_bug.cgi?id=63756

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
11:03 Changeset [90368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] r90148 did not apply to X11 platforms in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=63862

Correct the guard for an X11 specific piece of code. TARGET(X11) not
defined for the GTK+ port.

No new tests. This is covered by an existing test.

  • plugins/npapi.cpp: Correct the X11 guard. (NPN_InvalidateRect):
08:53 Changeset [90367] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: network-preflight-options.html test is flaky.
https://bugs.webkit.org/show_bug.cgi?id=63904

Unreviewed test fix.

  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network-preflight-options.html:
  • platform/qt/Skipped:
08:31 Changeset [90366] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Andras Becsi <abecsi@webkit.org>

[Qt] http/tests/inspector/network-preflight-options.html fails frequently
https://bugs.webkit.org/show_bug.cgi?id=63910

Unreviewed.

  • platform/qt/Skipped: Skip http/tests/inspector/network-preflight-options.html.
07:48 Changeset [90365] by pfeldman@chromium.org
  • 26 edits
    1 move
    1 add in trunk

2011-07-04 Pavel Feldman <pfeldman@google.com>

Web Inspector: implement settings panel.
https://bugs.webkit.org/show_bug.cgi?id=63907

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction): (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype): ():
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype.hide): (WebInspector.HelpScreen.prototype._onKeyDown):
  • inspector/front-end/NetworkItemView.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.saveSidebarWidth):
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Setting): (WebInspector.Setting.prototype.addChangeListener): (WebInspector.Setting.prototype.removeChangeListener): (WebInspector.Setting.prototype.get var): (WebInspector.Setting.prototype): (WebInspector.Setting.prototype.set if):
  • inspector/front-end/SettingsScreen.js: Added. (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._appendSection): (WebInspector.SettingsScreen.prototype._columnElement): (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener): (WebInspector.SettingsScreen.prototype._createRadioSetting):
  • inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js. (WebInspector.ShortcutsScreen):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WatchExpressionsSidebarPane.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-content): (.help-close-button): (body.attached .help-close-button): (body.attached .help-content): (.help-table): (body.platform-mac .help-key): (.help-combine-keys): (.help-content p): (.help-content fieldset): (.help-content fieldset p): (.help-content p.help-section): (.help-section-title): (.help-content input[type=checkbox]):
  • inspector/front-end/inspector.css: (button.settings-status-bar-item): (.settings-status-bar-item .glyph):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._toggleAttach): (WebInspector._toggleSettings): (WebInspector._registerShortcuts): (WebInspector.documentKeyDown):
07:09 Changeset [90364] by vsevik@chromium.org
  • 5 edits
    3 adds in trunk

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
https://bugs.webkit.org/show_bug.cgi?id=63701

Added a test that checks mime type when resources are loaded from cache by InspectorPageAgent.

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/resource-tree/resource-tree-mimetype-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html: Added.
  • http/tests/inspector/resource-tree/resources/empty.png: Added.

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
https://bugs.webkit.org/show_bug.cgi?id=63701

Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.

Reviewed by Yury Semikhatsky.

Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype._createResource):
06:29 Changeset [90363] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-04 Marcus Bulach <bulach@chromium.org>

[chromium] Updates expectations for failures on svg/animations/svgtransform-animation-1.html
https://bugs.webkit.org/show_bug.cgi?id=63902

Unreviewed expectations fix.

  • platform/chromium/test_expectations.txt:
05:50 Changeset [90362] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Yury Semikhatsky <yurys@chromium.org>

Web Inspector: repeated message counter should be aligned with other message icons
https://bugs.webkit.org/show_bug.cgi?id=63901

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css: (.console-message .bubble):
05:18 Changeset [90361] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-07-04 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add LayoutTestControllerEfl.
https://bugs.webkit.org/show_bug.cgi?id=61974

Only the core features are implemented. Most functions are actually
stubs and will be implemented as soon as its features are needed.
Build system changes will be made as soon as DRT is completely
upstreamed.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added. (LayoutTestController::~LayoutTestController): (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::copyDecodedHostName): (LayoutTestController::copyEncodedHostName): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::display): (LayoutTestController::counterValueForElementById): (LayoutTestController::keepWebHistory): (LayoutTestController::computedStyleIncludingVisitedInfo): (LayoutTestController::nodesFromRect): (LayoutTestController::layerTreeAsText): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages): (LayoutTestController::pageProperty): (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageSizeAndMarginsInPixels): (LayoutTestController::webHistoryItemCount): (LayoutTestController::workerThreadCount): (LayoutTestController::notifyDone): (LayoutTestController::pathToLocalResource): (LayoutTestController::queueLoad): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setAlwaysAcceptCookies): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::addOriginAccessWhitelistEntry): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setValueForUser): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setWindowIsKey): (LayoutTestController::setSmartInsertDeleteEnabled): (waitToDumpWatchdogFired): (LayoutTestController::setWaitToDump): (LayoutTestController::windowCount): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setSpatialNavigationEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setAutofilled): (LayoutTestController::disableImageLoading): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setGeolocationPermission): (LayoutTestController::numberOfPendingGeolocationPermissionRequests): (LayoutTestController::addMockSpeechInputResult): (LayoutTestController::setIconDatabaseEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::setPluginsEnabled): (LayoutTestController::elementDoesAutoCompleteForElementWithId): (LayoutTestController::execCommand): (LayoutTestController::findString): (LayoutTestController::isCommandEnabled): (LayoutTestController::setCacheModel): (LayoutTestController::setPersistentUserStyleSheetLocation): (LayoutTestController::clearPersistentUserStyleSheet): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota): (LayoutTestController::clearApplicationCacheForOrigin): (LayoutTestController::localStorageDiskUsageForOrigin): (LayoutTestController::originsWithApplicationCache): (LayoutTestController::applicationCacheDiskUsageForOrigin): (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::syncLocalStorage): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): (LayoutTestController::setAppCacheMaximumSize): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations): (LayoutTestController::overridePreference): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::setAsynchronousSpellCheckingEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::evaluateScriptInIsolatedWorld): (LayoutTestController::removeAllVisitedLinks): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::apiTestNewWindowDataLoadBaseURL): (LayoutTestController::apiTestGoToCurrentBackForwardItem): (LayoutTestController::setWebViewEditable): (LayoutTestController::markerTextForListItem): (LayoutTestController::authenticateSession): (LayoutTestController::setEditingBehavior): (LayoutTestController::abortModal): (LayoutTestController::hasSpellingMarker): (LayoutTestController::hasGrammarMarker): (LayoutTestController::dumpConfigurationForViewport): (LayoutTestController::setSerializeHTTPLoads): (LayoutTestController::setMinimumTimerInterval): (LayoutTestController::setTextDirection): (LayoutTestController::allowRoundingHacks):
04:55 Changeset [90360] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Adding new CSS rules should be more discoverable in the UI
https://bugs.webkit.org/show_bug.cgi?id=63803

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):
03:56 Changeset [90359] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-04 Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>

[Qt] Fixing build with --media-stream flag enabled
https://bugs.webkit.org/show_bug.cgi?id=63831

Reviewed by Benjamin Poulain.

  • features.pri: Adding support to ENABLE_MEDIA_STREAM flag.
03:07 Changeset [90358] by vsevik@chromium.org
  • 2 edits in trunk/Tools

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Unreviewed, add myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
02:51 Changeset [90357] by bulach@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-07-04 Marcus Bulach <bulach@chromium.org>

[chromium] Rebaseline following r90338
https://bugs.webkit.org/show_bug.cgi?id=63896

Unreviewed rebaseline.

  • platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
02:36 Changeset [90356] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Update network resource url from response data.
https://bugs.webkit.org/show_bug.cgi?id=63736

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
02:20 Changeset [90355] by caseq@chromium.org
  • 5 edits in trunk

2011-07-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits.html:

2011-07-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.AuditResultImpl):
02:18 Changeset [90354] by yutak@chromium.org
  • 45 edits in trunk/LayoutTests

2011-07-04 Yuta Kitamura <yutak@chromium.org>

WebSocket: Use jsTestIsAsync and finishJSTest() wherever possible in WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=63892

Reviewed by Kent Tamura.

Use jsTestIsAsync and finishJSTest() in WebSocket tests which are run asynchronously.
Script tags loading js-test-post-function.js must be removed, and instead js-test-post.js
must be loaded after each test.

  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html: This test is done synchronously, thus there is no need to use jsTestIsAsync and finishJSTest(). As we are moving away from js-test-post-function.js, isSuccessfullyParsed() should not be used anymore.
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/close-before-open.html:
  • http/tests/websocket/tests/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/close-on-unload.html:
  • http/tests/websocket/tests/close-unref-websocket.html:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-overflow.html: Add close tags for <body> and <html> elements which were not present for some reason.
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/reload-crash.html:
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
00:49 Changeset [90353] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-03 Balazs Kelemen <kbalazs@webkit.org>

[Qt][WK2] Remove passing tests from the qt-wk2 list
https://bugs.webkit.org/show_bug.cgi?id=63877

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.