Timeline


and

07/13/11:

23:27 Changeset [90982] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Add platform specific expected result for a new test.

  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
23:23 Changeset [90981] by morrita@google.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed attempt at a build fix.

  • win/WebKit2CFLite.def:
22:54 Changeset [90980] by loislo@chromium.org
  • 5 edits in trunk

Web Inspector: if you rename an element into the INPUT element the browser will crash.
https://bugs.webkit.org/show_bug.cgi?id=64292

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeName):
Unnecessary function call copyNonAttributeProperties was removed.

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
22:32 Changeset [90979] by yutak@chromium.org
  • 15 edits
    9 adds in trunk

WebSocket: Implement hybi handshake
https://bugs.webkit.org/show_bug.cgi?id=64344

Reviewed by Kent Tamura.

Source/WebCore:

Implement WebSocket handshake which is described at
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-5.1>.

Notable differences from hixie-76 protocol are:

  • Challenge-response scheme has been changed dramatically.
  • Servers do not send Sec-WebSocket-Location and Sec-WebSocket-Origin anymore.
  • The value of "Upgrade" header has been changed to "websocket" (lower-case only).
  • "Origin" header in client's request is renamed to "Sec-WebSocket-Origin".

New tests: http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html

http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html
http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html

Note: Tests under hybi/ directory (including the new ones) are skipped and cannot be enabled
yet, because pywebsocket does not accept requests from half-baked client implementation
(i.e. hybi handshake + hixie-76 framing). They will be unskipped when hybi framing is landed
in WebCore.

  • websockets/WebSocketHandshake.cpp:

Functions and members only used for hixie-76 handshake are renamed so that they are not confused
with hybi-10's ones.
(WebCore::generateHixie76SecWebSocketKey):
(WebCore::generateHixie76Key3):
(WebCore::generateHixie76ExpectedChallengeResponse):
(WebCore::generateSecWebSocketKey):
Generates a value for Sec-WebSocket-Key as stated in hybi-10.
(WebCore::getExpectedWebSocketAccept):
Calculates the expected value of Sec-WebSocket-Accept.
(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::serverWebSocketAccept):
(WebCore::WebSocketHandshake::serverWebSocketExtensions):
(WebCore::WebSocketHandshake::checkResponseHeaders):

  • websockets/WebSocketHandshake.h:

LayoutTests:

Fix existing tests so they match the new handshake format, and add tests for new header fields.

There are several changes in the format of handshake response, such as:

  • Reason string in HTTP status line has been changed to "Switching Protocols".
  • The value of "Upgrade" header has been changed to "websocket" (lower-case only).
  • Sec-WebSocket-Location and Sec-WebSocket-Origin are gone.
  • "Challenge response" value (16-byte data after the response header fields) is removed, and Sec-WebSocket-Accept header is added instead.

The value of Sec-WebSocket-Accept header is computed using compute_accept() function
located in mod_pywebsocket.handshake.hybi06 module. Although the module name contains
"hybi06", this function can be used to calculate the value of Sec-WebSocket-Accept header
for hybi-10 (calculation method has not been changed since hybi-06).

Note: Tests under hybi/ directory (including the new ones) are skipped and cannot be enabled
yet, because pywebsocket does not accept requests from half-baked client implementation
(i.e. hybi handshake + hixie-76 framing). They will be unskipped when hybi framing is landed
in WebCore.

  • http/tests/websocket/tests/handler_map.txt:

There must be only one handler that can handle requests to "/". hybi/echo-location_wsh.py
is modified to accept requests of both protocol versions.

  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/echo-challenge_wsh.py:
  • http/tests/websocket/tests/hybi/echo-location_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/workers/resources/echo-challenge_wsh.py:
22:05 Changeset [90978] by commit-queue@webkit.org
  • 14 edits in trunk/Tools

Move webkitpy off of loose mocks
https://bugs.webkit.org/show_bug.cgi?id=64508

Reviewed by Adam Barth.

Using Mock has caused us more pain than help.
It's possible that there was a cleaner way to use it
(maybe Mock(class) instead of inheriting from it?).
But for now, I've removed all uses of Mock from mocktool.py.

I also moved run_command into the only 3 files which call it
instead of leaving the deprecated method in executive.py.

I changed various direct calls to os.* to use filesystem instead.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
21:13 Changeset [90977] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Reviewed by Adam Barth.

Add a warning message in the revision= case to help us diagnose
what's going wrong on the bot.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
20:39 Changeset [90976] by morrita@google.com
  • 22 edits
    2 adds in trunk

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

  • Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
  • Updated the set on inclusion list changes.
  • Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

  • Renamed NodeRenderingContext::m_contentElement to m_includer
  • ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

  • dom/ShadowContentElement.cpp:

(WebCore::removeFromSet): Added
(WebCore::addToSet): Added
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor): Replaced activeElement()
(WebCore::ShadowRoot::inclusions): Added
(WebCore::ShadowRoot::ensureInclusions): Added

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

  • win/WebKit2.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Added a new test.
  • Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.
  • fast/dom/shadow/content-element-includer-expected.txt: Added.
  • fast/dom/shadow/content-element-includer.html: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
19:48 Changeset [90975] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
19:40 Changeset [90974] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Remove duplicated entries.

  • platform/qt/test_expectations.txt:
19:32 Changeset [90973] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests: print baseline search path as part of config output
https://bugs.webkit.org/show_bug.cgi?id=64499

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
19:25 Changeset [90972] by dominicc@chromium.org
  • 12 edits
    2 adds in trunk

Raise if dispatchEvent dispatches an event that is being dispatched
https://bugs.webkit.org/show_bug.cgi?id=64150

Reviewed by Dimitri Glazkov.

Source/WebCore:

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-EventTarget-dispatchEvent

Test: fast/events/dispatch-event-being-dispatched.html

  • dom/Event.h:

(WebCore::Event::isBeingDispatched): Added.

  • dom/EventException.h:
  • dom/EventException.idl: Add DISPATCH_REQUEST_ERR.
  • dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEvent): Raise if being dispatched.

  • dom/ExceptionCode.cpp: Add gunk for DISPATCH_REQUEST_ERR.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt: Added DISPATCH_REQUEST_ERR.
  • fast/events/dispatch-event-being-dispatched-expected.txt: Added.
  • fast/events/dispatch-event-being-dispatched.html: Added.
  • fast/workers/resources/worker-event-listener.js:

(onmessage): Redispatching the MessageEvent throws an exception now.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
19:16 Changeset [90971] by tkent@chromium.org
  • 47 edits
    3 adds in trunk

Implement text field placeholders using shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=64253

Reviewed by Dimitri Glazkov.

Source/WebCore:

Represents a placeholder text as a shadow element, and its
visibility is controlled by 'visibility' CSS property.

This patch removes all of existing code about placeholder from
RenderTextControl*. RenderTextControl* have only small code about
placeholder layout.

Also, this patch removes INPUT_PLACEHOLDER legacy pseudo ID, and
the placeholder style uses Element::shadowPseudoId().

This fixes the following regressions:

Test: fast/forms/textarea-placeholder-wrapping.html

  • css/CSSSelector.cpp: Remove INPUT_PLACEHOLDER legacy pseudo ID.

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h: ditto.
  • css/html.css:

(::-webkit-input-placeholder): Added. This contains properties
common in <input> and <textarea>. Some properties have !important
so that a stylesheet specified by a page author won't break
WebKit's assumption.
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

Added the default style for <input> placeholders.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::placeholderElement): Delegate to an InputType.
(WebCore::HTMLInputElement::updatePlaceholderText): ditto.

  • html/HTMLInputElement.h: Declare placeholderElement() and updatePlaceholderText().
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createRenderer):
Remove the 'placeholderVisible' argument.
(WebCore::HTMLTextAreaElement::placeholderElement): Added.
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

Added. This creates, deletes, or updates the placeholder element.

  • html/HTMLTextAreaElement.h:
  • Declare placeholderElement() and updatePlaceholderText().
  • Add m_placeholder.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
Update the placeholder element and 'visibility' CSS property,
instead of delegating the job to a renderer.

  • html/HTMLTextFormControlElement.h:

Declare two pure virtual functions: placeholderElement() and updatePlaceholderText().

  • html/InputType.cpp:

(WebCore::InputType::placeholderElement): Add an empty implementation.
(WebCore::InputType::updatePlaceholderText): Add an empty implementation.

  • html/InputType.h: Declare placeholderElement() and updatePlaceholderText().
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createRenderer):
Remove the 'placeholderVisible' argument.
(WebCore::TextFieldInputType::placeholderElement): Added.
(WebCore::TextFieldInputType::destroyShadowSubtree): Deletes m_placeholder.
(WebCore::TextFieldInputType::updatePlaceholderText):

Added. This creates, deletes, or updates the placeholder element.

  • html/TextFieldInputType.h:
  • Declare placeholderElement() and updatePlaceholderText().
  • Add m_placeholder.
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Excludes the placeholder renderer in order to avoid to secure a box for
the placeholder.

  • rendering/RenderTextControl.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControl signature.
  • Add layoutSpecialExcludedChild().
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild):
Laying out the placeholder box so that it has correct width and location.

  • rendering/RenderTextControlMultiLine.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControlMultiLine signature.
  • Add layoutSpecialExcludedChild().
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControlSingleLine::layout):
Laying out the placeholder box so that it has correct width and location.

  • rendering/RenderTextControlSingleLine.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControlSingleLine signature.
  • rendering/style/RenderStyleConstants.h: Remove INPUT_PLACEHOLDER.

LayoutTests:

Add some test cases, and update expectations because placeholders
have their renderers.

  • fast/forms/input-placeholder-text-indent.html: Remove an obsolete comment. A placeholder respects a percentage indent.
  • fast/forms/placeholder-position.html: Add tests for line-height and text-align.
  • fast/forms/textarea-placeholder-wrapping.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.png:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-stripped-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.png:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/qt/test_expectations.txt:
19:05 Changeset [90970] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove hack that forcefully prevents scripts from running in shadow SVG
https://bugs.webkit.org/show_bug.cgi?id=64419

This hack was put in to prevent scripts from running in shadow SVG. This should never have
happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
r88584, so the hack is no longer needed.

No new tests since there is no change in functionality.

Reviewed by Tony Gentilcore.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

18:46 Changeset [90969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean undeeded WebCore:: namespace prefixing from WebBindings.
https://bugs.webkit.org/show_bug.cgi?id=64361

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-13
Reviewed by Kent Tamura.

  • src/WebBindings.cpp:

(WebKit::makeIntArrayImpl):
(WebKit::makeStringArrayImpl):

18:39 Changeset [90968] by abarth@webkit.org
  • 8 edits in trunk/Tools

gardening server should have an API for parsing changelogs
https://bugs.webkit.org/show_bug.cgi?id=64495

Reviewed by Eric Seidel.

This patch exposes much of the same information from CommitInfo in a
dictionary form, which is easier to send over-the-wire as JSON to the
frontend.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
18:03 Changeset [90967] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

REGRESSION: GitTestWithMock.test_create_patch fails
https://bugs.webkit.org/show_bug.cgi?id=62945

Reviewed by Daniel Bates.

I was not able to reproduce the exact failure seen in the bug,
however this test was failing on my machine for other reasons.

I went through and did an audit of our run_command usage, it's
entirely in scm classes after this change. (Not surprising given
that scm.py was the second file ever created in webkit.py.)

The real bug I'm fixing here is that we were setting executive.should_log
when the value had changed to executive._should_log. Now we set the right one
and the test works again.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
17:29 Changeset [90966] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

[CSSRegions] Parse -webkit-content-order property
https://bugs.webkit.org/show_bug.cgi?id=63897

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-content-order-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionIndex):
(WebCore::InheritedFlags::setRegionIndex):
(WebCore::InheritedFlags::initialRegionIndex):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/regions/script-tests/webkit-content-order-parsing.js: Added.
  • fast/regions/webkit-content-order-parsing-expected.txt: Added.
  • fast/regions/webkit-content-order-parsing.html: Added.
16:45 Changeset [90965] by isherman@chromium.org
  • 3 edits in trunk/Tools

Fix WTF header guard style check
https://bugs.webkit.org/show_bug.cgi?id=64488

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
16:31 Changeset [90964] by ojan@chromium.org
  • 3 edits in trunk/Tools

bring flakiness_dashboard.html closer to webkit style
https://bugs.webkit.org/show_bug.cgi?id=64477

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/dashboard_base.js:

Fix bad variable name that would hit only when running the tests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:

No code/logic changes. All moving/removing brackets, indents and moving things
to one line.

16:14 Changeset [90963] by commit-queue@webkit.org
  • 14 edits
    4 adds in trunk/Source/WebCore

Patch by James Robinson <jamesr@chromium.org> on 2011-07-13
Reviewed by Kenneth Russell.

[chromium] Move draw implementation for ContentLayerChromium/ImageLayerChromium to the appropriate CCLayerImpl subclass
https://bugs.webkit.org/show_bug.cgi?id=58833

Adds a TiledLayerChromium class to handle the tiling logic shared by ContentLayerChromium and ImageLayerChromium
so that they can be siblings in the class hierarchy instead of children. Also adds a CCTiledLayerImpl to handle
the drawing responsibilities for tiled layers.

TiledLayerChromium maintains a tiler, tiling options, and calculates the tiling transform. Subclasses are
responsible for providing an appropriate texture updater implementation. CCTiledLayerImpl takes the tiler,
tiling transform and layer properties and draws the layer. Longer term it'd be better of the CCTiledLayerImpl
owned the tiler and the TiledLayerChromium only owned an updater, but getting there will require changing the
way tile eviction works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::textureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::cleanupResources):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::textureUpdater):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Added.

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::~TiledLayerChromium):
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setLayerRenderer):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::setIsMask):
(WebCore::TiledLayerChromium::tilingTransform):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/TiledLayerChromium.h: Added.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::drawsContent):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Added.

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::~CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Added.

(WebCore::CCTiledLayerImpl::create):
(WebCore::CCTiledLayerImpl::setTilingTransform):
(WebCore::CCTiledLayerImpl::setTiler):

16:05 Changeset [90962] by msaboff@apple.com
  • 7 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=64202
Enh: Improve handling of RegExp in the form of /.*blah.*/

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/src/webkit/LayoutTests:

New tests to support /.*<expression>.*/ enhancement.

  • fast/regex/dotstar-expected.txt: Added.
  • fast/regex/dotstar.html: Added.
  • fast/regex/script-tests/dotstar.js: Added.

../../../../Volumes/Data/src/webkit/Source/JavaScriptCore:

Added code to both the Yarr interpreter and JIT to handle
these expressions a little differently. First off, the terms
in between the leading and trailing .*'s cannot capture and
also this enhancement is limited to single alternative expressions.
If an expression is of the right form with the aforementioned
restrictions, we process the inner terms and then look for the
beginning of the string and end of the string. There is handling
for multiline expressions to allow the beginning and end to be
right after and right before newlines.

This enhancement speeds up expressions of this type 12x on
a MacBookPro.

Cleaned up 'case' statement indentation.

A new set of tests was added as LayoutTests/fast/regex/dotstar.html

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::end):
(JSC::Yarr::Interpreter::matchDotStarEnclosure):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::assertionDotStarEnclosure):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::ByteTerm::DotStarEnclosure):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::backtrackDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
(JSC::Yarr::YarrPattern::compile):

  • yarr/YarrPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm):

16:00 Changeset [90961] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an unused bit in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=64485

Reviewed by Darin Adler.

No change in behavior so no new test.

  • rendering/RenderObject.h: Removed a bit that was duplicated from RenderTableCell.

However it was not used in RenderObject and RenderTableCell already packed this bit.
We were lying in the number of used bits in RenderObject which was 33. This change
brings us back to what was advertised.

15:57 Changeset [90960] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:56 Changeset [90959] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-07-13 Simon Fraser <simon.fraser@apple.com>

Fix non-debug builds.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer):
15:50 Changeset [90958] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r90957.
http://trac.webkit.org/changeset/90957

Fixing incorrect test expectations

  • platform/chromium/test_expectations.txt:
15:46 Changeset [90957] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:27 Changeset [90956] by vitalyr@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-13 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Fix mac build after r90949.

  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::hiddenReferenceName):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
15:24 Changeset [90955] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Switch table rendering to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64478

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h:
  • rendering/HitTestResult.cpp:
  • rendering/HitTestResult.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
14:57 Changeset [90954] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-07-13 Simon Fraser <simon.fraser@apple.com>

Factor some GraphicsLayer creation code in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=64487

Reviewed by Sam Weinig.

Move the GraphicsLayer::create() calls into once place so that we
don't have lots of #ifndef NDEBUG in various places, and can share
more code in future.

No behavior change, so no new tests.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayers): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateOverflowControlsLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer):
  • rendering/RenderLayerBacking.h:
14:55 Changeset [90953] by xan@webkit.org
  • 6 edits in trunk

Tools:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck

Reviewed by Martin Robinson.

  • WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.

WebCore:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck.

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: add missing files.

JavaScriptCore:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: add missing files.
14:51 Changeset [90952] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] No implementation defined for WTF::monotonicallyIncreasingTime
https://bugs.webkit.org/show_bug.cgi?id=64420

Reviewed by Tony Gentilcore.

Source/WebCore:

Removes some redundant time related code.

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SystemTimeChromium.cpp:

(WebCore::userIdleTime):

Source/WebKit/chromium:

Provides an implementation of WTF::monotonicallyIncreasingTime() alongside the implementation of
WTF::currentTime().

  • src/ChromiumCurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):

  • src/PlatformBridge.cpp:
14:45 Changeset [90951] by joepeck@webkit.org
  • 2 edits in trunk/Tools

Unreviewed fix. Add a "\n" to a printf that somehow got lost.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
14:44 Changeset [90950] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement prototype chain or list caching for get_by_id.
https://bugs.webkit.org/show_bug.cgi?id=64147

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-13
Reviewed by Gavin Barraclough.

This implements unified support for prototype caching, prototype chain
caching, and polymorphic (i.e. list) prototype and prototype chain
caching. This is done by creating common code for emitting prototype
or chain access stubs, and having it factored out into
generateProtoChainAccessStub(). This function is called by
tryCacheGetByID once the latter determines that some form of prototype
access caching is necessary (i.e. the slot being accessed is not on the
base value but on some other object).

Direct prototype list, and prototype chain list, caching is implemented by
linking the slow path to operationGetByIdProtoBuildList(), which uses the
same helper function (generateProtoChainAccessStub()) as tryCacheGetByID.

This change required ensuring that the value in the scratchGPR field in
StructureStubInfo is preserved even after the stub info is in the
chain, or proto_list, states. Hence scratchGPR was moved out of the union
and into the top-level of StructureStubInfo.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::dfgBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGRepatch.h:
14:44 Changeset [90949] by vitalyr@chromium.org
  • 16 edits in trunk/Source/WebCore

2011-07-13 Vitaly Repeshko <vitalyr@chromium.org>

[V8] Avoid memory leaks with hidden references.
https://bugs.webkit.org/show_bug.cgi?id=64467

Reviewed by Adam Barth.

We used to have growing arrays of hidden references associated
with objects. The entries in this array had no keys and were never
removed. This patch changes the interface to require a reference
name. This way it's harder to leak an unbounded number of
objects. Also it makes our wrapper objects one machine word
smaller.

14:40 Changeset [90948] by joepeck@webkit.org
  • 10 edits in trunk/Source

Improve names of some ApplicationCacheStorage accessor methods
https://bugs.webkit.org/show_bug.cgi?id=64433

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Some methods returned a bool for success/failure and
actually returned a value as an out parameter so their
name was confusing. Rename these methods to make them
more clear.

(WebCore::ApplicationCache::diskUsageForOrigin):

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::calculateQuotaForOrigin): (WebCore::ApplicationCacheStorage::calculateUsageForOrigin): (WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache): (WebCore::ApplicationCacheStorage::checkOriginQuota):
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/ApplicationCache.cpp: Rename the methods.
  • WebCore.exp.in: Replaced old versions. Also, calculateRemaining wasn't needed outside WebCore, so no longer export it.
14:40 Changeset [90947] by joepeck@webkit.org
  • 3 edits in trunk/Source/WebCore

Some ApplicationCache Origin Cleanup
https://bugs.webkit.org/show_bug.cgi?id=64431

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

  • m_loadedSize is inaccurate. This just replaces it with calls to ApplicationCache::estimatedSizeInStorage.
  • m_availableSpaceInQuota can get out of date, so we just recalculate it at the start of appcache downloads.
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didReceiveData): Remove references to m_loadedSize.

(WebCore::ApplicationCacheGroup::didFinishLoading):
Replace m_loadedSize with estimatedSizeInStorage after we
add the new cached resource to the cache. The calculation
already happened so this check is fast.

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
When we start the Downloading phase, recalculate the quota
so that we have an up to date quota value so that we can
break early if needed.

14:40 Changeset [90946] by joepeck@webkit.org
  • 10 edits in trunk

ApplicationCache Quota Output is Flakey
https://bugs.webkit.org/show_bug.cgi?id=64410

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Have the tests truncate the number of bytes needed in
the delegate callback to get an approximation of how
much space was needed.

  • http/tests/appcache/origin-quota-continued-download-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests.html:
  • http/tests/appcache/origin-quota-expected.txt: Update the output and clarify what the multiple-manifests test is looking for in the space needed output.
  • platform/mac/Skipped:
  • platform/qt/Skipped: Unskip the tests.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Unify the delegate logging for reaching application cache
quotas. Truncate the space needed to the nearest 10000
for less flakey test output. This also better supports
printing NSUInteger on non-64 bit systems by casting to
an unsigned long.

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
13:55 Changeset [90945] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium gpu expectations.

  • platform/chromium/test_expectations.txt:
12:52 Changeset [90944] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Prettify spacing in test_expectations.txt

  • platform/chromium/test_expectations.txt: Ran through the new parser/serializer code.
12:41 Changeset [90943] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Remove unused TestExpectations._overrides.
https://bugs.webkit.org/show_bug.cgi?id=64470

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
12:40 Changeset [90942] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Introduce TestExpectationSerializer.list_to_string.
https://bugs.webkit.org/show_bug.cgi?id=64462

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
12:36 Changeset [90941] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Consolidate expectations parsing code.
https://bugs.webkit.org/show_bug.cgi?id=64460

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
12:31 Changeset [90940] by bfulgham@webkit.org
  • 14 edits in trunk

Standardize WinCairo conditionalized code under PLATFORM macro.
https://bugs.webkit.org/show_bug.cgi?id=64377

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Update to use PLATFORM(WIN_CAIRO) for tests.

Source/WebCore:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

  • WebCore.vcproj/WebCoreCairo.vsprops: Remove redundant declaration of WIN_CAIRO.
  • WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Update to use the existing WinCairo.vsprops file.
  • WebCorePrefix.h: Update for new WTF_PLATFORM_WIN_CAIRO define.
  • config.h: Update to use PLATFORM(WIN_CAIRO).

Tools:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

  • DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant define of WIN_CAIRO=1.
  • DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add WinCairo.vsprops to set (to match Release build).

WebKitLibraries:

  • win/tools/vsprops/WinCairo.vsprops: Update to comply with PLATFORM macro definition (WTF_PLATFORM_WIN_CAIRO)
12:19 Changeset [90939] by levin@chromium.org
  • 4 edits in trunk/Source

Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
https://bugs.webkit.org/show_bug.cgi?id=64465

Reviewed by Dmitry Titov.

There isn't a good way to test this as it is very highly unlikely to occur.

Source/JavaScriptCore:

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
isn't thread-safe, change the initialization to be global.

Source/WebKit2:

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::shouldCallRealDebugger): :Since scoped static initialization
isn't thread-safe, change the initialization to be global.

11:59 Changeset [90938] by barraclough@apple.com
  • 7 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64424
Our direct eval behaviour deviates slightly from the spec.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The ES5 spec defines a concept of 'Direct Call to Eval' (see section 15.1.2.1.1), where
behaviour will differ from that of an indirect call (e.g. " { eval: window.eval }.eval();"
or "var a = eval; a();" are indirect calls), particularly in non-strict scopes variables
may be introduced into the caller's environment.

ES5 direct calls are any call where the callee function is provided by a reference, a base
of that Reference is an EnvironmentRecord (this corresponds to all productions
"PrimaryExpression: Identifier", see 10.2.2.1 GetIdentifierReference), and where the name
of the reference is "eval". This means any expression of the form "eval(...)", and that
calls the standard built in eval method from on the Global Object, is considered to be
direct.

In JavaScriptCore we are currently overly restrictive. We also check that the
EnvironmentRecord that is the base of the reference is the Declaractive Environment Record
at the root of the scope chain, corresponding to the Global Object - an "eval(..)" statement
that hits a var eval in a nested scope is not considered to be direct. This behaviour does
not emanate from the spec, and is incorrect.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Fixed direct eval check in op_call_eval.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Fixed direct eval check in op_call_eval.
  • runtime/Executable.h:

(JSC::isHostFunction):

  • Added check for host function with specific NativeFunction.

LayoutTests:

Correct expected results.

  • fast/js/eval-keyword-vs-function-expected.txt:
  • fast/js/eval-keyword-vs-function.html:
11:56 Changeset [90937] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[CSS Exclusions] Fix for comment #23 on wrap-shape parsing bug 61726
https://bugs.webkit.org/show_bug.cgi?id=64464

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

No new tests needed.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRect): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeCircle): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeEllipse): Removed the "valid" local.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSWrapShapes.h:

(WebCore::CSSWrapShapePolygon::getXAt): Replaced bit shift with multiplication.
(WebCore::CSSWrapShapePolygon::getYAt): Replaced bit shift with multiplication.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
11:51 Changeset [90936] by inferno@chromium.org
  • 4 edits
    1 copy
    1 add in trunk

Source/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
Reviewed by Adam Barth.

Issue with Frame lifetime due to deletion in beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Copy the Frame protector higher in the stack from loadWithDocumentLoader
to loadFrameRequest since any of loadPostRequest or loadURL can call
loadWithDocumentLoader, thereby dispatching the beforeload event and
blowing away the frame. This deleted frame will be later accessed in
the loadFrameRequest function causing a crash.

Test: fast/events/form-iframe-target-before-load-crash2.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests: Tests that we do not crash when frame is blown away in a beforeload
event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Reviewed by Adam Barth.

  • fast/events/form-iframe-target-before-load-crash.html:
  • fast/events/form-iframe-target-before-load-crash2-expected.txt: Added.
  • fast/events/form-iframe-target-before-load-crash2.html: Added.
11:49 Changeset [90935] by commit-queue@webkit.org
  • 5 edits in trunk

[CSSRegions]content:-webkit-from-flow not applied correctly
https://bugs.webkit.org/show_bug.cgi?id=64438

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

Source/WebCore:

Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).

Test: fast/regions/content-webkit-from-flow-parsing.html (existing).

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getStringValue):

LayoutTests:

Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".

  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:
11:40 Changeset [90934] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Eliminate TestExpectationsFile.
https://bugs.webkit.org/show_bug.cgi?id=64458

Turns out, we can just use a Python list.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,

removed TestExpectationsFile.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,

since there's no more custom iterator machinery.

10:55 Changeset [90933] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Don't reuse the last InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=64416

Reviewed by Justin Garcia.

This patch makes the interface of InsertTextCommand less foreign. It now takes arguments in
its constructor and executes the command in doApply like other edit commands.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::applyCommandToComposite): Added.

  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand): Takes arguments input used to take.
(WebCore::InsertTextCommand::doApply): Renamed from input.

  • editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create): Takes arguments input used to take.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertTextRunWithoutNewlines): Creates InsertTextCommand.

10:50 Changeset [90932] by philn@webkit.org
  • 2 edits in trunk/Tools

2011-07-13 Philippe Normand <pnormand@igalia.com>

Unreviewed, added my other email addresses.

  • Scripts/webkitpy/common/config/committers.py:
10:49 Changeset [90931] by dslomov@google.com
  • 12 edits in trunk/Source/WebCore

2011-07-12 Dmitry Lomov <dslomov@google.com>

https://bugs.webkit.org/show_bug.cgi?id=63041
[Chromium][V8] Make DOMDataStore per-isolate
This patch:

  • makes DOMData class an utility class with static members only
  • adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.

Dromaeo benchmarks are not affected.

Reviewed by Adam Barth.

10:36 Changeset [90930] by abarth@webkit.org
  • 2 edits in trunk/Tools

Folks should only be listed once.

  • Scripts/webkitpy/common/config/committers.py:
10:10 Changeset [90929] by philn@webkit.org
  • 2 edits in trunk/Tools

2011-07-13 Philippe Normand <pnormand@igalia.com>

Unreviewed, adding myself as Reviewer.

  • Scripts/webkitpy/common/config/committers.py:
10:09 Changeset [90928] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix flickering bug introduced by my previous patch. I forgot to change
the name of the class everywhere.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
10:04 Changeset [90927] by philn@webkit.org
  • 4 edits in trunk

[GTK] media/media-blocked-by-willsendrequest.html fails
https://bugs.webkit.org/show_bug.cgi?id=63699

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): Abort the request if explicitely asked by the LayoutTestController's willSendRequestReturnsNull() function.

LayoutTests:

[GTK] media/media-blocked-by-willsendrequest.html fails
https://bugs.webkit.org/show_bug.cgi?id=63699

Reviewed by Martin Robinson.

  • platform/gtk/Skipped: Unskip fixed test.
10:02 Changeset [90926] by abarth@webkit.org
  • 3 edits in trunk/Tools

Remove "Dismiss" button from garden-o-matic butterbar
https://bugs.webkit.org/show_bug.cgi?id=64443

Reviewed by Dimitri Glazkov.

We don't have any persistent butter bar messages yet, so the dismiss
button is premature (and fairly heavy, visually).

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
10:02 Changeset [90925] by simon.fraser@apple.com
  • 9 edits in trunk/Source/WebCore

2011-07-12 Simon Fraser <simon.fraser@apple.com>

Rename compositing-related updateContentsScale() methods
https://bugs.webkit.org/show_bug.cgi?id=64430

Reviewed by Joseph Pecoraro.

Rename updateContentsScale() to something less presumptuous; layers may choose
to do something other than update their contents scale when the page scale factor
changes. pageScaleFactorChanged() is a better name.

  • page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): (WebCore::Frame::scalePage):
  • page/Frame.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::pageScaleFactorChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::pageScaleFactorChanged):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::pageScaleFactorChanged):
  • rendering/RenderLayerCompositor.h:
10:01 Changeset [90924] by abarth@webkit.org
  • 8 edits in trunk/Tools

Refine garden-o-matic status pane
https://bugs.webkit.org/show_bug.cgi?id=64442

Reviewed by Dimitri Glazkov.

This patch makes two improvements to the status pane:

1) We only query the server for failure types that we're expecting.

This dramatically reduces the number of HTTP requests, making
loading the status pane faster.

2) The status pane now displays which test and which builder it is

showing results for.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
09:57 Changeset [90923] by abarth@webkit.org
  • 10 edits in trunk/Tools

garden-o-matic should show test results
https://bugs.webkit.org/show_bug.cgi?id=64440

Reviewed by Adam Roben.

This patch introduces the results detail pane, which appears at the
bottom of the window and contains test results from the bots.
Currently, you can activate the pane by mousing over one of the builder
names associated with a failing test.

This is just a first iteration of the UI. There's no way to resize or
zoom in on elements of the details pane, and images likely aren't sized
correctly, but it's a place to start.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    • Add constants for our data attributes so we don't typo them!
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add DOM structure for the details pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Bind events for showing and hiding the details pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Reduce the number of result types that we query for to avoid overfilling the details pane. We'll probably need another solution here in the long-term. For example, we could use tabs to pack more results into the pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
    • Now that we're using the config package during testing, we need to include it in the testing HTML.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
    • Change the DOM structure of the results detail to make it fit nicely in the details pane (rather than flowing freely in the body, as it did before).
09:30 Changeset [90922] by aroben@apple.com
  • 6 edits
    1 add in trunk/Tools

Make TestFailures show every time a possibly-flaky test failed, but hide it by default

It's useful to be able to see every time a flaky test failed to see whether it failed the
same way every time. But doing so takes a lot of space, so the list of failures is now
collapsed by default and can be revealed using a disclosure triangle.

Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
flaky tests as I would like, even though the page is already so long

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
function. Now returns all failures for the given test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:

Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
more over time.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
that we no longer return passing builds for possibly-flaky tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
flakiness examples small, too, since it can get quite long.

(.disclosure-triangle):
(.expanded > .disclosure-triangle):
Simple styles for the disclosure triangle.

(.flakiness-examples-list): Collapse the list by default.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
_domForPossiblyFlakyTests.
(ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
of each test name, and the number of failures to the right. When the disclosure triangle is
clicked for the first time, we build up the list of failures and expand the element. After
that we just collapse or expand the element on subsequent clicks.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pulled in new tests.

09:06 Changeset [90921] by aroben@apple.com
  • 3 edits in trunk/Tools

Teach TestFailures to understand NRWT's output when it exits early due to too many failures

Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
exits early

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
line. Tightened up the regex that's used to parse the number of failing tests to require the
leading number to be followed by whitespace so that we won't parse the "2011" in
"2011-07-13" as a number of failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

08:49 Changeset [90920] by dglazkov@chromium.org
  • 4 edits in trunk/Tools

Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=64386

This is the first step in converting TestExpectations to a real model.

  • TestExpectationsLine represents a line in the test_expectations.txt file, and
  • TestExpectationsFile represents the file, which is a collection of lines.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
08:43 Changeset [90919] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix compile for QRawFont.

https://bugs.webkit.org/show_bug.cgi?id=64453

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-07-13
Reviewed by Andreas Kling.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawGlyphs):

08:21 WebKit Team edited by andreas.kling@nokia.com
(diff)
07:52 Changeset [90918] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Do not grab focus too early in DRT.

Reviewed by Gustavo Noronha.

It causes a layout to happen and a progress signal to be emitted
since r90900, but at this point we don't have a
LayoutTestController object and we'll eventually crash. Since we
already grab focus at the beginning of runTest() this is
redundant, so get rid of it to fix the crash.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main): remove call to grab_focus
07:31 Changeset [90917] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-13 Gabor Loki <loki@webkit.org>

[Qt] Flakey test: xmlhttprequest-50ms-download-dispatch.html on ARM
https://bugs.webkit.org/show_bug.cgi?id=64452

Rubber-stamped by Csaba Osztrogonác

  • platform/qt-arm/Skipped:
07:25 Changeset [90916] by ademar.reis@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

Reviewed by Andreas Kling.

Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717

QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.

Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)

  • wtf/DateMath.cpp: fix usage of abs/labs
  • wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
  • wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
07:11 Changeset [90915] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition
https://bugs.webkit.org/show_bug.cgi?id=64429

Include the cstddef which has the nullptr_t typedef according to the C++0x standard.

  • wtf/NullPtr.h:
07:11 Changeset [90914] by jknotten@chromium.org
  • 4 edits
    4 adds in trunk

Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
https://bugs.webkit.org/show_bug.cgi?id=64363

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html

  • page/Geolocation.cpp:

(WebCore::Geolocation::setIsAllowed):

  • page/Geolocation.h:

LayoutTests:

  • fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html: Added.
  • fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html: Added.
  • fast/dom/Geolocation/script-tests/remove-remote-context-in-error-callback-crash.js: Added.
  • fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt: Added.

(gc):
(onIframeReady):

07:02 Changeset [90913] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Network panel search needs each resource to have unique identifier.
https://bugs.webkit.org/show_bug.cgi?id=64287

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._appendResource):
(WebInspector.NetworkPanel.prototype._frameNavigated):
(WebInspector.NetworkPanel.prototype._updateSearchMatchedListAfterResourceIdentifierChanged):

06:45 Changeset [90912] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class
https://bugs.webkit.org/show_bug.cgi?id=63987

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Hajime Morita.

Change doesn't add new functionality. No test needed.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY):

06:31 Changeset [90911] by morrita@google.com
  • 8 edits
    1 add in trunk/Source

Refactoring: Ignored ExceptionCode value should be less annoying.
https://bugs.webkit.org/show_bug.cgi?id=63688

Source/JavaScriptCore:

Added ASSERT_AT macro.

Reviewed by Darin Adler.

  • wtf/Assertions.h:

Source/WebCore:

  • Introduced ExceptionCodePlaceholder class for the default parameter of ExceptionCode.
  • Introduced ASSERT_NO_EXCEPTION to check ExceptionCode not set to non-zero after the call.
  • Adopted ASSERT_NO_EXCEPTION in Range.cpp

No new tests. No behaviour change.

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionCodePlaceholder.h: Added.

(WebCore::ExceptionCodePlaceholder::ExceptionCodePlaceholder):
(WebCore::ExceptionCodePlaceholder::operator ExceptionCode& ):
(WebCore::IgnorableExceptionCode::IgnorableExceptionCode):
(WebCore::CheckedExceptionCode::CheckedExceptionCode):
(WebCore::CheckedExceptionCode::~CheckedExceptionCode):

  • dom/Range.cpp:

(WebCore::Range::Range):
(WebCore::Range::editingStartPosition):

  • dom/Range.h:
06:02 Changeset [90910] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt/Skipped: Skip svg/text/small-fonts-2.svg because of the 32/64 bit bug.
06:01 Changeset [90909] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Remove invalid signal/slot connection in QTouchWebView.
https://bugs.webkit.org/show_bug.cgi?id=64450

Reviewed by Benjamin Poulain.

The focusNextPrevChild() signal was removed, so we shouldn't try to
connect to it.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setPage):

05:54 Changeset [90908] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>

Regression: OOB read in svg text run
https://bugs.webkit.org/show_bug.cgi?id=63627

Not reviewed.

Fixed last minute typo leading to assertions.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection):
05:32 Changeset [90907] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Undelayed WorkItems are leaked after execution.
https://bugs.webkit.org/show_bug.cgi?id=64447

Reviewed by Benjamin Poulain.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::WorkItemQt::executeAndDelete):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::scheduleWork):

05:13 Changeset [90906] by benjamin.poulain@nokia.com
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=64352

Reviewed by Andreas Kling.

Unskip http/tests/misc/script-async.html since the original change has been reverted.

  • platform/qt-4.8/Skipped:
05:02 Changeset [90905] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DevTools: Enable clear cache and cookies from network panel in chromium.
https://bugs.webkit.org/show_bug.cgi?id=64095

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

():

04:51 Changeset [90904] by caseq@chromium.org
  • 3 edits in trunk

2011-07-12 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: factor NetworkLogView out of Network panel
https://bugs.webkit.org/show_bug.cgi?id=64366

Reviewed by Pavel Feldman.

04:47 Changeset [90903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r90634.
http://trac.webkit.org/changeset/90634
https://bugs.webkit.org/show_bug.cgi?id=64448

Qt HTTP Pipelining is not robust enough to be used in that
generic way. (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

04:35 Changeset [90902] by ossy@webkit.org
  • 2 edits
    220 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests and unskip them.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-13
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/fast/[...]: Added.
  • platform/qt/svg/[...]: Added.
04:33 Changeset [90901] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>

Regression: OOB read in svg text run
https://bugs.webkit.org/show_bug.cgi?id=63627

Reviewed by Zoltan Herczeg.

A TextRun is constructed for a portion of a string [a,b] whose original length is c (0 < a < b < c).
The TextRun charactersLength variable stores the length of the remaining text from (b..c) in order
to support ligatures in SVG Fonts. Example: <text>ffl</text>. When measuring the advance from char 0
to char 1 the whole 'ffl' text must be passed to the SVG glyph selection code, as the SVG Font may
define a single glyph for the characters 'ffl' thus leading to a single character long text
pointing to the ffl ligature, not three individual 'f' / 'f' / 'l' characters anymore.

constructTextRun(..const UChar*, int length, ..) did not correctly calculate the maximum length (b..c).
The passed in UChar buffer starts at eg. textRenderer->characters() + start(), and following condition
holds true for 'length': start() + length <= textRenderer->textLength() (which denotes the maximum length
of the textRenderer->characters() buffer). We have to keep track of the start() offset, so that we
can calculate the charactersLength for the TextRun correctly: textRenderer->textLength() - start().

There are also other cases like RenderCombinedText and/or the presence of hyphens that were incorrectly
tracked. Only InlineTextBox had to be fixed, the other callsites in eg. RenderBlockLineLayout already
computed the maximum length correctly - I assured this by valgrind runs on all SVG Font tests.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::constructTextRun): Add maximumLength parameter to constructTextRun.
  • rendering/InlineTextBox.h: Ditto.
03:23 Changeset [90900] by antti@apple.com
  • 6 edits in trunk/Source/WebCore

didFirstVisuallyNonEmptyLayout dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=64412

Reviewed by Darin Adler and Sam Weinig.

Improve the mechanism that dispatches didFirstVisuallyNonEmptyLayout

  • Wait until a threshold of characters and pixels has been exceeded before dispatching.
  • Wait until stylesheets are loaded (painting is disabled in this case).
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageChanged):

  • rendering/RenderImage.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):

02:50 Changeset [90899] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Also stop the scale commit timer when commitScaleChange is called explicitly.
https://bugs.webkit.org/show_bug.cgi?id=64357

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::timerEvent):
(QTouchWebPagePrivate::commitScaleChange):

02:40 Changeset [90898] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r90893 and r90894.
http://trac.webkit.org/changeset/90893
http://trac.webkit.org/changeset/90894
https://bugs.webkit.org/show_bug.cgi?id=64441

NRWT still doesn't work on qt-mac platform (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

Tools:

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

LayoutTests:

  • platform/qt-mac/Skipped:
02:09 Changeset [90897] by jamesr@google.com
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] Add chromium mac gpu baseline for webgl-background-color.html

  • platform/chromium-gpu-mac/compositing/webgl/webgl-background-color-expected.png: Added.
01:47 Changeset [90896] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Add two chromium gpu linux baselines.

  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
01:06 Changeset [90895] by jamesr@google.com
  • 26 edits
    11 adds
    2 deletes in trunk/LayoutTests

[chromium] Assorted chromium gpu rebaselines and expectation cleanups.

  • platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium/test_expectations.txt:
00:52 Changeset [90894] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Remove 2 tests, because they are in test_expectations.txt too.
00:44 Changeset [90893] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

  • Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.

(useNewRunWebKitTests):

00:18 Changeset [90892] by jamesr@google.com
  • 43 edits
    9 adds in trunk/LayoutTests

[chromium] More edge AA and misc chromium gpu baselines and expectations updates.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:06 Changeset [90891] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip http/tests/misc/script-async.html until fix.
  • platform/qt-mac/Skipped: Skip new failing tests.
  • platform/qt/test_expectations.txt: Mark slow tests.

07/12/11:

23:47 Changeset [90890] by jamesr@google.com
  • 18 edits
    5 adds in trunk/LayoutTests

[chromium] Update expectations+baselines for edge AA changes.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
23:14 WebKit Team edited by zherczeg@webkit.org
(diff)
23:03 Changeset [90889] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix the 32-bit build.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
Cast the NSUInteger value to unsigned long to match the format specifier.

22:43 Changeset [90888] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

[Refactoring][ShadowContentElement] Forwarded node list should be a linked-list.
https://bugs.webkit.org/show_bug.cgi?id=64252

Reviewed by Dimitri Glazkov.

Introduced ShadowInclusionList and ShadowInclusion for maintaining
forwarded content children. ShadowInclusion is doubly-linked list.
ShadowContentElement::m_inclusions is replaced by ShadowInclusionList.

This change is a prepration for bug 64251, which will introduce
forwarded-children to content-element table.

No new tests. No behavioral change.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/ShadowContentElement.cpp:

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::attach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::inclusions):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
22:35 Changeset [90887] by commit-queue@webkit.org
  • 6 edits in trunk

[Chromium] Use nearest filter method with pixel aligned transforms.
https://bugs.webkit.org/show_bug.cgi?id=64338

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by James Robinson.

Source/WebCore:

Check for integer translation and use nearest texture filter when
possible to avoid filter precisions problems at the layer edges.

Test: compositing/iframes/nested-iframe-scrolling.html (existing)

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isIntegerTranslation):

  • platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

  • platform/chromium/test_expectations.txt:
22:12 Changeset [90886] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Removed unnecessary function parameters from TilingData::textureOffset.
https://bugs.webkit.org/show_bug.cgi?id=64245

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by Brent Fulgham.

No new tests, no functionality changes.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::textureOffset):

  • platform/graphics/gpu/TilingData.h:
21:23 Changeset [90885] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Move RenderTextControl::indexForVisiblePosition to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64403

Reviewed by Hajime Morita.

Moved indexForVisiblePosition from RenderTextControl to HTMLTextFormControlElement.

Also replaced the call to RenderTextControl::isSelectableElement by a call to enclosingTextFormControl
(moved from htmlediting to HTMLTextFormControlElement) because we are only interested in checking
whether the given position is inside the current text form control or not.

In addition, modernized the code in indexForVisiblePosition by calling parentAnchoredEquivalent on the
given position and replacing calls to deprecateNode and deprecatedEditingOffset by calls to containerNode
and offsetInContainer.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls indexForVisiblePosition.

  • editing/htmlediting.cpp: Removed enclosingTextFromControl.
  • editing/htmlediting.h: Removed enclosingTextFromControl.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Moved from RenderTextControl.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Calls indexForVisiblePosition.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Calls indexForVisiblePosition.
(WebCore::enclosingTextFormControl): Moved from htmlediting.cpp

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
21:05 Changeset [90884] by abarth@webkit.org
  • 6 edits in trunk/Tools

Improve garden-o-matic UI when the bots fail to report revision numbers
https://bugs.webkit.org/show_bug.cgi?id=64427

Reviewed by Dimitri Glazkov.

At least Win (dbg)(2) seems to fail to report the SVN revision number
in full_results.json. This patch makes garden-o-matic more robust to
missing revision numbers.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
20:52 Changeset [90883] by joepeck@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping a few tests which fail due to differing output in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

20:30 Changeset [90882] by jchaffraix@webkit.org
  • 7 edits in trunk/Source/WebCore

Make RenderObject::containingBlock virtual for better speed and clarity
https://bugs.webkit.org/show_bug.cgi?id=64318

Reviewed by Darin Adler.

No new tests, performance refactoring.

On some of my test cases, this method takes between 3 and 5% of the time spend.
The method makes 2 calls to virtual methods which could be moved to their overriden
version of containingBlock if we made it virtual.

That's what this patch does. It saves between 1 and 2% on some synthetic test cases
as well as made the current method shorter.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Removed code for RenderView and RenderTableCell,
replaced by ASSERTs.

  • rendering/RenderObject.h: Made containingBlock virtual.
  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::containingBlock):

  • rendering/RenderView.h:

(WebCore::RenderView::containingBlock):
The code moved from RenderObject is inlined in those 2 methods.

19:41 Changeset [90881] by abarth@webkit.org
  • 4 edits in trunk/Tools

Adjust garden-o-matic layout to use fewer lines
https://bugs.webkit.org/show_bug.cgi?id=64422

Reviewed by Ojan Vafai.

This patch effectively merges the test name line with the list of
builders on which the test fails. Each test failure now occupies two
lines instead of three.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
19:39 Changeset [90880] by abarth@webkit.org
  • 9 edits
    2 adds in trunk/Tools

garden-o-matic should label tests failures of new tests as such
https://bugs.webkit.org/show_bug.cgi?id=64421

Reviewed by Ojan Vafai.

Also, we shouldn't dim failures of new tests, even if we've only seen
them once because they're likely to be real problems that need
attention.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
19:34 Changeset [90879] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic should display how many times we've seen a failure
https://bugs.webkit.org/show_bug.cgi?id=64417

Reviewed by Ojan Vafai.

This patch adds some UI to display how many times we've seen a given
failure, which can be helpful for determining whether that failure is a
real failure or a flaky test.

When a failure has only been seen once (i.e., only a single run on a
single bot), we set the opacity of to 50% to avoid distracting the
gardener.

This patch also refactors the failure walker to have a simpler API
internally by moving from an object-oriented paradigm to a functional
paradigm.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
19:28 Changeset [90878] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Added the ability to dynamically change the parent context of a WebGraphicsContext3D.
GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate.
https://bugs.webkit.org/show_bug.cgi?id=64397

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-12
Reviewed by Kenneth Russell.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setParentContext):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::platformTexture):

18:47 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
18:46 Changeset [90877] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk

DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

This is a fixed implementation of op_construct. Constructor calls are implemented
by reusing almost all of the code for Call, with care taken to make sure that
where the are differences (like selecting different code blocks), those differences
are respected. The two fixes over the last patch are: (1) make sure the
CodeBlock::unlinkCalls respects differences between Call and Construct, and (2)
make sure that virtualFor() in DFGOperations respects the CodeSpecializationKind
(either CodeForCall or CodeForConstruct) when invoking the compiler.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordConstruct):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/CodeBlock.cpp:

(JSC::CodeBlock::unlinkCalls):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Added a test for the DFG op_construct regression, where polymorphic constructor
calls will result in the code being compiled for call but then invoked as a
constructor. This test will fail if that part of the patch is omitted.

  • fast/js/polymorphic-construct-expected.txt: Added.
  • fast/js/polymorphic-construct.html: Added.
  • fast/js/script-tests/polymorphic-construct.js: Added.

(Foo):
():

18:44 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
18:33 Changeset [90876] by crogers@google.com
  • 4 edits in trunk

Enable Web Audio for chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=64409

Reviewed by James Robinson.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
18:31 TestExpectations edited by dpranke@chromium.org
(diff)
17:53 Changeset [90875] by oliver@apple.com
  • 8 edits in trunk

Overzealous type validation in method_check
https://bugs.webkit.org/show_bug.cgi?id=64415

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Make sure we don't trip any assertions when caching access
to an InternalFunction

  • fast/js/script-tests/method-check.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

method_check is essentially just a value look up
optimisation, but it internally stores the value
as a JSFunction, even though it never relies on
this fact. Under GC validation however we end up
trying to enforce that assumption. The fix is
simply to store the value as a correct supertype.

  • bytecode/CodeBlock.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

17:52 Changeset [90874] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Chromium win build fix.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::drawGlyphsWin):

17:24 Changeset [90873] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Reviewed by David Kilzer.

Changes to ResourceHandle class to get it to compile with USE(CFNETWORK).

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::didReceiveResponse):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::WebCoreSynchronousLoaderClient::willSendRequest): Call adjustMIMETypeIfNecessary
on Mac. Also port over fix for <rdar://problem/6901522> added in r43993 which forces the
MIME type to text/html if the request is annotated with a "ForceHTMLMIMEType" property.

17:20 Changeset [90872] by jamesr@google.com
  • 25 edits
    12 deletes in trunk/Source

[chromium] Delete the unused legacy accelerated canvas 2d code
https://bugs.webkit.org/show_bug.cgi?id=64214

Reviewed by Stephen White.

Source/WebCore:

This removes the legacy accelerated canvas 2d path and support logic since we (chromium) are no longer using
this codepath and it seems clear that no other port is interested.

Refactoring and removing unused code, so no new tests.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::didDraw):

  • html/canvas/CanvasRenderingContext2D.h:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::setGrContext):

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::pointInTriangle):

  • platform/graphics/gpu/BicubicShader.cpp: Removed.
  • platform/graphics/gpu/BicubicShader.h: Removed.
  • platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  • platform/graphics/gpu/ConvolutionShader.h: Removed.
  • platform/graphics/gpu/GraphicsContextGPU.cpp: Removed.
  • platform/graphics/gpu/GraphicsContextGPU.h: Removed.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
  • platform/graphics/gpu/SolidFillShader.cpp: Removed.
  • platform/graphics/gpu/SolidFillShader.h: Removed.
  • platform/graphics/gpu/TexShader.cpp: Removed.
  • platform/graphics/gpu/TexShader.h: Removed.
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::~NativeImageSkia):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
(WebCore::PlatformContextSkia::makeGrContextCurrent):

  • platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

Adds a way to stash a GrContext* on a GraphicsContext3D. Previously, this was handled by
SharedGraphicsContext3D, but we don't need that class any more. This is used only for the shared
GraphicsContext3D stashed on the Page and shared by all accelerated canvases within the Page, for WebGL and
compositor contexts the GrContext is never set.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::grContext):
(WebCore::GraphicsContext3D::grContext):

  • src/GraphicsContext3DInternal.h:
17:13 Changeset [90871] by abarth@webkit.org
  • 6 edits in trunk/Tools

Tweak some UI in garden-o-matic now that the tree actually has a
failure and I can see what this all looks like.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
17:05 Changeset [90870] by joepeck@webkit.org
  • 4 edits in trunk

Unreviewed. Skipping a few tests which fail due to differing output
in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

17:04 Changeset [90869] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Switch InlineFlowBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64399

Reviewed by Eric Seidel.

First step in moving floats over to the new layout abstraction.

No new tests, no new functionality.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::logicalBottom):
(WebCore::InlineBox::setLogicalTop):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalRightSelectionGap):

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getTextShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowBlockDirectionExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):

16:37 Changeset [90868] by bashi@chromium.org
  • 4 edits
    3 adds in trunk

[Chromium] SVG text is not rendered sometimes with geometricPrecision
https://bugs.webkit.org/show_bug.cgi?id=64341

Source/WebCore:

Changing the type of x and y offsets of ComplexTextControllerLinux to make it possible to treat negative offsets.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

Test: platform/chromium-linux/svg/text/text-with-geometric-precision.svg

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: Changed the type of m_offsetX and m_startingY from unsigned to int.

(WebCore::ComplexTextController::ComplexTextController): Changed the type of the argument.
(WebCore::ComplexTextController::reset): Ditto.

  • platform/graphics/chromium/ComplexTextControllerLinux.h:

LayoutTests:

Add a test for the regression that the text is not rendered with geometricPrecision.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

  • platform/chromium-linux/svg/text/text-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux/svg/text/text-with-geometric-precision-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-with-geometric-precision.svg: Added.
16:32 Changeset [90867] by cevans@google.com
  • 7 edits in branches/chromium/782/Source

Merge 90308
BUG=86108
Review URL: http://codereview.chromium.org/7356002

16:31 Changeset [90866] by abarth@webkit.org
  • 8 edits in trunk/Tools

garden-o-matic should display regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64407

Reviewed by Dimitri Glazkov.

This patch computes a regression range for a failure by intersecting
the regression ranges seen by the various bots. We make the underlying
assumption that a test is only failing due to one revision at any given
moment. If that's not true, this code probably explodes.

The regression ranges appear asynchronously, which might be a jarring
UI. We'll have to experiment to see.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
15:35 Changeset [90865] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

COLLECT_ON_EVERY_ALLOCATION no longer works.
https://bugs.webkit.org/show_bug.cgi?id=64388

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Oliver Hunt.

Added a flag to Heap that determines if it's safe to collect (which for now means that
JSGlobalObject has actually been initialized, but it should work for other things, too).
This allows JSGlobalObject to allocate even if the allocator wants to GC; instead of
GCing it just grows the heap, if necessary.

Then changed Heap::allocate() to not recurse ad infinitum when
COLLECT_ON_EVERY_ALLOCATION is set. This also makes the allocator generally more
resilient against bugs; this change allowed me to put in handy assertions, such as that
an allocation must succeed after either a collection or after a new block was added.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::notifyIsSafeToCollect):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

15:35 Changeset [90864] by abarth@webkit.org
  • 3 edits in trunk/Tools

cr-linux-ews should run pixel tests
https://bugs.webkit.org/show_bug.cgi?id=64394

Reviewed by Ojan Vafai.

This patch enabled pixel test on the cr-linux-ews. Running a quick
test on the bots, it looks like we have five pixel failures, related to
some missing fonts. I've also made the bots skip failing tests to
avoid uploading huge zip files to bugs.webkit.org (with all the exected
IMAGE failures).

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
15:34 Changeset [90863] by commit-queue@webkit.org
  • 18 edits
    7 adds in trunk

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-12
Reviewed by David Hyatt.

[CSS Exclusions] Parse wrap-shape property
https://bugs.webkit.org/show_bug.cgi?id=61726

Source/WebCore:

Parsing wrap-shape: rect, circle, ellipse and polygon.
Moved WindRule from Path.h to it's own file.

Test: fast/exclusions/parsing-wrap-shape.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseWrapShape):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/CSSWrapShapes.cpp: Added.

(WebCore::CSSWrapShapeRect::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
(WebCore::CSSWrapShapePolygon::cssText):

  • css/CSSWrapShapes.h: Added.

(WebCore::CSSWrapShape::~CSSWrapShape):
(WebCore::CSSWrapShape::CSSWrapShape):
(WebCore::CSSWrapShapeRect::create):
(WebCore::CSSWrapShapeRect::left):
(WebCore::CSSWrapShapeRect::top):
(WebCore::CSSWrapShapeRect::width):
(WebCore::CSSWrapShapeRect::height):
(WebCore::CSSWrapShapeRect::radiusX):
(WebCore::CSSWrapShapeRect::radiusY):
(WebCore::CSSWrapShapeRect::setLeft):
(WebCore::CSSWrapShapeRect::setTop):
(WebCore::CSSWrapShapeRect::setWidth):
(WebCore::CSSWrapShapeRect::setHeight):
(WebCore::CSSWrapShapeRect::setRadiusX):
(WebCore::CSSWrapShapeRect::setRadiusY):
(WebCore::CSSWrapShapeRect::type):
(WebCore::CSSWrapShapeRect::CSSWrapShapeRect):
(WebCore::CSSWrapShapeCircle::create):
(WebCore::CSSWrapShapeCircle::left):
(WebCore::CSSWrapShapeCircle::top):
(WebCore::CSSWrapShapeCircle::radius):
(WebCore::CSSWrapShapeCircle::setLeft):
(WebCore::CSSWrapShapeCircle::setTop):
(WebCore::CSSWrapShapeCircle::setRadius):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeCircle::CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::create):
(WebCore::CSSWrapShapeEllipse::left):
(WebCore::CSSWrapShapeEllipse::top):
(WebCore::CSSWrapShapeEllipse::radiusX):
(WebCore::CSSWrapShapeEllipse::radiusY):
(WebCore::CSSWrapShapeEllipse::setLeft):
(WebCore::CSSWrapShapeEllipse::setTop):
(WebCore::CSSWrapShapeEllipse::setRadiusX):
(WebCore::CSSWrapShapeEllipse::setRadiusY):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapeEllipse::CSSWrapShapeEllipse):
(WebCore::CSSWrapShapePolygon::create):
(WebCore::CSSWrapShapePolygon::appendPoint):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::setWindRule):
(WebCore::CSSWrapShapePolygon::windRule):
(WebCore::CSSWrapShapePolygon::type):
(WebCore::CSSWrapShapePolygon::CSSWrapShapePolygon):

  • css/SVGCSSValueKeywords.in:
  • platform/graphics/Path.h:
  • platform/graphics/WindRule.h: Added.
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setWrapShape):
(WebCore::InheritedFlags::wrapShape):
(WebCore::InheritedFlags::initialWrapShape):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/exclusions/parsing-wrap-shape-expected.txt: Added.
  • fast/exclusions/parsing-wrap-shape.html: Added.
  • fast/exclusions/script-tests/parsing-wrap-shape.js: Added.

(testCSSText):
(testComputedStyle):
(testNotInherited):
(test):
(negative_test):

15:30 Changeset [90862] by cevans@google.com
  • 3 edits
    3 copies in branches/chromium/782

Merge 90166
BUG=87862
Review URL: http://codereview.chromium.org/7350005

15:29 Changeset [90861] by cevans@google.com
  • 4 edits
    4 copies in branches/chromium/782

Merge 90156
BUG=87862
Review URL: http://codereview.chromium.org/7350004

15:21 Changeset [90860] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-07-12 Simon Fraser <simon.fraser@apple.com>

Clean up some RenderLayerCompositor code relating to scroll and root layers
https://bugs.webkit.org/show_bug.cgi?id=64400

Reviewed by James Robinson.

There was no need for FrameView::syncCompositingStateForThisFrame()
to call syncCompositingStateForThisLayerOnly() on the various
scrollbar-related layers, because the subsequent call to
compositor()->flushPendingLayerChanges() starts to flush at
m_overflowControlsHostLayer if one exists, and its an ancestor
of the scrollbar layers.

Also clean up terminology in RenderLayerCompositor.

m_rootPlatformLayer -> m_rootContentLayer
rootPlatformLayer() -> rootGraphicsLayer()

No behavior change, so no new tests.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): (WebCore::RenderLayerCompositor::flushPendingLayerChanges): (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::layerTreeAsText): (WebCore::RenderLayerCompositor::parentFrameContentLayers): (WebCore::RenderLayerCompositor::rootGraphicsLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootLayer): (WebCore::RenderLayerCompositor::destroyRootLayer): (WebCore::RenderLayerCompositor::attachRootLayer): (WebCore::RenderLayerCompositor::detachRootLayer): (WebCore::RenderLayerCompositor::updateRootLayerAttachment):
  • rendering/RenderLayerCompositor.h:
15:17 Changeset [90859] by commit-queue@webkit.org
  • 13 edits
    4 deletes in trunk/Source/WebCore

Unreviewed, rolling out r90842.
http://trac.webkit.org/changeset/90842
https://bugs.webkit.org/show_bug.cgi?id=64401

Causes crash in debug on compositing/overflow/content-gains-
scrollbars.html (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::cleanupResources):
(WebCore::ContentLayerChromium::setLayerRenderer):
(WebCore::ContentLayerChromium::tilingTransform):
(WebCore::ContentLayerChromium::contentBounds):
(WebCore::ContentLayerChromium::updateLayerSize):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::setTilingOption):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::setIsMask):
(WebCore::writeIndent):
(WebCore::ContentLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
(WebCore::ImageLayerChromium::contentBounds):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore::ImageLayerChromium::drawsContent):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::draw):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
  • platform/graphics/chromium/TiledLayerChromium.h: Removed.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.
15:14 Changeset [90858] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 89831
BUG=87298
Review URL: http://codereview.chromium.org/7350003

15:07 Changeset [90857] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 90595
BUG=87729
Review URL: http://codereview.chromium.org/7350001

15:00 Changeset [90856] by joepeck@webkit.org
  • 58 edits
    1 copy
    9 adds in trunk

ApplicationCache update should not immediately fail when reaching per-origin quota
https://bugs.webkit.org/show_bug.cgi?id=64177

Reviewed by Alexey Proskuryakov.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

Include spaceNeeded information in the output dumped for appcache quota delegates.
Add and update tests related to handling of per-origin quotas.

  • http/tests/appcache/origin-quota-continued-download-expected.txt: Added.
  • http/tests/appcache/origin-quota-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.manifest: Added. New test which checks that there will still be a successful cache when the per-origin quota is reached and increased at the end of downloading.
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt: Added.
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.manifest: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.manifest: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.manifest: Added. New test which checks that the spaceNeeded appropriately lists enough space for multiple manifests across multiple frames for the same origin.
  • http/tests/appcache/resources/quota-origin-iframe-3.manifest: Fix a typo.
  • http/tests/appcache/origin-quota.html: Update the old test to disallow automatic increase of the quota, which is the default handling of DRT when reaching the quota.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped: Skip the test on ports that don't implement ApplicationCache per-origin quotas.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

New behavior of handling ApplicationCache per-origin quotas. Previously,
if the quota was reached while downloading we would fail the download
and then prompt the user for a storage increase. This required a refresh,
a redownload of resources, and the total storage was not known so the
process could be repeated multiple times before an acceptable quota
was found or the user disallowed an increase.

The new behavior is to complete the download of the entire appcache.
When the cache completes downloading and it is greater than the origin
quota, prompt the user to allow a quota increase with the known space
needed. If the quota is increased, the cache will succeed, otherwise
it will fail with the normal failure steps.

An alternative behavior is prompting while downloading immediately
when the origin quota is reached, however at that point the entire
space needed is unknown and so quota increases might not be enough
and could result in multiple prompts to the user.

Tests: http/tests/appcache/origin-quota-continued-download-multiple-manifests.html

http/tests/appcache/origin-quota-continued-download.html

  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Rename instance variable to be more clear on its intent.

(WebCore::ApplicationCacheGroup::didFinishLoading):
Check the quota limit while downloading so we can fail early
if the user already denied a quota increase.

(WebCore::ApplicationCacheGroup::didReachOriginQuota):
Pass the space needed information to the chrome client.

(WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
Removed. Instead convert the callers to update state and console
log when the per-origin quota is reached. This allows us to follow
the normal failure steps if the quota is reached at the end of a
download, and the alternative short path when we fail during downloading.

(WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
Extract to a helper function.

(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
Allow for a quota increase at the end of the download now that
we know the space needed. Then proceed to fail or succeed
as we normally would.

  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::checkOriginQuota): (WebCore::ApplicationCacheStorage::storeNewestCache): Extract checking the origin quota for when an ApplicationCacheGroup will be replacing an ApplicationCacheGroup into a helper function. The helper also provides an out parameter for the space needed to properly fit the new cache group if it wouldn't fit.
  • page/ChromeClient.h:
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota): Add a space needed parameter when reaching the per-origin quota.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

  • WebView/WebUIDelegatePrivate.h:
  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]): Update the delegate to include a space needed parameter.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedApplicationCacheOriginQuota): Call the delegate with the new space needed information.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/ChromeClientQt.h: Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
to disable the default behavior of raising the default per-origin
quota to 5MB when reached. This allows us to test what happens
when the quota is reached and not increased.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (disallowIncreaseForApplicationCacheQuotaCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::disallowIncreaseForApplicationCacheQuota): (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::disallowIncreaseForApplicationCacheQuota): (LayoutTestController::dumpApplicationCacheDelegateCallbacks): Expose a function to prevent automatically increasing the per-origin quota when the quota is reached. This allows us to test what happens when a user would "disallow" a quota increase.
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota): Respect the new disallowIncrease flag and dump the spaceNeeded values for ports that implement application cache quotas.
14:56 Changeset [90855] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Delete some redundant code in WebHTMLView

This code had no user-visible effect, as we were just duplicating work that AppKit would do
for us at a slightly different time.

Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):
Don't bother setting the root layer's transform to account for the scale factor. AppKit
takes care of this for us nowadays.

14:51 Changeset [90854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT put_by_id transition caching does not inform the GC about the structure and
prototype chain that it is referencing.
https://bugs.webkit.org/show_bug.cgi?id=64387

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Fixed the relevant code in DFGRepatch to call StructureStubInfo::initPutByIdTransition().

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

14:46 Changeset [90853] by crogers@google.com
  • 5 edits in trunk/Source/WebCore

AudioDevice::Stop can close NULL handle.
https://bugs.webkit.org/show_bug.cgi?id=64157

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::uninitialize):

  • webaudio/AudioContext.h:
14:38 Changeset [90852] by ojan@chromium.org
  • 2 edits in trunk/Tools

fix flakiness dashboard to work with new crash log filenames
https://bugs.webkit.org/show_bug.cgi?id=64393

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
14:38 Changeset [90851] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary
https://bugs.webkit.org/show_bug.cgi?id=63217
<rdar://problem/9660291>

Reviewed by Darin Adler.

Check to see if the NSWindow hosting the WebView is not on the active space before changing the window's
collectionBehavior.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganExitFullScreenAnimation]):

14:22 Changeset [90850] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Move call to syncCompositingLayers so that we do not trigger redundant draws.
https://bugs.webkit.org/show_bug.cgi?id=64224

Source/WebCore:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing. CCLayerTreeHostImplProxy::updateLayers was
no longer needed, because animateAndLayout calls WebViewImpl::layout.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::syncCompositingLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):

Source/WebKit/chromium:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::layout):
(WebKit::WebViewImpl::syncCompositingLayers):

  • src/WebViewImpl.h:
14:20 Changeset [90849] by rniwa@webkit.org
  • 16 edits
    2 copies in trunk/Source/WebCore

Isolate HTMLTextFormControlElement into a separate file
https://bugs.webkit.org/show_bug.cgi?id=64381

Reviewed by Dimitri Glazkov.

Extracted HTMLTextFormControlElement.h and HTMLTextFormControlElement.cpp out of
HTMLFormControlElement.h and HTMLFormControlElement.cpp.

Also moved defaultEventHandler from HTMLFormControlElementWithState to HTMLTextFormControlElement
because it was specific to HTMLTextFormControlElement, and replaced all references to
HTMLFormControlElementWithState in HTMLInputElement and HTMLTextAreaElement by ones to
HTMLTextFormControlElement.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/TextIterator.cpp:
  • editing/htmlediting.cpp:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isFocusable):

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::isMouseFocusable):
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::canStartSelection):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::rendererIsNeeded):
(WebCore::HTMLInputElement::attach):
(WebCore::HTMLInputElement::detach):
(WebCore::HTMLInputElement::copyNonAttributeProperties):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::addSubresourceAttributeURLs):
(WebCore::HTMLInputElement::recalcWillValidate):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp: Copied from Source/WebCore/html/HTMLFormControlElement.cpp.

(WebCore::HTMLTextFormControlElement::defaultEventHandler):

  • html/HTMLTextFormControlElement.h: Copied from Source/WebCore/html/HTMLFormControlElement.h.
14:18 Changeset [90848] by cevans@google.com
  • 1 edit
    6 copies in branches/chromium/782

Merge 90568
BUG=83672
Review URL: http://codereview.chromium.org/7344020

14:08 Changeset [90847] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r90831.
http://trac.webkit.org/changeset/90831
https://bugs.webkit.org/show_bug.cgi?id=64389

Likely caused fast/canvas/DrawImageSinglePixelStretch.html to
start timing out on the chromium GPU bots (Requested by ojan
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

13:58 SourceDirectory edited by jchaffraix@webkit.org
Forgot a lot of directories inside WebCore, added all directories with … (diff)
13:58 Changeset [90846] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

Add a happy animation to garden-o-matic when there are no failures
https://bugs.webkit.org/show_bug.cgi?id=64382

Reviewed by Ojan Vafai.

As requested by Ojan.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
13:57 Changeset [90845] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 90130
BUG=87925
Review URL: http://codereview.chromium.org/7344019

13:25 Changeset [90844] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Navigation actions in incorrect state when loadStarted() is emitted.
https://bugs.webkit.org/show_bug.cgi?id=64383

Reviewed by Kenneth Rohde Christiansen.

Update the navigation actions before emitting loadStarted().

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):

13:22 Changeset [90843] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • DEPS:
12:56 Changeset [90842] by jamesr@google.com
  • 13 edits
    4 adds in trunk/Source/WebCore

Reviewed by Kenneth Russell.

[chromium] Move draw implementation for ContentLayerChromium/ImageLayerChromium to the appropriate CCLayerImpl subclass
https://bugs.webkit.org/show_bug.cgi?id=58833

Adds a TiledLayerChromium class to handle the tiling logic shared by ContentLayerChromium and ImageLayerChromium
so that they can be siblings in the class hierarchy instead of children. Also adds a CCTiledLayerImpl to handle
the drawing responsibilities for tiled layers.

TiledLayerChromium maintains a tiler, tiling options, and calculates the tiling transform. Subclasses are
responsible for providing an appropriate texture updater implementation. CCTiledLayerImpl takes the tiler,
tiling transform and layer properties and draws the layer. Longer term it'd be better of the CCTiledLayerImpl
owned the tiler and the TiledLayerChromium only owned an updater, but getting there will require changing the
way tile eviction works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::textureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::cleanupResources):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::textureUpdater):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::contentBounds):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::visibleLayerRect):
(WebCore::paintLayerContentsIfDirty):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Added.

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::~TiledLayerChromium):
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setLayerRenderer):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::setIsMask):
(WebCore::TiledLayerChromium::tilingTransform):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/TiledLayerChromium.h: Copied from Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::contentBounds):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::doubleSided):
(WebCore::CCLayerImpl::setDoubleSided):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Added.

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::~CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Added.

(WebCore::CCTiledLayerImpl::create):
(WebCore::CCTiledLayerImpl::setTilingTransform):
(WebCore::CCTiledLayerImpl::setTiler):

12:41 Changeset [90841] by xan@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-07-12 Arno Renevier <arno@renevier.net>

[GTK] DOM bindings do not have gir annotations
https://bugs.webkit.org/show_bug.cgi?id=45395

Reviewed by Xan Lopez.

  • bindings/scripts/CodeGeneratorGObject.pm: generate introspection annotations.
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: update for new output.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: ditto.
12:20 Changeset [90840] by abarth@webkit.org
  • 3 edits in trunk/Tools

sheriffbot can't perform rollouts
https://bugs.webkit.org/show_bug.cgi?id=64370

Reviewed by Eric Seidel.

Now that we're not updating the working copy before processing every
IRC message, the rollout command needs to update it manually.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
12:16 Changeset [90839] by crogers@google.com
  • 6 edits in trunk/Source/WebCore

2011-07-12 Chris Rogers <crogers@google.com>

webkitAudioContext does not do proper sanity checking on its arguments.
https://bugs.webkit.org/show_bug.cgi?id=64076

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
  • bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::constructorCallback): (WebCore::V8AudioContext::createBufferCallback):
  • platform/audio/HRTFDatabaseLoader.h: (WebCore::HRTFDatabaseLoader::databaseSampleRate):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::create): (WebCore::AudioContext::createOfflineContext): (WebCore::AudioContext::createBuffer):
  • webaudio/AudioContext.h:
12:16 Changeset [90838] by benjamin.poulain@nokia.com
  • 8 edits
    4 adds in trunk/Source/WebKit2

[Qt][WK2] Add a basic Pinch gesture recognizer for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64373

Reviewed by Andreas Kling.

This patch adds QtPinchGestureRecognizer to recognize pinch gesture out of
the events not handled by the WebProcess.

TouchViewInterface::pinchGestureRequestScale() has a basic default implementation
so the feature can be tested manually.

  • UIProcess/qt/QtGestureRecognizer.cpp:

QtGestureRecognizer is the private base class for both gesture recognizer
in order to be able to share some code.
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::reset):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::reset):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp: Added.

(WebKit::findTouchPointIndex):
(WebKit::computeTouchCenter):
(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::reset):
(WebKit::QtPinchGestureRecognizer::initializeGesture):

  • UIProcess/qt/QtPinchGestureRecognizer.h: Copied from Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.h.

(WebKit::QtPinchGestureRecognizer::TouchPointInformation::TouchPointInformation):
(WebKit::QtPinchGestureRecognizer::TouchPointInformation::isValid):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::pinchGestureStarted):
(WebKit::TouchViewInterface::pinchGestureRequestScale):
The scale factor reported by the recognizer to the TouchViewInterface is the total scale since the start
of the gesture in order to avoid numerical instabilities.
(WebKit::TouchViewInterface::pinchGestureEnded):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
(QTouchWebPageProxy::processDidCrash):
(QTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
11:55 Changeset [90837] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Navigation actions should react to web process availability.
https://bugs.webkit.org/show_bug.cgi?id=64375

Reviewed by Benjamin Poulain.

When the web process is unavailable, the reload and stop actions should
behave slightly differently. Stop should always be disabled, and reload
should be enabled if there's a reloadable item in the back/forward list.

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationActionEnabledStatusAtStartup):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationActionEnabledStatusAtStartup):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::updateAction):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

11:53 Changeset [90836] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] DRT depends on v8
https://bugs.webkit.org/show_bug.cgi?id=64376

DumpRenderTree.cpp has calls to v8:: functions, so it should have a build
dependency on v8. This fixes missing references in the shared-object build.

  • WebKit.gyp:
11:49 Changeset [90835] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix the grammar in the FIXME comment.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
11:47 Changeset [90834] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Implement didReceiveDataArray callback for CFNetwork based loader
https://bugs.webkit.org/show_bug.cgi?id=64130

Reviewed by David Kilzer.

Factor out the didReceiveDataArray code from ResourceHandleMac.mm into
a new method ResourceHandle::handleDataArray(). Implement the callback
in the CFNetwork loader code and call handleDataArray() to process
incoming data.

No new tests because the flag is not enabled for any bots.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::didReceiveDataArray):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::handleDataArray):

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):

11:42 Changeset [90833] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

Switch preferred width/height and columns to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64329

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::ceiledLayoutUnit):
Add ceiledLayoutUnit to go with the floored version.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns):
Rename rect version of flipForWritingModeIncludingColumns to
adjustStartEdgeForWritingModeIncludingColumns as it adjust the start edge
and does not flip the rect.

(WebCore::RenderBlock::adjustForColumns):
(WebCore::updatePreferredWidth):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::flipForWritingModeIncludingColumns):

  • rendering/RenderBox.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::itemBoundingBoxRect):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):
(WebCore::RenderObject::adjustForColumns):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/TableLayout.h:
11:37 Changeset [90832] by leviw@chromium.org
  • 23 edits
    2 moves in trunk/Source/WebCore

Change roundedIntRect to roundedRect
https://bugs.webkit.org/show_bug.cgi?id=64326

Reviewed by Eric Seidel.

Renaming RoundedIntRect to RoundedRect and moving the underlying type to Layout units from
integer-based versions.

No new tests, no new functionality

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

  • platform/graphics/Path.h:
  • platform/graphics/RoundedIntRect.cpp: Removed.
  • platform/graphics/RoundedIntRect.h: Removed.
  • platform/graphics/RoundedRect.cpp: Copied from Source/WebCore/platform/graphics/RoundedIntRect.cpp.

(WebCore::RoundedRect::Radii::isZero):
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::includeLogicalEdges):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
(WebCore::RoundedRect::includeLogicalEdges):
(WebCore::RoundedRect::excludeLogicalEdges):
(WebCore::RoundedRect::isRenderable):

  • platform/graphics/RoundedRect.h: Copied from Source/WebCore/platform/graphics/RoundedIntRect.h.

(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
(WebCore::operator==):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::setLastShadowValues):
(WebCore::ScratchBuffer::setLastInsetShadowValues):
(WebCore::ScratchBuffer::matchesLastShadow):
(WebCore::ScratchBuffer::matchesLastInsetShadow):
(WebCore::computeSliceSizesFromRadii):
(WebCore::ShadowBlur::templateSize):
(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

  • rendering/style/RenderStyle.h:
11:31 Changeset [90831] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing.
https://bugs.webkit.org/show_bug.cgi?id=64302

Patch by Mike Reed <reed@google.com> on 2011-07-12
Reviewed by Stephen White.

No new tests. Just an optimization for getImageData(), existing <canvas> tests apply

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

11:27 SourceDirectory edited by jchaffraix@webkit.org
Added more content to the WebCore section (diff)
11:20 Changeset [90830] by pfeldman@chromium.org
  • 16 edits
    3 adds in trunk

Web Inspector: introduce UserMetrics for collecting stats in Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=64350

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/user-metrics.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::recordActionTaken):
(WebCore::JSInspectorFrontendHost::recordPanelShown):
(WebCore::JSInspectorFrontendHost::recordSettingChanged):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype.initiateAudit):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
(.WebInspector.InspectorFrontendHostStub.prototype.recordActionTaken):
(.WebInspector.InspectorFrontendHostStub.prototype.recordPanelShown):
(.WebInspector.InspectorFrontendHostStub.prototype.recordSettingChanged):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

  • inspector/front-end/UserMetrics.js: Added.

(WebInspector.UserMetrics.settingChanged):
(WebInspector.UserMetrics):
(WebInspector.UserMetrics.prototype.panelShown):
(WebInspector.UserMetrics._Recorder):
(WebInspector.UserMetrics._Recorder.prototype.record):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._toggleAttach):

LayoutTests:

  • inspector/user-metrics-expected.txt: Added.
  • inspector/user-metrics.html: Added.
11:13 Changeset [90829] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] QDesktopWebView crashes if resized without web process.
https://bugs.webkit.org/show_bug.cgi?id=64371

Reviewed by Benjamin Poulain.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::paint): Remove an invalid assertion. The drawing
area may be null if the web process has crashed.
(QtWebPageProxy::setDrawingAreaSize): Fail silently if there is no
drawing area.

11:06 Changeset [90828] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Patch by Jeff Timanus <twiz@chromium.org> on 2011-07-12
Reviewed by Stephen White.

Suppress flaky Chromium layout tests.
https://bugs.webkit.org/show_bug.cgi?id=64308

  • platform/chromium/test_expectations.txt:
11:00 Changeset [90827] by commit-queue@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Remove results for iframe-outline.html
https://bugs.webkit.org/show_bug.cgi?id=64343

fast/frames/iframe-outline.html was reverted in bug 57439 (another test
added to replace it). Remove the redundant iframe-outline test results.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-12
Reviewed by Tony Chang.

  • platform/chromium-win/fast/frames/iframe-outline-expected.png: Removed.
  • platform/chromium/iframe-outline-expected.png: Removed.
  • platform/gtk/fast/frames/iframe-outline-expected.png: Removed.
  • platform/gtk/fast/frames/iframe-outline-expected.txt: Removed.
10:53 SourceDirectory edited by jchaffraix@webkit.org
Filled more details about Source/JavaScriptCore (diff)
10:52 Changeset [90826] by eric@webkit.org
  • 11 edits
    1 add in trunk/Tools

NRWT should open test results page with Safari trunk, not the system provided one on Mac
https://bugs.webkit.org/show_bug.cgi?id=64346

Reviewed by Adam Barth.

To fix this I implemented Port.show_results_html_file in Mac, Gtk and Qt ports with
implementations (mostly) matching those found in old-run-webkit-tests.
There are still some minor differences for Qt which Qt hackers may wish to tweak.

I had to add a WebKitPort._port_flag_for_scripts method (similar to flag() in common.config.ports.py)
for the Qt/Gtk ports which always require a flag passed to scripts.

While trying to test this, I found that FactoryTest.test_chromium_gpu_linux
was using a real filesystem (due to assert_platform) which due to
global variables in config.py was causing set-webkit-configuration to have
an affect on unit test results! So I fixed this by making FactoryTest.assert_port
pass a mock file system whenever calling factory.get.

Unfortunately TestPort was depending on always being passed a None filesystem
and asserting filesystem._tests (only true for unit_test_filesystem()).
So I just removed the FactoryTest.test_test and FactoryTest.test_dryrun tests
deciding that they were pretty much useless anyway. If others feel strongly
I'm happy to fix this in a different way.

  • Scripts/webkitpy/common/system/executive.py:
    • default arguments in python are screwy. They use a single shared instance, so it's better to use argument=None and then argument = argument or Default() if you have any chance of mutating (or returning) the default argument.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • This code is wrong. We don't need to use a global variable here (as far as I can tell). I'm not fixing it in this patch, but I've marked it with a FIXME and we can convert to storing the results of the read on the Config object (which should only be created once during normal operation). Unit tests shouldn't be hitting the disk anyway. It's possible Config should move off of Port and onto Tool/Host directly.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
10:51 Changeset [90825] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

Reviewed by David Kilzer.

Add NSURLResponse wrapper in ResourceResponse when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63286

When USE(CFNETWORK) is enabled on Mac, keep an NSURLResponse object along with the
CFURLResponseRef so that WebKit can continue using the NSURLResponse.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::ResourceResponse):

10:50 Changeset [90824] by aroben@apple.com
  • 4 edits in trunk/Tools

Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot

Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
exit status but we didn't find any failure counts, assume that there was some error that
caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a new test that shows that we get a failingTestCount of -1 when run-webkit-tests dies
early.
(runGetNumberOfFailingTestsTest): Moved most code here from the only pre-existing test in this
file.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bump the cache number so old cached data that was
tainted by the bug fixed in this patch will be evicted.

10:49 Changeset [90823] by abarth@webkit.org
  • 4 edits in trunk/Tools

cr-linux-ews complains about tests that aren't actually failing
https://bugs.webkit.org/show_bug.cgi?id=64367

The underlying problem here is that full_results.json doesn't have
enough information to determine whether a given test result was
expected because whether an actual result is expected depends on
whether full_results.json was generated duing a test run that included
pixel tests.

The right long-term solution is to make full_results.json a complete
description of what happened durning a test run. In this patch
however, to stop the spam, this patch makes the jsonresultsparser
ignore pixel failures.

(I'm landing this patch unreviewed in order to stop the bots from
spamming. I'll happily address any review comments in a follow-up
patch.)

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
10:46 Changeset [90822] by abarth@webkit.org
  • 10 edits
    1 add in trunk/Tools

Re-work garden-o-matic UI to begin to look like the mocks
https://bugs.webkit.org/show_bug.cgi?id=64334

Reviewed by Dimitri Glazkov.

This patch changes how we display failures to be more like the mock the
dglazkov made. We now can display the same information much more
compactly.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:23 SourceDirectory edited by jchaffraix@webkit.org
Enhanced the formatting of the page (diff)
09:28 Changeset [90821] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implemenation of allowRoundingHacks
https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks-expansion.html to the wk2 Skipped list to get the
bots green.

  • platform/wk2/Skipped:
09:15 Changeset [90820] by andreas.kling@nokia.com
  • 15 edits
    3 adds in trunk/Source/WebKit2

[Qt][WK2] Add informative loadFailed() signal to web views.
https://bugs.webkit.org/show_bug.cgi?id=64362

Reviewed by Benjamin Poulain.

The web views will now emit loadFailed(QWebError) when a load failure occurs.

The QWebError object currently contains:

  • Type of failure (whether it's an engine, network or protocol error.)
  • The failing URL.
  • Any error code associated with the failure.
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qweberror.cpp: Added.

(QWebError::QWebError):
(QWebErrorPrivate::createQWebError):
(QWebErrorPrivate::QWebErrorPrivate):
(QWebErrorPrivate::~QWebErrorPrivate):
(QWebError::type):
(QWebError::errorCode):
(QWebError::url):

  • UIProcess/API/qt/qweberror.h: Added.
  • UIProcess/API/qt/qweberror_p.h: Added.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/ClientImpl.cpp:

(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • WebKit2API.pri:
07:53 Changeset [90819] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Cancelling an empty edit fails.
https://bugs.webkit.org/show_bug.cgi?id=64351

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.cancelEditing):

07:49 Changeset [90818] by podivilov@chromium.org
  • 4 edits in trunk

Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=64353

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.doubleClick):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

LayoutTests:

  • inspector/debugger/live-edit.html:
07:44 Changeset [90817] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] Forward the touch view scale changes to the tiled drawing area.
https://bugs.webkit.org/show_bug.cgi?id=64357

Reviewed by Kenneth Rohde Christiansen.

The drawing area needs to know the new scale to render tiles accordingly.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::commitScaleChange):

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setContentsScale):

  • UIProcess/qt/qtouchwebpageproxy.h:

(QTouchWebPageProxy::drawingArea):

06:59 Changeset [90816] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Update Windows expected results for plugins/mouse-events-fixedpos.html after r90742

  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
06:54 Changeset [90815] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: remove more dead code from the Network panel
https://bugs.webkit.org/show_bug.cgi?id=64291

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

  • inspector/front-end/networkPanel.css:
06:53 Changeset [90814] by aroben@apple.com
  • 6 edits
    5 adds in trunk/Tools

Extract TestFailures's bug-filing code into two new classes

Fixes <http://webkit.org/b/64300> TestFailures page's new-bug-filing code is a mess!

Reviewed by Darin Adler and Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:

(Buildbot.prototype.resultsDirectoryURL): Changed to return a URI-encoded URL. Otherwise the
URL isn't valid (and it's harder to mock this function).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js:

Added. Just tests the above change (for now).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a license header, enclosed everything in a closure to avoid polluting the global
namespace, changed the test name to actually describe the passing condition, and replaced
uses of equals() with equal(). (The latter is the actual name of the function, and matches
deepEqual, etc.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Added.

(NewBugForm): This class knows how to construct a <form> used for filing new bugs in
Bugzilla based on some parameters.
(NewBugForm.prototype.domElement): Creates and returns the <form> element. Code came from
ViewController.prototype._domForNewAndExistingBugs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:

Added. Tests the above code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js: Added.

(TestFailureBugForm): This class knows how to construct a <form> element used for filing new
bugs specifically about test failures. Code came from
ViewController.prototype._domForNewAndExistingBugs.
(TestFailureBugForm.prototype.domElement): Slightly customizes the <form> element returned
by NewBugForm.
(TestFailureBugForm.prototype._computeOperatingSystem):
(TestFailureBugForm.prototype._computePlatform):
(TestFailureBugForm.prototype._createBugTitle):
(TestFailureBugForm.prototype._failingResultsHTMLURL):
(TestFailureBugForm.prototype._failingRevision):
(TestFailureBugForm.prototype._passingRevision):
(TestFailureBugForm.prototype._regressionRangeString):
Code came from ViewController.prototype._domForNewAndExistingBugs. I broke it out into
separate functions to break up the rat's nest a bit.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js:

Added. Tests the above code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Moved code from here to
TestFailureBugForm/NewBugForm, and changed this code to use a TestFailureBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

NewBugForm/TestFailureBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added new tests and required files.

06:35 Changeset [90813] by aroben@apple.com
  • 8 edits
    1 add in trunk

Ensure no intermediate WTF::Strings are created when concatenating with string literals

Fixes <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
operator+ is suboptimal

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<String>::writeTo): Added a macro that can be used for testing how
many WTF::Strings get copied while evaluating an operator+ expression.

  • wtf/text/StringOperators.h:

(WTF::operator+): Changed the overload that takes a StringAppend to take it on the left-hand
side, since operator+ is left-associative. Having the StringAppend on the right-hand side
was causing us to make intermediate WTF::Strings when evaluating expressions that contained
multiple calls to operator+. Added some more overloads for that take a left-hand side of
const char* to resolve overload ambiguity for certain expressions. Added overloads that take
a left-hand side of const UChar* (matching the const char* overloads) so that wide string
literals don't first have to be converted to a WTF::String in operator+ expressions.

Source/WebKit2:

Export some symbols needed by TestWebKitAPI

  • win/WebKit2.def:

Tools:

Test that no intermediate WTF::Strings are created when concatenating with string literals

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp: Added.

(TestWebKitAPI::TEST): Test that a bunch of different string concatenation expressions don't
create any intermediate WTF::Strings while they're being evaluated.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added new file.

06:29 QtWebKitRelease22 edited by joel.parks@nokia.com
(diff)
05:39 Changeset [90812] by aroben@apple.com
  • 4 edits in trunk/Source

Unreviewed, rolling out r90811.
http://trac.webkit.org/changeset/90811
https://bugs.webkit.org/show_bug.cgi?id=61025

Several svg tests failing assertions beneath
SVGSMILElement::findInstanceTime

Source/JavaScriptCore:

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

03:14 Changeset [90811] by reni@webkit.org
  • 4 edits in trunk/Source

Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-07-12
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

01:35 WebKit Team edited by dslomov@google.com
(diff)
01:08 Changeset [90810] by eric@webkit.org
  • 11 edits
    1 delete in trunk

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

Reviewed by Adam Barth.

Tools:

This is more fall-out from the Port class inappropriately encapsulating
both platform and port knowledge. We need to split out some of this
platform knowledge into a separate class which can be better shared
between ports.

The fix was to move all the _path_to_apache_config_file logic down
into the WebKitPort baseclass so that all of the ports can find the
right apache config file, regardless of what platform they may be running on.

I did not move this down into base.Port (even though I considered it).
Chromium duplicates some of this logic, but since they have separate
subclasses for each port-OS combination (e.g. ChromiumMac, ChromiumWin)
they wouldn't notice the change. Eventually we'll move this logic
out of Port entirely, and then it will be shared by all ports.

I also cleaned up the http-config logic for ORWT while I was there,
although since we're killing that code, I'm happy to revert that part
of the change if changing it is viewed as needlessly risky.

During this cleanup, I noticed that no ports use the "default" httpd.conf
which is left over from Mac OS X Tiger (and old linux distros) which used
Apache 1.3. I've removed httpd.conf (and associated support in ORWT) since
we no longer support any ports which use this httpd.conf.

  • Scripts/webkitperl/httpd.pm:

(getHTTPDConfigPathForTestDirectory):

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

LayoutTests:

Removed this old httpd.conf file (used by Tiger and old linux distros)
since no supported WebKit ports use it anymore.

  • http/conf/httpd.conf: Removed.

07/11/11:

23:26 Changeset [90809] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize HTMLInputElement::updateCheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=62840

Patch by Zeng Huiqing <huiqing.zeng@intel.com> on 2011-07-11
Reviewed by Kent Tamura.

No new tests.

  • dom/Document.h:

(WebCore::Document::getFormElements):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

22:58 Changeset [90808] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-07-11
Reviewed by Ryosuke Niwa.

[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Implements basic functions for "redo" command.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::registerCommandForUndo):
(WebCore::EditorClientEfl::registerCommandForRedo):
(WebCore::EditorClientEfl::clearUndoRedoOperations):
(WebCore::EditorClientEfl::canRedo):
(WebCore::EditorClientEfl::undo):
(WebCore::EditorClientEfl::redo):
(WebCore::EditorClientEfl::EditorClientEfl):

  • WebCoreSupport/EditorClientEfl.h:
21:54 Changeset [90807] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Reviewed by David Kilzer.

Add NSURLRequest wrapper in ResourceRequest when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63276

When USE(CFNETWORK) is enabled on Mac, keep an NSURLRequest object along with the
CFURLRequestRef so that WebKit can continue using the NSURLRequest.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
(WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):

19:51 Changeset [90806] by hbono@chromium.org
  • 17 edits in trunk

Reviewed by Adam Roben.

Implement layoutTestController.setTextDirection for WebKit2 and Windows.
https://bugs.webkit.org/show_bug.cgi?id=61931

This change implements layoutTextController.setTextDirection for WebKit2
and Windows so we can run a layout test added by r87770 on them. Each
implementation adds a wrapper function for Editor::setBaseWritingDirection()
so LayoutTestController can call it.

Source/WebKit/win:

  • Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow

LayoutTestController to change the text direction.

  • WebFrame.cpp: ditto.

(WebFrame::setTextDirection):

  • WebFrame.h: ditto.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Added

WKBundleFrameSetTextDirection to allow LayoutTestController to change the
text direction.
(WKBundleFrameSetTextDirection):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: ditto.
  • WebProcess/WebPage/WebFrame.cpp: Added setTextDirection to allow

WKBundleFrame to change the text direction.
(WebKit::WebFrame::setTextDirection):

  • WebProcess/WebPage/WebFrame.h: ditto.

Tools:

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setTextDirection): Implemented the binding function
for layoutTestController.setTextDirection (Windows).

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Added a binding function for layoutTestController.setTextDirection (WebKit2).

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto.

(WTR::LayoutTestController::setTextDirection):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto.

LayoutTests:

  • platform/mac-wk2/Skipped: Removed set-text-direction.html.
  • platform/win/Skipped: ditto.
19:20 Changeset [90805] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time.
https://bugs.webkit.org/show_bug.cgi?id=64293

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-11
Reviewed by Kent Tamura.

gEcoreEvas was being destroyed after shutdownEfl() was called, so the
call to ecore_evas_free() failed.

We now shut it down manually before shutdownEfl() is called.

  • DumpRenderTree/efl/ImageDiff.cpp:

(main): Destroy gEcoreEvas before shutting down the EFL.

19:17 Changeset [90804] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Make Chromium Mac and Linux tests bot core builders
https://bugs.webkit.org/show_bug.cgi?id=63196

Reviewed by Adam Barth.

Added Chromium Mac and Linux Release Tests bots core builders.

Also rearranged the order of bots so that test bots show up right next to
respective builders.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
19:11 Changeset [90803] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[EFL] DRT: Add code related to font management.
https://bugs.webkit.org/show_bug.cgi?id=63989

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-11
Reviewed by Kent Tamura.

The added files are responsible for managing fontconfig and adding the
fonts required by some layout tests to fontconfig's path.

  • DumpRenderTree/efl/FontManagement.cpp: Added.

(getFontDirectories):
(getFontFiles):
(addFontDirectories):
(addFontFiles):
(addFontsToEnvironment):

  • DumpRenderTree/efl/FontManagement.h: Added.
18:56 Changeset [90802] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip hittest-on-relative-positioned-children.html in WebKit2.

  • platform/wk2/Skipped:
18:26 Changeset [90801] by yutak@chromium.org
  • 1 edit
    21 deletes in trunk/LayoutTests

WebSocket: Remove WebSocket tests that do not apply to hybi protocol
https://bugs.webkit.org/show_bug.cgi?id=64288

Reviewed by Kent Tamura.

Remove tests from http/tests/websocket/tests/hybi that are not meaningful in terms of
the hybi protocol. The most recent WebSocket protocol draft is available at
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10>, and referred as
"hybi-10" here.

  • http/tests/websocket/tests/hybi/error-detect-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/error-detect.html: Removed.

Hybi protocol has a completely different scheme of representing frame types.
Additionally, hybi-10 no longer fires "error" events (which invoke "onerror" handler).

  • http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Removed.

Variable-length encoding (which is used to represent frame length in hixie-76) is no longer
used in hybi-10.

  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow.html: Removed. Ditto.
  • http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip.html: Removed.

There are two ways to indicate the length of a frame in hixie-76 protocol, but
hybi-10 has only one method (length-prefixed frames). Skipping unwanted frames will
be covered by other tests that will be added in a later patch.

  • http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Removed.

In hybi-10, servers no longer returns Origin header in handshake response, and clients
are not required to validate this value.

  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Removed.

In hybi-10, clients are not required to (and must not) compare the values of subprotocols
in client's request and server's response.

  • http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Removed.

In hybi-10, servers do not provide "Sec-WebSocket-Location" header, and clients are not required
to validate this value.

  • http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Removed.

Same as handshake-fail-by-sub-protocol-mismatch.html.

18:10 Changeset [90800] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

positionForPoint is broken when a block is positioned relatively inside the parent
https://bugs.webkit.org/show_bug.cgi?id=64298

Reviewed by Simon Fraser.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's not taking relativePositionOffset
into account when computing the point in child coordinates. Fixed the bug by adding the offset to
childLocation as needed.

Test: fast/block/positioning/hittest-on-relative-positioned-children.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries): Fixed the bug; also replaced all instances of
IntPoint by LayoutPoint.

LayoutTests:

Added a test for hit testing on relatively positioned children.

  • fast/block/positioning/hittest-on-relative-positioned-children-expected.txt: Added.
  • fast/block/positioning/hittest-on-relative-positioned-children.html: Added.
18:10 Changeset [90799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG speculative JIT does not guard itself against floating point speculation
failures on non-floating-point constants.
https://bugs.webkit.org/show_bug.cgi?id=64330

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-11
Reviewed by Gavin Barraclough.

Made fillSpeculateDouble immediate invoke terminateSpeculativeExecution() as
soon as it notices that it's speculating on something that is a non-numeric
JSConstant.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

17:39 Changeset [90798] by mitz@apple.com
  • 4 edits
    3 adds in trunk

Excessive expansion of justified text when rounding hacks are enabled
https://bugs.webkit.org/show_bug.cgi?id=64331

Reviewed by Anders Carlsson.

Source/WebCore:

Test: platform/mac/fast/text/rounding-hacks-expansion.html

When rounding hacks are enabled, the expansion at each expansion opportunity should be by an
integer. Restored more of the logic that was removed in r78846 in order to ensure this.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/rounding-hacks-expansion.html: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.png: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.txt: Added.
17:30 Changeset [90797] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
https://bugs.webkit.org/show_bug.cgi?id=64327

Reviewed by Darin Adler.

No new tests; no change in functionality, so covered by existing tests.

Make the rules from fullscreenQuickTime.css !important so they are not overridden
by page authors.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):

17:10 Changeset [90796] by dpranke@chromium.org
  • 8 edits in trunk/Tools

nrwt: linting fixes
https://bugs.webkit.org/show_bug.cgi?id=64225

Reviewed by Eric Siedel.

Miscellaneous linting fixes. The most notable change is that
we add public attributes for user, executive, filesystem, and
options on the Port object, so we don't have to refer to the
"protected" versions all over the place".

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:55 Changeset [90795] by ojan@chromium.org
  • 9 edits in trunk/LayoutTests

Win7 rebaselines after http://trac.webkit.org/changeset/90701.
Should have been part of http://trac.webkit.org/changeset/90716/,
but the Win7 bot was down at that time.

  • platform/chromium-win/http/tests/loading/simple-subframe-expected.png:
  • platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-win/http/tests/misc/iframe404-expected.png:
  • platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png:
  • platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium/test_expectations.txt:

Removing useless duplicated comment line.

16:49 Changeset [90794] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectation that was missed because the WIN7 bot was down for a long time.

  • platform/chromium/test_expectations.txt:
16:35 Changeset [90793] by rniwa@webkit.org
  • 2 edits in trunk/Tools

webkit-patch roll-chromium-deps no longer works
https://bugs.webkit.org/show_bug.cgi?id=64324

Reviewed by James Robinson.

Lower the minimum commit message length to 10.

  • Scripts/webkitpy/tool/steps/commit.py:
16:33 Changeset [90792] by dpranke@chromium.org
  • 6 edits in trunk/LayoutTests

update the boilerplate documentation in the test_expectations.txt files
https://bugs.webkit.org/show_bug.cgi?id=64221

Reviewed by Eric Seidel.

The test expectations files either had documentation for the
Chromium port's version of the file (which was also incorrect),
or were undocumented. This adds a comment with a link to the
documentation for the file to each.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
16:31 Changeset [90791] by leviw@chromium.org
  • 22 edits in trunk/Source/WebCore

2011-07-11 Levi Weintraub <leviw@chromium.org>

Switch lineTop and lineBottom to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64317

Reviewed by Eric Seidel.

Changing lineTop and lineBottom to LayoutUnits and preparing all uses
of them for the upcoming conversion.

No new tests, no new functionality.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/GapRects.h: (WebCore::GapRects::left): (WebCore::GapRects::center): (WebCore::GapRects::right): (WebCore::GapRects::uniteLeft): (WebCore::GapRects::uniteCenter): (WebCore::GapRects::uniteRight): (WebCore::GapRects::operator LayoutRect):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::setLayoutOverflow): (WebCore::InlineFlowBox::setVisualOverflow): (WebCore::InlineFlowBox::setOverflowFromLogicalRects): (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::visualOverflowRect):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::anyLineIntersectsRect):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::lineTop): (WebCore::RootInlineBox::lineBottom): (WebCore::RootInlineBox::setLineTopBottomPositions): (WebCore::RootInlineBox::logicalTopVisualOverflow): (WebCore::RootInlineBox::logicalBottomVisualOverflow): (WebCore::RootInlineBox::logicalTopLayoutOverflow): (WebCore::RootInlineBox::logicalBottomLayoutOverflow):
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.h:
16:23 Changeset [90790] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Rolled Chromium DEPS.

16:10 WebKitGtkLayoutTests edited by mrobinson@webkit.org
(diff)
15:48 Changeset [90789] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-07-11
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
15:43 Changeset [90788] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Daniel Bates.

[GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering
https://bugs.webkit.org/show_bug.cgi?id=62752

Instead of offsetting the cursor blit by the hotspot, just pass the hotspot
arguments to the GdkCursor constructor.

No new tests. This is covered by manual-tests/cursor.html.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor):

15:30 Changeset [90787] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Skip plugins/evaluate-js-after-removing-plugin-element.html on Chromium Vista.

https://bugs.webkit.org/show_bug.cgi?id=64319

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
15:29 Changeset [90786] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

[GTK] [NRWT] Pixel tests do not work
https://bugs.webkit.org/show_bug.cgi?id=64091

Reviewed by Eric Seidel.

Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
path to the ImageDiff binary.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
15:24 Changeset [90785] by dslomov@google.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed, adding myself as a committer

15:00 Changeset [90784] by yi.4.shen@nokia.com
  • 5 edits
    3 deletes in trunk

[Qt] Unreviewed rollout 90779 which may fail the layout-test.

Source/WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

LayoutTests:

  • loader/load-defer-resume-crash-expected.txt: Removed.
  • loader/load-defer-resume-crash.html: Removed.
  • loader/resources/images.html: Removed.
  • platform/chromium/test_expectations.txt:
14:52 Changeset [90783] by abarth@webkit.org
  • 1 delete in S60

Delete top-level S60 directory. This directory hasn't been touched in four years. r=smfr

13:28 Changeset [90782] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading.
https://bugs.webkit.org/show_bug.cgi?id=64313

Add loader/load-defer-resume-crash.html to the WK2 Skipped list in order to get the bots
green.

  • platform/wk2/Skipped:
13:23 Changeset [90781] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix hang on win32 in a multiprocessing test that shouldn't have been running.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12:55 Changeset [90780] by darin@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-11 Bradley Nelson <bradnelson@chromium.org>

Reviewed by Darin Fisher.

Split webcore_dom off webcore_remaining to reduce its size for
whole program optimization builds.

https://bugs.webkit.org/show_bug.cgi?id=64299

  • WebCore.gyp/WebCore.gyp:
12:33 Changeset [90779] by yi.4.shen@nokia.com
  • 5 edits
    3 adds in trunk

[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
https://bugs.webkit.org/show_bug.cgi?id=62808

Source/WebCore:

Reviewed by Benjamin Poulain.

The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously.

Test: loader/load-defer-resume-crash.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

LayoutTests:

Added a test for the crash occurs when load deferring is turned off.

Reviewed by Benjamin Poulain.

  • loader/load-defer-resume-crash-expected.txt: Added.
  • loader/load-defer-resume-crash.html: Added.
  • loader/resources/images.html: Added.
  • platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
12:20 Changeset [90778] by aroben@apple.com
  • 2 edits
    2 adds in trunk/Tools

Don't count leaks as test failures on TestFailures's front page

As a bonus, this patch adds our first unit test.

Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
are failing on the Leaks bot than actually are

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
failure counts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added. Contains a simple test to show that leaks aren't counted as test failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added. This is the test harness.

12:14 Changeset [90777] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations update.

Mark 2d.gradient.object.update as passing after r90767.

  • platform/chromium/test_expectations.txt:
12:10 Changeset [90776] by kov@webkit.org
  • 6 edits in trunk

Add API to WebKit-GTK to allow setting localStorage database path
https://bugs.webkit.org/show_bug.cgi?id=62091

Patch by Mike Stegeman <mrstegeman@gmail.com> on 2011-06-14
Reviewed by Martin Robinson and Gustavo Noronha.

Expose the path of the localStorage databases through a setting
to allow HTML5 localStorage to be persistent. New setting is:
html5-local-storage-database-path

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

12:06 Changeset [90775] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Move innerTextElement() from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64134

Reviewed by Kent Tamura.

Moved innerTextElement from RenderTextControl to HTMLTextFormControlElement. It is implemented by
HTMLInputElement and HTMLTextAreaElement instead of RenderTextControlSingleLine and
RenderTextControlMultiLine.

This refactoring removes the indirection through RenderTextControl and makes the ownership of
shadow DOM for input and textarea elements clear. Accessing the shadow DOM of input and textarea elements
are now less error prone because it no longer depends on the lifetime of the render tree.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Access innerTextElement via
HTMLTextFormControlElement.

  • dom/Node.cpp:

(WebCore::traverseTreeAndMark): No longer calls innerTextElement because this was a work-around
needed before making input and textarea elements use the new shadow DOM model.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement): Access innerTextElement via HTMLTextFormControlElement.

  • html/HTMLFormControlElement.cpp:

(WebCore::hasVisibleTextArea): Takes innerTextElement.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Calls innerTextElement().
(WebCore::HTMLTextFormControlElement::selection): Ditto.
(WebCore::HTMLTextFormControlElement::selectionStart): Ditto; no longer uses a temporary local variable
for innerTextElement because innerTextElement() no longer depends on the lifetime of the render tree.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.

  • html/HTMLFormControlElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Added.

  • html/HTMLTextAreaElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Made this function a const member.
(WebCore::RenderTextControl::innerTextElement): Added.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:
12:04 Changeset [90774] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should be able to rebaseline tests
https://bugs.webkit.org/show_bug.cgi?id=64186

Reviewed by Eric Seidel.

This patch contains a simple HTTP server binding for the
rebaseline-test command. The frontend will appear in another patch.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
12:02 Changeset [90773] by tony@chromium.org
  • 6 edits in trunk/Source/WebCore

rename RenderObject::isFlexibleBox to isDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=64217

Reviewed by Ojan Vafai.

This is to make way for the new flexbox needing a similar method.
RenderObject also has isFlexingChildren() and isStretchingChildren(),
but we may be able to use those for the new flexbox as well so I
didn't rename them.

No new tests, just refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::shouldCheckLines):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderDeprecatedFlexibleBox.h:

(WebCore::RenderDeprecatedFlexibleBox::isDeprecatedFlexibleBox):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isDeprecatedFlexibleBox):

11:58 Changeset [90772] by abarth@webkit.org
  • 6 edits in trunk/Tools

Add some basic UI for showing regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64243

Reviewed by Eric Seidel.

This UI is all temporary. It exists mostly just to have some buttons
to click to exercise the code.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:54 Changeset [90771] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should be able to determine which revisions caused a given failure
https://bugs.webkit.org/show_bug.cgi?id=64189

Reviewed by Adam Roben.

Walking the failure history looking for failures turns out to be
slightly tricky because the network requests are asynchronous.
Currently we do all the fetches serially and our cache is unbounded.
We'll probably optimize both those parameters eventually.

This patch also generalizes some functionality in the unit testing
framework to make testing this sort of code easier.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
11:51 Changeset [90770] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/Tools

Add a webkit-patch command for rebaselining an individual test
https://bugs.webkit.org/show_bug.cgi?id=64246

Reviewed by Eric Seidel.

This patch introduces a command that's able to rebaseline a single
test. Currently, the command works only with the build.chromium.org
buildbots, but extending it to work with the build.webkit.org bots
shouldn't be that hard.

A complete rebaseling tool should also include an "optimize baselines"
command (which moves/deletes baselines in order to reduce the number of
expected results files), but that will come in a future patch.

Really BuilderToPort should be merged into builders.py, but I'm going
to save that for a future patch as well. (We need to stop shaving yaks
at some point.)

  • Scripts/webkitpy/tool/commands/rebaseline.py:
11:48 Changeset [90769] by japhet@chromium.org
  • 2 edits
    1 add in trunk/Source/WebCore

[Chromium] Ensure we don't crash when an
HTMLSelectElement mouse release event removes
the element from the DOM.
https://bugs.webkit.org/show_bug.cgi?id=64295

Reviewed by Dimitri Glazkov.

Manual test only because the crash requires a
real popup menu, which DRT doesn't provide.

  • manual-tests/chromium/popup-menu-crash.html: Added.
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::handleMouseReleaseEvent):

11:39 Changeset [90768] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG Speculative JIT does not always insert speculation checks when speculating
arrays.
https://bugs.webkit.org/show_bug.cgi?id=64254

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-11
Reviewed by Gavin Barraclough.

Changed the SetLocal instruction to always validate that the value being stored
into the local variable is an array, if that variable was marked PredictArray.
This is necessary since uses of arrays assume that if a PredictArray value is
in a local variable then the speculation check validating that the value is an
array was already performed.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:39 Changeset [90767] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[skia] remove platform helpers for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=64281

Patch by Mike Reed <reed@google.com> on 2011-07-11
Reviewed by Stephen White.

No new tests. fixes canvas/philip/tests/2d.gradient.object.update.html

Remove (now empty) platform helpers for fill/stroke gradients/patterns. We now pickup the platformGradient
and platformPattern fresh when they're needed, so we can see any edits that have occurred to them
2d.gradient.object.update.html sets the fillgradient, and then edits the gradient object. This CL allows
us to see that edit.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformInit):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::~State):
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::setupShader):
(WebCore::PlatformContextSkia::setupPaintForFilling):
(WebCore::PlatformContextSkia::setupPaintForStroking):
(WebCore::PlatformContextSkia::setFillColor):
(WebCore::PlatformContextSkia::setStrokeColor):
(WebCore::PlatformContextSkia::canAccelerate):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::setGraphicsContext):

11:22 Changeset [90766] by benjamin.poulain@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Get rid of focusNextPrevChild()
https://bugs.webkit.org/show_bug.cgi?id=64289

Reviewed by Andreas Kling.

Qt 5 does not use focusNextPrevChild() but uses setFocusNavigation(), and
the focus is not based on QWidget.

We can get rid of the method since the new implementation will be totally
different.

  • UIProcess/API/qt/qtouchwebpage.cpp:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_takeFocus):

  • UIProcess/qt/QtWebPageProxy.h:
11:20 Changeset [90765] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Patch by Young Han Lee <joybro@company100.net> on 2011-07-11
Reviewed by Simon Fraser.

Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
https://bugs.webkit.org/show_bug.cgi?id=63859

The existing code to set the m_startTime haven't worked because
the animation is not the right state to accept the start event.
This patch just sets the values directly instead of using event.

Source/WebCore:

Test: transitions/delay.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

  • transitions/delay-expected.txt: Added.
  • transitions/delay.html: Added.
11:14 Changeset [90764] by andersca@apple.com
  • 13 edits in trunk

Implement getFormValue for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64294
<rdar://problem/3964087>

Source/WebKit2:

Reviewed by Kevin Decker.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::getFormValue):
Call Plugin::getFormValue.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new GetFormValue message.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::getFormValue):
Get the form value and convert it to a String.

  • WebProcess/Plugins/Plugin.h:

Add getFormValue pure virtual member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getFormValue):
Send a GetFormValue message to the plug-in process.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::getFormValue):
Call Plugin::getFormValue.

LayoutTests:

Remove now passing test.

  • platform/wk2/Skipped:
10:55 Changeset [90763] by rniwa@webkit.org
  • 9 edits in trunk/Source

Move selection related code from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64133

Reviewed by Dimitri Glazkov.

Source/WebCore:

Moved selectionStart, selectionEnd, hasVisibleTextArea, setSelectionRange, setContainerAndOffsetForRange
and selection from RenderTextControl.cpp to HTMLFormControlElement.cpp.

This refactoring removes RenderTextControl's dependency on FrameSelection.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText): Calls HTMLTextFromControl::selectedText.
(WebCore::AccessibilityRenderObject::selectedTextRange): Calls selectionStart and selectionEnd.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText): Extracted from AccessibilityRenderObject::selectedText.
(WebCore::hasVisibleTextArea): Added.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls computeSelectionStart instead of RenderTextControl::selectionStart.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Moved from RenderTextControl::selectionStart.
(WebCore::HTMLTextFormControlElement::selectionEnd): Calls computeSelectionEnd instead of RenderText::selectionEnd.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Moved from RenderTextControl::selectionStart.
(WebCore::setContainerAndOffsetForRange): Moved from RenderTextControl.cpp.
(WebCore::HTMLTextFormControlElement::selection): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls computeSelectionStart and computeSelectionEnd instead of
RenderTextControl::selectionStart and RenderTextControl::selectionEnd.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls selectionStart and selectionEnd.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Calls setSelectionRange.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Added.

  • rendering/RenderTextControl.h:

Source/WebKit/qt:

Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

10:51 Changeset [90762] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=64185

Reviewed by Eric Seidel.

This gardening server API is simply a binding to the rollout machinery
already present in webkit-patch.

  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
10:35 Changeset [90761] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix syntax error from r90757.

  • platform/chromium/test_expectations.txt:
09:57 Changeset [90760] by adachan@apple.com
  • 6 edits in trunk/Source/WebKit2

The original request should be accessible from WebNavigationData.
https://bugs.webkit.org/show_bug.cgi?id=64227

Reviewed by Anders Carlsson.

  • Shared/WebNavigationDataStore.h: (WebKit::WebNavigationDataStore::encode): Handle the encoding of the original request. (WebKit::WebNavigationDataStore::decode): Handle the decoding of the original request.
  • UIProcess/API/C/WKNavigationData.cpp: (WKNavigationDataCopyOriginalRequest):
  • UIProcess/API/C/WKNavigationData.h:
  • UIProcess/WebNavigationData.h: (WebKit::WebNavigationData::originalRequest):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the original request in the WebNavigationDataStore.
09:52 Changeset [90759] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache/history-only-cached-subresource-loads-max-age-https.html timing out on
Windows and WebKit2 since it was added.
https://bugs.webkit.org/show_bug.cgi?id=63806

Add the test to the WK2 Skipped list to get the bots green.

  • platform/wk2/Skipped:
09:47 Changeset [90758] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Oliver Hunt.

Canvas: Use fast, approximate dirty rects for stroke()
https://bugs.webkit.org/show_bug.cgi?id=59764

No new tests, this is an optimization.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Instead of using
Path::strokeBoundingRect() to calculate the exact bounding rect
for a path stroke, get the Path::boundingRect() and inflate it by
miterLimit + lineWidth to get a slightly oversized dirty rect
in a fraction of the time.

09:37 Changeset [90757] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
09:36 Changeset [90756] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=36415

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2011-07-11
Reviewed by Gustavo Noronha.

  • uk.po: added.
09:30 Changeset [90755] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Indonesian translation
https://bugs.webkit.org/show_bug.cgi?id=44410

Patch by Andika Triwidada <andika@gmail.com> on 2011-07-11
Reviewed by Gustavo Noronha.

  • id.po: updated.
09:26 Changeset [90754] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Portuguese translation update
https://bugs.webkit.org/show_bug.cgi?id=46137

Patch by Duarte Loreto <happyguy_pt@hotmail.com> on 2011-07-11
Reviewed by Gustavo Noronha.

  • pt.po: updated.
09:09 Changeset [90753] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Remove non-existent editing/pasteboard/do-not-copy-body-color.html.
08:58 Changeset [90752] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][Mac] Unreviewed fix after r90746.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests): Really disable NRWT for qt-mac platform.

08:55 Changeset [90751] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
08:53 Changeset [90750] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebKit2

[Qt][WK2] Forward the viewport visible area from the view instead of inferring it from the TiledDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=64275

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-11
Reviewed by Simon Hausmann.

This patch refactors the way the viewport visible area is handled.
Previously, the TiledDrawingAreaProxy would ask for the visible rect
when painting or updating. This is reversed with this patch, and the viewport
informs the page of any change in the view area.

With this change, the TiledDrawingAreaProxy does not need to know about QTouchWebPage,
and can use the TouchViewInterface directly.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setViewportRect):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):
(QTouchWebViewPrivate::viewportRectUpdated):
(QTouchWebView::resizeEvent):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::setVisibleArea):
(WebKit::TiledDrawingAreaProxy::createTiles):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::updateWebView):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::contentSizeChanged):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/WebPageProxyQt.cpp:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::createDrawingAreaProxy):
(QTouchWebPageProxy::setVisibleArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
08:44 Changeset [90749] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
08:38 Changeset [90748] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles.
https://bugs.webkit.org/show_bug.cgi?id=64285

Add fast/forms/file-input-change-event.html to the mac-wk2 Skipped list to get the bots
green.

  • platform/wk2/Skipped:
08:27 Changeset [90747] by aroben@apple.com
  • 2 edits in trunk/Tools

Teach TestFailures that ORWT's results.html file might be missing due to all tests passing

There are three reasons why we might fail to fetch ORWT's results.html:

  • All tests passed, so no results.html was generated
  • Some error during the test run caused results.html not to be generated (e.g., ORWT timed out)
  • Some network error occurred when fetching results.html

We were failing to account for the first possibility in some cases. For test runs before
r89610, we first check build.webkit.org/json to determine how many tests failed and whether
ORWT exited early due to too many failures; if all tests passed then we don't fetch
results.html at all. r89610 changed ORWT to put information in results.html about exiting
early due to too many failures, so we no longer needed to check build.webkit.org/json to get
that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
still needed to check build.webkit.org/json to find out if all tests passed!

Now, for test runs after r89610, we check results.html first, and then check
build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
tests passing and the error cases.

Fixes <http://webkit.org/b/64280> TestFailures page can't pinpoint that r90699 caused 13
tests to fail on Windows 7 Release (WebKit2 Tests)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
cached data will get evicted. We were marking builds where all tests passed as errors!
(LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
parameters to the fetchAndParseResultsHTML helper function, and added a similar
fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
from later in the function). For test runs before r89610, we first check
build.webkit.org/json then check results.html. For builds after r89610, we first check
results.html and then check build.webkit.org/json if we couldn't fetch results.html.

08:15 Changeset [90746] by ossy@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests does not support qt-arm or qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

Reviewed by Zoltán Herczeg.

  • Scripts/run-webkit-tests: Disable NRWT for qt-mac, qt-arm and qt-4.8 platforms until fix.

(useNewRunWebKitTests):

07:38 Changeset [90745] by caseq@chromium.org
  • 11 edits in trunk

Reviewed by Pavel Feldman.

Web Inspector: [refactoring] Remove dependencies of components requiring network resource list from network panel
https://bugs.webkit.org/show_bug.cgi?id=62477

Source/WebCore:

  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._inspectedURLChanged):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype.initExtensions):

  • inspector/front-end/HAREntry.js:

(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get resources):
(WebInspector.NetworkLog.prototype._onInspectedURLChanged):
(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._reset):
(WebInspector.NetworkPanel.prototype._copyAll):
(WebInspector.NetworkPanel.prototype._exportAll):

  • inspector/front-end/inspector.js:

(WebInspector.reset):

LayoutTests:

  • http/tests/inspector/resource-har-conversion.html:
07:37 Changeset [90744] by aroben@apple.com
  • 1 edit
    25 adds in trunk/LayoutTests

Add back the win-xp and win-wk2 results that were deleted in r90699

Deleting these results caused the tests to start failing on the bots. The only test result I
didn't add back was
win-wk2/http/tests/uri/username-with-no-hostname-expected.txt, as that test is not currently
failing on the bots.

Fixes <http://webkit.org/b/64277> REGRESSION (r90699): 12 svg tests failing on Windows XP
Debug (Tests) and 13 tests failing on Windows 7 Release (WebKit2 Tests)

  • platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
  • platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Added.
07:08 Changeset [90743] by podivilov@chromium.org
  • 4 edits in trunk

Web Inspector: make SourceFrame a View.
https://bugs.webkit.org/show_bug.cgi?id=64274

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype._beforeTextChanged):
(WebInspector.SourceFrame.prototype._afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype._suggestedFileName):
(WebInspector.SourceFrame.prototype._doubleClick):
(WebInspector.SourceFrame.prototype._cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):

07:03 Changeset [90742] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-11
Reviewed by Adam Roben.

Source/WebCore:

Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::setFocus): Forward focus events if the plugin is windowless.

LayoutTests:

New plugin/keyboard-events,mouse-events test expectations for the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375

  • platform/win/plugins/keyboard-events-expected.txt: Added.
  • platform/win/plugins/mouse-events-expected.txt: Updated.
06:54 Changeset [90741] by yael.aharon@nokia.com
  • 4 edits in trunk/LayoutTests

[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255

Reviewed by Csaba Osztrogonác.

Modify the tests to wait until the icon loading is finished.

  • fast/notifications/notifications-double-show.html:
  • fast/notifications/notifications-with-permission.html:
  • platform/qt/Skipped:
06:52 Changeset [90740] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

  • platform/qt/test_expectations.txt: Set inspector/cookie-parser.html as flakey test.
06:25 Changeset [90739] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Move zoomable-area-for-point functionality to QTouchWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=64273

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::findZoomableAreaForPoint):
(QTouchWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
05:32 Changeset [90738] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the condition of the optimized code in doubleTransfer
https://bugs.webkit.org/show_bug.cgi?id=64261

Reviewed by Zoltan Herczeg.

The condition of the optimized code in doubleTransfer is wrong. The
data transfer should be executed with four bytes aligned address.
VFP cannot perform unaligned memory access.

Reported by Jacob Bramley.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::doubleTransfer):

05:29 Changeset [90737] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Added accessibility notification when value is changed.
https://bugs.webkit.org/show_bug.cgi?id=64256

Notifies the value change of range input when accessibility is enabled.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-11
Reviewed by Kent Tamura.

Covered by existing tests.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

Added accessibility notification when value is changed.

05:21 Changeset [90736] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove duplicates from Chromium test expectations.

  • platform/chromium/test_expectations.txt:
04:58 Changeset [90735] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Fix resizing of sidebar pane in Timeline and Profile panels.
https://bugs.webkit.org/show_bug.cgi?id=64161

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):

04:55 Changeset [90734] by pfeldman@chromium.org
  • 28 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location.
https://bugs.webkit.org/show_bug.cgi?id=63982

Rolling out 89760, 89756, 89754, 89753 for breaking inspector highlight.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawNodeHighlight):

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/Widget.cpp:
  • platform/Widget.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):

  • rendering/RenderObject.h:

(WebCore::RenderObject::localToAbsoluteQuad):

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

  • rendering/svg/SVGRenderSupport.h:
04:17 Changeset [90733] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r90698.

  • platform/chromium/test_expectations.txt:
04:09 Changeset [90732] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped:
    • Remove non-existent editing tests.
    • Remove fast/selectors/unqualified-hover-strict.html, because it is in test_expectations.txt too.
    • Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it is in test_expectations.txt too.
03:31 Changeset [90731] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Signed arithmetic bug in dataTransfer32.
https://bugs.webkit.org/show_bug.cgi?id=64257

Reviewed by Zoltan Herczeg.

An arithmetic bug is fixed. If the offset of dataTransfer is half of the
addressable memory space on a 32-bit machine (-2147483648 = 0x80000000)
a load instruction is emitted with a wrong zero offset.

Inspired by Jacob Bramley's patch from JaegerMonkey.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):

02:33 Changeset [90730] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
02:18 Writing Reftests edited by kbalazs@webkit.org
Remove the disclaimer since nrwt has become the default harness (diff)
02:06 Changeset [90729] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt/test_expectations.txt: Do not expect the test to crash any more.
01:56 Changeset [90728] by bashi@chromium.org
  • 7 edits in trunk

Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files
https://bugs.webkit.org/show_bug.cgi?id=64248

Tools:

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-11
Reviewed by Kent Tamura.

  • DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto.
  • GNUmakefile.am: Ditto.

LayoutTests:

Updates test_expectations.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-11
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Removed SKIP from plugins/form-value.html.
01:11 Changeset [90727] by jamesr@google.com
  • 144 edits
    21 adds
    3 deletes in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 12/12).

  • platform/chromium-gpu-linux/compositing/geometry/outline-change-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-linux/editing/pasteboard/3976872-expected.png:
  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/dom/34176-expected.png:
  • platform/chromium-linux/fast/dom/HTMLElement/bdo-expected.png:
  • platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.png:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png:
  • platform/chromium-linux/fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/international/003-expected.png:
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-linux/http/tests/misc/iframe404-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1220-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-fixed-container-expected.png:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-vista/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/misc/iframe404-expected.png: Added.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/34176-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/international/003-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/3976872-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-win/fast/css/acid2-pixel-expected.png:
  • platform/chromium-win/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/dom/HTMLElement/bdo-expected.png:
  • platform/chromium-win/fast/forms/001-expected.png:
  • platform/chromium-win/fast/forms/input-first-letter-expected.png:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png:
  • platform/chromium-win/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.txt:
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-win/fast/text/should-use-atsui-expected.png:
  • platform/chromium-win/plugins/embed-attributes-style-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1220-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-fixed-container-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium/test_expectations.txt:
00:51 Changeset [90726] by yutak@chromium.org
  • 7 edits
    158 adds in trunk/LayoutTests

WebSocket: Copy existing WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=64242

Reviewed by Kent Tamura.

Copy the existing WebSocket tests under http/tests/websocket/tests/hybi/ and skip them.

These tests will be used to test the latest WebSocket protocol implementation. They are skipped
in all ports for now, and will be unskipped when the new protocol implementation is landed in WebCore.

The following modifications are applied to the new tests:

  • Change paths and URLs appeared in the tests and the test results so they fit for the new location.
  • Call layoutTestController.overridePreferences() to enable the new protocol implementation.
  • http/tests/websocket/tests/hybi/alert-in-event-handler-expected.txt: Added.
  • http/tests/websocket/tests/hybi/alert-in-event-handler.html: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash.html: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars.html: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty.html: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html: Added.
  • http/tests/websocket/tests/hybi/client-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/client-close.html: Added.
  • http/tests/websocket/tests/hybi/client-close_wsh.py: Added.
  • http/tests/websocket/tests/hybi/close-before-open-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-before-open.html: Added.
  • http/tests/websocket/tests/hybi/close-event-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-event.html: Added.
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload_wsh.py: Added.
  • http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-unref-websocket.html: Added.
  • http/tests/websocket/tests/hybi/cross-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/cross-origin.html: Added.
  • http/tests/websocket/tests/hybi/echo-challenge_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo-cookie_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo-location_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo_wsh.py: Added.
  • http/tests/websocket/tests/hybi/error-detect-expected.txt: Added.
  • http/tests/websocket/tests/hybi/error-detect.html: Added.
  • http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-lengths-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-lengths.html: Added.
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness.html: Added.
  • http/tests/websocket/tests/hybi/handshake-error-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-error.html: Added.
  • http/tests/websocket/tests/hybi/handshake-error_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Added.
  • http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Added.
  • http/tests/websocket/tests/hybi/httponly-cookie-expected.txt: Added.
  • http/tests/websocket/tests/hybi/httponly-cookie.pl: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header.html: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/multiple-connections-expected.txt: Added.
  • http/tests/websocket/tests/hybi/multiple-connections.html: Added.
  • http/tests/websocket/tests/hybi/no-query_wsh.py: Added.
  • http/tests/websocket/tests/hybi/null-character-expected.txt: Added.
  • http/tests/websocket/tests/hybi/null-character.html: Added.
  • http/tests/websocket/tests/hybi/origin-test_wsh.py: Added.
  • http/tests/websocket/tests/hybi/protocol-test_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reload-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reload-crash.html: Added.
  • http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html: Added.
  • http/tests/websocket/tests/hybi/resources/close-on-unload-iframe.html: Added.
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html: Added.
  • http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html: Added.
  • http/tests/websocket/tests/hybi/send-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-throw-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-throw.html: Added.
  • http/tests/websocket/tests/hybi/send.html: Added.
  • http/tests/websocket/tests/hybi/send2_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send_wsh.py: Added.
  • http/tests/websocket/tests/hybi/server-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/server-close.html: Added.
  • http/tests/websocket/tests/hybi/server-close_wsh.py: Added.
  • http/tests/websocket/tests/hybi/simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/simple-stress-expected.txt: Added.
  • http/tests/websocket/tests/hybi/simple-stress.html: Added.
  • http/tests/websocket/tests/hybi/simple.html: Added.
  • http/tests/websocket/tests/hybi/simple_wsh.py: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space.html: Added.
  • http/tests/websocket/tests/hybi/sub-protocol.html: Added.
  • http/tests/websocket/tests/hybi/unicode-expected.txt: Added.
  • http/tests/websocket/tests/hybi/unicode.html: Added.
  • http/tests/websocket/tests/hybi/unicode_wsh.py: Added.
  • http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Added.
  • http/tests/websocket/tests/hybi/url-no-trailing-slash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-no-trailing-slash.html: Added.
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-parsing.html: Added.
  • http/tests/websocket/tests/hybi/url-with-credential-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-credential.html: Added.
  • http/tests/websocket/tests/hybi/url-with-empty-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-empty-query.html: Added.
  • http/tests/websocket/tests/hybi/url-with-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Added.
  • http/tests/websocket/tests/hybi/url-with-query.html: Added.
  • http/tests/websocket/tests/hybi/websocket-event-target-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-event-target.html: Added.
  • http/tests/websocket/tests/hybi/websocket-pending-activity-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-pending-activity.html: Added.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-worker-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-worker.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/close-in-onmessage-crash.js: Added.

(runTests.try.ws.onopen):
(runTests.try.ws.onmessage):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/close-in-worker.js: Added.

(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.ws.onopen):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/echo-challenge_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/echo_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/simple_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/worker-handshake-challenge-randomness.js: Added.

(endTest):
(runTests.try.ws1.onmessage):
(runTests.try.ws1.onclose.ws2.onmessage):
(runTests.try.ws1.onclose.ws2.onclose):
(runTests.try.ws1.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/worker-simple.js: Added.

(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.ws.onopen):
(runTests.try.ws.onmessage):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/shared-worker-simple.html: Added.
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness.html: Added.
  • http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-simple.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

A category "failing websocket tests" is listed at the beginning of Skipped file,
but there is no such section in the lists. Thus, a new section is inserted.

  • platform/win/Skipped:
  • platform/wk2/Skipped:
00:45 Changeset [90725] by jamesr@google.com
  • 201 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 11/??).

  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cellspacing-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nested2-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/padding-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla/other/cellspacing-expected.png:
  • platform/chromium-win/tables/mozilla/other/nested2-expected.png:
  • platform/chromium-win/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-win/tables/mozilla/other/padding-expected.png:
  • platform/chromium-win/tables/mozilla/other/test3-expected.png:
  • platform/chromium-win/tables/mozilla/other/test6-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium/test_expectations.txt:
00:24 Changeset [90724] by jamesr@google.com
  • 202 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 10/??).

  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_rel-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellspacing-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_rel-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellspacing-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_middle-expected.png:
  • platform/chromium/test_expectations.txt:
00:06 Changeset [90723] by commit-queue@webkit.org
  • 9 edits in trunk

Patch by Mustafizur Rahaman <mustaf.here@gmail.com> on 2011-07-11
Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48292

and

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48302

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationAtop
to draw transparency elsewhere for destination-atop

LayoutTests:

  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt: Added

a trailing line

  • fast/canvas/canvas-composite-alpha.html: Rebaselined for destination-atop test case
  • platform/chromium/test_expectations.txt: Removed passing test case
  • platform/gtk/Skipped: Ditto
  • platform/mac/Skipped: Ditto
  • platform/qt/Skipped: Ditto
00:03 Changeset [90722] by jamesr@google.com
  • 202 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 9/??).

  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_cellpadding-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_cellpadding-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium/test_expectations.txt:

07/10/11:

23:41 Changeset [90721] by jamesr@google.com
  • 202 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 8/??).

  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_per-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_auto-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_per-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-linux/tables/mozilla/core/nested1-expected.png:
  • platform/chromium-linux/tables/mozilla/core/one_row-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/core/table_frame-expected.png:
  • platform/chromium-linux/tables/mozilla/core/table_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/core/table_widths-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/appendCol2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/appendRowsExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCellsShrink1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCellsShrink2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCol1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCol2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteCol3-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteColGroup1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteColGroup2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteRowsShrink1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCellsExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCellsExpand2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCellsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCellsRebuild2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertColGroups1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertColGroups2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCols1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCols2-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCols3-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCols4-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertCols5-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertRowsExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/insertRowsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/body_col-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/col_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_overflow_hidden_td-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_row_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_row_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_black-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_blue-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_gray-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_green-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_lime-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_navy-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_olive-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_purple-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_red-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_silver-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_teal-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_white-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_border_1-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_border_2-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_border_3-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_per-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_auto-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_fix-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_per-expected.png:
  • platform/chromium-win/tables/mozilla/core/margins-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/core/nested1-expected.png:
  • platform/chromium-win/tables/mozilla/core/one_row-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/core/table_frame-expected.png:
  • platform/chromium-win/tables/mozilla/core/table_heights-expected.png:
  • platform/chromium-win/tables/mozilla/core/table_widths-expected.png:
  • platform/chromium-win/tables/mozilla/dom/appendCol2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/appendRowsExpand1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCellsShrink1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCellsShrink2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCol1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCol2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteCol3-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteColGroup1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteColGroup2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteRowsShrink1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCellsExpand1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCellsExpand2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCellsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCellsRebuild2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertColGroups1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertColGroups2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCols1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCols2-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCols3-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCols4-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertCols5-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertRowsExpand1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/insertRowsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/body_col-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/col_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_overflow_hidden_td-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_black-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_blue-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_gray-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_green-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_lime-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_navy-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_olive-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_purple-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_red-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_silver-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_teal-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_white-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_border_1-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_border_2-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_border_3-expected.png:
  • platform/chromium/test_expectations.txt:
23:32 Changeset [90720] by mnaganov@chromium.org
  • 11 edits
    4 adds
    1 delete in trunk/Source/WebCore

Web Inspector: [Chromium] Get rid of flickering "Please wait" message in Heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=61175

The message has been replaced with spinner icons appearing instead of profile's
icon. As each profile owns a worker, they run independently, and there can be
multiple spinners at the same time.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled):
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype.processLoadedSnapshot):
(WebInspector.DetailedHeapshotView.prototype._changeView):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.dispose):
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
(WebInspector.HeapSnapshotWorker.prototype._checkLongRunningCalls):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.get worker):

  • inspector/front-end/Images/spinnerActive.gif: Added. Generated using ajaxload.info.
  • inspector/front-end/Images/spinnerActiveSelected.gif: Added. Generated using ajaxload.info.
  • inspector/front-end/Images/spinnerInactive.gif: Added. Generated using ajaxload.info.
  • inspector/front-end/Images/spinnerInactiveSelected.gif: Added. Generated using ajaxload.info.
  • inspector/front-end/PleaseWaitMessage.js: Removed.
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot.setProfileWait):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarTreeElement.prototype.set wait):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/heapProfiler.css:

(.heap-snapshot-sidebar-tree-item.wait .icon):
(.heap-snapshot-sidebar-tree-item.wait.selected .icon):
(body.inactive .heap-snapshot-sidebar-tree-item.wait .icon):
(body.inactive .heap-snapshot-sidebar-tree-item.wait.selected .icon):

  • inspector/front-end/inspector.html:
23:01 Changeset [90719] by jamesr@google.com
  • 200 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 7/??).

  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4385-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44523-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4501-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4520-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4523-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug45486-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4576-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46268-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46268-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46268-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46268-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46623-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46924-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46944-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4739-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug47432-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug53690-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug53690-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug53891-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug54450-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug57300-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug57378-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug57828-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5798-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5799-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5835-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug58402-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60013-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60807-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60992-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6184-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug647-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug68998-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug69187-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug69382-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7121-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug727-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7471-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7714-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug81934-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug82946-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug88035-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8858-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug9123-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug9123-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92143-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug965-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug97138-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug98196-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug9879-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug99923-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/borders-expected.png:
  • platform/chromium-linux/tables/mozilla/core/box_sizing-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_span-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_auto-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4385-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44523-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4501-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4520-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4523-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug45486-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4576-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46268-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46268-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46268-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46268-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46924-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46944-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4739-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug47432-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug53690-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug53690-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug53891-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug54450-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56201-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug57300-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug57378-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug57828-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5798-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5799-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5835-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug58402-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60013-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60807-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60992-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6184-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug68998-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug69187-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug69382-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7121-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug727-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7471-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7714-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug78162-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug81934-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug82946-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug88035-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8858-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9123-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9123-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug92143-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug965-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97138-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug98196-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9879-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug99923-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/borders-expected.png:
  • platform/chromium-win/tables/mozilla/core/box_sizing-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_span-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_auto-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium/test_expectations.txt:
22:31 Changeset [90718] by jamesr@google.com
  • 195 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 6/??).

  • platform/chromium-linux/tables/mozilla/bugs/bug139524-4-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1474-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15247-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16252-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17168-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug175455-4-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17548-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17587-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1800-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1809-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1828-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18440-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18558-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18955-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug19356-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug19599-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2050-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2065-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug21299-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug21918-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug220536-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug221784-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug221784-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22246-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22246-2a-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22246-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22246-3a-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2267-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug24503-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug24627-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug24661-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug24880-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug25004-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug25086-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug25663-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2585-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2684-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2757-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2773-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug278385-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug27993-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29058-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29157-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2962-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30273-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30332-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30332-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30418-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3103-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3191-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-5-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3260-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3263-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32841-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3309-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33137-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3454-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug35662-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3718-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug40828-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug41890-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug42187-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug42443-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug139524-4-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1474-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15247-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug16252-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17168-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug175455-4-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17548-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17587-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1800-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1802-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1809-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1818-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1818-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1818-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1818-4-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1828-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18440-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18558-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18955-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug19356-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug19599-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2050-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2065-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug21299-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug21918-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug219693-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug219693-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug220536-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug221784-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug221784-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22246-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22246-2a-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22246-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22246-3a-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2267-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24503-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24627-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24661-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24880-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug25004-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug25086-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug25663-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2585-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2684-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2757-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2773-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug278385-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27993-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29157-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29429-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2962-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30273-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30332-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30332-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30418-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3103-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3191-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32205-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32205-5-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3260-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3263-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32841-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3309-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug33137-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3454-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug35662-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3718-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug40828-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug41890-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug42187-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug42443-expected.png:
  • platform/chromium/test_expectations.txt:
22:19 Changeset [90717] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Generate conditional include statements in CodeGeneratorJS
https://bugs.webkit.org/show_bug.cgi?id=64231

Reviewed by Brent Fulgham.

Suround headers with a correspondig #if ENABLE() line.
This allows us to generate bindings only of required IDL files.

Changing the current preprocessor statements to the Conditional attribute
in a next step helps in getting rid of calls to the preprocessor,
which causes so much pain on a natvie Windows environment.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(WriteData):

22:00 Changeset [90716] by jamesr@google.com
  • 191 edits
    1 copy
    5 adds in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 5/??).

  • platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-linux/fast/table/click-near-anonymous-table-expected.png:
  • platform/chromium-linux/fast/table/dynamic-cellpadding-expected.png:
  • platform/chromium-linux/fast/table/early-table-layout-expected.png:
  • platform/chromium-linux/fast/table/edge-offsets-expected.png:
  • platform/chromium-linux/fast/table/large-width-expected.png:
  • platform/chromium-linux/fast/table/nobr-expected.png:
  • platform/chromium-linux/fast/table/overflowHidden-expected.png:
  • platform/chromium-linux/fast/table/percent-heights-expected.png:
  • platform/chromium-linux/fast/table/row-height-recalc-expected.png:
  • platform/chromium-linux/fast/table/rowindex-expected.png:
  • platform/chromium-linux/fast/table/rowspan-paint-order-expected.png:
  • platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-linux/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/chromium-linux/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png:
  • platform/chromium-linux/fast/table/table-hspace-align-center-expected.png:
  • platform/chromium-linux/fast/table/text-field-baseline-expected.png:
  • platform/chromium-linux/fast/table/unbreakable-images-quirk-expected.png:
  • platform/chromium-linux/fast/table/vertical-align-baseline-expected.png:
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/chromium-linux/fast/text/basic/001-expected.png:
  • platform/chromium-linux/fast/text/basic/006-expected.png:
  • platform/chromium-linux/fast/text/basic/007-expected.png:
  • platform/chromium-linux/fast/text/basic/015-expected.png:
  • platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/chromium-linux/fast/text/cg-vs-atsui-expected.png:
  • platform/chromium-linux/fast/text/in-rendered-text-rtl-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-innertext-expected.png:
  • platform/chromium-linux/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-linux/fast/text/midword-break-hang-expected.png:
  • platform/chromium-linux/fast/text/whitespace/027-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-linux/fast/text/word-break-expected.png:
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-linux/http/tests/loading/simple-subframe-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/location-replace-crossdomain-expected.png:
  • platform/chromium-linux/http/tests/multipart/invalid-image-data-standalone-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/tables/layering/paint-test-layering-1-expected.png:
  • platform/chromium-linux/tables/layering/paint-test-layering-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10009-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10036-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10039-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug101201-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1067-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug106816-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug108340-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug109043-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug110566-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113424-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12008-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1224-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12268-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1261-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12709-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug128229-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12910-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug13118-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug13196-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug13484-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win-vista/http/tests/loading/simple-subframe-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/location-replace-crossdomain-expected.png: Copied from LayoutTests/platform/chromium-win/fast/table/giantRowspan-expected.png.
  • platform/chromium-win-vista/http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
  • platform/chromium-win-xp/fast/text/basic/006-expected.png:
  • platform/chromium-win-xp/fast/text/cg-vs-atsui-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-win/fast/table/click-near-anonymous-table-expected.png:
  • platform/chromium-win/fast/table/dynamic-cellpadding-expected.png:
  • platform/chromium-win/fast/table/early-table-layout-expected.png:
  • platform/chromium-win/fast/table/edge-offsets-expected.png:
  • platform/chromium-win/fast/table/giantRowspan-expected.png:
  • platform/chromium-win/fast/table/large-width-expected.png:
  • platform/chromium-win/fast/table/multiple-percent-height-rows-expected.png:
  • platform/chromium-win/fast/table/nobr-expected.png:
  • platform/chromium-win/fast/table/overflowHidden-expected.png:
  • platform/chromium-win/fast/table/percent-heights-expected.png:
  • platform/chromium-win/fast/table/row-height-recalc-expected.png:
  • platform/chromium-win/fast/table/rowindex-expected.png:
  • platform/chromium-win/fast/table/rowspan-paint-order-expected.png:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-win/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png:
  • platform/chromium-win/fast/table/table-hspace-align-center-expected.png:
  • platform/chromium-win/fast/table/text-field-baseline-expected.png:
  • platform/chromium-win/fast/table/unbreakable-images-quirk-expected.png:
  • platform/chromium-win/fast/table/vertical-align-baseline-expected.png:
  • platform/chromium-win/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/chromium-win/fast/text/basic/001-expected.png:
  • platform/chromium-win/fast/text/basic/006-expected.png:
  • platform/chromium-win/fast/text/basic/007-expected.png:
  • platform/chromium-win/fast/text/basic/015-expected.png:
  • platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/chromium-win/fast/text/cg-vs-atsui-expected.png:
  • platform/chromium-win/fast/text/in-rendered-text-rtl-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-win/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/chromium-win/fast/text/international/bidi-innertext-expected.png:
  • platform/chromium-win/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-win/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-win/fast/text/midword-break-hang-expected.png:
  • platform/chromium-win/fast/text/whitespace/027-expected.png:
  • platform/chromium-win/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-win/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/chromium-win/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-win/fast/text/word-break-expected.png:
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.png:
  • platform/chromium-win/svg/custom/svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/tables/layering/paint-test-layering-1-expected.png:
  • platform/chromium-win/tables/layering/paint-test-layering-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10009-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10036-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10039-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101201-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1067-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug106795-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug106816-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug108340-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug109043-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug110566-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113424-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12008-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1224-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12268-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1261-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12709-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug128229-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12910-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13118-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13196-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug133948-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13484-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug137388-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug137388-3-expected.png:
  • platform/chromium/test_expectations.txt:
21:26 Changeset [90715] by jamesr@google.com
  • 197 edits
    1 add in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 4/??).

  • platform/chromium-linux/fast/forms/button-default-title-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-linux/fast/forms/button-style-color-expected.png:
  • platform/chromium-linux/fast/forms/caret-rtl-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-with-float-expected.png:
  • platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-linux/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-linux/fast/forms/image-border-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-linux/fast/forms/text-style-color-expected.png:
  • platform/chromium-linux/fast/frames/frameElement-iframe-expected.png:
  • platform/chromium-linux/fast/frames/iframe-option-crash-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/iframe-with-frameborder-expected.png:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-linux/fast/frames/viewsource-on-image-file-expected.png:
  • platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-linux/fast/inline/inline-box-background-expected.png:
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-linux/fast/inline/inline-continuation-borders-expected.png:
  • platform/chromium-linux/fast/inline/outline-continuations-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/invalid/table-inside-stray-table-content-expected.png:
  • platform/chromium-linux/fast/lists/004-expected.png:
  • platform/chromium-linux/fast/lists/markers-in-selection-expected.png:
  • platform/chromium-linux/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-linux/fast/lists/olstart-expected.png:
  • platform/chromium-linux/fast/media/viewport-media-query-expected.png:
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-linux/fast/overflow/002-expected.png:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-rtl-inline-scrollbar-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.txt: Added.
  • platform/chromium-linux/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-linux/fast/repaint/containing-block-position-change-expected.png:
  • platform/chromium-linux/fast/repaint/delete-into-nested-block-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/flexible-box-overflow-expected.png:
  • platform/chromium-linux/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/float-move-during-layout-expected.png:
  • platform/chromium-linux/fast/repaint/inline-block-overflow-expected.png:
  • platform/chromium-linux/fast/repaint/inline-outline-repaint-expected.png:
  • platform/chromium-linux/fast/repaint/layer-outline-expected.png:
  • platform/chromium-linux/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/line-overflow-expected.png:
  • platform/chromium-linux/fast/repaint/outline-child-repaint-expected.png:
  • platform/chromium-linux/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/chromium-linux/fast/repaint/outline-shrinking-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-delete-line-expected.png:
  • platform/chromium-linux/fast/repaint/static-to-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/chromium-linux/fast/replaced/005-expected.png:
  • platform/chromium-linux/fast/replaced/007-expected.png:
  • platform/chromium-linux/fast/replaced/inline-box-wrapper-handover-expected.png:
  • platform/chromium-linux/fast/selectors/032-expected.png:
  • platform/chromium-linux/fast/selectors/077-expected.png:
  • platform/chromium-linux/fast/selectors/077b-expected.png:
  • platform/chromium-linux/fast/selectors/078b-expected.png:
  • platform/chromium-linux/fast/table/003-expected.png:
  • platform/chromium-linux/fast/table/004-expected.png:
  • platform/chromium-linux/fast/table/006-expected.png:
  • platform/chromium-linux/fast/table/007-expected.png:
  • platform/chromium-linux/fast/table/009-expected.png:
  • platform/chromium-linux/fast/table/017-expected.png:
  • platform/chromium-linux/fast/table/018-expected.png:
  • platform/chromium-linux/fast/table/020-expected.png:
  • platform/chromium-linux/fast/table/029-expected.png:
  • platform/chromium-linux/fast/table/030-expected.png:
  • platform/chromium-linux/fast/table/035-expected.png:
  • platform/chromium-linux/fast/table/035-vertical-expected.png:
  • platform/chromium-linux/fast/table/038-expected.png:
  • platform/chromium-linux/fast/table/038-vertical-expected.png:
  • platform/chromium-linux/fast/table/039-expected.png:
  • platform/chromium-linux/fast/table/040-expected.png:
  • platform/chromium-linux/fast/table/040-vertical-expected.png:
  • platform/chromium-linux/fast/table/041-expected.png:
  • platform/chromium-linux/fast/table/add-before-anonymous-child-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-win/fast/forms/button-style-color-expected.png:
  • platform/chromium-win/fast/forms/caret-rtl-expected.png:
  • platform/chromium-win/fast/forms/fieldset-align-expected.png:
  • platform/chromium-win/fast/forms/fieldset-with-float-expected.png:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-win/fast/forms/image-border-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-win/fast/forms/radio_checked_dynamic-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/select-baseline-expected.png:
  • platform/chromium-win/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/chromium-win/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-win/fast/forms/text-style-color-expected.png:
  • platform/chromium-win/fast/frames/content-opacity-1-expected.png:
  • platform/chromium-win/fast/frames/content-opacity-2-expected.png:
  • platform/chromium-win/fast/frames/frameElement-iframe-expected.png:
  • platform/chromium-win/fast/frames/iframe-option-crash-expected.png:
  • platform/chromium-win/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-win/fast/frames/iframe-text-contents-expected.png:
  • platform/chromium-win/fast/frames/iframe-with-frameborder-expected.png:
  • platform/chromium-win/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-win/fast/frames/viewsource-on-image-file-expected.png:
  • platform/chromium-win/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-win/fast/inline/inline-continuation-borders-expected.png:
  • platform/chromium-win/fast/inline/outline-continuations-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.png:
  • platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.png:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.png:
  • platform/chromium-win/fast/lists/004-expected.png:
  • platform/chromium-win/fast/lists/markers-in-selection-expected.png:
  • platform/chromium-win/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-win/fast/lists/olstart-expected.png:
  • platform/chromium-win/fast/media/viewport-media-query-expected.png:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-win/fast/overflow/002-expected.png:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-inline-scrollbar-expected.png:
  • platform/chromium-win/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-win/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/chromium-win/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-win/fast/repaint/containing-block-position-change-expected.png:
  • platform/chromium-win/fast/repaint/delete-into-nested-block-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/flexible-box-overflow-expected.png:
  • platform/chromium-win/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/float-move-during-layout-expected.png:
  • platform/chromium-win/fast/repaint/inline-block-overflow-expected.png:
  • platform/chromium-win/fast/repaint/inline-outline-repaint-expected.png:
  • platform/chromium-win/fast/repaint/layer-outline-expected.png:
  • platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/line-overflow-expected.png:
  • platform/chromium-win/fast/repaint/outline-child-repaint-expected.png:
  • platform/chromium-win/fast/repaint/outline-inset-expected.png:
  • platform/chromium-win/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/chromium-win/fast/repaint/outline-shrinking-expected.png:
  • platform/chromium-win/fast/repaint/overflow-delete-line-expected.png:
  • platform/chromium-win/fast/repaint/static-to-positioned-expected.png:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-win/fast/repaint/text-shadow-expected.png:
  • platform/chromium-win/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/chromium-win/fast/replaced/005-expected.png:
  • platform/chromium-win/fast/replaced/007-expected.png:
  • platform/chromium-win/fast/replaced/inline-box-wrapper-handover-expected.png:
  • platform/chromium-win/fast/selectors/032-expected.png:
  • platform/chromium-win/fast/selectors/077-expected.png:
  • platform/chromium-win/fast/selectors/077b-expected.png:
  • platform/chromium-win/fast/selectors/078b-expected.png:
  • platform/chromium-win/fast/table/003-expected.png:
  • platform/chromium-win/fast/table/004-expected.png:
  • platform/chromium-win/fast/table/006-expected.png:
  • platform/chromium-win/fast/table/007-expected.png:
  • platform/chromium-win/fast/table/009-expected.png:
  • platform/chromium-win/fast/table/017-expected.png:
  • platform/chromium-win/fast/table/018-expected.png:
  • platform/chromium-win/fast/table/020-expected.png:
  • platform/chromium-win/fast/table/029-expected.png:
  • platform/chromium-win/fast/table/030-expected.png:
  • platform/chromium-win/fast/table/035-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/038-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/039-expected.png:
  • platform/chromium-win/fast/table/040-expected.png:
  • platform/chromium-win/fast/table/040-vertical-expected.png:
  • platform/chromium-win/fast/table/041-expected.png:
  • platform/chromium-win/fast/table/add-before-anonymous-child-expected.png:
  • platform/chromium/test_expectations.txt:
20:55 Changeset [90714] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; Skip plugins/form-value.html.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-10

  • platform/chromium/test_expectations.txt:
20:37 Changeset [90713] by jamesr@google.com
  • 182 edits in trunk/LayoutTests

[chromium] Update win/linux pixel expectations for r90701 (part 3/??).

  • platform/chromium-linux/editing/selection/7152-1-expected.png:
  • platform/chromium-linux/editing/selection/7152-2-expected.png:
  • platform/chromium-linux/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-linux/editing/selection/iframe-expected.png:
  • platform/chromium-linux/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-linux/editing/selection/inline-table-expected.png:
  • platform/chromium-linux/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-linux/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-linux/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-linux/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-linux/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-linux/editing/style/5017613-1-expected.png:
  • platform/chromium-linux/editing/style/5017613-2-expected.png:
  • platform/chromium-linux/editing/undo/4063751-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/block/basic/013-expected.png:
  • platform/chromium-linux/fast/block/basic/018-expected.png:
  • platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-linux/fast/block/basic/text-indent-rtl-expected.png:
  • platform/chromium-linux/fast/block/float/015-expected.png:
  • platform/chromium-linux/fast/block/float/016-expected.png:
  • platform/chromium-linux/fast/block/float/025-expected.png:
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/027-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-linux/fast/block/float/032-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/chromium-linux/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-linux/fast/block/float/table-relayout-expected.png:
  • platform/chromium-linux/fast/block/float/width-update-after-clear-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-linux/fast/block/positioning/height-change-expected.png:
  • platform/chromium-linux/fast/block/positioning/leftmargin-topmargin-expected.png:
  • platform/chromium-linux/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/chromium-linux/fast/block/positioning/window-height-change-expected.png:
  • platform/chromium-linux/fast/blockflow/fieldsets-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-linux/fast/css-generated-content/014-expected.png:
  • platform/chromium-linux/fast/css-generated-content/016-expected.png:
  • platform/chromium-linux/fast/css-generated-content/hover-style-change-expected.png:
  • platform/chromium-linux/fast/css/MarqueeLayoutTest-expected.png:
  • platform/chromium-linux/fast/css/apple-prefix-expected.png:
  • platform/chromium-linux/fast/css/border-radius-outline-offset-expected.png:
  • platform/chromium-linux/fast/css/fieldset-display-row-expected.png:
  • platform/chromium-linux/fast/css/find-next-layer-expected.png:
  • platform/chromium-linux/fast/css/first-letter-detach-expected.png:
  • platform/chromium-linux/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-linux/fast/css/hover-subselector-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/list-outline-expected.png:
  • platform/chromium-linux/fast/css/outline-auto-location-expected.png:
  • platform/chromium-linux/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.png:
  • platform/chromium-linux/fast/css/universal-hover-quirk-expected.png:
  • platform/chromium-linux/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-linux/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
  • platform/chromium-linux/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-linux/fast/dom/css-inline-style-important-expected.png:
  • platform/chromium-linux/fast/dom/isindex-001-expected.png:
  • platform/chromium-linux/fast/dom/isindex-002-expected.png:
  • platform/chromium-linux/fast/dom/row-inner-text-expected.png:
  • platform/chromium-linux/fast/dynamic/012-expected.png:
  • platform/chromium-linux/fast/dynamic/013-expected.png:
  • platform/chromium-linux/fast/dynamic/015-expected.png:
  • platform/chromium-linux/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/forms/006-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/editing/selection/7152-1-expected.png:
  • platform/chromium-win/editing/selection/7152-2-expected.png:
  • platform/chromium-win/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-win/editing/selection/iframe-expected.png:
  • platform/chromium-win/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-win/editing/selection/inline-table-expected.png:
  • platform/chromium-win/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-win/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-win/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-win/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-win/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-win/editing/style/5017613-1-expected.png:
  • platform/chromium-win/editing/style/5017613-2-expected.png:
  • platform/chromium-win/editing/undo/4063751-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/basic/013-expected.png:
  • platform/chromium-win/fast/block/basic/018-expected.png:
  • platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-win/fast/block/basic/quirk-percent-height-table-cell-expected.png:
  • platform/chromium-win/fast/block/basic/text-indent-rtl-expected.png:
  • platform/chromium-win/fast/block/float/015-expected.png:
  • platform/chromium-win/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/block/float/025-expected.png:
  • platform/chromium-win/fast/block/float/026-expected.png:
  • platform/chromium-win/fast/block/float/027-expected.png:
  • platform/chromium-win/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/block/float/032-expected.png:
  • platform/chromium-win/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-win/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/chromium-win/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-win/fast/block/float/table-relayout-expected.png:
  • platform/chromium-win/fast/block/float/width-update-after-clear-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-win/fast/block/positioning/height-change-expected.png:
  • platform/chromium-win/fast/block/positioning/leftmargin-topmargin-expected.png:
  • platform/chromium-win/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/chromium-win/fast/block/positioning/window-height-change-expected.png:
  • platform/chromium-win/fast/blockflow/fieldsets-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-win/fast/css-generated-content/014-expected.png:
  • platform/chromium-win/fast/css-generated-content/016-expected.png:
  • platform/chromium-win/fast/css-generated-content/hover-style-change-expected.png:
  • platform/chromium-win/fast/css/MarqueeLayoutTest-expected.png:
  • platform/chromium-win/fast/css/apple-prefix-expected.png:
  • platform/chromium-win/fast/css/border-radius-outline-offset-expected.png:
  • platform/chromium-win/fast/css/fieldset-display-row-expected.png:
  • platform/chromium-win/fast/css/find-next-layer-expected.png:
  • platform/chromium-win/fast/css/first-letter-detach-expected.png:
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-win/fast/css/hover-subselector-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/list-outline-expected.png:
  • platform/chromium-win/fast/css/outline-auto-location-expected.png:
  • platform/chromium-win/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-win/fast/css/rtl-ordering-expected.png:
  • platform/chromium-win/fast/css/universal-hover-quirk-expected.png:
  • platform/chromium-win/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
  • platform/chromium-win/fast/dom/attr_dead_doc-expected.png:
  • platform/chromium-win/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-win/fast/dom/css-inline-style-important-expected.png:
  • platform/chromium-win/fast/dom/isindex-001-expected.png:
  • platform/chromium-win/fast/dom/isindex-002-expected.png:
  • platform/chromium-win/fast/dom/row-inner-text-expected.png:
  • platform/chromium-win/fast/dynamic/012-expected.png:
  • platform/chromium-win/fast/dynamic/013-expected.png:
  • platform/chromium-win/fast/dynamic/015-expected.png:
  • platform/chromium-win/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/forms/006-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium/test_expectations.txt:
20:25 Changeset [90712] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix test_expectations.txt

  • platform/chromium/test_expectations.txt:
20:14 Changeset [90711] by jamesr@google.com
  • 192 edits in trunk/LayoutTests

[chromium] Update win/linux pixel baselines for r90701 (part 2/??)

  • platform/chromium-linux/css1/box_properties/padding_left_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_top-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_top_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/width-expected.png:
  • platform/chromium-linux/css1/cascade/cascade_order-expected.png:
  • platform/chromium-linux/css1/cascade/important-expected.png:
  • platform/chromium-linux/css1/classification/display-expected.png:
  • platform/chromium-linux/css1/classification/list_style-expected.png:
  • platform/chromium-linux/css1/classification/list_style_image-expected.png:
  • platform/chromium-linux/css1/classification/list_style_position-expected.png:
  • platform/chromium-linux/css1/classification/list_style_type-expected.png:
  • platform/chromium-linux/css1/classification/white_space-expected.png:
  • platform/chromium-linux/css1/color_and_background/background-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_color-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_image-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_position-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-linux/css1/color_and_background/color-expected.png:
  • platform/chromium-linux/css1/font_properties/font-expected.png:
  • platform/chromium-linux/css1/font_properties/font_family-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/css1/font_properties/font_style-expected.png:
  • platform/chromium-linux/css1/font_properties/font_variant-expected.png:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.png:
  • platform/chromium-linux/css1/formatting_model/canvas-expected.png:
  • platform/chromium-linux/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-linux/css1/pseudo/anchor-expected.png:
  • platform/chromium-linux/css1/pseudo/firstletter-expected.png:
  • platform/chromium-linux/css1/pseudo/firstline-expected.png:
  • platform/chromium-linux/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-linux/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/chromium-linux/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-linux/css1/text_properties/line_height-expected.png:
  • platform/chromium-linux/css1/text_properties/text_align-expected.png:
  • platform/chromium-linux/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-linux/css1/text_properties/text_indent-expected.png:
  • platform/chromium-linux/css1/text_properties/text_transform-expected.png:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-linux/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-linux/css1/units/color_units-expected.png:
  • platform/chromium-linux/css1/units/length_units-expected.png:
  • platform/chromium-linux/css1/units/percentage_units-expected.png:
  • platform/chromium-linux/css1/units/urls-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5516-brdr-c-00-a-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5522-brdr-00-b-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5522-ibrdr-00-a-expected.png:
  • platform/chromium-linux/css3/css3-modsel-33-expected.png:
  • platform/chromium-linux/editing/deleting/5099303-expected.png:
  • platform/chromium-linux/editing/deleting/5126166-expected.png:
  • platform/chromium-linux/editing/deleting/5206311-1-expected.png:
  • platform/chromium-linux/editing/deleting/5433862-2-expected.png:
  • platform/chromium-linux/editing/deleting/5483370-expected.png:
  • platform/chromium-linux/editing/deleting/table-cells-expected.png:
  • platform/chromium-linux/editing/execCommand/5481523-expected.png:
  • platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-linux/editing/execCommand/paste-1-expected.png:
  • platform/chromium-linux/editing/execCommand/paste-2-expected.png:
  • platform/chromium-linux/editing/inserting/4278698-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/4076267-expected.png:
  • platform/chromium-linux/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.png:
  • platform/chromium-linux/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-linux/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-linux/editing/selection/4402375-expected.png:
  • platform/chromium-linux/editing/selection/4776665-expected.png:
  • platform/chromium-linux/editing/selection/4818145-expected.png:
  • platform/chromium-linux/editing/selection/4889598-expected.png:
  • platform/chromium-linux/editing/selection/4895428-2-expected.png:
  • platform/chromium-linux/editing/selection/4960137-expected.png:
  • platform/chromium-linux/editing/selection/4975120-expected.png:
  • platform/chromium-linux/editing/selection/5057506-2-expected.png:
  • platform/chromium-linux/editing/selection/5057506-expected.png:
  • platform/chromium-linux/editing/selection/6476-expected.png:
  • platform/chromium-win/css1/box_properties/padding_left_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_top-expected.png:
  • platform/chromium-win/css1/box_properties/padding_top_inline-expected.png:
  • platform/chromium-win/css1/box_properties/width-expected.png:
  • platform/chromium-win/css1/cascade/cascade_order-expected.png:
  • platform/chromium-win/css1/cascade/important-expected.png:
  • platform/chromium-win/css1/classification/display-expected.png:
  • platform/chromium-win/css1/classification/list_style-expected.png:
  • platform/chromium-win/css1/classification/list_style_image-expected.png:
  • platform/chromium-win/css1/classification/list_style_position-expected.png:
  • platform/chromium-win/css1/classification/list_style_type-expected.png:
  • platform/chromium-win/css1/classification/white_space-expected.png:
  • platform/chromium-win/css1/color_and_background/background-expected.png:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-win/css1/color_and_background/background_color-expected.png:
  • platform/chromium-win/css1/color_and_background/background_image-expected.png:
  • platform/chromium-win/css1/color_and_background/background_position-expected.png:
  • platform/chromium-win/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-win/css1/color_and_background/color-expected.png:
  • platform/chromium-win/css1/font_properties/font-expected.png:
  • platform/chromium-win/css1/font_properties/font_family-expected.png:
  • platform/chromium-win/css1/font_properties/font_size-expected.png:
  • platform/chromium-win/css1/font_properties/font_style-expected.png:
  • platform/chromium-win/css1/font_properties/font_variant-expected.png:
  • platform/chromium-win/css1/font_properties/font_weight-expected.png:
  • platform/chromium-win/css1/formatting_model/canvas-expected.png:
  • platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-win/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-win/css1/pseudo/anchor-expected.png:
  • platform/chromium-win/css1/pseudo/firstletter-expected.png:
  • platform/chromium-win/css1/pseudo/firstline-expected.png:
  • platform/chromium-win/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-win/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/chromium-win/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-win/css1/text_properties/line_height-expected.png:
  • platform/chromium-win/css1/text_properties/text_align-expected.png:
  • platform/chromium-win/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-win/css1/text_properties/text_indent-expected.png:
  • platform/chromium-win/css1/text_properties/text_transform-expected.png:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-win/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-win/css1/units/color_units-expected.png:
  • platform/chromium-win/css1/units/length_units-expected.png:
  • platform/chromium-win/css1/units/percentage_units-expected.png:
  • platform/chromium-win/css1/units/urls-expected.png:
  • platform/chromium-win/css2.1/t0805-c5516-brdr-c-00-a-expected.png:
  • platform/chromium-win/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png:
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/css2.1/t0805-c5522-brdr-00-b-expected.png:
  • platform/chromium-win/css2.1/t0805-c5522-ibrdr-00-a-expected.png:
  • platform/chromium-win/css3/css3-modsel-33-expected.png:
  • platform/chromium-win/editing/deleting/5099303-expected.png:
  • platform/chromium-win/editing/deleting/5126166-expected.png:
  • platform/chromium-win/editing/deleting/5206311-1-expected.png:
  • platform/chromium-win/editing/deleting/5433862-2-expected.png:
  • platform/chromium-win/editing/deleting/5483370-expected.png:
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/editing/execCommand/5481523-expected.png:
  • platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-win/editing/execCommand/paste-1-expected.png:
  • platform/chromium-win/editing/execCommand/paste-2-expected.png:
  • platform/chromium-win/editing/inserting/4278698-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-win/editing/pasteboard/4076267-expected.png:
  • platform/chromium-win/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-win/editing/pasteboard/5387578-expected.png:
  • platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.png:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-win/editing/selection/4402375-expected.png:
  • platform/chromium-win/editing/selection/4776665-expected.png:
  • platform/chromium-win/editing/selection/4818145-expected.png:
  • platform/chromium-win/editing/selection/4889598-expected.png:
  • platform/chromium-win/editing/selection/4895428-2-expected.png:
  • platform/chromium-win/editing/selection/4960137-expected.png:
  • platform/chromium-win/editing/selection/4975120-expected.png:
  • platform/chromium-win/editing/selection/5057506-2-expected.png:
  • platform/chromium-win/editing/selection/5057506-expected.png:
  • platform/chromium-win/editing/selection/6476-expected.png:
  • platform/chromium/test_expectations.txt:
20:02 Changeset [90710] by jamesr@google.com
  • 104 edits in trunk/LayoutTests

[chromium] Add win/linux pixel baselines for r90701 (part 1/20)

  • platform/chromium-linux/css1/basic/class_as_selector-expected.png:
  • platform/chromium-linux/css1/basic/comments-expected.png:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-linux/css1/basic/grouping-expected.png:
  • platform/chromium-linux/css1/basic/id_as_selector-expected.png:
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/css1/box_properties/border-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_color-expected.png:
  • platform/chromium-linux/css1/box_properties/border_color_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_width_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_width_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_width_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_width_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/clear-expected.png:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_margin-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/box_properties/height-expected.png:
  • platform/chromium-linux/css1/box_properties/margin-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_left-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_left_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_right_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_top-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_top_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_left-expected.png:
  • platform/chromium-win/css1/basic/class_as_selector-expected.png:
  • platform/chromium-win/css1/basic/comments-expected.png:
  • platform/chromium-win/css1/basic/containment-expected.png:
  • platform/chromium-win/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-win/css1/basic/grouping-expected.png:
  • platform/chromium-win/css1/basic/id_as_selector-expected.png:
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/css1/box_properties/border-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_color-expected.png:
  • platform/chromium-win/css1/box_properties/border_color_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_left-expected.png:
  • platform/chromium-win/css1/box_properties/border_left_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_left_width_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_right-expected.png:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_right_width_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_top-expected.png:
  • platform/chromium-win/css1/box_properties/border_top_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_top_width_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_width_inline-expected.png:
  • platform/chromium-win/css1/box_properties/clear-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_margin-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/height-expected.png:
  • platform/chromium-win/css1/box_properties/margin-expected.png:
  • platform/chromium-win/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-win/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_left-expected.png:
  • platform/chromium-win/css1/box_properties/margin_left_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_top-expected.png:
  • platform/chromium-win/css1/box_properties/margin_top_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding-expected.png:
  • platform/chromium-win/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-win/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_left-expected.png:
  • platform/chromium/test_expectations.txt:
19:55 Changeset [90709] by paroga@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove array size from generated JSC binding tables
https://bugs.webkit.org/show_bug.cgi?id=64229

Reviewed by Brent Fulgham.

Because many items in the array are surrounded with #if(ENABLE_XXX) lines,
the array size isn't fix and correct in all cases.
So let the compiler calculate the correct size itself.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
19:51 Changeset [90708] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Windows expectation updates for r90701

  • platform/chromium/test_expectations.txt:
19:28 Changeset [90707] by bashi@chromium.org
  • 22 edits
    3 adds in trunk

Let plugins participate in form submission
https://bugs.webkit.org/show_bug.cgi?id=13061

Source/WebCore:

Implements HTMLObjectElement::appendFormData() so that object
elements respond as form associated elements.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-10
Reviewed by Anders Carlsson.

Test: plugins/form-value.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData): Implemented.

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::getFormValue): Added.

Source/WebKit/mac:

Adds methods to get form value from NPAPI plugins.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-10
Reviewed by Anders Carlsson.

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView getFormValue:]): Added.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView getFormValue:]): Added.

  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage browserFuncs]): Added.

  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getFormValue:]): Added.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(NetscapePluginWidget::getFormValue): Added.

Tools:

Adds NPPVformValue support to the testing plugin.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-10
Reviewed by Anders Carlsson.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added FormValue.cpp
  • DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp: Added.

(FormValue::FormValue): Ditto.
(FormValue::NPP_GetValue): Ditto.

LayoutTests:

Adds a test that checks getting form value from plugins.
This test will pass only mac Leopard for now.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-10
Reviewed by Anders Carlsson.

  • platform/chromium/test_expectations.txt: Added an entry for plugins/form-value.html.
  • platform/gtk/Skipped: Ditto.
  • platform/mac-snowleopard/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
  • plugins/form-value-expected.txt: Added.
  • plugins/form-value.html: Added.
19:19 Changeset [90706] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More expectation fixes.

  • platform/chromium/test_expectations.txt:
19:08 Changeset [90705] by andersca@apple.com
  • 4 edits in trunk/Source

WebKit2 is leaking NSCursors created by leakNamedCursor
https://bugs.webkit.org/show_bug.cgi?id=64241
<rdar://problem/9507151>

Reviewed by Oliver Hunt.

../WebCore:

  • platform/mac/CursorMac.mm:

(WebCore::createNamedCursor):
Rename this from leakNamedCursor to createNamedCursor and make it return a
RetainPtr<NSCursor> instead of a raw pointer.

(WebCore::Cursor::ensurePlatformCursor):
Don't leak cursors here. We still won't deallocate cursors during shutdown (which leakNamedCursor
was said to prevent) because the cursor singletons are all allocated from the heap and are never destroyed
anyway.

../WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::decode):
When decoding a cursor of a known type, make sure to eagerly create the platform cursor
for the cursor singleton. This way we avoid re-creating new NSCursor objects over and over for
standard cursors.

19:04 Changeset [90704] by yutak@chromium.org
  • 5 edits in trunk/Source/WebCore

WebSocket: Add useHixie76Protocol flag to WebSocketChannel and WebSocketHandshake
https://bugs.webkit.org/show_bug.cgi?id=64244

Reviewed by Kent Tamura.

Get the value of Settings::useHixie76WebSocketProtocol() and save it in
WebSocketChannel and WebSocketHandshake instances. Obtained flag value
is not used for now.

No behavior change, thus no new tests.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
WebSocketChannel is always created in context of Document (see
ThreadableWebSocketChannel::create()).
Because m_useHixie76Protocol must be passed to WebSocketHandshake
constructor, WebSocketHandshake instance is allocated dynamically
and stored in OwnPtr.
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpen):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::processBuffer):

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::WebSocketHandshake):

  • websockets/WebSocketHandshake.h:
19:03 Changeset [90703] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Add more test expectations for r90701

  • platform/chromium/test_expectations.txt:
18:59 Changeset [90702] by rolandsteiner@chromium.org
  • 4 edits in trunk/Tools

Reviewed by Tony Chang.

Complete functions in filesystem.py
https://bugs.webkit.org/show_bug.cgi?id=63528

  • missing text file functions added
  • functions sorted
  • removed 'append' optional parameters (were unused)
  • adapted filesystem_mock in the same way
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
18:47 Changeset [90701] by jamesr@google.com
  • 4 edits in trunk

Patch by Tom Hudson <tomhudson@google.com> on 2011-07-10
Reviewed by James Robinson.

GraphicsContextSkia::drawConvexPolygon doesn't pay attention to shouldAntialias
https://bugs.webkit.org/show_bug.cgi?id=61369

Source/WebCore:

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawConvexPolygon): Pass the
shouldAntialias parameter on to Skia.

LayoutTests:

  • platform/chromium/test_expectations.txt: Temporarily add roughly

1100 images that were incorrectly being antialiased; will remove
once they've been rebaselined off of the bots.

18:38 Changeset [90700] by yuzo@google.com
  • 2 edits in trunk/Source/WebCore

Fix for Bug 63968 - Add comment to explain Vector usage in FontCache::purgeInactiveFontData
https://bugs.webkit.org/show_bug.cgi?id=63968

Reviewed by Dan Bernstein.

No new tests because this changes comments only.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData): Add explanation why SimpleFontData is not deleted in the iteration loop.

12:33 Changeset [90699] by abarth@webkit.org
  • 1 edit
    805 deletes in trunk/LayoutTests

Optmize LayoutTest resutls by removing redundant results.

Rubber-stamped by Eric Seidel.

  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/borders/border-radius-constraints-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-radius-huge-assert-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusInvalidColor-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid04-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/inset-box-shadows-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-linux-x86/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/last-of-type-pseudo-class-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Removed.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-child-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-child-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-nested-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-nested-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-remove-child-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-remove-child-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-1-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-2-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Removed.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Removed.
  • platform/chromium-linux-x86/fast/overflow/border-radius-clipping-expected.png: Removed.
  • platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png: Removed.
  • platform/chromium-linux-x86/fast/replaced/outline-replaced-elements-expected.png: Removed.
  • platform/chromium-linux-x86/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/chromium-linux-x86/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Removed.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/chromium-linux-x86/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/as-object/object-box-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/dasharrayOrigin-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/fractional-rects-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/gradient-rotated-bbox-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-hex-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/invalid-stroke-hex-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/invalid-uri-stroke-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/rounded-rects-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/svg-fonts-in-html-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feDropShadow-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.txt: Removed.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.txt: Removed.
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Removed.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/select-background-none-expected.txt: Removed.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Removed.
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/005-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/006-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/009-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-rules-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Removed.
  • platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Removed.
  • platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-and-parts-outline-expected.txt: Removed.
  • platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/chromium-linux/fast/text/justify-padding-distribution-expected.png: Removed.
  • platform/chromium-linux/fast/text/softHyphen-expected.txt: Removed.
  • platform/chromium-linux/fast/text/word-break-soft-hyphen-expected.txt: Removed.
  • platform/chromium-linux/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/manifest-redirect-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/resource-redirect-2-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/resource-redirect-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/wrong-signature-2-expected.txt: Removed.
  • platform/chromium-linux/http/tests/appcache/wrong-signature-expected.txt: Removed.
  • platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt: Removed.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/chromium-linux/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
  • platform/chromium-linux/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Removed.
  • platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textDecoration2-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPCDATA-expected.txt: Removed.
  • platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.png: Removed.
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/embedding-external-svgs-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Removed.
  • platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
  • platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/chromium-linux/svg/in-html/by-reference-expected.txt: Removed.
  • platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Removed.
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.txt: Removed.
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
  • platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/css/focus-ring-detached-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/css/focus-ring-multiline-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/circular-marker-reference-2-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-viewTarget-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-zoomAndPan-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/non-circular-marker-reference-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/text-rotated-gradient-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-detach-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-detach-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/hixie/links/001-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/text/small-fonts-2-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Removed.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.txt: Removed.
  • platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
  • platform/chromium-mac/fast/borders/table-borders-expected.txt: Removed.
  • platform/chromium-mac/fast/css/background-clip-values-expected.png: Removed.
  • platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/getElementsByClassName/011-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-number-unacceptable-style-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/select-background-none-expected.txt: Removed.
  • platform/chromium-mac/fast/invalid/missing-end-tag-expected.txt: Removed.
  • platform/chromium-mac/fast/js/console-non-string-values-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-toExponential-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-toprecision-expected.txt: Removed.
  • platform/chromium-mac/fast/lists/003-vertical-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/chromium-mac/fast/parser/external-entities-expected.txt: Removed.
  • platform/chromium-mac/fast/parser/xhtml-alternate-entities-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/text/find-kana-expected.txt: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png: Removed.
  • platform/chromium-mac/fast/url/path-url-expected.txt: Removed.
  • platform/chromium-mac/fast/url/scheme-expected.txt: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Removed.
  • platform/chromium-mac/fast/xsl/mozilla-tests-expected.txt: Removed.
  • platform/chromium-mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Removed.
  • platform/chromium-mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Removed.
  • platform/chromium-mac/svg/custom/gradient-stroke-width-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/use-invalid-style-expected.txt: Removed.
  • platform/chromium-mac/svg/text/bidi-embedded-direction-expected.png: Removed.
  • platform/chromium-mac/svg/text/bidi-embedded-direction-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Removed.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.txt: Removed.
  • platform/chromium-win-vista/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Removed.
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Removed.
  • platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/chromium-win-vista/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/appcache/manifest-redirect-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/appcache/resource-redirect-2-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/appcache/resource-redirect-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/appcache/wrong-signature-2-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/appcache/wrong-signature-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/chromium-win-vista/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Removed.
  • platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
  • platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Removed.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/circular-marker-reference-2-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/non-circular-marker-reference-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
  • platform/chromium-win-xp/svg/hixie/links/001-expected.txt: Removed.
  • platform/chromium-win/fast/css/css3-nth-tokens-script-expected.txt: Removed.
  • platform/chromium-win/fast/css/css3-nth-tokens-style-expected.txt: Removed.
  • platform/chromium-win/fast/dom/getElementsByClassName/011-expected.txt: Removed.
  • platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • platform/chromium-win/fast/js/console-non-string-values-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-prototype-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/exception_propagation-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-toExponential-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-toprecision-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/text/justification-padding-mid-word-expected.txt: Removed.
  • platform/chromium-win/fast/url/path-url-expected.txt: Removed.
  • platform/chromium-win/fast/url/scheme-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Removed.
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.txt: Removed.
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt: Removed.
  • platform/chromium-win/svg/dom/length-list-parser-expected.txt: Removed.
  • platform/chromium-win/svg/dom/path-parser-expected.txt: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/page-zoom-expected.txt: Removed.
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt: Removed.
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
  • platform/gtk/fast/forms/onselect-textarea-expected.txt: Removed.
  • platform/gtk/fast/table/simple_paint-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
  • platform/gtk/svg/custom/text-zoom-expected.txt: Removed.
  • platform/mac-leopard/accessibility/table-with-aria-role-expected.txt: Removed.
  • platform/mac-leopard/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
  • platform/mac-leopard/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
  • platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Removed.
  • platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Removed.
  • platform/mac-leopard/media/controls-strict-mode-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Removed.
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/mac-leopard/svg/carto.net/button-expected.txt: Removed.
  • platform/mac-leopard/svg/carto.net/combobox-expected.txt: Removed.
  • platform/mac-leopard/svg/carto.net/textbox-expected.txt: Removed.
  • platform/mac-leopard/svg/carto.net/window-expected.txt: Removed.
  • platform/mac-leopard/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/mac-leopard/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/mac-leopard/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/mac-leopard/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/circular-marker-reference-2-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/js-late-clipPath-creation-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/marker-default-width-height-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/non-circular-marker-reference-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/path-textPath-simulation-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/stroke-width-large-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/stroked-pattern-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/text-rotated-gradient-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/tref-update-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/use-detach-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/viewBox-hit-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/error/017-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/links/001-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/mixed/004-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/mixed/005-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/mac-leopard/svg/text/font-size-below-point-five-2-expected.txt: Removed.
  • platform/mac-leopard/svg/text/scaled-font-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacing-stretch-4-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/mac-leopard/svg/text/select-x-list-3-expected.txt: Removed.
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt: Removed.
  • platform/mac-leopard/svg/text/small-fonts-3-expected.txt: Removed.
  • platform/mac-leopard/svg/text/small-fonts-expected.txt: Removed.
  • platform/mac-leopard/svg/text/small-fonts-in-html5-expected.txt: Removed.
  • platform/mac-leopard/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • platform/mac-wk2/media/controls-without-preload-expected.txt: Removed.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Removed.
  • platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/win-wk2/fast/css/pseudo-any-expected.txt: Removed.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
  • platform/win-wk2/http/tests/uri/username-with-no-hostname-expected.txt: Removed.
  • platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Removed.
  • platform/win-wk2/plugins/resize-from-plugin-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Removed.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/win/editing/inserting/4960120-1-expected.txt: Removed.
  • platform/win/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Removed.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Removed.
  • platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
  • platform/win/fast/css/opacity-float-expected.txt: Removed.
  • platform/win/fast/css/resize-corner-tracking-expected.txt: Removed.
  • platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
  • platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Removed.
  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/win/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/win/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt: Removed.
  • platform/win/fast/forms/textAreaLineHeight-expected.txt: Removed.
  • platform/win/fast/forms/textarea-metrics-expected.txt: Removed.
  • platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
  • platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Removed.
  • platform/win/fast/forms/textarea-placeholder-set-value-expected.txt: Removed.
  • platform/win/fast/forms/textarea-scrollbar-expected.txt: Removed.
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt: Removed.
  • platform/win/fast/forms/textarea-setinnerhtml-expected.txt: Removed.
  • platform/win/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/win/fast/overflow/overflow-x-y-expected.txt: Removed.
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt: Removed.
  • platform/win/fast/text/atsui-negative-spacing-features-expected.txt: Removed.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Removed.
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Removed.
  • platform/win/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/win/svg/custom/broken-internal-references-expected.txt: Removed.
  • platform/win/svg/custom/junk-data-expected.txt: Removed.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt: Removed.
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/win/tables/mozilla/bugs/bug30559-expected.txt: Removed.
12:20 Changeset [90698] by eae@chromium.org
  • 15 edits in trunk/Source/WebCore

Switch updateHitTestResult to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64209

Reviewed by Eric Seidel.

No new tests, no functionality changes.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::updateHitTestResult):

  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateHitTestResult):

  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::updateHitTestResult):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::nodeAtFloatPoint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::nodeAtFloatPoint):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::nodeAtFloatPoint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

11:55 Changeset [90697] by abarth@webkit.org
  • 5 edits in trunk/Tools

Clean up style in fallback path calculation
https://bugs.webkit.org/show_bug.cgi?id=64239

Reviewed by Daniel Bates.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
11:39 Changeset [90696] by abarth@webkit.org
  • 2 deletes in trunk/LayoutTests/platform

Actually remove the directories.

11:37 Changeset [90695] by abarth@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Remove LayoutTests/platform/android and LayoutTests/platform/android-v8
https://bugs.webkit.org/show_bug.cgi?id=64240

Reviewed by Sam Weinig.

These results directories are basically empty and haven't been touched
in almost a year. There are not maintained and are almost certantly
out of date.

  • platform/android: Removed.
  • platform/android-v8: Removed.
  • platform/android-v8/fast: Removed.
  • platform/android-v8/fast/dom: Removed.
  • platform/android-v8/fast/dom/DeviceMotion: Removed.
  • platform/android-v8/fast/dom/DeviceMotion/window-property-expected.txt: Removed.
  • platform/android-v8/fast/dom/DeviceOrientation: Removed.
  • platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
  • platform/android/fast: Removed.
  • platform/android/fast/text: Removed.
  • platform/android/fast/text/hyphenate-character-expected.txt: Removed.
  • platform/android/fast/text/hyphens-expected.txt: Removed.
11:33 Changeset [90694] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Move setResizesToContentsUsingLayoutSize() to the touch specific page proxy
https://bugs.webkit.org/show_bug.cgi?id=64238

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-10
Reviewed by Andreas Kling.

The method is specific to the touch view, so it should be in QTouchWebPageProxy instead
of QtWebPageProxy.

  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setResizesToContentsUsingLayoutSize):

  • UIProcess/qt/qtouchwebpageproxy.h:
11:04 Changeset [90693] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

[Qt][WK2] Implement the rest of WTR::PlatformWebView
https://bugs.webkit.org/show_bug.cgi?id=63630

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-07-10
Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

09:32 Changeset [90692] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Adam Barth.

Fix member variable order of ContextMenuItem
https://bugs.webkit.org/show_bug.cgi?id=59905

Use the same order at decleration and assignment to silence compiler warning.

  • platform/ContextMenuItem.h:
08:37 Changeset [90691] by mitz@apple.com
  • 6 edits
    2 adds in trunk

<rdar://problem/9750062> REGRESSION: Button text missing in many iTunes Store pages
https://bugs.webkit.org/show_bug.cgi?id=64236

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/css/empty-display-none.html

When an :empty selector caused an element to not have a renderer, the check for empty style
change when finishing parsing the elemenet did nothing, because it could not check if the
element’s current style was affected by :empty. The fix is to record the fact that the style
was affected by :empty in ElementRareData in the no-renderer case.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle): Clear the m_styleAffectedByEmpty flag.
(WebCore::checkForEmptyStyleChange): If the style is null (meaning there is no renderer), check
Element::styleAffectedByEmpty().
(WebCore::Element::setStyleAffectedByEmpty): Added. Sets the flag in rare data.
(WebCore::Element::styleAffectedByEmpty): Added. Checks for the flag in rare data.

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData): Added m_styleAffectedByEmpty and initialized it
to false.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererAndStyle): If an element doesn’t need a renderer
and its style is affected by :empty, record this fact in the element by calling setStyleAffectedByEmpty().

LayoutTests:

  • fast/css/empty-display-none-expected.txt: Added.
  • fast/css/empty-display-none.html: Added.
05:21 Changeset [90690] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • svg/properties/SVGAttributeToPropertyMap.h: Forward-declare SVGPropertyInfo as a struct

since that's what it is.

03:49 Changeset [90689] by mrowe@apple.com
  • 2 edits in trunk/Tools

Teach build-webkit how to find the latest WebKitSystemInterface binary.

  • Scripts/build-webkit:

07/09/11:

13:43 Changeset [90688] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix unaligned userspace access for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=62993

Patch by Thouraya Andolsi <thouraya.andolsi@st.com> on 2011-07-09

  • wtf/Platform.h:
13:06 Changeset [90687] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix MIPS build due to readInt32 and readPointer
https://bugs.webkit.org/show_bug.cgi?id=63962

Patch by Chao-ying Fu <fu@mips.com> on 2011-07-09

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::readInt32):
(JSC::MIPSAssembler::readPointer):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::rshift32):

12:47 Changeset [90686] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-09
Reviewed by Adam Roben.

[WebKit2] Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63251

No new tests. Covered by existing tests: plugins/mouse-events.html and
plugins/keyboard-events.html.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformSetFocus):

12:44 Changeset [90685] by kevino@webkit.org
  • 7 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

[wx] In load events, specify the wxWebFrame that sent them.

https://bugs.webkit.org/show_bug.cgi?id=64233

12:40 Changeset [90684] by paroga@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed WinCE build fix for r90680.

Repeat the change done in r90681 for all other SVGAnimated*PropertyTearOff.h files.

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Make create public and remove friendship with SVGAnimatedProperty.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.
  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.
12:29 Changeset [90683] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Make sure wxPrintData grabs the default print settings to calculate page width,
and readjusts settings after the print dialog is displayed.

https://bugs.webkit.org/show_bug.cgi?id=64232

12:05 Changeset [90682] by aroben@apple.com
  • 4 edits in trunk/Tools

Teach TestFailures to abbreviate the examples of test flakiness

These lists can get quite long, and it's not really helpful in most cases to have soooooo
many examples of flakiness.

Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
long they're hard to navigate

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
of examples, replace the middle items with a separator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.flakiness-example-separator): Added styles for the separator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
the separator.

07:35 Changeset [90681] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-09 Nikolas Zimmermann <nzimmermann@rim.com>

Add a possibility to retrieve the associated SVGAnimatedProperty object for a certain XML attribute
https://bugs.webkit.org/show_bug.cgi?id=63797

Fix WinCE build. Funny none other platform complained.

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Make create public, SVGAnimatedProperty needs it - remove friendship with it.
04:26 Changeset [90680] by zimmermann@webkit.org
  • 168 edits
    3 adds in trunk/Source/WebCore

2011-07-09 Nikolas Zimmermann <nzimmermann@rim.com>

Add a possibility to retrieve the associated SVGAnimatedProperty object for a certain XML attribute
https://bugs.webkit.org/show_bug.cgi?id=63797

Reviewed by Dirk Schulze.

In order to prepare animVal support we need a way to map a given SVG DOM attribute to a SVGAnimatedProperty.
eg. SVGNames::xAttr -> SVGRectElement::xAnimated(), etc. This will be needed to update the animVal of the
SVGAnimatedProperty, if an animation is running. It would required adding a new method to all SVG* classes
that define animated properties. Unfortunately we already have lots of repeated code in methods like
synchronizeProperty / fillAttributeToPropertyTypeMap. Look at SVGRectElement for example:

void SVGRectElement::synchronizeProperty(const QualifiedName& attrName)
{

if (attrName == anyQName()) {

synchronizeX();
synchronizeY();

...

}

if (attrName == SVGNames::xAttr) {

synchronizeX();
return;

}

if (attrName == SVGNames::yAttr) {

synchronizeY();
return;

}
...

}

or

void SVGRectElement::fillAttributeToPropertyTypeMap()
{

AttributeToPropertyTypeMap& attributeToPropertyTypeMap = this->attributeToPropertyTypeMap();


SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap(attributeToPropertyTypeMap);
attributeToPropertyTypeMap.set(SVGNames::xAttr, AnimatedLength);
attributeToPropertyTypeMap.set(SVGNames::yAttr, AnimatedLength);
...

}

These lookups are all performed dynamically. Each synchronizeProperty() call does a lot of comparisons.
fillAttributeToPropertyTypeMap() isn't that bad as the result is cached in a static HashMap per-SVGRectElement.
There's no reason to do these things dynamically!

Inspired by JSC, I'm adding a "static const SVGPropertyInfo s_fooPropertyInfo" object for each animated SVG property.
For example, for SVGRectElements SVGAnimatedLength x property we're storing:

  • "AnimatedPropertyType type" (AnimatedLength -- note the enum was named AnimatedAttributeType, I renamed it to AnimatedPropertyType for clarity)
  • "const QualifiedName& attributeName" (SVGNames::xAttr)
  • "const AtomicString& propertyIdentifier" (SVGNames::xAttr.localName() -- only different if N-wrappers map to a single XML DOM attribute, eg. orientAttr)
  • "SynchronizeProperty synchronizeProperty" (callback to SVGRectElement::synchronizeX)
  • "LookupOrCreateWrapperForAnimatedProperty lookupOrCreateWrapperForAnimatedProperty" (callback to SVGRectElement::xAnimated)

Using this information, we can replace all the various synchronizeProperty/fillAttributeToPropertyMap implementations, with a single one in SVGElement.
All these are auto-generated, using the standard macros used to define/declare SVG animated properties. This required several changes to the macros.
Here's a summary:


#1) In all headers, wrap DECLARE_ANIMATED_* calls, in BEGIN_DECLARE_ANIMATED_PROPERTIES(ClassName) / END_DECLARE_ANIMATED_PROPERTIES blocks.


Sample change for SVGRectElement:

  • DECLARE_ANIMATED_LENGTH(X, x)
  • DECLARE_ANIMATED_LENGTH(Y, y)
  • ...

+ BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGRectElement)
+ DECLARE_ANIMATED_LENGTH(X, x)
+ DECLARE_ANIMATED_LENGTH(Y, y)
+ ...
+ END_DECLARE_ANIMATED_PROPERTIES

#2) In all cpp files, add a new section wrapped in BEGIN_REGISTER_ANIMATED_PROPERTIES(ClassName / END_REGISTER_ANIMATED_PROPERTIES blocks:

Sample change for SVGRectElement:
+BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGRectElement)
+ REGISTER_LOCAL_ANIMATED_PROPERTY(x)
+ REGISTER_LOCAL_ANIMATED_PROPERTY(y)
+ ...
+ REGISTER_PARENT_ANIMATED_PROPERTIES(SVGStyledTransformableElement)
+ REGISTER_PARENT_ANIMATED_PROPERTIES(SVGTests)
+END_REGISTER_ANIMATED_PROPERTIES

This is the main piece of the logic that replaces the manual synchronizeProperty/fillAttributeToPropertyMap implementation. It expands to following:

SVGAttributeToPropertyMap& SVGRectElement::attributeToPropertyMap()
{

DEFINE_STATIC_LOCAL(SVGAttributeToPropertyMap, s_attributeToPropertyMap, ());

}

static void registerAnimatedPropertiesForSVGRectElement()
{

SVGAttributeToPropertyMap& map = SVGRectElement::attributeToPropertyMap();
if (!map.isEmpty())

return;

map.addProperty(SVGRectElement::xPropertyInfo());
map.addProperty(SVGRectElement::yPropertyInfo());
...
map.addProperties(SVGStyledTransformableElement::attributeToPropertyMap());
map.addProperties(SVGTests::attributeToPropertyMap());

}

A single-instance of SVGAttributeToPropertyMap is created for each SVG*Element. The constructor of SVGRectElement is supposed to call
registerAnimatedPropertiesForSVGRectElement(), which collects all properties of SVGRectElement and all its parent classes and stores them
in a Vector<const SVGPropertyInfo*>. This Vector is stored in a HashMap<QualifiedName, Vector<const SVGPropertyInfo*> > where the key
is the attribute name (eg. SVGNames::xAttr -> SVGRectElement::xPropertyInfo). This is only done _once_ per SVGRectElement.

SVGElement contains a "virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap()" method, and SVGRectElement overrides it
and returns SVGRectElement::attributeToPropertyMap() (which is static!) -- this is hidden again in the macros, no need to write any code.

SVGAttributeToPropertyMap provides following API:

  • bool synchronizeProperty(SVGElement* contextElement, const QualifiedName& attributeName)
  • void synchronizeProperties(SVGElement* contextElement)


A generic way to synchronize a SVGAnimatedProperty with its XML DOM attribute. Any SVG DOM change to eg. <rect>s x property will now trigger
contextElement->localAttributeToPropertyMap().synchronizeProperty(this, SVGNames::xAttr)
The SVGAttributeToPropertyMap will ask its HashMap for the Vector containing the properties for SVGNames::xAttr (in that case, just one xAnimated()).

  • void animatedPropertyTypeForAttribute(const QualifiedName& attributeName, Vector<AnimatedPropertyType>& propertyTypes)

This method replaces the fillAttributeToPropertyMap implementations everywhere.


  • void animatedPropertiesForAttribute(SVGElement* contextElement, const QualifiedName& attributeName, Vector<RefPtr<SVGAnimatedProperty> >& properties);

This method is not used yet, but allows us to collect all SVGAnimatedProperties for a QualifiedName -- the initial goal for this patch.

#3) In all cpp files, add a call to "registerAnimatedPropertiesForClassName()" in the constructor. Forgetting this will result in a compile error.

Doesn't affect any tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: (NativeToJSValue):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement):
  • svg/SVGAElement.h: (WebCore::SVGAElement::synchronizeRequiredFeatures): (WebCore::SVGAElement::synchronizeRequiredExtensions): (WebCore::SVGAElement::synchronizeSystemLanguage):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedPropertyType): (WebCore::SVGAnimateElement::determinePropertyValueTypes): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance): (WebCore::SVGAnimateElement::ensureAnimator):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedPropertyType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::SVGAnimatedType):
  • svg/SVGAnimatedType.h: (WebCore::SVGAnimatedType::type):
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
  • svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::synchronizeRequiredFeatures): (WebCore::SVGAnimationElement::synchronizeRequiredExtensions): (WebCore::SVGAnimationElement::synchronizeSystemLanguage):
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement):
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::synchronizeRequiredFeatures): (WebCore::SVGCircleElement::synchronizeRequiredExtensions): (WebCore::SVGCircleElement::synchronizeSystemLanguage):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement):
  • svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::synchronizeRequiredFeatures): (WebCore::SVGClipPathElement::synchronizeRequiredExtensions): (WebCore::SVGClipPathElement::synchronizeSystemLanguage):
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement):
  • svg/SVGCursorElement.h: (WebCore::SVGCursorElement::synchronizeRequiredFeatures): (WebCore::SVGCursorElement::synchronizeRequiredExtensions): (WebCore::SVGCursorElement::synchronizeSystemLanguage):
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement):
  • svg/SVGDefsElement.h: (WebCore::SVGDefsElement::synchronizeRequiredFeatures): (WebCore::SVGDefsElement::synchronizeRequiredExtensions): (WebCore::SVGDefsElement::synchronizeSystemLanguage):
  • svg/SVGElement.cpp: (WebCore::SVGElement::animatedPropertyTypeForAttribute): (WebCore::SVGElement::updateAnimatedSVGAttribute): (WebCore::SVGElement::localAttributeToPropertyMap): (WebCore::SVGElement::synchronizeRequiredFeatures): (WebCore::SVGElement::synchronizeRequiredExtensions): (WebCore::SVGElement::synchronizeSystemLanguage):
  • svg/SVGElement.h: (WebCore::SVGElement::svgAttributeChanged): (WebCore::SVGElement::synchronizeRequiredFeatures): (WebCore::SVGElement::synchronizeRequiredExtensions): (WebCore::SVGElement::synchronizeSystemLanguage):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement):
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::synchronizeRequiredFeatures): (WebCore::SVGEllipseElement::synchronizeRequiredExtensions): (WebCore::SVGEllipseElement::synchronizeSystemLanguage):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement):
  • svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
  • svg/SVGForeignObjectElement.h: (WebCore::SVGForeignObjectElement::synchronizeRequiredFeatures): (WebCore::SVGForeignObjectElement::synchronizeRequiredExtensions): (WebCore::SVGForeignObjectElement::synchronizeSystemLanguage):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement):
  • svg/SVGGElement.h: (WebCore::SVGGElement::synchronizeRequiredFeatures): (WebCore::SVGGElement::synchronizeRequiredExtensions): (WebCore::SVGGElement::synchronizeSystemLanguage):
  • svg/SVGGlyphElement.cpp:
  • svg/SVGGlyphElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::svgAttributeChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::synchronizeRequiredFeatures): (WebCore::SVGImageElement::synchronizeRequiredExtensions): (WebCore::SVGImageElement::synchronizeSystemLanguage):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement):
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::synchronizeRequiredFeatures): (WebCore::SVGLineElement::synchronizeRequiredExtensions): (WebCore::SVGLineElement::synchronizeSystemLanguage):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypePropertyInfo): (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper): (WebCore::SVGMarkerElement::orientTypeAnimated):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement):
  • svg/SVGMaskElement.h: (WebCore::SVGMaskElement::synchronizeRequiredFeatures): (WebCore::SVGMaskElement::synchronizeRequiredExtensions): (WebCore::SVGMaskElement::synchronizeSystemLanguage):
  • svg/SVGMissingGlyphElement.cpp:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::dPropertyInfo): (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::svgAttributeChanged): (WebCore::SVGPathElement::lookupOrCreateDWrapper): (WebCore::SVGPathElement::synchronizeD): (WebCore::SVGPathElement::pathSegList): (WebCore::SVGPathElement::animatedPathSegList):
  • svg/SVGPathElement.h: (WebCore::SVGPathElement::pathByteStream): (WebCore::SVGPathElement::synchronizeRequiredFeatures): (WebCore::SVGPathElement::synchronizeRequiredExtensions): (WebCore::SVGPathElement::synchronizeSystemLanguage):
  • svg/SVGPathSegWithContext.h: (WebCore::SVGPathSegWithContext::animatedProperty):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
  • svg/SVGPatternElement.h: (WebCore::SVGPatternElement::synchronizeRequiredFeatures): (WebCore::SVGPatternElement::synchronizeRequiredExtensions): (WebCore::SVGPatternElement::synchronizeSystemLanguage):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::pointsPropertyInfo): (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::lookupOrCreatePointsWrapper): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints):
  • svg/SVGPolyElement.h: (WebCore::SVGPolyElement::synchronizeRequiredFeatures): (WebCore::SVGPolyElement::synchronizeRequiredExtensions): (WebCore::SVGPolyElement::synchronizeSystemLanguage):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement):
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::synchronizeRequiredFeatures): (WebCore::SVGRectElement::synchronizeRequiredExtensions): (WebCore::SVGRectElement::synchronizeSystemLanguage):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::synchronizeRequiredFeatures): (WebCore::SVGSVGElement::synchronizeRequiredExtensions): (WebCore::SVGSVGElement::synchronizeSystemLanguage):
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForAttribute):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement):
  • svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::synchronizeRequiredFeatures): (WebCore::SVGSwitchElement::synchronizeRequiredExtensions): (WebCore::SVGSwitchElement::synchronizeSystemLanguage):
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement):
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp:
  • svg/SVGTSpanElement.h:
  • svg/SVGTests.cpp: (WebCore::SVGTests::requiredFeaturesPropertyInfo): (WebCore::SVGTests::requiredExtensionsPropertyInfo): (WebCore::SVGTests::systemLanguagePropertyInfo): (WebCore::SVGTests::attributeToPropertyMap): (WebCore::SVGTests::synchronizeRequiredFeatures): (WebCore::SVGTests::synchronizeRequiredExtensions): (WebCore::SVGTests::synchronizeSystemLanguage):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::textLengthPropertyInfo): (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeTextLength): (WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper): (WebCore::SVGTextContentElement::textLengthAnimated):
  • svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::synchronizeRequiredFeatures): (WebCore::SVGTextContentElement::synchronizeRequiredExtensions): (WebCore::SVGTextContentElement::synchronizeSystemLanguage):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp:
  • svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::synchronizeRequiredFeatures): (WebCore::SVGUseElement::synchronizeRequiredExtensions): (WebCore::SVGUseElement::synchronizeSystemLanguage):
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement):
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h:
  • svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): (WebCore::SVGAnimatedProperty::lookupWrapper):
  • svg/properties/SVGAnimatedPropertyMacros.h:
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • svg/properties/SVGAttributeToPropertyMap.cpp: Added. (WebCore::SVGAttributeToPropertyMap::addProperties): (WebCore::SVGAttributeToPropertyMap::addProperty): (WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute): (WebCore::SVGAttributeToPropertyMap::animatedPropertyTypeForAttribute): (WebCore::SVGAttributeToPropertyMap::synchronizeProperties): (WebCore::SVGAttributeToPropertyMap::synchronizeProperty): (WebCore::SVGAttributeToPropertyMap::animatedProperty):
  • svg/properties/SVGAttributeToPropertyMap.h: Added. (WebCore::SVGAttributeToPropertyMap::SVGAttributeToPropertyMap): (WebCore::SVGAttributeToPropertyMap::~SVGAttributeToPropertyMap): (WebCore::SVGAttributeToPropertyMap::isEmpty):
  • svg/properties/SVGPropertyInfo.h: Added. (WebCore::SVGPropertyInfo::SVGPropertyInfo):
04:21 Changeset [90679] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: stack traces from worker-side exceptions aren't very useful inside test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=64218

Reviewed by Eric Seidel.

Exceptions aren't picklable and can't be sent across the
manager/worker message queue without losing information. NRWT
handles this by turning the stack trace into a set of strings,
and logging the strings when we receive an exception from the
worker. However, when you are running tests and something
crashes on the worker side, test-webkitpy prints the
manager-side stack trace, which is just confusing and useless.

This patch changes the logic so that exceptions are passed
through as-is when the worker and manager are in the same
process (the --worker-model=inline option). This increases the
code paths slightly but makes crashes much more useful.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
03:55 Changeset [90678] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r90676.

  • platform/graphics/ImageBuffer.cpp:
03:36 WinCE edited by paroga@webkit.org
Fixed build exmple after r76656 (diff)
02:58 Changeset [90677] by darin@chromium.org
  • 2 edits in trunk/Tools

Eliminate bad dependency on gfx::Point.
https://bugs.webkit.org/show_bug.cgi?id=64228

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/EventSender.cpp:

(initMouseEvent):

Note: See TracTimeline for information about the timeline view.