Timeline


and

07/15/11:

22:55 Changeset [91147] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix the build.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::updateEnabledState):
22:15 Changeset [91146] by commit-queue@webkit.org

Overlay scrollbars in overflow areas no longer pulse when revealed
https://bugs.webkit.org/show_bug.cgi?id=64606
<rdar://problem/9390674>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

Ensure that the state of the scrollbar implementation is kept in sync
with WebCore's internal representation. Previously, we synchronized them
at paint time, causing pulsing to be skipped due to the scrollbars being
disabled.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

21:41 Changeset [91145] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • WebView.h: (WebView::backingScaleFactor): (WebView::pageScaleFactor):
21:03 Changeset [91144] by abarth@webkit.org

gardening server should proxy buildbot status for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64588

Reviewed by Eric Seidel.

This information will be used to detect build breaks. I took this
opportunity to make ChromiumBuildBot non-static.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
19:11 Changeset [91143] by cevans@google.com

Merge 90936
BUG=88846
Review URL: http://codereview.chromium.org/7390020

19:08 Changeset [91142] by cevans@google.com

Merge 90914
BUG=86705
Review URL: http://codereview.chromium.org/7398018

19:04 Changeset [91141] by cevans@google.com

Merge 91044
BUG=88337
Review URL: http://codereview.chromium.org/7401011

18:41 Changeset [91140] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Another Windows build fix; make this method non-pure virtual.

  • platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::didCommitChangesForLayer):
18:40 Changeset [91139] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix build error in 32-bit builds.

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect):
18:33 Changeset [91138] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::backingScaleFactor): (WebCore::MediaPlayerPrivate::pageScaleFactor):
18:30 Changeset [91137] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

RenderLayerBacking would set the contentsScale on GraphicsLayers
on creation, and update it when the pageScaleFactor changed. However,
RenderLayerBacking doesn't really know what contentsScale is best
for a layer, so instead, have GraphicsLayers call back through the
GraphicsLayerClient to get the two relevant scale factors, and do
their own computation of contentsScale.

No testable behavior changes.

  • page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): No need to pass the scale.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants): Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on each layer.
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::pageScaleFactorChanged): Remove contentsScale/setContentsScale
  • platform/graphics/GraphicsLayerClient.h: Add methods to fetch the backingScaleFactor() and pageScaleFactor().
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges defaults to ContentsScaleChanged so we update contentsScale on the first flush.

(WebCore::GraphicsLayerCA::setContentsToBackgroundColor):
This was the wrong time to call updateContentsRect() and setupContentsLayer();
those should be done at commit time, so moved to updateLayerBackgroundColor().
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we
have any changes, and call didCommitChangesForLayer() on the client.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here.
(WebCore::clampedContentsScaleForScale): No longer has any hysteresis
on the scale, and now just clamps.
(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales
from the client, and multiply them, then clamp.
(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes
contentsScale into account when deciding to use tiled layer,
so that zooming in will cause layers to start tiling.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call
setContentsScale(), but rather updateContentsScale().
(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits
for properties that depend on the scale.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
Note that contentsScale needs to be updated. At some point we might also
need to dirty other properties.

  • platform/graphics/ca/GraphicsLayerCA.h: Moved the m_allowTiledLayer bool for better packing. No need for a m_contentsScale member now.
  • rendering/RenderLayer.cpp: Removed pageScaleFactorChanged().
  • rendering/RenderLayer.h: Ditto.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to push the contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::didCommitChangesForLayer): Send through to the compositor.
  • rendering/RenderLayerBacking.h: GraphicsLayerClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::didFlushChangesForLayer): We'll use this later. (WebCore::RenderLayerCompositor::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerCompositor::pageScaleFactor): Ditto. (WebCore::RenderLayerCompositor::didCommitChangesForLayer): Ditto. (WebCore::RenderLayerCompositor::ensureRootLayer): No need to push the contents scale. (WebCore::RenderLayerCompositor::pageScaleFactorChanged): Just call notePageScaleFactorChangedIncludingDescendants() on the root GraphicsLayer.
  • rendering/RenderLayerCompositor.h: Added GraphicsLayerClient methods.

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale,
and don't push the scale.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): (WebKit::LayerTreeHostCA::backingScaleFactor): (WebKit::LayerTreeHostCA::pageScaleFactor): (WebKit::LayerTreeHostCA::createPageOverlayLayer):
  • WebProcess/WebPage/ca/LayerTreeHostCA.h: (WebKit::LayerTreeHostCA::didCommitChangesForLayer):

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale.

  • src/PageOverlay.cpp: (WebKit::OverlayGraphicsLayerClientImpl::backingScaleFactor): (WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):
18:10 Changeset [91136] by jchaffraix@webkit.org

[NRWT] Add support for --no-http
https://bugs.webkit.org/show_bug.cgi?id=64564

Reviewed by Dirk Pranke.

Added support for --no-http, which disables both HTTP and websockets tests.
It also matches the old-run-webkit-tests behavior if --force is used.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine
what is worth have an HTTP lock as --no-http to avoid badness.

  • Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that

we do skip properly HTTP / websocket tests inside platform/.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Added tests that we properly skip all the tests.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Added checks for the command line arguments.

17:27 Changeset [91135] by jhoneycutt@apple.com

Build fix. Unreviewed.

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Cast size_t to int for comparison.

17:16 Changeset [91134] by aestes@apple.com

Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
https://bugs.webkit.org/show_bug.cgi?id=64641

Reviewed by Brian Weinstein.

Source/WebCore:

  • WebCore.exp.in: Update to new symbol.
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolarWalkMac): Renamed from applicationIsSolarWalk.

  • platform/RuntimeApplicationChecks.h: Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().

17:03 Changeset [91133] by mrowe@apple.com

Fix the build.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextStateSaver::context): Remove a bogus type qualifier.

16:55 Changeset [91132] by jhoneycutt@apple.com

Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
16:52 Changeset [91131] by mrowe@apple.com

Fix the build.

  • dfg/DFGGraph.h:
16:52 Changeset [91130] by cmarrin@apple.com

Fixing style issues pointed out by Simon for
https://bugs.webkit.org/show_bug.cgi?id=64542

Unreviewed.

16:49 Changeset [91129] by jhoneycutt@apple.com

ALT + DOWN arrow key does not open select

https://bugs.webkit.org/show_bug.cgi?id=14407
<rdar://problem/5319507>

Reviewed by Alexey Proskuryakov.

No test, because eventSender sends events to the WebView, rather than
the popup menu, so the popup isn't closed.

  • WebCore.vcproj/WebCore.vcproj:

Add SelectElementWin.cpp to project.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::platformHandleKeydownEvent):
Moved ARROW_KEYS_POP_MENU code here. Updated to return whether the
function has handled the key, or whether the caller needs to process it
further.
(WebCore::SelectElement::menuListDefaultEventHandler):
Allow the platform the first chance at handling the keyboard event.

  • dom/SelectElement.h:

Declare platformHandleKeydownEvent().

  • dom/SelectElementWin.cpp: Added.

(WebCore::SelectElement::platformHandleKeyboardEvent):
Allow (Shift) F4 and (Ctrl/Shift) Alt/AltGr + Up/Down
arrow to show the popup. After the popup is dismissed, call
setSelectedIndex(), and report that we handled the event.

  • platform/win/PopupMenuWin.cpp:

Declare HIGH_BIT_MASK_SHORT.
(WebCore::PopupMenuWin::show):
Forward WM_SYSKEYDOWN to the popup's HWND.
(WebCore::PopupMenuWin::wndProc):
Allow the same shortcuts that show the menu to hide it, matching
Firefox.

16:48 Changeset [91128] by jhoneycutt@apple.com

Ensure that a single select element's child option elements are
reported correctly to accessibility clients if the children are
changed.

https://bugs.webkit.org/show_bug.cgi?id=64500
<rdar://problem/9773066>

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/win/accessibility/single-select-children-changed.html

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):
Remove a comment about WML, which we no longer support.
(WebCore::AccessibilityMenuListPopup::childrenChanged):
Don't just remove children that were detached - this will miss childen
that were dynamically added. Clear the children and re-add them.

LayoutTests:

  • platform/win/accessibility/single-select-children-changed-expected.txt: Added.
  • platform/win/accessibility/single-select-children-changed.html: Added.
16:39 Changeset [91127] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • DEPS:
16:17 Changeset [91126] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
16:00 Changeset [91125] by rwlbuis@webkit.org

2011-07-15 Rob Buis <rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:
15:49 Changeset [91124] by dglazkov@chromium.org

Refactor TestExpectationModel to use TestExpectationLine as data item.
https://bugs.webkit.org/show_bug.cgi?id=64635

This is a bit largish in scope. Does the following things:

1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,

and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
needs to have any port knowledge.

2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,

and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
Now all expectations are added to the model in the same way!

3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
15:42 Changeset [91123] by aroben@apple.com

Teach TestFailures how to detect interrupted build steps

Fixes <http://webkit.org/b/64619> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
build step was interrupted. Treat it as an error (by returning a failureCount of -1).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cache data that was afflicted by the above bug.

15:40 Changeset [91122] by tony@chromium.org

Unreviewed, unskip css3/selectors3 tests so we can rebaseline them.

  • platform/chromium/test_expectations.txt:
15:40 Changeset [91121] by eric@webkit.org

new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
https://bugs.webkit.org/show_bug.cgi?id=64533

Reviewed by Adam Roben.

Blind removal of Chromium-specific code (now that Chromium does not use this file).

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
15:32 Changeset [91120] by enne@google.com

[chromium] Rebaseline overflow-scroll on Linux after r91114.

Unreviewed.

  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
15:30 Changeset [91119] by aroben@apple.com

Make TestFailures's list of possibly-flaky tests not so tall

Fixes <http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
much room

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Removed a no-longer-used .flakiness-example-separator selector.

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
Use a lot less padding for the possibly-flaky tests.

15:13 Changeset [91118] by tony@chromium.org

[chromium] land linux selection color layout test
https://bugs.webkit.org/show_bug.cgi?id=64631

Reviewed by Ojan Vafai.

Tools:

I had removed this code in r76620 because I thought it wasn't used.
Turns out there was a layout test in the chromium tree that never
got migrated that used it. Re-add the code and land the layout
test (I will remove it from the chromium tree soon).

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::forceRedSelectionColors):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

  • platform/chromium-linux/editing/selection/linux_selection_color.html: Added.
15:10 Changeset [91117] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
15:03 Changeset [91116] by barraclough@apple.com

NativeError.prototype objects have Class? of "Object" but should be "Error"
https://bugs.webkit.org/show_bug.cgi?id=55346

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • Switch to putDirect since we're not the only ones tranitioning this Structure now.
  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

  • runtime/NativeErrorPrototype.h:
    • Switch base class to ErrorPrototype.

LayoutTests:

Added test case.

  • fast/js/native-error-prototype-expected.txt: Added.
  • fast/js/native-error-prototype.html: Added.
  • fast/js/script-tests/native-error-prototype.js: Added.
14:57 Changeset [91115] by barraclough@apple.com

DFG JIT - Where arguments passed are integers, speculate this.
https://bugs.webkit.org/show_bug.cgi?id=64630

Reviewed by Sam Weinig.

Presently the DFG JIT is overly aggressively predicting double.
Use a bit of dynamic information, and curtail this a little.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • Check for integer arguments.
  • dfg/DFGGraph.h:
    • Function declaration.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::FunctionExecutable::compileForCallInternal):

  • Add call to predictArgumentTypes.
14:54 Changeset [91114] by enne@google.com

Reviewed by Simon Fraser.

Overlap map for compositing needs to consider clipping
https://bugs.webkit.org/show_bug.cgi?id=63493

Source/WebCore:

Test: compositing/layer-creation/overlap-clipping.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Added new test. limit-layer-bounds-clipping-ancestor had changed
behavior because some layers no longer needed to become composited.
Adjusted that test to be less platform-specific as well.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • compositing/layer-creation/overlap-clipping.html: Added.
  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
14:24 Changeset [91113] by commit-queue@webkit.org

Unreviewed, rolling out r90592.
http://trac.webkit.org/changeset/90592
https://bugs.webkit.org/show_bug.cgi?id=64627

Causes crashes with the web audio async decoding API
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

  • manual-tests/array-buffer-memory.html: Removed.
14:22 Changeset [91112] by kbr@google.com

Don't restore WebGL context if it was guilty of a graphics reset
https://bugs.webkit.org/show_bug.cgi?id=64497

Reviewed by Stephen White.

Source/WebCore:

Use getGraphicsResetStatusARB already defined in Extensions3D to
determine why the context was lost, and respond to guilty context
notifications by forbidding restoration of the context.

It isn't currently possible to write an automated test for this.
We might consider extending the WEBKIT_lose_context extension to
allow a reason to be provided why the context was lost. It was
tested manually in Chromium on Windows and Linux with some test
cases that provoke actual graphics card resets.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

Source/WebKit/chromium:

Actually implement getGraphicsResetStatusARB rather than inferring
the status based on whether the context has been lost.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

LayoutTests:

Updated expectations for context-lost test and added comment about
the order of event delivery. Per the specification of the
WEBKIT_lose_context extension, the previous expectations were wrong.

  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
14:17 Changeset [91111] by lforschler@apple.com

Update Versioning.

14:17 Changeset [91110] by cmarrin@apple.com

Move TransformState to platform/graphics and give it the option to transform just a FloatQuad
https://bugs.webkit.org/show_bug.cgi?id=64542

Reviewed by Simon Fraser.

This is to make it possible to use TransformState in some GraphicsLayer work. HitTestingTransformState
was split out and left in rendering since it's not needed in the platform code. Also added a FIXME
because HitTestingTransformState should eventually be replaced by TransformState.

14:07 Changeset [91109] by lforschler@apple.com

New branch.

14:00 Changeset [91108] by adachan@apple.com

Implement "Jump to Selection" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64569

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView centerSelectionInVisibleArea:]): Call WebPageProxy::centerSelectionInVisibleArea().
(-[WKView validateUserInterfaceItem:]): Enable the centerSelectionInVisibleArea: selector if there's a selection
range or if there's an insertion point in an editable area.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::showFindIndicatorInSelection): Call updateFindIndicator() to show the find indicator.

  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea): Use the selection in the focused or main frame.
After scrolling the selection into view, flash the find indicator.

13:54 Changeset [91107] by mitz@apple.com

Chromium build fix.

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::setCursorHiddenUntilMouseMoves):

  • src/WebPopupMenuImpl.h:
13:49 Changeset [91106] by dglazkov@chromium.org

Revert http://trac.webkit.org/changeset/91091, since Python 2.5
does not support enumerate() start argument.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
13:49 Changeset [91105] by enne@google.com

[chromium] Re-mark tests as failing as a result of r91069
https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

senorblanco checked in baselines, but these tests appear to still be failing.

  • platform/chromium/test_expectations.txt:
13:41 Changeset [91104] by weinig@apple.com

Reviewed by Simon Fraser.

We should import the CSS 3 Selectors test suite
https://bugs.webkit.org/show_bug.cgi?id=64610

Add dump of the CSS 3 Selectors test suite from http://www.w3.org/Style/CSS/Test/CSS3/Selectors/current/.
Add standalone versions of the html, xhtml and xml suites.

  • css3/selectors3: Added.
  • css3/selectors3/html: Added.
  • css3/selectors3/xhtml: Added.
  • css3/selectors3/xml: Added.
  • platform/mac/css3/selectors3: Added.
  • platform/mac/css3/selectors3/html: Added.
  • platform/mac/css3/selectors3/xhtml: Added.
  • platform/mac/css3/selectors3/xml: Added.

[Individual tests elided]

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Added css3/selectors3 pending results.

13:41 Changeset [91103] by dglazkov@chromium.org

Clean up test_expectations.py after refactorings.
https://bugs.webkit.org/show_bug.cgi?id=64620

  • Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with its sub-part, the actual expectation.
  • Renamed all references to options to modifier to eliminate dual terminology.
  • Made a bunch of parser constants and changed all callsites to use them.
  • Various other minor clean-ups.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
13:35 Changeset [91102] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Minor changes needed to keep the compiler happy.

No new tests because no change in functionality.

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCopy):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::WebCoreSynchronousLoaderClient::willSendRequest):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::toTimeT):

13:22 Changeset [91101] by senorblanco@chromium.org

Unreviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
13:17 Changeset [91100] by mitz@apple.com

Windows build fix.

  • UIProcess/win/WebView.cpp:
13:14 Changeset [91099] by commit-queue@webkit.org

DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches.
https://bugs.webkit.org/show_bug.cgi?id=64573

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-15
Reviewed by Gavin Barraclough.

This patch moves some of NonSpeculativeJIT's functionality up into the
JITCodeGenerator superclass so that it can be used from both JITs. Now,
in cases where the speculative JIT doesn't want to speculate but still
wants to emit good code, it can reliably emit the same code sequence as
the non-speculative JIT. This patch also extends the non-speculative
JIT's compare optimizations to include compare/branch fusing, and
extends the speculative JIT's compare optimizations to cover StrictEqual.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::detectPeepHoleBranch):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • wtf/Platform.h:
13:10 Changeset [91098] by mitz@apple.com

Windows build fix.

  • UIProcess/win/WebView.h:
13:03 Changeset [91097] by mitz@apple.com

REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
https://bugs.webkit.org/show_bug.cgi?id=64615

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
entering full screen.
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
hiding the HUD.

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.

  • page/Chrome.cpp:

(WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
+[NSCursor setHiddenUntilMouseMoves:].

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit2:

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
to the page proxy.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:59 Changeset [91096] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
12:51 Changeset [91095] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64250
Global strict mode function leaking global object as "this".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The root problem here is that we pass the wrong values into
calls, and then try to fix them up in the callee. Correct
behaviour per the spec is to pass in the value undefined,
as this unless either (1) the function call is based on an
explicit property access or (2) the base of the call comes
directly from a 'with'.

This change does away with the need for this conversion of
objects (non strict code should only box primitives), and
does away with all this conversion for strict functions.

This patch may have web compatibility ramifications, and may
require some advocacy.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecode/Opcode.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitResolveWithThis):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolveThisAndProperty):

  • Based on resolveBaseAndProperty, but produce correct this value.

(JSC::Interpreter::privateExecute):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JITStubs.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • runtime/JSActivation.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSStaticScopeObject.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • removed NeedsThisConversion.
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):

  • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSValue.h:
    • removed NeedsThisConversion.
  • runtime/JSVariableObject.h:
    • Corrected StructureFlags inheritance.
  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

  • Added IsEnvironmentRecord to StructureFlags, addded createStructure.
  • runtime/Structure.h:
    • removed NeedsThisConversion.
  • tests/mozilla/ecma/String/15.5.4.6-2.js:

(getTestCases):

  • Removed invalid test case.

Source/WebCore:

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

  • Change call to pass DOM Window shell, instead of the global varaible object.

LayoutTests:

Add test case / update test results.

  • fast/js/call-base-resolution-expected.txt: Added.
  • fast/js/call-base-resolution.html: Added.
    • Add test for ES5 correct this value resolution in calls.
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
12:46 Changeset [91094] by commit-queue@webkit.org

Unreviewed, rolling out r91082, r91087, and r91089.
http://trac.webkit.org/changeset/91082
http://trac.webkit.org/changeset/91087
http://trac.webkit.org/changeset/91089
https://bugs.webkit.org/show_bug.cgi?id=64616

gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

12:44 Changeset [91093] by commit-queue@webkit.org

[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
https://bugs.webkit.org/show_bug.cgi?id=64612

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-15
Reviewed by Stephen White.

Tested by compositing/shadows/shadow-drawing.html

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):

12:33 Changeset [91092] by dglazkov@chromium.org

Move expectation parsing code to TestExpectationParser.
https://bugs.webkit.org/show_bug.cgi?id=64605

This is a somewhat mechanical move, with two interesting bits:

1) TestExpectationParser.parse methods renamed to tokenize, to better
reflect what they do

2) TestExpectationLine now carries all of its info, from tokens to parsed data,
and even the list of tests that it matches (a line may refer to more than one test).

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods

to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
to "tokenize", changed callsites to use new code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
12:29 Changeset [91091] by dglazkov@chromium.org

Switch to use Python enumerate function to enumerate line numbers.
https://bugs.webkit.org/show_bug.cgi?id=64602

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
12:27 Changeset [91090] by commit-queue@webkit.org

Avoid rounded rect corner-drawing overhead if no corners are visible
https://bugs.webkit.org/show_bug.cgi?id=64584

Patch by Ian Henderson <ianh@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

No new tests, rendering is visually identical.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::unroundClippedCorners):
(WebCore::RenderBoxModelObject::paintBorder):
Any invisible corner may be replaced with a corner of radius zero, as
long as the stroke style is solid. Change the GraphicsContext
parameter into a PaintInfo parameter so we can get the rect to be
drawn.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

12:23 Changeset [91089] by levin@chromium.org

Another attempted build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:16 Changeset [91088] by jeffm@apple.com

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

  • WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.
12:15 Changeset [91087] by levin@chromium.org

Chromium build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:14 Changeset [91086] by senorblanco@chromium.org

Unreviewed. Yet more chromium test baselines.

Somehow I messed these up in my mass-rebaselining.

  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
12:10 Changeset [91085] by andersca@apple.com

Find indicator should take scale factor into account
https://bugs.webkit.org/show_bug.cgi?id=64611
<rdar://problem/9761020>

Reviewed by Sam Weinig.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
Keep track of the scale factor of the find indicator bitmap.

(WebKit::FindIndicator::draw):
Pass the scale factor to ShareableBitmap::draw.

  • UIProcess/FindIndicator.h:

Add scale factor member variable.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
This now takes the content image scale factor.

  • UIProcess/WebPageProxy.messages.in:

Add the scale factor.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Size the backing store correctly, and apply the scale factor to
the graphics context.

(WebKit::FindController::hideFindIndicator):
Pass the scale factor along.

11:52 Changeset [91084] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/AuthenticationCF.h: Just use AuthenticationMac.h instead of having

Mac-specific declarations here.

  • platform/network/cf/CredentialStorageCFNet.cpp:
  • platform/network/mac/AuthenticationMac.h:
11:51 Changeset [91083] by senorblanco@chromium.org

Unreviewed; chromium test expectations update.

Remove some now-passing tests from chromium's text_expectations.

  • platform/chromium/test_expectations.txt:
11:49 Changeset [91082] by levin@chromium.org

currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

11:38 Changeset [91081] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get LoaderRunLoop to work on Mac when USE(CFNETWORK) is enabled. Although we could use the
main run loop, it's better to have a separate thread handling the loads so that it can work
in parallel to the main thread. This is similar to what NSURLConnection does for us
internally when we use the NS APIs.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread): Create an autorelease pool for objc code that might be called in
the run loop.
(WebCore::loaderRunLoop):

  • platform/network/cf/LoaderRunLoopCF.h:
11:34 Changeset [91080] by senorblanco@chromium.org

Unreviewed. New chromium test baselines after r91069.

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
  • platform/chromium-win-vista/fast/block: Added.
  • platform/chromium-win-vista/fast/block/positioning: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Added.
  • platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win-vista/svg/zoom/text: Added.
  • platform/chromium-win-vista/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win-xp/fast/dynamic: Added.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/005-vertical-expected.png:
  • platform/chromium-win/fast/lists/006-vertical-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/009-vertical-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Removed.
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-win/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.png:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/custom/text-rotation-expected.png:
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-win/svg/hixie/error/017-expected.png:
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium/test_expectations.txt:
11:25 Changeset [91079] by kenneth@webkit.org

REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect

Reviewed by Antonio Gomes.

Only set setFixedVisibleContentRect when in resizesToContents mode.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

11:11 Changeset [91078] by mrobinson@webkit.org

Build fixes for WebKit2. Ensure that all generated sources are
on nodist primaries, that they are on forward declared variables
so that BUILT_SOURCES is calculated properly and that zlib is
included during linking (for WOFF support).

.:

  • GNUmakefile.am:
  • Source/autotools/webkit.m4: Include test for zlib.

Source/WebKit/gtk:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:

Tools:

  • WebKitTestRunner/GNUmakefile.am:
10:23 Changeset [91077] by xji@chromium.org

--webkit-visual-word crash on mixed editability
https://bugs.webkit.org/show_bug.cgi?id=61978

--webkit-visual-word crashes (VisiblePosition.getInlineBoxAndOffset could return null box)
https://bugs.webkit.org/show_bug.cgi?id=62814

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace previousWordPosition/nextWordPosition with previousBoundary/nextBoundary which do
not honor editable bounary. Honor editable boundary as the last stage of leftWordPosition
and rightWordPosition.

Check previousBoundary/nextBoundary against NULL. Have a static function to encapsulate the
usage of getInlineBoxAndOffset and check the visible position is not NULL before passing to
getInlineBoxAndOffset. Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Test: editing/selection/move-by-word-visually-null-box.html

  • editing/visible_units.cpp:

(WebCore::positionIsInBox):
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::positionIsInsideBox):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

Add a standalone test for testing getInlineBoxAndOffset returning null box.

  • editing/selection/move-by-word-visually-null-box-expected.txt: Added.
  • editing/selection/move-by-word-visually-null-box.html: Added.
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html:
10:17 Changeset [91076] by senorblanco@chromium.org

Unreviewed. Mopping up some more expectations after r91069.

  • platform/chromium/test_expectations.txt:
10:12 Changeset [91075] by psolanki@apple.com

Remove unncessary creation of connectionProperties dictionary
https://bugs.webkit.org/show_bug.cgi?id=63958

Reviewed by Alexey Proskuryakov.

No new tests because no change in functionality.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

09:50 Changeset [91074] by enne@google.com

[chromium] Mark more tests failing as a result of r91069
https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:58 Changeset [91073] by dglazkov@chromium.org

Store error and warning information on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64565

Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,

converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
08:55 Changeset [91072] by dglazkov@chromium.org

Plumb the use of TestExpectationLine deeper, clean up.
https://bugs.webkit.org/show_bug.cgi?id=64559

Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
also cleaning up names and remove an unused TestExpectations._get_options_list member.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
08:51 Changeset [91071] by dglazkov@chromium.org

Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
https://bugs.webkit.org/show_bug.cgi?id=64554

This moves us toward the world where errors are collected on the expectations, which allows us to
easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.

Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
parsing.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,

changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
08:34 Changeset [91070] by pfeldman@chromium.org

Web Inspector: Focusing on another node while editing CSS property does not update styles
https://bugs.webkit.org/show_bug.cgi?id=64283

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-change-node-while-editing.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype.updateStyles):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.callback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.inlineStyleCallback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
(WebInspector.MetricsSidebarPane.prototype._styleSheetChanged):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylesSidebarPane.prototype._styleSheetChanged):
(WebInspector.StylesSidebarPane.prototype._attributesUpdated):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

  • inspector/styles/styles-change-node-while-editing-expected.txt: Added.
  • inspector/styles/styles-change-node-while-editing.html: Added.
08:27 Changeset [91069] by commit-queue@webkit.org

[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
https://bugs.webkit.org/show_bug.cgi?id=64368

Patch by Mike Reed <reed@google.com> on 2011-07-15
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
08:10 Changeset [91068] by aroben@apple.com

Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Updated for renames.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and

reordered <script>s to put files which others depend on for parsing first.

07:38 Changeset [91067] by commit-queue@webkit.org

Pixel difference in FEMorphology effect
https://bugs.webkit.org/show_bug.cgi?id=63930

Source/WebCore:

Patch by Piroska András <Piroska.Andras@stud.u-szeged.hu> on 2011-07-15
Reviewed by Zoltan Herczeg.

Using short-circuit evaluation in the setFilterEffectAttribute function
was wrong. We should call both setRadius functions and evaluate the
changes separately.

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):

LayoutTests:

Patch by Gabor Loki <loki@webkit.org> on 2011-07-15
Reviewed by Zoltan Herczeg.

Layout test is updated to follow the bugfix.

  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
07:02 Changeset [91066] by jeffm@apple.com

Fullscreen content doesn't use fullscreen controller on Windows
https://bugs.webkit.org/show_bug.cgi?id=64540
<rdar://problem/9510455>

Source/WebCore:

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.

  • rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests:

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

  • fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.
  • fullscreen/video-controls-override.html: Add new test to check the height of the panel, and

log errors if window.internals or window.layoutTestController are undefined.

06:10 Changeset [91065] by zimmermann@webkit.org

2011-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build failure introduced in r91061.

  • page/Console.cpp: (WebCore::Console::markTimeline): Remove argument name from unused parameter.
05:02 Changeset [91064] by kenneth@webkit.org

Upstream QtWebKit/N9 changes related to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=64589

Reviewed by Simon Hausmann.

Source/WebCore:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

Make visibleContentRect return the fixed value if set, and remove
all calls to actualVisibleContentRect.

Also updated the documentation.

This is similar to what we have on our QtWebKit/N9 branch and is
pretty well tested.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
If a fixed visibleContentRect is set, return that.
Remove the code returning the contents size when in
paintsEntireContents mode as that is wrong and already
ifdeffed out for EFL.
(WebCore::ScrollView::setScrollPosition):
Do not try to be smart and update the fixed visibleContentsRect
automatically, as the embedder might ignore the scroll request
for various reasons.

  • platform/ScrollView.h:

(WebCore::ScrollView::setFixedVisibleContentRect):
(WebCore::ScrollView::fixedVisibleContentRect):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setActualVisibleContentRect):
Change to use setFixedVisibleContentRect.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • symbian/eabi/QtWebKitu.def:

Source/WebKit2:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFixedVisibleContentRect):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleArea):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
04:09 Changeset [91063] by carlosgc@webkit.org

[GTK] Build plugin process by default when building WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64592

Reviewed by Philippe Normand.

  • configure.ac:
03:40 Changeset [91062] by carlosgc@webkit.org

Reviewed by Martin Robinson.

[GTK] Install a custom X error handler in plugin process
https://bugs.webkit.org/show_bug.cgi?id=63248

Some plugins, specially flash, can cause X errors that when
handled by the default X error handler (or the GDK one) abort the
process. Since we don't want to crash due to buggy plugins, we
install a custom error handler to show a warning when a X error
happens without aborting.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::webkitgtkXError):
(WebKit::PluginProcessMainGtk):

03:06 Changeset [91061] by commit-queue@webkit.org

Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.
https://bugs.webkit.org/show_bug.cgi?id=63317

Patch by Mike West <mkwst@chromium.org> on 2011-07-15
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-time-stamp.html

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::consoleTimeStamp):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleTimeStampImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didTimeStamp):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimeStampData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

  • page/Console.cpp:

(WebCore::Console::markTimeline):
(WebCore::Console::timeStamp):

  • page/Console.h:
  • page/Console.idl:

LayoutTests:

  • inspector/timeline/resources/timeline-iframe-data.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch.html:
  • inspector/timeline/timeline-mark-timeline-expected.txt:
  • inspector/timeline/timeline-mark-timeline.html:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.dumpTimelineRecord):

  • inspector/timeline/timeline-time-stamp-expected.txt: Added.
  • inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
  • platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
  • platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.
01:35 Changeset [91060] by commit-queue@webkit.org

LocalStorage: Changed the value type of ItemTable from TEXT to BLOB
to avoid string truncation.
This patch will also convert the exsisting ItemTable and perform
the DATA MIGRATION job.
https://bugs.webkit.org/show_bug.cgi?id=58762

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2011-07-15
Reviewed by Jeremy Orlow.

Tests: manual-tests/localstorage-value-truncation.html

  • manual-tests/localstorage-value-truncation.html: Added.

Demostrate the testcase shown in bug 58762.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclearedAsBlob):
Test if the pre-defined type of column is BLOB.

  • platform/sql/SQLiteStatement.h:
  • storage/StorageAreaSync.cpp:

Change the localStorage value type from Text to BLOB to avoid the
value string truncation at \x00.
(WebCore::StorageAreaSync::openDatabase):
Change the database structure, use BLOB to replace the TEXT type of
value segment in ItemTable.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
Migrate the ItemTable if the pre-defined type of value is TEXT.
(WebCore::StorageAreaSync::performImport):
Use getColumnBlobAsString() to import the BLOB value.
(WebCore::StorageAreaSync::sync):
Use bindBlob() to bind value string to the SQLiteStatement for the
database execution.

  • storage/StorageAreaSync.h:
01:25 WebKitGTK edited by plaes@plaes.org
Looking for 1.4.3 ;) (diff)
01:22 Changeset [91059] by abarth@webkit.org

NRWT stores the Chromium revision number in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=64586

I have no earthly idea how to test this change.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
01:10 Changeset [91058] by commit-queue@webkit.org

Clear the content of a search input form when 'Escape' is pressed.
https://bugs.webkit.org/show_bug.cgi?id=51897

Source/WebCore:

This change added handleKeydownEvent() to a search input form,
which clears the form and triggers a 'search' event when 'Escape' is pressed.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

Test: fast/forms/input-search-press-escape-key.html

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

  • html/SearchInputType.h:

LayoutTests:

The added test checks if the value in a search input form is cleared
and a 'search' event is triggered, when we press 'Escape' key.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

  • fast/forms/input-search-press-escape-key-expected.txt: Added.
  • fast/forms/input-search-press-escape-key.html: Added.
00:23 Changeset [91057] by commit-queue@webkit.org

Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
https://bugs.webkit.org/show_bug.cgi?id=64360

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-15
Reviewed by Hajime Morita.

No new tests needed because the patch is just a refactor.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

07/14/11:

23:56 Changeset [91056] by morrita@google.com

ExceptionCodePlaceholder should have its own ExceptionCodePlaceholder.cpp file
https://bugs.webkit.org/show_bug.cgi?id=64503

Reviewed by Darin Adler.

No new tests. Just a file reorg.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ExceptionCodePlaceholder.cpp: Added.

(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):

  • dom/ExceptionCodePlaceholder.h: Removed NoExceptionAssertionChecker::m_function, which is loonger used.
23:49 Changeset [91055] by hayato@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
23:38 Changeset [91054] by ojan@chromium.org

fix remaining style issues in the static-dashboards directory
https://bugs.webkit.org/show_bug.cgi?id=64561

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
23:33 Changeset [91053] by commit-queue@webkit.org

Remove LegacyDefaultOptionalArguments flag from WebGL
https://bugs.webkit.org/show_bug.cgi?id=64549

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/bad-arguments-test-expected.txt:
  • fast/canvas/webgl/bad-arguments-test.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
23:26 Changeset [91052] by yutak@chromium.org

WebSocket: Introduce pywebsocket-0.6b2
https://bugs.webkit.org/show_bug.cgi?id=64534

Reviewed by Kent Tamura.

Source/WebCore:

pywebsocket now accepts "Sec-WebSocket-Version: 8" as required in hybi-10 specification.

No new functionality is added, thus no new tests. Existing WebSocket tests should keep passing.

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

Tools:

  • Scripts/webkitpy/thirdparty/init.py:

LayoutTests:

Module "mod_pywebsocket.handshake.hybi06" has been renamed to "mod_pywebsocket.handshake.hybi".

  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py:
23:07 Changeset [91051] by commit-queue@webkit.org

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-07-14
Reviewed by Adam Barth.

[EFL] Remove IconDatabase initialization in _ewk_init_body()
https://bugs.webkit.org/show_bug.cgi?id=63491

Make IconDatabase feature optional by removing its initialization from _ewk_init_body().
Now IconDatabase must be fully managed by an application:
if it doesn't want to use it, there's nothing to do. Otherwise, just call
ewk_settings_icon_database_path_set() with the directory path.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):

22:58 Changeset [91050] by dglazkov@chromium.org

Introduce TestExpectationsModel, split out of TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=64531

This is a simple split-and-make-work refactoring, a first step among many.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members

out of TestExpectations and into TestExpectationsModel.

22:37 Changeset [91049] by commit-queue@webkit.org

Replaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with all the corresponding function calls.
https://bugs.webkit.org/show_bug.cgi?id=54476

Patch by SravanKumar S <sravan.ken@gmail.com> on 2011-07-14
Reviewed by Darin Adler.

No new tests, since existing fast/dom/HTMLInputElement/checked-pseudo-selector.html verifies the patch.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::removeButton):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldAppearChecked):

  • html/HTMLInputElement.h: Removed virtual declaration from shouldAppearChecked().
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):

21:36 Changeset [91048] by bashi@chromium.org

<input form="x"> should not associate the input with any forms when there is no form with id="x"
https://bugs.webkit.org/show_bug.cgi?id=64509

Source/WebCore:

Don't set form owner when a form associated element has the form attribute but there is no such form element.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

Test: fast/forms/form-attribute-nonexistence-form-id.html

  • dom/Document.cpp:

(WebCore::Document::resetFormElementsOwner): Removed the argument which is no longer needed.

  • dom/Document.h: Ditto.
  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedIntoTree): Resets m_form whenever the element has the form attribute.
(WebCore::FormAssociatedElement::resetFormOwner): Don't set m_form when there is no form element which has the given id.
(WebCore::FormAssociatedElement::formAttributeChanged): Removed the argument of resetFormOwner().

  • html/FormAssociatedElement.h: Ditto.
  • html/HTMLFormElement.cpp: Ditto.

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):

LayoutTests:

Adds a test for checking input elements don't associate any form elements when they have the form attribute which points nonexistence form.
Fixes existing tests that contain unintended form attributes.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

  • fast/forms/form-attribute-nonexistence-form-id-expected.txt: Added.
  • fast/forms/form-attribute-nonexistence-form-id.html: Added.
  • fast/forms/script-tests/form-attribute.js: Fixed unintended form attributes.
  • fast/forms/script-tests/form-collection-elements-order.js: Ditto.
21:31 Changeset [91047] by tkent@chromium.org

REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
https://bugs.webkit.org/show_bug.cgi?id=64537

Reviewed by Darin Adler.

Source/WebCore:

We stopped to call updateCheckedRadioButtons() for checkboxes
since r90809, but we need to call RenderTheme::stateChanged(),
which was in updateCheckedRadioButtons(), for checkboxes.

Tests: fast/forms/checkbox-appearance-change-by-checked-expected.html

fast/forms/checkbox-appearance-change-by-checked.html

  • html/HTMLInputElement.cpp: Move the RenderTheme::stateChanged() call

from updateCheckedRadioButtons() to setChecked().
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

  • fast/forms/checkbox-appearance-change-by-checked-expected.html: Added.
  • fast/forms/checkbox-appearance-change-by-checked.html: Added.
20:50 Changeset [91046] by tkent@chromium.org

[Chromium] Updat test expectations for r90971.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac-leopard/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac-leopard/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:33 Changeset [91045] by eric@webkit.org

Move webkitpy off of loose mocks
https://bugs.webkit.org/show_bug.cgi?id=64508

Unreviewed. Fixing a test which fails under test-webkitpy --all (but not in a normal run).

  • Scripts/webkitpy/common/checkout/scm/git.py:
19:16 Changeset [91044] by abarth@webkit.org

The beforeload event allows tracking URI changes in a frame
https://bugs.webkit.org/show_bug.cgi?id=64482

Reviewed by Nate Chapin.

Source/WebCore:

Tests: http/tests/security/beforeload-iframe-client-redirect.html

http/tests/security/beforeload-iframe-server-redirect.html

Only dispatch the beforeload event for a frame if we haven't yet
committed our first real load. The URL that we send to our parent will
be the same URL the parent seens in the src attribute.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests:

Test whether the beforeload event is fired for various kinds of redirects.

  • http/tests/security/beforeload-iframe-client-redirect-expected.txt: Added.
  • http/tests/security/beforeload-iframe-client-redirect.html: Added.
  • http/tests/security/beforeload-iframe-server-redirect-expected.txt: Added.
  • http/tests/security/beforeload-iframe-server-redirect.html: Added.
  • http/tests/security/resources/post-done.html: Added.
  • http/tests/security/resources/client-redir.html: Added.
19:10 Changeset [91043] by mitz@apple.com

LLVM Compiler build fix.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):

19:06 Changeset [91042] by abarth@webkit.org

garden-o-matic should have a "rebaseline" button
https://bugs.webkit.org/show_bug.cgi?id=64446

Reviewed by Ojan Vafai.

This patch adds a basic Rebaseline button that copies the baselines
displayed in the results pane into the appropriate directory in your
working copy.

There are two main limitations:

1) There is no UI for actually committing the baselines.

2) The baselines are not optimized for redundancy (meaning you can have

identical baselines in both chromium-mac and chromium-win).

  • Scripts/webkitpy/tool/commands/rebaseline.py:
    • Turns out we need to create the directory for the baseline if it doesn't exist yet.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
    • Add an programatic API to call the server.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add the rebaseline button itself.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • Change the CSS so that the Rebaseline and Close buttons can appear in the normal order in the DOM.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Bind the event and translate the parameters.
    • Hide/show the rebaseline button, as appropriate.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Add some helpful utility functions for manipulating failure types.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
19:06 Changeset [91041] by commit-queue@webkit.org

DFG JIT does not optimize Branch as well as it could.
https://bugs.webkit.org/show_bug.cgi?id=64574

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This creates a common code path for emitting unfused branches, which does
no speculation, and only performs a slow call if absolutely necessary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitBranch):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

18:51 Changeset [91040] by darin@apple.com

[Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not-allowed
https://bugs.webkit.org/show_bug.cgi?id=64570

Reviewed by Alexey Proskuryakov.

Mac OS X documentation and usage makes it clear that this cursor is usually used for no-drop,
and that it's also reasonable to use it for not-allowed.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use [NSCursor operationNotAllowedCursor] for
Cursor::NoDrop.

18:40 Changeset [91039] by commit-queue@webkit.org

GC allocation fast path has too many operations.
https://bugs.webkit.org/show_bug.cgi?id=64493

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Darin Adler.

Changed the timing of the lazy sweep so that it occurs when we land on
a previously-unsweeped block, rather than whenever we land on an unsweeped
cell. After the per-block lazy sweep occurs, the block is turned into a
singly linked list of free cells. The allocation fast path is now just a
load-branch-store to remove a cell from the head of the list.

Additionally, this changes the way new blocks are allocated. Previously,
they would be populated with dummy cells. With this patch, they are
turned into a free list, which means that there will never be destructor
calls for allocations in fresh blocks.

These changes result in a 1.9% speed-up on V8, and a 0.6% speed-up on
SunSpider. There are no observed statistically significant slow-downs
on any individual benchmark.

(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::allocate):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):

  • heap/MarkedBlock.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::addBlock):
(JSC::NewSpace::canonicalizeBlocks):

  • heap/NewSpace.h:

(JSC::NewSpace::allocate):
(JSC::NewSpace::SizeClass::SizeClass):
(JSC::NewSpace::SizeClass::canonicalizeBlock):

  • heap/OldSpace.cpp:

(JSC::OldSpace::addBlock):

18:28 Changeset [91038] by macpherson@chromium.org

Reviewed by Dimitri Glazkov.

Introduce templated compute length class in CSSStyleApplyProperty, and use to handle several CSS properties.
https://bugs.webkit.org/show_bug.cgi?id=62957

No new tests / refactoring only.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Add computeLength function that returns unsigned short.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyComputeLength::ApplyPropertyComputeLength):
Added class to handle computeLength based properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize ApplyPropertyComputeLength for appropriate properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::useSVGZoomRules):
Make this a public member function instead of a private static function.
(WebCore::CSSStyleSelector::applyProperty):
Removed code now implemented in CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::setFontSize):
Use new useSVGZoomRules function.

  • css/CSSStyleSelector.h:

Add interface for useSVGZoomRules.

16:48 Changeset [91037] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
16:40 Changeset [91036] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
16:38 Changeset [91035] by scheib@chromium.org

DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

  • fast/js/array-constructor-host-call-expected.txt: Added.
  • fast/js/array-constructor-host-call.html: Added.
  • fast/js/script-tests/array-constructor-host-call.js: Added.

(constructArray):

16:26 Changeset [91034] by commit-queue@webkit.org

Source/JavaScriptCore: DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Fixed the relevant ASSERT.

  • dfg/DFGOperations.cpp:

LayoutTests: DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

  • fast/js/array-constructor-host-call-expected.txt: Added.
  • fast/js/array-constructor-host-call.html: Added.
  • fast/js/script-tests/array-constructor-host-call.js: Added.

(constructArray):

16:23 Changeset [91033] by rniwa@webkit.org

REGRESSION: webkit-patch roll-chromium-deps is broken
https://bugs.webkit.org/show_bug.cgi?id=64568

Reviewed by Dirk Pranke

Use _filesystem.join.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittests.py:
16:22 Changeset [91032] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
16:00 Changeset [91031] by rniwa@webkit.org

Rolled Chromium revision to 92606.

  • DEPS:
14:52 Changeset [91030] by noam.rosenthal@nokia.com

Adding myself to the reviewers list; No review needed.

  • Scripts/webkitpy/common/config/committers.py:
14:49 Changeset [91029] by aroben@apple.com

Don't use Element.prototype.classList in TestFailures

Safari 5 doesn't support it.

Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(Element.prototype.hasStyleClass):
(Element.prototype.addStyleClass):
(Element.prototype.removeStyleClass):
(Element.prototype.toggleStyleClass):
Added these helper functions which simulate classList functionality.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:

Added. Tests for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Changed to use
toggleStyleClass/hasStyleClass instead of classList.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added Utilities_unittests.js, and reordered the tested files to be in
roughly dependency order (i.e., the lowest-level files are imported
and tested first).

14:21 Changeset [91028] by commit-queue@webkit.org

NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Unreviewed. Just fixing my test-webkitpy regression.

Fix the unit tests. Unfortunately scm does not use a filesystem
object so we can't control the result of detect_scm_system.
When detect_scm_system would fail, we would log, which would
cause all passing_run integration tests to fail.

  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14:16 Changeset [91027] by antti@apple.com

REGRESSION: Should not dispatch didFirstVisuallyNonEmptyLayout for the initial empty document
https://bugs.webkit.org/show_bug.cgi?id=64557

Reviewed by Kenneth Rohde Christiansen.

Avoid sending didFirstVisuallyNonEmptyLayout for the initial empty document of the frame. The
clients may not expect it and it doesn't make much sense in any case.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

13:49 Changeset [91026] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
13:08 Changeset [91025] by jpfau@apple.com

Character reference parser for new XML parser
https://bugs.webkit.org/show_bug.cgi?id=64398

Reviewed by Adam Barth.

Refactored out the HTML entity parser and added a common template for parsing character references.

  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLEntityParser.cpp:

(WebCore::consumeHTMLEntity):

  • xml/parser/CharacterReferenceParserInlineMethods.h: Copied from Source/WebCore/html/parser/HTMLEntityParser.cpp.

(WebCore::isHexDigit):
(WebCore::unconsumeCharacters):
(WebCore::consumeCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.cpp: Added.

(WebCore::consumeXMLCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.h: Added.
12:51 Changeset [91024] by loislo@chromium.org

Reviewed by Pavel Feldman.

Web Inspector: panel switching is too slow.
https://bugs.webkit.org/show_bug.cgi?id=60959

  • inspector/front-end/inspector.css:

(.panel):
(.panel.visible):

12:32 Changeset [91023] by commit-queue@webkit.org

NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Reviewed by Ojan Vafai.

This should fix the bug. Unfortunately this code is currently
impossible to test since it's impossible to mock detect_scm_system at the
moment. I started re-writing scm.detection.py to be mockable, but decided that
was best left for another day.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
12:31 Changeset [91022] by commit-queue@webkit.org

DFG speculative JIT contains a FIXME for rewinding speculative code generation that
has already been fixed.
https://bugs.webkit.org/show_bug.cgi?id=64022

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

12:24 Changeset [91021] by ojan@chromium.org

fix coding style of dashboard_base.js
https://bugs.webkit.org/show_bug.cgi?id=64545

Reviewed by Adam Roben.

The code changes to the files other than dashboard_base.js
are just fallout from renaming globals in dashboard_base.js.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
11:28 Changeset [91020] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
11:23 Changeset [91019] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [91018] by ryuan.choi@samsung.com

[EFL] Add OwnPtr specialization for Ecore_Pipe.
https://bugs.webkit.org/show_bug.cgi?id=64515

Add an overload for deleteOwnedPtr(Ecore_Pipe*) on EFL port.

Reviewed by Xan Lopez.

  • wtf/OwnPtrCommon.h:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):

10:57 Changeset [91017] by caseq@chromium.org

Web Inspector: remove more unused CSS from inspector.css
https://bugs.webkit.org/show_bug.cgi?id=64529

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:
10:52 Changeset [91016] by carlosgc@webkit.org

Reviewed by Anders Carlsson.

[UNIX] Allow sending null handles in messages
https://bugs.webkit.org/show_bug.cgi?id=60621

Only valid file descriptors are now sent using sendmsg() control
messages, and instead of sending a list of attachment sizes we now
send a list of AttachmentInfo structs. AttachmentInfo contains
information about the attachments including the size for
MappedMemory attachmens and whether the attachment is null or not.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::AttachmentInfo::AttachmentInfo): New class containing
information about the attachments sent.
(CoreIPC::AttachmentInfo::setType): Set the attachment type.
(CoreIPC::AttachmentInfo::getType): Return the attachment type.
(CoreIPC::AttachmentInfo::setSize): Set the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::getSize): Get the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::setNull): Set attachment as null, it
contains an invalid file descriptor, so the receiver shouldn't
expect a file desriptor for this attachment.
(CoreIPC::AttachmentInfo::isNull): Return whether attachment is
null, it contains an invalid file descriptor.
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

10:49 Changeset [91015] by carlosgc@webkit.org

Reviewed by Martin Robinson.

[GTK] Implement Plugin Process
https://bugs.webkit.org/show_bug.cgi?id=60546

.:

  • configure.ac: Always check for gtk2 when building the plugin

process.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • PluginProcess/gtk/PluginProcessMainGtk.cpp: Added.

(WebKit::PluginProcessMainGtk):

  • PluginProcess/gtk/PluginProcessMainGtk.h: Added.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::moduleMixesGtkSymbols):

  • gtk/PluginMainGtk.cpp: Added.

(main):

10:45 Changeset [91014] by rniwa@webkit.org

Move subtreeHasChanged from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64476

Reviewed by Kent Tamura.

Moved subtreeHasChanged from RenderTextControl, RenderTextControlSingleLine, and
RenderTextControlMultiLine to HTMLTextFormControlElement, HTMLInputElement, and
HTMLTextAreaElement. Also moved m_searchEventTimer and related functions from
RenderTextSingleLine to SearchInputType.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): Moved from RenderTextControlSingleLine.
(WebCore::HTMLInputElement::onSearch): Calls stopSearchEventTimer.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::subtreeHasChanged): Moved from RenderTextMultiLine.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::defaultEventHandler): Calls subtreeHasChanged.
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Added; calls respondToChangeByUser.

  • html/HTMLTextFormControlElement.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType): Initializes m_searchEventTimer.
(WebCore::SearchInputType::startSearchEventTimer): Moved from RenderTextControlSingleLine.
(WebCore::SearchInputType::stopSearchEventTimer): Ditto.
(WebCore::SearchInputType::searchEventTimerFired): Ditto.

  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Updated comment.

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:

(WebCore::RenderTextControl::respondToChangeByUser): Renamed from subtreeHasChanged.

  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): No longer initializes
m_searchEventTimer.

  • rendering/RenderTextControlSingleLine.h:
10:44 Changeset [91013] by carlosgc@webkit.org

Reviewed by Anders Carlsson.

Implement plugin process for UNIX platform
https://bugs.webkit.org/show_bug.cgi?id=60629

  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/unix/AttachmentUnix.cpp:

(CoreIPC::Attachment::Attachment): Add the ability to pass a
socket via Attachment.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::encode): Remove assertions that
check that the Handle is not null. In
PluginProxy::geometryDidChange we pass a null Handle if we do not
need to allocate a new backing store.
(WebKit::SharedMemory::Handle::releaseToAttachment): Ditto.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection): Use
Attachment. Set up the connection with socketpair.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Use Attachment to pass the connection.

10:42 Changeset [91012] by adachan@apple.com

Implement support to center selection on a page for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=64481

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp: (WKPageCenterSelectionInVisibleArea): Added. Call WebPageProxy::centerSelectionInVisibleArea().
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::centerSelectionInVisibleArea): Send message to the WebProcess to center selection.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::centerSelectionInVisibleArea): Get the FrameSelection from the main frame and call revealSelection() to center it.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add the CenterSelectionInVisibleArea message.
10:40 Changeset [91011] by carlosgc@webkit.org

2011-07-14 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r90953.

  • WebKitTestRunner/GNUmakefile.am:
10:32 Changeset [91010] by commit-queue@webkit.org

DFG JIT unnecessarily boxes and unboxes values during silent spilling.
https://bugs.webkit.org/show_bug.cgi?id=64068

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Silent spilling and filling of registers is done during slow-path C
function calls. The silent spill/fill logic does not affect register
allocation on paths that don't involve the C function call.

This changes the silent spilling code to spill in unboxed form. The
silent fill will refill in whatever form the register was spilled in.
For example, the silent spill code may choose not to spill the register
because it was already spilled previously, which would imply that it
was spilled in boxed form. The filling code detects this and either
unboxes, or not, depending on what is appropriate.

This change also results in a simplification of the silent spill/fill
API: silent spilling no longer needs to know about the set of registers
that cannot be trampled, since it never does boxing and hence does not
need a temporary register.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:24 Changeset [91009] by abarth@webkit.org

garden-o-matic results pane should be more discoverable
https://bugs.webkit.org/show_bug.cgi?id=64513

Reviewed by Eric Seidel.

This patch causes us to trigger the results pane on mouse clicks
instead of mousein. Also, handle the case of no results details more
elegantly.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Change the binding to "click".
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Handle the "no results URLs" case explicitly instead of never calling the callback.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • Show a message when there are no result details to show.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
10:15 Changeset [91008] by vsevik@chromium.org

Move XML errors handling out from XMLDocumentParser (refactoring).
https://bugs.webkit.org/show_bug.cgi?id=64305

XML errors handling logic is moved out from XMLDocumentParser to allow using it for XSLT error handling as well.

Reviewed by Adam Barth.

No tests needed as there is no new functionality added.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/XMLErrors.cpp: Added.

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/XMLErrors.h: Added.
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::error):
(WebCore::warningHandler):
(WebCore::fatalErrorHandler):
(WebCore::normalErrorHandler):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseDtd):

10:09 Changeset [91007] by abarth@webkit.org

garden-o-matic should badge TIMEOUT failures
https://bugs.webkit.org/show_bug.cgi?id=64435

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:

(.regression .what a[draggable].TIMEOUT::before):

  • Add TIMEOUT.
09:59 Changeset [91006] by vsevik@chromium.org

Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache.
https://bugs.webkit.org/show_bug.cgi?id=64356

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):

  • loader/FrameLoader.h:
09:57 Changeset [91005] by commit-queue@webkit.org

Clear SVGElementInstance's children immediately upon detachment
https://bugs.webkit.org/show_bug.cgi?id=63739
<rdar://problem/9705708>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-14
Reviewed by Nikolas Zimmermann.

In addition to clearing the instance's children in the destructor,
clear them when the instance is detached from its <use>. This way,
we won't attempt to use them after we're detached but before the
destructor has been called.

Source/WebCore:

Test: svg/custom/use-crash-using-children-before-destroy.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):

  • svg/SVGElementInstance.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance):

LayoutTests:

  • svg/custom/use-crash-using-children-before-destroy-expected.txt: Added.
  • svg/custom/use-crash-using-children-before-destroy.svg: Added.
09:42 Changeset [91004] by isherman@chromium.org

Rename AutoFill -> Autofill and autoFill -> autofill
https://bugs.webkit.org/show_bug.cgi?id=64333
http://code.google.com/p/chromium/issues/detail?id=72758

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebAutofillClient.h:

(WebKit::WebAutofillClient::didAcceptAutofillSuggestion):
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
(WebKit::WebAutofillClient::didClearAutofillSelection):
(WebKit::WebAutofillClient::removeAutocompleteSuggestion):
(WebKit::WebAutofillClient::textFieldDidBeginEditing):
(WebKit::WebAutofillClient::textFieldDidEndEditing):
(WebKit::WebAutofillClient::textFieldDidChange):
(WebKit::WebAutofillClient::textFieldDidReceiveKeyDown):
(WebKit::WebAutofillClient::~WebAutofillClient):

  • public/WebNode.h:
  • public/WebView.h:
  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::~AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::selectionCleared):
(WebKit::AutofillPopupMenuClient::itemText):
(WebKit::AutofillPopupMenuClient::itemLabel):
(WebKit::AutofillPopupMenuClient::itemIcon):
(WebKit::AutofillPopupMenuClient::itemIsEnabled):
(WebKit::AutofillPopupMenuClient::itemStyle):
(WebKit::AutofillPopupMenuClient::menuStyle):
(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):
(WebKit::AutofillPopupMenuClient::popupDidHide):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::setTextFromItem):
(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::hostWindow):
(WebKit::AutofillPopupMenuClient::createScrollbar):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
(WebKit::AutofillPopupMenuClient::convertListIndexToInternalIndex):
(WebKit::AutofillPopupMenuClient::getWebView):
(WebKit::AutofillPopupMenuClient::textFieldStyle):

  • src/AutofillPopupMenuClient.h:

(WebKit::AutofillPopupMenuClient::itemToolTip):
(WebKit::AutofillPopupMenuClient::itemAccessibilityText):
(WebKit::AutofillPopupMenuClient::clientInsetLeft):
(WebKit::AutofillPopupMenuClient::clientInsetRight):
(WebKit::AutofillPopupMenuClient::listSize):
(WebKit::AutofillPopupMenuClient::selectedIndex):
(WebKit::AutofillPopupMenuClient::itemIsLabel):
(WebKit::AutofillPopupMenuClient::itemIsSelected):
(WebKit::AutofillPopupMenuClient::shouldPopOver):
(WebKit::AutofillPopupMenuClient::valueShouldChangeOnHotTrack):
(WebKit::AutofillPopupMenuClient::getTextField):
(WebKit::AutofillPopupMenuClient::getSelectedIndex):
(WebKit::AutofillPopupMenuClient::setSelectedIndex):

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doAutofill):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setAutofilled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setAutofillClient):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::autocompleteHandleKeyEvent):
(WebKit::WebViewImpl::hideAutofillPopup):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::hidePopups):
(WebKit::WebViewImpl::refreshAutofillPopup):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::autofillClient):
(WebKit::WebViewImpl::autofillPopupDidHide):

09:29 Changeset [91003] by japhet@chromium.org

Don't skip custom cursors if an Image* is null,
since this can lead to a non-custom Cursor flickering
back in when the custom cursor hasn't finished loading yet.
https://bugs.webkit.org/show_bug.cgi?id=64321

Reviewed by Darin Fisher.

Manual test, since we're testing visual flickering.

  • manual-tests/canvas-cursor.html: Added.
  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • platform/Cursor.cpp:

(WebCore::determineHotSpot):

09:20 Changeset [91002] by commit-queue@webkit.org

Patch by Young Han Lee <joybro@company100.net> on 2011-07-14
Reviewed by Dirk Schulze.

REGRESSION (r89774): svg/W3C-SVG-1.1/animate-elem-82-t.svg hits assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=63911

Some functions assumed calculateKeyTimesIndex() does not return the last index of
the keyTimes, but it would be right behavior for calculateKeyTimesIndex() when it
accepts 1 as the percent argument.

To avoid the assumption, and for more efficiency, this patch allows the functions
using calculateKeyTimesIndex() to return early when it accepts 1 as the percent argument.
These functions have always returned the last element of the corresponding vector
in that situation.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

09:00 Changeset [91001] by abarth@webkit.org

Fix Python exception blocking the commit-queue.

  • Scripts/webkitpy/common/checkout/scm/git.py:
07:54 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.8.x trunk bot (diff)
07:47 Changeset [91000] by ossy@webkit.org

[Qt]Update layout test results for newer Qt 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=64527

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/[...]: Added.
  • platform/qt-4.8/Skipped: Unskip http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html.
07:39 Changeset [90999] by yurys@chromium.org

[Chromium] Web Inspector: URL parameters should consistently use camel case names
https://bugs.webkit.org/show_bug.cgi?id=64520

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(devtools.domContentLoaded): Now that Chromium side is updated we can remove the old parameter
handling code.

07:04 Changeset [90998] by xan@webkit.org

2011-07-14 Xan Lopez <xlopez@igalia.com>

[GTK] Skip one crashing test in GTK+/debug bots.

  • platform/gtk/Skipped:
06:56 Changeset [90997] by xan@webkit.org

2011-07-14 Xan Lopez <xlopez@igalia.com>

[GTK] Skip one crashing test in GTK+/debug bots.

  • platform/gtk/Skipped:
06:36 Changeset [90996] by caseq@chromium.org

2011-07-14 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=64524

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • inspector/front-end/SummaryBar.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
06:36 Changeset [90995] by ossy@webkit.org

[Qt]svg/animations/svgtransform-animation-1.html asserts intermittently
https://bugs.webkit.org/show_bug.cgi?id=64526

  • platform/qt/test_expectations.txt: Mark the test as flakey crash.
06:30 Changeset [90994] by kov@webkit.org

[GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.
https://bugs.webkit.org/show_bug.cgi?id=62935

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-07-14
Reviewed by Gustavo Noronha.

WebKit can be build with WEBKITOUTPUTDIR env variable set using build-webkit script.
In this case WEBKITOUTPUDIR may be outside repository structure. This causes testmimehandling and testwebview
to fail because they use external test files in WebKit Source directory.
This bug fixes this issue introducing optional environment variable WEBKITREPODIR
Also coding style in existing functions is fixed.

  • tests/test_utils.c: Coding style fixes.

(testutils_relative_chdir): If WEBKITREPODIR is set, change current directory to it.

  • tests/test_utils.h: Coding style fixes.
06:28 Changeset [90993] by podivilov@chromium.org

Web Inspector: add test for css live edit.
https://bugs.webkit.org/show_bug.cgi?id=64454

Reviewed by Pavel Feldman.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.showResource):

  • http/tests/inspector/live-edit-test.js: Added.

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

  • inspector/debugger/live-edit.html:
  • inspector/styles/css-live-edit-expected.txt: Added.
  • inspector/styles/css-live-edit.html: Added.
05:15 Changeset [90992] by yutak@chromium.org

WebSocket: Add platform-specific test results for hybi tests
https://bugs.webkit.org/show_bug.cgi?id=64349

Reviewed by Kent Tamura.

These results are identical to ones in hixie76/ directory.

  • platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt: Added.
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt: Added.
  • platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
04:05 Changeset [90991] by pvarga@webkit.org

[Qt][V8] Build fix after r90830.

Reviewed by Csaba Osztrogonác.

The histogramEnumeration() function isn't available from the Qt port's
PlatformBridge.h because this function is Chromium specific.
Since the http://trac.webkit.org/changeset/90830 change we need to
guard the usage of the histogramEnumeration() function.

No new tests needed.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

03:06 Changeset [90990] by yurys@chromium.org

[Chromium] Web Inspector: URL parameters should consistently use camel case names
https://bugs.webkit.org/show_bug.cgi?id=64520

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(devtools.domContentLoaded):

02:47 Changeset [90989] by ossy@webkit.org

[Qt] Update platform specific expected results after r90971.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/password-placeholder-expected.png: Added.
  • platform/qt/fast/forms/password-placeholder-expected.txt:
  • platform/qt/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/qt/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/qt/fast/forms/placeholder-set-attribute-expected.png: Added.
  • platform/qt/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/placeholder-stripped-expected.png:
  • platform/qt/fast/forms/placeholder-stripped-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/test_expectations.txt:
02:16 Changeset [90988] by yurys@chromium.org

Web Inspector: show only Console and Scripts panels in shared worker inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=64519

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):
(WebInspector.WorkerManager.isWorkerFrontend):
(WebInspector.WorkerManager.isSharedWorkerFrontend):
(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.DedicatedWorkerMessageForwarder):

02:00 Changeset [90987] by morrita@google.com

Unreviewed, rolling out r90976, r90981, and r90985.
http://trac.webkit.org/changeset/90976
http://trac.webkit.org/changeset/90981
http://trac.webkit.org/changeset/90985
https://bugs.webkit.org/show_bug.cgi?id=64251

build break

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):
(WebCore::ShadowContentSelector::willAttachContentFor):
(WebCore::ShadowContentSelector::didAttachContent):
(WebCore::ShadowContentSelector::activeElement):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::activeContentElement):

  • dom/ShadowRoot.h:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/content-element-includer-expected.txt: Removed.
  • fast/dom/shadow/content-element-includer.html: Removed.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
01:54 Changeset [90986] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/test_expectations.txt: Remove a passing test.
01:08 Changeset [90985] by morrita@google.com

Unreviewed attempt to build fix.

  • Source/autotools/symbols.filter:
00:26 Changeset [90984] by tkent@chromium.org

[Chromium] Make an entry for input-appearance-range.html specific.

  • platform/chromium/test_expectations.txt:
00:08 Changeset [90983] by rniwa@webkit.org

Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64475

Reviewed by Kent Tamura.

Moved forwardEvent from RenderTextControl, RenderTextControlSingleLine, and RenderTextControlMultiLine
to HTMLTextFormControlElement, HTMLInputElement, and HTMLTextAreaElement.

This removes the last dependency on Event.h and EventNames.h in the cpp files for the above render
objects classes.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::forwardEvent):

  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:

07/13/11:

23:27 Changeset [90982] by ossy@webkit.org

[Qt] Add platform specific expected result for a new test.

  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
23:23 Changeset [90981] by morrita@google.com

Unreviewed attempt at a build fix.

  • win/WebKit2CFLite.def:
22:54 Changeset [90980] by loislo@chromium.org

Web Inspector: if you rename an element into the INPUT element the browser will crash.
https://bugs.webkit.org/show_bug.cgi?id=64292

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeName):
Unnecessary function call copyNonAttributeProperties was removed.

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
22:32 Changeset [90979] by yutak@chromium.org

WebSocket: Implement hybi handshake
https://bugs.webkit.org/show_bug.cgi?id=64344

Reviewed by Kent Tamura.

Source/WebCore:

Implement WebSocket handshake which is described at
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-5.1>.

Notable differences from hixie-76 protocol are:

  • Challenge-response scheme has been changed dramatically.
  • Servers do not send Sec-WebSocket-Location and Sec-WebSocket-Origin anymore.
  • The value of "Upgrade" header has been changed to "websocket" (lower-case only).
  • "Origin" header in client's request is renamed to "Sec-WebSocket-Origin".

New tests: http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html

http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html
http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html

Note: Tests under hybi/ directory (including the new ones) are skipped and cannot be enabled
yet, because pywebsocket does not accept requests from half-baked client implementation
(i.e. hybi handshake + hixie-76 framing). They will be unskipped when hybi framing is landed
in WebCore.

  • websockets/WebSocketHandshake.cpp:

Functions and members only used for hixie-76 handshake are renamed so that they are not confused
with hybi-10's ones.
(WebCore::generateHixie76SecWebSocketKey):
(WebCore::generateHixie76Key3):
(WebCore::generateHixie76ExpectedChallengeResponse):
(WebCore::generateSecWebSocketKey):
Generates a value for Sec-WebSocket-Key as stated in hybi-10.
(WebCore::getExpectedWebSocketAccept):
Calculates the expected value of Sec-WebSocket-Accept.
(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::serverWebSocketAccept):
(WebCore::WebSocketHandshake::serverWebSocketExtensions):
(WebCore::WebSocketHandshake::checkResponseHeaders):

  • websockets/WebSocketHandshake.h:

LayoutTests:

Fix existing tests so they match the new handshake format, and add tests for new header fields.

There are several changes in the format of handshake response, such as:

  • Reason string in HTTP status line has been changed to "Switching Protocols".
  • The value of "Upgrade" header has been changed to "websocket" (lower-case only).
  • Sec-WebSocket-Location and Sec-WebSocket-Origin are gone.
  • "Challenge response" value (16-byte data after the response header fields) is removed, and Sec-WebSocket-Accept header is added instead.

The value of Sec-WebSocket-Accept header is computed using compute_accept() function
located in mod_pywebsocket.handshake.hybi06 module. Although the module name contains
"hybi06", this function can be used to calculate the value of Sec-WebSocket-Accept header
for hybi-10 (calculation method has not been changed since hybi-06).

Note: Tests under hybi/ directory (including the new ones) are skipped and cannot be enabled
yet, because pywebsocket does not accept requests from half-baked client implementation
(i.e. hybi handshake + hixie-76 framing). They will be unskipped when hybi framing is landed
in WebCore.

  • http/tests/websocket/tests/handler_map.txt:

There must be only one handler that can handle requests to "/". hybi/echo-location_wsh.py
is modified to accept requests of both protocol versions.

  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/echo-challenge_wsh.py:
  • http/tests/websocket/tests/hybi/echo-location_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/workers/resources/echo-challenge_wsh.py:
22:05 Changeset [90978] by commit-queue@webkit.org

Move webkitpy off of loose mocks
https://bugs.webkit.org/show_bug.cgi?id=64508

Reviewed by Adam Barth.

Using Mock has caused us more pain than help.
It's possible that there was a cleaner way to use it
(maybe Mock(class) instead of inheriting from it?).
But for now, I've removed all uses of Mock from mocktool.py.

I also moved run_command into the only 3 files which call it
instead of leaving the deprecated method in executive.py.

I changed various direct calls to os.* to use filesystem instead.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
21:13 Changeset [90977] by commit-queue@webkit.org

NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Reviewed by Adam Barth.

Add a warning message in the revision= case to help us diagnose
what's going wrong on the bot.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
20:39 Changeset [90976] by morrita@google.com

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

  • Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
  • Updated the set on inclusion list changes.
  • Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

  • Renamed NodeRenderingContext::m_contentElement to m_includer
  • ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

  • dom/ShadowContentElement.cpp:

(WebCore::removeFromSet): Added
(WebCore::addToSet): Added
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor): Replaced activeElement()
(WebCore::ShadowRoot::inclusions): Added
(WebCore::ShadowRoot::ensureInclusions): Added

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

  • win/WebKit2.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Added a new test.
  • Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.
  • fast/dom/shadow/content-element-includer-expected.txt: Added.
  • fast/dom/shadow/content-element-includer.html: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
19:48 Changeset [90975] by scheib@chromium.org

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
19:40 Changeset [90974] by tkent@chromium.org

[Qt] Remove duplicated entries.

  • platform/qt/test_expectations.txt:
19:32 Changeset [90973] by dpranke@chromium.org

new-run-webkit-tests: print baseline search path as part of config output
https://bugs.webkit.org/show_bug.cgi?id=64499

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
19:25 Changeset [90972] by dominicc@chromium.org

Raise if dispatchEvent dispatches an event that is being dispatched
https://bugs.webkit.org/show_bug.cgi?id=64150

Reviewed by Dimitri Glazkov.

Source/WebCore:

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-EventTarget-dispatchEvent

Test: fast/events/dispatch-event-being-dispatched.html

  • dom/Event.h:

(WebCore::Event::isBeingDispatched): Added.

  • dom/EventException.h:
  • dom/EventException.idl: Add DISPATCH_REQUEST_ERR.
  • dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEvent): Raise if being dispatched.

  • dom/ExceptionCode.cpp: Add gunk for DISPATCH_REQUEST_ERR.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt: Added DISPATCH_REQUEST_ERR.
  • fast/events/dispatch-event-being-dispatched-expected.txt: Added.
  • fast/events/dispatch-event-being-dispatched.html: Added.
  • fast/workers/resources/worker-event-listener.js:

(onmessage): Redispatching the MessageEvent throws an exception now.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
19:16 Changeset [90971] by tkent@chromium.org

Implement text field placeholders using shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=64253

Reviewed by Dimitri Glazkov.

Source/WebCore:

Represents a placeholder text as a shadow element, and its
visibility is controlled by 'visibility' CSS property.

This patch removes all of existing code about placeholder from
RenderTextControl*. RenderTextControl* have only small code about
placeholder layout.

Also, this patch removes INPUT_PLACEHOLDER legacy pseudo ID, and
the placeholder style uses Element::shadowPseudoId().

This fixes the following regressions:

Test: fast/forms/textarea-placeholder-wrapping.html

  • css/CSSSelector.cpp: Remove INPUT_PLACEHOLDER legacy pseudo ID.

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h: ditto.
  • css/html.css:

(::-webkit-input-placeholder): Added. This contains properties
common in <input> and <textarea>. Some properties have !important
so that a stylesheet specified by a page author won't break
WebKit's assumption.
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

Added the default style for <input> placeholders.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::placeholderElement): Delegate to an InputType.
(WebCore::HTMLInputElement::updatePlaceholderText): ditto.

  • html/HTMLInputElement.h: Declare placeholderElement() and updatePlaceholderText().
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createRenderer):
Remove the 'placeholderVisible' argument.
(WebCore::HTMLTextAreaElement::placeholderElement): Added.
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

Added. This creates, deletes, or updates the placeholder element.

  • html/HTMLTextAreaElement.h:
  • Declare placeholderElement() and updatePlaceholderText().
  • Add m_placeholder.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
Update the placeholder element and 'visibility' CSS property,
instead of delegating the job to a renderer.

  • html/HTMLTextFormControlElement.h:

Declare two pure virtual functions: placeholderElement() and updatePlaceholderText().

  • html/InputType.cpp:

(WebCore::InputType::placeholderElement): Add an empty implementation.
(WebCore::InputType::updatePlaceholderText): Add an empty implementation.

  • html/InputType.h: Declare placeholderElement() and updatePlaceholderText().
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createRenderer):
Remove the 'placeholderVisible' argument.
(WebCore::TextFieldInputType::placeholderElement): Added.
(WebCore::TextFieldInputType::destroyShadowSubtree): Deletes m_placeholder.
(WebCore::TextFieldInputType::updatePlaceholderText):

Added. This creates, deletes, or updates the placeholder element.

  • html/TextFieldInputType.h:
  • Declare placeholderElement() and updatePlaceholderText().
  • Add m_placeholder.
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Excludes the placeholder renderer in order to avoid to secure a box for
the placeholder.

  • rendering/RenderTextControl.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControl signature.
  • Add layoutSpecialExcludedChild().
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild):
Laying out the placeholder box so that it has correct width and location.

  • rendering/RenderTextControlMultiLine.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControlMultiLine signature.
  • Add layoutSpecialExcludedChild().
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
Remove the 'placeholderVisible' argument.
(WebCore::RenderTextControlSingleLine::layout):
Laying out the placeholder box so that it has correct width and location.

  • rendering/RenderTextControlSingleLine.h:
  • Remove declarations of removed functions.
  • Update the RenderTextControlSingleLine signature.
  • rendering/style/RenderStyleConstants.h: Remove INPUT_PLACEHOLDER.

LayoutTests:

Add some test cases, and update expectations because placeholders
have their renderers.

  • fast/forms/input-placeholder-text-indent.html: Remove an obsolete comment. A placeholder respects a percentage indent.
  • fast/forms/placeholder-position.html: Add tests for line-height and text-align.
  • fast/forms/textarea-placeholder-wrapping.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.png:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-stripped-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.png:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/mac/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/qt/test_expectations.txt:
19:05 Changeset [90970] by simonjam@chromium.org

Remove hack that forcefully prevents scripts from running in shadow SVG
https://bugs.webkit.org/show_bug.cgi?id=64419

This hack was put in to prevent scripts from running in shadow SVG. This should never have
happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
r88584, so the hack is no longer needed.

No new tests since there is no change in functionality.

Reviewed by Tony Gentilcore.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

18:46 Changeset [90969] by commit-queue@webkit.org

[chromium] Clean undeeded WebCore:: namespace prefixing from WebBindings.
https://bugs.webkit.org/show_bug.cgi?id=64361

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-13
Reviewed by Kent Tamura.

  • src/WebBindings.cpp:

(WebKit::makeIntArrayImpl):
(WebKit::makeStringArrayImpl):

18:39 Changeset [90968] by abarth@webkit.org

gardening server should have an API for parsing changelogs
https://bugs.webkit.org/show_bug.cgi?id=64495

Reviewed by Eric Seidel.

This patch exposes much of the same information from CommitInfo in a
dictionary form, which is easier to send over-the-wire as JSON to the
frontend.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
18:03 Changeset [90967] by commit-queue@webkit.org

REGRESSION: GitTestWithMock.test_create_patch fails
https://bugs.webkit.org/show_bug.cgi?id=62945

Reviewed by Daniel Bates.

I was not able to reproduce the exact failure seen in the bug,
however this test was failing on my machine for other reasons.

I went through and did an audit of our run_command usage, it's
entirely in scm classes after this change. (Not surprising given
that scm.py was the second file ever created in webkit.py.)

The real bug I'm fixing here is that we were setting executive.should_log
when the value had changed to executive._should_log. Now we set the right one
and the test works again.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
17:29 Changeset [90966] by commit-queue@webkit.org

[CSSRegions] Parse -webkit-content-order property
https://bugs.webkit.org/show_bug.cgi?id=63897

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-content-order-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionIndex):
(WebCore::InheritedFlags::setRegionIndex):
(WebCore::InheritedFlags::initialRegionIndex):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/regions/script-tests/webkit-content-order-parsing.js: Added.
  • fast/regions/webkit-content-order-parsing-expected.txt: Added.
  • fast/regions/webkit-content-order-parsing.html: Added.
16:45 Changeset [90965] by isherman@chromium.org

Fix WTF header guard style check
https://bugs.webkit.org/show_bug.cgi?id=64488

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
16:31 Changeset [90964] by ojan@chromium.org

bring flakiness_dashboard.html closer to webkit style
https://bugs.webkit.org/show_bug.cgi?id=64477

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/dashboard_base.js:

Fix bad variable name that would hit only when running the tests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:

No code/logic changes. All moving/removing brackets, indents and moving things
to one line.

16:14 Changeset [90963] by commit-queue@webkit.org

Patch by James Robinson <jamesr@chromium.org> on 2011-07-13
Reviewed by Kenneth Russell.

[chromium] Move draw implementation for ContentLayerChromium/ImageLayerChromium to the appropriate CCLayerImpl subclass
https://bugs.webkit.org/show_bug.cgi?id=58833

Adds a TiledLayerChromium class to handle the tiling logic shared by ContentLayerChromium and ImageLayerChromium
so that they can be siblings in the class hierarchy instead of children. Also adds a CCTiledLayerImpl to handle
the drawing responsibilities for tiled layers.

TiledLayerChromium maintains a tiler, tiling options, and calculates the tiling transform. Subclasses are
responsible for providing an appropriate texture updater implementation. CCTiledLayerImpl takes the tiler,
tiling transform and layer properties and draws the layer. Longer term it'd be better of the CCTiledLayerImpl
owned the tiler and the TiledLayerChromium only owned an updater, but getting there will require changing the
way tile eviction works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::textureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::cleanupResources):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::textureUpdater):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Added.

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::~TiledLayerChromium):
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setLayerRenderer):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::setIsMask):
(WebCore::TiledLayerChromium::tilingTransform):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/TiledLayerChromium.h: Added.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::drawsContent):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Added.

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::~CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Added.

(WebCore::CCTiledLayerImpl::create):
(WebCore::CCTiledLayerImpl::setTilingTransform):
(WebCore::CCTiledLayerImpl::setTiler):

16:05 Changeset [90962] by msaboff@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64202
Enh: Improve handling of RegExp in the form of /.*blah.*/

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/src/webkit/LayoutTests:

New tests to support /.*<expression>.*/ enhancement.

  • fast/regex/dotstar-expected.txt: Added.
  • fast/regex/dotstar.html: Added.
  • fast/regex/script-tests/dotstar.js: Added.

../../../../Volumes/Data/src/webkit/Source/JavaScriptCore:

Added code to both the Yarr interpreter and JIT to handle
these expressions a little differently. First off, the terms
in between the leading and trailing .*'s cannot capture and
also this enhancement is limited to single alternative expressions.
If an expression is of the right form with the aforementioned
restrictions, we process the inner terms and then look for the
beginning of the string and end of the string. There is handling
for multiline expressions to allow the beginning and end to be
right after and right before newlines.

This enhancement speeds up expressions of this type 12x on
a MacBookPro.

Cleaned up 'case' statement indentation.

A new set of tests was added as LayoutTests/fast/regex/dotstar.html

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::end):
(JSC::Yarr::Interpreter::matchDotStarEnclosure):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::assertionDotStarEnclosure):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::ByteTerm::DotStarEnclosure):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::backtrackDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
(JSC::Yarr::YarrPattern::compile):

  • yarr/YarrPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm):

16:00 Changeset [90961] by jchaffraix@webkit.org

Remove an unused bit in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=64485

Reviewed by Darin Adler.

No change in behavior so no new test.

  • rendering/RenderObject.h: Removed a bit that was duplicated from RenderTableCell.

However it was not used in RenderObject and RenderTableCell already packed this bit.
We were lying in the number of used bits in RenderObject which was 33. This change
brings us back to what was advertised.

15:57 Changeset [90960] by scheib@chromium.org

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:56 Changeset [90959] by simon.fraser@apple.com

2011-07-13 Simon Fraser <simon.fraser@apple.com>

Fix non-debug builds.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer):
15:50 Changeset [90958] by scheib@chromium.org

Unreviewed, rolling out r90957.
http://trac.webkit.org/changeset/90957

Fixing incorrect test expectations

  • platform/chromium/test_expectations.txt:
15:46 Changeset [90957] by scheib@chromium.org

[chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:27 Changeset [90956] by vitalyr@chromium.org

2011-07-13 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Fix mac build after r90949.

  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::hiddenReferenceName):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
15:24 Changeset [90955] by eae@chromium.org

Switch table rendering to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64478

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h:
  • rendering/HitTestResult.cpp:
  • rendering/HitTestResult.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
14:57 Changeset [90954] by simon.fraser@apple.com

2011-07-13 Simon Fraser <simon.fraser@apple.com>

Factor some GraphicsLayer creation code in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=64487

Reviewed by Sam Weinig.

Move the GraphicsLayer::create() calls into once place so that we
don't have lots of #ifndef NDEBUG in various places, and can share
more code in future.

No behavior change, so no new tests.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayers): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateOverflowControlsLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer):
  • rendering/RenderLayerBacking.h:
14:55 Changeset [90953] by xan@webkit.org

Tools:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck

Reviewed by Martin Robinson.

  • WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.

WebCore:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck.

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: add missing files.

JavaScriptCore:

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Fix distcheck

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: add missing files.
14:51 Changeset [90952] by jamesr@google.com

[chromium] No implementation defined for WTF::monotonicallyIncreasingTime
https://bugs.webkit.org/show_bug.cgi?id=64420

Reviewed by Tony Gentilcore.

Source/WebCore:

Removes some redundant time related code.

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SystemTimeChromium.cpp:

(WebCore::userIdleTime):

Source/WebKit/chromium:

Provides an implementation of WTF::monotonicallyIncreasingTime() alongside the implementation of
WTF::currentTime().

  • src/ChromiumCurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):

  • src/PlatformBridge.cpp:
14:45 Changeset [90951] by joepeck@webkit.org

Unreviewed fix. Add a "\n" to a printf that somehow got lost.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
14:44 Changeset [90950] by commit-queue@webkit.org

DFG JIT does not implement prototype chain or list caching for get_by_id.
https://bugs.webkit.org/show_bug.cgi?id=64147

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-13
Reviewed by Gavin Barraclough.

This implements unified support for prototype caching, prototype chain
caching, and polymorphic (i.e. list) prototype and prototype chain
caching. This is done by creating common code for emitting prototype
or chain access stubs, and having it factored out into
generateProtoChainAccessStub(). This function is called by
tryCacheGetByID once the latter determines that some form of prototype
access caching is necessary (i.e. the slot being accessed is not on the
base value but on some other object).

Direct prototype list, and prototype chain list, caching is implemented by
linking the slow path to operationGetByIdProtoBuildList(), which uses the
same helper function (generateProtoChainAccessStub()) as tryCacheGetByID.

This change required ensuring that the value in the scratchGPR field in
StructureStubInfo is preserved even after the stub info is in the
chain, or proto_list, states. Hence scratchGPR was moved out of the union
and into the top-level of StructureStubInfo.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::dfgBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGRepatch.h:
14:44 Changeset [90949] by vitalyr@chromium.org

2011-07-13 Vitaly Repeshko <vitalyr@chromium.org>

[V8] Avoid memory leaks with hidden references.
https://bugs.webkit.org/show_bug.cgi?id=64467

Reviewed by Adam Barth.

We used to have growing arrays of hidden references associated
with objects. The entries in this array had no keys and were never
removed. This patch changes the interface to require a reference
name. This way it's harder to leak an unbounded number of
objects. Also it makes our wrapper objects one machine word
smaller.

14:40 Changeset [90948] by joepeck@webkit.org

Improve names of some ApplicationCacheStorage accessor methods
https://bugs.webkit.org/show_bug.cgi?id=64433

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Some methods returned a bool for success/failure and
actually returned a value as an out parameter so their
name was confusing. Rename these methods to make them
more clear.

(WebCore::ApplicationCache::diskUsageForOrigin):

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::calculateQuotaForOrigin): (WebCore::ApplicationCacheStorage::calculateUsageForOrigin): (WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache): (WebCore::ApplicationCacheStorage::checkOriginQuota):
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/ApplicationCache.cpp: Rename the methods.
  • WebCore.exp.in: Replaced old versions. Also, calculateRemaining wasn't needed outside WebCore, so no longer export it.
14:40 Changeset [90947] by joepeck@webkit.org

Some ApplicationCache Origin Cleanup
https://bugs.webkit.org/show_bug.cgi?id=64431

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

  • m_loadedSize is inaccurate. This just replaces it with calls to ApplicationCache::estimatedSizeInStorage.
  • m_availableSpaceInQuota can get out of date, so we just recalculate it at the start of appcache downloads.
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didReceiveData): Remove references to m_loadedSize.

(WebCore::ApplicationCacheGroup::didFinishLoading):
Replace m_loadedSize with estimatedSizeInStorage after we
add the new cached resource to the cache. The calculation
already happened so this check is fast.

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
When we start the Downloading phase, recalculate the quota
so that we have an up to date quota value so that we can
break early if needed.

14:40 Changeset [90946] by joepeck@webkit.org

ApplicationCache Quota Output is Flakey
https://bugs.webkit.org/show_bug.cgi?id=64410

Reviewed by Alexey Proskuryakov.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Have the tests truncate the number of bytes needed in
the delegate callback to get an approximation of how
much space was needed.

  • http/tests/appcache/origin-quota-continued-download-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests.html:
  • http/tests/appcache/origin-quota-expected.txt: Update the output and clarify what the multiple-manifests test is looking for in the space needed output.
  • platform/mac/Skipped:
  • platform/qt/Skipped: Unskip the tests.

2011-07-13 Joseph Pecoraro <joepeck@webkit.org>

Unify the delegate logging for reaching application cache
quotas. Truncate the space needed to the nearest 10000
for less flakey test output. This also better supports
printing NSUInteger on non-64 bit systems by casting to
an unsigned long.

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
13:55 Changeset [90945] by jamesr@google.com

[chromium] Update chromium gpu expectations.

  • platform/chromium/test_expectations.txt:
12:52 Changeset [90944] by dglazkov@chromium.org

[Chromium] Prettify spacing in test_expectations.txt

  • platform/chromium/test_expectations.txt: Ran through the new parser/serializer code.
12:41 Changeset [90943] by dglazkov@chromium.org

Remove unused TestExpectations._overrides.
https://bugs.webkit.org/show_bug.cgi?id=64470

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
12:40 Changeset [90942] by dglazkov@chromium.org

Introduce TestExpectationSerializer.list_to_string.
https://bugs.webkit.org/show_bug.cgi?id=64462

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
12:36 Changeset [90941] by dglazkov@chromium.org

Consolidate expectations parsing code.
https://bugs.webkit.org/show_bug.cgi?id=64460

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
12:31 Changeset [90940] by bfulgham@webkit.org

Standardize WinCairo conditionalized code under PLATFORM macro.
https://bugs.webkit.org/show_bug.cgi?id=64377

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Update to use PLATFORM(WIN_CAIRO) for tests.

Source/WebCore:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

  • WebCore.vcproj/WebCoreCairo.vsprops: Remove redundant declaration of WIN_CAIRO.
  • WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Update to use the existing WinCairo.vsprops file.
  • WebCorePrefix.h: Update for new WTF_PLATFORM_WIN_CAIRO define.
  • config.h: Update to use PLATFORM(WIN_CAIRO).

Tools:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

  • DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant define of WIN_CAIRO=1.
  • DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add WinCairo.vsprops to set (to match Release build).

WebKitLibraries:

  • win/tools/vsprops/WinCairo.vsprops: Update to comply with PLATFORM macro definition (WTF_PLATFORM_WIN_CAIRO)
12:19 Changeset [90939] by levin@chromium.org

Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
https://bugs.webkit.org/show_bug.cgi?id=64465

Reviewed by Dmitry Titov.

There isn't a good way to test this as it is very highly unlikely to occur.

Source/JavaScriptCore:

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
isn't thread-safe, change the initialization to be global.

Source/WebKit2:

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::shouldCallRealDebugger): :Since scoped static initialization
isn't thread-safe, change the initialization to be global.

11:59 Changeset [90938] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64424
Our direct eval behaviour deviates slightly from the spec.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The ES5 spec defines a concept of 'Direct Call to Eval' (see section 15.1.2.1.1), where
behaviour will differ from that of an indirect call (e.g. " { eval: window.eval }.eval();"
or "var a = eval; a();" are indirect calls), particularly in non-strict scopes variables
may be introduced into the caller's environment.

ES5 direct calls are any call where the callee function is provided by a reference, a base
of that Reference is an EnvironmentRecord (this corresponds to all productions
"PrimaryExpression: Identifier", see 10.2.2.1 GetIdentifierReference), and where the name
of the reference is "eval". This means any expression of the form "eval(...)", and that
calls the standard built in eval method from on the Global Object, is considered to be
direct.

In JavaScriptCore we are currently overly restrictive. We also check that the
EnvironmentRecord that is the base of the reference is the Declaractive Environment Record
at the root of the scope chain, corresponding to the Global Object - an "eval(..)" statement
that hits a var eval in a nested scope is not considered to be direct. This behaviour does
not emanate from the spec, and is incorrect.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Fixed direct eval check in op_call_eval.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Fixed direct eval check in op_call_eval.
  • runtime/Executable.h:

(JSC::isHostFunction):

  • Added check for host function with specific NativeFunction.

LayoutTests:

Correct expected results.

  • fast/js/eval-keyword-vs-function-expected.txt:
  • fast/js/eval-keyword-vs-function.html:
11:56 Changeset [90937] by commit-queue@webkit.org

[CSS Exclusions] Fix for comment #23 on wrap-shape parsing bug 61726
https://bugs.webkit.org/show_bug.cgi?id=64464

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

No new tests needed.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRect): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeCircle): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeEllipse): Removed the "valid" local.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSWrapShapes.h:

(WebCore::CSSWrapShapePolygon::getXAt): Replaced bit shift with multiplication.
(WebCore::CSSWrapShapePolygon::getYAt): Replaced bit shift with multiplication.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
11:51 Changeset [90936] by inferno@chromium.org

Source/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
Reviewed by Adam Barth.

Issue with Frame lifetime due to deletion in beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Copy the Frame protector higher in the stack from loadWithDocumentLoader
to loadFrameRequest since any of loadPostRequest or loadURL can call
loadWithDocumentLoader, thereby dispatching the beforeload event and
blowing away the frame. This deleted frame will be later accessed in
the loadFrameRequest function causing a crash.

Test: fast/events/form-iframe-target-before-load-crash2.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests: Tests that we do not crash when frame is blown away in a beforeload
event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Reviewed by Adam Barth.

  • fast/events/form-iframe-target-before-load-crash.html:
  • fast/events/form-iframe-target-before-load-crash2-expected.txt: Added.
  • fast/events/form-iframe-target-before-load-crash2.html: Added.
11:49 Changeset [90935] by commit-queue@webkit.org

[CSSRegions]content:-webkit-from-flow not applied correctly
https://bugs.webkit.org/show_bug.cgi?id=64438

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

Source/WebCore:

Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).

Test: fast/regions/content-webkit-from-flow-parsing.html (existing).

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getStringValue):

LayoutTests:

Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".

  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:
11:40 Changeset [90934] by dglazkov@chromium.org

Eliminate TestExpectationsFile.
https://bugs.webkit.org/show_bug.cgi?id=64458

Turns out, we can just use a Python list.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,

removed TestExpectationsFile.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,

since there's no more custom iterator machinery.

10:55 Changeset [90933] by rniwa@webkit.org

Don't reuse the last InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=64416

Reviewed by Justin Garcia.

This patch makes the interface of InsertTextCommand less foreign. It now takes arguments in
its constructor and executes the command in doApply like other edit commands.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::applyCommandToComposite): Added.

  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand): Takes arguments input used to take.
(WebCore::InsertTextCommand::doApply): Renamed from input.

  • editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create): Takes arguments input used to take.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertTextRunWithoutNewlines): Creates InsertTextCommand.

10:50 Changeset [90932] by philn@webkit.org

2011-07-13 Philippe Normand <pnormand@igalia.com>

Unreviewed, added my other email addresses.

  • Scripts/webkitpy/common/config/committers.py:
10:49 Changeset [90931] by dslomov@google.com

2011-07-12 Dmitry Lomov <dslomov@google.com>

https://bugs.webkit.org/show_bug.cgi?id=63041
[Chromium][V8] Make DOMDataStore per-isolate
This patch:

  • makes DOMData class an utility class with static members only
  • adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.

Dromaeo benchmarks are not affected.

Reviewed by Adam Barth.

10:36 Changeset [90930] by abarth@webkit.org

Folks should only be listed once.

  • Scripts/webkitpy/common/config/committers.py:
10:10 Changeset [90929] by philn@webkit.org

2011-07-13 Philippe Normand <pnormand@igalia.com>

Unreviewed, adding myself as Reviewer.

  • Scripts/webkitpy/common/config/committers.py:
10:09 Changeset [90928] by abarth@webkit.org

Fix flickering bug introduced by my previous patch. I forgot to change
the name of the class everywhere.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
10:04 Changeset [90927] by philn@webkit.org

[GTK] media/media-blocked-by-willsendrequest.html fails
https://bugs.webkit.org/show_bug.cgi?id=63699

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): Abort the request if explicitely asked by the LayoutTestController's willSendRequestReturnsNull() function.

LayoutTests:

[GTK] media/media-blocked-by-willsendrequest.html fails
https://bugs.webkit.org/show_bug.cgi?id=63699

Reviewed by Martin Robinson.

  • platform/gtk/Skipped: Unskip fixed test.
10:02 Changeset [90926] by abarth@webkit.org

Remove "Dismiss" button from garden-o-matic butterbar
https://bugs.webkit.org/show_bug.cgi?id=64443

Reviewed by Dimitri Glazkov.

We don't have any persistent butter bar messages yet, so the dismiss
button is premature (and fairly heavy, visually).

  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
10:02 Changeset [90925] by simon.fraser@apple.com

2011-07-12 Simon Fraser <simon.fraser@apple.com>

Rename compositing-related updateContentsScale() methods
https://bugs.webkit.org/show_bug.cgi?id=64430

Reviewed by Joseph Pecoraro.

Rename updateContentsScale() to something less presumptuous; layers may choose
to do something other than update their contents scale when the page scale factor
changes. pageScaleFactorChanged() is a better name.

  • page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): (WebCore::Frame::scalePage):
  • page/Frame.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::pageScaleFactorChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::pageScaleFactorChanged):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::pageScaleFactorChanged):
  • rendering/RenderLayerCompositor.h:
10:01 Changeset [90924] by abarth@webkit.org

Refine garden-o-matic status pane
https://bugs.webkit.org/show_bug.cgi?id=64442

Reviewed by Dimitri Glazkov.

This patch makes two improvements to the status pane:

1) We only query the server for failure types that we're expecting.

This dramatically reduces the number of HTTP requests, making
loading the status pane faster.

2) The status pane now displays which test and which builder it is

showing results for.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
09:57 Changeset [90923] by abarth@webkit.org

garden-o-matic should show test results
https://bugs.webkit.org/show_bug.cgi?id=64440

Reviewed by Adam Roben.

This patch introduces the results detail pane, which appears at the
bottom of the window and contains test results from the bots.
Currently, you can activate the pane by mousing over one of the builder
names associated with a failing test.

This is just a first iteration of the UI. There's no way to resize or
zoom in on elements of the details pane, and images likely aren't sized
correctly, but it's a place to start.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    • Add constants for our data attributes so we don't typo them!
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add DOM structure for the details pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Bind events for showing and hiding the details pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Reduce the number of result types that we query for to avoid overfilling the details pane. We'll probably need another solution here in the long-term. For example, we could use tabs to pack more results into the pane.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
    • Now that we're using the config package during testing, we need to include it in the testing HTML.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
    • Change the DOM structure of the results detail to make it fit nicely in the details pane (rather than flowing freely in the body, as it did before).
09:30 Changeset [90922] by aroben@apple.com

Make TestFailures show every time a possibly-flaky test failed, but hide it by default

It's useful to be able to see every time a flaky test failed to see whether it failed the
same way every time. But doing so takes a lot of space, so the list of failures is now
collapsed by default and can be revealed using a disclosure triangle.

Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
flaky tests as I would like, even though the page is already so long

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
function. Now returns all failures for the given test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:

Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
more over time.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
that we no longer return passing builds for possibly-flaky tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
flakiness examples small, too, since it can get quite long.

(.disclosure-triangle):
(.expanded > .disclosure-triangle):
Simple styles for the disclosure triangle.

(.flakiness-examples-list): Collapse the list by default.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
_domForPossiblyFlakyTests.
(ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
of each test name, and the number of failures to the right. When the disclosure triangle is
clicked for the first time, we build up the list of failures and expand the element. After
that we just collapse or expand the element on subsequent clicks.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pulled in new tests.

09:06 Changeset [90921] by aroben@apple.com

Teach TestFailures to understand NRWT's output when it exits early due to too many failures

Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
exits early

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
line. Tightened up the regex that's used to parse the number of failing tests to require the
leading number to be followed by whitespace so that we won't parse the "2011" in
"2011-07-13" as a number of failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

08:49 Changeset [90920] by dglazkov@chromium.org

Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=64386

This is the first step in converting TestExpectations to a real model.

  • TestExpectationsLine represents a line in the test_expectations.txt file, and
  • TestExpectationsFile represents the file, which is a collection of lines.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
08:43 Changeset [90919] by commit-queue@webkit.org

Fix compile for QRawFont.

https://bugs.webkit.org/show_bug.cgi?id=64453

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-07-13
Reviewed by Andreas Kling.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawGlyphs):

08:21 WebKit Team edited by andreas.kling@nokia.com
(diff)
07:52 Changeset [90918] by xan@webkit.org

2011-07-13 Xan Lopez <xlopez@igalia.com>

[GTK] Do not grab focus too early in DRT.

Reviewed by Gustavo Noronha.

It causes a layout to happen and a progress signal to be emitted
since r90900, but at this point we don't have a
LayoutTestController object and we'll eventually crash. Since we
already grab focus at the beginning of runTest() this is
redundant, so get rid of it to fix the crash.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main): remove call to grab_focus
07:31 Changeset [90917] by loki@webkit.org

2011-07-13 Gabor Loki <loki@webkit.org>

[Qt] Flakey test: xmlhttprequest-50ms-download-dispatch.html on ARM
https://bugs.webkit.org/show_bug.cgi?id=64452

Rubber-stamped by Csaba Osztrogonác

  • platform/qt-arm/Skipped:
07:25 Changeset [90916] by ademar.reis@openbossa.org

Reviewed by Andreas Kling.

Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717

QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.

Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)

  • wtf/DateMath.cpp: fix usage of abs/labs
  • wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
  • wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
07:11 Changeset [90915] by andersca@apple.com

If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition
https://bugs.webkit.org/show_bug.cgi?id=64429

Include the cstddef which has the nullptr_t typedef according to the C++0x standard.

  • wtf/NullPtr.h:
07:11 Changeset [90914] by jknotten@chromium.org

Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
https://bugs.webkit.org/show_bug.cgi?id=64363

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html

  • page/Geolocation.cpp:

(WebCore::Geolocation::setIsAllowed):

  • page/Geolocation.h:

LayoutTests:

  • fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html: Added.
  • fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html: Added.
  • fast/dom/Geolocation/script-tests/remove-remote-context-in-error-callback-crash.js: Added.
  • fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt: Added.

(gc):
(onIframeReady):

07:02 Changeset [90913] by vsevik@chromium.org

Web Inspector: Network panel search needs each resource to have unique identifier.
https://bugs.webkit.org/show_bug.cgi?id=64287

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._appendResource):
(WebInspector.NetworkPanel.prototype._frameNavigated):
(WebInspector.NetworkPanel.prototype._updateSearchMatchedListAfterResourceIdentifierChanged):

06:45 Changeset [90912] by commit-queue@webkit.org

Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class
https://bugs.webkit.org/show_bug.cgi?id=63987

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Hajime Morita.

Change doesn't add new functionality. No test needed.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY):

06:31 Changeset [90911] by morrita@google.com

Refactoring: Ignored ExceptionCode value should be less annoying.
https://bugs.webkit.org/show_bug.cgi?id=63688

Source/JavaScriptCore:

Added ASSERT_AT macro.

Reviewed by Darin Adler.

  • wtf/Assertions.h:

Source/WebCore:

  • Introduced ExceptionCodePlaceholder class for the default parameter of ExceptionCode.
  • Introduced ASSERT_NO_EXCEPTION to check ExceptionCode not set to non-zero after the call.
  • Adopted ASSERT_NO_EXCEPTION in Range.cpp

No new tests. No behaviour change.

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionCodePlaceholder.h: Added.

(WebCore::ExceptionCodePlaceholder::ExceptionCodePlaceholder):
(WebCore::ExceptionCodePlaceholder::operator ExceptionCode& ):
(WebCore::IgnorableExceptionCode::IgnorableExceptionCode):
(WebCore::CheckedExceptionCode::CheckedExceptionCode):
(WebCore::CheckedExceptionCode::~CheckedExceptionCode):

  • dom/Range.cpp:

(WebCore::Range::Range):
(WebCore::Range::editingStartPosition):

  • dom/Range.h:
06:02 Changeset [90910] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt/Skipped: Skip svg/text/small-fonts-2.svg because of the 32/64 bit bug.
06:01 Changeset [90909] by andreas.kling@nokia.com

[Qt][WK2] Remove invalid signal/slot connection in QTouchWebView.
https://bugs.webkit.org/show_bug.cgi?id=64450

Reviewed by Benjamin Poulain.

The focusNextPrevChild() signal was removed, so we shouldn't try to
connect to it.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setPage):

05:54 Changeset [90908] by zimmermann@webkit.org

2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>

Regression: OOB read in svg text run
https://bugs.webkit.org/show_bug.cgi?id=63627

Not reviewed.

Fixed last minute typo leading to assertions.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection):
05:32 Changeset [90907] by andreas.kling@nokia.com

[Qt][WK2] Undelayed WorkItems are leaked after execution.
https://bugs.webkit.org/show_bug.cgi?id=64447

Reviewed by Benjamin Poulain.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::WorkItemQt::executeAndDelete):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::scheduleWork):

05:13 Changeset [90906] by benjamin.poulain@nokia.com

[Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=64352

Reviewed by Andreas Kling.

Unskip http/tests/misc/script-async.html since the original change has been reverted.

  • platform/qt-4.8/Skipped:
05:02 Changeset [90905] by vsevik@chromium.org

Chromium DevTools: Enable clear cache and cookies from network panel in chromium.
https://bugs.webkit.org/show_bug.cgi?id=64095

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

():

04:51 Changeset [90904] by caseq@chromium.org

2011-07-12 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: factor NetworkLogView out of Network panel
https://bugs.webkit.org/show_bug.cgi?id=64366

Reviewed by Pavel Feldman.

04:47 Changeset [90903] by commit-queue@webkit.org

Unreviewed, rolling out r90634.
http://trac.webkit.org/changeset/90634
https://bugs.webkit.org/show_bug.cgi?id=64448

Qt HTTP Pipelining is not robust enough to be used in that
generic way. (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

04:35 Changeset [90902] by ossy@webkit.org

[Qt] Add expected results for the new passing tests and unskip them.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-13
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/fast/[...]: Added.
  • platform/qt/svg/[...]: Added.
04:33 Changeset [90901] by zimmermann@webkit.org

2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>

Regression: OOB read in svg text run
https://bugs.webkit.org/show_bug.cgi?id=63627

Reviewed by Zoltan Herczeg.

A TextRun is constructed for a portion of a string [a,b] whose original length is c (0 < a < b < c).
The TextRun charactersLength variable stores the length of the remaining text from (b..c) in order
to support ligatures in SVG Fonts. Example: <text>ffl</text>. When measuring the advance from char 0
to char 1 the whole 'ffl' text must be passed to the SVG glyph selection code, as the SVG Font may
define a single glyph for the characters 'ffl' thus leading to a single character long text
pointing to the ffl ligature, not three individual 'f' / 'f' / 'l' characters anymore.

constructTextRun(..const UChar*, int length, ..) did not correctly calculate the maximum length (b..c).
The passed in UChar buffer starts at eg. textRenderer->characters() + start(), and following condition
holds true for 'length': start() + length <= textRenderer->textLength() (which denotes the maximum length
of the textRenderer->characters() buffer). We have to keep track of the start() offset, so that we
can calculate the charactersLength for the TextRun correctly: textRenderer->textLength() - start().

There are also other cases like RenderCombinedText and/or the presence of hyphens that were incorrectly
tracked. Only InlineTextBox had to be fixed, the other callsites in eg. RenderBlockLineLayout already
computed the maximum length correctly - I assured this by valgrind runs on all SVG Font tests.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::constructTextRun): Add maximumLength parameter to constructTextRun.
  • rendering/InlineTextBox.h: Ditto.
03:23 Changeset [90900] by antti@apple.com

didFirstVisuallyNonEmptyLayout dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=64412

Reviewed by Darin Adler and Sam Weinig.

Improve the mechanism that dispatches didFirstVisuallyNonEmptyLayout

  • Wait until a threshold of characters and pixels has been exceeded before dispatching.
  • Wait until stylesheets are loaded (painting is disabled in this case).
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageChanged):

  • rendering/RenderImage.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):

02:50 Changeset [90899] by jocelyn.turcotte@nokia.com

[Qt] Also stop the scale commit timer when commitScaleChange is called explicitly.
https://bugs.webkit.org/show_bug.cgi?id=64357

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::timerEvent):
(QTouchWebPagePrivate::commitScaleChange):

02:40 Changeset [90898] by commit-queue@webkit.org

Unreviewed, rolling out r90893 and r90894.
http://trac.webkit.org/changeset/90893
http://trac.webkit.org/changeset/90894
https://bugs.webkit.org/show_bug.cgi?id=64441

NRWT still doesn't work on qt-mac platform (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

Tools:

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

LayoutTests:

  • platform/qt-mac/Skipped:
02:09 Changeset [90897] by jamesr@google.com

[chromium] Add chromium mac gpu baseline for webgl-background-color.html

  • platform/chromium-gpu-mac/compositing/webgl/webgl-background-color-expected.png: Added.
01:47 Changeset [90896] by jamesr@google.com

[chromium] Add two chromium gpu linux baselines.

  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
01:06 Changeset [90895] by jamesr@google.com

[chromium] Assorted chromium gpu rebaselines and expectation cleanups.

  • platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium/test_expectations.txt:
00:52 Changeset [90894] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Remove 2 tests, because they are in test_expectations.txt too.
00:44 Changeset [90893] by ossy@webkit.org

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

  • Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.

(useNewRunWebKitTests):

00:18 Changeset [90892] by jamesr@google.com

[chromium] More edge AA and misc chromium gpu baselines and expectations updates.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:06 Changeset [90891] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip http/tests/misc/script-async.html until fix.
  • platform/qt-mac/Skipped: Skip new failing tests.
  • platform/qt/test_expectations.txt: Mark slow tests.

07/12/11:

23:47 Changeset [90890] by jamesr@google.com

[chromium] Update expectations+baselines for edge AA changes.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
23:14 WebKit Team edited by zherczeg@webkit.org
(diff)
23:03 Changeset [90889] by mrowe@apple.com

Fix the 32-bit build.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
Cast the NSUInteger value to unsigned long to match the format specifier.

22:43 Changeset [90888] by morrita@google.com

[Refactoring][ShadowContentElement] Forwarded node list should be a linked-list.
https://bugs.webkit.org/show_bug.cgi?id=64252

Reviewed by Dimitri Glazkov.

Introduced ShadowInclusionList and ShadowInclusion for maintaining
forwarded content children. ShadowInclusion is doubly-linked list.
ShadowContentElement::m_inclusions is replaced by ShadowInclusionList.

This change is a prepration for bug 64251, which will introduce
forwarded-children to content-element table.

No new tests. No behavioral change.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/ShadowContentElement.cpp:

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::attach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::inclusions):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
22:35 Changeset [90887] by commit-queue@webkit.org

[Chromium] Use nearest filter method with pixel aligned transforms.
https://bugs.webkit.org/show_bug.cgi?id=64338

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by James Robinson.

Source/WebCore:

Check for integer translation and use nearest texture filter when
possible to avoid filter precisions problems at the layer edges.

Test: compositing/iframes/nested-iframe-scrolling.html (existing)

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isIntegerTranslation):

  • platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

  • platform/chromium/test_expectations.txt:
22:12 Changeset [90886] by commit-queue@webkit.org

Removed unnecessary function parameters from TilingData::textureOffset.
https://bugs.webkit.org/show_bug.cgi?id=64245

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by Brent Fulgham.

No new tests, no functionality changes.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::textureOffset):

  • platform/graphics/gpu/TilingData.h:
21:23 Changeset [90885] by rniwa@webkit.org

Move RenderTextControl::indexForVisiblePosition to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64403

Reviewed by Hajime Morita.

Moved indexForVisiblePosition from RenderTextControl to HTMLTextFormControlElement.

Also replaced the call to RenderTextControl::isSelectableElement by a call to enclosingTextFormControl
(moved from htmlediting to HTMLTextFormControlElement) because we are only interested in checking
whether the given position is inside the current text form control or not.

In addition, modernized the code in indexForVisiblePosition by calling parentAnchoredEquivalent on the
given position and replacing calls to deprecateNode and deprecatedEditingOffset by calls to containerNode
and offsetInContainer.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls indexForVisiblePosition.

  • editing/htmlediting.cpp: Removed enclosingTextFromControl.
  • editing/htmlediting.h: Removed enclosingTextFromControl.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Moved from RenderTextControl.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Calls indexForVisiblePosition.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Calls indexForVisiblePosition.
(WebCore::enclosingTextFormControl): Moved from htmlediting.cpp

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
21:05 Changeset [90884] by abarth@webkit.org

Improve garden-o-matic UI when the bots fail to report revision numbers
https://bugs.webkit.org/show_bug.cgi?id=64427

Reviewed by Dimitri Glazkov.

At least Win (dbg)(2) seems to fail to report the SVN revision number
in full_results.json. This patch makes garden-o-matic more robust to
missing revision numbers.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
20:52 Changeset [90883] by joepeck@webkit.org

Unreviewed. Skipping a few tests which fail due to differing output in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

20:30 Changeset [90882] by jchaffraix@webkit.org

Make RenderObject::containingBlock virtual for better speed and clarity
https://bugs.webkit.org/show_bug.cgi?id=64318

Reviewed by Darin Adler.

No new tests, performance refactoring.

On some of my test cases, this method takes between 3 and 5% of the time spend.
The method makes 2 calls to virtual methods which could be moved to their overriden
version of containingBlock if we made it virtual.

That's what this patch does. It saves between 1 and 2% on some synthetic test cases
as well as made the current method shorter.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Removed code for RenderView and RenderTableCell,
replaced by ASSERTs.

  • rendering/RenderObject.h: Made containingBlock virtual.
  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::containingBlock):

  • rendering/RenderView.h:

(WebCore::RenderView::containingBlock):
The code moved from RenderObject is inlined in those 2 methods.

19:41 Changeset [90881] by abarth@webkit.org

Adjust garden-o-matic layout to use fewer lines
https://bugs.webkit.org/show_bug.cgi?id=64422

Reviewed by Ojan Vafai.

This patch effectively merges the test name line with the list of
builders on which the test fails. Each test failure now occupies two
lines instead of three.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
19:39 Changeset [90880] by abarth@webkit.org

garden-o-matic should label tests failures of new tests as such
https://bugs.webkit.org/show_bug.cgi?id=64421

Reviewed by Ojan Vafai.

Also, we shouldn't dim failures of new tests, even if we've only seen
them once because they're likely to be real problems that need
attention.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
19:34 Changeset [90879] by abarth@webkit.org

garden-o-matic should display how many times we've seen a failure
https://bugs.webkit.org/show_bug.cgi?id=64417

Reviewed by Ojan Vafai.

This patch adds some UI to display how many times we've seen a given
failure, which can be helpful for determining whether that failure is a
real failure or a flaky test.

When a failure has only been seen once (i.e., only a single run on a
single bot), we set the opacity of to 50% to avoid distracting the
gardener.

This patch also refactors the failure walker to have a simpler API
internally by moving from an object-oriented paradigm to a functional
paradigm.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
19:28 Changeset [90878] by commit-queue@webkit.org

Added the ability to dynamically change the parent context of a WebGraphicsContext3D.
GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate.
https://bugs.webkit.org/show_bug.cgi?id=64397

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-12
Reviewed by Kenneth Russell.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setParentContext):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::platformTexture):

18:47 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
18:46 Changeset [90877] by commit-queue@webkit.org

DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

This is a fixed implementation of op_construct. Constructor calls are implemented
by reusing almost all of the code for Call, with care taken to make sure that
where the are differences (like selecting different code blocks), those differences
are respected. The two fixes over the last patch are: (1) make sure the
CodeBlock::unlinkCalls respects differences between Call and Construct, and (2)
make sure that virtualFor() in DFGOperations respects the CodeSpecializationKind
(either CodeForCall or CodeForConstruct) when invoking the compiler.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordConstruct):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/CodeBlock.cpp:

(JSC::CodeBlock::unlinkCalls):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Added a test for the DFG op_construct regression, where polymorphic constructor
calls will result in the code being compiled for call but then invoked as a
constructor. This test will fail if that part of the patch is omitted.

  • fast/js/polymorphic-construct-expected.txt: Added.
  • fast/js/polymorphic-construct.html: Added.
  • fast/js/script-tests/polymorphic-construct.js: Added.

(Foo):
():

18:44 NewRunWebKitTests edited by dpranke@chromium.org
(diff)
18:33 Changeset [90876] by crogers@google.com

Enable Web Audio for chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=64409

Reviewed by James Robinson.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
18:31 TestExpectations edited by dpranke@chromium.org
(diff)
17:53 Changeset [90875] by oliver@apple.com

Overzealous type validation in method_check
https://bugs.webkit.org/show_bug.cgi?id=64415

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Make sure we don't trip any assertions when caching access
to an InternalFunction

  • fast/js/script-tests/method-check.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

method_check is essentially just a value look up
optimisation, but it internally stores the value
as a JSFunction, even though it never relies on
this fact. Under GC validation however we end up
trying to enforce that assumption. The fix is
simply to store the value as a correct supertype.

  • bytecode/CodeBlock.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

17:52 Changeset [90874] by jamesr@google.com

[chromium] Chromium win build fix.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::drawGlyphsWin):

17:24 Changeset [90873] by psolanki@apple.com

Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Reviewed by David Kilzer.

Changes to ResourceHandle class to get it to compile with USE(CFNETWORK).

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::didReceiveResponse):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::WebCoreSynchronousLoaderClient::willSendRequest): Call adjustMIMETypeIfNecessary
on Mac. Also port over fix for <rdar://problem/6901522> added in r43993 which forces the
MIME type to text/html if the request is annotated with a "ForceHTMLMIMEType" property.

17:20 Changeset [90872] by jamesr@google.com

[chromium] Delete the unused legacy accelerated canvas 2d code
https://bugs.webkit.org/show_bug.cgi?id=64214

Reviewed by Stephen White.

Source/WebCore:

This removes the legacy accelerated canvas 2d path and support logic since we (chromium) are no longer using
this codepath and it seems clear that no other port is interested.

Refactoring and removing unused code, so no new tests.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::didDraw):

  • html/canvas/CanvasRenderingContext2D.h:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::setGrContext):

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::pointInTriangle):

  • platform/graphics/gpu/BicubicShader.cpp: Removed.
  • platform/graphics/gpu/BicubicShader.h: Removed.
  • platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  • platform/graphics/gpu/ConvolutionShader.h: Removed.
  • platform/graphics/gpu/GraphicsContextGPU.cpp: Removed.
  • platform/graphics/gpu/GraphicsContextGPU.h: Removed.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
  • platform/graphics/gpu/SolidFillShader.cpp: Removed.
  • platform/graphics/gpu/SolidFillShader.h: Removed.
  • platform/graphics/gpu/TexShader.cpp: Removed.
  • platform/graphics/gpu/TexShader.h: Removed.
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::~NativeImageSkia):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
(WebCore::PlatformContextSkia::makeGrContextCurrent):

  • platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

Adds a way to stash a GrContext* on a GraphicsContext3D. Previously, this was handled by
SharedGraphicsContext3D, but we don't need that class any more. This is used only for the shared
GraphicsContext3D stashed on the Page and shared by all accelerated canvases within the Page, for WebGL and
compositor contexts the GrContext is never set.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::grContext):
(WebCore::GraphicsContext3D::grContext):

  • src/GraphicsContext3DInternal.h:
17:13 Changeset [90871] by abarth@webkit.org

Tweak some UI in garden-o-matic now that the tree actually has a
failure and I can see what this all looks like.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
17:05 Changeset [90870] by joepeck@webkit.org

Unreviewed. Skipping a few tests which fail due to differing output
in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

17:04 Changeset [90869] by eae@chromium.org

Switch InlineFlowBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64399

Reviewed by Eric Seidel.

First step in moving floats over to the new layout abstraction.

No new tests, no new functionality.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::logicalBottom):
(WebCore::InlineBox::setLogicalTop):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalRightSelectionGap):

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getTextShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowBlockDirectionExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):

16:37 Changeset [90868] by bashi@chromium.org

[Chromium] SVG text is not rendered sometimes with geometricPrecision
https://bugs.webkit.org/show_bug.cgi?id=64341

Source/WebCore:

Changing the type of x and y offsets of ComplexTextControllerLinux to make it possible to treat negative offsets.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

Test: platform/chromium-linux/svg/text/text-with-geometric-precision.svg

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: Changed the type of m_offsetX and m_startingY from unsigned to int.

(WebCore::ComplexTextController::ComplexTextController): Changed the type of the argument.
(WebCore::ComplexTextController::reset): Ditto.

  • platform/graphics/chromium/ComplexTextControllerLinux.h:

LayoutTests:

Add a test for the regression that the text is not rendered with geometricPrecision.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

  • platform/chromium-linux/svg/text/text-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux/svg/text/text-with-geometric-precision-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-with-geometric-precision.svg: Added.
16:32 Changeset [90867] by cevans@google.com

Merge 90308
BUG=86108
Review URL: http://codereview.chromium.org/7356002

16:31 Changeset [90866] by abarth@webkit.org

garden-o-matic should display regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64407

Reviewed by Dimitri Glazkov.

This patch computes a regression range for a failure by intersecting
the regression ranges seen by the various bots. We make the underlying
assumption that a test is only failing due to one revision at any given
moment. If that's not true, this code probably explodes.

The regression ranges appear asynchronously, which might be a jarring
UI. We'll have to experiment to see.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
15:35 Changeset [90865] by commit-queue@webkit.org

COLLECT_ON_EVERY_ALLOCATION no longer works.
https://bugs.webkit.org/show_bug.cgi?id=64388

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Oliver Hunt.

Added a flag to Heap that determines if it's safe to collect (which for now means that
JSGlobalObject has actually been initialized, but it should work for other things, too).
This allows JSGlobalObject to allocate even if the allocator wants to GC; instead of
GCing it just grows the heap, if necessary.

Then changed Heap::allocate() to not recurse ad infinitum when
COLLECT_ON_EVERY_ALLOCATION is set. This also makes the allocator generally more
resilient against bugs; this change allowed me to put in handy assertions, such as that
an allocation must succeed after either a collection or after a new block was added.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::notifyIsSafeToCollect):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

15:35 Changeset [90864] by abarth@webkit.org

cr-linux-ews should run pixel tests
https://bugs.webkit.org/show_bug.cgi?id=64394

Reviewed by Ojan Vafai.

This patch enabled pixel test on the cr-linux-ews. Running a quick
test on the bots, it looks like we have five pixel failures, related to
some missing fonts. I've also made the bots skip failing tests to
avoid uploading huge zip files to bugs.webkit.org (with all the exected
IMAGE failures).

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
15:34 Changeset [90863] by commit-queue@webkit.org

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-12
Reviewed by David Hyatt.

[CSS Exclusions] Parse wrap-shape property
https://bugs.webkit.org/show_bug.cgi?id=61726

Source/WebCore:

Parsing wrap-shape: rect, circle, ellipse and polygon.
Moved WindRule from Path.h to it's own file.

Test: fast/exclusions/parsing-wrap-shape.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseWrapShape):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/CSSWrapShapes.cpp: Added.

(WebCore::CSSWrapShapeRect::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
(WebCore::CSSWrapShapePolygon::cssText):

  • css/CSSWrapShapes.h: Added.

(WebCore::CSSWrapShape::~CSSWrapShape):
(WebCore::CSSWrapShape::CSSWrapShape):
(WebCore::CSSWrapShapeRect::create):
(WebCore::CSSWrapShapeRect::left):
(WebCore::CSSWrapShapeRect::top):
(WebCore::CSSWrapShapeRect::width):
(WebCore::CSSWrapShapeRect::height):
(WebCore::CSSWrapShapeRect::radiusX):
(WebCore::CSSWrapShapeRect::radiusY):
(WebCore::CSSWrapShapeRect::setLeft):
(WebCore::CSSWrapShapeRect::setTop):
(WebCore::CSSWrapShapeRect::setWidth):
(WebCore::CSSWrapShapeRect::setHeight):
(WebCore::CSSWrapShapeRect::setRadiusX):
(WebCore::CSSWrapShapeRect::setRadiusY):
(WebCore::CSSWrapShapeRect::type):
(WebCore::CSSWrapShapeRect::CSSWrapShapeRect):
(WebCore::CSSWrapShapeCircle::create):
(WebCore::CSSWrapShapeCircle::left):
(WebCore::CSSWrapShapeCircle::top):
(WebCore::CSSWrapShapeCircle::radius):
(WebCore::CSSWrapShapeCircle::setLeft):
(WebCore::CSSWrapShapeCircle::setTop):
(WebCore::CSSWrapShapeCircle::setRadius):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeCircle::CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::create):
(WebCore::CSSWrapShapeEllipse::left):
(WebCore::CSSWrapShapeEllipse::top):
(WebCore::CSSWrapShapeEllipse::radiusX):
(WebCore::CSSWrapShapeEllipse::radiusY):
(WebCore::CSSWrapShapeEllipse::setLeft):
(WebCore::CSSWrapShapeEllipse::setTop):
(WebCore::CSSWrapShapeEllipse::setRadiusX):
(WebCore::CSSWrapShapeEllipse::setRadiusY):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapeEllipse::CSSWrapShapeEllipse):
(WebCore::CSSWrapShapePolygon::create):
(WebCore::CSSWrapShapePolygon::appendPoint):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::setWindRule):
(WebCore::CSSWrapShapePolygon::windRule):
(WebCore::CSSWrapShapePolygon::type):
(WebCore::CSSWrapShapePolygon::CSSWrapShapePolygon):

  • css/SVGCSSValueKeywords.in:
  • platform/graphics/Path.h:
  • platform/graphics/WindRule.h: Added.
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setWrapShape):
(WebCore::InheritedFlags::wrapShape):
(WebCore::InheritedFlags::initialWrapShape):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/exclusions/parsing-wrap-shape-expected.txt: Added.
  • fast/exclusions/parsing-wrap-shape.html: Added.
  • fast/exclusions/script-tests/parsing-wrap-shape.js: Added.

(testCSSText):
(testComputedStyle):
(testNotInherited):
(test):
(negative_test):

15:30 Changeset [90862] by cevans@google.com

Merge 90166
BUG=87862
Review URL: http://codereview.chromium.org/7350005

15:29 Changeset [90861] by cevans@google.com

Merge 90156
BUG=87862
Review URL: http://codereview.chromium.org/7350004

15:21 Changeset [90860] by simon.fraser@apple.com

2011-07-12 Simon Fraser <simon.fraser@apple.com>

Clean up some RenderLayerCompositor code relating to scroll and root layers
https://bugs.webkit.org/show_bug.cgi?id=64400

Reviewed by James Robinson.

There was no need for FrameView::syncCompositingStateForThisFrame()
to call syncCompositingStateForThisLayerOnly() on the various
scrollbar-related layers, because the subsequent call to
compositor()->flushPendingLayerChanges() starts to flush at
m_overflowControlsHostLayer if one exists, and its an ancestor
of the scrollbar layers.

Also clean up terminology in RenderLayerCompositor.

m_rootPlatformLayer -> m_rootContentLayer
rootPlatformLayer() -> rootGraphicsLayer()

No behavior change, so no new tests.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): (WebCore::RenderLayerCompositor::flushPendingLayerChanges): (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::layerTreeAsText): (WebCore::RenderLayerCompositor::parentFrameContentLayers): (WebCore::RenderLayerCompositor::rootGraphicsLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootLayer): (WebCore::RenderLayerCompositor::destroyRootLayer): (WebCore::RenderLayerCompositor::attachRootLayer): (WebCore::RenderLayerCompositor::detachRootLayer): (WebCore::RenderLayerCompositor::updateRootLayerAttachment):
  • rendering/RenderLayerCompositor.h:
15:17 Changeset [90859] by commit-queue@webkit.org

Unreviewed, rolling out r90842.
http://trac.webkit.org/changeset/90842
https://bugs.webkit.org/show_bug.cgi?id=64401

Causes crash in debug on compositing/overflow/content-gains-
scrollbars.html (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::cleanupResources):
(WebCore::ContentLayerChromium::setLayerRenderer):
(WebCore::ContentLayerChromium::tilingTransform):
(WebCore::ContentLayerChromium::contentBounds):
(WebCore::ContentLayerChromium::updateLayerSize):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::setTilingOption):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::setIsMask):
(WebCore::writeIndent):
(WebCore::ContentLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
(WebCore::ImageLayerChromium::contentBounds):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore::ImageLayerChromium::drawsContent):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::draw):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
  • platform/graphics/chromium/TiledLayerChromium.h: Removed.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.
15:14 Changeset [90858] by cevans@google.com

Merge 89831
BUG=87298
Review URL: http://codereview.chromium.org/7350003

15:07 Changeset [90857] by cevans@google.com

Merge 90595
BUG=87729
Review URL: http://codereview.chromium.org/7350001

15:00 Changeset [90856] by joepeck@webkit.org

ApplicationCache update should not immediately fail when reaching per-origin quota
https://bugs.webkit.org/show_bug.cgi?id=64177

Reviewed by Alexey Proskuryakov.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

Include spaceNeeded information in the output dumped for appcache quota delegates.
Add and update tests related to handling of per-origin quotas.

  • http/tests/appcache/origin-quota-continued-download-expected.txt: Added.
  • http/tests/appcache/origin-quota-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.manifest: Added. New test which checks that there will still be a successful cache when the per-origin quota is reached and increased at the end of downloading.
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt: Added.
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.manifest: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.manifest: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.html: Added.
  • http/tests/appcache/resources/quota-origin-continued-download.manifest: Added. New test which checks that the spaceNeeded appropriately lists enough space for multiple manifests across multiple frames for the same origin.
  • http/tests/appcache/resources/quota-origin-iframe-3.manifest: Fix a typo.
  • http/tests/appcache/origin-quota.html: Update the old test to disallow automatic increase of the quota, which is the default handling of DRT when reaching the quota.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped: Skip the test on ports that don't implement ApplicationCache per-origin quotas.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

New behavior of handling ApplicationCache per-origin quotas. Previously,
if the quota was reached while downloading we would fail the download
and then prompt the user for a storage increase. This required a refresh,
a redownload of resources, and the total storage was not known so the
process could be repeated multiple times before an acceptable quota
was found or the user disallowed an increase.

The new behavior is to complete the download of the entire appcache.
When the cache completes downloading and it is greater than the origin
quota, prompt the user to allow a quota increase with the known space
needed. If the quota is increased, the cache will succeed, otherwise
it will fail with the normal failure steps.

An alternative behavior is prompting while downloading immediately
when the origin quota is reached, however at that point the entire
space needed is unknown and so quota increases might not be enough
and could result in multiple prompts to the user.

Tests: http/tests/appcache/origin-quota-continued-download-multiple-manifests.html

http/tests/appcache/origin-quota-continued-download.html

  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Rename instance variable to be more clear on its intent.

(WebCore::ApplicationCacheGroup::didFinishLoading):
Check the quota limit while downloading so we can fail early
if the user already denied a quota increase.

(WebCore::ApplicationCacheGroup::didReachOriginQuota):
Pass the space needed information to the chrome client.

(WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
Removed. Instead convert the callers to update state and console
log when the per-origin quota is reached. This allows us to follow
the normal failure steps if the quota is reached at the end of a
download, and the alternative short path when we fail during downloading.

(WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
Extract to a helper function.

(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
Allow for a quota increase at the end of the download now that
we know the space needed. Then proceed to fail or succeed
as we normally would.

  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::checkOriginQuota): (WebCore::ApplicationCacheStorage::storeNewestCache): Extract checking the origin quota for when an ApplicationCacheGroup will be replacing an ApplicationCacheGroup into a helper function. The helper also provides an out parameter for the space needed to properly fit the new cache group if it wouldn't fit.
  • page/ChromeClient.h:
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota): Add a space needed parameter when reaching the per-origin quota.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

  • WebView/WebUIDelegatePrivate.h:
  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]): Update the delegate to include a space needed parameter.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedApplicationCacheOriginQuota): Call the delegate with the new space needed information.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/ChromeClientQt.h: Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.

2011-07-12 Joseph Pecoraro <joepeck@webkit.org>

Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
to disable the default behavior of raising the default per-origin
quota to 5MB when reached. This allows us to test what happens
when the quota is reached and not increased.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (disallowIncreaseForApplicationCacheQuotaCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::disallowIncreaseForApplicationCacheQuota): (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::disallowIncreaseForApplicationCacheQuota): (LayoutTestController::dumpApplicationCacheDelegateCallbacks): Expose a function to prevent automatically increasing the per-origin quota when the quota is reached. This allows us to test what happens when a user would "disallow" a quota increase.
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpApplicationCacheQuota): Respect the new disallowIncrease flag and dump the spaceNeeded values for ports that implement application cache quotas.
14:56 Changeset [90855] by aroben@apple.com

Delete some redundant code in WebHTMLView

This code had no user-visible effect, as we were just duplicating work that AppKit would do
for us at a slightly different time.

Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):
Don't bother setting the root layer's transform to account for the scale factor. AppKit
takes care of this for us nowadays.

14:51 Changeset [90854] by commit-queue@webkit.org

DFG JIT put_by_id transition caching does not inform the GC about the structure and
prototype chain that it is referencing.
https://bugs.webkit.org/show_bug.cgi?id=64387

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Fixed the relevant code in DFGRepatch to call StructureStubInfo::initPutByIdTransition().

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

14:46 Changeset [90853] by crogers@google.com

AudioDevice::Stop can close NULL handle.
https://bugs.webkit.org/show_bug.cgi?id=64157

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::uninitialize):

  • webaudio/AudioContext.h:
14:38 Changeset [90852] by ojan@chromium.org

fix flakiness dashboard to work with new crash log filenames
https://bugs.webkit.org/show_bug.cgi?id=64393

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
14:38 Changeset [90851] by jer.noble@apple.com

Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary
https://bugs.webkit.org/show_bug.cgi?id=63217
<rdar://problem/9660291>

Reviewed by Darin Adler.

Check to see if the NSWindow hosting the WebView is not on the active space before changing the window's
collectionBehavior.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganExitFullScreenAnimation]):

14:22 Changeset [90850] by commit-queue@webkit.org

Move call to syncCompositingLayers so that we do not trigger redundant draws.
https://bugs.webkit.org/show_bug.cgi?id=64224

Source/WebCore:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing. CCLayerTreeHostImplProxy::updateLayers was
no longer needed, because animateAndLayout calls WebViewImpl::layout.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::syncCompositingLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):

Source/WebKit/chromium:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::layout):
(WebKit::WebViewImpl::syncCompositingLayers):

  • src/WebViewImpl.h:
14:20 Changeset [90849] by rniwa@webkit.org

Isolate HTMLTextFormControlElement into a separate file
https://bugs.webkit.org/show_bug.cgi?id=64381

Reviewed by Dimitri Glazkov.

Extracted HTMLTextFormControlElement.h and HTMLTextFormControlElement.cpp out of
HTMLFormControlElement.h and HTMLFormControlElement.cpp.

Also moved defaultEventHandler from HTMLFormControlElementWithState to HTMLTextFormControlElement
because it was specific to HTMLTextFormControlElement, and replaced all references to
HTMLFormControlElementWithState in HTMLInputElement and HTMLTextAreaElement by ones to
HTMLTextFormControlElement.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/TextIterator.cpp:
  • editing/htmlediting.cpp:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isFocusable):

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::isMouseFocusable):
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::canStartSelection):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::rendererIsNeeded):
(WebCore::HTMLInputElement::attach):
(WebCore::HTMLInputElement::detach):
(WebCore::HTMLInputElement::copyNonAttributeProperties):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::addSubresourceAttributeURLs):
(WebCore::HTMLInputElement::recalcWillValidate):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp: Copied from Source/WebCore/html/HTMLFormControlElement.cpp.

(WebCore::HTMLTextFormControlElement::defaultEventHandler):

  • html/HTMLTextFormControlElement.h: Copied from Source/WebCore/html/HTMLFormControlElement.h.
14:18 Changeset [90848] by cevans@google.com

Merge 90568
BUG=83672
Review URL: http://codereview.chromium.org/7344020

14:08 Changeset [90847] by commit-queue@webkit.org

Unreviewed, rolling out r90831.
http://trac.webkit.org/changeset/90831
https://bugs.webkit.org/show_bug.cgi?id=64389

Likely caused fast/canvas/DrawImageSinglePixelStretch.html to
start timing out on the chromium GPU bots (Requested by ojan
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

13:58 SourceDirectory edited by jchaffraix@webkit.org
Forgot a lot of directories inside WebCore, added all directories with … (diff)
13:58 Changeset [90846] by abarth@webkit.org

Add a happy animation to garden-o-matic when there are no failures
https://bugs.webkit.org/show_bug.cgi?id=64382

Reviewed by Ojan Vafai.

As requested by Ojan.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
13:57 Changeset [90845] by cevans@google.com

Merge 90130
BUG=87925
Review URL: http://codereview.chromium.org/7344019

13:25 Changeset [90844] by andreas.kling@nokia.com

[Qt][WK2] Navigation actions in incorrect state when loadStarted() is emitted.
https://bugs.webkit.org/show_bug.cgi?id=64383

Reviewed by Kenneth Rohde Christiansen.

Update the navigation actions before emitting loadStarted().

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):

13:22 Changeset [90843] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

  • DEPS:
12:56 Changeset [90842] by jamesr@google.com

Reviewed by Kenneth Russell.

[chromium] Move draw implementation for ContentLayerChromium/ImageLayerChromium to the appropriate CCLayerImpl subclass
https://bugs.webkit.org/show_bug.cgi?id=58833

Adds a TiledLayerChromium class to handle the tiling logic shared by ContentLayerChromium and ImageLayerChromium
so that they can be siblings in the class hierarchy instead of children. Also adds a CCTiledLayerImpl to handle
the drawing responsibilities for tiled layers.

TiledLayerChromium maintains a tiler, tiling options, and calculates the tiling transform. Subclasses are
responsible for providing an appropriate texture updater implementation. CCTiledLayerImpl takes the tiler,
tiling transform and layer properties and draws the layer. Longer term it'd be better of the CCTiledLayerImpl
owned the tiler and the TiledLayerChromium only owned an updater, but getting there will require changing the
way tile eviction works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::textureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::cleanupResources):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::textureUpdater):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::contentBounds):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::visibleLayerRect):
(WebCore::paintLayerContentsIfDirty):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp: Added.

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::~TiledLayerChromium):
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setLayerRenderer):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::setIsMask):
(WebCore::TiledLayerChromium::tilingTransform):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/TiledLayerChromium.h: Copied from Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h.
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::contentBounds):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::doubleSided):
(WebCore::CCLayerImpl::setDoubleSided):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Added.

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::~CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h: Added.

(WebCore::CCTiledLayerImpl::create):
(WebCore::CCTiledLayerImpl::setTilingTransform):
(WebCore::CCTiledLayerImpl::setTiler):

12:41 Changeset [90841] by xan@webkit.org

2011-07-12 Arno Renevier <arno@renevier.net>

[GTK] DOM bindings do not have gir annotations
https://bugs.webkit.org/show_bug.cgi?id=45395

Reviewed by Xan Lopez.

  • bindings/scripts/CodeGeneratorGObject.pm: generate introspection annotations.
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: update for new output.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: ditto.
12:20 Changeset [90840] by abarth@webkit.org

sheriffbot can't perform rollouts
https://bugs.webkit.org/show_bug.cgi?id=64370

Reviewed by Eric Seidel.

Now that we're not updating the working copy before processing every
IRC message, the rollout command needs to update it manually.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
12:16 Changeset [90839] by crogers@google.com

2011-07-12 Chris Rogers <crogers@google.com>

webkitAudioContext does not do proper sanity checking on its arguments.
https://bugs.webkit.org/show_bug.cgi?id=64076

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
  • bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::constructorCallback): (WebCore::V8AudioContext::createBufferCallback):
  • platform/audio/HRTFDatabaseLoader.h: (WebCore::HRTFDatabaseLoader::databaseSampleRate):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::create): (WebCore::AudioContext::createOfflineContext): (WebCore::AudioContext::createBuffer):
  • webaudio/AudioContext.h:
12:16 Changeset [90838] by benjamin.poulain@nokia.com

[Qt][WK2] Add a basic Pinch gesture recognizer for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64373

Reviewed by Andreas Kling.

This patch adds QtPinchGestureRecognizer to recognize pinch gesture out of
the events not handled by the WebProcess.

TouchViewInterface::pinchGestureRequestScale() has a basic default implementation
so the feature can be tested manually.

  • UIProcess/qt/QtGestureRecognizer.cpp:

QtGestureRecognizer is the private base class for both gesture recognizer
in order to be able to share some code.
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::reset):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::reset):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp: Added.

(WebKit::findTouchPointIndex):
(WebKit::computeTouchCenter):
(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::reset):
(WebKit::QtPinchGestureRecognizer::initializeGesture):

  • UIProcess/qt/QtPinchGestureRecognizer.h: Copied from Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.h.

(WebKit::QtPinchGestureRecognizer::TouchPointInformation::TouchPointInformation):
(WebKit::QtPinchGestureRecognizer::TouchPointInformation::isValid):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::pinchGestureStarted):
(WebKit::TouchViewInterface::pinchGestureRequestScale):
The scale factor reported by the recognizer to the TouchViewInterface is the total scale since the start
of the gesture in order to avoid numerical instabilities.
(WebKit::TouchViewInterface::pinchGestureEnded):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
(QTouchWebPageProxy::processDidCrash):
(QTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
11:55 Changeset [90837] by andreas.kling@nokia.com

[Qt][WK2] Navigation actions should react to web process availability.
https://bugs.webkit.org/show_bug.cgi?id=64375

Reviewed by Benjamin Poulain.

When the web process is unavailable, the reload and stop actions should
behave slightly differently. Stop should always be disabled, and reload
should be enabled if there's a reloadable item in the back/forward list.

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationActionEnabledStatusAtStartup):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationActionEnabledStatusAtStartup):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::updateAction):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

11:53 Changeset [90836] by evan@chromium.org

[chromium] DRT depends on v8
https://bugs.webkit.org/show_bug.cgi?id=64376

DumpRenderTree.cpp has calls to v8:: functions, so it should have a build
dependency on v8. This fixes missing references in the shared-object build.

  • WebKit.gyp:
11:49 Changeset [90835] by abarth@webkit.org

Fix the grammar in the FIXME comment.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
11:47 Changeset [90834] by psolanki@apple.com

Implement didReceiveDataArray callback for CFNetwork based loader
https://bugs.webkit.org/show_bug.cgi?id=64130

Reviewed by David Kilzer.

Factor out the didReceiveDataArray code from ResourceHandleMac.mm into
a new method ResourceHandle::handleDataArray(). Implement the callback
in the CFNetwork loader code and call handleDataArray() to process
incoming data.

No new tests because the flag is not enabled for any bots.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::didReceiveDataArray):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::handleDataArray):

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):

11:42 Changeset [90833] by eae@chromium.org

Switch preferred width/height and columns to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64329

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::ceiledLayoutUnit):
Add ceiledLayoutUnit to go with the floored version.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns):
Rename rect version of flipForWritingModeIncludingColumns to
adjustStartEdgeForWritingModeIncludingColumns as it adjust the start edge
and does not flip the rect.

(WebCore::RenderBlock::adjustForColumns):
(WebCore::updatePreferredWidth):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::flipForWritingModeIncludingColumns):

  • rendering/RenderBox.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::itemBoundingBoxRect):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):
(WebCore::RenderObject::adjustForColumns):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/TableLayout.h:
11:37 Changeset [90832] by leviw@chromium.org

Change roundedIntRect to roundedRect
https://bugs.webkit.org/show_bug.cgi?id=64326

Reviewed by Eric Seidel.

Renaming RoundedIntRect to RoundedRect and moving the underlying type to Layout units from
integer-based versions.

No new tests, no new functionality

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

  • platform/graphics/Path.h:
  • platform/graphics/RoundedIntRect.cpp: Removed.
  • platform/graphics/RoundedIntRect.h: Removed.
  • platform/graphics/RoundedRect.cpp: Copied from Source/WebCore/platform/graphics/RoundedIntRect.cpp.

(WebCore::RoundedRect::Radii::isZero):
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::includeLogicalEdges):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
(WebCore::RoundedRect::includeLogicalEdges):
(WebCore::RoundedRect::excludeLogicalEdges):
(WebCore::RoundedRect::isRenderable):

  • platform/graphics/RoundedRect.h: Copied from Source/WebCore/platform/graphics/RoundedIntRect.h.

(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
(WebCore::operator==):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::setLastShadowValues):
(WebCore::ScratchBuffer::setLastInsetShadowValues):
(WebCore::ScratchBuffer::matchesLastShadow):
(WebCore::ScratchBuffer::matchesLastInsetShadow):
(WebCore::computeSliceSizesFromRadii):
(WebCore::ShadowBlur::templateSize):
(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

  • rendering/style/RenderStyle.h:
11:31 Changeset [90831] by commit-queue@webkit.org

[skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing.
https://bugs.webkit.org/show_bug.cgi?id=64302

Patch by Mike Reed <reed@google.com> on 2011-07-12
Reviewed by Stephen White.

No new tests. Just an optimization for getImageData(), existing <canvas> tests apply

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

11:27 SourceDirectory edited by jchaffraix@webkit.org
Added more content to the WebCore section (diff)
11:20 Changeset [90830] by pfeldman@chromium.org

Web Inspector: introduce UserMetrics for collecting stats in Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=64350

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/user-metrics.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::recordActionTaken):
(WebCore::JSInspectorFrontendHost::recordPanelShown):
(WebCore::JSInspectorFrontendHost::recordSettingChanged):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype.initiateAudit):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
(.WebInspector.InspectorFrontendHostStub.prototype.recordActionTaken):
(.WebInspector.InspectorFrontendHostStub.prototype.recordPanelShown):
(.WebInspector.InspectorFrontendHostStub.prototype.recordSettingChanged):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

  • inspector/front-end/UserMetrics.js: Added.

(WebInspector.UserMetrics.settingChanged):
(WebInspector.UserMetrics):
(WebInspector.UserMetrics.prototype.panelShown):
(WebInspector.UserMetrics._Recorder):
(WebInspector.UserMetrics._Recorder.prototype.record):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._toggleAttach):

LayoutTests:

  • inspector/user-metrics-expected.txt: Added.
  • inspector/user-metrics.html: Added.
11:13 Changeset [90829] by andreas.kling@nokia.com

[Qt][WK2] QDesktopWebView crashes if resized without web process.
https://bugs.webkit.org/show_bug.cgi?id=64371

Reviewed by Benjamin Poulain.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::paint): Remove an invalid assertion. The drawing
area may be null if the web process has crashed.
(QtWebPageProxy::setDrawingAreaSize): Fail silently if there is no
drawing area.

11:06 Changeset [90828] by commit-queue@webkit.org

Patch by Jeff Timanus <twiz@chromium.org> on 2011-07-12
Reviewed by Stephen White.

Suppress flaky Chromium layout tests.
https://bugs.webkit.org/show_bug.cgi?id=64308

  • platform/chromium/test_expectations.txt:
11:00 Changeset [90827] by commit-queue@webkit.org

Remove results for iframe-outline.html
https://bugs.webkit.org/show_bug.cgi?id=64343

fast/frames/iframe-outline.html was reverted in bug 57439 (another test
added to replace it). Remove the redundant iframe-outline test results.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-12
Reviewed by Tony Chang.

  • platform/chromium-win/fast/frames/iframe-outline-expected.png: Removed.
  • platform/chromium/iframe-outline-expected.png: Removed.
  • platform/gtk/fast/frames/iframe-outline-expected.png: Removed.
  • platform/gtk/fast/frames/iframe-outline-expected.txt: Removed.
10:53 SourceDirectory edited by jchaffraix@webkit.org
Filled more details about Source/JavaScriptCore (diff)
10:52 Changeset [90826] by eric@webkit.org

NRWT should open test results page with Safari trunk, not the system provided one on Mac
https://bugs.webkit.org/show_bug.cgi?id=64346

Reviewed by Adam Barth.

To fix this I implemented Port.show_results_html_file in Mac, Gtk and Qt ports with
implementations (mostly) matching those found in old-run-webkit-tests.
There are still some minor differences for Qt which Qt hackers may wish to tweak.

I had to add a WebKitPort._port_flag_for_scripts method (similar to flag() in common.config.ports.py)
for the Qt/Gtk ports which always require a flag passed to scripts.

While trying to test this, I found that FactoryTest.test_chromium_gpu_linux
was using a real filesystem (due to assert_platform) which due to
global variables in config.py was causing set-webkit-configuration to have
an affect on unit test results! So I fixed this by making FactoryTest.assert_port
pass a mock file system whenever calling factory.get.

Unfortunately TestPort was depending on always being passed a None filesystem
and asserting filesystem._tests (only true for unit_test_filesystem()).
So I just removed the FactoryTest.test_test and FactoryTest.test_dryrun tests
deciding that they were pretty much useless anyway. If others feel strongly
I'm happy to fix this in a different way.

  • Scripts/webkitpy/common/system/executive.py:
    • default arguments in python are screwy. They use a single shared instance, so it's better to use argument=None and then argument = argument or Default() if you have any chance of mutating (or returning) the default argument.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • This code is wrong. We don't need to use a global variable here (as far as I can tell). I'm not fixing it in this patch, but I've marked it with a FIXME and we can convert to storing the results of the read on the Config object (which should only be created once during normal operation). Unit tests shouldn't be hitting the disk anyway. It's possible Config should move off of Port and onto Tool/Host directly.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
10:51 Changeset [90825] by psolanki@apple.com

Reviewed by David Kilzer.

Add NSURLResponse wrapper in ResourceResponse when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63286

When USE(CFNETWORK) is enabled on Mac, keep an NSURLResponse object along with the
CFURLResponseRef so that WebKit can continue using the NSURLResponse.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::ResourceResponse):

10:50 Changeset [90824] by aroben@apple.com

Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot

Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
exit status but we didn't find any failure counts, assume that there was some error that
caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a new test that shows that we get a failingTestCount of -1 when run-webkit-tests dies
early.
(runGetNumberOfFailingTestsTest): Moved most code here from the only pre-existing test in this
file.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bump the cache number so old cached data that was
tainted by the bug fixed in this patch will be evicted.

10:49 Changeset [90823] by abarth@webkit.org

cr-linux-ews complains about tests that aren't actually failing
https://bugs.webkit.org/show_bug.cgi?id=64367

The underlying problem here is that full_results.json doesn't have
enough information to determine whether a given test result was
expected because whether an actual result is expected depends on
whether full_results.json was generated duing a test run that included
pixel tests.

The right long-term solution is to make full_results.json a complete
description of what happened durning a test run. In this patch
however, to stop the spam, this patch makes the jsonresultsparser
ignore pixel failures.

(I'm landing this patch unreviewed in order to stop the bots from
spamming. I'll happily address any review comments in a follow-up
patch.)

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
10:46 Changeset [90822] by abarth@webkit.org

Re-work garden-o-matic UI to begin to look like the mocks
https://bugs.webkit.org/show_bug.cgi?id=64334

Reviewed by Dimitri Glazkov.

This patch changes how we display failures to be more like the mock the
dglazkov made. We now can display the same information much more
compactly.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:23 SourceDirectory edited by jchaffraix@webkit.org
Enhanced the formatting of the page (diff)
09:28 Changeset [90821] by jberlin@webkit.org

WebKitTestRunner needs an implemenation of allowRoundingHacks
https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks-expansion.html to the wk2 Skipped list to get the
bots green.

  • platform/wk2/Skipped:
09:15 Changeset [90820] by andreas.kling@nokia.com

[Qt][WK2] Add informative loadFailed() signal to web views.
https://bugs.webkit.org/show_bug.cgi?id=64362

Reviewed by Benjamin Poulain.

The web views will now emit loadFailed(QWebError) when a load failure occurs.

The QWebError object currently contains:

  • Type of failure (whether it's an engine, network or protocol error.)
  • The failing URL.
  • Any error code associated with the failure.
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qweberror.cpp: Added.

(QWebError::QWebError):
(QWebErrorPrivate::createQWebError):
(QWebErrorPrivate::QWebErrorPrivate):
(QWebErrorPrivate::~QWebErrorPrivate):
(QWebError::type):
(QWebError::errorCode):
(QWebError::url):

  • UIProcess/API/qt/qweberror.h: Added.
  • UIProcess/API/qt/qweberror_p.h: Added.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/ClientImpl.cpp:

(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • WebKit2API.pri:
07:53 Changeset [90819] by podivilov@chromium.org

Web Inspector: Cancelling an empty edit fails.
https://bugs.webkit.org/show_bug.cgi?id=64351

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.cancelEditing):

07:49 Changeset [90818] by podivilov@chromium.org

Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=64353

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.doubleClick):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

LayoutTests:

  • inspector/debugger/live-edit.html:
07:44 Changeset [90817] by jocelyn.turcotte@nokia.com

[Qt] Forward the touch view scale changes to the tiled drawing area.
https://bugs.webkit.org/show_bug.cgi?id=64357

Reviewed by Kenneth Rohde Christiansen.

The drawing area needs to know the new scale to render tiles accordingly.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::commitScaleChange):

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setContentsScale):

  • UIProcess/qt/qtouchwebpageproxy.h:

(QTouchWebPageProxy::drawingArea):

06:59 Changeset [90816] by aroben@apple.com

Update Windows expected results for plugins/mouse-events-fixedpos.html after r90742

  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
06:54 Changeset [90815] by caseq@chromium.org

Web Inspector: remove more dead code from the Network panel
https://bugs.webkit.org/show_bug.cgi?id=64291

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

  • inspector/front-end/networkPanel.css:
06:53 Changeset [90814] by aroben@apple.com

Extract TestFailures's bug-filing code into two new classes

Fixes <http://webkit.org/b/64300> TestFailures page's new-bug-filing code is a mess!

Reviewed by Darin Adler and Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:

(Buildbot.prototype.resultsDirectoryURL): Changed to return a URI-encoded URL. Otherwise the
URL isn't valid (and it's harder to mock this function).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js:

Added. Just tests the above change (for now).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a license header, enclosed everything in a closure to avoid polluting the global
namespace, changed the test name to actually describe the passing condition, and replaced
uses of equals() with equal(). (The latter is the actual name of the function, and matches
deepEqual, etc.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Added.

(NewBugForm): This class knows how to construct a <form> used for filing new bugs in
Bugzilla based on some parameters.
(NewBugForm.prototype.domElement): Creates and returns the <form> element. Code came from
ViewController.prototype._domForNewAndExistingBugs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:

Added. Tests the above code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js: Added.

(TestFailureBugForm): This class knows how to construct a <form> element used for filing new
bugs specifically about test failures. Code came from
ViewController.prototype._domForNewAndExistingBugs.
(TestFailureBugForm.prototype.domElement): Slightly customizes the <form> element returned
by NewBugForm.
(TestFailureBugForm.prototype._computeOperatingSystem):
(TestFailureBugForm.prototype._computePlatform):
(TestFailureBugForm.prototype._createBugTitle):
(TestFailureBugForm.prototype._failingResultsHTMLURL):
(TestFailureBugForm.prototype._failingRevision):
(TestFailureBugForm.prototype._passingRevision):
(TestFailureBugForm.prototype._regressionRangeString):
Code came from ViewController.prototype._domForNewAndExistingBugs. I broke it out into
separate functions to break up the rat's nest a bit.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js:

Added. Tests the above code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewAndExistingBugs): Moved code from here to
TestFailureBugForm/NewBugForm, and changed this code to use a TestFailureBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

NewBugForm/TestFailureBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added new tests and required files.

06:35 Changeset [90813] by aroben@apple.com

Ensure no intermediate WTF::Strings are created when concatenating with string literals

Fixes <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
operator+ is suboptimal

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<String>::writeTo): Added a macro that can be used for testing how
many WTF::Strings get copied while evaluating an operator+ expression.

  • wtf/text/StringOperators.h:

(WTF::operator+): Changed the overload that takes a StringAppend to take it on the left-hand
side, since operator+ is left-associative. Having the StringAppend on the right-hand side
was causing us to make intermediate WTF::Strings when evaluating expressions that contained
multiple calls to operator+. Added some more overloads for that take a left-hand side of
const char* to resolve overload ambiguity for certain expressions. Added overloads that take
a left-hand side of const UChar* (matching the const char* overloads) so that wide string
literals don't first have to be converted to a WTF::String in operator+ expressions.

Source/WebKit2:

Export some symbols needed by TestWebKitAPI

  • win/WebKit2.def:

Tools:

Test that no intermediate WTF::Strings are created when concatenating with string literals

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp: Added.

(TestWebKitAPI::TEST): Test that a bunch of different string concatenation expressions don't
create any intermediate WTF::Strings while they're being evaluated.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added new file.

06:29 QtWebKitRelease22 edited by joel.parks@nokia.com
(diff)
05:39 Changeset [90812] by aroben@apple.com

Unreviewed, rolling out r90811.
http://trac.webkit.org/changeset/90811
https://bugs.webkit.org/show_bug.cgi?id=61025

Several svg tests failing assertions beneath
SVGSMILElement::findInstanceTime

Source/JavaScriptCore:

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

03:14 Changeset [90811] by reni@webkit.org

Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-07-12
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

01:35 WebKit Team edited by dslomov@google.com
(diff)
01:08 Changeset [90810] by eric@webkit.org

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

Reviewed by Adam Barth.

Tools:

This is more fall-out from the Port class inappropriately encapsulating
both platform and port knowledge. We need to split out some of this
platform knowledge into a separate class which can be better shared
between ports.

The fix was to move all the _path_to_apache_config_file logic down
into the WebKitPort baseclass so that all of the ports can find the
right apache config file, regardless of what platform they may be running on.

I did not move this down into base.Port (even though I considered it).
Chromium duplicates some of this logic, but since they have separate
subclasses for each port-OS combination (e.g. ChromiumMac, ChromiumWin)
they wouldn't notice the change. Eventually we'll move this logic
out of Port entirely, and then it will be shared by all ports.

I also cleaned up the http-config logic for ORWT while I was there,
although since we're killing that code, I'm happy to revert that part
of the change if changing it is viewed as needlessly risky.

During this cleanup, I noticed that no ports use the "default" httpd.conf
which is left over from Mac OS X Tiger (and old linux distros) which used
Apache 1.3. I've removed httpd.conf (and associated support in ORWT) since
we no longer support any ports which use this httpd.conf.

  • Scripts/webkitperl/httpd.pm:

(getHTTPDConfigPathForTestDirectory):

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

LayoutTests:

Removed this old httpd.conf file (used by Tiger and old linux distros)
since no supported WebKit ports use it anymore.

  • http/conf/httpd.conf: Removed.

07/11/11:

23:26 Changeset [90809] by commit-queue@webkit.org

Optimize HTMLInputElement::updateCheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=62840

Patch by Zeng Huiqing <huiqing.zeng@intel.com> on 2011-07-11
Reviewed by Kent Tamura.

No new tests.

  • dom/Document.h:

(WebCore::Document::getFormElements):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

22:58 Changeset [90808] by commit-queue@webkit.org

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-07-11
Reviewed by Ryosuke Niwa.

[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Implements basic functions for "redo" command.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::registerCommandForUndo):
(WebCore::EditorClientEfl::registerCommandForRedo):
(WebCore::EditorClientEfl::clearUndoRedoOperations):
(WebCore::EditorClientEfl::canRedo):
(WebCore::EditorClientEfl::undo):
(WebCore::EditorClientEfl::redo):
(WebCore::EditorClientEfl::EditorClientEfl):

  • WebCoreSupport/EditorClientEfl.h:
21:54 Changeset [90807] by psolanki@apple.com

Reviewed by David Kilzer.

Add NSURLRequest wrapper in ResourceRequest when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63276

When USE(CFNETWORK) is enabled on Mac, keep an NSURLRequest object along with the
CFURLRequestRef so that WebKit can continue using the NSURLRequest.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
(WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):

19:51 Changeset [90806] by hbono@chromium.org

Reviewed by Adam Roben.

Implement layoutTestController.setTextDirection for WebKit2 and Windows.
https://bugs.webkit.org/show_bug.cgi?id=61931

This change implements layoutTextController.setTextDirection for WebKit2
and Windows so we can run a layout test added by r87770 on them. Each
implementation adds a wrapper function for Editor::setBaseWritingDirection()
so LayoutTestController can call it.

Source/WebKit/win:

  • Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow

LayoutTestController to change the text direction.

  • WebFrame.cpp: ditto.

(WebFrame::setTextDirection):

  • WebFrame.h: ditto.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Added

WKBundleFrameSetTextDirection to allow LayoutTestController to change the
text direction.
(WKBundleFrameSetTextDirection):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: ditto.
  • WebProcess/WebPage/WebFrame.cpp: Added setTextDirection to allow

WKBundleFrame to change the text direction.
(WebKit::WebFrame::setTextDirection):

  • WebProcess/WebPage/WebFrame.h: ditto.

Tools:

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setTextDirection): Implemented the binding function
for layoutTestController.setTextDirection (Windows).

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Added a binding function for layoutTestController.setTextDirection (WebKit2).

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto.

(WTR::LayoutTestController::setTextDirection):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto.

LayoutTests:

  • platform/mac-wk2/Skipped: Removed set-text-direction.html.
  • platform/win/Skipped: ditto.
19:20 Changeset [90805] by commit-queue@webkit.org

[EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time.
https://bugs.webkit.org/show_bug.cgi?id=64293

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-11
Reviewed by Kent Tamura.

gEcoreEvas was being destroyed after shutdownEfl() was called, so the
call to ecore_evas_free() failed.

We now shut it down manually before shutdownEfl() is called.

  • DumpRenderTree/efl/ImageDiff.cpp:

(main): Destroy gEcoreEvas before shutting down the EFL.

19:17 Changeset [90804] by rniwa@webkit.org

Make Chromium Mac and Linux tests bot core builders
https://bugs.webkit.org/show_bug.cgi?id=63196

Reviewed by Adam Barth.

Added Chromium Mac and Linux Release Tests bots core builders.

Also rearranged the order of bots so that test bots show up right next to
respective builders.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
19:11 Changeset [90803] by commit-queue@webkit.org

[EFL] DRT: Add code related to font management.
https://bugs.webkit.org/show_bug.cgi?id=63989

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-11
Reviewed by Kent Tamura.

The added files are responsible for managing fontconfig and adding the
fonts required by some layout tests to fontconfig's path.

  • DumpRenderTree/efl/FontManagement.cpp: Added.

(getFontDirectories):
(getFontFiles):
(addFontDirectories):
(addFontFiles):
(addFontsToEnvironment):

  • DumpRenderTree/efl/FontManagement.h: Added.
18:56 Changeset [90802] by rniwa@webkit.org

Skip hittest-on-relative-positioned-children.html in WebKit2.

  • platform/wk2/Skipped:
18:26 Changeset [90801] by yutak@chromium.org

WebSocket: Remove WebSocket tests that do not apply to hybi protocol
https://bugs.webkit.org/show_bug.cgi?id=64288

Reviewed by Kent Tamura.

Remove tests from http/tests/websocket/tests/hybi that are not meaningful in terms of
the hybi protocol. The most recent WebSocket protocol draft is available at
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10>, and referred as
"hybi-10" here.

  • http/tests/websocket/tests/hybi/error-detect-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/error-detect.html: Removed.

Hybi protocol has a completely different scheme of representing frame types.
Additionally, hybi-10 no longer fires "error" events (which invoke "onerror" handler).

  • http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Removed.

Variable-length encoding (which is used to represent frame length in hixie-76) is no longer
used in hybi-10.

  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-overflow.html: Removed. Ditto.
  • http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/frame-length-skip.html: Removed.

There are two ways to indicate the length of a frame in hixie-76 protocol, but
hybi-10 has only one method (length-prefixed frames). Skipping unwanted frames will
be covered by other tests that will be added in a later patch.

  • http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Removed.

In hybi-10, servers no longer returns Origin header in handshake response, and clients
are not required to validate this value.

  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Removed.

In hybi-10, clients are not required to (and must not) compare the values of subprotocols
in client's request and server's response.

  • http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Removed.

In hybi-10, servers do not provide "Sec-WebSocket-Location" header, and clients are not required
to validate this value.

  • http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Removed.

Same as handshake-fail-by-sub-protocol-mismatch.html.

18:10 Changeset [90800] by rniwa@webkit.org

positionForPoint is broken when a block is positioned relatively inside the parent
https://bugs.webkit.org/show_bug.cgi?id=64298

Reviewed by Simon Fraser.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's not taking relativePositionOffset
into account when computing the point in child coordinates. Fixed the bug by adding the offset to
childLocation as needed.

Test: fast/block/positioning/hittest-on-relative-positioned-children.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries): Fixed the bug; also replaced all instances of
IntPoint by LayoutPoint.

LayoutTests:

Added a test for hit testing on relatively positioned children.

  • fast/block/positioning/hittest-on-relative-positioned-children-expected.txt: Added.
  • fast/block/positioning/hittest-on-relative-positioned-children.html: Added.
18:10 Changeset [90799] by commit-queue@webkit.org

DFG speculative JIT does not guard itself against floating point speculation
failures on non-floating-point constants.
https://bugs.webkit.org/show_bug.cgi?id=64330

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-11
Reviewed by Gavin Barraclough.

Made fillSpeculateDouble immediate invoke terminateSpeculativeExecution() as
soon as it notices that it's speculating on something that is a non-numeric
JSConstant.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

17:39 Changeset [90798] by mitz@apple.com

Excessive expansion of justified text when rounding hacks are enabled
https://bugs.webkit.org/show_bug.cgi?id=64331

Reviewed by Anders Carlsson.

Source/WebCore:

Test: platform/mac/fast/text/rounding-hacks-expansion.html

When rounding hacks are enabled, the expansion at each expansion opportunity should be by an
integer. Restored more of the logic that was removed in r78846 in order to ensure this.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/rounding-hacks-expansion.html: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.png: Added.
  • platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.txt: Added.
17:30 Changeset [90797] by jer.noble@apple.com

HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
https://bugs.webkit.org/show_bug.cgi?id=64327

Reviewed by Darin Adler.

No new tests; no change in functionality, so covered by existing tests.

Make the rules from fullscreenQuickTime.css !important so they are not overridden
by page authors.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):

17:10 Changeset [90796] by dpranke@chromium.org

nrwt: linting fixes
https://bugs.webkit.org/show_bug.cgi?id=64225

Reviewed by Eric Siedel.

Miscellaneous linting fixes. The most notable change is that
we add public attributes for user, executive, filesystem, and
options on the Port object, so we don't have to refer to the
"protected" versions all over the place".

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:55 Changeset [90795] by ojan@chromium.org

Win7 rebaselines after http://trac.webkit.org/changeset/90701.
Should have been part of http://trac.webkit.org/changeset/90716/,
but the Win7 bot was down at that time.

  • platform/chromium-win/http/tests/loading/simple-subframe-expected.png:
  • platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-win/http/tests/misc/iframe404-expected.png:
  • platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png:
  • platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium/test_expectations.txt:

Removing useless duplicated comment line.

16:49 Changeset [90794] by ojan@chromium.org

Update expectation that was missed because the WIN7 bot was down for a long time.

  • platform/chromium/test_expectations.txt:
16:35 Changeset [90793] by rniwa@webkit.org

webkit-patch roll-chromium-deps no longer works
https://bugs.webkit.org/show_bug.cgi?id=64324

Reviewed by James Robinson.

Lower the minimum commit message length to 10.

  • Scripts/webkitpy/tool/steps/commit.py:
16:33 Changeset [90792] by dpranke@chromium.org

update the boilerplate documentation in the test_expectations.txt files
https://bugs.webkit.org/show_bug.cgi?id=64221

Reviewed by Eric Seidel.

The test expectations files either had documentation for the
Chromium port's version of the file (which was also incorrect),
or were undocumented. This adds a comment with a link to the
documentation for the file to each.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
16:31 Changeset [90791] by leviw@chromium.org

2011-07-11 Levi Weintraub <leviw@chromium.org>

Switch lineTop and lineBottom to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64317

Reviewed by Eric Seidel.

Changing lineTop and lineBottom to LayoutUnits and preparing all uses
of them for the upcoming conversion.

No new tests, no new functionality.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/GapRects.h: (WebCore::GapRects::left): (WebCore::GapRects::center): (WebCore::GapRects::right): (WebCore::GapRects::uniteLeft): (WebCore::GapRects::uniteCenter): (WebCore::GapRects::uniteRight): (WebCore::GapRects::operator LayoutRect):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesInBlockDirection): (WebCore::InlineFlowBox::flipLinesInBlockDirection): (WebCore::InlineFlowBox::computeOverflow): (WebCore::InlineFlowBox::setLayoutOverflow): (WebCore::InlineFlowBox::setVisualOverflow): (WebCore::InlineFlowBox::setOverflowFromLogicalRects): (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::visualOverflowRect):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::anyLineIntersectsRect):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::lineTop): (WebCore::RootInlineBox::lineBottom): (WebCore::RootInlineBox::setLineTopBottomPositions): (WebCore::RootInlineBox::logicalTopVisualOverflow): (WebCore::RootInlineBox::logicalBottomVisualOverflow): (WebCore::RootInlineBox::logicalTopLayoutOverflow): (WebCore::RootInlineBox::logicalBottomLayoutOverflow):
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.h:
16:23 Changeset [90790] by rniwa@webkit.org

Rolled Chromium DEPS.

16:10 WebKitGtkLayoutTests edited by mrobinson@webkit.org
(diff)
15:48 Changeset [90789] by commit-queue@webkit.org

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-07-11
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
15:43 Changeset [90788] by mrobinson@webkit.org

Reviewed by Daniel Bates.

[GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering
https://bugs.webkit.org/show_bug.cgi?id=62752

Instead of offsetting the cursor blit by the hotspot, just pass the hotspot
arguments to the GdkCursor constructor.

No new tests. This is covered by manual-tests/cursor.html.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor):

15:30 Changeset [90787] by dpranke@chromium.org

Skip plugins/evaluate-js-after-removing-plugin-element.html on Chromium Vista.

https://bugs.webkit.org/show_bug.cgi?id=64319

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
15:29 Changeset [90786] by mrobinson@webkit.org

[GTK] [NRWT] Pixel tests do not work
https://bugs.webkit.org/show_bug.cgi?id=64091

Reviewed by Eric Seidel.

Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
path to the ImageDiff binary.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
15:24 Changeset [90785] by dslomov@google.com

Unreviewed, adding myself as a committer

15:00 Changeset [90784] by yi.4.shen@nokia.com

[Qt] Unreviewed rollout 90779 which may fail the layout-test.

Source/WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

LayoutTests:

  • loader/load-defer-resume-crash-expected.txt: Removed.
  • loader/load-defer-resume-crash.html: Removed.
  • loader/resources/images.html: Removed.
  • platform/chromium/test_expectations.txt:
14:52 Changeset [90783] by abarth@webkit.org

Delete top-level S60 directory. This directory hasn't been touched in four years. r=smfr

13:28 Changeset [90782] by jberlin@webkit.org

WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading.
https://bugs.webkit.org/show_bug.cgi?id=64313

Add loader/load-defer-resume-crash.html to the WK2 Skipped list in order to get the bots
green.

  • platform/wk2/Skipped:
13:23 Changeset [90781] by dpranke@chromium.org

Fix hang on win32 in a multiprocessing test that shouldn't have been running.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12:55 Changeset [90780] by darin@chromium.org

2011-07-11 Bradley Nelson <bradnelson@chromium.org>

Reviewed by Darin Fisher.

Split webcore_dom off webcore_remaining to reduce its size for
whole program optimization builds.

https://bugs.webkit.org/show_bug.cgi?id=64299

  • WebCore.gyp/WebCore.gyp:
12:33 Changeset [90779] by yi.4.shen@nokia.com

[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
https://bugs.webkit.org/show_bug.cgi?id=62808

Source/WebCore:

Reviewed by Benjamin Poulain.

The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously.

Test: loader/load-defer-resume-crash.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

LayoutTests:

Added a test for the crash occurs when load deferring is turned off.

Reviewed by Benjamin Poulain.

  • loader/load-defer-resume-crash-expected.txt: Added.
  • loader/load-defer-resume-crash.html: Added.
  • loader/resources/images.html: Added.
  • platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
12:20 Changeset [90778] by aroben@apple.com

Don't count leaks as test failures on TestFailures's front page

As a bonus, this patch adds our first unit test.

Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
are failing on the Leaks bot than actually are

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
failure counts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added. Contains a simple test to show that leaks aren't counted as test failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added. This is the test harness.

12:14 Changeset [90777] by senorblanco@chromium.org

Unreviewed; chromium test expectations update.

Mark 2d.gradient.object.update as passing after r90767.

  • platform/chromium/test_expectations.txt:
12:10 Changeset [90776] by kov@webkit.org

Add API to WebKit-GTK to allow setting localStorage database path
https://bugs.webkit.org/show_bug.cgi?id=62091

Patch by Mike Stegeman <mrstegeman@gmail.com> on 2011-06-14
Reviewed by Martin Robinson and Gustavo Noronha.

Expose the path of the localStorage databases through a setting
to allow HTML5 localStorage to be persistent. New setting is:
html5-local-storage-database-path

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

12:06 Changeset [90775] by rniwa@webkit.org

Move innerTextElement() from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64134

Reviewed by Kent Tamura.

Moved innerTextElement from RenderTextControl to HTMLTextFormControlElement. It is implemented by
HTMLInputElement and HTMLTextAreaElement instead of RenderTextControlSingleLine and
RenderTextControlMultiLine.

This refactoring removes the indirection through RenderTextControl and makes the ownership of
shadow DOM for input and textarea elements clear. Accessing the shadow DOM of input and textarea elements
are now less error prone because it no longer depends on the lifetime of the render tree.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Access innerTextElement via
HTMLTextFormControlElement.

  • dom/Node.cpp:

(WebCore::traverseTreeAndMark): No longer calls innerTextElement because this was a work-around
needed before making input and textarea elements use the new shadow DOM model.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement): Access innerTextElement via HTMLTextFormControlElement.

  • html/HTMLFormControlElement.cpp:

(WebCore::hasVisibleTextArea): Takes innerTextElement.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Calls innerTextElement().
(WebCore::HTMLTextFormControlElement::selection): Ditto.
(WebCore::HTMLTextFormControlElement::selectionStart): Ditto; no longer uses a temporary local variable
for innerTextElement because innerTextElement() no longer depends on the lifetime of the render tree.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.

  • html/HTMLFormControlElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Added.

  • html/HTMLTextAreaElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Made this function a const member.
(WebCore::RenderTextControl::innerTextElement): Added.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:
12:04 Changeset [90774] by abarth@webkit.org

garden-o-matic should be able to rebaseline tests
https://bugs.webkit.org/show_bug.cgi?id=64186

Reviewed by Eric Seidel.

This patch contains a simple HTTP server binding for the
rebaseline-test command. The frontend will appear in another patch.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
12:02 Changeset [90773] by tony@chromium.org

rename RenderObject::isFlexibleBox to isDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=64217

Reviewed by Ojan Vafai.

This is to make way for the new flexbox needing a similar method.
RenderObject also has isFlexingChildren() and isStretchingChildren(),
but we may be able to use those for the new flexbox as well so I
didn't rename them.

No new tests, just refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::shouldCheckLines):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderDeprecatedFlexibleBox.h:

(WebCore::RenderDeprecatedFlexibleBox::isDeprecatedFlexibleBox):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isDeprecatedFlexibleBox):

11:58 Changeset [90772] by abarth@webkit.org

Add some basic UI for showing regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64243

Reviewed by Eric Seidel.

This UI is all temporary. It exists mostly just to have some buttons
to click to exercise the code.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:54 Changeset [90771] by abarth@webkit.org

garden-o-matic should be able to determine which revisions caused a given failure
https://bugs.webkit.org/show_bug.cgi?id=64189

Reviewed by Adam Roben.

Walking the failure history looking for failures turns out to be
slightly tricky because the network requests are asynchronous.
Currently we do all the fetches serially and our cache is unbounded.
We'll probably optimize both those parameters eventually.

This patch also generalizes some functionality in the unit testing
framework to make testing this sort of code easier.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
11:51 Changeset [90770] by abarth@webkit.org

Add a webkit-patch command for rebaselining an individual test
https://bugs.webkit.org/show_bug.cgi?id=64246

Reviewed by Eric Seidel.

This patch introduces a command that's able to rebaseline a single
test. Currently, the command works only with the build.chromium.org
buildbots, but extending it to work with the build.webkit.org bots
shouldn't be that hard.

A complete rebaseling tool should also include an "optimize baselines"
command (which moves/deletes baselines in order to reduce the number of
expected results files), but that will come in a future patch.

Really BuilderToPort should be merged into builders.py, but I'm going
to save that for a future patch as well. (We need to stop shaving yaks
at some point.)

  • Scripts/webkitpy/tool/commands/rebaseline.py:
11:48 Changeset [90769] by japhet@chromium.org

[Chromium] Ensure we don't crash when an
HTMLSelectElement mouse release event removes
the element from the DOM.
https://bugs.webkit.org/show_bug.cgi?id=64295

Reviewed by Dimitri Glazkov.

Manual test only because the crash requires a
real popup menu, which DRT doesn't provide.

  • manual-tests/chromium/popup-menu-crash.html: Added.
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::handleMouseReleaseEvent):

11:39 Changeset [90768] by commit-queue@webkit.org

DFG Speculative JIT does not always insert speculation checks when speculating
arrays.
https://bugs.webkit.org/show_bug.cgi?id=64254

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-11
Reviewed by Gavin Barraclough.

Changed the SetLocal instruction to always validate that the value being stored
into the local variable is an array, if that variable was marked PredictArray.
This is necessary since uses of arrays assume that if a PredictArray value is
in a local variable then the speculation check validating that the value is an
array was already performed.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:39 Changeset [90767] by commit-queue@webkit.org

[skia] remove platform helpers for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=64281

Patch by Mike Reed <reed@google.com> on 2011-07-11
Reviewed by Stephen White.

No new tests. fixes canvas/philip/tests/2d.gradient.object.update.html

Remove (now empty) platform helpers for fill/stroke gradients/patterns. We now pickup the platformGradient
and platformPattern fresh when they're needed, so we can see any edits that have occurred to them
2d.gradient.object.update.html sets the fillgradient, and then edits the gradient object. This CL allows
us to see that edit.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformInit):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::~State):
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::setupShader):
(WebCore::PlatformContextSkia::setupPaintForFilling):
(WebCore::PlatformContextSkia::setupPaintForStroking):
(WebCore::PlatformContextSkia::setFillColor):
(WebCore::PlatformContextSkia::setStrokeColor):
(WebCore::PlatformContextSkia::canAccelerate):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::setGraphicsContext):

11:22 Changeset [90766] by benjamin.poulain@nokia.com

[Qt][WK2] Get rid of focusNextPrevChild()
https://bugs.webkit.org/show_bug.cgi?id=64289

Reviewed by Andreas Kling.

Qt 5 does not use focusNextPrevChild() but uses setFocusNavigation(), and
the focus is not based on QWidget.

We can get rid of the method since the new implementation will be totally
different.

  • UIProcess/API/qt/qtouchwebpage.cpp:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_takeFocus):

  • UIProcess/qt/QtWebPageProxy.h:
11:20 Changeset [90765] by commit-queue@webkit.org

Patch by Young Han Lee <joybro@company100.net> on 2011-07-11
Reviewed by Simon Fraser.

Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
https://bugs.webkit.org/show_bug.cgi?id=63859

The existing code to set the m_startTime haven't worked because
the animation is not the right state to accept the start event.
This patch just sets the values directly instead of using event.

Source/WebCore:

Test: transitions/delay.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

  • transitions/delay-expected.txt: Added.
  • transitions/delay.html: Added.
11:14 Changeset [90764] by andersca@apple.com

Implement getFormValue for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64294
<rdar://problem/3964087>

Source/WebKit2:

Reviewed by Kevin Decker.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::getFormValue):
Call Plugin::getFormValue.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new GetFormValue message.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::getFormValue):
Get the form value and convert it to a String.

  • WebProcess/Plugins/Plugin.h:

Add getFormValue pure virtual member function.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getFormValue):
Send a GetFormValue message to the plug-in process.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::getFormValue):
Call Plugin::getFormValue.

LayoutTests:

Remove now passing test.

  • platform/wk2/Skipped:
10:55 Changeset [90763] by rniwa@webkit.org

Move selection related code from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64133

Reviewed by Dimitri Glazkov.

Source/WebCore:

Moved selectionStart, selectionEnd, hasVisibleTextArea, setSelectionRange, setContainerAndOffsetForRange
and selection from RenderTextControl.cpp to HTMLFormControlElement.cpp.

This refactoring removes RenderTextControl's dependency on FrameSelection.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText): Calls HTMLTextFromControl::selectedText.
(WebCore::AccessibilityRenderObject::selectedTextRange): Calls selectionStart and selectionEnd.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText): Extracted from AccessibilityRenderObject::selectedText.
(WebCore::hasVisibleTextArea): Added.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls computeSelectionStart instead of RenderTextControl::selectionStart.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Moved from RenderTextControl::selectionStart.
(WebCore::HTMLTextFormControlElement::selectionEnd): Calls computeSelectionEnd instead of RenderText::selectionEnd.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Moved from RenderTextControl::selectionStart.
(WebCore::setContainerAndOffsetForRange): Moved from RenderTextControl.cpp.
(WebCore::HTMLTextFormControlElement::selection): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls computeSelectionStart and computeSelectionEnd instead of
RenderTextControl::selectionStart and RenderTextControl::selectionEnd.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls selectionStart and selectionEnd.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Calls setSelectionRange.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Added.

  • rendering/RenderTextControl.h:

Source/WebKit/qt:

Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

10:51 Changeset [90762] by abarth@webkit.org

garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=64185

Reviewed by Eric Seidel.

This gardening server API is simply a binding to the rollout machinery
already present in webkit-patch.

  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
10:35 Changeset [90761] by ojan@chromium.org

Fix syntax error from r90757.

  • platform/chromium/test_expectations.txt:
09:57 Changeset [90760] by adachan@apple.com

The original request should be accessible from WebNavigationData.
https://bugs.webkit.org/show_bug.cgi?id=64227

Reviewed by Anders Carlsson.

  • Shared/WebNavigationDataStore.h: (WebKit::WebNavigationDataStore::encode): Handle the encoding of the original request. (WebKit::WebNavigationDataStore::decode): Handle the decoding of the original request.
  • UIProcess/API/C/WKNavigationData.cpp: (WKNavigationDataCopyOriginalRequest):
  • UIProcess/API/C/WKNavigationData.h:
  • UIProcess/WebNavigationData.h: (WebKit::WebNavigationData::originalRequest):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the original request in the WebNavigationDataStore.
09:52 Changeset [90759] by jberlin@webkit.org

http/tests/cache/history-only-cached-subresource-loads-max-age-https.html timing out on
Windows and WebKit2 since it was added.
https://bugs.webkit.org/show_bug.cgi?id=63806

Add the test to the WK2 Skipped list to get the bots green.

  • platform/wk2/Skipped:
09:47 Changeset [90758] by andreas.kling@nokia.com

Reviewed by Oliver Hunt.

Canvas: Use fast, approximate dirty rects for stroke()
https://bugs.webkit.org/show_bug.cgi?id=59764

No new tests, this is an optimization.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Instead of using
Path::strokeBoundingRect() to calculate the exact bounding rect
for a path stroke, get the Path::boundingRect() and inflate it by
miterLimit + lineWidth to get a slightly oversized dirty rect
in a fraction of the time.

09:37 Changeset [90757] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
09:36 Changeset [90756] by kov@webkit.org

Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=36415

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2011-07-11
Reviewed by Gustavo Noronha.

  • uk.po: added.
09:30 Changeset [90755] by kov@webkit.org

Indonesian translation
https://bugs.webkit.org/show_bug.cgi?id=44410

Patch by Andika Triwidada <andika@gmail.com> on 2011-07-11
Reviewed by Gustavo Noronha.

  • id.po: updated.
09:26 Changeset [90754] by kov@webkit.org

Portuguese translation update
https://bugs.webkit.org/show_bug.cgi?id=46137

Patch by Duarte Loreto <happyguy_pt@hotmail.com> on 2011-07-11
Reviewed by Gustavo Noronha.

  • pt.po: updated.
09:09 Changeset [90753] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Remove non-existent editing/pasteboard/do-not-copy-body-color.html.
08:58 Changeset [90752] by ossy@webkit.org

[Qt][Mac] Unreviewed fix after r90746.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests): Really disable NRWT for qt-mac platform.

08:55 Changeset [90751] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
08:53 Changeset [90750] by commit-queue@webkit.org

[Qt][WK2] Forward the viewport visible area from the view instead of inferring it from the TiledDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=64275

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-11
Reviewed by Simon Hausmann.

This patch refactors the way the viewport visible area is handled.
Previously, the TiledDrawingAreaProxy would ask for the visible rect
when painting or updating. This is reversed with this patch, and the viewport
informs the page of any change in the view area.

With this change, the TiledDrawingAreaProxy does not need to know about QTouchWebPage,
and can use the TouchViewInterface directly.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setViewportRect):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):
(QTouchWebViewPrivate::viewportRectUpdated):
(QTouchWebView::resizeEvent):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::setVisibleArea):
(WebKit::TiledDrawingAreaProxy::createTiles):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::updateWebView):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::contentSizeChanged):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/WebPageProxyQt.cpp:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::createDrawingAreaProxy):
(QTouchWebPageProxy::setVisibleArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
08:44 Changeset [90749] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
08:38 Changeset [90748] by jberlin@webkit.org

WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles.
https://bugs.webkit.org/show_bug.cgi?id=64285

Add fast/forms/file-input-change-event.html to the mac-wk2 Skipped list to get the bots
green.

  • platform/wk2/Skipped:
08:27 Changeset [90747] by aroben@apple.com

Teach TestFailures that ORWT's results.html file might be missing due to all tests passing

There are three reasons why we might fail to fetch ORWT's results.html:

  • All tests passed, so no results.html was generated
  • Some error during the test run caused results.html not to be generated (e.g., ORWT timed out)
  • Some network error occurred when fetching results.html

We were failing to account for the first possibility in some cases. For test runs before
r89610, we first check build.webkit.org/json to determine how many tests failed and whether
ORWT exited early due to too many failures; if all tests passed then we don't fetch
results.html at all. r89610 changed ORWT to put information in results.html about exiting
early due to too many failures, so we no longer needed to check build.webkit.org/json to get
that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
still needed to check build.webkit.org/json to find out if all tests passed!

Now, for test runs after r89610, we check results.html first, and then check
build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
tests passing and the error cases.

Fixes <http://webkit.org/b/64280> TestFailures page can't pinpoint that r90699 caused 13
tests to fail on Windows 7 Release (WebKit2 Tests)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
cached data will get evicted. We were marking builds where all tests passed as errors!
(LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
parameters to the fetchAndParseResultsHTML helper function, and added a similar
fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
from later in the function). For test runs before r89610, we first check
build.webkit.org/json then check results.html. For builds after r89610, we first check
results.html and then check build.webkit.org/json if we couldn't fetch results.html.

08:15 Changeset [90746] by ossy@webkit.org

new-run-webkit-tests does not support qt-arm or qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

Reviewed by Zoltán Herczeg.

  • Scripts/run-webkit-tests: Disable NRWT for qt-mac, qt-arm and qt-4.8 platforms until fix.

(useNewRunWebKitTests):

07:38 Changeset [90745] by caseq@chromium.org

Reviewed by Pavel Feldman.

Web Inspector: [refactoring] Remove dependencies of components requiring network resource list from network panel
https://bugs.webkit.org/show_bug.cgi?id=62477

Source/WebCore:

  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._inspectedURLChanged):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype.initExtensions):

  • inspector/front-end/HAREntry.js:

(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get resources):
(WebInspector.NetworkLog.prototype._onInspectedURLChanged):
(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._reset):
(WebInspector.NetworkPanel.prototype._copyAll):
(WebInspector.NetworkPanel.prototype._exportAll):

  • inspector/front-end/inspector.js:

(WebInspector.reset):

LayoutTests:

  • http/tests/inspector/resource-har-conversion.html:
07:37 Changeset [90744] by aroben@apple.com

Add back the win-xp and win-wk2 results that were deleted in r90699

Deleting these results caused the tests to start failing on the bots. The only test result I
didn't add back was
win-wk2/http/tests/uri/username-with-no-hostname-expected.txt, as that test is not currently
failing on the bots.

Fixes <http://webkit.org/b/64277> REGRESSION (r90699): 12 svg tests failing on Windows XP
Debug (Tests) and 13 tests failing on Windows 7 Release (WebKit2 Tests)

  • platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.
  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.
  • platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Added.
07:08 Changeset [90743] by podivilov@chromium.org

Web Inspector: make SourceFrame a View.
https://bugs.webkit.org/show_bug.cgi?id=64274

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype._beforeTextChanged):
(WebInspector.SourceFrame.prototype._afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype._suggestedFileName):
(WebInspector.SourceFrame.prototype._doubleClick):
(WebInspector.SourceFrame.prototype._cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):

07:03 Changeset [90742] by commit-queue@webkit.org

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-11
Reviewed by Adam Roben.

Source/WebCore:

Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::setFocus): Forward focus events if the plugin is windowless.

LayoutTests:

New plugin/keyboard-events,mouse-events test expectations for the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375

  • platform/win/plugins/keyboard-events-expected.txt: Added.
  • platform/win/plugins/mouse-events-expected.txt: Updated.
06:54 Changeset [90741] by yael.aharon@nokia.com

[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255

Reviewed by Csaba Osztrogonác.

Modify the tests to wait until the icon loading is finished.

  • fast/notifications/notifications-double-show.html:
  • fast/notifications/notifications-with-permission.html:
  • platform/qt/Skipped:
06:52 Changeset [90740] by ossy@webkit.org

[Qt] Unreviewed gardening.

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

  • platform/qt/test_expectations.txt: Set inspector/cookie-parser.html as flakey test.
06:25 Changeset [90739] by andreas.kling@nokia.com

[Qt][WK2] Move zoomable-area-for-point functionality to QTouchWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=64273

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtWebPageProxy.cpp:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::findZoomableAreaForPoint):
(QTouchWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
05:32 Changeset [90738] by loki@webkit.org

Fix the condition of the optimized code in doubleTransfer
https://bugs.webkit.org/show_bug.cgi?id=64261

Reviewed by Zoltan Herczeg.

The condition of the optimized code in doubleTransfer is wrong. The
data transfer should be executed with four bytes aligned address.
VFP cannot perform unaligned memory access.

Reported by Jacob Bramley.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::doubleTransfer):

05:29 Changeset [90737] by commit-queue@webkit.org

Added accessibility notification when value is changed.
https://bugs.webkit.org/show_bug.cgi?id=64256

Notifies the value change of range input when accessibility is enabled.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-11
Reviewed by Kent Tamura.

Covered by existing tests.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

Added accessibility notification when value is changed.

05:21 Changeset [90736] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove duplicates from Chromium test expectations.

  • platform/chromium/test_expectations.txt:
04:58 Changeset [90735] by mnaganov@chromium.org

Web Inspector: Fix resizing of sidebar pane in Timeline and Profile panels.
https://bugs.webkit.org/show_bug.cgi?id=64161

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):

04:55 Changeset [90734] by pfeldman@chromium.org

Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location.
https://bugs.webkit.org/show_bug.cgi?id=63982

Rolling out 89760, 89756, 89754, 89753 for breaking inspector highlight.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawNodeHighlight):

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/Widget.cpp:
  • platform/Widget.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):

  • rendering/RenderObject.h:

(WebCore::RenderObject::localToAbsoluteQuad):

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

  • rendering/svg/SVGRenderSupport.h:
04:17 Changeset [90733] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r90698.

  • platform/chromium/test_expectations.txt:
04:09 Changeset [90732] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped:
    • Remove non-existent editing tests.
    • Remove fast/selectors/unqualified-hover-strict.html, because it is in test_expectations.txt too.
    • Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it is in test_expectations.txt too.
03:31 Changeset [90731] by loki@webkit.org

Signed arithmetic bug in dataTransfer32.
https://bugs.webkit.org/show_bug.cgi?id=64257

Reviewed by Zoltan Herczeg.

An arithmetic bug is fixed. If the offset of dataTransfer is half of the
addressable memory space on a 32-bit machine (-2147483648 = 0x80000000)
a load instruction is emitted with a wrong zero offset.

Inspired by Jacob Bramley's patch from JaegerMonkey.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):

02:33 Changeset [90730] by yurys@chromium.org

2011-07-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
02:18 Writing Reftests edited by kbalazs@webkit.org
Remove the disclaimer since nrwt has become the default harness (diff)
02:06 Changeset [90729] by abecsi@webkit.org

[Qt] http/tests/plugins/get-url.html is crashing on the bot
https://bugs.webkit.org/show_bug.cgi?id=64168

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt/test_expectations.txt: Do not expect the test to crash any more.
01:56 Changeset [90728] by bashi@chromium.org

Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files
https://bugs.webkit.org/show_bug.cgi?id=64248

Tools:

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-11
Reviewed by Kent Tamura.

  • DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto.
  • GNUmakefile.am: Ditto.

LayoutTests:

Updates test_expectations.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-11
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Removed SKIP from plugins/form-value.html.
01:11 Changeset [90727] by jamesr@google.com

[chromium] Update win/linux pixel expectations for r90701 (part 12/12).

  • platform/chromium-gpu-linux/compositing/geometry/outline-change-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-linux/editing/pasteboard/3976872-expected.png:
  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/dom/34176-expected.png:
  • platform/chromium-linux/fast/dom/HTMLElement/bdo-expected.png:
  • platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.png:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png:
  • platform/chromium-linux/fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/international/003-expected.png:
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-linux/http/tests/misc/iframe404-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1220-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-fixed-container-expected.png:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-vista/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/misc/iframe404-expected.png: Added.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/34176-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/international/003-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/3976872-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-win/fast/css/acid2-pixel-expected.png:
  • platform/chromium-win/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/dom/HTMLElement/bdo-expected.png:
  • platform/chromium-win/fast/forms/001-expected.png:
  • platform/chromium-win/fast/forms/input-first-letter-expected.png:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png:
  • platform/chromium-win/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.txt:
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-win/fast/text/should-use-atsui-expected.png:
  • platform/chromium-win/plugins/embed-attributes-style-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1220-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-fixed-container-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium/test_expectations.txt:
00:51 Changeset [90726] by yutak@chromium.org

WebSocket: Copy existing WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=64242

Reviewed by Kent Tamura.

Copy the existing WebSocket tests under http/tests/websocket/tests/hybi/ and skip them.

These tests will be used to test the latest WebSocket protocol implementation. They are skipped
in all ports for now, and will be unskipped when the new protocol implementation is landed in WebCore.

The following modifications are applied to the new tests:

  • Change paths and URLs appeared in the tests and the test results so they fit for the new location.
  • Call layoutTestController.overridePreferences() to enable the new protocol implementation.
  • http/tests/websocket/tests/hybi/alert-in-event-handler-expected.txt: Added.
  • http/tests/websocket/tests/hybi/alert-in-event-handler.html: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash.html: Added.
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars.html: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty.html: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html: Added.
  • http/tests/websocket/tests/hybi/client-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/client-close.html: Added.
  • http/tests/websocket/tests/hybi/client-close_wsh.py: Added.
  • http/tests/websocket/tests/hybi/close-before-open-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-before-open.html: Added.
  • http/tests/websocket/tests/hybi/close-event-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-event.html: Added.
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload.html: Added.
  • http/tests/websocket/tests/hybi/close-on-unload_wsh.py: Added.
  • http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-unref-websocket.html: Added.
  • http/tests/websocket/tests/hybi/cross-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/cross-origin.html: Added.
  • http/tests/websocket/tests/hybi/echo-challenge_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo-cookie_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo-location_wsh.py: Added.
  • http/tests/websocket/tests/hybi/echo_wsh.py: Added.
  • http/tests/websocket/tests/hybi/error-detect-expected.txt: Added.
  • http/tests/websocket/tests/hybi/error-detect.html: Added.
  • http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip.html: Added.
  • http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Added.
  • http/tests/websocket/tests/hybi/frame-lengths-expected.txt: Added.
  • http/tests/websocket/tests/hybi/frame-lengths.html: Added.
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness.html: Added.
  • http/tests/websocket/tests/hybi/handshake-error-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-error.html: Added.
  • http/tests/websocket/tests/hybi/handshake-error_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Added.
  • http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Added.
  • http/tests/websocket/tests/hybi/httponly-cookie-expected.txt: Added.
  • http/tests/websocket/tests/hybi/httponly-cookie.pl: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header.html: Added.
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py: Added.
  • http/tests/websocket/tests/hybi/multiple-connections-expected.txt: Added.
  • http/tests/websocket/tests/hybi/multiple-connections.html: Added.
  • http/tests/websocket/tests/hybi/no-query_wsh.py: Added.
  • http/tests/websocket/tests/hybi/null-character-expected.txt: Added.
  • http/tests/websocket/tests/hybi/null-character.html: Added.
  • http/tests/websocket/tests/hybi/origin-test_wsh.py: Added.
  • http/tests/websocket/tests/hybi/protocol-test_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reload-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reload-crash.html: Added.
  • http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html: Added.
  • http/tests/websocket/tests/hybi/resources/close-on-unload-iframe.html: Added.
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html: Added.
  • http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html: Added.
  • http/tests/websocket/tests/hybi/send-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-throw-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-throw.html: Added.
  • http/tests/websocket/tests/hybi/send.html: Added.
  • http/tests/websocket/tests/hybi/send2_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send_wsh.py: Added.
  • http/tests/websocket/tests/hybi/server-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/server-close.html: Added.
  • http/tests/websocket/tests/hybi/server-close_wsh.py: Added.
  • http/tests/websocket/tests/hybi/simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/simple-stress-expected.txt: Added.
  • http/tests/websocket/tests/hybi/simple-stress.html: Added.
  • http/tests/websocket/tests/hybi/simple.html: Added.
  • http/tests/websocket/tests/hybi/simple_wsh.py: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space.html: Added.
  • http/tests/websocket/tests/hybi/sub-protocol.html: Added.
  • http/tests/websocket/tests/hybi/unicode-expected.txt: Added.
  • http/tests/websocket/tests/hybi/unicode.html: Added.
  • http/tests/websocket/tests/hybi/unicode_wsh.py: Added.
  • http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Added.
  • http/tests/websocket/tests/hybi/url-no-trailing-slash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-no-trailing-slash.html: Added.
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-parsing.html: Added.
  • http/tests/websocket/tests/hybi/url-with-credential-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-credential.html: Added.
  • http/tests/websocket/tests/hybi/url-with-empty-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-empty-query.html: Added.
  • http/tests/websocket/tests/hybi/url-with-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Added.
  • http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Added.
  • http/tests/websocket/tests/hybi/url-with-query.html: Added.
  • http/tests/websocket/tests/hybi/websocket-event-target-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-event-target.html: Added.
  • http/tests/websocket/tests/hybi/websocket-pending-activity-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-pending-activity.html: Added.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-worker-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-in-worker.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/close-in-onmessage-crash.js: Added.

(runTests.try.ws.onopen):
(runTests.try.ws.onmessage):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/close-in-worker.js: Added.

(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.ws.onopen):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/echo-challenge_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/echo_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/simple_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/worker-handshake-challenge-randomness.js: Added.

(endTest):
(runTests.try.ws1.onmessage):
(runTests.try.ws1.onclose.ws2.onmessage):
(runTests.try.ws1.onclose.ws2.onclose):
(runTests.try.ws1.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/resources/worker-simple.js: Added.

(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.ws.onopen):
(runTests.try.ws.onmessage):
(runTests.try.ws.onclose):
(runTests):

  • http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/shared-worker-simple.html: Added.
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness.html: Added.
  • http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-simple.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

A category "failing websocket tests" is listed at the beginning of Skipped file,
but there is no such section in the lists. Thus, a new section is inserted.

  • platform/win/Skipped:
  • platform/wk2/Skipped:
00:45 Changeset [90725] by jamesr@google.com

[chromium] Update win/linux pixel expectations for r90701 (part 11/??).

  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cellspacing-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nested2-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/padding-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla/other/cellspacing-expected.png:
  • platform/chromium-win/tables/mozilla/other/nested2-expected.png:
  • platform/chromium-win/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-win/tables/mozilla/other/padding-expected.png:
  • platform/chromium-win/tables/mozilla/other/test3-expected.png:
  • platform/chromium-win/tables/mozilla/other/test6-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium/test_expectations.txt:
00:24 Changeset [90724] by jamesr@google.com

[chromium] Update win/linux pixel expectations for r90701 (part 10/??).

  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_col_width_rel-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellspacing-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_col_width_rel-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellspacing-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_middle-expected.png:
  • platform/chromium/test_expectations.txt:
00:06 Changeset [90723] by commit-queue@webkit.org

Patch by Mustafizur Rahaman <mustaf.here@gmail.com> on 2011-07-11
Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48292

and

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48302

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationAtop
to draw transparency elsewhere for destination-atop

LayoutTests:

  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt: Added

a trailing line

  • fast/canvas/canvas-composite-alpha.html: Rebaselined for destination-atop test case
  • platform/chromium/test_expectations.txt: Removed passing test case
  • platform/gtk/Skipped: Ditto
  • platform/mac/Skipped: Ditto
  • platform/qt/Skipped: Ditto
00:03 Changeset [90722] by jamesr@google.com

[chromium] Update win/linux pixel expectations for r90701 (part 9/??).

  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_cellpadding-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_td_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_char-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_cellpadding-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_td_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_char-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.