Timeline


and

07/19/11:

23:32 Changeset [91342] by leo.yang@torchmobile.com.cn

Unreviewed. Rebaseline test expectations for Windows after r91331.
platform/win/fast/dom/Window/window-property-descriptors-expected.txt
platform/win/fast/dom/prototype-inheritance-expected.txt
platform/win/fast/js/global-constructors-expected.txt

23:28 Changeset [91341] by loki@webkit.org

Move platform independent expected.txts out of platform/mac
https://bugs.webkit.org/show_bug.cgi?id=64796

Reviewed by Rob Buis.

  • fast/css/replaced-element-implicit-size-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/replaced-element-implicit-size-expected.txt.
  • svg/custom/zero-path-square-cap-rendering-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/zero-path-square-cap-rendering-expected.txt.
23:11 Changeset [91340] by leo.yang@torchmobile.com.cn

Unreviewed. Rebaseline JS and DOM test expectations after r91331.

fast/js/global-constructors-expected.txt
fast/dom/prototype-inheritance-2-expected.txt
fast/dom/prototype-inheritance-expected.txt
fast/dom/Window/window-properties-expected.txt
fast/dom/Window/window-property-descriptors-expected.txt
svg/custom/global-constructors-expected.txt

22:59 Changeset [91339] by leo.yang@torchmobile.com.cn

Unreviewed. Rebaseline test expectations for Mac after r91331.

platform/mac/svg/text/text-altglyph-01-b-expected.txt
platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt

22:53 Changeset [91338] by leo.yang@torchmobile.com.cn

Unreviewed. Rebasline chromium test expectation after r91331.

22:52 Changeset [91337] by sjl@chromium.org

[chromium] Media player controls do not fade out.
https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):

  • html/shadow/MediaControlRootElementChromium.h:
22:41 Changeset [91336] by macpherson@chromium.org

Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64846

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCounter
Added class to handle counter properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize counter property handlers.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove old handlers.

22:31 Changeset [91335] by caio.oliveira@openbossa.org

[Qt] Improve documentation of QWebView::setPage()
https://bugs.webkit.org/show_bug.cgi?id=64827

Reviewed by Noam Rosenthal.

  • Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.
22:19 Changeset [91334] by hayato@chromium.org

[chromium] More chromium rebaseline for r91249.
Unreviewed.

  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.
21:46 Changeset [91333] by tkent@chromium.org

REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback.
https://bugs.webkit.org/show_bug.cgi?id=64314

Reviewed by Sam Weinig.

No new tests because it's hard to make a non-flaky test for this behavior.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
Don't call SliderThumbElement::dragFrom() for events on the thumb.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
Do not call setDefaultHandled() for mouse events in order to
propagate them to ancestor elements.

21:24 Changeset [91332] by mdelaney@apple.com

Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

  • platform/graphics/ImageBuffer.h:

1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.

  • platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
  • platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

  • platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:

  • platform/graphics/qt/ImageBufferQt.cpp
  • platform/graphics/filters/FETile.cpp
  • platform/graphics/cairo/ImageBufferCairo.cpp
  • platform/graphics/skia/ImageBufferSkia.cpp
  • platform/graphics/wx/ImageBufferWx.cpp
  • platform/graphics/wince/ImageBufferWinCE.cpp
  • svg/SVGFEImageElement.cpp
  • svg/graphics/SVGImage.cpp
  • html/HTMLCanvasElement.cpp
  • html/canvas/WebGLRenderingContext.cpp
  • rendering/svg/RenderSVGResourcePattern.cpp
19:48 Changeset [91331] by leo.yang@torchmobile.com.cn

SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=60850

Reviewed by Nikolas Zimmermann.

SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
elements for alternative glyph features.

Source/WebCore:

NOTE: x, y, dx, dy, format and glyphRef attributes on <glyphRef> are not
honored yet, so neither are the reaction of dynamic change of them. They
will be honored in separated patches.

Test: svg/W3C-SVG-1.1/text-altglyph-01-b.svg
With this patch this test works as expected.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMSVG.h:
  • page/DOMWindow.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAltGlyphDefElement.cpp: Added.

(WebCore::SVGAltGlyphDefElement::SVGAltGlyphDefElement):
(WebCore::SVGAltGlyphDefElement::create):
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphDefElement.h: Added.
  • svg/SVGAltGlyphDefElement.idl: Added.
  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.cpp: Added.

(WebCore::SVGAltGlyphItemElement::SVGAltGlyphItemElement):
(WebCore::SVGAltGlyphItemElement::create):
(WebCore::SVGAltGlyphItemElement::hasValidGlyphElements):

  • svg/SVGAltGlyphItemElement.h: Added.
  • svg/SVGAltGlyphItemElement.idl: Added.
  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGGlyphRefElement.cpp: Added.

(WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
(WebCore::SVGGlyphRefElement::create):
(WebCore::SVGGlyphRefElement::hasValidGlyphElement):
(WebCore::SVGGlyphRefElement::parseMappedAttribute):
(WebCore::SVGGlyphRefElement::glyphRef):
(WebCore::SVGGlyphRefElement::setGlyphRef):
(WebCore::SVGGlyphRefElement::setX):
(WebCore::SVGGlyphRefElement::setY):
(WebCore::SVGGlyphRefElement::setDx):
(WebCore::SVGGlyphRefElement::setDy):

  • svg/SVGGlyphRefElement.h: Added.
  • svg/SVGGlyphRefElement.idl: Added.
  • svg/svgtags.in:

Source/WebKit/mac:

  • MigrateHeaders.make:

LayoutTests:

Updated test expectation.

  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
19:41 Changeset [91330] by rniwa@webkit.org

Unreviewed. Rolled DEPS.

  • DEPS:
19:13 Changeset [91329] by rniwa@webkit.org

Chromium test expectation update. svg/custom/crash-textPath-attributes.html is hitting an assertion.
The failure is tracked by the bug 64844.

  • platform/chromium/test_expectations.txt:
18:18 Changeset [91328] by aroben@apple.com

Skip some more tests on WebKit2 that rely on unimplemented test harness APIs

  • platform/wk2/Skipped: Added svg/animations/svgtransform-animation-discrete.html and

fast/forms/input-search-press-escape-key.html.

18:15 Changeset [91327] by rniwa@webkit.org

Apparently my rebaseline was incorrect for r91294.

Remove expected results and skip compositing/scaling/tiled-layer-recursion.html on Chromium
because it's missing expected results.

  • platform/chromium/test_expectations.txt:
18:00 Changeset [91326] by lforschler@apple.com

New tag.

17:48 Changeset [91325] by aroben@apple.com

Remove some unused code in FormDataStreamCFNet

Rubber-stamped by Steve Falkenburg.

  • platform/network/cf/FormDataStreamCFNet.cpp:
17:46 Changeset [91324] by simon.fraser@apple.com

2011-07-19 Simon Fraser <simon.fraser@apple.com>

REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64808

Reviewed by Adam Roben.

Initializing m_uncommittedChanges to a non-zero value
caused the first call to noteLayerPropertyChanged() to
not call m_client->notifySyncRequired(). This resulted in
animations never getting committed on Windows, which broke
a lot of tests.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA):
17:29 Changeset [91323] by eric@webkit.org

parse-malloc-history always exits 1, causing NRWT to fail
https://bugs.webkit.org/show_bug.cgi?id=64835

Reviewed by Adam Barth.

ORWT just never checked the return code. :)

  • Scripts/parse-malloc-history:

(main):

  • Scripts/webkitpy/layout_tests/port/mac.py:
17:07 Changeset [91322] by jamesr@google.com

[chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
https://bugs.webkit.org/show_bug.cgi?id=64834

Reviewed by Kenneth Russell.

Uses setters and getters to access RenderSurfaceChromium's private member variables instead of directly
accessing them via a friend declaration. This cleans up a minor code smell and will be helpful for future
refactoring.

Refactor only, no change in behavior. Tested by compositing/ tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::clearLayerList):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::contentRect):
(WebCore::RenderSurfaceChromium::setContentRect):
(WebCore::RenderSurfaceChromium::drawOpacity):
(WebCore::RenderSurfaceChromium::setDrawOpacity):
(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::maskLayer):
(WebCore::RenderSurfaceChromium::setMaskLayer):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::scissorRect):
(WebCore::RenderSurfaceChromium::setScissorRect):
(WebCore::RenderSurfaceChromium::skipsDraw):
(WebCore::RenderSurfaceChromium::setSkipsDraw):
(WebCore::RenderSurfaceChromium::contentsTexture):

16:21 Changeset [91321] by simon.fraser@apple.com

2011-07-19 Simon Fraser <simon.fraser@apple.com>

Skip compositing/scaling/tiled-layer-recursion.html on chromium
and Windows because it requires the scalePageBy DRT API.

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
16:18 Changeset [91320] by jberlin@webkit.org

GTK + QT build fix.

Rubber-stamped by Daniel Bates and Alexey Proskuryakov.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

16:14 Changeset [91319] by crogers@google.com

Fix web audio compile on mac port
https://bugs.webkit.org/show_bug.cgi?id=64836

Unreviewed build fix.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):
(WebCore::JSAudioContext::createBuffer):

16:14 Changeset [91318] by kevino@webkit.org

[wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.

15:58 Changeset [91317] by rniwa@webkit.org

Build fix after r91307.

  • Platform/Logging.h:
15:57 Changeset [91316] by jberlin@webkit.org

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Reviewed by Alexey Proskuryakov.

Make these unexpected cases crash in the WebKit nightlies so we can gather more
information and potentially find a repro case.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

15:56 Changeset [91315] by eric@webkit.org

new-run-webkit-tests should only enable MallocStackLogging for DRT
https://bugs.webkit.org/show_bug.cgi?id=64792

Reviewed by Adam Barth.

The previous code would enable it for all servers launched
by the port, which included Apache, the python websocket server
as well as ImageDiff. Now only DumpRenderTree will have
MallocStackLogging enabled or the GuardMalloc library injected.

I also cleaned up the websocket_server code to use filesystem
while I was in it.

I also made DRT restart every 1000 tests when running with
--leaks enabled. I believe this made the --leaks run slightly
faster, but it still takes over an hour on my machine. :(

  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:
15:49 Changeset [91314] by mitz@apple.com

Nothing printed when specifying a very large maximum layout width
https://bugs.webkit.org/show_bug.cgi?id=64831

Reviewed by Beth Dakin.

I am not adding a test because the DumpRenderTree printing test machinery is based on PrintContext,
which does not exercise the code path on which this bug lies.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination): Fixed an integer overflow.

15:48 Changeset [91313] by ojan@chromium.org

remove the concept of platform fallbacks
https://bugs.webkit.org/show_bug.cgi?id=64829

Reviewed by Adam Barth.

In the process, wrote tests for this code and fixed a pretty major
bug (now covered by the test).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:46 Changeset [91312] by ojan@chromium.org

cleanup some of the PLATFORM logic in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64821

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:44 Changeset [91311] by dglazkov@chromium.org

Store line number on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64800

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
15:21 Changeset [91310] by rniwa@webkit.org

Chromium rebaseline for r91294. Also filed the bug 64828 to track the crash on Chromium Mac.

  • platform/chromium-gpu-linux/compositing/scaling: Added.
  • platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-win/compositing/scaling: Added.
  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:13 Changeset [91309] by japhet@chromium.org

Source/WebCore: [V8] Wait until no v8 context is on the stack before
cancelling pending indexed db transactions.
https://bugs.webkit.org/show_bug.cgi?id=64552

Reviewed by Adam Barth.

Test: storage/indexeddb/transaction-abort-with-js-recursion.html

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64552.

Reviewed by Adam Barth.

  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt: Added.
  • storage/indexeddb/transaction-abort-with-js-recursion.html: Added.
15:08 Changeset [91308] by inferno@chromium.org

Source/WebCore: Crash in CompositeEditCommand::replaceTextInNodePreservingMarkers.
https://bugs.webkit.org/show_bug.cgi?id=64738

Patch by MORITA Hajime <morrita@google.com> on 2011-07-19
Reviewed by Ryosuke Niwa.

Test: editing/undo/replace-text-in-node-preserving-markers-crash.html

  • editing/CompositeEditCommand.cpp:

(WebCore::copyMarkers):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

LayoutTests: Sending a Ping-From header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

  • http/tests/navigation/ping-cross-origin-expected.txt:
15:07 Changeset [91307] by commit-queue@webkit.org

[GTK] [WK2] Implement missing initializeLogChannel function.
https://bugs.webkit.org/show_bug.cgi?id=63381

Patch by Lukasz Slachciak <lukasz.slachciak@gmail.com> on 2011-07-19
Reviewed by Martin Robinson.

Implemented logging for GTK platform in WebKit2 - function initializeLogChannel is called for all ports,
so added missing implementation. Aslo helper function added for getting channels from names.

  • GNUmakefile.am: Added reference to new file LoggingGtk.cpp.
  • Platform/Logging.cpp: Logging implementation for GTK port enabled.

(WebKit::getChannelFromName): Helper to connect name with WTFLogChannel.

  • Platform/Logging.h: New helper method added.
  • Platform/gtk/LoggingGtk.cpp: Added. GTK logging implementation.

(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.

14:56 Changeset [91306] by commit-queue@webkit.org

Sending a Ping-From header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

Source/WebCore:

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

LayoutTests:

  • http/tests/navigation/ping-cross-origin-expected.txt:
14:51 Changeset [91305] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64809
REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

Reviewed by Adam Roben.

I think this just needs new results. The test deliberately triggers a stack overflow,
and doesn't catch it, so the error is printed to the console. Previously RangeError
had the wrong prototype, and didn't convert the error into a useful error message,
printing a blank line in the console. Since r91116 we inherit from Error correctly,
and print the error to the console.

  • fast/dom/error-to-string-stack-overflow-expected.txt:
  • fast/js/script-tests/object-prototype-properties.js:
14:49 Changeset [91304] by ojan@chromium.org

fix flakiness dashboard for XP bots with XP in the name instead of WIN
https://bugs.webkit.org/show_bug.cgi?id=64826

Reviewed by Mihai Parparita.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
14:39 Changeset [91303] by rniwa@webkit.org

More Chromium rebaselines for r91277.

  • platform/chromium-linux/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
14:31 Changeset [91302] by caio.oliveira@openbossa.org

[Qt] Fix leak of QWebPage in errorPageExtension tests
https://bugs.webkit.org/show_bug.cgi?id=64814

Reviewed by Noam Rosenthal.

QWebView::setPage() doesn't take ownership, so the ErrorPages were leaking. So now
allocate them on the stack. This shouldn't change any behavior.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtension):
(tst_QWebPage::errorPageExtensionInIFrames):
(tst_QWebPage::errorPageExtensionInFrameset):

14:22 Changeset [91301] by tony@chromium.org

[chromium] remove BUG_DRT tests that the flakiness dashboard say are passing
https://bugs.webkit.org/show_bug.cgi?id=64819

Reviewed by Ryosuke Niwa.

  • platform/chromium/test_expectations.txt:
14:09 Changeset [91300] by levin@chromium.org

Bring V8's SerializedScriptValue implementation up to date.

https://bugs.webkit.org/show_bug.cgi?id=63481

Source/WebCore:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

The HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data) has been updated since the V8 version of SerializedScriptValue was first implemented. This patch aims to bring this implementation up to date. It:

  • Introduces the new HTML5 DOM error codes for TIMEOUT_ERR, INVALID_NODE_TYPE_ERR, DATA_CLONE_ERR
  • Handles cyclic structures and equality of reference preservation for cloned values
  • Allows DataViews to be constructed on the native side using the existing wrapper techniques
  • Amends tests and introduces new ones to check for correctness (the bulk of the patch)
  • Tolerates the old version of the serialized object format

The patch permits the cloning of JavaScript typed arrays. This functionality is in active use already and was supported (somewhat inefficiently) by the existing code through an artifact of implementation.

Tests: fast/dom/Window/window-postmessage-clone-deep-array.html

fast/dom/Window/window-postmessage-clone-really-deep-array.html
fast/dom/Window/window-postmessage-clone.html
fast/canvas/webgl/array-message-passing.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeVersion):
(WebCore::V8ObjectMap::Writer::writeArrayBuffer):
(WebCore::V8ObjectMap::Writer::writeArrayBufferView):
(WebCore::V8ObjectMap::Writer::writeObjectReference):
(WebCore::V8ObjectMap::Writer::writeReferenceCount):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshObject):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshArray):
(WebCore::V8ObjectMap::Writer::doWriteArrayBuffer):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::serialize):
(WebCore::V8ObjectMap::Serializer::StateBase::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::AbstractObjectState):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::advance):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::execDepth):
(WebCore::V8ObjectMap::Serializer::push):
(WebCore::V8ObjectMap::Serializer::pop):
(WebCore::V8ObjectMap::Serializer::handleError):
(WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
(WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
(WebCore::V8ObjectMap::Serializer::greyObject):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::Reader):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readVersion):
(WebCore::V8ObjectMap::Reader::setVersion):
(WebCore::V8ObjectMap::Reader::undoReadTag):
(WebCore::V8ObjectMap::Reader::readArrayBufferViewSubTag):
(WebCore::V8ObjectMap::Reader::doReadArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBufferView):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::deserialize):
(WebCore::V8ObjectMap::Deserializer::newArray):
(WebCore::V8ObjectMap::Deserializer::consumeTopOfStack):
(WebCore::V8ObjectMap::Deserializer::completeArray):
(WebCore::V8ObjectMap::Deserializer::newObject):
(WebCore::V8ObjectMap::Deserializer::completeObject):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::pushObjectReference):
(WebCore::V8ObjectMap::Deserializer::tryGetObjectFromObjectReference):
(WebCore::V8ObjectMap::Deserializer::objectReferenceCount):
(WebCore::V8ObjectMap::Deserializer::openComposite):
(WebCore::V8ObjectMap::Deserializer::closeComposite):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::isHostObject):

  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • dom/DOMCoreException.idl:
  • dom/ExceptionCode.cpp:
  • dom/ExceptionCode.h:
  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::create):

  • html/canvas/ArrayBuffer.h:
  • html/canvas/DataView.cpp:

(WebCore::DataView::create):

  • html/canvas/DataView.h:

LayoutTests:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

This patch refactors window-postmessage-clone into a script test, checks additional functionality set forth in the standard, and fixes up expectations. It also checks for typed array message passing.

  • fast/canvas/webgl/array-message-passing-expected.txt: Added.
  • fast/canvas/webgl/array-message-passing.html: Added.
  • fast/canvas/webgl/script-tests/array-message-passing.js: Added.

(classCompare):
(bufferCompare):
(viewCompare):
(typedArrayCompare):
(dataViewCompare):
(createBuffer):
(createTypedArray):
(createTypedArrayOverBuffer):
(testList):
(doneTest):
(windowHandleMessage):

  • fast/dom/Window/script-tests/postmessage-clone-deep-array.js: Added.
  • fast/dom/Window/script-tests/postmessage-clone-really-deep-array.js: Added.
  • fast/dom/Window/script-tests/postmessage-clone.js: Added.

(thunk):

  • fast/dom/Window/script-tests/postmessage-test.js: Copied from LayoutTests/fast/dom/Window/window-postmessage-clone.html.

():
(safeToString):
(shouldBe):
(shouldBeIdentical):
(doPass):
(doFail):
(window.doPassFail):
(onmessage):
(ConstructorWithPrototype):
(window.tryPostMessage):

  • fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
  • fast/dom/Window/window-postmessage-clone-deep-array.html: Added.
  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
  • fast/dom/Window/window-postmessage-clone-really-deep-array.html: Added.
  • fast/dom/Window/window-postmessage-clone.html:
  • fast/dom/Window/window-properties-expected.txt: Also fixed this due to r91061.
  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
14:06 Changeset [91299] by rwlbuis@webkit.org

2011-07-19 Rob Buis <rbuis@rim.com>

REGRESSION (r91187-r91192): svg/W3C-SVG-1.1/animate-elem-80-t.svg failing on SnowLeopard Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64820

Reviewed by Darin Adler.

Update result after r91192.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
14:03 Changeset [91298] by rniwa@webkit.org

Chromium rebaseline after r91290.

  • platform/chromium/fast/js/array-prototype-properties-expected.txt: Added.
13:47 Changeset [91297] by commit-queue@webkit.org

Adds some methods to retrieve accessible information from tables and
table cells. Also refactors WebAccessibilityObject to use WebPrivatePtr
instead of its own implementation that didn't allow access to subclasses
of AccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=64805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-07-19
Reviewed by Dimitri Glazkov.

  • public/WebAccessibilityObject.h:

(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::isNull):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::reset):
(WebKit::WebAccessibilityObject::assign):
(WebKit::WebAccessibilityObject::equals):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::isValid):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::setFocused):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::hasComputedStyle):
(WebKit::WebAccessibilityObject::computedStyleDisplay):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):
(WebKit::WebAccessibilityObject::cellForColumnAndRow):
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::operator=):
(WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):

13:44 BuildingGtk edited by levin@chromium.org
Added information setting up dependencies for Linux when working on … (diff)
13:40 Changeset [91296] by rniwa@webkit.org

Chromium Windows rebaseline after r91277, and Chromium rebaseline for r91284.

  • platform/chromium/fast/js/string-prototype-properties-expected.txt: Added.
  • platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.png: Added.
13:33 Changeset [91295] by commit-queue@webkit.org

[Chromium] Need to remove app/ from DEPS
https://bugs.webkit.org/show_bug.cgi?id=64750

Patch by Robert Sesek <rsesek@chromium.org> on 2011-07-19
Reviewed by Tony Chang.

.:

Remove Source/WebKit/chromium/app/ from .gitignore.

  • .gitignore:

Source/WebKit/chromium:

Roll DEPS and remove dependencies on Chromium's /src/app.

  • DEPS:
  • WebKit.gyp:
13:32 Changeset [91294] by simon.fraser@apple.com

2011-07-19 Simon Fraser <simon.fraser@apple.com>

Possible recursion in GraphicsLayerCA::updateGeometry()
https://bugs.webkit.org/show_bug.cgi?id=64815

Reviewed by Sam Weinig.

It was possible to recurse via updateGeometry/swapFromOrToTiledLayer/
updateContentsScale because updateGeometry() and updateContentsScale()
used different sizes; updateGeometry() used the scaled size, while
updateContentsScale() used the unscaled size.

Always use the unscaled size; the scaled size will be at most a couple
of pixels bigger, and our threshold is not close to the max texture
size limit, so using the slightly smaller size is OK.

Test: compositing/scaling/tiled-layer-recursion.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateGeometry): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::updateContentsScale): (WebCore::GraphicsLayerCA::requiresTiledLayer):
  • platform/graphics/ca/GraphicsLayerCA.h:
13:20 Changeset [91293] by rwlbuis@webkit.org

2011-07-19 Rob Buis <rbuis@rim.com>

REGRESSION (r89951): svg/foreignObject/text-tref-02-b.svg failing on Leopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64817

Rubber stamped by Darin Adler.

Remove outdated, incorrect test results, hopefully the generic mac results are good enough.

  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Removed.
  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
13:08 Changeset [91292] by robert@webkit.org

Add platform-specific results for r91277.

Unreviewed, add platform-specific results.

  • platform/gtk/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
13:06 Changeset [91291] by caryclark@google.com

add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=64816

No review needed.

  • Scripts/webkitpy/common/config/committers.py:
13:03 Changeset [91290] by barraclough@apple.com

Source/JavaScriptCore: [JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

LayoutTests: Chromium rebaselines r91269 and r91277.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-19

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
12:55 Changeset [91289] by gavinp@chromium.org

Revert 91204, Merge 90595 BUG=87729

12:49 Changeset [91288] by commit-queue@webkit.org

[JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

12:40 Changeset [91287] by rniwa@webkit.org

Chromium rebaselines r91269 and r91277.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
12:32 Changeset [91286] by commit-queue@webkit.org

[CSSRegions]Parse -webkit-region-overflow property
https://bugs.webkit.org/show_bug.cgi?id=64444

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-region-overflow-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionOverflow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialRegionOverflow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/regions/script-tests/webkit-region-overflow-parsing.js: Added.
  • fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
  • fast/regions/webkit-region-overflow-parsing.html: Added.
12:25 Changeset [91285] by commit-queue@webkit.org

hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block.

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Test: fast/dynamic/hover-before-position-after-style-change.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

  • fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
  • fast/dynamic/hover-before-position-after-style-change.html: Added.
12:16 Changeset [91284] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64677
Fix bugs in String.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to
the global object, and primitive values should not be converted via
object types.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):

  • These methods should throw if this value is undefined, convert ToString directly, not via ToObject.

LayoutTests:

  • fast/js/script-tests/string-prototype-properties.js: Added.
  • fast/js/string-prototype-properties-expected.txt: Added.
  • fast/js/string-prototype-properties.html: Added.
    • Added layout test for string prototype functions with undefined/number as this value.
12:13 Changeset [91283] by macpherson@chromium.org

Implement CSSPropertyWebkitPerspectiveOrigin in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64784

Reviewed by Simon Fraser.

No new tests / refactoring.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

12:00 Changeset [91282] by dbates@webkit.org

Rename variable isEmptyTextPatch in svn-{apply, unapply}
https://bugs.webkit.org/show_bug.cgi?id=64648

Reviewed by Adam Roben.

Rename the variable isEmptyTextPatch to hasTextChunks, which is
more descriptive and makes its usage read well in control statements.

  • Scripts/svn-apply:

(patch):

  • Scripts/svn-unapply:

(patch):

11:59 Changeset [91281] by crogers@google.com

Implement WaveShaperNode for Web Audio API
https://bugs.webkit.org/show_bug.cgi?id=64644

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWaveShaperNodeCustom.cpp: Added.

(WebCore::JSWaveShaperNode::setCurve):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createWaveShaper):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/WaveShaperDSPKernel.cpp: Added.

(WebCore::WaveShaperDSPKernel::process):

  • webaudio/WaveShaperDSPKernel.h: Added.

(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::waveShaperProcessor):

  • webaudio/WaveShaperNode.cpp: Added.

(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setCurve):
(WebCore::WaveShaperNode::curve):

  • webaudio/WaveShaperNode.h: Added.

(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::waveShaperProcessor):

  • webaudio/WaveShaperNode.idl: Added.
  • webaudio/WaveShaperProcessor.cpp: Added.

(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::~WaveShaperProcessor):
(WebCore::WaveShaperProcessor::createKernel):
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::process):

  • webaudio/WaveShaperProcessor.h: Added.

(WebCore::WaveShaperProcessor::curve):

11:55 Changeset [91280] by commit-queue@webkit.org

DFG JIT sometimes emits spill code even when the respective values
are never needed.
https://bugs.webkit.org/show_bug.cgi?id=64774

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-19
Reviewed by Gavin Barraclough.

The main high-level change is that it is now easier to call use() on a
virtual register. JSValueOperand and its other-typed relatives now have
a handy use() method, and jsValueResult() and friends now make it easier to
pass UseChildrenCalledExplicitly.

The rest of this patch hoists the call to use() as high as possible for
all of those cases where either flushRegisters() or silentSpillAllRegisters()
may be called.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::use):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateCellOperand::use):

11:52 Changeset [91279] by cevans@google.com

Revert 91274 - Merge 91148
BUG=89552
Review URL: http://codereview.chromium.org/7443008

11:51 Changeset [91278] by aroben@apple.com

Make TestFailures show existing bugs and a new bug link for flaky tests

Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
flaky tests
and
<http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
tests, but should

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:

Added. This is what's used to file new bugs about flaky tests.
(FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
title, description, and URL.

(FlakyTestBugForm.prototype._createBugDescription):
(FlakyTestBugForm.prototype._createBugTitle):
These do what they say.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:

Added. Tests of the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
(#possibly-flaky-tests > li > :first-child):
(.flakiness-examples-list):
Styling to account for the new elements.

(.expandable):
(.expanded > .expandable):
Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
transition properties because we can't transition to/from 'auto' (but really would like
to!).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
(ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
argument instead of creating one ourselves.
(ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
an argument instead of just the number of analyzed builds. Put the examples list inside a
container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
with animating the height of the examples list; we don't do this anymore because it's hard
to make it work correctly with the asynchronous loading of existing bugs. When we populate
the examples list, also set up the new/existing bug UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

FlakyTestBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pull in FlakyTestBugForm and its tests.

11:40 Changeset [91277] by robert@webkit.org

REGRESSION: Incorrect layout at recline-online.com
https://bugs.webkit.org/show_bug.cgi?id=64030

Reviewed by David Hyatt.

Source/WebCore:

http://trac.webkit.org/changeset/68362 dropped the check for cases
where the render box is floating or inline. When the box is left or right
aligned it is considered to be floating and needs to its margins set appropriately.

Test: fast/table/align-right-within-left-aligned-div.html

created by Dominic Cooney <dominicc@chromium.org>

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeInlineDirectionMargins):

LayoutTests:

  • fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • fast/table/align-right-within-left-aligned-div.html: Added.
11:36 Changeset [91276] by cevans@google.com

Merge 91270
BUG=89678
Review URL: http://codereview.chromium.org/7446011

11:33 Changeset [91275] by xan@webkit.org

ARMv7 backend broken, lacks 3 parameter rshift32 method
https://bugs.webkit.org/show_bug.cgi?id=64571

Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method.

11:33 Changeset [91274] by cevans@google.com

Merge 91148
BUG=89552
Review URL: http://codereview.chromium.org/7446010

11:21 Changeset [91273] by rniwa@webkit.org

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Tony Chang.

Added "missing results" label for tests that are missing results.

buildbot Now reports shows a label "X missing results" on a run when X tests were missing
expected results on that run.

Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:11 Changeset [91272] by aroben@apple.com

Extract some of FailingTestsBugForm's code into a base class

Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
file bugs about flaky tests

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
TestRelatedBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:

Moved some tests to TestRelatedBugForm_unittests.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.

(TestRelatedBugForm):
(TestRelatedBugForm.prototype.domElement):
(TestRelatedBugForm.prototype._computeOperatingSystem):
(TestRelatedBugForm.prototype._computePlatform):
Code came from FailingTestsBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:

Added. Tests came from FailingTestsBugForm_unittests.js

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:

Added. Code came from FailingTestsBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
need to be pulled in early for parsing reasons.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pull in TestRelatedBugForm and tests and WebKitBugzilla.

10:40 Changeset [91271] by bweinstein@apple.com

Add back a change that was accidentally removed in r91266.

Make sure to retain the WKPasteboardFilePromiseOwner before calling draggedImage because draggedImage releases
its responder. Also make the comment more explicit, to keep this mistake from being made in the future.

Rubber-stamped by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::dragEnded):

10:39 Changeset [91270] by inferno@chromium.org

Source/WebCore: Crash when removing unrenderered nodes in replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):

LayoutTests: Tests that we do not crash when removing unrendering nodes
in a replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.
10:26 Changeset [91269] by rwlbuis@webkit.org

2011-07-19 Rob Buis <rbuis@rim.com>

https://bugs.webkit.org/show_bug.cgi?id=64673
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html

Reviewed by Nikolas Zimmermann.

Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.

Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg

  • svg/SVGTRefElement.cpp: (WebCore::SubtreeModificationEventListener::handleEvent):
10:22 Changeset [91268] by tony@chromium.org

use more specific types in CSSFlexValue
https://bugs.webkit.org/show_bug.cgi?id=64763

Reviewed by Ojan Vafai.

No new tests because no change in functionality.

  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::create):
(WebCore::CSSFlexValue::isFlexValue): Make it possible to tell if

we're a flex value or not. Will be needed when we're copying
values to RenderStyle.

(WebCore::CSSFlexValue::positiveFlex): Use floats for positive and

negative flex because in the render code, we use floats.

(WebCore::CSSFlexValue::negativeFlex): Add accessors for these since

we'll need it when reading the flex values.

(WebCore::CSSFlexValue::preferredSize):
(WebCore::CSSFlexValue::CSSFlexValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive): Make the type more

specific.

(WebCore::CSSParser::parseFlex):

  • css/CSSParser.h:
  • css/CSSValue.h:

(WebCore::CSSValue::isFlexValue):

10:22 Changeset [91267] by cfleizach@apple.com

If the control associated with a <label> is hidden, the label is also hidden (incorrectly)
https://bugs.webkit.org/show_bug.cgi?id=64752

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/label-element-with-hidden-control.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

  • platform/mac/accessibility/label-element-with-hidden-control-expected.txt: Added.
  • platform/mac/accessibility/label-element-with-hidden-control.html: Added.
10:14 Changeset [91266] by bweinstein@apple.com

Speculative fix for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Enrica Casucci.

I was unable to reproduce this bug, but Darin Adler and I discussed the probable issue. When starting the drag, we create
a WKPasteboardFilePromiseOwner, and a WKPasteboardOwner. When the drag is concluded, we call a method on the WKPasteboardFilePromiseOwner
which uses the WKPasteboardOwner. However, we are not guaranteeing that the WKPasteboardOwner will be around when the
WKPasteboardFilePromiseOwner method is called.

The fix is to retain both the WKPasteboardFilePromiseOwner and the WKPasteboardOwner that we need, making sure that we are keeping
both objects alive.

This patch also uses r91222 to replace WebPage::platformDragEnded, so WebPage doesn't need to know about the drag source.

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::dragEnded): Add a non-Mac stub method, since the Mac is the only platform that does something here.

  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Use member variables instead of local variables.
(WebKit::WebDragClient::dragEnded): Move code from WebPageMac::platformDragEnded to here, and clear both member variables.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dragEnded): Don't call platformDragEnded anymore. WebCore::DragController::dragEnded calls WebDragClient::dragEnded,

which does the same thing.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm: Remove platformDragEnded.
10:08 Changeset [91265] by rniwa@webkit.org

Remove failing Chromium test expectations after r91224.

  • platform/chromium/test_expectations.txt:
09:38 Changeset [91264] by vsevik@chromium.org

Web Inspector: Backend should provide network resource identifiers that are unique across navigation.
https://bugs.webkit.org/show_bug.cgi?id=64746

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::createIdentifier):
(WebCore::IdentifiersFactory::resourceId):
(WebCore::IdentifiersFactory::addProcessIdPrefixTo):

  • inspector/IdentifiersFactory.h:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForResourceId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::resourceId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:

LayoutTests:

  • inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
09:36 Changeset [91263] by jberlin@webkit.org

Fix assertion failure seen in plugins/return-npobject.html on Windows XP Debug bots.

Rubber-stamped by Adam Roben.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveData):
It is possible for a subclass to cancel the load from within didReceiveData, which would
set m_documentLoader to 0.
Remove the assertion I added that the DocumentLoader's frame is non-null.

09:28 Changeset [91262] by weinig@apple.com

Remove obsolete Mac NRWT test bots
https://bugs.webkit.org/show_bug.cgi?id=64806

Reviewed by Adam Roben.

Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
which have been disconnected for some time and have been obsoleted by
the main testers using NRWT.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
09:13 Changeset [91261] by weinig@apple.com

webkit-patch rebaseline crashes on use
https://bugs.webkit.org/show_bug.cgi?id=64775

Reviewed by Adam Roben.

Fix incorrectly spelled attribute name.

  • Scripts/webkitpy/common/net/layouttestresults.py:

The attribute is test_name, not filename.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

Add test for tests_matching_failure_types.

08:56 Changeset [91260] by steveblock@google.com

REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
https://bugs.webkit.org/show_bug.cgi?id=64730

Reviewed by Alexey Proskuryakov.

Covered by existing tests.

  • bridge/jni/v8/JNIUtilityPrivate.cpp:

(JSC::Bindings::jvalueToJavaValue):

08:55 Changeset [91259] by rniwa@webkit.org

[chromium] rebaseline Chromium results after r91249 .
Unreviewed.

Patch by Jeremy Moskovich <jeremy@chromium.org> on 2011-07-19

  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Added.
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
08:51 Changeset [91258] by yurys@chromium.org

[Chromium] Web Inspector: add sanity test for shared worker inspector
https://bugs.webkit.org/show_bug.cgi?id=64799

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testSharedWorker):
(.TestSuite.prototype.evaluateInConsole_):

08:46 Changeset [91257] by weinig@apple.com

Check in Leopard specific results for Selectors 3 tests.

  • platform/mac-leopard/css3/selectors3: Added.
  • platform/mac-leopard/css3/selectors3/html: Added.
  • platform/mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml: Added.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml: Added.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
08:29 Changeset [91256] by vitalyr@chromium.org

2011-07-19 Vitaly Repeshko <vitalyr@chromium.org>

[V8] Don't put CSSRuleLists in object groups.
https://bugs.webkit.org/show_bug.cgi?id=64798

Reviewed by Pavel Feldman.

Retention of CSSRuleLists should be implemented using hidden
references from holder objects. By putting lists in groups we
artificially extend their lifetimes much more than necessary.

  • bindings/v8/V8GCController.cpp: (WebCore::GrouperVisitor::visitDOMWrapper):
08:28 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
08:26 Changeset [91255] by gyuyoung.kim@samsung.com

[EFL] Add ewk_network.cpp|h files.
https://bugs.webkit.org/show_bug.cgi?id=63315

Source/WebCore:

Enable setOnLine(bool) on EFL port as well as Android and Chromium.

Reviewed by Antonio Gomes.

  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:

Source/WebKit/efl:

ewk_network.cpp|h files are added to ewk in order to support APIs related to networking.
In addition, ewk_network_state_notifier_online_set() is added to ewk_network.cpp in order
to notify NetworkStateNotifier of network status.

Reviewed by Antonio Gomes.

  • CMakeListsEfl.txt:
  • ewk/EWebKit.h:
  • ewk/ewk_network.cpp: Added.

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
(ewk_network_state_notifier_online_set):

  • ewk/ewk_network.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
08:25 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
07:58 Changeset [91254] by jeremy@chromium.org

Merge 91249 - Fix microphone icon placement in speech input control for dir=rtl.
https://bugs.webkit.org/show_bug.cgi?id=64668

Reviewed by Dimitri Glazkov.

Source/WebCore:

Modify default stylesheet to propagate dir=rtl from the outer input
control to the shadow DOM container. This makes the microphone
icon appear on the left for dir=rtl, which is the desired behavior.

Test: fast/speech/speech-bidi-rendering.html

  • css/html.css:

(input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):

LayoutTests:

Added test that verifies placement of microphone icon for dir=rtl.

  • fast/speech/speech-bidi-rendering.html: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.

TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/7432005

07:49 Changeset [91253] by kov@webkit.org

[GTK] Google Calendar thinks we're mobile
https://bugs.webkit.org/show_bug.cgi?id=63994

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-07-11
Reviewed by Xan Lopez.

Further special-case Google Calendar, for it thinks WebKit+Linux
means mobile, so we also have to spoof the OS.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
private API that centralizes the logic now.

  • tests/testwebsettings.c: Add tests to make sure the Google

special-cases only apply for the expected domains and when quirks
special-casing is enabled.
(test_non_quirky_user_agents):
(test_webkit_web_settings_user_agent):

  • webkit/webkitwebsettings.cpp:

(webkitUserAgent): make it static.
(safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
(initializeDomainsList): moved from FrameLoaderClientGtk.
(isGoogleDomain):ditto.
(isGoogleCalendar): ditto.
(userAgentForURL): ditto.
(webkitWebSettingsUserAgentForUri): centralize the whole
user agent spoofing logic in this new private API that can be used
by the browser to know what's going to happen for a specific URI
and also allows our API testing.

  • webkit/webkitwebsettingsprivate.h:
06:45 Changeset [91252] by loislo@chromium.org

Web Inspector: implement import/export for timeline data.
https://bugs.webkit.org/show_bug.cgi?id=64601

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-load.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::contextMenuItemSelected):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createFileSelector):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._exportToFile):
(WebInspector.TimelinePanel.prototype._importFromFile):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._importNextChunk):
(WebInspector.TimelineModel.prototype._importFromFile):
(WebInspector.TimelineModel.prototype._importFromFile.onError):
(WebInspector.TimelineModel.prototype._exportToFile):
(WebInspector.TimelineModel.prototype._reset):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/timeline/timeline-load-expected.txt: Added.
  • inspector/timeline/timeline-load.html: Added.
06:11 Changeset [91251] by loki@webkit.org

Add missing expected file after r91191

  • platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
06:02 Changeset [91250] by vsevik@chromium.org

Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static.
https://bugs.webkit.org/show_bug.cgi?id=64729

Reviewed by Pavel Feldman.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/IdentifiersFactory.cpp: Added.

(WebCore::IdentifiersFactory::createIdentifier):

  • inspector/IdentifiersFactory.h: Added.

(WebCore::IdentifiersFactory::setProcessId):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setProcessId):

  • inspector/InspectorController.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):

  • inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::setAgentIdentifierPrefix):
(WebKit::WebDevToolsAgentImpl::setProcessId):

  • src/WebDevToolsAgentImpl.h:
05:22 Changeset [91249] by jeremy@chromium.org

Fix microphone icon placement in speech input control for dir=rtl.
https://bugs.webkit.org/show_bug.cgi?id=64668

Reviewed by Dimitri Glazkov.

Source/WebCore:

Modify default stylesheet to propagate dir=rtl from the outer input
control to the shadow DOM container. This makes the microphone
icon appear on the left for dir=rtl, which is the desired behavior.

Test: fast/speech/speech-bidi-rendering.html

  • css/html.css:

(input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):

LayoutTests:

Added test that verifies placement of microphone icon for dir=rtl.

  • fast/speech/speech-bidi-rendering.html: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.
04:06 Changeset [91248] by alexis.menard@openbossa.org

[Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=64690

Make the API usable with QML by declaring what's needed
with the macros.

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/qdesktopwebview.h:
03:24 Changeset [91247] by commit-queue@webkit.org

[EFL] Account for the invalid pointer case in WebCore::screenRect()
https://bugs.webkit.org/show_bug.cgi?id=64543

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-19
Reviewed by Antonio Gomes.

Fix a regression introduced in r88245: it assumes the pointer passed
to screenRect() is always valid.
fast/frames/crash-removed-iframe.html proves this is not always true,
so we need to do some sanity check on the pointer before using it.
No new tests as this has been caught by the current test suite.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):

02:51 Changeset [91246] by yutak@chromium.org

Unreviewed. Edit Chromium test expectation for http/tests/websocket/tests/hybi/reserved-opcodes.html.

  • platform/chromium/test_expectations.txt:
02:25 Changeset [91245] by eric@webkit.org

new-run-webkit-tests should support --leaks
https://bugs.webkit.org/show_bug.cgi?id=63832

Reviewed by Dirk Pranke.

This may not be sufficient to actually transition over the leaks bot,
but this is a huge step in the right direction.

I had to make parse-malloc-history understand being passed more than
one file (to avoid the silly cat | nonsense in old-run-webkit-tests).

I removed some dead code relating to previous iterations of our crash detection.

I created a new class "LeakDetector" to encapsulate all this logic.
Eventually we should consider pulling that class out of mac.py and
sharing with other ports. However given that ORWT has had
--leaks support on Mac for almost 7 years and no other port has added
it, leaves me to believe we're in no rush to move LeakDetector.

I've tested --leaks locally. I suspect there are more bugs to shake out
but it seems to work well enough to start.

I also added support for --guard-malloc, but have not tested it much. It
should be viewed as experimental at this time.

I also fixed various os.path uses to self._filesystem as I was reading
through the various files to understand how best to fix this bug.

  • Scripts/old-run-webkit-tests:

(parseLeaksandPrintUniqueLeaks):

  • Scripts/parse-malloc-history:

(main):

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
02:21 Changeset [91244] by commit-queue@webkit.org

Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-07-19
Reviewed by Antonio Gomes.

ScrollBar should initialize current position in constructor.
https://bugs.webkit.org/show_bug.cgi?id=39284

When ScrollBar is created, m_currentPos should be initialized to
m_scrollableArea's current scrollPosition. Because scrollbars may
be created after the content of m_scrollableArea has been scrolled.

Source/WebCore:

Test: scrollbars/scrollbar-initial-position.html

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):

LayoutTests:

  • scrollbars/scrollbar-initial-position-expected.png: Added.
  • scrollbars/scrollbar-initial-position-expected.txt: Added.
  • scrollbars/scrollbar-initial-position.html: Added.
01:57 Changeset [91243] by yutak@chromium.org

WebSocket: Implement hybi framing
https://bugs.webkit.org/show_bug.cgi?id=64522

Reviewed by Kent Tamura.

Source/WebCore:

Implement WebSocket framing protocol which is mainly described in
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4> and
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-6>.

Hybi protocol introduces a new frame format which is drastically different from
the old one. Notable differences are:

  • Binary data support.
  • Fragmentation support: a single message can be fragmented to multiple frames.
  • Ping-pong support.
  • Masking: frame content of a client must be masked to prevent cross-protocol attacks.

This patch covers the following features:

  • Send a pong frame when a ping frame is received.
  • Receive fragmented frames.
  • Receive masked frames. (Servers do not have to mask frames, but they may if they wish.)

The following features are NOT implemented yet:

  • Send or receive binary messages.
  • Send a ping message.
  • Send fragmented frames. (It is unclear whether this is necessary.)
  • Rewrite the frame content by WebSocket protocol extensions (like frame compression).

New tests: http/tests/websocket/tests/hybi/broken-utf8.html

http/tests/websocket/tests/hybi/fragmented-control-frame.html
http/tests/websocket/tests/hybi/fragmented-frames.html
http/tests/websocket/tests/hybi/interleaved-fragments.html
http/tests/websocket/tests/hybi/long-control-frame.html
http/tests/websocket/tests/hybi/masked-frames.html
http/tests/websocket/tests/hybi/pong.html
http/tests/websocket/tests/hybi/reserved-bits.html
http/tests/websocket/tests/hybi/reserved-opcodes.html
http/tests/websocket/tests/hybi/too-long-payload.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
The original content of send() was moved to a private method sendFrameHixie76().
(WebCore::WebSocketChannel::fail):
Stop handling incoming data after the WebSocket connection is failed.
It was unclear to me whether we should do the same thing for hixie-76 connection;
for now, I kept the original behavior.
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):
(WebCore::WebSocketChannel::sendFrame):
(WebCore::WebSocketChannel::sendFrameHixie76):

  • websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

LayoutTests:

Fix existing tests so they match the new frame format, and add tests for the new frame types
and error conditions related to the new frame format.

Unskip hybi tests on mac, win and chromium. Other ports (wk2, qt and gtk) still skip these tests
because they do not support changing the value of "WebKitHixie76WebSocketProtocolEnabled"
preference key via layoutTestController.overridePreferences() yet.

  • http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Added.
  • http/tests/websocket/tests/hybi/broken-utf8.html: Added.
  • http/tests/websocket/tests/hybi/broken-utf8_wsh.py: Added.
  • http/tests/websocket/tests/hybi/client-close-expected.txt:
  • http/tests/websocket/tests/hybi/client-close.html:

The format of a close frame has been changed. Currently, we do not include any payload
in a close frame, thus it must start with "\x88\x80" (see section 4.1 of hybi-10
specification for more details).

  • http/tests/websocket/tests/hybi/client-close_wsh.py:
  • http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/fragmented-control-frame_wsh.py: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames.html: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments.html: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments_wsh.py: Added.
  • http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/long-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/long-control-frame_wsh.py: Added.
  • http/tests/websocket/tests/hybi/masked-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/masked-frames.html: Added.
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/pong-expected.txt: Added.
  • http/tests/websocket/tests/hybi/pong.html: Added.
  • http/tests/websocket/tests/hybi/pong_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reserved-bits.html: Added.
  • http/tests/websocket/tests/hybi/reserved-bits_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes.html: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send2_wsh.py:

Send two text frames at once.

  • http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/too-long-payload.html: Added.
  • http/tests/websocket/tests/hybi/too-long-payload_wsh.py: Added.
  • platform/chromium/test_expectations.txt:

Derive test expectations of hixie76 tests, because these tests are likely to behave
the same way as hixie76 tests. Will be checked later whether they really do.

  • platform/mac/Skipped:
  • platform/win/Skipped:
01:12 Changeset [91242] by zimmermann@webkit.org

2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
https://bugs.webkit.org/show_bug.cgi?id=64059

REGRESSION (r88913): <object> has wrong computed height
https://bugs.webkit.org/show_bug.cgi?id=62769

Reviewed by Rob Buis.

Add new layout test in fast/css covering both bugs.
Update svg/zoom/page results (this is a progression, but the test itself remains broken, see comment inline).

  • fast/css/replaced-element-implicit-size.html: Added.
  • platform/mac/fast/css/replaced-element-implicit-size-expected.png: Added.
  • platform/mac/fast/css/replaced-element-implicit-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt:

2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
https://bugs.webkit.org/show_bug.cgi?id=64059

REGRESSION (r88913): <object> has wrong computed height
https://bugs.webkit.org/show_bug.cgi?id=62769

Reviewed by Rob Buis.

Fix misinterpretation of CSS 2.1 - "10.5 Content height: the 'height' property".
It says "If the height of the containing block is not specified explicitelz (i.e. it depends on the
content height), and this element is not absolutely positioned, the value computes to 'auto'".

Checking whether the containing block height depends on the content height is not equal to checking
whether the height property is set on the containing block, there are other ways to implicitly specify
the height by setting top & bottom. Fix that by checking whether the containing block has a height
property or top & bottom set.

While I was at it, make computeReplacedLogicalWidth/Height a bit more explicit to make it easier to compare
the code with the spec quoatations - this doesn't change the functionality only the readability.


Test: fast/css/replaced-element-implicit-size.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): Cleanup comment, make code more explicit. (WebCore::RenderReplaced::logicalHeightIsAuto): Add helper method used by computeReplacedLogicalHeight. (WebCore::RenderReplaced::computeReplacedLogicalHeight): Fix height=auto detection.
  • rendering/RenderReplaced.h:
00:38 Changeset [91241] by abarth@webkit.org

garden-o-matic should have a "Triage Failures" button for iterating over failures
https://bugs.webkit.org/show_bug.cgi?id=64769

Reviewed by Eric Seidel.

This patch adds some global static state and refactors things a bit so
that we can iterate over all the failures in the details pane.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
    • Add a generic callback iterator to iterate through a series of callbacks. We use this to iterate through the failures we want to display the details of.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add a toolbar for the results summary and change the buttons to be real buttons.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • Make the detail pane 75% of the window.
    • Make the buttons pretty.
    • Allow the failure type badges to apply to the details pane as well.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Restructure how we bring up the details pane so we can iterate through a bunch of failures.
    • Remove the transition between results details because it's annoying when you want to click through a bunch of failures.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • Add some more structure to the title bar for the results details so it's clearer which results we're currently displaying.
00:37 Changeset [91240] by abarth@webkit.org

garden-o-matic should live update as conditions change on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=64646

Reviewed by Eric Seidel.

This patch causes the garden-o-matic display to update every 10 minutes
to show the latest failures. This patch required a moderately large
refactoring of main.js to make the display incremental instead of
all-at-once.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

07/18/11:

22:33 Changeset [91239] by aestes@apple.com

Solar Walk app-specific hack accidentally strips stylesheets from the document.
https://bugs.webkit.org/show_bug.cgi?id=64777

Reviewed by Adam Barth.

Solar Walk uses a self-closed title tag in its documents ("<title />").
The HTML5 parser does not recognize this as a valid self-closing tag,
so it treats the remainder of the document as title text.

We work around this in WebKit by injecting a script that calls
document.write() on the contents of document.title, thereby restoring
the contents of the document. Unfortunately this overwrote several
<style> tags that existed before the <title>, thereby causing the
document to not have the intended styling.

Fix this by having the injected script concatenate document.title to
the document instead of overwriting it during document.write(). We can
also take the opportunity to remove document.title since it does not
contain useful information.

  • Misc/SolarWalkQuirksUserScript.js:
22:04 Changeset [91238] by rniwa@webkit.org

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
21:14 Changeset [91237] by rniwa@webkit.org

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Add a runtime check for font cascading optimization.

It's a constant value in Mac port so hopefully gcc will constant-propagate the value
and eliminate the function altogether.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::canSetCascadeListForCustomFont): Added.
(WebCore::FontPlatformData::ctFont):

21:03 Changeset [91236] by rniwa@webkit.org

Chromium test expectation update after r91229.

  • platform/chromium/test_expectations.txt:
19:55 Changeset [91235] by morrita@google.com

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

  • Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
  • Updated the set on inclusion list changes.
  • Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

  • Renamed NodeRenderingContext::m_contentElement to m_includer
  • ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

  • dom/ShadowContentElement.cpp:

(WebCore::removeFromSet):
(WebCore::addToSet):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Added a new test.
  • Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.
  • fast/dom/shadow/content-element-includer-expected.txt: Added.
  • fast/dom/shadow/content-element-includer.html: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
19:42 Changeset [91234] by barraclough@apple.com

Add a failing test expectation for object-prototype-properties.html after r91225.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-18

  • platform/chromium/test_expectations.txt:
19:25 Changeset [91233] by commit-queue@webkit.org

Tab Atkins is not in committers.py (as a non-committer)
https://bugs.webkit.org/show_bug.cgi?id=64770

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
19:21 Changeset [91232] by dino@apple.com

2011-07-18 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=64742
Expose WebPreferences for media playback requiring user gestures and inline playback

Reviewed by Simon Fraser.

Media playback already tested if it should require user gestures, but
no setting was ever exposed to clients. Also, some ports only allow media
playback to be fullscreen, so exposing a new setting for them.

Two new WebPreferences: MediaPlaybackRequiresUserGesture and
MediaPlaybackAllowsInline.

WebCore:

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Examine the new Setting for user gestures.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Two new settings. (WebCore::Settings::setMediaPlaybackRequiresUserGesture): (WebCore::Settings::mediaPlaybackRequiresUserGesture): (WebCore::Settings::setMediaPlaybackAllowsInline): (WebCore::Settings::mediaPlaybackAllowsInline):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences mediaPlaybackRequiresUserGesture]): (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): (-[WebPreferences mediaPlaybackAllowsInline]): (-[WebPreferences setMediaPlaybackAllowsInline:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setMediaPlaybackRequiresUserGesture): (WebPreferences::mediaPlaybackRequiresUserGesture): (WebPreferences::setMediaPlaybackAllowsInline): (WebPreferences::mediaPlaybackAllowsInline):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMediaPlaybackRequiresUserGesture): (WKPreferencesGetMediaPlaybackRequiresUserGesture): (WKPreferencesSetMediaPlaybackAllowsInline): (WKPreferencesGetMediaPlaybackAllowsInline):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
18:42 Changeset [91231] by rniwa@webkit.org

Leopard build fix after r91229.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont):

18:25 Changeset [91230] by rniwa@webkit.org

Add a failing test expectation for object-prototype-properties.html after r91225.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [91229] by mitz@apple.com

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Reviewed by Sam Weinig.

  • platform/graphics/Font.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Undo the cascade list optimization on Leopard for custom
fonts, because adding a cascade list apparently breaks the font.

17:54 Changeset [91228] by mdelaney@apple.com

Remove drawsUsingCopy now that all ports handle the copying
https://bugs.webkit.org/show_bug.cgi?id=64768

Introduced in https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy
was used to know whether or not an ImageBuffer should be explicitly copied before being
painted into a context (as was used in HTMLCanvasElement::paint). All platforms now
handle the logic of copying or not in their ImageBuffer::draw() implementations, so
drawsUsingCopy() is no longer needed. This patch removes it.

Reviewed by Dan Bernstein.

No new tests; does not affect behavior.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::isAccelerated):

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
17:39 Changeset [91227] by vsevik@chromium.org

Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated event is dispatched on NetworkPanel.
https://bugs.webkit.org/show_bug.cgi?id=64748

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

17:36 Changeset [91226] by commit-queue@webkit.org

DFG JIT does not optimize strict equality as effectively as the old JIT does.
https://bugs.webkit.org/show_bug.cgi?id=64759

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

This adds a more complete set of strict equality optimizations. If either
operand is known numeric, then the code reverts to the old style of optimizing
(first try integer comparison). Otherwise it uses the old JIT's trick of
first simultaneously checking if both operands are either numbers or cells;
if not then a fast path is taken.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:26 Changeset [91225] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64760
DFG JIT - Should be able to compile program code.

Reviewed by Geoff Garen.

Add support for op_end, hooks to compile program code in Executable.cpp.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • Add support for op_end
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • Added, separate out steps of compileFunction.

(JSC::DFG::JITCompiler::compile):

  • Added, compile program code.

(JSC::DFG::JITCompiler::compileFunction):

  • Sections separated out to helper functions.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • Added m_exceptionCheckCount.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

  • Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.
17:25 Changeset [91224] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to the global object,
also, to toLocaleString should be calling the ToObject & invoking the object's toString
function, even for values that are already strings.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

LayoutTests:

  • fast/js/resources/js-test-pre.js:
    • Updated harness to not call Object.prototype.toString on undefined.
  • fast/js/eval-var-decl-expected.txt:
  • fast/js/object-prototype-properties-expected.txt: Added.
  • fast/js/object-prototype-properties.html: Added.
  • fast/js/object-prototype-toLocaleString-expected.txt
  • fast/js/script-tests/eval-var-decl.js:
    • Fix test case, calling hasProperty with undefined as the this value should throw.
  • fast/js/script-tests/object-prototype-properties.js: Added.
    • Place for test cases for Object.prototype properties; to being with, check that calling these methods on undefined throws!
  • fast/js/script-tests/object-prototype-toLocaleString.js:
    • Added test cases for correct behaviour when this is a string primitive.
  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
    • These test cases are all incorrect. (See https://bugs.ecmascript.org/show_bug.cgi?id=117). We were incorrectly passing 15.5.4.11_String.prototype.replace, this should fail, as the others do. All the other 15.5.4 tests were failing & are still failing, but now have a better error message. S11.1.1_A2 is also invalid, calling toString() passing undefined as this should throw.
17:20 Changeset [91223] by rniwa@webkit.org

Fix a typo.

  • platform/chromium/test_expectations.txt:
17:14 Changeset [91222] by bweinstein@apple.com

Prep work for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Darin Adler.

Add a DragClient function that is called when a drag is ended, and call it from DragController::dragEnded.
This isn't used yet, but will be used by WebKit2 on Mac.

This patch also cleans up style in DragClient.h.

No change in behavior, no tests needed.

  • page/DragClient.h:

(WebCore::DragClient::dragEnded): Stub virtual implementation for now, this will be used by

WebKit2 on Mac.

  • page/DragController.cpp:

(WebCore::DragController::dragEnded): Call DragClient::dragEnded.

16:59 Changeset [91221] by rniwa@webkit.org

Add Chromium failing expectations for some font tests; failures are tracked by the bug 64767.

  • platform/chromium/test_expectations.txt:
16:19 Changeset [91220] by ojan@chromium.org

Load ToT chromium bots by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64756

Reviewed by Adam Barth.

For now, these are the most useful bots to look at. Eventually,
we may want to load the build.webkit.org bots by default once
most of the bots there upload results.

  • TestResultServer/static-dashboards/dashboard_base.js:
16:16 Changeset [91219] by jhoneycutt@apple.com

Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
16:11 BuildingGtk edited by levin@chromium.org
Fix formatting of recent change. (diff)
15:55 Changeset [91218] by commit-queue@webkit.org

JSC GC lazy sweep does not inline the common cases of cell destruction.
https://bugs.webkit.org/show_bug.cgi?id=64745

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This inlines the case of JSFinalObject destruction.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::lazySweep):

15:49 Changeset [91217] by commit-queue@webkit.org

Add regression tests for legacy color parsing of valid CSS colors
https://bugs.webkit.org/show_bug.cgi?id=64576

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Simon Fraser.

  • fast/dom/attribute-legacy-colors-expected.txt:
  • fast/dom/script-tests/attribute-legacy-colors.js:
15:42 Changeset [91216] by oliver@apple.com

Interpreter build-fix

15:36 Changeset [91215] by commit-queue@webkit.org

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Unreviewed. Just updating unit test results after bug 64751.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
15:27 Changeset [91214] by abarth@webkit.org

simplejson has trouble on chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=64757

Reviewed by Eric Seidel.

Use the native JSON, if available.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
14:59 Changeset [91213] by rniwa@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18

  • DEPS:
14:51 Changeset [91212] by ojan@chromium.org

update the flakiness dashboard to understand the new platforms/formats in test_expectations
https://bugs.webkit.org/show_bug.cgi?id=64743

Reviewed by Adam Barth.

The test expectations format changed a long time ago and the flakiness dashboard
was never updated to match.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
14:33 BuildingQtOnLinux edited by phihag@phihag.de
Outdated Mesa (when compiling on debian stable or other old distros) (diff)
14:27 Changeset [91211] by rniwa@webkit.org

[SVG] [Chromium]: painting-control-04-f.svg and zero-path-square-cap-rendering.svg are failing
https://bugs.webkit.org/show_bug.cgi?id=64675

Rebaseline painting-control-04-f.svg since r91191 fixed it.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91210] by commit-queue@webkit.org

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Reviewed by Adam Barth.

Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
is a step that we run for most commands (as one of the earliest steps).
EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
the CWD to the checkout root. This magically made a bunch of otherwise
wrong code work.

When I realized that apply-attachment no longer worked as expected today,
I went and fixed the bug, then realizing that we were not testing
what the cwd was when running various commands. I fixed our MockExecutive
to always log what the cwd is and fixed a whole bunch of places
where we needed to be setting the cwd.

Hopefully this will solve our cwd problems once and for-all, and webkit-patch
will again correctly work when called from any directory (including outside
of a webkit checkout).

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/update.py:
14:10 Changeset [91209] by mitz@apple.com

Specify a cascade list consisting of the last resort font for Core Text
https://bugs.webkit.org/show_bug.cgi?id=64747

Reviewed by Sam Weinig.

No new tests, because this does not affect behavior.

This prevents Core Text from taking its default, longer fallback list when the primary font does
not include a character. This is OK to do because WebKit never uses the results of Core Text
fallback anyway.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::cascadeToLastResortFontDescriptor): Added. Returns a CTFontDescriptor with a cascade
list consisting of the last resort font.
(WebCore::FontPlatformData::ctFont): Changed to include the cascadeToLastResortFontDescriptor
in the returned font.

14:04 Changeset [91208] by commit-queue@webkit.org

DFG JIT does not optimize equal-null comparisons and branches.
https://bugs.webkit.org/show_bug.cgi?id=64659

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

Added a peephole-aware compare-to-null implementation to JITCodeGenerator,
which is used by both the speculative and non-speculative JIT. Through
the use of the new isNullConstant helper, the two JITs invoke the
nonSpecualtiveCompareNull() helper instead of their regular comparison
helpers when compiling CompareEq. Through the use of the new isKnownCell
helper, the compare-null code will skip the is-a-cell check if the
speculative JIT had been speculating cell.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isNullConstant):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:56 Changeset [91207] by ctguil@chromium.org

Merge 90599 - Work around Skia PDF's lack of inverted path support.
https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7398032

13:38 Changeset [91206] by commit-queue@webkit.org

Timer scheduling should be based off the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64544

Patch by James Robinson <jamesr@chromium.org> on 2011-07-18
Reviewed by Darin Adler.

Source/JavaScriptCore:

Switches ThreadCondition::timedWait and related utility functions from currentTime() to
monotonicallyIncreasingTime().

Add WTF::monotonicallyIncreasingTime() to list of exported functions so it can be accessed from WebCore/WebKit.

(WTF::ThreadCondition::timedWait):

  • wtf/ThreadingWin.cpp:

(WTF::absoluteTimeToWaitTimeoutInterval):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::ThreadCondition::timedWait):

  • wtf/qt/ThreadingQt.cpp:

(WTF::ThreadCondition::timedWait):

Source/WebCore:

Changes the Timer scheduling logic from using absolute values in terms of currentTime() to using relative
intervals in terms of monotonicallyIncreasingTime(). This provides better standards compliance, compatibility,
and predictability when the system clock is adjusted.

No automated tests since there is no way to modify the system clock from DRT.

  • platform/SharedTimer.h:

(WebCore::MainThreadSharedTimer::setFireInterval):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/Timer.cpp:

(WebCore::TimerBase::start):
(WebCore::TimerBase::nextFireInterval):

  • platform/android/SharedTimerAndroid.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/brew/SharedTimerBrew.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/efl/SharedTimerEfl.cpp:

(WebCore::addNewTimer):
(WebCore::setSharedTimerFireInterval):

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/haiku/SharedTimerHaiku.cpp:

(WebCore::SharedTimerHaiku::start):
(WebCore::setSharedTimerFireInterval):

  • platform/mac/SharedTimerMac.mm:

(WebCore::setSharedTimerFireInterval):

  • platform/qt/SharedTimerQt.cpp:

(WebCore::SharedTimerQt::start):
(WebCore::setSharedTimerFireInterval):

  • platform/win/SharedTimerWin.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wince/SharedTimerWinCE.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wx/SharedTimerWx.cpp:

(WebCore::setSharedTimerFireInterval):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerSharedTimer::setFireInterval):

Source/WebKit/chromium:

Renames setSharedTimerFireTime to setSharedTimerFireInterval to be consistent with WebCore.

  • public/WebKitClient.h:

(WebKit::WebKitClient::setSharedTimerFireInterval):

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::setSharedTimerFireInterval):

Source/WebKit2:

Converts the WebKit2 RunLoop and CoreIPC timeouts to use monotonicallyIncreasingTime().

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/RunLoop.h:
13:36 Changeset [91205] by commit-queue@webkit.org

Patch by Yuzhu Shen <yzshen@chromium.com> on 2011-07-18
Reviewed by James Robinson.

[chromium] WebFontImpl::drawText needs to handle the canvasIsOpaque input.
https://bugs.webkit.org/show_bug.cgi?id=64555

This change handles canvasIsOpaque for the WEBKIT_USING_SKIA case.

  • src/WebFontImpl.cpp: handled canvasIsOpaque.
  • src/WebFontImpl.h: added method declaration.
13:20 Changeset [91204] by gavinp@chromium.org

Merge 89719 BUG=80729

13:16 Changeset [91203] by abarth@webkit.org

Update baseline. rbuis says this is an improvement.

  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
12:31 Changeset [91202] by tony@chromium.org

[chromium] Move a Linux specific test into chromium-linux and rebaseline
https://bugs.webkit.org/show_bug.cgi?id=64632

Reviewed by Ojan Vafai.

Rebaselining per the comment in test_expectations.txt.

  • platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:20 Changeset [91201] by psolanki@apple.com

Unreviewed. Fix Windows build. Move static function defaultSessionCookieStorage() to before
its use in defaultCookieStorage().

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):

11:59 BuildingGtk edited by levin@chromium.org
Add info about fixing libjpeg error using mac ports. (diff)
11:55 Changeset [91200] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get coookie storage code to work with USE(CFNETWORK) enabled on Mac.

No new tests because no change in functionality.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultCookieStorage):
(WebCore::defaultSessionCookieStorage):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

  • platform/network/mac/CookieStorageMac.mm:
11:55 Changeset [91199] by commit-queue@webkit.org

JSC JIT does not inline GC allocation fast paths
https://bugs.webkit.org/show_bug.cgi?id=64582

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This addresses inlining allocation for the easiest-to-allocate cases:
op_new_object and op_create_this. Inlining GC allocation fast paths
required three changes. First, the JSGlobalData now saves the vtable
pointer of JSFinalObject, since that's what op_new_object and
op_create_this allocate. Second, the Heap exposes a reference to
the appropriate SizeClass, so that the JIT may inline accesses
directly to the SizeClass for JSFinalObject allocations. And third,
the JIT is extended with code to emit inline fast paths for GC
allocation. A stub call is emitted in the case where the inline fast
path fails.

  • heap/Heap.h:

(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFinalObject):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

  • runtime/JSGlobalData.h:
  • runtime/JSObject.h:

(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInheritorID):

11:43 Changeset [91198] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit/mac:

Create an NSURLDownload from the CF objects that we have.

  • Misc/WebDownload.mm:

(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):

  • Misc/WebDownloadInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::download):

11:20 Changeset [91197] by abarth@webkit.org

Increase information garden-o-matic information density by switching to a table
https://bugs.webkit.org/show_bug.cgi?id=64642

Reviewed by Dimitri Glazkov.

The old layout couldn't handle the large number of failures we had
today. This patch switches garden-o-matic to a table-based layout,
which can handle many more failures gracefully. (I expect we'll need
more UI iterations.)

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:18 Changeset [91196] by abarth@webkit.org

garden-o-matic should be able to determine when compile breaks
https://bugs.webkit.org/show_bug.cgi?id=64190

Reviewed by Dimitri Glazkov.

This patch adds a red-ish box to the top of the page whenever there is
a compile error on the bots. The box automatically opens and closes as
appropriate and links to the waterfall display. In the future, we
might want to compute a regression range.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    • Add the build-only bots to the config. We use these to check whether the build failed, which is faster than waiting for the tester bots to cycle.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add DOM for the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • CSS to support the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Wiring up events to poll the buildbot to see whether compile has failed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Infrastructure for fetching and parsing the buildbot status JSON blob. This code could be better factored for testability. :(
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • UI for displaying compile errors.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:11 Changeset [91195] by barraclough@apple.com

Speculative fix for Leopard assertions caused by 91095.

Rubber stamped by Sam Weinig.

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

  • ensure we pass the window shell, not the global object.
10:47 Changeset [91194] by oliver@apple.com

2011-07-18 Mark Hahnenberg <mhahnenberg@apple.com>

Refactor JSC to replace JSCell::operator new with static create method
https://bugs.webkit.org/show_bug.cgi?id=64466

Reviewed by Oliver Hunt (oliver@apple.com) and Darin Adler (darin@apple.com).

First step in a longer refactoring process to remove the use of
operator new overloading in order to allocate GC objects and to replace
this method with static create methods for each individual type of heap-allocated
JS object. This particular patch only deals with replacing uses of
operator new within JSC proper. Future patches will remove it from the
parts that interface with the DOM. Due to the DOM's continued dependence
on it, operator new has not actually been removed from JSCell.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::create):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::create):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::operator new): (JSC::JSCallbackObject::create):
  • API/JSCallbackObjectFunctions.h: (JSC::::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction):
  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::create): (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::create): (JSC::Arguments::createNoParameters):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::create):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::create):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h: (JSC::BooleanConstructor::create):
  • runtime/BooleanObject.h: (JSC::BooleanObject::create):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::create):
  • runtime/DateConstructor.cpp: (JSC::constructDate):
  • runtime/DateConstructor.h: (JSC::DateConstructor::create):
  • runtime/DateInstance.h: (JSC::DateInstance::create):
  • runtime/DatePrototype.h: (JSC::DatePrototype::create):
  • runtime/Error.cpp: (JSC::createError): (JSC::createEvalError): (JSC::createRangeError): (JSC::createReferenceError): (JSC::createSyntaxError): (JSC::createTypeError): (JSC::createURIError): (JSC::StrictModeTypeErrorFunction::create): (JSC::createTypeErrorFunction):
  • runtime/ErrorConstructor.h: (JSC::ErrorConstructor::create):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): (JSC::ErrorInstance::create):
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::create):
  • runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::InterruptedExecutionError::create): (JSC::createInterruptedExecutionException): (JSC::TerminatedExecutionError::TerminatedExecutionError): (JSC::TerminatedExecutionError::create): (JSC::createTerminatedExecutionException):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::FunctionExecutable): (JSC::FunctionExecutable::fromGlobalCode):
  • runtime/Executable.h: (JSC::ExecutableBase::create): (JSC::NativeExecutable::create): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::ProgramExecutable::create): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::make):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h: (JSC::FunctionConstructor::create):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::addFunctionProperties):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::create):
  • runtime/GetterSetter.h: (JSC::GetterSetter::create):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::create): (JSC::jsAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h: (JSC::JSActivation::create):
  • runtime/JSArray.h: (JSC::JSArray::create):
  • runtime/JSCell.h: (JSC::JSCell::allocateCell):
  • runtime/JSFunction.h: (JSC::JSFunction::create):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::create):
  • runtime/JSONObject.h: (JSC::JSONObject::create):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::putDescriptor):
  • runtime/JSObject.h: (JSC::JSFinalObject::create):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope): (JSC::JSString::replaceCharacter): (JSC::StringObject::create):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::create): (JSC::RopeBuilder::createHasOtherOwner): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString): (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • runtime/JSValue.cpp: (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/MathObject.h: (JSC::MathObject::create):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::create):
  • runtime/NativeErrorPrototype.h: (JSC::NativeErrorPrototype::create):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::create):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h: (JSC::NumberObject::create):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::create):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::create):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::create):
  • runtime/Operations.h: (JSC::jsString):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::createWithoutCaching): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::arrayOfMatches): (JSC::constructRegExp):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::create):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::create):
  • runtime/RegExpObject.h: (JSC::RegExpObject::create):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::create):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::create): (JSC::ScopeChainNode::push):
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • runtime/StringConstructor.cpp: (JSC::constructWithStringConstructor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::create):
  • runtime/StringObject.h: (JSC::StringObject::create):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • runtime/StringPrototype.h: (JSC::StringPrototype::create):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::createStructure):
  • runtime/StructureChain.h: (JSC::StructureChain::create):
10:12 Changeset [91193] by commit-queue@webkit.org

[Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
https://bugs.webkit.org/show_bug.cgi?id=64560

Patch by Hui Huang <hui.2.huang@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

10:04 Changeset [91192] by commit-queue@webkit.org

[Texmap] [Qt] [WK2] Unsync in TextureMapperNode between parent and child lists cause crashes on WK2.
https://bugs.webkit.org/show_bug.cgi?id=62587

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

Fix unsync between m_parent and m_children list in child and parent texture mapper nodes
in syncCompositingStateSelf.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

10:01 Changeset [91191] by commit-queue@webkit.org

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Patch by Rob Buis <rbuis@rim.com> on 2011-07-18
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Do not rely on toolkits to correctly render zero-length path with stroke-linecap=round, render
it ourselves just like for stroke-linecap=square.

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::setupSquareCapPath):

LayoutTests:

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
09:54 Changeset [91190] by commit-queue@webkit.org

[REGRESSION] Value 'none' breaks multiple background-image display
https://bugs.webkit.org/show_bug.cgi?id=59274

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-18
Reviewed by Simon Fraser.

When taking fast path for simple color background, we should draw
the background only if it is the last in the list of backgrounds.
Otherwise, it will obscure the previously drawn backgrounds.

Source/WebCore:

Test: fast/backgrounds/background-fast-path-simple-color.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

  • fast/backgrounds/background-fast-path-simple-color-expected.png: Added.
  • fast/backgrounds/background-fast-path-simple-color-expected.txt: Added.
  • fast/backgrounds/background-fast-path-simple-color.html: Added.
09:48 Changeset [91189] by yi.4.shen@nokia.com

[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
https://bugs.webkit.org/show_bug.cgi?id=62808

Source/WebCore:

The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously
when its load type is set to SynchronousLoad.

Reviewed by Benjamin Poulain.

Test: loader/load-defer-resume-crash.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandler::setLoadingDeferred):

LayoutTests:

Added a test for the crash occurs when load deferring is turned off.

Reviewed by Benjamin Poulain.

  • loader/load-defer-resume-crash-expected.txt: Added.
  • loader/load-defer-resume-crash.html: Added.
  • loader/resources/images.html: Added.
  • platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
09:43 Changeset [91188] by andersca@apple.com

Make using lowercase parameter names for AppleConnect be a plug-in quirk
https://bugs.webkit.org/show_bug.cgi?id=64638

Reviewed by Sam Weinig.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):
Set the WantsLowercaseParameterNames quirk for the AppleConnect plug-in.

  • Shared/Plugins/PluginQuirks.h:

Add WantsLowercaseParameterNames quirk.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
If the plug-in has the WantsLowercaseParameterNames quirk, convert the parameter
names to lowercase.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Remove the code that would convert the parameters here. Also remove the FIXME; plug-in quirks
aren't really the same thing as site-specific quirks.

09:16 Changeset [91187] by commit-queue@webkit.org

AnimationBase asserts if a test tries to pause during the delay phase
https://bugs.webkit.org/show_bug.cgi?id=59475

Patch by Young Han Lee <joybro@company100.net> on 2011-07-18
Reviewed by Simon Fraser.

There is no more assertion failure after r90765, but the testcase still fails due to
the miscalculation of the pauseTime. This patch pauses the animation at its startTime
if a test tries to pause it during the delay phase.

Source/WebCore:

Test: transitions/transition-in-delay-phase.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

  • transitions/transition-in-delay-phase-expected.txt: Added.
  • transitions/transition-in-delay-phase.html: Added.
07:26 Changeset [91186] by senorblanco@chromium.org

Unreviewed; updated chromium test expectations.

Remove a passing test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
07:08 Changeset [91185] by senorblanco@chromium.org

Unreviewed; updated chromium test expectations.

Remove two tests from test_expectations.txt that have been rebaselined.

  • platform/chromium/test_expectations.txt:
07:04 Changeset [91184] by vsevik@chromium.org

Web Inspector: Web Inspector: provide unique identifiers for loaders
https://bugs.webkit.org/show_bug.cgi?id=64599

Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::loaderDetachedFromFrameImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameDestroyed):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::loaderId):
(WebCore::InspectorPageAgent::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame):

06:43 Changeset [91183] by jocelyn.turcotte@nokia.com

[Qt] Consider QTouchWebPage's transform when scrolling the viewport.
https://bugs.webkit.org/show_bug.cgi?id=64541

Reviewed by Benjamin Poulain.

Currently the scroll deltas are given to moveBy in page coordinates
which doesn't match when the page view is scalled.
This patch gives the scroll delta to the viewport in it's own coordinates.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureRequestScroll):

06:43 Changeset [91182] by jocelyn.turcotte@nokia.com

[Qt] Push the new viewport rect to the drawing area after committing the scale.
https://bugs.webkit.org/show_bug.cgi?id=64597

Reviewed by Benjamin Poulain.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureEnded):

06:43 Changeset [91181] by jocelyn.turcotte@nokia.com

[Qt] Remove the scale commit timer from QTouchWebPage.
https://bugs.webkit.org/show_bug.cgi?id=64600

Reviewed by Benjamin Poulain.

Since we don't currently need unprepared page view scale changes,
this timer isn't useful.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::commitScaleChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureStarted):

06:43 Changeset [91180] by jocelyn.turcotte@nokia.com

TiledDrawingArea: map the visibleArea rect from page to tiles coordinates.
https://bugs.webkit.org/show_bug.cgi?id=64538

Reviewed by Benjamin Poulain.

TiledDrawingAreaProxy expects its coordinates to be scaled according to
contentsScale. This patch keep the pushed visibleArea as page coordinates
and convert it each time to scaled coordinates in case the contents scale was
changed afterward.
This is a regression introduced in r90750.
Also:

  • Rename visibleArea to visibleContentRect
  • Remove an unnecessary mapToContents in QTouchWebPageProxy::setVisibleContentRect
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setViewportRect):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::visibleRect):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRect):

  • UIProcess/qt/qtouchwebpageproxy.h:
06:18 Changeset [91179] by pfeldman@chromium.org

Web Inspector: "Reveal in Elements Panel" is broken.
https://bugs.webkit.org/show_bug.cgi?id=64688

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

05:40 Changeset [91178] by jchaffraix@webkit.org

Remove RenderObject::addLayers second argument
https://bugs.webkit.org/show_bug.cgi?id=64649

Reviewed by Benjamin Poulain.

No change in behavior.

The code was always passing |this| as the second argument. Thus just
removed the argument for clarity.

  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addLayers): Removed the argument, replaced
by |this|.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Removed the second argument at those 2 call sites.

02:20 Changeset [91177] by loki@webkit.org

Qt rebaselines after r91060 and r91116

  • platform/qt/fast/dom/Window/window-properties-expected.txt: (r91060)
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Added (r91116)
02:09 Changeset [91176] by pfeldman@chromium.org

Web Inspector: do not pause on caught exceptions while typing in the console.
https://bugs.webkit.org/show_bug.cgi?id=64379

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

01:11 Changeset [91175] by rniwa@webkit.org

GTK and Qt rebaselines after r91158.

  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/qt/editing/inserting/5058163-1-expected.txt:
00:34 Changeset [91174] by commit-queue@webkit.org

Unreviewed, rolling out r91132 and r91135.
http://trac.webkit.org/changeset/91132
http://trac.webkit.org/changeset/91135
https://bugs.webkit.org/show_bug.cgi?id=64681

Broke GTK and Chromium debug bots (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18

Source/WebCore:

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::didSetSelectedIndex):

  • rendering/RenderMenuList.h:

Tools:

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(logEventProc):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):

07/17/11:

23:30 Changeset [91173] by commit-queue@webkit.org

[GTK] Fix selection of elements in a multi select list and remove an unnecessary include in WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=64666

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-07-17
Reviewed by Martin Robinson.

  • Platform/gtk/WorkQueueGtk.cpp: Remove an include which is no longer required
  • Shared/gtk/WebEventFactory.cpp:

(WebKit::modifiersForEvent): Fix an incorrect ASSERT statement
(WebKit::WebEventFactory::createWebMouseEvent): Call the function to determine the modifier keys

23:24 Changeset [91172] by rniwa@webkit.org

Chromium rebaselines after r91158.

Add failing expectations for tests added in r91125. The failures are tracked by the bug 64675.

Also remove failing expectations for some editing tests tracked by the Chromium issue 89477
because they are now passing.

  • platform/chromium-linux/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.txt:
  • platform/chromium/test_expectations.txt:
19:58 Changeset [91171] by ryuan.choi@samsung.com

[EFL] Refactor scheduleDispatchFunctionsOnMainThread to fix crash.
https://bugs.webkit.org/show_bug.cgi?id=64337

Replace ecore_timer_add to Ecore_Pipe.
This is needed because ecore_timer should not be called in a child thread,
but in the main thread.

Reviewed by Antonio Gomes.

  • wtf/efl/MainThreadEfl.cpp:

(WTF::pipeObject):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

18:59 Changeset [91170] by macpherson@chromium.org

Implement CSSPropertyCursor in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=64432

Reviewed by Dimitri Glazkov.

No new tests / refectoring only.

  • css/CSSStyleApplyProperty.cpp:

Add handler for CSSPropertyCursor.

  • css/CSSStyleSelector.cpp:

Remove current handler of CSSPropertyCursor.

  • css/CSSStyleSelector.h:

Make styleImage and cachedOrPendingFromValue public.

18:47 Changeset [91169] by commit-queue@webkit.org

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-07-17
Reviewed by Martin Robinson.

[GTK] [WK2] Fix for getting editor client commands.
https://bugs.webkit.org/show_bug.cgi?id=63081

Editor client commands intepretation was incorrect. It was based on the NativeWebKeyboardEvent only.
In fact EventHandler is generating interpreted events - keypress and keydown. These event types
are now passed from UIProcess to WebProcess so KeyBindingTranslator can correctly find editor commands.
Also build break for Debug build was fixed.

  • UIProcess/API/gtk/PageClientImpl.cpp: KeyboardEvent type is used for KeyBindingTranslator.

(WebKit::PageClientImpl::getEditorCommandsForKeyEvent): getEditorCommandsForKeyEvent now has additional
parameter describing KeyboardEvent type.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): KeyboardEvent type passed to PageClient.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::getEditorCommandsForKeyEvent): Sync message send with KeyboardEvent type.

02:02 Changeset [91168] by commit-queue@webkit.org

DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline.
https://bugs.webkit.org/show_bug.cgi?id=64637

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-17
Reviewed by Gavin Barraclough.

  • dfg/DFGOperations.cpp:
01:57 Changeset [91167] by commit-queue@webkit.org

test-webkitpy failing with Python 2.5
https://bugs.webkit.org/show_bug.cgi?id=64594

Patch by Philippe Normand <pnormand@igalia.com> on 2011-07-17
Reviewed by Eric Seidel.

Updated simplejson to version 2.1.6 that fixes an issue when
dumping slashes. Also use cgi.parse_qs instead of the urlparse
version to be compatible with Python2.5. Verified the fix with
test-webkitpy on python 2.5 and python 2.6.

  • Scripts/webkitpy/thirdparty/simplejson/README.txt:
  • Scripts/webkitpy/thirdparty/simplejson/init.py:
  • Scripts/webkitpy/thirdparty/simplejson/_speedups.c:

(json_PyOS_string_to_double):
(_convertPyInt_AsSsize_t):
(_convertPyInt_FromSsize_t):
(ascii_escape_char):
(ascii_escape_unicode):
(ascii_escape_str):
(raise_errmsg):
(join_list_unicode):
(join_list_string):
(_build_rval_index_tuple):
(scanstring_str):
(scanstring_unicode):
(py_scanstring):
(py_encode_basestring_ascii):
(scanner_dealloc):
(scanner_traverse):
(scanner_clear):
(_parse_object_str):
(_parse_object_unicode):
(_parse_array_str):
(_parse_array_unicode):
(_parse_constant):
(_match_number_str):
(_match_number_unicode):
(scan_once_str):
(scan_once_unicode):
(scanner_call):
(scanner_new):
(scanner_init):
(encoder_new):
(encoder_init):
(encoder_call):
(_encoded_const):
(encoder_encode_float):
(encoder_encode_string):
(_steal_list_append):
(encoder_listencode_obj):
(encoder_listencode_dict):
(encoder_listencode_list):
(encoder_dealloc):
(encoder_traverse):
(encoder_clear):
(init_speedups):

  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/encoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
  • Scripts/webkitpy/thirdparty/simplejson/scanner.py:
  • Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
00:38 Changeset [91166] by dglazkov@chromium.org

Rename ModifierMatcher to SpecificityCalculator.
https://bugs.webkit.org/show_bug.cgi?id=64660

It's a little longer than before, but it is much clearer.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted

all callsites, also rewrote the comments.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites

and renamed tests.

07/16/11:

22:40 Changeset [91165] by cevans@google.com

Merge 91152
BUG=89520
Review URL: http://codereview.chromium.org/7395022

22:04 Changeset [91164] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64657
Converted this value not preserved when accessed via direct eval.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Upon entry into a non-strict function, primitive this values should be boxed as Object types
(or substituted with the global object) - which is done by op_convert_this. However we only
do so where this is used lexically within the function (we omit the conversion op if not).
The problem comes if a direct eval (running within the function's scope) accesses the this
value.

We are safe in the case of a single eval, since the this object will be converted within
callEval, however the converted value is not preserved, and a new wrapper object is allocated
each time eval is invoked. This is inefficient and incorrect, since any changes to the wrapper
object will be lost between eval statements.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • If a function uses eval, we always need to convert this.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • Don't convert primitive values here - this is too late!

(JSC::Interpreter::privateExecute):

  • Changed op_convert_this to call new isPrimitive method.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Changed op_convert_this to call new isPrimitive method.
  • runtime/JSCell.h:

(JSC::JSCell::JSValue::isPrimitive):

  • Added JSValue::isPrimitive.
  • runtime/JSValue.h:
    • Added JSValue::isPrimitive.

LayoutTests:

Added test case.

  • fast/js/read-modify-eval-expected.txt:
  • fast/js/script-tests/read-modify-eval.js:

(primitiveThisTest):

21:56 Changeset [91163] by dbates@webkit.org

2011-07-16 Daniel Bates <dbates@webkit.org>

Fix Win Cairo Debug build after <http://trac.webkit.org/changeset/91085>.

Add stub implementation of scale factor overloaded ShareableBitmap::paint() for
Cairo WebKit2 port after its usage in changeset <http://trac.webkit.org/changeset/91085>.

Also add stub implementation for GTK.

We'll need to actually implement this. See <https://bugs.webkit.org/show_bug.cgi?id=64664>
and <https://bugs.webkit.org/show_bug.cgi?id=64665> for Cairo and GTK, respectively.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
  • Shared/gtk/ShareableBitmapGtk.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
21:21 Changeset [91162] by dbates@webkit.org

2011-07-16 Daniel Bates <dbates@webkit.org>

Fix Qt Linux Release build after changeset <http://trac.webkit.org/changeset/91085>
(https://bugs.webkit.org/show_bug.cgi?id=64611).

Stub out scale factor-variant implementation of ShareableBitmap::paint().
We'll need to implement this. See <https://bugs.webkit.org/show_bug.cgi?id=64663>
for more details.

  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
19:34 Changeset [91161] by simon.fraser@apple.com

2011-07-16 Simon Fraser <simon.fraser@apple.com>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Implemented a new behavior on GraphicsLayerCA which attempts to keep layers pixel
aligned as page scale changes.

This requires denoting which layer has the page scale on it (it is assumed to be
already aligned), via setAppliesPageScale(). We also now pass a scale and offset
down through the GraphicsLayer commits, which are used to map layer bounds to display
coordinates for rounding.

  • platform/graphics/GraphicsLayer.h: New flags and getters/setters for pixel alignment, and the layer that is the applier of the scale. (WebCore::GraphicsLayer::setMaintainsPixelAlignment): (WebCore::GraphicsLayer::maintainsPixelAlignment): (WebCore::GraphicsLayer::setAppliesPageScale): (WebCore::GraphicsLayer::appliesPageScale):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Initialize the new flags. (WebCore::GraphicsLayer::backingScaleFactor): Utility method that calls the client if there is one. (WebCore::GraphicsLayer::pageScaleFactor): Ditto.
  • platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::backingScaleFactor): Provide default implementation. (WebCore::GraphicsLayerClient::pageScaleFactor): Ditto.
  • platform/graphics/ca/GraphicsLayerCA.h: Pass scale and base-relative offset around to methods that need to update geometry during commit. Some new methods related to pixel alignment.
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::computePositionRelativeToBase): For single-layer commits, we have to compute the base-relative offset, and whether we're under the layer applying the scale by walking up the tree.

(WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly): Call
computePositionRelativeToBase() to get scaling parameters for the target layer.

(WebCore::GraphicsLayerCA::recursiveCommitChanges): Pass flags related to scaling.
positionRelativeToBase is an offset relative to the ancestor layer known to be pixel
aligned. affectedByPageScale is true for layers which are descendants of the layer
which applies the scale.

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Pass scale and offset.
(WebCore::GraphicsLayerCA::updateGeometry): Call computePixelAlignment() to get
pixel-aligned geometry. This only needs to be applied to layers which render content,
so re-organize the code to use the unchanged layer geometry for the structural layer,
but to apply the adjusted geometry to the m_layer.

(WebCore::GraphicsLayerCA::updateStructuralLayer): Pass scale and offset.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Ditto.
(WebCore::GraphicsLayerCA::updateLayerDrawsContent): Ditto.
(WebCore::GraphicsLayerCA::updateContentsScale): Ditto.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::setKeepPixelAligned): When set, dirties flags
for properties that need to be recomputed.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
(WebCore::isIntegral):
(WebCore::GraphicsLayerCA::computePixelAlignment): Map our bounds to screen
scale, round out to an integral rect, then map it back, adding a fudge factor
so that CA backing stores don't end up being smaller than we expect because
of integer truncation.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Turn on pixel alignment if the compositor says so. (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Set the RenderView's layer as the one applying the scale, for the main frame.
  • rendering/RenderLayerCompositor.h: New method.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::keepLayersPixelAligned): Master switch for pixel alignment. Default to on. (WebCore::RenderLayerCompositor::ensureRootLayer): Give the two root-ish layers a client so they can ask for page scale if necessary.

2011-07-16 Simon Fraser <simon.fraser@apple.com>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementation of pageScaleFactor() now that GraphicsLayerClient has
a default implementation.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

2011-07-16 Simon Fraser <simon.fraser@apple.com>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

  • WebView.h:

2011-07-16 Simon Fraser <simon.fraser@apple.com>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

  • src/PageOverlay.cpp:
18:47 Changeset [91160] by commit-queue@webkit.org

DFG JIT compare/branch code emits is-integer tests even when a value is
definitely not an integer.
https://bugs.webkit.org/show_bug.cgi?id=64654

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Added the isKnownNotInteger() method, which returns true if a node is
definitely not an integer and will always fail any is-integer test. Then
modified the compare and branch code to use this method; if it returns
true then is-int tests are omitted and the compiler always emits a slow
call.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):

17:46 Changeset [91159] by dbates@webkit.org

2011-07-16 Daniel Bates <dbates@webkit.org>

Attempt to fix the Qt Linux Release build after changeset <http://trac.webkit.org/changeset/91097>
(https://bugs.webkit.org/show_bug.cgi?id=64615).

  • UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::setCursorHiddenUntilMouseMoves): Added stub method.
  • UIProcess/qt/QtWebPageProxy.h:
17:33 Changeset [91158] by enrica@apple.com

REGRESSION: Pressing return in a particular document sends the cursor to the end of the document.
https://bugs.webkit.org/show_bug.cgi?id=64140
<rdar://problem/9737491>

Source/WebCore:

Inserting a paragraph separator at a break element, inside an inline, generates redundant markup
and moves the selection at the end of the inserted block.
The fix consists in detecting that the insertion point is a break element and simply inserting another
break element. This solves the problem of the wrong final selection and also produces less redundant
markup.

Reviewed by Simon Fraser.

Test: editing/inserting/insert-paragraph-separator-at-break.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Modified logic for insertion at a break
element.

LayoutTests:

Added new test to cover this case and updated results for one test that now
produces simpler markup.

Reviewed by Simon Fraser.

  • editing/inserting/insert-paragraph-separator-at-break-expected.txt: Added.
  • editing/inserting/insert-paragraph-separator-at-break.html: Added.
  • platform/mac/editing/inserting/5058163-1-expected.txt:
16:29 Changeset [91157] by psolanki@apple.com

SubresourceLoader::didReceiveDataArray can crash when calling m_client->didReceiveData()
https://bugs.webkit.org/show_bug.cgi?id=64656
<rdar://problem/9754425>

Reviewed by Alexey Proskuryakov.

  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray): Check for m_client before calling
m_client->didReceiveData().

16:14 Changeset [91156] by commit-queue@webkit.org

DFG speculative JIT has dead code for slow calls for branches.
https://bugs.webkit.org/show_bug.cgi?id=64653

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Removed SpeculativeJIT::compilePeepHoleCall.

  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:
16:01 Changeset [91155] by commit-queue@webkit.org

[Qt] Compilation fails on disabling TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=64408

Fix compilation error due to API name change in GraphicsLayer

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-07-16
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQt::setContentsToBackgroundColor):

  • platform/graphics/qt/GraphicsLayerQt.h:
15:59 Changeset [91154] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

New WebKitSystemInterface functions for CFNetwork-based loader.

../../git/opensource/WebKit.git/Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

../../git/opensource/WebKit.git/Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:39 Changeset [91153] by commit-queue@webkit.org

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <jberlin@apple.com> on 2011-07-16
Reviewed by Darin Adler.

No loads should be going on for a DocumentLoader that has been detached from its frame, but
that appears to be what is happening in this bug.

Add assertions with the hope that someone will run into this while debugging and thereby find
a reproducible case.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

13:12 Changeset [91152] by commit-queue@webkit.org

DOMWindow::open performs a security check on a wrong window
https://bugs.webkit.org/show_bug.cgi?id=64651

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-07-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-window-open-parent.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

LayoutTests:

  • http/tests/security/resources/xss-DENIED-window-open-parent-attacker.html: Added.
  • http/tests/security/xss-DENIED-window-open-parent-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-parent.html: Added.
12:07 Changeset [91151] by weinig@apple.com

Attribute selectors don't handle glob namespaces (e.g. *|E)
https://bugs.webkit.org/show_bug.cgi?id=64567

Reviewed by Anders Carlsson.

Source/WebCore:

Change checking of attribute selectors to match CSS 3 Selectors in
the presence of namespaces. This entails changing the algorithm to
check each attribute on an element as a match for the attribute selector
and taking into account a prefix of *.

  • css/CSSStyleSelector.cpp:

(WebCore::attributeQualifiedNameMatches):
Checks if the a particular attributes qualified name matches
the attribute selector, taking into account a prefix of *.

(WebCore::attributeValueMatches):
Checks if a particular attribute on an element, matches
the attribute selector.

(WebCore::anyAttributeMatches):
Top level attribute check. Checks if any of an elements attributes
match the attribute selector.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Factor out attribute checking code into the above functions.

LayoutTests:

Update results for correct handling of a * prefix in an attribute selector.
Fixes 50 tests.

  • platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-104-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-104-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-105-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-105-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-106-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-106-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-107-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-107-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-108-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-108-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-109-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-109-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-110-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-110-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-130-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-130-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-131-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-131-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-132-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-132-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-133-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-133-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-134-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-134-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-135-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-135-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-136-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-136-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt:
12:06 Changeset [91150] by cevans@google.com

Merge 91005
BUG=88730
Review URL: http://codereview.chromium.org/7396010

05:37 Changeset [91149] by jhoneycutt@apple.com

WinCE build fix. Unreviewed.

  • dom/SelectElement.cpp:
00:33 Changeset [91148] by commit-queue@webkit.org

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-16
Reviewed by Nikolas Zimmermann.

SVG animation API crashes on SVGAnimateTransform
https://bugs.webkit.org/show_bug.cgi?id=64104

Source/WebCore:

This patch ensures the update in AnimatedTransform list in
SVGAnimateTransformElement.cpp is in sync with its wrapper list.

Test: svg/animations/svgtransform-animation-discrete.html

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::animatedTransformListFor):
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):

LayoutTests:

Added the test to cover assertion in AnimatedTransform list where its
value and wrapper length mismatch occurs.

  • svg/animations/script-tests/svgtransform-animation-discrete.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/svgtransform-animation-discrete-expected.txt: Added.
  • svg/animations/svgtransform-animation-discrete.html: Added.

07/15/11:

22:55 Changeset [91147] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix the build.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::updateEnabledState):
22:15 Changeset [91146] by commit-queue@webkit.org

Overlay scrollbars in overflow areas no longer pulse when revealed
https://bugs.webkit.org/show_bug.cgi?id=64606
<rdar://problem/9390674>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

Ensure that the state of the scrollbar implementation is kept in sync
with WebCore's internal representation. Previously, we synchronized them
at paint time, causing pulsing to be skipped due to the scrollbars being
disabled.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

21:41 Changeset [91145] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • WebView.h: (WebView::backingScaleFactor): (WebView::pageScaleFactor):
21:03 Changeset [91144] by abarth@webkit.org

gardening server should proxy buildbot status for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64588

Reviewed by Eric Seidel.

This information will be used to detect build breaks. I took this
opportunity to make ChromiumBuildBot non-static.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
19:11 Changeset [91143] by cevans@google.com

Merge 90936
BUG=88846
Review URL: http://codereview.chromium.org/7390020

19:08 Changeset [91142] by cevans@google.com

Merge 90914
BUG=86705
Review URL: http://codereview.chromium.org/7398018

19:04 Changeset [91141] by cevans@google.com

Merge 91044
BUG=88337
Review URL: http://codereview.chromium.org/7401011

18:41 Changeset [91140] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Another Windows build fix; make this method non-pure virtual.

  • platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::didCommitChangesForLayer):
18:40 Changeset [91139] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix build error in 32-bit builds.

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect):
18:33 Changeset [91138] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::backingScaleFactor): (WebCore::MediaPlayerPrivate::pageScaleFactor):
18:30 Changeset [91137] by simon.fraser@apple.com

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

RenderLayerBacking would set the contentsScale on GraphicsLayers
on creation, and update it when the pageScaleFactor changed. However,
RenderLayerBacking doesn't really know what contentsScale is best
for a layer, so instead, have GraphicsLayers call back through the
GraphicsLayerClient to get the two relevant scale factors, and do
their own computation of contentsScale.

No testable behavior changes.

  • page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): No need to pass the scale.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants): Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on each layer.
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::pageScaleFactorChanged): Remove contentsScale/setContentsScale
  • platform/graphics/GraphicsLayerClient.h: Add methods to fetch the backingScaleFactor() and pageScaleFactor().
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges defaults to ContentsScaleChanged so we update contentsScale on the first flush.

(WebCore::GraphicsLayerCA::setContentsToBackgroundColor):
This was the wrong time to call updateContentsRect() and setupContentsLayer();
those should be done at commit time, so moved to updateLayerBackgroundColor().
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we
have any changes, and call didCommitChangesForLayer() on the client.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here.
(WebCore::clampedContentsScaleForScale): No longer has any hysteresis
on the scale, and now just clamps.
(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales
from the client, and multiply them, then clamp.
(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes
contentsScale into account when deciding to use tiled layer,
so that zooming in will cause layers to start tiling.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call
setContentsScale(), but rather updateContentsScale().
(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits
for properties that depend on the scale.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
Note that contentsScale needs to be updated. At some point we might also
need to dirty other properties.

  • platform/graphics/ca/GraphicsLayerCA.h: Moved the m_allowTiledLayer bool for better packing. No need for a m_contentsScale member now.
  • rendering/RenderLayer.cpp: Removed pageScaleFactorChanged().
  • rendering/RenderLayer.h: Ditto.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to push the contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::didCommitChangesForLayer): Send through to the compositor.
  • rendering/RenderLayerBacking.h: GraphicsLayerClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::didFlushChangesForLayer): We'll use this later. (WebCore::RenderLayerCompositor::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerCompositor::pageScaleFactor): Ditto. (WebCore::RenderLayerCompositor::didCommitChangesForLayer): Ditto. (WebCore::RenderLayerCompositor::ensureRootLayer): No need to push the contents scale. (WebCore::RenderLayerCompositor::pageScaleFactorChanged): Just call notePageScaleFactorChangedIncludingDescendants() on the root GraphicsLayer.
  • rendering/RenderLayerCompositor.h: Added GraphicsLayerClient methods.

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale,
and don't push the scale.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): (WebKit::LayerTreeHostCA::backingScaleFactor): (WebKit::LayerTreeHostCA::pageScaleFactor): (WebKit::LayerTreeHostCA::createPageOverlayLayer):
  • WebProcess/WebPage/ca/LayerTreeHostCA.h: (WebKit::LayerTreeHostCA::didCommitChangesForLayer):

2011-07-15 Simon Fraser <simon.fraser@apple.com>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale.

  • src/PageOverlay.cpp: (WebKit::OverlayGraphicsLayerClientImpl::backingScaleFactor): (WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):
18:10 Changeset [91136] by jchaffraix@webkit.org

[NRWT] Add support for --no-http
https://bugs.webkit.org/show_bug.cgi?id=64564

Reviewed by Dirk Pranke.

Added support for --no-http, which disables both HTTP and websockets tests.
It also matches the old-run-webkit-tests behavior if --force is used.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine
what is worth have an HTTP lock as --no-http to avoid badness.

  • Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that

we do skip properly HTTP / websocket tests inside platform/.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Added tests that we properly skip all the tests.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Added checks for the command line arguments.

17:27 Changeset [91135] by jhoneycutt@apple.com

Build fix. Unreviewed.

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Cast size_t to int for comparison.

17:16 Changeset [91134] by aestes@apple.com

Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
https://bugs.webkit.org/show_bug.cgi?id=64641

Reviewed by Brian Weinstein.

Source/WebCore:

  • WebCore.exp.in: Update to new symbol.
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolarWalkMac): Renamed from applicationIsSolarWalk.

  • platform/RuntimeApplicationChecks.h: Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().

17:03 Changeset [91133] by mrowe@apple.com

Fix the build.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextStateSaver::context): Remove a bogus type qualifier.

16:55 Changeset [91132] by jhoneycutt@apple.com

Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
16:52 Changeset [91131] by mrowe@apple.com

Fix the build.

  • dfg/DFGGraph.h:
16:52 Changeset [91130] by cmarrin@apple.com

Fixing style issues pointed out by Simon for
https://bugs.webkit.org/show_bug.cgi?id=64542

Unreviewed.

16:49 Changeset [91129] by jhoneycutt@apple.com

ALT + DOWN arrow key does not open select

https://bugs.webkit.org/show_bug.cgi?id=14407
<rdar://problem/5319507>

Reviewed by Alexey Proskuryakov.

No test, because eventSender sends events to the WebView, rather than
the popup menu, so the popup isn't closed.

  • WebCore.vcproj/WebCore.vcproj:

Add SelectElementWin.cpp to project.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::platformHandleKeydownEvent):
Moved ARROW_KEYS_POP_MENU code here. Updated to return whether the
function has handled the key, or whether the caller needs to process it
further.
(WebCore::SelectElement::menuListDefaultEventHandler):
Allow the platform the first chance at handling the keyboard event.

  • dom/SelectElement.h:

Declare platformHandleKeydownEvent().

  • dom/SelectElementWin.cpp: Added.

(WebCore::SelectElement::platformHandleKeyboardEvent):
Allow (Shift) F4 and (Ctrl/Shift) Alt/AltGr + Up/Down
arrow to show the popup. After the popup is dismissed, call
setSelectedIndex(), and report that we handled the event.

  • platform/win/PopupMenuWin.cpp:

Declare HIGH_BIT_MASK_SHORT.
(WebCore::PopupMenuWin::show):
Forward WM_SYSKEYDOWN to the popup's HWND.
(WebCore::PopupMenuWin::wndProc):
Allow the same shortcuts that show the menu to hide it, matching
Firefox.

16:48 Changeset [91128] by jhoneycutt@apple.com

Ensure that a single select element's child option elements are
reported correctly to accessibility clients if the children are
changed.

https://bugs.webkit.org/show_bug.cgi?id=64500
<rdar://problem/9773066>

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/win/accessibility/single-select-children-changed.html

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):
Remove a comment about WML, which we no longer support.
(WebCore::AccessibilityMenuListPopup::childrenChanged):
Don't just remove children that were detached - this will miss childen
that were dynamically added. Clear the children and re-add them.

LayoutTests:

  • platform/win/accessibility/single-select-children-changed-expected.txt: Added.
  • platform/win/accessibility/single-select-children-changed.html: Added.
16:39 Changeset [91127] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • DEPS:
16:17 Changeset [91126] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
16:00 Changeset [91125] by rwlbuis@webkit.org

2011-07-15 Rob Buis <rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:
15:49 Changeset [91124] by dglazkov@chromium.org

Refactor TestExpectationModel to use TestExpectationLine as data item.
https://bugs.webkit.org/show_bug.cgi?id=64635

This is a bit largish in scope. Does the following things:

1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,

and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
needs to have any port knowledge.

2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,

and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
Now all expectations are added to the model in the same way!

3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
15:42 Changeset [91123] by aroben@apple.com

Teach TestFailures how to detect interrupted build steps

Fixes <http://webkit.org/b/64619> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
build step was interrupted. Treat it as an error (by returning a failureCount of -1).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cache data that was afflicted by the above bug.

15:40 Changeset [91122] by tony@chromium.org

Unreviewed, unskip css3/selectors3 tests so we can rebaseline them.

  • platform/chromium/test_expectations.txt:
15:40 Changeset [91121] by eric@webkit.org

new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
https://bugs.webkit.org/show_bug.cgi?id=64533

Reviewed by Adam Roben.

Blind removal of Chromium-specific code (now that Chromium does not use this file).

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
15:32 Changeset [91120] by enne@google.com

[chromium] Rebaseline overflow-scroll on Linux after r91114.

Unreviewed.

  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
15:30 Changeset [91119] by aroben@apple.com

Make TestFailures's list of possibly-flaky tests not so tall

Fixes <http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
much room

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Removed a no-longer-used .flakiness-example-separator selector.

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
Use a lot less padding for the possibly-flaky tests.

15:13 Changeset [91118] by tony@chromium.org

[chromium] land linux selection color layout test
https://bugs.webkit.org/show_bug.cgi?id=64631

Reviewed by Ojan Vafai.

Tools:

I had removed this code in r76620 because I thought it wasn't used.
Turns out there was a layout test in the chromium tree that never
got migrated that used it. Re-add the code and land the layout
test (I will remove it from the chromium tree soon).

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::forceRedSelectionColors):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

  • platform/chromium-linux/editing/selection/linux_selection_color.html: Added.
15:10 Changeset [91117] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
15:03 Changeset [91116] by barraclough@apple.com

NativeError.prototype objects have Class? of "Object" but should be "Error"
https://bugs.webkit.org/show_bug.cgi?id=55346

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • Switch to putDirect since we're not the only ones tranitioning this Structure now.
  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

  • runtime/NativeErrorPrototype.h:
    • Switch base class to ErrorPrototype.

LayoutTests:

Added test case.

  • fast/js/native-error-prototype-expected.txt: Added.
  • fast/js/native-error-prototype.html: Added.
  • fast/js/script-tests/native-error-prototype.js: Added.
14:57 Changeset [91115] by barraclough@apple.com

DFG JIT - Where arguments passed are integers, speculate this.
https://bugs.webkit.org/show_bug.cgi?id=64630

Reviewed by Sam Weinig.

Presently the DFG JIT is overly aggressively predicting double.
Use a bit of dynamic information, and curtail this a little.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • Check for integer arguments.
  • dfg/DFGGraph.h:
    • Function declaration.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::FunctionExecutable::compileForCallInternal):

  • Add call to predictArgumentTypes.
14:54 Changeset [91114] by enne@google.com

Reviewed by Simon Fraser.

Overlap map for compositing needs to consider clipping
https://bugs.webkit.org/show_bug.cgi?id=63493

Source/WebCore:

Test: compositing/layer-creation/overlap-clipping.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Added new test. limit-layer-bounds-clipping-ancestor had changed
behavior because some layers no longer needed to become composited.
Adjusted that test to be less platform-specific as well.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • compositing/layer-creation/overlap-clipping.html: Added.
  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
14:24 Changeset [91113] by commit-queue@webkit.org

Unreviewed, rolling out r90592.
http://trac.webkit.org/changeset/90592
https://bugs.webkit.org/show_bug.cgi?id=64627

Causes crashes with the web audio async decoding API
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

  • manual-tests/array-buffer-memory.html: Removed.
14:22 Changeset [91112] by kbr@google.com

Don't restore WebGL context if it was guilty of a graphics reset
https://bugs.webkit.org/show_bug.cgi?id=64497

Reviewed by Stephen White.

Source/WebCore:

Use getGraphicsResetStatusARB already defined in Extensions3D to
determine why the context was lost, and respond to guilty context
notifications by forbidding restoration of the context.

It isn't currently possible to write an automated test for this.
We might consider extending the WEBKIT_lose_context extension to
allow a reason to be provided why the context was lost. It was
tested manually in Chromium on Windows and Linux with some test
cases that provoke actual graphics card resets.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

Source/WebKit/chromium:

Actually implement getGraphicsResetStatusARB rather than inferring
the status based on whether the context has been lost.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

LayoutTests:

Updated expectations for context-lost test and added comment about
the order of event delivery. Per the specification of the
WEBKIT_lose_context extension, the previous expectations were wrong.

  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
14:17 Changeset [91111] by lforschler@apple.com

Update Versioning.

14:17 Changeset [91110] by cmarrin@apple.com

Move TransformState to platform/graphics and give it the option to transform just a FloatQuad
https://bugs.webkit.org/show_bug.cgi?id=64542

Reviewed by Simon Fraser.

This is to make it possible to use TransformState in some GraphicsLayer work. HitTestingTransformState
was split out and left in rendering since it's not needed in the platform code. Also added a FIXME
because HitTestingTransformState should eventually be replaced by TransformState.

14:07 Changeset [91109] by lforschler@apple.com

New branch.

14:00 Changeset [91108] by adachan@apple.com

Implement "Jump to Selection" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64569

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView centerSelectionInVisibleArea:]): Call WebPageProxy::centerSelectionInVisibleArea().
(-[WKView validateUserInterfaceItem:]): Enable the centerSelectionInVisibleArea: selector if there's a selection
range or if there's an insertion point in an editable area.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::showFindIndicatorInSelection): Call updateFindIndicator() to show the find indicator.

  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea): Use the selection in the focused or main frame.
After scrolling the selection into view, flash the find indicator.

13:54 Changeset [91107] by mitz@apple.com

Chromium build fix.

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::setCursorHiddenUntilMouseMoves):

  • src/WebPopupMenuImpl.h:
13:49 Changeset [91106] by dglazkov@chromium.org

Revert http://trac.webkit.org/changeset/91091, since Python 2.5
does not support enumerate() start argument.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
13:49 Changeset [91105] by enne@google.com

[chromium] Re-mark tests as failing as a result of r91069
https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

senorblanco checked in baselines, but these tests appear to still be failing.

  • platform/chromium/test_expectations.txt:
13:41 Changeset [91104] by weinig@apple.com

Reviewed by Simon Fraser.

We should import the CSS 3 Selectors test suite
https://bugs.webkit.org/show_bug.cgi?id=64610

Add dump of the CSS 3 Selectors test suite from http://www.w3.org/Style/CSS/Test/CSS3/Selectors/current/.
Add standalone versions of the html, xhtml and xml suites.

  • css3/selectors3: Added.
  • css3/selectors3/html: Added.
  • css3/selectors3/xhtml: Added.
  • css3/selectors3/xml: Added.
  • platform/mac/css3/selectors3: Added.
  • platform/mac/css3/selectors3/html: Added.
  • platform/mac/css3/selectors3/xhtml: Added.
  • platform/mac/css3/selectors3/xml: Added.

[Individual tests elided]

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Added css3/selectors3 pending results.

13:41 Changeset [91103] by dglazkov@chromium.org

Clean up test_expectations.py after refactorings.
https://bugs.webkit.org/show_bug.cgi?id=64620

  • Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with its sub-part, the actual expectation.
  • Renamed all references to options to modifier to eliminate dual terminology.
  • Made a bunch of parser constants and changed all callsites to use them.
  • Various other minor clean-ups.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
13:35 Changeset [91102] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Minor changes needed to keep the compiler happy.

No new tests because no change in functionality.

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCopy):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::WebCoreSynchronousLoaderClient::willSendRequest):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::toTimeT):

13:22 Changeset [91101] by senorblanco@chromium.org

Unreviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
13:17 Changeset [91100] by mitz@apple.com

Windows build fix.

  • UIProcess/win/WebView.cpp:
13:14 Changeset [91099] by commit-queue@webkit.org

DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches.
https://bugs.webkit.org/show_bug.cgi?id=64573

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-15
Reviewed by Gavin Barraclough.

This patch moves some of NonSpeculativeJIT's functionality up into the
JITCodeGenerator superclass so that it can be used from both JITs. Now,
in cases where the speculative JIT doesn't want to speculate but still
wants to emit good code, it can reliably emit the same code sequence as
the non-speculative JIT. This patch also extends the non-speculative
JIT's compare optimizations to include compare/branch fusing, and
extends the speculative JIT's compare optimizations to cover StrictEqual.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::detectPeepHoleBranch):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • wtf/Platform.h:
13:10 Changeset [91098] by mitz@apple.com

Windows build fix.

  • UIProcess/win/WebView.h:
13:03 Changeset [91097] by mitz@apple.com

REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
https://bugs.webkit.org/show_bug.cgi?id=64615

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
entering full screen.
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
hiding the HUD.

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.

  • page/Chrome.cpp:

(WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
+[NSCursor setHiddenUntilMouseMoves:].

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit2:

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
to the page proxy.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:59 Changeset [91096] by scheib@chromium.org

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
12:51 Changeset [91095] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64250
Global strict mode function leaking global object as "this".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The root problem here is that we pass the wrong values into
calls, and then try to fix them up in the callee. Correct
behaviour per the spec is to pass in the value undefined,
as this unless either (1) the function call is based on an
explicit property access or (2) the base of the call comes
directly from a 'with'.

This change does away with the need for this conversion of
objects (non strict code should only box primitives), and
does away with all this conversion for strict functions.

This patch may have web compatibility ramifications, and may
require some advocacy.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecode/Opcode.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitResolveWithThis):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolveThisAndProperty):

  • Based on resolveBaseAndProperty, but produce correct this value.

(JSC::Interpreter::privateExecute):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JITStubs.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • runtime/JSActivation.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSStaticScopeObject.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • removed NeedsThisConversion.
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):

  • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSValue.h:
    • removed NeedsThisConversion.
  • runtime/JSVariableObject.h:
    • Corrected StructureFlags inheritance.
  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

  • Added IsEnvironmentRecord to StructureFlags, addded createStructure.
  • runtime/Structure.h:
    • removed NeedsThisConversion.
  • tests/mozilla/ecma/String/15.5.4.6-2.js:

(getTestCases):

  • Removed invalid test case.

Source/WebCore:

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

  • Change call to pass DOM Window shell, instead of the global varaible object.

LayoutTests:

Add test case / update test results.

  • fast/js/call-base-resolution-expected.txt: Added.
  • fast/js/call-base-resolution.html: Added.
    • Add test for ES5 correct this value resolution in calls.
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
12:46 Changeset [91094] by commit-queue@webkit.org

Unreviewed, rolling out r91082, r91087, and r91089.
http://trac.webkit.org/changeset/91082
http://trac.webkit.org/changeset/91087
http://trac.webkit.org/changeset/91089
https://bugs.webkit.org/show_bug.cgi?id=64616

gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

12:44 Changeset [91093] by commit-queue@webkit.org

[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
https://bugs.webkit.org/show_bug.cgi?id=64612

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-15
Reviewed by Stephen White.

Tested by compositing/shadows/shadow-drawing.html

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):

12:33 Changeset [91092] by dglazkov@chromium.org

Move expectation parsing code to TestExpectationParser.
https://bugs.webkit.org/show_bug.cgi?id=64605

This is a somewhat mechanical move, with two interesting bits:

1) TestExpectationParser.parse methods renamed to tokenize, to better
reflect what they do

2) TestExpectationLine now carries all of its info, from tokens to parsed data,
and even the list of tests that it matches (a line may refer to more than one test).

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods

to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
to "tokenize", changed callsites to use new code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
12:29 Changeset [91091] by dglazkov@chromium.org

Switch to use Python enumerate function to enumerate line numbers.
https://bugs.webkit.org/show_bug.cgi?id=64602

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
12:27 Changeset [91090] by commit-queue@webkit.org

Avoid rounded rect corner-drawing overhead if no corners are visible
https://bugs.webkit.org/show_bug.cgi?id=64584

Patch by Ian Henderson <ianh@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

No new tests, rendering is visually identical.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::unroundClippedCorners):
(WebCore::RenderBoxModelObject::paintBorder):
Any invisible corner may be replaced with a corner of radius zero, as
long as the stroke style is solid. Change the GraphicsContext
parameter into a PaintInfo parameter so we can get the rect to be
drawn.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

12:23 Changeset [91089] by levin@chromium.org

Another attempted build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:16 Changeset [91088] by jeffm@apple.com

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

  • WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.
12:15 Changeset [91087] by levin@chromium.org

Chromium build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:14 Changeset [91086] by senorblanco@chromium.org

Unreviewed. Yet more chromium test baselines.

Somehow I messed these up in my mass-rebaselining.

  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
12:10 Changeset [91085] by andersca@apple.com

Find indicator should take scale factor into account
https://bugs.webkit.org/show_bug.cgi?id=64611
<rdar://problem/9761020>

Reviewed by Sam Weinig.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
Keep track of the scale factor of the find indicator bitmap.

(WebKit::FindIndicator::draw):
Pass the scale factor to ShareableBitmap::draw.

  • UIProcess/FindIndicator.h:

Add scale factor member variable.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
This now takes the content image scale factor.

  • UIProcess/WebPageProxy.messages.in:

Add the scale factor.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Size the backing store correctly, and apply the scale factor to
the graphics context.

(WebKit::FindController::hideFindIndicator):
Pass the scale factor along.

11:52 Changeset [91084] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/AuthenticationCF.h: Just use AuthenticationMac.h instead of having

Mac-specific declarations here.

  • platform/network/cf/CredentialStorageCFNet.cpp:
  • platform/network/mac/AuthenticationMac.h:
11:51 Changeset [91083] by senorblanco@chromium.org

Unreviewed; chromium test expectations update.

Remove some now-passing tests from chromium's text_expectations.

  • platform/chromium/test_expectations.txt:
11:49 Changeset [91082] by levin@chromium.org

currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

11:38 Changeset [91081] by psolanki@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get LoaderRunLoop to work on Mac when USE(CFNETWORK) is enabled. Although we could use the
main run loop, it's better to have a separate thread handling the loads so that it can work
in parallel to the main thread. This is similar to what NSURLConnection does for us
internally when we use the NS APIs.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread): Create an autorelease pool for objc code that might be called in
the run loop.
(WebCore::loaderRunLoop):

  • platform/network/cf/LoaderRunLoopCF.h:
11:34 Changeset [91080] by senorblanco@chromium.org

Unreviewed. New chromium test baselines after r91069.

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
  • platform/chromium-win-vista/fast/block: Added.
  • platform/chromium-win-vista/fast/block/positioning: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Added.
  • platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win-vista/svg/zoom/text: Added.
  • platform/chromium-win-vista/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win-xp/fast/dynamic: Added.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/005-vertical-expected.png:
  • platform/chromium-win/fast/lists/006-vertical-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/009-vertical-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Removed.
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-win/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.png:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/custom/text-rotation-expected.png:
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-win/svg/hixie/error/017-expected.png:
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium/test_expectations.txt:
11:25 Changeset [91079] by kenneth@webkit.org

REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect

Reviewed by Antonio Gomes.

Only set setFixedVisibleContentRect when in resizesToContents mode.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

11:11 Changeset [91078] by mrobinson@webkit.org

Build fixes for WebKit2. Ensure that all generated sources are
on nodist primaries, that they are on forward declared variables
so that BUILT_SOURCES is calculated properly and that zlib is
included during linking (for WOFF support).

.:

  • GNUmakefile.am:
  • Source/autotools/webkit.m4: Include test for zlib.

Source/WebKit/gtk:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:

Tools:

  • WebKitTestRunner/GNUmakefile.am:
10:23 Changeset [91077] by xji@chromium.org

--webkit-visual-word crash on mixed editability
https://bugs.webkit.org/show_bug.cgi?id=61978

--webkit-visual-word crashes (VisiblePosition.getInlineBoxAndOffset could return null box)
https://bugs.webkit.org/show_bug.cgi?id=62814

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace previousWordPosition/nextWordPosition with previousBoundary/nextBoundary which do
not honor editable bounary. Honor editable boundary as the last stage of leftWordPosition
and rightWordPosition.

Check previousBoundary/nextBoundary against NULL. Have a static function to encapsulate the
usage of getInlineBoxAndOffset and check the visible position is not NULL before passing to
getInlineBoxAndOffset. Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Test: editing/selection/move-by-word-visually-null-box.html

  • editing/visible_units.cpp:

(WebCore::positionIsInBox):
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::positionIsInsideBox):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

Add a standalone test for testing getInlineBoxAndOffset returning null box.

  • editing/selection/move-by-word-visually-null-box-expected.txt: Added.
  • editing/selection/move-by-word-visually-null-box.html: Added.
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html:
10:17 Changeset [91076] by senorblanco@chromium.org

Unreviewed. Mopping up some more expectations after r91069.

  • platform/chromium/test_expectations.txt:
10:12 Changeset [91075] by psolanki@apple.com

Remove unncessary creation of connectionProperties dictionary
https://bugs.webkit.org/show_bug.cgi?id=63958

Reviewed by Alexey Proskuryakov.

No new tests because no change in functionality.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

09:50 Changeset [91074] by enne@google.com

[chromium] Mark more tests failing as a result of r91069
https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:58 Changeset [91073] by dglazkov@chromium.org

Store error and warning information on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64565

Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,

converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
08:55 Changeset [91072] by dglazkov@chromium.org

Plumb the use of TestExpectationLine deeper, clean up.
https://bugs.webkit.org/show_bug.cgi?id=64559

Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
also cleaning up names and remove an unused TestExpectations._get_options_list member.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
08:51 Changeset [91071] by dglazkov@chromium.org

Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
https://bugs.webkit.org/show_bug.cgi?id=64554

This moves us toward the world where errors are collected on the expectations, which allows us to
easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.

Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
parsing.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,

changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
08:34 Changeset [91070] by pfeldman@chromium.org

Web Inspector: Focusing on another node while editing CSS property does not update styles
https://bugs.webkit.org/show_bug.cgi?id=64283

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-change-node-while-editing.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype.updateStyles):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.callback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.inlineStyleCallback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
(WebInspector.MetricsSidebarPane.prototype._styleSheetChanged):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylesSidebarPane.prototype._styleSheetChanged):
(WebInspector.StylesSidebarPane.prototype._attributesUpdated):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

  • inspector/styles/styles-change-node-while-editing-expected.txt: Added.
  • inspector/styles/styles-change-node-while-editing.html: Added.
08:27 Changeset [91069] by commit-queue@webkit.org

[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
https://bugs.webkit.org/show_bug.cgi?id=64368

Patch by Mike Reed <reed@google.com> on 2011-07-15
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
08:10 Changeset [91068] by aroben@apple.com

Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Updated for renames.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and

reordered <script>s to put files which others depend on for parsing first.

07:38 Changeset [91067] by commit-queue@webkit.org

Pixel difference in FEMorphology effect
https://bugs.webkit.org/show_bug.cgi?id=63930

Source/WebCore:

Patch by Piroska András <Piroska.Andras@stud.u-szeged.hu> on 2011-07-15
Reviewed by Zoltan Herczeg.

Using short-circuit evaluation in the setFilterEffectAttribute function
was wrong. We should call both setRadius functions and evaluate the
changes separately.

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):

LayoutTests:

Patch by Gabor Loki <loki@webkit.org> on 2011-07-15
Reviewed by Zoltan Herczeg.

Layout test is updated to follow the bugfix.

  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
07:02 Changeset [91066] by jeffm@apple.com

Fullscreen content doesn't use fullscreen controller on Windows
https://bugs.webkit.org/show_bug.cgi?id=64540
<rdar://problem/9510455>

Source/WebCore:

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.

  • rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests:

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

  • fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.
  • fullscreen/video-controls-override.html: Add new test to check the height of the panel, and

log errors if window.internals or window.layoutTestController are undefined.

06:10 Changeset [91065] by zimmermann@webkit.org

2011-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix build failure introduced in r91061.

  • page/Console.cpp: (WebCore::Console::markTimeline): Remove argument name from unused parameter.
05:02 Changeset [91064] by kenneth@webkit.org

Upstream QtWebKit/N9 changes related to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=64589

Reviewed by Simon Hausmann.

Source/WebCore:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

Make visibleContentRect return the fixed value if set, and remove
all calls to actualVisibleContentRect.

Also updated the documentation.

This is similar to what we have on our QtWebKit/N9 branch and is
pretty well tested.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
If a fixed visibleContentRect is set, return that.
Remove the code returning the contents size when in
paintsEntireContents mode as that is wrong and already
ifdeffed out for EFL.
(WebCore::ScrollView::setScrollPosition):
Do not try to be smart and update the fixed visibleContentsRect
automatically, as the embedder might ignore the scroll request
for various reasons.

  • platform/ScrollView.h:

(WebCore::ScrollView::setFixedVisibleContentRect):
(WebCore::ScrollView::fixedVisibleContentRect):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setActualVisibleContentRect):
Change to use setFixedVisibleContentRect.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • symbian/eabi/QtWebKitu.def:

Source/WebKit2:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFixedVisibleContentRect):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleArea):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
04:09 Changeset [91063] by carlosgc@webkit.org

[GTK] Build plugin process by default when building WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64592

Reviewed by Philippe Normand.

  • configure.ac:
03:40 Changeset [91062] by carlosgc@webkit.org

Reviewed by Martin Robinson.

[GTK] Install a custom X error handler in plugin process
https://bugs.webkit.org/show_bug.cgi?id=63248

Some plugins, specially flash, can cause X errors that when
handled by the default X error handler (or the GDK one) abort the
process. Since we don't want to crash due to buggy plugins, we
install a custom error handler to show a warning when a X error
happens without aborting.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::webkitgtkXError):
(WebKit::PluginProcessMainGtk):

03:06 Changeset [91061] by commit-queue@webkit.org

Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.
https://bugs.webkit.org/show_bug.cgi?id=63317

Patch by Mike West <mkwst@chromium.org> on 2011-07-15
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-time-stamp.html

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::consoleTimeStamp):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleTimeStampImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didTimeStamp):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimeStampData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

  • page/Console.cpp:

(WebCore::Console::markTimeline):
(WebCore::Console::timeStamp):

  • page/Console.h:
  • page/Console.idl:

LayoutTests:

  • inspector/timeline/resources/timeline-iframe-data.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch.html:
  • inspector/timeline/timeline-mark-timeline-expected.txt:
  • inspector/timeline/timeline-mark-timeline.html:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.dumpTimelineRecord):

  • inspector/timeline/timeline-time-stamp-expected.txt: Added.
  • inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
  • platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
  • platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.
01:35 Changeset [91060] by commit-queue@webkit.org

LocalStorage: Changed the value type of ItemTable from TEXT to BLOB
to avoid string truncation.
This patch will also convert the exsisting ItemTable and perform
the DATA MIGRATION job.
https://bugs.webkit.org/show_bug.cgi?id=58762

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2011-07-15
Reviewed by Jeremy Orlow.

Tests: manual-tests/localstorage-value-truncation.html

  • manual-tests/localstorage-value-truncation.html: Added.

Demostrate the testcase shown in bug 58762.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclearedAsBlob):
Test if the pre-defined type of column is BLOB.

  • platform/sql/SQLiteStatement.h:
  • storage/StorageAreaSync.cpp:

Change the localStorage value type from Text to BLOB to avoid the
value string truncation at \x00.
(WebCore::StorageAreaSync::openDatabase):
Change the database structure, use BLOB to replace the TEXT type of
value segment in ItemTable.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
Migrate the ItemTable if the pre-defined type of value is TEXT.
(WebCore::StorageAreaSync::performImport):
Use getColumnBlobAsString() to import the BLOB value.
(WebCore::StorageAreaSync::sync):
Use bindBlob() to bind value string to the SQLiteStatement for the
database execution.

  • storage/StorageAreaSync.h:
01:25 WebKitGTK edited by plaes@plaes.org
Looking for 1.4.3 ;) (diff)
01:22 Changeset [91059] by abarth@webkit.org

NRWT stores the Chromium revision number in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=64586

I have no earthly idea how to test this change.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
01:10 Changeset [91058] by commit-queue@webkit.org

Clear the content of a search input form when 'Escape' is pressed.
https://bugs.webkit.org/show_bug.cgi?id=51897

Source/WebCore:

This change added handleKeydownEvent() to a search input form,
which clears the form and triggers a 'search' event when 'Escape' is pressed.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

Test: fast/forms/input-search-press-escape-key.html

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

  • html/SearchInputType.h:

LayoutTests:

The added test checks if the value in a search input form is cleared
and a 'search' event is triggered, when we press 'Escape' key.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

  • fast/forms/input-search-press-escape-key-expected.txt: Added.
  • fast/forms/input-search-press-escape-key.html: Added.
00:23 Changeset [91057] by commit-queue@webkit.org

Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
https://bugs.webkit.org/show_bug.cgi?id=64360

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-15
Reviewed by Hajime Morita.

No new tests needed because the patch is just a refactor.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

Note: See TracTimeline for information about the timeline view.