Timeline


and

07/21/11:

23:55 Changeset [91558] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

23:28 Changeset [91557] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix after r91555.

22:35 Changeset [91556] by tkent@chromium.org
  • 5 edits in trunk

A trivial fix for r91550.
https://bugs.webkit.org/show_bug.cgi?id=65001

Source/WebCore:

Need to update placeholder visibility when the owner elemnent style is changed.

  • html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):
Call updatePlaceholderVisibility().

LayoutTests:

  • platform/chromium/test_expectations.txt:
22:34 Changeset [91555] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=19271
eliminate PIC branches by changing NaN handling in JSValue::toNumber

Reviewed by Sam Weinig.

Moving the non-numeric cases out of line seems to be a consistent
win on SunSpider for me, to the order of about 0.5%.

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toNumber):

  • Changed to only handle values that are already numbers, moce non-numeric cases out of line.
  • runtime/JSValue.cpp:

(JSC::JSValue::toNumberSlowCase):

  • Added toNumberSlowCase, handling non-numeric cases.
  • runtime/JSValue.h:
    • Add declaration of toNumberSlowCase.
22:27 Changeset [91554] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65002
Get authentication to work with USE(CFNETWORK) on Mac

Reviewed by David Kilzer.

Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
one given to us by CFNetwork.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
new CFURLAuthChallengeRef ivar.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
(WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
(WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
creating a new one.

22:24 Changeset [91553] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64875
Use of yield keyword is broken

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseIdentifier):

  • The bug here is that a successful match of a RESERVED_IF_STRICT token from parseKeyword is being nullified back to IDENT. The problem is that in the case of IDENT matches parseKeyword should not move the lexer's input position, but in the case of RESERVED_IF_STRICT it has done so.

LayoutTests:

  • fast/js/reserved-words-as-property-expected.txt:
  • fast/js/script-tests/reserved-words-as-property.js:
    • Make this test more comprehensive, to cover future-reserved & non-reserved words.
22:06 Changeset [91552] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a failing expectation for fast/forms/placeholder-in-invisible-elements.html
added by r91550 on Chromium. The failure is tracked by the bug 65010.

  • platform/chromium/test_expectations.txt:
21:55 Changeset [91551] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Remove wrong test expectation added in r91490.

Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009.

  • platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Removed.
  • platform/chromium/test_expectations.txt
20:31 Changeset [91550] by tkent@chromium.org
  • 4 edits
    4 adds in trunk

REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
https://bugs.webkit.org/show_bug.cgi?id=65001

Reviewed by Dimitri Glazkov.

Source/WebCore:

Tests: fast/forms/placeholder-in-invisible-elements.html

fast/forms/search-cancel-in-invisible-elements.html

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Don't show the placeholder if the 'visibility' property of the owner element is 'hidden.'

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::visibilityForCancelButton): ditto.

LayoutTests:

  • fast/forms/placeholder-in-invisible-elements-expected.html: Added.
  • fast/forms/placeholder-in-invisible-elements.html: Added.
  • fast/forms/search-cancel-in-invisible-elements-expected.html: Added.
  • fast/forms/search-cancel-in-invisible-elements.html: Added.
20:27 Changeset [91549] by commit-queue@webkit.org
  • 8 edits in trunk

The input[type="number"] with step="any" should not suffer from step mismatch.
https://bugs.webkit.org/show_bug.cgi?id=64858

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-21
Reviewed by Kent Tamura.

Source/WebCore:

Added check step="any" not to suffer from step mismatch.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep): Added check step="any".
(WebCore::HTMLInputElement::alignValueForStep): Added.

LayoutTests:

Added test cases of input[type="number"] with step="any"

  • fast/forms/input-stepup-stepdown-expected.txt: added the test cases.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
20:12 Changeset [91548] by morrita@google.com
  • 12 edits
    2 moves in trunk/Source/WebCore

[Refactoring] ShadowContentSelector should be ShadowInclusionSelector
https://bugs.webkit.org/show_bug.cgi?id=64850

Reviewed by Dimitri Glazkov.

Renamed:

  • ShadowContentSelector -> ShadowInclusionSelector
  • ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor
  • ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select
  • ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect
  • ShadowContentSelector::didSelectInclusion -> ShadowInclusionSelector::didSelect
  • ShadowContentSelector::willSelectInclusionOver -> ShadowInclusionSelector::willSelectOver
  • ShadowContentSelector::hasChildren -> ShadowInclusionSelector::hasCandidates

No new tests. Just a textual change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/NodeRenderingContext.cpp:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowContentSelector.cpp.

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowInclusionSelector::ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::~ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::select):
(WebCore::ShadowInclusionSelector::unselect):
(WebCore::ShadowInclusionSelector::findFor):
(WebCore::ShadowInclusionSelector::didSelect):
(WebCore::ShadowInclusionSelector::willSelectOver):

  • dom/ShadowInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowContentSelector.h.

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowInclusionSelector::hasCandidates):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:
20:00 Changeset [91547] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60737

ThumbPosition() in ScrollbarTheme should be ceiled before returned.
Otherwise, some topest/leftest content can not be shown by dragging
scrollbar thumb.

Source/WebCore:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

Test: scrollbars/scrollbar-drag-thumb-with-large-content.html

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbPosition):

  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarThemeQt::thumbPosition):

LayoutTests:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

  • scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt: Added.
  • scrollbars/scrollbar-drag-thumb-with-large-content.html: Added.
19:46 Changeset [91546] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix typo in TestFailures

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
18:34 Changeset [91545] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update after r91533.
fast/css/absolute-child-with-percent-height-inside-relative-parent.html is missing a pixel result.
A patch to add the pixel result has been uploaded to the bug 64046.

  • platform/chromium/test_expectations.txt:
18:12 Changeset [91544] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

18:11 Changeset [91543] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.2

New tag.

18:02 Changeset [91542] by simon.fraser@apple.com
  • 5 edits in trunk/Source/WebCore

GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489

Reviewed by James Robinson.

Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
for subframes, when those GraphicsLayers are rooted in the
parent document.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
that contains the rootmost frame on which sync was called. This is used
to indicate to the compositor whether it's the root of the sync.
(WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
Frame in.
(WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.

  • page/FrameView.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
to specify whether this compositor is in the rootmost Frame being flushed.
We can avoid doing work if we know that flushing some ancestor frame would
have also traversed our GraphicsLayers.

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
callers are probably most intersted in enclosingCompositorFlushingLayers().

17:48 Changeset [91541] by ojan@chromium.org
  • 3 edits in trunk/Tools

simplify gtest display now that we strip modifiers from the JSON
https://bugs.webkit.org/show_bug.cgi?id=64990

Reviewed by Adam Barth.

Now that names are normalized, we can remove all the code that
handles gtest name changes (e.g. for adding modifiers like DISABLED_).
Instead, if you try to list a test with a modifier in it, we need
to strip the modifier so we get the normalized value.

We also get rid of the concept of extra/missing expectations for gtests.
In a patch soon, we'll stop showing extra/missing expectations from the UI
entirely and only leave it for the special updating test_expectations.txt
view of the dashboard, which doesn't apply to gtests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
17:40 Changeset [91540] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

Local files cannot load icons.
https://bugs.webkit.org/show_bug.cgi?id=62459

Previous policy only allowed favicons for pages whose protocol was part of HTTP family.
Changed that to allow to any url that's not empty and whose protocol is not "about".
Also added this check where it attempts to start loading the favicon, so it can avoid
wasting time downloading a resource that won't be stored and won't be used.

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-07-21
Reviewed by Adam Barth.

Test: manual-tests/resources/favicon-loads-for-local-files.html

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Added check to avoid to request a favicon
when there's no way to store it.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon"
to reflect better which url we're handling.

(WebCore::IconDatabase::synchronousIconForPageURL): Ditto.
(WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
(WebCore::IconDatabase::retainIconForPageURL): Ditto.
(WebCore::IconDatabase::releaseIconForPageURL): Ditto.
(WebCore::IconDatabase::setIconURLForPageURL): Ditto.
(WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
(WebCore::IconDatabase::importIconURLForPageURL): Ditto.
(WebCore::IconDatabase::performURLImport): Ditto.

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its
default behavior of not allowing favicons when we have IconDatabase enabled.

  • manual-tests/resources/favicon-loads-for-local-files.html: Added.
  • manual-tests/resources/favicon.png: Added.
17:36 Changeset [91539] by lforschler@apple.com
  • 12 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r90198.

17:29 Changeset [91538] by abarth@webkit.org
  • 10 edits in trunk/Tools

Refactor Trac.js for use in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64998

Reviewed by Adam Roben.

This patch refactors Trac.js to match the architecture and style of
garden-o-matic. I've also factored AsynchronousCache out of Trac (and
moved it to base) because it was redundant with some other code we
already had.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

(FailingTestsBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
17:23 Changeset [91537] by lforschler@apple.com
  • 5 edits
    3 copies in branches/safari-534.51-branch

Merge r90166.

17:21 Changeset [91536] by lforschler@apple.com
  • 6 edits
    4 copies in branches/safari-534.51-branch

Merge r90156.

17:18 Changeset [91535] by lforschler@apple.com
  • 4 edits
    4 copies in branches/safari-534.51-branch

Merge r90130.

17:15 Changeset [91534] by lforschler@apple.com
  • 11 edits
    2 deletes in branches/safari-534.51-branch/Source

Merge r90087.

17:14 Changeset [91533] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests: Test to cover absolutely positioned child with percentage height
in relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

  • fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.
17:00 Changeset [91532] by mdelaney@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Changelog fix for 91496

16:53 Changeset [91531] by gavinp@chromium.org
  • 3 edits
    2 adds in trunk

Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.

https://bugs.webkit.org/show_bug.cgi?id=64736

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/css-imports-2.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::checkLoaded):

LayoutTests:

  • fast/css/css-imports-2-expected.txt: Added.
  • fast/css/css-imports-2.html: Added.
16:29 Changeset [91530] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Temporarily add failing test expectation for multi column tests after r91497.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [91529] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix issue throwing a 500 to the bots. We were modifying
the dictionary during an iteration over it's keys and would get
RuntimeError: dictionary changed size during iteration

  • TestResultServer/model/jsonresults.py:
16:21 Changeset [91528] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg.

  • platform/chromium/test_expectations.txt:
16:14 Changeset [91527] by lforschler@apple.com
  • 6 edits
    4 copies in branches/safari-534.51-branch

Merge r90068.

15:57 Changeset [91526] by abarth@webkit.org
  • 2 edits in trunk/Tools

ORWT fails to consume some NRWT arguments
https://bugs.webkit.org/show_bug.cgi?id=64988

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests:
15:34 Changeset [91525] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Yet another spinbutton test ...

  • platform/win/Skipped:
15:31 Changeset [91524] by abarth@webkit.org
  • 2 edits
    1 delete in trunk/Tools

Merge TestFailures and garden-o-matic unit tests harness
https://bugs.webkit.org/show_bug.cgi?id=64984

Reviewed by Adam Roben.

One unit testing framework is better than two.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
15:27 Changeset [91523] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.51-branch

Merge r90038.

15:24 Changeset [91522] by lforschler@apple.com
  • 3 edits
    36 copies in branches/safari-534.51-branch

Merge r89836.

15:22 Changeset [91521] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Add another spinbutton test to the Skipped list to get the bots green.

  • platform/win/Skipped:
15:22 Changeset [91520] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.51-branch

Merge r89831.

15:20 Changeset [91519] by abarth@webkit.org
  • 4 edits
    16 copies
    1 delete in trunk/Tools

Rubber-stamped by Adam Roben.

Move garden-o-matic files into the same directory as TestFailures to
make it easier to integrate the codebases.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
  • Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
15:13 Changeset [91518] by ojan@chromium.org
  • 2 edits in trunk/Tools

fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832

Reviewed by Tony Chang.

Make them actual anchor tags and linkify the test name instead of
adding an extra link. Also simplify the update view since we now
show the linkified test name.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:09 Changeset [91517] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.51-branch

Merge r89780.

15:09 Changeset [91516] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit.org builders should upload results to test-results AppEngine instance
https://bugs.webkit.org/show_bug.cgi?id=64979

Reviewed by Adam Roben.

The master just needs to pass some flags to NRWT. This patch also lets
ORWT consume the flags (ignoring them) so we can pass the flags
unconditionally.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/old-run-webkit-tests:
15:02 Changeset [91515] by ojan@chromium.org
  • 3 edits in trunk/Tools

normalize gtest names in the result json
https://bugs.webkit.org/show_bug.cgi?id=64971

Reviewed by Eric Seidel.

This will make the resulting JSON smaller and make the
flakiness dashboard much more sane (e.g. we won't need to
show you the FLAKY_ version and the normal version).

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
15:01 Changeset [91514] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.51-branch

Merge r89769.

14:59 Changeset [91513] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r89720.

14:58 Changeset [91512] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.51-branch

Merge r89614.

14:54 Changeset [91511] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.51-branch

Merge r89595.

14:53 Changeset [91510] by cdn@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-20 Cris Neckar <cdn@chromium.org>

Hook v8 up to cryptographicallyRandomValues as an entropy source.
https://bugs.webkit.org/show_bug.cgi?id=64887

Reviewed by Adam Barth.

  • src/WebKit.cpp: (WebKit::generateEntropy): (WebKit::initialize):
14:50 Changeset [91509] by lforschler@apple.com
  • 3 edits
    4 copies in branches/safari-534.51-branch

Merge r89492.

14:48 Changeset [91508] by eric@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Reenable ORWT for the --leaks bot.
Something is still wrong with the leaks summarizing
but I'm about to head out on vacation for 2 weeks,
so it's best to just revert back to ORWT until I'm back.

  • Scripts/run-webkit-tests:

(usingLeaks):
(useNewRunWebKitTests):

14:48 Changeset [91507] by lforschler@apple.com
  • 3 edits
    4 copies in branches/safari-534.51-branch

Merge r89474.

14:46 Changeset [91506] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534.51-branch

Merge r89397.

14:44 Changeset [91505] by lforschler@apple.com
  • 3 edits
    5 copies in branches/safari-534.51-branch

Merge r89313.

14:43 Changeset [91504] by kbr@google.com
  • 6 edits in trunk

Update webglcontextlost / webglcontextrestored delivery to match spec changes
https://bugs.webkit.org/show_bug.cgi?id=58621

Reviewed by James Robinson.

Source/WebCore:

Updated conditions under which webglcontextrestored event is
delivered to be spec compliant.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated layout test to test spec compliant behavior.

  • fast/canvas/webgl/context-lost-restored-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
14:42 Changeset [91503] by lforschler@apple.com
  • 4 edits
    2 copies in branches/safari-534.51-branch

Merge r89165.

14:38 Changeset [91502] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r89067.

14:37 Changeset [91501] by lforschler@apple.com
  • 3 edits
    6 copies in branches/safari-534.51-branch

Merge r88987.

14:34 Changeset [91500] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r88667.

14:33 Changeset [91499] by lforschler@apple.com
  • 6 edits
    4 copies in branches/safari-534.51-branch

Merge r88601.

14:21 Changeset [91498] by rniwa@webkit.org
  • 37 edits
    17 adds
    7 deletes in trunk/LayoutTests

Chromium rebaselines after r91493.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91497] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=64975
Elements that have columns (e.g., column-width or column-count non-auto) and elements that have
column-spans establish block formatting contexts, and therefore they should not be allowing
child margins to collapse with their own margins.

Reviewed by Beth Dakin.

Covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

13:49 Changeset [91496] by mdelaney@apple.com
  • 19 edits in trunk/Source/WebCore

Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

  • platform/graphics/ImageBuffer.h:

1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.

  • platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
  • platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

  • platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:

  • platform/graphics/qt/ImageBufferQt.cpp
  • platform/graphics/filters/FETile.cpp
  • platform/graphics/cairo/ImageBufferCairo.cpp
  • platform/graphics/skia/ImageBufferSkia.cpp
  • platform/graphics/wx/ImageBufferWx.cpp
  • platform/graphics/wince/ImageBufferWinCE.cpp
  • svg/SVGFEImageElement.cpp
  • svg/graphics/SVGImage.cpp
  • html/HTMLCanvasElement.cpp
  • html/canvas/WebGLRenderingContext.cpp
  • rendering/svg/RenderSVGResourcePattern.cpp
13:31 Changeset [91495] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update after rolling out r91285 and r91332.

  • platform/chromium/test_expectations.txt:
13:23 Changeset [91494] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output

Reviewed by Eric Seidel.

  • html/parser/create-html-entity-table:
  • Fix duplicate "EntityName" suffix on local variables (changes fooSemicolonEntityNameEntityName to fooSemicolonEntityName) for all 2138 symbols.
  • Add newlines to make source file human-readable (as originally intended).
  • Add static (const) keywords to local variables that are never referenced externally.
13:12 Changeset [91493] by rwlbuis@webkit.org
  • 43 edits in trunk/LayoutTests

2011-07-21 Rob Buis <rbuis@rim.com>

Fix SVG Font resources link in W3C SVG 1.1SE tests
https://bugs.webkit.org/show_bug.cgi?id=64953

Reviewed by Dirk schulze.

  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • svg/W3C-SVG-1.1-SE/color-prop-05-t.svg:
  • svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg:
  • svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg:
  • svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg:
  • svg/W3C-SVG-1.1-SE/painting-control-04-f.svg:
  • svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg:
  • svg/W3C-SVG-1.1-SE/struct-use-14-f.svg:
  • svg/W3C-SVG-1.1-SE/styling-css-04-f.svg:
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-02-b.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-05-t.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1-SE/text-tref-03-b.svg:
  • svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg:
13:11 Changeset [91492] by jonlee@apple.com
  • 2 edits
    5 adds in trunk/Websites/webkit.org

Create a new survey page that showcases form and interactive elements for quick reference and comparison.
<rdar://problem/9782965>

Rubber-stamped by Maciej Stachowiak.

  • projects/forms/image-usemap.png: Added.
  • projects/forms/image1.png: Added.
  • projects/forms/image10.png: Added.
  • projects/forms/image16.png: Added.
  • projects/forms/index.html: Update links
  • projects/forms/survey.html: Added.
12:45 Changeset [91491] by ojan@chromium.org
  • 3 edits in trunk/Tools

cleanup jsonresults.py style in preparation for making some changes
https://bugs.webkit.org/show_bug.cgi?id=64968

Reviewed by Adam Barth.

No code changes. Unittest still passes. Mostly just removing
useless comments and 80 character wrapping.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
12:30 Changeset [91490] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

More Chromium rebaselines for r91474.

  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-win-xp/fast/events: Added.
  • platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Added.
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
12:22 Changeset [91489] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add missing column header.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
12:15 Changeset [91488] by eric@webkit.org
  • 3 edits in trunk/Tools

Unreviewed. Just fixing (and unittesting) a previous typo.

Fix typo in print_leaks_summary regexp which was causing
leaks summarizing to fail on the --leaks bot.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
12:14 Changeset [91487] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic should be able to rebaseline many tests at once
https://bugs.webkit.org/show_bug.cgi?id=64963

Reviewed by Dimitri Glazkov.

This patch contains some UI for rebaselining tests in bulk. I don't
expect this UI to be the final UI, but the underlying infrastructure
will be useful.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
12:13 Changeset [91486] by commit-queue@webkit.org
  • 23 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from FileAPI
https://bugs.webkit.org/show_bug.cgi?id=64539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-21
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/EntriesCallback.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/EntryCallback.idl:
  • fileapi/EntrySync.idl:
  • fileapi/ErrorCallback.idl:
  • fileapi/FileCallback.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • fileapi/FileSystemCallback.idl:
  • fileapi/FileWriter.idl:
  • fileapi/FileWriterCallback.idl:
  • fileapi/FileWriterSync.idl:
  • fileapi/MetadataCallback.idl:
  • fileapi/WebKitBlobBuilder.idl:
12:12 Changeset [91485] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

sort WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=64901

Unreviewed, just using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
12:04 Changeset [91484] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Disable failing new test on mac/win ports
https://bugs.webkit.org/show_bug.cgi?id=64882

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-21
Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
11:59 Changeset [91483] by barraclough@apple.com
  • 9 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64900
Function.prototype.apply should accept an array-like object as its second argument

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply):

  • Remove the type error if object is not an array.

LayoutTests:

  • fast/js/function-apply-expected.txt:
  • fast/js/script-tests/function-apply.js:
    • Add a test for array-like objects.
  • sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T4-expected.txt:
    • These tests are incorrect & assert ES3 behaviour.
11:57 Changeset [91482] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=64964
DFG JIT - Enable support for eval code

Reviewed by Sam Weinig.

This is basically the same as program code, to the JIT!

  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
    • Enable opcodeNames in !NDEBUG builds.
  • dfg/DFGOperations.cpp:
    • Fix a bug exposed by eval support, throw correct type error for new.
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):

  • Enable DFG JIT for eval code.
11:45 Changeset [91481] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Cannot click to position the caret to the right of an image with display:block style.
https://bugs.webkit.org/show_bug.cgi?id=64962
<rdar://problem/9446343>

Reviewed by David Hyatt.

Source/WebCore:

Test: editing/selection/click-on-block-image.html

The current implementation of positionForPoint always returns the visible
position to the left of the image, if the image has a block style.
This patch changes the behavior for block styled images to match the behavior
for inline images.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint): Modified to avoid relying entirely
on InlineBox to calculate the position.

LayoutTests:

  • editing/selection/click-on-block-image-expected.txt: Added.
  • editing/selection/click-on-block-image.html: Added.
11:37 Changeset [91480] by rniwa@webkit.org
  • 39 edits
    13 adds
    6 deletes in trunk/LayoutTests

Chromium rebaseline for r91474.

  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
11:34 Changeset [91479] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

fast/events/offsetX-offsetY.html is failing on the bots.

  • fast/events/offsetX-offsetY-expected.txt:
  • fast/events/offsetX-offsetY.html:

Update test and result in response to changes to margins in columns.

10:25 Changeset [91478] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic has trouble when the same test fails in different ways on diffrent bots
https://bugs.webkit.org/show_bug.cgi?id=64830

Unreviewed. (Missing the patch is blocking me from fixing the tree.)

This patch is just some minor bug fixes. One of the bugs results from
the sadness of having two representations (a list and a space-separated
string) for the set of failure types.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
09:48 Changeset [91477] by sjl@chromium.org
  • 3 edits in branches/chromium/782/Source/WebCore

Merge 91337 - [chromium] Media player controls do not fade out.
https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):

  • html/shadow/MediaControlRootElementChromium.h:

TBR=sjl@chromium.org
Review URL: http://codereview.chromium.org/7472040

09:31 Changeset [91476] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark http/tests/inspector/console-websocket-error.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64957

This test times out on Linux Debug.

Unreviewed.

  • platform/chromium/test_expectations.txt:
09:28 Changeset [91475] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: one liner typo fix in Inspector.json.

  • inspector/Inspector.json:
09:14 Changeset [91474] by weinig@apple.com
  • 20 edits in trunk

Source/WebCore: CSS top margin collapses when paginating
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
Update to only go down paginated path when we actually have a page height (so
not in the case that we are just gathering breaks) and to call the version of
of nextPageLogicalTop that actually returns the next page, even if we are at
the boundary point.

(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
Split into two functions which differ in how they deal with the boundary condition.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
Switch to call nextPageLogicalTopIncludingBoundaryPoint.

  • rendering/RenderBlock.h:

Add new functions declarations and comment them.

LayoutTests: CSS top margin collapses when paginating
<rdar://problem/9434990>
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

  • fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:

Update results now that we take margins into account.

09:08 Changeset [91473] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fast/js/function-apply-many-args.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64955

The test is timing out on Mac Debug.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:49 Changeset [91472] by pfeldman@chromium.org
  • 13 edits
    3 adds in trunk

Web Inspector: RuntimeAgent.evaluateOn should not require "return X;" syntax.
https://bugs.webkit.org/show_bug.cgi?id=64691

Reviewed by Yury Semikhatsky.

Source/WebCore:

I'm introducing callFunctionOn that receives function declaration in order
to make call site syntax clear.

Test: inspector/runtime/runtime-callFunctionOn.html

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode.dimensions):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved.protoList):
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.callFunction):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/runtime/runtime-callFunctionOn-expected.txt: Added.
  • inspector/runtime/runtime-callFunctionOn.html: Added.
08:39 Changeset [91471] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fast/frames/meta-refresh-user-gesture.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64952

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:27 Changeset [91470] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix test expectations, mark fast/forms/input-file-label.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64949

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:12 Changeset [91469] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Adopt existing GraphicsContext3D members (part 1)
https://bugs.webkit.org/show_bug.cgi?id=64877

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-21
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Remove GraphicsContext3DInternal members and use the existing
corresponding members from GraphicsContext3D instead.
Move most of the GraphicsContext3DInternal constructor, destructor
and the reshape() method into GraphicsContext3D.
The GraphicsContext3D members will be needed when we adopt
GraphicsContext3DOpenGL.cpp.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::boundingRect):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::getExtensions):

08:06 Changeset [91468] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fast/dom/DeviceOrientation/no-synchronous-events.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64947

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:48 Changeset [91467] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove test expectation for fast/speech/input-text-speechbutton.html.
https://bugs.webkit.org/show_bug.cgi?id=64945

The test was fixed in https://bugs.webkit.org/show_bug.cgi?id=64857.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:37 Changeset [91466] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark test fast/flexbox/010.html as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64944

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:18 Changeset [91465] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark svg/W3C-SVG-1.1/animate-elem-78-t.svg as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64941

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:48 Changeset [91464] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark http/tests/websocket/tests/hybi/reserved-opcodes.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=64938

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:39 Changeset [91463] by yael.aharon@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Code cleanup for drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=64916

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startDrag):
Allow receiving a NULL bitmap from the web process.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
Fix typo introduced in http://trac.webkit.org/changeset/90458.
All DnD related events should be GraphicsScene events.

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQPixmapToShareableBitmap):
Remove hack that creates a 1x1 bitmap.
It is no longer needed after http://trac.webkit.org/changeset/91016.

(WebKit::WebDragClient::startDrag):
Allow sending a NULL bitmap to the UI process.

06:28 Changeset [91462] by jknotten@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Remove windows baseline for fast/speech/input-text-speechbutton.
https://bugs.webkit.org/show_bug.cgi?id=64936

Unreviewed.

  • platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Removed.
05:19 Changeset [91461] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: [protocol] extend setBreakpointByUrl request to accept incomplete URL (predicates)
https://bugs.webkit.org/show_bug.cgi?id=60762

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-set-breakpoint-regex.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::buildObjectForBreakpointCookie):
(WebCore::matches):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt: Added.
  • inspector/debugger/debugger-set-breakpoint-regex.html: Added.
04:21 Changeset [91460] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION(r88757): input[type=range] renders incorrectly in RTL context.
https://bugs.webkit.org/show_bug.cgi?id=64904

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/forms/input-appearance-range-rtl.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::layout):
The thumb should be positioned based on 'right' CSS property instead of 'left.'
(WebCore::SliderThumbElement::setPositionFromPoint):
The fraction should be flipped in RTL.

LayoutTests:

  • fast/forms/input-appearance-range-rtl-expected.html: Added.
  • fast/forms/input-appearance-range-rtl.html: Added.
  • platform/chromium/test_expectatinos.txt:
03:22 Changeset [91459] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt.
Revert http://trac.webkit.org/changeset/91451 and skip the tests
via the Skipped list because the test_expectations way don't work.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
03:18 Changeset [91458] by jeremy@chromium.org
  • 3 edits in trunk/LayoutTests

Fix fast/speech/input-text-speechbutton.html after r91249 .
https://bugs.webkit.org/show_bug.cgi?id=64857

Reviewed by Kent Tamura.

  • fast/speech/input-text-speechbutton.html: Correct mouse coordinates now that the microphone icon can be on the left in RTL..
  • platform/chromium/test_expectations.txt: Test no longer times out.
03:12 Changeset [91457] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Remove networkDataRemoved field from resource.
https://bugs.webkit.org/show_bug.cgi?id=64749

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

03:06 Changeset [91456] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium DevTools] Remove unused method setAgentIdentifierPrefix from WebDevToolAgent.
https://bugs.webkit.org/show_bug.cgi?id=64793

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
03:05 Changeset [91455] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

MediaStream API: Merging MediaStreamContainer and MediaStreamList
https://bugs.webkit.org/show_bug.cgi?id=64794

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-07-21
Reviewed by Tony Gentilcore.

  • GNUmakefile.list.am:
  • dom/MediaStreamContainer.h: Removed.
  • dom/MediaStreamList.cpp:

(WebCore::MediaStreamList::create):
(WebCore::MediaStreamList::MediaStreamList):
(WebCore::MediaStreamList::length):
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::add):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):
(WebCore::MediaStreamList::get):

  • dom/MediaStreamList.h:
02:51 Changeset [91454] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: always open dedicated worker inspector in a new window not a new tab
https://bugs.webkit.org/show_bug.cgi?id=64872

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype.openWorkerInspector):

02:39 Changeset [91453] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

[Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
https://bugs.webkit.org/show_bug.cgi?id=64849

Reviewed by Dimitri Glazkov.

This change is a reorg around Shadow inclusion mechanism.

  • Moved definition of ShadowInclusion, ShadowInclusionSet and ShadowInclusionList from ShadowContentElement.h to ShadowContentSelector.h, which is included from smaller number of places.
  • Moved ShadowInclusionSet from ShadowRoot to ShadowContentSelector
  • Made ShadowContentSelector's lifetime managed by ShadowRoot because ShadowInclusionSet is held by the selector.
  • Thus, there is no longer "active" selector (ShadowContentSelector::s_currentInstance) Because the selector is associated for each ShadowRoot object.

No new tests. No behavior change.

  • dom/NodeRenderingContext.cpp:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowContentElement::inclusions):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::~ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):
(WebCore::ShadowContentSelector::unselectInclusion):
(WebCore::ShadowContentSelector::findInclusionFor):
(WebCore::ShadowContentSelector::didSelectInclusion):
(WebCore::ShadowContentSelector::willSelectInclusionOver):

  • dom/ShadowContentSelector.h:

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowContentSelector::hasChildren):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:
02:29 Changeset [91452] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Patch by Rohan McGovern <rohan@mcgovern.id.au> on 2011-07-21
Reviewed by Noam Rosenthal.

[Qt] Qt5 Build Fix: remove useless use of qRound(int)
https://bugs.webkit.org/show_bug.cgi?id=64907

Rounding an integer doesn't make sense.
Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
permitted to compile.

No new tests needed.

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepthPerComponent): Ditto.

02:27 Changeset [91451] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening for Qt.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=64927 and https://bugs.webkit.org/show_bug.cgi?id=64928

  • platform/qt/test_expectations.txt:

Mark inspector/styles/css-live-edit.html as TIMEOUT.
Mark inspector/syles/get-set-stylesheet-text.html as PASS or TIMEOUT.

01:15 Changeset [91450] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] [WebKit API] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

Remove failing test expectations from fast/html/details-*.html
since localization strings have been updated in Chromium side.

  • platform/chromium/test_expectations.txt:
00:26 Changeset [91449] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:

07/20/11:

23:53 Changeset [91448] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Adam Barth.

The bug was caused by multiple expressions matching on the single output.
Fixed it by exiting the loop as soon as one expression matches.

Because the regular expression for 'failures' is most general,
moved it to the end of the list to avoid it catching other cases.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
23:22 Changeset [91447] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a Valgrind failure caused by r91435.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):

22:56 Changeset [91446] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Unreviewed, rolling out r91332.
http://trac.webkit.org/changeset/91332
https://bugs.webkit.org/show_bug.cgi?id=64925

Crashes css3/images/optimize-contrast-canvas.html on safari-
mac,chromium-mac (Requested by mikelawther on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-20

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::makePresentationCopy):
(WebCore::HTMLCanvasElement::copiedImage):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::videoFrameToImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::cgImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::imageWithColorSpace):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::apply):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

22:49 Changeset [91445] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Websites/webkit.org

SVG feature status is not up-to-date
https://bugs.webkit.org/show_bug.cgi?id=64856

Patch by Leo Yang <leo.yang@torchmobile.com.cn> on 2011-07-20
Reviewed by Dirk Schulze.

Update SVG feature status after r91331.

  • projects/svg/status.xml:
22:04 Changeset [91444] by rniwa@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r91380.
http://trac.webkit.org/changeset/91380
https://bugs.webkit.org/show_bug.cgi?id=64924

Caused assertion failures in Chromium's IndexedDB tests
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-20

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

20:15 Changeset [91443] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add crash expectation to fast/canvas/webgl/renderbuffer-initialization.html on Chromium Windows,
tracked by the bug 64920.

  • platform/chromium/test_expectations.txt:
20:04 Changeset [91442] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium build fix after r91440.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

19:46 Changeset [91441] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Set the parent context to that of the associated view when calling GraphicsContext3DChromium::copyTextureToParentCHROMIUM.
This fixes a race condition whereby the view window does not exist when the offscreen context is created. It allows
accelerated 2D canvases to be added to newly created window.
https://bugs.webkit.org/show_bug.cgi?id=64905

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-20
Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::copyTextureToParentTextureCHROMIUM):

19:29 Changeset [91440] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Shadow-related tests need rebaselining after r85299
https://bugs.webkit.org/show_bug.cgi?id=59782

Remove failing Chromium test expectations since these tests are passing since r91393.

  • platform/chromium/test_expectations.txt:
19:12 Changeset [91439] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT does not use() the aliased GetByVal,
resulting in bloated use counts.
https://bugs.webkit.org/show_bug.cgi?id=64911

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-20
Reviewed by Gavin Barraclough.

Inserted a call to use() for the aliased GetByVal.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

19:08 Changeset [91438] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r91435.

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollbarOverlayStyle):

19:05 Changeset [91437] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebCore

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-20
Reviewed by Darin Adler.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
<rdar://problem/9727074>

Add SVGLength::construct, which can be used to construct an SVGLength
as normal, but returns an SVGParsingError via a reference argument.
The function also takes another argument, which is whether or not
the SVGLength value is allowed to be negative. If not, an error is
thrown. It defaults to allowing negatives if not specified.

  • GNUmakefile.list.am:
  • svg/SVGLength.cpp:

(WebCore::SVGLength::construct):
(WebCore::SVGLength::rawValue):

  • svg/SVGLength.h:
  • svg/SVGElement.h:
  • svg/SVGParsingError.h: Added.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
18:42 Changeset [91436] by leviw@chromium.org
  • 7 edits in trunk/Source/WebCore

Switch getTransformFromContainer and its uses to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64908

Reviewed by Simon Fraser.

Switching getTransformFromContainer and its uses to use the new Layout
Types from strictly integer ones.

No new tests, no new functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createLocalTransformState):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTransformFromContainer):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):

18:32 Changeset [91435] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Scrollbar color heuristic needs to be hooked up in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=64220
<rdar://problem/9589140>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-20
Reviewed by Darin Adler.

Store the scroller style on ScrollableArea, and recompute it whenever
the document or body element background color changes or the base background
color of the scrollview changes. Also, make sure to repaint the scrollbars
whenever the style changes.

Source/WebCore:

No new tests, since this code is only enabled on future versions of Mac OS X.

  • WebCore.exp.in:
  • page/Frame.cpp:

(WebCore::Frame::getDocumentBackgroundColor):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle):
(WebCore::FrameView::setBaseBackgroundColor):
(WebCore::FrameView::documentBackgroundColor): Renamed.

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollbarOverlayStyle):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollbarOverlayStyle):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarOverlayStyle):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):

  • platform/mac/ScrollViewMac.mm:

(WebCore::toNSScrollerKnobStyle):
(WebCore::ScrollView::platformSetScrollbarOverlayStyle):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::paint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::getDocumentBackgroundColor):

18:24 Changeset [91434] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2011-07-20 Chang Shu <cshu@webkit.org>

Adding myself to the reviewers list; No review needed.

  • Scripts/webkitpy/common/config/committers.py:
18:07 Changeset [91433] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyWebkitTransformOriginZ and Origin in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64785
Note that this changes a cast from

computed length double -> 28 bit int -> float

to

computed length double -> float

I couldn't see any reason in the code that this was strictly necessary,
however it may have been so that X,Y,Z all have the same behavior, even though Z itself is not stored in a Length.

Reviewed by Simon Fraser.

No new tests / refactoring.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

17:50 Changeset [91432] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests --leaks does not restart DumpRenderTree often enough
https://bugs.webkit.org/show_bug.cgi?id=64912

Reviewed by Adam Barth.

The bug was that set_default_option only works if the option's value
is "None". So I fixed --batch-size to default to None instead of 0
(which kinda makes sense).

  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:47 Changeset [91431] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

17:45 Changeset [91430] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.1

New tag.

17:42 Changeset [91429] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64909
DFG JIT - Missing ToInt32 conversions for double constants.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):

  • We cannot trivially omit ToInt32 conversions on double constants.

LayoutTests:

  • fast/js/bitops-type-tag-expected.txt:
  • fast/js/script-tests/bitops-type-tag.js:
    • Test case for DFG JIT.
17:24 Changeset [91428] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG speculative JIT sometimes claims to use compare operands twice, leading to
use count corruption.
https://bugs.webkit.org/show_bug.cgi?id=64903

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-20
Reviewed by Gavin Barraclough.

Move the calls to use() in SpeculativeJIT::compare() so that they only happen
if the JITCodeGenerator's helper method (which also calls use()) is not called.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):

17:22 Changeset [91427] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.51-branch

Merge r88549.

17:13 Changeset [91426] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.51-branch

Merge r88456.

16:59 Changeset [91425] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r88277.

16:41 Changeset [91424] by lforschler@apple.com
  • 3 edits
    2 deletes in branches/safari-534.51-branch

Merge r88137.

16:34 Changeset [91423] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.51-branch

Merge r88071.

16:33 Changeset [91422] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r87827.

16:28 Changeset [91421] by eric@webkit.org
  • 2 edits in trunk/Tools

Make kill-old-processes kill httpd on mac
https://bugs.webkit.org/show_bug.cgi?id=64898

Reviewed by Adam Barth.

  • BuildSlaveSupport/kill-old-processes:
    • The line endings seem to have flipped again, Thus making this diff gigantic. The only line changed is the "httpd" line. I suspect we'll need to set the line ending style from an svn checkout.
16:25 Changeset [91420] by lforschler@apple.com
  • 8 edits
    4 copies in branches/safari-534.51-branch

Merge r87743.

16:22 Changeset [91419] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Remove some more passing tests from chromium GPU expectations
(just required a clobber).

Unreviewed.

  • platform/chromium/test_expectations.txt:
16:21 Changeset [91418] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove stray reference to StyleFlexibleBoxData.h that was accidentally
added in r91402.

  • WebCore.xcodeproj/project.pbxproj:
16:18 Changeset [91417] by leviw@chromium.org
  • 20 edits in trunk/Source/WebCore

Bring Int/Float graphics classes closer to parity
https://bugs.webkit.org/show_bug.cgi?id=64833

Reviewed by James Robinson.

In preparation of switching to Floating point data structures, bringing the
functionality and method names of the Int/Float graphics classes close together.

Also fixing some compiler errors when using Floats for layout units along the way.

No new tests, no functionality change.

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::convertChildToSelf):
(WebCore::ScrollView::convertSelfToChild):

  • platform/graphics/FloatPoint.h:

(WebCore::operator-): Adding a single-parameter version.

  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isZero): Adding isZero that uses epsilon for floats.

  • platform/graphics/FloatSize.h:
  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::moveBy): Renaming IntPoint version to moveBy to mirror FloatPoint.

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::expand): Switching to specific templatized max.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData):

  • rendering/RenderBlock.cpp: Moving outstanding Int* functions to Layout units.

(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::logicalRectToPhysicalRect):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionForPoint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::subtractCaptionRect):

  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::RenderTableCell::setOverrideSizeFromRowHeight):
(WebCore::RenderTableCell::paintCollapsedBorder):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTableCell.h:
  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):

  • rendering/RootInlineBox.h:
16:15 Changeset [91416] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: mouseover reporting incorrect mouse button, when the button isn't
down. https://bugs.webkit.org/show_bug.cgi?id=64882

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-20
Reviewed by Eric Seidel.

Don't increment the button returned in 'which' unless the button is
actually down.

Test: fast/events/mouseover-button.html

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::which):

LayoutTests: mouseover event reporting incorrect button in 'which'.
https://bugs.webkit.org/show_bug.cgi?id=64882

New test, move in/out of iframe with none/left/middle buttons down.

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-20
Reviewed by Eric Seidel.

  • fast/events/mouseover-button-expected.txt: Added.
  • fast/events/mouseover-button.html: Added.
  • fast/events/resources/mouseover-button-iframe.html: Added.
16:15 Changeset [91415] by ojan@chromium.org
  • 2 edits in trunk/Tools

show a list of average test times in the treemap
https://bugs.webkit.org/show_bug.cgi?id=64899

Reviewed by Adam Roben.

For now, you click a link and it replaces the treemap
with a reverse sorted list of directories based on
average test runtime within that directory.

To cut some of the noise, we don't show directories
that only have one test in them or where the average
runtime is less than 100ms.

  • TestResultServer/static-dashboards/treemap.html:
16:13 Changeset [91414] by kbr@google.com
  • 9 edits in trunk

Add restoreContext() to WEBKIT_lose_context
https://bugs.webkit.org/show_bug.cgi?id=58626

Reviewed by James Robinson.

Source/WebCore:

Added the restoreContext() entry point to the WEBKIT_lose_context
extension. Refactored and simplified the logic associated with context
loss and restoration.

A subsequent patch will make the delivery of the webglcontextrestored
event spec compliant.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
(WebCore::WebGLRenderingContextLostCallback::onContextLost):
(WebCore::WebGLRenderingContext::isContextLost):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::forceRestoreContext):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):

  • html/canvas/WebKitLoseContext.cpp:

(WebCore::WebKitLoseContext::loseContext):
(WebCore::WebKitLoseContext::restoreContext):

  • html/canvas/WebKitLoseContext.h:
  • html/canvas/WebKitLoseContext.idl:

LayoutTests:

Used the new WEBKIT_lose_context restoreContext() entry point in
the associated layout test.

  • fast/canvas/webgl/context-lost-restored-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
16:03 Changeset [91413] by eric@webkit.org
  • 3 edits in trunk/Tools

Teach build.webkit.org how to identify leaks in NRWT output
https://bugs.webkit.org/show_bug.cgi?id=64891

Reviewed by Adam Barth.

This was the last remaining piece blocking turning on
NRWT for the leaks bot, so I did that in this change too.
If for some reason we see trouble on the bots, I'll
revert that part of this change.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-webkit-tests:
15:16 Changeset [91412] by ojan@chromium.org
  • 2 edits in trunk/Tools

make the treemap display more human friendly
https://bugs.webkit.org/show_bug.cgi?id=64896

Reviewed by Tony Chang.

  • TestResultServer/static-dashboards/treemap.html:
15:06 Changeset [91411] by eric@webkit.org
  • 4 edits in trunk/Tools

Move HttpLock to using a FileSystem object
https://bugs.webkit.org/show_bug.cgi?id=64885

Reviewed by Adam Barth.

I made a typo in my previous change, taking the value
of read_text_file(pid_file) and setting it to lock_pid_file
instead of current_pid. Fixed now. :)

In order to test my new change I had to overhaul the unittests
for this class to create a separate set of tests which work off
of Mock objects instead of the real filesystem.

Since Executive doesn't yet wrap os.getpid() I added a FIXME
in several places where we're currently calling os.getpid(). I
felt adding Executive.getpid was outside of the scope of this change
but once it exists some of this code will be much simpler to mock.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
15:00 Changeset [91410] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Pass -webkit-flex() values on to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=64038

Reviewed by Eric Seidel.

No new tests, this just copies data to RenderStyle, which we can
then access when doing layout. Tests will come with the layout
changes.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

14:56 Changeset [91409] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-20 Daniel Bates <dbates@rim.com>

Attempt to fix the GTK build after changeset 91396 <http://trac.webkit.org/changeset/91396>
(https://bugs.webkit.org/show_bug.cgi?id=64764).

  • xml/parser/MarkupTokenBase.h: #include <stdio.h> in debug build for printf(3), which is used in MarkupTokenBase::printString() and MarkupTokenBase::printAttrs().
14:52 Changeset [91408] by vsevik@chromium.org
  • 22 edits
    4 adds in trunk

Web Inspector: Add support for disabling cache in web inspector.
https://bugs.webkit.org/show_bug.cgi?id=64097

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/network/network-disable-cache-memory.html

http/tests/inspector/network/network-disable-cache-xhrs.html

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::setCacheDisabled):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.inflightResourceForURL):
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::setCacheDisabled):

  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::setCacheDisabled):

  • src/WebDevToolsAgentImpl.h:
  • src/js/DevTools.js:

():

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):

  • http/tests/inspector/network/network-disable-cache-memory-expected.txt: Added.
  • http/tests/inspector/network/network-disable-cache-memory.html: Added.
  • http/tests/inspector/network/network-disable-cache-xhrs-expected.txt: Added.
  • http/tests/inspector/network/network-disable-cache-xhrs.html: Added.
  • http/tests/inspector/network/resources/resource.php:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:27 Changeset [91407] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix typo in TestFailures's Bugzilla constants

This was preventing the "Version" field from being pre-filled when filing new bugs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
14:27 Changeset [91406] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch

Merge r86976.

14:17 Changeset [91405] by lforschler@apple.com
  • 12 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r86919.

14:12 Changeset [91404] by commit-queue@webkit.org
  • 72 edits in trunk/Source

Remove "const" from obviously-non-const accessors
https://bugs.webkit.org/show_bug.cgi?id=62302

Patch by Peter Kasting <pkasting@google.com> on 2011-07-20
Reviewed by Darin Adler.

Source/WebCore:

No functional change, so no new tests.

  • WebCore.exp.in: Adjust function names to reflect non-constness.
  • dom/Element.cpp:

(WebCore::Element::cloneElementWithoutAttributesAndChildren): Not const, calls non-const function Document::createElement().
(WebCore::Element::scrollLeft): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::scrollTop): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::scrollWidth): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::scrollHeight): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::boundsInWindowSpace): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::getClientRects): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::getBoundingClientRect): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::innerText): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Element::outerText): Not const, calls newly non-const function Element::innerText().

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::Node::isContentEditable): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::Node::shouldUseInputMethod): Not const, calls newly non-const function Node::isContentEditable().

  • dom/Node.h:
  • dom/OptionElement.h: Virtual function OptionElement::selected() not const because HTMLOptionElement implementation is non-const.
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::text): Not const, calls newly non-const function Element::innerText().

  • html/HTMLAnchorElement.h:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings): Not const, calls non-const function RenderApplet::createWidgetIfNecessary().

  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement): Not const, calls newly non-const function HTMLMapElement::imageElement().

  • html/HTMLAreaElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::scrollLeft): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::HTMLBodyElement::scrollTop): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::HTMLBodyElement::scrollHeight): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::HTMLBodyElement::scrollWidth): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().

  • html/HTMLBodyElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Not const, calls non-const function Document::createElement().

  • html/HTMLEmbedElement.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::width): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::HTMLFrameElementBase::height): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().

  • html/HTMLFrameElementBase.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::width): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::HTMLImageElement::height): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldUseInputMethod): Virtual function not const because Node implementation is non-const.

  • html/HTMLInputElement.h:
  • html/HTMLKeygenElement.cpp:

(WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement): Not const, calls non-const function Document::images().

  • html/HTMLMapElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().

  • html/HTMLObjectElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::selected): Not const, calls non-const function HTMLSelectElement::recalcListItemsIfNeeded().

  • html/HTMLOptionElement.h:
  • html/HTMLPlugInElement.cpp: Virtual function HTMLPlugInElement::renderWidgetForJSBindings() not const because various subclass implementations are non-const.

(WebCore::HTMLPlugInElement::getInstance): Not const, calls newly non-const function HTMLPlugInElement::pluginWidget().
(WebCore::HTMLPlugInElement::pluginWidget): Not const, calls newly non-const function HTMLPlugInElement::renderWidgetForJSBindings().

  • html/HTMLPlugInElement.h:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.

  • html/HTMLScriptElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::shouldUseInputMethod): Virtual function not const because Node implementation is non-const.

  • html/HTMLTextAreaElement.h:
  • html/shadow/SliderThumbElement.h:

(WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.

  • rendering/svg/SVGShadowTreeElements.cpp:

(WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.

  • rendering/svg/SVGShadowTreeElements.h:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType): Not const, calls newly non-const function SVGSMILElement::targetElement().

  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType): Not const, calls newly non-const function SVGSMILElement::targetElement().

  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::hasValidAttributeType): Not const, calls newly non-const function SVGSMILElement::targetElement().

  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation): Not const, calls newly non-const function SVGSMILElement::targetElement().

  • svg/SVGAnimationElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::accessDocumentSVGExtensions): Not const, calls non-const function Document::accessSVGExtensions().
(WebCore::SVGElement::boundingBox): Not const, calls newly non-const function SVGStyledLocatableElement::getBBox().

  • svg/SVGElement.h:
  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getBBox): Argument not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets() on argument.
(WebCore::SVGLocatable::computeCTM): Argument not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets() on argument.
(WebCore::SVGLocatable::getTransformToElement): Not const, calls newly non-const function SVGLocatable::getCTM().

  • svg/SVGLocatable.h: Virtual functions SVGLocatable::getBBox(), SVGLocatable::getCTM(), and SVGLocatable::getScreenCTM() not const because various subclass implementations are non-const.
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.

  • svg/SVGScriptElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded): Not const, calls non-const function Document::accessSVGExtensions().

  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp:

(WebCore::SVGStyledLocatableElement::getBBox): Not const, calls newly non-const static function SVGLocatable::getBBox().
(WebCore::SVGStyledLocatableElement::getCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().
(WebCore::SVGStyledLocatableElement::getScreenCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().

  • svg/SVGStyledLocatableElement.h:
  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::getCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().
(WebCore::SVGStyledTransformableElement::getScreenCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().
(WebCore::SVGStyledTransformableElement::getBBox): Not const, calls newly non-const static function SVGLocatable::getBBox().
(WebCore::SVGStyledTransformableElement::toClipPath): Virtual function not const because SVGUseElement implementation is non-const.

  • svg/SVGStyledTransformableElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::getNumberOfChars): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getComputedTextLength): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getSubStringLength): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getStartPositionOfChar): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getEndPositionOfChar): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getExtentOfChar): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getRotationOfChar): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::getCharNumAtPosition): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::SVGTextContentElement::selectSubString): Not const, calls newly non-const static function SVGTextContentElement::getNumberOfChars().

  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::getBBox): Not const, calls newly non-const static function SVGLocatable::getBBox().
(WebCore::SVGTextElement::getCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().
(WebCore::SVGTextElement::getScreenCTM): Not const, calls newly non-const static function SVGLocatable::computeCTM().

  • svg/SVGTextElement.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::instanceRoot): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
(WebCore::isDirectReference):
(WebCore::SVGUseElement::toClipPath): Not const, calls non-const function Document::accessSVGExtensions().

  • svg/SVGUseElement.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::eventBaseFor): Not const, calls newly non-const function SVGSMILElement::targetElement().
(WebCore::SVGSMILElement::targetElement): Not const, calls non-const function Document::accessSVGExtensions().

  • svg/animation/SVGSMILElement.h: Virtual function SVGSMILElement::hasValidAttributeType() not const because various subclass implementations are non-const.

Source/WebKit/chromium:

  • public/WebElement.h:
  • src/WebElement.cpp:

(WebKit::WebElement::innerText): Not const due to call to newly-non-const Element::innerText().

  • src/WebSearchableFormData.cpp: Use non-const Node*s for code that calls newly non-const accessors.

(HTMLNames::IsSelectInDefaultState):
(HTMLNames::IsInDefaultState):

  • src/WebViewImpl.cpp: Use non-const Node*s for code that calls newly non-const accessors.

(WebKit::WebViewImpl::setComposition):
(WebKit::WebViewImpl::confirmComposition):
(WebKit::WebViewImpl::textInputType):

14:09 Changeset [91403] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r90232.

14:09 Changeset [91402] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build after r91392.

  • WebCore.xcodeproj/project.pbxproj: StyleFlexibleBoxData.h should be a

private forwarding header of WebCore.

14:07 Changeset [91401] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't throw away code when JSGarbageCollect API is called
https://bugs.webkit.org/show_bug.cgi?id=64894

Reviewed by Sam Weinig.

Just call collectAllGarbage. That will clean up all unneeded
code without causing any pathological recompilation problems.

  • API/JSBase.cpp:

(JSGarbageCollect):

14:04 Changeset [91400] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations update for tests now passing on WIN7.

Unreviewed.

  • platform/chromium/test_expectations.txt:
13:50 Changeset [91399] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Mark some tests as passing on the GPU after
http://src.chromium.org/viewvc/chrome?view=rev&revision=93233.

  • platform/chromium/test_expectations.txt:
13:45 Changeset [91398] by eric@webkit.org
  • 4 edits in trunk/Tools

Move HttpLock to using a FileSystem object
https://bugs.webkit.org/show_bug.cgi?id=64885

Reviewed by Adam Barth.

There is no functional change here. Just moving off
of direct os.foo calls to their filesystem equivalent.

This makes it possible to now unittest HttpLock using a
MockFileSystem instead of needing to talk to the filesystem directly.

This also will have changed any port test cases which were using a
mock file system to now have an HttpLock based on a mock filesystem
instead. I saw no change in the unittests so it's possible
we're not testing that configuration (or more likely that it "just works").

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
13:42 Changeset [91397] by jamesr@google.com
  • 2 edits in branches/chromium/782/Source/WebCore

2011-07-20 James Robinson <jamesr@chromium.org>

Speculative null pointer check to fix crashes seen in the field.
BUG=89193, cros bug 17121

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::transferRootLayer):
13:34 Changeset [91396] by jpfau@apple.com
  • 17 edits
    2 adds in trunk/Source/WebCore

New Token class for XML
https://bugs.webkit.org/show_bug.cgi?id=64764

Reviewed by Adam Barth.

Refactor HTMLToken into MarkupTokenBase and add new XMLToken

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSource):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::sourceForToken):

  • html/parser/HTMLToken.h:

(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::forceQuirks):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::forceQuirks):
(WebCore::AtomicHTMLToken::usesName):
(WebCore::AtomicHTMLToken::usesAttributes):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenInitial):
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):

  • xml/parser/MarkupTokenBase.h: Added.

(WebCore::DoctypeDataBase::DoctypeDataBase):
(WebCore::MarkupTokenBase::MarkupTokenBase):
(WebCore::MarkupTokenBase::~MarkupTokenBase):
(WebCore::MarkupTokenBase::clear):
(WebCore::MarkupTokenBase::isUninitialized):
(WebCore::MarkupTokenBase::startIndex):
(WebCore::MarkupTokenBase::endIndex):
(WebCore::MarkupTokenBase::setBaseOffset):
(WebCore::MarkupTokenBase::end):
(WebCore::MarkupTokenBase::makeEndOfFile):
(WebCore::MarkupTokenBase::beginStartTag):
(WebCore::MarkupTokenBase::beginEndTag):
(WebCore::MarkupTokenBase::ensureIsCharacterToken):
(WebCore::MarkupTokenBase::beginComment):
(WebCore::MarkupTokenBase::beginDOCTYPE):
(WebCore::MarkupTokenBase::appendToCharacter):
(WebCore::MarkupTokenBase::appendToComment):
(WebCore::MarkupTokenBase::addNewAttribute):
(WebCore::MarkupTokenBase::beginAttributeName):
(WebCore::MarkupTokenBase::endAttributeName):
(WebCore::MarkupTokenBase::beginAttributeValue):
(WebCore::MarkupTokenBase::endAttributeValue):
(WebCore::MarkupTokenBase::appendToAttributeName):
(WebCore::MarkupTokenBase::appendToAttributeValue):
(WebCore::MarkupTokenBase::type):
(WebCore::MarkupTokenBase::selfClosing):
(WebCore::MarkupTokenBase::setSelfClosing):
(WebCore::MarkupTokenBase::attributes):
(WebCore::MarkupTokenBase::eraseCharacters):
(WebCore::MarkupTokenBase::eraseValueOfAttribute):
(WebCore::MarkupTokenBase::characters):
(WebCore::MarkupTokenBase::comment):
(WebCore::MarkupTokenBase::publicIdentifier):
(WebCore::MarkupTokenBase::systemIdentifier):
(WebCore::MarkupTokenBase::setPublicIdentifierToEmptyString):
(WebCore::MarkupTokenBase::setSystemIdentifierToEmptyString):
(WebCore::MarkupTokenBase::appendToPublicIdentifier):
(WebCore::MarkupTokenBase::appendToSystemIdentifier):
(WebCore::MarkupTokenBase::printString):
(WebCore::MarkupTokenBase::printAttrs):
(WebCore::MarkupTokenBase::appendToName):
(WebCore::MarkupTokenBase::name):

  • xml/parser/XMLToken.h: Added.

(WebCore::XMLToken::XMLToken):
(WebCore::XMLToken::clear):
(WebCore::XMLToken::appendToName):
(WebCore::XMLToken::name):
(WebCore::XMLToken::beginDOCTYPE):
(WebCore::XMLToken::beginXMLDeclaration):
(WebCore::XMLToken::appendToXMLVersion):
(WebCore::XMLToken::beginXMLEncoding):
(WebCore::XMLToken::appendToXMLEncoding):
(WebCore::XMLToken::setXMLStandalone):
(WebCore::XMLToken::beginProcessingInstruction):
(WebCore::XMLToken::appendToProcessingInstructionTarget):
(WebCore::XMLToken::appendToProcessingInstructionData):
(WebCore::XMLToken::beginCDATA):
(WebCore::XMLToken::appendToCDATA):
(WebCore::XMLToken::beginEntity):
(WebCore::XMLToken::print):
(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):

13:30 Changeset [91395] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

WebKit crashes on selection when documentElement is removed.
https://bugs.webkit.org/show_bug.cgi?id=63908

Source/WebCore:

This patch adds NULL pointer validation for documentElement
in WebCore::startOfDocument

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-20
Reviewed by Eric Seidel.

Test: editing/selection/selection-empty-documentElement.html

  • editing/visible_units.cpp:

(WebCore::startOfDocument):

LayoutTests:

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-20
Reviewed by Eric Seidel.

  • editing/selection/selection-empty-documentElement-expected.txt: Added.
  • editing/selection/selection-empty-documentElement.html: Added.
13:25 Changeset [91394] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Codeblock doesn't visit cached structures in global resolve instructions
https://bugs.webkit.org/show_bug.cgi?id=64889

Reviewed by Sam Weinig.

Visit the global resolve instructions. This fixes a couple
of random crashes seen in the jquery tests when using the
interpreter.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

13:10 Changeset [91393] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[skia] use nocheck version of pixel packer when caller already has premultiplied data
https://bugs.webkit.org/show_bug.cgi?id=64881

Patch by Mike Reed <reed@google.com> on 2011-07-20
Reviewed by Kenneth Russell.

No new tests. existing canvas and svg test exercise this

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):

13:06 Changeset [91392] by tony@chromium.org
  • 12 edits
    2 adds in trunk/Source/WebCore

add new flexbox data to StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=64765

Reviewed by David Hyatt.

Add placeholders for the positive and negative flex values for the
width and the height. When we get to the other properties (flex-pack,
flex-align, etc), we'll add more to the StyleFlexibleBoxData class

No new tests, these values aren't hooked up to anything yet.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexboxWidthPositiveFlex):
(WebCore::InheritedFlags::flexboxWidthNegativeFlex):
(WebCore::InheritedFlags::flexboxHeightPositiveFlex):
(WebCore::InheritedFlags::flexboxHeightNegativeFlex):
(WebCore::InheritedFlags::setFlexboxWidthPositiveFlex):
(WebCore::InheritedFlags::setFlexboxWidthNegativeFlex):
(WebCore::InheritedFlags::setFlexboxHeightPositiveFlex):
(WebCore::InheritedFlags::setFlexboxHeightNegativeFlex):
(WebCore::InheritedFlags::initialFlexboxWidthPositiveFlex):
(WebCore::InheritedFlags::initialFlexboxWidthNegativeFlex):
(WebCore::InheritedFlags::initialFlexboxHeightPositiveFlex):
(WebCore::InheritedFlags::initialFlexboxHeightNegativeFlex):

  • rendering/style/StyleAllInOne.cpp:
  • rendering/style/StyleFlexibleBoxData.cpp: Added.

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h: Added.

(WebCore::StyleFlexibleBoxData::create):
(WebCore::StyleFlexibleBoxData::copy):
(WebCore::StyleFlexibleBoxData::operator!=):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
13:04 Changeset [91391] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:39 Changeset [91390] by isherman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove TODO in WebNode.h from a two-sided patch that has now landed
https://bugs.webkit.org/show_bug.cgi?id=64840

Reviewed by Darin Fisher.

  • public/WebNode.h:
12:36 Changeset [91389] by gavinp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/html

Try again: Merge 89719 BUG=80729

12:31 Changeset [91388] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

update FontSkia to match platform context convention
https://bugs.webkit.org/show_bug.cgi?id=64795

Reviewed by James Robinson.

No new tests. This platform variant is not
built at this time.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):
Call makeGrContextCurrent instead of the obsolete prepareForSoftwareDraw.

12:16 Changeset [91387] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r91384. Add an ASSERT_UNSED for the timer.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

12:01 Changeset [91386] by tony@chromium.org
  • 4 edits
    2 adds in trunk

Stale pointer due to floats not removed (flexible box display)
https://bugs.webkit.org/show_bug.cgi?id=64603

Reviewed by David Hyatt.

Source/WebCore:

Flexbox items should avoid floats.

Test: fast/flexbox/horizontal-box-float-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::avoidsFloats):

  • rendering/RenderBox.h:

(WebCore::RenderBox::isDeprecatedFlexItem):

LayoutTests:

  • fast/flexbox/horizontal-box-float-crash-expected.txt: Added.
  • fast/flexbox/horizontal-box-float-crash.html: Added.
11:55 Changeset [91385] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations changes.

Pre-emptively mark some test failures/timeouts from an upcoming skia
change in Chrome.

  • platform/chromium/test_expectations.txt:
11:45 Changeset [91384] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-20
Reviewed by Antti Koivisto.

REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).

No new layout tests, but with this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::getHandleCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):

  • loader/cache/CachedResourceLoader.h:
11:43 Changeset [91383] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Revert worker and WebKit2 runloops to use currentTime() for scheduling instead of the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64841

Patch by James Robinson <jamesr@chromium.org> on 2011-07-20
Reviewed by Mark Rowe.

http://trac.webkit.org/changeset/91206 converted most of WebKit's deferred work scheduling to using the
monotonic clock instead of WTF::currentTime(). This broke many plugin tests on WebKit2 for reasons that are
unclear. This reverts everything except for WebCore::ThreadTimers back to the previous behavior.

Source/JavaScriptCore:

  • wtf/ThreadingPthreads.cpp:

(WTF::ThreadCondition::timedWait):

  • wtf/ThreadingWin.cpp:

(WTF::absoluteTimeToWaitTimeoutInterval):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::ThreadCondition::timedWait):

  • wtf/qt/ThreadingQt.cpp:

(WTF::ThreadCondition::timedWait):

Source/WebCore:

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerSharedTimer::setFireInterval):

Source/WebKit2:

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/RunLoop.h:
11:32 Changeset [91382] by simonjam@chromium.org
  • 4 edits in trunk

Refuse to run scripts inside the SVG shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=64776

Source/WebCore:

This is a rollback of r90970. The hack that was removed there was also protecting us from
two further bugs that have been discovered. So, the hack is going back in.

Reviewed by Tony Gentilcore.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

LayoutTests:

Reviewed by Tony Gentilcore.

  • platform/chromium/test_expectations.txt:
11:30 Changeset [91381] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging http://trac.webkit.org/changeset/91253

11:21 Changeset [91380] by levin@chromium.org
  • 4 edits in trunk/Source/JavaScriptCore

currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

11:14 Changeset [91379] by abarth@webkit.org
  • 2 edits in trunk/Tools

NRWT results uses too much space per run
https://bugs.webkit.org/show_bug.cgi?id=64845

Reviewed by Ojan Vafai.

Removing these files saves about 750K per build.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
11:07 Changeset [91378] by levin@chromium.org
  • 3 edits in trunk/Source/WebCore

gtk shouldn't have global variables for timers.
https://bugs.webkit.org/show_bug.cgi?id=64871

Reviewed by Martin Robinson.

No new functionality exposed so no new tests.

  • platform/graphics/cairo/ContextShadowCairo.cpp:

(WebCore::scheduleScratchBufferPurge): Changed global variable to DEFINE_STATIC_LOCAL.

  • platform/gtk/WidgetRenderingContext.cpp:

(WebCore::scheduleScratchBufferPurge): Ditto.

10:01 Changeset [91377] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Bug 64625: Add isSpeechInputEnabled flag to WebContextMenuData.
https://bugs.webkit.org/show_bug.cgi?id=64625

Patch by Glen Shires <gshires@google.com> on 2011-07-20
Reviewed by Darin Fisher.

  • public/WebContextMenuData.h:

(WebKit::WebContextMenuData::WebContextMenuData): added flag isSpeechInputEnabled

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): set flag isSpeechInputEnabled

09:52 Changeset [91376] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] REGRESSION(r86436): does not add newlines when return is pressed with some modifiers held
https://bugs.webkit.org/show_bug.cgi?id=64867

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2011-07-20
Reviewed by Martin Robinson.

  • platform/gtk/KeyBindingTranslator.cpp:

(WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):
special-case enter keys so that their commands are returned
whatever the modifiers state.

09:42 Changeset [91375] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[skia] disable lcd text when drawing on a transparent layer or canvas
https://bugs.webkit.org/show_bug.cgi?id=64873

Patch by Mike Reed <reed@google.com> on 2011-07-20
Reviewed by Stephen White.

No new tests. canvas sites illustrate the bug. DRT disables LCD
so existing layouttests are not affected by this change.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::isCanvasMultiLayered):
(WebCore::disableTextLCD):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

09:33 Changeset [91374] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Gtk] [NRWT] Xvfb produces a lot of stderr output
https://bugs.webkit.org/show_bug.cgi?id=64669

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-07-20
Reviewed by Philippe Normand.

Redirect the stderr output of the driver's Xvfb process
to /dev/null to suppress unneeded output.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
09:07 Changeset [91373] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.1/WebKit2

Tag for WebKit2 in Safari 5.1 (WebKit2 534.48.3)

09:07 Changeset [91372] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.1/WebKit

Tag for WebKit in Safari 5.1 (WebKit 534.48.3)

09:06 Changeset [91371] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.1/WebCore

Tag for WebCore in Safari 5.1 (WebCore 534.48.3)

09:06 Changeset [91370] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.1/JavaScriptGlue

Tag for JavaScriptGlue in Safari 5.1 (JavaScriptGlue 534.48.3)

09:05 Changeset [91369] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.1/JavaScriptCore

Tag for JavaScriptCore in Safari 5.1 (JavaScriptCore 534.48.3)

08:54 Changeset [91368] by timothy@apple.com
  • 1 add in releases/Apple/Safari 5.1

New release tag.

08:43 Changeset [91367] by loislo@chromium.org
  • 5 edits in trunk

Web Inspector: add keyboard shortcuts to load/save operations in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=64864

Source/WebCore:

Export/import were renamed to save/load.
Ctrl|Meta-S/Ctrl|Meta-O shortcuts were added for Save and Load operations.
Ctrl|Meta-E shortcut toggles Record button;
Ctrl|Meta-Shift-F shortcut toggles short records filter button;
All the shortcuts were added to the shortcuts help screen.
There was a problem with saving empty data.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._createFileSelector):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._saveToFile):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadFromFile.onError):
(WebInspector.TimelineModel.prototype._saveToFile):

LayoutTests:

Export/import were renamed to save/load.

Reviewed by Yury Semikhatsky.

  • inspector/timeline/timeline-load.html:
08:38 Changeset [91366] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix after r91355.

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

08:27 Changeset [91365] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
07:55 Changeset [91364] by commit-queue@webkit.org
  • 26 edits
    1 copy
    5 moves
    4 deletes in trunk/Source/WebCore

MediaStream API: Update the tracklists to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=64791

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-07-20
Reviewed by Tony Gentilcore.

The test harness will be forthcoming very soon now, introducing tests for this.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExclusiveTrackList.cpp: Removed.
  • dom/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
(WebCore::LocalMediaStream::streamEnded):
(WebCore::LocalMediaStream::stop):

  • dom/LocalMediaStream.h:

(WebCore::LocalMediaStream::isLocalMediaStream):

  • dom/LocalMediaStream.idl:
  • dom/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):

  • dom/MediaStream.h:

(WebCore::MediaStream::tracks):

  • dom/MediaStream.idl:
  • dom/MediaStreamTrack.cpp: Copied from Source/WebCore/dom/ExclusiveTrackList.h.

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):

  • dom/MediaStreamTrack.h: Renamed from Source/WebCore/dom/MultipleTrackList.h.
  • dom/MediaStreamTrack.idl: Renamed from Source/WebCore/dom/ExclusiveTrackList.idl.
  • dom/MediaStreamTrackList.cpp: Renamed from Source/WebCore/dom/ExclusiveTrackList.h.

(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::~MediaStreamTrackList):
(WebCore::MediaStreamTrackList::length):
(WebCore::MediaStreamTrackList::item):

  • dom/MediaStreamTrackList.h: Renamed from Source/WebCore/dom/TrackList.idl.

(WebCore::MediaStreamTrackList::associateStream):

  • dom/MediaStreamTrackList.idl: Renamed from Source/WebCore/dom/MultipleTrackList.idl.
  • dom/MultipleTrackList.cpp: Removed.
  • dom/TrackList.cpp: Removed.
  • dom/TrackList.h: Removed.
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp:

(WebCore::MediaStreamController::setMediaStreamTrackEnabled):
(WebCore::MediaStreamController::streamGenerated):

  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp:

(WebCore::MediaStreamFrameController::setMediaStreamTrackEnabled):
(WebCore::MediaStreamFrameController::streamGenerated):

  • page/MediaStreamFrameController.h:
07:52 Changeset [91363] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] Make OpenGL symbol resolver transparent
https://bugs.webkit.org/show_bug.cgi?id=57154

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-20
Reviewed by Noam Rosenthal.

Adopting new resolver should be transparent,
existing tests should apply.

Adopt OpenGLShims symbol resolver from cairo for Qt.
Update TextureMapperGL and Qt GraphicsContext3D to use the resolver.

  • WebCore.pro:
  • platform/graphics/cairo/OpenGLShims.cpp:

(WebCore::getProcAddress):

  • platform/graphics/cairo/OpenGLShims.h:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::reshape):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):

07:43 Changeset [91362] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

[V8] JavaMethodJobject::signature() incorrectly encodes arguments of type JavaTypeString
https://bugs.webkit.org/show_bug.cgi?id=62389

Reviewed by Tony Gentilcore.

Covered by existing tests.

  • bridge/jni/JavaMethodJobject.cpp:

(JavaMethodJobject::signature):

07:11 Changeset [91361] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: sidebar width sometimes is not restored
https://bugs.webkit.org/show_bug.cgi?id=64869

Make sure sidebar width is restored even if window initial size has not been set yet.

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.updateSidebarWidth):

07:03 Changeset [91360] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove dead code (WebInspector.drawLoadingPieChart)
https://bugs.webkit.org/show_bug.cgi?id=64868

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:
06:29 Changeset [91359] by caseq@chromium.org
  • 16 edits
    1 copy
    3 adds in trunk/Source

2011-07-20 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: move Network log view to an iframe
https://bugs.webkit.org/show_bug.cgi?id=62006

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onWindowMessage):
  • inspector/front-end/IFrameView.js: Added. (WebInspector.IFrameView): (WebInspector.IFrameView.prototype._innerShow): (WebInspector.IFrameView.prototype._innerHide): (WebInspector.IFrameView.prototype.attach): (WebInspector.IFrameView.prototype._attachIFrameAndInitialize): (WebInspector.IFrameView.prototype.addStylesheets): (WebInspector.IFrameView.prototype._setDocumentType): (WebInspector.IFrameView.prototype._propagateBodyStyle):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView): (WebInspector.NetworkLogView.prototype.initializeView): (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkLogView.prototype._createTable): (WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): (WebInspector.NetworkLogView.prototype.show): (WebInspector.NetworkLogView.prototype._reset): (WebInspector.NetworkLogView.prototype.switchToDetailedView): (WebInspector.NetworkLogView.prototype.switchToBriefView): (WebInspector.NetworkLogView.prototype.get _setLargerResources): (WebInspector.NetworkLogView.prototype._updateHighlightIfMatched): (WebInspector.NetworkLogView.prototype.performSearch): (WebInspector.NetworkLogView.prototype.searchCanceled): (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onSearchCountUpdated): (WebInspector.NetworkDataGridNode.prototype.select):
  • inspector/front-end/Popover.js: (WebInspector.Popover.prototype._positionElement):
  • inspector/front-end/View.js: (WebInspector.View.prototype._innerShow): (WebInspector.View.prototype.show): (WebInspector.View.prototype._innerHide): (WebInspector.View.prototype.hide):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/dataGrid.css: Added.
  • inspector/front-end/inspectorCommon.css: Added.
  • inspector/front-end/networkLogView.css: Copied from Source/WebCore/inspector/front-end/networkPanel.css.

2011-07-20 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: move Network log view to an iframe
https://bugs.webkit.org/show_bug.cgi?id=62006

Reviewed by Pavel Feldman.

  • WebKit.gyp:
05:28 Changeset [91358] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectation fix.
Forgot to remove fast/forms/input-appearance-number-rtl.html form test_expectations.txt
in http://trac.webkit.org/changeset/91356 that added platform specific result for this test.

  • platform/qt/test_expectations.txt:
05:00 Changeset [91357] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip a spinbutton test after r91353

  • platform/qt/Skipped:
04:24 Changeset [91356] by loki@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add missing expected file after r91345 and r91269

  • platform/qt/fast/forms/input-appearance-number-rtl-expected.txt: Added. (r91345)
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added. (r91269)
04:20 Changeset [91355] by steveblock@google.com
  • 11 edits in trunk/Source/WebCore

JobjectWrapper should inherit from RefCounted rather than implementing its own ref counting
https://bugs.webkit.org/show_bug.cgi?id=55786

Also adds static create() method and cleans up use of data members.

Reviewed by Tony Gentilcore.

No new tests, refactoring only.

  • bridge/jni/JobjectWrapper.cpp:

(JobjectWrapper::JobjectWrapper):

  • bridge/jni/JobjectWrapper.h:

(JSC::Bindings::JobjectWrapper::create):

  • bridge/jni/jsc/JavaArrayJSC.cpp:

(JavaArray::JavaArray):

  • bridge/jni/jsc/JavaArrayJSC.h:

(JSC::Bindings::JavaArray::javaArray):

  • bridge/jni/jsc/JavaFieldJSC.cpp:

(JavaField::JavaField):
(JavaField::dispatchValueFromInstance):
(JavaField::dispatchSetValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::JavaInstance):
(JavaInstance::getClass):
(JavaInstance::stringValue):
(JavaInstance::numberValue):
(JavaInstance::booleanValue):
(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaInstanceJSC.h:

(JSC::Bindings::JavaInstance::javaInstance):

  • bridge/jni/v8/JavaFieldJobjectV8.cpp:

(JavaFieldJobject::JavaFieldJobject):

  • bridge/jni/v8/JavaInstanceJobjectV8.cpp:

(JavaInstanceJobject::JavaInstanceJobject):

  • bridge/jni/v8/JavaInstanceJobjectV8.h:

(JSC::Bindings::JavaInstanceJobject::javaInstance):

04:02 Changeset [91354] by commit-queue@webkit.org
  • 2 edits in trunk

[Qt] Qt5 Build Fix: Disable the legacy mac assert macros.

This is done in order to prevent collision with the recently
introduced function QSslCertificate::verify() in Qt5.

https://bugs.webkit.org/show_bug.cgi?id=64855

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-07-20
Reviewed by Simon Hausmann.

  • Source/WebKit.pri:
03:23 Changeset [91353] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

The value of a number input form continues to increase/decrease even if we disable the input form.
https://bugs.webkit.org/show_bug.cgi?id=64786

Patch by Kentaro Hara <haraken@google.com> on 2011-07-20
Reviewed by Kent Tamura.

Source/WebCore:

The value of the number input form continues to increase/decrease in the following scenario:
(1) Click the spin button of the input form.
(2) Hook the 'mouseup' event and disable the input form.
(3) Enable the input form after some delay (e.g. 50ms).

What is happening above is as follows:
(1) When the 'mousedown' event happens, the repeating timer of the spin button starts.
(2) If the input form is not disabled, the repeating timer stops at the 'mouseup' event.
However, if the input form is disabled, the 'mouseup' event is ignored, failing to stop
the repeating timer.
(3) The value continues to increase/decrease, since the repeating timer is still working.

This patch stops the repeating timer when the input form gets disabled or readonly.

Test: fast/forms/spin-button-gets-disabled-or-readonly.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Calls disabledAttributeChanged() when 'disabled' attribute gets changed. Calls readonlyAttributeChanged() when 'readonly' attribute gets changed.

  • html/InputType.cpp:

(WebCore::InputType::disabledAttributeChanged): Stops the repeating timer and releases mouse capturing.
(WebCore::InputType::readonlyAttributeChanged): Ditto.

  • html/InputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::disabledAttributeChanged): Ditto.
(WebCore::TextFieldInputType::readonlyAttributeChanged): Ditto.

  • html/TextFieldInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::detach): Replased the code with releaseCapture().
(WebCore::SpinButtonElement::defaultEventHandler): Ditto.
(WebCore::SpinButtonElement::releaseCapture): Stops the repeating timer and releases mouse capturing.

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

The value of the number input form continues to increase/decrease in the following scenario:
(1) Click the spin button of the number input form.
(2) Hook the 'mouseup' event and disable the number input form.
(3) Enable the number input form after some delay (e.g. 50ms).

What is happening above is as follows:
(1) When the 'mousedown' event happens, the repeating timer of the spin button starts.
(2) If the input form is not disabled, the repeating timer stops at the 'mouseup' event.
However, if the input form is disabled, the 'mouseup' event is ignored, failing to stop
the repeating timer.
(3) The value continues to increase/decrease, since the repeating timer is still working.

The added test checks if the value does not continue to increase/decrease when we do the above operation.

  • fast/forms/spin-button-gets-disabled-or-readonly-expected.txt: Added.
  • fast/forms/spin-button-gets-disabled-or-readonly.html: Added.
03:09 Changeset [91352] by tkent@chromium.org
  • 11 edits
    4 adds in trunk/LayoutTests

[Chromium] Expectation update for some forms and speech tests.

  • platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
02:43 Changeset [91351] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the 32-bit build.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

02:40 Changeset [91350] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/LayoutTests/platform/mac/svg

Unreviewed. Rebaseline image test expectations for Mac after r91331.

  • platform/mac/svg/text/text-altglyph-01-b-expected.png
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png
02:21 Changeset [91349] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r91285.
http://trac.webkit.org/changeset/91285
https://bugs.webkit.org/show_bug.cgi?id=64854

"Assertion hit in svg/custom/crash-textPath-attributes.html"
(Requested by mihnea on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-20

Source/WebCore:

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/dynamic/hover-before-position-after-style-change-expected.txt: Removed.
  • fast/dynamic/hover-before-position-after-style-change.html: Removed.
01:59 Changeset [91348] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't send Console.enable messages in case of workers
https://bugs.webkit.org/show_bug.cgi?id=64853

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:
01:08 Changeset [91347] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/LayoutTests/platform/gtk

Unreviewed. Rebaseline test expectations for GTK after r91331.
platform/gtk/fast/dom/Window/window-properties-expected.txt
platform/gtk/svg/text/text-altglyph-01-b-expected.txt
platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt

00:54 Changeset [91346] by caseq@chromium.org
  • 7 edits in trunk

Source/WebCore: Add a resourceLink audit formatter to make it possible for devtools
extensions to link to specific lines in HTML/JS/CSS resources from the
audit results panel.

https://bugs.webkit.org/show_bug.cgi?id=64315

Patch by Boris Smus <smus@chromium.org> on 2011-07-20
Reviewed by Yury Semikhatsky.

  • inspector/front-end/AuditFormatters.js: resourceLink implementation
  • inspector/front-end/ExtensionAPI.js: registering resourceLink FormattedValue

LayoutTests: Web Inspector: audit extensions need a way to link directly to resources
https://bugs.webkit.org/show_bug.cgi?id=64315

Patch by Boris Smus <smus@chromium.org> on 2011-07-20
Reviewed by Yury Semikhatsky.

  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits.html:
00:52 Changeset [91345] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

input type=number doesn't render correctly in rtl.
https://bugs.webkit.org/show_bug.cgi?id=59703

Source/WebCore:

Reviewed by Ryosuke Niwa.

Test: fast/forms/input-appearance-number-rtl.html

  • css/html.css:

(input[type="search"]::-webkit-textfield-decoration-container):
Set "direction: ltr;" only for type=search because we'd like to
respect text direction except type=search.
(input[x-webkit-speech][di=rtl]::-webkit-input-speech-button):
Remove a workaround.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Support for RTL in the spin button location adjustment.

LayoutTests:

Patch by tkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2011-07-20
Reviewed by Ryosuke Niwa.

  • fast/forms/input-appearance-number-rtl.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.txt: Added.
  • platform/qt/test_expectations.txt:
00:50 Changeset [91344] by barraclough@apple.com
  • 17 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fix ES5.1 correctness issues identified by Mads Ager.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • ES5.1 expects toString of undefined/null to produce "[object Undefined]"/"[object Null]".

LayoutTests:

  • fast/js/object-prototype-properties-expected.txt:
  • fast/js/script-tests/object-prototype-properties.js:
    • Fix these tests to check Object.prototype explicitly, not the Global Object, and expect ES5.1 correct results.
  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
    • Slight change in expected results, these tests are all incorrect, were all FAILing, and are still all FAILing.
00:32 Changeset [91343] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations for r91331.
Unreviewed.

  • platform/chromium/test_expectations.txt:

07/19/11:

23:32 Changeset [91342] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/LayoutTests/platform/win/fast

Unreviewed. Rebaseline test expectations for Windows after r91331.
platform/win/fast/dom/Window/window-property-descriptors-expected.txt
platform/win/fast/dom/prototype-inheritance-expected.txt
platform/win/fast/js/global-constructors-expected.txt

23:28 Changeset [91341] by loki@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

Move platform independent expected.txts out of platform/mac
https://bugs.webkit.org/show_bug.cgi?id=64796

Reviewed by Rob Buis.

  • fast/css/replaced-element-implicit-size-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/replaced-element-implicit-size-expected.txt.
  • svg/custom/zero-path-square-cap-rendering-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/zero-path-square-cap-rendering-expected.txt.
23:11 Changeset [91340] by leo.yang@torchmobile.com.cn
  • 6 edits in trunk/LayoutTests

Unreviewed. Rebaseline JS and DOM test expectations after r91331.

fast/js/global-constructors-expected.txt
fast/dom/prototype-inheritance-2-expected.txt
fast/dom/prototype-inheritance-expected.txt
fast/dom/Window/window-properties-expected.txt
fast/dom/Window/window-property-descriptors-expected.txt
svg/custom/global-constructors-expected.txt

22:59 Changeset [91339] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/LayoutTests/platform/mac/svg

Unreviewed. Rebaseline test expectations for Mac after r91331.

platform/mac/svg/text/text-altglyph-01-b-expected.txt
platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt

22:53 Changeset [91338] by leo.yang@torchmobile.com.cn
  • 1 edit in trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt

Unreviewed. Rebasline chromium test expectation after r91331.

22:52 Changeset [91337] by sjl@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Media player controls do not fade out.
https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):

  • html/shadow/MediaControlRootElementChromium.h:
22:41 Changeset [91336] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64846

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCounter
Added class to handle counter properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize counter property handlers.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove old handlers.

22:31 Changeset [91335] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Improve documentation of QWebView::setPage()
https://bugs.webkit.org/show_bug.cgi?id=64827

Reviewed by Noam Rosenthal.

  • Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.
22:19 Changeset [91334] by hayato@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] More chromium rebaseline for r91249.
Unreviewed.

  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.
21:46 Changeset [91333] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback.
https://bugs.webkit.org/show_bug.cgi?id=64314

Reviewed by Sam Weinig.

No new tests because it's hard to make a non-flaky test for this behavior.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
Don't call SliderThumbElement::dragFrom() for events on the thumb.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
Do not call setDefaultHandled() for mouse events in order to
propagate them to ancestor elements.

21:24 Changeset [91332] by mdelaney@apple.com
  • 19 edits in trunk/Source/WebCore

Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

  • platform/graphics/ImageBuffer.h:

1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.

  • platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
  • platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

  • platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:

  • platform/graphics/qt/ImageBufferQt.cpp
  • platform/graphics/filters/FETile.cpp
  • platform/graphics/cairo/ImageBufferCairo.cpp
  • platform/graphics/skia/ImageBufferSkia.cpp
  • platform/graphics/wx/ImageBufferWx.cpp
  • platform/graphics/wince/ImageBufferWinCE.cpp
  • svg/SVGFEImageElement.cpp
  • svg/graphics/SVGImage.cpp
  • html/HTMLCanvasElement.cpp
  • html/canvas/WebGLRenderingContext.cpp
  • rendering/svg/RenderSVGResourcePattern.cpp
19:48 Changeset [91331] by leo.yang@torchmobile.com.cn
  • 23 edits
    9 adds in trunk

SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=60850

Reviewed by Nikolas Zimmermann.

SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
elements for alternative glyph features.

Source/WebCore:

NOTE: x, y, dx, dy, format and glyphRef attributes on <glyphRef> are not
honored yet, so neither are the reaction of dynamic change of them. They
will be honored in separated patches.

Test: svg/W3C-SVG-1.1/text-altglyph-01-b.svg
With this patch this test works as expected.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMSVG.h:
  • page/DOMWindow.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAltGlyphDefElement.cpp: Added.

(WebCore::SVGAltGlyphDefElement::SVGAltGlyphDefElement):
(WebCore::SVGAltGlyphDefElement::create):
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphDefElement.h: Added.
  • svg/SVGAltGlyphDefElement.idl: Added.
  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.cpp: Added.

(WebCore::SVGAltGlyphItemElement::SVGAltGlyphItemElement):
(WebCore::SVGAltGlyphItemElement::create):
(WebCore::SVGAltGlyphItemElement::hasValidGlyphElements):

  • svg/SVGAltGlyphItemElement.h: Added.
  • svg/SVGAltGlyphItemElement.idl: Added.
  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGGlyphRefElement.cpp: Added.

(WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
(WebCore::SVGGlyphRefElement::create):
(WebCore::SVGGlyphRefElement::hasValidGlyphElement):
(WebCore::SVGGlyphRefElement::parseMappedAttribute):
(WebCore::SVGGlyphRefElement::glyphRef):
(WebCore::SVGGlyphRefElement::setGlyphRef):
(WebCore::SVGGlyphRefElement::setX):
(WebCore::SVGGlyphRefElement::setY):
(WebCore::SVGGlyphRefElement::setDx):
(WebCore::SVGGlyphRefElement::setDy):

  • svg/SVGGlyphRefElement.h: Added.
  • svg/SVGGlyphRefElement.idl: Added.
  • svg/svgtags.in:

Source/WebKit/mac:

  • MigrateHeaders.make:

LayoutTests:

Updated test expectation.

  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
19:41 Changeset [91330] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
19:13 Changeset [91329] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update. svg/custom/crash-textPath-attributes.html is hitting an assertion.
The failure is tracked by the bug 64844.

  • platform/chromium/test_expectations.txt:
18:18 Changeset [91328] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip some more tests on WebKit2 that rely on unimplemented test harness APIs

  • platform/wk2/Skipped: Added svg/animations/svgtransform-animation-discrete.html and

fast/forms/input-search-press-escape-key.html.

18:15 Changeset [91327] by rniwa@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Apparently my rebaseline was incorrect for r91294.

Remove expected results and skip compositing/scaling/tiled-layer-recursion.html on Chromium
because it's missing expected results.

  • platform/chromium/test_expectations.txt:
18:00 Changeset [91326] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51

New tag.

17:48 Changeset [91325] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Remove some unused code in FormDataStreamCFNet

Rubber-stamped by Steve Falkenburg.

  • platform/network/cf/FormDataStreamCFNet.cpp:
17:46 Changeset [91324] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-07-19 Simon Fraser <simon.fraser@apple.com>

REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64808

Reviewed by Adam Roben.

Initializing m_uncommittedChanges to a non-zero value
caused the first call to noteLayerPropertyChanged() to
not call m_client->notifySyncRequired(). This resulted in
animations never getting committed on Windows, which broke
a lot of tests.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA):
17:29 Changeset [91323] by eric@webkit.org
  • 3 edits in trunk/Tools

parse-malloc-history always exits 1, causing NRWT to fail
https://bugs.webkit.org/show_bug.cgi?id=64835

Reviewed by Adam Barth.

ORWT just never checked the return code. :)

  • Scripts/parse-malloc-history:

(main):

  • Scripts/webkitpy/layout_tests/port/mac.py:
17:07 Changeset [91322] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
https://bugs.webkit.org/show_bug.cgi?id=64834

Reviewed by Kenneth Russell.

Uses setters and getters to access RenderSurfaceChromium's private member variables instead of directly
accessing them via a friend declaration. This cleans up a minor code smell and will be helpful for future
refactoring.

Refactor only, no change in behavior. Tested by compositing/ tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::clearLayerList):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::contentRect):
(WebCore::RenderSurfaceChromium::setContentRect):
(WebCore::RenderSurfaceChromium::drawOpacity):
(WebCore::RenderSurfaceChromium::setDrawOpacity):
(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::maskLayer):
(WebCore::RenderSurfaceChromium::setMaskLayer):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::scissorRect):
(WebCore::RenderSurfaceChromium::setScissorRect):
(WebCore::RenderSurfaceChromium::skipsDraw):
(WebCore::RenderSurfaceChromium::setSkipsDraw):
(WebCore::RenderSurfaceChromium::contentsTexture):

16:21 Changeset [91321] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2011-07-19 Simon Fraser <simon.fraser@apple.com>

Skip compositing/scaling/tiled-layer-recursion.html on chromium
and Windows because it requires the scalePageBy DRT API.

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
16:18 Changeset [91320] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

GTK + QT build fix.

Rubber-stamped by Daniel Bates and Alexey Proskuryakov.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

16:14 Changeset [91319] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix web audio compile on mac port
https://bugs.webkit.org/show_bug.cgi?id=64836

Unreviewed build fix.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):
(WebCore::JSAudioContext::createBuffer):

16:14 Changeset [91318] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.

15:58 Changeset [91317] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix after r91307.

  • Platform/Logging.h:
15:57 Changeset [91316] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Reviewed by Alexey Proskuryakov.

Make these unexpected cases crash in the WebKit nightlies so we can gather more
information and potentially find a repro case.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

15:56 Changeset [91315] by eric@webkit.org
  • 11 edits in trunk/Tools

new-run-webkit-tests should only enable MallocStackLogging for DRT
https://bugs.webkit.org/show_bug.cgi?id=64792

Reviewed by Adam Barth.

The previous code would enable it for all servers launched
by the port, which included Apache, the python websocket server
as well as ImageDiff. Now only DumpRenderTree will have
MallocStackLogging enabled or the GuardMalloc library injected.

I also cleaned up the websocket_server code to use filesystem
while I was in it.

I also made DRT restart every 1000 tests when running with
--leaks enabled. I believe this made the --leaks run slightly
faster, but it still takes over an hour on my machine. :(

  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:
15:49 Changeset [91314] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Nothing printed when specifying a very large maximum layout width
https://bugs.webkit.org/show_bug.cgi?id=64831

Reviewed by Beth Dakin.

I am not adding a test because the DumpRenderTree printing test machinery is based on PrintContext,
which does not exercise the code path on which this bug lies.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination): Fixed an integer overflow.

15:48 Changeset [91313] by ojan@chromium.org
  • 3 edits in trunk/Tools

remove the concept of platform fallbacks
https://bugs.webkit.org/show_bug.cgi?id=64829

Reviewed by Adam Barth.

In the process, wrote tests for this code and fixed a pretty major
bug (now covered by the test).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:46 Changeset [91312] by ojan@chromium.org
  • 3 edits in trunk/Tools

cleanup some of the PLATFORM logic in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64821

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:44 Changeset [91311] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Store line number on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64800

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
15:21 Changeset [91310] by rniwa@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

Chromium rebaseline for r91294. Also filed the bug 64828 to track the crash on Chromium Mac.

  • platform/chromium-gpu-linux/compositing/scaling: Added.
  • platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-win/compositing/scaling: Added.
  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:13 Changeset [91309] by japhet@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: [V8] Wait until no v8 context is on the stack before
cancelling pending indexed db transactions.
https://bugs.webkit.org/show_bug.cgi?id=64552

Reviewed by Adam Barth.

Test: storage/indexeddb/transaction-abort-with-js-recursion.html

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64552.

Reviewed by Adam Barth.

  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt: Added.
  • storage/indexeddb/transaction-abort-with-js-recursion.html: Added.
15:08 Changeset [91308] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash in CompositeEditCommand::replaceTextInNodePreservingMarkers.
https://bugs.webkit.org/show_bug.cgi?id=64738

Patch by MORITA Hajime <morrita@google.com> on 2011-07-19
Reviewed by Ryosuke Niwa.

Test: editing/undo/replace-text-in-node-preserving-markers-crash.html

  • editing/CompositeEditCommand.cpp:

(WebCore::copyMarkers):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

LayoutTests: Sending a Ping-From header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

  • http/tests/navigation/ping-cross-origin-expected.txt:
15:07 Changeset [91307] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit2

[GTK] [WK2] Implement missing initializeLogChannel function.
https://bugs.webkit.org/show_bug.cgi?id=63381

Patch by Lukasz Slachciak <lukasz.slachciak@gmail.com> on 2011-07-19
Reviewed by Martin Robinson.

Implemented logging for GTK platform in WebKit2 - function initializeLogChannel is called for all ports,
so added missing implementation. Aslo helper function added for getting channels from names.

  • GNUmakefile.am: Added reference to new file LoggingGtk.cpp.
  • Platform/Logging.cpp: Logging implementation for GTK port enabled.

(WebKit::getChannelFromName): Helper to connect name with WTFLogChannel.

  • Platform/Logging.h: New helper method added.
  • Platform/gtk/LoggingGtk.cpp: Added. GTK logging implementation.

(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.

14:56 Changeset [91306] by commit-queue@webkit.org
  • 4 edits in trunk

Sending a Ping-From header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

Source/WebCore:

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

LayoutTests:

  • http/tests/navigation/ping-cross-origin-expected.txt:
14:51 Changeset [91305] by barraclough@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=64809
REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

Reviewed by Adam Roben.

I think this just needs new results. The test deliberately triggers a stack overflow,
and doesn't catch it, so the error is printed to the console. Previously RangeError
had the wrong prototype, and didn't convert the error into a useful error message,
printing a blank line in the console. Since r91116 we inherit from Error correctly,
and print the error to the console.

  • fast/dom/error-to-string-stack-overflow-expected.txt:
  • fast/js/script-tests/object-prototype-properties.js:
14:49 Changeset [91304] by ojan@chromium.org
  • 3 edits in trunk/Tools

fix flakiness dashboard for XP bots with XP in the name instead of WIN
https://bugs.webkit.org/show_bug.cgi?id=64826

Reviewed by Mihai Parparita.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
14:39 Changeset [91303] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

More Chromium rebaselines for r91277.

  • platform/chromium-linux/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
14:31 Changeset [91302] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix leak of QWebPage in errorPageExtension tests
https://bugs.webkit.org/show_bug.cgi?id=64814

Reviewed by Noam Rosenthal.

QWebView::setPage() doesn't take ownership, so the ErrorPages were leaking. So now
allocate them on the stack. This shouldn't change any behavior.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtension):
(tst_QWebPage::errorPageExtensionInIFrames):
(tst_QWebPage::errorPageExtensionInFrameset):

14:22 Changeset [91301] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] remove BUG_DRT tests that the flakiness dashboard say are passing
https://bugs.webkit.org/show_bug.cgi?id=64819

Reviewed by Ryosuke Niwa.

  • platform/chromium/test_expectations.txt:
14:09 Changeset [91300] by levin@chromium.org
  • 22 edits
    1 copy
    16 adds in trunk

Bring V8's SerializedScriptValue implementation up to date.

https://bugs.webkit.org/show_bug.cgi?id=63481

Source/WebCore:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

The HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data) has been updated since the V8 version of SerializedScriptValue was first implemented. This patch aims to bring this implementation up to date. It:

  • Introduces the new HTML5 DOM error codes for TIMEOUT_ERR, INVALID_NODE_TYPE_ERR, DATA_CLONE_ERR
  • Handles cyclic structures and equality of reference preservation for cloned values
  • Allows DataViews to be constructed on the native side using the existing wrapper techniques
  • Amends tests and introduces new ones to check for correctness (the bulk of the patch)
  • Tolerates the old version of the serialized object format

The patch permits the cloning of JavaScript typed arrays. This functionality is in active use already and was supported (somewhat inefficiently) by the existing code through an artifact of implementation.

Tests: fast/dom/Window/window-postmessage-clone-deep-array.html

fast/dom/Window/window-postmessage-clone-really-deep-array.html
fast/dom/Window/window-postmessage-clone.html
fast/canvas/webgl/array-message-passing.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeVersion):
(WebCore::V8ObjectMap::Writer::writeArrayBuffer):
(WebCore::V8ObjectMap::Writer::writeArrayBufferView):
(WebCore::V8ObjectMap::Writer::writeObjectReference):
(WebCore::V8ObjectMap::Writer::writeReferenceCount):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshObject):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshArray):
(WebCore::V8ObjectMap::Writer::doWriteArrayBuffer):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::serialize):
(WebCore::V8ObjectMap::Serializer::StateBase::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::AbstractObjectState):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::advance):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::execDepth):
(WebCore::V8ObjectMap::Serializer::push):
(WebCore::V8ObjectMap::Serializer::pop):
(WebCore::V8ObjectMap::Serializer::handleError):
(WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
(WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
(WebCore::V8ObjectMap::Serializer::greyObject):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::Reader):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readVersion):
(WebCore::V8ObjectMap::Reader::setVersion):
(WebCore::V8ObjectMap::Reader::undoReadTag):
(WebCore::V8ObjectMap::Reader::readArrayBufferViewSubTag):
(WebCore::V8ObjectMap::Reader::doReadArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBufferView):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::deserialize):
(WebCore::V8ObjectMap::Deserializer::newArray):
(WebCore::V8ObjectMap::Deserializer::consumeTopOfStack):
(WebCore::V8ObjectMap::Deserializer::completeArray):
(WebCore::V8ObjectMap::Deserializer::newObject):
(WebCore::V8ObjectMap::Deserializer::completeObject):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::pushObjectReference):
(WebCore::V8ObjectMap::Deserializer::tryGetObjectFromObjectReference):
(WebCore::V8ObjectMap::Deserializer::objectReferenceCount):
(WebCore::V8ObjectMap::Deserializer::openComposite):
(WebCore::V8ObjectMap::Deserializer::closeComposite):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::isHostObject):

  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • dom/DOMCoreException.idl:
  • dom/ExceptionCode.cpp:
  • dom/ExceptionCode.h:
  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::create):

  • html/canvas/ArrayBuffer.h:
  • html/canvas/DataView.cpp:

(WebCore::DataView::create):

  • html/canvas/DataView.h:

LayoutTests:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

This patch refactors window-postmessage-clone into a script test, checks additional functionality set forth in the standard, and fixes up expectations. It also checks for typed array message passing.

  • fast/canvas/webgl/array-message-passing-expected.txt: Added.
  • fast/canvas/webgl/array-message-passing.html: Added.
  • fast/canvas/webgl/script-tests/array-message-passing.js: Added.

(classCompare):
(bufferCompare):
(viewCompare):
(typedArrayCompare):
(dataViewCompare):
(createBuffer):
(createTypedArray):
(createTypedArrayOverBuffer):
(testList):
(doneTest):
(windowHandleMessage):

  • fast/dom/Window/script-tests/postmessage-clone-deep-array.js: Added.
  • fast/dom/Window/script-tests/postmessage-clone-really-deep-array.js: Added.
  • fast/dom/Window/script-tests/postmessage-clone.js: Added.

(thunk):

  • fast/dom/Window/script-tests/postmessage-test.js: Copied from LayoutTests/fast/dom/Window/window-postmessage-clone.html.

():
(safeToString):
(shouldBe):
(shouldBeIdentical):
(doPass):
(doFail):
(window.doPassFail):
(onmessage):
(ConstructorWithPrototype):
(window.tryPostMessage):

  • fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
  • fast/dom/Window/window-postmessage-clone-deep-array.html: Added.
  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
  • fast/dom/Window/window-postmessage-clone-really-deep-array.html: Added.
  • fast/dom/Window/window-postmessage-clone.html:
  • fast/dom/Window/window-properties-expected.txt: Also fixed this due to r91061.
  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
14:06 Changeset [91299] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-19 Rob Buis <rbuis@rim.com>

REGRESSION (r91187-r91192): svg/W3C-SVG-1.1/animate-elem-80-t.svg failing on SnowLeopard Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64820

Reviewed by Darin Adler.

Update result after r91192.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
14:03 Changeset [91298] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Chromium rebaseline after r91290.

  • platform/chromium/fast/js/array-prototype-properties-expected.txt: Added.
13:47 Changeset [91297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Adds some methods to retrieve accessible information from tables and
table cells. Also refactors WebAccessibilityObject to use WebPrivatePtr
instead of its own implementation that didn't allow access to subclasses
of AccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=64805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-07-19
Reviewed by Dimitri Glazkov.

  • public/WebAccessibilityObject.h:

(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::isNull):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::reset):
(WebKit::WebAccessibilityObject::assign):
(WebKit::WebAccessibilityObject::equals):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::isValid):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::setFocused):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::hasComputedStyle):
(WebKit::WebAccessibilityObject::computedStyleDisplay):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):
(WebKit::WebAccessibilityObject::cellForColumnAndRow):
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::operator=):
(WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):

13:44 BuildingGtk edited by levin@chromium.org
Added information setting up dependencies for Linux when working on … (diff)
13:40 Changeset [91296] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Chromium Windows rebaseline after r91277, and Chromium rebaseline for r91284.

  • platform/chromium/fast/js/string-prototype-properties-expected.txt: Added.
  • platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.png: Added.
13:33 Changeset [91295] by commit-queue@webkit.org
  • 5 edits in trunk

[Chromium] Need to remove app/ from DEPS
https://bugs.webkit.org/show_bug.cgi?id=64750

Patch by Robert Sesek <rsesek@chromium.org> on 2011-07-19
Reviewed by Tony Chang.

.:

Remove Source/WebKit/chromium/app/ from .gitignore.

  • .gitignore:

Source/WebKit/chromium:

Roll DEPS and remove dependencies on Chromium's /src/app.

  • DEPS:
  • WebKit.gyp:
13:32 Changeset [91294] by simon.fraser@apple.com
  • 4 edits
    3 adds in trunk

2011-07-19 Simon Fraser <simon.fraser@apple.com>

Possible recursion in GraphicsLayerCA::updateGeometry()
https://bugs.webkit.org/show_bug.cgi?id=64815

Reviewed by Sam Weinig.

It was possible to recurse via updateGeometry/swapFromOrToTiledLayer/
updateContentsScale because updateGeometry() and updateContentsScale()
used different sizes; updateGeometry() used the scaled size, while
updateContentsScale() used the unscaled size.

Always use the unscaled size; the scaled size will be at most a couple
of pixels bigger, and our threshold is not close to the max texture
size limit, so using the slightly smaller size is OK.

Test: compositing/scaling/tiled-layer-recursion.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateGeometry): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::updateContentsScale): (WebCore::GraphicsLayerCA::requiresTiledLayer):
  • platform/graphics/ca/GraphicsLayerCA.h:
13:20 Changeset [91293] by rwlbuis@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-07-19 Rob Buis <rbuis@rim.com>

REGRESSION (r89951): svg/foreignObject/text-tref-02-b.svg failing on Leopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=64817

Rubber stamped by Darin Adler.

Remove outdated, incorrect test results, hopefully the generic mac results are good enough.

  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Removed.
  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
13:08 Changeset [91292] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add platform-specific results for r91277.

Unreviewed, add platform-specific results.

  • platform/gtk/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
13:06 Changeset [91291] by caryclark@google.com
  • 2 edits in trunk/Tools

add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=64816

No review needed.

  • Scripts/webkitpy/common/config/committers.py:
13:03 Changeset [91290] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

Source/JavaScriptCore: [JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

LayoutTests: Chromium rebaselines r91269 and r91277.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-19

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
12:55 Changeset [91289] by gavinp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/html

Revert 91204, Merge 90595 BUG=87729

12:49 Changeset [91288] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

12:40 Changeset [91287] by rniwa@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Chromium rebaselines r91269 and r91277.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
12:32 Changeset [91286] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk

[CSSRegions]Parse -webkit-region-overflow property
https://bugs.webkit.org/show_bug.cgi?id=64444

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-region-overflow-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionOverflow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialRegionOverflow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/regions/script-tests/webkit-region-overflow-parsing.js: Added.
  • fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
  • fast/regions/webkit-region-overflow-parsing.html: Added.
12:25 Changeset [91285] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block.

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Test: fast/dynamic/hover-before-position-after-style-change.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

  • fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
  • fast/dynamic/hover-before-position-after-style-change.html: Added.
12:16 Changeset [91284] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=64677
Fix bugs in String.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to
the global object, and primitive values should not be converted via
object types.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):

  • These methods should throw if this value is undefined, convert ToString directly, not via ToObject.

LayoutTests:

  • fast/js/script-tests/string-prototype-properties.js: Added.
  • fast/js/string-prototype-properties-expected.txt: Added.
  • fast/js/string-prototype-properties.html: Added.
    • Added layout test for string prototype functions with undefined/number as this value.
12:13 Changeset [91283] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyWebkitPerspectiveOrigin in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64784

Reviewed by Simon Fraser.

No new tests / refactoring.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

12:00 Changeset [91282] by dbates@webkit.org
  • 3 edits in trunk/Tools

Rename variable isEmptyTextPatch in svn-{apply, unapply}
https://bugs.webkit.org/show_bug.cgi?id=64648

Reviewed by Adam Roben.

Rename the variable isEmptyTextPatch to hasTextChunks, which is
more descriptive and makes its usage read well in control statements.

  • Scripts/svn-apply:

(patch):

  • Scripts/svn-unapply:

(patch):

11:59 Changeset [91281] by crogers@google.com
  • 8 edits
    8 adds in trunk/Source/WebCore

Implement WaveShaperNode for Web Audio API
https://bugs.webkit.org/show_bug.cgi?id=64644

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWaveShaperNodeCustom.cpp: Added.

(WebCore::JSWaveShaperNode::setCurve):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createWaveShaper):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/WaveShaperDSPKernel.cpp: Added.

(WebCore::WaveShaperDSPKernel::process):

  • webaudio/WaveShaperDSPKernel.h: Added.

(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::waveShaperProcessor):

  • webaudio/WaveShaperNode.cpp: Added.

(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setCurve):
(WebCore::WaveShaperNode::curve):

  • webaudio/WaveShaperNode.h: Added.

(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::waveShaperProcessor):

  • webaudio/WaveShaperNode.idl: Added.
  • webaudio/WaveShaperProcessor.cpp: Added.

(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::~WaveShaperProcessor):
(WebCore::WaveShaperProcessor::createKernel):
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::process):

  • webaudio/WaveShaperProcessor.h: Added.

(WebCore::WaveShaperProcessor::curve):

11:55 Changeset [91280] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT sometimes emits spill code even when the respective values
are never needed.
https://bugs.webkit.org/show_bug.cgi?id=64774

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-19
Reviewed by Gavin Barraclough.

The main high-level change is that it is now easier to call use() on a
virtual register. JSValueOperand and its other-typed relatives now have
a handy use() method, and jsValueResult() and friends now make it easier to
pass UseChildrenCalledExplicitly.

The rest of this patch hoists the call to use() as high as possible for
all of those cases where either flushRegisters() or silentSpillAllRegisters()
may be called.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::use):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateCellOperand::use):

11:52 Changeset [91279] by cevans@google.com
  • 1 edit
    3 deletes in branches/chromium/782

Revert 91274 - Merge 91148
BUG=89552
Review URL: http://codereview.chromium.org/7443008

11:51 Changeset [91278] by aroben@apple.com
  • 5 edits
    2 adds in trunk/Tools

Make TestFailures show existing bugs and a new bug link for flaky tests

Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
flaky tests
and
<http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
tests, but should

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:

Added. This is what's used to file new bugs about flaky tests.
(FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
title, description, and URL.

(FlakyTestBugForm.prototype._createBugDescription):
(FlakyTestBugForm.prototype._createBugTitle):
These do what they say.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:

Added. Tests of the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
(#possibly-flaky-tests > li > :first-child):
(.flakiness-examples-list):
Styling to account for the new elements.

(.expandable):
(.expanded > .expandable):
Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
transition properties because we can't transition to/from 'auto' (but really would like
to!).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
(ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
argument instead of creating one ourselves.
(ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
an argument instead of just the number of analyzed builds. Put the examples list inside a
container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
with animating the height of the examples list; we don't do this anymore because it's hard
to make it work correctly with the asynchronous loading of existing bugs. When we populate
the examples list, also set up the new/existing bug UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

FlakyTestBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pull in FlakyTestBugForm and its tests.

11:40 Changeset [91277] by robert@webkit.org
  • 3 edits
    3 adds in trunk

REGRESSION: Incorrect layout at recline-online.com
https://bugs.webkit.org/show_bug.cgi?id=64030

Reviewed by David Hyatt.

Source/WebCore:

http://trac.webkit.org/changeset/68362 dropped the check for cases
where the render box is floating or inline. When the box is left or right
aligned it is considered to be floating and needs to its margins set appropriately.

Test: fast/table/align-right-within-left-aligned-div.html

created by Dominic Cooney <dominicc@chromium.org>

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeInlineDirectionMargins):

LayoutTests:

  • fast/table/align-right-within-left-aligned-div-expected.png: Added.
  • fast/table/align-right-within-left-aligned-div-expected.txt: Added.
  • fast/table/align-right-within-left-aligned-div.html: Added.
11:36 Changeset [91276] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91270
BUG=89678
Review URL: http://codereview.chromium.org/7446011

11:33 Changeset [91275] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 backend broken, lacks 3 parameter rshift32 method
https://bugs.webkit.org/show_bug.cgi?id=64571

Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method.

11:33 Changeset [91274] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/782

Merge 91148
BUG=89552
Review URL: http://codereview.chromium.org/7446010

11:21 Changeset [91273] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Tony Chang.

Added "missing results" label for tests that are missing results.

buildbot Now reports shows a label "X missing results" on a run when X tests were missing
expected results on that run.

Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:11 Changeset [91272] by aroben@apple.com
  • 5 edits
    3 adds in trunk/Tools

Extract some of FailingTestsBugForm's code into a base class

Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
file bugs about flaky tests

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
TestRelatedBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:

Moved some tests to TestRelatedBugForm_unittests.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.

(TestRelatedBugForm):
(TestRelatedBugForm.prototype.domElement):
(TestRelatedBugForm.prototype._computeOperatingSystem):
(TestRelatedBugForm.prototype._computePlatform):
Code came from FailingTestsBugForm.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:

Added. Tests came from FailingTestsBugForm_unittests.js

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:

Added. Code came from FailingTestsBugForm.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
need to be pulled in early for parsing reasons.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Pull in TestRelatedBugForm and tests and WebKitBugzilla.

10:40 Changeset [91271] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Add back a change that was accidentally removed in r91266.

Make sure to retain the WKPasteboardFilePromiseOwner before calling draggedImage because draggedImage releases
its responder. Also make the comment more explicit, to keep this mistake from being made in the future.

Rubber-stamped by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::dragEnded):

10:39 Changeset [91270] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash when removing unrenderered nodes in replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):

LayoutTests: Tests that we do not crash when removing unrendering nodes
in a replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.
10:26 Changeset [91269] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

2011-07-19 Rob Buis <rbuis@rim.com>

https://bugs.webkit.org/show_bug.cgi?id=64673
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html

Reviewed by Nikolas Zimmermann.

Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.

Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg

  • svg/SVGTRefElement.cpp: (WebCore::SubtreeModificationEventListener::handleEvent):
10:22 Changeset [91268] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

use more specific types in CSSFlexValue
https://bugs.webkit.org/show_bug.cgi?id=64763

Reviewed by Ojan Vafai.

No new tests because no change in functionality.

  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::create):
(WebCore::CSSFlexValue::isFlexValue): Make it possible to tell if

we're a flex value or not. Will be needed when we're copying
values to RenderStyle.

(WebCore::CSSFlexValue::positiveFlex): Use floats for positive and

negative flex because in the render code, we use floats.

(WebCore::CSSFlexValue::negativeFlex): Add accessors for these since

we'll need it when reading the flex values.

(WebCore::CSSFlexValue::preferredSize):
(WebCore::CSSFlexValue::CSSFlexValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive): Make the type more

specific.

(WebCore::CSSParser::parseFlex):

  • css/CSSParser.h:
  • css/CSSValue.h:

(WebCore::CSSValue::isFlexValue):

10:22 Changeset [91267] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

If the control associated with a <label> is hidden, the label is also hidden (incorrectly)
https://bugs.webkit.org/show_bug.cgi?id=64752

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/label-element-with-hidden-control.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

  • platform/mac/accessibility/label-element-with-hidden-control-expected.txt: Added.
  • platform/mac/accessibility/label-element-with-hidden-control.html: Added.
10:14 Changeset [91266] by bweinstein@apple.com
  • 7 edits in trunk/Source/WebKit2

Speculative fix for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Enrica Casucci.

I was unable to reproduce this bug, but Darin Adler and I discussed the probable issue. When starting the drag, we create
a WKPasteboardFilePromiseOwner, and a WKPasteboardOwner. When the drag is concluded, we call a method on the WKPasteboardFilePromiseOwner
which uses the WKPasteboardOwner. However, we are not guaranteeing that the WKPasteboardOwner will be around when the
WKPasteboardFilePromiseOwner method is called.

The fix is to retain both the WKPasteboardFilePromiseOwner and the WKPasteboardOwner that we need, making sure that we are keeping
both objects alive.

This patch also uses r91222 to replace WebPage::platformDragEnded, so WebPage doesn't need to know about the drag source.

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::dragEnded): Add a non-Mac stub method, since the Mac is the only platform that does something here.

  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Use member variables instead of local variables.
(WebKit::WebDragClient::dragEnded): Move code from WebPageMac::platformDragEnded to here, and clear both member variables.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dragEnded): Don't call platformDragEnded anymore. WebCore::DragController::dragEnded calls WebDragClient::dragEnded,

which does the same thing.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm: Remove platformDragEnded.
10:08 Changeset [91265] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove failing Chromium test expectations after r91224.

  • platform/chromium/test_expectations.txt:
09:38 Changeset [91264] by vsevik@chromium.org
  • 18 edits in trunk

Web Inspector: Backend should provide network resource identifiers that are unique across navigation.
https://bugs.webkit.org/show_bug.cgi?id=64746

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::createIdentifier):
(WebCore::IdentifiersFactory::resourceId):
(WebCore::IdentifiersFactory::addProcessIdPrefixTo):

  • inspector/IdentifiersFactory.h:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForResourceId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::resourceId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:

LayoutTests:

  • inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
09:36 Changeset [91263] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix assertion failure seen in plugins/return-npobject.html on Windows XP Debug bots.

Rubber-stamped by Adam Roben.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveData):
It is possible for a subclass to cancel the load from within didReceiveData, which would
set m_documentLoader to 0.
Remove the assertion I added that the DocumentLoader's frame is non-null.

09:28 Changeset [91262] by weinig@apple.com
  • 2 edits in trunk/Tools

Remove obsolete Mac NRWT test bots
https://bugs.webkit.org/show_bug.cgi?id=64806

Reviewed by Adam Roben.

Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
which have been disconnected for some time and have been obsoleted by
the main testers using NRWT.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
09:13 Changeset [91261] by weinig@apple.com
  • 3 edits in trunk/Tools

webkit-patch rebaseline crashes on use
https://bugs.webkit.org/show_bug.cgi?id=64775

Reviewed by Adam Roben.

Fix incorrectly spelled attribute name.

  • Scripts/webkitpy/common/net/layouttestresults.py:

The attribute is test_name, not filename.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

Add test for tests_matching_failure_types.

08:56 Changeset [91260] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
https://bugs.webkit.org/show_bug.cgi?id=64730

Reviewed by Alexey Proskuryakov.

Covered by existing tests.

  • bridge/jni/v8/JNIUtilityPrivate.cpp:

(JSC::Bindings::jvalueToJavaValue):

08:55 Changeset [91259] by rniwa@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[chromium] rebaseline Chromium results after r91249 .
Unreviewed.

Patch by Jeremy Moskovich <jeremy@chromium.org> on 2011-07-19

  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Added.
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
08:51 Changeset [91258] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: add sanity test for shared worker inspector
https://bugs.webkit.org/show_bug.cgi?id=64799

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testSharedWorker):
(.TestSuite.prototype.evaluateInConsole_):

08:46 Changeset [91257] by weinig@apple.com
  • 1 edit
    10 copies
    4 adds in trunk/LayoutTests

Check in Leopard specific results for Selectors 3 tests.

  • platform/mac-leopard/css3/selectors3: Added.
  • platform/mac-leopard/css3/selectors3/html: Added.
  • platform/mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml: Added.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml: Added.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
08:29 Changeset [91256] by vitalyr@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-19 Vitaly Repeshko <vitalyr@chromium.org>

[V8] Don't put CSSRuleLists in object groups.
https://bugs.webkit.org/show_bug.cgi?id=64798

Reviewed by Pavel Feldman.

Retention of CSSRuleLists should be implemented using hidden
references from holder objects. By putting lists in groups we
artificially extend their lifetimes much more than necessary.

  • bindings/v8/V8GCController.cpp: (WebCore::GrouperVisitor::visitDOMWrapper):
08:28 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
08:26 Changeset [91255] by gyuyoung.kim@samsung.com
  • 9 edits
    1 copy
    1 add in trunk

[EFL] Add ewk_network.cpp|h files.
https://bugs.webkit.org/show_bug.cgi?id=63315

Source/WebCore:

Enable setOnLine(bool) on EFL port as well as Android and Chromium.

Reviewed by Antonio Gomes.

  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:

Source/WebKit/efl:

ewk_network.cpp|h files are added to ewk in order to support APIs related to networking.
In addition, ewk_network_state_notifier_online_set() is added to ewk_network.cpp in order
to notify NetworkStateNotifier of network status.

Reviewed by Antonio Gomes.

  • CMakeListsEfl.txt:
  • ewk/EWebKit.h:
  • ewk/ewk_network.cpp: Added.

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
(ewk_network_state_notifier_online_set):

  • ewk/ewk_network.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
08:25 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
07:58 Changeset [91254] by jeremy@chromium.org
  • 4 edits
    1 copy in branches/chromium/782

Merge 91249 - Fix microphone icon placement in speech input control for dir=rtl.
https://bugs.webkit.org/show_bug.cgi?id=64668

Reviewed by Dimitri Glazkov.

Source/WebCore:

Modify default stylesheet to propagate dir=rtl from the outer input
control to the shadow DOM container. This makes the microphone
icon appear on the left for dir=rtl, which is the desired behavior.

Test: fast/speech/speech-bidi-rendering.html

  • css/html.css:

(input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):

LayoutTests:

Added test that verifies placement of microphone icon for dir=rtl.

  • fast/speech/speech-bidi-rendering.html: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.

TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/7432005

07:49 Changeset [91253] by kov@webkit.org
  • 5 edits in trunk/Source/WebKit/gtk

[GTK] Google Calendar thinks we're mobile
https://bugs.webkit.org/show_bug.cgi?id=63994

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-07-11
Reviewed by Xan Lopez.

Further special-case Google Calendar, for it thinks WebKit+Linux
means mobile, so we also have to spoof the OS.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
private API that centralizes the logic now.

  • tests/testwebsettings.c: Add tests to make sure the Google

special-cases only apply for the expected domains and when quirks
special-casing is enabled.
(test_non_quirky_user_agents):
(test_webkit_web_settings_user_agent):

  • webkit/webkitwebsettings.cpp:

(webkitUserAgent): make it static.
(safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
(initializeDomainsList): moved from FrameLoaderClientGtk.
(isGoogleDomain):ditto.
(isGoogleCalendar): ditto.
(userAgentForURL): ditto.
(webkitWebSettingsUserAgentForUri): centralize the whole
user agent spoofing logic in this new private API that can be used
by the browser to know what's going to happen for a specific URI
and also allows our API testing.

  • webkit/webkitwebsettingsprivate.h:
06:45 Changeset [91252] by loislo@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: implement import/export for timeline data.
https://bugs.webkit.org/show_bug.cgi?id=64601

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-load.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::contextMenuItemSelected):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createFileSelector):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._exportToFile):
(WebInspector.TimelinePanel.prototype._importFromFile):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._importNextChunk):
(WebInspector.TimelineModel.prototype._importFromFile):
(WebInspector.TimelineModel.prototype._importFromFile.onError):
(WebInspector.TimelineModel.prototype._exportToFile):
(WebInspector.TimelineModel.prototype._reset):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/timeline/timeline-load-expected.txt: Added.
  • inspector/timeline/timeline-load.html: Added.
06:11 Changeset [91251] by loki@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add missing expected file after r91191

  • platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
06:02 Changeset [91250] by vsevik@chromium.org
  • 15 edits
    2 adds in trunk/Source

Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static.
https://bugs.webkit.org/show_bug.cgi?id=64729

Reviewed by Pavel Feldman.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/IdentifiersFactory.cpp: Added.

(WebCore::IdentifiersFactory::createIdentifier):

  • inspector/IdentifiersFactory.h: Added.

(WebCore::IdentifiersFactory::setProcessId):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setProcessId):

  • inspector/InspectorController.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):

  • inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::setAgentIdentifierPrefix):
(WebKit::WebDevToolsAgentImpl::setProcessId):

  • src/WebDevToolsAgentImpl.h:
05:22 Changeset [91249] by jeremy@chromium.org
  • 4 edits
    4 adds in trunk

Fix microphone icon placement in speech input control for dir=rtl.
https://bugs.webkit.org/show_bug.cgi?id=64668

Reviewed by Dimitri Glazkov.

Source/WebCore:

Modify default stylesheet to propagate dir=rtl from the outer input
control to the shadow DOM container. This makes the microphone
icon appear on the left for dir=rtl, which is the desired behavior.

Test: fast/speech/speech-bidi-rendering.html

  • css/html.css:

(input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):

LayoutTests:

Added test that verifies placement of microphone icon for dir=rtl.

  • fast/speech/speech-bidi-rendering.html: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.
04:06 Changeset [91248] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=64690

Make the API usable with QML by declaring what's needed
with the macros.

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/qdesktopwebview.h:
03:24 Changeset [91247] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Account for the invalid pointer case in WebCore::screenRect()
https://bugs.webkit.org/show_bug.cgi?id=64543

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-19
Reviewed by Antonio Gomes.

Fix a regression introduced in r88245: it assumes the pointer passed
to screenRect() is always valid.
fast/frames/crash-removed-iframe.html proves this is not always true,
so we need to do some sanity check on the pointer before using it.
No new tests as this has been caught by the current test suite.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):

02:51 Changeset [91246] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Edit Chromium test expectation for http/tests/websocket/tests/hybi/reserved-opcodes.html.

  • platform/chromium/test_expectations.txt:
02:25 Changeset [91245] by eric@webkit.org
  • 16 edits in trunk/Tools

new-run-webkit-tests should support --leaks
https://bugs.webkit.org/show_bug.cgi?id=63832

Reviewed by Dirk Pranke.

This may not be sufficient to actually transition over the leaks bot,
but this is a huge step in the right direction.

I had to make parse-malloc-history understand being passed more than
one file (to avoid the silly cat | nonsense in old-run-webkit-tests).

I removed some dead code relating to previous iterations of our crash detection.

I created a new class "LeakDetector" to encapsulate all this logic.
Eventually we should consider pulling that class out of mac.py and
sharing with other ports. However given that ORWT has had
--leaks support on Mac for almost 7 years and no other port has added
it, leaves me to believe we're in no rush to move LeakDetector.

I've tested --leaks locally. I suspect there are more bugs to shake out
but it seems to work well enough to start.

I also added support for --guard-malloc, but have not tested it much. It
should be viewed as experimental at this time.

I also fixed various os.path uses to self._filesystem as I was reading
through the various files to understand how best to fix this bug.

  • Scripts/old-run-webkit-tests:

(parseLeaksandPrintUniqueLeaks):

  • Scripts/parse-malloc-history:

(main):

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
02:21 Changeset [91244] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-07-19
Reviewed by Antonio Gomes.

ScrollBar should initialize current position in constructor.
https://bugs.webkit.org/show_bug.cgi?id=39284

When ScrollBar is created, m_currentPos should be initialized to
m_scrollableArea's current scrollPosition. Because scrollbars may
be created after the content of m_scrollableArea has been scrolled.

Source/WebCore:

Test: scrollbars/scrollbar-initial-position.html

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):

LayoutTests:

  • scrollbars/scrollbar-initial-position-expected.png: Added.
  • scrollbars/scrollbar-initial-position-expected.txt: Added.
  • scrollbars/scrollbar-initial-position.html: Added.
01:57 Changeset [91243] by yutak@chromium.org
  • 11 edits
    7 copies
    23 adds in trunk

WebSocket: Implement hybi framing
https://bugs.webkit.org/show_bug.cgi?id=64522

Reviewed by Kent Tamura.

Source/WebCore:

Implement WebSocket framing protocol which is mainly described in
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4> and
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-6>.

Hybi protocol introduces a new frame format which is drastically different from
the old one. Notable differences are:

  • Binary data support.
  • Fragmentation support: a single message can be fragmented to multiple frames.
  • Ping-pong support.
  • Masking: frame content of a client must be masked to prevent cross-protocol attacks.

This patch covers the following features:

  • Send a pong frame when a ping frame is received.
  • Receive fragmented frames.
  • Receive masked frames. (Servers do not have to mask frames, but they may if they wish.)

The following features are NOT implemented yet:

  • Send or receive binary messages.
  • Send a ping message.
  • Send fragmented frames. (It is unclear whether this is necessary.)
  • Rewrite the frame content by WebSocket protocol extensions (like frame compression).

New tests: http/tests/websocket/tests/hybi/broken-utf8.html

http/tests/websocket/tests/hybi/fragmented-control-frame.html
http/tests/websocket/tests/hybi/fragmented-frames.html
http/tests/websocket/tests/hybi/interleaved-fragments.html
http/tests/websocket/tests/hybi/long-control-frame.html
http/tests/websocket/tests/hybi/masked-frames.html
http/tests/websocket/tests/hybi/pong.html
http/tests/websocket/tests/hybi/reserved-bits.html
http/tests/websocket/tests/hybi/reserved-opcodes.html
http/tests/websocket/tests/hybi/too-long-payload.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
The original content of send() was moved to a private method sendFrameHixie76().
(WebCore::WebSocketChannel::fail):
Stop handling incoming data after the WebSocket connection is failed.
It was unclear to me whether we should do the same thing for hixie-76 connection;
for now, I kept the original behavior.
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):
(WebCore::WebSocketChannel::sendFrame):
(WebCore::WebSocketChannel::sendFrameHixie76):

  • websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

LayoutTests:

Fix existing tests so they match the new frame format, and add tests for the new frame types
and error conditions related to the new frame format.

Unskip hybi tests on mac, win and chromium. Other ports (wk2, qt and gtk) still skip these tests
because they do not support changing the value of "WebKitHixie76WebSocketProtocolEnabled"
preference key via layoutTestController.overridePreferences() yet.

  • http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Added.
  • http/tests/websocket/tests/hybi/broken-utf8.html: Added.
  • http/tests/websocket/tests/hybi/broken-utf8_wsh.py: Added.
  • http/tests/websocket/tests/hybi/client-close-expected.txt:
  • http/tests/websocket/tests/hybi/client-close.html:

The format of a close frame has been changed. Currently, we do not include any payload
in a close frame, thus it must start with "\x88\x80" (see section 4.1 of hybi-10
specification for more details).

  • http/tests/websocket/tests/hybi/client-close_wsh.py:
  • http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/fragmented-control-frame_wsh.py: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames.html: Added.
  • http/tests/websocket/tests/hybi/fragmented-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments.html: Added.
  • http/tests/websocket/tests/hybi/interleaved-fragments_wsh.py: Added.
  • http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/long-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/long-control-frame_wsh.py: Added.
  • http/tests/websocket/tests/hybi/masked-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/masked-frames.html: Added.
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/pong-expected.txt: Added.
  • http/tests/websocket/tests/hybi/pong.html: Added.
  • http/tests/websocket/tests/hybi/pong_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reserved-bits.html: Added.
  • http/tests/websocket/tests/hybi/reserved-bits_wsh.py: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes.html: Added.
  • http/tests/websocket/tests/hybi/reserved-opcodes_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send2_wsh.py:

Send two text frames at once.

  • http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/too-long-payload.html: Added.
  • http/tests/websocket/tests/hybi/too-long-payload_wsh.py: Added.
  • platform/chromium/test_expectations.txt:

Derive test expectations of hixie76 tests, because these tests are likely to behave
the same way as hixie76 tests. Will be checked later whether they really do.

  • platform/mac/Skipped:
  • platform/win/Skipped:
01:12 Changeset [91242] by zimmermann@webkit.org
  • 6 edits
    3 adds in trunk

2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
https://bugs.webkit.org/show_bug.cgi?id=64059

REGRESSION (r88913): <object> has wrong computed height
https://bugs.webkit.org/show_bug.cgi?id=62769

Reviewed by Rob Buis.

Add new layout test in fast/css covering both bugs.
Update svg/zoom/page results (this is a progression, but the test itself remains broken, see comment inline).

  • fast/css/replaced-element-implicit-size.html: Added.
  • platform/mac/fast/css/replaced-element-implicit-size-expected.png: Added.
  • platform/mac/fast/css/replaced-element-implicit-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt:

2011-07-19 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
https://bugs.webkit.org/show_bug.cgi?id=64059

REGRESSION (r88913): <object> has wrong computed height
https://bugs.webkit.org/show_bug.cgi?id=62769

Reviewed by Rob Buis.

Fix misinterpretation of CSS 2.1 - "10.5 Content height: the 'height' property".
It says "If the height of the containing block is not specified explicitelz (i.e. it depends on the
content height), and this element is not absolutely positioned, the value computes to 'auto'".

Checking whether the containing block height depends on the content height is not equal to checking
whether the height property is set on the containing block, there are other ways to implicitly specify
the height by setting top & bottom. Fix that by checking whether the containing block has a height
property or top & bottom set.

While I was at it, make computeReplacedLogicalWidth/Height a bit more explicit to make it easier to compare
the code with the spec quoatations - this doesn't change the functionality only the readability.


Test: fast/css/replaced-element-implicit-size.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): Cleanup comment, make code more explicit. (WebCore::RenderReplaced::logicalHeightIsAuto): Add helper method used by computeReplacedLogicalHeight. (WebCore::RenderReplaced::computeReplacedLogicalHeight): Fix height=auto detection.
  • rendering/RenderReplaced.h:
00:38 Changeset [91241] by abarth@webkit.org
  • 8 edits in trunk/Tools

garden-o-matic should have a "Triage Failures" button for iterating over failures
https://bugs.webkit.org/show_bug.cgi?id=64769

Reviewed by Eric Seidel.

This patch adds some global static state and refactors things a bit so
that we can iterate over all the failures in the details pane.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
    • Add a generic callback iterator to iterate through a series of callbacks. We use this to iterate through the failures we want to display the details of.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add a toolbar for the results summary and change the buttons to be real buttons.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • Make the detail pane 75% of the window.
    • Make the buttons pretty.
    • Allow the failure type badges to apply to the details pane as well.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Restructure how we bring up the details pane so we can iterate through a bunch of failures.
    • Remove the transition between results details because it's annoying when you want to click through a bunch of failures.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • Add some more structure to the title bar for the results details so it's clearer which results we're currently displaying.
00:37 Changeset [91240] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic should live update as conditions change on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=64646

Reviewed by Eric Seidel.

This patch causes the garden-o-matic display to update every 10 minutes
to show the latest failures. This patch required a moderately large
refactoring of main.js to make the display incremental instead of
all-at-once.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

07/18/11:

22:33 Changeset [91239] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Solar Walk app-specific hack accidentally strips stylesheets from the document.
https://bugs.webkit.org/show_bug.cgi?id=64777

Reviewed by Adam Barth.

Solar Walk uses a self-closed title tag in its documents ("<title />").
The HTML5 parser does not recognize this as a valid self-closing tag,
so it treats the remainder of the document as title text.

We work around this in WebKit by injecting a script that calls
document.write() on the contents of document.title, thereby restoring
the contents of the document. Unfortunately this overwrote several
<style> tags that existed before the <title>, thereby causing the
document to not have the intended styling.

Fix this by having the injected script concatenate document.title to
the document instead of overwriting it during document.write(). We can
also take the opportunity to remove document.title since it does not
contain useful information.

  • Misc/SolarWalkQuirksUserScript.js:
22:04 Changeset [91238] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
21:14 Changeset [91237] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Add a runtime check for font cascading optimization.

It's a constant value in Mac port so hopefully gcc will constant-propagate the value
and eliminate the function altogether.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::canSetCascadeListForCustomFont): Added.
(WebCore::FontPlatformData::ctFont):

21:03 Changeset [91236] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update after r91229.

  • platform/chromium/test_expectations.txt:
19:55 Changeset [91235] by morrita@google.com
  • 23 edits
    2 adds in trunk

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

  • Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
  • Updated the set on inclusion list changes.
  • Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

  • Renamed NodeRenderingContext::m_contentElement to m_includer
  • ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

  • dom/ShadowContentElement.cpp:

(WebCore::removeFromSet):
(WebCore::addToSet):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Added a new test.
  • Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.
  • fast/dom/shadow/content-element-includer-expected.txt: Added.
  • fast/dom/shadow/content-element-includer.html: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
19:42 Changeset [91234] by barraclough@apple.com
  • 13 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-18

  • platform/chromium/test_expectations.txt:
19:25 Changeset [91233] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Tab Atkins is not in committers.py (as a non-committer)
https://bugs.webkit.org/show_bug.cgi?id=64770

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
19:21 Changeset [91232] by dino@apple.com
  • 20 edits in trunk/Source

2011-07-18 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=64742
Expose WebPreferences for media playback requiring user gestures and inline playback

Reviewed by Simon Fraser.

Media playback already tested if it should require user gestures, but
no setting was ever exposed to clients. Also, some ports only allow media
playback to be fullscreen, so exposing a new setting for them.

Two new WebPreferences: MediaPlaybackRequiresUserGesture and
MediaPlaybackAllowsInline.

WebCore:

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Examine the new Setting for user gestures.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Two new settings. (WebCore::Settings::setMediaPlaybackRequiresUserGesture): (WebCore::Settings::mediaPlaybackRequiresUserGesture): (WebCore::Settings::setMediaPlaybackAllowsInline): (WebCore::Settings::mediaPlaybackAllowsInline):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences mediaPlaybackRequiresUserGesture]): (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): (-[WebPreferences mediaPlaybackAllowsInline]): (-[WebPreferences setMediaPlaybackAllowsInline:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setMediaPlaybackRequiresUserGesture): (WebPreferences::mediaPlaybackRequiresUserGesture): (WebPreferences::setMediaPlaybackAllowsInline): (WebPreferences::mediaPlaybackAllowsInline):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMediaPlaybackRequiresUserGesture): (WKPreferencesGetMediaPlaybackRequiresUserGesture): (WKPreferencesSetMediaPlaybackAllowsInline): (WKPreferencesGetMediaPlaybackAllowsInline):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
18:42 Changeset [91231] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r91229.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont):

18:25 Changeset [91230] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [91229] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=64767

Reviewed by Sam Weinig.

  • platform/graphics/Font.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Undo the cascade list optimization on Leopard for custom
fonts, because adding a cascade list apparently breaks the font.

17:54 Changeset [91228] by mdelaney@apple.com
  • 9 edits in trunk/Source/WebCore

Remove drawsUsingCopy now that all ports handle the copying
https://bugs.webkit.org/show_bug.cgi?id=64768

Introduced in https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy
was used to know whether or not an ImageBuffer should be explicitly copied before being
painted into a context (as was used in HTMLCanvasElement::paint). All platforms now
handle the logic of copying or not in their ImageBuffer::draw() implementations, so
drawsUsingCopy() is no longer needed. This patch removes it.

Reviewed by Dan Bernstein.

No new tests; does not affect behavior.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::isAccelerated):

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
17:39 Changeset [91227] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated event is dispatched on NetworkPanel.
https://bugs.webkit.org/show_bug.cgi?id=64748

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

17:36 Changeset [91226] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize strict equality as effectively as the old JIT does.
https://bugs.webkit.org/show_bug.cgi?id=64759

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

This adds a more complete set of strict equality optimizations. If either
operand is known numeric, then the code reverts to the old style of optimizing
(first try integer comparison). Otherwise it uses the old JIT's trick of
first simultaneously checking if both operands are either numbers or cells;
if not then a fast path is taken.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:26 Changeset [91225] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=64760
DFG JIT - Should be able to compile program code.

Reviewed by Geoff Garen.

Add support for op_end, hooks to compile program code in Executable.cpp.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • Add support for op_end
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • Added, separate out steps of compileFunction.

(JSC::DFG::JITCompiler::compile):

  • Added, compile program code.

(JSC::DFG::JITCompiler::compileFunction):

  • Sections separated out to helper functions.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • Added m_exceptionCheckCount.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

  • Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.
17:25 Changeset [91224] by barraclough@apple.com
  • 8 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to the global object,
also, to toLocaleString should be calling the ToObject & invoking the object's toString
function, even for values that are already strings.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

LayoutTests:

  • fast/js/resources/js-test-pre.js:
    • Updated harness to not call Object.prototype.toString on undefined.
  • fast/js/eval-var-decl-expected.txt:
  • fast/js/object-prototype-properties-expected.txt: Added.
  • fast/js/object-prototype-properties.html: Added.
  • fast/js/object-prototype-toLocaleString-expected.txt
  • fast/js/script-tests/eval-var-decl.js:
    • Fix test case, calling hasProperty with undefined as the this value should throw.
  • fast/js/script-tests/object-prototype-properties.js: Added.
    • Place for test cases for Object.prototype properties; to being with, check that calling these methods on undefined throws!
  • fast/js/script-tests/object-prototype-toLocaleString.js:
    • Added test cases for correct behaviour when this is a string primitive.
  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
    • These test cases are all incorrect. (See https://bugs.ecmascript.org/show_bug.cgi?id=117). We were incorrectly passing 15.5.4.11_String.prototype.replace, this should fail, as the others do. All the other 15.5.4 tests were failing & are still failing, but now have a better error message. S11.1.1_A2 is also invalid, calling toString() passing undefined as this should throw.
17:20 Changeset [91223] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a typo.

  • platform/chromium/test_expectations.txt:
17:14 Changeset [91222] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebCore

Prep work for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Darin Adler.

Add a DragClient function that is called when a drag is ended, and call it from DragController::dragEnded.
This isn't used yet, but will be used by WebKit2 on Mac.

This patch also cleans up style in DragClient.h.

No change in behavior, no tests needed.

  • page/DragClient.h:

(WebCore::DragClient::dragEnded): Stub virtual implementation for now, this will be used by

WebKit2 on Mac.

  • page/DragController.cpp:

(WebCore::DragController::dragEnded): Call DragClient::dragEnded.

16:59 Changeset [91221] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add Chromium failing expectations for some font tests; failures are tracked by the bug 64767.

  • platform/chromium/test_expectations.txt:
16:19 Changeset [91220] by ojan@chromium.org
  • 2 edits in trunk/Tools

Load ToT chromium bots by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64756

Reviewed by Adam Barth.

For now, these are the most useful bots to look at. Eventually,
we may want to load the build.webkit.org bots by default once
most of the bots there upload results.

  • TestResultServer/static-dashboards/dashboard_base.js:
16:16 Changeset [91219] by jhoneycutt@apple.com
  • 15 edits
    2 adds in trunk

Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
16:11 BuildingGtk edited by levin@chromium.org
Fix formatting of recent change. (diff)
15:55 Changeset [91218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC lazy sweep does not inline the common cases of cell destruction.
https://bugs.webkit.org/show_bug.cgi?id=64745

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This inlines the case of JSFinalObject destruction.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::lazySweep):

15:49 Changeset [91217] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Add regression tests for legacy color parsing of valid CSS colors
https://bugs.webkit.org/show_bug.cgi?id=64576

Patch by Tab Atkins <jackalmage@gmail.com> on 2011-07-18
Reviewed by Simon Fraser.

  • fast/dom/attribute-legacy-colors-expected.txt:
  • fast/dom/script-tests/attribute-legacy-colors.js:
15:42 Changeset [91216] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build-fix

15:36 Changeset [91215] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Unreviewed. Just updating unit test results after bug 64751.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
15:27 Changeset [91214] by abarth@webkit.org
  • 5 edits in trunk/Tools

simplejson has trouble on chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=64757

Reviewed by Eric Seidel.

Use the native JSON, if available.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
14:59 Changeset [91213] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18

  • DEPS:
14:51 Changeset [91212] by ojan@chromium.org
  • 5 edits in trunk/Tools

update the flakiness dashboard to understand the new platforms/formats in test_expectations
https://bugs.webkit.org/show_bug.cgi?id=64743

Reviewed by Adam Barth.

The test expectations format changed a long time ago and the flakiness dashboard
was never updated to match.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
14:33 BuildingQtOnLinux edited by phihag@phihag.de
Outdated Mesa (when compiling on debian stable or other old distros) (diff)
14:27 Changeset [91211] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[SVG] [Chromium]: painting-control-04-f.svg and zero-path-square-cap-rendering.svg are failing
https://bugs.webkit.org/show_bug.cgi?id=64675

Rebaseline painting-control-04-f.svg since r91191 fixed it.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91210] by commit-queue@webkit.org
  • 37 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
https://bugs.webkit.org/show_bug.cgi?id=64751

Reviewed by Adam Barth.

Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
is a step that we run for most commands (as one of the earliest steps).
EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
the CWD to the checkout root. This magically made a bunch of otherwise
wrong code work.

When I realized that apply-attachment no longer worked as expected today,
I went and fixed the bug, then realizing that we were not testing
what the cwd was when running various commands. I fixed our MockExecutive
to always log what the cwd is and fixed a whole bunch of places
where we needed to be setting the cwd.

Hopefully this will solve our cwd problems once and for-all, and webkit-patch
will again correctly work when called from any directory (including outside
of a webkit checkout).

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/update.py:
14:10 Changeset [91209] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Specify a cascade list consisting of the last resort font for Core Text
https://bugs.webkit.org/show_bug.cgi?id=64747

Reviewed by Sam Weinig.

No new tests, because this does not affect behavior.

This prevents Core Text from taking its default, longer fallback list when the primary font does
not include a character. This is OK to do because WebKit never uses the results of Core Text
fallback anyway.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::cascadeToLastResortFontDescriptor): Added. Returns a CTFontDescriptor with a cascade
list consisting of the last resort font.
(WebCore::FontPlatformData::ctFont): Changed to include the cascadeToLastResortFontDescriptor
in the returned font.

14:04 Changeset [91208] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize equal-null comparisons and branches.
https://bugs.webkit.org/show_bug.cgi?id=64659

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

Added a peephole-aware compare-to-null implementation to JITCodeGenerator,
which is used by both the speculative and non-speculative JIT. Through
the use of the new isNullConstant helper, the two JITs invoke the
nonSpecualtiveCompareNull() helper instead of their regular comparison
helpers when compiling CompareEq. Through the use of the new isKnownCell
helper, the compare-null code will skip the is-a-cell check if the
speculative JIT had been speculating cell.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isNullConstant):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

13:56 Changeset [91207] by ctguil@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 90599 - Work around Skia PDF's lack of inverted path support.
https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7398032

13:38 Changeset [91206] by commit-queue@webkit.org
  • 30 edits in trunk/Source

Timer scheduling should be based off the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64544

Patch by James Robinson <jamesr@chromium.org> on 2011-07-18
Reviewed by Darin Adler.

Source/JavaScriptCore:

Switches ThreadCondition::timedWait and related utility functions from currentTime() to
monotonicallyIncreasingTime().

Add WTF::monotonicallyIncreasingTime() to list of exported functions so it can be accessed from WebCore/WebKit.

(WTF::ThreadCondition::timedWait):

  • wtf/ThreadingWin.cpp:

(WTF::absoluteTimeToWaitTimeoutInterval):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::ThreadCondition::timedWait):

  • wtf/qt/ThreadingQt.cpp:

(WTF::ThreadCondition::timedWait):

Source/WebCore:

Changes the Timer scheduling logic from using absolute values in terms of currentTime() to using relative
intervals in terms of monotonicallyIncreasingTime(). This provides better standards compliance, compatibility,
and predictability when the system clock is adjusted.

No automated tests since there is no way to modify the system clock from DRT.

  • platform/SharedTimer.h:

(WebCore::MainThreadSharedTimer::setFireInterval):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/Timer.cpp:

(WebCore::TimerBase::start):
(WebCore::TimerBase::nextFireInterval):

  • platform/android/SharedTimerAndroid.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/brew/SharedTimerBrew.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/efl/SharedTimerEfl.cpp:

(WebCore::addNewTimer):
(WebCore::setSharedTimerFireInterval):

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/haiku/SharedTimerHaiku.cpp:

(WebCore::SharedTimerHaiku::start):
(WebCore::setSharedTimerFireInterval):

  • platform/mac/SharedTimerMac.mm:

(WebCore::setSharedTimerFireInterval):

  • platform/qt/SharedTimerQt.cpp:

(WebCore::SharedTimerQt::start):
(WebCore::setSharedTimerFireInterval):

  • platform/win/SharedTimerWin.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wince/SharedTimerWinCE.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wx/SharedTimerWx.cpp:

(WebCore::setSharedTimerFireInterval):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerSharedTimer::setFireInterval):

Source/WebKit/chromium:

Renames setSharedTimerFireTime to setSharedTimerFireInterval to be consistent with WebCore.

  • public/WebKitClient.h:

(WebKit::WebKitClient::setSharedTimerFireInterval):

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::setSharedTimerFireInterval):

Source/WebKit2:

Converts the WebKit2 RunLoop and CoreIPC timeouts to use monotonicallyIncreasingTime().

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/RunLoop.h:
13:36 Changeset [91205] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Patch by Yuzhu Shen <yzshen@chromium.com> on 2011-07-18
Reviewed by James Robinson.

[chromium] WebFontImpl::drawText needs to handle the canvasIsOpaque input.
https://bugs.webkit.org/show_bug.cgi?id=64555

This change handles canvasIsOpaque for the WEBKIT_USING_SKIA case.

  • src/WebFontImpl.cpp: handled canvasIsOpaque.
  • src/WebFontImpl.h: added method declaration.
13:20 Changeset [91204] by gavinp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/html

Merge 89719 BUG=80729

13:16 Changeset [91203] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update baseline. rbuis says this is an improvement.

  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
12:31 Changeset [91202] by tony@chromium.org
  • 2 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

[chromium] Move a Linux specific test into chromium-linux and rebaseline
https://bugs.webkit.org/show_bug.cgi?id=64632

Reviewed by Ojan Vafai.

Rebaselining per the comment in test_expectations.txt.

  • platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:20 Changeset [91201] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Windows build. Move static function defaultSessionCookieStorage() to before
its use in defaultCookieStorage().

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):

11:59 BuildingGtk edited by levin@chromium.org
Add info about fixing libjpeg error using mac ports. (diff)
11:55 Changeset [91200] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get coookie storage code to work with USE(CFNETWORK) enabled on Mac.

No new tests because no change in functionality.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultCookieStorage):
(WebCore::defaultSessionCookieStorage):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

  • platform/network/mac/CookieStorageMac.mm:
11:55 Changeset [91199] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

JSC JIT does not inline GC allocation fast paths
https://bugs.webkit.org/show_bug.cgi?id=64582

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This addresses inlining allocation for the easiest-to-allocate cases:
op_new_object and op_create_this. Inlining GC allocation fast paths
required three changes. First, the JSGlobalData now saves the vtable
pointer of JSFinalObject, since that's what op_new_object and
op_create_this allocate. Second, the Heap exposes a reference to
the appropriate SizeClass, so that the JIT may inline accesses
directly to the SizeClass for JSFinalObject allocations. And third,
the JIT is extended with code to emit inline fast paths for GC
allocation. A stub call is emitted in the case where the inline fast
path fails.

  • heap/Heap.h:

(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFinalObject):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

  • runtime/JSGlobalData.h:
  • runtime/JSObject.h:

(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInheritorID):

11:43 Changeset [91198] by psolanki@apple.com
  • 6 edits in trunk/Source

Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit/mac:

Create an NSURLDownload from the CF objects that we have.

  • Misc/WebDownload.mm:

(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):

  • Misc/WebDownloadInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::download):

11:20 Changeset [91197] by abarth@webkit.org
  • 5 edits in trunk/Tools

Increase information garden-o-matic information density by switching to a table
https://bugs.webkit.org/show_bug.cgi?id=64642

Reviewed by Dimitri Glazkov.

The old layout couldn't handle the large number of failures we had
today. This patch switches garden-o-matic to a table-based layout,
which can handle many more failures gracefully. (I expect we'll need
more UI iterations.)

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:18 Changeset [91196] by abarth@webkit.org
  • 8 edits in trunk/Tools

garden-o-matic should be able to determine when compile breaks
https://bugs.webkit.org/show_bug.cgi?id=64190

Reviewed by Dimitri Glazkov.

This patch adds a red-ish box to the top of the page whenever there is
a compile error on the bots. The box automatically opens and closes as
appropriate and links to the waterfall display. In the future, we
might want to compute a regression range.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    • Add the build-only bots to the config. We use these to check whether the build failed, which is faster than waiting for the tester bots to cycle.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add DOM for the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • CSS to support the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Wiring up events to poll the buildbot to see whether compile has failed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Infrastructure for fetching and parsing the buildbot status JSON blob. This code could be better factored for testability. :(
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • UI for displaying compile errors.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:11 Changeset [91195] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative fix for Leopard assertions caused by 91095.

Rubber stamped by Sam Weinig.

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

  • ensure we pass the window shell, not the global object.
10:47 Changeset [91194] by oliver@apple.com
  • 100 edits in trunk/Source

2011-07-18 Mark Hahnenberg <mhahnenberg@apple.com>

Refactor JSC to replace JSCell::operator new with static create method
https://bugs.webkit.org/show_bug.cgi?id=64466

Reviewed by Oliver Hunt (oliver@apple.com) and Darin Adler (darin@apple.com).

First step in a longer refactoring process to remove the use of
operator new overloading in order to allocate GC objects and to replace
this method with static create methods for each individual type of heap-allocated
JS object. This particular patch only deals with replacing uses of
operator new within JSC proper. Future patches will remove it from the
parts that interface with the DOM. Due to the DOM's continued dependence
on it, operator new has not actually been removed from JSCell.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::create):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::create):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::operator new): (JSC::JSCallbackObject::create):
  • API/JSCallbackObjectFunctions.h: (JSC::::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction):
  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::create): (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::create): (JSC::Arguments::createNoParameters):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::create):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::create):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h: (JSC::BooleanConstructor::create):
  • runtime/BooleanObject.h: (JSC::BooleanObject::create):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::create):
  • runtime/DateConstructor.cpp: (JSC::constructDate):
  • runtime/DateConstructor.h: (JSC::DateConstructor::create):
  • runtime/DateInstance.h: (JSC::DateInstance::create):
  • runtime/DatePrototype.h: (JSC::DatePrototype::create):
  • runtime/Error.cpp: (JSC::createError): (JSC::createEvalError): (JSC::createRangeError): (JSC::createReferenceError): (JSC::createSyntaxError): (JSC::createTypeError): (JSC::createURIError): (JSC::StrictModeTypeErrorFunction::create): (JSC::createTypeErrorFunction):
  • runtime/ErrorConstructor.h: (JSC::ErrorConstructor::create):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): (JSC::ErrorInstance::create):
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::create):
  • runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::InterruptedExecutionError::create): (JSC::createInterruptedExecutionException): (JSC::TerminatedExecutionError::TerminatedExecutionError): (JSC::TerminatedExecutionError::create): (JSC::createTerminatedExecutionException):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::FunctionExecutable): (JSC::FunctionExecutable::fromGlobalCode):
  • runtime/Executable.h: (JSC::ExecutableBase::create): (JSC::NativeExecutable::create): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::ProgramExecutable::create): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::make):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h: (JSC::FunctionConstructor::create):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::addFunctionProperties):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::create):
  • runtime/GetterSetter.h: (JSC::GetterSetter::create):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::create): (JSC::jsAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h: (JSC::JSActivation::create):
  • runtime/JSArray.h: (JSC::JSArray::create):
  • runtime/JSCell.h: (JSC::JSCell::allocateCell):
  • runtime/JSFunction.h: (JSC::JSFunction::create):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::create):
  • runtime/JSONObject.h: (JSC::JSONObject::create):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::putDescriptor):
  • runtime/JSObject.h: (JSC::JSFinalObject::create):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope): (JSC::JSString::replaceCharacter): (JSC::StringObject::create):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::create): (JSC::RopeBuilder::createHasOtherOwner): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString): (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • runtime/JSValue.cpp: (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/MathObject.h: (JSC::MathObject::create):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::create):
  • runtime/NativeErrorPrototype.h: (JSC::NativeErrorPrototype::create):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::create):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h: (JSC::NumberObject::create):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::create):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::create):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::create):
  • runtime/Operations.h: (JSC::jsString):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::createWithoutCaching): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::arrayOfMatches): (JSC::constructRegExp):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::create):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::create):
  • runtime/RegExpObject.h: (JSC::RegExpObject::create):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::create):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::create): (JSC::ScopeChainNode::push):
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • runtime/StringConstructor.cpp: (JSC::constructWithStringConstructor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::create):
  • runtime/StringObject.h: (JSC::StringObject::create):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • runtime/StringPrototype.h: (JSC::StringPrototype::create):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::createStructure):
  • runtime/StructureChain.h: (JSC::StructureChain::create):
10:12 Changeset [91193] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
https://bugs.webkit.org/show_bug.cgi?id=64560

Patch by Hui Huang <hui.2.huang@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

10:04 Changeset [91192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] [Qt] [WK2] Unsync in TextureMapperNode between parent and child lists cause crashes on WK2.
https://bugs.webkit.org/show_bug.cgi?id=62587

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

Fix unsync between m_parent and m_children list in child and parent texture mapper nodes
in syncCompositingStateSelf.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

10:01 Changeset [91191] by commit-queue@webkit.org
  • 5 edits in trunk

Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Patch by Rob Buis <rbuis@rim.com> on 2011-07-18
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Do not rely on toolkits to correctly render zero-length path with stroke-linecap=round, render
it ourselves just like for stroke-linecap=square.

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::setupSquareCapPath):

LayoutTests:

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
09:54 Changeset [91190] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[REGRESSION] Value 'none' breaks multiple background-image display
https://bugs.webkit.org/show_bug.cgi?id=59274

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-18
Reviewed by Simon Fraser.

When taking fast path for simple color background, we should draw
the background only if it is the last in the list of backgrounds.
Otherwise, it will obscure the previously drawn backgrounds.

Source/WebCore:

Test: fast/backgrounds/background-fast-path-simple-color.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

  • fast/backgrounds/background-fast-path-simple-color-expected.png: Added.
  • fast/backgrounds/background-fast-path-simple-color-expected.txt: Added.
  • fast/backgrounds/background-fast-path-simple-color.html: Added.
09:48 Changeset [91189] by yi.4.shen@nokia.com
  • 5 edits
    3 adds in trunk

[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
https://bugs.webkit.org/show_bug.cgi?id=62808

Source/WebCore:

The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously
when its load type is set to SynchronousLoad.

Reviewed by Benjamin Poulain.

Test: loader/load-defer-resume-crash.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandler::setLoadingDeferred):

LayoutTests:

Added a test for the crash occurs when load deferring is turned off.

Reviewed by Benjamin Poulain.

  • loader/load-defer-resume-crash-expected.txt: Added.
  • loader/load-defer-resume-crash.html: Added.
  • loader/resources/images.html: Added.
  • platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
09:43 Changeset [91188] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Make using lowercase parameter names for AppleConnect be a plug-in quirk
https://bugs.webkit.org/show_bug.cgi?id=64638

Reviewed by Sam Weinig.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):
Set the WantsLowercaseParameterNames quirk for the AppleConnect plug-in.

  • Shared/Plugins/PluginQuirks.h:

Add WantsLowercaseParameterNames quirk.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
If the plug-in has the WantsLowercaseParameterNames quirk, convert the parameter
names to lowercase.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Remove the code that would convert the parameters here. Also remove the FIXME; plug-in quirks
aren't really the same thing as site-specific quirks.

09:16 Changeset [91187] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AnimationBase asserts if a test tries to pause during the delay phase
https://bugs.webkit.org/show_bug.cgi?id=59475

Patch by Young Han Lee <joybro@company100.net> on 2011-07-18
Reviewed by Simon Fraser.

There is no more assertion failure after r90765, but the testcase still fails due to
the miscalculation of the pauseTime. This patch pauses the animation at its startTime
if a test tries to pause it during the delay phase.

Source/WebCore:

Test: transitions/transition-in-delay-phase.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

  • transitions/transition-in-delay-phase-expected.txt: Added.
  • transitions/transition-in-delay-phase.html: Added.
07:26 Changeset [91186] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; updated chromium test expectations.

Remove a passing test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
07:08 Changeset [91185] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; updated chromium test expectations.

Remove two tests from test_expectations.txt that have been rebaselined.

  • platform/chromium/test_expectations.txt:
07:04 Changeset [91184] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Web Inspector: provide unique identifiers for loaders
https://bugs.webkit.org/show_bug.cgi?id=64599

Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::loaderDetachedFromFrameImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameDestroyed):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::loaderId):
(WebCore::InspectorPageAgent::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame):

06:43 Changeset [91183] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Consider QTouchWebPage's transform when scrolling the viewport.
https://bugs.webkit.org/show_bug.cgi?id=64541

Reviewed by Benjamin Poulain.

Currently the scroll deltas are given to moveBy in page coordinates
which doesn't match when the page view is scalled.
This patch gives the scroll delta to the viewport in it's own coordinates.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureRequestScroll):

06:43 Changeset [91182] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Push the new viewport rect to the drawing area after committing the scale.
https://bugs.webkit.org/show_bug.cgi?id=64597

Reviewed by Benjamin Poulain.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureEnded):

06:43 Changeset [91181] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt] Remove the scale commit timer from QTouchWebPage.
https://bugs.webkit.org/show_bug.cgi?id=64600

Reviewed by Benjamin Poulain.

Since we don't currently need unprepared page view scale changes,
this timer isn't useful.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::commitScaleChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureStarted):

06:43 Changeset [91180] by jocelyn.turcotte@nokia.com
  • 6 edits in trunk/Source/WebKit2

TiledDrawingArea: map the visibleArea rect from page to tiles coordinates.
https://bugs.webkit.org/show_bug.cgi?id=64538

Reviewed by Benjamin Poulain.

TiledDrawingAreaProxy expects its coordinates to be scaled according to
contentsScale. This patch keep the pushed visibleArea as page coordinates
and convert it each time to scaled coordinates in case the contents scale was
changed afterward.
This is a regression introduced in r90750.
Also:

  • Rename visibleArea to visibleContentRect
  • Remove an unnecessary mapToContents in QTouchWebPageProxy::setVisibleContentRect
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setViewportRect):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::visibleRect):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRect):

  • UIProcess/qt/qtouchwebpageproxy.h:
06:18 Changeset [91179] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: "Reveal in Elements Panel" is broken.
https://bugs.webkit.org/show_bug.cgi?id=64688

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

05:40 Changeset [91178] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove RenderObject::addLayers second argument
https://bugs.webkit.org/show_bug.cgi?id=64649

Reviewed by Benjamin Poulain.

No change in behavior.

The code was always passing |this| as the second argument. Thus just
removed the argument for clarity.

  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addLayers): Removed the argument, replaced
by |this|.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Removed the second argument at those 2 call sites.

02:20 Changeset [91177] by loki@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Qt rebaselines after r91060 and r91116

  • platform/qt/fast/dom/Window/window-properties-expected.txt: (r91060)
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Added (r91116)
02:09 Changeset [91176] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: do not pause on caught exceptions while typing in the console.
https://bugs.webkit.org/show_bug.cgi?id=64379

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

01:11 Changeset [91175] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK and Qt rebaselines after r91158.

  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/qt/editing/inserting/5058163-1-expected.txt:
00:34 Changeset [91174] by commit-queue@webkit.org
  • 14 edits in trunk

Unreviewed, rolling out r91132 and r91135.
http://trac.webkit.org/changeset/91132
http://trac.webkit.org/changeset/91135
https://bugs.webkit.org/show_bug.cgi?id=64681

Broke GTK and Chromium debug bots (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18

Source/WebCore:

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::didSetSelectedIndex):

  • rendering/RenderMenuList.h:

Tools:

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(logEventProc):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):

07/17/11:

23:30 Changeset [91173] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Fix selection of elements in a multi select list and remove an unnecessary include in WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=64666

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-07-17
Reviewed by Martin Robinson.

  • Platform/gtk/WorkQueueGtk.cpp: Remove an include which is no longer required
  • Shared/gtk/WebEventFactory.cpp:

(WebKit::modifiersForEvent): Fix an incorrect ASSERT statement
(WebKit::WebEventFactory::createWebMouseEvent): Call the function to determine the modifier keys

23:24 Changeset [91172] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Chromium rebaselines after r91158.

Add failing expectations for tests added in r91125. The failures are tracked by the bug 64675.

Also remove failing expectations for some editing tests tracked by the Chromium issue 89477
because they are now passing.

  • platform/chromium-linux/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.txt:
  • platform/chromium/test_expectations.txt:
19:58 Changeset [91171] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Refactor scheduleDispatchFunctionsOnMainThread to fix crash.
https://bugs.webkit.org/show_bug.cgi?id=64337

Replace ecore_timer_add to Ecore_Pipe.
This is needed because ecore_timer should not be called in a child thread,
but in the main thread.

Reviewed by Antonio Gomes.

  • wtf/efl/MainThreadEfl.cpp:

(WTF::pipeObject):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

18:59 Changeset [91170] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSSPropertyCursor in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=64432

Reviewed by Dimitri Glazkov.

No new tests / refectoring only.

  • css/CSSStyleApplyProperty.cpp:

Add handler for CSSPropertyCursor.

  • css/CSSStyleSelector.cpp:

Remove current handler of CSSPropertyCursor.

  • css/CSSStyleSelector.h:

Make styleImage and cachedOrPendingFromValue public.

18:47 Changeset [91169] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-07-17
Reviewed by Martin Robinson.

[GTK] [WK2] Fix for getting editor client commands.
https://bugs.webkit.org/show_bug.cgi?id=63081

Editor client commands intepretation was incorrect. It was based on the NativeWebKeyboardEvent only.
In fact EventHandler is generating interpreted events - keypress and keydown. These event types
are now passed from UIProcess to WebProcess so KeyBindingTranslator can correctly find editor commands.
Also build break for Debug build was fixed.

  • UIProcess/API/gtk/PageClientImpl.cpp: KeyboardEvent type is used for KeyBindingTranslator.

(WebKit::PageClientImpl::getEditorCommandsForKeyEvent): getEditorCommandsForKeyEvent now has additional
parameter describing KeyboardEvent type.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): KeyboardEvent type passed to PageClient.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::getEditorCommandsForKeyEvent): Sync message send with KeyboardEvent type.

02:02 Changeset [91168] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline.
https://bugs.webkit.org/show_bug.cgi?id=64637

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-17
Reviewed by Gavin Barraclough.

  • dfg/DFGOperations.cpp:
01:57 Changeset [91167] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Tools

test-webkitpy failing with Python 2.5
https://bugs.webkit.org/show_bug.cgi?id=64594

Patch by Philippe Normand <pnormand@igalia.com> on 2011-07-17
Reviewed by Eric Seidel.

Updated simplejson to version 2.1.6 that fixes an issue when
dumping slashes. Also use cgi.parse_qs instead of the urlparse
version to be compatible with Python2.5. Verified the fix with
test-webkitpy on python 2.5 and python 2.6.

  • Scripts/webkitpy/thirdparty/simplejson/README.txt:
  • Scripts/webkitpy/thirdparty/simplejson/init.py:
  • Scripts/webkitpy/thirdparty/simplejson/_speedups.c:

(json_PyOS_string_to_double):
(_convertPyInt_AsSsize_t):
(_convertPyInt_FromSsize_t):
(ascii_escape_char):
(ascii_escape_unicode):
(ascii_escape_str):
(raise_errmsg):
(join_list_unicode):
(join_list_string):
(_build_rval_index_tuple):
(scanstring_str):
(scanstring_unicode):
(py_scanstring):
(py_encode_basestring_ascii):
(scanner_dealloc):
(scanner_traverse):
(scanner_clear):
(_parse_object_str):
(_parse_object_unicode):
(_parse_array_str):
(_parse_array_unicode):
(_parse_constant):
(_match_number_str):
(_match_number_unicode):
(scan_once_str):
(scan_once_unicode):
(scanner_call):
(scanner_new):
(scanner_init):
(encoder_new):
(encoder_init):
(encoder_call):
(_encoded_const):
(encoder_encode_float):
(encoder_encode_string):
(_steal_list_append):
(encoder_listencode_obj):
(encoder_listencode_dict):
(encoder_listencode_list):
(encoder_dealloc):
(encoder_traverse):
(encoder_clear):
(init_speedups):

  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/encoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
  • Scripts/webkitpy/thirdparty/simplejson/scanner.py:
  • Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
00:38 Changeset [91166] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Rename ModifierMatcher to SpecificityCalculator.
https://bugs.webkit.org/show_bug.cgi?id=64660

It's a little longer than before, but it is much clearer.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted

all callsites, also rewrote the comments.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites

and renamed tests.

Note: See TracTimeline for information about the timeline view.