Timeline


and

07/25/11:

22:35 Changeset [91743] by commit-queue@webkit.org

DFG non-speculative JIT emits inefficient code for arithmetic
involving two registers
https://bugs.webkit.org/show_bug.cgi?id=65160

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The non-speculative JIT now emits inline code for double arithmetic, but
still attempts integer arithmetic first. This is a speed-up on SunSpider
(albeit a small one), and a large speed-up on Kraken.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::basicArithOp):

22:21 Changeset [91742] by ryuan.choi@samsung.com

[CMAKE] Split JSC related files from WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=61350

Reviewed by Daniel Bates.

No new tests, just moving jsc related files from CMakeLists.txt to UseJSC.cmake.

  • CMakeLists.txt:
  • UseJSC.cmake:
22:11 Changeset [91741] by commit-queue@webkit.org

[EFL] Remove unused code in ewk_tile_model.c
https://bugs.webkit.org/show_bug.cgi?id=64521

Remove unused code in ewk_tile_model.c. Dirty flag is not referenced anywhere.

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-07-25
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_model.c:

(ewk_tile_unused_cache_clear):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

21:44 Changeset [91740] by mitz@apple.com

Updated three more tests that relied on fonts loading synchronously.

  • fast/blockflow/japanese-rl-text-with-broken-font.html:
  • platform/mac/fast/text/myanmar-shaping.html:
  • platform/mac/fast/text/thai-combining-mark-positioning.html:
20:37 Changeset [91739] by mitz@apple.com

Fix the build by committing a rename in this file that I neglected to include in the previous commit.

  • css/CSSFontFaceSource.h:
20:21 Changeset [91738] by mitz@apple.com

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
https://bugs.webkit.org/show_bug.cgi?id=65123

Source/WebCore:

Reviewed by Anders Carlsson and Darin Adler.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:

LayoutTests:

Reviewed by Darin Adler.

Updated tests that depended on fonts loading synchronously during layout.
Unfortunately, font loading does not fire any DOM events, so in most cases
a constant timeout had to be introduced.

  • fast/blockflow/broken-ideograph-small-caps.html:
  • fast/css/color-leakage.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-remote-sources.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-woff.html:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
  • svg/custom/svg-fonts-fallback.xhtml:
  • svg/custom/svg-fonts-in-html.html:
  • svg/custom/svg-fonts-segmented.xhtml:
  • svg/custom/svg-fonts-with-no-element-reference.html:
  • svg/custom/svg-fonts-without-missing-glyph.xhtml:
  • svg/text/text-overflow-ellipsis-svgfont.html:
18:41 Changeset [91737] by ryuan.choi@samsung.com

[EFL] Build break with --debug after r89153.
https://bugs.webkit.org/show_bug.cgi?id=65150

Unreviewed build fix.

  • wtf/CMakeListsEfl.txt: Add missing libraries.
18:18 Changeset [91736] by commit-queue@webkit.org

Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
18:07 Changeset [91735] by weinig@apple.com

Refactor ScrollableArea pinned predicates to be more generally useful
<rdar://problem/9740379>

Reviewed by Dan Bernstein.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedInBothDirections):
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
(WebCore::ScrollableArea::isPinnedVerticallyInDirection):

  • platform/ScrollableArea.h:
18:04 Changeset [91734] by commit-queue@webkit.org

DFG non-speculative JIT emits obviously inefficient code for arithmetic
where one operand is a constant.
https://bugs.webkit.org/show_bug.cgi?id=65146

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Changed the code to emit double arithmetic inline.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):

18:03 Changeset [91733] by thakis@chromium.org

[chromium] components/mac: Make webcore not depend on CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=65143

Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:
18:02 Changeset [91732] by enne@google.com

[chromium] Mark fast/cyclic-prototypes.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:58 Changeset [91731] by enne@google.com

[chromium] draw-arrays-out-of-bounds.html is a non-GPU flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:40 Changeset [91730] by thakis@chromium.org

[chromium] Don't link in both libjpeg and libjpeg_turbo in the components build
https://bugs.webkit.org/show_bug.cgi?id=65138

Reviewed by James Robinson.

  • WebKit.gyp:
17:31 Changeset [91729] by enne@google.com

[chromium] Mark fast/selectors/001.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:25 Changeset [91728] by commit-queue@webkit.org

DFG JIT bytecode parser misuses pointers into objects allocated as part of a
WTF::Vector.
https://bugs.webkit.org/show_bug.cgi?id=65128

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The bytecode parser code seems to be right to have a DFGNode& phiNode reference
into the graph, since this makes the code greatly more readable. This patch
thus makes the minimal change necessary to make the code right: it uses a
pointer (to disambiguate between reloading the pointer and performing a
copy from one location of the vector to another) and reloads it after the
calls to addToGraph().

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

17:12 Changeset [91727] by commit-queue@webkit.org

WebFrame should have a method to determine its visual emptiness
https://bugs.webkit.org/show_bug.cgi?id=64223

Patch by Ian Henderson <ianh@apple.com> on 2011-07-25
Reviewed by Dan Bernstein.

Source/WebCore:

  • page/FrameView.h:

(WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
so we can tell whether it's visually non-empty.

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
through WebKit.

  • WebView/WebFramePrivate.h:
17:11 Changeset [91726] by enne@google.com

[chromium] Mark fast/cyclic-proto.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:57 Changeset [91725] by commit-queue@webkit.org

REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Rollback previous patch. Occasional crashes seen caused by
CachedResource being deleted twice.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):

  • loader/cache/CachedResourceLoader.h:
16:56 Changeset [91724] by paroga@webkit.org

Ignore line endings in ChangeLogTests
https://bugs.webkit.org/show_bug.cgi?id=64956

Reviewed by Adam Barth.

Split the lines of the ChangeLog text before comparing them.
This fixes 3 tests on windows, since only the content importent.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
16:40 Changeset [91723] by crogers@google.com

Deprecate AudioBufferSourceNode .looping attribute and implement .loop
https://bugs.webkit.org/show_bug.cgi?id=65133

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::loop):
(WebCore::AudioBufferSourceNode::setLoop):

  • webaudio/AudioBufferSourceNode.idl:
16:35 Changeset [91722] by jamesr@google.com

[chromium] HUD texture must be unreserved after drawing
https://bugs.webkit.org/show_bug.cgi?id=65122

Unreserve the HUD texture after drawing. To test, start chrome in debug with --show-fps-counter. Since this is
a debugging option, no tests.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

16:28 Changeset [91721] by commit-queue@webkit.org

Fix leveldb crash when compacting during destruction
https://bugs.webkit.org/show_bug.cgi?id=64494

Patch by David Grogan <dgrogan@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Only tested manually so far by following the repro instructions at
crbug.com/88944

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::~LevelDBDatabase):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):

16:27 Changeset [91720] by commit-queue@webkit.org

[Chromium] Use correct vertex shader when rendering video layer.
https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

16:14 Changeset [91719] by abarth@webkit.org

Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
https://bugs.webkit.org/show_bug.cgi?id=65148

Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
16:12 Changeset [91718] by paroga@webkit.org

Fix AtomicString vs. String usage in accessibility code
https://bugs.webkit.org/show_bug.cgi?id=65086

Reviewed by Darin Adler.

Use AtomicString instead of String where appropriate
to avoid implicit type conversations.
Also fix a invalid reference to a temporary String.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::elementsFromAttribute):
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.h:
16:10 Changeset [91717] by enne@google.com

[chromium] Mark user-script-image-document as a flaky crasher on Linux

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

16:02 Changeset [91716] by ojan@chromium.org

Tweak whitespace wrapping to improve readability.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:59 Changeset [91715] by commit-queue@webkit.org

Unreviewed, rolling out r91686.
http://trac.webkit.org/changeset/91686
https://bugs.webkit.org/show_bug.cgi?id=65144

1.5% regression in JSC (Requested by jmontemayor on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/JavaScriptCore:

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Removed.
15:54 Changeset [91714] by crogers@google.com

Disable web audio layout tests on all platforms except chromium - as initial tests are added
https://bugs.webkit.org/show_bug.cgi?id=65142

Unreviewed.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
15:41 Changeset [91713] by ojan@chromium.org

Minor tweak to wrap label elements as atomic units.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:33 Changeset [91712] by ojan@chromium.org

always show flakiness details on the builder page
https://bugs.webkit.org/show_bug.cgi?id=65139

Reviewed by Tony Chang.

In order to simplify the UI, we hide the flakiness details by default,
but there's no actual use-case for this page without the flakiness details.
So get rid of that option and always show the flakiness details.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:32 Changeset [91711] by ojan@chromium.org

simplify the UI of the header above the test list table
https://bugs.webkit.org/show_bug.cgi?id=65136

Reviewed by Adam Barth.

Use checkboxes instead of links since this is really about which tests to include.
Ends up using less text and put the checkboxes to the right of the header instead of below it.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:23 Changeset [91710] by mitz@apple.com

Reverted r91699 due to
<http://webkit.org/b/65134> REGRESSION: r91699 broke some font tests (image+text)

Many tests relied on font loading occurring synchronously in the cached and local cases.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
15:23 Changeset [91709] by crogers@google.com

Update new-run-webkit-tests to accomodate binary audio data
https://bugs.webkit.org/show_bug.cgi?id=65135

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:16 Changeset [91708] by crogers@google.com

Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
https://bugs.webkit.org/show_bug.cgi?id=65039

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebArrayBufferView.h: Added.

(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):

  • public/WebBindings.h:
  • src/WebArrayBufferView.cpp: Added.

(WebKit::WebArrayBufferView::assign):
(WebKit::WebArrayBufferView::reset):
(WebKit::WebArrayBufferView::baseAddress):
(WebKit::WebArrayBufferView::byteOffset):
(WebKit::WebArrayBufferView::byteLength):
(WebKit::WebArrayBufferView::WebArrayBufferView):
(WebKit::WebArrayBufferView::operator=):
(WebKit::WebArrayBufferView::operator PassRefPtr<ArrayBufferView>):

  • src/WebBindings.cpp:

(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getArrayBufferView):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setAudioData):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::audioData):

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(DRTPrinter::handleAudioHeader):
(TestShellPrinter::handleAudioHeader):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

14:43 Changeset [91707] by mrobinson@webkit.org

Reviewed by Gustavo Noronha Silva.

[GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
https://bugs.webkit.org/show_bug.cgi?id=62252

Source/WebCore:

Properly handle the situation where the GtkWidget wants WebCore to draw its
own main frame scrollbars.

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
(WebCore::ScrollView::createScrollbar): Use the new helper.
(WebCore::ScrollView::visibleContentRect): Use the new helper.

Source/WebKit/gtk:

Added an undocumented self-scrolling property to WebKitWebView which
communicates to WebCore whether or not this widget is expected to draw
its own main frame scrollbars or not.

  • webkit/webkitwebview.cpp: Add the self-scrolling property.
  • webkit/webkitwebviewprivate.h: Add the selfScrolling private member.

Tools:

Add a new subclass of WebKitWebView that overrides the size request to
return 1 pixel by 1 pixel. This ensure that it operates properly when
not packed into a GtkScrolledWindow. Also construct the WebKitWebView
with self-scrolling set to true.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
(createWebView): Ditto.
(main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.

(self_scrolling_webkit_web_view_class_init):
(self_scrolling_webkit_web_view_init):
(self_scrolling_webkit_web_view_new):
(sizeRequestMethod):
(getPreferredSizeMethod):

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
  • GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.

LayoutTests:

Unskip tests which are now passing and update results for tests which
previously had incorrect results.

  • platform/gtk/Skipped: Unskip now-passing tests.
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.png:
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/flexbox/flex-hang-expected.png:
  • platform/gtk/fast/flexbox/flex-hang-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.png:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.png: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.png: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
14:33 Changeset [91706] by jonlee@apple.com

Assertion called in ExecutableBase::generatedJITCodeForCall() when JIT is not available
https://bugs.webkit.org/show_bug.cgi?id=65132
<rdar://problem/9836297>

Reviewed by Oliver Hunt.

Make sure the JIT is available to use before running the following calls:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::unlinkCalls): Added check, return early if JIT is not available.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addMethodCallLinkInfos): Added assertion.

14:01 Changeset [91705] by ojan@chromium.org

by default hide tests that have passes for all recorded runs
https://bugs.webkit.org/show_bug.cgi?id=65127

Reviewed by Adam Barth.

This is part of simplifying the default views of the dashboard to
make it show less information for the common use cases.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
13:45 Changeset [91704] by ojan@chromium.org

stop generating expectations.json now that it's unused
https://bugs.webkit.org/show_bug.cgi?id=65130

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • TestResultServer/handlers/menu.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
13:20 Changeset [91703] by enne@google.com

[chromium] media-controls-clone started flaky crashing on mac.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

13:08 Changeset [91702] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65125

(1) Add the new CSS3 positioned value for floats.
(2) Rename FLEFT, FRIGHT and FNONE to our more modern convention: NoFloat, LeftFloat, RightFloat.
(3) Replace uses of == FNONE and != FNONE with isFloating and !isFloating.

Reviewed by Dan Bernstein.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFloat):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • css/CSSValueKeywords.in:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isFloating):
(WebCore::InheritedFlags::initialFloating):

  • rendering/style/RenderStyleConstants.h:
13:08 Changeset [91701] by ojan@chromium.org

don't show builders in the flakiness dashboard that have stopped running a given test suite
https://bugs.webkit.org/show_bug.cgi?id=65126

Reviewed by Mihai Parparita.

  • TestResultServer/static-dashboards/dashboard_base.js:
13:05 Changeset [91700] by enne@google.com

[chromium] More WebGL flaky crashers on Linux.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

13:00 Changeset [91699] by mitz@apple.com

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
https://bugs.webkit.org/show_bug.cgi?id=65123

Reviewed by Anders Carlsson.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:
12:55 Changeset [91698] by dbates@webkit.org

2011-07-25 Daniel Bates <dbates@rim.com>

Rename expected results file after changeset <http://trac.webkit.org/changeset/91689>.

  • fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt: Copied from LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt.
  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Removed.
12:50 Changeset [91697] by mrobinson@webkit.org

Update baselines for GTK+ after several revisions.

  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt:
  • platform/gtk/fast/forms/input-appearance-range-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.png:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
12:46 Changeset [91696] by lforschler@apple.com

Versioning.

12:42 Changeset [91695] by lforschler@apple.com

New tag.

12:20 Changeset [91694] by commit-queue@webkit.org

[Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)
https://bugs.webkit.org/show_bug.cgi?id=64878

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Adopt GraphicsContext3DOpenGL.cpp and ANGLE compiler for Qt.

  • WebCore.pro: Build ANGLE compiler and GraphicsContext3DOpenGL.cpp.
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h: Expose exising ANGLEWebKitBridge compiler member for Qt.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLE resources.

12:08 Changeset [91693] by enne@google.com

[chromium] More ICU roll test failures from the slow windows bot
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:59 Changeset [91692] by lforschler@apple.com

Merge r91147.

11:58 Changeset [91691] by cevans@google.com

Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7506003

11:57 Changeset [91690] by enne@google.com

[chromium] japanese-rl-selection-repaint also broken by ICU roll
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:55 Changeset [91689] by dbates@webkit.org

REGRESSION (r85964): Improper relayout of some nested positioned elements
https://bugs.webkit.org/show_bug.cgi?id=64286

Reviewed by David Hyatt.

Source/WebCore:

Fixes an issue when traversing up the containing block hierarchy after skipping
relatively positioned inlines.

When processing a positioned element we skip any intermediate inlines to get to
to enclosing block B, but don't use the containing block for B (call this P_B) to
properly continue traversing up the containing block hierarchy. So, B may be
considered again instead of looking at P_B. Hence, we don't set the correct dirty
bits for P_B and may not schedule a relayout with respect to the correct layout node.

Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Add test case to ensure we don't regress relayout of nested positioned elements.

  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Added.
  • fast/block/positioning/relayout-nested-positioned-elements-crash.html: Added.
11:55 Changeset [91688] by cevans@google.com

Revert 91684 - Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7503002

11:43 Changeset [91687] by enne@google.com

[chromium] japanese-rl-selection-clear broken by ICU roll
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:41 Changeset [91686] by commit-queue@webkit.org

JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
11:34 Changeset [91685] by cevans@google.com

Merge 91611
BUG=90222
Review URL: http://codereview.chromium.org/7499005

11:32 Changeset [91684] by cevans@google.com

Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7502005

11:21 Changeset [91683] by enne@google.com

[chromium] Mark media/remove-from-document as another flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:11 Changeset [91682] by enne@google.com

[chromium] More WebGL flaky crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:08 Changeset [91681] by commit-queue@webkit.org

removes last ENABLE(DRAG_SUPPORT) gtk check
https://bugs.webkit.org/show_bug.cgi?id=64518

Patch by Arno Renevier <arno@renevier.net> on 2011-07-25
Reviewed by Martin Robinson.

  • platform/gtk/ClipboardGtk.h:
11:03 Changeset [91680] by enne@google.com

[chromium] Mark some media tests as being crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [91679] by commit-queue@webkit.org

[CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape
https://bugs.webkit.org/show_bug.cgi?id=65096

Source/WebCore:

Also the 'inherit' keyword is now treated correctly. It will
copy the value from the parent style.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-25
Reviewed by Tony Chang.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

Fixed 'inherit' test to copy the value from the parent. Also, added new tests
for 'inerhit' with no value in the parent.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-25
Reviewed by Tony Chang.

  • fast/exclusions/parsing-wrap-shape-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape.js:
10:59 Changeset [91678] by commit-queue@webkit.org

X86-64 assembler emits three instructions instead of two for certain
loads and stores.
https://bugs.webkit.org/show_bug.cgi?id=65095

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Simply made these four methods in the assembler use the scratch register,
which they were previously avoiding. It still optimizes for the case where
an absolute address memory accesses is using EAX. This results in a slight
performance improvement.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load32):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::storePtr):

10:51 Changeset [91677] by abarth@webkit.org

Overhaul garden-o-matic frontend to integrate revision history and failures
https://bugs.webkit.org/show_bug.cgi?id=65089

Reviewed by Dimitri Glazkov.

This is a major overhaul of the garden-o-matic frontend. The new UI
integrates the revision history information with failures. Failures
appear in context adjacent to the revisions that caused them (which are
highlighted). Each buildbot receives a collumn to the left, which
indicates which revisions that bot has tested and whether that bot
showed the indicated failures.

Failures are selectable with checkboxes, and can then either be
examined or rebaselined.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
10:47 Changeset [91676] by commit-queue@webkit.org

disable tests pending rebaseline with rotated text fix
https://bugs.webkit.org/show_bug.cgi?id=65114

Patch by Mike Reed <reed@google.com> on 2011-07-25
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
10:45 Changeset [91675] by enne@google.com

[chromium] Mark gl-enum-enable-test as a flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:39 Changeset [91674] by commit-queue@webkit.org

glActiveTexture(0) is invalid
https://bugs.webkit.org/show_bug.cgi?id=65115

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Kenneth Russell.

Existing WebGL layout tests.

Fix invalid glActiveTexture(0) call.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::prepareTexture):

10:06 Changeset [91673] by pfeldman@chromium.org

Unreviewed, rolling out r91665.
http://trac.webkit.org/changeset/91665
https://bugs.webkit.org/show_bug.cgi?id=65118

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
10:00 Changeset [91672] by pfeldman@chromium.org

Unreviewed, rolling out r91668.
http://trac.webkit.org/changeset/91668
https://bugs.webkit.org/show_bug.cgi?id=65117

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
09:40 Changeset [91671] by zecke@webkit.org

[buildbot] Add Qt Linux MIPSEL Configuration
https://bugs.webkit.org/show_bug.cgi?id=65116

Reviewed by Adam Roben.

Introduce a Qt Linux MIPS EL build slave. The configuration
is a build only configuration.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
09:21 Changeset [91670] by podivilov@chromium.org

2011-07-25 Pavel Podivilov <podivilov@chromium.org>

Web Inspector: unreviewed, fix pause-in-internal-script expectations.
https://bugs.webkit.org/show_bug.cgi?id=65078

  • inspector/debugger/pause-in-internal-script-expected.txt:
  • platform/chromium/inspector/debugger/pause-in-internal-script-expected.txt: Copied from LayoutTests/inspector/debugger/pause-in-internal-script-expected.txt.
  • platform/qt/Skipped:
08:51 Changeset [91669] by caio.oliveira@openbossa.org

[Qt] Add more tests to cover the behavior of loadFinished() signal
https://bugs.webkit.org/show_bug.cgi?id=63490

Reviewed by Benjamin Poulain.

  • tests/qwebframe/tst_qwebframe.cpp:

(FakeReply::FakeReply):
(FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.

(tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
after a 404 error without contents.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
is true when we use error page extension to produce our own error pages.

08:10 Changeset [91668] by pfeldman@chromium.org

Web Inspector: use dedicated type for object id in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
07:48 Changeset [91667] by vestbo@webkit.org

[Qt][WK2] Add multi-point touch mocking to MiniBrowser

https://bugs.webkit.org/show_bug.cgi?id=64374

Reviewed by Benjamin Poulain.

Each mouse button generate a touch point. The touch point stay
virtually on screen if the mouse release happened while the Ctrl
modifier was pressed.

07:42 Changeset [91666] by yurys@chromium.org

[Chromium] Web Inspector: live edit error should be revealed in Console
https://bugs.webkit.org/show_bug.cgi?id=65109

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):

07:24 Changeset [91665] by pfeldman@chromium.org

Web Inspector: refactor remote object structure to contain value for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=65103

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get subtype):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):
(WebInspector.LocalJSONObject.prototype.get subtype):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
07:01 Changeset [91664] by kbalazs@webkit.org

[Qt][WK2] Use NRWT for Qt-WK2
https://bugs.webkit.org/show_bug.cgi?id=65097

Reviewed by Andreas Kling.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

05:52 Changeset [91663] by mnaganov@chromium.org

Web Inspector: [Chromium] Fix mixing of retaining path in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=65028

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotPathFinderState): Added
(WebInspector.HeapSnapshotRetainingPathsList): Extracted State-specific code

05:47 Changeset [91662] by ossy@webkit.org

[Qt] Lot of RenderTree mismatches in fast/multicol
https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening. Add Qt specific expected results after r91474.

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.png: Added.
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt/fast/multicol/float-multicol-expected.txt:
  • platform/qt/fast/multicol/scrolling-overflow-expected.png:
  • platform/qt/fast/multicol/scrolling-overflow-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt:
05:17 Changeset [91661] by yurys@chromium.org

Web Inspector: worker inspector should show Scripts panel by default
https://bugs.webkit.org/show_bug.cgi?id=65099

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector._defaultPanelName):
(WebInspector.showPanel):

00:18 Changeset [91660] by ryuan.choi@samsung.com

[EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
https://bugs.webkit.org/show_bug.cgi?id=64354

Use ecore_time_unix_get which returns unix time as double type for currentTime
and ecore_time_get which uses monotonic clock for monotonicallyIncreasingTime.

Reviewed by Kent Tamura.

  • wtf/CurrentTime.cpp:

(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

00:10 Changeset [91659] by commit-queue@webkit.org

[EFL] Move macro checking inside ewk_view_context_menu_forward_event
https://bugs.webkit.org/show_bug.cgi?id=64682

When CONTEXT_MENUS macro is disabled method ewk_view_context_menu_forward_event just
returns EINA_FALSE and it avoid undefined reference during building.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

00:09 Changeset [91658] by commit-queue@webkit.org

[EFL] Method ewk_context_menu_destroy returns EINA_FALSE if CONTEXT_MENUS macro is disabled
https://bugs.webkit.org/show_bug.cgi?id=64683

Fix returned value and omit NULL checking if CONTEXT_MENUS macro is disabled
in ewk_context_menu_destroy.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_destroy):

07/24/11:

22:10 Changeset [91657] by macpherson@chromium.org

Small cleanup of m_fontDirty tracking in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=65090

Reviewed by Darin Adler.

1) Use existing setFontDescription helper where appropriate.
2) Move always used m_fontDirty check into updateFont()

No new tests / cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::updateFontIfDirty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
21:42 Changeset [91656] by tkent@chromium.org

[Chromium] Leftover of r91633 (SVG test move)

  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.txt.
21:38 Changeset [91655] by tkent@chromium.org

[Chromium] Update expectations for r91637.

  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
20:36 Changeset [91654] by tkent@chromium.org

Validation message bubble position is incorrect if the containing block has paddings.
https://bugs.webkit.org/show_bug.cgi?id=65091

Reviewed by Hajime Morita.

Source/WebCore:

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
We don't need to subtract paddings because the origin of
position:aboslute is inside borders and outside of the padding.

LayoutTests:

  • fast/forms/validation-message-in-relative-body.html: Update the test to cover a padding case.
19:16 Changeset [91653] by rwlbuis@webkit.org

2011-07-24 Rob Buis <rbuis@rim.com>

Crash in SVGUseElement::updateContainerOffsets on <use> with no parent
https://bugs.webkit.org/show_bug.cgi?id=63646

Reviewed by Darin Adler.

Prevent using invalid targetElementInstance->shadowTreeElement after shadow render tree recreation. This situation can
only occur when there was a valid shadowTreeElement before setting xlink:href to empty/invalid.

Test: svg/custom/use-shadow-root-parent-removal.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
18:27 Changeset [91652] by paroga@webkit.org

Fix AtomicString vs. String usage in JSC binding
https://bugs.webkit.org/show_bug.cgi?id=65085

Reviewed by Darin Adler.

Use ustringToAtomicString instead of ustringToString where appropriate.

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
17:38 Changeset [91651] by macpherson@chromium.org

Implement CSSPropertyOutlineOffset in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64773

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

13:54 Changeset [91650] by kbalazs@webkit.org

Yet another unreviewed Qt fixery for the weekend.

Don't use test_expectations until all of the Qt platforms switched to NRWT.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
12:49 Changeset [91649] by commit-queue@webkit.org

Unreviewed, rolling out r91635.
http://trac.webkit.org/changeset/91635
https://bugs.webkit.org/show_bug.cgi?id=65083

It broke the minimal build (Requested by Ossy_OFFLINE on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-24

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

11:48 Changeset [91648] by abarth@webkit.org

Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
09:03 Changeset [91647] by kbalazs@webkit.org

Unreviewed gardening for Qt.

  • platform/qt/svg/custom/tref-own-content-removal-expected.txt: Added.
09:01 Changeset [91646] by kbalazs@webkit.org

[Qt] inspector/debugger/pause-in-internal-script.html fails
https://bugs.webkit.org/show_bug.cgi?id=65078

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Mark the test as expected TEXT failure.
08:23 Changeset [91645] by kbalazs@webkit.org

[Qt] Lot of RenderTree mismatches in fast/multicol
https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Add expected TEXT failures.
06:57 Changeset [91644] by rwlbuis@webkit.org

2011-07-24 Rob Buis <rbuis@rim.com>

SVG <use> element is not repositioned when moved to x=0 y=0 through script
https://bugs.webkit.org/show_bug.cgi?id=53767

Reviewed by Nikolas Zimmermann.

Only bail out on zero offset if it is not explicitly set.

Test: svg/custom/use-move-to-offset.svg

  • rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement): (WebCore::SVGShadowTreeContainerElement::setContainerOffset):
  • rendering/svg/SVGShadowTreeElements.h: (WebCore::SVGShadowTreeContainerElement::containerOffsetChanged): (WebCore::SVGShadowTreeContainerElement::setContainerOffsetChanged):
03:07 Changeset [91643] by jpfau@apple.com

Refactor HTML tokenizer code in preparation for a new XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65000

Reviewed by Adam Barth.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLNames::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLNames::isEndTagBufferingState):
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::TextDocumentParser):

  • html/parser/TextViewSourceParser.cpp:

(WebCore::TextViewSourceParser::TextViewSourceParser):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::type):

  • xml/parser/MarkupTokenizerBase.h: Added.

(WebCore::MarkupTokenizerBase::~MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::lineNumber):
(WebCore::MarkupTokenizerBase::columnNumber):
(WebCore::MarkupTokenizerBase::state):
(WebCore::MarkupTokenizerBase::setState):
(WebCore::MarkupTokenizerBase::forceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::setForceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
(WebCore::MarkupTokenizerBase::MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):
(WebCore::MarkupTokenizerBase::emitAndResumeIn):
(WebCore::MarkupTokenizerBase::emitAndReconsumeIn):
(WebCore::MarkupTokenizerBase::emitEndOfFile):
(WebCore::MarkupTokenizerBase::reset):
(WebCore::MarkupTokenizerBase::haveBufferedCharacterToken):

  • xml/parser/MarkupTokenizerInlineMethods.h: Added.

(WebCore::isTokenizerWhitespace):
(WebCore::advanceStringAndASSERTIgnoringCase):
(WebCore::advanceStringAndASSERT):

07/23/11:

20:30 Changeset [91642] by dglazkov@chromium.org

TestConfiguration should be hashable and comparable for equality.
https://bugs.webkit.org/show_bug.cgi?id=65070

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added hash and eq methods.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
16:42 Changeset [91641] by paroga@webkit.org

Remove WTF namespace from isMainThread() calls
https://bugs.webkit.org/show_bug.cgi?id=65068

Reviewed by Sam Weinig.

Because of the using WTF::isMainThread in the header there is no
reason to include the namespace name when calling this function.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • page/DOMWindow.cpp:
  • page/History.cpp:
15:44 Changeset [91640] by tkent@chromium.org

[Chromium] Update expectations for r91636.

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91639] by dglazkov@chromium.org

Extract TestConfiguration from base and write a few unit tests to capture current behavior.
https://bugs.webkit.org/show_bug.cgi?id=65066

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
11:44 Changeset [91638] by alokp@chromium.org

Switching off acceleration for small canvas broke gpu tests
https://bugs.webkit.org/show_bug.cgi?id=65053

Reviewed by Stephen White.

Source/WebCore:

No new tests. These are supposed to fix existing canvas tests on gpu.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldAccelerateCanvas):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
(WebCore::Settings::setMinimumAccelerated2dCanvasSize):

  • page/Settings.h:

(WebCore::Settings::minimumAccelerated2dCanvasSize):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):

  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
11:17 Changeset [91637] by rwlbuis@webkit.org

2011-07-23 Rob Buis <rbuis@rim.com>

Freed SVGTRefElement used in SVGStyledElement::buildPendingResourcesIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=64758

Reviewed by Nikolas Zimmermann.

Fix the crash by storing referenced content inside a shadow tree. This way removing child nodes of
the <tref> does not remove the referenced content.

  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • dom/Text.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGShadowText::create): (WebCore::SVGShadowText::SVGShadowText): (WebCore::SVGShadowText::createRenderer): (WebCore::SVGShadowText::recalcStyle): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::childShouldCreateRenderer):
09:21 Changeset [91636] by commit-queue@webkit.org

Source/WebCore: Display number field without using a thousand separator.
https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

Separated formatters for parsing and displaying.
Removed a test for thousand separator.

  • manual-tests/input-number-localization.html:

Removed a test for thousand separator.
Made the test description more specific.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::createFormatterForCurrentLocaleToDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

LayoutTests: Marked fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Mark fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
08:39 Changeset [91635] by commit-queue@webkit.org

[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-23
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

07:54 Changeset [91634] by yutak@chromium.org

[Chromium] Turn on new WebSocket protocol in worker shadow page
https://bugs.webkit.org/show_bug.cgi?id=64852

Reviewed by Dmitry Titov.

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::initializeLoader):
Initialize the value of WebCore::Settings::useHixie76WebSocketProtocol()
for a new shadow page. The default value of this flag is overridden through
WebPreferences (located in webkit/glue in Chromium source tree) but a shadow
page does not receive the preference values from it.

04:18 Changeset [91633] by zimmermann@webkit.org

2011-07-23 Nikolas Zimmermann <nzimmermann@rim.com>

Move several SVG specific tests out of fast/(backgrounds|borders) into svg/(as-background-image|as-border-image) as
we're only running pixel tests for the svg/ subdirectory on a daily base. Also it's easier to spot errors this way.
Updated all Skipped/test_expectations.txt files as well.

Rubber-stamped by Maciej Stachowiak.

  • fast/backgrounds/animated-svg-as-background.html: Removed.
  • fast/backgrounds/resources/animated-rect-fixed-size.svg: Removed.
  • fast/backgrounds/resources/balloon.svg: Removed.
  • fast/backgrounds/resources/eyes.svg: Removed.
  • fast/backgrounds/resources/hearts.svg: Removed.
  • fast/backgrounds/resources/map.svg: Removed.
  • fast/backgrounds/resources/mouse-repel.svg: Removed.
  • fast/backgrounds/svg-as-background-1.html: Removed.
  • fast/backgrounds/svg-as-background-2.html: Removed.
  • fast/backgrounds/svg-as-background-3.html: Removed.
  • fast/backgrounds/svg-as-background-4.html: Removed.
  • fast/backgrounds/svg-as-background-5.html: Removed.
  • fast/backgrounds/svg-as-background-6.html: Removed.
  • fast/borders/resources/large-tiles.png: Removed.
  • fast/borders/resources/tiles-fixed-size.svg: Removed.
  • fast/borders/resources/tiles-relative-size.svg: Removed.
  • fast/borders/resources/tiles.png: Removed.
  • fast/borders/svg-as-border-image-2.html: Removed.
  • fast/borders/svg-as-border-image.html: Removed.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image: Added.
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-linux/svg/as-border-image: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-background-image: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac-leopard/svg/as-border-image: Added.
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image: Added.
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-win/svg/as-background-image: Added.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/chromium-win/svg/as-border-image: Added.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image: Added.
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/gtk/svg/as-border-image: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.png.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/gtk/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac-leopard/svg/as-background-image: Added.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac-leopard/svg/as-border-image: Added.
  • platform/mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/mac/svg/as-background-image: Added.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/mac/svg/as-border-image: Added.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/qt/svg/as-background-image: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/qt/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • svg/as-background-image: Added.
  • svg/as-background-image/animated-svg-as-background.html: Copied from fast/backgrounds/animated-svg-as-background.html.
  • svg/as-background-image/resources: Added.
  • svg/as-background-image/resources/animated-rect-relative-size.svg: Copied from fast/backgrounds/resources/animated-rect-relative-size.svg.
  • svg/as-background-image/resources/balloon.svg: Copied from fast/backgrounds/resources/balloon.svg.
  • svg/as-background-image/resources/butterfly.svg: Copied from svg/as-image/resources/butterfly.svg.
  • svg/as-background-image/resources/circle.svg: Copied from svg/as-image/resources/circle.svg.
  • svg/as-background-image/resources/eyes.svg: Copied from fast/backgrounds/resources/eyes.svg.
  • svg/as-background-image/resources/green-fixed-size-rect.svg: Copied from svg/as-image/resources/green-fixed-size-rect.svg.
  • svg/as-background-image/resources/green-relative-size-rect-with-viewBox.svg: Copied from svg/as-image/resources/green-relative-size-rect-with-viewBox.svg.
  • svg/as-background-image/resources/hearts.svg: Copied from fast/backgrounds/resources/hearts.svg.
  • svg/as-background-image/resources/linguistics.svg: Copied from fast/backgrounds/resources/linguistics.svg.
  • svg/as-background-image/resources/map.svg: Copied from fast/backgrounds/resources/map.svg.
  • svg/as-background-image/resources/mouse-repel.svg: Copied from fast/backgrounds/resources/mouse-repel.svg.
  • svg/as-background-image/resources/svg-as-background-with-relative-size.svg: Copied from svg/as-image/resources/svg-as-background-with-relative-size.svg.
  • svg/as-background-image/resources/width-100-percent.svg: Copied from svg/as-image/resources/width-100-percent.svg.
  • svg/as-background-image/svg-as-background-1.html: Copied from fast/backgrounds/svg-as-background-1.html.
  • svg/as-background-image/svg-as-background-2.html: Copied from fast/backgrounds/svg-as-background-2.html.
  • svg/as-background-image/svg-as-background-3.html: Copied from fast/backgrounds/svg-as-background-3.html.
  • svg/as-background-image/svg-as-background-4.html: Copied from fast/backgrounds/svg-as-background-4.html.
  • svg/as-background-image/svg-as-background-5.html: Copied from fast/backgrounds/svg-as-background-5.html.
  • svg/as-background-image/svg-as-background-6.html: Copied from fast/backgrounds/svg-as-background-6.html.
  • svg/as-background-image/svg-as-background-with-relative-size.html: Copied from svg/as-image/svg-as-background-with-relative-size.html.
  • svg/as-background-image/svg-as-background-with-viewBox.html: Copied from svg/as-image/svg-as-background-with-viewBox.html.
  • svg/as-background-image/svg-as-background.html: Copied from svg/as-image/svg-as-background.html.
  • svg/as-background-image/svg-as-tiled-background.html: Copied from svg/as-image/svg-as-tiled-background.html.
  • svg/as-background-image/svg-background-crash-on-refresh-expected.txt: Copied from svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-background-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html.
  • svg/as-background-image/svg-background-partial-redraw.html: Copied from svg/as-image/svg-background-partial-redraw.html.
  • svg/as-background-image/svg-width-100p-as-background.html: Copied from svg/as-image/svg-width-100p-as-background.html.
  • svg/as-border-image: Added.
  • svg/as-border-image/resources: Added.
  • svg/as-border-image/resources/large-tiles.png: Copied from fast/borders/resources/large-tiles.png.
  • svg/as-border-image/resources/tiles-fixed-size.svg: Copied from fast/borders/resources/tiles-fixed-size.svg.
  • svg/as-border-image/resources/tiles-relative-size.svg: Copied from fast/borders/resources/tiles-relative-size.svg.
  • svg/as-border-image/resources/tiles.png: Copied from fast/borders/resources/tiles.png.
  • svg/as-border-image/svg-as-border-image-2.html: Copied from fast/borders/svg-as-border-image-2.html.
  • svg/as-border-image/svg-as-border-image.html: Copied from fast/borders/svg-as-border-image.html.
  • svg/as-image/resources/butterfly.svg: Removed.
  • svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Removed.
  • svg/as-image/resources/svg-as-background-with-relative-size.svg: Removed.
  • svg/as-image/resources/width-100-percent.svg: Removed.
  • svg/as-image/svg-as-background-with-relative-size.html: Removed.
  • svg/as-image/svg-as-background-with-viewBox.html: Removed.
  • svg/as-image/svg-as-background.html: Removed.
  • svg/as-image/svg-as-tiled-background.html: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh.html: Removed.
  • svg/as-image/svg-background-partial-redraw.html: Removed.
  • svg/as-image/svg-width-100p-as-background.html: Removed.
01:15 Changeset [91632] by tkent@chromium.org

[Chromium] Update expectations for r91574.

  • platform/chromium-win/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt:
  • platform/chromium/test_expectations.txt:

07/22/11:

21:11 Changeset [91631] by rniwa@webkit.org

Add crashing and failing expectations for canvas and css tests after r91628.
The failures are tracked by the bug 65063.

  • platform/chromium/test_expectations.txt:
20:54 Changeset [91630] by rniwa@webkit.org

Add crash expectation for http/tests/media/video-error-abort.html on Chromium Mac and Chromium Windows,
tracked by the bug 65062.

  • platform/chromium/test_expectations.txt:
18:55 Changeset [91629] by jamesr@google.com

[chromium] Seperate texture management for contents textures vs render surface textures
https://bugs.webkit.org/show_bug.cgi?id=64771

Reviewed by Kenneth Russell.

Splits the chromium texture management across two TextureManagers, one for contents textures and one for render
surfaces. The lifetimes and relative evicition costs for these types of textures are significantly different.
Content textures need to be managed from paint time through draw time and evicting them is generally expensive,
since replacing the texture requires doing a software repaint into a buffer, creating a new texture, and
uploading the contents into the texture. Render surface textures are only used while drawing and never contain
useful contents between frames. The only reason to preserve a render surface texture between frames is to avoid
having to create the texture on the next frame, they never contain useful contents across frames.

The contents texture limits remain the same. Render surfaces are allocated the difference between the high
memory bound and the contents texture memory use during a frame and the difference between the low memory bound
and the contents texture memory use between frames.

Covered by existing compositing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::contentsTextureManager):
(WebCore::LayerRendererChromium::renderSurfaceTextureManager):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::createTile):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::prepareContentsTexture):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::setMemoryLimitBytes):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore::TextureManager::create):
(WebCore::TextureManager::currentMemoryUseBytes):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

17:39 Changeset [91628] by simon.fraser@apple.com

2011-07-22 Simon Fraser <simon.fraser@apple.com>

Avoiding painting backgrounds if they are fully obscures by an object's foreground
https://bugs.webkit.org/show_bug.cgi?id=65030

Reviewed by Dan Bernstein.

Some pages use animated loading GIFs as the background of <img>,
but WebKit keeps animating these after the <img> has loaded.

Thwart this by avoiding the painting of such backgrounds, if we can
determine that they are completely obscured by the border and content
of the element.

  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::currentFrameHasAlpha): Utility method, since currentFrame() is protected.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Call paintBackground(). (WebCore::RenderBox::paintBackground): New wrapper for the paintFillLayers() which paints the background layers, plus some code we call in a couple of places. This checks the new backgroundIsObscured() method before doing any painting.
  • rendering/RenderBox.h: (WebCore::RenderBox::backgroundIsObscured): New virtual method that determines whether any of the background is visible.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::BorderEdge::obscuresBackground): Returns true if this edge will entirely hide the background under it. (WebCore::RenderBoxModelObject::borderObscuresBackground): Determine whether the border hides the background.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::backgroundIsObscured): Override the RenderBox method and return true if the image is a loaded, opaque bitmap image, and the background won't show in the border or padding areas.
  • rendering/RenderImage.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Use paintBackground().
17:19 Changeset [91627] by commit-queue@webkit.org

Patch by Sommer Panage <panage@apple.com> on 2011-07-22
Reviewed by Oliver Hunt.

export JSContextCreateBacktrace as SPI in JSContextRefPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=64981

UIAutomation for iOS would like to support a Javascript backtrace in our error logs.
Currently, the C API does not provide the tools to do this. However, the private API
does expose the necessary functionality to get a backtrace
(via Interpreter::retrieveLastCaller). We recognize this information may result in
failure in the cases of programs run by 'eval', stack frames beneath host function
call frames, and in programs run from other programs. Thus, we propose exporting our
JSContextCreateBacktrace in JSContextRefPrivate.h. This will provide us with the tools
we need while not advertising an API that isn't really ready for full use.

17:18 Changeset [91626] by kbr@google.com

HTMLImageElement::crossOrigin is hard to use because of caching
https://bugs.webkit.org/show_bug.cgi?id=64813

Reviewed by Adam Barth.

Source/WebCore:

Reload the resource if the allowCredentials flag doesn't match that in the request.

Test: http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • loader/cache/CachedResourceLoader.h:

LayoutTests:

  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed.html: Added.
17:16 Changeset [91625] by rniwa@webkit.org

Chromium Mac rebaseline after r91605.

  • platform/chromium-mac/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-scale-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
17:10 Changeset [91624] by ojan@chromium.org

Don't match 'DEBUG' when trying to filter BUG modifiers.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
17:01 Changeset [91623] by simon.fraser@apple.com

2011-07-22 Simon Fraser <simon.fraser@apple.com>

Need to update the acceleratesDrawing status on a layer when switching to/from tiled layers
https://bugs.webkit.org/show_bug.cgi?id=65057

Reviewed by Joseph Pecoraro.

When switching to or from tiled layers, we need to update the new layer's
acceleratesDrawing status.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
16:58 Changeset [91622] by ojan@chromium.org

Fix issue loading gtests since there's no g_expectations.
Also, make filing a bug file a webkit.org bug, not a crbug since
the link is only shown for layout tests.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
16:37 Changeset [91621] by jamesr@google.com

[chromium] Remove code that attempted to explicitly sync compositing state before compositing
https://bugs.webkit.org/show_bug.cgi?id=65055

Reviewed by Kenneth Russell.

There was some logic in WebViewImpl to try to synchronously calculate compositing requirements and sync
compositing state on all frames before painting in an attempt to flush out all pending updates before entering
the composite routines. The idea behind this code was that it would allow us to not worry about compositing
turning off in the middle of a composite operation due to things like RenderLayer overlap being lazily
calculated. In practice, we still need to be defensive to compositing requirements updating during the
composite anyway and this code is quite expensive on some pages (10ms+ on the HTML specification on my box).

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::layout):

  • src/WebViewImpl.h:
16:33 Changeset [91620] by ojan@chromium.org

pull test expectations into the dashboard from wvn.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=65054

Reviewed by Adam Barth.

Now that svn.webkit.org supports cors headers, we can just grab the txt
file from there instead of generating a JSON file that we upload
to appengine. We'll stop generating the JSON file in a followup patch.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
16:32 Changeset [91619] by abarth@webkit.org

Fix typo so the tool works on a case-sensitive file system.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
16:30 Changeset [91618] by abarth@webkit.org

garden-o-matic should know what patches are landing
https://bugs.webkit.org/show_bug.cgi?id=64978

Reviewed by Dimitri Glazkov.

This patch adds a display of the recently committed patches to
garden-o-matic. The UI needs iteration, but this patch establishes the
plumbing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
    • Teach trac how to extract more information from the commit log.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
    • Add a data attribute for storing the revision.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
    • Add a container for the recent commit history.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
    • CSS for displaying non-ugly commit history.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
    • Wire up trac to the UI container.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
    • A basic, compact display for a list of commits.
16:26 Changeset [91617] by commit-queue@webkit.org

Add [Optional=CallWithDefaultValues] flag and use it in initXXXEvent declarations
https://bugs.webkit.org/show_bug.cgi?id=64973

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-22
Reviewed by Adam Barth.

We are doing away with the interface-level LegacyDefaultOptionalArguments
flag. To handle some cases of the old behavior, we need to define a new
(argument-level) flag so that functions can define optional arguments
but not have to declare every single combination of arguments in C++.
The old code generator handled this by calling a single C++ function
with all arguments, but with default values for the "optional" arguments.
Thus, this patch invents a new argument-level flag called
[Optional=CallWithDefaultValue] that emulates the old behavior.

This patch also fixes all the initXXXEvent declarations to remove the
LegacyDefaultOptionalArguments flag and use the new
[Optional=CallWithDefaultValue] flag only on the specific arguments that
require it for backward compatibility.

No new tests, all existing tests pass.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • dom/BeforeLoadEvent.idl:
  • dom/BeforeProcessEvent.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/StreamEvent.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • dom/WheelEvent.idl:
  • html/canvas/WebGLContextEvent.idl:
  • storage/StorageEvent.idl:
  • websockets/CloseEvent.idl:
16:22 Changeset [91616] by jberlin@webkit.org

Source/WebCore: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work
https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit2: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work.
https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

  • WebProcess/Cookies/mac/WebCookieManagerMac.mm:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on the Cookie Storage used by the Private Browsing Storage Session as well.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work.
https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

Add a wrapper around the setter for the CF HTTP cookie accept policy (since it is not
declared in the public headers on Snow Leopard). This wrapper is not necessary for Windows.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
16:05 Changeset [91615] by ojan@chromium.org

Fix bug when switching from layout-tests to another test-type if
ToT webkit.org is the selected group.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:59 Changeset [91614] by ojan@chromium.org

Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:42 Changeset [91613] by cdn@chromium.org

Hook v8 up to cryptographicallyRandomValues as an entropy source.
https://bugs.webkit.org/show_bug.cgi?id=64887

Reviewed by Adam Barth.

  • public/WebKitClient.h:
  • src/WebKit.cpp:

(WebKit::generateEntropy):
(WebKit::initialize):

15:31 Changeset [91612] by ojan@chromium.org

simplify the flakiness dashboard to only show modifiers/expectations for the current builder
https://bugs.webkit.org/show_bug.cgi?id=65049

Reviewed by Tony Chang.

This communicates less information, but probably makes the dashboard more usable.
Also make it show that bug lines that don't point to bug numbers still
show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
columns in any view. The data is still used, but only in the view that updates
the test_expectations.txt file.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:23 Changeset [91611] by commit-queue@webkit.org

Perform the JavaScript navigation check on a complete URL
https://bugs.webkit.org/show_bug.cgi?id=65038

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-07-22
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-document-baseURI-javascript.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

LayoutTests:

  • http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt: Added.
  • http/tests/security/xss-DENIED-document-baseURI-javascript.html: Added.
15:22 Changeset [91610] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65051
DFG JIT - Enable by default for mac platform on x86-64.

Rubber Stamped by Geoff Garen.

This is now a performance progression.

  • wtf/Platform.h:
    • Removed definition of ENABLE_DFG_JIT_RESTRICTIONS.
15:17 Changeset [91609] by lforschler@apple.com

Versioning.

15:12 Changeset [91608] by lforschler@apple.com

New tag.

15:08 Changeset [91607] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65047
DFG JIT - Add support for op_resolve/op_resolve_base

Reviewed by Sam Weinig.

These are necessary for any significant eval code coverage
(and as such increase LayoutTest coverage).

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordResolve):

  • Conservatively blow aliasing optimizations for now.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • Add support for op_resolve/op_resolve_base.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • Add call with exec, identifer aguments.
  • dfg/DFGNode.h:
    • Add new node types.

(JSC::DFG::Node::hasIdentifier):

  • Resolve nodes have identifiers, too!
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Add generation for new Nodes.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Added new operations.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Add generation for new Nodes.
14:31 Changeset [91606] by rniwa@webkit.org

Revert r91595 for it broke Chromium Windows build.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
14:28 Changeset [91605] by jchaffraix@webkit.org

RenderLayer fixed position logic needs more basic testing
https://bugs.webkit.org/show_bug.cgi?id=64650

Reviewed by James Robinson.

Those test checks that basic repainting with position: fixed and
scrolling works correctly. The tests are mostly platform-agnostic as they
don't use any text or native controls.

  • fast/repaint/resources/default.css: Added.

Default style sheet for the following tests. This style sheet sets the default size to
avoid complicated calculation and adds some neat classes.

  • fast/repaint/fixed-scroll-simple.html: Added.

Filed https://bugs.webkit.org/show_bug.cgi?id=64639 about this test as we repaint too much.

  • fast/repaint/fixed-after-scroll-expected.txt: Added.
  • fast/repaint/fixed-after-scroll.html: Added.
  • fast/repaint/fixed-scale.html: Added.
  • fast/repaint/fixed-table-cell.html: Added.
  • fast/repaint/fixed-table-overflow-zindex.html: Added.
  • fast/repaint/fixed-table-overflow.html: Added.

Added those new repaint dumpAsText(true) tests.

  • fast/repaint/fixed-scale-expected.txt: Added.
  • fast/repaint/fixed-scroll-simple-expected.txt: Added.
  • fast/repaint/fixed-table-cell-expected.txt: Added.
  • fast/repaint/fixed-table-overflow-expected.txt: Added.
  • fast/repaint/fixed-table-overflow-zindex-expected.txt: Added.
  • platform/chromium/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-scale-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
  • platform/mac/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-scale-expected.png: Added.
  • platform/mac/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
  • platform/qt/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-scale-expected.png: Added.
  • platform/qt/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
14:25 Changeset [91604] by rniwa@webkit.org

Chromium test expectation update; also rebaseline a test after r91574.

  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
14:21 WebKit Team edited by rwlbuis@webkit.org
(diff)
13:51 Changeset [91603] by lforschler@apple.com

Merge r87171.

13:49 Changeset [91602] by lforschler@apple.com

Merge r87103.

13:27 Changeset [91601] by commit-queue@webkit.org

BORDER attribute with the IMG tag, using percentage values not working.
https://bugs.webkit.org/show_bug.cgi?id=20226

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-22
Reviewed by Simon Fraser.

When border presentational attribute of image element has % in it, it should be parsed using
HTML parser rules. In this case, the algorithm is the one used described in:
http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-non-negative-integers

Source/WebCore:

  • html/HTMLImageElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLNonNegativeInteger):

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

  • fast/images/border-expected.txt:
  • fast/images/script-tests/border.js:
13:17 Changeset [91600] by commit-queue@webkit.org

DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste
https://bugs.webkit.org/show_bug.cgi?id=61894

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-22
Reviewed by James Robinson.

DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs
that have passed through FrameLoader::dispatchWillSendRequest() and is
used by FrameLoader::loadedResourceFromMemoryCached to decide whether
to inform the FrameLoader's m_client about this load. Unfortunately,
this set holds a reference to the URL string for every resource
loaded, so on pages that use data URLs to "load" large amounts of data
this leaks lots of memory. The cache improves performance going through
FrameLoader::loadResourceFromMemoryCache, so rather than removing it,
simply exclude 'data:' urls from the cache to save the majority of
memory that is held for too long.

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::didTellClientAboutLoad):

13:04 Changeset [91599] by alokp@chromium.org

Use software rendering for small canvas
https://bugs.webkit.org/show_bug.cgi?id=64958

Reviewed by Stephen White.

No new tests. Does not affect rendering output, just canvas backing.
If there is a regression, they should be caught by existing canvas tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldAccelerateCanvas):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):

  • html/canvas/CanvasRenderingContext2D.h:
12:57 Changeset [91598] by japhet@chromium.org

2011-07-22 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium expectations update.
media/adopt-node-crash.html hasn't been flaky recently.

  • platform/chromium/test_expectations.txt:
12:52 Changeset [91597] by enne@google.com

Fix repainting of composited fixed position elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=64010

Reviewed by Simon Fraser.

Source/WebCore:

In cases where an iframe's contents have their own graphics layer, the
invalidation during scrolling was being sent to the wrong render
layer. Fixed by checking if such a layer exists and routing scrolling
invalidations there first.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsSlowPath):

LayoutTests:

  • compositing/iframes/fixed-position-iframe-expected.png: Added.
  • compositing/iframes/fixed-position-iframe-expected.txt: Added.
  • compositing/iframes/fixed-position-iframe.html: Added.
  • compositing/iframes/resources/fixed-position-subframe.html: Added.
12:47 Changeset [91596] by lforschler@apple.com

Merge 91146.

12:42 Changeset [91595] by commit-queue@webkit.org

Improve (i.e., speed up) .gyp(i) files for Chromium
https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2011-07-22
Reviewed by Adam Barth.

Begin splitting off webcore_(privateheader_)files into separate lists
(dom/html/svg in this patch), to avoid the very slow pattern of
excluding all files and then filtering to include selected files.

Test by building (in all supported configurations).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:35 Changeset [91594] by tony@chromium.org

add placeholder RenderFlexibleBox.cpp files
https://bugs.webkit.org/show_bug.cgi?id=64982

Reviewed by Ojan Vafai.

No new tests, just adding new files and making sure it compiles.
Also adding the isFlexibleBox identifier to RenderObject.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFlexibleBox.cpp: Added.

(WebCore::RenderFlexibleBox::RenderFlexibleBox): Inherit from RenderBlock like the old flexbox.
(WebCore::RenderFlexibleBox::~RenderFlexibleBox):
(WebCore::RenderFlexibleBox::renderName):
(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.h: Added.

(WebCore::RenderFlexibleBox::isFlexibleBox):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBox):

12:31 Changeset [91593] by lforschler@apple.com

Merge r91066.

12:29 Changeset [91592] by lforschler@apple.com

Merge r91005.

12:26 Changeset [91591] by jamesr@google.com

[chromium] Force slow scrolling path for non-composited frames in a composited page
https://bugs.webkit.org/show_bug.cgi?id=64991

Reviewed by Darin Fisher.

The chromium compositor does not properly handle fast path scrolls for non-composited iframe in a composited
page.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

12:25 Changeset [91590] by lforschler@apple.com

Merge r90936.

12:23 Changeset [91589] by lforschler@apple.com

Merge r90914.

12:21 Changeset [91588] by lforschler@apple.com

Merge r90851.

12:20 Changeset [91587] by lforschler@apple.com

Merge r90797.

12:16 Changeset [91586] by ojan@chromium.org

hook in the rest of the bots to the dashboard now they run NRWT
https://bugs.webkit.org/show_bug.cgi?id=64985

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/builders.js:
12:15 Changeset [91585] by weinig@apple.com

Update results after change to make columns and column-span establish
formatting contexts in r91497

  • fast/multicol/single-line-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/scrolling-overflow-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
12:07 Changeset [91584] by scherkus@chromium.org

Remove surfaceType() and texture() methods from Chromium video frame classes.
https://bugs.webkit.org/show_bug.cgi?id=64818

Reviewed by Kenneth Russell.

Source/WebCore:

No tests as code was never being executed.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp:
  • src/VideoFrameChromiumImpl.h:
12:01 Changeset [91583] by japhet@chromium.org

Source/WebCore: Don't treat child frame loads as back-forward navigations
after the load event fires. This can lead to loading
the wrong url in the child frame.
https://bugs.webkit.org/show_bug.cgi?id=64895

Reviewed by Mihai Parparita.

Test: fast/loader/child-frame-add-after-back-forward.html

  • dom/Document.h: Drive-by FIXME.
  • loader/DocumentLoader.h: Drive-by FIXME.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURLIntoChildFrame):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64895.

Reviewed by Mihai Parparita.

  • fast/loader/child-frame-add-after-back-forward-expected.txt: Added.
  • fast/loader/child-frame-add-after-back-forward.html: Added.
11:42 Changeset [91582] by lforschler@apple.com

Merge r90573.

11:32 Changeset [91581] by lforschler@apple.com

Merge r90486.

11:30 Changeset [91580] by lforschler@apple.com

Merge r90282.

11:28 Changeset [91579] by lforschler@apple.com

Merge r90273.

11:25 Changeset [91578] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65036
Messing with the register allocation within flow control = badness.

Reviewed by Sam Weinig.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Fix register allocation.
11:12 Changeset [91577] by ap@apple.com

Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:00 Changeset [91576] by commit-queue@webkit.org

Date.prototype.toISOString doesn't handle negative years or years > 9999 correctly.
https://bugs.webkit.org/show_bug.cgi?id=63986

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-22
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Changed the implementation of Date.prototype.toISOString() to use the extended year
format (+/-yyyyyy) for years outside of [0,9999] to be in compliance with ES 15.9.1.15.1.

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

LayoutTests:

Changed the implementation of Date.prototype.toISOString() to use the extended year
format (+/-yyyyyy) for years outside of [0,9999] to be in compliance with ES 15.9.1.15.1.
Altered one test that tested for incorrect behavior on years > 9999, and added another test for
years < 0 (i.e. BCE).

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:
10:55 Changeset [91575] by inferno@chromium.org

Merge 91571 - Fix crash in IDBRequest::abort

BUG=89511
Review URL: http://codereview.chromium.org/7488021

10:54 Changeset [91574] by commit-queue@webkit.org

REGRESSION(r88757): The thumb of a vertical range slider is offset to the right on non-Mac.
https://bugs.webkit.org/show_bug.cgi?id=65011

Patch by Kent Tamura <tkent@google.com> on 2011-07-22
Reviewed by Dimitri Glazkov.

Source/WebCore:

We need to update the apeearance of thumbs before the layout of RenderSlider.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):
Added. This function adjsuts the apparance of a thumb for the appearance of an <input>.
(WebCore::RenderSliderThumb::isSliderThumb):
Added. Returns true.
(WebCore::RenderSliderThumb::layout):
Remove the appearance adjustment code. It is unnecessary because it is
done in RenderSlider::layout().
(WebCore::trackLimiterElementOf): Added.

  • html/shadow/SliderThumbElement.h: Move RenderSliderThumb from SliderThumbElement.cpp.
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSliderThumb): Added. Returns false.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):
If the renderers for the thumb element and the limiter element is
RenderSliderThumb, updates its appearance.

LayoutTests:

  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.txt:
  • platform/chromium/test_expectations.txt:
10:46 Changeset [91573] by tkent@chromium.org

Validation message bubble is incorrectly positioned in a relative body.
https://bugs.webkit.org/show_bug.cgi?id=65018

Reviewed by Dimitri Glazkov.

Source/WebCore:

We use position:aboslute for validation message bubbles, and the
origin of the absolute position can be not only the page, but also
an ancestor block with non-static position.

Test: fast/forms/validation-message-in-relative-body.html

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
Subtract the containing block position from the host position.
(WebCore::ValidationMessage::buildBubbleTree):
Change the order of appendChild() and adjustBubblePosition() in
order to use RenderObject::containingBlock() in
adjustbubbleposition().

LayoutTests:

  • fast/forms/validation-message-in-relative-body-expected.txt: Added.
  • fast/forms/validation-message-in-relative-body.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:31 Changeset [91572] by commit-queue@webkit.org

Source/WebKit/efl: [EFL] ewk_frame_hit_test_new enhancement
https://bugs.webkit.org/show_bug.cgi?id=64260

Replaces structure 'flags' with enum 'context' containing more hit test
result types and adds new char* fields to Ewk_Hit_Test structure:
image_uri and media_uri.

Patch by Michal Pakula vel Rutka <m.pakula@samsung.com> on 2011-07-22
Reviewed by Antonio Gomes.

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):

  • ewk/ewk_frame.h:

Tools: [EFL] ewk_frame_hit_test_new enchancement
https://bugs.webkit.org/show_bug.cgi?id=64260

Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
Replacing Ewk_Hit_Test_Result_Context structure 'flags'
in hit test output to by enum 'context'.

Patch by Michal Pakula vel Rutka <m.pakula@samsung.com> on 2011-07-22
Reviewed by Antonio Gomes.

  • EWebLauncher/main.c:

(on_key_down):

10:07 Changeset [91571] by commit-queue@webkit.org

Fix crash in IDBRequest::abort
https://bugs.webkit.org/show_bug.cgi?id=64740

Patch by David Grogan <dgrogan@chromium.org> on 2011-07-22
Reviewed by Nate Chapin.

Tested manually with the testcase in the bug.

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::abort):

08:50 Changeset [91570] by paroga@webkit.org

Replace preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=64961

Reviewed by Darin Adler.

Replaced ENABLE_DATALIST, ENABLE_DIRECTORY_UPLOAD, ENABLE_INPUT_SPEECH, ENABLE_MEDIA_STATISTICS
and ENABLE_ORIENTATION_EVENTS with the corresponding Conditional attribute.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.idl:
08:38 Changeset [91569] by caseq@chromium.org

011-07-22 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] add webInspector.resources.onContentEdited
https://bugs.webkit.org/show_bug.cgi?id=65024

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyResourceContentEdited):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.addRevision):

2011-07-22 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] add webInspector.resources.onContentEdited
https://bugs.webkit.org/show_bug.cgi?id=65024

Reviewed Pavel Feldman.

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
08:29 Changeset [91568] by podivilov@chromium.org

Web Inspector: fix exception when paused in internal script.
https://bugs.webkit.org/show_bug.cgi?id=64995

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/pause-in-internal-script.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresenationCallFrame.prototype.sourceLine):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/pause-in-internal-script-expected.txt: Added.
  • inspector/debugger/pause-in-internal-script.html: Added.
08:19 Changeset [91567] by loislo@chromium.org

Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
https://bugs.webkit.org/show_bug.cgi?id=65016

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-receive-response-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::appendRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.dump):

  • inspector/timeline/resources/anImage.png: Added.
  • inspector/timeline/resources/anotherImage.png: Added.
  • inspector/timeline/timeline-receive-response-event-expected.txt: Added.
  • inspector/timeline/timeline-receive-response-event.html: Added.
  • platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
06:40 Changeset [91566] by commit-queue@webkit.org

REGRESSION(r89535): Form reset does not repaint a file upload control.
https://bugs.webkit.org/show_bug.cgi?id=65008

Patch by Kentaro Hara <haraken@google.com> on 2011-07-22
Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected.

Tests: fast/forms/file-input-reset.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Calls repaint() if no files are selected.

LayoutTests:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected. The added test checks
if the label next to the file chooser button becomes "No file chosen"
when we press the reset button.

  • fast/forms/file-input-reset-expected.html: Added.
  • fast/forms/file-input-reset.html: Added.
06:38 Changeset [91565] by loislo@chromium.org

Web Inspector: the max depth of the Timeline events' stack trace should be customizable.
https://bugs.webkit.org/show_bug.cgi?id=65023

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::startTimelineProfiler):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):

03:53 Changeset [91564] by jknotten@chromium.org

[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65020

Create WebKit bug for slow/timing out layout tests:
editing/execCommand/4786404-1.html and
editing/execCommand/break-out-of-empty-list-item.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
02:59 Changeset [91563] by rniwa@webkit.org

Unreviewed. Rolled DEPS.

  • DEPS:
01:48 Changeset [91562] by loislo@chromium.org

Unreviewed, rolling out r91024.
http://trac.webkit.org/changeset/91024
https://bugs.webkit.org/show_bug.cgi?id=65017

number of problems happened with invisible elements which grab
pointer events. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-22

  • inspector/front-end/inspector.css:

(.panel):
(.panel.visible):

01:34 Changeset [91561] by rniwa@webkit.org

Another Chromium rebaselines after r91493.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
00:30 Changeset [91560] by rniwa@webkit.org

Revert r91510 due to Chromium debug test failures.

  • src/WebKit.cpp:

(WebKit::initialize):

00:16 Changeset [91559] by jpu@apple.com

Reviewed by Darin Adler.

[Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode().
https://bugs.webkit.org/show_bug.cgi?id=64824
<rdar://problem/9624232>

  • editing/Editor.cpp:

(WebCore::Editor::textFieldDidEndEditing): Dismiss autocorrection panel when current node losing focus.

07/21/11:

23:55 Changeset [91558] by barraclough@apple.com

Windows build fix

23:28 Changeset [91557] by rniwa@webkit.org

Build fix after r91555.

22:35 Changeset [91556] by tkent@chromium.org

A trivial fix for r91550.
https://bugs.webkit.org/show_bug.cgi?id=65001

Source/WebCore:

Need to update placeholder visibility when the owner elemnent style is changed.

  • html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):
Call updatePlaceholderVisibility().

LayoutTests:

  • platform/chromium/test_expectations.txt:
22:34 Changeset [91555] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=19271
eliminate PIC branches by changing NaN handling in JSValue::toNumber

Reviewed by Sam Weinig.

Moving the non-numeric cases out of line seems to be a consistent
win on SunSpider for me, to the order of about 0.5%.

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toNumber):

  • Changed to only handle values that are already numbers, moce non-numeric cases out of line.
  • runtime/JSValue.cpp:

(JSC::JSValue::toNumberSlowCase):

  • Added toNumberSlowCase, handling non-numeric cases.
  • runtime/JSValue.h:
    • Add declaration of toNumberSlowCase.
22:27 Changeset [91554] by psolanki@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65002
Get authentication to work with USE(CFNETWORK) on Mac

Reviewed by David Kilzer.

Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
one given to us by CFNetwork.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
new CFURLAuthChallengeRef ivar.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
(WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
(WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
creating a new one.

22:24 Changeset [91553] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64875
Use of yield keyword is broken

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseIdentifier):

  • The bug here is that a successful match of a RESERVED_IF_STRICT token from parseKeyword is being nullified back to IDENT. The problem is that in the case of IDENT matches parseKeyword should not move the lexer's input position, but in the case of RESERVED_IF_STRICT it has done so.

LayoutTests:

  • fast/js/reserved-words-as-property-expected.txt:
  • fast/js/script-tests/reserved-words-as-property.js:
    • Make this test more comprehensive, to cover future-reserved & non-reserved words.
22:06 Changeset [91552] by rniwa@webkit.org

Add a failing expectation for fast/forms/placeholder-in-invisible-elements.html
added by r91550 on Chromium. The failure is tracked by the bug 65010.

  • platform/chromium/test_expectations.txt:
21:55 Changeset [91551] by rniwa@webkit.org

Remove wrong test expectation added in r91490.

Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009.

  • platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Removed.
  • platform/chromium/test_expectations.txt
20:31 Changeset [91550] by tkent@chromium.org

REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
https://bugs.webkit.org/show_bug.cgi?id=65001

Reviewed by Dimitri Glazkov.

Source/WebCore:

Tests: fast/forms/placeholder-in-invisible-elements.html

fast/forms/search-cancel-in-invisible-elements.html

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Don't show the placeholder if the 'visibility' property of the owner element is 'hidden.'

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::visibilityForCancelButton): ditto.

LayoutTests:

  • fast/forms/placeholder-in-invisible-elements-expected.html: Added.
  • fast/forms/placeholder-in-invisible-elements.html: Added.
  • fast/forms/search-cancel-in-invisible-elements-expected.html: Added.
  • fast/forms/search-cancel-in-invisible-elements.html: Added.
20:27 Changeset [91549] by commit-queue@webkit.org

The input[type="number"] with step="any" should not suffer from step mismatch.
https://bugs.webkit.org/show_bug.cgi?id=64858

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-21
Reviewed by Kent Tamura.

Source/WebCore:

Added check step="any" not to suffer from step mismatch.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep): Added check step="any".
(WebCore::HTMLInputElement::alignValueForStep): Added.

LayoutTests:

Added test cases of input[type="number"] with step="any"

  • fast/forms/input-stepup-stepdown-expected.txt: added the test cases.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
20:12 Changeset [91548] by morrita@google.com

[Refactoring] ShadowContentSelector should be ShadowInclusionSelector
https://bugs.webkit.org/show_bug.cgi?id=64850

Reviewed by Dimitri Glazkov.

Renamed:

  • ShadowContentSelector -> ShadowInclusionSelector
  • ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor
  • ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select
  • ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect
  • ShadowContentSelector::didSelectInclusion -> ShadowInclusionSelector::didSelect
  • ShadowContentSelector::willSelectInclusionOver -> ShadowInclusionSelector::willSelectOver
  • ShadowContentSelector::hasChildren -> ShadowInclusionSelector::hasCandidates

No new tests. Just a textual change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/NodeRenderingContext.cpp:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowContentSelector.cpp.

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowInclusionSelector::ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::~ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::select):
(WebCore::ShadowInclusionSelector::unselect):
(WebCore::ShadowInclusionSelector::findFor):
(WebCore::ShadowInclusionSelector::didSelect):
(WebCore::ShadowInclusionSelector::willSelectOver):

  • dom/ShadowInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowContentSelector.h.

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowInclusionSelector::hasCandidates):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:
20:00 Changeset [91547] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=60737

ThumbPosition() in ScrollbarTheme should be ceiled before returned.
Otherwise, some topest/leftest content can not be shown by dragging
scrollbar thumb.

Source/WebCore:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

Test: scrollbars/scrollbar-drag-thumb-with-large-content.html

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbPosition):

  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarThemeQt::thumbPosition):

LayoutTests:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

  • scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt: Added.
  • scrollbars/scrollbar-drag-thumb-with-large-content.html: Added.
19:46 Changeset [91546] by aroben@apple.com

Fix typo in TestFailures

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
18:34 Changeset [91545] by rniwa@webkit.org

Chromium test expectation update after r91533.
fast/css/absolute-child-with-percent-height-inside-relative-parent.html is missing a pixel result.
A patch to add the pixel result has been uploaded to the bug 64046.

  • platform/chromium/test_expectations.txt:
18:12 Changeset [91544] by lforschler@apple.com

Versioning.

18:11 Changeset [91543] by lforschler@apple.com

New tag.

18:02 Changeset [91542] by simon.fraser@apple.com

GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489

Reviewed by James Robinson.

Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
for subframes, when those GraphicsLayers are rooted in the
parent document.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
that contains the rootmost frame on which sync was called. This is used
to indicate to the compositor whether it's the root of the sync.
(WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
Frame in.
(WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.

  • page/FrameView.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
to specify whether this compositor is in the rootmost Frame being flushed.
We can avoid doing work if we know that flushing some ancestor frame would
have also traversed our GraphicsLayers.

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
callers are probably most intersted in enclosingCompositorFlushingLayers().

17:48 Changeset [91541] by ojan@chromium.org

simplify gtest display now that we strip modifiers from the JSON
https://bugs.webkit.org/show_bug.cgi?id=64990

Reviewed by Adam Barth.

Now that names are normalized, we can remove all the code that
handles gtest name changes (e.g. for adding modifiers like DISABLED_).
Instead, if you try to list a test with a modifier in it, we need
to strip the modifier so we get the normalized value.

We also get rid of the concept of extra/missing expectations for gtests.
In a patch soon, we'll stop showing extra/missing expectations from the UI
entirely and only leave it for the special updating test_expectations.txt
view of the dashboard, which doesn't apply to gtests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
17:40 Changeset [91540] by commit-queue@webkit.org

Local files cannot load icons.
https://bugs.webkit.org/show_bug.cgi?id=62459

Previous policy only allowed favicons for pages whose protocol was part of HTTP family.
Changed that to allow to any url that's not empty and whose protocol is not "about".
Also added this check where it attempts to start loading the favicon, so it can avoid
wasting time downloading a resource that won't be stored and won't be used.

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-07-21
Reviewed by Adam Barth.

Test: manual-tests/resources/favicon-loads-for-local-files.html

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Added check to avoid to request a favicon
when there's no way to store it.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon"
to reflect better which url we're handling.

(WebCore::IconDatabase::synchronousIconForPageURL): Ditto.
(WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
(WebCore::IconDatabase::retainIconForPageURL): Ditto.
(WebCore::IconDatabase::releaseIconForPageURL): Ditto.
(WebCore::IconDatabase::setIconURLForPageURL): Ditto.
(WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
(WebCore::IconDatabase::importIconURLForPageURL): Ditto.
(WebCore::IconDatabase::performURLImport): Ditto.

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its
default behavior of not allowing favicons when we have IconDatabase enabled.

  • manual-tests/resources/favicon-loads-for-local-files.html: Added.
  • manual-tests/resources/favicon.png: Added.
17:36 Changeset [91539] by lforschler@apple.com

Merge r90198.

17:29 Changeset [91538] by abarth@webkit.org

Refactor Trac.js for use in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64998

Reviewed by Adam Roben.

This patch refactors Trac.js to match the architecture and style of
garden-o-matic. I've also factored AsynchronousCache out of Trac (and
moved it to base) because it was redundant with some other code we
already had.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

(FailingTestsBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
17:23 Changeset [91537] by lforschler@apple.com

Merge r90166.

17:21 Changeset [91536] by lforschler@apple.com

Merge r90156.

17:18 Changeset [91535] by lforschler@apple.com

Merge r90130.

17:15 Changeset [91534] by lforschler@apple.com

Merge r90087.

17:14 Changeset [91533] by commit-queue@webkit.org

Source/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests: Test to cover absolutely positioned child with percentage height
in relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

  • fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.
17:00 Changeset [91532] by mdelaney@apple.com

Changelog fix for 91496

16:53 Changeset [91531] by gavinp@chromium.org

Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.

https://bugs.webkit.org/show_bug.cgi?id=64736

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/css-imports-2.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::checkLoaded):

LayoutTests:

  • fast/css/css-imports-2-expected.txt: Added.
  • fast/css/css-imports-2.html: Added.
16:29 Changeset [91530] by rniwa@webkit.org

Temporarily add failing test expectation for multi column tests after r91497.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [91529] by ojan@chromium.org

Fix issue throwing a 500 to the bots. We were modifying
the dictionary during an iteration over it's keys and would get
RuntimeError: dictionary changed size during iteration

  • TestResultServer/model/jsonresults.py:
16:21 Changeset [91528] by rniwa@webkit.org

Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg.

  • platform/chromium/test_expectations.txt:
16:14 Changeset [91527] by lforschler@apple.com

Merge r90068.

15:57 Changeset [91526] by abarth@webkit.org

ORWT fails to consume some NRWT arguments
https://bugs.webkit.org/show_bug.cgi?id=64988

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests:
15:34 Changeset [91525] by jberlin@webkit.org

Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Yet another spinbutton test ...

  • platform/win/Skipped:
15:31 Changeset [91524] by abarth@webkit.org

Merge TestFailures and garden-o-matic unit tests harness
https://bugs.webkit.org/show_bug.cgi?id=64984

Reviewed by Adam Roben.

One unit testing framework is better than two.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
15:27 Changeset [91523] by lforschler@apple.com

Merge r90038.

15:24 Changeset [91522] by lforschler@apple.com

Merge r89836.

15:22 Changeset [91521] by jberlin@webkit.org

Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Add another spinbutton test to the Skipped list to get the bots green.

  • platform/win/Skipped:
15:22 Changeset [91520] by lforschler@apple.com

Merge r89831.

15:20 Changeset [91519] by abarth@webkit.org

Rubber-stamped by Adam Roben.

Move garden-o-matic files into the same directory as TestFailures to
make it easier to integrate the codebases.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
  • Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
15:13 Changeset [91518] by ojan@chromium.org

fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832

Reviewed by Tony Chang.

Make them actual anchor tags and linkify the test name instead of
adding an extra link. Also simplify the update view since we now
show the linkified test name.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:09 Changeset [91517] by lforschler@apple.com

Merge r89780.

15:09 Changeset [91516] by abarth@webkit.org

webkit.org builders should upload results to test-results AppEngine instance
https://bugs.webkit.org/show_bug.cgi?id=64979

Reviewed by Adam Roben.

The master just needs to pass some flags to NRWT. This patch also lets
ORWT consume the flags (ignoring them) so we can pass the flags
unconditionally.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/old-run-webkit-tests:
15:02 Changeset [91515] by ojan@chromium.org

normalize gtest names in the result json
https://bugs.webkit.org/show_bug.cgi?id=64971

Reviewed by Eric Seidel.

This will make the resulting JSON smaller and make the
flakiness dashboard much more sane (e.g. we won't need to
show you the FLAKY_ version and the normal version).

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
15:01 Changeset [91514] by lforschler@apple.com

Merge r89769.

14:59 Changeset [91513] by lforschler@apple.com

Merge r89720.

14:58 Changeset [91512] by lforschler@apple.com

Merge r89614.

14:54 Changeset [91511] by lforschler@apple.com

Merge r89595.

14:53 Changeset [91510] by cdn@chromium.org

2011-07-20 Cris Neckar <cdn@chromium.org>

Hook v8 up to cryptographicallyRandomValues as an entropy source.
https://bugs.webkit.org/show_bug.cgi?id=64887

Reviewed by Adam Barth.

  • src/WebKit.cpp: (WebKit::generateEntropy): (WebKit::initialize):
14:50 Changeset [91509] by lforschler@apple.com

Merge r89492.

14:48 Changeset [91508] by eric@webkit.org

Unreviewed. Reenable ORWT for the --leaks bot.
Something is still wrong with the leaks summarizing
but I'm about to head out on vacation for 2 weeks,
so it's best to just revert back to ORWT until I'm back.

  • Scripts/run-webkit-tests:

(usingLeaks):
(useNewRunWebKitTests):

14:48 Changeset [91507] by lforschler@apple.com

Merge r89474.

14:46 Changeset [91506] by lforschler@apple.com

Merge r89397.

14:44 Changeset [91505] by lforschler@apple.com

Merge r89313.

14:43 Changeset [91504] by kbr@google.com

Update webglcontextlost / webglcontextrestored delivery to match spec changes
https://bugs.webkit.org/show_bug.cgi?id=58621

Reviewed by James Robinson.

Source/WebCore:

Updated conditions under which webglcontextrestored event is
delivered to be spec compliant.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated layout test to test spec compliant behavior.

  • fast/canvas/webgl/context-lost-restored-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
14:42 Changeset [91503] by lforschler@apple.com

Merge r89165.

14:38 Changeset [91502] by lforschler@apple.com

Merge r89067.

14:37 Changeset [91501] by lforschler@apple.com

Merge r88987.

14:34 Changeset [91500] by lforschler@apple.com

Merge r88667.

14:33 Changeset [91499] by lforschler@apple.com

Merge r88601.

14:21 Changeset [91498] by rniwa@webkit.org

Chromium rebaselines after r91493.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91497] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64975
Elements that have columns (e.g., column-width or column-count non-auto) and elements that have
column-spans establish block formatting contexts, and therefore they should not be allowing
child margins to collapse with their own margins.

Reviewed by Beth Dakin.

Covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

13:49 Changeset [91496] by mdelaney@apple.com

Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

  • platform/graphics/ImageBuffer.h:

1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.

  • platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
  • platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

  • platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:

  • platform/graphics/qt/ImageBufferQt.cpp
  • platform/graphics/filters/FETile.cpp
  • platform/graphics/cairo/ImageBufferCairo.cpp
  • platform/graphics/skia/ImageBufferSkia.cpp
  • platform/graphics/wx/ImageBufferWx.cpp
  • platform/graphics/wince/ImageBufferWinCE.cpp
  • svg/SVGFEImageElement.cpp
  • svg/graphics/SVGImage.cpp
  • html/HTMLCanvasElement.cpp
  • html/canvas/WebGLRenderingContext.cpp
  • rendering/svg/RenderSVGResourcePattern.cpp
13:31 Changeset [91495] by rniwa@webkit.org

Chromium test expectations update after rolling out r91285 and r91332.

  • platform/chromium/test_expectations.txt:
13:23 Changeset [91494] by ddkilzer@apple.com

<http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output

Reviewed by Eric Seidel.

  • html/parser/create-html-entity-table:
  • Fix duplicate "EntityName" suffix on local variables (changes fooSemicolonEntityNameEntityName to fooSemicolonEntityName) for all 2138 symbols.
  • Add newlines to make source file human-readable (as originally intended).
  • Add static (const) keywords to local variables that are never referenced externally.
13:12 Changeset [91493] by rwlbuis@webkit.org

2011-07-21 Rob Buis <rbuis@rim.com>

Fix SVG Font resources link in W3C SVG 1.1SE tests
https://bugs.webkit.org/show_bug.cgi?id=64953

Reviewed by Dirk schulze.

  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • svg/W3C-SVG-1.1-SE/color-prop-05-t.svg:
  • svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg:
  • svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg:
  • svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg:
  • svg/W3C-SVG-1.1-SE/painting-control-04-f.svg:
  • svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg:
  • svg/W3C-SVG-1.1-SE/struct-use-14-f.svg:
  • svg/W3C-SVG-1.1-SE/styling-css-04-f.svg:
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-02-b.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-05-t.svg:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1-SE/text-tref-03-b.svg:
  • svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg:
13:11 Changeset [91492] by jonlee@apple.com

Create a new survey page that showcases form and interactive elements for quick reference and comparison.
<rdar://problem/9782965>

Rubber-stamped by Maciej Stachowiak.

  • projects/forms/image-usemap.png: Added.
  • projects/forms/image1.png: Added.
  • projects/forms/image10.png: Added.
  • projects/forms/image16.png: Added.
  • projects/forms/index.html: Update links
  • projects/forms/survey.html: Added.
12:45 Changeset [91491] by ojan@chromium.org

cleanup jsonresults.py style in preparation for making some changes
https://bugs.webkit.org/show_bug.cgi?id=64968

Reviewed by Adam Barth.

No code changes. Unittest still passes. Mostly just removing
useless comments and 80 character wrapping.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
12:30 Changeset [91490] by rniwa@webkit.org

More Chromium rebaselines for r91474.

  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-win-xp/fast/events: Added.
  • platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Added.
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
12:22 Changeset [91489] by abarth@webkit.org

Add missing column header.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
12:15 Changeset [91488] by eric@webkit.org

Unreviewed. Just fixing (and unittesting) a previous typo.

Fix typo in print_leaks_summary regexp which was causing
leaks summarizing to fail on the --leaks bot.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
12:14 Changeset [91487] by abarth@webkit.org

garden-o-matic should be able to rebaseline many tests at once
https://bugs.webkit.org/show_bug.cgi?id=64963

Reviewed by Dimitri Glazkov.

This patch contains some UI for rebaselining tests in bulk. I don't
expect this UI to be the final UI, but the underlying infrastructure
will be useful.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
12:13 Changeset [91486] by commit-queue@webkit.org

Remove LegacyDefaultOptionalArguments flag from FileAPI
https://bugs.webkit.org/show_bug.cgi?id=64539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-21
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/EntriesCallback.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/EntryCallback.idl:
  • fileapi/EntrySync.idl:
  • fileapi/ErrorCallback.idl:
  • fileapi/FileCallback.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • fileapi/FileSystemCallback.idl:
  • fileapi/FileWriter.idl:
  • fileapi/FileWriterCallback.idl:
  • fileapi/FileWriterSync.idl:
  • fileapi/MetadataCallback.idl:
  • fileapi/WebKitBlobBuilder.idl:
12:12 Changeset [91485] by tony@chromium.org

sort WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=64901

Unreviewed, just using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
12:04 Changeset [91484] by rniwa@webkit.org

Disable failing new test on mac/win ports
https://bugs.webkit.org/show_bug.cgi?id=64882

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-21
Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
11:59 Changeset [91483] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64900
Function.prototype.apply should accept an array-like object as its second argument

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply):

  • Remove the type error if object is not an array.

LayoutTests:

  • fast/js/function-apply-expected.txt:
  • fast/js/script-tests/function-apply.js:
    • Add a test for array-like objects.
  • sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T4-expected.txt:
    • These tests are incorrect & assert ES3 behaviour.
11:57 Changeset [91482] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=64964
DFG JIT - Enable support for eval code

Reviewed by Sam Weinig.

This is basically the same as program code, to the JIT!

  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
    • Enable opcodeNames in !NDEBUG builds.
  • dfg/DFGOperations.cpp:
    • Fix a bug exposed by eval support, throw correct type error for new.
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):

  • Enable DFG JIT for eval code.
11:45 Changeset [91481] by enrica@apple.com

Cannot click to position the caret to the right of an image with display:block style.
https://bugs.webkit.org/show_bug.cgi?id=64962
<rdar://problem/9446343>

Reviewed by David Hyatt.

Source/WebCore:

Test: editing/selection/click-on-block-image.html

The current implementation of positionForPoint always returns the visible
position to the left of the image, if the image has a block style.
This patch changes the behavior for block styled images to match the behavior
for inline images.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint): Modified to avoid relying entirely
on InlineBox to calculate the position.

LayoutTests:

  • editing/selection/click-on-block-image-expected.txt: Added.
  • editing/selection/click-on-block-image.html: Added.
11:37 Changeset [91480] by rniwa@webkit.org

Chromium rebaseline for r91474.

  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
11:34 Changeset [91479] by weinig@apple.com

fast/events/offsetX-offsetY.html is failing on the bots.

  • fast/events/offsetX-offsetY-expected.txt:
  • fast/events/offsetX-offsetY.html:

Update test and result in response to changes to margins in columns.

10:25 Changeset [91478] by abarth@webkit.org

garden-o-matic has trouble when the same test fails in different ways on diffrent bots
https://bugs.webkit.org/show_bug.cgi?id=64830

Unreviewed. (Missing the patch is blocking me from fixing the tree.)

This patch is just some minor bug fixes. One of the bugs results from
the sadness of having two representations (a list and a space-separated
string) for the set of failure types.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
09:48 Changeset [91477] by sjl@chromium.org

Merge 91337 - [chromium] Media player controls do not fade out.
https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):

  • html/shadow/MediaControlRootElementChromium.h:

TBR=sjl@chromium.org
Review URL: http://codereview.chromium.org/7472040

09:31 Changeset [91476] by jknotten@chromium.org

[Chromium] Mark http/tests/inspector/console-websocket-error.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64957

This test times out on Linux Debug.

Unreviewed.

  • platform/chromium/test_expectations.txt:
09:28 Changeset [91475] by pfeldman@chromium.org

2011-07-21 Pavel Feldman <pfeldman@google.com>

Not reviewed: one liner typo fix in Inspector.json.

  • inspector/Inspector.json:
09:14 Changeset [91474] by weinig@apple.com

Source/WebCore: CSS top margin collapses when paginating
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
Update to only go down paginated path when we actually have a page height (so
not in the case that we are just gathering breaks) and to call the version of
of nextPageLogicalTop that actually returns the next page, even if we are at
the boundary point.

(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
Split into two functions which differ in how they deal with the boundary condition.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
Switch to call nextPageLogicalTopIncludingBoundaryPoint.

  • rendering/RenderBlock.h:

Add new functions declarations and comment them.

LayoutTests: CSS top margin collapses when paginating
<rdar://problem/9434990>
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

  • fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:

Update results now that we take margins into account.

09:08 Changeset [91473] by jknotten@chromium.org

[Chromium] Mark fast/js/function-apply-many-args.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64955

The test is timing out on Mac Debug.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:49 Changeset [91472] by pfeldman@chromium.org

Web Inspector: RuntimeAgent.evaluateOn should not require "return X;" syntax.
https://bugs.webkit.org/show_bug.cgi?id=64691

Reviewed by Yury Semikhatsky.

Source/WebCore:

I'm introducing callFunctionOn that receives function declaration in order
to make call site syntax clear.

Test: inspector/runtime/runtime-callFunctionOn.html

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode.dimensions):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved.protoList):
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.callFunction):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/runtime/runtime-callFunctionOn-expected.txt: Added.
  • inspector/runtime/runtime-callFunctionOn.html: Added.
08:39 Changeset [91471] by jknotten@chromium.org

[Chromium] Mark fast/frames/meta-refresh-user-gesture.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64952

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:27 Changeset [91470] by jknotten@chromium.org

[Chromium] Fix test expectations, mark fast/forms/input-file-label.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64949

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:12 Changeset [91469] by commit-queue@webkit.org

[Qt] Adopt existing GraphicsContext3D members (part 1)
https://bugs.webkit.org/show_bug.cgi?id=64877

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-21
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Remove GraphicsContext3DInternal members and use the existing
corresponding members from GraphicsContext3D instead.
Move most of the GraphicsContext3DInternal constructor, destructor
and the reshape() method into GraphicsContext3D.
The GraphicsContext3D members will be needed when we adopt
GraphicsContext3DOpenGL.cpp.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::boundingRect):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::getExtensions):

08:06 Changeset [91468] by jknotten@chromium.org

[Chromium] Mark fast/dom/DeviceOrientation/no-synchronous-events.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64947

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:48 Changeset [91467] by jknotten@chromium.org

[Chromium] Remove test expectation for fast/speech/input-text-speechbutton.html.
https://bugs.webkit.org/show_bug.cgi?id=64945

The test was fixed in https://bugs.webkit.org/show_bug.cgi?id=64857.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:37 Changeset [91466] by jknotten@chromium.org

[Chromium] Mark test fast/flexbox/010.html as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64944

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:18 Changeset [91465] by jknotten@chromium.org

[Chromium] Mark svg/W3C-SVG-1.1/animate-elem-78-t.svg as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64941

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:48 Changeset [91464] by jknotten@chromium.org

[Chromium] Mark http/tests/websocket/tests/hybi/reserved-opcodes.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=64938

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:39 Changeset [91463] by yael.aharon@nokia.com

[Qt][WK2] Code cleanup for drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=64916

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startDrag):
Allow receiving a NULL bitmap from the web process.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
Fix typo introduced in http://trac.webkit.org/changeset/90458.
All DnD related events should be GraphicsScene events.

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQPixmapToShareableBitmap):
Remove hack that creates a 1x1 bitmap.
It is no longer needed after http://trac.webkit.org/changeset/91016.

(WebKit::WebDragClient::startDrag):
Allow sending a NULL bitmap to the UI process.

06:28 Changeset [91462] by jknotten@chromium.org

[Chromium] Remove windows baseline for fast/speech/input-text-speechbutton.
https://bugs.webkit.org/show_bug.cgi?id=64936

Unreviewed.

  • platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Removed.
05:19 Changeset [91461] by pfeldman@chromium.org

Web Inspector: [protocol] extend setBreakpointByUrl request to accept incomplete URL (predicates)
https://bugs.webkit.org/show_bug.cgi?id=60762

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-set-breakpoint-regex.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::buildObjectForBreakpointCookie):
(WebCore::matches):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt: Added.
  • inspector/debugger/debugger-set-breakpoint-regex.html: Added.
04:21 Changeset [91460] by tkent@chromium.org

REGRESSION(r88757): input[type=range] renders incorrectly in RTL context.
https://bugs.webkit.org/show_bug.cgi?id=64904

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/forms/input-appearance-range-rtl.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::layout):
The thumb should be positioned based on 'right' CSS property instead of 'left.'
(WebCore::SliderThumbElement::setPositionFromPoint):
The fraction should be flipped in RTL.

LayoutTests:

  • fast/forms/input-appearance-range-rtl-expected.html: Added.
  • fast/forms/input-appearance-range-rtl.html: Added.
  • platform/chromium/test_expectatinos.txt:
03:22 Changeset [91459] by kbalazs@webkit.org

Unreviewed gardening for Qt.
Revert http://trac.webkit.org/changeset/91451 and skip the tests
via the Skipped list because the test_expectations way don't work.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
03:18 Changeset [91458] by jeremy@chromium.org

Fix fast/speech/input-text-speechbutton.html after r91249 .
https://bugs.webkit.org/show_bug.cgi?id=64857

Reviewed by Kent Tamura.

  • fast/speech/input-text-speechbutton.html: Correct mouse coordinates now that the microphone icon can be on the left in RTL..
  • platform/chromium/test_expectations.txt: Test no longer times out.
03:12 Changeset [91457] by vsevik@chromium.org

Web Inspector: Remove networkDataRemoved field from resource.
https://bugs.webkit.org/show_bug.cgi?id=64749

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

03:06 Changeset [91456] by vsevik@chromium.org

[Chromium DevTools] Remove unused method setAgentIdentifierPrefix from WebDevToolAgent.
https://bugs.webkit.org/show_bug.cgi?id=64793

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
03:05 Changeset [91455] by commit-queue@webkit.org

MediaStream API: Merging MediaStreamContainer and MediaStreamList
https://bugs.webkit.org/show_bug.cgi?id=64794

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-07-21
Reviewed by Tony Gentilcore.

  • GNUmakefile.list.am:
  • dom/MediaStreamContainer.h: Removed.
  • dom/MediaStreamList.cpp:

(WebCore::MediaStreamList::create):
(WebCore::MediaStreamList::MediaStreamList):
(WebCore::MediaStreamList::length):
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::add):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):
(WebCore::MediaStreamList::get):

  • dom/MediaStreamList.h:
02:51 Changeset [91454] by yurys@chromium.org

Web Inspector: always open dedicated worker inspector in a new window not a new tab
https://bugs.webkit.org/show_bug.cgi?id=64872

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype.openWorkerInspector):

02:39 Changeset [91453] by morrita@google.com

[Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
https://bugs.webkit.org/show_bug.cgi?id=64849

Reviewed by Dimitri Glazkov.

This change is a reorg around Shadow inclusion mechanism.

  • Moved definition of ShadowInclusion, ShadowInclusionSet and ShadowInclusionList from ShadowContentElement.h to ShadowContentSelector.h, which is included from smaller number of places.
  • Moved ShadowInclusionSet from ShadowRoot to ShadowContentSelector
  • Made ShadowContentSelector's lifetime managed by ShadowRoot because ShadowInclusionSet is held by the selector.
  • Thus, there is no longer "active" selector (ShadowContentSelector::s_currentInstance) Because the selector is associated for each ShadowRoot object.

No new tests. No behavior change.

  • dom/NodeRenderingContext.cpp:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowContentElement::inclusions):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::~ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):
(WebCore::ShadowContentSelector::unselectInclusion):
(WebCore::ShadowContentSelector::findInclusionFor):
(WebCore::ShadowContentSelector::didSelectInclusion):
(WebCore::ShadowContentSelector::willSelectInclusionOver):

  • dom/ShadowContentSelector.h:

(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowContentSelector::hasChildren):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:
02:29 Changeset [91452] by commit-queue@webkit.org

Patch by Rohan McGovern <rohan@mcgovern.id.au> on 2011-07-21
Reviewed by Noam Rosenthal.

[Qt] Qt5 Build Fix: remove useless use of qRound(int)
https://bugs.webkit.org/show_bug.cgi?id=64907

Rounding an integer doesn't make sense.
Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
permitted to compile.

No new tests needed.

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepthPerComponent): Ditto.

02:27 Changeset [91451] by kbalazs@webkit.org

Unreviewed gardening for Qt.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=64927 and https://bugs.webkit.org/show_bug.cgi?id=64928

  • platform/qt/test_expectations.txt:

Mark inspector/styles/css-live-edit.html as TIMEOUT.
Mark inspector/syles/get-set-stylesheet-text.html as PASS or TIMEOUT.

01:15 Changeset [91450] by rniwa@webkit.org

[Chromium] [WebKit API] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

Remove failing test expectations from fast/html/details-*.html
since localization strings have been updated in Chromium side.

  • platform/chromium/test_expectations.txt:
00:26 Changeset [91449] by rniwa@webkit.org

Unreviewed. Rolled DEPS.

  • DEPS:
Note: See TracTimeline for information about the timeline view.