Timeline


and

07/27/11:

23:46 Changeset [91912] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium Windows test expectations after r91897.

  • platform/chromium/test_expectations.txt:
23:19 Changeset [91911] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

Style bot complains about EFL-specific forward declaration naming.
https://bugs.webkit.org/show_bug.cgi?id=64680

Exclude EFL-specific forward declarations from indentifiers with underscores checks.

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:05 Changeset [91910] by gyuyoung.kim@samsung.com
  • 6 edits
    2 adds in trunk/Source

[EFL] Add dummy NotificationPresenterClientEfl
https://bugs.webkit.org/show_bug.cgi?id=64064

Source/WebCore:

Add two files to CMakeLists.txt for HTML5 Notification.

Reviewed by Antonio Gomes.

  • CMakeLists.txt:

Source/WebKit/efl:

Add dummy files for HTML5 Notification. And also, notificationPresenter() is added to
ChromeClientEfl. Without this function implemented, there would be a build break when
ENABLE_NOTIFICATION is enabled.

Reviewed by Antonio Gomes.

  • CMakeListsEfl.txt:
  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::notificationPresenter):

  • WebCoreSupport/ChromeClientEfl.h:
  • WebCoreSupport/NotificationPresenterClientEfl.cpp: Added.

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

  • WebCoreSupport/NotificationPresenterClientEfl.h: Added.
22:59 Changeset [91909] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

Rebaseline extra test for bug 61369 (skia drawConvexPolygon antialiasing)
https://bugs.webkit.org/show_bug.cgi?id=65299

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

  • platform/chromium-linux/fast/layers/opacity-transforms-expected.png:
  • platform/chromium-win/fast/layers/opacity-transforms-expected.png: Added.
  • platform/chromium-win/fast/layers/opacity-transforms-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
22:24 Changeset [91908] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Calling window.find immediately after mutating the document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=65296

Reviewed by Darin Adler.

Source/WebCore:

Don't forget to layout first.

Test: editing/text-iterator/find-after-mutation.html

  • editing/TextIterator.cpp:

(WebCore::findPlainText):

LayoutTests:

Added a test to ensure WebKit doesn't crash when searching for string after mutating the document.

  • editing/text-iterator/find-after-mutation-expected.txt: Added.
  • editing/text-iterator/find-after-mutation.html: Added.
22:22 Changeset [91907] by commit-queue@webkit.org
  • 5 edits in trunk

Remove skia special case for outline rendering code
https://bugs.webkit.org/show_bug.cgi?id=65295

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

Source/WebCore:

The fix for bug 58999 (outlines with alpha channels showed artifacts in the corners) was
excluded from skia builds until bug 61369 (skia drawConvexPoly didn't pay attention to
shouldAntialias) was fixed. That bug is fixed so now the #if's can be removed.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

  • platform/chromium/test_expectations.txt:
22:16 Changeset [91906] by dslomov@google.com
  • 8 edits in trunk/Source/JavaScriptCore

[chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017
The patch turns on WTF_MULTIPLE_THREADS in chromium and
pushes some relevant initializations from JSC::initializeThreading
to WTF::initializeThreading.

Reviewed by David Levin.

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • wtf/FastMalloc.cpp:

(WTF::isForbidden):
(WTF::fastMallocForbid):
(WTF::fastMallocAllow):

  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

22:11 Changeset [91905] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Crypto.idl doesn't need legacy optional arguments
https://bugs.webkit.org/show_bug.cgi?id=65298

Reviewed by Darin Adler.

This API is relatively new and useless to call without its only argument.

  • page/Crypto.idl:
22:05 Changeset [91904] by tkent@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

2011-07-27 Kent Tamura <tkent@chromium.org>

REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl
https://bugs.webkit.org/show_bug.cgi?id=65239

Reviewed by Ryosuke Niwa.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): For RTL, move the speech button to the left side and shift the inner text to the right by the width of the speech button and the spin button.
21:59 Changeset [91903] by commit-queue@webkit.org
  • 38 edits in trunk/Source

Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-27
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • API/JSContextRef.cpp:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

Source/JavaScriptGlue:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • JSRun.cpp:

(JSRun::JSRun):

  • JSRun.h:

(JSGlueGlobalObject::create):

  • JSUtils.cpp:

(JSObjectKJSValue):
(getThreadGlobalObject):

  • UserObjectImp.h:

(UserObjectImp::create):

Source/WebCore:

No new tests.

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::newRuntimeObject):
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CInstance::getMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::newRuntimeObject):
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaInstance::getMethod):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::fallbackObject):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::newRuntimeObject):
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjcInstance::getMethod):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

Source/WebKit/mac:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::newRuntimeObject):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyInstance::getMethod):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame scopeChain]):

Source/WebKit2:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::methodGetter):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):

21:57 Changeset [91902] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Network panel sidebar should have width saved in preferences when resource is selected.
https://bugs.webkit.org/show_bug.cgi?id=65256

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkPanel.prototype.restoreSidebarWidth):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.preferredSidebarWidth):
(WebInspector.Panel.prototype.get restoreSidebarWidth):

21:34 Changeset [91901] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::open):

21:32 Changeset [91900] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove unused m_isWeak member of V8AbstractEventListener
https://bugs.webkit.org/show_bug.cgi?id=65273

Reviewed by Adam Barth.

m_isWeak is set to true in the constructor and never changed,
so the one if statement that tests it always executes; the
code has been updated to make this clear.

No behavior change, thus no tests.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):

  • bindings/v8/V8AbstractEventListener.h:
21:23 Changeset [91899] by aroben@apple.com
  • 2 edits in trunk/Tools

Use wacky !svn/bc URLs consistently in Leaks Viewer

This ensures that any resources loaded via relative URLs will still get pulled from the same
revision of Subversion.

Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the

!svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
from Subversion.

21:08 Changeset [91898] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Tools

[EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
https://bugs.webkit.org/show_bug.cgi?id=65269

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-27
Reviewed by Kent Tamura.

WorkQueueItemEfl.h was being included by efl's
LayoutTestControllerEfl.cpp, however the top-level
LayoutTestController still included WorkQueueItem.h, causing a lot of
type mismatches when running the WorkQueueItem code.

We can stick to the original WorkQueueItem header by making a few
changes to EFL's LayoutTestController.

This should make tests such as
fast/loader/non-deferred-substitute-load.html stop crashing.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

  • DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
20:56 Changeset [91897] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] fix clipping of some glyphs on windows
https://bugs.webkit.org/show_bug.cgi?id=65262

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
20:55 Changeset [91896] by fsamuel@chromium.org
  • 6 edits in trunk/Source

Source/WebCore: Popups on Chromium now check the minimum row height set through the Chromium WebKit API when
computing the height of a row in a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

No new tests.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::minimumRowHeight):
(WebCore::PopupMenuChromium::setMinimumRowHeight):

Source/WebKit/chromium: Added a Chromium WebKit API method to set the minimum row height of a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

  • public/WebPopupMenu.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenu::setMinimumRowHeight):

20:44 Changeset [91895] by morrita@google.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

The tree scope pointers on shadow tree nodes didn't cleared.
even when the tree scope (shadow root) is destroyed.
This change clear these poitners before detaching the shadow root.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/tree-scope-crash.html

  • dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

LayoutTests: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/tree-scope-crash-expected.txt: Added.
  • fast/dom/shadow/tree-scope-crash.html: Added.
20:25 Changeset [91894] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

DFG graph has no notion of double prediction.
https://bugs.webkit.org/show_bug.cgi?id=65234

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

Added the notion of PredictDouble, and PredictNumber, which is the least
upper bound of PredictInt32 and PredictDouble. Least upper bound is
defined as the bitwise-or of two predictions. Bottom is defined as 0,
and Top is defined as all bits being set. Added the ability to explicitly
distinguish between a node having had a prediction associated with it,
and that prediction still being valid (i.e. no conflicting predictions
have also been added). Used this to guard the speculative JIT from
speculating Int32 in cases where the graph knows that the value is
double, which currently only happens for GetLocal nodes on arguments
which were double at compile-time.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):

20:00 Changeset [91893] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Implement sizes attribute for link tag from HTML5
https://bugs.webkit.org/show_bug.cgi?id=37674

Patch by Rachel Blum <groby@chromium.org> on 2011-07-27
Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/icon-size-property.html

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSHTMLLinkElementCustom.cpp:

(WebCore::JSHTMLLinkElement::sizes):
(WebCore::JSHTMLLinkElement::setSizes):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp: Added.

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
(WebCore::V8HTMLLinkElement::sizesAccessorSetter):

  • html/HTMLAttributeNames.in:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::sizes):
(WebCore::HTMLLinkElement::setSizes):

  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.idl:

LayoutTests:

  • fast/dom/icon-size-property-expected.txt: Added.
  • fast/dom/icon-size-property.html: Added.
19:57 Changeset [91892] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add more text input types for chromium
https://bugs.webkit.org/show_bug.cgi?id=64937

Patch by Peng Huang <penghuang@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

19:31 Changeset [91891] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations for http://crbug.com/88911

  • platform/chromium/test_expectations.txt:
18:45 Changeset [91890] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Add sfntly library to the Chromium DEPS file.

  • DEPS:
18:27 Changeset [91889] by kbr@google.com
  • 4 edits in branches/chromium/835

Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7523024

18:24 Changeset [91888] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
18:02 Changeset [91887] by rniwa@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Chromium rebaseline after r91879.

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:21 Changeset [91886] by jamesr@google.com
  • 3 edits in branches/chromium/835/Source/WebCore

Merge 91823 - [chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::cleanupResources):

  • platform/graphics/chromium/ContentLayerChromium.h:

TBR=jamesr@chromium.org
BUG=89487
Review URL: http://codereview.chromium.org/7522010

17:13 Changeset [91885] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Incorrect arguments passed to LOG statement
https://bugs.webkit.org/show_bug.cgi?id=65293

Reviewed by Oliver Hunt.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):

16:52 Changeset [91884] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Re-add unit tests I accidentally zapped in r91878.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
16:48 Changeset [91883] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=65294
DFG JIT - may speculate based on wrong arguments.

Reviewed by Oliver Hunt

In the case of a DFG compiled function calling to and compiling a second function that
also compiles through the DFG JIT (i.e. compilation triggered with DFGOperations.cpp),
we call compileFor passing the caller functions exec state, rather than the callee's.
This may lead to mis-optimization, since the DFG compiler will example the exec state's
arguments on the assumption that these will be passed to the callee - it is wanting the
callee exec state, not the caller's exec state.

Fixing this for all cases of compilation is tricksy, due to the way the numeric sort
function is compiled, & the structure of the calls in the Interpreter::execute methods.
Only fix for compilation from the JIT, in other calls don't speculate based on arguments
for now.

  • dfg/DFGOperations.cpp:
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::FunctionExecutable::compileForCallInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileFor):

16:40 Changeset [91882] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Marking leviw's new unicode-bidi-plaintext test as failing

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [91881] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark another flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:18 Changeset [91880] by leviw@chromium.org
  • 13 edits in trunk/Source/WebCore

Switch transform operations to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=64301

Reviewed by Simon Fraser.

Changing TransformOperation and its progeny to operate on FloatSizes instead of IntSizes.

  • platform/graphics/transforms/IdentityTransformOperation.h:

(WebCore::IdentityTransformOperation::apply):

  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:

(WebCore::Matrix3DTransformOperation::blend):

  • platform/graphics/transforms/Matrix3DTransformOperation.h:

(WebCore::Matrix3DTransformOperation::apply):

  • platform/graphics/transforms/MatrixTransformOperation.cpp:

(WebCore::MatrixTransformOperation::blend):

  • platform/graphics/transforms/MatrixTransformOperation.h:

(WebCore::MatrixTransformOperation::apply):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:

(WebCore::PerspectiveTransformOperation::apply):

  • platform/graphics/transforms/RotateTransformOperation.h:

(WebCore::RotateTransformOperation::apply):

  • platform/graphics/transforms/ScaleTransformOperation.h:

(WebCore::ScaleTransformOperation::apply):

  • platform/graphics/transforms/SkewTransformOperation.h:

(WebCore::SkewTransformOperation::apply):

  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TransformOperations.h:

(WebCore::TransformOperations::apply):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::apply):

16:16 Changeset [91879] by leviw@chromium.org
  • 3 edits
    3 adds in trunk

unicode-bidi:-webkit-plaintext does not work on <textarea>
https://bugs.webkit.org/show_bug.cgi?id=65074

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixing unicode-bidi style propagation into text control shadow trees.

Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

LayoutTests:

Fixing unicode-bidi propagation into text controls.

  • fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
16:11 Changeset [91878] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with

test configuration matching, removed a bunch of code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
15:42 Changeset [91877] by dglazkov@chromium.org
  • 6 edits in trunk/Tools

Allow ports to specify their own test expectation specifier macros.
https://bugs.webkit.org/show_bug.cgi?id=65291

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
  • Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
15:35 Changeset [91876] by mahesh.kulkarni@nokia.com
  • 1 edit in trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h

Build fix for Symbian after r91800

15:33 Changeset [91875] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark another webgl flaky test.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:16 Changeset [91874] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

Allow TestConfigurationConverter report conversion errors.
https://bugs.webkit.org/show_bug.cgi?id=65287

Also, fix a few miscellaneous testing issues.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance

was created. 'default' is not a valid build type.

  • Scripts/webkitpy/layout_tests/port/test.py: Ditto. is not a valid version.
15:10 Changeset [91873] by enne@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:01 Changeset [91872] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2011-07-27 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Darin Adler.

Test: media/video-poster-blocked-by-willsendrequest.html

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if

willLoadMediaElementURL returns false.

2011-07-27 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Darin Adler.

  • media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
  • media/video-poster-blocked-by-willsendrequest.html: Added.
14:55 Changeset [91871] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Handle callback oriented JSONP
https://bugs.webkit.org/show_bug.cgi?id=65271

Reviewed by Gavin Barraclough.

Handle the callback oriented versions of JSONP. The Literal parser
now handles <Identifier> (. <Identifier>)* (jsonData).

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lex):

  • runtime/LiteralParser.h:
14:50 Changeset [91870] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests. Printing itself in Chrome has few tests, sadly. :(

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

14:44 Changeset [91869] by slewis@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.

Unreviewed rollout.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::releaseExecutableMemory):

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):

  • runtime/RegExp.h:
14:20 Changeset [91868] by kerz@chromium.org
  • 2 edits in branches/chromium/835/Source/WebKit/chromium

Merge 91847 - Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::startDownload):

TBR=commit-queue@webkit.org

14:18 Changeset [91867] by kerz@chromium.org
  • 37 edits
    8 copies in branches/chromium/835

Merge 91797 - Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL. The author can also supply a
suggested file name in the attribute value. This feature is a recent
addition to HTML to better support offline applications that use blob
URLs. Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event. This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html

fast/dom/HTMLAnchorElement/anchor-nodownload.html
fast/dom/HTMLAnchorElement/anchor-download-unset.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAttributeNames.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::startDownload):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::loadURLExternally):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::startDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::startDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::startDownload):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::startDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::startDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::startDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::startDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::loadURLExternally):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7521007

14:06 Changeset [91866] by dglazkov@chromium.org
  • 14 edits
    1 copy in trunk/Tools

Teach all ports about their test configurations.
https://bugs.webkit.org/show_bug.cgi?id=65278

Each Port object should return a valid set of all TestConfiguration instances,
available for this port.

Reviewed by Philippe Normand.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,

since it is different for each port.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of

all test configurations as a param.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
  • Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
  • Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
  • Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
  • Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
14:02 UsingGitWithWebKit edited by aroben@apple.com
Added some git config commands to produce better ObjC diffs (diff)
12:44 Changeset [91865] by rniwa@webkit.org
  • 47 edits
    14 adds
    10 deletes in trunk/LayoutTests

Chromium rebaselines for r89627 and r91497.

  • platform/chromium-linux/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-linux/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/single-line-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/chromium/test_expectations.txt:
12:26 Changeset [91864] by xji@chromium.org
  • 3 edits
    4 copies
    4 moves in trunk/LayoutTests

editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Split the 2 tests into 4 tests. But need to find a way to improve
performance eventually.

  • editing/selection/move-by-word-visually-multi-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
  • editing/selection/move-by-word-visually-multi-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
  • editing/selection/move-by-word-visually-multi-space-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
  • editing/selection/move-by-word-visually-multi-space.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
  • editing/selection/move-by-word-visually-others-expected.txt: Removed.
  • editing/selection/move-by-word-visually-others.html: Removed.
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
  • editing/selection/move-by-word-visually-single-space-inline-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
  • editing/selection/move-by-word-visually-single-space-one-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
  • editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Removed.
  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
12:21 Changeset [91863] by benjamin.poulain@nokia.com
  • 24 edits
    1 delete in trunk

[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
https://bugs.webkit.org/show_bug.cgi?id=62969

Reviewed by Andreas Kling.

Co-authored with Simon Hausmann <simon.hausmann@nokia.com>

Source/WebKit/qt:

Add the declarative dependency to link WebKit.

Source/WebKit2:

This patch change the base of WebKit2 from QGraphicsWidget
to scenegraph based items.

QTouchWebView becomes a QSGItem with the only role of clipping
child items.
QTouchWebPage becomes a QSGPaintedItem in order to render the content
of the flattened page. This is a temporary work around to get
something running without deep changes on the drawing area proxy.

QDesktopWebView become a QSGPaintedItem and behave as before
regarding rendering. The drawing area proxy is used to render
the full item.

The event delivery had to be adapted because the scenegraph does not
follow regular delivery of QEvents. Instead, each event type is
delivered directly to a specific virtual function.
In this patch, the events are forwarded to the classic QObject::event().

For the features that cannot be implemented on scenegraph (tooltip, menus, etc),
a temporary workaround was added: the parent canvas is used as the widget for
providing the feature. This assumes the web views alone in the canvas and
take its full size. This will have to be fixed in the scenegraph for us to
implement those features.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::isActive):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::init):
(paintCrashedPage):
(QDesktopWebView::keyPressEvent):
(QDesktopWebView::keyReleaseEvent):
(QDesktopWebView::inputMethodEvent):
(QDesktopWebView::focusInEvent):
(QDesktopWebView::focusOutEvent):
(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::touchEvent):
(QDesktopWebView::hoverEnterEvent):
(QDesktopWebView::hoverMoveEvent):
(QDesktopWebView::hoverLeaveEvent):
(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragExitEvent):
(QDesktopWebView::dragDropEvent):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::paint):
(QTouchWebPage::event):
(QTouchWebPage::keyPressEvent):
(QTouchWebPage::keyReleaseEvent):
(QTouchWebPage::inputMethodEvent):
(QTouchWebPage::focusInEvent):
(QTouchWebPage::focusOutEvent):
(QTouchWebPage::touchEvent):
(QTouchWebPage::geometryChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):
(TestWindow::resizeEvent):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::pinchGestureRequestUpdate):
(WebKit::TouchViewInterface::drawingAreaSize):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::isActive):

  • UIProcess/qt/ViewInterface.cpp: Removed.
  • UIProcess/qt/ViewInterface.h:
  • WebKit2.pro:

Tools:

With the scene graph, the interface to have a window on screen is
QSGCanvas. QGraphicsView is not used, and openGL is an enforced
dependency.

Both the BrowserView and the WebKitTest runner are changed from
QGraphicsView to QSGCanvas.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::view):

  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:
11:54 Changeset [91862] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Wrong image height in absolutely positioned div in relatively positioned parent with bottom padding
https://bugs.webkit.org/show_bug.cgi?id=64046

Reviewed by David Hyatt.

Add pixel test results.

  • platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
11:39 Changeset [91861] by rniwa@webkit.org
  • 13 edits in trunk/LayoutTests

Mac pixel rebaselines after r91497.

  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:
11:34 Changeset [91860] by mihaip@chromium.org
  • 8 edits in trunk/Source

[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
https://bugs.webkit.org/show_bug.cgi?id=65158

Reviewed by David Hyatt.

Source/WebCore:

Add per-Document instance user stylesheets (as opposed to the page
group user styles and the global page stylesheet).

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore::Document::addUserSheet):

  • dom/Document.h:

Source/WebKit/chromium:

Add WebDocument::insertUserStyleSheet which inserts a user stylesheet,
instead of forcing extensions to use insertStyleText which manipulates
the DOM of the page and results in compatibility issues (see
http://crbug.com/82220).

  • public/WebDocument.h:
  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

11:32 Changeset [91859] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark data-view-test.html as flaky in non-debug configs too.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:30 Changeset [91858] by vsevik@chromium.org
  • 11 edits
    1 add in trunk

Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/network/network-disable-cache-memory-expected.txt:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/resources/random-script.php: Added.
10:45 Changeset [91857] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/qt-wk2/Skipped: Skip failing test.
10:43 Changeset [91856] by enne@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

[chromium] Add baselines for struct-dom-11-f.svg.

Unreviewed gardening.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
10:40 Changeset [91855] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit/qt

[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
https://bugs.webkit.org/show_bug.cgi?id=61328

Reviewed by Andreas Kling.

Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
emitting signals in the progress notification functions, we use the
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
that loading code is prepared to handle load() when inside those functions.

The crash was being caused by setUrl() (and load()) being called when
loadFinished(false) was emitted. The problem here is that when
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
call again, because it was still the ProvisionalLoadState but with the
provisionalDocumentLoader already removed.

To emulate the same behavior that QtWebKit had when using
postProgressFinishedNotification, we now keep track of the frame originating the
load, and emit the signals when this frame's client is called.

The patch keeps the existing semantics for QWebPage signals, but we now emit the
QWebFrame signals everytime, not only when they are the originating frame for
loading.

  • Api/qwebframe.cpp:

(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.

  • WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep

track whether the frame is originating the load. Remove the signals from
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.

(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
signals to our signals for load/finished, signal emission will be done manually.

(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
loadStarted() signal and make the first notification of estimation change, that
Qt API tests expect to exist and notify 10%.

(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
m_loadError and emit loadFinished() signal.

(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
emission and mark the originating load as true, since only the originating frame
gets this call in its client.

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
emission.

(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
was successful or not. This wasn't necessary before because a successful call for
error page would lead to a load(), that cleared the m_loadError.
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
to m_loadError and emit finished signal indicating error if ErrorPage extension
doesn't handle it.
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.

(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
for the QWebFrame, and if the originating load also do for the QWebPage.

(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
loadFinished(). Take care to reset the originating load flag before the signals
are emitted, since they might want to set it back again.

  • tests/qwebframe/tst_qwebframe.cpp:

(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
when a certain signal is emitted in the frame.

(URLSetter::execute):
(tst_QWebFrame::loadInSignalHandlers_data):
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
crashes without this patch applied.

10:20 Changeset [91854] by enne@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Mark more tests as being flaky.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:09 Changeset [91853] by ossy@webkit.org
  • 3 edits
    12 adds
    1 delete in trunk/LayoutTests

[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

  • platform/qt-4.8/fast/css/font-face-opentype-expected.png: Added.
  • platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Added.
  • platform/qt-4.8/fast/css/font-family-pictograph-expected.png: Added.
  • platform/qt-4.8/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/qt-4.8/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/qt-4.8/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Remove window.XSLTProcessor entries.
  • platform/qt/Skipped: Skip a failing test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added after r91850.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added after r91850.
  • platform/qt/svg/custom/tref-own-content-removal-expected.png: Added.
09:20 Changeset [91852] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests after migration to Qt5.
  • platform/qt/test_expectations.txt: Mark fast/js/array-sort-modifying-tostring.html as TIMEOUT PASS flakey test in debug mode.
09:06 Changeset [91851] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip new failing tests.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Update after r91300.
  • platform/wk2/Skipped: Skip tests because of missing layoutTestController implementation.
08:58 Changeset [91850] by rwlbuis@webkit.org
  • 6 edits
    7 adds in trunk

2011-07-27 Rob Buis <rbuis@rim.com>

Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=11274

Reviewed by Nikolas Zimmermann.

Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
pointer-events=none in the list.

Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg

svg/custom/intersection-list-clipping.svg
svg/custom/intersection-list-nested-svg.svg

  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::getElementCTM): (WebCore::intersectsAllowingEmpty): (WebCore::isGraphicsElement): (WebCore::RenderSVGModelObject::checkIntersection): (WebCore::RenderSVGModelObject::checkEnclosure):
  • rendering/svg/RenderSVGModelObject.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure):
08:56 Changeset [91849] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Tighten up some chromium test expectations to green up the bots.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:45 Changeset [91848] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline one Chromium GPU test on Linux after
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
08:36 Changeset [91847] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::startDownload):

08:25 Changeset [91846] by senorblanco@chromium.org
  • 41 edits
    1 add in trunk/LayoutTests

New chromium-linux baselines after skia change
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-linux/fonts/cursive-expected.txt: Added.
  • platform/chromium-linux/fonts/fantasy-expected.txt:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-linux/svg/custom/text-rotation-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-linux/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/chromium/test_expectations.txt:
08:20 Changeset [91845] by caio.oliveira@openbossa.org
  • 7 edits in trunk

[Qt] Fix build in Qt 5 of QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=65258

Reviewed by Andreas Kling.

In Qt 5, the QGraphicsView-based classes for QtQuick are in the
qtquick1 module, including QDeclarativeItem and QDeclarativeView.

.:

  • Source/WebKit.pro:

Source/WebKit/qt:

  • declarative/qdeclarativewebview_p.h:
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
  • tests/tests.pri:
  • tests/tests.pro:
07:37 Changeset [91844] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][V8] Fix the build.

Unreviewed build fix.

No new tests needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.
07:20 Changeset [91843] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unreviewed build fix for mac.

QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.

  • DerivedSources.pro:
  • WebCore.pro:
07:12 Changeset [91842] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip a new failing test: svg/custom/image-with-transform-clip-filter.svg
06:56 Changeset [91841] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Speculative win build fix after r91835
https://bugs.webkit.org/show_bug.cgi?id=65255

Unreviewed build fix.

  • src/WebFontImpl.cpp:
06:55 Changeset [91840] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Clean WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65246

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-27
Reviewed by Andreas Kling.

Remove the empty functions from Qt's WKPageLoaderClient.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didSameDocumentNavigationForFrame): Move the function to
have all the implementations in the same order as the definitions.

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

06:37 Changeset [91839] by yurys@chromium.org
  • 15 edits
    4 adds in trunk

Inspector should support cd(window) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19872

Source/WebCore:

Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd.html

  • WebCore.gypi:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/ContextManager.js: Added.

(WebInspector.ContextManager):
(WebInspector.ContextManager.prototype._frameAdded):
(WebInspector.ContextManager.prototype._frameNavigated):
(WebInspector.ContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get id):
(WebInspector.FrameEvaluationContext.prototype.get url):
(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Added a test for console evaluation in an iframe.

Reviewed by Pavel Feldman.

  • http/tests/inspector/console-cd-expected.txt: Added.
  • http/tests/inspector/console-cd.html: Added.
  • http/tests/inspector/resources/console-cd-iframe.html: Added.
06:34 Changeset [91838] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

Fix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
https://bugs.webkit.org/show_bug.cgi?id=65253

Reviewed by Andreas Kling.

The -webkit-pictograph generic family was added by bug 65197.

  • Shared/WebPreferencesStore.h:
06:07 Changeset [91837] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):

Added an interface to take IsWhiteSpaceFunctionPtr.

(WTF::StringImpl::simplifyWhiteSpace): ditto.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.

  • wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

  • fast/forms/option-strip-unicode-spaces-expected.txt: Added.
  • fast/forms/option-strip-unicode-spaces.html: Added.
06:01 Changeset [91836] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Qt specific expected result for a new test introduced in r91777.

  • platform/qt/fast/css/font-family-pictograph-expected.png: Added.
  • platform/qt/fast/css/font-family-pictograph-expected.txt: Added.
05:38 Changeset [91835] by zecke@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove include of skia/ext/platform_canvas.h
https://bugs.webkit.org/show_bug.cgi?id=60852

Reviewed by Hajime Morita.

In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
skia::PlatformCanvas was eliminated in favor of directly using
SkCanvas directly. The include of platform_canvas.h was not removed
leaving the dependency on Chromium in the header files. Remove
that dependency now.

  • platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h
04:22 Changeset [91834] by philn@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, forgotten GTK pixel test results for
fast/forms/input-file-re-render.html after r91833.

  • platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
03:51 Changeset [91833] by philn@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed, GTK pixel tests rebaseline after r91759.

  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/file-input-direction-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/test_expectations.txt:
03:30 Changeset [91832] by bashi@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/platform/graphics/chromium

Merge 90868 by hand.

BUG=87132
TBR=bashi@chromium.org

03:24 Changeset [91831] by benjamin.poulain@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Simplify the PageUIClient
https://bugs.webkit.org/show_bug.cgi?id=65198

Reviewed by Andreas Kling.

The only function of WKPageLoaderClient with a complete implementation
is qt_wk_setStatusText(). The other functions were what is left from
before the refactoring of QWKPage.

This patch removes the unused functions to simplify the client. Since the dependency
on QtWebPageProxy is removed from that client, it now calls the ViewInterface directly.

  • UIProcess/qt/ClientImpl.cpp:

(toViewInterface):
(qt_wk_setStatusText):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:
03:03 Changeset [91830] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Unreviewed, rolling out r91792.
http://trac.webkit.org/changeset/91792
https://bugs.webkit.org/show_bug.cgi?id=65242

It broke NRWT on Qt and GTK (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-27

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
03:01 Changeset [91829] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

02:49 Changeset [91828] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Unreviewed build fix.

  • platform/chromium/test_expectations.txt:
02:15 Changeset [91827] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Knob of a disabled or readonly range control should not be draggable.
https://bugs.webkit.org/show_bug.cgi?id=54820

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Made disabled or readonly range control undraggable.

Test: fast/forms/range-drag.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

Added check that the element is readonly or disabled.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler): ditto.

LayoutTests:

Added tests to confirm disabled or readonly range control is undraggable.

  • fast/forms/range-drag-expected.txt: Added.
  • fast/forms/range-drag.html: Added.
01:56 Changeset [91826] by yutak@chromium.org
  • 6 edits in trunk

WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
https://bugs.webkit.org/show_bug.cgi?id=65232

Reviewed by Kent Tamura.

Source/WebCore:

Add [NoStaticTables] attribute to CloseEvent interface definition. This attribute
makes the code generator obtain the attributes table used for building ClassInfo
through JSGlobalData, instead of directly using a statically-allocated table.

Generally speaking, NoStaticTables needs to be specified in interfaces which
may be accessed from workers.

Tests: http/tests/websocket/tests/hybi/workers/shared-worker-simple.html (updated)

http/tests/websocket/tests/hybi/workers/worker-simple.html (updated)

  • websockets/CloseEvent.idl: Fixed the formatting, too.

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/resources/worker-simple.js:

(runTests): Check the value of closeEvent.wasClean.

  • http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt:
  • http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt:
00:12 Changeset [91825] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT speculation failure code performs incorrect conversions in
the case where two registers need to be swapped.
https://bugs.webkit.org/show_bug.cgi?id=65233

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::swapWith):

07/26/11:

23:02 Changeset [91824] by commit-queue@webkit.org
  • 7 edits in trunk

reduce and reduceRight bind callback's this to null rather than undefined
https://bugs.webkit.org/show_bug.cgi?id=62264

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed Array.prototype.reduce and Array.prototype.reduceRight so that they behave correctly
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

LayoutTests:

Added additional tests to test Array.prototype.reduce and Array.prototype.reduceRight
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • fast/js/array-reduce-expected.txt:
  • fast/js/array-reduceRight-expected.txt:
  • fast/js/script-tests/array-reduce.js:
  • fast/js/script-tests/array-reduceRight.js:
20:48 Changeset [91823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::cleanupResources):

  • platform/graphics/chromium/ContentLayerChromium.h:
20:42 Changeset [91822] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r91805.
http://trac.webkit.org/changeset/91805
https://bugs.webkit.org/show_bug.cgi?id=65226

Breaks @ symbols and changes other font rendering on Windows
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
20:18 Changeset [91821] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r91812.
http://trac.webkit.org/changeset/91812
https://bugs.webkit.org/show_bug.cgi?id=65210

Breaks OSX GPU tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

20:05 Changeset [91820] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog.

20:01 Changeset [91819] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

enne tells me that she already rebaselined this test. The 10.5 bot is
just behind because dglazkov broke NRWT on Python 2.5.

  • platform/chromium/test_expectations.txt:
19:59 Changeset [91818] by abarth@webkit.org
  • 2 edits in trunk/Tools

Switch to an older idiom that works on Python 2.5.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
19:56 Changeset [91817] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC command-line tool does not come with any facility for
measuring time precisely.
https://bugs.webkit.org/show_bug.cgi?id=65223

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

Exposed WTF::currentTime() as currentTimePrecise().

  • jsc.cpp:

(GlobalObject::GlobalObject):
(functionPreciseTime):

19:48 Changeset [91816] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r91809.
http://trac.webkit.org/changeset/91809
https://bugs.webkit.org/show_bug.cgi?id=65225

Does not build on Chromium Windows (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • platform/PlatformGestureEvent.h:
  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:
19:45 Changeset [91815] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Fix pointer operator coding style in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=65163

Move '*' operator to variable according to efl coding style. In addition,
add a space between * and variable in type casting.

Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_changed):
(_ewk_view_repaints_resize):
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scrolls_resize):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_core_frame_new):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_contents_resize):
(_ewk_view_smart_zoom_set):
(_ewk_view_smart_flush):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_zoom_animated_mark_stop):
(_ewk_view_zoom_animated_finish):
(_ewk_view_zoom_animated_current):
(_ewk_view_zoom_animator_cb):
(_ewk_view_zoom_animation_start):
(_ewk_view_viewport_attributes_compute):
(ewk_view_base_smart_set):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_frame_main_get):
(ewk_view_frame_focused_get):
(ewk_view_uri_set):
(ewk_view_uri_get):
(ewk_view_title_get):
(ewk_view_editable_get):
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
(ewk_view_text_search):
(ewk_view_text_matches_mark):
(ewk_view_text_matches_unmark_all):
(ewk_view_text_matches_highlight_set):
(ewk_view_text_matches_highlight_get):
(ewk_view_editable_set):
(ewk_view_selection_get):
(_ewk_view_editor_command):
(ewk_view_execute_editor_command):
(ewk_view_context_menu_forward_event):
(ewk_view_load_progress_get):
(ewk_view_stop):
(ewk_view_reload):
(ewk_view_reload_full):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_navigate):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_navigate_possible):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):
(ewk_view_zoom_get):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_smooth_scale_get):
(ewk_view_zoom_weak_smooth_scale_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_mark_start):
(ewk_view_zoom_animated_mark_end):
(ewk_view_zoom_animated_mark_current):
(ewk_view_zoom_animated_mark_stop):
(ewk_view_zoom_animated_set):
(ewk_view_zoom_text_only_get):
(ewk_view_zoom_text_only_set):
(ewk_view_pre_render_region):
(ewk_view_pre_render_relative_radius):
(ewk_view_pre_render_cancel):
(ewk_view_setting_user_agent_get):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_get):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_get):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_get):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_auto_resize_window_get):
(ewk_view_setting_enable_auto_resize_window_set):
(ewk_view_setting_enable_scripts_get):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_get):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_get):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_window_open_get):
(ewk_view_setting_scripts_window_open_set):
(ewk_view_setting_resizable_textareas_get):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_get):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_offline_app_cache_get):
(ewk_view_setting_offline_app_cache_set):
(ewk_view_setting_caret_browsing_get):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_setting_encoding_default_get):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_get):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_get):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_get):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_get):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_setting_font_standard_get):
(ewk_view_setting_font_standard_set):
(ewk_view_setting_font_cursive_get):
(ewk_view_setting_font_cursive_set):
(ewk_view_setting_font_fantasy_get):
(ewk_view_setting_font_fantasy_set):
(ewk_view_setting_font_monospace_get):
(ewk_view_setting_font_monospace_set):
(ewk_view_setting_font_serif_get):
(ewk_view_setting_font_serif_set):
(ewk_view_setting_font_sans_serif_get):
(ewk_view_setting_font_sans_serif_set):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_get):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_get):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_smart_data_get):
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
(ewk_view_repaint_add):
(ewk_view_layout_if_needed_recursive):
(ewk_view_scrolls_process):
(ewk_view_paint_context_new):
(ewk_view_paint_context_free):
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint_context_scale):
(ewk_view_paint_context_translate):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_ready):
(ewk_view_input_method_state_set):
(ewk_view_title_set):
(ewk_view_uri_changed):
(ewk_view_load_started):
(ewk_view_frame_main_load_started):
(ewk_view_load_provisional):
(ewk_view_load_show):
(ewk_view_frame_main_cleared):
(ewk_view_frame_main_icon_received):
(ewk_view_load_finished):
(ewk_view_load_error):
(ewk_view_load_progress_changed):
(ewk_view_restore_state):
(ewk_view_window_create):
(ewk_view_window_close):
(ewk_view_mouse_link_hover_in):
(ewk_view_mouse_link_hover_out):
(ewk_view_toolbars_visible_set):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_set):
(ewk_view_statusbar_visible_get):
(ewk_view_statusbar_text_set):
(ewk_view_scrollbars_visible_set):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_set):
(ewk_view_menubar_visible_get):
(ewk_view_tooltip_text_set):
(ewk_view_add_console_message):
(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):
(ewk_view_should_interrupt_javascript):
(ewk_view_exceeded_database_quota):
(ewk_view_run_open_panel):
(ewk_view_repaint):
(ewk_view_scroll):
(ewk_view_core_page_get):
(ewk_view_frame_create):
(ewk_view_plugin_create):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_download_request):
(ewk_view_viewport_attributes_set):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_need_touch_events_set):
(ewk_view_need_touch_events_get):
(ewk_view_mode_set):
(ewk_view_mode_get):
(ewk_view_editor_client_selection_changed):

  • ewk/ewk_view.h:
19:41 Changeset [91814] by dslomov@google.com
  • 11 edits in trunk/Source/WebCore

[V8][Chromium] Run workers in a separate v8::Isolate
https://bugs.webkit.org/show_bug.cgi?id=65004
This patch allocates a new v8::Isolate for every worker and enters it on worker thread.

Reviewed by David Levin.

Covered by existing chromium tests.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):

  • bindings/v8/WorkerScriptController.h:
19:37 Changeset [91813] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test appears to fail on Leopard only.

  • platform/chromium/test_expectations.txt:
19:28 Changeset [91812] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Avoid clearing the framebuffer when compositing in release builds
https://bugs.webkit.org/show_bug.cgi?id=65210

Reviewed by Kenneth Russell.

We clear the default framebuffer to blue when compositing so it's
easier to spot regions we miss. This is useful for debugging, but eats
bandwidth unnecessarily in release builds.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

19:25 Changeset [91811] by jpfau@apple.com
  • 9 edits
    2 adds in trunk/Source/WebCore

New XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=64566

Reviewed by Adam Barth.

Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLToken.h:
  • xml/parser/XMLTokenizer.cpp: Added.

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::XMLTokenizer::nextToken):
(WebCore::XMLTokenizer::bufferCharacter):
(WebCore::XMLTokenizer::parseError):

  • xml/parser/XMLTokenizer.h: Added.

(WebCore::XMLTokenizer::create):
(WebCore::XMLTokenizer::gotError):
(WebCore::XMLTokenizer::shouldSkipNullCharacters):

19:02 Changeset [91810] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Add an exception to coding style check for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=65162

Add an exception of whitespace/declaration for EFL port. Because,
'*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/style/checker.py:
18:52 Changeset [91809] by commit-queue@webkit.org
  • 21 edits in trunk/Source

[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
18:38 Changeset [91808] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

Restore Composited Layers Faster from PageCache
https://bugs.webkit.org/show_bug.cgi?id=65216

Reviewed by Simon Fraser.

Restore the layer tree hierarchy a little sooner, when
restoring from the page cache. This more closely matches
original restore behavior.

Existing test showed no change.

  • page/FrameView.cpp:

(WebCore::FrameView::restoreBackingStores):

18:27 Changeset [91807] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG speculative JIT never emits inline double comparisons, even when it
would be obvious more efficient to do so.
https://bugs.webkit.org/show_bug.cgi?id=65212

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This handles the obvious case of inlining double comparisons: it only addresses
the speculative JIT, and only for fused compare/branch sequences. But it does
handle the case where both operands are double (and there is no slow path),
or where one operand is double and the other is unknown type (in which case it
attempts to unbox the double, otherwise taking slow path). This is an 0.8%
speed-up on SunSpider.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

18:12 Changeset [91806] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-26
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

18:10 Changeset [91805] by commit-queue@webkit.org
  • 8 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Patch by Mike Reed <reed@google.com> on 2011-07-26
Reviewed by Kenneth Russell.

No new tests. existing tests apply to the new drawing path

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

17:55 Changeset [91804] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=64969
DFG JIT generates inefficient code for speculation failures.

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This implements a speculation failure strategy where (1) values spilled on
non-speculative but not spilled on speculative are spilled, (2) values that
are in registers on both paths are rearranged without ever touching memory,
and (3) values spilled on speculative but not spilled on non-speculative are
filled.

The register shuffling is the most interesting part of this patch. It
constructs a permutation graph for registers. Each node represents a
register, and each directed edge corresponds to the register's value having
to be moved to a different register as part of the shuffling. This is a
directed graph where each node may only have 0 or 1 incoming edges, and
0 or 1 outgoing edges. The algorithm then first finds maximal non-cyclic
subgraphs where all nodes in the subgraph are reachable from a start node.
Such subgraphs always resemble linked lists, and correspond to simply
moving the value in the second-to-last register into the last register, and
then moving the value in the third-to-last register into the second-to-last
register, and so on. Once these subgraphs are taken care of, the remaining
subgraphs are cycles, and are handled using either (a) conversion or no-op
if the cycle involves one node, (b) swap if it involves two nodes, or (c)
a cyclic shuffle involving a scratch register if there are three or more
nodes.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::GeneralizedRegister):
(JSC::DFG::GeneralizedRegister::createGPR):
(JSC::DFG::GeneralizedRegister::createFPR):
(JSC::DFG::GeneralizedRegister::dump):
(JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
(JSC::DFG::GeneralizedRegister::findInEntryLocation):
(JSC::DFG::GeneralizedRegister::previousDataFormat):
(JSC::DFG::GeneralizedRegister::nextDataFormat):
(JSC::DFG::GeneralizedRegister::convert):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::ShuffledRegister):
(JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::ShuffledRegister::lookup):
(JSC::DFG::lookupForRegister):
(JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
(JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
(JSC::DFG::NodeToRegisterMap::set):
(JSC::DFG::NodeToRegisterMap::end):
(JSC::DFG::NodeToRegisterMap::find):
(JSC::DFG::NodeToRegisterMap::clear):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::linkSpeculationChecks):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):

  • dfg/DFGSpeculativeJIT.h:
17:53 Changeset [91803] by kbr@google.com
  • 6 edits in trunk

Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
17:25 Changeset [91802] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222

Reviewed by James Robinson.

No new tests - this fixes upcoming audionode.html layout test

  • bindings/v8/custom/V8AudioNodeCustom.cpp:

(WebCore::V8AudioNode::connectCallback):

17:15 Changeset [91801] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lazyInitialize):

17:14 Changeset [91800] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=65164

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

Add casts to/from various numeric types.
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator float):

  • css/CSSStyleApplyProperty.cpp:

Add class to handle properties that set an "auto" boolean on RenderStyle.
(WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Remove existing implementations.
(WebCore::CSSStyleSelector::applyProperty):

16:43 Changeset [91799] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Add protection space authentication callback code to CFNetwork loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=65190
<rdar://problem/9842424>

Reviewed by Oliver Hunt.

Port over protection space authentication callback code from ResourceHandleMac.mm to
ResourceHandleCFNet.cpp.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::canRespondToProtectionSpace):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.

16:30 Changeset [91798] by enne@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

[chromium] Check in expectations for font-family-pictograph.
https://bugs.webkit.org/show_bug.cgi?id=65197

Unreviewed gardening.

  • platform/chromium-linux/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-linux/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.txt: Added.
16:25 Changeset [91797] by abarth@webkit.org
  • 46 edits
    8 adds in trunk

Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL. The author can also supply a
suggested file name in the attribute value. This feature is a recent
addition to HTML to better support offline applications that use blob
URLs. Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event. This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html

fast/dom/HTMLAnchorElement/anchor-nodownload.html
fast/dom/HTMLAnchorElement/anchor-download-unset.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAttributeNames.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::startDownload):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::loadURLExternally):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::startDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::startDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::startDownload):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::startDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::startDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::startDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::startDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::loadURLExternally):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.
16:18 Changeset [91796] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark webaudio/test-basic as crashing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=65219.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:47 Changeset [91795] by oliver@apple.com
  • 4 edits in trunk

Buffer overflow creating error messages for JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=65211

Reviewed by Darin Adler.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Update testcase to reflect actual expected output.

  • fast/js/JSON-parse-expected.txt:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Parse string length to the UString constructor.

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::parse):

15:23 Changeset [91794] by mitz@apple.com
  • 5 edits in trunk/Tools

Rubber-stamped by Anders Carlsson.

Update DumpRenderTree and API tests for the pictograph font family preference.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

15:08 Changeset [91793] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Apply r40940 to WebKit2 to work around a Silverlight crash.
https://bugs.webkit.org/show_bug.cgi?id=65205
<rdar://problem/9058370>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-26
Reviewed by Anders Carlsson.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

15:07 Changeset [91792] by dglazkov@chromium.org
  • 7 edits in trunk/Tools

Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with

test configuration matching, removed a bunch of code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance

was created. 'default' is not a valid build type.

  • Scripts/webkitpy/layout_tests/port/test.py: Ditto. is not a valid version.
15:04 Changeset [91791] by abarth@webkit.org
  • 4 edits in trunk/Tools

Increase the information density in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65141

Reviewed by Dimitri Glazkov.

This patch changes lets us show each revision on a single line,
allowing use to show an entire day's worth of commits at once.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
14:56 Changeset [91790] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Refactor automatically generated JS DOM bindings to replace operator new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Replacing the public constructors in the automatically generated JS DOM bindings with static
create methods. JSByteArray is used by several of these bindings in WebCore.

(JSC::JSByteArray::create):

  • runtime/JSByteArray.h:

Source/WebCore:

No new tests.

Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
with static create methods. This is part of a larger refactoring effort to use static create methods
in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.

  • bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::create):

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::create):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListener::createPrototype):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):

  • bridge/jni/jsc/JavaArrayJSC.cpp:

(JavaArray::convertJObjectToArray):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::newRuntimeObject):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

14:52 Changeset [91789] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

14:51 Changeset [91788] by xji@chromium.org
  • 10 edits in trunk

--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace Position(node, offset, PositionIsOffsetInAnchor) with
createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position
before/after <br/> etc. editingIgnoresContent node.

When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns
InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns
InlineBox across multiple lines).

  • editing/htmlediting.cpp:

(WebCore::createPositionAvoidingIgnoredNode):

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
createPositionAvoidingIgnoredNode().
(WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
(WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
(WebCore::blockWithPreviousLineBox): Added.
(WebCore::previousRootInlineBox): Added.
(WebCore::blockWithNextLineBox): Added.
(WebCore::nextRootInlineBox): Added.
(WebCore::leftInlineBox): Added.
(WebCore::rightInlineBox): Added.
(WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
and rightInlineBox().
(WebCore::rightWordBoundary): Ditto.
(WebCore::leftWordPositionAcrossBoundary): Ditto.
(WebCore::rightWordPositionAcrossBoundary): Ditto.

LayoutTests:

Add test for multiple-line.

  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html: Add tests for multi-line. Shorten

test id.

  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Shorten test id.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordForEveryPosition):
(setWidth):
(runMoveLeftRight):

14:49 Changeset [91787] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Qt/Linux.

On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to http://trac.webkit.org/changeset/91752.

  • wtf/wtf.pri:
14:44 Changeset [91786] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

TestConfigurationConverter should not barf on invalid specifiers.
https://bugs.webkit.org/show_bug.cgi?id=65194

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,

made it return empty set whenever an invalid specifier is encountered.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
14:42 Changeset [91785] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Introduce a way to convert between specifier lists and TestConfiguration sets.
https://bugs.webkit.org/show_bug.cgi?id=65094

Add TestConfigurationConverter, a facility to convert:
1) a set of specifiers into a set of TestConfiguration instances;
2) a set of TestConfiguration instances into a list of sets of specifiers.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
14:37 Changeset [91784] by kerz@chromium.org
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

Merge 91720 - [Chromium] Use correct vertex shader when rendering video layer.
https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7477025

14:26 Changeset [91783] by kerz@chromium.org
  • 1 add in branches/chromium/835/codereview.settings

add codereview settings file for chromium 835 branch

14:17 Changeset [91782] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
https://bugs.webkit.org/show_bug.cgi?id=65171

Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:39 Changeset [91781] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60778

Use after free because of line box culling optimization regression.

In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.

The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.

The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.

Reviewed by Dan Bernstein.

Added editing/execCommand/crash-line-break-after-outdent.html

Source/WebCore:

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

  • editing/execCommand/crash-line-break-after-outdent-expected.txt: Added.
  • editing/execCommand/crash-line-break-after-outdent.html: Added.
13:36 Changeset [91780] by crogers@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add first basic layout test for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=57977

Reviewed by Tony Chang.

  • webaudio: Added.
  • webaudio/resources: Added.
  • webaudio/resources/audio-testing.js: Added.

(writeString):
(writeInt16):
(writeInt32):
(writeAudioBuffer):
(createWaveFileData):
(createAudioData):
(finishAudioTest):

  • webaudio/test-basic-expected.wav: Added.
  • webaudio/test-basic.html: Added.
13:28 Changeset [91779] by crogers@google.com
  • 2 edits in trunk/Tools

Avoid outputting #EOF twice for web audio tests in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=65201

Reviewed by Dirk Pranke.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

13:27 Changeset [91778] by mitz@apple.com
  • 2 edits in trunk

Fix change log typos

13:23 Changeset [91777] by mitz@apple.com
  • 28 edits
    3 adds in trunk

Source/WebCore: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

Test: fast/css/font-family-pictograph.html

  • WebCore.exp.in: Export Settings::setPictographFontFamily().
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily): Added -webkit-pictograph.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::fontDataForGenericFamily): Ditto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Ditto.

  • css/CSSValueKeywords.in:
  • inspector/front-end/CSSKeywordCompletions.js: Ditto.
  • inspector/front-end/SourceCSSTokenizer.js: Ditto.

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
  • page/Settings.cpp:

(WebCore::Settings::pictographFontFamily): Added this getter.
(WebCore::Settings::setPictographFontFamily): Added this setter.

  • page/Settings.h:
  • platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.

Source/WebKit/mac: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set the default pictograph font family to
"Apple Color Emoji".
(-[WebPreferences pictographFontFamily]): Added this getter.
(-[WebPreferences setPictographFontFamily:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Pass the preference through to WebCore.

Source/WebKit/win: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Interfaces/IWebPreferences.idl: Added pictographFontFamily() and

setPictographFontFamily().

  • WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize the pictograph font
preference to "Times New Roman".
(WebPreferences::pictographFontFamily): Added this getter.
(WebPreferences::setPictographFontFamily): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Pass the preference value through to
WebCore.

Source/WebKit2: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPictographFontFamily): Added.
(WKPreferencesCopyPictographFontFamily): Added.

  • UIProcess/API/C/WKPreferences.h:

LayoutTests: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • fast/css/font-family-pictograph.html: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.txt: Added.
12:54 Changeset [91776] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91689
BUG=88723
Review URL: http://codereview.chromium.org/7470026

12:48 Changeset [91775] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] getClientRects now fails similarly on Mac after r91763.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:37 Changeset [91774] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve (i.e., speed up) .gyp(i) files for Chromium
https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

This re-applies r91595 with the source exclusion fixed.

Test by building (in all supported configurations).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:26 Changeset [91773] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix accidental duplicate expectation from r91772.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:22 Changeset [91772] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark test as flaky after r91738.
https://bugs.webkit.org/show_bug.cgi?id=65199

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:14 Changeset [91771] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Disable video support on linux if the dependencies are not found.

If we can't find the necessary dependencies to build the GStreamer media player
we disable the video support. This is related to http://trac.webkit.org/changeset/91752.

Reviewed by Holger Freyther.

No new tests, it's a build fix.

  • features.pri:
12:13 Changeset [91770] by evan@chromium.org
  • 4 edits in trunk/Source/WebCore

regression: generating CSSValueKeywords should not print by default
https://bugs.webkit.org/show_bug.cgi?id=65195

Reviewed by Tony Chang.

Some refactoring made some callers no longer pass the final 'beQuiet'
parameter to applyPreprocessor. This flag was only used to print the
input filename anyway, so remove the flag and just make the caller
print the filename if it wants this.

  • bindings/scripts/IDLParser.pm:

(Parse): print before calling applyPreprocessor, if necessary.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): remove the beQuiet flag; just always be quiet.

12:03 Changeset [91769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not crash on the isSlider() assert.
https://bugs.webkit.org/show_bug.cgi?id=65191

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-26
Reviewed by Antonio Gomes.

RenderThemeEfl's paintSliderThumb() just forwarded the call to
paintSliderTrack(), which, on its turn, called code that assumed that
object->isSlider() was true. That does not seem to be the case for
slidethumbs, so any page with an <input type="range"> tag would crash
WebKit.

We now do what RenderThemeQt does, and assume everything was properly
done in the call to paintSliderTrack().

No new tests, as this has been uncovered by an existing test.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintSliderThumb):

11:53 Changeset [91768] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
https://bugs.webkit.org/show_bug.cgi?id=65182

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-26
Reviewed by Stephen White.

No new tests. Not sure how to test wrong-ctx bugs in layout tests.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

11:17 Changeset [91767] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More flaky crashers.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:09 Changeset [91766] by abecsi@webkit.org
  • 4 edits in trunk

.: [Qt] [WK2] Disable the build with Qt versions older than 5.0
https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Source/WebKit.pro: Abort if not using Qt5.

Source/WebKit2: [Qt] [WK2] Disable the build with Qt versions older than 5.0
https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Platform/qt/ModuleQt.cpp:

(WebKit::Module::platformFunctionPointer): Fix the build for Qt5.

10:53 Changeset [91765] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
10:53 Changeset [91764] by kerz@chromium.org
  • 1 copy in branches/chromium/835

Branch webkit for chromium

10:47 Changeset [91763] by eae@chromium.org
  • 6 edits in trunk

RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code
https://bugs.webkit.org/show_bug.cgi?id=62478

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dom/Range/getClientRects.html

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::isZero):
Add izZero method, unlike isEmpty this checks if both the width and the
height are zero.

  • rendering/RenderText.cpp:

(WebCore::absoluteQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
Break duplicate code out of absoluteRectsForRange and
absoluteQuadsForRange into shared static function.

Fix what I presume to be a bug in the absoluteQuadsForRange where the
logicalHeight was always used to set the size in absoluteQuadForTextBox
as oppsued to the absoluteRectsForRange implementation that uses the
logicalWidth or the logicalHeight depending on whether it's horizontal or
vertical.

LayoutTests:

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

Add test for vertical text.

10:37 Changeset [91762] by abarth@webkit.org
  • 2 edits in trunk/Tools

Windows bots on build.chromium.org can't figure out the head_svn_revision
https://bugs.webkit.org/show_bug.cgi?id=65156

Reviewed by Tony Chang.

This patch is a bit of a guess as to the issue based on the
investigation in https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
not sure whether it will fix the issue, but it seems worth a try.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
10:32 Changeset [91761] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark media-controls-clone as flaky crashing on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=65129

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [91760] by commit-queue@webkit.org
  • 13 edits
    8 adds in trunk

[CSSRegions] Collect flowed elements in different render element
https://bugs.webkit.org/show_bug.cgi?id=64516

Source/WebCore:

All the RenderObjects that have a specified "flow" name are moved out of the
normal flow. A RenderFlowThread will collect all such RenderObjects. There is
a RenderFlowThread for each flow name. The new RenderFlowThread is an anonymous
RenderBlock that is positioned absolute and will not render directly. In a
different bug/patch we will add RenderRegion that will take care of rendering the
RenderFlowThread on screen.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Simon Fraser.

Tests: fast/regions/webkit-flow-renderer-layer.html

fast/regions/webkit-flow-renderer-nested.html
fast/regions/webkit-flow-renderer.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::hasFlowThreadParent):
(WebCore::NodeRenderingContext::parentFlowRenderer):

  • rendering/RenderFlowThread.cpp: Added.

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addChild):
(WebCore::RenderFlowThread::removeChild):

  • rendering/RenderFlowThread.h: Added.

(WebCore::toRenderFlowThread):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFlowThread):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Simon Fraser.

  • fast/regions/webkit-flow-renderer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer.html: Added.
  • fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-nested.html: Added.
  • fast/regions/webkit-flow-renderer.html: Added.
10:08 Changeset [91759] by commit-queue@webkit.org
  • 12 edits in trunk

Source/WebCore: Filename text in file upload controls is not aligned with button text on
chromium-linux, chromium-win, and gtk.

https://bugs.webkit.org/show_bug.cgi?id=64692

The fix is to not include the margin, border, and padding in the calculation,
because those are already accounted for by RenderBlock::baselinePosition().

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests: In file upload controls, filename text was misaligned with button text.
Update chromium-linux with the new baseline images, and add temporary
exceptions for chromium-win and gtk until they can be rebaselined.

https://bugs.webkit.org/show_bug.cgi?id=64692

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
09:56 Changeset [91758] by benjamin.poulain@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Make the WebContextMenuProxyQt handle the full interactions between the views and the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=64739

Reviewed by Andreas Kling.

Change the WebContextMenuProxyQt to be the intermediary between the WebPageProxy and our views regarding
the context menu.

The actions of the context menu are no longer the responsibility of QtWebPageProxy but are instead
created and handled directly by the WebContextMenuProxyQt.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::actionTriggered):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
09:22 Changeset [91757] by pfeldman@chromium.org
  • 3 edits
    1 copy
    1 add in trunk/LayoutTests

2011-07-26 Pavel Feldman <pfeldman@google.com>

Not reviewed: inspector test rebaselines.

  • inspector/console/console-format-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Copied from LayoutTests/inspector/runtime/runtime-getProperties-expected.txt.
07:58 Changeset [91756] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r91746.
http://trac.webkit.org/changeset/91746
https://bugs.webkit.org/show_bug.cgi?id=65180

It broke SL build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/JavaScriptCore:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):
(WTF::StringImpl::simplifyWhiteSpace):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

Source/WebCore:

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

LayoutTests:

  • fast/forms/option-strip-unicode-spaces-expected.txt: Removed.
  • fast/forms/option-strip-unicode-spaces.html: Removed.
07:55 Changeset [91755] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/Source

[GTK] Remove header webkitwebviewcommon.h
https://bugs.webkit.org/show_bug.cgi?id=65177

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-07-26
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Move webkitwebviewcommon.h contents back to webkitwebview.h.

  • GNUmakefile.am: Remove webkitwebviewcommon.h
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewcommon.h: Removed.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.h: Add function prototypes

instead of including webkitwebviewcommon.h.

07:44 Changeset [91754] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: Better represent custom getters in the properties pane
https://bugs.webkit.org/show_bug.cgi?id=16734

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-getProperties.html

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

LayoutTests:

  • inspector/runtime/runtime-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-getProperties.html: Added.
07:16 Changeset [91753] by ossy@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/css/font-face-opentype-expected.png: Added.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated after r91738.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png: Updated after r91748.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt: Updated after r91748.
06:34 Changeset [91752] by abecsi@webkit.org
  • 8 edits in trunk/Source

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-07-26
Reviewed by Andreas Kling.

[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
https://bugs.webkit.org/show_bug.cgi?id=63472

Source/JavaScriptCore:

Enable the bits needed for GStreamer only when QtMultimedia is not used.

  • wtf/wtf.pri:

Source/WebCore:

Enable the GStreamer backend and the QuickTime backend as default media players
for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.

No new tests. The media layout tests are disabled on the Qt port but hopefully with this
switch we can enable them again.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:

Source/WebKit/qt:

Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
exist anymore, it's the default. Ditto for GStreamer.

05:16 Changeset [91751] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-07-26 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: (getPreferredSizeMethod):
05:01 QtWebKitBuildBots edited by zecke@selfish.org
(diff)
04:44 QtWebKitBuildBots edited by zecke@selfish.org
(diff)
04:36 QtWebKitBuildBots edited by ossy@webkit.org
Add MIPS bot, update obsolete infos of obsolete bots (diff)
04:20 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on Snow Leopard bots (diff)
04:17 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.7.x QtWebKit2.2 bot and on 4.8 trunk … (diff)
03:20 Changeset [91750] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=65112

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-setPropertyValue.html

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt: Added.
  • inspector/runtime/runtime-setPropertyValue.html: Added.
03:09 Changeset [91749] by pfeldman@chromium.org
  • 23 edits in trunk

2011-07-26 Pavel Feldman <pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

https://bugs.webkit.org/show_bug.cgi?id=65103
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionOn):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::callFunctionOn):
  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.prototype.get subtype): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype.get type): (WebInspector.LocalJSONObject.prototype.get subtype):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.inspect):

2011-07-26 Pavel Feldman <pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

https://bugs.webkit.org/show_bug.cgi?id=65103
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
03:05 Changeset [91748] by zimmermann@webkit.org
  • 11 edits in trunk/Source/WebCore

2011-07-26 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare animVal support - phase 2
https://bugs.webkit.org/show_bug.cgi?id=65167

Reviewed by Dirk Schulze.

Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.

Doesn't affect any tests, yet.

  • svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added). (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPathSegWithContext.h: Ditto. (WebCore::SVGPathSegWithContext::animatedProperty):
  • svg/SVGPolyElement.cpp: Ditto. (WebCore::SVGPolyElement::parseMappedAttribute):
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type. (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not. (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS. (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper. (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
  • svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff. (WebCore::SVGAnimatedPropertyTearOff::isAnimating): (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue): (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating): (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::updateAnimVal):
02:39 Changeset [91747] by hans@chromium.org
  • 2 edits in trunk/LayoutTests

Update another test that relied on fonts loading synchronously.
https://bugs.webkit.org/show_bug.cgi?id=65169

Not Reviewed, tests fix.

  • platform/chromium-linux/fast/text/international/arabic-vertical-offset.html:
02:10 Changeset [91746] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):

Added an interface to take IsWhiteSpaceFunctionPtr.

(WTF::StringImpl::simplifyWhiteSpace): ditto.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.

  • wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • fast/forms/option-strip-unicode-spaces-expected.txt: Added.
  • fast/forms/option-strip-unicode-spaces.html: Added.
00:17 Changeset [91745] by morrita@google.com
  • 2 edits in trunk/Tools

[Chromium][DRT] MockSpellCheck.cpp should be clang clean
https://bugs.webkit.org/show_bug.cgi?id=65166

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord): -Wsign-compare warning.

00:05 Changeset [91744] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add regression test for :empty { display: none }
https://bugs.webkit.org/show_bug.cgi?id=26570

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-26
Reviewed by Alexey Proskuryakov.

  • fast/css/pseudo-empty-display-none-expected.txt: Added.
  • fast/css/pseudo-empty-display-none.html: Added.

07/25/11:

22:35 Changeset [91743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT emits inefficient code for arithmetic
involving two registers
https://bugs.webkit.org/show_bug.cgi?id=65160

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The non-speculative JIT now emits inline code for double arithmetic, but
still attempts integer arithmetic first. This is a speed-up on SunSpider
(albeit a small one), and a large speed-up on Kraken.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::basicArithOp):

22:21 Changeset [91742] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

[CMAKE] Split JSC related files from WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=61350

Reviewed by Daniel Bates.

No new tests, just moving jsc related files from CMakeLists.txt to UseJSC.cmake.

  • CMakeLists.txt:
  • UseJSC.cmake:
22:11 Changeset [91741] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused code in ewk_tile_model.c
https://bugs.webkit.org/show_bug.cgi?id=64521

Remove unused code in ewk_tile_model.c. Dirty flag is not referenced anywhere.

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-07-25
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_model.c:

(ewk_tile_unused_cache_clear):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

21:44 Changeset [91740] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated three more tests that relied on fonts loading synchronously.

  • fast/blockflow/japanese-rl-text-with-broken-font.html:
  • platform/mac/fast/text/myanmar-shaping.html:
  • platform/mac/fast/text/thai-combining-mark-positioning.html:
20:37 Changeset [91739] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build by committing a rename in this file that I neglected to include in the previous commit.

  • css/CSSFontFaceSource.h:
20:21 Changeset [91738] by mitz@apple.com
  • 19 edits in trunk

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
https://bugs.webkit.org/show_bug.cgi?id=65123

Source/WebCore:

Reviewed by Anders Carlsson and Darin Adler.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:

LayoutTests:

Reviewed by Darin Adler.

Updated tests that depended on fonts loading synchronously during layout.
Unfortunately, font loading does not fire any DOM events, so in most cases
a constant timeout had to be introduced.

  • fast/blockflow/broken-ideograph-small-caps.html:
  • fast/css/color-leakage.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-remote-sources.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-woff.html:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
  • svg/custom/svg-fonts-fallback.xhtml:
  • svg/custom/svg-fonts-in-html.html:
  • svg/custom/svg-fonts-segmented.xhtml:
  • svg/custom/svg-fonts-with-no-element-reference.html:
  • svg/custom/svg-fonts-without-missing-glyph.xhtml:
  • svg/text/text-overflow-ellipsis-svgfont.html:
18:41 Changeset [91737] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Build break with --debug after r89153.
https://bugs.webkit.org/show_bug.cgi?id=65150

Unreviewed build fix.

  • wtf/CMakeListsEfl.txt: Add missing libraries.
18:18 Changeset [91736] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
18:07 Changeset [91735] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor ScrollableArea pinned predicates to be more generally useful
<rdar://problem/9740379>

Reviewed by Dan Bernstein.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedInBothDirections):
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
(WebCore::ScrollableArea::isPinnedVerticallyInDirection):

  • platform/ScrollableArea.h:
18:04 Changeset [91734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT emits obviously inefficient code for arithmetic
where one operand is a constant.
https://bugs.webkit.org/show_bug.cgi?id=65146

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Changed the code to emit double arithmetic inline.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):

18:03 Changeset [91733] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] components/mac: Make webcore not depend on CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=65143

Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:
18:02 Changeset [91732] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/cyclic-prototypes.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:58 Changeset [91731] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] draw-arrays-out-of-bounds.html is a non-GPU flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:40 Changeset [91730] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't link in both libjpeg and libjpeg_turbo in the components build
https://bugs.webkit.org/show_bug.cgi?id=65138

Reviewed by James Robinson.

  • WebKit.gyp:
17:31 Changeset [91729] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/selectors/001.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:25 Changeset [91728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT bytecode parser misuses pointers into objects allocated as part of a
WTF::Vector.
https://bugs.webkit.org/show_bug.cgi?id=65128

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The bytecode parser code seems to be right to have a DFGNode& phiNode reference
into the graph, since this makes the code greatly more readable. This patch
thus makes the minimal change necessary to make the code right: it uses a
pointer (to disambiguate between reloading the pointer and performing a
copy from one location of the vector to another) and reloads it after the
calls to addToGraph().

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

17:12 Changeset [91727] by commit-queue@webkit.org
  • 5 edits in trunk/Source

WebFrame should have a method to determine its visual emptiness
https://bugs.webkit.org/show_bug.cgi?id=64223

Patch by Ian Henderson <ianh@apple.com> on 2011-07-25
Reviewed by Dan Bernstein.

Source/WebCore:

  • page/FrameView.h:

(WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
so we can tell whether it's visually non-empty.

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
through WebKit.

  • WebView/WebFramePrivate.h:
17:11 Changeset [91726] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/cyclic-proto.html as a flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:57 Changeset [91725] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Rollback previous patch. Occasional crashes seen caused by
CachedResource being deleted twice.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):

  • loader/cache/CachedResourceLoader.h:
16:56 Changeset [91724] by paroga@webkit.org
  • 3 edits in trunk/Tools

Ignore line endings in ChangeLogTests
https://bugs.webkit.org/show_bug.cgi?id=64956

Reviewed by Adam Barth.

Split the lines of the ChangeLog text before comparing them.
This fixes 3 tests on windows, since only the content importent.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
16:40 Changeset [91723] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

Deprecate AudioBufferSourceNode .looping attribute and implement .loop
https://bugs.webkit.org/show_bug.cgi?id=65133

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::loop):
(WebCore::AudioBufferSourceNode::setLoop):

  • webaudio/AudioBufferSourceNode.idl:
16:35 Changeset [91722] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] HUD texture must be unreserved after drawing
https://bugs.webkit.org/show_bug.cgi?id=65122

Unreserve the HUD texture after drawing. To test, start chrome in debug with --show-fps-counter. Since this is
a debugging option, no tests.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

16:28 Changeset [91721] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix leveldb crash when compacting during destruction
https://bugs.webkit.org/show_bug.cgi?id=64494

Patch by David Grogan <dgrogan@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Only tested manually so far by following the repro instructions at
crbug.com/88944

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::~LevelDBDatabase):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):

16:27 Changeset [91720] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Use correct vertex shader when rendering video layer.
https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

16:14 Changeset [91719] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
https://bugs.webkit.org/show_bug.cgi?id=65148

Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
16:12 Changeset [91718] by paroga@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix AtomicString vs. String usage in accessibility code
https://bugs.webkit.org/show_bug.cgi?id=65086

Reviewed by Darin Adler.

Use AtomicString instead of String where appropriate
to avoid implicit type conversations.
Also fix a invalid reference to a temporary String.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::elementsFromAttribute):
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.h:
16:10 Changeset [91717] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark user-script-image-document as a flaky crasher on Linux

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

16:02 Changeset [91716] by ojan@chromium.org
  • 2 edits in trunk/Tools

Tweak whitespace wrapping to improve readability.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:59 Changeset [91715] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r91686.
http://trac.webkit.org/changeset/91686
https://bugs.webkit.org/show_bug.cgi?id=65144

1.5% regression in JSC (Requested by jmontemayor on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/JavaScriptCore:

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Removed.
15:54 Changeset [91714] by crogers@google.com
  • 5 edits in trunk/LayoutTests

Disable web audio layout tests on all platforms except chromium - as initial tests are added
https://bugs.webkit.org/show_bug.cgi?id=65142

Unreviewed.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
15:41 Changeset [91713] by ojan@chromium.org
  • 3 edits in trunk/Tools

Minor tweak to wrap label elements as atomic units.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:33 Changeset [91712] by ojan@chromium.org
  • 2 edits in trunk/Tools

always show flakiness details on the builder page
https://bugs.webkit.org/show_bug.cgi?id=65139

Reviewed by Tony Chang.

In order to simplify the UI, we hide the flakiness details by default,
but there's no actual use-case for this page without the flakiness details.
So get rid of that option and always show the flakiness details.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:32 Changeset [91711] by ojan@chromium.org
  • 3 edits in trunk/Tools

simplify the UI of the header above the test list table
https://bugs.webkit.org/show_bug.cgi?id=65136

Reviewed by Adam Barth.

Use checkboxes instead of links since this is really about which tests to include.
Ends up using less text and put the checkboxes to the right of the header instead of below it.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15:23 Changeset [91710] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Reverted r91699 due to
<http://webkit.org/b/65134> REGRESSION: r91699 broke some font tests (image+text)

Many tests relied on font loading occurring synchronously in the cached and local cases.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
15:23 Changeset [91709] by crogers@google.com
  • 2 edits in trunk/Tools

Update new-run-webkit-tests to accomodate binary audio data
https://bugs.webkit.org/show_bug.cgi?id=65135

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:16 Changeset [91708] by crogers@google.com
  • 9 edits
    2 adds in trunk

Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
https://bugs.webkit.org/show_bug.cgi?id=65039

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebArrayBufferView.h: Added.

(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):

  • public/WebBindings.h:
  • src/WebArrayBufferView.cpp: Added.

(WebKit::WebArrayBufferView::assign):
(WebKit::WebArrayBufferView::reset):
(WebKit::WebArrayBufferView::baseAddress):
(WebKit::WebArrayBufferView::byteOffset):
(WebKit::WebArrayBufferView::byteLength):
(WebKit::WebArrayBufferView::WebArrayBufferView):
(WebKit::WebArrayBufferView::operator=):
(WebKit::WebArrayBufferView::operator PassRefPtr<ArrayBufferView>):

  • src/WebBindings.cpp:

(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getArrayBufferView):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setAudioData):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::audioData):

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(DRTPrinter::handleAudioHeader):
(TestShellPrinter::handleAudioHeader):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

14:43 Changeset [91707] by mrobinson@webkit.org
  • 35 edits
    10 adds in trunk

Reviewed by Gustavo Noronha Silva.

[GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
https://bugs.webkit.org/show_bug.cgi?id=62252

Source/WebCore:

Properly handle the situation where the GtkWidget wants WebCore to draw its
own main frame scrollbars.

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
(WebCore::ScrollView::createScrollbar): Use the new helper.
(WebCore::ScrollView::visibleContentRect): Use the new helper.

Source/WebKit/gtk:

Added an undocumented self-scrolling property to WebKitWebView which
communicates to WebCore whether or not this widget is expected to draw
its own main frame scrollbars or not.

  • webkit/webkitwebview.cpp: Add the self-scrolling property.
  • webkit/webkitwebviewprivate.h: Add the selfScrolling private member.

Tools:

Add a new subclass of WebKitWebView that overrides the size request to
return 1 pixel by 1 pixel. This ensure that it operates properly when
not packed into a GtkScrolledWindow. Also construct the WebKitWebView
with self-scrolling set to true.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
(createWebView): Ditto.
(main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.

(self_scrolling_webkit_web_view_class_init):
(self_scrolling_webkit_web_view_init):
(self_scrolling_webkit_web_view_new):
(sizeRequestMethod):
(getPreferredSizeMethod):

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
  • GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.

LayoutTests:

Unskip tests which are now passing and update results for tests which
previously had incorrect results.

  • platform/gtk/Skipped: Unskip now-passing tests.
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.png:
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/flexbox/flex-hang-expected.png:
  • platform/gtk/fast/flexbox/flex-hang-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.png:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.png: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.png: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
14:33 Changeset [91706] by jonlee@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Assertion called in ExecutableBase::generatedJITCodeForCall() when JIT is not available
https://bugs.webkit.org/show_bug.cgi?id=65132
<rdar://problem/9836297>

Reviewed by Oliver Hunt.

Make sure the JIT is available to use before running the following calls:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::unlinkCalls): Added check, return early if JIT is not available.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addMethodCallLinkInfos): Added assertion.

14:01 Changeset [91705] by ojan@chromium.org
  • 3 edits in trunk/Tools

by default hide tests that have passes for all recorded runs
https://bugs.webkit.org/show_bug.cgi?id=65127

Reviewed by Adam Barth.

This is part of simplifying the default views of the dashboard to
make it show less information for the common use cases.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
13:45 Changeset [91704] by ojan@chromium.org
  • 7 edits in trunk/Tools

stop generating expectations.json now that it's unused
https://bugs.webkit.org/show_bug.cgi?id=65130

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • TestResultServer/handlers/menu.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
13:20 Changeset [91703] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] media-controls-clone started flaky crashing on mac.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

13:08 Changeset [91702] by hyatt@apple.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65125

(1) Add the new CSS3 positioned value for floats.
(2) Rename FLEFT, FRIGHT and FNONE to our more modern convention: NoFloat, LeftFloat, RightFloat.
(3) Replace uses of == FNONE and != FNONE with isFloating and !isFloating.

Reviewed by Dan Bernstein.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFloat):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • css/CSSValueKeywords.in:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isFloating):
(WebCore::InheritedFlags::initialFloating):

  • rendering/style/RenderStyleConstants.h:
13:08 Changeset [91701] by ojan@chromium.org
  • 2 edits in trunk/Tools

don't show builders in the flakiness dashboard that have stopped running a given test suite
https://bugs.webkit.org/show_bug.cgi?id=65126

Reviewed by Mihai Parparita.

  • TestResultServer/static-dashboards/dashboard_base.js:
13:05 Changeset [91700] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More WebGL flaky crashers on Linux.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

13:00 Changeset [91699] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
https://bugs.webkit.org/show_bug.cgi?id=65123

Reviewed by Anders Carlsson.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:
12:55 Changeset [91698] by dbates@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-07-25 Daniel Bates <dbates@rim.com>

Rename expected results file after changeset <http://trac.webkit.org/changeset/91689>.

  • fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt: Copied from LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt.
  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Removed.
12:50 Changeset [91697] by mrobinson@webkit.org
  • 51 edits
    2 adds in trunk/LayoutTests

Update baselines for GTK+ after several revisions.

  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt:
  • platform/gtk/fast/forms/input-appearance-range-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.png:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
12:46 Changeset [91696] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:42 Changeset [91695] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.4

New tag.

12:20 Changeset [91694] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)
https://bugs.webkit.org/show_bug.cgi?id=64878

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Adopt GraphicsContext3DOpenGL.cpp and ANGLE compiler for Qt.

  • WebCore.pro: Build ANGLE compiler and GraphicsContext3DOpenGL.cpp.
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h: Expose exising ANGLEWebKitBridge compiler member for Qt.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLE resources.

12:08 Changeset [91693] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More ICU roll test failures from the slow windows bot
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:59 Changeset [91692] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91147.

11:58 Changeset [91691] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7506003

11:57 Changeset [91690] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] japanese-rl-selection-repaint also broken by ICU roll
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:55 Changeset [91689] by dbates@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r85964): Improper relayout of some nested positioned elements
https://bugs.webkit.org/show_bug.cgi?id=64286

Reviewed by David Hyatt.

Source/WebCore:

Fixes an issue when traversing up the containing block hierarchy after skipping
relatively positioned inlines.

When processing a positioned element we skip any intermediate inlines to get to
to enclosing block B, but don't use the containing block for B (call this P_B) to
properly continue traversing up the containing block hierarchy. So, B may be
considered again instead of looking at P_B. Hence, we don't set the correct dirty
bits for P_B and may not schedule a relayout with respect to the correct layout node.

Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Add test case to ensure we don't regress relayout of nested positioned elements.

  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Added.
  • fast/block/positioning/relayout-nested-positioned-elements-crash.html: Added.
11:55 Changeset [91688] by cevans@google.com
  • 2 edits
    2 deletes in branches/chromium/782

Revert 91684 - Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7503002

11:43 Changeset [91687] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] japanese-rl-selection-clear broken by ICU roll
https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:41 Changeset [91686] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk

JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
11:34 Changeset [91685] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91611
BUG=90222
Review URL: http://codereview.chromium.org/7499005

11:32 Changeset [91684] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 91386
BUG=88889
Review URL: http://codereview.chromium.org/7502005

11:21 Changeset [91683] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark media/remove-from-document as another flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:11 Changeset [91682] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More WebGL flaky crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:08 Changeset [91681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

removes last ENABLE(DRAG_SUPPORT) gtk check
https://bugs.webkit.org/show_bug.cgi?id=64518

Patch by Arno Renevier <arno@renevier.net> on 2011-07-25
Reviewed by Martin Robinson.

  • platform/gtk/ClipboardGtk.h:
11:03 Changeset [91680] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark some media tests as being crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [91679] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape
https://bugs.webkit.org/show_bug.cgi?id=65096

Source/WebCore:

Also the 'inherit' keyword is now treated correctly. It will
copy the value from the parent style.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-25
Reviewed by Tony Chang.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

Fixed 'inherit' test to copy the value from the parent. Also, added new tests
for 'inerhit' with no value in the parent.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-25
Reviewed by Tony Chang.

  • fast/exclusions/parsing-wrap-shape-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape.js:
10:59 Changeset [91678] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

X86-64 assembler emits three instructions instead of two for certain
loads and stores.
https://bugs.webkit.org/show_bug.cgi?id=65095

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Simply made these four methods in the assembler use the scratch register,
which they were previously avoiding. It still optimizes for the case where
an absolute address memory accesses is using EAX. This results in a slight
performance improvement.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load32):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::storePtr):

10:51 Changeset [91677] by abarth@webkit.org
  • 10 edits
    1 add in trunk/Tools

Overhaul garden-o-matic frontend to integrate revision history and failures
https://bugs.webkit.org/show_bug.cgi?id=65089

Reviewed by Dimitri Glazkov.

This is a major overhaul of the garden-o-matic frontend. The new UI
integrates the revision history information with failures. Failures
appear in context adjacent to the revisions that caused them (which are
highlighted). Each buildbot receives a collumn to the left, which
indicates which revisions that bot has tested and whether that bot
showed the indicated failures.

Failures are selectable with checkboxes, and can then either be
examined or rebaselined.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
10:47 Changeset [91676] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

disable tests pending rebaseline with rotated text fix
https://bugs.webkit.org/show_bug.cgi?id=65114

Patch by Mike Reed <reed@google.com> on 2011-07-25
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
10:45 Changeset [91675] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark gl-enum-enable-test as a flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:39 Changeset [91674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

glActiveTexture(0) is invalid
https://bugs.webkit.org/show_bug.cgi?id=65115

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Kenneth Russell.

Existing WebGL layout tests.

Fix invalid glActiveTexture(0) call.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::prepareTexture):

10:06 Changeset [91673] by pfeldman@chromium.org
  • 14 edits in trunk

Unreviewed, rolling out r91665.
http://trac.webkit.org/changeset/91665
https://bugs.webkit.org/show_bug.cgi?id=65118

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
10:00 Changeset [91672] by pfeldman@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r91668.
http://trac.webkit.org/changeset/91668
https://bugs.webkit.org/show_bug.cgi?id=65117

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
09:40 Changeset [91671] by zecke@webkit.org
  • 2 edits in trunk/Tools

[buildbot] Add Qt Linux MIPSEL Configuration
https://bugs.webkit.org/show_bug.cgi?id=65116

Reviewed by Adam Roben.

Introduce a Qt Linux MIPS EL build slave. The configuration
is a build only configuration.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
09:21 Changeset [91670] by podivilov@chromium.org
  • 3 edits
    1 copy in trunk/LayoutTests

2011-07-25 Pavel Podivilov <podivilov@chromium.org>

Web Inspector: unreviewed, fix pause-in-internal-script expectations.
https://bugs.webkit.org/show_bug.cgi?id=65078

  • inspector/debugger/pause-in-internal-script-expected.txt:
  • platform/chromium/inspector/debugger/pause-in-internal-script-expected.txt: Copied from LayoutTests/inspector/debugger/pause-in-internal-script-expected.txt.
  • platform/qt/Skipped:
08:51 Changeset [91669] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Add more tests to cover the behavior of loadFinished() signal
https://bugs.webkit.org/show_bug.cgi?id=63490

Reviewed by Benjamin Poulain.

  • tests/qwebframe/tst_qwebframe.cpp:

(FakeReply::FakeReply):
(FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.

(tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
after a 404 error without contents.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
is true when we use error page extension to produce our own error pages.

08:10 Changeset [91668] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: use dedicated type for object id in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
07:48 Changeset [91667] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt][WK2] Add multi-point touch mocking to MiniBrowser

https://bugs.webkit.org/show_bug.cgi?id=64374

Reviewed by Benjamin Poulain.

Each mouse button generate a touch point. The touch point stay
virtually on screen if the mouse release happened while the Ctrl
modifier was pressed.

07:42 Changeset [91666] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: live edit error should be revealed in Console
https://bugs.webkit.org/show_bug.cgi?id=65109

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):

07:24 Changeset [91665] by pfeldman@chromium.org
  • 14 edits in trunk

Web Inspector: refactor remote object structure to contain value for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=65103

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get subtype):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):
(WebInspector.LocalJSONObject.prototype.get subtype):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
07:01 Changeset [91664] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Use NRWT for Qt-WK2
https://bugs.webkit.org/show_bug.cgi?id=65097

Reviewed by Andreas Kling.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

05:52 Changeset [91663] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Fix mixing of retaining path in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=65028

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotPathFinderState): Added
(WebInspector.HeapSnapshotRetainingPathsList): Extracted State-specific code

05:47 Changeset [91662] by ossy@webkit.org
  • 43 edits
    2 adds in trunk/LayoutTests

[Qt] Lot of RenderTree mismatches in fast/multicol
https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening. Add Qt specific expected results after r91474.

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.png: Added.
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt/fast/multicol/float-multicol-expected.txt:
  • platform/qt/fast/multicol/scrolling-overflow-expected.png:
  • platform/qt/fast/multicol/scrolling-overflow-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt:
05:17 Changeset [91661] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: worker inspector should show Scripts panel by default
https://bugs.webkit.org/show_bug.cgi?id=65099

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector._defaultPanelName):
(WebInspector.showPanel):

00:18 Changeset [91660] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
https://bugs.webkit.org/show_bug.cgi?id=64354

Use ecore_time_unix_get which returns unix time as double type for currentTime
and ecore_time_get which uses monotonic clock for monotonicallyIncreasingTime.

Reviewed by Kent Tamura.

  • wtf/CurrentTime.cpp:

(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

00:10 Changeset [91659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Move macro checking inside ewk_view_context_menu_forward_event
https://bugs.webkit.org/show_bug.cgi?id=64682

When CONTEXT_MENUS macro is disabled method ewk_view_context_menu_forward_event just
returns EINA_FALSE and it avoid undefined reference during building.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

00:09 Changeset [91658] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Method ewk_context_menu_destroy returns EINA_FALSE if CONTEXT_MENUS macro is disabled
https://bugs.webkit.org/show_bug.cgi?id=64683

Fix returned value and omit NULL checking if CONTEXT_MENUS macro is disabled
in ewk_context_menu_destroy.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_destroy):

07/24/11:

22:10 Changeset [91657] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Small cleanup of m_fontDirty tracking in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=65090

Reviewed by Darin Adler.

1) Use existing setFontDescription helper where appropriate.
2) Move always used m_fontDirty check into updateFont()

No new tests / cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::updateFontIfDirty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
21:42 Changeset [91656] by tkent@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

[Chromium] Leftover of r91633 (SVG test move)

  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.txt.
21:38 Changeset [91655] by tkent@chromium.org
  • 6 edits
    6 adds in trunk/LayoutTests

[Chromium] Update expectations for r91637.

  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
20:36 Changeset [91654] by tkent@chromium.org
  • 4 edits in trunk

Validation message bubble position is incorrect if the containing block has paddings.
https://bugs.webkit.org/show_bug.cgi?id=65091

Reviewed by Hajime Morita.

Source/WebCore:

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
We don't need to subtract paddings because the origin of
position:aboslute is inside borders and outside of the padding.

LayoutTests:

  • fast/forms/validation-message-in-relative-body.html: Update the test to cover a padding case.
19:16 Changeset [91653] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-07-24 Rob Buis <rbuis@rim.com>

Crash in SVGUseElement::updateContainerOffsets on <use> with no parent
https://bugs.webkit.org/show_bug.cgi?id=63646

Reviewed by Darin Adler.

Prevent using invalid targetElementInstance->shadowTreeElement after shadow render tree recreation. This situation can
only occur when there was a valid shadowTreeElement before setting xlink:href to empty/invalid.

Test: svg/custom/use-shadow-root-parent-removal.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
18:27 Changeset [91652] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix AtomicString vs. String usage in JSC binding
https://bugs.webkit.org/show_bug.cgi?id=65085

Reviewed by Darin Adler.

Use ustringToAtomicString instead of ustringToString where appropriate.

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
17:38 Changeset [91651] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyOutlineOffset in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64773

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

13:54 Changeset [91650] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Yet another unreviewed Qt fixery for the weekend.

Don't use test_expectations until all of the Qt platforms switched to NRWT.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
12:49 Changeset [91649] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r91635.
http://trac.webkit.org/changeset/91635
https://bugs.webkit.org/show_bug.cgi?id=65083

It broke the minimal build (Requested by Ossy_OFFLINE on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-24

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

11:48 Changeset [91648] by abarth@webkit.org
  • 7 edits in trunk/Tools

Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
09:03 Changeset [91647] by kbalazs@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening for Qt.

  • platform/qt/svg/custom/tref-own-content-removal-expected.txt: Added.
09:01 Changeset [91646] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] inspector/debugger/pause-in-internal-script.html fails
https://bugs.webkit.org/show_bug.cgi?id=65078

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Mark the test as expected TEXT failure.
08:23 Changeset [91645] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Lot of RenderTree mismatches in fast/multicol
https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Add expected TEXT failures.
06:57 Changeset [91644] by rwlbuis@webkit.org
  • 5 edits
    3 adds in trunk

2011-07-24 Rob Buis <rbuis@rim.com>

SVG <use> element is not repositioned when moved to x=0 y=0 through script
https://bugs.webkit.org/show_bug.cgi?id=53767

Reviewed by Nikolas Zimmermann.

Only bail out on zero offset if it is not explicitly set.

Test: svg/custom/use-move-to-offset.svg

  • rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement): (WebCore::SVGShadowTreeContainerElement::setContainerOffset):
  • rendering/svg/SVGShadowTreeElements.h: (WebCore::SVGShadowTreeContainerElement::containerOffsetChanged): (WebCore::SVGShadowTreeContainerElement::setContainerOffsetChanged):
03:07 Changeset [91643] by jpfau@apple.com
  • 13 edits
    2 adds in trunk/Source/WebCore

Refactor HTML tokenizer code in preparation for a new XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65000

Reviewed by Adam Barth.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLNames::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLNames::isEndTagBufferingState):
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::TextDocumentParser):

  • html/parser/TextViewSourceParser.cpp:

(WebCore::TextViewSourceParser::TextViewSourceParser):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::type):

  • xml/parser/MarkupTokenizerBase.h: Added.

(WebCore::MarkupTokenizerBase::~MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::lineNumber):
(WebCore::MarkupTokenizerBase::columnNumber):
(WebCore::MarkupTokenizerBase::state):
(WebCore::MarkupTokenizerBase::setState):
(WebCore::MarkupTokenizerBase::forceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::setForceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
(WebCore::MarkupTokenizerBase::MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):
(WebCore::MarkupTokenizerBase::emitAndResumeIn):
(WebCore::MarkupTokenizerBase::emitAndReconsumeIn):
(WebCore::MarkupTokenizerBase::emitEndOfFile):
(WebCore::MarkupTokenizerBase::reset):
(WebCore::MarkupTokenizerBase::haveBufferedCharacterToken):

  • xml/parser/MarkupTokenizerInlineMethods.h: Added.

(WebCore::isTokenizerWhitespace):
(WebCore::advanceStringAndASSERTIgnoringCase):
(WebCore::advanceStringAndASSERT):

07/23/11:

20:30 Changeset [91642] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

TestConfiguration should be hashable and comparable for equality.
https://bugs.webkit.org/show_bug.cgi?id=65070

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added hash and eq methods.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
16:42 Changeset [91641] by paroga@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove WTF namespace from isMainThread() calls
https://bugs.webkit.org/show_bug.cgi?id=65068

Reviewed by Sam Weinig.

Because of the using WTF::isMainThread in the header there is no
reason to include the namespace name when calling this function.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • page/DOMWindow.cpp:
  • page/History.cpp:
15:44 Changeset [91640] by tkent@chromium.org
  • 9 edits in trunk/LayoutTests

[Chromium] Update expectations for r91636.

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
14:16 Changeset [91639] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk/Tools

Extract TestConfiguration from base and write a few unit tests to capture current behavior.
https://bugs.webkit.org/show_bug.cgi?id=65066

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
11:44 Changeset [91638] by alokp@chromium.org
  • 11 edits in trunk

Switching off acceleration for small canvas broke gpu tests
https://bugs.webkit.org/show_bug.cgi?id=65053

Reviewed by Stephen White.

Source/WebCore:

No new tests. These are supposed to fix existing canvas tests on gpu.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldAccelerateCanvas):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
(WebCore::Settings::setMinimumAccelerated2dCanvasSize):

  • page/Settings.h:

(WebCore::Settings::minimumAccelerated2dCanvasSize):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):

  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
11:17 Changeset [91637] by rwlbuis@webkit.org
  • 12 edits
    3 adds in trunk

2011-07-23 Rob Buis <rbuis@rim.com>

Freed SVGTRefElement used in SVGStyledElement::buildPendingResourcesIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=64758

Reviewed by Nikolas Zimmermann.

Fix the crash by storing referenced content inside a shadow tree. This way removing child nodes of
the <tref> does not remove the referenced content.

  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • dom/Text.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGShadowText::create): (WebCore::SVGShadowText::SVGShadowText): (WebCore::SVGShadowText::createRenderer): (WebCore::SVGShadowText::recalcStyle): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::childShouldCreateRenderer):
09:21 Changeset [91636] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebCore: Display number field without using a thousand separator.
https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

Separated formatters for parsing and displaying.
Removed a test for thousand separator.

  • manual-tests/input-number-localization.html:

Removed a test for thousand separator.
Made the test description more specific.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::createFormatterForCurrentLocaleToDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

LayoutTests: Marked fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Mark fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
08:39 Changeset [91635] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-23
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

07:54 Changeset [91634] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Turn on new WebSocket protocol in worker shadow page
https://bugs.webkit.org/show_bug.cgi?id=64852

Reviewed by Dmitry Titov.

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::initializeLoader):
Initialize the value of WebCore::Settings::useHixie76WebSocketProtocol()
for a new shadow page. The default value of this flag is overridden through
WebPreferences (located in webkit/glue in Chromium source tree) but a shadow
page does not receive the preference values from it.

04:18 Changeset [91633] by zimmermann@webkit.org
  • 4 edits
    4 copies
    145 moves
    18 adds
    1 delete in trunk/LayoutTests

2011-07-23 Nikolas Zimmermann <nzimmermann@rim.com>

Move several SVG specific tests out of fast/(backgrounds|borders) into svg/(as-background-image|as-border-image) as
we're only running pixel tests for the svg/ subdirectory on a daily base. Also it's easier to spot errors this way.
Updated all Skipped/test_expectations.txt files as well.

Rubber-stamped by Maciej Stachowiak.

  • fast/backgrounds/animated-svg-as-background.html: Removed.
  • fast/backgrounds/resources/animated-rect-fixed-size.svg: Removed.
  • fast/backgrounds/resources/balloon.svg: Removed.
  • fast/backgrounds/resources/eyes.svg: Removed.
  • fast/backgrounds/resources/hearts.svg: Removed.
  • fast/backgrounds/resources/map.svg: Removed.
  • fast/backgrounds/resources/mouse-repel.svg: Removed.
  • fast/backgrounds/svg-as-background-1.html: Removed.
  • fast/backgrounds/svg-as-background-2.html: Removed.
  • fast/backgrounds/svg-as-background-3.html: Removed.
  • fast/backgrounds/svg-as-background-4.html: Removed.
  • fast/backgrounds/svg-as-background-5.html: Removed.
  • fast/backgrounds/svg-as-background-6.html: Removed.
  • fast/borders/resources/large-tiles.png: Removed.
  • fast/borders/resources/tiles-fixed-size.svg: Removed.
  • fast/borders/resources/tiles-relative-size.svg: Removed.
  • fast/borders/resources/tiles.png: Removed.
  • fast/borders/svg-as-border-image-2.html: Removed.
  • fast/borders/svg-as-border-image.html: Removed.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image: Added.
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-linux/svg/as-border-image: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-background-image: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac-leopard/svg/as-border-image: Added.
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image: Added.
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-win/svg/as-background-image: Added.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/chromium-win/svg/as-border-image: Added.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image: Added.
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/gtk/svg/as-border-image: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.png.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/gtk/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac-leopard/svg/as-background-image: Added.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac-leopard/svg/as-border-image: Added.
  • platform/mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/mac/svg/as-background-image: Added.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/mac/svg/as-border-image: Added.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/qt/svg/as-background-image: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/qt/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • svg/as-background-image: Added.
  • svg/as-background-image/animated-svg-as-background.html: Copied from fast/backgrounds/animated-svg-as-background.html.
  • svg/as-background-image/resources: Added.
  • svg/as-background-image/resources/animated-rect-relative-size.svg: Copied from fast/backgrounds/resources/animated-rect-relative-size.svg.
  • svg/as-background-image/resources/balloon.svg: Copied from fast/backgrounds/resources/balloon.svg.
  • svg/as-background-image/resources/butterfly.svg: Copied from svg/as-image/resources/butterfly.svg.
  • svg/as-background-image/resources/circle.svg: Copied from svg/as-image/resources/circle.svg.
  • svg/as-background-image/resources/eyes.svg: Copied from fast/backgrounds/resources/eyes.svg.
  • svg/as-background-image/resources/green-fixed-size-rect.svg: Copied from svg/as-image/resources/green-fixed-size-rect.svg.
  • svg/as-background-image/resources/green-relative-size-rect-with-viewBox.svg: Copied from svg/as-image/resources/green-relative-size-rect-with-viewBox.svg.
  • svg/as-background-image/resources/hearts.svg: Copied from fast/backgrounds/resources/hearts.svg.
  • svg/as-background-image/resources/linguistics.svg: Copied from fast/backgrounds/resources/linguistics.svg.
  • svg/as-background-image/resources/map.svg: Copied from fast/backgrounds/resources/map.svg.
  • svg/as-background-image/resources/mouse-repel.svg: Copied from fast/backgrounds/resources/mouse-repel.svg.
  • svg/as-background-image/resources/svg-as-background-with-relative-size.svg: Copied from svg/as-image/resources/svg-as-background-with-relative-size.svg.
  • svg/as-background-image/resources/width-100-percent.svg: Copied from svg/as-image/resources/width-100-percent.svg.
  • svg/as-background-image/svg-as-background-1.html: Copied from fast/backgrounds/svg-as-background-1.html.
  • svg/as-background-image/svg-as-background-2.html: Copied from fast/backgrounds/svg-as-background-2.html.
  • svg/as-background-image/svg-as-background-3.html: Copied from fast/backgrounds/svg-as-background-3.html.
  • svg/as-background-image/svg-as-background-4.html: Copied from fast/backgrounds/svg-as-background-4.html.
  • svg/as-background-image/svg-as-background-5.html: Copied from fast/backgrounds/svg-as-background-5.html.
  • svg/as-background-image/svg-as-background-6.html: Copied from fast/backgrounds/svg-as-background-6.html.
  • svg/as-background-image/svg-as-background-with-relative-size.html: Copied from svg/as-image/svg-as-background-with-relative-size.html.
  • svg/as-background-image/svg-as-background-with-viewBox.html: Copied from svg/as-image/svg-as-background-with-viewBox.html.
  • svg/as-background-image/svg-as-background.html: Copied from svg/as-image/svg-as-background.html.
  • svg/as-background-image/svg-as-tiled-background.html: Copied from svg/as-image/svg-as-tiled-background.html.
  • svg/as-background-image/svg-background-crash-on-refresh-expected.txt: Copied from svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-background-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html.
  • svg/as-background-image/svg-background-partial-redraw.html: Copied from svg/as-image/svg-background-partial-redraw.html.
  • svg/as-background-image/svg-width-100p-as-background.html: Copied from svg/as-image/svg-width-100p-as-background.html.
  • svg/as-border-image: Added.
  • svg/as-border-image/resources: Added.
  • svg/as-border-image/resources/large-tiles.png: Copied from fast/borders/resources/large-tiles.png.
  • svg/as-border-image/resources/tiles-fixed-size.svg: Copied from fast/borders/resources/tiles-fixed-size.svg.
  • svg/as-border-image/resources/tiles-relative-size.svg: Copied from fast/borders/resources/tiles-relative-size.svg.
  • svg/as-border-image/resources/tiles.png: Copied from fast/borders/resources/tiles.png.
  • svg/as-border-image/svg-as-border-image-2.html: Copied from fast/borders/svg-as-border-image-2.html.
  • svg/as-border-image/svg-as-border-image.html: Copied from fast/borders/svg-as-border-image.html.
  • svg/as-image/resources/butterfly.svg: Removed.
  • svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Removed.
  • svg/as-image/resources/svg-as-background-with-relative-size.svg: Removed.
  • svg/as-image/resources/width-100-percent.svg: Removed.
  • svg/as-image/svg-as-background-with-relative-size.html: Removed.
  • svg/as-image/svg-as-background-with-viewBox.html: Removed.
  • svg/as-image/svg-as-background.html: Removed.
  • svg/as-image/svg-as-tiled-background.html: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh.html: Removed.
  • svg/as-image/svg-background-partial-redraw.html: Removed.
  • svg/as-image/svg-width-100p-as-background.html: Removed.
01:15 Changeset [91632] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Update expectations for r91574.

  • platform/chromium-win/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.