Timeline


and

07/30/11:

23:47 Changeset [92075] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30

  • DEPS:
23:44 Changeset [92074] by dbates@webkit.org

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
(https://bugs.webkit.org/show_bug.cgi?id=64744)

23:36 Changeset [92073] by dbates@webkit.org

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.

23:29 Changeset [92072] by dbates@webkit.org

2011-07-30 Daniel Bates <dbates@webkit.com>

Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
(https://bugs.webkit.org/show_bug.cgi?id=65342)

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock() to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.
23:14 Changeset [92071] by fpizlo@apple.com

DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421

Reviewed by Oliver Hunt.

Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

22:56 Changeset [92070] by mitz@apple.com

Try to fix the Windows build after r92059.

  • win/WebKit2.def: Export symbols needed by Internals.
21:46 Changeset [92069] by abarth@webkit.org

Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068

  • bindings/scripts/test/JS/JSTestCallback.cpp:
19:23 Changeset [92068] by paroga@webkit.org

Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add missing and remove unneeded include statements for MainThread.

  • wtf/CryptographicallyRandomNumber.cpp:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/text/StringStatics.cpp:

Source/WebCore:

Add missing include statements for MainThread.

  • bindings/js/DOMWrapperWorld.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMWrapperWorld.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • dom/EventTarget.cpp:
  • fileapi/LocalFileSystem.cpp:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/DOMWindow.cpp:
  • page/History.cpp:
  • page/SecurityOrigin.cpp:
  • page/mac/EventHandlerMac.mm:
  • platform/MIMETypeRegistry.cpp:
  • platform/ThreadGlobalData.cpp:
  • platform/ThreadTimers.cpp:
  • platform/TreeShared.h:
  • platform/audio/HRTFDatabaseLoader.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/FontFallbackList.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/Image.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
  • platform/mac/LocalizedStringsMac.mm:
  • platform/mac/SharedBufferMac.mm:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/text/LocalizedNumberICU.cpp:
  • platform/text/TextEncodingRegistry.cpp:
  • platform/text/mac/LocalizedNumberMac.mm:
  • platform/win/LocalizedStringsWin.cpp:
  • storage/LocalStorageThread.cpp:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaSync.cpp:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageSyncManager.cpp:
  • webaudio/AsyncAudioDecoder.cpp:
  • webaudio/AudioBufferSourceNode.cpp:
  • webaudio/AudioContext.h
  • webaudio/AudioContext.cpp:
  • webaudio/AudioNode.cpp:
  • webaudio/ConvolverNode.cpp:
  • webaudio/OfflineAudioDestinationNode.cpp:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/WaveShaperNode.cpp:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • workers/WorkerMessagingProxy.cpp:

Source/WebKit/chromium:

Add missing include statements for MainThread.

  • src/WebKit.cpp:
  • src/WebViewImpl.cpp:
  • tests/CCThreadTest.cpp:

Source/WebKit/gtk:

Add missing include statements for MainThread.

  • webkit/webkitglobals.cpp:

Source/WebKit/mac:

Add missing include statements for MainThread.

  • Carbon/CarbonWindowAdapter.mm:
  • History/WebBackForwardList.mm:
  • History/WebHistoryItem.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebIconDatabase.mm:
  • Misc/WebLocalizableStrings.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebResource.mm:
  • WebView/WebTextIterator.mm:
  • WebView/WebView.mm:
  • WebView/WebViewData.mm:

Source/WebKit/qt:

Add missing include statements for MainThread.

  • Api/qwebpage.cpp:

Source/WebKit/win:

Add missing include statements for MainThread.

  • WebKitClassFactory.cpp:
  • WebView.cpp:

Source/WebKit/wx:

Add missing include statements for MainThread.

  • WebView.cpp:

Source/WebKit2:

Add missing include statements for MainThread.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:
  • PluginProcess/mac/PluginProcessMainMac.mm:
  • PluginProcess/qt/PluginProcessMainQt.cpp:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp:
  • UIProcess/WebContext.cpp:
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:
  • WebProcess/mac/KeychainItemShimMethods.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
  • WebProcess/qt/WebProcessMainQt.cpp:
  • WebProcess/win/WebProcessMainWin.cpp:
18:19 Changeset [92067] by paroga@webkit.org

Fix ports_unittest.py on native windows
https://bugs.webkit.org/show_bug.cgi?id=64959

Reviewed by Adam Barth.

Replace WebKitPort.script_path with WebKitPort.script_shell_command.
The latter includes the interpreter executable required on native windows.

  • Scripts/webkitpy/common/config/ports_unittest.py:
17:51 Changeset [92066] by abarth@webkit.org

Update baselines. This patch cleans up after http://trac.webkit.org/changeset/92042.

  • platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-moved-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium-win/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium/fast/repaint/absolute-position-changed-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-hide-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-show-expected.png: Removed.
17:46 Changeset [92065] by abarth@webkit.org

Update more baselines. This completes the cleanup after
http://trac.webkit.org/changeset/92047.

  • platform/chromium-win-xp/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
17:39 Changeset [92064] by abarth@webkit.org

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
17:33 Changeset [92063] by abarth@webkit.org

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
17:25 Changeset [92062] by abarth@webkit.org

Update baseline.

  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
17:05 Changeset [92061] by abarth@webkit.org

Properly escape regular expressions. (Maybe these shouldn't be regular
expressions?)

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:57 Changeset [92060] by abarth@webkit.org

Add support for Win7 to garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:51 Changeset [92059] by enrica@apple.com

REGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419
<rdar://problem/9408862>

Source/WebCore:

This patch fixes a regression introduced in r83075.
Make sure that culledInlineAbsoluteRects still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
This code path could not be tested via JavaScript. The patch
extends the Internals object to be able to test this case.

Reviewed by Dan Bernstein.

Test: fast/inline/skipped-whitespace-boundingBox.html

  • WebCore.exp.in: Added some exports.
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteRects):

  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Reviewed by Dan Bernstein.

  • fast/inline/skipped-whitespace-boundingBox-expected.txt: Added.
  • fast/inline/skipped-whitespace-boundingBox.html: Added.
16:10 Changeset [92058] by oliver@apple.com

Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417

Reviewed by Dan Bernstein.

Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):

11:27 Changeset [92057] by abarth@webkit.org

garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406

Reviewed by Dimitri Glazkov.

Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range. Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.

This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
11:26 Changeset [92056] by abarth@webkit.org

garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403

Reviewed by Dimitri Glazkov.

The refresh button should be faster and less disruptive than the browser's reload button.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
11:25 Changeset [92055] by abarth@webkit.org

garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=65231

Reviewed by Dimitri Glazkov.

The human readable name is easier to understand, especially when the patch is landed by the commit-queue.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
11:24 Changeset [92054] by abarth@webkit.org

garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227

Reviewed by Dimitri Glazkov.

This helps gardeners keep track of which problems have been solved.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
11:12 Changeset [92053] by abarth@webkit.org

Add missing files to the server.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:39 Changeset [92052] by kbalazs@webkit.org

[Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410

Reviewed by Noam Rosenthal.

  • Shared/ShareableBitmap.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::paintContent):

05:42 Changeset [92051] by podivilov@chromium.org

Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-file.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.SourceFile.prototype.rawLocationToUILocation):
(WebInspector.SourceFile.prototype.uiLocationToRawLocation):
(WebInspector.SourceFile.prototype._scriptForRawLocation):
(WebInspector.SourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):

LayoutTests:

  • inspector/debugger/source-file-expected.txt: Added.
  • inspector/debugger/source-file.html: Added.
04:43 Changeset [92050] by kbalazs@webkit.org

MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263

Reviewed by Dmitry Titov.

  • wtf/Deque.h:

(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.

  • wtf/MessageQueue.h:

(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.

00:16 Changeset [92049] by ossy@webkit.org

[Qt] Update platform specific expected files after r92047.

  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.txt:
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.txt:
  • platform/qt-4.8/svg/batik/text/textDecoration-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.txt:
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLength-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-mac/Skipped: Skip failing tests.

07/29/11:

23:48 Changeset [92048] by ossy@webkit.org

[Qt] Update platform specific expected files after r92047.

  • platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/qt/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt/svg/batik/text/smallFonts-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect2-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/batik/text/textFeatures-expected.txt:
  • platform/qt/svg/batik/text/textLayout2-expected.txt:
  • platform/qt/svg/batik/text/textLength-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textPosition-expected.txt:
  • platform/qt/svg/batik/text/textPosition2-expected.txt:
  • platform/qt/svg/batik/text/textProperties-expected.txt:
  • platform/qt/svg/batik/text/textProperties2-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/hixie/error/014-expected.txt:
  • platform/qt/svg/hixie/use/002-expected.txt:
  • svg/custom/external-paintserver-reference-expected.png:
  • svg/custom/external-paintserver-reference-expected.txt:
  • svg/custom/linking-base-external-reference-expected.png:
  • svg/custom/linking-base-external-reference-expected.txt:
20:22 Changeset [92047] by rwlbuis@webkit.org

2011-07-29 Rob Buis <rbuis@rim.com>

URL references are completely broken in SVG
https://bugs.webkit.org/show_bug.cgi?id=63283

Reviewed by Nikolas Zimmermann.

Change SVGURIElement::getTarget to be more strict about iri resolving and make it serve as a central
place to resolve a iri to a SVGElement. The iri can be same-document or external, for now we only handle
the former, the latter will be handled in bug 65344.
Accept as same-document if the iri combined with the base uri equals the document url (ignoring
the fragment identifier). For convenience a method is added to lookup the element, if found.

Tests: svg/custom/external-paintserver-reference.svg

svg/custom/linking-base-external-reference.xhtml
svg/custom/uri-reference-handling.svg

  • css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontSelector.h: (WebCore::CSSFontSelector::document):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • rendering/svg/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::paintingResourceFromSVGPaint):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
  • svg/SVGGlyphRefElement.cpp: (WebCore::SVGGlyphRefElement::hasValidGlyphElement):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::matchesTargetURI):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::buildPendingResource):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::fragmentIdentifierFromIRIString): (WebCore::SVGURIReference::targetElementFromIRIString):
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
19:49 Changeset [92046] by fpizlo@apple.com

JSC GC zombie support no longer works, and is likely no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=65404

Reviewed by Darin Adler.

This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.

(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::isValidWeakNode):

  • heap/Heap.cpp:

(JSC::Heap::destroy):
(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::clearMarks):

  • interpreter/Register.h:

(JSC::Register::Register):
(JSC::Register::operator=):

  • runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):

  • runtime/JSCell.cpp:

(JSC::isZombie):

  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):

  • runtime/JSGlobalData.h:
  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::JSValue):

  • runtime/JSZombie.cpp: Removed.
  • runtime/JSZombie.h: Removed.
  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):

  • wtf/Platform.h:
19:26 Changeset [92045] by zmo@google.com

Unreviewed, rebaseline, gardener stuff.

  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
19:17 Changeset [92044] by abarth@webkit.org

Actually import the logging module!

  • Scripts/webkitpy/common/checkout/scm/git.py:
19:14 Changeset [92043] by abarth@webkit.org

More debug logging. Maybe we're running the git version of this
function somehow? (That would explain why it doesn't work!)

  • Scripts/webkitpy/common/checkout/scm/git.py:
19:12 Changeset [92042] by jchaffraix@webkit.org

Add more testing to RenderLayer [ct'd]
https://bugs.webkit.org/show_bug.cgi?id=65059

Reviewed by James Robinson.

This change adds testing with <iframe>, position: absolute elements and scrolling.

  • fast/repaint/absolute-position-change-containing-block.html: Added.
  • fast/repaint/absolute-position-changed.html: Added.
  • fast/repaint/absolute-position-moved.html: Added.
  • fast/repaint/fixed-and-absolute-position-scrolled.html: Added.
  • fast/repaint/fixed-position-transparency-with-overflow.html: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child.html: Added.
  • fast/repaint/nested-iframe-scroll-inner.html: Added.
  • fast/repaint/nested-iframe-scroll-outer.html: Added.
  • fast/repaint/overflow-hide.html: Added.
  • fast/repaint/overflow-show.html: Added.

New test cases.

  • fast/repaint/resources/iframe-inner.html: Added.
  • fast/repaint/resources/iframe-outer.html: Added.
  • fast/repaint/resources/default.css:

Added more shared code here.

  • fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • fast/repaint/absolute-position-change-containing-block-expected.txt: Added.
  • fast/repaint/absolute-position-changed-expected.txt: Added.
  • fast/repaint/absolute-position-moved-expected.png: Added.
  • fast/repaint/absolute-position-moved-expected.txt: Added.
  • fast/repaint/fixed-and-absolute-position-scrolled-expected.txt: Added.
  • fast/repaint/fixed-position-transparency-with-overflow-expected.txt: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt: Added.
  • fast/repaint/nested-iframe-scroll-inner-expected.txt: Added.
  • fast/repaint/nested-iframe-scroll-outer-expected.txt: Added.
  • fast/repaint/overflow-hide-expected.txt: Added.
  • fast/repaint/overflow-show-expected.txt: Added.
  • platform/chromium/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-show-expected.png: Added.
  • platform/mac/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/mac/fast/repaint/overflow-hide-expected.png: Added.
  • platform/mac/fast/repaint/overflow-show-expected.png: Added.

Those 2 results are strange and a bug will be opened about them.

19:11 Changeset [92041] by simonjam@chromium.org

Remove zipcar.com site specific hack added in r87361
https://bugs.webkit.org/show_bug.cgi?id=65405

Reviewed by Adam Barth.

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedIntoDocument):

19:06 Changeset [92040] by fpizlo@apple.com

LayoutTests does not have a test for array speculation pathologies in the JavaScriptCore DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=65397

Reviewed by Darin Adler.

This test reproduces the crash seen in https://bugs.webkit.org/show_bug.cgi?id=65327, and is
designed to guard itself against possible variants of array speculation failure. It will
test both the case where a speculate-array value is actually a non-array object, and the
case where it is a number. Particular care is taken to increase the likelihood that the
test remains relevant if the JIT performs speculation based on actual argument types and
values at the time of compilation.

  • fast/js/array-type-speculation-expected.txt: Added.
  • fast/js/array-type-speculation.html: Added.
  • fast/js/script-tests/array-type-speculation.js: Added.
19:00 Changeset [92039] by commit-queue@webkit.org

[EFL] Implement EditorClientEfl::respondToChangedContents
http://bugs.webkit.org/show_bug.cgi?id=64259

Implements respondToChangedContents by calling callback both from
ewk_frame and ewk_view with frame and view objects respectively.

Patch by Michal Pakula vel Rutka <m.pakula@samsung.com> on 2011-07-29
Reviewed by Antonio Gomes.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedContents):

  • ewk/ewk_frame.cpp:

(ewk_frame_editor_client_contents_changed):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_editor_client_contents_changed):

  • ewk/ewk_view.h:
19:00 Changeset [92038] by fpizlo@apple.com

DFG JIT verbose mode provides no details about predictions
https://bugs.webkit.org/show_bug.cgi?id=65389

Reviewed by Darin Adler.

Added a print-out of the predictions to the IR dump, with names as follows:
"p-bottom" = the parser made no predictions
"p-int32" = the parser predicted int32
... (same for array, cell, double, number)
"p-top" = the parser made conflicting predictions which will be ignored.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::predictionToString):

18:26 Changeset [92037] by jamesr@google.com

[chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
https://bugs.webkit.org/show_bug.cgi?id=65354

Reviewed by Kenneth Russell.

This moves a few function definitions in LayerRendererChromium around to make the patch on bug 58840 easier to
review. In that patch, updatePropertiesAndRenderSurfaces() becomes a templated free function instead of a
member function, so it has to be near the top of the .cpp.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateLayers):

17:53 Changeset [92036] by abarth@webkit.org

Add some temporary debug logging messages to try to understand why the
windows bots can't figure out their current SVN revision.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
17:51 Changeset [92035] by jeffm@apple.com

Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>

Prepare WebCore.vcproj to support AVCF media back end on Windows.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

  • WebCore.vcproj/WebCore.vcproj: Added MediaPlayerPrivateAVFoundation and MediaPlayerPrivateAVFoundationCF sources.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added additional include directories and dleay load DLLs for AVCF.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added, just a stub for now.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added, just a stub for now.
17:47 Changeset [92034] by jeffm@apple.com

Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>

Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
it references mutable so other const member functions can call it.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
17:09 Changeset [92033] by zmo@google.com

Unreviewed, test expectations update, gardener stuff.

  • platform/chromium/test_expectations.txt:
16:27 Changeset [92032] by zmo@google.com

Unreviewed, rolling out r92011.
http://trac.webkit.org/changeset/92011
https://bugs.webkit.org/show_bug.cgi?id=65044

break chromium win build

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • platform/PlatformGestureEvent.h:
  • platform/PlatformGestureRecognizer.h:
  • platform/ScrollAnimatorWin.cpp:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:
16:13 Changeset [92031] by lforschler@apple.com

Versioning.

16:11 Changeset [92030] by enne@google.com

[chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394

Reviewed by James Robinson.

The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path. Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

16:11 Changeset [92029] by lforschler@apple.com

New tag.

16:03 Changeset [92028] by cevans@google.com

Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7537012

16:00 Changeset [92027] by cevans@google.com

Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7540005

16:00 Changeset [92026] by abarth@webkit.org

Chromium try servers should use downstream test_expectations
https://bugs.webkit.org/show_bug.cgi?id=65390

Reviewed by Dirk Pranke.

Otherwise the try servers will report bogus failures.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:48 Changeset [92025] by eae@chromium.org

-webkit-marquee with anonymous node causes segmentation fault in Node::document
https://bugs.webkit.org/show_bug.cgi?id=64693

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/webkit-marquee-anonymous-node-crash.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
Add null check as renderer()->node() is null for anonymous nodes.

LayoutTests:

  • fast/css/webkit-marquee-anonymous-node-crash-expected.txt: Added.
  • fast/css/webkit-marquee-anonymous-node-crash.html: Added.

Add test for using -webkit-marquee with an anonymous node.

15:40 Changeset [92024] by fpizlo@apple.com

DFG JIT does not have any way of undoing double speculation.
https://bugs.webkit.org/show_bug.cgi?id=65334

Reviewed by Gavin Barraclough.

This adds code to do a branchConvertDoubleToInt on specualtion failure.
This is performance-neutral on most benchmarks but does result in
a slight improvement in Kraken.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

15:38 Changeset [92023] by lforschler@apple.com

Merge r91964.

15:17 Changeset [92022] by reed@google.com

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:16 Changeset [92021] by cevans@google.com

Merge 91721
BUG=88944
Review URL: http://codereview.chromium.org/7457026

15:16 Changeset [92020] by lforschler@apple.com

Merge r91271.

15:14 Changeset [92019] by lforschler@apple.com

Merge r91266.

15:13 Changeset [92018] by lforschler@apple.com

Merge r91222.

15:08 Changeset [92017] by lforschler@apple.com

Merge r91219.

14:58 Changeset [92016] by lforschler@apple.com

Merge r91085.

14:57 Changeset [92015] by lforschler@apple.com

Merge r90855.

14:54 Changeset [92014] by weinig@apple.com

Move Region code from WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=65392

Reviewed by David Hyatt.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update project files.

  • WebCore.exp.in:

Update exports.

  • platform/graphics/Region.cpp: Copied from Source/WebKit2/Platform/Region.cpp.
  • platform/graphics/Region.h: Copied from Source/WebKit2/Platform/Region.h.

Add files.

Source/WebKit2:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update project files.

  • Platform/Region.cpp: Removed.
  • Platform/Region.h: Removed.

Remove Region files.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDraw):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:
  • UIProcess/win/WebView.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Update for new namespace and include type.

14:48 Changeset [92013] by lforschler@apple.com

Merge r90295.

14:44 Changeset [92012] by lforschler@apple.com

Merge r90293.

14:41 Changeset [92011] by commit-queue@webkit.org

[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:

Added symbolic contstant for tick multiplier.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::handleGestureEvent):
Added missing method needed to fix the build on windows.

  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
14:34 Changeset [92010] by fpizlo@apple.com

Crash when opening docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=65327

Reviewed by Gavin Barraclough.

The speculative JIT was only checking whether a value is an array when
we had already checked that it was, rather then when we hadn't.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:29 Changeset [92009] by eric.carlson@apple.com

2011-07-29 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Joseph Pecoraro.

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Don't ask a load delegate if it is OK to

load an empty poster url.

14:17 Changeset [92008] by jeffm@apple.com

Re-sort one more file in the WebCore project with Visual Studio.

  • WebCore.vcproj/WebCore.vcproj:
14:14 Changeset [92007] by jeffm@apple.com

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
14:04 Changeset [92006] by dglazkov@chromium.org

Fix an error in macro collapsing, refactor code to be pretty.
https://bugs.webkit.org/show_bug.cgi?id=65387

My set math was wrong.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
13:20 Changeset [92005] by mitz@apple.com

Source/WebCore: Added the regional indicator symbols to the set of codepoints that force use of the complex text code path.

Fixes <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380

Reviewed by Anders Carlsson.

Test: fast/text/regional-indicator-symobls.html

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): Added handling of surrogate pairs, which returns Complex for characters in
the range U+1F1E6..U+1F1FF.

LayoutTests: Test for <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380

Reviewed by Anders Carlsson.

  • fast/text/regional-indicator-symobls-expected.txt: Added.
  • fast/text/regional-indicator-symobls.html: Added.
13:19 Changeset [92004] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65342

Add support for positioned floats being placed into a RenderBlock's FloatingObject list and for
correct propagation of those floating objects into descendants.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
The positioned float layout algorithm is 2-pass. You lay out without the positioned objects, and then
once they have been placed, you lay out again and use that placement to determine the float positions.
layoutBlock now has an extra parameter to indicate which layout pass you are in.

(WebCore::RenderBlock::addOverflowFromFloats):
Don't add overflow from positioned floats ever, since the positioning overflow function takes care of that
already.

(WebCore::RenderBlock::layoutBlockChild):
Include positioned floats in the lowestFloatLogicalBottom we look at so that overhang is computed properly.

(WebCore::RenderBlock::simplifiedLayout):
If layoutPositionedObjects indicates that a positioned float moved, then we can't do simplified layout. Bail
instead and do a full layout.

(WebCore::RenderBlock::positionedFloatsNeedRelayout):
Helper for layoutBlock in order to bypass the 2-pass model if we can detect that none of the positioned objects
will actually need to lay out again. This allows incremental layout to not always fault back to 2-pass as normal
flow content streams in.

(WebCore::RenderBlock::layoutPositionedObjects):
Modified to return a boolean indicating whether a positioned float got a layout. If so, we will lay out again
once our positioned objects are placed.

(WebCore::RenderBlock::insertFloatingObject):
insertFloatingObject can now handle positioned objects being inserted.

(WebCore::RenderBlock::positionNewFloats):
positionNewFloats doesn't attempt to position this new type of float. It only handles left/right floats.

(WebCore::RenderBlock::addPositionedFloats):
Helper to add in the floating objects for positioned floats. This is used instead of positionNewFloats and
just walks the positioned objects instead.

(WebCore::RenderBlock::clearFloats):
clearFloats now handles adding in positioned floats if the layout pass says they should be included.

(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
New helpers used by addPositionedFloats.

(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
Make sure the object count tracking handles positioned floats as well as left/right floats.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalLeftForChild):
New helper used by addPositionedFloats.

(WebCore::RenderBlock::FloatingObject::FloatingObject):
Change the constructor to take the RenderStyle enum. This makes the construction simpler.

(WebCore::RenderBlock::hasPositionedFloats):
A bit tracks whether or not a block has positioned floats in its positioned objects list.

(WebCore::RenderBlock::hasOverhangingFloats):
Modified to include positioned floats.

(WebCore::RenderBlock::lowestFloatLogicalBottom):
This function excludes positioned floats by default, so that places that - for example - expand to
encompass their lowestFloatLogicalBottom won't accidentally expand to encompass positioned objects.

(WebCore::RenderBlock::lowestFloatLogicalBottomIncludingPositionedFloats):
A new function that includes positioned floats for callers that care.

(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::hasPositionedObjects):
The object count tracking for positioned floats within a block's FloatingObjects list.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):
Make sure isFloating is set even if isPositioned is also set for the positioned float case.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Modified to do the extra layout pass if needed.

12:56 Changeset [92003] by levin@chromium.org

Tests for validating a new WebVTT parser for <track>
https://bugs.webkit.org/show_bug.cgi?id=64921

Patch by Anna Cavender <annacc@chromium.org> on 2011-07-29
Reviewed by Eric Carlson.

  • media/track/captions/tc000_empty.vtt: Added.
  • media/track/captions/tc001_iso2022jp3.vtt: Added.
  • media/track/captions/tc001_utf8.vtt: Added.
  • media/track/captions/tc002_bom.vtt: Added.
  • media/track/captions/tc003_newlines.vtt: Added.
  • media/track/captions/tc003_nonewlineateof.vtt: Added.
  • media/track/captions/tc004_nowebvtt.vtt: Added.
  • media/track/captions/tc004_webvttfile.vtt: Added.
  • media/track/captions/tc004_webvttrubbish.vtt: Added.
  • media/track/captions/tc005_defaultstyles.vtt: Added.
  • media/track/captions/tc005_metadataarea.vtt: Added.
  • media/track/captions/tc006_cueid.vtt: Added.
  • media/track/captions/tc006_cueiderror.vtt: Added.
  • media/track/captions/tc007_cuenoid.vtt: Added.
  • media/track/captions/tc007_cuenoiderror.vtt: Added.
  • media/track/captions/tc008_timingsnohour.vtt: Added.
  • media/track/captions/tc008_timingsnohourerrors.vtt: Added.
  • media/track/captions/tc009_timingshour.vtt: Added.
  • media/track/captions/tc009_timingshourerror.vtt: Added.
  • media/track/captions/tc010_notimings.vtt: Added.
  • media/track/captions/tc011_cues.vtt: Added.
  • media/track/captions/tc011_cuesnosep.vtt: Added.
  • media/track/captions/tc012_outoforder.vtt: Added.
  • media/track/captions/tc013_settings.vtt: Added.
  • media/track/captions/tc013_settingsbadsep.vtt: Added.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magicheader-expected.txt: Added.
  • media/track/track-webvtt-tc004-magicheader.html: Added.
  • media/track/track-webvtt-tc005-headercomment-expected.txt: Added.
  • media/track/track-webvtt-tc005-headercomment.html: Added.
  • media/track/track-webvtt-tc006-cueidentifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cueidentifiers.html: Added.
  • media/track/track-webvtt-tc007-cuenoid-expected.txt: Added.
  • media/track/track-webvtt-tc007-cuenoid.html: Added.
  • media/track/track-webvtt-tc008-timingsnohours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timingsnohours.html: Added.
  • media/track/track-webvtt-tc009-timingshour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timingshour.html: Added.
  • media/track/track-webvtt-tc010-notimings-expected.txt: Added.
  • media/track/track-webvtt-tc010-notimings.html: Added.
  • media/track/track-webvtt-tc011-blanklines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blanklines.html: Added.
  • media/track/track-webvtt-tc012-outoforder-expected.txt: Added.
  • media/track/track-webvtt-tc012-outoforder.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/wk2/Skipped:
12:11 Changeset [92002] by commit-queue@webkit.org

Scroll animation refinements.
https://bugs.webkit.org/show_bug.cgi?id=65154

Patch by Scott Byer <scottbyer@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.

Source/WebCore:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):

10:47 Changeset [92001] by tony@chromium.org

rename css3/flexbox/display-property.html to css3/flexbox/css-properties.html
https://bugs.webkit.org/show_bug.cgi?id=65343

Reviewed by Mihai Parparita.

I plan on adding more tests for the other flexbox properties
(flex-order, flex-direction, flex-pack, flex-align) to this file.

  • css3/flexbox/css-properties-expected.txt: Copied from LayoutTests/css3/flexbox/display-property-expected.txt.
  • css3/flexbox/css-properties.html: Copied from LayoutTests/css3/flexbox/display-property.html.
  • css3/flexbox/display-property-expected.txt: Removed.
  • css3/flexbox/display-property.html: Removed.
  • css3/flexbox/script-tests/css-properties.js: Copied from LayoutTests/css3/flexbox/script-tests/display-property.js.
  • css3/flexbox/script-tests/display-property.js: Removed.
10:37 Changeset [92000] by commit-queue@webkit.org

Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

To support searching the AccessibilityObject cache, we first need to
implement a minimal set of functions that will allow AccessibilityObjects
to be identified when searching using common search criteria. The additional
functions below complement the existing identification functionality already
available and together provide a basic working set to build search on top of.
Additionally, the blockquoteLevel function has been moved into the AccessibilityObject
class to make it available to all platforms.

Patch by Samuel White <samuel_white@apple.com> on 2011-07-29
Reviewed by Chris Fleizach.

New tests will be included in the following patch that will also implement
basic search functionality.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isBlockquote):
(WebCore::AccessibilityObject::isLandmark):
(WebCore::AccessibilityObject::hasMisspelling):
(WebCore::AccessibilityObject::blockquoteLevel):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isUnvisited):
(WebCore::AccessibilityObject::hasBoldFont):
(WebCore::AccessibilityObject::hasItalicFont):
(WebCore::AccessibilityObject::hasPlainText):
(WebCore::AccessibilityObject::hasSameFont):
(WebCore::AccessibilityObject::hasSameFontColor):
(WebCore::AccessibilityObject::hasSameStyle):
(WebCore::AccessibilityObject::hasStaticText):
(WebCore::AccessibilityObject::hasUnderline):
(WebCore::AccessibilityObject::tableLevel):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isUnvisited):
(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasSameFont):
(WebCore::AccessibilityRenderObject::hasSameFontColor):
(WebCore::AccessibilityRenderObject::hasSameStyle):
(WebCore::AccessibilityRenderObject::hasUnderline):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableLevel):

  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetBlockquoteLevel):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

10:23 Changeset [91999] by commit-queue@webkit.org

Avoid calling animation timer updates while the page is loading
https://bugs.webkit.org/show_bug.cgi?id=64851

Patch by Zeng Huiqing <huiqing.zeng@intel.com> on 2011-07-29
Reviewed by Simon Fraser.

There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

10:18 Changeset [91998] by andersca@apple.com

Pass the HTTP referrer header for URLs loaded by plug-ins
https://bugs.webkit.org/show_bug.cgi?id=65379
<rdar://problem/9822116>

Reviewed by Sam Weinig.

../WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

../WebKit2:

Set the HTTP referrer if necessary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

09:10 Changeset [91997] by ossy@webkit.org

[Qt] Unreviewed typo fix.

  • platform/qt/Skipped:
08:59 Changeset [91996] by senorblanco@chromium.org

[Chromium] Marking some media tests as passing and removing from
expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:39 Changeset [91995] by ossy@webkit.org

[Qt] Unreviewed gardening after r91986

  • platform/qt-arm/Skipped: Skip failing tests.
08:28 Changeset [91994] by jocelyn.turcotte@nokia.com

Fix the QTouchWebView in debug segfault on shutdown introduced in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

unregisterTile is called in the tile's destructor, triggered in the TileSet's
destruction, which happens in the middle of the proxy's destruction
(after the m_tilesByID HashMap destruction).
Detach the tiles in the proxy's destructor to make sure they can cleanup
using a valid proxy.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):

06:47 Changeset [91993] by ossy@webkit.org

[Qt] Unreviewed gardening after r91986

  • platform/qt-mac/Skipped: Skip one more failing test.
06:42 Changeset [91992] by ossy@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Add 4 new failing tests.
06:38 Changeset [91991] by ossy@webkit.org

[Qt][ARM]REGRESSION(r91752): It made audio related tests fail
https://bugs.webkit.org/show_bug.cgi?id=65369

  • platform/qt-arm/Skipped: Skip failing tests.
06:36 Changeset [91990] by jocelyn.turcotte@nokia.com

Fix the QTouchWebView in debug broke in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

registerTile is called in the Tile's constructor, before adoptRef.
Change the pointer parameter to use the raw type instead.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::registerTile):

  • UIProcess/TiledDrawingAreaProxy.h:
05:49 Changeset [91989] by ossy@webkit.org

[Qt] Unreviewed gardening after r91986

  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textDecoration2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textLength-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textLength-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPCDATA-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPosition-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textProperties-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textProperties-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/button-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/button-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/colourpicker-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/combobox-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/combobox-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/scrollbar-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/selectionlist-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/slider-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/slider-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/textbox-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/textbox-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/window-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/window-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
05:49 Changeset [91988] by leandrogracia@chromium.org

Fix speech input icon rect on RTL directions.
https://bugs.webkit.org/show_bug.cgi?id=65333

Reviewed by Tony Gentilcore.

No new tests. This is used by platforms, not WebCore, and
the base functionality is not changed but only the failing cases.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

05:32 Changeset [91987] by ossy@webkit.org

[Qt] Unreviewed gardening after r91984

  • platform/qt-4.8/fast/block/positioning/047-expected.png: Added.
  • platform/qt-4.8/fast/block/positioning/047-expected.txt: Added.
  • platform/qt-4.8/fast/block/positioning/051-expected.png: Added.
  • platform/qt-4.8/fast/block/positioning/051-expected.txt: Added.
  • platform/qt-4.8/fast/invalid/019-expected.png: Added.
  • platform/qt-4.8/fast/invalid/019-expected.txt: Added.
  • platform/qt-4.8/fast/lists/003-expected.png: Added.
  • platform/qt-4.8/fast/lists/003-expected.txt: Added.
  • platform/qt-4.8/fast/text/basic/generic-family-reset-expected.png: Added.
  • platform/qt-4.8/fast/text/basic/generic-family-reset-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
05:14 Changeset [91986] by ossy@webkit.org

[Qt] Add platform specific expected results

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/qt/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/qt/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/qt/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/qt/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/qt/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt/svg/batik/text/smallFonts-expected.png: Added.
  • platform/qt/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor2-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor3-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/qt/svg/batik/text/textDecoration2-expected.png: Added.
  • platform/qt/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect2-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect3-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/qt/svg/batik/text/textFeatures-expected.png: Added.
  • platform/qt/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/qt/svg/batik/text/textLayout2-expected.png: Added.
  • platform/qt/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/qt/svg/batik/text/textLength-expected.png: Added.
  • platform/qt/svg/batik/text/textLength-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/qt/svg/batik/text/textPCDATA-expected.png: Added.
  • platform/qt/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/qt/svg/batik/text/textPosition-expected.png: Added.
  • platform/qt/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt/svg/batik/text/textPosition2-expected.png: Added.
  • platform/qt/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt/svg/batik/text/textProperties-expected.png: Added.
  • platform/qt/svg/batik/text/textProperties-expected.txt: Added.
  • platform/qt/svg/batik/text/textProperties2-expected.png: Added.
  • platform/qt/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/qt/svg/carto.net/button-expected.png: Added.
  • platform/qt/svg/carto.net/button-expected.txt: Added.
  • platform/qt/svg/carto.net/colourpicker-expected.png: Added.
  • platform/qt/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/qt/svg/carto.net/combobox-expected.png: Added.
  • platform/qt/svg/carto.net/combobox-expected.txt: Added.
  • platform/qt/svg/carto.net/scrollbar-expected.png: Added.
  • platform/qt/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/qt/svg/carto.net/selectionlist-expected.png: Added.
  • platform/qt/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/qt/svg/carto.net/slider-expected.png: Added.
  • platform/qt/svg/carto.net/slider-expected.txt: Added.
  • platform/qt/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/qt/svg/carto.net/textbox-expected.png: Added.
  • platform/qt/svg/carto.net/textbox-expected.txt: Added.
  • platform/qt/svg/carto.net/window-expected.png: Added.
  • platform/qt/svg/carto.net/window-expected.txt: Added.
  • platform/qt/svg/css/css-box-min-width-expected.png: Added.
  • platform/qt/svg/css/css-box-min-width-expected.txt: Added.
  • platform/qt/svg/css/getComputedStyle-basic-expected.png: Added.
  • platform/qt/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/qt/svg/custom/foreign-object-skew-expected.txt: Added.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.png: Added.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • platform/qt/svg/custom/group-opacity-expected.png: Added.
  • platform/qt/svg/custom/group-opacity-expected.txt: Added.
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.png: Added.
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.txt: Added.
  • platform/qt/svg/custom/percentage-rect-expected.png: Added.
  • platform/qt/svg/custom/percentage-rect-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-image-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-image-expected.txt: Added.
  • platform/qt/svg/custom/text-linking-expected.png: Added.
  • platform/qt/svg/custom/text-linking-expected.txt: Added.
  • platform/qt/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
  • platform/qt/svg/hixie/cascade/001-broken-expected.png: Added.
  • platform/qt/svg/hixie/cascade/001-broken-expected.txt: Added.
  • platform/qt/svg/hixie/data-types/001-expected.png: Added.
  • platform/qt/svg/hixie/data-types/001-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/002-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/002-expected.txt:
  • platform/qt/svg/hixie/dynamic/003-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/003-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/004-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/004-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/005-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/005-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/006-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/006-expected.txt: Added.
  • platform/qt/svg/hixie/error/001-expected.png: Added.
  • platform/qt/svg/hixie/error/001-expected.txt: Added.
  • platform/qt/svg/hixie/error/002-expected.png: Added.
  • platform/qt/svg/hixie/error/002-expected.txt: Added.
  • platform/qt/svg/hixie/error/003-expected.png: Added.
  • platform/qt/svg/hixie/error/003-expected.txt: Added.
  • platform/qt/svg/hixie/error/007-expected.png: Added.
  • platform/qt/svg/hixie/error/007-expected.txt: Added.
  • platform/qt/svg/hixie/error/008-expected.png: Added.
  • platform/qt/svg/hixie/error/008-expected.txt: Added.
  • platform/qt/svg/hixie/error/009-expected.png: Added.
  • platform/qt/svg/hixie/error/009-expected.txt: Added.
  • platform/qt/svg/hixie/error/010-expected.png: Added.
  • platform/qt/svg/hixie/error/010-expected.txt: Added.
  • platform/qt/svg/hixie/error/011-expected.png: Added.
  • platform/qt/svg/hixie/error/011-expected.txt: Added.
  • platform/qt/svg/hixie/error/013-expected.png: Added.
  • platform/qt/svg/hixie/error/013-expected.txt: Added.
  • platform/qt/svg/hixie/error/014-expected.png: Added.
  • platform/qt/svg/hixie/error/014-expected.txt: Added.
  • platform/qt/svg/hixie/error/014-test-expected.png: Added.
  • platform/qt/svg/hixie/error/014-test-expected.txt: Added.
  • platform/qt/svg/hixie/error/015-expected.png: Added.
  • platform/qt/svg/hixie/error/015-expected.txt: Added.
  • platform/qt/svg/hixie/error/016-expected.png: Added.
  • platform/qt/svg/hixie/error/016-expected.txt: Added.
  • platform/qt/svg/hixie/error/017-expected.png: Added.
  • platform/qt/svg/hixie/error/017-expected.txt: Added.
  • platform/qt/svg/hixie/links/001-expected.png: Added.
  • platform/qt/svg/hixie/links/001-expected.txt: Added.
  • platform/qt/svg/hixie/links/002-expected.png: Added.
  • platform/qt/svg/hixie/links/002-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/003-expected.png: Added.
  • platform/qt/svg/hixie/mixed/003-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/004-expected.png: Added.
  • platform/qt/svg/hixie/mixed/004-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/005-expected.png: Added.
  • platform/qt/svg/hixie/mixed/005-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/006-expected.png: Added.
  • platform/qt/svg/hixie/mixed/006-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/007-expected.png: Added.
  • platform/qt/svg/hixie/mixed/007-expected.txt:
  • platform/qt/svg/hixie/mixed/008-expected.png: Added.
  • platform/qt/svg/hixie/mixed/008-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/009-expected.png: Added.
  • platform/qt/svg/hixie/mixed/009-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/010-expected.png: Added.
  • platform/qt/svg/hixie/mixed/010-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/011-expected.png: Added.
  • platform/qt/svg/hixie/mixed/011-expected.txt: Added.
  • platform/qt/svg/hixie/painting/001-expected.png: Added.
  • platform/qt/svg/hixie/painting/001-expected.txt: Added.
  • platform/qt/svg/hixie/perf/001-expected.png: Added.
  • platform/qt/svg/hixie/perf/001-expected.txt: Added.
  • platform/qt/svg/hixie/perf/002-expected.png: Added.
  • platform/qt/svg/hixie/perf/002-expected.txt: Added.
  • platform/qt/svg/hixie/perf/003-expected.png: Added.
  • platform/qt/svg/hixie/perf/003-expected.txt: Added.
  • platform/qt/svg/hixie/perf/004-expected.png: Added.
  • platform/qt/svg/hixie/perf/004-expected.txt: Added.
  • platform/qt/svg/hixie/perf/005-expected.png: Added.
  • platform/qt/svg/hixie/perf/005-expected.txt: Added.
  • platform/qt/svg/hixie/perf/006-expected.png: Added.
  • platform/qt/svg/hixie/perf/006-expected.txt: Added.
  • platform/qt/svg/hixie/perf/007-expected.png: Added.
  • platform/qt/svg/hixie/perf/007-expected.txt: Added.
  • platform/qt/svg/hixie/processing-model/003-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/003-expected.txt:
  • platform/qt/svg/hixie/processing-model/004-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/004-expected.txt:
  • platform/qt/svg/hixie/processing-model/005-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/005-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/001-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/001-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/002-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/002-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/003-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/003-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/003a-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/003a-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/004-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/004-expected.txt: Added.
  • platform/qt/svg/hixie/shapes/path/001-expected.png: Added.
  • platform/qt/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/qt/svg/hixie/text/002-expected.png: Added.
  • platform/qt/svg/hixie/text/002-expected.txt: Added.
  • platform/qt/svg/hixie/text/003-expected.png: Added.
  • platform/qt/svg/hixie/text/003-expected.txt: Added.
  • platform/qt/svg/hixie/text/003a-expected.png: Added.
  • platform/qt/svg/hixie/text/003a-expected.txt: Added.
  • platform/qt/svg/hixie/text/003b-expected.png: Added.
  • platform/qt/svg/hixie/text/003b-expected.txt: Added.
  • platform/qt/svg/hixie/transform/001-expected.png: Added.
  • platform/qt/svg/hixie/transform/001-expected.txt: Added.
  • platform/qt/svg/hixie/use/001-expected.png: Added.
  • platform/qt/svg/hixie/use/001-expected.txt: Added.
  • platform/qt/svg/hixie/use/002-expected.png: Added.
  • platform/qt/svg/hixie/use/002-expected.txt: Added.
  • platform/qt/svg/hixie/use/002-test-expected.png: Added.
  • platform/qt/svg/hixie/use/002-test-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/001-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/001-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/002-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/003-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/004-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/004-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
04:55 Changeset [91985] by alexis.menard@openbossa.org

[Qt] Make QDesktopWebView/QTouchWebView loadProgress property more usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65315

Reviewed by Benjamin Poulain.

In order to use the loadProgress value in QML we need to make it
a Q_PROPERTY, therefore we need a getter to get it.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebView::url):
(QDesktopWebView::loadProgress):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::loadProgress):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::stop):
(tst_CommonViewTests::loadProgress):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::desktopViewLoadFailed):
(WebViewAbstraction::touchViewLoadProgressChanged):
(WebViewAbstraction::desktopViewLoadProgressChanged):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeLoadProgress):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::loadProgress):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didChangeLoadProgress):

04:30 Changeset [91984] by ossy@webkit.org

[Qt] Update platform specific expected results

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.png: Added.
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/qt/fast/block/basic/010-expected.png: Added.
  • platform/qt/fast/block/basic/010-expected.txt:
  • platform/qt/fast/block/float/004-expected.png: Added.
  • platform/qt/fast/block/float/004-expected.txt:
  • platform/qt/fast/block/float/010-expected.png: Added.
  • platform/qt/fast/block/float/010-expected.txt:
  • platform/qt/fast/block/float/017-expected.png: Added.
  • platform/qt/fast/block/float/017-expected.txt:
  • platform/qt/fast/block/float/021-expected.png: Added.
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/032-expected.png: Added.
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-expected.png: Added.
  • platform/qt/fast/block/float/br-with-clear-expected.txt: Added.
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png: Added.
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/block/margin-collapse/006-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/055-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/055-expected.txt:
  • platform/qt/fast/block/positioning/047-expected.png: Added.
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/051-expected.png: Added.
  • platform/qt/fast/block/positioning/051-expected.txt:
  • platform/qt/fast/block/positioning/056-expected.png: Added.
  • platform/qt/fast/block/positioning/056-expected.txt:
  • platform/qt/fast/block/positioning/061-expected.png: Added.
  • platform/qt/fast/block/positioning/061-expected.txt:
  • platform/qt/fast/block/positioning/move-with-auto-width-expected.png: Added.
  • platform/qt/fast/block/positioning/move-with-auto-width-expected.txt: Added.
  • platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • platform/qt/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/qt/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/qt/fast/dynamic/containing-block-change-expected.txt:
  • platform/qt/fast/dynamic/floating-to-positioned-2-expected.png: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-2-expected.txt: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-expected.png: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-expected.txt: Added.
  • platform/qt/fast/events/focusingUnloadedFrame-expected.png: Added.
  • platform/qt/fast/flexbox/002-expected.png: Added.
  • platform/qt/fast/flexbox/002-expected.txt:
  • platform/qt/fast/flexbox/003-expected.png: Added.
  • platform/qt/fast/flexbox/003-expected.txt:
  • platform/qt/fast/forms/listbox-clip-expected.png: Added.
  • platform/qt/fast/forms/listbox-clip-expected.txt:
  • platform/qt/fast/forms/menulist-clip-expected.png: Added.
  • platform/qt/fast/forms/menulist-clip-expected.txt:
  • platform/qt/fast/forms/minWidthPercent-expected.png: Added.
  • platform/qt/fast/forms/minWidthPercent-expected.txt:
  • platform/qt/fast/forms/onchange-enter-submit-expected.png: Added.
  • platform/qt/fast/gradients/background-clipped-expected.png: Added.
  • platform/qt/fast/gradients/background-clipped-expected.txt: Added.
  • platform/qt/fast/gradients/generated-gradients-expected.png: Added.
  • platform/qt/fast/gradients/generated-gradients-expected.txt: Added.
  • platform/qt/fast/gradients/simple-gradients-expected.png: Added.
  • platform/qt/fast/gradients/simple-gradients-expected.txt: Added.
  • platform/qt/fast/inline-block/001-expected.png: Added.
  • platform/qt/fast/inline-block/001-expected.txt:
  • platform/qt/fast/inline/continuation-outlines-expected.png: Added.
  • platform/qt/fast/inline/continuation-outlines-expected.txt:
  • platform/qt/fast/inline/continuation-outlines-with-layers-expected.png: Added.
  • platform/qt/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/qt/fast/invalid/019-expected.png: Added.
  • platform/qt/fast/invalid/019-expected.txt:
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • platform/qt/fast/layers/self-painting-outline-expected.png: Added.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/qt/fast/lists/003-expected.png: Added.
  • platform/qt/fast/lists/003-expected.txt:
  • platform/qt/fast/media/mq-animation-expected.png: Added.
  • platform/qt/fast/media/mq-animation-expected.txt: Added.
  • platform/qt/fast/media/mq-js-media-except-01-expected.png: Added.
  • platform/qt/fast/media/mq-js-media-except-01-expected.txt:
  • platform/qt/fast/media/mq-js-media-except-02-expected.png: Added.
  • platform/qt/fast/media/mq-js-media-except-02-expected.txt:
  • platform/qt/fast/overflow/table-overflow-float-expected.png: Added.
  • platform/qt/fast/overflow/table-overflow-float-expected.txt:
  • platform/qt/fast/repaint/4774354-expected.png: Added.
  • platform/qt/fast/repaint/4774354-expected.txt:
  • platform/qt/fast/repaint/4776765-expected.png: Added.
  • platform/qt/fast/repaint/4776765-expected.txt:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
  • platform/qt/fast/repaint/body-background-image-expected.png: Added.
  • platform/qt/fast/repaint/body-background-image-expected.txt:
  • platform/qt/fast/repaint/border-fit-lines-expected.png: Added.
  • platform/qt/fast/repaint/border-fit-lines-expected.txt:
  • platform/qt/fast/repaint/border-radius-repaint-expected.png: Added.
  • platform/qt/fast/repaint/border-radius-repaint-expected.txt:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.png: Added.
  • platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.png: Added.
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
  • platform/qt/fast/repaint/bugzilla-3509-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-3509-expected.txt:
  • platform/qt/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-5699-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6278-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6388-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6388-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6473-expected.txt:
  • platform/qt/fast/repaint/bugzilla-7235-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-7235-expected.txt:
  • platform/qt/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/qt/fast/repaint/caret-outside-block-expected.txt: Added.
  • platform/qt/fast/repaint/change-transform-expected.png: Added.
  • platform/qt/fast/repaint/change-transform-expected.txt: Added.
  • platform/qt/fast/repaint/clip-with-layout-delta-expected.png: Added.
  • platform/qt/fast/repaint/clip-with-layout-delta-expected.txt: Added.
  • platform/qt/fast/repaint/clipped-relative-expected.png: Added.
  • platform/qt/fast/repaint/clipped-relative-expected.txt:
  • platform/qt/fast/repaint/containing-block-position-change-expected.png: Added.
  • platform/qt/fast/repaint/containing-block-position-change-expected.txt:
  • platform/qt/fast/repaint/continuation-after-outline-expected.png: Added.
  • platform/qt/fast/repaint/continuation-after-outline-expected.txt:
  • platform/qt/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/qt/fast/repaint/create-layer-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
  • platform/qt/fast/repaint/float-move-during-layout-expected.png: Added.
  • platform/qt/fast/repaint/float-move-during-layout-expected.txt:
  • platform/qt/fast/repaint/float-overflow-expected.png: Added.
  • platform/qt/fast/repaint/float-overflow-expected.txt:
  • platform/qt/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/qt/fast/repaint/float-overflow-right-expected.txt:
  • platform/qt/fast/repaint/focus-layers-expected.png: Added.
  • platform/qt/fast/repaint/focus-layers-expected.txt:
  • platform/qt/fast/repaint/inline-color-change-expected.png: Added.
  • platform/qt/fast/repaint/inline-color-change-expected.txt: Added.
  • platform/qt/fast/repaint/invisible-objects-expected.png: Added.
  • platform/qt/fast/repaint/invisible-objects-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-relative-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt: Added.
  • platform/qt/fast/repaint/line-overflow-expected.png: Added.
  • platform/qt/fast/repaint/line-overflow-expected.txt:
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.png: Added.
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.txt: Added.
  • platform/qt/fast/repaint/list-marker-2-expected.png: Added.
  • platform/qt/fast/repaint/list-marker-2-expected.txt:
  • platform/qt/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/qt/fast/repaint/make-children-non-inline-expected.txt: Added.
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
  • platform/qt/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/qt/fast/repaint/outline-child-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/outline-inset-expected.png: Added.
  • platform/qt/fast/repaint/outline-inset-expected.txt:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/outline-shrinking-expected.png: Added.
  • platform/qt/fast/repaint/outline-shrinking-expected.txt:
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/qt/fast/repaint/overflow-delete-line-expected.png: Added.
  • platform/qt/fast/repaint/overflow-delete-line-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.txt: Added.
  • platform/qt/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/qt/fast/repaint/reflection-redraw-expected.txt: Added.
  • platform/qt/fast/repaint/reflection-repaint-test-expected.png: Added.
  • platform/qt/fast/repaint/reflection-repaint-test-expected.txt: Added.
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png: Added.
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/qt/fast/repaint/selected-replaced-expected.png: Added.
  • platform/qt/fast/repaint/selected-replaced-expected.txt: Added.
  • platform/qt/fast/repaint/selection-clear-expected.png: Added.
  • platform/qt/fast/repaint/selection-clear-expected.txt: Added.
  • platform/qt/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/qt/fast/repaint/static-to-positioned-expected.txt:
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-cell-move-expected.png: Added.
  • platform/qt/fast/repaint/table-cell-move-expected.txt:
  • platform/qt/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/qt/fast/repaint/table-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
  • platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
  • platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Added.
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.txt: Added.
  • platform/qt/fast/repaint/transform-absolute-child-expected.png: Added.
  • platform/qt/fast/repaint/transform-absolute-child-expected.txt: Added.
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
  • platform/qt/fast/repaint/transform-disable-layoutstate-expected.png: Added.
  • platform/qt/fast/repaint/transform-disable-layoutstate-expected.txt: Added.
  • platform/qt/fast/repaint/transform-layout-repaint-expected.png: Added.
  • platform/qt/fast/repaint/transform-layout-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/qt/fast/repaint/transform-relative-position-expected.txt: Added.
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.txt: Added.
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.png: Added.
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.txt: Added.
  • platform/qt/fast/repaint/transform-translate-expected.png: Added.
  • platform/qt/fast/repaint/transform-translate-expected.txt: Added.
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
  • platform/qt/fast/text/basic/generic-family-reset-expected.png: Added.
  • platform/qt/fast/text/basic/generic-family-reset-expected.txt:
  • platform/qt/fast/text/whitespace/002-expected.png: Added.
  • platform/qt/fast/text/whitespace/002-expected.txt:
  • platform/qt/fast/text/whitespace/003-expected.png: Added.
  • platform/qt/fast/text/whitespace/003-expected.txt:
04:21 Changeset [91983] by tonyg@chromium.org

[chromium] Fail new fast/js/parseInt.html test
https://bugs.webkit.org/show_bug.cgi?id=65366

Unreviewed expectaions update.

  • platform/chromium/test_expectations.txt:
03:26 Changeset [91982] by tkent@chromium.org

Make the ExceptionCode argument of Element::setShadowPseudoId() ASSERT_NO_EXCEPTION by default
https://bugs.webkit.org/show_bug.cgi?id=65363

Reviewed by Hajime Morita.

No new tests. Cleanup-only.

  • dom/Element.h: Make the ExceptionCode argument ASSERT_NO_EXCEPTION by default.
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree): Remove the ExceptionCode argument and ASSERT(!ec).

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText): ditto.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree): ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree): ditto.
(WebCore::TextFieldInputType::updatePlaceholderText): ditto.

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree): ditto.

02:59 Changeset [91981] by commit-queue@webkit.org

[EFL] Move ewk_view API documentation to the header file
https://bugs.webkit.org/show_bug.cgi?id=65305

There are two arguments for this:

  1. Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
  2. It will be consistent with structures descriptions.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-29
Reviewed by Kent Tamura.

  • ewk/ewk_tiled_model.c:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view.h:
  • ewk/ewk_view_single.c:
  • ewk/ewk_view_tiled.c:
02:50 Changeset [91980] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
01:37 Changeset [91979] by jocelyn.turcotte@nokia.com

TiledDrawingArea: Use tile sets to paint old content while rendering for a new scale.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

We currently delete all the tiles when setContentsScale is called. This shows a blank
background to the user while the web process render tiles for the new scale.

This patch extracts the ownership of individual tiles from TiledDrawingAreaProxy to
TiledDrawingAreaTileSet to allow the proxy to paint tiles with different scales.
We can then paint the tiles we already have on top of the tiles we are rendering for
the new scale until enough content is available.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaTileSet::tiles):
(WebKit::TiledDrawingAreaTileSet::contentsScale):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::mapToContents):
(WebKit::TiledDrawingAreaTileSet::mapFromContents):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::registerTile):
(WebKit::TiledDrawingAreaProxy::unregisterTile):
Added those two methods to allow the tiles to clean
themselves on destruction.
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::cancelTileUpdate):
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::updateTileBuffers):
(WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::coverageRatio):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::resizeEdgeTiles):
(WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect):
(WebKit::TiledDrawingAreaProxy::disableTileSetUpdates):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):
(WebKit::TiledDrawingAreaProxy::contentsRect):
(WebKit::TiledDrawingAreaProxy::visibleRect):
(WebKit::TiledDrawingAreaProxy::hasPendingUpdates):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:

(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::updateBackBuffer):

01:16 Changeset [91978] by ossy@webkit.org

[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364

  • platform/qt/Skipped: Skip failing tests.
01:04 Changeset [91977] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
00:38 Changeset [91976] by mrobinson@webkit.org

Fix incorrect ChangeLog entry from r91954.

00:11 QtWebKitForQt5 edited by romaxa@gmail.com
(diff)
00:11 QtWebKitForQt5 edited by romaxa@gmail.com
WebGL option (diff)

07/28/11:

22:32 Changeset [91975] by commit-queue@webkit.org

[Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
https://bugs.webkit.org/show_bug.cgi?id=65304
http://code.google.com/p/chromium/issues/detail?id=63553

Patch by Naoki Takano <honten@chromium.org> on 2011-07-28
Reviewed by Darin Fisher.

Chromium Autofill feature needs to access the parent WebFormElement from WebFormControlElement. So added form() method.

  • public/WebFormControlElement.h: Add form() function.
  • src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::form): Return parent WebFormElement.

22:16 Changeset [91974] by commit-queue@webkit.org

[EFL] Removes EAPI attribute in internal headers.
https://bugs.webkit.org/show_bug.cgi?id=65251

Removes EAPI attribute in three header files because API in these files is internally used.

Patch by Kangil Han <kangil.han@samsung.com> on 2011-07-28
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
21:53 Changeset [91973] by commit-queue@webkit.org

[EFL] Defines header files will be publicly installed explicitly.
https://bugs.webkit.org/show_bug.cgi?id=64923

This patch modifies a way to define open header list from black-list to white-list.
Plus, 'ewk/ewk_util.h' will not be installed anymore because it only has internal API.

Patch by Kangil Han <kangil.han@samsung.com> on 2011-07-28
Reviewed by Anders Carlsson.

  • CMakeListsEfl.txt:
21:43 Changeset [91972] by gyuyoung.kim@samsung.com

[EFL] Fix coding style of pointer type in ewk files.
https://bugs.webkit.org/show_bug.cgi?id=65358

Move '*' operator to variable side according to efl coding style.
Because, '*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • ewk/ewk_auth.cpp:

(ewk_auth_credentials_set):

  • ewk/ewk_auth.h:
  • ewk/ewk_auth_soup.cpp:

(_Ewk_Auth_Data::ewk_auth_soup_dialog_class_init):
(_Ewk_Auth_Data::ewk_auth_soup_dialog_init):
(_Ewk_Auth_Data::ewk_auth_soup_credentials_set):
(_Ewk_Auth_Data::session_authenticate):
(_Ewk_Auth_Data::free_auth_data):
(_Ewk_Auth_Data::attach):
(_Ewk_Auth_Data::detach):

  • ewk/ewk_auth_soup.h:
  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_ref):
(ewk_context_menu_unref):
(ewk_context_menu_destroy):
(ewk_context_menu_item_list_get):
(ewk_context_menu_item_new):
(ewk_context_menu_item_select):
(ewk_context_menu_item_free):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_type_set):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_action_set):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_title_set):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_checked_set):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_new):
(ewk_context_menu_free):
(ewk_context_menu_item_append):
(ewk_context_menu_custom_get):
(ewk_context_menu_show):

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:

(ewk_cookies_file_set):
(ewk_cookies_clear):
(ewk_cookies_get_all):
(ewk_cookies_cookie_del):
(ewk_cookies_policy_set):
(ewk_cookies_policy_get):

  • ewk/ewk_history.cpp:

(_ewk_history_item_new):
(_ewk_history_item_list_get):
(ewk_history_forward):
(ewk_history_back):
(ewk_history_history_item_add):
(ewk_history_history_item_set):
(ewk_history_history_item_back_get):
(ewk_history_history_item_current_get):
(ewk_history_history_item_forward_get):
(ewk_history_history_item_nth_get):
(ewk_history_history_item_contains):
(ewk_history_forward_list_get):
(ewk_history_forward_list_get_with_limit):
(ewk_history_forward_list_length):
(ewk_history_back_list_get):
(ewk_history_back_list_get_with_limit):
(ewk_history_back_list_length):
(ewk_history_limit_get):
(ewk_history_limit_set):
(ewk_history_item_new):
(_ewk_history_item_free):
(ewk_history_item_free):
(ewk_history_item_list_free):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_title_alternate_set):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
(ewk_history_item_page_cache_exists):
(ewk_history_item_visit_count):
(ewk_history_item_visit_last_failed):
(ewk_history_new):
(ewk_history_free):

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):

  • ewk/ewk_network.h:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_get):
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):
(ewk_settings_default_user_agent_get):

  • ewk/ewk_util.cpp:

(ewk_util_image_from_cairo_surface_add):

  • ewk/ewk_util.h:
  • ewk/ewk_window_features.cpp:

(ewk_window_features_unref):
(ewk_window_features_ref):
(ewk_window_features_bool_property_get):
(ewk_window_features_int_property_get):
(ewk_window_features_new_from_core):

  • ewk/ewk_window_features.h:
21:18 Changeset [91971] by gyuyoung.kim@samsung.com

[EFL] Fix pointer operator coding style in ewk_frame.
https://bugs.webkit.org/show_bug.cgi?id=65357

Move '*' operator to variable according to efl coding style.
Because, '*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • ewk/ewk_frame.cpp:

(_ewk_frame_debug):
(_ewk_frame_loader_efl_get):
(kit):
(_ewk_frame_children_iterator_next):
(_ewk_frame_children_iterator_get_container):
(_ewk_frame_smart_add):
(_ewk_frame_smart_del):
(_ewk_frame_smart_resize):
(_ewk_frame_smart_set):
(_ewk_frame_smart_class_new):
(ewk_frame_view_get):
(ewk_frame_children_iterator_new):
(ewk_frame_child_find):
(ewk_frame_uri_set):
(ewk_frame_uri_get):
(ewk_frame_title_get):
(ewk_frame_name_get):
(ewk_frame_contents_size_get):
(_ewk_frame_contents_set_internal):
(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):
(ewk_frame_script_execute):
(ewk_frame_editable_get):
(ewk_frame_editable_set):
(ewk_frame_selection_get):
(ewk_frame_text_search):
(ewk_frame_text_matches_mark):
(ewk_frame_text_matches_unmark_all):
(ewk_frame_text_matches_highlight_set):
(ewk_frame_text_matches_highlight_get):
(_ewk_frame_rect_cmp_less_than):
(_ewk_frame_rect_is_negative_value):
(ewk_frame_text_matches_nth_pos_get):
(ewk_frame_stop):
(ewk_frame_reload):
(ewk_frame_reload_full):
(ewk_frame_back):
(ewk_frame_forward):
(ewk_frame_navigate):
(ewk_frame_back_possible):
(ewk_frame_forward_possible):
(ewk_frame_navigate_possible):
(ewk_frame_zoom_get):
(ewk_frame_zoom_set):
(ewk_frame_zoom_text_only_get):
(ewk_frame_zoom_text_only_set):
(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):
(ewk_frame_scroll_add):
(ewk_frame_scroll_set):
(ewk_frame_scroll_size_get):
(ewk_frame_scroll_pos_get):
(ewk_frame_visible_content_geometry_get):
(ewk_frame_paint_full_get):
(ewk_frame_paint_full_set):
(ewk_frame_feed_focus_in):
(ewk_frame_feed_focus_out):
(ewk_frame_feed_mouse_wheel):
(ewk_frame_feed_mouse_down):
(ewk_frame_feed_mouse_up):
(ewk_frame_feed_mouse_move):
(ewk_frame_feed_touch_event):
(_ewk_frame_handle_key_scrolling):
(ewk_frame_feed_key_down):
(ewk_frame_feed_key_up):
(ewk_frame_text_selection_type_get):
(ewk_frame_add):
(ewk_frame_init):
(ewk_frame_child_add):
(ewk_frame_core_gone):
(ewk_frame_core_get):
(ewk_frame_load_started):
(ewk_frame_load_provisional):
(ewk_frame_load_finished):
(ewk_frame_load_error):
(ewk_frame_load_progress_changed):
(ewk_frame_contents_size_changed):
(ewk_frame_title_set):
(ewk_frame_view_create_for_view):
(ewk_frame_uri_changed):
(ewk_frame_force_layout):
(ewk_frame_plugin_create):
(ewk_frame_editor_client_selection_changed):

  • ewk/ewk_frame.h:
20:25 Changeset [91970] by thakis@chromium.org

[chromium] Make WebImage::assign(CGImageRef) a WEBKIT_API
https://bugs.webkit.org/show_bug.cgi?id=65265

Reviewed by James Robinson.

Required for the components build on mac. The inline function
operator=(CGImageRef) is used from outside webkit, and calls this
function.

  • public/WebImage.h:
18:46 Changeset [91969] by macpherson@chromium.org

Remove remaining uses of CSSPrimitiveValue::computeLengthIntForLength()
https://bugs.webkit.org/show_bug.cgi?id=64919

Reviewed by Darin Adler.

No new tests / cleanup only.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Remove implementation of computeLengthIntForLength()

  • css/CSSPrimitiveValue.h:

Remove definition of computeLengthIntForLength()

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
Remove use of computeLengthIntForLength()

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove use of computeLengthIntForLength()

  • platform/Length.h:

(WebCore::Length::setQuirk):
Adds the ability to set the m_quirk member variable after construction.

18:37 Changeset [91968] by kerz@chromium.org

Merge 91927 - [chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/7474011

18:36 Changeset [91967] by tkent@chromium.org

[Qt] Fix style errors of test_expectations.txt.

  • platform/qt/test_expectations.txt:
17:43 Changeset [91966] by barraclough@apple.com

Source/JavaScriptCore: *_list instructions are only used in one place, where the code is wrong.
https://bugs.webkit.org/show_bug.cgi?id=65348

Patch by Oliver Hunt <oliver@apple.com> on 2011-07-28
Reviewed by Darin Adler.

Simply remove the instructions and all users. Speeds up the interpreter
slightly due to code motion, but otherwise has no effect (because none
of the _list instructions are ever used).

  • bytecode/CodeBlock.cpp:

(JSC::isPropertyAccess):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt

Reviewed by Oliver Hunt.

  • fast/js/parseInt-expected.txt: Added.
  • fast/js/parseInt.html: Added.
  • fast/js/script-tests/parseInt.js: Added.
    • Added test cases.
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.2_parseInt/S15.1.2.2_A1_T2-expected.txt:
    • Fixed.
17:38 Changeset [91965] by andersca@apple.com

Unreviewed, rolling out r88601. (Requested by Sam Weinig).
http://trac.webkit.org/changeset/88601
https://bugs.webkit.org/show_bug.cgi?id=62230

Caused a regression, see https://bugs.webkit.org/show_bug.cgi?id=64378

Source/WebCore:

  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::insertedIntoDocument):
(WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):

  • html/HTMLBodyElement.h:

LayoutTests:

  • fast/dom/body-link-decl-parent-crash-expected.txt: Removed.
  • fast/dom/body-link-decl-parent-crash.html: Removed.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Removed.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Removed.
17:26 Changeset [91964] by commit-queue@webkit.org

REGRESSION (5.1): CJK input broken after clicking on Flash content
<rdar://problem/9854447>
https://bugs.webkit.org/show_bug.cgi?id=65349

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-28
Reviewed by Darin Adler.

After giving Flash focus on a page and then navigating away from that page
using the back button, we were not getting notified to switch back to
inline (non-complex) input. Now, notify the page that it can leave complex
text mode when the plugin is destroyed.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

17:24 Changeset [91963] by jschuh@chromium.org

Simplify createCanonicalUUIDString implementation.
https://bugs.webkit.org/show_bug.cgi?id=65157

All ports support OS_RANDOMNESS, so better to have one implementation.

Reviewed by Adam Barth.

Change covered by existing tests.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

17:10 Changeset [91962] by andersca@apple.com

Add reviewer.

17:06 Changeset [91961] by andersca@apple.com

Crash when trying to encode FontInfo with a null font attribute descriptor
https://bugs.webkit.org/show_bug.cgi?id=65350
<rdar://problem/9520670>

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):
Encode a boolean specifying whether there's a fontAttributeDictionary member variable.

(WebKit::FontInfo::decode):
Don't try to decode the fontAttributeDictionary member variable if none has been encoded.

17:02 Changeset [91960] by commit-queue@webkit.org

Fixed gif animation dependency on system time
https://bugs.webkit.org/show_bug.cgi?id=64996

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-07-28
Reviewed by James Robinson.

Test: Load WebCore/manual-tests/animated-gif-looping.html
Change system time to a time in past

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation): Bitmap animation is now based
on monotonicallyIncreasingTime instead of currentTime

16:56 Changeset [91959] by commit-queue@webkit.org

V8 should correctly serialize Boolean, Number and String objects.

https://bugs.webkit.org/show_bug.cgi?id=65286

Source/WebCore:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-28
Reviewed by David Levin.

New APIs were exposed to allow V8 to correctly serialize Boolean, Number and String objects, as well as detect certain native errors as required by the HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data). SerializedScriptValue should make use of these APIs.

  • Checks for and serializes Boolean, Number and String objects.
  • Checks for native errors and aborts should a script attempt to serialize them.
  • Small name change to clear up the code: m_objectReferenceStack => m_openCompositeReferenceStack

Tests: fast/dom/Window/window-postmessage-clone.html

fast/loader/stateobjects/pushstate-object-types.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeBooleanObject):
(WebCore::V8ObjectMap::Writer::writeStringObject):
(WebCore::V8ObjectMap::Writer::writeNumberObject):
(WebCore::V8ObjectMap::Serializer::writeStringObject):
(WebCore::V8ObjectMap::Serializer::writeNumberObject):
(WebCore::V8ObjectMap::Serializer::writeBooleanObject):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readStringObject):
(WebCore::V8ObjectMap::Reader::readNumberObject):
(WebCore::V8ObjectMap::Deserializer::deserialize):
(WebCore::V8ObjectMap::Deserializer::openComposite):
(WebCore::V8ObjectMap::Deserializer::closeComposite):

LayoutTests:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-28
Reviewed by David Levin.

  • Check that Boolean, Number and String objects are correctly serialized.
  • Check that a native error is not serialized.
  • Fix an expectation that a native error can be serialized.
  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/script-tests/postmessage-test.js:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
16:43 Changeset [91958] by kerz@chromium.org

Merge 91915 - 2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/7532014

16:39 Changeset [91957] by abarth@webkit.org

Old code about empty security origins could use a bath
https://bugs.webkit.org/show_bug.cgi?id=64735

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch cleans up some old code related to empty security origins.
It also removes some dodgy code that seems wrong.

Test: http/tests/security/inactive-document-with-empty-security-origin.html

  • bindings/generic/BindingSecurityBase.cpp:

(WebCore::BindingSecurityBase::canAccess):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::isEmpty):
(WebCore::SecurityOrigin::isSecureTransitionTo):
(WebCore::SecurityOrigin::toString):

LayoutTests:

  • http/tests/security/inactive-document-with-empty-security-origin-expected.txt: Added.
  • http/tests/security/inactive-document-with-empty-security-origin.html: Added.
  • http/tests/security/resources/post-done-to-opener.html: Added.
16:37 Changeset [91956] by vsevik@chromium.org

Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector open and there are watch expressions added.
https://bugs.webkit.org/show_bug.cgi?id=65322

Reviewed by Pavel Feldman.

  • inspector/InspectorController.cpp:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
16:33 Changeset [91955] by commit-queue@webkit.org

[CSSRegions]Add basic RenderRegion support
https://bugs.webkit.org/show_bug.cgi?id=64689

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-28
Reviewed by David Hyatt.

Source/WebCore:

This patch introduces the RenderRegion object.
A RenderObject that takes its content from a "named" flow will become a RenderRegion, an element that is used to display the content from a RenderFlowThread.
A RenderRegion that is marked to take its content from a non existing flow, will have its content disconnected from the normal flow.

Tests: fast/regions/region-element-display-restriction.html

fast/regions/region-element-dynamic-attach-flow.html
fast/regions/region-element-dynamic-detach-flow.html
fast/regions/render-region-renderer.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderRegion):

  • rendering/RenderRegion.cpp: Added.

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::paint):

  • rendering/RenderRegion.h: Added.

(WebCore::RenderRegion::isRenderRegion):
(WebCore::RenderRegion::renderName):
(WebCore::toRenderRegion):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

  • fast/regions/region-element-display-restriction-expected.txt: Added.
  • fast/regions/region-element-display-restriction.html: Added.
  • fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
  • fast/regions/region-element-dynamic-attach-flow.html: Added.
  • fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
  • fast/regions/region-element-dynamic-detach-flow.html: Added.
  • fast/regions/render-region-renderer-expected.txt: Added.
  • fast/regions/render-region-renderer.html: Added.
  • fast/regions/script-tests/region-element-display-restriction.js: Added.
16:26 Changeset [91954] by commit-queue@webkit.org

[Soup] Cannot override default max-conns and max-conns-per-host Soup Session settings
https://bugs.webkit.org/show_bug.cgi?id=64355
Default max-conns and max-conns-per-host are set at "first contact" with
a site instead of at creation time. This results in values being
overwritten if they are set prior to said "first contact"; which is the
most likely (or only) scenario.

Patch by Marco Peereboom <marco@peereboom.us> on 2011-07-28
Reviewed by Martin Robinson.

No new tests. Rigged libsoup and xxxterm web browser to diagnose the
issue and validate the patch.

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::determinePitch):

16:22 Changeset [91953] by enne@google.com

[chromium] chromium-win-xp test updates after r91945.

Unreviewed gardening.

See also r91946, r91948.

  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-win-xp/fast/ruby/nested-ruby-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.txt: Added.
16:20 Changeset [91952] by oliver@apple.com

*_list instructions are only used in one place, where the code is wrong.
https://bugs.webkit.org/show_bug.cgi?id=65348

Reviewed by Darin Adler.

Simply remove the instructions and all users. Speeds up the interpreter
slightly due to code motion, but otherwise has no effect (because none
of the _list instructions are ever used).

  • bytecode/CodeBlock.cpp:

(JSC::isPropertyAccess):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

15:00 Changeset [91951] by mihaip@chromium.org

[Chromium] Remove WebDocument::insertStyleText
https://bugs.webkit.org/show_bug.cgi?id=65332

Reviewed by Tony Chang.

As of http://crrev.com/94499 no Chromium code calls this anymore.
Also does a bit of #include cleanup.

  • public/WebDocument.h:
  • src/WebDocument.cpp:
14:38 Changeset [91950] by tony@chromium.org

2011-07-28 Tony Chang <tony@chromium.org>

Add sql to svn:ignore and remove app.

  • chromium: Modified property svn:ignore.
14:37 Changeset [91949] by tony@chromium.org

Add sql to svn:ignore and remove app.

  • chromium: Modified property svn:ignore.
14:24 Changeset [91948] by senorblanco@chromium.org

Yet more chromium test updates. Vista tests were broken by the win7
results (same fallback problem as linux). Some tests just needed a
baseline. And some checked-in SVG masks test results were wrong.

Unreviewed.

  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:14 Changeset [91947] by rwlbuis@webkit.org

2011-07-28 Rob Buis <rbuis@rim.com>

Mac svg gardening.

RS=Nikolas Zimmerman.

  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/custom/text-linking-expected.png:
  • platform/mac/svg/filters/feGaussianBlur-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
13:36 Changeset [91946] by senorblanco@chromium.org

New chromium linux text results. These results used to match the XP
results, but since we now have (correct) win7 results with different
DOM trees, the fallback no longer works, and we need them here.

Unreviewed.

  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-linux/svg/custom/circular-marker-reference-1-expected.txt: Added.
  • platform/chromium-linux/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.txt: Added.
13:10 Changeset [91945] by senorblanco@chromium.org

Rebaseline many chromium win7 and vista tests. This also revealed some
incorrect results checked into the tree, which I've deleted.

Unreviewed.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-win-vista/fast/text/drawBidiText-expected.png:
  • platform/chromium-win-vista/fast/text/international/danda-space-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-vista/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-win/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-win/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-win/fast/css/first-letter-first-line-hover-expected.png: Added.
  • platform/chromium-win/fast/css/first-letter-first-line-hover-expected.txt: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win/fast/text/drawBidiText-expected.png:
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
  • platform/chromium-win/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-win/fast/text/international/plane2-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/custom/circular-marker-reference-1-expected.txt: Added.
  • platform/chromium-win/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/chromium-win/svg/custom/circular-marker-reference-4-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.
  • platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
12:45 Changeset [91944] by brettw@chromium.org

Merge 91789 - Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/7530003

12:27 Changeset [91943] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65323
r91931 causes NOTREACHED to be hit via StorageTracker

Change the meaning of the "has been initialized" flag to "needs initialization", and only set it to true
if the ::initializeTracker() method has been called.

Reviewed by Sam Weinig.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Set m_needsInitialization to true since the calling WebKit port expects full

initialization instead of a dummy tracker.

(WebCore::StorageTracker::internalInitialize):
(WebCore::StorageTracker::tracker): Only initialize the tracker if it was created in the above initializeTracker().
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:
12:03 Changeset [91942] by reed@google.com

add Mike Reed to committer list

11:53 Changeset [91941] by senorblanco@chromium.org

Chromium test_expectations update: remove a bunch of commented-out
expectations. Some of these were introduced by me, some were not.

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:24 Changeset [91940] by senorblanco@chromium.org

New chromium baselines after skia r1960.

Unreviewed.

  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-expected.png:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png: Removed.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png: Added.
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium/test_expectations.txt:
10:38 Changeset [91939] by cfleizach@apple.com

REGRESSION (Safari 5.1): JavaScript dialogs not usable with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=65214

Reviewed by Anders Carlsson.

Allow the ability to spin the run loop while WebProcess is waiting for a synchronous reply.
This allows it to continue to serve accessibility requests while waiting and basically
restores the behavior WK1 was presenting. This patch only enables this mode when accessibility is on.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::sendSync):

  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm:

(RunLoop::runForDuration):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

10:32 Changeset [91938] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt

Reviewed by Oliver Hunt.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):

  • parseInt applied to small positive numbers = floor.
10:24 Changeset [91937] by commit-queue@webkit.org

Pass the key_press_event or key_release_event to parent widget when it is not handled by Web Process.
(https://bugs.webkit.org/show_bug.cgi?id=64790)

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-07-28
Reviewed by Martin Robinson.

  • Shared/NativeWebKeyboardEvent.h:

(WebKit::NativeWebKeyboardEvent::nativeEvent): Return a GdkEvent* instead of const GdkEvent* (non-const).

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithKeyEvent): Implemented for GTK port. Sets flag if the keyboard event
needs to be passed to the parent widget. Invoke gtk_main_do_event() if event needs to be passed to parent.

  • UIProcess/API/gtk/PageClientImpl.h: Deleted obsolete functions didNotHandleKeyEvent & didNotHandleWheelEvent.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_init): Initialize shouldForwardNextKeyEvent flag.
(webkitWebViewBaseKeyPressEvent): Pass event to parent widget depending on status from doneWithKeyEvent.
(webkitWebViewBaseKeyReleaseEvent): Pass event to parent widget depending on status from doneWithKeyEvent.
(webkitWebViewBaseForwardNextKeyEvent): API to set flag shouldForwardNextKeyEvent.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added API to set shouldForwardNextKeyEvent flag.
09:57 Changeset [91936] by ddkilzer@apple.com

<http://webkit.org/b/65289> Remove GeolocationPositionCache

Reviewed by Adam Barth.

  • CMakeLists.txt: Remove references to GeolocationPositionCache.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Geolocation.cpp: Switch from using m_positionCache to

m_cachedPosition.
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::haveSuitableCachedPosition):
(WebCore::Geolocation::positionChangedInternal):

  • page/Geolocation.h: Remove PositionCacheWrapper and replace

with RefPtr<Geoposition>.

  • page/GeolocationPositionCache.cpp: Removed.
  • page/GeolocationPositionCache.h: Removed.
09:33 Changeset [91935] by mitz@apple.com

Source/WebCore: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebCore.exp.in: Exported wkGetVerticalGlyphsForCharacters.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Use wkGetVerticalGlyphsForCharacters. If it returns false, proceed
with the existing, slower method of getting vertical glyphs.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.

Source/WebKit2: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.

WebKitLibraries: WebKitSystemInterface support for
<rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetVerticalGlyphsForCharacters().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
09:30 Changeset [91934] by vangelis@chromium.org

Merge 91768 - [SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
https://bugs.webkit.org/show_bug.cgi?id=65182

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-26
Reviewed by Stephen White.

No new tests. Not sure how to test wrong-ctx bugs in layout tests.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7520031

09:26 Changeset [91933] by mitz@apple.com

Build fix.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):

08:33 Changeset [91932] by tonyg@chromium.org

[chromium] New expectations after r91924
https://bugs.webkit.org/show_bug.cgi?id=65320

Unreviewed expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
08:32 Changeset [91931] by beidson@apple.com

<rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView

Source/WebCore:

Move the heavy lifting done in StorageTracker::initializeTracker() until when the global tracker is actually
accessed, therefore deferring it until a web page actually uses LocalStorage or the app uses the API.

Reviewed by Maciej Stachowiak.

No new tests. (Not possible to test this API implementation detail)

  • WebCore.exp.in:
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::StorageAreaImpl): Access the global StorageTracker to indicate that a web page

is actually using the storage APIs.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Moved the potentially hefty work from here...
(WebCore::StorageTracker::internalInitialize): ...to here.
(WebCore::StorageTracker::tracker): If the global tracker hasn't had internalInitialize() called, do so.
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

  • Storage/WebStorageManager.mm:

(WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().

Source/WebKit2:

Reviewed by Maciej Stachowiak.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Pass a null client pointer in the new form of initializeTracker()

08:25 Changeset [91930] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: My last attempt to paint Qt-Mac bot green.
08:22 Changeset [91929] by carlosgc@webkit.org

[GTK] Copy and paste is broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=65252

Reviewed by Martin Robinson.

Use gtk_clipboard_get_for_display() instead of
gtk_widget_get_clipboard(), using the the default display when
there's no page client widget, which is the case of WebKit2.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::displayFromFrame): Return the display of the current
frame widget or the default display if there's no widget.
(WebCore::PasteboardHelper::getClipboard):
(WebCore::PasteboardHelper::getPrimarySelectionClipboard):

08:13 Changeset [91928] by vsevik@chromium.org

Web Inspector: Add resource initiator column to network panel.
https://bugs.webkit.org/show_bug.cgi?id=65105

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator.html

  • English.lproj/localizedStrings.js:
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculationImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willRecalculateStyle):
(WebCore::InspectorResourceAgent::didRecalculateStyle):
(WebCore::InspectorResourceAgent::didScheduleStyleRecalculation):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.InitiatorComparator):

  • inspector/front-end/networkLogView.css:

(.initiator-column a):

LayoutTests:

  • http/tests/inspector/network/network-initiator-expected.txt: Added.
  • http/tests/inspector/network/network-initiator.html: Added.
  • http/tests/inspector/network/resources/initiator.css: Added.

(.image-background):
(.image-background-2):

07:39 Changeset [91927] by tonyg@chromium.org

[chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
07:27 Changeset [91926] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: One more attempt to paint Qt-Mac bot green.
07:25 Changeset [91925] by senorblanco@chromium.org

Uncomment some suppressions we'll need for the upcoming skia roll.

Unreviewed; chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
07:24 Changeset [91924] by rwlbuis@webkit.org

2011-07-28 Rob Buis <rbuis@rim.com>

Use styling test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=62147

Reviewed by Nikolas Zimmermann.

Make sure CSS selectors are applied to the DOM tree referenced by <use>, not the internal shadow tree. In order to quickly
find the corresponding DOM tree element store this info in SVGElementRareData.

Test: svg/W3C-SVG-1.1-SE/struct-use-11-f.svg

  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::styleForRenderer):
  • rendering/svg/SVGShadowTreeElements.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::correspondingElement): (WebCore::SVGElement::setCorrespondingElement): (WebCore::SVGElement::styleForRenderer):
  • svg/SVGElement.h:
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::correspondingElement): (WebCore::SVGElementRareData::setCorrespondingElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::removedFromDocument):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
  • svg/SVGUseElement.h:
07:12 Changeset [91923] by commit-queue@webkit.org

This fixes build without video enabled.
https://bugs.webkit.org/show_bug.cgi?id=65084

Patch by Denis Oliver Kropp <dok@directfb.org> on 2011-07-28
Reviewed by Philippe Normand.

Test with --disable-video.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

07:07 Changeset [91922] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/qt/test_expectations.txt:
06:57 QtWebKitBuildBots edited by abecsi@webkit.org
(diff)
06:53 QtWebKitBuildBots edited by rgabor@webkit.org
(diff)
06:47 QtWebKitBuildBots edited by rgabor@webkit.org
(diff)
06:34 Changeset [91921] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Paint the bot green with skipping all failing and crashing tests.
06:15 Changeset [91920] by ossy@webkit.org

Unreviewed gardening.

[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

  • platform/qt-wk2/Skipped: Skip two failing fast test.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/Skipped:
05:21 Changeset [91919] by yutak@chromium.org

WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
https://bugs.webkit.org/show_bug.cgi?id=65250

Reviewed by Alexey Proskuryakov.

Add useHixie76Protocol() method to WebSocketChannel and its family. To implement hybi-specific
attributes in WebSocket object, WebSocket class needs to be able to get the value of
useHixie76Protocol flag of WebSocketChannel.

If the WebSocket object is created in a worker thread, the flag value must be obtained from
WebSocketChannel which resides in the loader thread (through WorkerThreadableWebSocketChannel).
Since the value does not change after creation of WebSocketChannel, it can be cached in
the worker thread.

There is no change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setUseHixie76Protocol):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::useHixie76Protocol):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Peer::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):

  • websockets/WorkerThreadableWebSocketChannel.h:
05:19 Changeset [91918] by ossy@webkit.org

[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

  • platform/qt-wk2/Skipped: Skip failing editing tests.
05:06 Changeset [91917] by commit-queue@webkit.org

Rebaseline pixel tests for file upload controls on chromium-win.
https://bugs.webkit.org/show_bug.cgi?id=65245

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-28
Reviewed by Gustavo Noronha Silva.

r91759 changed the appearance of file upload controls on gtk,
chromium-win and chromium-linux. New baselines were already committed
for chromium-linux (same changeset) and gtk (r91759).

  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/file-input-direction-expected.png:
  • platform/chromium-win/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium/test_expectations.txt:
05:03 Changeset [91916] by ossy@webkit.org

[Qt] Add platform specific expected result for a new test.

  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
04:42 Changeset [91915] by rwlbuis@webkit.org

2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
01:13 Changeset [91914] by mrobinson@webkit.org

[Cairo] Switch from ContextShadow to ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=64744

Source/WebCore:

Use ShadowBlur in the Cairo backend instead of ContextShadow. This allows us
to share shadowing code with Qt and Mac ports and to correct some broken
shadow rendering.

Reviewed by Dirk Schulze.

  • CMakeLists.txt: Remove ContextShadow from the build.
  • CMakeListsEfl.txt: Ditto.
  • GNUmakefile.list.am: Add ShadowBlur source files and remove ContextShadow

source files.

  • platform/graphics/GraphicsContext.cpp:Add #ifdefs to support ShadowBlur for Cairo.
  • platform/graphics/GraphicsContext.h: Remove Cairo ContextShadow code.
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawInsetShadowWithTiling): Since the ShadowBlur is a property
of the GraphicsContext, we cannot clear the GraphicsContext shadow until we have
finished using properties like m_offset. If we clear the GrahpicsContext shadow
before using these properties, they will be zero when we try to use them.
(WebCore::ShadowBlur::drawRectShadowWithTiling):Ditto.
(WebCore::ShadowBlur::drawLayerPieces): Ditto.
(WebCore::ShadowBlur::beginShadowLayer):Cairo is the first port to keep ShadowBlur
as a persistent property of GraphicsContext and use drawRectShadow and drawInsetShadow.
Thus, we must manually clear the cached tiling values so that ShadowBlur does not
try to reuse the scratch buffer for rectangular shadows after using beginShadowLayer
and endShadowLayer.
(WebCore::ShadowBlur::mustUseShadowBlur): Moved this method from the Qt port to
this cross-platform location.

  • platform/graphics/ShadowBlur.h: Added new method declaration.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Removed.
  • platform/graphics/cairo/FontCairo.cpp: Switched to using ShadowBlur.

(WebCore::drawGlyphsShadow):Ditto.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Switch to using ShadowBlur.

(WebCore::drawPathShadow): ShadowBlur has slightly different semantics than
ContextShadow. When filling the shadow layer, we do not need to use the fill
alpha. We also need to restore the Cairo path to the target context after
endShadowLayer as it destroys the current path.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Switch to using ShadowBlur.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):Ditto.
(WebCore::PlatformContextCairo::prepareForStroking): Add a mode ignoring alpha.

  • platform/graphics/cairo/PlatformContextCairo.h: Ditto.

(WebCore::PlatformContextCairo::shadowBlur):Added.

  • platform/graphics/gtk/FontGtk.cpp: Update to use ShadowBlur.
  • platform/graphics/qt/GraphicsContextQt.cpp: Switch to using the new version of mustUseShadowBlur.

LayoutTests:

Update test results, which are now correct after switch to ShadowBlur.

Reviewed by Dirk Schulze.

  • fast/box-shadow/box-shadow-radius-expected.png: Added.
  • fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • fast/box-shadow/inset-shadow-large-offset-expected.png:
  • fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • fast/box-shadow/scaled-box-shadow-expected.png: Added.
  • fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/gtk/Skipped: Skip a test, which now has a bug revealed.
  • platform/gtk/fast/box-shadow/basic-shadows-expected.png:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.png:
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/gtk/fast/box-shadow/inset-expected.png:
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/gtk/fast/box-shadow/spread-expected.png:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.png:
00:38 Changeset [91913] by tkent@chromium.org

Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=65300

Reviewed by Darin Adler.

r91837 had performance regression of StringImpl::stripWhiteSpace()
and simplifyWhiteSpace(). This changes the code so that compilers
generates code equivalent to r91836 or piror.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripMatchedCharacters):
A template member function for stripWhiteSpace(). This function takes a functor.
(WTF::UCharPredicate):
A functor for generic predicate for single UChar argument.
(WTF::SpaceOrNewlinePredicate):
A special functor for isSpaceOrNewline().
(WTF::StringImpl::stripWhiteSpace):
Use stripmatchedCharacters().
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
A template member function for simplifyWhiteSpace().
(WTF::StringImpl::simplifyWhiteSpace):
Use simplifyMatchedCharactersToSpace().

  • wtf/text/StringImpl.h:

07/27/11:

23:46 Changeset [91912] by rniwa@webkit.org

Fix Chromium Windows test expectations after r91897.

  • platform/chromium/test_expectations.txt:
23:19 Changeset [91911] by ryuan.choi@samsung.com

Style bot complains about EFL-specific forward declaration naming.
https://bugs.webkit.org/show_bug.cgi?id=64680

Exclude EFL-specific forward declarations from indentifiers with underscores checks.

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:05 Changeset [91910] by gyuyoung.kim@samsung.com

[EFL] Add dummy NotificationPresenterClientEfl
https://bugs.webkit.org/show_bug.cgi?id=64064

Source/WebCore:

Add two files to CMakeLists.txt for HTML5 Notification.

Reviewed by Antonio Gomes.

  • CMakeLists.txt:

Source/WebKit/efl:

Add dummy files for HTML5 Notification. And also, notificationPresenter() is added to
ChromeClientEfl. Without this function implemented, there would be a build break when
ENABLE_NOTIFICATION is enabled.

Reviewed by Antonio Gomes.

  • CMakeListsEfl.txt:
  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::notificationPresenter):

  • WebCoreSupport/ChromeClientEfl.h:
  • WebCoreSupport/NotificationPresenterClientEfl.cpp: Added.

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

  • WebCoreSupport/NotificationPresenterClientEfl.h: Added.
22:59 Changeset [91909] by commit-queue@webkit.org

Rebaseline extra test for bug 61369 (skia drawConvexPolygon antialiasing)
https://bugs.webkit.org/show_bug.cgi?id=65299

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

  • platform/chromium-linux/fast/layers/opacity-transforms-expected.png:
  • platform/chromium-win/fast/layers/opacity-transforms-expected.png: Added.
  • platform/chromium-win/fast/layers/opacity-transforms-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
22:24 Changeset [91908] by rniwa@webkit.org

Calling window.find immediately after mutating the document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=65296

Reviewed by Darin Adler.

Source/WebCore:

Don't forget to layout first.

Test: editing/text-iterator/find-after-mutation.html

  • editing/TextIterator.cpp:

(WebCore::findPlainText):

LayoutTests:

Added a test to ensure WebKit doesn't crash when searching for string after mutating the document.

  • editing/text-iterator/find-after-mutation-expected.txt: Added.
  • editing/text-iterator/find-after-mutation.html: Added.
22:22 Changeset [91907] by commit-queue@webkit.org

Remove skia special case for outline rendering code
https://bugs.webkit.org/show_bug.cgi?id=65295

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

Source/WebCore:

The fix for bug 58999 (outlines with alpha channels showed artifacts in the corners) was
excluded from skia builds until bug 61369 (skia drawConvexPoly didn't pay attention to
shouldAntialias) was fixed. That bug is fixed so now the #if's can be removed.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

  • platform/chromium/test_expectations.txt:
22:16 Changeset [91906] by dslomov@google.com

[chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017
The patch turns on WTF_MULTIPLE_THREADS in chromium and
pushes some relevant initializations from JSC::initializeThreading
to WTF::initializeThreading.

Reviewed by David Levin.

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • wtf/FastMalloc.cpp:

(WTF::isForbidden):
(WTF::fastMallocForbid):
(WTF::fastMallocAllow):

  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

22:11 Changeset [91905] by abarth@webkit.org

Crypto.idl doesn't need legacy optional arguments
https://bugs.webkit.org/show_bug.cgi?id=65298

Reviewed by Darin Adler.

This API is relatively new and useless to call without its only argument.

  • page/Crypto.idl:
22:05 Changeset [91904] by tkent@chromium.org

2011-07-27 Kent Tamura <tkent@chromium.org>

REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl
https://bugs.webkit.org/show_bug.cgi?id=65239

Reviewed by Ryosuke Niwa.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): For RTL, move the speech button to the left side and shift the inner text to the right by the width of the speech button and the spin button.
21:59 Changeset [91903] by commit-queue@webkit.org

Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-27
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • API/JSContextRef.cpp:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

Source/JavaScriptGlue:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • JSRun.cpp:

(JSRun::JSRun):

  • JSRun.h:

(JSGlueGlobalObject::create):

  • JSUtils.cpp:

(JSObjectKJSValue):
(getThreadGlobalObject):

  • UserObjectImp.h:

(UserObjectImp::create):

Source/WebCore:

No new tests.

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::newRuntimeObject):
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CInstance::getMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::newRuntimeObject):
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaInstance::getMethod):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::fallbackObject):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::newRuntimeObject):
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjcInstance::getMethod):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

Source/WebKit/mac:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::newRuntimeObject):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyInstance::getMethod):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame scopeChain]):

Source/WebKit2:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::methodGetter):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):

21:57 Changeset [91902] by vsevik@chromium.org

Web Inspector: Network panel sidebar should have width saved in preferences when resource is selected.
https://bugs.webkit.org/show_bug.cgi?id=65256

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkPanel.prototype.restoreSidebarWidth):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.preferredSidebarWidth):
(WebInspector.Panel.prototype.get restoreSidebarWidth):

21:34 Changeset [91901] by vsevik@chromium.org

Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::open):

21:32 Changeset [91900] by adamk@chromium.org

[V8] Remove unused m_isWeak member of V8AbstractEventListener
https://bugs.webkit.org/show_bug.cgi?id=65273

Reviewed by Adam Barth.

m_isWeak is set to true in the constructor and never changed,
so the one if statement that tests it always executes; the
code has been updated to make this clear.

No behavior change, thus no tests.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):

  • bindings/v8/V8AbstractEventListener.h:
21:23 Changeset [91899] by aroben@apple.com

Use wacky !svn/bc URLs consistently in Leaks Viewer

This ensures that any resources loaded via relative URLs will still get pulled from the same
revision of Subversion.

Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the

!svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
from Subversion.

21:08 Changeset [91898] by commit-queue@webkit.org

[EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
https://bugs.webkit.org/show_bug.cgi?id=65269

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-27
Reviewed by Kent Tamura.

WorkQueueItemEfl.h was being included by efl's
LayoutTestControllerEfl.cpp, however the top-level
LayoutTestController still included WorkQueueItem.h, causing a lot of
type mismatches when running the WorkQueueItem code.

We can stick to the original WorkQueueItem header by making a few
changes to EFL's LayoutTestController.

This should make tests such as
fast/loader/non-deferred-substitute-load.html stop crashing.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

  • DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
20:56 Changeset [91897] by reed@google.com

[skia] fix clipping of some glyphs on windows
https://bugs.webkit.org/show_bug.cgi?id=65262

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
20:55 Changeset [91896] by fsamuel@chromium.org

Source/WebCore: Popups on Chromium now check the minimum row height set through the Chromium WebKit API when
computing the height of a row in a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

No new tests.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::minimumRowHeight):
(WebCore::PopupMenuChromium::setMinimumRowHeight):

Source/WebKit/chromium: Added a Chromium WebKit API method to set the minimum row height of a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

  • public/WebPopupMenu.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenu::setMinimumRowHeight):

20:44 Changeset [91895] by morrita@google.com

Source/WebCore: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

The tree scope pointers on shadow tree nodes didn't cleared.
even when the tree scope (shadow root) is destroyed.
This change clear these poitners before detaching the shadow root.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/tree-scope-crash.html

  • dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

LayoutTests: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/tree-scope-crash-expected.txt: Added.
  • fast/dom/shadow/tree-scope-crash.html: Added.
20:25 Changeset [91894] by commit-queue@webkit.org

DFG graph has no notion of double prediction.
https://bugs.webkit.org/show_bug.cgi?id=65234

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

Added the notion of PredictDouble, and PredictNumber, which is the least
upper bound of PredictInt32 and PredictDouble. Least upper bound is
defined as the bitwise-or of two predictions. Bottom is defined as 0,
and Top is defined as all bits being set. Added the ability to explicitly
distinguish between a node having had a prediction associated with it,
and that prediction still being valid (i.e. no conflicting predictions
have also been added). Used this to guard the speculative JIT from
speculating Int32 in cases where the graph knows that the value is
double, which currently only happens for GetLocal nodes on arguments
which were double at compile-time.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):

20:00 Changeset [91893] by commit-queue@webkit.org

Implement sizes attribute for link tag from HTML5
https://bugs.webkit.org/show_bug.cgi?id=37674

Patch by Rachel Blum <groby@chromium.org> on 2011-07-27
Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/icon-size-property.html

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSHTMLLinkElementCustom.cpp:

(WebCore::JSHTMLLinkElement::sizes):
(WebCore::JSHTMLLinkElement::setSizes):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp: Added.

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
(WebCore::V8HTMLLinkElement::sizesAccessorSetter):

  • html/HTMLAttributeNames.in:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::sizes):
(WebCore::HTMLLinkElement::setSizes):

  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.idl:

LayoutTests:

  • fast/dom/icon-size-property-expected.txt: Added.
  • fast/dom/icon-size-property.html: Added.
19:57 Changeset [91892] by commit-queue@webkit.org

Add more text input types for chromium
https://bugs.webkit.org/show_bug.cgi?id=64937

Patch by Peng Huang <penghuang@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

19:31 Changeset [91891] by rniwa@webkit.org

Fix Chromium test expectations for http://crbug.com/88911

  • platform/chromium/test_expectations.txt:
18:45 Changeset [91890] by rniwa@webkit.org

Add sfntly library to the Chromium DEPS file.

  • DEPS:
18:27 Changeset [91889] by kbr@google.com

Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7523024

18:24 Changeset [91888] by rniwa@webkit.org

Unreviewed. Rolled DEPS.

  • DEPS:
18:02 Changeset [91887] by rniwa@webkit.org

Chromium rebaseline after r91879.

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:21 Changeset [91886] by jamesr@google.com

Merge 91823 - [chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::cleanupResources):

  • platform/graphics/chromium/ContentLayerChromium.h:

TBR=jamesr@chromium.org
BUG=89487
Review URL: http://codereview.chromium.org/7522010

17:13 Changeset [91885] by psolanki@apple.com

Incorrect arguments passed to LOG statement
https://bugs.webkit.org/show_bug.cgi?id=65293

Reviewed by Oliver Hunt.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):

16:52 Changeset [91884] by dglazkov@chromium.org

Re-add unit tests I accidentally zapped in r91878.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
16:48 Changeset [91883] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=65294
DFG JIT - may speculate based on wrong arguments.

Reviewed by Oliver Hunt

In the case of a DFG compiled function calling to and compiling a second function that
also compiles through the DFG JIT (i.e. compilation triggered with DFGOperations.cpp),
we call compileFor passing the caller functions exec state, rather than the callee's.
This may lead to mis-optimization, since the DFG compiler will example the exec state's
arguments on the assumption that these will be passed to the callee - it is wanting the
callee exec state, not the caller's exec state.

Fixing this for all cases of compilation is tricksy, due to the way the numeric sort
function is compiled, & the structure of the calls in the Interpreter::execute methods.
Only fix for compilation from the JIT, in other calls don't speculate based on arguments
for now.

  • dfg/DFGOperations.cpp:
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::FunctionExecutable::compileForCallInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileFor):

16:40 Changeset [91882] by enne@google.com

[chromium] Marking leviw's new unicode-bidi-plaintext test as failing

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [91881] by enne@google.com

[chromium] Mark another flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:18 Changeset [91880] by leviw@chromium.org

Switch transform operations to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=64301

Reviewed by Simon Fraser.

Changing TransformOperation and its progeny to operate on FloatSizes instead of IntSizes.

  • platform/graphics/transforms/IdentityTransformOperation.h:

(WebCore::IdentityTransformOperation::apply):

  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:

(WebCore::Matrix3DTransformOperation::blend):

  • platform/graphics/transforms/Matrix3DTransformOperation.h:

(WebCore::Matrix3DTransformOperation::apply):

  • platform/graphics/transforms/MatrixTransformOperation.cpp:

(WebCore::MatrixTransformOperation::blend):

  • platform/graphics/transforms/MatrixTransformOperation.h:

(WebCore::MatrixTransformOperation::apply):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:

(WebCore::PerspectiveTransformOperation::apply):

  • platform/graphics/transforms/RotateTransformOperation.h:

(WebCore::RotateTransformOperation::apply):

  • platform/graphics/transforms/ScaleTransformOperation.h:

(WebCore::ScaleTransformOperation::apply):

  • platform/graphics/transforms/SkewTransformOperation.h:

(WebCore::SkewTransformOperation::apply):

  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TransformOperations.h:

(WebCore::TransformOperations::apply):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::apply):

16:16 Changeset [91879] by leviw@chromium.org

unicode-bidi:-webkit-plaintext does not work on <textarea>
https://bugs.webkit.org/show_bug.cgi?id=65074

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixing unicode-bidi style propagation into text control shadow trees.

Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

LayoutTests:

Fixing unicode-bidi propagation into text controls.

  • fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
16:11 Changeset [91878] by dglazkov@chromium.org

Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with

test configuration matching, removed a bunch of code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
15:42 Changeset [91877] by dglazkov@chromium.org

Allow ports to specify their own test expectation specifier macros.
https://bugs.webkit.org/show_bug.cgi?id=65291

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
  • Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
15:35 Changeset [91876] by mahesh.kulkarni@nokia.com

Build fix for Symbian after r91800

15:33 Changeset [91875] by enne@google.com

[chromium] Mark another webgl flaky test.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:16 Changeset [91874] by dglazkov@chromium.org

Allow TestConfigurationConverter report conversion errors.
https://bugs.webkit.org/show_bug.cgi?id=65287

Also, fix a few miscellaneous testing issues.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance

was created. 'default' is not a valid build type.

  • Scripts/webkitpy/layout_tests/port/test.py: Ditto. is not a valid version.
15:10 Changeset [91873] by enne@google.com

[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:01 Changeset [91872] by eric.carlson@apple.com

2011-07-27 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Darin Adler.

Test: media/video-poster-blocked-by-willsendrequest.html

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if

willLoadMediaElementURL returns false.

2011-07-27 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Darin Adler.

  • media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
  • media/video-poster-blocked-by-willsendrequest.html: Added.
14:55 Changeset [91871] by oliver@apple.com

Handle callback oriented JSONP
https://bugs.webkit.org/show_bug.cgi?id=65271

Reviewed by Gavin Barraclough.

Handle the callback oriented versions of JSONP. The Literal parser
now handles <Identifier> (. <Identifier>)* (jsonData).

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lex):

  • runtime/LiteralParser.h:
14:50 Changeset [91870] by senorblanco@chromium.org

Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests. Printing itself in Chrome has few tests, sadly. :(

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

14:44 Changeset [91869] by slewis@apple.com

Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.

Unreviewed rollout.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::releaseExecutableMemory):

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):

  • runtime/RegExp.h:
14:20 Changeset [91868] by kerz@chromium.org

Merge 91847 - Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::startDownload):

TBR=commit-queue@webkit.org

14:18 Changeset [91867] by kerz@chromium.org

Merge 91797 - Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL. The author can also supply a
suggested file name in the attribute value. This feature is a recent
addition to HTML to better support offline applications that use blob
URLs. Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event. This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html

fast/dom/HTMLAnchorElement/anchor-nodownload.html
fast/dom/HTMLAnchorElement/anchor-download-unset.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAttributeNames.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::startDownload):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::loadURLExternally):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::startDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::startDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::startDownload):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::startDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::startDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::startDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::startDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::loadURLExternally):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7521007

14:06 Changeset [91866] by dglazkov@chromium.org

Teach all ports about their test configurations.
https://bugs.webkit.org/show_bug.cgi?id=65278

Each Port object should return a valid set of all TestConfiguration instances,
available for this port.

Reviewed by Philippe Normand.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,

since it is different for each port.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of

all test configurations as a param.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
  • Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
  • Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
  • Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
  • Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
14:02 UsingGitWithWebKit edited by aroben@apple.com
Added some git config commands to produce better ObjC diffs (diff)
12:44 Changeset [91865] by rniwa@webkit.org

Chromium rebaselines for r89627 and r91497.

  • platform/chromium-linux/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-linux/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/single-line-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/chromium/test_expectations.txt:
12:26 Changeset [91864] by xji@chromium.org

editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Split the 2 tests into 4 tests. But need to find a way to improve
performance eventually.

  • editing/selection/move-by-word-visually-multi-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
  • editing/selection/move-by-word-visually-multi-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
  • editing/selection/move-by-word-visually-multi-space-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
  • editing/selection/move-by-word-visually-multi-space.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
  • editing/selection/move-by-word-visually-others-expected.txt: Removed.
  • editing/selection/move-by-word-visually-others.html: Removed.
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
  • editing/selection/move-by-word-visually-single-space-inline-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
  • editing/selection/move-by-word-visually-single-space-one-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
  • editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Removed.
  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
12:21 Changeset [91863] by benjamin.poulain@nokia.com

[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
https://bugs.webkit.org/show_bug.cgi?id=62969

Reviewed by Andreas Kling.

Co-authored with Simon Hausmann <simon.hausmann@nokia.com>

Source/WebKit/qt:

Add the declarative dependency to link WebKit.

Source/WebKit2:

This patch change the base of WebKit2 from QGraphicsWidget
to scenegraph based items.

QTouchWebView becomes a QSGItem with the only role of clipping
child items.
QTouchWebPage becomes a QSGPaintedItem in order to render the content
of the flattened page. This is a temporary work around to get
something running without deep changes on the drawing area proxy.

QDesktopWebView become a QSGPaintedItem and behave as before
regarding rendering. The drawing area proxy is used to render
the full item.

The event delivery had to be adapted because the scenegraph does not
follow regular delivery of QEvents. Instead, each event type is
delivered directly to a specific virtual function.
In this patch, the events are forwarded to the classic QObject::event().

For the features that cannot be implemented on scenegraph (tooltip, menus, etc),
a temporary workaround was added: the parent canvas is used as the widget for
providing the feature. This assumes the web views alone in the canvas and
take its full size. This will have to be fixed in the scenegraph for us to
implement those features.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::isActive):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::init):
(paintCrashedPage):
(QDesktopWebView::keyPressEvent):
(QDesktopWebView::keyReleaseEvent):
(QDesktopWebView::inputMethodEvent):
(QDesktopWebView::focusInEvent):
(QDesktopWebView::focusOutEvent):
(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::touchEvent):
(QDesktopWebView::hoverEnterEvent):
(QDesktopWebView::hoverMoveEvent):
(QDesktopWebView::hoverLeaveEvent):
(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragExitEvent):
(QDesktopWebView::dragDropEvent):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::paint):
(QTouchWebPage::event):
(QTouchWebPage::keyPressEvent):
(QTouchWebPage::keyReleaseEvent):
(QTouchWebPage::inputMethodEvent):
(QTouchWebPage::focusInEvent):
(QTouchWebPage::focusOutEvent):
(QTouchWebPage::touchEvent):
(QTouchWebPage::geometryChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):
(TestWindow::resizeEvent):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::pinchGestureRequestUpdate):
(WebKit::TouchViewInterface::drawingAreaSize):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::isActive):

  • UIProcess/qt/ViewInterface.cpp: Removed.
  • UIProcess/qt/ViewInterface.h:
  • WebKit2.pro:

Tools:

With the scene graph, the interface to have a window on screen is
QSGCanvas. QGraphicsView is not used, and openGL is an enforced
dependency.

Both the BrowserView and the WebKitTest runner are changed from
QGraphicsView to QSGCanvas.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::view):

  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:
11:54 Changeset [91862] by rniwa@webkit.org

Wrong image height in absolutely positioned div in relatively positioned parent with bottom padding
https://bugs.webkit.org/show_bug.cgi?id=64046

Reviewed by David Hyatt.

Add pixel test results.

  • platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
11:39 Changeset [91861] by rniwa@webkit.org

Mac pixel rebaselines after r91497.

  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:
11:34 Changeset [91860] by mihaip@chromium.org

[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
https://bugs.webkit.org/show_bug.cgi?id=65158

Reviewed by David Hyatt.

Source/WebCore:

Add per-Document instance user stylesheets (as opposed to the page
group user styles and the global page stylesheet).

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore::Document::addUserSheet):

  • dom/Document.h:

Source/WebKit/chromium:

Add WebDocument::insertUserStyleSheet which inserts a user stylesheet,
instead of forcing extensions to use insertStyleText which manipulates
the DOM of the page and results in compatibility issues (see
http://crbug.com/82220).

  • public/WebDocument.h:
  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

11:32 Changeset [91859] by enne@google.com

[chromium] Mark data-view-test.html as flaky in non-debug configs too.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:30 Changeset [91858] by vsevik@chromium.org

Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/network/network-disable-cache-memory-expected.txt:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/resources/random-script.php: Added.
10:45 Changeset [91857] by ossy@webkit.org

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/qt-wk2/Skipped: Skip failing test.
10:43 Changeset [91856] by enne@google.com

[chromium] Add baselines for struct-dom-11-f.svg.

Unreviewed gardening.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
10:40 Changeset [91855] by caio.oliveira@openbossa.org

[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
https://bugs.webkit.org/show_bug.cgi?id=61328

Reviewed by Andreas Kling.

Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
emitting signals in the progress notification functions, we use the
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
that loading code is prepared to handle load() when inside those functions.

The crash was being caused by setUrl() (and load()) being called when
loadFinished(false) was emitted. The problem here is that when
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
call again, because it was still the ProvisionalLoadState but with the
provisionalDocumentLoader already removed.

To emulate the same behavior that QtWebKit had when using
postProgressFinishedNotification, we now keep track of the frame originating the
load, and emit the signals when this frame's client is called.

The patch keeps the existing semantics for QWebPage signals, but we now emit the
QWebFrame signals everytime, not only when they are the originating frame for
loading.

  • Api/qwebframe.cpp:

(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.

  • WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep

track whether the frame is originating the load. Remove the signals from
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.

(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
signals to our signals for load/finished, signal emission will be done manually.

(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
loadStarted() signal and make the first notification of estimation change, that
Qt API tests expect to exist and notify 10%.

(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
m_loadError and emit loadFinished() signal.

(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
emission and mark the originating load as true, since only the originating frame
gets this call in its client.

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
emission.

(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
was successful or not. This wasn't necessary before because a successful call for
error page would lead to a load(), that cleared the m_loadError.
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
to m_loadError and emit finished signal indicating error if ErrorPage extension
doesn't handle it.
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.

(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
for the QWebFrame, and if the originating load also do for the QWebPage.

(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
loadFinished(). Take care to reset the originating load flag before the signals
are emitted, since they might want to set it back again.

  • tests/qwebframe/tst_qwebframe.cpp:

(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
when a certain signal is emitted in the frame.

(URLSetter::execute):
(tst_QWebFrame::loadInSignalHandlers_data):
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
crashes without this patch applied.

10:20 Changeset [91854] by enne@google.com

[Chromium] Mark more tests as being flaky.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:09 Changeset [91853] by ossy@webkit.org

[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

  • platform/qt-4.8/fast/css/font-face-opentype-expected.png: Added.
  • platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Added.
  • platform/qt-4.8/fast/css/font-family-pictograph-expected.png: Added.
  • platform/qt-4.8/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/qt-4.8/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/qt-4.8/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Remove window.XSLTProcessor entries.
  • platform/qt/Skipped: Skip a failing test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added after r91850.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added after r91850.
  • platform/qt/svg/custom/tref-own-content-removal-expected.png: Added.
09:20 Changeset [91852] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests after migration to Qt5.
  • platform/qt/test_expectations.txt: Mark fast/js/array-sort-modifying-tostring.html as TIMEOUT PASS flakey test in debug mode.
09:06 Changeset [91851] by ossy@webkit.org

[WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip new failing tests.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Update after r91300.
  • platform/wk2/Skipped: Skip tests because of missing layoutTestController implementation.
08:58 Changeset [91850] by rwlbuis@webkit.org

2011-07-27 Rob Buis <rbuis@rim.com>

Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=11274

Reviewed by Nikolas Zimmermann.

Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
pointer-events=none in the list.

Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg

svg/custom/intersection-list-clipping.svg
svg/custom/intersection-list-nested-svg.svg

  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::getElementCTM): (WebCore::intersectsAllowingEmpty): (WebCore::isGraphicsElement): (WebCore::RenderSVGModelObject::checkIntersection): (WebCore::RenderSVGModelObject::checkEnclosure):
  • rendering/svg/RenderSVGModelObject.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure):
08:56 Changeset [91849] by senorblanco@chromium.org

Tighten up some chromium test expectations to green up the bots.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:45 Changeset [91848] by senorblanco@chromium.org

Rebaseline one Chromium GPU test on Linux after
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
08:36 Changeset [91847] by commit-queue@webkit.org

Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::startDownload):

08:25 Changeset [91846] by senorblanco@chromium.org

New chromium-linux baselines after skia change
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-linux/fonts/cursive-expected.txt: Added.
  • platform/chromium-linux/fonts/fantasy-expected.txt:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-linux/svg/custom/text-rotation-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-linux/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/chromium/test_expectations.txt:
08:20 Changeset [91845] by caio.oliveira@openbossa.org

[Qt] Fix build in Qt 5 of QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=65258

Reviewed by Andreas Kling.

In Qt 5, the QGraphicsView-based classes for QtQuick are in the
qtquick1 module, including QDeclarativeItem and QDeclarativeView.

.:

  • Source/WebKit.pro:

Source/WebKit/qt:

  • declarative/qdeclarativewebview_p.h:
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
  • tests/tests.pri:
  • tests/tests.pro:
07:37 Changeset [91844] by abecsi@webkit.org

[Qt][V8] Fix the build.

Unreviewed build fix.

No new tests needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.
07:20 Changeset [91843] by alexis.menard@openbossa.org

[Qt] Unreviewed build fix for mac.

QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.

  • DerivedSources.pro:
  • WebCore.pro:
07:12 Changeset [91842] by ossy@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip a new failing test: svg/custom/image-with-transform-clip-filter.svg
06:56 Changeset [91841] by tonyg@chromium.org

Speculative win build fix after r91835
https://bugs.webkit.org/show_bug.cgi?id=65255

Unreviewed build fix.

  • src/WebFontImpl.cpp:
06:55 Changeset [91840] by commit-queue@webkit.org

[Qt][WK2] Clean WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65246

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-27
Reviewed by Andreas Kling.

Remove the empty functions from Qt's WKPageLoaderClient.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didSameDocumentNavigationForFrame): Move the function to
have all the implementations in the same order as the definitions.

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

06:37 Changeset [91839] by yurys@chromium.org

Inspector should support cd(window) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19872

Source/WebCore:

Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd.html

  • WebCore.gypi:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/ContextManager.js: Added.

(WebInspector.ContextManager):
(WebInspector.ContextManager.prototype._frameAdded):
(WebInspector.ContextManager.prototype._frameNavigated):
(WebInspector.ContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get id):
(WebInspector.FrameEvaluationContext.prototype.get url):
(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Added a test for console evaluation in an iframe.

Reviewed by Pavel Feldman.

  • http/tests/inspector/console-cd-expected.txt: Added.
  • http/tests/inspector/console-cd.html: Added.
  • http/tests/inspector/resources/console-cd-iframe.html: Added.
06:34 Changeset [91838] by caio.oliveira@openbossa.org

Fix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
https://bugs.webkit.org/show_bug.cgi?id=65253

Reviewed by Andreas Kling.

The -webkit-pictograph generic family was added by bug 65197.

  • Shared/WebPreferencesStore.h:
06:07 Changeset [91837] by commit-queue@webkit.org

Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):

Added an interface to take IsWhiteSpaceFunctionPtr.

(WTF::StringImpl::simplifyWhiteSpace): ditto.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.

  • wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

  • fast/forms/option-strip-unicode-spaces-expected.txt: Added.
  • fast/forms/option-strip-unicode-spaces.html: Added.
06:01 Changeset [91836] by ossy@webkit.org

Add Qt specific expected result for a new test introduced in r91777.

  • platform/qt/fast/css/font-family-pictograph-expected.png: Added.
  • platform/qt/fast/css/font-family-pictograph-expected.txt: Added.
05:38 Changeset [91835] by zecke@webkit.org

[chromium] Remove include of skia/ext/platform_canvas.h
https://bugs.webkit.org/show_bug.cgi?id=60852

Reviewed by Hajime Morita.

In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
skia::PlatformCanvas was eliminated in favor of directly using
SkCanvas directly. The include of platform_canvas.h was not removed
leaving the dependency on Chromium in the header files. Remove
that dependency now.

  • platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h
04:22 Changeset [91834] by philn@webkit.org

Unreviewed, forgotten GTK pixel test results for
fast/forms/input-file-re-render.html after r91833.

  • platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
03:51 Changeset [91833] by philn@webkit.org

Unreviewed, GTK pixel tests rebaseline after r91759.

  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/file-input-direction-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/test_expectations.txt:
03:30 Changeset [91832] by bashi@chromium.org

Merge 90868 by hand.

BUG=87132
TBR=bashi@chromium.org

03:24 Changeset [91831] by benjamin.poulain@nokia.com

[Qt][WK2] Simplify the PageUIClient
https://bugs.webkit.org/show_bug.cgi?id=65198

Reviewed by Andreas Kling.

The only function of WKPageLoaderClient with a complete implementation
is qt_wk_setStatusText(). The other functions were what is left from
before the refactoring of QWKPage.

This patch removes the unused functions to simplify the client. Since the dependency
on QtWebPageProxy is removed from that client, it now calls the ViewInterface directly.

  • UIProcess/qt/ClientImpl.cpp:

(toViewInterface):
(qt_wk_setStatusText):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:
03:03 Changeset [91830] by commit-queue@webkit.org

Unreviewed, rolling out r91792.
http://trac.webkit.org/changeset/91792
https://bugs.webkit.org/show_bug.cgi?id=65242

It broke NRWT on Qt and GTK (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-27

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
03:01 Changeset [91829] by mnaganov@chromium.org

Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

02:49 Changeset [91828] by tonyg@chromium.org

editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Unreviewed build fix.

  • platform/chromium/test_expectations.txt:
02:15 Changeset [91827] by commit-queue@webkit.org

Knob of a disabled or readonly range control should not be draggable.
https://bugs.webkit.org/show_bug.cgi?id=54820

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Made disabled or readonly range control undraggable.

Test: fast/forms/range-drag.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

Added check that the element is readonly or disabled.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler): ditto.

LayoutTests:

Added tests to confirm disabled or readonly range control is undraggable.

  • fast/forms/range-drag-expected.txt: Added.
  • fast/forms/range-drag.html: Added.
01:56 Changeset [91826] by yutak@chromium.org

WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
https://bugs.webkit.org/show_bug.cgi?id=65232

Reviewed by Kent Tamura.

Source/WebCore:

Add [NoStaticTables] attribute to CloseEvent interface definition. This attribute
makes the code generator obtain the attributes table used for building ClassInfo
through JSGlobalData, instead of directly using a statically-allocated table.

Generally speaking, NoStaticTables needs to be specified in interfaces which
may be accessed from workers.

Tests: http/tests/websocket/tests/hybi/workers/shared-worker-simple.html (updated)

http/tests/websocket/tests/hybi/workers/worker-simple.html (updated)

  • websockets/CloseEvent.idl: Fixed the formatting, too.

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/resources/worker-simple.js:

(runTests): Check the value of closeEvent.wasClean.

  • http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt:
  • http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt:
00:12 Changeset [91825] by commit-queue@webkit.org

DFG JIT speculation failure code performs incorrect conversions in
the case where two registers need to be swapped.
https://bugs.webkit.org/show_bug.cgi?id=65233

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::swapWith):

07/26/11:

23:02 Changeset [91824] by commit-queue@webkit.org

reduce and reduceRight bind callback's this to null rather than undefined
https://bugs.webkit.org/show_bug.cgi?id=62264

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed Array.prototype.reduce and Array.prototype.reduceRight so that they behave correctly
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

LayoutTests:

Added additional tests to test Array.prototype.reduce and Array.prototype.reduceRight
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • fast/js/array-reduce-expected.txt:
  • fast/js/array-reduceRight-expected.txt:
  • fast/js/script-tests/array-reduce.js:
  • fast/js/script-tests/array-reduceRight.js:
20:48 Changeset [91823] by commit-queue@webkit.org

[chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::cleanupResources):

  • platform/graphics/chromium/ContentLayerChromium.h:
20:42 Changeset [91822] by commit-queue@webkit.org

Unreviewed, rolling out r91805.
http://trac.webkit.org/changeset/91805
https://bugs.webkit.org/show_bug.cgi?id=65226

Breaks @ symbols and changes other font rendering on Windows
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
20:18 Changeset [91821] by enne@google.com

Unreviewed, rolling out r91812.
http://trac.webkit.org/changeset/91812
https://bugs.webkit.org/show_bug.cgi?id=65210

Breaks OSX GPU tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

20:05 Changeset [91820] by abarth@webkit.org

Fix ChangeLog.

20:01 Changeset [91819] by abarth@webkit.org

enne tells me that she already rebaselined this test. The 10.5 bot is
just behind because dglazkov broke NRWT on Python 2.5.

  • platform/chromium/test_expectations.txt:
19:59 Changeset [91818] by abarth@webkit.org

Switch to an older idiom that works on Python 2.5.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
19:56 Changeset [91817] by commit-queue@webkit.org

JSC command-line tool does not come with any facility for
measuring time precisely.
https://bugs.webkit.org/show_bug.cgi?id=65223

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

Exposed WTF::currentTime() as currentTimePrecise().

  • jsc.cpp:

(GlobalObject::GlobalObject):
(functionPreciseTime):

19:48 Changeset [91816] by commit-queue@webkit.org

Unreviewed, rolling out r91809.
http://trac.webkit.org/changeset/91809
https://bugs.webkit.org/show_bug.cgi?id=65225

Does not build on Chromium Windows (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • platform/PlatformGestureEvent.h:
  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:
19:45 Changeset [91815] by gyuyoung.kim@samsung.com

[EFL] Fix pointer operator coding style in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=65163

Move '*' operator to variable according to efl coding style. In addition,
add a space between * and variable in type casting.

Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_changed):
(_ewk_view_repaints_resize):
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scrolls_resize):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_core_frame_new):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_contents_resize):
(_ewk_view_smart_zoom_set):
(_ewk_view_smart_flush):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_zoom_animated_mark_stop):
(_ewk_view_zoom_animated_finish):
(_ewk_view_zoom_animated_current):
(_ewk_view_zoom_animator_cb):
(_ewk_view_zoom_animation_start):
(_ewk_view_viewport_attributes_compute):
(ewk_view_base_smart_set):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_frame_main_get):
(ewk_view_frame_focused_get):
(ewk_view_uri_set):
(ewk_view_uri_get):
(ewk_view_title_get):
(ewk_view_editable_get):
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
(ewk_view_text_search):
(ewk_view_text_matches_mark):
(ewk_view_text_matches_unmark_all):
(ewk_view_text_matches_highlight_set):
(ewk_view_text_matches_highlight_get):
(ewk_view_editable_set):
(ewk_view_selection_get):
(_ewk_view_editor_command):
(ewk_view_execute_editor_command):
(ewk_view_context_menu_forward_event):
(ewk_view_load_progress_get):
(ewk_view_stop):
(ewk_view_reload):
(ewk_view_reload_full):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_navigate):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_navigate_possible):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):
(ewk_view_zoom_get):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_smooth_scale_get):
(ewk_view_zoom_weak_smooth_scale_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_mark_start):
(ewk_view_zoom_animated_mark_end):
(ewk_view_zoom_animated_mark_current):
(ewk_view_zoom_animated_mark_stop):
(ewk_view_zoom_animated_set):
(ewk_view_zoom_text_only_get):
(ewk_view_zoom_text_only_set):
(ewk_view_pre_render_region):
(ewk_view_pre_render_relative_radius):
(ewk_view_pre_render_cancel):
(ewk_view_setting_user_agent_get):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_get):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_get):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_get):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_auto_resize_window_get):
(ewk_view_setting_enable_auto_resize_window_set):
(ewk_view_setting_enable_scripts_get):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_get):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_get):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_window_open_get):
(ewk_view_setting_scripts_window_open_set):
(ewk_view_setting_resizable_textareas_get):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_get):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_offline_app_cache_get):
(ewk_view_setting_offline_app_cache_set):
(ewk_view_setting_caret_browsing_get):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_setting_encoding_default_get):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_get):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_get):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_get):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_get):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_setting_font_standard_get):
(ewk_view_setting_font_standard_set):
(ewk_view_setting_font_cursive_get):
(ewk_view_setting_font_cursive_set):
(ewk_view_setting_font_fantasy_get):
(ewk_view_setting_font_fantasy_set):
(ewk_view_setting_font_monospace_get):
(ewk_view_setting_font_monospace_set):
(ewk_view_setting_font_serif_get):
(ewk_view_setting_font_serif_set):
(ewk_view_setting_font_sans_serif_get):
(ewk_view_setting_font_sans_serif_set):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_get):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_get):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_smart_data_get):
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
(ewk_view_repaint_add):
(ewk_view_layout_if_needed_recursive):
(ewk_view_scrolls_process):
(ewk_view_paint_context_new):
(ewk_view_paint_context_free):
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint_context_scale):
(ewk_view_paint_context_translate):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_ready):
(ewk_view_input_method_state_set):
(ewk_view_title_set):
(ewk_view_uri_changed):
(ewk_view_load_started):
(ewk_view_frame_main_load_started):
(ewk_view_load_provisional):
(ewk_view_load_show):
(ewk_view_frame_main_cleared):
(ewk_view_frame_main_icon_received):
(ewk_view_load_finished):
(ewk_view_load_error):
(ewk_view_load_progress_changed):
(ewk_view_restore_state):
(ewk_view_window_create):
(ewk_view_window_close):
(ewk_view_mouse_link_hover_in):
(ewk_view_mouse_link_hover_out):
(ewk_view_toolbars_visible_set):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_set):
(ewk_view_statusbar_visible_get):
(ewk_view_statusbar_text_set):
(ewk_view_scrollbars_visible_set):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_set):
(ewk_view_menubar_visible_get):
(ewk_view_tooltip_text_set):
(ewk_view_add_console_message):
(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):
(ewk_view_should_interrupt_javascript):
(ewk_view_exceeded_database_quota):
(ewk_view_run_open_panel):
(ewk_view_repaint):
(ewk_view_scroll):
(ewk_view_core_page_get):
(ewk_view_frame_create):
(ewk_view_plugin_create):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_download_request):
(ewk_view_viewport_attributes_set):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_need_touch_events_set):
(ewk_view_need_touch_events_get):
(ewk_view_mode_set):
(ewk_view_mode_get):
(ewk_view_editor_client_selection_changed):

  • ewk/ewk_view.h:
19:41 Changeset [91814] by dslomov@google.com

[V8][Chromium] Run workers in a separate v8::Isolate
https://bugs.webkit.org/show_bug.cgi?id=65004
This patch allocates a new v8::Isolate for every worker and enters it on worker thread.

Reviewed by David Levin.

Covered by existing chromium tests.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):

  • bindings/v8/WorkerScriptController.h:
19:37 Changeset [91813] by abarth@webkit.org

This test appears to fail on Leopard only.

  • platform/chromium/test_expectations.txt:
19:28 Changeset [91812] by jamesr@google.com

[chromium] Avoid clearing the framebuffer when compositing in release builds
https://bugs.webkit.org/show_bug.cgi?id=65210

Reviewed by Kenneth Russell.

We clear the default framebuffer to blue when compositing so it's
easier to spot regions we miss. This is useful for debugging, but eats
bandwidth unnecessarily in release builds.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

19:25 Changeset [91811] by jpfau@apple.com

New XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=64566

Reviewed by Adam Barth.

Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLToken.h:
  • xml/parser/XMLTokenizer.cpp: Added.

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::XMLTokenizer::nextToken):
(WebCore::XMLTokenizer::bufferCharacter):
(WebCore::XMLTokenizer::parseError):

  • xml/parser/XMLTokenizer.h: Added.

(WebCore::XMLTokenizer::create):
(WebCore::XMLTokenizer::gotError):
(WebCore::XMLTokenizer::shouldSkipNullCharacters):

19:02 Changeset [91810] by gyuyoung.kim@samsung.com

Add an exception to coding style check for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=65162

Add an exception of whitespace/declaration for EFL port. Because,
'*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/style/checker.py:
18:52 Changeset [91809] by commit-queue@webkit.org

[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
18:38 Changeset [91808] by joepeck@webkit.org

Restore Composited Layers Faster from PageCache
https://bugs.webkit.org/show_bug.cgi?id=65216

Reviewed by Simon Fraser.

Restore the layer tree hierarchy a little sooner, when
restoring from the page cache. This more closely matches
original restore behavior.

Existing test showed no change.

  • page/FrameView.cpp:

(WebCore::FrameView::restoreBackingStores):

18:27 Changeset [91807] by commit-queue@webkit.org

DFG speculative JIT never emits inline double comparisons, even when it
would be obvious more efficient to do so.
https://bugs.webkit.org/show_bug.cgi?id=65212

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This handles the obvious case of inlining double comparisons: it only addresses
the speculative JIT, and only for fused compare/branch sequences. But it does
handle the case where both operands are double (and there is no slow path),
or where one operand is double and the other is unknown type (in which case it
attempts to unbox the double, otherwise taking slow path). This is an 0.8%
speed-up on SunSpider.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

18:12 Changeset [91806] by commit-queue@webkit.org

[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-26
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

18:10 Changeset [91805] by commit-queue@webkit.org

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Patch by Mike Reed <reed@google.com> on 2011-07-26
Reviewed by Kenneth Russell.

No new tests. existing tests apply to the new drawing path

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

17:55 Changeset [91804] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=64969
DFG JIT generates inefficient code for speculation failures.

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This implements a speculation failure strategy where (1) values spilled on
non-speculative but not spilled on speculative are spilled, (2) values that
are in registers on both paths are rearranged without ever touching memory,
and (3) values spilled on speculative but not spilled on non-speculative are
filled.

The register shuffling is the most interesting part of this patch. It
constructs a permutation graph for registers. Each node represents a
register, and each directed edge corresponds to the register's value having
to be moved to a different register as part of the shuffling. This is a
directed graph where each node may only have 0 or 1 incoming edges, and
0 or 1 outgoing edges. The algorithm then first finds maximal non-cyclic
subgraphs where all nodes in the subgraph are reachable from a start node.
Such subgraphs always resemble linked lists, and correspond to simply
moving the value in the second-to-last register into the last register, and
then moving the value in the third-to-last register into the second-to-last
register, and so on. Once these subgraphs are taken care of, the remaining
subgraphs are cycles, and are handled using either (a) conversion or no-op
if the cycle involves one node, (b) swap if it involves two nodes, or (c)
a cyclic shuffle involving a scratch register if there are three or more
nodes.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::GeneralizedRegister):
(JSC::DFG::GeneralizedRegister::createGPR):
(JSC::DFG::GeneralizedRegister::createFPR):
(JSC::DFG::GeneralizedRegister::dump):
(JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
(JSC::DFG::GeneralizedRegister::findInEntryLocation):
(JSC::DFG::GeneralizedRegister::previousDataFormat):
(JSC::DFG::GeneralizedRegister::nextDataFormat):
(JSC::DFG::GeneralizedRegister::convert):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::ShuffledRegister):
(JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::ShuffledRegister::lookup):
(JSC::DFG::lookupForRegister):
(JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
(JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
(JSC::DFG::NodeToRegisterMap::set):
(JSC::DFG::NodeToRegisterMap::end):
(JSC::DFG::NodeToRegisterMap::find):
(JSC::DFG::NodeToRegisterMap::clear):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::linkSpeculationChecks):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):

  • dfg/DFGSpeculativeJIT.h:
17:53 Changeset [91803] by kbr@google.com

Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
17:25 Changeset [91802] by crogers@google.com

V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222

Reviewed by James Robinson.

No new tests - this fixes upcoming audionode.html layout test

  • bindings/v8/custom/V8AudioNodeCustom.cpp:

(WebCore::V8AudioNode::connectCallback):

17:15 Changeset [91801] by crogers@google.com

AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lazyInitialize):

17:14 Changeset [91800] by macpherson@chromium.org

Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=65164

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

Add casts to/from various numeric types.
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator float):

  • css/CSSStyleApplyProperty.cpp:

Add class to handle properties that set an "auto" boolean on RenderStyle.
(WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Remove existing implementations.
(WebCore::CSSStyleSelector::applyProperty):

16:43 Changeset [91799] by psolanki@apple.com

Add protection space authentication callback code to CFNetwork loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=65190
<rdar://problem/9842424>

Reviewed by Oliver Hunt.

Port over protection space authentication callback code from ResourceHandleMac.mm to
ResourceHandleCFNet.cpp.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::canRespondToProtectionSpace):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.

16:30 Changeset [91798] by enne@google.com

[chromium] Check in expectations for font-family-pictograph.
https://bugs.webkit.org/show_bug.cgi?id=65197

Unreviewed gardening.

  • platform/chromium-linux/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-linux/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.txt: Added.
16:25 Changeset [91797] by abarth@webkit.org

Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL. The author can also supply a
suggested file name in the attribute value. This feature is a recent
addition to HTML to better support offline applications that use blob
URLs. Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event. This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html

fast/dom/HTMLAnchorElement/anchor-nodownload.html
fast/dom/HTMLAnchorElement/anchor-download-unset.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAttributeNames.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::startDownload):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::loadURLExternally):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::startDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::startDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::startDownload):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::startDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::startDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::startDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::startDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::loadURLExternally):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.
16:18 Changeset [91796] by enne@google.com

[chromium] Mark webaudio/test-basic as crashing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=65219.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
15:47 Changeset [91795] by oliver@apple.com

Buffer overflow creating error messages for JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=65211

Reviewed by Darin Adler.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Update testcase to reflect actual expected output.

  • fast/js/JSON-parse-expected.txt:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Parse string length to the UString constructor.

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::parse):

15:23 Changeset [91794] by mitz@apple.com

Rubber-stamped by Anders Carlsson.

Update DumpRenderTree and API tests for the pictograph font family preference.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

15:08 Changeset [91793] by commit-queue@webkit.org

Apply r40940 to WebKit2 to work around a Silverlight crash.
https://bugs.webkit.org/show_bug.cgi?id=65205
<rdar://problem/9058370>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-26
Reviewed by Anders Carlsson.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

15:07 Changeset [91792] by dglazkov@chromium.org

Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with

test configuration matching, removed a bunch of code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance

was created. 'default' is not a valid build type.

  • Scripts/webkitpy/layout_tests/port/test.py: Ditto. is not a valid version.
15:04 Changeset [91791] by abarth@webkit.org

Increase the information density in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65141

Reviewed by Dimitri Glazkov.

This patch changes lets us show each revision on a single line,
allowing use to show an entire day's worth of commits at once.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
14:56 Changeset [91790] by commit-queue@webkit.org

Refactor automatically generated JS DOM bindings to replace operator new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Replacing the public constructors in the automatically generated JS DOM bindings with static
create methods. JSByteArray is used by several of these bindings in WebCore.

(JSC::JSByteArray::create):

  • runtime/JSByteArray.h:

Source/WebCore:

No new tests.

Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
with static create methods. This is part of a larger refactoring effort to use static create methods
in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.

  • bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::create):

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::create):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListener::createPrototype):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):

  • bridge/jni/jsc/JavaArrayJSC.cpp:

(JavaArray::convertJObjectToArray):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::newRuntimeObject):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

14:52 Changeset [91789] by brettw@chromium.org

Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

14:51 Changeset [91788] by xji@chromium.org

--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace Position(node, offset, PositionIsOffsetInAnchor) with
createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position
before/after <br/> etc. editingIgnoresContent node.

When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns
InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns
InlineBox across multiple lines).

  • editing/htmlediting.cpp:

(WebCore::createPositionAvoidingIgnoredNode):

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
createPositionAvoidingIgnoredNode().
(WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
(WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
(WebCore::blockWithPreviousLineBox): Added.
(WebCore::previousRootInlineBox): Added.
(WebCore::blockWithNextLineBox): Added.
(WebCore::nextRootInlineBox): Added.
(WebCore::leftInlineBox): Added.
(WebCore::rightInlineBox): Added.
(WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
and rightInlineBox().
(WebCore::rightWordBoundary): Ditto.
(WebCore::leftWordPositionAcrossBoundary): Ditto.
(WebCore::rightWordPositionAcrossBoundary): Ditto.

LayoutTests:

Add test for multiple-line.

  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html: Add tests for multi-line. Shorten

test id.

  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Shorten test id.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordForEveryPosition):
(setWidth):
(runMoveLeftRight):

14:49 Changeset [91787] by alexis.menard@openbossa.org

Unreviewed build fix for Qt/Linux.

On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to http://trac.webkit.org/changeset/91752.

  • wtf/wtf.pri:
14:44 Changeset [91786] by dglazkov@chromium.org

TestConfigurationConverter should not barf on invalid specifiers.
https://bugs.webkit.org/show_bug.cgi?id=65194

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,

made it return empty set whenever an invalid specifier is encountered.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
14:42 Changeset [91785] by dglazkov@chromium.org

Introduce a way to convert between specifier lists and TestConfiguration sets.
https://bugs.webkit.org/show_bug.cgi?id=65094

Add TestConfigurationConverter, a facility to convert:
1) a set of specifiers into a set of TestConfiguration instances;
2) a set of TestConfiguration instances into a list of sets of specifiers.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
14:37 Changeset [91784] by kerz@chromium.org

Merge 91720 - [Chromium] Use correct vertex shader when rendering video layer.
https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7477025

14:26 Changeset [91783] by kerz@chromium.org

add codereview settings file for chromium 835 branch

14:17 Changeset [91782] by commit-queue@webkit.org

CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
https://bugs.webkit.org/show_bug.cgi?id=65171

Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:39 Changeset [91781] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=60778

Use after free because of line box culling optimization regression.

In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.

The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.

The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.

Reviewed by Dan Bernstein.

Added editing/execCommand/crash-line-break-after-outdent.html

Source/WebCore:

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

  • editing/execCommand/crash-line-break-after-outdent-expected.txt: Added.
  • editing/execCommand/crash-line-break-after-outdent.html: Added.
13:36 Changeset [91780] by crogers@google.com

Add first basic layout test for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=57977

Reviewed by Tony Chang.

  • webaudio: Added.
  • webaudio/resources: Added.
  • webaudio/resources/audio-testing.js: Added.

(writeString):
(writeInt16):
(writeInt32):
(writeAudioBuffer):
(createWaveFileData):
(createAudioData):
(finishAudioTest):

  • webaudio/test-basic-expected.wav: Added.
  • webaudio/test-basic.html: Added.
13:28 Changeset [91779] by crogers@google.com

Avoid outputting #EOF twice for web audio tests in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=65201

Reviewed by Dirk Pranke.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

13:27 Changeset [91778] by mitz@apple.com

Fix change log typos

13:23 Changeset [91777] by mitz@apple.com

Source/WebCore: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

Test: fast/css/font-family-pictograph.html

  • WebCore.exp.in: Export Settings::setPictographFontFamily().
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily): Added -webkit-pictograph.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::fontDataForGenericFamily): Ditto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Ditto.

  • css/CSSValueKeywords.in:
  • inspector/front-end/CSSKeywordCompletions.js: Ditto.
  • inspector/front-end/SourceCSSTokenizer.js: Ditto.

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
  • page/Settings.cpp:

(WebCore::Settings::pictographFontFamily): Added this getter.
(WebCore::Settings::setPictographFontFamily): Added this setter.

  • page/Settings.h:
  • platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.

Source/WebKit/mac: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set the default pictograph font family to
"Apple Color Emoji".
(-[WebPreferences pictographFontFamily]): Added this getter.
(-[WebPreferences setPictographFontFamily:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Pass the preference through to WebCore.

Source/WebKit/win: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Interfaces/IWebPreferences.idl: Added pictographFontFamily() and

setPictographFontFamily().

  • WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize the pictograph font
preference to "Times New Roman".
(WebPreferences::pictographFontFamily): Added this getter.
(WebPreferences::setPictographFontFamily): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Pass the preference value through to
WebCore.

Source/WebKit2: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPictographFontFamily): Added.
(WKPreferencesCopyPictographFontFamily): Added.

  • UIProcess/API/C/WKPreferences.h:

LayoutTests: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • fast/css/font-family-pictograph.html: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.txt: Added.
12:54 Changeset [91776] by cevans@google.com

Merge 91689
BUG=88723
Review URL: http://codereview.chromium.org/7470026

12:48 Changeset [91775] by enne@google.com

[chromium] getClientRects now fails similarly on Mac after r91763.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:37 Changeset [91774] by commit-queue@webkit.org

Improve (i.e., speed up) .gyp(i) files for Chromium
https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

This re-applies r91595 with the source exclusion fixed.

Test by building (in all supported configurations).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:26 Changeset [91773] by enne@google.com

[chromium] Fix accidental duplicate expectation from r91772.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:22 Changeset [91772] by enne@google.com

[chromium] Mark test as flaky after r91738.
https://bugs.webkit.org/show_bug.cgi?id=65199

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:14 Changeset [91771] by alexis.menard@openbossa.org

[Qt] Disable video support on linux if the dependencies are not found.

If we can't find the necessary dependencies to build the GStreamer media player
we disable the video support. This is related to http://trac.webkit.org/changeset/91752.

Reviewed by Holger Freyther.

No new tests, it's a build fix.

  • features.pri:
12:13 Changeset [91770] by evan@chromium.org

regression: generating CSSValueKeywords should not print by default
https://bugs.webkit.org/show_bug.cgi?id=65195

Reviewed by Tony Chang.

Some refactoring made some callers no longer pass the final 'beQuiet'
parameter to applyPreprocessor. This flag was only used to print the
input filename anyway, so remove the flag and just make the caller
print the filename if it wants this.

  • bindings/scripts/IDLParser.pm:

(Parse): print before calling applyPreprocessor, if necessary.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): remove the beQuiet flag; just always be quiet.

12:03 Changeset [91769] by commit-queue@webkit.org

[EFL] Do not crash on the isSlider() assert.
https://bugs.webkit.org/show_bug.cgi?id=65191

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-26
Reviewed by Antonio Gomes.

RenderThemeEfl's paintSliderThumb() just forwarded the call to
paintSliderTrack(), which, on its turn, called code that assumed that
object->isSlider() was true. That does not seem to be the case for
slidethumbs, so any page with an <input type="range"> tag would crash
WebKit.

We now do what RenderThemeQt does, and assume everything was properly
done in the call to paintSliderTrack().

No new tests, as this has been uncovered by an existing test.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintSliderThumb):

11:53 Changeset [91768] by commit-queue@webkit.org

[SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
https://bugs.webkit.org/show_bug.cgi?id=65182

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-26
Reviewed by Stephen White.

No new tests. Not sure how to test wrong-ctx bugs in layout tests.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

11:17 Changeset [91767] by enne@google.com

[chromium] More flaky crashers.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:09 Changeset [91766] by abecsi@webkit.org

.: [Qt] [WK2] Disable the build with Qt versions older than 5.0
https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Source/WebKit.pro: Abort if not using Qt5.

Source/WebKit2: [Qt] [WK2] Disable the build with Qt versions older than 5.0
https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Platform/qt/ModuleQt.cpp:

(WebKit::Module::platformFunctionPointer): Fix the build for Qt5.

10:53 Changeset [91765] by commit-queue@webkit.org

JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
10:53 Changeset [91764] by kerz@chromium.org

Branch webkit for chromium

10:47 Changeset [91763] by eae@chromium.org

RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code
https://bugs.webkit.org/show_bug.cgi?id=62478

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dom/Range/getClientRects.html

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::isZero):
Add izZero method, unlike isEmpty this checks if both the width and the
height are zero.

  • rendering/RenderText.cpp:

(WebCore::absoluteQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
Break duplicate code out of absoluteRectsForRange and
absoluteQuadsForRange into shared static function.

Fix what I presume to be a bug in the absoluteQuadsForRange where the
logicalHeight was always used to set the size in absoluteQuadForTextBox
as oppsued to the absoluteRectsForRange implementation that uses the
logicalWidth or the logicalHeight depending on whether it's horizontal or
vertical.

LayoutTests:

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

Add test for vertical text.

10:37 Changeset [91762] by abarth@webkit.org

Windows bots on build.chromium.org can't figure out the head_svn_revision
https://bugs.webkit.org/show_bug.cgi?id=65156

Reviewed by Tony Chang.

This patch is a bit of a guess as to the issue based on the
investigation in https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
not sure whether it will fix the issue, but it seems worth a try.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
10:32 Changeset [91761] by enne@google.com

[chromium] Mark media-controls-clone as flaky crashing on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=65129

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [91760] by commit-queue@webkit.org

[CSSRegions] Collect flowed elements in different render element
https://bugs.webkit.org/show_bug.cgi?id=64516

Source/WebCore:

All the RenderObjects that have a specified "flow" name are moved out of the
normal flow. A RenderFlowThread will collect all such RenderObjects. There is
a RenderFlowThread for each flow name. The new RenderFlowThread is an anonymous
RenderBlock that is positioned absolute and will not render directly. In a
different bug/patch we will add RenderRegion that will take care of rendering the
RenderFlowThread on screen.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Simon Fraser.

Tests: fast/regions/webkit-flow-renderer-layer.html

fast/regions/webkit-flow-renderer-nested.html
fast/regions/webkit-flow-renderer.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::hasFlowThreadParent):
(WebCore::NodeRenderingContext::parentFlowRenderer):

  • rendering/RenderFlowThread.cpp: Added.

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addChild):
(WebCore::RenderFlowThread::removeChild):

  • rendering/RenderFlowThread.h: Added.

(WebCore::toRenderFlowThread):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFlowThread):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Simon Fraser.

  • fast/regions/webkit-flow-renderer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer.html: Added.
  • fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-nested.html: Added.
  • fast/regions/webkit-flow-renderer.html: Added.
10:08 Changeset [91759] by commit-queue@webkit.org

Source/WebCore: Filename text in file upload controls is not aligned with button text on
chromium-linux, chromium-win, and gtk.

https://bugs.webkit.org/show_bug.cgi?id=64692

The fix is to not include the margin, border, and padding in the calculation,
because those are already accounted for by RenderBlock::baselinePosition().

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests: In file upload controls, filename text was misaligned with button text.
Update chromium-linux with the new baseline images, and add temporary
exceptions for chromium-win and gtk until they can be rebaselined.

https://bugs.webkit.org/show_bug.cgi?id=64692

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
09:56 Changeset [91758] by benjamin.poulain@nokia.com

[Qt][WK2] Make the WebContextMenuProxyQt handle the full interactions between the views and the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=64739

Reviewed by Andreas Kling.

Change the WebContextMenuProxyQt to be the intermediary between the WebPageProxy and our views regarding
the context menu.

The actions of the context menu are no longer the responsibility of QtWebPageProxy but are instead
created and handled directly by the WebContextMenuProxyQt.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::actionTriggered):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
09:22 Changeset [91757] by pfeldman@chromium.org

2011-07-26 Pavel Feldman <pfeldman@google.com>

Not reviewed: inspector test rebaselines.

  • inspector/console/console-format-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Copied from LayoutTests/inspector/runtime/runtime-getProperties-expected.txt.
07:58 Changeset [91756] by commit-queue@webkit.org

Unreviewed, rolling out r91746.
http://trac.webkit.org/changeset/91746
https://bugs.webkit.org/show_bug.cgi?id=65180

It broke SL build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/JavaScriptCore:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):
(WTF::StringImpl::simplifyWhiteSpace):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

Source/WebCore:

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

LayoutTests:

  • fast/forms/option-strip-unicode-spaces-expected.txt: Removed.
  • fast/forms/option-strip-unicode-spaces.html: Removed.
07:55 Changeset [91755] by commit-queue@webkit.org

[GTK] Remove header webkitwebviewcommon.h
https://bugs.webkit.org/show_bug.cgi?id=65177

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-07-26
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Move webkitwebviewcommon.h contents back to webkitwebview.h.

  • GNUmakefile.am: Remove webkitwebviewcommon.h
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewcommon.h: Removed.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.h: Add function prototypes

instead of including webkitwebviewcommon.h.

07:44 Changeset [91754] by pfeldman@chromium.org

Web Inspector: Better represent custom getters in the properties pane
https://bugs.webkit.org/show_bug.cgi?id=16734

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-getProperties.html

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

LayoutTests:

  • inspector/runtime/runtime-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-getProperties.html: Added.
07:16 Changeset [91753] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/fast/css/font-face-opentype-expected.png: Added.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated after r91738.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png: Updated after r91748.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt: Updated after r91748.
06:34 Changeset [91752] by abecsi@webkit.org

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-07-26
Reviewed by Andreas Kling.

[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
https://bugs.webkit.org/show_bug.cgi?id=63472

Source/JavaScriptCore:

Enable the bits needed for GStreamer only when QtMultimedia is not used.

  • wtf/wtf.pri:

Source/WebCore:

Enable the GStreamer backend and the QuickTime backend as default media players
for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.

No new tests. The media layout tests are disabled on the Qt port but hopefully with this
switch we can enable them again.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:

Source/WebKit/qt:

Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
exist anymore, it's the default. Ditto for GStreamer.

05:16 Changeset [91751] by carlosgc@webkit.org

2011-07-26 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: (getPreferredSizeMethod):
05:01 QtWebKitBuildBots edited by zecke@selfish.org
(diff)
04:44 QtWebKitBuildBots edited by zecke@selfish.org
(diff)
04:36 QtWebKitBuildBots edited by ossy@webkit.org
Add MIPS bot, update obsolete infos of obsolete bots (diff)
04:20 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on Snow Leopard bots (diff)
04:17 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.7.x QtWebKit2.2 bot and on 4.8 trunk … (diff)
03:20 Changeset [91750] by pfeldman@chromium.org

Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=65112

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-setPropertyValue.html

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt: Added.
  • inspector/runtime/runtime-setPropertyValue.html: Added.
03:09 Changeset [91749] by pfeldman@chromium.org

2011-07-26 Pavel Feldman <pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

https://bugs.webkit.org/show_bug.cgi?id=65103
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionOn):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::callFunctionOn):
  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.prototype.get subtype): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype.get type): (WebInspector.LocalJSONObject.prototype.get subtype):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.inspect):

2011-07-26 Pavel Feldman <pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

https://bugs.webkit.org/show_bug.cgi?id=65103
https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
03:05 Changeset [91748] by zimmermann@webkit.org

2011-07-26 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare animVal support - phase 2
https://bugs.webkit.org/show_bug.cgi?id=65167

Reviewed by Dirk Schulze.

Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.

Doesn't affect any tests, yet.

  • svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added). (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPathSegWithContext.h: Ditto. (WebCore::SVGPathSegWithContext::animatedProperty):
  • svg/SVGPolyElement.cpp: Ditto. (WebCore::SVGPolyElement::parseMappedAttribute):
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type. (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not. (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS. (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper. (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
  • svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff. (WebCore::SVGAnimatedPropertyTearOff::isAnimating): (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue): (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating): (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::updateAnimVal):
02:39 Changeset [91747] by hans@chromium.org

Update another test that relied on fonts loading synchronously.
https://bugs.webkit.org/show_bug.cgi?id=65169

Not Reviewed, tests fix.

  • platform/chromium-linux/fast/text/international/arabic-vertical-offset.html:
02:10 Changeset [91746] by commit-queue@webkit.org

Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):

Added an interface to take IsWhiteSpaceFunctionPtr.

(WTF::StringImpl::simplifyWhiteSpace): ditto.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.

  • wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • fast/forms/option-strip-unicode-spaces-expected.txt: Added.
  • fast/forms/option-strip-unicode-spaces.html: Added.
00:17 Changeset [91745] by morrita@google.com

[Chromium][DRT] MockSpellCheck.cpp should be clang clean
https://bugs.webkit.org/show_bug.cgi?id=65166

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord): -Wsign-compare warning.

00:05 Changeset [91744] by commit-queue@webkit.org

Add regression test for :empty { display: none }
https://bugs.webkit.org/show_bug.cgi?id=26570

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-26
Reviewed by Alexey Proskuryakov.

  • fast/css/pseudo-empty-display-none-expected.txt: Added.
  • fast/css/pseudo-empty-display-none.html: Added.
Note: See TracTimeline for information about the timeline view.