Timeline


and

08/01/11:

20:47 Changeset [92166] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic should call optimize-baselines when rebaselining tests
https://bugs.webkit.org/show_bug.cgi?id=65499

Reviewed by Dimitri Glazkov.

I took the opportunity to modernize this code to use some of our more
powerful primitives from base.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
20:09 Changeset [92165] by andersca@apple.com
  • 5 edits in trunk/LayoutTests

Update Lion specific test results.

  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
18:42 Changeset [92164] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Don't set m_fontDirty when setting zoom unless zoom has actually changed
https://bugs.webkit.org/show_bug.cgi?id=65092

Reviewed by Darin Adler.

No new tests as no functionality changed - this is an optimization that
should be logically equivalent to the current code.

The intent here is to avoid setting m_fontDirty unless the fornt information is actually dirty.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
Use setZoom and setEffectiveZoom wrapper functions.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setZoom):
Wrapper for m_style->setZoom() that automatically updates m_fontDirty.
(WebCore::CSSStyleSelector::setEffectiveZoom):
Wrapper for m_style->setEffectiveZoom that automatically updates m_fontDirty.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::ensurePropertyMap):
Use

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setZoom):
Return true only if underlying values change.
(WebCore::InheritedFlags::setZoomWithoutReturnValue):
Return void to match function pointer type where required.
(WebCore::InheritedFlags::setEffectiveZoom):
Return true only if underlying values change.

18:37 Changeset [92163] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline test results for recently added test.

  • platform/chromium-linux/svg/custom/repaint-shadow-expected.png: Added.
  • platform/qt/svg/custom/repaint-shadow-expected.txt: Added.
18:23 Changeset [92162] by zmo@google.com
  • 37 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rebaseline, webkit gardener stuff.

  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
18:20 Changeset [92161] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Removing old source files in gyp files that slow build
https://bugs.webkit.org/show_bug.cgi?id=65503

Patch by Jean-luc Brouillet <jeanluc@chromium.org> on 2011-08-01
Reviewed by Adam Barth.

A number of stale files are listed in the gyp files. These slow the
build on Visual Studio 2010. Removing them.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
18:16 Changeset [92160] by slewis@apple.com
  • 4 edits in trunk/Tools

Finish reconfiguration started by Lucas Forschler
Reconfigured slaves:
Removed Leopard Intel Release (Build)
Removed Leopard Intel Release (Tests)
Remove apple-pixel-1
Added Lion slaves from disabled Leopard slaves

Added builders:
Lion Intel Release (Build)
Lion Intel Debug (Build)
Lion Intel Release (Tests)
Lion Intel Release WK2 (Tests)
Lion Intel Debug (Tests)
Lion Intel Debug WK2 (Tests)

Added triggers:
lion-intel-debug-tests
lion-intel-debug-test-wk2
lion-intel-release-tests
lion-intel-release-tests-wk2

Removed trigger:
leopard-intel-release-tests

Added PlatformSpecificScheduler:
mac-lion

Added "mac-lion" to build.py and build_unitttest.py

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
17:59 Changeset [92159] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Shard webcore_remaining for msvs official builds

https://bugs.webkit.org/show_bug.cgi?id=65475

Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.

webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

  • WebCore.gyp/WebCore.gyp:
17:51 Changeset [92158] by commit-queue@webkit.org
  • 6 edits in trunk

WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
https://bugs.webkit.org/show_bug.cgi?id=65451

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-01
Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

LayoutTests:

  • accessibility/aria-roles.html:
  • platform/mac/accessibility/aria-multiline.html:
  • platform/mac/accessibility/aria-roles-expected.txt:
17:49 Changeset [92157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use threadsafeCopy() API when using Database Directory path variable
https://bugs.webkit.org/show_bug.cgi?id=65436

Patch by srikumar bonda <srikumar.b@gmail.com> on 2011-08-01
Reviewed by David Levin.

Use threadsafeCopy() API while using m_databaseDirectoryPath string variable
when the databaseGuard lock hasn't been taken in DatabaseTracker class.
This is just a safety fix.

No changes to functionality so no new tests.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::deleteOrigin):

17:44 Changeset [92156] by zmo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline, webkit gardener stuff.

  • platform/chromium-mac/svg/custom/repaint-shadow-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-shadow-expected.png: Added.
17:21 Changeset [92155] by michaeln@google.com
  • 11 edits in trunk/Source/WebCore

[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486

The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.

Reviewed by Darin Fisher.

No new tests. Existing layout tests cover the version handling functionality.

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::expectedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):

  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):

  • storage/SQLTransactionSync.h:
17:10 Changeset [92154] by levin@chromium.org
  • 4 edits in trunk/Source/JavaScriptCore

currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

17:07 Changeset [92153] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/Tools

webkit-patch needs to be able to "optimize" the storage of baselines on disk
https://bugs.webkit.org/show_bug.cgi?id=65418

Reviewed by Dimitri Glazkov.

If we're not careful when rebaselining tests, we can end up with lots
of duplicate expected results files in the tree. This patch adds a
webkit-patch command that optimizes the storage of expected results on
disk.

This command is similar to deduplicate-tests, except that it can move
test results around rather than just remove duplicate results.

Unfortunately, this problem is very tricky because the baseline search
structure is a hypergraph. This patch include a huerstic optimizer
that appears to work on a bunch of examples I've tried. We'll likely
need to refine it as gain experience.

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:49 Changeset [92152] by timothy_horton@apple.com
  • 5 edits
    3 adds in trunk

Severe shadow repaint issues with SVGText elements
https://bugs.webkit.org/show_bug.cgi?id=63648
<rdar://problem/7632269>

Reviewed by Darin Adler.

Make SVG elements which inherit from RenderSVGBlock take text-shadow
overflow into account when determining whether or not they should draw

Test: svg/custom/repaint-shadow.svg

  • rendering/RenderBox.h:

(WebCore::RenderBox::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.h:
16:25 Changeset [92151] by crogers@google.com
  • 2 edits in trunk/LayoutTests

One more test_expectations.txt fix for windows web audio
https://bugs.webkit.org/show_bug.cgi?id=65496

Unreviewed.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [92150] by zmo@google.com
  • 9 edits in trunk

Unreviewed, rolling out r92022.
http://trac.webkit.org/changeset/92022
https://bugs.webkit.org/show_bug.cgi?id=65203

try to see if this is causing a bunch of browser tests failues
on win bots - will recommit if not

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:45 Changeset [92149] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove time out expectation since media/track has been added to the skipped list on Qt.

  • platform/qt/test_expectations.txt:
15:32 Changeset [92148] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT sometimes creates speculation check data structures that have
invalid information about the format of a register
https://bugs.webkit.org/show_bug.cgi?id=65490

Reviewed by Gavin Barraclough.

The code now makes sure to (1) always have correct and up-to-date
information about register format at the time that a speculation
check is emitted, (2) assert that speculation data is correct
inside the speculation check implementation, and (3) avoid creating
speculation data altogether if compilation has already failed, since
at that point the format data is almost guaranteed to be bogus.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

15:22 Changeset [92147] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

Teach TestExpectationSerializer about parsed expectations.
https://bugs.webkit.org/show_bug.cgi?id=65444

This is a bit largish in size, but the essentials are:

  • TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
  • We now store original content of the expectation line on TestExpectationLine.
  • Lots of tests.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't

populate macros correctly, also fixed an issue where we incorrectly returned an empty list
for all configurations.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,

refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
changed to store and use TestExpectationLine.original_string.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
15:09 Changeset [92146] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r92092): Build fails on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=65458

Reviewed by Oliver Hunt.

The build was broken because some compilers were smart enough to see
an array index out of bounds due to the decision fuction for when to
go from precise size classes to imprecise size classes being broken:
it would assume that sizes in the range 97..128 belonged to a precise
size class when in fact they belonged to an imprecise one.

In fact, the code would have run correctly, by way of a fluke, because
though the 4th precise size class (for 97..128) didn't exist, the next
array over from m_preciseSizeClasses was m_impreciseSizeClasses, and
its first entry would have been a size class that is appropriate for
allocations in the range 97..128. However, this relies on specific
ordering of fields in NewSpace, so it's still a bug.

This fixes the bug by ensuring that allocations larger than 96 use
the imprecise size classes.

  • heap/NewSpace.h:

(JSC::NewSpace::sizeClassFor):

14:46 Changeset [92145] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add null check to setSwapbuffersCompletCallbackChromium
https://bugs.webkit.org/show_bug.cgi?id=65485

Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::SwapBuffersCompleteCallbackAdapter::create):

14:41 Changeset [92144] by crogers@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add audionode.html and gain.html web audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65276

Reviewed by Kenneth Russell.

  • webaudio/audionode-expected.txt: Added.
  • webaudio/audionode.html: Added.
  • webaudio/gain-expected.wav: Added.
  • webaudio/gain.html: Added.
  • webaudio/resources/buffer-loader.js: Added.

(BufferLoader):
(BufferLoader.prototype.loadBuffer.request.onload):
(BufferLoader.prototype.loadBuffer.request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):

14:22 Changeset [92143] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk

.: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • Source/autotools/symbols.filter:

Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).

With this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load. Test added for crash discovered in
previous revision, but no tests for memory usage.

Test: http/tests/inspector/network/disabled-cache-crash.html

  • WebCore.exp.in:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasOneHandle):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

  • loader/cache/CachedResourceLoader.h:
  • testing/Internals.cpp:

(WebCore::Internals::disableMemoryCache):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006

Test for CachedResourceLoader. Not caused by cache-disabling but very
difficult to reproduce when cache is active, so use cache disable in
inspector to exercise code.

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

  • http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
  • http/tests/inspector/network/disabled-cache-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:18 Changeset [92142] by jochen@chromium.org
  • 5 edits
    7 adds in trunk

Source/WebCore: Never override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809

Reviewed by Adam Barth.

Tests: http/tests/security/cookies/third-party-cookie-blocking-main-frame.html

http/tests/security/cookies/third-party-cookie-blocking-user-action.html
http/tests/security/cookies/third-party-cookie-blocking.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addExtraFieldsToSubresourceRequest):
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/FrameLoader.h:

LayoutTests: Require explicit user action to override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809

Reviewed by Adam Barth.

  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/security/cookies/resources/set-a-cookie.php: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-main-frame-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-main-frame.html: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-user-action-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-user-action.html: Added.
  • http/tests/security/cookies/third-party-cookie-blocking.html: Added.
14:16 Changeset [92141] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

media/track tests should be skipped on all platforms until feature is fully implemented.
https://bugs.webkit.org/show_bug.cgi?id=65482

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-01
Reviewed by Ryosuke Niwa.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:10 Changeset [92140] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Update comment added in r92139 per Darin's suggestion.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):

14:08 Changeset [92139] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Search field in designMode causes a crash
https://bugs.webkit.org/show_bug.cgi?id=65362

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crashed was caused by editing code inadvertently deleting search and cancel buttons in the design mode.
Fixed the bug by avoid inheriting user-modify property from the shadow host.

Test: editing/input/search-field-crash-in-designmode.html

  • css/CSSStyleSelector.cpp:

(WebCore::isAtShadowBoundary): Moved.
(WebCore::CSSStyleSelector::styleForElement): Overrides -webkit-user-modify by the initial value after m_style
inherited the values from m_parentStyle but before applying matched rules.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable): Ignore page's editability inside a shadow DOM.

LayoutTests:

Add a test to ensure WebKit doesn't crash when a user tries to delete inside
an empty search field in the design mode.

  • editing/input/search-field-crash-in-designmode-expected.txt: Added.
  • editing/input/search-field-crash-in-designmode.html: Added.
13:40 Changeset [92138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Set default max-conns to a more sane default value and fix comment
https://bugs.webkit.org/show_bug.cgi?id=65335

Patch by Marco Peereboom <marco@peereboom.us> on 2011-08-01
Reviewed by Martin Robinson.

Rigged the xxxterm web browser and validated that the default values were set properly.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

13:39 Changeset [92137] by abarth@webkit.org
  • 3 edits in trunk/Tools

Remove unused functionality from gardeningserver
https://bugs.webkit.org/show_bug.cgi?id=65479

Reviewed by Dimitri Glazkov.

We now handle these operations directly from the front-end. That means
they work even without the gardening server running!

Also, add some missing files to the list of static files.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
12:55 Changeset [92136] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
https://bugs.webkit.org/show_bug.cgi?id=65413

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted

existing code to use it.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
12:25 Changeset [92135] by abarth@webkit.org
  • 14 edits in trunk/Tools

Refactor bugzilla.js for use by garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65450

Reviewed by Dimitri Glazkov.

This patch refactors bugzilla.js to use the AsynchronousCache and
updates the style to use a module instead of an object. This patch
then fixes all the existing code that uses this class to use the new
API style.

This main benefit of this patch is we remove the tricky manual caching
and this code is now available to use in garden-o-matic (since the
dependency on Utilities.js is now gone).

I ran all the unit tests and poked around in TestFailures a bit to see
that everything seemed to be working properly.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

(FailingTestsBugForm):
(FailingTestsBugForm.prototype._createBugTitle):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:

(FlakyTestBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:

(NewBugForm):
(NewBugForm.prototype.domElement):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:

(TestRelatedBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
(ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
(ViewController.prototype._domForPossiblyFlakyTests):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
12:23 Changeset [92134] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

garden-o-matic shouldn't require local server to determine if compile failed
https://bugs.webkit.org/show_bug.cgi?id=65446

Reviewed by Dimitri Glazkov.

This patch adds some basic bindings for the buildbot JSON API. I
wanted to use Buildbot.js an Builder.js from the original TestFailures,
but they make a number of WebKit-specific assumptions. We'll
eventually need to reconcile these pieces of code.

I should really add tests for this code, but that will require me to
build a better mock network. I'll be happy to do that in a follow-up
patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
    • It's very unclear to me whether didFail is correct. Supposedly the first entry here is the exit code of the step, which is 0 on success. I suspect we'll need to improve this function over time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
11:45 Changeset [92133] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should show all failures, even ones that it can't find a regression range for
https://bugs.webkit.org/show_bug.cgi?id=65447

Reviewed by Dimitri Glazkov.

Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page). This patch just displays them at the end of the list,
which is slightly (but not much) better.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
11:03 Changeset [92132] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Regression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
https://bugs.webkit.org/show_bug.cgi?id=65137

Source/WebCore:

Fix the looping condition to prevent trailingSpaceMidpoint from becoming negative.

Reviewed by Dave Hyatt.

Test: fast/block/update-midpoints-for-trailing-boxes-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):

LayoutTests:

ASSERTION FAILED: trailingSpaceMidpoint >= 0

Reviewed by Dave Hyatt.

  • fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt: Added.
  • fast/block/update-midpoints-for-trailing-boxes-crash.html: Added.
09:51 Changeset [92131] by ossy@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r92127.

  • platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
  • platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/qt-4.8/editing/selection/4397952-expected.png: Added.
  • platform/qt-4.8/editing/selection/4397952-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
09:10 Changeset [92130] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] OpenGLShims does not build on ARM
https://bugs.webkit.org/show_bug.cgi?id=65465

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-01
Reviewed by Noam Rosenthal.

Fix the build with OpenGL ES 2:
-lookupOpenGLFunctionAddress() was defined but not used for OpenGL ES.
-glBlitFramebuffer() and glRenderbufferStorageMultisample() are not part of the specification.
When those are available as platform extension, the extension has been added.
-GLchar is not defined on some platform. The patch adds the same typedef as the official definition
to avoid conflicts.

  • platform/graphics/cairo/OpenGLShims.cpp:

(lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):

  • platform/graphics/cairo/OpenGLShims.h:
09:09 Changeset [92129] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/forms/selection-direction.html to the Skipped list.

  • platform/wk2/Skipped:
09:02 Changeset [92128] by jeffm@apple.com
  • 3 edits in trunk/Tools

Windows build fix after r92096.

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
09:01 Changeset [92127] by ossy@webkit.org
  • 105 edits
    112 adds in trunk/LayoutTests

[Qt] Update expected results and unskip now passing tests.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/css2.1/ [...]: Updated.
  • platform/qt/editing/ [...]: Updated.
06:47 Changeset [92126] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-08-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test that was just added.

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/test_expectations.txt:
05:45 Changeset [92125] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Trivial fix for inspector/debugger/debugger-completions-on-call-frame.html after r92122.

  • inspector/front-end/ConsoleView.js:
05:25 Changeset [92124] by hayato@chromium.org
  • 11 edits
    4 adds in trunk

Add support for getting an element in shadow root by its id into a window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=64587

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::getElementByIdInShadowRoot):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
  • fast/dom/shadow/resources/create-dom.js: Added.

(createShadow):
(createDom):

04:53 Changeset [92123] by commit-queue@webkit.org
  • 7 edits in trunk

build: Fix finding the headers for GStreamer

The cmake files to find the various GStreamer packages were all
checking for the header gst/gst.h. However if gst-plugins-base is
installed into a separate prefix from gstreamer then all of these
tests would only pick up the gstreamer include path so the build
would fail. This patch changes it to try and find a file
appropriate to each package.

https://bugs.webkit.org/show_bug.cgi?id=64933

Patch by Neil Roberts <neil@linux.intel.com> on 2011-08-01
Reviewed by Martin Robinson.

  • Source/cmake/FindGStreamer-App.cmake:
  • Source/cmake/FindGStreamer-Base.cmake:
  • Source/cmake/FindGStreamer-Interfaces.cmake:
  • Source/cmake/FindGStreamer-Pbutils.cmake:
  • Source/cmake/FindGStreamer-Plugins-Base.cmake:
  • Source/cmake/FindGStreamer-Video.cmake:
04:42 Changeset [92122] by yurys@chromium.org
  • 11 edits
    3 adds in trunk

Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors
https://bugs.webkit.org/show_bug.cgi?id=65457

Source/WebCore:

Console completions are now done using evaluation which returns a JSON object with all property names rather than a remote
object. Also Runtime.evaluate and Runtime.callFunctionOn commands were extended with an optional parameter that allows to
get result as JSON value.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd-completions.html

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::asBool):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertySet):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector/console-cd-completions-expected.txt: Added.
  • http/tests/inspector/console-cd-completions.html: Added.
  • http/tests/inspector/resources/console-cd-completions-iframe.html: Added.
04:38 Changeset [92121] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/inspector/resource-tree/resource-tree-document-url.html occasionally times out
https://bugs.webkit.org/show_bug.cgi?id=65463

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
04:30 Changeset [92120] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/cache/history-only-cached-subresource-loads-max-age-https.html frequently times out on Vista
https://bugs.webkit.org/show_bug.cgi?id=65462

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
04:22 Changeset [92119] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Temporarily expect scripts-sorting.html to fail
https://bugs.webkit.org/show_bug.cgi?id=65461

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:18 Changeset [92118] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

BORDER attribute with the object tag, using percentage values not working.
https://bugs.webkit.org/show_bug.cgi?id=65176

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-01
Reviewed by Hajime Morita.

Source/WebCore:

When border presentational attribute for object element has % in it, it should be parsed using HTML parser rules.

Test: fast/borders/border-width-percent.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseBorderWidthAttribute):

  • html/HTMLElement.h:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Added the tests with border width with percentages in a new file. Moved them
from images border test file.

  • fast/borders/border-width-percent-expected.txt: Added.
  • fast/borders/border-width-percent.html: Added.
  • fast/images/border-expected.txt:
  • fast/images/script-tests/border.js:
04:16 Changeset [92117] by tonyg@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Update expectations for fast/text/international/bidi-mirror-he-ar.html
https://bugs.webkit.org/show_bug.cgi?id=65460

Unreviewed expectations update.

  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
04:16 Changeset [92116] by yutak@chromium.org
  • 8 edits in trunk/Source/WebCore

WebSocket: Receive URL and subprotocol in WebSocketChannel::connect()
https://bugs.webkit.org/show_bug.cgi?id=65367

Reviewed by Kent Tamura.

To implement multiple subprotocols support (bug 65247), WebSocket::connect() will need to validate
the value of subprotocols after constructing WebSocketChannel, because the result depends on which
WebSocket protocol is used, which is obtained from WebSocketChannel::useHixie76Protocol(). This
means the subprotocol value will not be available at the time of WebSocketChannel construction.

This change moves URL and subprotocol arguments in WebSocketChannel constructor to
WebSocketChannel::connect(), which allows WebSocket::connect() function to check the subprotocol
value before the actual connection is established.

Relocating URL argument is technically not necessary, but seemed legitimate in terms of functional
correspondence between WebSocket and WebSocketChannel (constructor versus connect()).

No change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.cpp:

Remove "url" and "protocol" arguments from constructor and add them in connect().
(WebCore::ThreadableWebSocketChannel::create):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • websockets/WebSocketChannel.cpp: Same as ThreadableWebSocketChannel.

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
InspectorInstrumentation::didCreateWebSocket() call was moved to connect() because it needs URL.
This does not change behavior, because connect() is guaranteed to be called immediately after
WebSocketChannel is constructed.

  • websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

  • websockets/WorkerThreadableWebSocketChannel.cpp: Same as ThreadableWebSocketChannel.

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::connect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):

  • websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Peer::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

03:19 Changeset [92115] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::loadHtml5Video() API test
https://bugs.webkit.org/show_bug.cgi?id=65452

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

  • tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail

(tst_QWebPage::loadHtml5Video):

03:18 Changeset [92114] by vsevik@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Web Inspector: Add network panel sidebar width test.
https://bugs.webkit.org/show_bug.cgi?id=65314

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network/network-sidebar-width-expected.txt: Added.
  • http/tests/inspector/network/network-sidebar-width.html: Added.
02:53 Changeset [92113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r92108.
http://trac.webkit.org/changeset/92108
https://bugs.webkit.org/show_bug.cgi?id=65459

breaks SL compile (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-01

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

02:36 Changeset [92112] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/resource-tree-reload.html is flaky on chromium win
https://bugs.webkit.org/show_bug.cgi?id=60110

Marking it flaky on Linux as well.

  • platform/chromium/test_expectations.txt:
02:05 Changeset [92111] by tonyg@chromium.org
  • 2 edits
    1 copy in trunk/LayoutTests

Fix windows text rendering expectations for fast/text/justify-ideograph-leading-expansion.html
https://bugs.webkit.org/show_bug.cgi?id=65455

Unreviewed expectations update.

  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png.
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
02:04 Changeset [92110] by ossy@webkit.org
  • 5 edits
    4 copies in trunk/LayoutTests

REGRESSION (r92048): svg/custom/external-paintserver-reference.svg, svg/custom/linking-base-external-reference.xhtml failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65432

Revert accidentally committed changes, and update Qt specific expected results.

  • platform/qt/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.png.
  • platform/qt/svg/custom/external-paintserver-reference-expected.txt: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.txt.
  • platform/qt/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.png.
  • platform/qt/svg/custom/linking-base-external-reference-expected.txt: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.txt.
  • svg/custom/external-paintserver-reference-expected.png: Revert r92048.
  • svg/custom/external-paintserver-reference-expected.txt: Revert r92048.
  • svg/custom/linking-base-external-reference-expected.png: Revert r92048.
  • svg/custom/linking-base-external-reference-expected.txt: Revert r92048.
01:57 Changeset [92109] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test that was just added.

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
01:49 Changeset [92108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-01
Reviewed by Darin Adler.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.

01:48 Changeset [92107] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/outline-auto-empty-rects.html broken by r92059
https://bugs.webkit.org/show_bug.cgi?id=65453

This patch just expects the test to fail for now.

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
01:31 Changeset [92106] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Add iterator to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=65297

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isLength):
Add shorthand to determine if this primitive value is a length.

  • css/CSSStyleSelector.cpp:

Use CSSValueListIterator throughout.
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::applyPageSizeProperty):
(WebCore::CSSStyleSelector::createTransformOperations):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::copy):
Use itemWithoutBoundsCheck() instead of item().

  • css/CSSValueList.h:

Add CSSValueListIterator and CSSValueListInspector class definitions.
(WebCore::CSSValueList::item)
Provide inline definition of item.
(WebCore::CSSValueListIterator::CSSValueListIterator):
(WebCore::CSSValueListIterator::hasMore):
Return true if there are more values to consume, including the current value.
(WebCore::CSSValueListIterator::value):
Return the value at the current position.
(WebCore::CSSValueListIterator::next):
Move the iterator forward to the next item.
(WebCore::CSSValueListIterator::index):
Return the current position in the list.
(WebCore::CSSValueListInspector::item):
Return the item at a given index.
(WebCore::CSSValueListInspector::first):
Return the first item in the list.
(WebCore::CSSValueListInspector::second):
Return the second item in the list.
(WebCore::CSSValueListInspector::length):
Return the size of the underlying list.

01:17 Changeset [92105] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: group scripts by folder in the scripts selector.
https://bugs.webkit.org/show_bug.cgi?id=65321

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/scripts-sorting.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-sorting-expected.txt: Added.
  • inspector/debugger/scripts-sorting.html: Added.
01:13 Changeset [92104] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
https://bugs.webkit.org/show_bug.cgi?id=65331

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:

(generateBackendFunction):
(generateArgumentGetters):

LayoutTests:

  • inspector/report-protocol-errors-expected.txt:
01:04 Changeset [92103] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

application/json MIME type shouldn't cause warnings in <script> tags
https://bugs.webkit.org/show_bug.cgi?id=65448

Reviewed by Pavel Feldman.

This patch stops the web inspector from logging a ton of spam warnings
when a web page uses a JSONP service (which points script tags at
application/json resources).

  • inspector/front-end/inspector.js:

(WebInspector.reset):

00:26 Changeset [92102] by yutak@chromium.org
  • 10 edits in trunk/Source

WebSocket: Rename SocketStreamHandleClient member functions
https://bugs.webkit.org/show_bug.cgi?id=65374

Reviewed by Kent Tamura.

Source/WebCore:

Rename SocketStreamHandleClient member functions to avoid conflict of the names of
FileReaderLoaderClient functions.

No change in behavior, thus no new tests are added.

  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::didOpenSocketStream):
(WebCore::SocketStreamHandleClient::didCloseSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData):
(WebCore::SocketStreamHandleClient::didFailSocketStream):

  • platform/network/brew/SocketStreamHandleBrew.cpp:

(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosed):
(WebCore::SocketStreamHandlePrivate::socketError):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::platformClose):

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosedCallback):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::resumeTimerFired):

  • websockets/WebSocketChannel.h:

Source/WebKit/chromium:

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):

07/31/11:

23:05 Changeset [92101] by abarth@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

These results appear to differ only in text rendering.

  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
22:36 Changeset [92100] by abarth@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Adding expected results. These results appear to differ only in the scrollbar.

  • platform/chromium-linux/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-linux/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.txt: Added.
  • platform/chromium-win/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-win/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/chromium-win/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-win/svg/custom/linking-base-external-reference-expected.txt: Added.
22:33 Changeset [92099] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline. This patch might cause Linux to start failing, but in
that case, we can add a more specific Linux result. This approach is
somewhat of an exploration of this automated rebaselining algorithm.

  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
21:25 Changeset [92098] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r92094.
http://trac.webkit.org/changeset/92094
https://bugs.webkit.org/show_bug.cgi?id=65443

Triggered many asserts (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-31

Source/WebCore:

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

LayoutTests:

  • fast/events/event-target-reset-expected.txt: Removed.
  • fast/events/event-target-reset.html: Removed.
21:17 Changeset [92097] by andersca@apple.com
  • 2 edits in trunk/Tools

DownloadDecideDestinationCrash WebKit2 API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=65442

Reviewed by Sam Weinig.

Copy the 18-characters.html file to the destination directory so we won't
crash trying to make an URL for it.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21:10 Changeset [92096] by andersca@apple.com
  • 2 adds in trunk/Tools/TestWebKitAPI

Add forgotten files.

20:32 Changeset [92095] by andersca@apple.com
  • 8 edits in trunk/Tools

Fix SpacebarScrolling WebKit2 API test
https://bugs.webkit.org/show_bug.cgi?id=65431

Reviewed by Sam Weinig.

Add a way to do platform-specific bundle initialization, and use it to disable smooth
scrolling. Also make it possible for a test to load the injected bundle without actually running
a test from it.

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
19:53 Changeset [92094] by dominicc@chromium.org
  • 3 edits
    2 adds in trunk

Event target set to null post event dispatch
https://bugs.webkit.org/show_bug.cgi?id=63934

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/event-target-reset.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Reset target to outermost
shadow host.

LayoutTests:

  • fast/events/event-target-reset-expected.txt: Added.
  • fast/events/event-target-reset.html: Added.
18:50 Changeset [92093] by barraclough@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Unreviewed - rolling out r91290.

Source/JavaScriptCore:

Looks like the wild wild web isn't ready for this yet.

This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling Array.prototype.slice as a part
of its bind implementation.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Checking in failing results - we can't fix this bug just yet
for web compatibility reasons.

  • fast/js/array-prototype-properties-expected.txt:
  • ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
16:48 Changeset [92092] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437

Reviewed by Oliver Hunt.

Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words. This is a 1% win on SunSpider.

  • heap/MarkedBlock.h:
16:17 Changeset [92091] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix fast/dom/Range/getBoundingClientRect.html after r92089.

  • fast/dom/Range/getBoundingClientRect.html:
14:14 Changeset [92090] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty-list-item.html are slow/timeout
https://bugs.webkit.org/show_bug.cgi?id=65019

This bug was invalid; neither test is slow nor timing out.

  • platform/chromium/test_expectations.txt:
14:05 Changeset [92089] by weinig@apple.com
  • 7 edits in trunk

REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update to more closely match the spec.

  • dom/Range.cpp:

(WebCore::Range::getClientRects):
Return an empty ClientRectList instead of null when the range is empty.

(WebCore::Range::getBoundingClientRect):
Always return a ClientRect, even for an empty bounding rect.

LayoutTests:

  • fast/dom/Range/getBoundingClientRect-expected.txt:
  • fast/dom/Range/getBoundingClientRect.html:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

Add test cases for empty and collapsed ranges.

13:44 Changeset [92088] by rniwa@webkit.org
  • 10 edits
    2 copies
    4 adds in trunk

[HTML5] Implement the selectionDirection property on input and textarea
https://bugs.webkit.org/show_bug.cgi?id=60403

Reviewed by Darin Adler.

Source/WebCore:

Implements selectionDirection property as specified in HTML5 section 4.10.20:
http://www.whatwg.org/specs/web-apps/current-work/#textFieldSelection

selectionDirection is a property on input and textarea elements, which, on getting returns either "none",
"forward", or "backward" corresponding to the current selection direction, and on setting, modifies
the direction of the current selection. When selection doesn't exist or direction is unknown, "none"
is returned on getting. Setting the property value to neither of above values will result in setting "none".

This patch also adds the optional third argument, direction, to setSelectionRange.

Test: fast/forms/selection-direction.html

fast/forms/selection-wrongtype.html

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::selectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionRange): Processes the third argument.

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter): Added.
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter): Added.
(WebCore::V8HTMLInputElement::setSelectionRangeCallback): Processes the third argument.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance): Calls hasCachedSelection.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
(WebCore::HTMLInputElement::setValue): Calls cacheSelection with SelectionHasNoDirection.

  • html/HTMLTextAreaElement.idl: Added selectionDirection and the third argument to setSelectionRange.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initializes
m_cachedSelectionDirection.
(WebCore::HTMLTextFormControlElement::setSelectionStart): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
(WebCore::HTMLTextFormControlElement::setSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::select): Calls setSelectionRange with SelectionHasNoDirection.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Added the version that takes direction
string as the third argument, which calls the version that takes two ints and TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::directionString): Added.
(WebCore::HTMLTextFormControlElement::selectionDirection): Added.
(WebCore::HTMLTextFormControlElement::computeSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::selection): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls cacheSelection.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Takes TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::hasCachedSelection): Extracted from hasCachedSelectionStart;
cacheSelection is the only function that modifies m_cacheSelectionStart and m_cacheSelectionEnd
and none of its callers ever set one of them be -1 so they are always both -1 or both non-negative.
Thus, having two separate functions for m_cacheSelectionStart and m_cacheSelectionEnd was redundant.

LayoutTests:

Added a test to ensure WebKit sets and gets selectionDirection property.

Also added a test to ensure WebKit throws exceptions when retrieving or assigning values to selectionStart,
selectionEnd, and selectionDirection property of the input element when the element isn't a text field.

  • fast/forms/selection-direction-expected.txt: Added.
  • fast/forms/selection-direction.html: Added.
  • fast/forms/selection-wrongtype-expected.txt: Added.
  • fast/forms/selection-wrongtype.html: Added.
  • platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt; editing delegate change.

  • platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt since Windows port fallbacks to Mac.

13:40 Changeset [92087] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Use set comparison to find duplicate or overlapping specifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65430

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length

of a set is wrong.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch

regressions.

13:32 Changeset [92086] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add expected results for Snow Leopard and earlier for fast/css/font-family-pictograph.html

Fixes REGRESSION (r91777): fast/css/font-family-pictograph.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65433

  • platform/mac-snowleopard/fast/css: Added.
  • platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Added.
13:13 Changeset [92085] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424

Reviewed by Gavin Barraclough.

Added code to emit PutByVal inline fast path.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

12:03 Changeset [92084] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382

Reviewed by Oliver Hunt.

This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire. New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

  • heap/Heap.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):

  • heap/MarkedBlock.h:
  • wtf/Platform.h:
09:30 Changeset [92083] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
overload, and change the overload that takes WebURLLoaderOptions to
use a default value. This is equivalent to the original parameterless
overload.
https://bugs.webkit.org/show_bug.cgi?id=65280

Patch by Bill Budge <bbudge@chromium.org> on 2011-07-31
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • src/AssociatedURLLoader.cpp:
  • src/AssociatedURLLoader.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
01:48 Changeset [92082] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
https://bugs.webkit.org/show_bug.cgi?id=65427

This variable was unused when it was initially added in <http://trac.webkit.org/changeset/89660> (bug #62718)
and it is unused today. We should remove it. This will also resolve a compiler warning.

Reviewed by Xan Lopez.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(getChildForTable):

01:34 Changeset [92081] by dbates@webkit.org
  • 2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Add missing semicolons to build fix attempt in <http://trac.webkit.org/changeset/92080>.

  • Source/autotools/symbols.filter:
01:18 Changeset [92080] by dbates@webkit.org
  • 2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Some more fixes to the GTK build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

  • Source/autotools/symbols.filter: Export symbols needed by Internals.
01:06 Changeset [92079] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-07-31 Daniel Bates <dbates@webkit.org>

Try again to fix the WinCairo Debug build after r92059 ( https://bugs.webkit.org/show_bug.cgi?id=65419).

  • win/WebKit2CFLite.def: Export symbols needed by Internals.
00:37 Changeset [92078] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit/win

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

  • WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
  • WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
00:16 Changeset [92077] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-31 Xan Lopez <xlopez@igalia.com>

Group dependencies CFLAGS together.

  • GNUmakefile.am: ditto.
00:04 Changeset [92076] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
(https://bugs.webkit.org/show_bug.cgi?id=65419).

  • GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.

07/30/11:

23:47 Changeset [92075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30

  • DEPS:
23:44 Changeset [92074] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
(https://bugs.webkit.org/show_bug.cgi?id=64744)

23:36 Changeset [92073] by dbates@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.

23:29 Changeset [92072] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.com>

Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
(https://bugs.webkit.org/show_bug.cgi?id=65342)

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock() to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.
23:14 Changeset [92071] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421

Reviewed by Oliver Hunt.

Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

22:56 Changeset [92070] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Windows build after r92059.

  • win/WebKit2.def: Export symbols needed by Internals.
21:46 Changeset [92069] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068

  • bindings/scripts/test/JS/JSTestCallback.cpp:
19:23 Changeset [92068] by paroga@webkit.org
  • 112 edits in trunk/Source

Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add missing and remove unneeded include statements for MainThread.

  • wtf/CryptographicallyRandomNumber.cpp:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/text/StringStatics.cpp:

Source/WebCore:

Add missing include statements for MainThread.

  • bindings/js/DOMWrapperWorld.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMWrapperWorld.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • dom/EventTarget.cpp:
  • fileapi/LocalFileSystem.cpp:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/DOMWindow.cpp:
  • page/History.cpp:
  • page/SecurityOrigin.cpp:
  • page/mac/EventHandlerMac.mm:
  • platform/MIMETypeRegistry.cpp:
  • platform/ThreadGlobalData.cpp:
  • platform/ThreadTimers.cpp:
  • platform/TreeShared.h:
  • platform/audio/HRTFDatabaseLoader.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/FontFallbackList.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/Image.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
  • platform/mac/LocalizedStringsMac.mm:
  • platform/mac/SharedBufferMac.mm:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/text/LocalizedNumberICU.cpp:
  • platform/text/TextEncodingRegistry.cpp:
  • platform/text/mac/LocalizedNumberMac.mm:
  • platform/win/LocalizedStringsWin.cpp:
  • storage/LocalStorageThread.cpp:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaSync.cpp:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageSyncManager.cpp:
  • webaudio/AsyncAudioDecoder.cpp:
  • webaudio/AudioBufferSourceNode.cpp:
  • webaudio/AudioContext.h
  • webaudio/AudioContext.cpp:
  • webaudio/AudioNode.cpp:
  • webaudio/ConvolverNode.cpp:
  • webaudio/OfflineAudioDestinationNode.cpp:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/WaveShaperNode.cpp:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • workers/WorkerMessagingProxy.cpp:

Source/WebKit/chromium:

Add missing include statements for MainThread.

  • src/WebKit.cpp:
  • src/WebViewImpl.cpp:
  • tests/CCThreadTest.cpp:

Source/WebKit/gtk:

Add missing include statements for MainThread.

  • webkit/webkitglobals.cpp:

Source/WebKit/mac:

Add missing include statements for MainThread.

  • Carbon/CarbonWindowAdapter.mm:
  • History/WebBackForwardList.mm:
  • History/WebHistoryItem.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebIconDatabase.mm:
  • Misc/WebLocalizableStrings.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebResource.mm:
  • WebView/WebTextIterator.mm:
  • WebView/WebView.mm:
  • WebView/WebViewData.mm:

Source/WebKit/qt:

Add missing include statements for MainThread.

  • Api/qwebpage.cpp:

Source/WebKit/win:

Add missing include statements for MainThread.

  • WebKitClassFactory.cpp:
  • WebView.cpp:

Source/WebKit/wx:

Add missing include statements for MainThread.

  • WebView.cpp:

Source/WebKit2:

Add missing include statements for MainThread.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:
  • PluginProcess/mac/PluginProcessMainMac.mm:
  • PluginProcess/qt/PluginProcessMainQt.cpp:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp:
  • UIProcess/WebContext.cpp:
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:
  • WebProcess/mac/KeychainItemShimMethods.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
  • WebProcess/qt/WebProcessMainQt.cpp:
  • WebProcess/win/WebProcessMainWin.cpp:
18:19 Changeset [92067] by paroga@webkit.org
  • 2 edits in trunk/Tools

Fix ports_unittest.py on native windows
https://bugs.webkit.org/show_bug.cgi?id=64959

Reviewed by Adam Barth.

Replace WebKitPort.script_path with WebKitPort.script_shell_command.
The latter includes the interpreter executable required on native windows.

  • Scripts/webkitpy/common/config/ports_unittest.py:
17:51 Changeset [92066] by abarth@webkit.org
  • 1 edit
    17 adds
    7 deletes in trunk/LayoutTests

Update baselines. This patch cleans up after http://trac.webkit.org/changeset/92042.

  • platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-moved-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium-win/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium/fast/repaint/absolute-position-changed-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-hide-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-show-expected.png: Removed.
17:46 Changeset [92065] by abarth@webkit.org
  • 16 edits
    1 delete in trunk/LayoutTests

Update more baselines. This completes the cleanup after
http://trac.webkit.org/changeset/92047.

  • platform/chromium-win-xp/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
17:39 Changeset [92064] by abarth@webkit.org
  • 17 edits
    2 deletes in trunk/LayoutTests

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
17:33 Changeset [92063] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
17:25 Changeset [92062] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline.

  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
17:05 Changeset [92061] by abarth@webkit.org
  • 2 edits in trunk/Tools

Properly escape regular expressions. (Maybe these shouldn't be regular
expressions?)

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:57 Changeset [92060] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add support for Win7 to garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:51 Changeset [92059] by enrica@apple.com
  • 7 edits
    2 adds in trunk

REGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419
<rdar://problem/9408862>

Source/WebCore:

This patch fixes a regression introduced in r83075.
Make sure that culledInlineAbsoluteRects still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
This code path could not be tested via JavaScript. The patch
extends the Internals object to be able to test this case.

Reviewed by Dan Bernstein.

Test: fast/inline/skipped-whitespace-boundingBox.html

  • WebCore.exp.in: Added some exports.
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteRects):

  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Reviewed by Dan Bernstein.

  • fast/inline/skipped-whitespace-boundingBox-expected.txt: Added.
  • fast/inline/skipped-whitespace-boundingBox.html: Added.
16:10 Changeset [92058] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417

Reviewed by Dan Bernstein.

Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):

11:27 Changeset [92057] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406

Reviewed by Dimitri Glazkov.

Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range. Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.

This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
11:26 Changeset [92056] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403

Reviewed by Dimitri Glazkov.

The refresh button should be faster and less disruptive than the browser's reload button.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
11:25 Changeset [92055] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=65231

Reviewed by Dimitri Glazkov.

The human readable name is easier to understand, especially when the patch is landed by the commit-queue.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
11:24 Changeset [92054] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227

Reviewed by Dimitri Glazkov.

This helps gardeners keep track of which problems have been solved.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
11:12 Changeset [92053] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add missing files to the server.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:39 Changeset [92052] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410

Reviewed by Noam Rosenthal.

  • Shared/ShareableBitmap.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::paintContent):

05:42 Changeset [92051] by podivilov@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-file.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.SourceFile.prototype.rawLocationToUILocation):
(WebInspector.SourceFile.prototype.uiLocationToRawLocation):
(WebInspector.SourceFile.prototype._scriptForRawLocation):
(WebInspector.SourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):

LayoutTests:

  • inspector/debugger/source-file-expected.txt: Added.
  • inspector/debugger/source-file.html: Added.
04:43 Changeset [92050] by kbalazs@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263

Reviewed by Dmitry Titov.

  • wtf/Deque.h:

(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.

  • wtf/MessageQueue.h:

(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.

00:16 Changeset [92049] by ossy@webkit.org
  • 23 edits in trunk/LayoutTests

[Qt] Update platform specific expected files after r92047.

  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.txt:
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.txt:
  • platform/qt-4.8/svg/batik/text/textDecoration-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.txt:
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLength-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-mac/Skipped: Skip failing tests.

07/29/11:

23:48 Changeset [92048] by ossy@webkit.org
  • 32 edits in trunk/LayoutTests

[Qt] Update platform specific expected files after r92047.

  • platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/qt/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt/svg/batik/text/smallFonts-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect2-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/batik/text/textFeatures-expected.txt:
  • platform/qt/svg/batik/text/textLayout2-expected.txt:
  • platform/qt/svg/batik/text/textLength-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textPosition-expected.txt:
  • platform/qt/svg/batik/text/textPosition2-expected.txt:
  • platform/qt/svg/batik/text/textProperties-expected.txt:
  • platform/qt/svg/batik/text/textProperties2-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/hixie/error/014-expected.txt:
  • platform/qt/svg/hixie/use/002-expected.txt:
  • svg/custom/external-paintserver-reference-expected.png:
  • svg/custom/external-paintserver-reference-expected.txt:
  • svg/custom/linking-base-external-reference-expected.png:
  • svg/custom/linking-base-external-reference-expected.txt:
20:22 Changeset [92047] by rwlbuis@webkit.org
  • 53 edits
    9 adds in trunk

2011-07-29 Rob Buis <rbuis@rim.com>

URL references are completely broken in SVG
https://bugs.webkit.org/show_bug.cgi?id=63283

Reviewed by Nikolas Zimmermann.

Change SVGURIElement::getTarget to be more strict about iri resolving and make it serve as a central
place to resolve a iri to a SVGElement. The iri can be same-document or external, for now we only handle
the former, the latter will be handled in bug 65344.
Accept as same-document if the iri combined with the base uri equals the document url (ignoring
the fragment identifier). For convenience a method is added to lookup the element, if found.

Tests: svg/custom/external-paintserver-reference.svg

svg/custom/linking-base-external-reference.xhtml
svg/custom/uri-reference-handling.svg

  • css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontSelector.h: (WebCore::CSSFontSelector::document):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • rendering/svg/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::paintingResourceFromSVGPaint):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
  • svg/SVGGlyphRefElement.cpp: (WebCore::SVGGlyphRefElement::hasValidGlyphElement):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::matchesTargetURI):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::buildPendingResource):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::fragmentIdentifierFromIRIString): (WebCore::SVGURIReference::targetElementFromIRIString):
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
19:49 Changeset [92046] by fpizlo@apple.com
  • 20 edits
    2 deletes in trunk/Source/JavaScriptCore

JSC GC zombie support no longer works, and is likely no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=65404

Reviewed by Darin Adler.

This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.

(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::isValidWeakNode):

  • heap/Heap.cpp:

(JSC::Heap::destroy):
(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::clearMarks):

  • interpreter/Register.h:

(JSC::Register::Register):
(JSC::Register::operator=):

  • runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):

  • runtime/JSCell.cpp:

(JSC::isZombie):

  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):

  • runtime/JSGlobalData.h:
  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::JSValue):

  • runtime/JSZombie.cpp: Removed.
  • runtime/JSZombie.h: Removed.
  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):

  • wtf/Platform.h:
19:26 Changeset [92045] by zmo@google.com
  • 29 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed, rebaseline, gardener stuff.

  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
19:17 Changeset [92044] by abarth@webkit.org
  • 2 edits in trunk/Tools

Actually import the logging module!

  • Scripts/webkitpy/common/checkout/scm/git.py:
19:14 Changeset [92043] by abarth@webkit.org
  • 2 edits in trunk/Tools

More debug logging. Maybe we're running the git version of this
function somehow? (That would explain why it doesn't work!)

  • Scripts/webkitpy/common/checkout/scm/git.py:
19:12 Changeset [92042] by jchaffraix@webkit.org
  • 2 edits
    39 adds in trunk/LayoutTests

Add more testing to RenderLayer [ct'd]
https://bugs.webkit.org/show_bug.cgi?id=65059

Reviewed by James Robinson.

This change adds testing with <iframe>, position: absolute elements and scrolling.

  • fast/repaint/absolute-position-change-containing-block.html: Added.
  • fast/repaint/absolute-position-changed.html: Added.
  • fast/repaint/absolute-position-moved.html: Added.
  • fast/repaint/fixed-and-absolute-position-scrolled.html: Added.
  • fast/repaint/fixed-position-transparency-with-overflow.html: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child.html: Added.
  • fast/repaint/nested-iframe-scroll-inner.html: Added.
  • fast/repaint/nested-iframe-scroll-outer.html: Added.
  • fast/repaint/overflow-hide.html: Added.
  • fast/repaint/overflow-show.html: Added.

New test cases.

  • fast/repaint/resources/iframe-inner.html: Added.
  • fast/repaint/resources/iframe-outer.html: Added.
  • fast/repaint/resources/default.css:

Added more shared code here.

  • fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • fast/repaint/absolute-position-change-containing-block-expected.txt: Added.
  • fast/repaint/absolute-position-changed-expected.txt: Added.
  • fast/repaint/absolute-position-moved-expected.png: Added.
  • fast/repaint/absolute-position-moved-expected.txt: Added.
  • fast/repaint/fixed-and-absolute-position-scrolled-expected.txt: Added.
  • fast/repaint/fixed-position-transparency-with-overflow-expected.txt: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt: Added.
  • fast/repaint/nested-iframe-scroll-inner-expected.txt: Added.
  • fast/repaint/nested-iframe-scroll-outer-expected.txt: Added.
  • fast/repaint/overflow-hide-expected.txt: Added.
  • fast/repaint/overflow-show-expected.txt: Added.
  • platform/chromium/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium/fast/repaint/overflow-show-expected.png: Added.
  • platform/mac/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/mac/fast/repaint/overflow-hide-expected.png: Added.
  • platform/mac/fast/repaint/overflow-show-expected.png: Added.

Those 2 results are strange and a bug will be opened about them.

19:11 Changeset [92041] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove zipcar.com site specific hack added in r87361
https://bugs.webkit.org/show_bug.cgi?id=65405

Reviewed by Adam Barth.

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedIntoDocument):

19:06 Changeset [92040] by fpizlo@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

LayoutTests does not have a test for array speculation pathologies in the JavaScriptCore DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=65397

Reviewed by Darin Adler.

This test reproduces the crash seen in https://bugs.webkit.org/show_bug.cgi?id=65327, and is
designed to guard itself against possible variants of array speculation failure. It will
test both the case where a speculate-array value is actually a non-array object, and the
case where it is a number. Particular care is taken to increase the likelihood that the
test remains relevant if the JIT performs speculation based on actual argument types and
values at the time of compilation.

  • fast/js/array-type-speculation-expected.txt: Added.
  • fast/js/array-type-speculation.html: Added.
  • fast/js/script-tests/array-type-speculation.js: Added.
19:00 Changeset [92039] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

[EFL] Implement EditorClientEfl::respondToChangedContents
http://bugs.webkit.org/show_bug.cgi?id=64259

Implements respondToChangedContents by calling callback both from
ewk_frame and ewk_view with frame and view objects respectively.

Patch by Michal Pakula vel Rutka <m.pakula@samsung.com> on 2011-07-29
Reviewed by Antonio Gomes.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedContents):

  • ewk/ewk_frame.cpp:

(ewk_frame_editor_client_contents_changed):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_editor_client_contents_changed):

  • ewk/ewk_view.h:
19:00 Changeset [92038] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT verbose mode provides no details about predictions
https://bugs.webkit.org/show_bug.cgi?id=65389

Reviewed by Darin Adler.

Added a print-out of the predictions to the IR dump, with names as follows:
"p-bottom" = the parser made no predictions
"p-int32" = the parser predicted int32
... (same for array, cell, double, number)
"p-top" = the parser made conflicting predictions which will be ignored.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::predictionToString):

18:26 Changeset [92037] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
https://bugs.webkit.org/show_bug.cgi?id=65354

Reviewed by Kenneth Russell.

This moves a few function definitions in LayerRendererChromium around to make the patch on bug 58840 easier to
review. In that patch, updatePropertiesAndRenderSurfaces() becomes a templated free function instead of a
member function, so it has to be near the top of the .cpp.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateLayers):

17:53 Changeset [92036] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add some temporary debug logging messages to try to understand why the
windows bots can't figure out their current SVN revision.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
17:51 Changeset [92035] by jeffm@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>

Prepare WebCore.vcproj to support AVCF media back end on Windows.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

  • WebCore.vcproj/WebCore.vcproj: Added MediaPlayerPrivateAVFoundation and MediaPlayerPrivateAVFoundationCF sources.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added additional include directories and dleay load DLLs for AVCF.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added, just a stub for now.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added, just a stub for now.
17:47 Changeset [92034] by jeffm@apple.com
  • 3 edits in trunk/Source/WebCore

Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>

Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
it references mutable so other const member functions can call it.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
17:09 Changeset [92033] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update, gardener stuff.

  • platform/chromium/test_expectations.txt:
16:27 Changeset [92032] by zmo@google.com
  • 22 edits in trunk/Source

Unreviewed, rolling out r92011.
http://trac.webkit.org/changeset/92011
https://bugs.webkit.org/show_bug.cgi?id=65044

break chromium win build

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • platform/PlatformGestureEvent.h:
  • platform/PlatformGestureRecognizer.h:
  • platform/ScrollAnimatorWin.cpp:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:
16:13 Changeset [92031] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

16:11 Changeset [92030] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394

Reviewed by James Robinson.

The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path. Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

16:11 Changeset [92029] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.5

New tag.

16:03 Changeset [92028] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7537012

16:00 Changeset [92027] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/835

Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7540005

16:00 Changeset [92026] by abarth@webkit.org
  • 2 edits in trunk/Tools

Chromium try servers should use downstream test_expectations
https://bugs.webkit.org/show_bug.cgi?id=65390

Reviewed by Dirk Pranke.

Otherwise the try servers will report bogus failures.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:48 Changeset [92025] by eae@chromium.org
  • 3 edits
    2 adds in trunk

-webkit-marquee with anonymous node causes segmentation fault in Node::document
https://bugs.webkit.org/show_bug.cgi?id=64693

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/webkit-marquee-anonymous-node-crash.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
Add null check as renderer()->node() is null for anonymous nodes.

LayoutTests:

  • fast/css/webkit-marquee-anonymous-node-crash-expected.txt: Added.
  • fast/css/webkit-marquee-anonymous-node-crash.html: Added.

Add test for using -webkit-marquee with an anonymous node.

15:40 Changeset [92024] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT does not have any way of undoing double speculation.
https://bugs.webkit.org/show_bug.cgi?id=65334

Reviewed by Gavin Barraclough.

This adds code to do a branchConvertDoubleToInt on specualtion failure.
This is performance-neutral on most benchmarks but does result in
a slight improvement in Kraken.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

15:38 Changeset [92023] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r91964.

15:17 Changeset [92022] by reed@google.com
  • 9 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:16 Changeset [92021] by cevans@google.com
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 91721
BUG=88944
Review URL: http://codereview.chromium.org/7457026

15:16 Changeset [92020] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r91271.

15:14 Changeset [92019] by lforschler@apple.com
  • 7 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r91266.

15:13 Changeset [92018] by lforschler@apple.com
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91222.

15:08 Changeset [92017] by lforschler@apple.com
  • 15 edits
    2 copies in branches/safari-534.51-branch

Merge r91219.

14:58 Changeset [92016] by lforschler@apple.com
  • 7 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r91085.

14:57 Changeset [92015] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit/mac

Merge r90855.

14:54 Changeset [92014] by weinig@apple.com
  • 21 edits
    2 moves in trunk/Source

Move Region code from WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=65392

Reviewed by David Hyatt.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update project files.

  • WebCore.exp.in:

Update exports.

  • platform/graphics/Region.cpp: Copied from Source/WebKit2/Platform/Region.cpp.
  • platform/graphics/Region.h: Copied from Source/WebKit2/Platform/Region.h.

Add files.

Source/WebKit2:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update project files.

  • Platform/Region.cpp: Removed.
  • Platform/Region.h: Removed.

Remove Region files.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDraw):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:
  • UIProcess/win/WebView.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Update for new namespace and include type.

14:48 Changeset [92013] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r90295.

14:44 Changeset [92012] by lforschler@apple.com
  • 6 edits in branches/safari-534.51-branch/Source

Merge r90293.

14:41 Changeset [92011] by commit-queue@webkit.org
  • 22 edits in trunk/Source

[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:

Added symbolic contstant for tick multiplier.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::handleGestureEvent):
Added missing method needed to fix the build on windows.

  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
14:34 Changeset [92010] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash when opening docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=65327

Reviewed by Gavin Barraclough.

The speculative JIT was only checking whether a value is an array when
we had already checked that it was, rather then when we hadn't.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:29 Changeset [92009] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-07-29 Eric Carlson <eric.carlson@apple.com>

Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270

Reviewed by Joseph Pecoraro.

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Don't ask a load delegate if it is OK to

load an empty poster url.

14:17 Changeset [92008] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Re-sort one more file in the WebCore project with Visual Studio.

  • WebCore.vcproj/WebCore.vcproj:
14:14 Changeset [92007] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
14:04 Changeset [92006] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Fix an error in macro collapsing, refactor code to be pretty.
https://bugs.webkit.org/show_bug.cgi?id=65387

My set math was wrong.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
13:20 Changeset [92005] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Added the regional indicator symbols to the set of codepoints that force use of the complex text code path.

Fixes <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380

Reviewed by Anders Carlsson.

Test: fast/text/regional-indicator-symobls.html

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): Added handling of surrogate pairs, which returns Complex for characters in
the range U+1F1E6..U+1F1FF.

LayoutTests: Test for <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380

Reviewed by Anders Carlsson.

  • fast/text/regional-indicator-symobls-expected.txt: Added.
  • fast/text/regional-indicator-symobls.html: Added.
13:19 Changeset [92004] by hyatt@apple.com
  • 8 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65342

Add support for positioned floats being placed into a RenderBlock's FloatingObject list and for
correct propagation of those floating objects into descendants.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
The positioned float layout algorithm is 2-pass. You lay out without the positioned objects, and then
once they have been placed, you lay out again and use that placement to determine the float positions.
layoutBlock now has an extra parameter to indicate which layout pass you are in.

(WebCore::RenderBlock::addOverflowFromFloats):
Don't add overflow from positioned floats ever, since the positioning overflow function takes care of that
already.

(WebCore::RenderBlock::layoutBlockChild):
Include positioned floats in the lowestFloatLogicalBottom we look at so that overhang is computed properly.

(WebCore::RenderBlock::simplifiedLayout):
If layoutPositionedObjects indicates that a positioned float moved, then we can't do simplified layout. Bail
instead and do a full layout.

(WebCore::RenderBlock::positionedFloatsNeedRelayout):
Helper for layoutBlock in order to bypass the 2-pass model if we can detect that none of the positioned objects
will actually need to lay out again. This allows incremental layout to not always fault back to 2-pass as normal
flow content streams in.

(WebCore::RenderBlock::layoutPositionedObjects):
Modified to return a boolean indicating whether a positioned float got a layout. If so, we will lay out again
once our positioned objects are placed.

(WebCore::RenderBlock::insertFloatingObject):
insertFloatingObject can now handle positioned objects being inserted.

(WebCore::RenderBlock::positionNewFloats):
positionNewFloats doesn't attempt to position this new type of float. It only handles left/right floats.

(WebCore::RenderBlock::addPositionedFloats):
Helper to add in the floating objects for positioned floats. This is used instead of positionNewFloats and
just walks the positioned objects instead.

(WebCore::RenderBlock::clearFloats):
clearFloats now handles adding in positioned floats if the layout pass says they should be included.

(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
New helpers used by addPositionedFloats.

(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
Make sure the object count tracking handles positioned floats as well as left/right floats.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalLeftForChild):
New helper used by addPositionedFloats.

(WebCore::RenderBlock::FloatingObject::FloatingObject):
Change the constructor to take the RenderStyle enum. This makes the construction simpler.

(WebCore::RenderBlock::hasPositionedFloats):
A bit tracks whether or not a block has positioned floats in its positioned objects list.

(WebCore::RenderBlock::hasOverhangingFloats):
Modified to include positioned floats.

(WebCore::RenderBlock::lowestFloatLogicalBottom):
This function excludes positioned floats by default, so that places that - for example - expand to
encompass their lowestFloatLogicalBottom won't accidentally expand to encompass positioned objects.

(WebCore::RenderBlock::lowestFloatLogicalBottomIncludingPositionedFloats):
A new function that includes positioned floats for callers that care.

(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::hasPositionedObjects):
The object count tracking for positioned floats within a block's FloatingObjects list.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):
Make sure isFloating is set even if isPositioned is also set for the positioned float case.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Modified to do the extra layout pass if needed.

12:56 Changeset [92003] by levin@chromium.org
  • 5 edits
    55 adds in trunk/LayoutTests

Tests for validating a new WebVTT parser for <track>
https://bugs.webkit.org/show_bug.cgi?id=64921

Patch by Anna Cavender <annacc@chromium.org> on 2011-07-29
Reviewed by Eric Carlson.

  • media/track/captions/tc000_empty.vtt: Added.
  • media/track/captions/tc001_iso2022jp3.vtt: Added.
  • media/track/captions/tc001_utf8.vtt: Added.
  • media/track/captions/tc002_bom.vtt: Added.
  • media/track/captions/tc003_newlines.vtt: Added.
  • media/track/captions/tc003_nonewlineateof.vtt: Added.
  • media/track/captions/tc004_nowebvtt.vtt: Added.
  • media/track/captions/tc004_webvttfile.vtt: Added.
  • media/track/captions/tc004_webvttrubbish.vtt: Added.
  • media/track/captions/tc005_defaultstyles.vtt: Added.
  • media/track/captions/tc005_metadataarea.vtt: Added.
  • media/track/captions/tc006_cueid.vtt: Added.
  • media/track/captions/tc006_cueiderror.vtt: Added.
  • media/track/captions/tc007_cuenoid.vtt: Added.
  • media/track/captions/tc007_cuenoiderror.vtt: Added.
  • media/track/captions/tc008_timingsnohour.vtt: Added.
  • media/track/captions/tc008_timingsnohourerrors.vtt: Added.
  • media/track/captions/tc009_timingshour.vtt: Added.
  • media/track/captions/tc009_timingshourerror.vtt: Added.
  • media/track/captions/tc010_notimings.vtt: Added.
  • media/track/captions/tc011_cues.vtt: Added.
  • media/track/captions/tc011_cuesnosep.vtt: Added.
  • media/track/captions/tc012_outoforder.vtt: Added.
  • media/track/captions/tc013_settings.vtt: Added.
  • media/track/captions/tc013_settingsbadsep.vtt: Added.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magicheader-expected.txt: Added.
  • media/track/track-webvtt-tc004-magicheader.html: Added.
  • media/track/track-webvtt-tc005-headercomment-expected.txt: Added.
  • media/track/track-webvtt-tc005-headercomment.html: Added.
  • media/track/track-webvtt-tc006-cueidentifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cueidentifiers.html: Added.
  • media/track/track-webvtt-tc007-cuenoid-expected.txt: Added.
  • media/track/track-webvtt-tc007-cuenoid.html: Added.
  • media/track/track-webvtt-tc008-timingsnohours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timingsnohours.html: Added.
  • media/track/track-webvtt-tc009-timingshour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timingshour.html: Added.
  • media/track/track-webvtt-tc010-notimings-expected.txt: Added.
  • media/track/track-webvtt-tc010-notimings.html: Added.
  • media/track/track-webvtt-tc011-blanklines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blanklines.html: Added.
  • media/track/track-webvtt-tc012-outoforder-expected.txt: Added.
  • media/track/track-webvtt-tc012-outoforder.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/wk2/Skipped:
12:11 Changeset [92002] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Scroll animation refinements.
https://bugs.webkit.org/show_bug.cgi?id=65154

Patch by Scott Byer <scottbyer@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.

Source/WebCore:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):

10:47 Changeset [92001] by tony@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

rename css3/flexbox/display-property.html to css3/flexbox/css-properties.html
https://bugs.webkit.org/show_bug.cgi?id=65343

Reviewed by Mihai Parparita.

I plan on adding more tests for the other flexbox properties
(flex-order, flex-direction, flex-pack, flex-align) to this file.

  • css3/flexbox/css-properties-expected.txt: Copied from LayoutTests/css3/flexbox/display-property-expected.txt.
  • css3/flexbox/css-properties.html: Copied from LayoutTests/css3/flexbox/display-property.html.
  • css3/flexbox/display-property-expected.txt: Removed.
  • css3/flexbox/display-property.html: Removed.
  • css3/flexbox/script-tests/css-properties.js: Copied from LayoutTests/css3/flexbox/script-tests/display-property.js.
  • css3/flexbox/script-tests/display-property.js: Removed.
10:37 Changeset [92000] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

To support searching the AccessibilityObject cache, we first need to
implement a minimal set of functions that will allow AccessibilityObjects
to be identified when searching using common search criteria. The additional
functions below complement the existing identification functionality already
available and together provide a basic working set to build search on top of.
Additionally, the blockquoteLevel function has been moved into the AccessibilityObject
class to make it available to all platforms.

Patch by Samuel White <samuel_white@apple.com> on 2011-07-29
Reviewed by Chris Fleizach.

New tests will be included in the following patch that will also implement
basic search functionality.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isBlockquote):
(WebCore::AccessibilityObject::isLandmark):
(WebCore::AccessibilityObject::hasMisspelling):
(WebCore::AccessibilityObject::blockquoteLevel):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isUnvisited):
(WebCore::AccessibilityObject::hasBoldFont):
(WebCore::AccessibilityObject::hasItalicFont):
(WebCore::AccessibilityObject::hasPlainText):
(WebCore::AccessibilityObject::hasSameFont):
(WebCore::AccessibilityObject::hasSameFontColor):
(WebCore::AccessibilityObject::hasSameStyle):
(WebCore::AccessibilityObject::hasStaticText):
(WebCore::AccessibilityObject::hasUnderline):
(WebCore::AccessibilityObject::tableLevel):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isUnvisited):
(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasSameFont):
(WebCore::AccessibilityRenderObject::hasSameFontColor):
(WebCore::AccessibilityRenderObject::hasSameStyle):
(WebCore::AccessibilityRenderObject::hasUnderline):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableLevel):

  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetBlockquoteLevel):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

10:23 Changeset [91999] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid calling animation timer updates while the page is loading
https://bugs.webkit.org/show_bug.cgi?id=64851

Patch by Zeng Huiqing <huiqing.zeng@intel.com> on 2011-07-29
Reviewed by Simon Fraser.

There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

10:18 Changeset [91998] by andersca@apple.com
  • 4 edits in trunk/Source

Pass the HTTP referrer header for URLs loaded by plug-ins
https://bugs.webkit.org/show_bug.cgi?id=65379
<rdar://problem/9822116>

Reviewed by Sam Weinig.

../WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

../WebKit2:

Set the HTTP referrer if necessary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

09:10 Changeset [91997] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed typo fix.

  • platform/qt/Skipped:
08:59 Changeset [91996] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking some media tests as passing and removing from
expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:39 Changeset [91995] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r91986

  • platform/qt-arm/Skipped: Skip failing tests.
08:28 Changeset [91994] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

Fix the QTouchWebView in debug segfault on shutdown introduced in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

unregisterTile is called in the tile's destructor, triggered in the TileSet's
destruction, which happens in the middle of the proxy's destruction
(after the m_tilesByID HashMap destruction).
Detach the tiles in the proxy's destructor to make sure they can cleanup
using a valid proxy.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):

06:47 Changeset [91993] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r91986

  • platform/qt-mac/Skipped: Skip one more failing test.
06:42 Changeset [91992] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Add 4 new failing tests.
06:38 Changeset [91991] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARM]REGRESSION(r91752): It made audio related tests fail
https://bugs.webkit.org/show_bug.cgi?id=65369

  • platform/qt-arm/Skipped: Skip failing tests.
06:36 Changeset [91990] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

Fix the QTouchWebView in debug broke in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

registerTile is called in the Tile's constructor, before adoptRef.
Change the pointer parameter to use the raw type instead.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::registerTile):

  • UIProcess/TiledDrawingAreaProxy.h:
05:49 Changeset [91989] by ossy@webkit.org
  • 3 edits
    79 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r91986

  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textDecoration2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textLength-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textLength-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPCDATA-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPosition-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textProperties-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textProperties-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/button-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/button-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/colourpicker-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/combobox-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/combobox-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/scrollbar-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/selectionlist-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/slider-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/slider-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/textbox-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/textbox-expected.txt: Added.
  • platform/qt-4.8/svg/carto.net/window-expected.png: Added.
  • platform/qt-4.8/svg/carto.net/window-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
05:49 Changeset [91988] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix speech input icon rect on RTL directions.
https://bugs.webkit.org/show_bug.cgi?id=65333

Reviewed by Tony Gentilcore.

No new tests. This is used by platforms, not WebCore, and
the base functionality is not changed but only the failing cases.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

05:32 Changeset [91987] by ossy@webkit.org
  • 3 edits
    10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r91984

  • platform/qt-4.8/fast/block/positioning/047-expected.png: Added.
  • platform/qt-4.8/fast/block/positioning/047-expected.txt: Added.
  • platform/qt-4.8/fast/block/positioning/051-expected.png: Added.
  • platform/qt-4.8/fast/block/positioning/051-expected.txt: Added.
  • platform/qt-4.8/fast/invalid/019-expected.png: Added.
  • platform/qt-4.8/fast/invalid/019-expected.txt: Added.
  • platform/qt-4.8/fast/lists/003-expected.png: Added.
  • platform/qt-4.8/fast/lists/003-expected.txt: Added.
  • platform/qt-4.8/fast/text/basic/generic-family-reset-expected.png: Added.
  • platform/qt-4.8/fast/text/basic/generic-family-reset-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
05:14 Changeset [91986] by ossy@webkit.org
  • 7 edits
    243 adds in trunk/LayoutTests

[Qt] Add platform specific expected results

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/qt/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/qt/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/qt/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/qt/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/qt/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/qt/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt/svg/batik/text/smallFonts-expected.png: Added.
  • platform/qt/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor2-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/qt/svg/batik/text/textAnchor3-expected.png: Added.
  • platform/qt/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/qt/svg/batik/text/textDecoration2-expected.png: Added.
  • platform/qt/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect2-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/qt/svg/batik/text/textEffect3-expected.png: Added.
  • platform/qt/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/qt/svg/batik/text/textFeatures-expected.png: Added.
  • platform/qt/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/qt/svg/batik/text/textLayout2-expected.png: Added.
  • platform/qt/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/qt/svg/batik/text/textLength-expected.png: Added.
  • platform/qt/svg/batik/text/textLength-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/qt/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/qt/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/qt/svg/batik/text/textPCDATA-expected.png: Added.
  • platform/qt/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/qt/svg/batik/text/textPosition-expected.png: Added.
  • platform/qt/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt/svg/batik/text/textPosition2-expected.png: Added.
  • platform/qt/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt/svg/batik/text/textProperties-expected.png: Added.
  • platform/qt/svg/batik/text/textProperties-expected.txt: Added.
  • platform/qt/svg/batik/text/textProperties2-expected.png: Added.
  • platform/qt/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/qt/svg/carto.net/button-expected.png: Added.
  • platform/qt/svg/carto.net/button-expected.txt: Added.
  • platform/qt/svg/carto.net/colourpicker-expected.png: Added.
  • platform/qt/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/qt/svg/carto.net/combobox-expected.png: Added.
  • platform/qt/svg/carto.net/combobox-expected.txt: Added.
  • platform/qt/svg/carto.net/scrollbar-expected.png: Added.
  • platform/qt/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/qt/svg/carto.net/selectionlist-expected.png: Added.
  • platform/qt/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/qt/svg/carto.net/slider-expected.png: Added.
  • platform/qt/svg/carto.net/slider-expected.txt: Added.
  • platform/qt/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/qt/svg/carto.net/textbox-expected.png: Added.
  • platform/qt/svg/carto.net/textbox-expected.txt: Added.
  • platform/qt/svg/carto.net/window-expected.png: Added.
  • platform/qt/svg/carto.net/window-expected.txt: Added.
  • platform/qt/svg/css/css-box-min-width-expected.png: Added.
  • platform/qt/svg/css/css-box-min-width-expected.txt: Added.
  • platform/qt/svg/css/getComputedStyle-basic-expected.png: Added.
  • platform/qt/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/qt/svg/custom/foreign-object-skew-expected.txt: Added.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.png: Added.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • platform/qt/svg/custom/group-opacity-expected.png: Added.
  • platform/qt/svg/custom/group-opacity-expected.txt: Added.
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.png: Added.
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.txt: Added.
  • platform/qt/svg/custom/percentage-rect-expected.png: Added.
  • platform/qt/svg/custom/percentage-rect-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-image-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-image-expected.txt: Added.
  • platform/qt/svg/custom/text-linking-expected.png: Added.
  • platform/qt/svg/custom/text-linking-expected.txt: Added.
  • platform/qt/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
  • platform/qt/svg/hixie/cascade/001-broken-expected.png: Added.
  • platform/qt/svg/hixie/cascade/001-broken-expected.txt: Added.
  • platform/qt/svg/hixie/data-types/001-expected.png: Added.
  • platform/qt/svg/hixie/data-types/001-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/002-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/002-expected.txt:
  • platform/qt/svg/hixie/dynamic/003-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/003-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/004-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/004-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/005-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/005-expected.txt: Added.
  • platform/qt/svg/hixie/dynamic/006-expected.png: Added.
  • platform/qt/svg/hixie/dynamic/006-expected.txt: Added.
  • platform/qt/svg/hixie/error/001-expected.png: Added.
  • platform/qt/svg/hixie/error/001-expected.txt: Added.
  • platform/qt/svg/hixie/error/002-expected.png: Added.
  • platform/qt/svg/hixie/error/002-expected.txt: Added.
  • platform/qt/svg/hixie/error/003-expected.png: Added.
  • platform/qt/svg/hixie/error/003-expected.txt: Added.
  • platform/qt/svg/hixie/error/007-expected.png: Added.
  • platform/qt/svg/hixie/error/007-expected.txt: Added.
  • platform/qt/svg/hixie/error/008-expected.png: Added.
  • platform/qt/svg/hixie/error/008-expected.txt: Added.
  • platform/qt/svg/hixie/error/009-expected.png: Added.
  • platform/qt/svg/hixie/error/009-expected.txt: Added.
  • platform/qt/svg/hixie/error/010-expected.png: Added.
  • platform/qt/svg/hixie/error/010-expected.txt: Added.
  • platform/qt/svg/hixie/error/011-expected.png: Added.
  • platform/qt/svg/hixie/error/011-expected.txt: Added.
  • platform/qt/svg/hixie/error/013-expected.png: Added.
  • platform/qt/svg/hixie/error/013-expected.txt: Added.
  • platform/qt/svg/hixie/error/014-expected.png: Added.
  • platform/qt/svg/hixie/error/014-expected.txt: Added.
  • platform/qt/svg/hixie/error/014-test-expected.png: Added.
  • platform/qt/svg/hixie/error/014-test-expected.txt: Added.
  • platform/qt/svg/hixie/error/015-expected.png: Added.
  • platform/qt/svg/hixie/error/015-expected.txt: Added.
  • platform/qt/svg/hixie/error/016-expected.png: Added.
  • platform/qt/svg/hixie/error/016-expected.txt: Added.
  • platform/qt/svg/hixie/error/017-expected.png: Added.
  • platform/qt/svg/hixie/error/017-expected.txt: Added.
  • platform/qt/svg/hixie/links/001-expected.png: Added.
  • platform/qt/svg/hixie/links/001-expected.txt: Added.
  • platform/qt/svg/hixie/links/002-expected.png: Added.
  • platform/qt/svg/hixie/links/002-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/003-expected.png: Added.
  • platform/qt/svg/hixie/mixed/003-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/004-expected.png: Added.
  • platform/qt/svg/hixie/mixed/004-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/005-expected.png: Added.
  • platform/qt/svg/hixie/mixed/005-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/006-expected.png: Added.
  • platform/qt/svg/hixie/mixed/006-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/007-expected.png: Added.
  • platform/qt/svg/hixie/mixed/007-expected.txt:
  • platform/qt/svg/hixie/mixed/008-expected.png: Added.
  • platform/qt/svg/hixie/mixed/008-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/009-expected.png: Added.
  • platform/qt/svg/hixie/mixed/009-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/010-expected.png: Added.
  • platform/qt/svg/hixie/mixed/010-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/011-expected.png: Added.
  • platform/qt/svg/hixie/mixed/011-expected.txt: Added.
  • platform/qt/svg/hixie/painting/001-expected.png: Added.
  • platform/qt/svg/hixie/painting/001-expected.txt: Added.
  • platform/qt/svg/hixie/perf/001-expected.png: Added.
  • platform/qt/svg/hixie/perf/001-expected.txt: Added.
  • platform/qt/svg/hixie/perf/002-expected.png: Added.
  • platform/qt/svg/hixie/perf/002-expected.txt: Added.
  • platform/qt/svg/hixie/perf/003-expected.png: Added.
  • platform/qt/svg/hixie/perf/003-expected.txt: Added.
  • platform/qt/svg/hixie/perf/004-expected.png: Added.
  • platform/qt/svg/hixie/perf/004-expected.txt: Added.
  • platform/qt/svg/hixie/perf/005-expected.png: Added.
  • platform/qt/svg/hixie/perf/005-expected.txt: Added.
  • platform/qt/svg/hixie/perf/006-expected.png: Added.
  • platform/qt/svg/hixie/perf/006-expected.txt: Added.
  • platform/qt/svg/hixie/perf/007-expected.png: Added.
  • platform/qt/svg/hixie/perf/007-expected.txt: Added.
  • platform/qt/svg/hixie/processing-model/003-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/003-expected.txt:
  • platform/qt/svg/hixie/processing-model/004-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/004-expected.txt:
  • platform/qt/svg/hixie/processing-model/005-expected.png: Added.
  • platform/qt/svg/hixie/processing-model/005-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/001-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/001-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/002-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/002-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/003-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/003-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/003a-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/003a-expected.txt: Added.
  • platform/qt/svg/hixie/rendering-model/004-expected.png: Added.
  • platform/qt/svg/hixie/rendering-model/004-expected.txt: Added.
  • platform/qt/svg/hixie/shapes/path/001-expected.png: Added.
  • platform/qt/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/qt/svg/hixie/text/002-expected.png: Added.
  • platform/qt/svg/hixie/text/002-expected.txt: Added.
  • platform/qt/svg/hixie/text/003-expected.png: Added.
  • platform/qt/svg/hixie/text/003-expected.txt: Added.
  • platform/qt/svg/hixie/text/003a-expected.png: Added.
  • platform/qt/svg/hixie/text/003a-expected.txt: Added.
  • platform/qt/svg/hixie/text/003b-expected.png: Added.
  • platform/qt/svg/hixie/text/003b-expected.txt: Added.
  • platform/qt/svg/hixie/transform/001-expected.png: Added.
  • platform/qt/svg/hixie/transform/001-expected.txt: Added.
  • platform/qt/svg/hixie/use/001-expected.png: Added.
  • platform/qt/svg/hixie/use/001-expected.txt: Added.
  • platform/qt/svg/hixie/use/002-expected.png: Added.
  • platform/qt/svg/hixie/use/002-expected.txt: Added.
  • platform/qt/svg/hixie/use/002-test-expected.png: Added.
  • platform/qt/svg/hixie/use/002-test-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/001-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/001-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/002-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/003-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/004-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/004-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png: Added.
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
04:55 Changeset [91985] by alexis.menard@openbossa.org
  • 11 edits in trunk/Source/WebKit2

[Qt] Make QDesktopWebView/QTouchWebView loadProgress property more usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65315

Reviewed by Benjamin Poulain.

In order to use the loadProgress value in QML we need to make it
a Q_PROPERTY, therefore we need a getter to get it.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebView::url):
(QDesktopWebView::loadProgress):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::loadProgress):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::stop):
(tst_CommonViewTests::loadProgress):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::desktopViewLoadFailed):
(WebViewAbstraction::touchViewLoadProgressChanged):
(WebViewAbstraction::desktopViewLoadProgressChanged):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeLoadProgress):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::loadProgress):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didChangeLoadProgress):

04:30 Changeset [91984] by ossy@webkit.org
  • 68 edits
    186 adds in trunk/LayoutTests

[Qt] Update platform specific expected results

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.png: Added.
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/qt/fast/block/basic/010-expected.png: Added.
  • platform/qt/fast/block/basic/010-expected.txt:
  • platform/qt/fast/block/float/004-expected.png: Added.
  • platform/qt/fast/block/float/004-expected.txt:
  • platform/qt/fast/block/float/010-expected.png: Added.
  • platform/qt/fast/block/float/010-expected.txt:
  • platform/qt/fast/block/float/017-expected.png: Added.
  • platform/qt/fast/block/float/017-expected.txt:
  • platform/qt/fast/block/float/021-expected.png: Added.
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/032-expected.png: Added.
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-expected.png: Added.
  • platform/qt/fast/block/float/br-with-clear-expected.txt: Added.
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png: Added.
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/block/margin-collapse/006-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/055-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/055-expected.txt:
  • platform/qt/fast/block/positioning/047-expected.png: Added.
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/051-expected.png: Added.
  • platform/qt/fast/block/positioning/051-expected.txt:
  • platform/qt/fast/block/positioning/056-expected.png: Added.
  • platform/qt/fast/block/positioning/056-expected.txt:
  • platform/qt/fast/block/positioning/061-expected.png: Added.
  • platform/qt/fast/block/positioning/061-expected.txt:
  • platform/qt/fast/block/positioning/move-with-auto-width-expected.png: Added.
  • platform/qt/fast/block/positioning/move-with-auto-width-expected.txt: Added.
  • platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • platform/qt/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/qt/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/qt/fast/dynamic/containing-block-change-expected.txt:
  • platform/qt/fast/dynamic/floating-to-positioned-2-expected.png: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-2-expected.txt: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-expected.png: Added.
  • platform/qt/fast/dynamic/floating-to-positioned-expected.txt: Added.
  • platform/qt/fast/events/focusingUnloadedFrame-expected.png: Added.
  • platform/qt/fast/flexbox/002-expected.png: Added.
  • platform/qt/fast/flexbox/002-expected.txt:
  • platform/qt/fast/flexbox/003-expected.png: Added.
  • platform/qt/fast/flexbox/003-expected.txt:
  • platform/qt/fast/forms/listbox-clip-expected.png: Added.
  • platform/qt/fast/forms/listbox-clip-expected.txt:
  • platform/qt/fast/forms/menulist-clip-expected.png: Added.
  • platform/qt/fast/forms/menulist-clip-expected.txt:
  • platform/qt/fast/forms/minWidthPercent-expected.png: Added.
  • platform/qt/fast/forms/minWidthPercent-expected.txt:
  • platform/qt/fast/forms/onchange-enter-submit-expected.png: Added.
  • platform/qt/fast/gradients/background-clipped-expected.png: Added.
  • platform/qt/fast/gradients/background-clipped-expected.txt: Added.
  • platform/qt/fast/gradients/generated-gradients-expected.png: Added.
  • platform/qt/fast/gradients/generated-gradients-expected.txt: Added.
  • platform/qt/fast/gradients/simple-gradients-expected.png: Added.
  • platform/qt/fast/gradients/simple-gradients-expected.txt: Added.
  • platform/qt/fast/inline-block/001-expected.png: Added.
  • platform/qt/fast/inline-block/001-expected.txt:
  • platform/qt/fast/inline/continuation-outlines-expected.png: Added.
  • platform/qt/fast/inline/continuation-outlines-expected.txt:
  • platform/qt/fast/inline/continuation-outlines-with-layers-expected.png: Added.
  • platform/qt/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/qt/fast/invalid/019-expected.png: Added.
  • platform/qt/fast/invalid/019-expected.txt:
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • platform/qt/fast/layers/self-painting-outline-expected.png: Added.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/qt/fast/lists/003-expected.png: Added.
  • platform/qt/fast/lists/003-expected.txt:
  • platform/qt/fast/media/mq-animation-expected.png: Added.
  • platform/qt/fast/media/mq-animation-expected.txt: Added.
  • platform/qt/fast/media/mq-js-media-except-01-expected.png: Added.
  • platform/qt/fast/media/mq-js-media-except-01-expected.txt:
  • platform/qt/fast/media/mq-js-media-except-02-expected.png: Added.
  • platform/qt/fast/media/mq-js-media-except-02-expected.txt:
  • platform/qt/fast/overflow/table-overflow-float-expected.png: Added.
  • platform/qt/fast/overflow/table-overflow-float-expected.txt:
  • platform/qt/fast/repaint/4774354-expected.png: Added.
  • platform/qt/fast/repaint/4774354-expected.txt:
  • platform/qt/fast/repaint/4776765-expected.png: Added.
  • platform/qt/fast/repaint/4776765-expected.txt:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
  • platform/qt/fast/repaint/body-background-image-expected.png: Added.
  • platform/qt/fast/repaint/body-background-image-expected.txt:
  • platform/qt/fast/repaint/border-fit-lines-expected.png: Added.
  • platform/qt/fast/repaint/border-fit-lines-expected.txt:
  • platform/qt/fast/repaint/border-radius-repaint-expected.png: Added.
  • platform/qt/fast/repaint/border-radius-repaint-expected.txt:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.png: Added.
  • platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.png: Added.
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
  • platform/qt/fast/repaint/bugzilla-3509-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-3509-expected.txt:
  • platform/qt/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-5699-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6278-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6388-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6388-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-6473-expected.txt:
  • platform/qt/fast/repaint/bugzilla-7235-expected.png: Added.
  • platform/qt/fast/repaint/bugzilla-7235-expected.txt:
  • platform/qt/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/qt/fast/repaint/caret-outside-block-expected.txt: Added.
  • platform/qt/fast/repaint/change-transform-expected.png: Added.
  • platform/qt/fast/repaint/change-transform-expected.txt: Added.
  • platform/qt/fast/repaint/clip-with-layout-delta-expected.png: Added.
  • platform/qt/fast/repaint/clip-with-layout-delta-expected.txt: Added.
  • platform/qt/fast/repaint/clipped-relative-expected.png: Added.
  • platform/qt/fast/repaint/clipped-relative-expected.txt:
  • platform/qt/fast/repaint/containing-block-position-change-expected.png: Added.
  • platform/qt/fast/repaint/containing-block-position-change-expected.txt:
  • platform/qt/fast/repaint/continuation-after-outline-expected.png: Added.
  • platform/qt/fast/repaint/continuation-after-outline-expected.txt:
  • platform/qt/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/qt/fast/repaint/create-layer-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
  • platform/qt/fast/repaint/float-move-during-layout-expected.png: Added.
  • platform/qt/fast/repaint/float-move-during-layout-expected.txt:
  • platform/qt/fast/repaint/float-overflow-expected.png: Added.
  • platform/qt/fast/repaint/float-overflow-expected.txt:
  • platform/qt/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/qt/fast/repaint/float-overflow-right-expected.txt:
  • platform/qt/fast/repaint/focus-layers-expected.png: Added.
  • platform/qt/fast/repaint/focus-layers-expected.txt:
  • platform/qt/fast/repaint/inline-color-change-expected.png: Added.
  • platform/qt/fast/repaint/inline-color-change-expected.txt: Added.
  • platform/qt/fast/repaint/invisible-objects-expected.png: Added.
  • platform/qt/fast/repaint/invisible-objects-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-relative-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt: Added.
  • platform/qt/fast/repaint/line-overflow-expected.png: Added.
  • platform/qt/fast/repaint/line-overflow-expected.txt:
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.png: Added.
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.txt: Added.
  • platform/qt/fast/repaint/list-marker-2-expected.png: Added.
  • platform/qt/fast/repaint/list-marker-2-expected.txt:
  • platform/qt/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/qt/fast/repaint/make-children-non-inline-expected.txt: Added.
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
  • platform/qt/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/qt/fast/repaint/outline-child-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/outline-inset-expected.png: Added.
  • platform/qt/fast/repaint/outline-inset-expected.txt:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/outline-shrinking-expected.png: Added.
  • platform/qt/fast/repaint/outline-shrinking-expected.txt:
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/qt/fast/repaint/overflow-delete-line-expected.png: Added.
  • platform/qt/fast/repaint/overflow-delete-line-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.txt: Added.
  • platform/qt/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/qt/fast/repaint/reflection-redraw-expected.txt: Added.
  • platform/qt/fast/repaint/reflection-repaint-test-expected.png: Added.
  • platform/qt/fast/repaint/reflection-repaint-test-expected.txt: Added.
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png: Added.
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/qt/fast/repaint/selected-replaced-expected.png: Added.
  • platform/qt/fast/repaint/selected-replaced-expected.txt: Added.
  • platform/qt/fast/repaint/selection-clear-expected.png: Added.
  • platform/qt/fast/repaint/selection-clear-expected.txt: Added.
  • platform/qt/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/qt/fast/repaint/static-to-positioned-expected.txt:
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-cell-move-expected.png: Added.
  • platform/qt/fast/repaint/table-cell-move-expected.txt:
  • platform/qt/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/qt/fast/repaint/table-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
  • platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
  • platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Added.
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.txt: Added.
  • platform/qt/fast/repaint/transform-absolute-child-expected.png: Added.
  • platform/qt/fast/repaint/transform-absolute-child-expected.txt: Added.
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
  • platform/qt/fast/repaint/transform-disable-layoutstate-expected.png: Added.
  • platform/qt/fast/repaint/transform-disable-layoutstate-expected.txt: Added.
  • platform/qt/fast/repaint/transform-layout-repaint-expected.png: Added.
  • platform/qt/fast/repaint/transform-layout-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/qt/fast/repaint/transform-relative-position-expected.txt: Added.
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.txt: Added.
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.png: Added.
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.txt: Added.
  • platform/qt/fast/repaint/transform-translate-expected.png: Added.
  • platform/qt/fast/repaint/transform-translate-expected.txt: Added.
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
  • platform/qt/fast/text/basic/generic-family-reset-expected.png: Added.
  • platform/qt/fast/text/basic/generic-family-reset-expected.txt:
  • platform/qt/fast/text/whitespace/002-expected.png: Added.
  • platform/qt/fast/text/whitespace/002-expected.txt:
  • platform/qt/fast/text/whitespace/003-expected.png: Added.
  • platform/qt/fast/text/whitespace/003-expected.txt:
04:21 Changeset [91983] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fail new fast/js/parseInt.html test
https://bugs.webkit.org/show_bug.cgi?id=65366

Unreviewed expectaions update.

  • platform/chromium/test_expectations.txt:
03:26 Changeset [91982] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

Make the ExceptionCode argument of Element::setShadowPseudoId() ASSERT_NO_EXCEPTION by default
https://bugs.webkit.org/show_bug.cgi?id=65363

Reviewed by Hajime Morita.

No new tests. Cleanup-only.

  • dom/Element.h: Make the ExceptionCode argument ASSERT_NO_EXCEPTION by default.
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree): Remove the ExceptionCode argument and ASSERT(!ec).

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText): ditto.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree): ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree): ditto.
(WebCore::TextFieldInputType::updatePlaceholderText): ditto.

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree): ditto.

02:59 Changeset [91981] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Move ewk_view API documentation to the header file
https://bugs.webkit.org/show_bug.cgi?id=65305

There are two arguments for this:

  1. Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
  2. It will be consistent with structures descriptions.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-29
Reviewed by Kent Tamura.

  • ewk/ewk_tiled_model.c:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view.h:
  • ewk/ewk_view_single.c:
  • ewk/ewk_view_tiled.c:
02:50 Changeset [91980] by ossy@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
01:37 Changeset [91979] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebKit2

TiledDrawingArea: Use tile sets to paint old content while rendering for a new scale.
https://bugs.webkit.org/show_bug.cgi?id=64728

Reviewed by Benjamin Poulain.

We currently delete all the tiles when setContentsScale is called. This shows a blank
background to the user while the web process render tiles for the new scale.

This patch extracts the ownership of individual tiles from TiledDrawingAreaProxy to
TiledDrawingAreaTileSet to allow the proxy to paint tiles with different scales.
We can then paint the tiles we already have on top of the tiles we are rendering for
the new scale until enough content is available.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaTileSet::tiles):
(WebKit::TiledDrawingAreaTileSet::contentsScale):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::mapToContents):
(WebKit::TiledDrawingAreaTileSet::mapFromContents):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::registerTile):
(WebKit::TiledDrawingAreaProxy::unregisterTile):
Added those two methods to allow the tiles to clean
themselves on destruction.
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::cancelTileUpdate):
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::updateTileBuffers):
(WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::coverageRatio):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::resizeEdgeTiles):
(WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect):
(WebKit::TiledDrawingAreaProxy::disableTileSetUpdates):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):
(WebKit::TiledDrawingAreaProxy::contentsRect):
(WebKit::TiledDrawingAreaProxy::visibleRect):
(WebKit::TiledDrawingAreaProxy::hasPendingUpdates):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:

(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::updateBackBuffer):

01:16 Changeset [91978] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364

  • platform/qt/Skipped: Skip failing tests.
01:04 Changeset [91977] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
00:38 Changeset [91976] by mrobinson@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix incorrect ChangeLog entry from r91954.

00:11 QtWebKitForQt5 edited by romaxa@gmail.com
(diff)
00:11 QtWebKitForQt5 edited by romaxa@gmail.com
WebGL option (diff)

07/28/11:

22:32 Changeset [91975] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
https://bugs.webkit.org/show_bug.cgi?id=65304
http://code.google.com/p/chromium/issues/detail?id=63553

Patch by Naoki Takano <honten@chromium.org> on 2011-07-28
Reviewed by Darin Fisher.

Chromium Autofill feature needs to access the parent WebFormElement from WebFormControlElement. So added form() method.

  • public/WebFormControlElement.h: Add form() function.
  • src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::form): Return parent WebFormElement.

22:16 Changeset [91974] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Removes EAPI attribute in internal headers.
https://bugs.webkit.org/show_bug.cgi?id=65251

Removes EAPI attribute in three header files because API in these files is internally used.

Patch by Kangil Han <kangil.han@samsung.com> on 2011-07-28
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
21:53 Changeset [91973] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Defines header files will be publicly installed explicitly.
https://bugs.webkit.org/show_bug.cgi?id=64923

This patch modifies a way to define open header list from black-list to white-list.
Plus, 'ewk/ewk_util.h' will not be installed anymore because it only has internal API.

Patch by Kangil Han <kangil.han@samsung.com> on 2011-07-28
Reviewed by Anders Carlsson.

  • CMakeListsEfl.txt:
21:43 Changeset [91972] by gyuyoung.kim@samsung.com
  • 17 edits in trunk/Source/WebKit/efl

[EFL] Fix coding style of pointer type in ewk files.
https://bugs.webkit.org/show_bug.cgi?id=65358

Move '*' operator to variable side according to efl coding style.
Because, '*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • ewk/ewk_auth.cpp:

(ewk_auth_credentials_set):

  • ewk/ewk_auth.h:
  • ewk/ewk_auth_soup.cpp:

(_Ewk_Auth_Data::ewk_auth_soup_dialog_class_init):
(_Ewk_Auth_Data::ewk_auth_soup_dialog_init):
(_Ewk_Auth_Data::ewk_auth_soup_credentials_set):
(_Ewk_Auth_Data::session_authenticate):
(_Ewk_Auth_Data::free_auth_data):
(_Ewk_Auth_Data::attach):
(_Ewk_Auth_Data::detach):

  • ewk/ewk_auth_soup.h:
  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_ref):
(ewk_context_menu_unref):
(ewk_context_menu_destroy):
(ewk_context_menu_item_list_get):
(ewk_context_menu_item_new):
(ewk_context_menu_item_select):
(ewk_context_menu_item_free):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_type_set):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_action_set):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_title_set):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_checked_set):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_new):
(ewk_context_menu_free):
(ewk_context_menu_item_append):
(ewk_context_menu_custom_get):
(ewk_context_menu_show):

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:

(ewk_cookies_file_set):
(ewk_cookies_clear):
(ewk_cookies_get_all):
(ewk_cookies_cookie_del):
(ewk_cookies_policy_set):
(ewk_cookies_policy_get):

  • ewk/ewk_history.cpp:

(_ewk_history_item_new):
(_ewk_history_item_list_get):
(ewk_history_forward):
(ewk_history_back):
(ewk_history_history_item_add):
(ewk_history_history_item_set):
(ewk_history_history_item_back_get):
(ewk_history_history_item_current_get):
(ewk_history_history_item_forward_get):
(ewk_history_history_item_nth_get):
(ewk_history_history_item_contains):
(ewk_history_forward_list_get):
(ewk_history_forward_list_get_with_limit):
(ewk_history_forward_list_length):
(ewk_history_back_list_get):
(ewk_history_back_list_get_with_limit):
(ewk_history_back_list_length):
(ewk_history_limit_get):
(ewk_history_limit_set):
(ewk_history_item_new):
(_ewk_history_item_free):
(ewk_history_item_free):
(ewk_history_item_list_free):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_title_alternate_set):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
(ewk_history_item_page_cache_exists):
(ewk_history_item_visit_count):
(ewk_history_item_visit_last_failed):
(ewk_history_new):
(ewk_history_free):

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):

  • ewk/ewk_network.h:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_get):
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):
(ewk_settings_default_user_agent_get):

  • ewk/ewk_util.cpp:

(ewk_util_image_from_cairo_surface_add):

  • ewk/ewk_util.h:
  • ewk/ewk_window_features.cpp:

(ewk_window_features_unref):
(ewk_window_features_ref):
(ewk_window_features_bool_property_get):
(ewk_window_features_int_property_get):
(ewk_window_features_new_from_core):

  • ewk/ewk_window_features.h:
21:18 Changeset [91971] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Fix pointer operator coding style in ewk_frame.
https://bugs.webkit.org/show_bug.cgi?id=65357

Move '*' operator to variable according to efl coding style.
Because, '*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • ewk/ewk_frame.cpp:

(_ewk_frame_debug):
(_ewk_frame_loader_efl_get):
(kit):
(_ewk_frame_children_iterator_next):
(_ewk_frame_children_iterator_get_container):
(_ewk_frame_smart_add):
(_ewk_frame_smart_del):
(_ewk_frame_smart_resize):
(_ewk_frame_smart_set):
(_ewk_frame_smart_class_new):
(ewk_frame_view_get):
(ewk_frame_children_iterator_new):
(ewk_frame_child_find):
(ewk_frame_uri_set):
(ewk_frame_uri_get):
(ewk_frame_title_get):
(ewk_frame_name_get):
(ewk_frame_contents_size_get):
(_ewk_frame_contents_set_internal):
(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):
(ewk_frame_script_execute):
(ewk_frame_editable_get):
(ewk_frame_editable_set):
(ewk_frame_selection_get):
(ewk_frame_text_search):
(ewk_frame_text_matches_mark):
(ewk_frame_text_matches_unmark_all):
(ewk_frame_text_matches_highlight_set):
(ewk_frame_text_matches_highlight_get):
(_ewk_frame_rect_cmp_less_than):
(_ewk_frame_rect_is_negative_value):
(ewk_frame_text_matches_nth_pos_get):
(ewk_frame_stop):
(ewk_frame_reload):
(ewk_frame_reload_full):
(ewk_frame_back):
(ewk_frame_forward):
(ewk_frame_navigate):
(ewk_frame_back_possible):
(ewk_frame_forward_possible):
(ewk_frame_navigate_possible):
(ewk_frame_zoom_get):
(ewk_frame_zoom_set):
(ewk_frame_zoom_text_only_get):
(ewk_frame_zoom_text_only_set):
(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):
(ewk_frame_scroll_add):
(ewk_frame_scroll_set):
(ewk_frame_scroll_size_get):
(ewk_frame_scroll_pos_get):
(ewk_frame_visible_content_geometry_get):
(ewk_frame_paint_full_get):
(ewk_frame_paint_full_set):
(ewk_frame_feed_focus_in):
(ewk_frame_feed_focus_out):
(ewk_frame_feed_mouse_wheel):
(ewk_frame_feed_mouse_down):
(ewk_frame_feed_mouse_up):
(ewk_frame_feed_mouse_move):
(ewk_frame_feed_touch_event):
(_ewk_frame_handle_key_scrolling):
(ewk_frame_feed_key_down):
(ewk_frame_feed_key_up):
(ewk_frame_text_selection_type_get):
(ewk_frame_add):
(ewk_frame_init):
(ewk_frame_child_add):
(ewk_frame_core_gone):
(ewk_frame_core_get):
(ewk_frame_load_started):
(ewk_frame_load_provisional):
(ewk_frame_load_finished):
(ewk_frame_load_error):
(ewk_frame_load_progress_changed):
(ewk_frame_contents_size_changed):
(ewk_frame_title_set):
(ewk_frame_view_create_for_view):
(ewk_frame_uri_changed):
(ewk_frame_force_layout):
(ewk_frame_plugin_create):
(ewk_frame_editor_client_selection_changed):

  • ewk/ewk_frame.h:
20:25 Changeset [91970] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make WebImage::assign(CGImageRef) a WEBKIT_API
https://bugs.webkit.org/show_bug.cgi?id=65265

Reviewed by James Robinson.

Required for the components build on mac. The inline function
operator=(CGImageRef) is used from outside webkit, and calls this
function.

  • public/WebImage.h:
18:46 Changeset [91969] by macpherson@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove remaining uses of CSSPrimitiveValue::computeLengthIntForLength()
https://bugs.webkit.org/show_bug.cgi?id=64919

Reviewed by Darin Adler.

No new tests / cleanup only.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Remove implementation of computeLengthIntForLength()

  • css/CSSPrimitiveValue.h:

Remove definition of computeLengthIntForLength()

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
Remove use of computeLengthIntForLength()

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove use of computeLengthIntForLength()

  • platform/Length.h:

(WebCore::Length::setQuirk):
Adds the ability to set the m_quirk member variable after construction.

18:37 Changeset [91968] by kerz@chromium.org
  • 1 edit
    2 copies in branches/chromium/835/LayoutTests

Merge 91927 - [chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/7474011

18:36 Changeset [91967] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Fix style errors of test_expectations.txt.

  • platform/qt/test_expectations.txt:
17:43 Changeset [91966] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Source/JavaScriptCore: *_list instructions are only used in one place, where the code is wrong.
https://bugs.webkit.org/show_bug.cgi?id=65348

Patch by Oliver Hunt <oliver@apple.com> on 2011-07-28
Reviewed by Darin Adler.

Simply remove the instructions and all users. Speeds up the interpreter
slightly due to code motion, but otherwise has no effect (because none
of the _list instructions are ever used).

  • bytecode/CodeBlock.cpp:

(JSC::isPropertyAccess):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt

Reviewed by Oliver Hunt.

  • fast/js/parseInt-expected.txt: Added.
  • fast/js/parseInt.html: Added.
  • fast/js/script-tests/parseInt.js: Added.
    • Added test cases.
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.2_parseInt/S15.1.2.2_A1_T2-expected.txt:
    • Fixed.
17:38 Changeset [91965] by andersca@apple.com
  • 6 edits
    4 deletes in trunk

Unreviewed, rolling out r88601. (Requested by Sam Weinig).
http://trac.webkit.org/changeset/88601
https://bugs.webkit.org/show_bug.cgi?id=62230

Caused a regression, see https://bugs.webkit.org/show_bug.cgi?id=64378

Source/WebCore:

  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::insertedIntoDocument):
(WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):

  • html/HTMLBodyElement.h:

LayoutTests:

  • fast/dom/body-link-decl-parent-crash-expected.txt: Removed.
  • fast/dom/body-link-decl-parent-crash.html: Removed.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Removed.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Removed.
17:26 Changeset [91964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION (5.1): CJK input broken after clicking on Flash content
<rdar://problem/9854447>
https://bugs.webkit.org/show_bug.cgi?id=65349

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-28
Reviewed by Darin Adler.

After giving Flash focus on a page and then navigating away from that page
using the back button, we were not getting notified to switch back to
inline (non-complex) input. Now, notify the page that it can leave complex
text mode when the plugin is destroyed.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

17:24 Changeset [91963] by jschuh@chromium.org
  • 2 edits in trunk/Source/WebCore

Simplify createCanonicalUUIDString implementation.
https://bugs.webkit.org/show_bug.cgi?id=65157

All ports support OS_RANDOMNESS, so better to have one implementation.

Reviewed by Adam Barth.

Change covered by existing tests.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

17:10 Changeset [91962] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Add reviewer.

17:06 Changeset [91961] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Crash when trying to encode FontInfo with a null font attribute descriptor
https://bugs.webkit.org/show_bug.cgi?id=65350
<rdar://problem/9520670>

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):
Encode a boolean specifying whether there's a fontAttributeDictionary member variable.

(WebKit::FontInfo::decode):
Don't try to decode the fontAttributeDictionary member variable if none has been encoded.

17:02 Changeset [91960] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixed gif animation dependency on system time
https://bugs.webkit.org/show_bug.cgi?id=64996

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-07-28
Reviewed by James Robinson.

Test: Load WebCore/manual-tests/animated-gif-looping.html
Change system time to a time in past

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation): Bitmap animation is now based
on monotonicallyIncreasingTime instead of currentTime

16:56 Changeset [91959] by commit-queue@webkit.org
  • 9 edits in trunk

V8 should correctly serialize Boolean, Number and String objects.

https://bugs.webkit.org/show_bug.cgi?id=65286

Source/WebCore:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-28
Reviewed by David Levin.

New APIs were exposed to allow V8 to correctly serialize Boolean, Number and String objects, as well as detect certain native errors as required by the HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data). SerializedScriptValue should make use of these APIs.

  • Checks for and serializes Boolean, Number and String objects.
  • Checks for native errors and aborts should a script attempt to serialize them.
  • Small name change to clear up the code: m_objectReferenceStack => m_openCompositeReferenceStack

Tests: fast/dom/Window/window-postmessage-clone.html

fast/loader/stateobjects/pushstate-object-types.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeBooleanObject):
(WebCore::V8ObjectMap::Writer::writeStringObject):
(WebCore::V8ObjectMap::Writer::writeNumberObject):
(WebCore::V8ObjectMap::Serializer::writeStringObject):
(WebCore::V8ObjectMap::Serializer::writeNumberObject):
(WebCore::V8ObjectMap::Serializer::writeBooleanObject):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readStringObject):
(WebCore::V8ObjectMap::Reader::readNumberObject):
(WebCore::V8ObjectMap::Deserializer::deserialize):
(WebCore::V8ObjectMap::Deserializer::openComposite):
(WebCore::V8ObjectMap::Deserializer::closeComposite):

LayoutTests:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-28
Reviewed by David Levin.

  • Check that Boolean, Number and String objects are correctly serialized.
  • Check that a native error is not serialized.
  • Fix an expectation that a native error can be serialized.
  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/script-tests/postmessage-test.js:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
16:43 Changeset [91958] by kerz@chromium.org
  • 3 edits
    3 copies in branches/chromium/835

Merge 91915 - 2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/7532014

16:39 Changeset [91957] by abarth@webkit.org
  • 4 edits
    4 adds in trunk

Old code about empty security origins could use a bath
https://bugs.webkit.org/show_bug.cgi?id=64735

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch cleans up some old code related to empty security origins.
It also removes some dodgy code that seems wrong.

Test: http/tests/security/inactive-document-with-empty-security-origin.html

  • bindings/generic/BindingSecurityBase.cpp:

(WebCore::BindingSecurityBase::canAccess):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::isEmpty):
(WebCore::SecurityOrigin::isSecureTransitionTo):
(WebCore::SecurityOrigin::toString):

LayoutTests:

  • http/tests/security/inactive-document-with-empty-security-origin-expected.txt: Added.
  • http/tests/security/inactive-document-with-empty-security-origin.html: Added.
  • http/tests/security/resources/post-done-to-opener.html: Added.
16:37 Changeset [91956] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector open and there are watch expressions added.
https://bugs.webkit.org/show_bug.cgi?id=65322

Reviewed by Pavel Feldman.

  • inspector/InspectorController.cpp:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
16:33 Changeset [91955] by commit-queue@webkit.org
  • 8 edits
    11 adds in trunk

[CSSRegions]Add basic RenderRegion support
https://bugs.webkit.org/show_bug.cgi?id=64689

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-28
Reviewed by David Hyatt.

Source/WebCore:

This patch introduces the RenderRegion object.
A RenderObject that takes its content from a "named" flow will become a RenderRegion, an element that is used to display the content from a RenderFlowThread.
A RenderRegion that is marked to take its content from a non existing flow, will have its content disconnected from the normal flow.

Tests: fast/regions/region-element-display-restriction.html

fast/regions/region-element-dynamic-attach-flow.html
fast/regions/region-element-dynamic-detach-flow.html
fast/regions/render-region-renderer.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderRegion):

  • rendering/RenderRegion.cpp: Added.

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::paint):

  • rendering/RenderRegion.h: Added.

(WebCore::RenderRegion::isRenderRegion):
(WebCore::RenderRegion::renderName):
(WebCore::toRenderRegion):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

  • fast/regions/region-element-display-restriction-expected.txt: Added.
  • fast/regions/region-element-display-restriction.html: Added.
  • fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
  • fast/regions/region-element-dynamic-attach-flow.html: Added.
  • fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
  • fast/regions/region-element-dynamic-detach-flow.html: Added.
  • fast/regions/render-region-renderer-expected.txt: Added.
  • fast/regions/render-region-renderer.html: Added.
  • fast/regions/script-tests/region-element-display-restriction.js: Added.
16:26 Changeset [91954] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Cannot override default max-conns and max-conns-per-host Soup Session settings
https://bugs.webkit.org/show_bug.cgi?id=64355
Default max-conns and max-conns-per-host are set at "first contact" with
a site instead of at creation time. This results in values being
overwritten if they are set prior to said "first contact"; which is the
most likely (or only) scenario.

Patch by Marco Peereboom <marco@peereboom.us> on 2011-07-28
Reviewed by Martin Robinson.

No new tests. Rigged libsoup and xxxterm web browser to diagnose the
issue and validate the patch.

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::determinePitch):

16:22 Changeset [91953] by enne@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

[chromium] chromium-win-xp test updates after r91945.

Unreviewed gardening.

See also r91946, r91948.

  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-win-xp/fast/ruby/nested-ruby-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.txt: Added.
16:20 Changeset [91952] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

*_list instructions are only used in one place, where the code is wrong.
https://bugs.webkit.org/show_bug.cgi?id=65348

Reviewed by Darin Adler.

Simply remove the instructions and all users. Speeds up the interpreter
slightly due to code motion, but otherwise has no effect (because none
of the _list instructions are ever used).

  • bytecode/CodeBlock.cpp:

(JSC::isPropertyAccess):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

15:00 Changeset [91951] by mihaip@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebDocument::insertStyleText
https://bugs.webkit.org/show_bug.cgi?id=65332

Reviewed by Tony Chang.

As of http://crrev.com/94499 no Chromium code calls this anymore.
Also does a bit of #include cleanup.

  • public/WebDocument.h:
  • src/WebDocument.cpp:
14:38 Changeset [91950] by tony@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium

2011-07-28 Tony Chang <tony@chromium.org>

Add sql to svn:ignore and remove app.

  • chromium: Modified property svn:ignore.
14:37 Changeset [91949] by tony@chromium.org
  • 1 edit in trunk/Source/WebKit/ChangeLog

Add sql to svn:ignore and remove app.

  • chromium: Modified property svn:ignore.
14:24 Changeset [91948] by senorblanco@chromium.org
  • 2 edits
    23 adds
    4 deletes in trunk/LayoutTests

Yet more chromium test updates. Vista tests were broken by the win7
results (same fallback problem as linux). Some tests just needed a
baseline. And some checked-in SVG masks test results were wrong.

Unreviewed.

  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:14 Changeset [91947] by rwlbuis@webkit.org
  • 5 edits in trunk/LayoutTests

2011-07-28 Rob Buis <rbuis@rim.com>

Mac svg gardening.

RS=Nikolas Zimmerman.

  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/custom/text-linking-expected.png:
  • platform/mac/svg/filters/feGaussianBlur-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
13:36 Changeset [91946] by senorblanco@chromium.org
  • 1 edit
    15 adds in trunk/LayoutTests

New chromium linux text results. These results used to match the XP
results, but since we now have (correct) win7 results with different
DOM trees, the fallback no longer works, and we need them here.

Unreviewed.

  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-linux/svg/custom/circular-marker-reference-1-expected.txt: Added.
  • platform/chromium-linux/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.txt: Added.
13:10 Changeset [91945] by senorblanco@chromium.org
  • 73 edits
    32 adds
    13 deletes in trunk/LayoutTests

Rebaseline many chromium win7 and vista tests. This also revealed some
incorrect results checked into the tree, which I've deleted.

Unreviewed.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-win-vista/fast/text/drawBidiText-expected.png:
  • platform/chromium-win-vista/fast/text/international/danda-space-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-vista/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-win/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-win/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-win/fast/css/first-letter-first-line-hover-expected.png: Added.
  • platform/chromium-win/fast/css/first-letter-first-line-hover-expected.txt: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win/fast/text/drawBidiText-expected.png:
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
  • platform/chromium-win/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-win/fast/text/international/plane2-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/custom/circular-marker-reference-1-expected.txt: Added.
  • platform/chromium-win/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/chromium-win/svg/custom/circular-marker-reference-4-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.
  • platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
12:45 Changeset [91944] by brettw@chromium.org
  • 2 edits in branches/chromium/835/Source/WebKit/chromium

Merge 91789 - Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/7530003

12:27 Changeset [91943] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65323
r91931 causes NOTREACHED to be hit via StorageTracker

Change the meaning of the "has been initialized" flag to "needs initialization", and only set it to true
if the ::initializeTracker() method has been called.

Reviewed by Sam Weinig.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Set m_needsInitialization to true since the calling WebKit port expects full

initialization instead of a dummy tracker.

(WebCore::StorageTracker::internalInitialize):
(WebCore::StorageTracker::tracker): Only initialize the tracker if it was created in the above initializeTracker().
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:
12:03 Changeset [91942] by reed@google.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

add Mike Reed to committer list

11:53 Changeset [91941] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations update: remove a bunch of commented-out
expectations. Some of these were introduced by me, some were not.

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:24 Changeset [91940] by senorblanco@chromium.org
  • 39 edits
    2 adds
    1 delete in trunk/LayoutTests

New chromium baselines after skia r1960.

Unreviewed.

  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-expected.png:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png: Removed.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png: Added.
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium/test_expectations.txt:
10:38 Changeset [91939] by cfleizach@apple.com
  • 6 edits in trunk/Source/WebKit2

REGRESSION (Safari 5.1): JavaScript dialogs not usable with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=65214

Reviewed by Anders Carlsson.

Allow the ability to spin the run loop while WebProcess is waiting for a synchronous reply.
This allows it to continue to serve accessibility requests while waiting and basically
restores the behavior WK1 was presenting. This patch only enables this mode when accessibility is on.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::sendSync):

  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm:

(RunLoop::runForDuration):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

10:32 Changeset [91938] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt

Reviewed by Oliver Hunt.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):

  • parseInt applied to small positive numbers = floor.
10:24 Changeset [91937] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Pass the key_press_event or key_release_event to parent widget when it is not handled by Web Process.
(https://bugs.webkit.org/show_bug.cgi?id=64790)

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-07-28
Reviewed by Martin Robinson.

  • Shared/NativeWebKeyboardEvent.h:

(WebKit::NativeWebKeyboardEvent::nativeEvent): Return a GdkEvent* instead of const GdkEvent* (non-const).

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithKeyEvent): Implemented for GTK port. Sets flag if the keyboard event
needs to be passed to the parent widget. Invoke gtk_main_do_event() if event needs to be passed to parent.

  • UIProcess/API/gtk/PageClientImpl.h: Deleted obsolete functions didNotHandleKeyEvent & didNotHandleWheelEvent.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_init): Initialize shouldForwardNextKeyEvent flag.
(webkitWebViewBaseKeyPressEvent): Pass event to parent widget depending on status from doneWithKeyEvent.
(webkitWebViewBaseKeyReleaseEvent): Pass event to parent widget depending on status from doneWithKeyEvent.
(webkitWebViewBaseForwardNextKeyEvent): API to set flag shouldForwardNextKeyEvent.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added API to set shouldForwardNextKeyEvent flag.
09:57 Changeset [91936] by ddkilzer@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebCore

<http://webkit.org/b/65289> Remove GeolocationPositionCache

Reviewed by Adam Barth.

  • CMakeLists.txt: Remove references to GeolocationPositionCache.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Geolocation.cpp: Switch from using m_positionCache to

m_cachedPosition.
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::haveSuitableCachedPosition):
(WebCore::Geolocation::positionChangedInternal):

  • page/Geolocation.h: Remove PositionCacheWrapper and replace

with RefPtr<Geoposition>.

  • page/GeolocationPositionCache.cpp: Removed.
  • page/GeolocationPositionCache.h: Removed.
09:33 Changeset [91935] by mitz@apple.com
  • 14 edits in trunk

Source/WebCore: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebCore.exp.in: Exported wkGetVerticalGlyphsForCharacters.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Use wkGetVerticalGlyphsForCharacters. If it returns false, proceed
with the existing, slower method of getting vertical glyphs.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.

Source/WebKit2: <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.

WebKitLibraries: WebKitSystemInterface support for
<rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetVerticalGlyphsForCharacters().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
09:30 Changeset [91934] by vangelis@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp

Merge 91768 - [SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
https://bugs.webkit.org/show_bug.cgi?id=65182

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-26
Reviewed by Stephen White.

No new tests. Not sure how to test wrong-ctx bugs in layout tests.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7520031

09:26 Changeset [91933] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):

08:33 Changeset [91932] by tonyg@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] New expectations after r91924
https://bugs.webkit.org/show_bug.cgi?id=65320

Unreviewed expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
08:32 Changeset [91931] by beidson@apple.com
  • 9 edits in trunk/Source

<rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView

Source/WebCore:

Move the heavy lifting done in StorageTracker::initializeTracker() until when the global tracker is actually
accessed, therefore deferring it until a web page actually uses LocalStorage or the app uses the API.

Reviewed by Maciej Stachowiak.

No new tests. (Not possible to test this API implementation detail)

  • WebCore.exp.in:
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::StorageAreaImpl): Access the global StorageTracker to indicate that a web page

is actually using the storage APIs.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Moved the potentially hefty work from here...
(WebCore::StorageTracker::internalInitialize): ...to here.
(WebCore::StorageTracker::tracker): If the global tracker hasn't had internalInitialize() called, do so.
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

  • Storage/WebStorageManager.mm:

(WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().

Source/WebKit2:

Reviewed by Maciej Stachowiak.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Pass a null client pointer in the new form of initializeTracker()

08:25 Changeset [91930] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: My last attempt to paint Qt-Mac bot green.
08:22 Changeset [91929] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Copy and paste is broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=65252

Reviewed by Martin Robinson.

Use gtk_clipboard_get_for_display() instead of
gtk_widget_get_clipboard(), using the the default display when
there's no page client widget, which is the case of WebKit2.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::displayFromFrame): Return the display of the current
frame widget or the default display if there's no widget.
(WebCore::PasteboardHelper::getClipboard):
(WebCore::PasteboardHelper::getPrimarySelectionClipboard):

08:13 Changeset [91928] by vsevik@chromium.org
  • 12 edits
    3 adds in trunk

Web Inspector: Add resource initiator column to network panel.
https://bugs.webkit.org/show_bug.cgi?id=65105

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator.html

  • English.lproj/localizedStrings.js:
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculationImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willRecalculateStyle):
(WebCore::InspectorResourceAgent::didRecalculateStyle):
(WebCore::InspectorResourceAgent::didScheduleStyleRecalculation):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.InitiatorComparator):

  • inspector/front-end/networkLogView.css:

(.initiator-column a):

LayoutTests:

  • http/tests/inspector/network/network-initiator-expected.txt: Added.
  • http/tests/inspector/network/network-initiator.html: Added.
  • http/tests/inspector/network/resources/initiator.css: Added.

(.image-background):
(.image-background-2):

07:39 Changeset [91927] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
07:27 Changeset [91926] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: One more attempt to paint Qt-Mac bot green.
07:25 Changeset [91925] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Uncomment some suppressions we'll need for the upcoming skia roll.

Unreviewed; chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
07:24 Changeset [91924] by rwlbuis@webkit.org
  • 11 edits
    3 adds in trunk

2011-07-28 Rob Buis <rbuis@rim.com>

Use styling test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=62147

Reviewed by Nikolas Zimmermann.

Make sure CSS selectors are applied to the DOM tree referenced by <use>, not the internal shadow tree. In order to quickly
find the corresponding DOM tree element store this info in SVGElementRareData.

Test: svg/W3C-SVG-1.1-SE/struct-use-11-f.svg

  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::styleForRenderer):
  • rendering/svg/SVGShadowTreeElements.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::correspondingElement): (WebCore::SVGElement::setCorrespondingElement): (WebCore::SVGElement::styleForRenderer):
  • svg/SVGElement.h:
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::correspondingElement): (WebCore::SVGElementRareData::setCorrespondingElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::removedFromDocument):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
  • svg/SVGUseElement.h:
07:12 Changeset [91923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

This fixes build without video enabled.
https://bugs.webkit.org/show_bug.cgi?id=65084

Patch by Denis Oliver Kropp <dok@directfb.org> on 2011-07-28
Reviewed by Philippe Normand.

Test with --disable-video.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

07:07 Changeset [91922] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/qt/test_expectations.txt:
06:57 QtWebKitBuildBots edited by abecsi@webkit.org
(diff)
06:53 QtWebKitBuildBots edited by rgabor@webkit.org
(diff)
06:47 QtWebKitBuildBots edited by rgabor@webkit.org
(diff)
06:34 Changeset [91921] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Paint the bot green with skipping all failing and crashing tests.
06:15 Changeset [91920] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

  • platform/qt-wk2/Skipped: Skip two failing fast test.
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/Skipped:
05:21 Changeset [91919] by yutak@chromium.org
  • 8 edits in trunk/Source/WebCore

WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
https://bugs.webkit.org/show_bug.cgi?id=65250

Reviewed by Alexey Proskuryakov.

Add useHixie76Protocol() method to WebSocketChannel and its family. To implement hybi-specific
attributes in WebSocket object, WebSocket class needs to be able to get the value of
useHixie76Protocol flag of WebSocketChannel.

If the WebSocket object is created in a worker thread, the flag value must be obtained from
WebSocketChannel which resides in the loader thread (through WorkerThreadableWebSocketChannel).
Since the value does not change after creation of WebSocketChannel, it can be cached in
the worker thread.

There is no change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setUseHixie76Protocol):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::useHixie76Protocol):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Peer::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):

  • websockets/WorkerThreadableWebSocketChannel.h:
05:19 Changeset [91918] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

  • platform/qt-wk2/Skipped: Skip failing editing tests.
05:06 Changeset [91917] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

Rebaseline pixel tests for file upload controls on chromium-win.
https://bugs.webkit.org/show_bug.cgi?id=65245

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-28
Reviewed by Gustavo Noronha Silva.

r91759 changed the appearance of file upload controls on gtk,
chromium-win and chromium-linux. New baselines were already committed
for chromium-linux (same changeset) and gtk (r91759).

  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/file-input-direction-expected.png:
  • platform/chromium-win/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium/test_expectations.txt:
05:03 Changeset [91916] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Add platform specific expected result for a new test.

  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
04:42 Changeset [91915] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
01:13 Changeset [91914] by mrobinson@webkit.org
  • 27 edits
    8 adds
    1 delete in trunk

[Cairo] Switch from ContextShadow to ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=64744

Source/WebCore:

Use ShadowBlur in the Cairo backend instead of ContextShadow. This allows us
to share shadowing code with Qt and Mac ports and to correct some broken
shadow rendering.

Reviewed by Dirk Schulze.

  • CMakeLists.txt: Remove ContextShadow from the build.
  • CMakeListsEfl.txt: Ditto.
  • GNUmakefile.list.am: Add ShadowBlur source files and remove ContextShadow

source files.

  • platform/graphics/GraphicsContext.cpp:Add #ifdefs to support ShadowBlur for Cairo.
  • platform/graphics/GraphicsContext.h: Remove Cairo ContextShadow code.
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawInsetShadowWithTiling): Since the ShadowBlur is a property
of the GraphicsContext, we cannot clear the GraphicsContext shadow until we have
finished using properties like m_offset. If we clear the GrahpicsContext shadow
before using these properties, they will be zero when we try to use them.
(WebCore::ShadowBlur::drawRectShadowWithTiling):Ditto.
(WebCore::ShadowBlur::drawLayerPieces): Ditto.
(WebCore::ShadowBlur::beginShadowLayer):Cairo is the first port to keep ShadowBlur
as a persistent property of GraphicsContext and use drawRectShadow and drawInsetShadow.
Thus, we must manually clear the cached tiling values so that ShadowBlur does not
try to reuse the scratch buffer for rectangular shadows after using beginShadowLayer
and endShadowLayer.
(WebCore::ShadowBlur::mustUseShadowBlur): Moved this method from the Qt port to
this cross-platform location.

  • platform/graphics/ShadowBlur.h: Added new method declaration.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Removed.
  • platform/graphics/cairo/FontCairo.cpp: Switched to using ShadowBlur.

(WebCore::drawGlyphsShadow):Ditto.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Switch to using ShadowBlur.

(WebCore::drawPathShadow): ShadowBlur has slightly different semantics than
ContextShadow. When filling the shadow layer, we do not need to use the fill
alpha. We also need to restore the Cairo path to the target context after
endShadowLayer as it destroys the current path.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Switch to using ShadowBlur.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):Ditto.
(WebCore::PlatformContextCairo::prepareForStroking): Add a mode ignoring alpha.

  • platform/graphics/cairo/PlatformContextCairo.h: Ditto.

(WebCore::PlatformContextCairo::shadowBlur):Added.

  • platform/graphics/gtk/FontGtk.cpp: Update to use ShadowBlur.
  • platform/graphics/qt/GraphicsContextQt.cpp: Switch to using the new version of mustUseShadowBlur.

LayoutTests:

Update test results, which are now correct after switch to ShadowBlur.

Reviewed by Dirk Schulze.

  • fast/box-shadow/box-shadow-radius-expected.png: Added.
  • fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • fast/box-shadow/inset-shadow-large-offset-expected.png:
  • fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • fast/box-shadow/scaled-box-shadow-expected.png: Added.
  • fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/gtk/Skipped: Skip a test, which now has a bug revealed.
  • platform/gtk/fast/box-shadow/basic-shadows-expected.png:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.png:
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/gtk/fast/box-shadow/inset-expected.png:
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/gtk/fast/box-shadow/spread-expected.png:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.png:
00:38 Changeset [91913] by tkent@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=65300

Reviewed by Darin Adler.

r91837 had performance regression of StringImpl::stripWhiteSpace()
and simplifyWhiteSpace(). This changes the code so that compilers
generates code equivalent to r91836 or piror.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripMatchedCharacters):
A template member function for stripWhiteSpace(). This function takes a functor.
(WTF::UCharPredicate):
A functor for generic predicate for single UChar argument.
(WTF::SpaceOrNewlinePredicate):
A special functor for isSpaceOrNewline().
(WTF::StringImpl::stripWhiteSpace):
Use stripmatchedCharacters().
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
A template member function for simplifyWhiteSpace().
(WTF::StringImpl::simplifyWhiteSpace):
Use simplifyMatchedCharactersToSpace().

  • wtf/text/StringImpl.h:
Note: See TracTimeline for information about the timeline view.