Timeline


and

08/03/11:

23:35 Changeset [92352] by commit-queue@webkit.org
  • 5 edits in trunk

An element with role=textbox should have settable AXValue unless read-only
https://bugs.webkit.org/show_bug.cgi?id=65664

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-03
Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetValueAttribute):
Return true for non-native text field with aria-readonly not set.

LayoutTests:

  • accessibility/aria-readonly-expected.txt:
  • accessibility/aria-readonly.html:
23:08 Changeset [92351] by abarth@webkit.org
  • 6 edits in trunk/Tools

Use failureInfo more pervasively in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65650

Reviewed by Dimitri Glazkov.

These three variable appears in concert together many places. This
patch unifies the remaining uses into being failureInfo objects, which
saves some marshalling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
22:34 Changeset [92350] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/win

[Windows] Fix build without ENABLE_VIDEO.

  • WebView.cpp:

(WebView::enterFullscreenForNode):

21:40 Changeset [92349] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Clean up value clamping in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65588

Reviewed by Darin Adler.

No new tests / trivial code cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Replace (unsigned int)primitiveValue->getDoubleValue() with primtiveValue->getValue<unsigned>() for correct clamping.
Replace clampToInteger(primitiveValue->getDoubleValue()) with primitiveValue->getIntValue().

21:38 Changeset [92348] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should be able to update expecations from the details pane
https://bugs.webkit.org/show_bug.cgi?id=65648

Reviewed by Dimitri Glazkov.

The new button queues up the updates, which get executed all at once.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
21:38 Changeset [92347] by tkent@chromium.org
  • 13 edits in trunk/Source

Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590

Reviewed by Dimitri Glazkov.

<video> and <audio> can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.

Source/WebCore:

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedIntoTree):
(WebCore::HTMLSourceElement::willRemove):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):

  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaMuteButton):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _isAnyMoviePlaying]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::enterFullscreenForNode):

21:16 Changeset [92346] by abarth@webkit.org
  • 7 edits in trunk/Tools

Add UI to garden-o-matic for updating expectations
https://bugs.webkit.org/show_bug.cgi?id=65644

Reviewed by Dimitri Glazkov.

The patch plumbs the UI back to the gardening server, but the gardening
server endpoint is just a stub at this point.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
20:54 Changeset [92345] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Use of AVFoundation should default to off on Windows
https://bugs.webkit.org/show_bug.cgi?id=65660

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.
20:02 Changeset [92344] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic details view should queue rebaselines for later execution
https://bugs.webkit.org/show_bug.cgi?id=65636

Reviewed by Dimitri Glazkov.

This patch doesn't contain any confirmation UI, but we'll probably want
that at some point.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
19:35 Changeset [92343] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
https://bugs.webkit.org/show_bug.cgi?id=65659

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

ScrollbarOverlayUtilitiesChromiumMac.h couldn't be included from pure c++ code because it used NSInteger. I fixed this by checking for OBJC before using NSInteger.

Currently no pure c++ files are including ScrollbarOverlayUtilitiesChromiumMac.h but this will change in future patches from jam@chromium.org.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterControllerStyle):
(wkSetScrollbarPainterControllerStyle):

19:09 Changeset [92342] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65657

Reviewed by Simon Fraser.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Implement cast from EBoxSizing.
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
Implement cast to EBoxSizing.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to simplify code using cast.

19:01 Changeset [92341] by commit-queue@webkit.org
  • 10 edits
    4 adds
    6 deletes in trunk

Implement EventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Patch by Kentaro Hara <haraken@google.com> on 2011-08-03
Reviewed by Darin Fisher.

Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
and then sets a scroll position to (x, y). Enabled the tests that had been waiting
for the implementation of EventSender.scalePageBy(f, x, y).

Source/WebKit/chromium:

Tests: compositing/scaling/tiled-layer-recursion.html

fast/repaint/scale-page-shrink.html
fast/dom/Element/scale-page-client-rects.html
fast/dom/Range/scale-page-client-rects.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-bounding-client-rect.html

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scalePage): A wrapper method for scalePage() in WebCore.

  • src/WebViewImpl.h:

Tools:

Tests: compositing/scaling/tiled-layer-recursion.html

fast/repaint/scale-page-shrink.html
fast/dom/Element/scale-page-client-rects.html
fast/dom/Range/scale-page-client-rects.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-bounding-client-rect.html

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender): Added bindings for scalePageBy().
(EventSender::scalePageBy): A wrapper method for scalePage() in WebView.

  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController): Resets the scale factor to 1.

LayoutTests:

  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Enabled one test. Enabled two tests for chromium-linux.
18:51 Changeset [92340] by joepeck@webkit.org
  • 10 edits
    3 adds in trunk

<http://webkit.org/b/65006> Draw rectangular box shadow for elements with border-radius if no corners are visible

Patch by Ian Henderson <ianh@apple.com> on 2011-08-03
Reviewed by Simon Fraser.

Source/WebCore:

Change "unroundClippedCorners" to "allCornersClippedOut" and use it to
determine when the corners' influence affects the blurred shadow in
the current drawing region.

Test: fast/box-shadow/box-shadow-clipped-slices.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxShadow): Pass PaintInfo through to
RenderBoxModelObject::paintBoxShadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Ditto.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::allCornersClippedOut): Determines whether the bounding rects
for any of the given rounded rect's corners intersects the clip rect.
(WebCore::RenderBoxModelObject::paintBorder): Instead of "unrounding"
any corner outside the clip rect, unround all corners at once, and
only if they are all outside the clip rect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Determine whether any
corner will influence shadow drawing using allCornersClippedOut on the
influenceRect, whose corners extend past the fillRect's corners by the
blur radius and inside the fillRect's corners by the blur radius.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
RenderBoxModelObject::paintBoxShadow.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

LayoutTests:

  • fast/box-shadow/box-shadow-clipped-slices.html: Added.
  • platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.txt: Added.
18:44 Changeset [92339] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
https://bugs.webkit.org/show_bug.cgi?id=65521

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-03
Reviewed by Adam Barth.

file: scheme URI paths on Windows include the disk drive reference (C: for example).
Refer to http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.

  • fast/dom/resource-locations-in-created-html-document.html:
  • platform/chromium/test_expectations.txt:
18:41 Changeset [92338] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Revert an erroneous rebaseline from r92315.

  • fast/dom/navigator-detached-no-crash-expected.txt:
17:22 Changeset [92337] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn't show composited content
https://bugs.webkit.org/show_bug.cgi?id=65629

Reviewed by Benjamin Poulain.

Some non-ES2 initialization was wrongfully #ifdefed in CPU(X86) and thus compiled-out.
When put it in the correct #ifdef, composited layers which require an intermediate buffer
work again.

No new tests. Existing opacity tests in LayoutTests/compositing test this.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::bind):

17:16 Changeset [92336] by rniwa@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Chromium Windows and Linux rebaselines after r92330.

  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
16:57 Changeset [92335] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp

Merge 92331 - [chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::protectTileTextures):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7508041

16:53 Changeset [92334] by levin@chromium.org
  • 3 edits in trunk/Tools

Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=65652

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
16:51 Changeset [92333] by mrowe@apple.com
  • 8 edits in trunk/Source

Bring some order to FeatureDefines.xcconfig to make it easier to follow.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
16:50 Changeset [92332] by mrowe@apple.com
  • 8 edits in trunk/Source

Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings

Reviewed by Dave Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
16:43 Changeset [92331] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::protectTileTextures):

16:42 Changeset [92330] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
https://bugs.webkit.org/show_bug.cgi?id=26483

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit serializing pre, h1, etc... to retain structure and appearance when copying
rich content and pasting did not remove such nodes wrapping the copied contents.

Fixed the bug by extending r81887 and r83322 to remove those elements from where WebKit pastes into.

Test: editing/pasteboard/copy-paste-text-in-h1.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::nodeHasAttributesToPreserve): Extracted from isInlineNodeWithStyle.
(WebCore::isInlineNodeWithStyle): Calls nodeHasAttributesToPreserve.
(WebCore::ReplaceSelectionCommand::doApply): Calls ancestorToRetainStructureAndAppearance.
Remove nodes copied by ancestorToRetainStructureAndAppearance at insertionPos before pasting the fragment.

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearance): Takes ShouldIncludeParagraphSeparators.

  • editing/markup.h:

LayoutTests:

  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-paste-text-in-h1-expected.txt: Added.
  • editing/pasteboard/copy-paste-text-in-h1.html: Added.
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
16:35 Changeset [92329] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641

Reviewed by Darin Adler.

Fix build on non-x86 platforms, by ensuring that the relevant
parameter always appears to be used even when it isn't.

  • heap/Heap.cpp:
16:31 Changeset [92328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Console.idl
https://bugs.webkit.org/show_bug.cgi?id=65569

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/Console.idl:
16:20 Changeset [92327] by commit-queue@webkit.org
  • 34 edits in trunk

Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

  • html/DOMFormData.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/TimeRanges.idl:

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt:
  • fast/files/create-blob-url-crash.html:
  • fast/files/revoke-blob-url-expected.txt:
  • fast/files/revoke-blob-url.html:
  • fast/forms/ValidityState-customError-expected.txt:
  • fast/forms/ValidityState-customError.html:
16:19 Changeset [92326] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Adding Filip Pizlo to committer list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
16:18 Changeset [92325] by jpfau@apple.com
  • 6 edits in trunk/Source/WebCore

Make atomic XML token
https://bugs.webkit.org/show_bug.cgi?id=65639

Reviewed by Adam Barth.

Create a shared AtomicMarkupTokenBase that is shared by AtomicHTMLToken and the new AtomicXMLToken

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::setForceQuirks):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::forceQuirks):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::type):
(WebCore::AtomicMarkupTokenBase::name):
(WebCore::AtomicMarkupTokenBase::setName):
(WebCore::AtomicMarkupTokenBase::selfClosing):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAtributes):
(WebCore::AtomicMarkupTokenBase::characters):
(WebCore::AtomicMarkupTokenBase::comment):
(WebCore::AtomicMarkupTokenBase::publicIdentifier):
(WebCore::AtomicMarkupTokenBase::systemIdentifier):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):
(WebCore::AtomicXMLToken::prefix):
(WebCore::AtomicXMLToken::target):
(WebCore::AtomicXMLToken::data):
(WebCore::AtomicXMLToken::xmlVersion):
(WebCore::AtomicXMLToken::xmlStandalone):

  • xml/parser/XMLTokenizer.cpp:

(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):

16:03 Changeset [92324] by dglazkov@chromium.org
  • 2 edits
    1 add in trunk/Tools

Add "optimize-expectations" command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=65633

For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/init.py: Added command.
  • Scripts/webkitpy/tool/commands/expectations.py: Added.
16:01 Changeset [92323] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
https://bugs.webkit.org/show_bug.cgi?id=65355

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/Geolocation.idl:
  • page/PositionCallback.idl:
  • page/PositionErrorCallback.idl:
15:59 Changeset [92322] by darin@chromium.org
  • 104 edits in trunk/Source/WebKit/chromium

2011-08-03 Darin Fisher <darin@chromium.org>

[Chromium] Rename WEBKIT_API to WEBKIT_EXPORT.
https://bugs.webkit.org/show_bug.cgi?id=65649

Reviewed by Adam Barth.

  • README:
  • public/WebAccessibilityCache.h:
  • public/WebAccessibilityObject.h:
  • public/WebArrayBufferView.h:
  • public/WebAttribute.h:
  • public/WebAudioBus.h:
  • public/WebBindings.h:
  • public/WebBlobData.h:
  • public/WebBlobRegistry.h:
  • public/WebCString.h:
  • public/WebCache.h:
  • public/WebColor.h:
  • public/WebCommon.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMMouseEvent.h:
  • public/WebDOMMutationEvent.h:
  • public/WebDOMStringList.h:
  • public/WebData.h:
  • public/WebDatabase.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDocumentType.h:
  • public/WebDragData.h:
  • public/WebElement.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHTTPBody.h:
  • public/WebHTTPLoadInfo.h:
  • public/WebHistoryItem.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebImage.h:
  • public/WebImageDecoder.h:
  • public/WebInputElement.h:
  • public/WebInputEvent.h:
  • public/WebKit.h:
  • public/WebLabelElement.h:
  • public/WebMediaElement.h:
  • public/WebNamedNodeMap.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebOptionElement.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPluginDocument.h:
  • public/WebPopupMenu.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScriptController.h:
  • public/WebScrollbar.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSerializedScriptValue.h:
  • public/WebSharedWorker.h:
  • public/WebSpeechInputControllerMock.h:
  • public/WebSpeechInputResult.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebStorageNamespace.h:
  • public/WebString.h:
  • public/WebTestingSupport.h:
  • public/WebThreadSafeData.h:
  • public/WebURLLoadTiming.h:
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • public/WebView.h:
  • public/WebWorker.h:
  • public/gtk/WebFontInfo.h:
  • public/gtk/WebInputEventFactory.h:
  • public/linux/WebFontRenderStyle.h:
  • public/linux/WebFontRendering.h:
  • public/linux/WebRenderTheme.h:
  • public/mac/WebInputEventFactory.h:
  • public/mac/WebScreenInfoFactory.h:
  • public/mac/WebSubstringUtil.h:
  • public/win/WebInputEventFactory.h:
  • public/win/WebScreenInfoFactory.h:
  • public/x11/WebScreenInfoFactory.h:
  • tests/WebUnitTests.h:
15:50 Changeset [92321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
https://bugs.webkit.org/show_bug.cgi?id=65566

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/DOMSelection.idl:
15:47 Changeset [92320] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Location.idl
https://bugs.webkit.org/show_bug.cgi?id=65565

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Darin Adler.

No new tests, all existing tests pass.

  • page/Location.idl:
15:42 Changeset [92319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

15:36 Changeset [92318] by michaeln@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Minor cleanup, remove a deprecated method.
The old WebDatabase::updateDatabaseSize method has been replaced with
updateDatabaseSize, updateSpaceAvailable, and resetSpaceAvailable.
https://bugs.webkit.org/show_bug.cgi?id=65553

Reviewed by Adam Barth.

  • public/WebDatabase.h:
  • src/WebDatabase.cpp:
15:34 Changeset [92317] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Allow multiple bug identifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65642

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
15:24 Changeset [92316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

14:58 Changeset [92315] by commit-queue@webkit.org
  • 7 edits in trunk

Remove LegacyDefaultOptionalArguments flag from navigator IDL files
https://bugs.webkit.org/show_bug.cgi?id=65370

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

  • page/Navigator.idl:
  • page/NavigatorUserMediaErrorCallback.idl:
  • page/NavigatorUserMediaSuccessCallback.idl:

LayoutTests:

  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
14:53 Changeset [92314] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

webarchive/loading/missing-data.html is failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=63507

Reviewed by Adam Barth.

When loading a main resource from a web archive, make sure that the working URL is actually
the URL of the resource, and not the URL of the web archive itself.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

14:50 Changeset [92313] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=65353

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • page/DOMWindow.idl:
14:22 Changeset [92312] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91447.

14:16 Changeset [92311] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91438.

14:04 Changeset [92310] by lforschler@apple.com
  • 17 edits in branches/safari-534.51-branch/Source

Merge r91435.

13:52 Changeset [92309] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Chromimum and Qt builds after r92308.

  • config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.
13:15 Changeset [92308] by jeffm@apple.com
  • 3 edits in trunk/Source/WebCore

Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
https://bugs.webkit.org/show_bug.cgi?id=65634

AVFoundation support on Windows will (eventually) be predicated on the
availability of AVFoundationCF headers and libraries in the WebKit Support
Libraries, so we test for the existence of one of the header files (AVCFBase.h)
to determine whether to AVCF is available.

For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).

Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.

Reviewed by Adam Roben.

No change in functionality, so new tests.

  • DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
  • config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.
13:13 Changeset [92307] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fix an error in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:57 Changeset [92306] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.

  • platform/chromium/test_expectations.txt:
12:55 Changeset [92305] by michaeln@google.com
  • 10 edits in branches/chromium/835/Source/WebCore/storage

Merge 92155 - [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486

The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.

Reviewed by Darin Fisher.

No new tests. Existing layout tests cover the version handling functionality.

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::expectedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):

  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):

  • storage/SQLTransactionSync.h:

TBR=michaeln@google.com
Review URL: http://codereview.chromium.org/7563014

12:54 Changeset [92304] by commit-queue@webkit.org
  • 27 edits
    2 copies
    7 adds in trunk

MediaStream API: Implement PeerConnection and SignalingCallback
https://bugs.webkit.org/show_bug.cgi?id=65101

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-03
Reviewed by Adam Barth.

LayoutTests will be provided by a follow-up CL, see <https://bugs.webkit.org/show_bug.cgi?id=56587>.

Source/WebCore:

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSPeerConnectionCustom.cpp: Copied from Source/WebCore/page/MediaStreamClient.h.

(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/custom/V8PeerConnectionCustom.cpp: Added.

(WebCore::V8PeerConnection::constructorCallback):

  • dom/DispatchTask.h: Added.

(WebCore::SimpleDispatchTask::create):
(WebCore::SimpleDispatchTask::performTask):
(WebCore::SimpleDispatchTask::SimpleDispatchTask):
(WebCore::DispatchTask::create):
(WebCore::DispatchTask::performTask):
(WebCore::DispatchTask::DispatchTask):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toPeerConnection):

  • dom/EventTarget.h:
  • p2p/PeerConnection.cpp: Added.

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::init):
(WebCore::PeerConnection::~PeerConnection):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::onNegotiationStarted):
(WebCore::PeerConnection::onNegotiationDone):
(WebCore::PeerConnection::streamAdded):
(WebCore::PeerConnection::streamRemoved):
(WebCore::PeerConnection::onMessage):
(WebCore::PeerConnection::onSignalingMessage):
(WebCore::PeerConnection::toPeerConnection):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::eventTargetData):
(WebCore::PeerConnection::ensureEventTargetData):
(WebCore::PeerConnection::postMessageEvent):
(WebCore::PeerConnection::postSignalingEvent):
(WebCore::PeerConnection::postStreamAddedEvent):
(WebCore::PeerConnection::postStreamRemovedEvent):
(WebCore::PeerConnection::postSimpleEvent):
(WebCore::PeerConnection::postStartNegotiationTask):
(WebCore::PeerConnection::dispatchMessageEvent):
(WebCore::PeerConnection::dispatchSignalingEvent):
(WebCore::PeerConnection::dispatchStreamEvent):
(WebCore::PeerConnection::dispatchSimpleEvent):
(WebCore::PeerConnection::dispatchStartNegotiationTask):

  • p2p/PeerConnection.h: Added.

(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

  • p2p/PeerConnection.idl: Added.
  • p2p/SignalingCallback.h: Copied from Source/WebCore/page/MediaStreamClient.h.

(WebCore::SignalingCallback::~SignalingCallback):

  • p2p/SignalingCallback.idl: Added.
  • page/DOMWindow.idl:
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp:

(WebCore::MediaStreamController::MediaStreamController):
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::onSignalingMessage):
(WebCore::MediaStreamController::frameToPagePeerConnectionId):
(WebCore::MediaStreamController::processSignalingMessage):
(WebCore::MediaStreamController::message):
(WebCore::MediaStreamController::onMessage):
(WebCore::MediaStreamController::addStream):
(WebCore::MediaStreamController::onAddStream):
(WebCore::MediaStreamController::removeStream):
(WebCore::MediaStreamController::onRemoveStream):
(WebCore::MediaStreamController::newPeerConnection):
(WebCore::MediaStreamController::closePeerConnection):
(WebCore::MediaStreamController::startNegotiation):
(WebCore::MediaStreamController::onNegotiationStarted):
(WebCore::MediaStreamController::onNegotiationDone):

  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp:

(WebCore::MediaStreamFrameController::Request::isSignalingRequest):
(WebCore::MediaStreamFrameController::createPeerConnection):
(WebCore::MediaStreamFrameController::newPeerConnection):
(WebCore::MediaStreamFrameController::closePeerConnection):
(WebCore::MediaStreamFrameController::startNegotiation):
(WebCore::MediaStreamFrameController::processSignalingMessage):
(WebCore::MediaStreamFrameController::message):
(WebCore::MediaStreamFrameController::addStream):
(WebCore::MediaStreamFrameController::removeStream):
(WebCore::MediaStreamFrameController::onMessage):
(WebCore::MediaStreamFrameController::onAddStream):
(WebCore::MediaStreamFrameController::onRemoveStream):
(WebCore::MediaStreamFrameController::onSignalingMessage):
(WebCore::MediaStreamFrameController::onNegotiationStarted):
(WebCore::MediaStreamFrameController::onNegotiationDone):

  • page/MediaStreamFrameController.h:

(WebCore::MediaStreamFrameController::ClientBase::isPeerConnection):
(WebCore::MediaStreamFrameController::PeerConnectionClient::PeerConnectionClient):
(WebCore::MediaStreamFrameController::PeerConnectionClient::~PeerConnectionClient):
(WebCore::MediaStreamFrameController::PeerConnectionClient::isPeerConnection):

LayoutTests:

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
12:38 Changeset [92303] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix after gesture recognizer changes.

12:36 Changeset [92302] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Improve position of context menu for QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65635

Reviewed by Andreas Kling.

Do not assume that the QDesktopWebView takes the entire canvas when
positioning the context menu.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::showContextMenu):

12:18 Changeset [92301] by lforschler@apple.com
  • 4 edits in branches/safari-534.51-branch/Source

Merge r90705.

12:09 Changeset [92300] by joepeck@webkit.org
  • 15 edits in trunk/Source

Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582

Reviewed by Pavel Feldman.

Source/WebCore:

Remove stale code. WebInspector.settings uses localStorage and
handles the "debuggerEnabled" state. So remove the only remaining
usage of load/saveSessionSetting.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebCoreSupport/WebInspectorClient.h:
12:06 Changeset [92299] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/page/FrameView.cpp

Merge 92030 - [chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394

Reviewed by James Robinson.

The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path. Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7565014

11:56 Changeset [92298] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser. Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky. In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it. Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

  • fast/loader/reload-zero-byte-plugin-expected.txt: Added.
  • fast/loader/reload-zero-byte-plugin.html: Added.
11:40 Changeset [92297] by senorblanco@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 92227 - [Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560

Reviewed by James Robinson.

No new tests. (Printing has few tests, sadly.)

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7465097

11:38 Changeset [92296] by senorblanco@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 91870 - Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests. Printing itself in Chrome has few tests, sadly. :(

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7564022

11:38 Changeset [92295] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

WebCore images backing CG patterns should be released on the main thread
https://bugs.webkit.org/show_bug.cgi?id=65630

Reviewed by Sam Weinig.

  • platform/graphics/cg/PatternCG.cpp:

(WebCore::patternReleaseOnMainThreadCallback):
Deref the image.

(WebCore::patternReleaseCallback):
Call callOnMainThread.

11:11 Changeset [92294] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Teach BuilderToPort to distinguish between Release and Debug builders.
https://bugs.webkit.org/show_bug.cgi?id=65628

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
10:55 Changeset [92293] by leviw@chromium.org
  • 16 edits
    343 deletes in branches/chromium/835

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

Reviewed by James Robinson.

Rolling back r87526 for Chrome 14.

Source/WebCore:

  • platform/Length.h:

(WebCore::Length::isIntrinsicOrAuto):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::embeddedContentBox):

  • rendering/RenderReplaced.cpp:

(WebCore::lengthIsSpecified):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):

  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::viewBoxToViewTransform):

  • svg/SVGSVGElement.h:

LayoutTests:

  • css2.1/20110323/replaced-intrinsic-001.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-002.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-003.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-004.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-005.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-ratio-001.htm: Removed.
  • http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm: Removed.
  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Removed.
  • http/tests/misc/resources/embedded.svg: Removed.
  • http/tests/misc/resources/intrinsic-ratio-slow.pl: Removed.
  • http/tests/misc/resources/intrinsic-ratio.svg: Removed.
  • http/tests/misc/resources/svg-slow.pl: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Removed.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Removed.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/mac/svg/hixie/text/003-expected.png: Removed.
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Removed.
  • platform/qt-4.8/svg/custom/object-sizing-expected.png: Removed.
  • platform/qt-4.8/svg/custom/object-sizing-expected.txt: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/win/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/win/svg/hixie/intrinsic/003-expected.txt: Removed.
  • svg/custom/object-no-size-attributes.xhtml: Removed.
  • svg/custom/object-sizing-explicit-height.xhtml: Removed.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Removed.
  • svg/custom/object-sizing-explicit-width.xhtml: Removed.
  • svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Removed.
  • svg/custom/object-sizing-no-width-height.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing.xhtml: Removed.
  • svg/custom/resources/embedded.svg: Removed.
  • svg/custom/resources/red-circle.svg: Removed.
  • svg/hixie/intrinsic/001.html: Removed.
  • svg/hixie/intrinsic/002.html: Removed.
  • svg/hixie/intrinsic/003.html: Removed.
  • svg/hixie/intrinsic/resources: Removed.
  • svg/hixie/intrinsic/resources/001.svg: Removed.
  • svg/hixie/intrinsic/resources/002.svg: Removed.
  • svg/hixie/intrinsic/resources/003.svg: Removed.
  • svg/hixie/intrinsic/resources/test-bl: Removed.
  • svg/hixie/intrinsic/resources/test-br: Removed.
  • svg/hixie/intrinsic/resources/test-tl: Removed.
  • svg/hixie/intrinsic/resources/test-tr: Removed.
  • svg/in-html/by-reference-expected.png: Removed.
  • svg/wicd/rightsizing-grid.xhtml: Removed.
  • svg/wicd/test-rightsizing-a.xhtml: Removed.
  • svg/wicd/test-rightsizing-b.xhtml: Removed.
  • svg/zoom/page/resources/intrinsic-ratio.svg: Removed.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Removed.
10:41 Changeset [92292] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix API tests.

Initialize threading before trying to allocate the WebContext.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::create):

10:22 Changeset [92291] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows nightly build fix after r91777

  • Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the

interface to maintain binary compatibility with Safari 5.1.

10:06 Changeset [92290] by andersca@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a Mac Lion skipped list.

  • platform/mac-lion: Added.
  • platform/mac-lion/Skipped: Added.
09:48 Changeset [92289] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Use appropriate macro for CSSPropertyImageRendering.
https://bugs.webkit.org/show_bug.cgi?id=65594

Reviewed by Simon Fraser.

No new tests / trivial code cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

09:48 Changeset [92288] by vsevik@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 92167 - Web Inspector: button + "New style rule"
https://bugs.webkit.org/show_bug.cgi?id=65409

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-add-new-rule.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt: Added.
  • inspector/styles/styles-add-new-rule.html: Added.

TBR=pfeldman@chromium.org
BUG=91217
Review URL: http://codereview.chromium.org/7566008

09:46 Changeset [92287] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font
https://bugs.webkit.org/show_bug.cgi?id=65597

Reviewed by Simon Fraser.

No test added because behavior is unchanged, but this saves a call to getFontData().

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution
to continue and familyIndex to be set.

09:27 Changeset [92286] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Add RenderedPosition
https://bugs.webkit.org/show_bug.cgi?id=65221

Reviewed by Hajime Morita.

Add the skeleton for RenderedPosition and use it in rootBoxForLine.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/EditingAllInOne.cpp:
  • editing/RenderedPosition.cpp: Added.

(WebCore::RenderedPosition::RenderedPosition):

  • editing/RenderedPosition.h: Added.

(WebCore::RenderedPosition::isNull):
(WebCore::RenderedPosition::rootBox):
(WebCore::RenderedPosition::RenderedPosition):

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):

09:15 Changeset [92285] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
https://bugs.webkit.org/show_bug.cgi?id=65598

Reviewed by Dimitri Glazkov.

Added UNKNOWN_RULE to the switch statement.

No new tests. (No semantic change)

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

09:11 Changeset [92284] by pfeldman@chromium.org
  • 26 edits in trunk/Source

Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
https://bugs.webkit.org/show_bug.cgi?id=65510

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawRectHighlight):

  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::drawHighlight):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelinePanel.prototype._hideRectHighlight):

  • inspector/front-end/inspector.js:

(WebInspector.highlightDOMNode):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::paintPageOverlay):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(paintWebView):

Source/WebKit/mac:

  • WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView drawRect:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderRelativeCoords):

Source/WebKit/win:

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

08:56 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.7.x QtWebKit2.2 bot (diff)
08:49 Changeset [92283] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

[Qt] Fix running qmltests for WK2 in the bot
https://bugs.webkit.org/show_bug.cgi?id=65621

Reviewed by Csaba Osztrogonác.

The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
but now there's the case for WK2 UIProcess tests as well.

  • Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
08:33 Changeset [92282] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Add a way to edit test expectations.
https://bugs.webkit.org/show_bug.cgi?id=64922

Implements a TestExpectationsEditor, which provides a standard way to
update and remove test expectations.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,

added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
enchilada.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
08:30 Changeset [92281] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Added two compositing tests whose pixel results on the
Mesa bots are different following
http://trac.webkit.org/changeset/92255.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:09 Changeset [92280] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: make text in popover selectable + make popover re-appear faster.
https://bugs.webkit.org/show_bug.cgi?id=65603

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype.setTimeout):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._handleMouseAction):

  • inspector/front-end/popover.css:

(.popover .content):

07:40 Changeset [92279] by philn@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for media/media-controls-clone.html.

  • platform/gtk/media/media-controls-clone-expected.png: Added.
  • platform/gtk/media/media-controls-clone-expected.txt: Added.
07:33 Changeset [92278] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Console scroll position should be saved when switching panels.
https://bugs.webkit.org/show_bug.cgi?id=65607

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleView.prototype.get scrollLeft):
(WebInspector.ConsoleView.prototype.set scrollLeft):
(WebInspector.ConsoleView.prototype.get scrollTop):
(WebInspector.ConsoleView.prototype.set scrollTop):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype._endStatusBarDragging):
(WebInspector.Drawer.prototype.get scrollLeft):
(WebInspector.Drawer.prototype.set scrollLeft):
(WebInspector.Drawer.prototype.get scrollTop):
(WebInspector.Drawer.prototype.set scrollTop):

07:25 Changeset [92277] by caio.oliveira@openbossa.org
  • 6 edits
    13 adds in trunk

[Qt] [WK2] Expose web view classes to QML
https://bugs.webkit.org/show_bug.cgi?id=65339

Reviewed by Benjamin Poulain.

.:

  • Source/WebKit.pro: Include QML plugin subdir in the build system for WK2.

Source/WebKit2:

This patch also uses QuickTest from QtDeclarative to provide the basic autotest
infrastructure for the exposed elements.

  • UIProcess/API/qt/qmlplugin/plugin.cpp: Added.

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qmlplugin/qmldir: Added.
  • UIProcess/API/qt/qmlplugin/qmlplugin.pro: Added.
  • UIProcess/API/qt/qtouchwebpage.h: Expose load() to QML environment.
  • UIProcess/API/qt/qtouchwebview.h: Since QTouchWebPage* doesn't change once set

in the constructor, we mark the page property as CONSTANT. This avoid QML
warnings for not having a NOTIFY signal for the property change.

  • UIProcess/API/qt/tests/tests.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test1.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro: Added.
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Added.
06:15 Changeset [92276] by andreas.kling@nokia.com
  • 3 edits in trunk/Tools

[Qt] MiniBrowser: Unbreak load progress indication.
https://bugs.webkit.org/show_bug.cgi?id=65614

Reviewed by Kenneth Rohde Christiansen.

loadProgress() was renamed to loadProgressChanged().

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onLoadProgressChanged):

  • MiniBrowser/qt/BrowserWindow.h:
06:05 Changeset [92275] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.

  • platform/chromium/test_expectations.txt:
05:29 Changeset [92274] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Build fix for WebKit2GTK+.

  • WebKitTestRunner/GNUmakefile.am: Include libInternals as one of

of the library dependencies of the injected bundle.

05:20 Changeset [92273] by carlosgc@webkit.org
  • 10 edits in trunk

[GTK] Install web and plugin processes in libexecdir instead of bindir
https://bugs.webkit.org/show_bug.cgi?id=65600

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Initialize libexec_PROGRAMS, only used by

WebKit2 in this moment.

Source/WebKit2:

Launch processes from libexecdir or WEBKIT_EXEC_PATH
environment variable when it's set. This variable will be used by
MiniBrowser and unit tests to find processes without having to
install them.

  • GNUmakefile.am:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

Tools:

Set WEBKIT_EXEC_PATH environment variable to use web and plugin
process from current directory instead of the intalled ones.

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c:

(main):

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/gtk/main.cpp:

(main):

04:55 Changeset [92272] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

[Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
https://bugs.webkit.org/show_bug.cgi?id=65605

  • platform/qt/Skipped: Skip failing tests:
    • fast/frames/lots-of-objects.html
    • fast/frames/lots-of-iframes.html
    • editing/text-iterator/basic-iteration.html
04:14 Changeset [92271] by philn@webkit.org
  • 3 edits in trunk/Source/WebCore

libsoup-CRITICAL : soup_message_io_pause: assertion `io != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Martin Robinson.

Avoid any operation on not yet started messages and completed messages.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::startHTTPRequest): (WebCore::ResourceHandle::platformSetDefersLoading):
03:50 Changeset [92270] by vsevik@chromium.org
  • 8 edits
    1 copy in branches/chromium/835

Merge 91858 - Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/network/network-disable-cache-memory-expected.txt:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/resources/random-script.php: Added.

TBR=pfeldman@chromium.org
BUG=90757
Review URL: http://codereview.chromium.org/7563005

03:48 Changeset [92269] by jeremy@chromium.org
  • 7 edits in trunk/Source

[Chromium] Fix OOP font loading to work on 10.6.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=65543

In 10.6.6 the function used to get the unique ID for an NSFont in the
renderer was changed so it fails in the sandbox (it now tries to access
the on-disk font file). In order to work around this, we get the font
ID from the browser process.

To speed things up, we introduce 2 levels of caching in WebKit. A font
name cache where we can perform a quick lookup without the need for the
font id and a font id cache which we can only lookup in after getting
the unique ID from the browser process.

Reviewed by Kenneth Russell.

No new tests since this is not readily testable.

Source/WebCore:

  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/CrossProcessFontLoading.h:
  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

  • public/mac/WebSandboxSupport.h: Plumb font ID parameter through.
  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::loadFont): ditto.

03:46 Changeset [92268] by philn@webkit.org
  • 31 edits
    3 adds in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r92047.

  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/smallFonts-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/gtk/svg/custom/linking-base-external-reference-expected.txt: Added.
  • platform/gtk/svg/custom/text-linking-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
03:18 Changeset [92267] by vsevik@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp

Merge 91901 - Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::open):

TBR=vsevik@chromium.org
BUG=87345
Review URL: http://codereview.chromium.org/7565004

03:17 Changeset [92266] by hayato@chromium.org
  • 12 edits in trunk/Source/WebCore

Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Hajime Morita.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

This is a minor update of r92256, which failed on chromium win builds.

No changes to functionality so no new tests.

  • dom/Event.cpp:

(WebCore::EventDispatchMediator::create):

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEventDispatchMediator::create):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):

  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::create):

  • dom/WheelEvent.h:
01:28 Changeset [92265] by pfeldman@chromium.org
  • 38 edits in trunk/Source

Web Inspector: remove Node parameter from the InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlight):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::highlight):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::highlight):

  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::highlight):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::highlight):

  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::highlight):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/InspectorClientHaiku.cpp:

(WebCore::InspectorClientHaiku::highlight):

  • WebCoreSupport/InspectorClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::highlight):

  • WebInspector/WebNodeHighlighter.h:
  • WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::highlight):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::highlight):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/InspectorClientWinCE.cpp:

(WebKit::InspectorClientWinCE::highlight):

  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/InspectorClientWx.cpp:

(WebCore::InspectorClientWx::highlight):

  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
01:20 Changeset [92264] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65599
Image loads should trigger didFirstVisuallyNonEmptyLayout more easily

Reviewed by Dan Bernstein.

Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout.

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

00:43 Changeset [92263] by carlosgc@webkit.org
  • 9 edits
    2 moves in trunk

[GTK] Reorganize pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=65548

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which

are common to all libraries.

  • configure.ac: Update pkg-config files.

Source/JavaScriptCore:

  • GNUmakefile.am:
  • javascriptcoregtk.pc.in: Renamed from Source/WebKit/gtk/javascriptcoregtk.pc.in.

Source/WebKit/gtk:

  • GNUmakefile.am: Remove javascriptcore pc file references.

Source/WebKit2:

  • GNUmakefile.am: Rename pc file as webkit2gtk.pc.in. WebKit2

depends on gtk3 unconditionally so we don't need to use
WEBKITGTK_PC_NAME.

  • webkit2gtk.pc.in: Renamed from Source/WebKit2/gtk/webkit2.pc.in.
00:06 Changeset [92262] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebSocket: Could not handle zero length text frame.
https://bugs.webkit.org/show_bug.cgi?id=65592

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/zero-length-text.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

LayoutTests:

  • http/tests/websocket/tests/hybi/zero-length-text-expected.txt: Added.
  • http/tests/websocket/tests/hybi/zero-length-text.html: Added.
  • http/tests/websocket/tests/hybi/zero-length-text_wsh.py: Added.

08/02/11:

22:07 Changeset [92261] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584

Reviewed by David Kilzer.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.

21:37 Changeset [92260] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebSocket: Should be closed by receiving invalid continuation frame.

https://bugs.webkit.org/show_bug.cgi?id=65527

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-02
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/invalid-continuation.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

LayoutTests:

  • http/tests/websocket/tests/hybi/invalid-continuation-expected.txt: Added.
  • http/tests/websocket/tests/hybi/invalid-continuation.html: Added.
  • http/tests/websocket/tests/hybi/invalid-continuation_wsh.py: Added.
21:26 Changeset [92259] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r92256.
http://trac.webkit.org/changeset/92256
https://bugs.webkit.org/show_bug.cgi?id=65593

Causing tons of crashes on the chromium win bots (Requested by
jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-02

  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.cpp:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:
  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):

  • dom/WheelEvent.cpp:
  • dom/WheelEvent.h:
20:59 Changeset [92258] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

More expectation updates for r92255

  • platform/chromium/test_expectations.txt:
20:26 Changeset [92257] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Expectation follow-up for r92255

  • platform/chromium/test_expectations.txt:
20:25 Changeset [92256] by hayato@chromium.org
  • 12 edits in trunk/Source/WebCore

Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Dimitri Glazkov.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

No changes to functionality so no new tests.

  • dom/Event.cpp:

(WebCore::EventDispatchMediator::create):

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEventDispatchMediator::create):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):

  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::create):

  • dom/WheelEvent.h:
19:52 Changeset [92255] by jamesr@google.com
  • 15 edits in trunk

Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Use an edge distance based method instead of the current linear
filtering method for producing anti-aliased edges on 3D transformed
layers. This removes the outer border handling from TilingData as
it's no longer needed for anti-aliasing.

Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing)

platform/chromium/compositing/huge-layer-rotated.html (existing)
compositing/images/content-image-change.html (existing)
TilingDataTest in webkit_unit_tests

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::screenMatrix):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::windowMatrix):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderTile::VertexShaderTile):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderTile::getShaderString):
(WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding):
(WebCore::FragmentTexAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderTile::vertexTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::alphaLocation):
(WebCore::FragmentTexAlphaAABinding::samplerLocation):
(WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::edgeLocation):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::setIsMask):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::intersectDrawQuad):
(WebCore::TilingData::textureOffset):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Update expected results.

  • platform/chromium/test_expectations.txt:
19:28 Changeset [92254] by levin@chromium.org
  • 14 edits
    3 adds in trunk/Source

Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider): Ditto.

  • wtf/CMakeLists.txt: Added new files to the build.
  • wtf/ThreadRestrictionVerifier.h: Added.

Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):

  • wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
  • wtf/text/CString.h:

(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium (bug 58093).

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.

Source/WebCore:

No new functionality exposed so no new tests. (The change is basically adding
more testing.)

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.

19:11 Changeset [92253] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=65441

Reviewed by Simon Fraser.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getFloatValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getIntValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getValue):
Templated getValue that works for all numeric types.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use getValue<short> instead of rolling-your-own clamp to short.

18:58 Changeset [92252] by jchaffraix@webkit.org
  • 35 edits in trunk/Source/WebCore

RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
https://bugs.webkit.org/show_bug.cgi?id=65494

Reviewed by Darin Adler.

No new tests, const-ness change only.

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
Made those 2 const as they call a const method now.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as
this is const.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::rectWithOutlineForRepaint):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:

(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):

  • rendering/svg/SVGRenderSupport.h:

Updated the following method's signature to use a const object.

18:48 Changeset [92251] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC may not be able to reuse partially-free blocks after a
full collection
https://bugs.webkit.org/show_bug.cgi?id=65585

Reviewed by Darin Adler.

This fixes the linked list management bug. This fix is performance
neutral on SunSpider.

  • heap/NewSpace.cpp:

(JSC::NewSpace::removeBlock):

17:41 Changeset [92250] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422

Reviewed by Gavin Barraclough.

Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject. This doesn't impact performance, but
we can use this change to make other improvements later.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):

17:04 Changeset [92249] by jpfau@apple.com
  • 4 edits in trunk/Source/WebCore

Add namespace prefix support in XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65578

Reviewed by Adam Barth.

This also changes markup debug printing to print to stderr instead of stdout

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::printString):

  • xml/parser/XMLToken.h:

(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):
(WebCore::XMLToken::clear):
(WebCore::XMLToken::appendToName):
(WebCore::XMLToken::name):
(WebCore::XMLToken::target):
(WebCore::XMLToken::data):
(WebCore::XMLToken::prefix):
(WebCore::XMLToken::xmlDeclarationData):
(WebCore::XMLToken::endPrefix):
(WebCore::XMLToken::hasPrefix):
(WebCore::XMLToken::endAttributePrefix):
(WebCore::XMLToken::attributeHasPrefix):
(WebCore::XMLToken::printAttrs):
(WebCore::XMLToken::print):

  • xml/parser/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::nextToken):

17:02 Changeset [92248] by zmo@google.com
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r92238.
http://trac.webkit.org/changeset/92238
https://bugs.webkit.org/show_bug.cgi?id=65555

fail fast/events/scrollbar-double-click.html on Mac

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::paint):

16:47 Changeset [92247] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from History.idl
https://bugs.webkit.org/show_bug.cgi?id=65572

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/History.idl:
16:41 Changeset [92246] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
https://bugs.webkit.org/show_bug.cgi?id=65571

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/WebKitAnimationList.idl:
16:20 Changeset [92245] by commit-queue@webkit.org
  • 25 edits
    2 copies in trunk/Source

[chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms
https://bugs.webkit.org/show_bug.cgi?id=58840

Patch by James Robinson <jamesr@chromium.org> on 2011-08-02
Reviewed by Kenneth Russell.

This decouples the layer visibility related calculations from the LayerChromium and CCLayerImpl trees. This is
done by making LayerRendererChromium's "calculate the world" function (renamed
calculateDrawTransformsAndVisibility()) a templated, free function that can operate on either LayerChromium +
RenderSurfaceChromium pairs or on CCLayerImpl + CCRenderSurface pairs and invoking it twice, once before
painting and once before drawing. Before painting, these calculations are used to determine which layers are
potentially visible and should be painted, which depends on the calculated opacity, render surface bounds, and
draw transforms. Before drawing, these calculations are used to figure out everything needed to draw.

RenderSurfaceChromium is now used just for visibility calculations when painting. CCRenderSurfaceChromium is
responsible for actually drawing the render surfaces.

This does mean that in the current implementation the second calculations are redundant, but in the future this
won't be the case since the pre-draw time calculations might be influenced by animations or gestures. I've
added some traces to try to monitor if this math is a significant amount of the per-frame computation. Note
that layer sorting only happens on the CCLayerImpl tree and the layer sort algorithm is the most expensive part
of the calculations currently.

This removes all of the weak back/forward pointers between LayerChromium and CCLayerImpls, the trees are now
truly decoupled.

Covered by compositing/ tests.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
(WebCore::LayerChromium::createCCLayerImpl):
(WebCore::LayerChromium::createRenderSurface):
(WebCore::LayerChromium::descendantsDrawsContent):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setUsesLayerScissor):
(WebCore::LayerChromium::usesLayerScissor):
(WebCore::LayerChromium::clearRenderSurface):
(WebCore::LayerChromium::renderSurface):
(WebCore::LayerChromium::drawOpacity):
(WebCore::LayerChromium::setDrawOpacity):
(WebCore::LayerChromium::scissorRect):
(WebCore::LayerChromium::setScissorRect):
(WebCore::LayerChromium::targetRenderSurface):
(WebCore::LayerChromium::setTargetRenderSurface):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::drawableContentRect):
(WebCore::LayerChromium::setDrawableContentRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::~RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::clearLayerList):
(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::setMaskLayer):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::tilingTransform):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTreeRecursive):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(WebCore::CCCanvasLayerImpl::create):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::bindContentsTexture):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::renderSurface):
(WebCore::CCLayerImpl::targetRenderSurface):
(WebCore::CCLayerImpl::setTargetRenderSurface):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::create):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp.

(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::~CCRenderSurface):
(WebCore::CCRenderSurface::cleanupResources):
(WebCore::CCRenderSurface::layerRenderer):
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::name):
(WebCore::writeIndent):
(WebCore::CCRenderSurface::dumpSurface):
(WebCore::CCRenderSurface::owningLayerId):

  • platform/graphics/chromium/cc/CCRenderSurface.h: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h.

(WebCore::CCRenderSurface::contentRectCenter):
(WebCore::CCRenderSurface::drawOpacity):
(WebCore::CCRenderSurface::setDrawOpacity):
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScissorRect):
(WebCore::CCRenderSurface::scissorRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::contentRect):
(WebCore::CCRenderSurface::setSkipsDraw):
(WebCore::CCRenderSurface::skipsDraw):
(WebCore::CCRenderSurface::clearLayerList):
(WebCore::CCRenderSurface::layerList):
(WebCore::CCRenderSurface::setMaskLayer):
(WebCore::CCRenderSurface::contentsTexture):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::create):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore::CCVideoLayerImpl::create):

16:18 Changeset [92244] by andersca@apple.com
  • 3 edits in trunk/Tools

Add mac-lion platform to old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65577

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

(isLion):

16:15 Changeset [92243] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition and CSSPropertyWebkitTextEmphasisStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=65517

Reviewed by Dimitri Glazkov.

No new tests. Just refactoring and moving code around.

  • css/CSSStyleApplyProperty.cpp:

Added class ApplyPropertyTextEmphasisStyle to handle the special TextEmphasisStyle logic.
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added initializations for CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition, CSSPropertyWebkitTextEmphasisStyle.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations.

15:47 Changeset [92242] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
https://bugs.webkit.org/show_bug.cgi?id=65570

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass

  • page/SpeechInputResultList.idl:
15:41 Changeset [92241] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from EventSource.idl
https://bugs.webkit.org/show_bug.cgi?id=65568

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/EventSource.idl:
15:19 Changeset [92240] by commit-queue@webkit.org
  • 2 edits in trunk

Missing null check in WebViewImpl::selectionRange
https://bugs.webkit.org/show_bug.cgi?id=65561

Patch by Varun Jain <varunjain@google.com> on 2011-08-02
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/src/WebViewImpl.cpp:
15:17 Changeset [92239] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

fail earlier to track down null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=65563

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.

Reviewed by Alexey Proskuryakov.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

15:11 Changeset [92238] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555

Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-02
Reviewed by James Robinson.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterSetEnabled):

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

14:36 Changeset [92237] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65337

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Nikolas Zimmermann.

No new tests, all existing tests pass.

  • svg/ElementTimeControl.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGException.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStylable.idl:
  • svg/SVGStyleElement.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
14:35 Changeset [92236] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from CSS IDL files
https://bugs.webkit.org/show_bug.cgi?id=65341

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests. All existing tests pass.

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
14:33 Changeset [92235] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update, gardener stuff.

  • platform/chromium/test_expectations.txt:
14:26 Changeset [92234] by commit-queue@webkit.org
  • 21 edits in trunk/Source

[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Source/WebCore:

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:

Added symbolic contstant for tick multiplier.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Reviewed by Adam Barth.

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
14:22 Changeset [92233] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

JSC GC uses dummy cells to avoid having to remember which cells
it has already destroyed
https://bugs.webkit.org/show_bug.cgi?id=65556

Reviewed by Oliver Hunt.

This gets rid of dummy cells, and ensures that it's not necessary
to invoke a destructor on cells that have already been swept. In
the common case, a block knows that either all of its free cells
still need to have destructors called, or none of them do, which
minimizes the amount of branching that needs to happen per cell
when performing a sweep.

This is performance neutral on SunSpider and V8. It is meant as
a stepping stone to simplify the implementation of more
sophisticated sweeping algorithms.

  • heap/Heap.cpp:

(JSC::CountFunctor::ClearMarks::operator()):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedReset):
(JSC::MarkedBlock::reset):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::produceFreeList):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::FreeCell::setNoObject):
(JSC::MarkedBlock::setDestructorState):
(JSC::MarkedBlock::destructorState):
(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):

  • runtime/JSGlobalData.h:
  • runtime/Structure.h:
14:22 Changeset [92232] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list.

  • platform/mac/Skipped:
14:19 Changeset [92231] by msaboff@apple.com
  • 6 edits in trunk/Source

Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
https://bugs.webkit.org/show_bug.cgi?id=65502

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
added an assert to the return code of madvise to catch any regressions.

  • wtf/TCSystemAlloc.cpp:

(TCMalloc_SystemRelease):

Source/WebCore:

Change the vm_copy in PurgeableBuffer::create to be a memcpy. The
vm_copy causes the process to have additional references to the same
memory region. These additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.

No tests added this is a resource defect and not a functional issue.

  • platform/mac/PurgeableBufferMac.cpp:

(WebCore::PurgeableBuffer::create):

Source/WebKit2:

Changed OOL message to use MACH_MSG_PHYSICAL_COPY flag instead of virtual flag
so that the original memory region isn't referenced by the message and ultimately
the receiving process. The additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

14:13 Changeset [92230] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Windows build.

14:08 Changeset [92229] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update, gardener stuff.

  • platform/chromium/test_expectations.txt:
14:06 Changeset [92228] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

  • fast/blockflow/japanese-rl-text-with-broken-font.html:

This test would create an empty RenderText after the change to make it asynchronous.
Fix this by putting the script inside the head.

14:06 Changeset [92227] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560

Reviewed by James Robinson.

No new tests. (Printing has few tests, sadly.)

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.

13:52 Changeset [92226] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix a Windows build error.

13:47 Changeset [92225] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, mark SelectPopupMenuTest.SelectItemKeyEvent as flaky, gardener stuff.

  • tests/PopupMenuTest.cpp:

(WebKit::TEST_F):

13:40 Changeset [92224] by fpizlo@apple.com
  • 10 edits in trunk/Source

JSC GC is far too conservative about growing the heap size, particularly
on desktop platforms
https://bugs.webkit.org/show_bug.cgi?id=65438

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The minimum heap size is now 16MB instead of 512KB, provided all of the
following are true:
a) ENABLE(LARGE_HEAP) is set, which currently only happens on

x86 targets, but could reasonably happen on any platform that is
known to have a decent amount of RAM.

b) JSGlobalData is initialized with HeapSize = LargeHeap, which

currently only happens when it's the JSDOMWindowBase in WebCore or
in the jsc command-line tool.

This is a 4.1% speed-up on SunSpider.

(JSC::Heap::Heap):
(JSC::Heap::collect):

  • heap/Heap.h:
  • jsc.cpp:

(main):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:
  • wtf/Platform.h:

Source/WebCore:

No change in behavior, thus no new tests.

Pass the LargeHeap hint to JSGlobalData when creating the JSC runtime
instance corresponding to non-worker JS code.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

13:38 Changeset [92223] by commit-queue@webkit.org
  • 11 edits in trunk

--webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
https://bugs.webkit.org/show_bug.cgi?id=61346

Patch by Van Lam <vanlam@google.com> on 2011-08-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

When collecintg word boundaries in a box, explicitly check if the box
is at the end of line (so it should contain the end-of-line position)
and collect the end-of-line position.

  • editing/visible_units.cpp:

(WebCore::isBoxVisuallyLastInLine):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):

LayoutTests:

Updated test cases to check for visual word movement to the end-of-line
position.

  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-multi-line.html:
  • editing/selection/move-by-word-visually-multi-space-expected.txt:
  • editing/selection/move-by-word-visually-multi-space.html:
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-inline-element.html:
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
13:31 Changeset [92222] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update, gardener stuff.

  • platform/chromium/test_expectations.txt:
13:24 QtWebKitRelease22 edited by joel.parks@nokia.com
(diff)
13:12 Changeset [92221] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Should save scroll positions for network panel Response and Preview tabs.
https://bugs.webkit.org/show_bug.cgi?id=65557

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkItemView.js:

(WebInspector.ResourceContentView.prototype.get innerView):
(WebInspector.ResourceContentView.prototype.set innerView):
(WebInspector.ResourceContentView.prototype.hide):

  • inspector/front-end/ResourcePreviewView.js:

(WebInspector.ResourcePreviewView.prototype.contentLoaded):

  • inspector/front-end/ResourceResponseView.js:

(WebInspector.ResourceResponseView.prototype.contentLoaded):

13:06 Changeset [92220] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
https://bugs.webkit.org/show_bug.cgi?id=65554

Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-02
Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:00 Changeset [92219] by jochen@chromium.org
  • 6 edits
    2 adds in trunk

Tools: Implement WebPermissionClient::allowPlugins for layout tests
https://bugs.webkit.org/show_bug.cgi?id=33991

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setPluginsAllowed):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowPlugins):
(WebPermissions::setPluginsAllowed):
(WebPermissions::reset):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add a test for FrameLoaderClient::allowPlugins
https://bugs.webkit.org/show_bug.cgi?id=33991

Reviewed by Adam Barth.

  • platform/chromium/permissionclient/plugin-permission-expected.txt: Added.
  • platform/chromium/permissionclient/plugin-permission.html: Added.
12:57 Changeset [92218] by abarth@webkit.org
  • 2 edits in trunk/Tools

TestFailures unit tests leak a global variable
https://bugs.webkit.org/show_bug.cgi?id=65500

Reviewed by Adam Roben.

qunit detects the leak if you check the "noglobals" box on run-unittests.html.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
12:57 Changeset [92217] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445

Reviewed by Oliver Hunt.

If the high watermark is not reached, then we allocate new blocks as
before. If the current watermark does reach (or exceed) the high
watermark, then we check if there is a block on the free block pool.
If there is, we simply allocation from it. If there isn't, we
invoke a collectin as before. This effectively couples the elastic
scavenging to the collector's decision function. That is, if an
application rapidly varies its heap usage (sometimes using more and
sometimes less) then the collector will not thrash as it used to.
But if heap usage drops and stays low then the scavenger thread and
the GC will eventually reach a kind of consensus: the GC will set
the watermark low because of low heap usage, and the scavenger thread
will steadily eliminate pages from the free page pool, until the size
of the free pool is below the high watermark.

On command-line, this is neutral on SunSpider and Kraken and a 3% win
on V8. In browser, this is a 1% win on V8 and neutral on the other
two.

  • heap/Heap.cpp:

(JSC::Heap::allocateSlowCase):
(JSC::Heap::allocateBlock):

  • heap/Heap.h:
12:50 Changeset [92216] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Ignore empty requests on policy decisions.
https://bugs.webkit.org/show_bug.cgi?id=64536

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-02
Reviewed by Kenneth Rohde Christiansen.

This is the same fix introduced in the GTK+ port in r41313: empty
request should be ignored, so tests such as
fast/loader/empty-embed-src-attribute.html do not crash.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

12:15 Changeset [92215] by zmo@google.com
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline, gardener stuff.

  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/chromium/test_expectations.txt:
11:45 Changeset [92214] by lforschler@apple.com
  • 11 edits in branches/safari-534.51-branch

Merge r91616.

11:41 Changeset [92213] by vsevik@chromium.org
  • 8 edits
    1 copy in trunk

Web Inspector: Remove initator column for JSC, fix network resource initiator tests.
https://bugs.webkit.org/show_bug.cgi?id=65534

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

():

LayoutTests:

  • http/tests/inspector/network/network-initiator-expected.txt:
  • http/tests/inspector/network/network-initiator.html:
  • platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-initiator-expected.txt.
11:32 Changeset [92212] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: SourceFrame should store saved scroll positions in View.
https://bugs.webkit.org/show_bug.cgi?id=65472

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._sourceFileChanged):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.get scrollLeft):
(WebInspector.SourceFrame.prototype.set scrollLeft):
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):

  • inspector/front-end/View.js:

(WebInspector.View.prototype._innerShow):
(WebInspector.View.prototype._innerHide):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.storeScrollPositions):
(WebInspector.View.prototype.inheritScrollPositionsFromView):
(WebInspector.View.prototype.restoreScrollPositions):

11:32 Changeset [92211] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation updates, gardener stuff.

  • platform/chromium/test_expectations.txt:
11:29 Changeset [92210] by jeffm@apple.com
  • 4 edits in trunk/Source

Move WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=65552

Since this is a WebCore feature, there's no need to define it in JavaScriptCore/wtf/platform.h.

Reviewed by Adam Roben.

Source/JavaScriptCore:

  • wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.

Source/WebCore:

No change in functionality, so new tests.

  • config.h: Added WTF_USE_AVFOUNDATION.
11:29 Changeset [92209] by andersca@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add Snow Leopard specific test results.

  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
11:26 Changeset [92208] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove time out expectation since media/track has been added to the skipped list on GTK.

  • platform/gtk/test_expectations.txt:
11:07 Changeset [92207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Split RenderBlock::layoutRunsAndFloats into multiple methods
https://bugs.webkit.org/show_bug.cgi?id=65376

Extracted layoutRunsAndFloatsInRange, linkToEndLineIfNeeded and repaintDirtyFloats methods and moved
most of the locals to LineLayoutState.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-02
Reviewed by David Hyatt.

No new tests needed because it is just refactoring existing code.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::repaintDirtyFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):

10:53 Changeset [92206] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
https://bugs.webkit.org/show_bug.cgi?id=65519

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::setViewport):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

10:37 Changeset [92205] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove expectations for no longer crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed expectation update.

These were fixed after Chromium r94376, r94374, r94373.

  • platform/chromium/test_expectations.txt:
10:36 Changeset [92204] by simonjam@chromium.org
  • 18 edits
    2 copies in branches/chromium/835

Merge 92143 - .: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • Source/autotools/symbols.filter:

Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).

With this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load. Test added for crash discovered in
previous revision, but no tests for memory usage.

Test: http/tests/inspector/network/disabled-cache-crash.html

  • WebCore.exp.in:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasOneHandle):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

  • loader/cache/CachedResourceLoader.h:
  • testing/Internals.cpp:

(WebCore::Internals::disableMemoryCache):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006

Test for CachedResourceLoader. Not caused by cache-disabling but very
difficult to reproduce when cache is active, so use cache disable in
inspector to exercise code.

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

  • http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
  • http/tests/inspector/network/disabled-cache-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7548016

10:33 Changeset [92203] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
https://bugs.webkit.org/show_bug.cgi?id=65498

Reviewed by Dimitri Glazkov.

  • WebCore.gyp/mac/adjust_visibility.sh:
10:31 Changeset [92202] by simonjam@chromium.org
  • 4 edits in branches/chromium/835/Source/WebCore

Merge 91725 - REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Rollback previous patch. Occasional crashes seen caused by
CachedResource being deleted twice.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):

  • loader/cache/CachedResourceLoader.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7542020

10:16 Changeset [92201] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Removed a dangling reference to Leopard Intel Release (Build).

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:08 Changeset [92200] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by David Hyatt.

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block. We choose the insertion
point to be the first child only if the anonymous block has children, otherwise the before element ends up
in a wrong block.

Tests: fast/dynamic/hover-before-position-after-style-change.html

fast/dynamic/hover-before-position-after-style-change2.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
  • fast/dynamic/hover-before-position-after-style-change.html: Added.
  • fast/dynamic/hover-before-position-after-style-change2-expected.txt: Added.
  • fast/dynamic/hover-before-position-after-style-change2.html: Added.
10:00 Changeset [92199] by jocelyn.turcotte@nokia.com
  • 6 edits
    1 copy in trunk/Source/WebKit2

[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
https://bugs.webkit.org/show_bug.cgi?id=65378

Reviewed by Benjamin Poulain.

This prevent the runner of the tests from having to add it to PATH himself.

  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::tst_CommonViewTests):

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::tst_QDesktopWebView):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::tst_QTouchWebView):

  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.cpp: Copied from Source/WebKit2/UIProcess/API/qt/tests/util.h.

Move definitions to a cpp file to prevent unused static symbol warnings.
(addQtWebProcessToPath):
(waitForSignal):

  • UIProcess/API/qt/tests/util.h:
10:00 Changeset [92198] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

TiledDrawingArea: Handle update requests in the order they were received.
https://bugs.webkit.org/show_bug.cgi?id=64365

Reviewed by Andreas Kling.

TiledDrawingAreaProxy::createTiles() uses the distance of tiles to the
center of the viewport to decide which tile should be rendered first.
This logic is useless if the requests are not handled in the same order
as they were received.
Now use a list instead of a map to hold pending tile update requests.

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::cancelTileUpdate):
(WebKit::TiledDrawingArea::requestTileUpdate):

  • WebProcess/WebPage/TiledDrawingArea.h:
09:34 Changeset [92197] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Simplify Path::translate() implementation.
https://bugs.webkit.org/show_bug.cgi?id=65540

Patch by Andreas Kling <kling@webkit.org> on 2011-08-02
Reviewed by Benjamin Poulain.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::translate):

08:59 Changeset [92196] by podivilov@chromium.org
  • 6 edits in trunk

Web Inspector: merge FormattedSourceFile into SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65411

Reviewed by Pavel Feldman.

Prepare for splitting SourceFile into RawSourceCode and UISourceCode:

  • merge FormattedSourceFile into SourceFile
  • rename SourceFile to RawSourceCode
  • hide formatter worker lazy creation in ScriptFormatter

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.ScriptFormatter.prototype.get _worker):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._invokeRequestContentCallbacks):

LayoutTests:

  • inspector/debugger/source-file.html:
08:58 Changeset [92195] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSSRegions]Fix build after changeset 92106
https://bugs.webkit.org/show_bug.cgi?id=65539

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by Adam Roben.

No new tests since it is just a build fix.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

08:54 Changeset [92194] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
https://bugs.webkit.org/show_bug.cgi?id=65466

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator-from-console.html

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

LayoutTests:

  • http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
  • http/tests/inspector/network/network-initiator-from-console.html: Added.
08:52 Changeset [92193] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: REGRESSION(r92105): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65525

  • platform/qt/Skipped: Unskip tests, because r92185 fixed the bug.
08:51 Changeset [92192] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
https://bugs.webkit.org/show_bug.cgi?id=65514

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/elements-panel-styles.html:
08:25 Changeset [92191] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

CSS Regions build bot should archive and upload output files
https://bugs.webkit.org/show_bug.cgi?id=65200

Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.

The "features" argument is now taken into account when determining the name of the archive on the server. That
was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-02
Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
08:18 Changeset [92190] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove overlapping recursive layout function
https://bugs.webkit.org/show_bug.cgi?id=63241

First, _ewk_view_layout_if_needed_recursive is called twice in _ewk_view_smart_calculate
and _ewk_view_tiled_updates_process_pre,so it is no problem removing one of them.
Second, In tiled backingstore configuration, _ewk_view_layout_if_needed_recursive called
in _ewk_view_smart_calculate will result in generating repaints for dirty areas
located outside of viewport since m_paintEntireContents is set.
But, the areas will not be actually painted. Thus, the layout is unnecessary except
when there is something to paint inside of viewport, which will consume CPU unnecessarily.
So,the layout func was removed from _ewk_view_smart_calculate
and added to _ewk_view_single_smart_repaints_process for single backingstore.

Patch by Eunsol Park <eunsol47.park@samsung.com> on 2011-08-02
Reviewed by Antonio Gomes.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_calculate):

  • ewk/ewk_view_single.c:

(_ewk_view_single_smart_repaints_process):

08:08 Changeset [92189] by gyuyoung.kim@samsung.com
  • 7 edits
    3 adds in trunk/Source

[EFL] Add fullscreen button to media control UI.
https://bugs.webkit.org/show_bug.cgi?id=64428

Source/WebCore:

Implement paintMediaFullscreenButton and emit fullscreen signal.

Reviewed by Antonio Gomes.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):

  • platform/efl/RenderThemeEfl.h:

Source/WebKit/efl:

Implement functions for full screen in ChromeClientEfl in order to display a full screen button on media control UI.
When full screen mode is activated by pressing the button, the functions are called by Document. So, if there is no implemented
function, full screen button will not be shown.
In addition, a .edc file and an image file are added for full screen button.

Reviewed by Antonio Gomes.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Added.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Added.
  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::supportsFullScreenForElement):
(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientEfl.h:
07:11 Changeset [92188] by paroga@webkit.org
  • 2 edits in trunk/Tools

Fix _win32_check_running_pid on 64bit windows python
https://bugs.webkit.org/show_bug.cgi?id=64950

Reviewed by Adam Roben.

Use the correct types for the PROCESSENTRY32 struct.
th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
failure, when calling the Process32First function.
This is covered by the executive unittest.

  • Scripts/webkitpy/common/system/executive.py:
07:01 Changeset [92187] by caseq@chromium.org
  • 5 edits
    2 adds in trunk

2011-08-01 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
https://bugs.webkit.org/show_bug.cgi?id=65476

  • fixed webInspector.inspectedWindow.reload(), brought tests back.
  • removed redundant setting of user agent in FrameLoader::loadResourceSynchronously()

Reviewed by Yury Semikhatsky.

Test: http/tests/inspector/extensions-useragent.html

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):

2011-08-01 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
https://bugs.webkit.org/show_bug.cgi?id=65476

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-useragent-expected.txt: Added.
  • http/tests/inspector/extensions-useragent.html: Added.
06:58 Changeset [92186] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042
Remove mark as expected fail where unexpected pass and mark failing test case as expected fail

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):

06:54 Changeset [92185] by pfeldman@chromium.org
  • 6 edits
    1 copy in trunk

2011-08-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing inspector tests.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

2011-08-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing inspector tests.

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-sorting-expected.txt.
06:43 Changeset [92184] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-02 Pavel Feldman <pfeldman@google.com>

Not reviewed: one line inspector style change.

  • inspector/front-end/networkLogView.css: (.network-error-row, .network-error-row .network-cell-subtitle):
06:39 Changeset [92183] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-02
Reviewed by Martin Robinson.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.

05:38 Changeset [92182] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::viewModes() API test
https://bugs.webkit.org/show_bug.cgi?id=65531

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.

  • tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail

(tst_QWebPage::viewModes):

05:34 Changeset [92181] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Malformed chromium test expectation fix, again. Sorry for the spam...

  • platform/chromium/test_expectations.txt:
05:13 Changeset [92180] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
https://bugs.webkit.org/show_bug.cgi?id=65170

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.

  • tests/qwebframe/tst_qwebframe.cpp: Mark failing test case as expected fail

(tst_QWebFrame::connectAndDisconnect):

05:13 Changeset [92179] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebElement::render() API test
https://bugs.webkit.org/show_bug.cgi?id=65243

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.

  • tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail

(tst_QWebElement::render):

05:02 Changeset [92178] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Fix malformed chromium test expectation introduced by r92173

  • platform/chromium/test_expectations.txt:
04:06 Changeset [92177] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening. Paint the Qt Snow Leopard bot green.

  • platform/qt-mac/Skipped: Skip a failing test.
04:00 Changeset [92176] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Add comment after r92175.
03:57 Changeset [92175] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Paint the Qt bot green.

  • platform/qt/Skipped: Skip failing tests.
03:49 Changeset [92174] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations.txt update for r92165

  • platform/chromium/test_expectations.txt:
02:50 Changeset [92173] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/text/international/bidi-mirror-he-ar.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65524

Just update test_expectations.txt

  • platform/chromium/test_expectations.txt:
02:47 Changeset [92172] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r92127.

  • platform/qt/editing/selection/4397952-expected.png: Updated.
  • platform/qt/editing/selection/4397952-expected.txt: Updated.
02:25 Changeset [92171] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones.
https://bugs.webkit.org/show_bug.cgi?id=65468

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScriptSource.js:
02:20 Changeset [92170] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: 404/errors should get a RED visual treatment so easier to identify.
https://bugs.webkit.org/show_bug.cgi?id=65471

Reviewed by Yury Semikhatsky.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

  • inspector/front-end/networkLogView.css:

(.network-error-cell):

01:46 Changeset [92169] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=65244

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.

  • tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail

(tst_QWebElement::style):

01:05 Changeset [92168] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix.
https://bugs.webkit.org/show_bug.cgi?id=65467

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._messagesClicked):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement):

  • inspector/front-end/inspector.css:

(.properties-tree li):
(.properties-tree li.parent::before):

  • inspector/front-end/treeoutline.js:

(TreeElement.treeElementToggled):

01:03 Changeset [92167] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: button + "New style rule"
https://bugs.webkit.org/show_bug.cgi?id=65409

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-add-new-rule.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt: Added.
  • inspector/styles/styles-add-new-rule.html: Added.

08/01/11:

20:47 Changeset [92166] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic should call optimize-baselines when rebaselining tests
https://bugs.webkit.org/show_bug.cgi?id=65499

Reviewed by Dimitri Glazkov.

I took the opportunity to modernize this code to use some of our more
powerful primitives from base.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
20:09 Changeset [92165] by andersca@apple.com
  • 5 edits in trunk/LayoutTests

Update Lion specific test results.

  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
18:42 Changeset [92164] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Don't set m_fontDirty when setting zoom unless zoom has actually changed
https://bugs.webkit.org/show_bug.cgi?id=65092

Reviewed by Darin Adler.

No new tests as no functionality changed - this is an optimization that
should be logically equivalent to the current code.

The intent here is to avoid setting m_fontDirty unless the fornt information is actually dirty.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
Use setZoom and setEffectiveZoom wrapper functions.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setZoom):
Wrapper for m_style->setZoom() that automatically updates m_fontDirty.
(WebCore::CSSStyleSelector::setEffectiveZoom):
Wrapper for m_style->setEffectiveZoom that automatically updates m_fontDirty.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::ensurePropertyMap):
Use

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setZoom):
Return true only if underlying values change.
(WebCore::InheritedFlags::setZoomWithoutReturnValue):
Return void to match function pointer type where required.
(WebCore::InheritedFlags::setEffectiveZoom):
Return true only if underlying values change.

18:37 Changeset [92163] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline test results for recently added test.

  • platform/chromium-linux/svg/custom/repaint-shadow-expected.png: Added.
  • platform/qt/svg/custom/repaint-shadow-expected.txt: Added.
18:23 Changeset [92162] by zmo@google.com
  • 37 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rebaseline, webkit gardener stuff.

  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
18:20 Changeset [92161] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Removing old source files in gyp files that slow build
https://bugs.webkit.org/show_bug.cgi?id=65503

Patch by Jean-luc Brouillet <jeanluc@chromium.org> on 2011-08-01
Reviewed by Adam Barth.

A number of stale files are listed in the gyp files. These slow the
build on Visual Studio 2010. Removing them.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
18:16 Changeset [92160] by slewis@apple.com
  • 4 edits in trunk/Tools

Finish reconfiguration started by Lucas Forschler
Reconfigured slaves:
Removed Leopard Intel Release (Build)
Removed Leopard Intel Release (Tests)
Remove apple-pixel-1
Added Lion slaves from disabled Leopard slaves

Added builders:
Lion Intel Release (Build)
Lion Intel Debug (Build)
Lion Intel Release (Tests)
Lion Intel Release WK2 (Tests)
Lion Intel Debug (Tests)
Lion Intel Debug WK2 (Tests)

Added triggers:
lion-intel-debug-tests
lion-intel-debug-test-wk2
lion-intel-release-tests
lion-intel-release-tests-wk2

Removed trigger:
leopard-intel-release-tests

Added PlatformSpecificScheduler:
mac-lion

Added "mac-lion" to build.py and build_unitttest.py

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
17:59 Changeset [92159] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Shard webcore_remaining for msvs official builds

https://bugs.webkit.org/show_bug.cgi?id=65475

Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.

webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

  • WebCore.gyp/WebCore.gyp:
17:51 Changeset [92158] by commit-queue@webkit.org
  • 6 edits in trunk

WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
https://bugs.webkit.org/show_bug.cgi?id=65451

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-01
Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

LayoutTests:

  • accessibility/aria-roles.html:
  • platform/mac/accessibility/aria-multiline.html:
  • platform/mac/accessibility/aria-roles-expected.txt:
17:49 Changeset [92157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use threadsafeCopy() API when using Database Directory path variable
https://bugs.webkit.org/show_bug.cgi?id=65436

Patch by srikumar bonda <srikumar.b@gmail.com> on 2011-08-01
Reviewed by David Levin.

Use threadsafeCopy() API while using m_databaseDirectoryPath string variable
when the databaseGuard lock hasn't been taken in DatabaseTracker class.
This is just a safety fix.

No changes to functionality so no new tests.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::deleteOrigin):

17:44 Changeset [92156] by zmo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline, webkit gardener stuff.

  • platform/chromium-mac/svg/custom/repaint-shadow-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-shadow-expected.png: Added.
17:21 Changeset [92155] by michaeln@google.com
  • 11 edits in trunk/Source/WebCore

[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486

The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.

Reviewed by Darin Fisher.

No new tests. Existing layout tests cover the version handling functionality.

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::expectedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):

  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):

  • storage/SQLTransactionSync.h:
17:10 Changeset [92154] by levin@chromium.org
  • 4 edits in trunk/Source/JavaScriptCore

currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

17:07 Changeset [92153] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/Tools

webkit-patch needs to be able to "optimize" the storage of baselines on disk
https://bugs.webkit.org/show_bug.cgi?id=65418

Reviewed by Dimitri Glazkov.

If we're not careful when rebaselining tests, we can end up with lots
of duplicate expected results files in the tree. This patch adds a
webkit-patch command that optimizes the storage of expected results on
disk.

This command is similar to deduplicate-tests, except that it can move
test results around rather than just remove duplicate results.

Unfortunately, this problem is very tricky because the baseline search
structure is a hypergraph. This patch include a huerstic optimizer
that appears to work on a bunch of examples I've tried. We'll likely
need to refine it as gain experience.

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:49 Changeset [92152] by timothy_horton@apple.com
  • 5 edits
    3 adds in trunk

Severe shadow repaint issues with SVGText elements
https://bugs.webkit.org/show_bug.cgi?id=63648
<rdar://problem/7632269>

Reviewed by Darin Adler.

Make SVG elements which inherit from RenderSVGBlock take text-shadow
overflow into account when determining whether or not they should draw

Test: svg/custom/repaint-shadow.svg

  • rendering/RenderBox.h:

(WebCore::RenderBox::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.h:
16:25 Changeset [92151] by crogers@google.com
  • 2 edits in trunk/LayoutTests

One more test_expectations.txt fix for windows web audio
https://bugs.webkit.org/show_bug.cgi?id=65496

Unreviewed.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [92150] by zmo@google.com
  • 9 edits in trunk

Unreviewed, rolling out r92022.
http://trac.webkit.org/changeset/92022
https://bugs.webkit.org/show_bug.cgi?id=65203

try to see if this is causing a bunch of browser tests failues
on win bots - will recommit if not

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:45 Changeset [92149] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove time out expectation since media/track has been added to the skipped list on Qt.

  • platform/qt/test_expectations.txt:
15:32 Changeset [92148] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT sometimes creates speculation check data structures that have
invalid information about the format of a register
https://bugs.webkit.org/show_bug.cgi?id=65490

Reviewed by Gavin Barraclough.

The code now makes sure to (1) always have correct and up-to-date
information about register format at the time that a speculation
check is emitted, (2) assert that speculation data is correct
inside the speculation check implementation, and (3) avoid creating
speculation data altogether if compilation has already failed, since
at that point the format data is almost guaranteed to be bogus.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

15:22 Changeset [92147] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

Teach TestExpectationSerializer about parsed expectations.
https://bugs.webkit.org/show_bug.cgi?id=65444

This is a bit largish in size, but the essentials are:

  • TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
  • We now store original content of the expectation line on TestExpectationLine.
  • Lots of tests.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't

populate macros correctly, also fixed an issue where we incorrectly returned an empty list
for all configurations.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,

refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
changed to store and use TestExpectationLine.original_string.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
15:09 Changeset [92146] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r92092): Build fails on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=65458

Reviewed by Oliver Hunt.

The build was broken because some compilers were smart enough to see
an array index out of bounds due to the decision fuction for when to
go from precise size classes to imprecise size classes being broken:
it would assume that sizes in the range 97..128 belonged to a precise
size class when in fact they belonged to an imprecise one.

In fact, the code would have run correctly, by way of a fluke, because
though the 4th precise size class (for 97..128) didn't exist, the next
array over from m_preciseSizeClasses was m_impreciseSizeClasses, and
its first entry would have been a size class that is appropriate for
allocations in the range 97..128. However, this relies on specific
ordering of fields in NewSpace, so it's still a bug.

This fixes the bug by ensuring that allocations larger than 96 use
the imprecise size classes.

  • heap/NewSpace.h:

(JSC::NewSpace::sizeClassFor):

14:46 Changeset [92145] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add null check to setSwapbuffersCompletCallbackChromium
https://bugs.webkit.org/show_bug.cgi?id=65485

Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::SwapBuffersCompleteCallbackAdapter::create):

14:41 Changeset [92144] by crogers@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add audionode.html and gain.html web audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65276

Reviewed by Kenneth Russell.

  • webaudio/audionode-expected.txt: Added.
  • webaudio/audionode.html: Added.
  • webaudio/gain-expected.wav: Added.
  • webaudio/gain.html: Added.
  • webaudio/resources/buffer-loader.js: Added.

(BufferLoader):
(BufferLoader.prototype.loadBuffer.request.onload):
(BufferLoader.prototype.loadBuffer.request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):

14:22 Changeset [92143] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk

.: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • Source/autotools/symbols.filter:

Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).

With this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load. Test added for crash discovered in
previous revision, but no tests for memory usage.

Test: http/tests/inspector/network/disabled-cache-crash.html

  • WebCore.exp.in:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasOneHandle):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

  • loader/cache/CachedResourceLoader.h:
  • testing/Internals.cpp:

(WebCore::Internals::disableMemoryCache):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

Update exports for test harness.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006

Test for CachedResourceLoader. Not caused by cache-disabling but very
difficult to reproduce when cache is active, so use cache disable in
inspector to exercise code.

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.

  • http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
  • http/tests/inspector/network/disabled-cache-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:18 Changeset [92142] by jochen@chromium.org
  • 5 edits
    7 adds in trunk

Source/WebCore: Never override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809

Reviewed by Adam Barth.

Tests: http/tests/security/cookies/third-party-cookie-blocking-main-frame.html

http/tests/security/cookies/third-party-cookie-blocking-user-action.html
http/tests/security/cookies/third-party-cookie-blocking.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addExtraFieldsToSubresourceRequest):
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/FrameLoader.h:

LayoutTests: Require explicit user action to override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809

Reviewed by Adam Barth.

  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/security/cookies/resources/set-a-cookie.php: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-main-frame-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-main-frame.html: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-user-action-expected.txt: Added.
  • http/tests/security/cookies/third-party-cookie-blocking-user-action.html: Added.
  • http/tests/security/cookies/third-party-cookie-blocking.html: Added.
14:16 Changeset [92141] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

media/track tests should be skipped on all platforms until feature is fully implemented.
https://bugs.webkit.org/show_bug.cgi?id=65482

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-01
Reviewed by Ryosuke Niwa.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
14:10 Changeset [92140] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Update comment added in r92139 per Darin's suggestion.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):

14:08 Changeset [92139] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Search field in designMode causes a crash
https://bugs.webkit.org/show_bug.cgi?id=65362

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crashed was caused by editing code inadvertently deleting search and cancel buttons in the design mode.
Fixed the bug by avoid inheriting user-modify property from the shadow host.

Test: editing/input/search-field-crash-in-designmode.html

  • css/CSSStyleSelector.cpp:

(WebCore::isAtShadowBoundary): Moved.
(WebCore::CSSStyleSelector::styleForElement): Overrides -webkit-user-modify by the initial value after m_style
inherited the values from m_parentStyle but before applying matched rules.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable): Ignore page's editability inside a shadow DOM.

LayoutTests:

Add a test to ensure WebKit doesn't crash when a user tries to delete inside
an empty search field in the design mode.

  • editing/input/search-field-crash-in-designmode-expected.txt: Added.
  • editing/input/search-field-crash-in-designmode.html: Added.
13:40 Changeset [92138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Set default max-conns to a more sane default value and fix comment
https://bugs.webkit.org/show_bug.cgi?id=65335

Patch by Marco Peereboom <marco@peereboom.us> on 2011-08-01
Reviewed by Martin Robinson.

Rigged the xxxterm web browser and validated that the default values were set properly.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

13:39 Changeset [92137] by abarth@webkit.org
  • 3 edits in trunk/Tools

Remove unused functionality from gardeningserver
https://bugs.webkit.org/show_bug.cgi?id=65479

Reviewed by Dimitri Glazkov.

We now handle these operations directly from the front-end. That means
they work even without the gardening server running!

Also, add some missing files to the list of static files.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
12:55 Changeset [92136] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
https://bugs.webkit.org/show_bug.cgi?id=65413

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted

existing code to use it.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
12:25 Changeset [92135] by abarth@webkit.org
  • 14 edits in trunk/Tools

Refactor bugzilla.js for use by garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65450

Reviewed by Dimitri Glazkov.

This patch refactors bugzilla.js to use the AsynchronousCache and
updates the style to use a module instead of an object. This patch
then fixes all the existing code that uses this class to use the new
API style.

This main benefit of this patch is we remove the tricky manual caching
and this code is now available to use in garden-o-matic (since the
dependency on Utilities.js is now gone).

I ran all the unit tests and poked around in TestFailures a bit to see
that everything seemed to be working properly.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:

(FailingTestsBugForm):
(FailingTestsBugForm.prototype._createBugTitle):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:

(FlakyTestBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:

(NewBugForm):
(NewBugForm.prototype.domElement):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:

(TestRelatedBugForm):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
(ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
(ViewController.prototype._domForPossiblyFlakyTests):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
12:23 Changeset [92134] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

garden-o-matic shouldn't require local server to determine if compile failed
https://bugs.webkit.org/show_bug.cgi?id=65446

Reviewed by Dimitri Glazkov.

This patch adds some basic bindings for the buildbot JSON API. I
wanted to use Buildbot.js an Builder.js from the original TestFailures,
but they make a number of WebKit-specific assumptions. We'll
eventually need to reconcile these pieces of code.

I should really add tests for this code, but that will require me to
build a better mock network. I'll be happy to do that in a follow-up
patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
    • It's very unclear to me whether didFail is correct. Supposedly the first entry here is the exit code of the step, which is 0 on success. I suspect we'll need to improve this function over time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
11:45 Changeset [92133] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should show all failures, even ones that it can't find a regression range for
https://bugs.webkit.org/show_bug.cgi?id=65447

Reviewed by Dimitri Glazkov.

Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page). This patch just displays them at the end of the list,
which is slightly (but not much) better.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
11:03 Changeset [92132] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Regression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
https://bugs.webkit.org/show_bug.cgi?id=65137

Source/WebCore:

Fix the looping condition to prevent trailingSpaceMidpoint from becoming negative.

Reviewed by Dave Hyatt.

Test: fast/block/update-midpoints-for-trailing-boxes-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):

LayoutTests:

ASSERTION FAILED: trailingSpaceMidpoint >= 0

Reviewed by Dave Hyatt.

  • fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt: Added.
  • fast/block/update-midpoints-for-trailing-boxes-crash.html: Added.
09:51 Changeset [92131] by ossy@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r92127.

  • platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
  • platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/qt-4.8/editing/selection/4397952-expected.png: Added.
  • platform/qt-4.8/editing/selection/4397952-expected.txt: Added.
  • platform/qt-mac/Skipped: Skip failing tests.
  • platform/qt-wk2/Skipped: Skip failing tests.
09:10 Changeset [92130] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] OpenGLShims does not build on ARM
https://bugs.webkit.org/show_bug.cgi?id=65465

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-01
Reviewed by Noam Rosenthal.

Fix the build with OpenGL ES 2:
-lookupOpenGLFunctionAddress() was defined but not used for OpenGL ES.
-glBlitFramebuffer() and glRenderbufferStorageMultisample() are not part of the specification.
When those are available as platform extension, the extension has been added.
-GLchar is not defined on some platform. The patch adds the same typedef as the official definition
to avoid conflicts.

  • platform/graphics/cairo/OpenGLShims.cpp:

(lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):

  • platform/graphics/cairo/OpenGLShims.h:
09:09 Changeset [92129] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/forms/selection-direction.html to the Skipped list.

  • platform/wk2/Skipped:
09:02 Changeset [92128] by jeffm@apple.com
  • 3 edits in trunk/Tools

Windows build fix after r92096.

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
09:01 Changeset [92127] by ossy@webkit.org
  • 105 edits
    112 adds in trunk/LayoutTests

[Qt] Update expected results and unskip now passing tests.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/css2.1/ [...]: Updated.
  • platform/qt/editing/ [...]: Updated.
06:47 Changeset [92126] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-08-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test that was just added.

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/test_expectations.txt:
05:45 Changeset [92125] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Trivial fix for inspector/debugger/debugger-completions-on-call-frame.html after r92122.

  • inspector/front-end/ConsoleView.js:
05:25 Changeset [92124] by hayato@chromium.org
  • 11 edits
    4 adds in trunk

Add support for getting an element in shadow root by its id into a window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=64587

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::getElementByIdInShadowRoot):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
  • fast/dom/shadow/resources/create-dom.js: Added.

(createShadow):
(createDom):

04:53 Changeset [92123] by commit-queue@webkit.org
  • 7 edits in trunk

build: Fix finding the headers for GStreamer

The cmake files to find the various GStreamer packages were all
checking for the header gst/gst.h. However if gst-plugins-base is
installed into a separate prefix from gstreamer then all of these
tests would only pick up the gstreamer include path so the build
would fail. This patch changes it to try and find a file
appropriate to each package.

https://bugs.webkit.org/show_bug.cgi?id=64933

Patch by Neil Roberts <neil@linux.intel.com> on 2011-08-01
Reviewed by Martin Robinson.

  • Source/cmake/FindGStreamer-App.cmake:
  • Source/cmake/FindGStreamer-Base.cmake:
  • Source/cmake/FindGStreamer-Interfaces.cmake:
  • Source/cmake/FindGStreamer-Pbutils.cmake:
  • Source/cmake/FindGStreamer-Plugins-Base.cmake:
  • Source/cmake/FindGStreamer-Video.cmake:
04:42 Changeset [92122] by yurys@chromium.org
  • 11 edits
    3 adds in trunk

Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors
https://bugs.webkit.org/show_bug.cgi?id=65457

Source/WebCore:

Console completions are now done using evaluation which returns a JSON object with all property names rather than a remote
object. Also Runtime.evaluate and Runtime.callFunctionOn commands were extended with an optional parameter that allows to
get result as JSON value.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd-completions.html

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::asBool):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertySet):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector/console-cd-completions-expected.txt: Added.
  • http/tests/inspector/console-cd-completions.html: Added.
  • http/tests/inspector/resources/console-cd-completions-iframe.html: Added.
04:38 Changeset [92121] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/inspector/resource-tree/resource-tree-document-url.html occasionally times out
https://bugs.webkit.org/show_bug.cgi?id=65463

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
04:30 Changeset [92120] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/cache/history-only-cached-subresource-loads-max-age-https.html frequently times out on Vista
https://bugs.webkit.org/show_bug.cgi?id=65462

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
04:22 Changeset [92119] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Temporarily expect scripts-sorting.html to fail
https://bugs.webkit.org/show_bug.cgi?id=65461

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:18 Changeset [92118] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

BORDER attribute with the object tag, using percentage values not working.
https://bugs.webkit.org/show_bug.cgi?id=65176

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-01
Reviewed by Hajime Morita.

Source/WebCore:

When border presentational attribute for object element has % in it, it should be parsed using HTML parser rules.

Test: fast/borders/border-width-percent.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseBorderWidthAttribute):

  • html/HTMLElement.h:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Added the tests with border width with percentages in a new file. Moved them
from images border test file.

  • fast/borders/border-width-percent-expected.txt: Added.
  • fast/borders/border-width-percent.html: Added.
  • fast/images/border-expected.txt:
  • fast/images/script-tests/border.js:
04:16 Changeset [92117] by tonyg@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Update expectations for fast/text/international/bidi-mirror-he-ar.html
https://bugs.webkit.org/show_bug.cgi?id=65460

Unreviewed expectations update.

  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
04:16 Changeset [92116] by yutak@chromium.org
  • 8 edits in trunk/Source/WebCore

WebSocket: Receive URL and subprotocol in WebSocketChannel::connect()
https://bugs.webkit.org/show_bug.cgi?id=65367

Reviewed by Kent Tamura.

To implement multiple subprotocols support (bug 65247), WebSocket::connect() will need to validate
the value of subprotocols after constructing WebSocketChannel, because the result depends on which
WebSocket protocol is used, which is obtained from WebSocketChannel::useHixie76Protocol(). This
means the subprotocol value will not be available at the time of WebSocketChannel construction.

This change moves URL and subprotocol arguments in WebSocketChannel constructor to
WebSocketChannel::connect(), which allows WebSocket::connect() function to check the subprotocol
value before the actual connection is established.

Relocating URL argument is technically not necessary, but seemed legitimate in terms of functional
correspondence between WebSocket and WebSocketChannel (constructor versus connect()).

No change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.cpp:

Remove "url" and "protocol" arguments from constructor and add them in connect().
(WebCore::ThreadableWebSocketChannel::create):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • websockets/WebSocketChannel.cpp: Same as ThreadableWebSocketChannel.

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
InspectorInstrumentation::didCreateWebSocket() call was moved to connect() because it needs URL.
This does not change behavior, because connect() is guaranteed to be called immediately after
WebSocketChannel is constructed.

  • websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

  • websockets/WorkerThreadableWebSocketChannel.cpp: Same as ThreadableWebSocketChannel.

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::connect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):

  • websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Peer::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

03:19 Changeset [92115] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::loadHtml5Video() API test
https://bugs.webkit.org/show_bug.cgi?id=65452

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

  • tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail

(tst_QWebPage::loadHtml5Video):

03:18 Changeset [92114] by vsevik@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Web Inspector: Add network panel sidebar width test.
https://bugs.webkit.org/show_bug.cgi?id=65314

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network/network-sidebar-width-expected.txt: Added.
  • http/tests/inspector/network/network-sidebar-width.html: Added.
02:53 Changeset [92113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r92108.
http://trac.webkit.org/changeset/92108
https://bugs.webkit.org/show_bug.cgi?id=65459

breaks SL compile (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-01

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

02:36 Changeset [92112] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/resource-tree-reload.html is flaky on chromium win
https://bugs.webkit.org/show_bug.cgi?id=60110

Marking it flaky on Linux as well.

  • platform/chromium/test_expectations.txt:
02:05 Changeset [92111] by tonyg@chromium.org
  • 2 edits
    1 copy in trunk/LayoutTests

Fix windows text rendering expectations for fast/text/justify-ideograph-leading-expansion.html
https://bugs.webkit.org/show_bug.cgi?id=65455

Unreviewed expectations update.

  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png.
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
02:04 Changeset [92110] by ossy@webkit.org
  • 5 edits
    4 copies in trunk/LayoutTests

REGRESSION (r92048): svg/custom/external-paintserver-reference.svg, svg/custom/linking-base-external-reference.xhtml failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65432

Revert accidentally committed changes, and update Qt specific expected results.

  • platform/qt/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.png.
  • platform/qt/svg/custom/external-paintserver-reference-expected.txt: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.txt.
  • platform/qt/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.png.
  • platform/qt/svg/custom/linking-base-external-reference-expected.txt: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.txt.
  • svg/custom/external-paintserver-reference-expected.png: Revert r92048.
  • svg/custom/external-paintserver-reference-expected.txt: Revert r92048.
  • svg/custom/linking-base-external-reference-expected.png: Revert r92048.
  • svg/custom/linking-base-external-reference-expected.txt: Revert r92048.
01:57 Changeset [92109] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-01 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake inspector test that was just added.

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
01:49 Changeset [92108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-01
Reviewed by Darin Adler.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.

01:48 Changeset [92107] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/outline-auto-empty-rects.html broken by r92059
https://bugs.webkit.org/show_bug.cgi?id=65453

This patch just expects the test to fail for now.

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
01:31 Changeset [92106] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Add iterator to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=65297

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isLength):
Add shorthand to determine if this primitive value is a length.

  • css/CSSStyleSelector.cpp:

Use CSSValueListIterator throughout.
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::applyPageSizeProperty):
(WebCore::CSSStyleSelector::createTransformOperations):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::copy):
Use itemWithoutBoundsCheck() instead of item().

  • css/CSSValueList.h:

Add CSSValueListIterator and CSSValueListInspector class definitions.
(WebCore::CSSValueList::item)
Provide inline definition of item.
(WebCore::CSSValueListIterator::CSSValueListIterator):
(WebCore::CSSValueListIterator::hasMore):
Return true if there are more values to consume, including the current value.
(WebCore::CSSValueListIterator::value):
Return the value at the current position.
(WebCore::CSSValueListIterator::next):
Move the iterator forward to the next item.
(WebCore::CSSValueListIterator::index):
Return the current position in the list.
(WebCore::CSSValueListInspector::item):
Return the item at a given index.
(WebCore::CSSValueListInspector::first):
Return the first item in the list.
(WebCore::CSSValueListInspector::second):
Return the second item in the list.
(WebCore::CSSValueListInspector::length):
Return the size of the underlying list.

01:17 Changeset [92105] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: group scripts by folder in the scripts selector.
https://bugs.webkit.org/show_bug.cgi?id=65321

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/scripts-sorting.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-sorting-expected.txt: Added.
  • inspector/debugger/scripts-sorting.html: Added.
01:13 Changeset [92104] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
https://bugs.webkit.org/show_bug.cgi?id=65331

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:

(generateBackendFunction):
(generateArgumentGetters):

LayoutTests:

  • inspector/report-protocol-errors-expected.txt:
01:04 Changeset [92103] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

application/json MIME type shouldn't cause warnings in <script> tags
https://bugs.webkit.org/show_bug.cgi?id=65448

Reviewed by Pavel Feldman.

This patch stops the web inspector from logging a ton of spam warnings
when a web page uses a JSONP service (which points script tags at
application/json resources).

  • inspector/front-end/inspector.js:

(WebInspector.reset):

00:26 Changeset [92102] by yutak@chromium.org
  • 10 edits in trunk/Source

WebSocket: Rename SocketStreamHandleClient member functions
https://bugs.webkit.org/show_bug.cgi?id=65374

Reviewed by Kent Tamura.

Source/WebCore:

Rename SocketStreamHandleClient member functions to avoid conflict of the names of
FileReaderLoaderClient functions.

No change in behavior, thus no new tests are added.

  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::didOpenSocketStream):
(WebCore::SocketStreamHandleClient::didCloseSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData):
(WebCore::SocketStreamHandleClient::didFailSocketStream):

  • platform/network/brew/SocketStreamHandleBrew.cpp:

(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosed):
(WebCore::SocketStreamHandlePrivate::socketError):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::platformClose):

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosedCallback):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::resumeTimerFired):

  • websockets/WebSocketChannel.h:

Source/WebKit/chromium:

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):

07/31/11:

23:05 Changeset [92101] by abarth@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

These results appear to differ only in text rendering.

  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
22:36 Changeset [92100] by abarth@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Adding expected results. These results appear to differ only in the scrollbar.

  • platform/chromium-linux/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-linux/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.txt: Added.
  • platform/chromium-win/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-win/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/chromium-win/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-win/svg/custom/linking-base-external-reference-expected.txt: Added.
22:33 Changeset [92099] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline. This patch might cause Linux to start failing, but in
that case, we can add a more specific Linux result. This approach is
somewhat of an exploration of this automated rebaselining algorithm.

  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
21:25 Changeset [92098] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r92094.
http://trac.webkit.org/changeset/92094
https://bugs.webkit.org/show_bug.cgi?id=65443

Triggered many asserts (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-31

Source/WebCore:

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

LayoutTests:

  • fast/events/event-target-reset-expected.txt: Removed.
  • fast/events/event-target-reset.html: Removed.
21:17 Changeset [92097] by andersca@apple.com
  • 2 edits in trunk/Tools

DownloadDecideDestinationCrash WebKit2 API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=65442

Reviewed by Sam Weinig.

Copy the 18-characters.html file to the destination directory so we won't
crash trying to make an URL for it.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21:10 Changeset [92096] by andersca@apple.com
  • 2 adds in trunk/Tools/TestWebKitAPI

Add forgotten files.

20:32 Changeset [92095] by andersca@apple.com
  • 8 edits in trunk/Tools

Fix SpacebarScrolling WebKit2 API test
https://bugs.webkit.org/show_bug.cgi?id=65431

Reviewed by Sam Weinig.

Add a way to do platform-specific bundle initialization, and use it to disable smooth
scrolling. Also make it possible for a test to load the injected bundle without actually running
a test from it.

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
19:53 Changeset [92094] by dominicc@chromium.org
  • 3 edits
    2 adds in trunk

Event target set to null post event dispatch
https://bugs.webkit.org/show_bug.cgi?id=63934

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/event-target-reset.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Reset target to outermost
shadow host.

LayoutTests:

  • fast/events/event-target-reset-expected.txt: Added.
  • fast/events/event-target-reset.html: Added.
18:50 Changeset [92093] by barraclough@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Unreviewed - rolling out r91290.

Source/JavaScriptCore:

Looks like the wild wild web isn't ready for this yet.

This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling Array.prototype.slice as a part
of its bind implementation.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Checking in failing results - we can't fix this bug just yet
for web compatibility reasons.

  • fast/js/array-prototype-properties-expected.txt:
  • ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
16:48 Changeset [92092] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437

Reviewed by Oliver Hunt.

Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words. This is a 1% win on SunSpider.

  • heap/MarkedBlock.h:
16:17 Changeset [92091] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix fast/dom/Range/getBoundingClientRect.html after r92089.

  • fast/dom/Range/getBoundingClientRect.html:
14:14 Changeset [92090] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty-list-item.html are slow/timeout
https://bugs.webkit.org/show_bug.cgi?id=65019

This bug was invalid; neither test is slow nor timing out.

  • platform/chromium/test_expectations.txt:
14:05 Changeset [92089] by weinig@apple.com
  • 7 edits in trunk

REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update to more closely match the spec.

  • dom/Range.cpp:

(WebCore::Range::getClientRects):
Return an empty ClientRectList instead of null when the range is empty.

(WebCore::Range::getBoundingClientRect):
Always return a ClientRect, even for an empty bounding rect.

LayoutTests:

  • fast/dom/Range/getBoundingClientRect-expected.txt:
  • fast/dom/Range/getBoundingClientRect.html:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

Add test cases for empty and collapsed ranges.

13:44 Changeset [92088] by rniwa@webkit.org
  • 10 edits
    2 copies
    4 adds in trunk

[HTML5] Implement the selectionDirection property on input and textarea
https://bugs.webkit.org/show_bug.cgi?id=60403

Reviewed by Darin Adler.

Source/WebCore:

Implements selectionDirection property as specified in HTML5 section 4.10.20:
http://www.whatwg.org/specs/web-apps/current-work/#textFieldSelection

selectionDirection is a property on input and textarea elements, which, on getting returns either "none",
"forward", or "backward" corresponding to the current selection direction, and on setting, modifies
the direction of the current selection. When selection doesn't exist or direction is unknown, "none"
is returned on getting. Setting the property value to neither of above values will result in setting "none".

This patch also adds the optional third argument, direction, to setSelectionRange.

Test: fast/forms/selection-direction.html

fast/forms/selection-wrongtype.html

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::selectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionRange): Processes the third argument.

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter): Added.
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter): Added.
(WebCore::V8HTMLInputElement::setSelectionRangeCallback): Processes the third argument.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance): Calls hasCachedSelection.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
(WebCore::HTMLInputElement::setValue): Calls cacheSelection with SelectionHasNoDirection.

  • html/HTMLTextAreaElement.idl: Added selectionDirection and the third argument to setSelectionRange.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initializes
m_cachedSelectionDirection.
(WebCore::HTMLTextFormControlElement::setSelectionStart): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
(WebCore::HTMLTextFormControlElement::setSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::select): Calls setSelectionRange with SelectionHasNoDirection.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Added the version that takes direction
string as the third argument, which calls the version that takes two ints and TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::directionString): Added.
(WebCore::HTMLTextFormControlElement::selectionDirection): Added.
(WebCore::HTMLTextFormControlElement::computeSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::selection): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls cacheSelection.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Takes TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::hasCachedSelection): Extracted from hasCachedSelectionStart;
cacheSelection is the only function that modifies m_cacheSelectionStart and m_cacheSelectionEnd
and none of its callers ever set one of them be -1 so they are always both -1 or both non-negative.
Thus, having two separate functions for m_cacheSelectionStart and m_cacheSelectionEnd was redundant.

LayoutTests:

Added a test to ensure WebKit sets and gets selectionDirection property.

Also added a test to ensure WebKit throws exceptions when retrieving or assigning values to selectionStart,
selectionEnd, and selectionDirection property of the input element when the element isn't a text field.

  • fast/forms/selection-direction-expected.txt: Added.
  • fast/forms/selection-direction.html: Added.
  • fast/forms/selection-wrongtype-expected.txt: Added.
  • fast/forms/selection-wrongtype.html: Added.
  • platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt; editing delegate change.

  • platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt since Windows port fallbacks to Mac.

13:40 Changeset [92087] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Use set comparison to find duplicate or overlapping specifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65430

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length

of a set is wrong.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch

regressions.

13:32 Changeset [92086] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add expected results for Snow Leopard and earlier for fast/css/font-family-pictograph.html

Fixes REGRESSION (r91777): fast/css/font-family-pictograph.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65433

  • platform/mac-snowleopard/fast/css: Added.
  • platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Added.
13:13 Changeset [92085] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424

Reviewed by Gavin Barraclough.

Added code to emit PutByVal inline fast path.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

12:03 Changeset [92084] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382

Reviewed by Oliver Hunt.

This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire. New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

  • heap/Heap.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):

  • heap/MarkedBlock.h:
  • wtf/Platform.h:
09:30 Changeset [92083] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
overload, and change the overload that takes WebURLLoaderOptions to
use a default value. This is equivalent to the original parameterless
overload.
https://bugs.webkit.org/show_bug.cgi?id=65280

Patch by Bill Budge <bbudge@chromium.org> on 2011-07-31
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • src/AssociatedURLLoader.cpp:
  • src/AssociatedURLLoader.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
01:48 Changeset [92082] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
https://bugs.webkit.org/show_bug.cgi?id=65427

This variable was unused when it was initially added in <http://trac.webkit.org/changeset/89660> (bug #62718)
and it is unused today. We should remove it. This will also resolve a compiler warning.

Reviewed by Xan Lopez.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(getChildForTable):

01:34 Changeset [92081] by dbates@webkit.org
  • 2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Add missing semicolons to build fix attempt in <http://trac.webkit.org/changeset/92080>.

  • Source/autotools/symbols.filter:
01:18 Changeset [92080] by dbates@webkit.org
  • 2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Some more fixes to the GTK build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

  • Source/autotools/symbols.filter: Export symbols needed by Internals.
01:06 Changeset [92079] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-07-31 Daniel Bates <dbates@webkit.org>

Try again to fix the WinCairo Debug build after r92059 ( https://bugs.webkit.org/show_bug.cgi?id=65419).

  • win/WebKit2CFLite.def: Export symbols needed by Internals.
00:37 Changeset [92078] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit/win

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

  • WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
  • WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
00:16 Changeset [92077] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-31 Xan Lopez <xlopez@igalia.com>

Group dependencies CFLAGS together.

  • GNUmakefile.am: ditto.
00:04 Changeset [92076] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
(https://bugs.webkit.org/show_bug.cgi?id=65419).

  • GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.

07/30/11:

23:47 Changeset [92075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30

  • DEPS:
23:44 Changeset [92074] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
(https://bugs.webkit.org/show_bug.cgi?id=64744)

23:36 Changeset [92073] by dbates@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.

23:29 Changeset [92072] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.com>

Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
(https://bugs.webkit.org/show_bug.cgi?id=65342)

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock() to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.
23:14 Changeset [92071] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421

Reviewed by Oliver Hunt.

Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

22:56 Changeset [92070] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Windows build after r92059.

  • win/WebKit2.def: Export symbols needed by Internals.
21:46 Changeset [92069] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068

  • bindings/scripts/test/JS/JSTestCallback.cpp:
19:23 Changeset [92068] by paroga@webkit.org
  • 112 edits in trunk/Source

Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add missing and remove unneeded include statements for MainThread.

  • wtf/CryptographicallyRandomNumber.cpp:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/text/StringStatics.cpp:

Source/WebCore:

Add missing include statements for MainThread.

  • bindings/js/DOMWrapperWorld.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMWrapperWorld.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • dom/EventTarget.cpp:
  • fileapi/LocalFileSystem.cpp:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/DOMWindow.cpp:
  • page/History.cpp:
  • page/SecurityOrigin.cpp:
  • page/mac/EventHandlerMac.mm:
  • platform/MIMETypeRegistry.cpp:
  • platform/ThreadGlobalData.cpp:
  • platform/ThreadTimers.cpp:
  • platform/TreeShared.h:
  • platform/audio/HRTFDatabaseLoader.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/FontFallbackList.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/Image.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
  • platform/mac/LocalizedStringsMac.mm:
  • platform/mac/SharedBufferMac.mm:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/text/LocalizedNumberICU.cpp:
  • platform/text/TextEncodingRegistry.cpp:
  • platform/text/mac/LocalizedNumberMac.mm:
  • platform/win/LocalizedStringsWin.cpp:
  • storage/LocalStorageThread.cpp:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaSync.cpp:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageSyncManager.cpp:
  • webaudio/AsyncAudioDecoder.cpp:
  • webaudio/AudioBufferSourceNode.cpp:
  • webaudio/AudioContext.h
  • webaudio/AudioContext.cpp:
  • webaudio/AudioNode.cpp:
  • webaudio/ConvolverNode.cpp:
  • webaudio/OfflineAudioDestinationNode.cpp:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/WaveShaperNode.cpp:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • workers/WorkerMessagingProxy.cpp:

Source/WebKit/chromium:

Add missing include statements for MainThread.

  • src/WebKit.cpp:
  • src/WebViewImpl.cpp:
  • tests/CCThreadTest.cpp:

Source/WebKit/gtk:

Add missing include statements for MainThread.

  • webkit/webkitglobals.cpp:

Source/WebKit/mac:

Add missing include statements for MainThread.

  • Carbon/CarbonWindowAdapter.mm:
  • History/WebBackForwardList.mm:
  • History/WebHistoryItem.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebIconDatabase.mm:
  • Misc/WebLocalizableStrings.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebResource.mm:
  • WebView/WebTextIterator.mm:
  • WebView/WebView.mm:
  • WebView/WebViewData.mm:

Source/WebKit/qt:

Add missing include statements for MainThread.

  • Api/qwebpage.cpp:

Source/WebKit/win:

Add missing include statements for MainThread.

  • WebKitClassFactory.cpp:
  • WebView.cpp:

Source/WebKit/wx:

Add missing include statements for MainThread.

  • WebView.cpp:

Source/WebKit2:

Add missing include statements for MainThread.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:
  • PluginProcess/mac/PluginProcessMainMac.mm:
  • PluginProcess/qt/PluginProcessMainQt.cpp:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp:
  • UIProcess/WebContext.cpp:
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:
  • WebProcess/mac/KeychainItemShimMethods.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
  • WebProcess/qt/WebProcessMainQt.cpp:
  • WebProcess/win/WebProcessMainWin.cpp:
18:19 Changeset [92067] by paroga@webkit.org
  • 2 edits in trunk/Tools

Fix ports_unittest.py on native windows
https://bugs.webkit.org/show_bug.cgi?id=64959

Reviewed by Adam Barth.

Replace WebKitPort.script_path with WebKitPort.script_shell_command.
The latter includes the interpreter executable required on native windows.

  • Scripts/webkitpy/common/config/ports_unittest.py:
17:51 Changeset [92066] by abarth@webkit.org
  • 1 edit
    17 adds
    7 deletes in trunk/LayoutTests

Update baselines. This patch cleans up after http://trac.webkit.org/changeset/92042.

  • platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/absolute-position-moved-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium-win/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/chromium-win/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-hide-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-show-expected.png: Added.
  • platform/chromium/fast/repaint/absolute-position-changed-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
  • platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
  • platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-hide-expected.png: Removed.
  • platform/chromium/fast/repaint/overflow-show-expected.png: Removed.
17:46 Changeset [92065] by abarth@webkit.org
  • 16 edits
    1 delete in trunk/LayoutTests

Update more baselines. This completes the cleanup after
http://trac.webkit.org/changeset/92047.

  • platform/chromium-win-xp/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
17:39 Changeset [92064] by abarth@webkit.org
  • 17 edits
    2 deletes in trunk/LayoutTests

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
17:33 Changeset [92063] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
17:25 Changeset [92062] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline.

  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
17:05 Changeset [92061] by abarth@webkit.org
  • 2 edits in trunk/Tools

Properly escape regular expressions. (Maybe these shouldn't be regular
expressions?)

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:57 Changeset [92060] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add support for Win7 to garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:51 Changeset [92059] by enrica@apple.com
  • 7 edits
    2 adds in trunk

REGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419
<rdar://problem/9408862>

Source/WebCore:

This patch fixes a regression introduced in r83075.
Make sure that culledInlineAbsoluteRects still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
This code path could not be tested via JavaScript. The patch
extends the Internals object to be able to test this case.

Reviewed by Dan Bernstein.

Test: fast/inline/skipped-whitespace-boundingBox.html

  • WebCore.exp.in: Added some exports.
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteRects):

  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Reviewed by Dan Bernstein.

  • fast/inline/skipped-whitespace-boundingBox-expected.txt: Added.
  • fast/inline/skipped-whitespace-boundingBox.html: Added.
16:10 Changeset [92058] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417

Reviewed by Dan Bernstein.

Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):

11:27 Changeset [92057] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406

Reviewed by Dimitri Glazkov.

Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range. Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.

This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
11:26 Changeset [92056] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403

Reviewed by Dimitri Glazkov.

The refresh button should be faster and less disruptive than the browser's reload button.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
11:25 Changeset [92055] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=65231

Reviewed by Dimitri Glazkov.

The human readable name is easier to understand, especially when the patch is landed by the commit-queue.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
11:24 Changeset [92054] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227

Reviewed by Dimitri Glazkov.

This helps gardeners keep track of which problems have been solved.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
11:12 Changeset [92053] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add missing files to the server.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:39 Changeset [92052] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410

Reviewed by Noam Rosenthal.

  • Shared/ShareableBitmap.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::paintContent):

05:42 Changeset [92051] by podivilov@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-file.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.SourceFile.prototype.rawLocationToUILocation):
(WebInspector.SourceFile.prototype.uiLocationToRawLocation):
(WebInspector.SourceFile.prototype._scriptForRawLocation):
(WebInspector.SourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):

LayoutTests:

  • inspector/debugger/source-file-expected.txt: Added.
  • inspector/debugger/source-file.html: Added.
04:43 Changeset [92050] by kbalazs@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263

Reviewed by Dmitry Titov.

  • wtf/Deque.h:

(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.

  • wtf/MessageQueue.h:

(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.

00:16 Changeset [92049] by ossy@webkit.org
  • 23 edits in trunk/LayoutTests

[Qt] Update platform specific expected files after r92047.

  • platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt-4.8/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/smallFonts-expected.txt:
  • platform/qt-4.8/svg/batik/text/textAnchor-expected.txt:
  • platform/qt-4.8/svg/batik/text/textDecoration-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textEffect3-expected.txt:
  • platform/qt-4.8/svg/batik/text/textFeatures-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLayout2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textLength-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition-expected.txt:
  • platform/qt-4.8/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties-expected.txt:
  • platform/qt-4.8/svg/batik/text/textProperties2-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-mac/Skipped: Skip failing tests.
Note: See TracTimeline for information about the timeline view.