Timeline


and

08/08/11:

21:08 Changeset [92664] by tkent@chromium.org
  • 7 edits in trunk/LayoutTests

[Chromium] Update baseline files for r92585.

  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium/test_expectations.txt:
21:02 Changeset [92663] by cevans@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/rendering/CounterNode.cpp

Merge 92630
BUG=88216
Review URL: http://codereview.chromium.org/7601020

20:58 Changeset [92662] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Windows] input-number-size.html is expected to fail because of no spin-button.

  • platform/win/Skipped:
20:55 Changeset [92661] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Grouping spin-button related tests.
https://bugs.webkit.org/show_bug.cgi?id=65896

  • platform/qt/Skipped:
18:26 Changeset [92660] by abarth@webkit.org
  • 3 edits in trunk/Tools

Chromium Windows bots can't figure out what SVN revision they're running
https://bugs.webkit.org/show_bug.cgi?id=65893

Reviewed by Eric Seidel.

The comment in _engage_awesome_windows_hacks explains why we're making
this change. It's ugly and rediculous, but this approach seems better
than using shell=True when calling popen.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
17:55 Changeset [92659] by steveblock@google.com
  • 7 edits
    1 move
    5 deletes in trunk/Source/WebCore

Removes V8's JavaInstanceJobject, JavaClassJobject and JavaFieldJobject.
https://bugs.webkit.org/show_bug.cgi?id=57859

Reviewed by Alexey Proskuryakov.

This effectively reverts the changes made in Bugs 55383, 57533 and

  1. These classes were only used by Android. In the future, Android

will use the Chromium WebKit API to implement the Java bridge.

Towards this goal, this patch ...

  • Simplfies the JavaInstance, JavaClass and JavaField interfaces for V8. These interfaces will be implemented in Chromium's WebKit layer.
  • Adds a JavaMethod interface for V8
  • Removes the jvalue <-> JavaValue conversion functions for V8, which are now superfluous
  • Removes the calls to JavaInstance::begin()/end() for V8, which are now superfluous

Will be covered by existing tests once the Chromium WebKit layer is complete.

  • WebCore.gypi:
  • bridge/jni/v8/JNIUtilityPrivate.cpp:
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaClassJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaFieldJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaFieldJobjectV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h:
  • bridge/jni/v8/JavaInstanceJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaInstanceJobjectV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JavaMethodV8.h:

(JSC::Bindings::JavaMethod::~JavaMethod):

  • bridge/jni/v8/JavaNPObjectV8.cpp:

(JSC::Bindings::JavaNPObjectHasMethod):
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectHasProperty):
(JSC::Bindings::JavaNPObjectGetProperty):

17:49 Changeset [92658] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Fix thread-safety of AudioNode deletion
https://bugs.webkit.org/show_bug.cgi?id=65888

Reviewed by Kenneth Russell

No new tests - JavaScript API is not affected.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodesDispatch):
(WebCore::AudioContext::deleteMarkedNodes):

  • webaudio/AudioContext.h:
17:25 Changeset [92657] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-08-08 Chris Marrin <cmarrin@apple.com>

Fix build breakage caused by http://trac.webkit.org/changeset/92651

Unreviewed.

  • WebCore.exp.in:
17:19 Changeset [92656] by abarth@webkit.org
  • 1 edit
    3 deletes in trunk/Tools

Remove deduplicate-tests
https://bugs.webkit.org/show_bug.cgi?id=65886

Reviewed by Tony Chang.

This script is redundant with "webkit-patch bulk-optimize-baselines",
which can find many more duplicates than deduplicate-tests because
bulk-optimize-baselines can move results around whereas
deduplicate-tests can only remove results.

  • Scripts/deduplicate-tests: Removed.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
17:11 Changeset [92655] by abarth@webkit.org
  • 3 edits in trunk/Tools

scm.delete should delete empty parent directories as well
https://bugs.webkit.org/show_bug.cgi?id=65878

Reviewed by Eric Seidel.

This behavior makes SVN match GIT (which has no concept of empty
directories). This bug comes up a lot when optimizing baselines, which
often create empty directories when we're able to optimize everything
out of a given folder.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
17:05 Changeset [92654] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This should actually be the correct fix for
fast/js/regexp-overflow.html. The bug in bulk-optimize-baselines is
https://bugs.webkit.org/show_bug.cgi?id=65891.

  • platform/chromium/fast/js/regexp-overflow-expected.txt:
16:34 Changeset [92653] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add fast/js/regexp-overflow.html result back for Chromium. I'm not
sure why bulk-rebaseline-tests remove it. There's some bug in the
script I need to track down.

  • platform/chromium/fast/js/regexp-overflow-expected.txt: Added.
16:32 Changeset [92652] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark gradient-after-transparent-border.html as failed on chromium.

  • platform/chromium/test_expectations.txt:
16:21 Changeset [92651] by cmarrin@apple.com
  • 14 edits in trunk/Source

Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=65708

Source/WebCore:

Add logic to syncCompositingState to compute the visible rect for each
layer. This can be used to synchronously render the visible tiles of a
TiledLayer and avoid the flashing that often occurs when tiles are rendered
asynchronously. A new synchronouslyDisplayTilesInRect is also added to do
the actual rendering, but the call is not currently being made.

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::syncCompositingState):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::syncCompositingState):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::synchronouslyDisplayTilesInRect):

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::TransformState):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/mac:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

Source/WebKit2:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

16:09 Changeset [92650] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

16:07 Changeset [92649] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.9

New tag.

15:55 Changeset [92648] by abarth@webkit.org
  • 1 edit
    58 adds
    119 deletes in trunk/LayoutTests

Optimize baselines for fast/js.
This patch was created with webkit-patch bulk-optimize-baselines.

  • fast/js/exception-linenums-in-html-3-expected.txt: Added.
  • fast/js/global-constructors-expected.txt: Removed.
  • fast/js/missing-style-end-tag-js-expected.txt: Added.
  • platform/chromium-mac/fast/js/array-every-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-foreach-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-functions-non-arrays-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-some-expected.txt: Removed.
  • platform/chromium-mac/fast/js/assign-expected.txt: Removed.
  • platform/chromium-mac/fast/js/break-ASI-expected.txt: Removed.
  • platform/chromium-mac/fast/js/const-expected.txt: Removed.
  • platform/chromium-mac/fast/js/constructor-attributes-expected.txt: Removed.
  • platform/chromium-mac/fast/js/cyclic-proto-expected.txt: Removed.
  • platform/chromium-mac/fast/js/cyclic-prototypes-expected.txt: Removed.
  • platform/chromium-mac/fast/js/date-proto-generic-invocation-expected.txt: Removed.
  • platform/chromium-mac/fast/js/date-toisostring-expected.txt: Removed.
  • platform/chromium-mac/fast/js/deep-recursion-test-expected.txt: Removed.
  • platform/chromium-mac/fast/js/delete-getters-setters-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-codegen-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-for-nonobject-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-declaration-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-object-literals-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-parentheses-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt: Removed.
  • platform/chromium-mac/fast/js/invalid-syntax-for-function-expected.txt: Removed.
  • platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/StringObject-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/encode_decode_uri-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/function-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/garbage-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/lval-exceptions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/parse-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/string-1-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/string-2-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/modify-non-references-expected.txt: Removed.
  • platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-toString-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-tofixed-expected.txt: Removed.
  • platform/chromium-mac/fast/js/object-extra-comma-expected.txt: Removed.
  • platform/chromium-mac/fast/js/postfix-syntax-expected.txt: Removed.
  • platform/chromium-mac/fast/js/prefix-syntax-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-compile-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-compile-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-no-extensions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-range-out-of-order-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-test-null-string-expected.txt: Removed.
  • platform/chromium-mac/fast/js/string-capitalization-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-and-valueOf-override-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-stack-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/js/uncaught-exception-line-number-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-every-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-foreach-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-functions-non-arrays-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-some-expected.txt: Removed.
  • platform/chromium-win/fast/js/assign-expected.txt: Removed.
  • platform/chromium-win/fast/js/break-ASI-expected.txt: Removed.
  • platform/chromium-win/fast/js/const-expected.txt: Removed.
  • platform/chromium-win/fast/js/constructor-attributes-expected.txt: Removed.
  • platform/chromium-win/fast/js/cyclic-proto-expected.txt: Removed.
  • platform/chromium-win/fast/js/cyclic-prototypes-expected.txt: Removed.
  • platform/chromium-win/fast/js/date-proto-generic-invocation-expected.txt: Removed.
  • platform/chromium-win/fast/js/date-toisostring-expected.txt: Removed.
  • platform/chromium-win/fast/js/deep-recursion-test-expected.txt: Removed.
  • platform/chromium-win/fast/js/delete-getters-setters-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-codegen-crash-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-for-nonobject-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt: Removed.
  • platform/chromium-win/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-declaration-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-object-literals-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-parentheses-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt: Removed.
  • platform/chromium-win/fast/js/invalid-syntax-for-function-expected.txt: Removed.
  • platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/StringObject-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/encode_decode_uri-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/function-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/garbage-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/lval-exceptions-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/parse-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/string-1-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/string-2-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/modify-non-references-expected.txt: Removed.
  • platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-toString-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-tofixed-expected.txt: Removed.
  • platform/chromium-win/fast/js/object-extra-comma-expected.txt: Removed.
  • platform/chromium-win/fast/js/postfix-syntax-expected.txt: Removed.
  • platform/chromium-win/fast/js/prefix-syntax-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-compile-crash-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-compile-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-no-extensions-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-range-out-of-order-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-test-null-string-expected.txt: Removed.
  • platform/chromium-win/fast/js/string-capitalization-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-and-valueOf-override-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-stack-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/uncaught-exception-line-number-expected.txt: Removed.
  • platform/chromium/fast/js/array-every-expected.txt: Added.
  • platform/chromium/fast/js/array-foreach-expected.txt: Added.
  • platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Added.
  • platform/chromium/fast/js/array-some-expected.txt: Added.
  • platform/chromium/fast/js/assign-expected.txt: Added.
  • platform/chromium/fast/js/break-ASI-expected.txt: Added.
  • platform/chromium/fast/js/const-expected.txt: Added.
  • platform/chromium/fast/js/constructor-attributes-expected.txt: Added.
  • platform/chromium/fast/js/cyclic-proto-expected.txt: Added.
  • platform/chromium/fast/js/cyclic-prototypes-expected.txt: Added.
  • platform/chromium/fast/js/date-proto-generic-invocation-expected.txt: Added.
  • platform/chromium/fast/js/date-toisostring-expected.txt: Added.
  • platform/chromium/fast/js/deep-recursion-test-expected.txt: Added.
  • platform/chromium/fast/js/delete-getters-setters-expected.txt: Added.
  • platform/chromium/fast/js/exception-codegen-crash-expected.txt: Added.
  • platform/chromium/fast/js/exception-for-nonobject-expected.txt: Added.
  • platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Added.
  • platform/chromium/fast/js/exception-thrown-from-new-expected.txt: Added.
  • platform/chromium/fast/js/exceptions-thrown-in-callbacks-expected.txt: Added.
  • platform/chromium/fast/js/function-declaration-expected.txt: Added.
  • platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Added.
  • platform/chromium/fast/js/function-prototype-descriptor-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-object-literals-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-parentheses-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-semicolon-insertion-expected.txt: Added.
  • platform/chromium/fast/js/instance-of-immediates-expected.txt: Added.
  • platform/chromium/fast/js/invalid-syntax-for-function-expected.txt: Added.
  • platform/chromium/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium/fast/js/kde: Added.
  • platform/chromium/fast/js/kde/RegExp-expected.txt: Added.
  • platform/chromium/fast/js/kde/StringObject-expected.txt: Added.
  • platform/chromium/fast/js/kde/encode_decode_uri-expected.txt: Added.
  • platform/chromium/fast/js/kde/function-expected.txt: Added.
  • platform/chromium/fast/js/kde/garbage-n-expected.txt: Added.
  • platform/chromium/fast/js/kde/lval-exceptions-expected.txt: Added.
  • platform/chromium/fast/js/kde/parse-expected.txt: Added.
  • platform/chromium/fast/js/kde/string-1-n-expected.txt: Added.
  • platform/chromium/fast/js/kde/string-2-n-expected.txt: Added.
  • platform/chromium/fast/js/modify-non-references-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Removed.
  • platform/chromium/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium/fast/js/number-toString-expected.txt: Added.
  • platform/chromium/fast/js/number-tofixed-expected.txt: Added.
  • platform/chromium/fast/js/object-extra-comma-expected.txt: Added.
  • platform/chromium/fast/js/postfix-syntax-expected.txt: Added.
  • platform/chromium/fast/js/prefix-syntax-expected.txt: Added.
  • platform/chromium/fast/js/regexp-compile-crash-expected.txt: Added.
  • platform/chromium/fast/js/regexp-compile-expected.txt: Added.
  • platform/chromium/fast/js/regexp-no-extensions-expected.txt: Added.
  • platform/chromium/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-range-out-of-order-expected.txt: Added.
  • platform/chromium/fast/js/regexp-test-null-string-expected.txt: Added.
  • platform/chromium/fast/js/string-capitalization-expected.txt: Added.
  • platform/chromium/fast/js/toString-and-valueOf-override-expected.txt: Added.
  • platform/chromium/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
  • platform/chromium/fast/js/toString-stack-overflow-expected.txt: Added.
  • platform/chromium/fast/js/uncaught-exception-line-number-expected.txt: Added.
  • platform/gtk/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/gtk/fast/js/missing-style-end-tag-js-expected.txt: Removed.
  • platform/mac/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/mac/fast/js/global-constructors-expected.txt: Added.
  • platform/mac/fast/js/missing-style-end-tag-js-expected.txt: Removed.
  • platform/qt/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/qt/fast/js/missing-style-end-tag-js-expected.txt: Removed.
15:49 Changeset [92647] by lforschler@apple.com
  • 2 edits in trunk/Tools

Add triggers for Lion WK2 test bots.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:29 Changeset [92646] by abarth@webkit.org
  • 1 edit
    5 adds
    7 deletes in trunk/LayoutTests

Optimize baselines for fast/inspector-support.
This patch was created with webkit-patch bulk-optimize-baselines.

  • fast/inspector-support/style-expected.txt: Added.
  • platform/chromium-mac/fast/inspector-support: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
  • platform/chromium/fast/inspector-support: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt: Added.
  • platform/gtk/fast/inspector-support/style-expected.txt: Removed.
  • platform/mac/fast/inspector-support/style-expected.txt: Removed.
  • platform/qt/fast/inspector-support/style-expected.txt: Removed.
15:24 Changeset [92645] by abarth@webkit.org
  • 1 edit
    13 adds
    23 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/HTMLAnchorElement and fast/dom/Window.
This patch was created with webkit-patch bulk-optimize-baselines.
(Note: I massaged the two results that enumerate the global object to
leave the "base" results as matching mac even though the tool wanted to
push those results down into the mac directory.)

  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/get-set-properties-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/get-set-properties-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
  • platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt: Added.
  • platform/chromium/fast/dom/Window/get-set-properties-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
  • platform/chromium/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-properties-geolocation-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt: Added.
15:18 Changeset [92644] by abarth@webkit.org
  • 1 edit
    5 adds
    2 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/DOMException.
This patch was created with webkit-patch bulk-optimize-baselines.
(I've manually remove the README file because we don't use these sorts
of README files anymore.)

  • platform/chromium-mac/fast/dom/DOMException: Removed.
  • platform/chromium-mac/fast/dom/DOMException/EventException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/README: Removed.
  • platform/chromium-mac/fast/dom/DOMException/RangeException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/XPathException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException: Removed.
  • platform/chromium-win/fast/dom/DOMException/EventException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/README: Removed.
  • platform/chromium-win/fast/dom/DOMException/RangeException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/XPathException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/chromium/fast/dom/DOMException: Added.
  • platform/chromium/fast/dom/DOMException/EventException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/RangeException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/XPathException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/prototype-object-expected.txt: Added.
15:17 Changeset [92643] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r92619.
http://trac.webkit.org/changeset/92619
https://bugs.webkit.org/show_bug.cgi?id=65881

This patch breaks chromium canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8GCController.cpp:

(WebCore::globalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:

(WebCore::AllowAllocation::AllowAllocation):
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium:

  • src/BoundObject.cpp:
15:04 Changeset [92642] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

15:04 Changeset [92641] by abarth@webkit.org
  • 2 edits in trunk/Tools

bulk-optimize-baselines should take directories on the command line
https://bugs.webkit.org/show_bug.cgi?id=65879

Reviewed by Dimitri Glazkov.

Passing lists of tests via stdin is a pain. It's easier if the command
takes a list of tests on the command line, like run-webkit-tests.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
15:03 Changeset [92640] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.8

New tag.

15:01 Changeset [92639] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Scroll animator changes to nail the framerate
https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST):

14:53 Changeset [92638] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch legacy flexbox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65340

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::placeChild):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderDeprecatedFlexibleBox.h:
14:37 Changeset [92637] by abarth@webkit.org
  • 2 edits in trunk/Tools

Deprecate rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65873

Reviewed by Dimitri Glazkov.

This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests. This patch deprecates
the script in order to flush out any issues with the new tools. Once
folks are happy with the new tools, we'll delete this script.

  • Scripts/rebaseline-chromium-webkit-tests:
14:35 Changeset [92636] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

garden-o-matic should only touch expectations that need updating.
https://bugs.webkit.org/show_bug.cgi?id=65876

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,

so that a caller could influence which lines to serialize from values.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
14:28 Changeset [92635] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Using mprotect to create guard pages breaks our use of madvise to release executable memory
https://bugs.webkit.org/show_bug.cgi?id=65870

Reviewed by Gavin Barraclough.

Use mmap rather than mprotect to clear guard page permissions.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

14:28 Changeset [92634] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

TestExpectationsEditor should return a list of updated expectations.
https://bugs.webkit.org/show_bug.cgi?id=65872

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
14:16 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
14:07 Changeset [92633] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark preventExtensions.html as failed on chromium.

  • platform/chromium/test_expectations.txt:
14:04 Changeset [92632] by abarth@webkit.org
  • 3 edits in trunk/Tools

Fix SCM webkitpy unit test failures
https://bugs.webkit.org/show_bug.cgi?id=65823

Patch by Jochen Eisinger <jochen@chromium.org> on 2011-08-08
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
13:49 Changeset [92631] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Switch RenderStyle to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65208

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addShadowOverflow):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

  • rendering/style/RenderStyle.h:
  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):

13:39 Changeset [92630] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove counter nodes from the tree and fix-up children when they are removed from the counter map.
https://bugs.webkit.org/show_bug.cgi?id=65346

Reviewed by Adam Barth.

Covered by existing CSS counter tests.

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::~CounterNode):

13:37 Changeset [92629] by eric@webkit.org
  • 2 edits in trunk/Tools

Move the --leaks bot back over to NRWT now that I'm back
from vacation and able to debug it.

Unreviewed.

  • Scripts/run-webkit-tests:

(usingWebKit2):
(useNewRunWebKitTests):

13:32 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
13:29 Changeset [92628] by tony@chromium.org
  • 8 edits
    4 adds in trunk

implement basic horizontal flexing
https://bugs.webkit.org/show_bug.cgi?id=65045

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/001.html

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::FlexibleBoxIterator::FlexibleBoxIterator): flexitem iterator
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::first):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::next):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::reset):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::preferredFlexItemContentWidth): Returns the intrinsic size of a flex item's content.
(WebCore::RenderFlexibleBox::layoutHorizontalBlock): Runs the flex algorithm
(WebCore::preferredSizeForMarginsAndPadding):
(WebCore::RenderFlexibleBox::computePreferredSize): Calculate the preferred size of the

flex items.

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/001-expected.txt: Added.
  • css3/flexbox/001.html: Added.
  • css3/flexbox/resources/flexbox.js: Added. I plan on using this file for other tests.

(insertAfter):
(checkHorizontalBoxen):

13:18 Changeset [92627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add detail to ASSERT message in IDBTransaction::enqueueEvent
https://bugs.webkit.org/show_bug.cgi?id=65735

I've hit this a few times but haven't been able to pin it down. The
extra detail could be helpful.

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-08
Reviewed by Nate Chapin.

No new tests, just an error message.

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

13:13 Changeset [92626] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r92610.
http://trac.webkit.org/changeset/92610
https://bugs.webkit.org/show_bug.cgi?id=65868

Caused assertion failures when running fast/multicol tests
(Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

PerformanceTests:

  • Layout/floats.html:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::set):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

13:11 Changeset [92625] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Rename absoluteQuadsForRange and InlineTextBox::selectionRect to local*
https://bugs.webkit.org/show_bug.cgi?id=65722

Reviewed by Simon Fraser.

No new tests, no new functionality.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):
Rename InlineTextBox::selectionRect to localSelectionRect to reflect that
it, unlike RenderObject::selectionRect returns a rect in the local
coordinate space.

  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp:

(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint):
Rename absoluteQuadForTextBox to localQuadForTextBox to reflect that it
returns a quad in the local coordinate space.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

  • rendering/svg/SVGInlineTextBox.h:
12:59 Changeset [92624] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

Wire up updating expectations in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=65794

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
  • Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
12:54 Changeset [92623] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

Use a raw pointer to the security origin in the ctor of FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=65852

Reviewed by Alexey Proskuryakov.

  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):

  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::NavigationScheduler::scheduleLocationChange):

  • loader/NavigationScheduler.h:
12:47 Changeset [92622] by dglazkov@chromium.org
  • 5 edits
    2 deletes in branches/chromium/835

Revert r91125 for Chromium 835.

12:41 Changeset [92621] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

WebView::performLayeredWindowUpdate() crashes with
NULL pointer when using layered window updates.
https://bugs.webkit.org/show_bug.cgi?id=60618

Reviewed by Adam Roben.

During resize operations, the backing store will be destroyed if
the window's size (either height or width) is set to zero. The
bug was identified when a user first resized a WebView to zero
dimensions, then attempted to perform a MoveWindow. The paint
message triggered by the MoveWindow attempted to use the layered
window update logic, which encountered the nulled backing store.

  • WebView.cpp:

(WebView::performLayeredWindowUpdate): Add an early

return when there is no backing store to blend with.

12:15 Changeset [92620] by rniwa@webkit.org
  • 15 edits
    2 adds in trunk

Remove redundant inline styles from the pasted contents more aggressively
https://bugs.webkit.org/show_bug.cgi?id=65833

Reviewed by Tony Chang.

Source/WebCore:

Make removeRedundantStylesAndKeepStyleSpanInline more aggressively remove redundant styles by realizing that
when an editing inheritable property in an inline style declaration of an element can be safely removed
if it is present either in style rules or in its ancestor and not overridden by style rules or default style
of the element.

Test: editing/pasteboard/paste-with-redundant-style.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Do not match author style sheets if AuthorCSSRules
is not included in the rules to include. This is used in EditingStyle::removePropertiesInElementDefaultStyle.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute): Added; returns true if the element is a style span or
span possibly with a style attribute.

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement): Takes rulesToInclude.
(WebCore::EditingStyle::mergeStyleFromRules): Calls styleFromMatchedRulesForElement with AuthorCSSRules
| CrossOriginCSSRules to keep the original behavior.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Renamed from removeStyleFromRules; removes styles that
are present in context and not overridden by matched rules.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Added.

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See the description above.

LayoutTests:

Added a test to paste contents with many redundant styles. WebKit should remove as much style spans as possible
(all of this in this case).

  • editing/pasteboard/4930986-2-expected.txt: style attribute now has a trailing space.
  • editing/pasteboard/interchange-newline-1-expected.txt: No longer has a wrapping span without any attributes.
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Ditto.
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Ditto.
  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Ditto.
  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Ditto.
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Ditto.
  • editing/pasteboard/paste-with-redundant-style-expected.txt: Added.
  • editing/pasteboard/paste-with-redundant-style.html: Added.
12:11 Changeset [92619] by dslomov@google.com
  • 14 edits in trunk/Source

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by David Levin.

Covered by existing tests.

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/V8GCController.cpp:

(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by David Levin.

  • src/BoundObject.cpp: AllowAllocation moved from V8Utilities.h to V8Binding.h
12:09 Changeset [92618] by oliver@apple.com
  • 5 edits in trunk

Non-extensibility does not prevent mutating Prototype?
https://bugs.webkit.org/show_bug.cgi?id=65832

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add tests to ensure we can't assign to proto when an object
is not extensible.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Disallow mutation of proto on objects that are not extensible.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

12:09 Changeset [92617] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r92607.
http://trac.webkit.org/changeset/92607
https://bugs.webkit.org/show_bug.cgi?id=65865

This patch breaks Chromium Mac Canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::mouseWheelEvent):

11:59 Changeset [92616] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark 1 test as flaky in chromium.

  • platform/chromium/test_expectations.txt:
11:42 Changeset [92615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests cover this.

Implement WebGL antialiasing for Qt desktop.
Existing code in GraphicsContext3DOpenGL.cpp manages the
multisample FBO. GraphicsContext3DQt.cpp creates it and blits
it to the regular FBO when painting.
Requires adoption of Extensions3DOpenGL to be fully functional.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::multisampleResolve):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

11:39 Changeset [92614] by kerz@chromium.org
  • 3 edits
    3 deletes in branches/chromium/835

Reverting for crbug.com/91858
Revert 91958 - Merge 91915 - 2011-07-28 Rob Buis <rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/7532014

TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/7529030

11:35 Changeset [92613] by kerz@chromium.org
  • 1 edit
    2 deletes in branches/chromium/835/LayoutTests

Beginning revert chain to fix crbug.com/91858

Revert 91968 - Merge 91927 - [chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/7474011

TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/7558004

11:33 Changeset [92612] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test_expectations.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [92611] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::Counter::visit):

11:09 Changeset [92610] by commit-queue@webkit.org
  • 9 edits in trunk

Optimize floating elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65668

PerformanceTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-08
Reviewed by David Hyatt.

  • Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-08
Reviewed by David Hyatt.

No new tests, just a refactor on the floating objects data structure.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

11:02 Changeset [92609] by jochen@chromium.org
  • 3 edits in trunk/Tools

webkit-patch doesn't get along with renamed files
https://bugs.webkit.org/show_bug.cgi?id=48075

Possibly a bit heavy handed - I removed all instances of -C and
changed every instance of -M with '--no-renames' in git.py. This
forces git to not try to tell us about renames at all, which is
ultimately the behaviour we want. The old file is shown deleted,
then the new file is shown added, followed by any changes that
occurred. Also gets rid of the problem where deleting one file
and adding another file which has similar content would
unexpectedly show up as a rename, and fall out of a diff.

Based on a patch by Wyatt Carss.

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:
11:00 Changeset [92608] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark some tests as flaky on chromium.

  • platform/chromium/test_expectations.txt:
10:56 Changeset [92607] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[Chromium] Enable rubber banding when scrolling.

https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-08
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

10:54 Changeset [92606] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS from 95576 to 95783.

  • DEPS:
10:52 Changeset [92605] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Cairo][Gtk] Get more of the philip suite of canvas tests passing
https://bugs.webkit.org/show_bug.cgi?id=54458

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-08-08
Reviewed by Martin Robinson.

Update the list of skipped canvas tests and describe why platform-specific
failures occur.

  • platform/gtk/Skipped:
10:43 Changeset [92604] by andersca@apple.com
  • 6 edits
    2 copies
    5 adds in trunk/LayoutTests

More Lion specific results.

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/editing: Added.
  • platform/mac-snowleopard/editing/input: Added.
  • platform/mac-snowleopard/editing/input/devanagari-ligature-expected.png: Copied from platform/mac/editing/input/devanagari-ligature-expected.png.
  • platform/mac-snowleopard/editing/input/devanagari-ligature-expected.txt: Copied from platform/mac/editing/input/devanagari-ligature-expected.txt.
  • platform/mac-snowleopard/fast/xsl: Added.
  • platform/mac-snowleopard/fast/xsl/sort-locale-expected.txt: Added.
  • platform/mac/editing/input/devanagari-ligature-expected.png:
  • platform/mac/editing/input/devanagari-ligature-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/fast/xsl/sort-locale-expected.txt: Added.
10:28 Changeset [92603] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
https://bugs.webkit.org/show_bug.cgi?id=65860

Reviewed by Simon Fraser.

When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
unconditionally.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):

10:20 Changeset [92602] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix more typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
09:27 Changeset [92601] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-08 Pavel Podivilov <podivilov@chromium.org>

Web Inspector: unreviewed, build fix for r92598.

  • inspector/debugger/script-formatter.html:
09:26 Changeset [92600] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::sizeShouldIncludeDecoration): Fixed an obvious typo.

09:13 Changeset [92599] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Clean up project file after r92492.

Unreviewed gardening.

No new tests needed.

  • WebCore.pro: remove nonexistent PluginHalterClient.h, PluginHalter.h, HaltablePlugin.h.
08:50 Changeset [92598] by podivilov@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: refactor links creation.
https://bugs.webkit.org/show_bug.cgi?id=65612

Reviewed by Pavel Feldman.

No new tests - it is refactoring, modified code covered by script-formatter.html test.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/Panel.js:
  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.linkifyUncopyable):
(WebInspector.StylePropertiesSection):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/inspector.js:

(WebInspector._showSettingsScreen):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):

08:34 Changeset [92597] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Fix typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
08:29 Changeset [92596] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests.

Adopt Extensions3DOpenGL for Qt desktop as a prerequisite
for implementing WebGL antialiasing.
Extensions3DQt is still used for ES2.

  • WebCore.pri:
  • WebCore.pro:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::layerComposited):

08:05 Changeset [92595] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Marks the tests as failing on Chromium.

  • platform/chromium/test_expectations.txt:
07:25 Changeset [92594] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

Build fix after r92589, defaultSize is not used.

Reviewed by Andreas Kling.

  • html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

05:50 Changeset [92593] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT does not track speculation decisions for global variables
https://bugs.webkit.org/show_bug.cgi?id=65825

Reviewed by Gavin Barraclough.

Added the capability to track predictions for global variables, and
ensured that code can abstract over the source of prediction (local
versus global variable) wherever it is appropriate to do so. Also
cleaned up the code in SpeculativeJIT that decides how to speculate
based on recorded predictions (for example instead of using isInteger,
which makes sense for local predictions where the GetLocal would
return an integer value, we now tend to use shouldSpeculateInteger,
which checks if the value is either already an integer or should be
speculated to be an integer).

This is an 0.8% win on SunSpider, almost entirely thanks to a 25%
win on controlflow-recursive. It's also a 4.8% win on v8-crypto.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):

05:44 Changeset [92592] by keishi@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

  • WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and

ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE

  • WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::isColorInputType): Returns true.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.

  • html/ColorInputType.h:
  • html/FileInputType.cpp:
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach): Calls InputType::detach

  • html/InputType.cpp:

(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.

  • html/InputType.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::openColorChooser):
(WebCore::EmptyChromeClient::closeColorChooser):
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Close color chooser when navigating away from the page. We do this here
because ColorInputType::detach() is called seconds after the page transition so it is too slow.

  • page/Chrome.cpp:

(WebCore::Chrome::openColorChooser): Added.
(WebCore::Chrome::closeColorChooser): Added.
(WebCore::Chrome::setSelectedColorInColorChooser): Added.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Added.

(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.

  • platform/ColorChooser.h: Added.

(WebCore::ColorChooserClient::isColorInputType): Added.
(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

05:16 Changeset [92591] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/forms/input-number-size.html added in r92589 fails
https://bugs.webkit.org/show_bug.cgi?id=65851

Unreviewed gardening.

  • platform/qt/Skipped: Skip the test.
03:56 Changeset [92590] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65847

Unreviewed.

  • platform/chromium/test_expectations.txt:
02:16 Changeset [92589] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Source/WebCore: The input[type=number] element should be as wide as necessary to show the widest possible value.
https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

The size of input[type=number] is calculated from min/max/step attributes to show the widest possible value.
If min or max attribute is absent, the default size is used.
Also, if its css width is not auto, the width is used with priority.

If min/max/attribute is set dynamically, the size of the input[type=number] will be recalculated.

Test: fast/forms/input-number-size.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

Added stepAttributeChanged handler.

(WebCore::HTMLInputElement::sizeShouldIncludeDecoration):

Returns true if a renderer should include decoration (e.g. inner spinbox).
Also returns the preferred size of the input.

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.

(WebCore::InputType::stepAttributeChanged):

Will be called When step attribute is changed.
Sets a flag to recalculate layout.

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::lengthBeforeDecimalPoint):

Calculates the width before the decimal point.

(WebCore::NumberInputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.
However, this will calculate the preferred size from min/max/step attribute.

(WebCore::NumberInputType::minOrMaxAttributeChanged):

Sets a flag to recalculate layout.

(WebCore::NumberInputType::stepAttributeChanged): ditto.

  • html/NumberInputType.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentWidth):

Uses preferredSize instead of size.
Also, adds innerSpinButtonElement size to width if sizeShouldIncludeDecoration returns true.

LayoutTests: Added the test to check the width of input[type=number].
https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

  • fast/forms/input-number-size-expected.txt: Added.
  • fast/forms/input-number-size.html: Added.
01:42 Changeset [92588] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should not use C-style cast in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=65807

Remove C-style cast.

Reviewed by Kent Tamura.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction): Replaced a cast with clampToInteger().
(WebCore::CSSParser::parseFontFeatureTag): Ditto.
(WebCore::CSSParser::createKeyframeRule): Replaced a cast with C++-style cast.

01:12 Changeset [92587] by pfeldman@chromium.org
  • 23 edits in trunk/Source

Web Inspector: implement dock/undock in WebKit2 without getting into WebCore.
https://bugs.webkit.org/show_bug.cgi?id=65763

Source/WebCore:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/inspector.js:

(windowLoaded):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/js/DevTools.js:

(devtools.domContentLoaded):

Source/WebKit2:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didLoadInspectorPage):

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in:
00:32 Changeset [92586] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip divergent tests
https://bugs.webkit.org/show_bug.cgi?id=65831

  • platform/qt/Skipped:
00:25 Changeset [92585] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

[Chromium] Make form validation bubble fit with Chrome UI style
https://bugs.webkit.org/show_bug.cgi?id=65359

Reviewed by Hajime Morita.

Source/WebCore:

Change the appearance of validation message bubble for
Chromium. Basically it doesn't change for other ports.

  • Introduce a new element to put an icon, and enclose it and the

message text by a flexible box.

  • Repesent the message text by two elements. One for the heading,

another for the remaining.

  • Introduce themeChromium.css
  • WebCore.gyp/WebCore.gyp: Add themeChromium.css.
  • css/html.css:

(::-webkit-validation-bubble-message): Make this a flexible box container.
(::-webkit-validation-bubble-text-block): Takes flexibility.
(::-webkit-validation-bubble-heading):
Make the content bold because we removed <b></b>.

  • css/themeChromium.css: Added.

(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
(::-webkit-validation-bubble-icon):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-body):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Sets the text into m_messageHeading and m_messageBody, instead of m_bubbleMessage.
Use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::buildBubbleTree):
Build the new structure, and use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::deleteBubbleTree):
Clear m_messageHeading and m_messageBody.

  • html/ValidationMessage.h:
  • rendering/RenderThemeChromiumMac.h: Add extraDefaultStyleSheet().
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::extraDefaultStyleSheet): Append themeChromium.css.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): Append themeChromium.css.

LayoutTests:

  • fast/forms/validation-message-appearance.html: Need to wait for a litle because of image loading.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
00:03 Changeset [92584] by kerz@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92529 - Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7585032

08/07/11:

23:38 Changeset [92583] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754

Unreviewed chromium test_expectations.txt update
No more failure as r92439 was rolled out by r92453

  • platform/chromium/test_expectations.txt:
23:02 Changeset [92582] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
21:06 Changeset [92581] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix after r92578. I accidentally added the call to dumpAsText(true).

  • editing/pasteboard/nested-blocks-with-text-area.html:
20:46 Changeset [92580] by rniwa@webkit.org
  • 3 edits
    2 adds
    17 deletes in trunk/LayoutTests

Dump-as-markup conversion: paste-blockquote-into-blockquote.html and prevent-block-nesting-01.html
https://bugs.webkit.org/show_bug.cgi?id=65837

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
  • editing/pasteboard/prevent-block-nesting-01.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
20:31 Changeset [92579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758

Test is now green on chromium and webkit build bots.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
19:47 Changeset [92578] by rniwa@webkit.org
  • 3 edits
    2 adds
    23 deletes in trunk/LayoutTests

Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html
https://bugs.webkit.org/show_bug.cgi?id=65836

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-area.html:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-field.html:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
19:28 Changeset [92577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757

This test and the others mentioned in the bug are now green on chromium
and webkit build bots.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
19:06 Changeset [92576] by koz@chromium.org
  • 8 edits in trunk/Source

Make the fullscreen JS API enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

  • dom/Document.idl:
  • dom/Element.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

15:16 Changeset [92575] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-through-* results diverging between bots
https://bugs.webkit.org/show_bug.cgi?id=65831

Unreviewed Qt gardening.

  • platform/qt/Skipped:
12:42 Changeset [92574] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebKit2

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

  • UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

06:47 Changeset [92573] by mrobinson@webkit.org
  • 5 edits in trunk/Source

Distribution fix for GTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Strip removed files from the source list.

Source/WebCore:

  • GNUmakefile.am: Add some files to the distribution list.
  • GNUmakefile.list.am: Strip removed files from the source list.
04:29 Changeset [92572] by jochen@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

Move FrameLoadRequest to loader/
https://bugs.webkit.org/show_bug.cgi?id=65817

Reviewed by Alexey Proskuryakov.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::requester):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):

02:48 Changeset [92571] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Source/WebCore: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

New AccessibilityObject cache search functionality and API for the mac
platform to expose it. At this point the AccessibilityObject cache can
be searched using one of the supported search keys that have been defined
in AccessibilityObject.h, or by passing search text.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-predicate.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::accessibilityObjectContainsText):
(WebCore::AccessibilityObject::accessibleObjectsWithAccessibilitySearchPredicate):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

Added testing support for AccessibilityObject cache searching. Currently,
only the mac platform is full supported and has had API exposed. Other
platforms have only have this new functionality stubbed. Full implementation
is a job suited only for an accessibility expert of each respective platform.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

Tests for the new AccessibilityObject cache search API and the additional
functionality in the AccessibilityObject class that makes AccessibilityObject
cache searching possible.

Additional tests for finding frames, misspellings, and visited links will be
included in a subsequent patch.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/search-predicate-expected.txt: Added.
  • platform/mac/accessibility/search-predicate.html: Added.
01:01 Changeset [92570] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline a test on GTK+ for which r92554 checked in an
incorrect result.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Update results.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Ditto.

08/06/11:

20:44 Changeset [92569] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.

Reviewed by Oliver Hunt.

This is a 1% win on SunSpider.

  • dfg/DFGOperations.cpp:
    • Use fastGetOwnProperty.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Use fastGetOwnProperty.
  • runtime/JSCell.h:
  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnProperty):

  • Fast call to get a property without creating an identifier the first time.
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

  • Add interface to look up by either strinsg or identifiers.
  • runtime/Structure.h:

(JSC::Structure::get):

  • Add a get() call that takes a UString, not an Identifier.
  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasHash):

  • Add a call to check if the has has been set (to detect the first use as a property name).
18:09 Changeset [92568] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.

18:09 Changeset [92567] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Adopt the newly-allocated WebHTMLConverter
instance so that it does not leak.

16:35 Changeset [92566] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.
Fix environmental differencies in the results added in r92564.
I was in the wrong chroot.

  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
15:36 Changeset [92565] by siddharth.mathur@nokia.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add Siddharth Mathur to committer list. Unreviewed

15:29 Changeset [92564] by kbalazs@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed gardening.
Add missing Qt results.

  • platform/qt/Skipped:
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
15:19 Changeset [92563] by abarth@webkit.org
  • 6 edits
    6 deletes in trunk/Tools

Remove dead code in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=65818

Reviewed by Dimitri Glazkov.

This code was added to support the rebaseline2 command six months ago,
but the rebaseline2 command was never finished and no one else has used
this code since it was landed. This patch removes the dead code. If
we revive rebaseline2, then we can revert this patch and recover the
code. Until then, this code is just dead weight.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/testoutput.py: Removed.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:17 Changeset [92562] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit-patch optimize-baselines can't handle promotions to base results directory
https://bugs.webkit.org/show_bug.cgi?id=65819

Reviewed by Dimitri Glazkov.

This bug came up when testing the optimizer on some editing baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
15:04 Changeset [92561] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Fix baselines for cross-origin-xsl-BLOCKED.html. These results
uncovered a subtle bug in webkit-patch bulk-optimize-baselines, which
I'll fix in a follow-up patch.

  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
14:24 Changeset [92560] by abarth@webkit.org
  • 1 edit
    3 adds
    8 deletes in trunk/LayoutTests

Optimize expected results for editing.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-paste-float-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
14:11 Changeset [92559] by abarth@webkit.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Optimize expected results for animations.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium/animations/keyframes-rule-expected.txt: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Removed.
14:07 Changeset [92558] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add a small command to optimize baselines in bulk.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
13:48 Changeset [92557] by abarth@webkit.org
  • 1 edit
    50 adds
    82 deletes in trunk/LayoutTests

Optimize expected results for http/tests/security.
This patch was created with webkit-patch optimize-baselines.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium/http/tests/security/dataURL: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/frameNavigation: Added.
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/listener: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-eval-expected.txt: Added.
13:17 Changeset [92556] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Timer heap implementation to work with more libraries (other versions of STL)
https://bugs.webkit.org/show_bug.cgi?id=65782

Reviewed by Anders Carlsson.

No behavior change, so no tests needed. Existing tests pass.

  • platform/Timer.cpp: Added TimerHeapPointer and TimerHeapReference class

alongside the TimerHeapIterator class. Also added a swap function. Also
added a TimerHeapLessThanFunction class.
(WebCore::TimerBase::heapDecreaseKey): Pass pointers in to the TimerHeapIterator
since that's how the class works now. Pass a TimerHeapLessThanFunction object
instead of letting the library use the < operator directly.
(WebCore::TimerBase::heapPopMin): Ditto.

  • platform/Timer.h: Updated for above changes.
12:52 Changeset [92555] by commit-queue@webkit.org
  • 11 edits in trunk

Patch by Aron Rosenberg <arosenberg@logitech.com> on 2011-08-06
Reviewed by Benjamin Poulain.

[Qt] Fix build with Intel compiler on Windows
https://bugs.webkit.org/show_bug.cgi?id=65088

.:

Disable Intel Compiler warning 873 - function "" has no corresponding operator
delete (to be called if an exception is thrown during initialization of an
allocated object).

  • Source/WebKit.pri:

Source/JavaScriptCore:

Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays

Source/WebCore:

Intel compiler needs .lib suffixes instead of .a

  • WebCore.pri:

Source/WebKit2:

Intel compiler needs .lib suffixes instead of .a

  • WebKit2.pri:
10:09 Changeset [92554] by zimmermann@webkit.org
  • 6 edits
    2 deletes in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Rebaseline some tests on Leopard/gtk/qt in order to get the bots greener.

Not reviewed.


  • platform/gtk/Skipped:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
10:00 Changeset [92553] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
https://bugs.webkit.org/show_bug.cgi?id=65809

Reviewed by Darin Adler and Sam Weinig.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.

  • platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.

09:17 Changeset [92552] by joepeck@webkit.org
  • 5 edits in trunk/Source

Potential Leaks - RetainPtr<> over retaining Create'd objects
https://bugs.webkit.org/show_bug.cgi?id=65806

Reviewed by Darin Adler.

Fix a possible leak by adopting an allocation instead of retaining it.

Source/WebCore:

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView previousValidKeyView]):

08:57 Changeset [92551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION (r91540): Favicons are not loaded
https://bugs.webkit.org/show_bug.cgi?id=65692

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.

The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::documentCanHaveIcon):

  • loader/icon/IconDatabaseBase.h:
08:23 Changeset [92550] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)

  • try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.

Rubber-stamped by Antti Koivisto.

  • svg/zoom/resources/testPageZoom.js: (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().
03:02 Changeset [92549] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should use C++-style cast in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=65807

Replaces C-style cast with C++style cast.

Reviewed by Shinichiro Hamaji.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):

02:40 Changeset [92548] by zimmermann@webkit.org
  • 3 edits
    6 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.


Not reviewed.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
02:27 Changeset [92547] by zimmermann@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.

Not reviewed.

  • platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
02:19 Changeset [92546] by zimmermann@webkit.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

Follow-up for r92545.


Rebaseline some tests on gtk/qt and win.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
01:25 Changeset [92545] by zimmermann@webkit.org
  • 6 edits
    6 moves
    30 adds in trunk

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
Add several new tests in svg/as-object - covering bug 64974.

  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
  • svg/as-object/embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
  • svg/as-object/embedded-svg-size-changes.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes.html: Added.
  • svg/as-object/resources: Added.
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
  • svg/as-object/resources/embedded-svg-size-changes.svg: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
through RenderSVGRoot::layout.

And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
document to be laid out again, now that the size of the embedded SVG document is known.

As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
right before painting.

A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
FrameView::layout().

Consider following document:
<body><iframe src="some.svg"></body>


After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
(in the simplest case, where width/height are both auto).

Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.

After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).

The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).

Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.

Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html

svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/embedded-svg-immediate-offsetWidth-query.html
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished. (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method. (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
  • page/FrameView.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
  • rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
  • rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic. (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).

08/05/11:

21:19 BuildingQtOnLinux edited by rafael.lobo@openbossa.org
(diff)
21:14 Changeset [92544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove HaltablePlugin references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=65808

HaltablePlugin and related classes were removed in r92492. Remove any
reference to the deleted files from the gyp project files.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Adam Barth.

  • WebCore.gypi: remove HaltablePlugin.h reference.
20:49 Changeset [92543] by mitz@apple.com
  • 6 edits
    13 moves in trunk/LayoutTests

Renamed fast/blockflow to fast/writing-mode.

Rubber-stamped by Sam Weinig.

  • fast/blockflow: Removed.
  • fast/writing-mode: Copied from fast/blockflow.
  • platform/chromium-linux/fast/blockflow: Removed.
  • platform/chromium-linux/fast/writing-mode: Copied from platform/chromium-linux/fast/blockflow.
  • platform/chromium-mac-leopard/fast/blockflow: Removed.
  • platform/chromium-mac-leopard/fast/writing-mode: Copied from platform/chromium-mac-leopard/fast/blockflow.
  • platform/chromium-mac/fast/blockflow: Removed.
  • platform/chromium-mac/fast/writing-mode: Copied from platform/chromium-mac/fast/blockflow.
  • platform/chromium-win-vista/fast/blockflow: Removed.
  • platform/chromium-win-vista/fast/writing-mode: Copied from platform/chromium-win-vista/fast/blockflow.
  • platform/chromium-win-xp/fast/blockflow: Removed.
  • platform/chromium-win-xp/fast/writing-mode: Copied from platform/chromium-win-xp/fast/blockflow.
  • platform/chromium-win/fast/blockflow: Removed.
  • platform/chromium-win/fast/writing-mode: Copied from platform/chromium-win/fast/blockflow.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/blockflow: Removed.
  • platform/gtk/fast/writing-mode: Copied from platform/gtk/fast/blockflow.
  • platform/mac-leopard/fast/blockflow: Removed.
  • platform/mac-leopard/fast/writing-mode: Copied from platform/mac-leopard/fast/blockflow.
  • platform/mac-wk2/fast/blockflow: Removed.
  • platform/mac-wk2/fast/writing-mode: Copied from platform/mac-wk2/fast/blockflow.
  • platform/mac/Skipped:
  • platform/mac/fast/blockflow: Removed.
  • platform/mac/fast/writing-mode: Copied from platform/mac/fast/blockflow.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/blockflow: Removed.
  • platform/qt/fast/writing-mode: Copied from platform/qt/fast/blockflow.
  • platform/win/fast/blockflow: Removed.
  • platform/win/fast/writing-mode: Copied from platform/win/fast/blockflow.
  • platform/wk2/Skipped:
20:09 Changeset [92542] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build after r92538.

Like all of the recent "track"-related work the new files in r92538 appear to have
been added to completely random places in the Xcode project. However, this time
the file paths were marked as being relative to their containing group resulting in
Xcode being unable to find the files on disk.

I've attempted to clean up all of the "track"-related mess in the Xcode project.
The location of the files in the project now reflect their locations on disk, and
are all correctly marked as being relative to their containing group as is our
convention.

  • WebCore.xcodeproj/project.pbxproj:
19:25 Changeset [92541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.

Patch by Tom Hudson <tomhudson@google.com> on 2011-08-05
Reviewed by James Robinson.

No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

19:17 Changeset [92540] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String replace with the empty string means string removal
https://bugs.webkit.org/show_bug.cgi?id=65799

Reviewed by Sam Weinig.

Optimization for String.prototype.replace([RegExp], ""), this improves v8-regexp by ~3%.

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::stringProtoFuncReplace):

19:07 Changeset [92539] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

r92330 has been rolled out so its rebaseline needs to be reverted as well
https://bugs.webkit.org/show_bug.cgi?id=65805

  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
19:00 Changeset [92538] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Adding a WebVTTParser for <track>.
https://bugs.webkit.org/show_bug.cgi?id=62882

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-05
Reviewed by Eric Carlson.

Feature is hidden behind VIDEO_TRACK feature define, which is turned off, but
new tests have been added in media/track/ (and are skipped).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCue.cpp:
  • html/TextTrackCue.h:
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
  • platform/track/CueParserPrivate.h:
  • platform/track/WebVTTParser.cpp: Added.
  • platform/track/WebVTTParser.h: Added.
18:47 Changeset [92537] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r92330.
http://trac.webkit.org/changeset/92330
https://bugs.webkit.org/show_bug.cgi?id=65804

caused various regressions in paste (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::doApply):

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-paste-text-in-h1-expected.txt: Removed.
  • editing/pasteboard/copy-paste-text-in-h1.html: Removed.
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
18:45 Changeset [92536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Chromium] Remove JSZombie references from gyp project files.
https://bugs.webkit.org/show_bug.cgi?id=65798

JSC runtime/JSZombie.{cpp,h} were removed in r92046. Remove references to these
file names from the gyp projects.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Darin Adler.

18:33 Changeset [92535] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 91908
BUG=90668

18:31 Changeset [92534] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91908
BUG=90668
Review URL: http://codereview.chromium.org/7550057

18:06 Changeset [92533] by tkent@chromium.org
  • 15 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r92477.
http://trac.webkit.org/changeset/92477
https://bugs.webkit.org/show_bug.cgi?id=62619

Layering violation. We should not use WebCore/dom/ in
WebCore/platform/.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::valueChanged):

  • html/ColorInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::chrome):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach):

  • html/InputType.cpp:
  • html/InputType.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Removed.
  • platform/ColorChooser.h: Removed.
17:47 Changeset [92532] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Qt Mac build.

  • plugins/mac/PluginViewMac.mm: Removed PluginHalter functions.
17:41 Changeset [92531] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a failing test added by r92526 to Qt's skipped list.
The failure is tracked by the bug 65801.

  • platform/qt/Skipped:
17:24 Changeset [92530] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
https://bugs.webkit.org/show_bug.cgi?id=65789

Reviewed by David Kilzer.

Fix a leak by adopting an allocation instead of retaining it.

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::httpBodyFromRequest):

17:15 Changeset [92529] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

17:06 Changeset [92528] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on 32-bit Mac.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag): Added a cast to int.

16:53 Changeset [92527] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip test eeza-Pro-vertical-metrics-adjustment.html in chromium.

  • platform/chromium/test_expectations.txt:
16:41 Changeset [92526] by rniwa@webkit.org
  • 3 edits
    4 copies in trunk

Upwards cursor movement incorrect when previous block ends with <br>
https://bugs.webkit.org/show_bug.cgi?id=33247

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by previousLinePosition's trying to obtain the root line box at the position
after the previous line's br. This obviously fails because the the position after br is considered
as a part of the next line.

Fixed the bug by obtaining root inline boxes using position at the minimum caret offset as supposed
to maximum caret offset. The code was initially introduced by r32508 to fix arrow key movement in RTL text
but the test added by the revision continues to pass after this change. Furthermore, this change makes
new code consistent with nextLinePosition.

Also reverted the change added by r55613 because it is no longer needed.

Tests: editing/execCommand/move-selection-back-line-rtl.html

editing/execCommand/move-selection-back-line-strict.html

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):

LayoutTests:

Added tests to ensure WebKit lets user move caret up in strict mode and in RTL content
when the previous line ends with a br.

  • editing/execCommand/move-selection-back-line-rtl-expected.txt: Copied from

LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.

  • editing/execCommand/move-selection-back-line-rtl.html: Copied from

LayoutTests/editing/execCommand/move-selection-back-line.html.

  • editing/execCommand/move-selection-back-line-strict-expected.txt: Copied from

LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.

  • editing/execCommand/move-selection-back-line-strict.html: Copied from

LayoutTests/editing/execCommand/move-selection-back-line.html.

16:03 Changeset [92525] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

16:02 Changeset [92524] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.7

New tag.

15:36 Changeset [92523] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
is tied to a particular dispatch queue

A RefCounted object can be opted in to this mode by calling setDispatchQueueForVerifier
with the dispatch queue it will be tied to. This will cause ThreadRestrictionVerifier
to ensure that all operations are performed on the given dispatch queue.

Reviewed by Anders Carlsson.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::setDispatchQueueForVerifier):

  • wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::~ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::setShared):
(WTF::ThreadRestrictionVerifier::isSafeToUse):

15:33 Changeset [92522] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Build Fix.

15:15 Changeset [92521] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91531
BUG=89552
Review URL: http://codereview.chromium.org/7585022

15:14 Changeset [92520] by commit-queue@webkit.org
  • 24 edits
    2 adds in trunk/Source

[chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402

Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.

Source/WebCore:

Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.

  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Source/WebKit/chromium:

Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
15:12 Changeset [92519] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91308
BUG=89575
Review URL: http://codereview.chromium.org/7541053

15:08 Changeset [92518] by andersca@apple.com
  • 6 edits
    5 copies
    9 adds in trunk/LayoutTests

Add more Lion specific test results and add more tests to the skipped list.

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/fast/dom: Added.
  • platform/mac-snowleopard/fast/dom/52776-expected.png: Copied from platform/mac/fast/dom/52776-expected.png.
  • platform/mac-snowleopard/fast/dom/52776-expected.txt: Copied from platform/mac/fast/dom/52776-expected.txt.
  • platform/mac-snowleopard/fast/loader: Added.
  • platform/mac-snowleopard/fast/preloader: Added.
  • platform/mac-snowleopard/fast/preloader/document-write-2-expected.txt: Copied from fast/preloader/document-write-2-expected.txt.
  • platform/mac-snowleopard/fast/preloader/document-write-expected.txt: Copied from fast/preloader/document-write-expected.txt.
  • platform/mac-snowleopard/fast/preloader/script-expected.txt: Copied from fast/preloader/script-expected.txt.
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/preloader: Added.
  • platform/mac/fast/preloader/document-write-2-expected.txt: Added.
  • platform/mac/fast/preloader/document-write-expected.txt: Added.
  • platform/mac/fast/preloader/script-expected.txt: Added.
15:02 Changeset [92517] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip canvas-putImageData.html in chromium.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [92516] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Build Fix.

14:33 Changeset [92515] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Fix unit test breakage by plumbing convert_404_to_None in MockWeb.

  • Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
14:09 Changeset [92514] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Garden-o-matic updateexpectations needs a unit test.
https://bugs.webkit.org/show_bug.cgi?id=65780

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
14:07 Changeset [92513] by andersca@apple.com
  • 5 edits in trunk

Future proof an Objective-C test
https://bugs.webkit.org/show_bug.cgi?id=65788

Tools:

Reviewed by Dan Bernstein.

Add isObjectInstanceOf to ObjCController.

  • DumpRenderTree/mac/ObjCController.m:

(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController isObject:instanceOf:]):

LayoutTests:

Don't check explicitly for class names; just check that the objects are instances of the right classes.

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
14:00 Changeset [92512] by lforschler@apple.com
  • 6 edits in branches/safari-534.51-branch/Source/WebKit/win

Merge r92414.

13:55 Changeset [92511] by lforschler@apple.com
  • 8 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92404.

13:50 Changeset [92510] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7569017

13:49 Changeset [92509] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r92345.

13:47 Changeset [92508] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92398.

13:40 Changeset [92507] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92309.

13:38 Changeset [92506] by lforschler@apple.com
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92308.

13:34 Changeset [92505] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/835

Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7585017

13:33 Changeset [92504] by lforschler@apple.com
  • 4 edits in branches/safari-534.51-branch/Source

Merge r92210.

13:33 Changeset [92503] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7491067

13:29 Changeset [92502] by andersca@apple.com
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Add a Lion specific test for fast/repaint/canvas-putImageData.html

  • platform/mac-snowleopard/fast/repaint: Added.
  • platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from fast/repaint/canvas-putImageData-expected.txt.
  • platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
13:26 Changeset [92501] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7550046

13:20 Changeset [92500] by andersca@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.gypi

Actually commit the file.

13:19 Changeset [92499] by andersca@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix Chromium build.

  • WebCore.gypi:
13:03 Changeset [92498] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Inline allocation of function objects
https://bugs.webkit.org/show_bug.cgi?id=65779

Reviewed by Gavin Barraclough.

Inline allocation and initilisation of function objects
in generated code. This ended up being a 60-70% improvement
in function allocation performance. This improvement shows
up as a ~2% improvement in 32bit sunspider and V8, but is a
wash on 64-bit.

We currently don't inline the allocation of named function
expressions, as that requires being able to gc allocate a
variable object.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emitStoreCell):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):

  • jit/JITOpcodes32_64.cpp:

Removed duplicate implementation of op_new_func and op_new_func_exp

  • runtime/JSFunction.h:

(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):

12:55 Changeset [92497] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Tools

trac.js needs unittests
https://bugs.webkit.org/show_bug.cgi?id=65673

Reviewed by Dimitri Glazkov.

This tests also have somewhat large fixtures. I've trimmed the example
XML down a bunch while still hitting interesting cases in the parsing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
12:49 Changeset [92496] by andersca@apple.com
  • 24 edits
    20 copies
    1 add in trunk/LayoutTests

Add more Lion specific test results.

  • platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Copied from platform/mac/fast/text/capitalize-boundaries-expected.png.
  • platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.txt: Copied from platform/mac/fast/text/capitalize-boundaries-expected.txt.
  • platform/mac-snowleopard/fast/text/complex-text-opacity-expected.png: Copied from platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-snowleopard/fast/text/complex-text-opacity-expected.txt: Copied from platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-snowleopard/fast/text/international: Added.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bold-bengali-expected.png: Copied from platform/mac/fast/text/international/bold-bengali-expected.png.
  • platform/mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Copied from platform/mac/fast/text/international/bold-bengali-expected.txt.
  • platform/mac-snowleopard/fast/text/international/khmer-selection-expected.png: Copied from platform/mac/fast/text/international/khmer-selection-expected.png.
  • platform/mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Copied from platform/mac/fast/text/international/khmer-selection-expected.txt.
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bold-bengali-expected.png:
  • platform/mac/fast/text/international/bold-bengali-expected.txt:
  • platform/mac/fast/text/international/khmer-selection-expected.png:
  • platform/mac/fast/text/international/khmer-selection-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
12:41 Changeset [92495] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two fast/text tests to the skipped list.

  • platform/mac-lion/Skipped:
12:24 Changeset [92494] by andersca@apple.com
  • 11 edits
    10 copies
    3 adds in trunk/LayoutTests

Add Lion specific test results for css1 and css2.1.

  • platform/mac-snowleopard/css1: Added.
  • platform/mac-snowleopard/css1/font_properties: Added.
  • platform/mac-snowleopard/css1/font_properties/font-expected.png: Copied from platform/mac/css1/font_properties/font-expected.png.
  • platform/mac-snowleopard/css1/font_properties/font-expected.txt: Copied from platform/mac/css1/font_properties/font-expected.txt.
  • platform/mac-snowleopard/css2.1: Added.
  • platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.png.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.txt.
  • platform/mac/css1/font_properties/font-expected.png:
  • platform/mac/css1/font_properties/font-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/css2.1/t1508-c527-font-05-b-expected.png:
  • platform/mac/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/mac/css2.1/t1508-c527-font-10-c-expected.png:
  • platform/mac/css2.1/t1508-c527-font-10-c-expected.txt:
11:50 Changeset [92493] by abarth@webkit.org
  • 10 edits in trunk/Tools

Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
https://bugs.webkit.org/show_bug.cgi?id=65759

Reviewed by Dimitri Glazkov.

rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
architecture, is poorly tested, and has a bunch of quirks. This patch
rebuilds the core functionality of rebaseline-chromium-webkit-tests on
top of more modern infrastructure. In the process, we get more code
re-use and better testing.

Once we're satisfied with this new implementation, we can delete the
old implementation.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/net/web.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
11:44 Changeset [92492] by andersca@apple.com
  • 45 edits
    9 deletes in trunk

Remove PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=65729

Reviewed by Darin Adler.

Source/WebCore:

Remove plug-in halter and associated classes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h:
  • page/HaltablePlugin.h: Removed.
  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:
  • page/PluginHalter.cpp: Removed.
  • page/PluginHalter.h: Removed.
  • page/PluginHalterClient.h: Removed.
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

  • rendering/RenderWidget.h:

Source/WebKit:

Remove deleted files from Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Remove plug-in halter and associated classes.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):

  • WebCoreSupport/WebPluginHalterClient.h: Removed.
  • WebCoreSupport/WebPluginHalterClient.mm: Removed.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/win:

Remove plug-in halter and associated classes.

  • Interfaces/IWebPluginHalterDelegate.idl: Removed.
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebPluginHalterClient.cpp: Removed.
  • WebCoreSupport/WebPluginHalterClient.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::close):
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
(WebView::unused1):
(WebView::unused2):
(WebView::unused3):
(WebView::unused4):
(WebView::unused5):

  • WebView.h:

Source/WebKit/wx:

Don't include PluginHalterClient.h, it's been removed.

  • WebView.cpp:

Tools:

Remove call to set the allowed plug-in run time.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

11:23 Changeset [92491] by darin@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

[WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state
https://bugs.webkit.org/show_bug.cgi?id=63779

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent): Unrelated cleanup. Removed unneeded local variable.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates): Rearranged code so that the call to
setPaintBehavior is after the early exit. Also got rid of unneeded save/restore since
the function uses a graphics context that it then throws away.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Ditto.

11:18 Changeset [92490] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534.51-branch/Source/WebCore

Merge r92035.

11:14 Changeset [92489] by lforschler@apple.com
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92034.

11:04 Changeset [92488] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip those tests still failing on chromium due to incomplete
baseline caused by r92466.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [92487] by jochen@chromium.org
  • 5 edits in trunk/Source

Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
10:58 Changeset [92486] by thakis@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92319 - Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7584008

10:56 Changeset [92485] by thakis@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92316 - Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7582015

10:19 BuildingQtOnLinux edited by cavalcantii@gmail.com
Note about how to choose webkit2 as the build target. (diff)
10:13 Changeset [92484] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r92433): media/video-src-change.html fails
https://bugs.webkit.org/show_bug.cgi?id=65771

Reviewed by Dimitri Glazkov.

Give the listener as the second argument to removeEventListener.

  • media/video-src-change.html:
09:56 Changeset [92483] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

compositing/video/video-background-color.html test does not produce correct output
https://bugs.webkit.org/show_bug.cgi?id=55519

Unreviewed.

Chromium doesn't support video codecs that support alpha, so stop
running (and failing) a test that depends on codecs supporting alpha.

Patch by Ami Fischman <fischman@chromium.org> on 2011-08-05

  • platform/chromium/test_expectations.txt:
09:27 Changeset [92482] by senorblanco@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 92388 - Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700

Reviewed by James Robinson.

No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7582010

08:40 Changeset [92481] by ademar.reis@openbossa.org
  • 2 edits in trunk/Tools

Unreviewed build fix for Qt-Minimal buildbot

Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
is disabled.

Rubber-stamped by Holger Freyther.

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

08:08 BuildingQtOnLinux edited by cavalcantii@gmail.com
Adding a small remark about QT5 and QTDIR environment variable. (diff)
07:36 Changeset [92480] by yael.aharon@nokia.com
  • 6 edits
    6 adds in trunk

dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428

Reviewed by Darin Adler.

Source/WebCore:

Changed the directionality algorithm to evaluate the value of input elements and textarea elements when
they have the attribute dir-auto Set.
Also skip these elements when evaluating the directionality of their ancestors.

HTMLTextAreaElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

HTMLInputElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

Tests: fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html

fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality):

  • html/HTMLElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::subtreeHasChanged):

LayoutTests:

  • fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.
07:17 Changeset [92479] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-05
Reviewed by Andreas Kling.

Reverted commit r87797, http://trac.webkit.org/changeset/87797, because it
causes the regression reported under bug# 63582.

[Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.
https://bugs.webkit.org/show_bug.cgi?id=63582

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):

07:03 Changeset [92478] by ademar.reis@openbossa.org
  • 5 edits
    2 adds in trunk/Tools

[Qt] QtTestBrowser: Add support for saving cookies on disk
https://bugs.webkit.org/show_bug.cgi?id=65328

Simple cookiejar that saves cookies on disk.

Added menu options to clear cookies (Edit->Clear cookies) and
disable disk cookies (Settings->[ ]Save Cookies on Disk).

Option -no-disk-cookies is also available.

Reviewed by Andreas Kling.

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/cookiejar.cpp: Added.
  • QtTestBrowser/cookiejar.h: Added.
  • QtTestBrowser/launcherwindow.cpp:
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/main.cpp:
06:45 Changeset [92477] by keishi@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

  • WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and

ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE

  • WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::closeColorChooserIfClientIsInDocument): Close color chooser if element is in
document. Called when the page navigates away.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.

  • html/ColorInputType.h:
  • html/FileInputType.cpp:
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach): Calls InputType::detach

  • html/InputType.cpp:

(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.

  • html/InputType.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::openColorChooser): Added.
(WebCore::EmptyChromeClient::closeColorChooser): Added.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Added.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Close color chooser when
navigating away from the page.

  • page/Chrome.cpp:

(WebCore::Chrome::openColorChooser): Added. Opens the color chooser.
(WebCore::Chrome::closeColorChooser): Added. Tries to close the color chooser. Might not close if the
listener of the color chooser is another part of the browser or another render process.
(WebCore::Chrome::setSelectedColorInColorChooser): Added. Sets the selected color in the color chooser.
Again, might not be executed if the listener of the color chooser is another part of the browser or another render process.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Added.

(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::closeColorChooserIfClientIsInDocument): Close the color chooser if the client is
inside the document.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.

  • platform/ColorChooser.h: Added.

(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

06:16 Changeset [92476] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: check that detaching frame has been attached before removing it from the console selector
https://bugs.webkit.org/show_bug.cgi?id=65686

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameDetached):

05:18 Changeset [92475] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
04:39 Changeset [92474] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364

Unreviewed: unskipping tests now that the test was fixed.

  • platform/qt/Skipped:
03:16 Changeset [92473] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebKit/efl

[EFL] Move API documentation of ewk files to the headers
https://bugs.webkit.org/show_bug.cgi?id=65373

There are two arguments for this:

  1. Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
  2. It will be consistent with structures descriptions.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-05
Reviewed by Kent Tamura.

  • ewk/ewk_auth.cpp:
  • ewk/ewk_auth.h:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_history.cpp:
  • ewk/ewk_history.h:
  • ewk/ewk_main.cpp:
  • ewk/ewk_main.h:
  • ewk/ewk_network.cpp:
  • ewk/ewk_network.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
  • ewk/ewk_window_features.cpp:
  • ewk/ewk_window_features.h:
02:40 Changeset [92472] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip 2 crashy tests on Qt SnowLeopard Intel Release bot to make a green world,

  • platform/qt-mac/Skipped:
02:37 Changeset [92471] by yurys@chromium.org
  • 8 edits in trunk

Web Inspector: constrain maximum depth for returnByValue objects
https://bugs.webkit.org/show_bug.cgi?id=65761

Source/WebCore:

Set maximum depth to 20 for objects returned by value as a result of evaluations.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.cpp:

(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

  • inspector/InspectorValues.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
02:30 Changeset [92470] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Add http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
to Skiplist because it makes ARMv5 Linux Qt Release weepy.

  • platform/qt-arm/Skipped:
01:57 Changeset [92469] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from appcache IDL files
https://bugs.webkit.org/show_bug.cgi?id=65752

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • loader/appcache/DOMApplicationCache.idl:
01:42 Changeset [92468] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Stop using free-lists for database/object store/index ids.
https://bugs.webkit.org/show_bug.cgi?id=65678

Reviewed by Tony Chang.

Don't use free-lists for database/object store/index ids,
just assign increasing numbers.

It turns out that deleting an object store and creating a new one with
the same id would cause the delete markers from the old object store to
slow down lookups into the new one. Therefore we should generate
a new id every time. Running out of ids (64 bits for databases and
object stores, 32 bits for indices) is not realistic.

Also make functions that generate new ids report errors, and make the
callers of those functions check the return values.

We must still delete free-lists when deleting an object store, and we
must keep the code for encoding/decoding/comparison of free-list keys
since users might have them in their databases.

This is just a performance optimization, so no new tests.

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):

01:37 Changeset [92467] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Ossyize fast/forms/enter-clicks-buttons.html because
it makes Qt SnowLeopard Intel Release bot bleeding after r92375.

  • platform/qt-mac/Skipped:
01:33 Changeset [92466] by commit-queue@webkit.org
  • 48 edits in trunk/LayoutTests

[chromium] Rebaseline following r92255.
https://bugs.webkit.org/show_bug.cgi?id=65736

Patch by David Reveman <reveman@chromium.org> on 2011-08-05
Reviewed by James Robinson.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium/test_expectations.txt:
01:28 Changeset [92465] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
01:24 Changeset [92464] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
01:21 Changeset [92463] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: change an instance of isImportRule() that was overlooked in commit 92448.

No new tests. (No functional change)

  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::isImportRule):

01:19 Changeset [92462] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from remaining SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65751

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • svg/SVGElementInstance.idl:
00:51 Changeset [92461] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: do not delay scroll event handling - scroll is already async.
https://bugs.webkit.org/show_bug.cgi?id=65693

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-05
Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._syncScroll):

00:48 Changeset [92460] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
00:45 Changeset [92459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from web audio API
https://bugs.webkit.org/show_bug.cgi?id=65750

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • webaudio/AudioBufferSourceNode.idl:
00:43 Changeset [92458] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Web Workers
https://bugs.webkit.org/show_bug.cgi?id=65746

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
00:34 Changeset [92457] by bashi@chromium.org
  • 17 edits
    6 adds in trunk

Parsing CSS3 font-feature-settings property
https://bugs.webkit.org/show_bug.cgi?id=63618

Source/WebCore:

Introduces CSS3 font-feature-settings property as -webkit-font-feature-settings. This change only contains parsing part. Parsed information are stored in FontDescription class.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

Test: css3/font-feature-settings-parsing.html

  • CMakeLists.txt: Added FontFeatureValue.{h,cpp} and FontFeatureSettings.{h,cpp}.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added CSSPropertyWebkitFontFeatureSettings.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added parsing code for -webkit-font-feature-settings.
(WebCore::CSSParser::parseFontFeatureTag): Added.
(WebCore::CSSParser::parseFontFeatureSettings): Added.

  • css/CSSParser.h: Added parseFontFeatureSettings().
  • css/CSSPropertyNames.in: Added -webkit-font-feature-settings.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Modified a compile assert to follow adding -webkit-font-feature-settings.
(WebCore::CSSStyleSelector::applyProperty): Added a case clause for CSSPropertyWebkitFontFeatureSettings.

  • css/CSSValue.h:

(WebCore::CSSValue::isFontFeatureValue): Added.

  • css/CSSValueKeywords.in: Added 'on' and 'off' keywords.
  • css/FontFeatureValue.cpp: Added.

(WebCore::FontFeatureValue::FontFeatureValue):
(WebCore::FontFeatureValue::value):
(WebCore::FontFeatureValue::cssText):

  • css/FontFeatureValue.h: Added.

(WebCore::FontFeatureValue::create):
(WebCore::FontFeatureValue::tag):
(WebCore::FontFeatureValue::isFontFeatureValue):

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::makeNormalFeatureSettings): Added.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added m_featureSettings member variable.
(WebCore::FontDescription::featureSettings): Added.
(WebCore::FontDescription::setFeatureSettings): Added.
(WebCore::FontDescription::operator==): Modified to take into account m_featureSettings

  • platform/graphics/FontFeatureSettings.cpp: Added.

(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator=):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):

  • platform/graphics/FontFeatureSettings.h: Added.

(WebCore::FontFeature::tag):
(WebCore::FontFeature::value):
(WebCore::FontFeatureSettings::create):
(WebCore::FontFeatureSettings::append):
(WebCore::FontFeatureSettings::size):
(WebCore::FontFeatureSettings::operator[]):
(WebCore::FontFeatureSettings::at):

LayoutTests:

Add parsing test case for -webkit-font-feature-settings property.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

  • css3/font-feature-settings-parsing-expected.txt: Added.
  • css3/font-feature-settings-parsing.html: Added.
00:32 Changeset [92456] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from websockets
https://bugs.webkit.org/show_bug.cgi?id=65749

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • websockets/WebSocket.idl:
00:30 Changeset [92455] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to heal media/video-can-play-type.html and media/video-src-change.html.

  • html/HTMLMediaElement.idl:
00:18 Changeset [92454] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from notifications IDL files
https://bugs.webkit.org/show_bug.cgi?id=65747

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • notifications/Notification.idl:
  • notifications/NotificationCenter.idl:
00:00 Changeset [92453] by commit-queue@webkit.org
  • 4 edits
    4 deletes in trunk

Unreviewed, rolling out r92439.
http://trac.webkit.org/changeset/92439
https://bugs.webkit.org/show_bug.cgi?id=65753

Caused 9 tests to fail on Qt (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::implicitOpen):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

  • loader/document-destruction-within-unload-expected.txt: Removed.
  • loader/document-destruction-within-unload.html: Removed.
  • loader/resources/document-destruction-within-unload-iframe.html: Removed.
  • loader/resources/document-destruction-within-unload.svg: Removed.

08/04/11:

23:58 Changeset [92452] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update after r92341.

  • platform/chromium/test_expectations.txt:
23:26 Changeset [92451] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Use RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=65647

Reviewed by Hajime Morita.

Encapsulated the use of getInlineBoxAndOffset in Editor.cpp and AccessibilityObject.cpp by RenderedPosition.

Also added rendererFromPosition that returns the renderer of deprecatedNode but using a proper Position interface.

  • accessibility/AccessibilityObject.cpp:

(WebCore::updateAXLineStartForVisiblePosition):

  • editing/Editor.cpp:

(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::rendererFromPosition):
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::absoluteRect):

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):

23:14 Changeset [92450] by hayato@chromium.org
  • 8 edits in trunk/Source/WebCore

Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
https://bugs.webkit.org/show_bug.cgi?id=65613

Reviewed by Dimitri Glazkov.

No changes to functionality so no new tests.

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):

  • dom/EventDispatcher.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchScopedEventDispatchMediator):

  • dom/Node.h:
  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEventDispatchMediator):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):

  • dom/ScopedEventQueue.h:
23:05 Changeset [92449] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

23:04 Changeset [92448] by rolandsteiner@chromium.org
  • 12 edits in trunk/Source/WebCore

Improve const-correctness in CSS code: type information methods
https://bugs.webkit.org/show_bug.cgi?id=65506

Reviewed by Simon Fraser.

Make "is...()" functions (e.g., "isStyleRule()") const.
Also, change CSSRule's type() function to return CSSRuleType.

No new tests. (no change in semantics)

  • css/CSSCharsetRule.h:

(WebCore::CSSCharsetRule::isCharsetRule):
(WebCore::CSSCharsetRule::type):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::isFontFaceRule):
(WebCore::CSSFontFaceRule::type):

  • css/CSSImportRule.h:

(WebCore::CSSImportRule::isImportRule):
(WebCore::CSSImportRule::type):

  • css/CSSMediaRule.h:

(WebCore::CSSMediaRule::isMediaRule):
(WebCore::CSSMediaRule::type):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::isPageRule):
(WebCore::CSSPageRule::type):

  • css/CSSRule.h:

(WebCore::CSSRule::isRule):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::isStyleRule):
(WebCore::CSSStyleRule::type):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::type):

  • css/StyleBase.h:

(WebCore::StyleBase::isCharsetRule):
(WebCore::StyleBase::isFontFaceRule):
(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isKeyframeRule):
(WebCore::StyleBase::isKeyframesRule):
(WebCore::StyleBase::isMediaRule):
(WebCore::StyleBase::isPageRule):
(WebCore::StyleBase::isRule):
(WebCore::StyleBase::isStyleRule):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::isKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::type):

  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::isKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::type):

22:42 Changeset [92447] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from plugin IDL files
https://bugs.webkit.org/show_bug.cgi?id=65745

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
22:37 Changeset [92446] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
https://bugs.webkit.org/show_bug.cgi?id=65740

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • xml/DOMParser.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:
22:27 Changeset [92445] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04

  • DEPS:
21:51 Changeset [92444] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

Add a performance test for floating elements layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=65741

The test creating lots of small floats and randomly changes
the width of one element at a time. It measures how often it can do that.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-04
Reviewed by Adam Barth.

  • Layout/floats.html: Added.
20:50 Changeset [92443] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • html/canvas/CanvasGradient.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
20:26 Changeset [92442] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Tools

model.js needs some unit testing
https://bugs.webkit.org/show_bug.cgi?id=65730

Reviewed by Dimitri Glazkov.

These tests do not cover all the functions exported by the model
module. We'll need to add the remaining ones in the future.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
20:25 Changeset [92441] by morrita@google.com
  • 11 edits
    1 add in trunk/Source/WebCore

Reviewed by Ryosuke Niwa.

DocumentMarker: Type specific details should be separately held by other object.
https://bugs.webkit.org/show_bug.cgi?id=59855

  • Introduced DocumentMarkerDetails abstract class and two its subclasses DocumentMarkerDescription and DocumentMarkerActiveMatch,
  • Replacing DocumentMarker::m_description and DocumentMarker::m_activeMatch with these new details classes.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DocumentMarker.cpp: Added.

(WebCore::emptyDescription):
(WebCore::DocumentMarkerDetails::DocumentMarkerDetails):
(WebCore::DocumentMarkerDetails::~DocumentMarkerDetails):
(WebCore::DocumentMarkerDescription::description):
(WebCore::DocumentMarkerDescription::isDescription):
(WebCore::DocumentMarkerDescription::DocumentMarkerDescription):
(WebCore::DocumentMarkerDescription::createUnlessEmpty):
(WebCore::DocumentMarkerDescription::compatibleTypes):
(WebCore::DocumentMarkerTextMatch::activeMatch):
(WebCore::DocumentMarkerTextMatch::isTextMatch):
(WebCore::DocumentMarkerTextMatch::DocumentMarkerTextMatch):
(WebCore::DocumentMarkerTextMatch::instanceFor):
(WebCore::DocumentMarkerTextMatch::compatibleTypes):
(WebCore::DocumentMarker::DocumentMarker):
(WebCore::DocumentMarker::shiftOffsets):
(WebCore::DocumentMarker::setActiveMatch):
(WebCore::DocumentMarker::description):
(WebCore::DocumentMarker::activeMatch):

  • dom/DocumentMarker.h:

(WebCore::DocumentMarker::details):
(WebCore::DocumentMarker::clearDetails):
(WebCore::DocumentMarkerDetails::isDescription):
(WebCore::DocumentMarkerDetails::isTextMatch):
(WebCore::DocumentMarkerDetails::isAllowedFor):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

18:45 Changeset [92440] by abarth@webkit.org
  • 2 edits in trunk/Tools

Another speculative fix for the "svn revision on Windows" problem.

  • Scripts/webkitpy/common/checkout/scm/git.py:
18:32 Changeset [92439] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Bad interaction between document destruction and unload events
https://bugs.webkit.org/show_bug.cgi?id=64741

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

Source/WebCore:

Three different errors triggered by this test case. The case to
consider is a subdocument with an onunload on an element, that
destroys the parent document during the onunload. One fix was a
lifetime issue fixed by a protecting RefPtr, and another was an
additional cancel of event triggers. The main fix was that during the
transition to commited state, the documentLoader is being replaced by
the provisionalDocumentLoader. But, because during firing events in
the subdocument the parent is destroyed, that subevent caused the
provisionalDocumentLoader to be detached from its frame. By marking
the page as being in committed state before the parent documentLoader
is set, this is avoided.

Test: loader/document-destruction-within-unload.html

  • dom/Document.cpp:

(WebCore::Document::implicitOpen):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

  • loader/document-destruction-within-unload-expected.txt: Added.
  • loader/document-destruction-within-unload.html: Added.
  • loader/resources/document-destruction-within-unload-iframe.html: Added.
  • loader/resources/document-destruction-within-unload.svg: Added.
18:07 Changeset [92438] by simon.fraser@apple.com
  • 24 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <simon.fraser@apple.com>

Add code to determine whether a Range in inside fixed position content
https://bugs.webkit.org/show_bug.cgi?id=65720

Reviewed by Sam Weinig.

Propagate the 'wasFixed' flag out from various methods that
are used when computing the collection of rects or quads
for a range. Use the flag in Range to computer whether
the Range is entirely within, partially within, or outside
of fixed-position content.

  • WebCore.exp.in:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect):
  • dom/Range.cpp: (WebCore::Range::textRects): (WebCore::Range::textQuads):
  • dom/Range.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteQuads):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteQuads):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteQuads):
  • rendering/RenderInline.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteQuads):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuads): (WebCore::RenderText::absoluteQuadsForRange):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteQuads):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteQuads):
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteQuads):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteQuads):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteQuads):
  • rendering/svg/RenderSVGText.h:
17:51 Changeset [92437] by levin@chromium.org
  • 4 edits in trunk/Source

CStringBuffer should have thread safety checks turned on.
https://bugs.webkit.org/show_bug.cgi?id=58093

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

  • wtf/text/CString.h:

(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
turned this off for Chromium.

Source/WebKit/chromium:

  • DEPS: Roll far enough to pick up the latest WebKit::initialize

fix for Linux.

17:39 Changeset [92436] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65717

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • dom/Document.idl:
17:26 Changeset [92435] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <simon.fraser@apple.com>

Fix release build failure with last commit.

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
17:19 Changeset [92434] by simon.fraser@apple.com
  • 21 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <simon.fraser@apple.com>

Add code to determine whether a Range in inside fixed position content
https://bugs.webkit.org/show_bug.cgi?id=65720

Reviewed by Dan Bernstein.

Add an out param for various coordinate mapping functions
that tells us whether the point or rectangle being
mapped is inside fixed-position content.

This brings back some of the changes from r89754.

No behavior changes, so no tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad):
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
  • rendering/svg/SVGRenderSupport.h:
17:03 Changeset [92433] by commit-queue@webkit.org
  • 25 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65715

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItems.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/MediaStream.idl:
  • dom/MediaStreamList.idl:
  • dom/MediaStreamTrackList.idl:
  • dom/MessagePort.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/Range.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/StringCallback.idl:
  • dom/Text.idl:
  • dom/TouchList.idl:
16:58 Changeset [92432] by mrowe@apple.com
  • 45 edits in trunk

Future-proof Xcode configuration settings.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKit2.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
16:56 Changeset [92431] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

A few purely stylistic modifications to visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=65723

Patch by Van Lam <vanlam@google.com> on 2011-08-04
Reviewed by Ryosuke Niwa.

Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox
to positionIsInBoxButNotOnBoundary (to avoid confusion with
positionIsInBox, which is just a getInlineBoxAndOffset check).
Removed use of invalidOffset as an error value in greatestOffsetUnder
and smallestOffsetAbove since semantically it should only be used to
check if it makes sense to compare offsets in a single box.

  • editing/visible_units.cpp:

(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):
(WebCore::positionIsInBoxButNotOnBoundary):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):

16:46 Changeset [92430] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:
16:25 Changeset [92429] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fancier debug logging.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
16:20 Changeset [92428] by mitz@apple.com
  • 2 edits in trunk/Websites/webkit.org

Fixed a typo.

  • coding/contributing.html:
16:17 Changeset [92427] by tkent@chromium.org
  • 15 edits
    7 copies
    6 moves
    8 adds
    3 deletes in trunk/LayoutTests

Move <input type=week> tests to fast/forms/week/
https://bugs.webkit.org/show_bug.cgi?id=65676

Reviewed by Tony Chang.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-week-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-week.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt:
  • fast/forms/date-input-visible-strings.html:
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/input-type-change3-expected.txt:
  • fast/forms/input-valueasdate-week-expected.txt: Removed.
  • fast/forms/input-valueasdate-week.html: Removed.
  • fast/forms/input-valueasnumber-week-expected.txt: Removed.
  • fast/forms/input-valueasnumber-week.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/input-type-change3.js:
  • fast/forms/script-tests/input-valueasdate-week.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-week.js: Removed.
  • fast/forms/week: Added.
  • fast/forms/week/ValidityState-rangeOverflow-week-expected.txt: Added.
  • fast/forms/week/ValidityState-rangeOverflow-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt: Added.
  • fast/forms/week/ValidityState-rangeUnderflow-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/week/ValidityState-stepMismatch-week-expected.txt: Added.
  • fast/forms/week/ValidityState-stepMismatch-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/week/ValidityState-typeMismatch-week-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-week-expected.txt.
  • fast/forms/week/ValidityState-typeMismatch-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-week.js.
  • fast/forms/week/input-valueasdate-week-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-week-expected.txt.
  • fast/forms/week/input-valueasdate-week.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-week.js.
  • fast/forms/week/input-valueasnumber-week-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-week-expected.txt.
  • fast/forms/week/input-valueasnumber-week.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-week.js.
  • fast/forms/week/week-input-type-expected.txt: Added.
  • fast/forms/week/week-input-type.html: Copied from LayoutTests/fast/forms/script-tests/input-type-change3.js.
  • fast/forms/week/week-input-visible-string-expected.txt: Added.
  • fast/forms/week/week-input-visible-string.html: Copied from LayoutTests/fast/forms/date-input-visible-strings.html.
  • fast/forms/week/week-stepup-stepdown-expected.txt: Added.
  • fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/week/week-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/week/week-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
15:54 Changeset [92426] by timothy_horton@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Move Tim Horton to committers section of committers.py

No review necessary.

15:53 Changeset [92425] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Reduce memory consumption of HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=65688

Adds a cache for HB_FaceRec to eliminate multiple allocation for the same font.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-04
Reviewed by Tony Chang.

No new tests since there is no behavior change.

  • platform/graphics/chromium/HarfbuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace): Added.
(WebCore::releaseCachedHarfbuzzFace): Ditto.
(WebCore::HarfbuzzFace::HarfbuzzFace): Calls getCachedHarfbuzzFace() instead of allocating HB_FaceRec.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Calls releaseCachedHarfbuzzFace() to release the onership of the cache.

  • platform/graphics/chromium/HarfbuzzSkia.h:
15:51 Changeset [92424] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r92415.
http://trac.webkit.org/changeset/92415
https://bugs.webkit.org/show_bug.cgi?id=65728

Causes many DEBUG crashes (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-04

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
15:46 Changeset [92423] by timothy_horton@apple.com
  • 39 edits in trunk

Reviewed by Nikolas Zimmermann.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
<rdar://problem/9727074>

Make use of SVGLength::construct when parsing Length attributes; we will
now propagate errors which occur while parsing SVGLength attributes to the
Web Inspector console.

15:42 Changeset [92422] by commit-queue@webkit.org
  • 39 edits in trunk

Unreviewed, rolling out r92419.
http://trac.webkit.org/changeset/92419
https://bugs.webkit.org/show_bug.cgi?id=65726

"committed partially to branch" (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-04

Source/WebCore:

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::parseMappedAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::parseMappedAttribute):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::parseMappedAttribute):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::parseMappedAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::parseMappedAttribute):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::parseMappedAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseMappedAttribute):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::parseMappedAttribute):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::parseMappedAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::parseMappedAttribute):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::parseMappedAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseMappedAttribute):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::parseMappedAttribute):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::parseMappedAttribute):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseMappedAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseMappedAttribute):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::parseMappedAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::parseMappedAttribute):

LayoutTests:

  • platform/chromium-win/svg/hixie/error/013-expected.txt:
  • platform/gtk/svg/hixie/error/001-expected.txt:
  • platform/gtk/svg/hixie/error/007-expected.txt:
  • platform/gtk/svg/hixie/error/013-expected.txt:
  • platform/gtk/svg/hixie/error/015-expected.txt:
  • platform/mac/svg/hixie/error/001-expected.txt:
  • platform/mac/svg/hixie/error/007-expected.txt:
  • platform/mac/svg/hixie/error/013-expected.txt:
  • platform/mac/svg/hixie/error/015-expected.txt:
  • platform/qt/svg/hixie/error/001-expected.txt:
  • platform/qt/svg/hixie/error/007-expected.txt:
  • platform/qt/svg/hixie/error/013-expected.txt:
  • platform/qt/svg/hixie/error/015-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/svg-parse-overflow-1-expected.txt:
  • svg/custom/svg-parse-overflow-2-expected.txt:
  • svg/custom/svg-parse-overflow-3-expected.txt:
  • svg/custom/svg-parse-overflow-4-expected.txt:
  • svg/custom/svg-parse-overflow-5-expected.txt:
15:41 Changeset [92421] by thakis@chromium.org
  • 2 edits in trunk/Websites/webkit.org

Update the contributors page to recommend webkit-patch instead of many manual steps
https://bugs.webkit.org/show_bug.cgi?id=65714

Reviewed by Adam Barth.

asvitkine followed the contributing instructions for his first patch, and got
the ChangeLog entry wrong: https://bugs.webkit.org/show_bug.cgi?id=65707
webkit-patch prevents errors like this and more.

  • coding/contributing.html:
15:39 Changeset [92420] by levin@chromium.org
  • 2 edits in trunk/Tools

[chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
https://bugs.webkit.org/show_bug.cgi?id=65685

Reviewed by Dmitry Titov.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost): Intialize WTF threading before
anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
but in some cases code may use WTF without creating WebViewImpl and
WTF code functionality may call WTF::currentThread, which requires
this initialization now.

15:15 Changeset [92419] by timothy_horton@apple.com
  • 39 edits in /

Reviewed by Nikolas Zimmermann.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
<rdar://problem/9727074>

Make use of SVGLength::construct when parsing Length attributes; we will
now propagate errors which occur while parsing SVGLength attributes to the
Web Inspector console.

15:03 Changeset [92418] by abarth@webkit.org
  • 3 edits in trunk/Tools

An educated guess at causing the Windows bots on build.webkit.org to
find the SVN revision number.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
15:00 Changeset [92417] by fsamuel@chromium.org
  • 5 edits
    3 adds in trunk

Source/WebCore: Background Does Not Scale Correctly with Page
https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

Test: fast/repaint/background-scaling.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):

  • rendering/RenderView.h:

LayoutTests: Background Does Not Scale Correctly with Page

Scaling is applied twice to the background (the paint area is doubly scaled).
This patch fixes this issue by passing the unscaled document rect to paintFillLayers
in paintRootBoxFillLayers.

https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

  • fast/repaint/background-scaling-expected.png: Added.
  • fast/repaint/background-scaling-expected.txt: Added.
  • fast/repaint/background-scaling.html: Added.
14:50 Changeset [92416] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed.

Skipping tests until rebaseline.

  • platform/qt/Skipped:
14:50 Changeset [92415] by jochen@chromium.org
  • 5 edits in trunk/Source

Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
14:40 Changeset [92414] by jeffm@apple.com
  • 6 edits in trunk/Source/WebKit/win

Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718

Reviewed by Adam Roben.

  • Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
  • WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.

  • WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.

14:37 Changeset [92413] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Fix integer overflow in custom bindings for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=65646

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-08-04
Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/uniform-array-length-overflow.html

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toVector): Don't crash if allocation fails.

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

LayoutTests:

  • fast/canvas/webgl/resources/floatArrayUniformShader.vert: Added.
  • fast/canvas/webgl/resources/intArrayUniformShader2.vert: Added.
  • fast/canvas/webgl/uniform-array-length-overflow-expected.txt: Added.
  • fast/canvas/webgl/uniform-array-length-overflow.html: Added.
14:29 Changeset [92412] by lforschler@apple.com
  • 4 edits in tags/Safari-534.49.1/Source

Merge r90705.

14:13 Changeset [92411] by lforschler@apple.com
  • 2 edits in tags/Safari-534.49.1/Source/WebCore

Merge r89214.

14:12 Changeset [92410] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Implement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=65704
<rdar://problem/9877734>

Reviewed by Oliver Hunt.

Implement support for client side certificate authentication in the CFNetwork based loader.

  • platform/network/cf/AuthenticationCF.cpp:

(WebCore::createCF):
(WebCore::core): Also fix leak of password string.

14:11 Changeset [92409] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Refine some test expectations to account for flakiness.

  • platform/chromium/test_expectations.txt:
14:07 Changeset [92408] by crogers@google.com
  • 6 edits in trunk/Source/WebCore

Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize):

13:38 Changeset [92407] by abarth@webkit.org
  • 2 edits in trunk/Tools

More logging to help debug the "no SVN rev on Chromium Windows bots"
bug. My current theory is that we're trying to detect the SCM system
in the wrong directory.

  • Scripts/webkitpy/layout_tests/port/base.py:
13:14 Changeset [92406] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_bug.cgi?id=65712
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.

Reviewed by Darin Adler.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a

whole bunch of stuff that might need to check it.

13:09 Changeset [92405] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Make fast/css/import-and-insert-rule-no-update.html less flaky
https://bugs.webkit.org/show_bug.cgi?id=65713

Reviewed by Dan Bernstein.

Wait until the @imported style sheet has finished loading before running the test.

  • fast/css/import-and-insert-rule-no-update.html:
13:06 Changeset [92404] by jeffm@apple.com
  • 8 edits in trunk/Source/WebCore

Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9894105>

First cut at implementation in MediaPlayerPrivateAVFoundationCF.cpp/.h, based on
work by Eric Carlson. Note that use of AVFoundation is determined at runtime, and
defaults to off.

Reviewed by Darin Adler.

No new tests, uses existing media tests.

  • config.h: Turn on WTF_USE_AVFOUNDATION on Windows if AVFoundationCF is available.


  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationCF on Windows.

  • platform/graphics/MediaPlayer.h: Add support for an AVCFPlayer.


  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Workaround an AVCF limitation that prevents an AVCFPlayer from being created without an AVCFItem.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Added support for ContentsNeedsDisplay notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::contentsNeedsDisplay): Added support for ContentsNeedsDisplay notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added implementation.

(WebCore::AVFWrapper::caVideoLayer):
(WebCore::AVFWrapper::videoLayerWrapper):
(WebCore::AVFWrapper::videoLayer):
(WebCore::AVFWrapper::avPlayer):
(WebCore::AVFWrapper::avAsset):
(WebCore::AVFWrapper::avPlayerItem):
(WebCore::AVFWrapper::timeObserver):
(WebCore::AVFWrapper::imageGenerator):
(WebCore::AVFWrapper::dispatchQueue):
(WebCore::LayerClient::LayerClient):
(WebCore::LayerClient::~LayerClient):
(WebCore::LayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::LayerClient::platformCALayerAnimationStarted):
(WebCore::LayerClient::platformCALayerContentsOrientation):
(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerShowDebugBorders):
(WebCore::LayerClient::platformCALayerShowRepaintCounter):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
(WebCore::LayerClient::platformCALayerContentsOpaque):
(WebCore::LayerClient::platformCALayerDrawsContent):
(WebCore::LayerClient::platformCALayerLayerDidDisplay):
(WebCore::boolString):
(WebCore::metadataKeyNames):
(WebCore::CMTimeRangeStartKey):
(WebCore::CMTimeRangeDurationKey):
(WebCore::CACFContextNeedsFlushNotification):
(WebCore::videoLayer):
(WebCore::avPlayer):
(WebCore::avAsset):
(WebCore::avPlayerItem):
(WebCore::imageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationCF::create):
(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationCF::MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::~MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationCF::checkPlayability):
(WebCore::MediaPlayerPrivateAVFoundationCF::beginLoadingMetadata):
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMedia):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationCF::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::setVolume):
(WebCore::MediaPlayerPrivateAVFoundationCF::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::rate):
(WebCore::timeRangeIsValidAndNotEmpty):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationCF::paint):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes):
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationCF::mediaTimeForTimeValue):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::contentsNeedsDisplay):
(WebCore::AVFWrapper::AVFWrapper):
(WebCore::AVFWrapper::~AVFWrapper):
(WebCore::AVFWrapper::scheduleDisconnectAndDelete):
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper):
(WebCore::AVFWrapper::deleteAVFWrapper):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::periodicTimeObserverCallback):
(WebCore::AVFWrapper::notificationCallback):
(WebCore::AVFWrapper::loadPlayableCompletionCallback):
(WebCore::AVFWrapper::checkPlayability):
(WebCore::AVFWrapper::loadMetadataCompletionCallback):
(WebCore::AVFWrapper::beginLoadingMetadata):
(WebCore::AVFWrapper::seekCompletedCallback):
(WebCore::AVFWrapper::seekToTime):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::destroyVideoLayer):
(WebCore::AVFWrapper::setVideoLayerNeedsCommit):
(WebCore::AVFWrapper::setVideoLayerHidden):
(WebCore::AVFWrapper::createImageGenerator):
(WebCore::AVFWrapper::destroyImageGenerator):
(WebCore::AVFWrapper::createImageForTimeInRect):
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added implementation.
13:04 Changeset [92403] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

Speed up webkit-patch optimize-expectations significantly by not collecting test files.
https://bugs.webkit.org/show_bug.cgi?id=65697

I neglected to realize that collecting test names is not necessary for this operation.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
12:42 Changeset [92402] by lforschler@apple.com
  • 6 edits in tags/Safari-534.49.1/Source

Merge r92231.

12:35 Changeset [92401] by lforschler@apple.com
  • 5 edits in tags/Safari-534.49.1/Source

Versioning.

12:33 Changeset [92400] by lforschler@apple.com
  • 1 copy in tags/Safari-534.49.1

New tag.

12:23 Changeset [92399] by jochen@chromium.org
  • 15 edits in trunk/Source

Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=48483

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/chromium/ResourceRequest.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

  • platform/network/chromium/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::targetType):
(WebCore::ResourceRequest::setTargetType):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:

(WebCore::WorkerScriptLoader::create):
(WebCore::WorkerScriptLoader::setTargetType):

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):

12:21 Changeset [92398] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCE build after r92308.

  • config.h: Don't try to include WebCoreHeaderDetection.h for WinCE.
12:20 Changeset [92397] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add more failing tests to the skipped list.

  • platform/mac-lion/Skipped:
12:19 Changeset [92396] by abarth@webkit.org
  • 3 edits in trunk/Tools

checkout_unittest.js should have better coverage of checkout.js
https://bugs.webkit.org/show_bug.cgi?id=65671

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
    • Remove unused functions.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
    • Test remaining public functions in the checkout module.
12:11 Changeset [92395] by lforschler@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:09 Changeset [92394] by lforschler@apple.com
  • 1 copy in tags/Safari-534.51.6

New tag.

11:50 Maintenance and architecture list edited by tony@gonk.net
Tweaked formatting. (diff)
11:40 Memory Use edited by tony@gonk.net
Added formatting for readability. Tweaked a few words and phrases. (diff)
11:26 Changeset [92393] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter can potentially GC in the middle of initializing a structure chain
https://bugs.webkit.org/show_bug.cgi?id=65638

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-04
Reviewed by Oliver Hunt.

Moved the allocation of a prototype StructureChain before the initialization of
the structure chain within the interpreter that was causing intermittent GC crashes.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::tryCachePutByID):

  • wtf/Platform.h:
11:19 Changeset [92392] by darin@chromium.org
  • 2 edits in trunk/Source/WebCore

webkitRequestAnimationFrame's element argument needs to be marked optional
https://bugs.webkit.org/show_bug.cgi?id=65698

Reviewed by James Robinson.

  • page/DOMWindow.idl:
11:17 Changeset [92391] by dslomov@google.com
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=65706
Run run-unit-tests on release mode test bots.
Reenabling after 61812 is fixed.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:11 Changeset [92390] by aroben@apple.com
  • 3 edits
    8 deletes in trunk/Source/WebCore

Delete some unused code from platform/graphics/win

MediaPlayerPrivateQuickTimeWin has been unused since r72117, and the GraphicsLayer-related
classes have been unused since r75262.

Fixes <http://webkit.org/b/65689> platform/graphics/win has a bunch of unused code

Reviewed by Eric Carlson.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:

Removed now-deleted files.

  • platform/graphics/win/GraphicsLayerCACF.cpp: Removed.
  • platform/graphics/win/GraphicsLayerCACF.h: Removed.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: Removed.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Removed.
  • platform/graphics/win/WebLayer.cpp: Removed.
  • platform/graphics/win/WebLayer.h: Removed.
  • platform/graphics/win/WebTiledLayer.cpp: Removed.
  • platform/graphics/win/WebTiledLayer.h: Removed.
11:11 Changeset [92389] by aroben@apple.com
  • 3 edits
    2 adds in trunk

Detect and handle overflow in PlatformCALayerWinInternal::constrainedSize

Google Maps sometimes requests very large (i.e., 250 pixels or greater) layers when
zooming. PlatformCALayerWinInternal has code to limit tiled layers to 2
27 pixels, but it
was not correctly handling overflow. In some cases, this would lead to creating a tiled
layer with 0 tiles, which was the cause of this crash.

Fixes <http://webkit.org/b/65637> <rdar://problem/9784849> Crash beneath
PlatformCALayerWinInternal::updateTiles when zooming on Google Maps

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::constrainedSize): Check for overflow before seeing if the
number of required tiles is larger than the maximum number of allowed tiles.
(PlatformCALayerWinInternal::updateTiles): Added an assertion to catch cases where we have a
non-empty tiled layer that contains 0 tiles, which would cause the crash in this bug report.

LayoutTests:

Test that a 225x225 pixel layer doesn't cause a crash

  • compositing/tiling/crash-huge-layer-expected.txt: Added.
  • compositing/tiling/crash-huge-layer.html: Added.
11:00 Changeset [92388] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700

Reviewed by James Robinson.

No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

10:52 Changeset [92387] by dslomov@google.com
  • 2 edits in trunk/Source/ThirdParty

https://bugs.webkit.org/show_bug.cgi?id=61812
TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc

Disable fast malloc for offending class (::std::strstream) in gtest.
This looks like the most non-intrusive solution.

Reviewed by David Levin.

10:48 Changeset [92386] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Eval handling attempts literal parsing even when the eval
string is in the cache
https://bugs.webkit.org/show_bug.cgi?id=65675

Reviewed by Oliver Hunt.

This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
in SunSpider. It's neutral on V8.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

10:48 Changeset [92385] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark gain.html as flaky on Linux chromium.

  • platform/chromium/test_expectations.txt:
10:45 Changeset [92384] by bweinstein@apple.com
  • 20 edits in trunk/Source

Source/WebCore: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Expose some methods on InspectorFrontendClient through the InspectorController so WebKit2
can request the inspector be docked, or ask whether or not it can be docked.

  • WebCore.exp.in: Export needed methods.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::requestAttachWindow): Call through to InspectorFrontendClient.
(WebCore::InspectorController::canAttachWindow): Ditto.

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Add a stub method for Chromium.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canAttachWindow):

  • src/InspectorFrontendClientImpl.h:

Source/WebKit2: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

When opening the inspector, the web process tells the UI process that the inspector page has loaded,
but now will pass another bit of data, whether the inspector can start attached, so the UI process
doesn't need to ask the web process to do another calculation on whether or not it can be attached.

If the user prefers the inspector to start docked (this defaults to true), and there is room for the
window, we send a message to the web process to try and attach the inspector. This makes sure that the
inspector knows it is docked (in the web process).

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach): Update the user's docked/undocked preference if the inspector is visible

when it was attached.

(WebKit::WebInspectorProxy::detach): Ditto (but when it was detached).
(WebKit::WebInspectorProxy::didLoadInspectorPage): If we can start docked, and the user prefers to start docked,

then request the inspector be attached to the window.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Only show the window if we are going to start undocked.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen): Ditto.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didLoadInspectorPage): Pass whether or not we can attach the window.
(WebKit::WebInspector::requestAttachWindow): Call through to the InspectorController to attach the inspector.
(WebKit::WebInspector::canAttachWindow): Ask the InspectorController if we can attach the inspector.

  • WebProcess/WebPage/WebInspector.h:
  • Shared/WebPreferencesStore.h: Add a new preference for whether or not the inspector should

start attached.

  • UIProcess/WebInspectorProxy.messages.in: When the inspector page is loaded, tell the UI Process whether

we can attach the inspector without needing another message.

  • WebProcess/WebPage/WebInspector.messages.in: Add a new message for RequestAttachWindow
10:25 Changeset [92383] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702.

  • platform/gtk/Skipped:
09:51 Changeset [92382] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

builders.js needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=65670

Reviewed by Dimitri Glazkov.

This test requires somewhat large test fixtures, but using real
examples seemed better than trimming them down too much.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
    • Note: trac_unittests.js doesn't exist (yet!).
09:41 Changeset [92381] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip some svg tests on GTK, likely affected by bug 39022.

  • platform/gtk/Skipped:
09:33 Changeset [92380] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and test_expectations update (2 tests
now passing).

  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/test_expectations.txt:
09:22 Changeset [92379] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Normalize test_expectations.txt file.

  • platform/chromium/test_expectations.txt: Ran webkit-path optimize-expectations.
09:10 Changeset [92378] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65665

Reviewed by Simon Fraser.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBorderFit.
(WebCore::CSSPrimitiveValue::operator EBorderFit):
Support cast to EBorderFit.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use new cast to allow use of appropriate macro.

09:09 Changeset [92377] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=65687

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
08:41 Changeset [92376] by jocelyn.turcotte@nokia.com
  • 11 edits
    1 copy
    3 adds in trunk/Source/WebKit2

[Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using imperative painting.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

Converts QTouchWebPage from QSGPaintedItem to a straight QSGItem.

  • A SGTileNode is created and added to the scene graph for each tile, positioning them relatively to the page. It's basically a QSGSimpleTextureNode with support for specifying a source rect plus for owning the QSGTexture for proper destruction on shutdown by the rendering thread.
  • Scale nodes are used as parent of tile nodes to revert the scaling set on the QTouchWebPage and allow us to keep using integer coordinates.
  • The SGAgent class is introduced to carry scene graph update request up to the updatePaintNode call of the item, which may be on the scene graph rendering thread.
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::updatePaintNode):
Delegate scene graph updates to the SGAgent which received update requests from the tiled drawing area.
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

Manage the scale node in the TileSet, it will be the parent node of Tile nodes.
(WebKit::TiledDrawingAreaTileSet::sgNodeID):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::~TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):

  • UIProcess/TiledDrawingAreaTile.h:

(WebKit::TiledDrawingAreaTile::create):

  • UIProcess/qt/SGAgent.cpp: Added.
  • UIProcess/qt/SGAgent.h: Added.
  • UIProcess/qt/SGTileNode.cpp: Added.
  • UIProcess/qt/SGTileNode.h: Added.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

Disable the paint call and update the scene graph on incorporateUpdate through the SGAgent.
(WebKit::TiledDrawingAreaProxy::updateWebView):

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:

(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::isReadyToPaint):
(WebKit::TiledDrawingAreaTile::swapBackBufferToFront):
(WebKit::TiledDrawingAreaTile::paint):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::setParentNodeID):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::sceneGraphAgent):
(WebKit::TouchViewInterface::setViewNeedsDisplay):

  • UIProcess/qt/TouchViewInterface.h:
  • WebKit2.pro:
08:22 Changeset [92375] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Use -webkit-locale for font selection.
https://bugs.webkit.org/show_bug.cgi?id=10874

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-04
Reviewed by Dan Bernstein.

Infer a script from -webkit-locale to use to choose a font for generic
font families and the default unstyled font. The font is retrieved
from per-script font settings (see bug 20797). Since these settings
have not changed there should be no visible effect yet.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontSelector.cpp: Use script when getting font from Settings

(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSPropertyNames.in: Increase priority of -webkit-locale since it affects font
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty): Set script in font based on -webkit-locale

  • page/Settings.cpp:

(WebCore::getGenericFontFamilyForScript): Fallback to USCRIPT_COMMON

  • platform/graphics/FontDescription.h: Add m_script

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::script):
(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):

  • platform/text/LocaleToScriptMapping.h: Added.
  • platform/text/LocaleToScriptMappingDefault.cpp: Added.

(WebCore::localeToScriptCodeForFontSelection):
(WebCore::LocaleScript::if):
(WebCore::LocaleScript::while):

  • platform/text/LocaleToScriptMappingICU.cpp: Added.

(WebCore::scriptCodeForFontSelection):
(WebCore::localeToScriptCodeForFontSelection):

08:04 Changeset [92374] by philn@webkit.org
  • 1 edit
    93 adds in trunk/LayoutTests

Unreviewed, GTK new baselines for new tests.

  • platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
  • platform/gtk/fast/blockflow/broken-ideographic-font-expected.png: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/gtk/fast/css/color-leakage-expected.png: Added.
  • platform/gtk/fast/css/color-leakage-expected.txt: Added.
  • platform/gtk/fast/css/font-family-pictograph-expected.png: Added.
  • platform/gtk/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/gtk/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Added.
  • platform/gtk/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/gtk/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-shadow-expected.png: Added.
  • platform/gtk/svg/custom/repaint-shadow-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/gtk/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/gtk/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
07:57 Changeset [92373] by alexis.menard@openbossa.org
  • 15 edits
    2 adds in trunk

[Qt] Make navigation actions properly usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65624

Source/WebKit2:

Add a new class that is exposed in QML to control the navigation
like reload/stop/back/forward. Enums are not very QML friendly,
it not possible to use enums that are not declared in the same class
than the object exposed in QML, therefore it makes hard the sharing
between the desktop and the touch views. In addition namespaced enums are
even harder to support in QML. QWebNavigationController is
not really meant to be used in C++ but it is exported for convenience
reason (tests and MiniBrowser) so its API is not meant to be public but
exposed in QML through properties and convenience slots. The QML code to use
the navigation action in QML will look like "desktopView.navigation.reload();"
or "if (desktopView.navigation.reloadAction.enabled) ...".

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/WKView.h: To get the forward header generated
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebView::navigationController):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::navigationController):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qwebnavigationcontroller.cpp: Added.

(QWebNavigationControllerPrivate::QWebNavigationControllerPrivate):
(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::~QWebNavigationController):
(QWebNavigationController::backAction):
(QWebNavigationController::forwardAction):
(QWebNavigationController::stopAction):
(QWebNavigationController::reloadAction):
(QWebNavigationController::navigationAction):
(QWebNavigationController::back):
(QWebNavigationController::forward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):

  • UIProcess/API/qt/qwebnavigationcontroller.h: Added.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::triggerNavigationAction):

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationActionsStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationActionsStatusAtStartup):

  • WebKit2API.pri:

Tools:

Fix compilation after the introduction of QWebNavigationController.

Reviewed by Benjamin Poulain.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::navigationAction):

07:39 Changeset [92372] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Pretty print JSONP in network panel preview tab.
https://bugs.webkit.org/show_bug.cgi?id=65559

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-preview-json.html

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ParsedJSON):

  • inspector/front-end/ResourcePreviewView.js:

(WebInspector.ResourcePreviewView.prototype._createPreviewView):

LayoutTests:

  • http/tests/inspector/network/network-preview-json-expected.txt: Added.
  • http/tests/inspector/network/network-preview-json.html: Added.
06:54 Changeset [92371] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
https://bugs.webkit.org/show_bug.cgi?id=65684

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
  • inspector/debugger/debugger-set-breakpoint-regex.html:
06:42 Changeset [92370] by philn@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] fullscreen/video-controls-override.html fails
https://bugs.webkit.org/show_bug.cgi?id=65618

Reviewed by Martin Robinson.

Implement extraFullScreenStyleSheet() and provide the QuickTime
stylesheet for now, later we might want our own stylesheet.

  • GNUmakefile.am:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::extraFullScreenStyleSheet):
  • platform/gtk/RenderThemeGtk.h:
06:07 Changeset [92369] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
https://bugs.webkit.org/show_bug.cgi?id=65682

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

():

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.setScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.registerAnchor):
(WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set _debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.sourceLine):

  • inspector/front-end/EventListenersSidebarPane.js:

(.):
():

  • inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._concatenateScriptsContent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/source-file.html:
05:43 Changeset [92368] by philn@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt:
  • platform/gtk/fast/dom/Range/getClientRects-expected.txt:
  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
04:24 Changeset [92367] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Unreviewed chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
04:04 Changeset [92366] by vsevik@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Merge 91829 - Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

TBR=mnaganov@chromium.org
BUG=91535
Review URL: http://codereview.chromium.org/7575008

03:07 Changeset [92365] by commit-queue@webkit.org
  • 16 edits
    3 moves in trunk/Source/WebCore

MediaStream API: Rename StreamEvent to MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=65669

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-04
Reviewed by Tony Gentilcore.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp:

(WebCore::Event::isMediaStreamEvent):

  • dom/Event.h:
  • p2p/MediaStreamEvent.cpp: Renamed from Source/WebCore/dom/StreamEvent.cpp.

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
(WebCore::MediaStreamEvent::~MediaStreamEvent):
(WebCore::MediaStreamEvent::initMediaStreamEvent):
(WebCore::MediaStreamEvent::stream):

  • p2p/MediaStreamEvent.h: Renamed from Source/WebCore/dom/StreamEvent.h.

(WebCore::MediaStreamEvent::isMediaStreamEvent):

  • p2p/MediaStreamEvent.idl: Renamed from Source/WebCore/dom/StreamEvent.idl.
  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::dispatchStreamEvent):

02:32 Changeset [92364] by hans@chromium.org
  • 6 edits
    2 adds in trunk

IndexedDB: Fix index data invalidation bugs.
https://bugs.webkit.org/show_bug.cgi?id=65547

Reviewed by Tony Chang.

Source/WebCore:

The function that checks whether a key exists in an index failed
to check whether that key was still valid or not.

Deleting a record from an object store must also delete its exists
entry, thus invalidating index keys pointing to that record.

Test: storage/indexeddb/index-unique.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::CursorOptions::IndexKeyCursorImpl::loadCurrentRow):

LayoutTests:

Add layout test to verify that update object store data causes old
index data to be invalidated.

  • storage/indexeddb/index-unique.html: Added.
02:19 WikiStart edited by whzeng@126.com
(diff)
02:10 Changeset [92363] by commit-queue@webkit.org
  • 1 edit
    4 moves in trunk/Source/WebCore

Move PODIntervalTree to Source/WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=65667

It seems the files were not part of any project, so no project files were modified.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-04
Reviewed by Adam Barth.

No new tests, just moving files from one folder to the other.

  • platform/PODArena.h: Renamed from Source/WebCore/platform/graphics/gpu/PODArena.h.

(WebCore::PODArena::Allocator::~Allocator):
(WebCore::PODArena::FastMallocAllocator::create):
(WebCore::PODArena::FastMallocAllocator::allocate):
(WebCore::PODArena::FastMallocAllocator::free):
(WebCore::PODArena::FastMallocAllocator::FastMallocAllocator):
(WebCore::PODArena::create):
(WebCore::PODArena::allocateObject):
(WebCore::PODArena::~PODArena):
(WebCore::PODArena::PODArena):
(WebCore::PODArena::minAlignment):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::roundUp):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(WebCore::PODArena::Chunk::allocate):

  • platform/PODInterval.h: Renamed from Source/WebCore/platform/graphics/gpu/PODInterval.h.

(WebCore::PODInterval::PODInterval):
(WebCore::PODInterval::low):
(WebCore::PODInterval::high):
(WebCore::PODInterval::data):
(WebCore::PODInterval::overlaps):
(WebCore::PODInterval::operator<):
(WebCore::PODInterval::operator==):
(WebCore::PODInterval::maxHigh):
(WebCore::PODInterval::setMaxHigh):
(WebCore::PODInterval::toString):

  • platform/PODIntervalTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODIntervalTree.h.

(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::createInterval):
(WebCore::PODIntervalTree::checkInvariants):
(WebCore::PODIntervalTree::init):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
(WebCore::PODIntervalTree::updateNode):
(WebCore::PODIntervalTree::checkInvariantsFromNode):

  • platform/PODRedBlackTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODRedBlackTree.h.

(WebCore::PODRedBlackTree::Visitor::~Visitor):
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::~PODRedBlackTree):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::setNeedsFullOrderingComparisons):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::setVerboseDebugging):
(WebCore::PODRedBlackTree::Node::Node):
(WebCore::PODRedBlackTree::Node::~Node):
(WebCore::PODRedBlackTree::Node::color):
(WebCore::PODRedBlackTree::Node::setColor):
(WebCore::PODRedBlackTree::Node::data):
(WebCore::PODRedBlackTree::Node::copyFrom):
(WebCore::PODRedBlackTree::Node::left):
(WebCore::PODRedBlackTree::Node::setLeft):
(WebCore::PODRedBlackTree::Node::right):
(WebCore::PODRedBlackTree::Node::setRight):
(WebCore::PODRedBlackTree::Node::parent):
(WebCore::PODRedBlackTree::Node::setParent):
(WebCore::PODRedBlackTree::root):
(WebCore::PODRedBlackTree::updateNode):
(WebCore::PODRedBlackTree::treeSearch):
(WebCore::PODRedBlackTree::treeSearchNormal):
(WebCore::PODRedBlackTree::treeSearchFullComparisons):
(WebCore::PODRedBlackTree::treeInsert):
(WebCore::PODRedBlackTree::treeSuccessor):
(WebCore::PODRedBlackTree::treeMinimum):
(WebCore::PODRedBlackTree::propagateUpdates):
(WebCore::PODRedBlackTree::leftRotate):
(WebCore::PODRedBlackTree::rightRotate):
(WebCore::PODRedBlackTree::insertNode):
(WebCore::PODRedBlackTree::deleteFixup):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::visitInorderImpl):
(WebCore::PODRedBlackTree::Counter::Counter):
(WebCore::PODRedBlackTree::Counter::visit):
(WebCore::PODRedBlackTree::Counter::count):
(WebCore::PODRedBlackTree::checkInvariantsFromNode):
(WebCore::PODRedBlackTree::logIfVerbose):
(WebCore::PODRedBlackTree::dumpFromNode):

01:52 Changeset [92362] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65666

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
01:39 Changeset [92361] by hamaji@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Chromium test rebaselining

  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:56 Changeset [92360] by abarth@webkit.org
  • 2 edits in trunk/Tools

Another subtle bug due to lack of testing in main.js. :(

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
00:52 Changeset [92359] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Test progression after <http://trac.webkit.org/changeset/92341>.

  • platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt:
  • platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt:
00:49 Changeset [92358] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

Update baselines after <http://trac.webkit.org/changeset/92340>.

  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
00:41 Changeset [92357] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix types. Sadly, main.js has no test coverage. (I need to think
about how to test this part of the code.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
00:14 Changeset [92356] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

bugzilla.js is missing unit tests
https://bugs.webkit.org/show_bug.cgi?id=65656

Reviewed by Adam Roben.

Testing makes perfect.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:

(NetworkSimulator.prototype.runTest.get if):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
00:14 Changeset [92355] by abarth@webkit.org
  • 19 edits in trunk/Tools

Add missing license blocks to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65654

Reviewed by Dimitri Glazkov.

This patch is entirely boilerplate.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
00:13 Changeset [92354] by abarth@webkit.org
  • 12 edits
    2 adds in trunk/Tools

garden-o-matic needs a way to mock out the network
https://bugs.webkit.org/show_bug.cgi?id=65653

Reviewed by Dimitri Glazkov.

This patch introduces the net module, which is a useful mock point for
abstracting away the network. Future patches will use this
infrastructure to test some currently untested code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.

(NetworkSimulator):
(NetworkSimulator.prototype.scheduleCallback):
(NetworkSimulator.prototype.runTest):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
00:10 Changeset [92353] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test triggers a crasher on some ports. The crasher is filed already.

  • platform/qt/Skipped:
Note: See TracTimeline for information about the timeline view.