Timeline


and

08/13/11:

23:55 Changeset [93028] by mitz@apple.com

Set the svn:mime-type property of some PNG files to image/png

13:38 Changeset [93027] by mitz@apple.com

Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.

Reviewed by Joseph Pecoraro.

../WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:

../WebKit/win:

  • WebPreferenceKeysPrivate.h:
12:27 Changeset [93026] by weinig@apple.com

Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.

  • bindings/objc/WebScriptObject.mm:
12:25 Changeset [93025] by weinig@apple.com

Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined dealloc]):

12:12 Changeset [93024] by weinig@apple.com

Remove unused variables from WebView/WebFullScreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66194

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:

Remove a few variables which were not used.

12:03 Changeset [93023] by weinig@apple.com

Remove unused variables from WKFullScreenWindowController.h
https://bugs.webkit.org/show_bug.cgi?id=66193

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:

Remove _layerViewPlaceholder, _isWindowLoaded and _initialFrame which were not used.

11:57 Changeset [93022] by weinig@apple.com

Remove unused variables from WebVideoFullscreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66192

Reviewed by Dan Bernstein.

  • platform/mac/WebVideoFullscreenController.h:

Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.

11:51 Changeset [93021] by weinig@apple.com

Fix incorrect objective-c initialize in WebCore
https://bugs.webkit.org/show_bug.cgi?id=66191

Reviewed by David Kilzer.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):

  • rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.

11:31 Changeset [93020] by abarth@webkit.org

Fix clang build.

  • platform/chromium/PopupMenuChromium.h:
11:06 Changeset [93019] by ddkilzer@apple.com

<http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate entries

by using uniq. Originally noticed by Xcode 4.

10:54 Changeset [93018] by weinig@apple.com

Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190

Reviewed by David Kilzer.

  • wtf/Assertions.h:

Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.

10:48 Changeset [93017] by weinig@apple.com

Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66182

Reviewed by Dan Bernstein.

Fixes 10 warnings in JavaScriptCore and 2 in testapi.

  • API/tests/testapi.c:

(main):
Remove dead variables.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).

  • wtf/dtoa.cpp:

(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.

08:39 Changeset [93016] by dglazkov@chromium.org

garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
https://bugs.webkit.org/show_bug.cgi?id=66166

Also changed base.RequestTracker to:
a) fire callback immediately if requestsInFlight is 0;
b) not barf if callback is not supplied.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
00:00 Changeset [93015] by mitz@apple.com

Build fix.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

08/12/11:

23:25 Changeset [93014] by mitz@apple.com

Source/WebCore: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
truncated text, try to set the tooltip to the full text of the truncated text, if any.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize new member variable.
(WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.

  • page/Settings.h:

(WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.

  • rendering/HitTestResult.h:
  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Made this public.

Source/WebKit/mac: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Added a default value of NO for the
ShowsToolTipOverTruncatedText preference.
(-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
(-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit/win: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Interfaces/IWebPreferencesPrivate.idl: Added accessors.
  • WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added a default value of
false for the ShowsToolTipOverTruncatedText preference.
(WebPreferences::showsToolTipOverTruncatedText): Added this getter.
(WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit2: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShowsToolTipOverTruncatedText): Added this setter.
(WKPreferencesGetShowsToolTipOverTruncatedText): Added this getter.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Handle the showsToolTipOverTruncatedText preference.

20:26 Changeset [93013] by senorblanco@chromium.org

Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=66154

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::isAccelerated):
Plumb this call through GraphicsContext::isAcceleratedContext().
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
For the ACCELERATED_2D_CANVAS path, plumb this call through
(the new) GraphicsContext::paintsIntoCanvasBuffer().
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):
Remove the use of the m_context3D member; use a temporary instead.

  • html/canvas/CanvasRenderingContext2D.h:

Remove the m_context3D member.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Implement stub versions of these functions for other platforms.

  • platform/graphics/GraphicsContext.h:

Expose isAcceleratedContext() to all platforms. Add
paintsIntoImageBuffer() member function.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setGraphicsContext3D):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Basically gut this class leaving only a static creation function.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
Use isAccelerated() in place of useSkiaGpu().

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
(WebCore::PlatformContextSkia::paintsIntoImageBuffer):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::isAccelerated):
Rename useSkiaGpu() to isAccelerated(). Plumb through
paintsIntoImageBuffer() to GraphicsContext3D.

19:40 Changeset [93012] by weinig@apple.com

Use builtin_trap() for CRASH when building with clang
https://bugs.webkit.org/show_bug.cgi?id=66152

Reviewed by Anders Carlsson.

../JavaScriptCore:

  • wtf/Assertions.h:

Add Clang specific CRASH macro that calls builtin_trap() instead
of silly techniques to crash. This allows the static analyzer to understand
that we are intentionally crashing. As a result, we need to mark some functions
as not returning.

Also adds a macros that annotates a function as never returning due to ASSERT or CRASH.

  • wtf/Compiler.h:

Add COMPILIER(CLANG) and fix some formatting and spelling mistakes.

  • wtf/FastMalloc.cpp:

(WTF::Internal::fastMallocMatchFailed):
Add NO_RETURN_DUE_TO_CRASH.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
Add NO_RETURN_DUE_TO_ASSERT.

../WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::fail):

  • bindings/objc/WebScriptObject.mm:
  • platform/mac/BlockExceptions.h:
  • platform/text/cf/StringImplCF.cpp:

Add NO_RETURN_DUE_TO_ASSERT.

  • bridge/IdentifierRep.h:

Don't define the destructor since it is never called,

../WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
(-[WebBaseNetscapePluginView handleMouseMoved:]):
(-[WebBaseNetscapePluginView handleMouseEntered:]):
(-[WebBaseNetscapePluginView handleMouseExited:]):
(-[WebBaseNetscapePluginView focusChanged]):
(-[WebBaseNetscapePluginView windowFocusChanged:]):
(-[WebBaseNetscapePluginView createPlugin]):
(-[WebBaseNetscapePluginView loadStream]):
(-[WebBaseNetscapePluginView shouldStop]):
(-[WebBaseNetscapePluginView destroyPlugin]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
(-[WebBaseNetscapePluginView pluginLayer]):
(-[WebBaseNetscapePluginView getFormValue:]):
Remove the ASSERT_NOT_REACHED from the base class methods. They were not
adding much value and were getting in the way of making the static analyzer
work. A better way to do this would be to use a formal protocol.

18:44 Changeset [93011] by joepeck@webkit.org

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

No new tests, this is not a functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
If the CSS font-face is loading from a URL then immediately
fallback to a system font matching the description, since we
cannot determine a reasonable family name from the m_string
URL. The URL could be a dataURI.

16:27 Changeset [93010] by fpizlo@apple.com

DFG JIT has inconsistent use of boxDouble and unboxDouble,
inconsistent use of assertions regarding doubles, and those
assertions are not turned on in debug builds
https://bugs.webkit.org/show_bug.cgi?id=66160

Reviewed by Gavin Barraclough.

JIT assertions are now turned on in debug builds. JIT
assertions are now used for boxing and unboxing doubles, and boxing
and unboxing no longer involves code duplication.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):

16:18 Changeset [93009] by fsamuel@chromium.org

Refactoring of PopupMenuChromium For Readability and Maintainability
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
and PopupLisBox.{h|cpp} for readability and maintainability.

No new tests as there's no change in functionality.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
  • tests/PopupMenuTest.cpp:
15:59 Changeset [93008] by abarth@webkit.org

Need a way to selectively use hixie-76 for websocket connections depending on destination and/or origin
https://bugs.webkit.org/show_bug.cgi?id=65835

Patch by Denis Lagno <dilmah@chromium.org> on 2011-08-12
Reviewed by Alexey Proskuryakov and Yuta Kitamura.

WebCore:

No new tests. (because it is temporary solution for transient period between hixie-76 and hybi-NN).

  • page/Settings.cpp:

(WebCore::Settings::addHixie76WebSocketProtocolException):
(WebCore::Settings::useHixie76WebSocketProtocol):

  • page/Settings.h:

(WebCore::Settings::setUseHixie76WebSocketProtocol):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):

WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::addHixie76WebSocketProtocolException):

  • src/WebSettingsImpl.h:
15:56 Changeset [93007] by fsamuel@chromium.org

Expose pageScaleFactor() to Chromium's WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=66067

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):

  • src/WebViewImpl.h:
15:48 Changeset [93006] by rniwa@webkit.org

Skip the test added by r92997 on Qt port because it uses a method on EventSender that hasn't been
implemented by Qt port's DRT. The failure is tracked by the bug 66173.

  • platform/qt/Skipped:
15:35 Changeset [93005] by mrowe@apple.com

Be more forward-looking in the choice of compiler.

Rubber-stamped by Jon Honeycutt.

Source/JavaScriptCore:

  • Configurations/CompilerVersion.xcconfig:

Source/JavaScriptGlue:

  • Configurations/CompilerVersion.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/CompilerVersion.xcconfig:

Source/WebCore:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit/mac:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit2:

  • Configurations/CompilerVersion.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
15:32 Changeset [93004] by commit-queue@webkit.org

[GTK] Fix non-pthreads build after r91906.
https://bugs.webkit.org/show_bug.cgi?id=66151

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-12
Reviewed by David Levin.

r91906 broke the non-pthreads GTK+ build by including a header which
doesn't exist. Fix it by including DateMath.h instead of DateMap.h.

  • wtf/gtk/ThreadingGtk.cpp:
15:00 Changeset [93003] by nduca@chromium.org

[chromium] Fix comile warning on CCLayerTreeHost

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

14:44 Changeset [93002] by abarth@webkit.org

Update expectations to note flakiness.

  • platform/chromium/test_expectations.txt:
14:42 Changeset [93001] by rniwa@webkit.org

Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/execCommand/16049-expected.txt:
  • editing/execCommand/5685604-1.html:
  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/query-font-size-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-expected.txt:
  • editing/execCommand/script-tests/remove-format-multiple-elements.js:
  • editing/execCommand/script-tests/toggle-text-decorations.js:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/execCommand/toggle-text-decorations-expected.txt:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/pasteboard/paste-text-with-style-2-expected.txt:
  • editing/style/apply-font-size-to-multiple-nodes-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/highlight-insert-paragraph-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/invalid-font-size-expected.txt:
  • editing/style/push-down-font-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-font-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-win/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/editing/inserting/5994480-2-expected.txt:
14:42 Changeset [93000] by mrowe@apple.com

Update some configuration settings that were missed back in r92432.

  • Configurations/CompilerVersion.xcconfig:
14:41 Changeset [92999] by nduca@chromium.org

[chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
https://bugs.webkit.org/show_bug.cgi?id=66168

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

14:35 Changeset [92998] by leviw@chromium.org

Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
https://bugs.webkit.org/show_bug.cgi?id=66149

Reviewed by Eric Seidel.

Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
abstraction from ints.

No tests as no change in functionality.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::listHeight):
(WebCore::RenderListBox::baselinePosition):
(WebCore::RenderListBox::itemBoundingBoxRect):
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::itemHeight):
(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::controlClipRect):
(WebCore::RenderListBox::invalidateScrollbarRect):
(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::controlClipRect):
(WebCore::RenderMenuList::showPopup):

  • rendering/RenderMenuList.h:
14:28 Changeset [92997] by commit-queue@webkit.org

Source/WebKit/chromium: Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollBegin):
(EventSender::gestureScrollEnd):
(EventSender::gestureTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • fast/events/touch/gesture/gesture-click-expected.txt: Added.
  • fast/events/touch/gesture/gesture-click.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.
14:10 Changeset [92996] by lforschler@apple.com

Merge r92986.

14:08 Changeset [92995] by lforschler@apple.com

Merge r92911.

14:06 Changeset [92994] by lforschler@apple.com

Merge r92909.

14:02 Changeset [92993] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66133

Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
layer tree (just as we did with painting).

Reviewed by Sam Weinig.

Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.

Source/WebCore:

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::type):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/hit-test-float-expected.txt: Added.
  • fast/regions/hit-test-float.html: Added.
14:01 Changeset [92992] by leviw@chromium.org

Switch RenderTable* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66146

Reviewed by Eric Seidel.

Converting RenderTable* classes to new LayoutUnits from ints.

No new tests as no new functionality.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::firstLineBoxBaseline):
(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:

(WebCore::RenderTable::columnPositions):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
(WebCore::RenderTableSection::getBaseline):

13:58 Changeset [92991] by commit-queue@webkit.org

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-08-12
Reviewed by Alexey Proskuryakov.

EventSource loader should not buffer data
https://bugs.webkit.org/show_bug.cgi?id=61863

Disabled buffering in the EventSource loader.

Added a manual test.

  • manual-tests/eventsource/eventsource-loader-buffering.html: Added.
  • manual-tests/eventsource/eventsource-loader-buffering.php: Added.
  • page/EventSource.cpp:

(WebCore::EventSource::connect):

13:56 Changeset [92990] by rniwa@webkit.org

Skip the test added by r92982 on Qt since it uses a new layoutTestController method
that hasn't been implemented by Qt DRT. The failure is tracked by the bug 66162.

  • platform/qt/Skipped:
13:46 Changeset [92989] by commit-queue@webkit.org

[Chromium] Implement the embedders for the HTML5 Track List objects
https://bugs.webkit.org/show_bug.cgi?id=60260

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-12
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamTrack.h: Added.

(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::isNull):

  • public/WebMediaStreamTrackList.h: Added.

(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::~WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::isNull):

  • src/WebMediaStreamTrack.cpp: Added.

(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator WTF::PassRefPtr<WebCore::MediaStreamTrack>):

  • src/WebMediaStreamTrackList.cpp: Added.

(WebKit::WebMediaStreamTrackList::initialize):
(WebKit::WebMediaStreamTrackList::reset):
(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::operator WTF::PassRefPtr<MediaStreamTrackList>):

13:41 Changeset [92988] by rniwa@webkit.org

GTK rebaselines after r92890.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
13:34 Changeset [92987] by rniwa@webkit.org

Mac rebaselines after r92890.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
13:33 Changeset [92986] by barraclough@apple.com

REGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
Matrix3D.invert)
https://bugs.webkit.org/show_bug.cgi?id=66038

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-12
Reviewed by Gavin Barraclough.

Simplest and lowest-impact fix for the case where the spilled format
of a DFG node differs from the register format: if the format is
converted then indicate that the spilled value is no longer valid
("kill the spill").

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::killSpilled):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

13:33 Changeset [92985] by psolanki@apple.com

ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
https://bugs.webkit.org/show_bug.cgi?id=65926

Reviewed by Alexey Proskuryakov.

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
m_shouldBufferData is set to false.

13:18 Changeset [92984] by aestes@apple.com

allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
https://bugs.webkit.org/show_bug.cgi?id=66158

Reviewed by Dan Bernstein.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback): The third argument is the 'this'
JSObjectRef, not the second.

13:16 Changeset [92983] by abarth@webkit.org

Unreviewed, rolling out r92976.
http://trac.webkit.org/changeset/92976
https://bugs.webkit.org/show_bug.cgi?id=66159

Does not compile on chromium-win (Requested by abarth|gardener
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Removed.
  • platform/chromium/PopupContainer.h: Removed.
  • platform/chromium/PopupListBox.cpp: Removed.
  • platform/chromium/PopupListBox.h: Removed.
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupItem::PopupItem):
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
12:56 Changeset [92982] by aestes@apple.com

Cancel in onbeforeunload dialog sometime causes a button to stop working.
https://bugs.webkit.org/show_bug.cgi?id=26211

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/loader/form-submission-after-beforeunload-cancel.html

If an onbeforeunload handler cancels a navigation that was triggered by
a form submission, WebCore's multiple form submission protection
prevents the form from being submitted a second time even though no
first submission actually took place. Fix this by clearing
m_submittedFormURL if the onbeforeunload handler cancels the load. This
allows the submission to be retried.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
if shouldClose() will return false.

Tools:

Implement a new LayoutTestController method that a test can call to set
the return value of DumpRenderTree's beforeunload UI delegate.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload.
(setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
(LayoutTestController::staticFunctions): Register
'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload and bind
'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
(LayoutTestController::reset): Reset
m_shouldStayOnPageAfterHandlingBeforeUnload to false.
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
from JavaScript.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
return the inverse of
LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Define setShouldStayOnPageAfterHandlingBeforeUnload().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
to the Test Controller telling it what value it should return in its
onbeforeunload UI delegate.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Call InjectedBundle::postNewBeforeUnloadReturnValue().

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize
m_beforeUnloadReturnValue to true.
(WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
the value of TestController::beforeUnloadReturnValue().
(WTR::TestController::resetStateToConsistentValues): Reset
m_beforeUnloadReturnValue to true.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::beforeUnloadReturnValue):
(WTR::TestController::setBeforeUnloadReturnValue):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
message posted from the injected bundle by retrieving the message body
as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().

LayoutTests:

  • fast/loader/form-submission-after-beforeunload-cancel-expected.txt: Added.
  • fast/loader/form-submission-after-beforeunload-cancel.html: Added.
12:53 Changeset [92981] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66130

RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
offset.

Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
They no longer have to subclass their own layout method or worry about all of the painting logic
for anything other than the content area.

Reviewed by Anders Carlsson.

Existing tests have a layer tree example, and so those results are updated to show the tree now.

Source/WebCore:

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png:
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
  • fast/regions/content-flowed-into-regions-expected.png:
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-expected.png:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png:
12:38 Changeset [92980] by abarth@webkit.org

Unreviewed, rolling out r92978.
http://trac.webkit.org/changeset/92978
https://bugs.webkit.org/show_bug.cgi?id=66155

This patch does not compile (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:56 Changeset [92979] by crogers@google.com

Fix mac build when web audio is enabled
https://bugs.webkit.org/show_bug.cgi?id=66150

Unreviewed build fix.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

11:43 Changeset [92978] by fsamuel@chromium.org

Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=66089

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:42 Changeset [92977] by jeffm@apple.com

Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
https://bugs.webkit.org/show_bug.cgi?id=65724

Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).

Reviewed by Eric Carlson.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().

11:36 Changeset [92976] by fsamuel@chromium.org

Refactoring of PopupMenuChromium
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
for readability and maintainability.

No new tests as no functionality has changed.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
11:06 Changeset [92975] by cevans@google.com

Merge 92798
BUG=91972
Review URL: http://codereview.chromium.org/7634029

10:51 Changeset [92974] by weinig@apple.com

Move compiler specific macros to their own header
https://bugs.webkit.org/show_bug.cgi?id=66119

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Add Compiler.h

  • wtf/AlwaysInline.h:

Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h. We can remove this file in a later commit.

  • wtf/Compiler.h: Added.

Put all compiler specific checks and features in this file.

  • wtf/Platform.h:

Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h. Include Compiler.h since it is necessary.

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
10:36 Changeset [92973] by noam.rosenthal@nokia.com

[Qt][REGRESSION] composited content doesn't render since r92651
https://bugs.webkit.org/show_bug.cgi?id=66108

Reviewed by Benjamin Poulain.

Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
the new signature in GraphicsLayer.h.

No new tests. This is a regression that's covered by existing pixel tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::syncCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
10:34 Changeset [92972] by dglazkov@chromium.org

Add a way to extend DOM objects in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=66096

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
10:33 Changeset [92971] by cevans@google.com

Merge 92791
BUG=91362
Review URL: http://codereview.chromium.org/7634026

10:28 Changeset [92970] by fsamuel@chromium.org

Expose pageScaleFactor in Chromium's WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=66139

Reviewed by Darin Fisher.

  • public/WebHistoryItem.h:
  • src/WebHistoryItem.cpp:

(WebKit::WebHistoryItem::pageScaleFactor):
(WebKit::WebHistoryItem::setPageScaleFactor):

10:22 Changeset [92969] by commit-queue@webkit.org

Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.

[CSSRegions]RenderFlowThread should display its content using RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=65627

Source/WebCore:

RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
of RenderRegion objects that get the content from the same flow.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

Tests: fast/regions/content-flowed-into-regions-dynamically-added.html

fast/regions/content-flowed-into-regions-dynamically-removed.html
fast/regions/content-flowed-into-regions-with-dyn-index.html
fast/regions/content-flowed-into-regions-with-index-dom.html
fast/regions/content-flowed-into-regions-with-index.html
fast/regions/content-flowed-into-regions.html
fast/regions/flow-content-basic-vertical-rl.html
fast/regions/flow-content-basic-vertical.html

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::compareRenderRegions):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paint):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

LayoutTests:

Also updated the old tests that expected an 100% by 100% RenderFlowThread. Those tests
require at least a region attached, otherwise the RenderFlowThread would have been 0/0 in size,
and no output would be generated for them in the render tree.

The attached regions are now printed in the render tree, so some tests required updated results.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html: Added.
  • fast/regions/content-flowed-into-regions-expected.png: Added.
  • fast/regions/content-flowed-into-regions-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index.html: Added.
  • fast/regions/content-flowed-into-regions.html: Added.
  • fast/regions/flow-content-basic-vertical-rl.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic-vertical.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic.html:
  • fast/regions/render-region-renderer-expected.txt:
  • fast/regions/resources/region-style.css: Added.

(.greenBox):
(.blueBox):
(.orangeBox):
(.flowArticle):
(.regionArticle):
(.borderBox):

  • fast/regions/webkit-flow-renderer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested-expected.txt:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • platform/mac/fast/regions/flow-content-basic-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
10:17 Changeset [92968] by cevans@google.com

Merge 92966
BUG=92621
Review URL: http://codereview.chromium.org/7640019

10:15 Changeset [92967] by cevans@google.com

Merge 92966
BUG=92621
Review URL: http://codereview.chromium.org/7635022

09:27 Changeset [92966] by inferno@chromium.org

Crash in WebCore::editingIgnoresContent
https://bugs.webkit.org/show_bug.cgi?id=66125

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr a few nodes in case they get blown away in
dispatchEvent calls.

Test: editing/selection/select-start-remove-root-crash.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Tests that we do not crash when we blow away the root
during the firing of selectstart event in selection.

  • editing/selection/select-start-remove-root-crash-expected.txt: Added.
  • editing/selection/select-start-remove-root-crash.html: Added.
09:26 Changeset [92965] by nduca@chromium.org

[chromium] Add WebThread to WebKitClient
https://bugs.webkit.org/show_bug.cgi?id=66013

Reviewed by Darin Fisher.

  • public/WebKitClient.h:

(WebKit::WebKitClient::createThread):

  • public/WebThread.h: Added.

(WebKit::WebThread::~WebThread):

08:34 Changeset [92964] by podivilov@chromium.org

Web Inspector: properly update console message count in source frames and resources panel.
https://bugs.webkit.org/show_bug.cgi?id=57009

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype._updateMessageRepeatCount):

08:15 Changeset [92963] by caio.oliveira@openbossa.org

[Qt] Add test for correct order of load signals in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=66016

Reviewed by Benjamin Poulain.

Add API test to ensure the order of load signals: loadStarted() needs to be emitted
first, then loadProgress(100), followed by loadFinished().

The test is skipped since this right now is broken, the bug
https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.

  • tests/qwebpage/tst_qwebpage.cpp:

(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
(SpyForLoadSignalsOrder::isFinished):
(SpyForLoadSignalsOrder::onLoadProgress):
(tst_QWebPage::loadSignalsOrder_data):
(tst_QWebPage::loadSignalsOrder):

07:56 Changeset [92962] by pfeldman@chromium.org

2011-08-12 Pavel Feldman <pfeldman@google.com>

Not reviewed: follow up to inspector test breakage.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
07:50 Changeset [92961] by yurys@chromium.org

Web Inspector: expand exception properties when wrapping it as object.
https://bugs.webkit.org/show_bug.cgi?id=66035

Source/WebCore:

Use toString() value as a description for value thrown during eval.

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-eval-syntax-error-expected.txt:
  • inspector/console/console-eval-undefined-override-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • platform/chromium/inspector/console/console-eval-global-expected.txt:
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt:
  • platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt:
07:33 Changeset [92960] by alexis.menard@openbossa.org

[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.

In order to build correctly the QtQuick1 plugin we need to explicitly
link to the new library added in Qt5 "qtquick1".

Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
07:05 Changeset [92959] by andreip@google.com

2011-08-12 Andrei Popescu <andreip@google.com>

[Chromium] Rebaseline these tests on Leopard.

Unreviewed gardening.

  • LayoutTests/platform/chromium-linux/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-win-xp/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
06:54 Changeset [92958] by pfeldman@chromium.org

Web Inspector: make folders optional in the Scripts' panel file selector.
https://bugs.webkit.org/show_bug.cgi?id=66100

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
06:03 Changeset [92957] by podivilov@chromium.org

Web Inspector: add space between error info and error message in source frame message bubble.
https://bugs.webkit.org/show_bug.cgi?id=65069

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • inspector/debugger/source-frame-expected.txt:
05:56 Changeset [92956] by pfeldman@chromium.org

Web Inspector: console loses focus upon reloading the page from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=66068

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.revealAndSelect):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._setDocument.selectNode):
(WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._setDocument):
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.selectedDOMNode):
(WebInspector.ElementsPanel.prototype.selectDOMNode):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.updateFocusedNode):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.reset):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype._jumpToSearchResult):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createTopPane):

  • inspector/front-end/inspector.js:
  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.select):

LayoutTests:

  • inspector/console/command-line-api-inspect.html:
05:17 Changeset [92955] by ossy@webkit.org

Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
05:06 Changeset [92954] by yurys@chromium.org

2011-08-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h

  • inspector/InspectorAgent.h:
04:44 Changeset [92953] by vsevik@chromium.org

Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
https://bugs.webkit.org/show_bug.cgi?id=66061

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::requestId):

  • inspector/IdentifiersFactory.h:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::requestId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._requestId):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._appendResource):
(WebInspector.NetworkLogView.prototype._matchResource):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.FormattedRecord):

LayoutTests:

  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-test.js:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
03:57 Changeset [92952] by ossy@webkit.org

Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • fast/html/unknown-tag-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated.
02:32 Changeset [92951] by hans@chromium.org

IndexedDB: Object store records don't need to have keys in all indexes
https://bugs.webkit.org/show_bug.cgi?id=66049

Reviewed by Tony Chang.

Source/WebCore:

Allow inserting records in an object store even though they don't
yield keys in some index. The spec has changed in this regard.

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

LayoutTests:

Update test to make sure it's possible to add an object store record
even though it doesn't yield keys in every index.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
01:51 Changeset [92950] by hans@chromium.org

IndexedDB: Overwriting key in unique index should be possible
https://bugs.webkit.org/show_bug.cgi?id=65993

Reviewed by Tony Chang.

Source/WebCore:

It should be possible to overwrite an object store record even if
there is a derived key for that record in an index with the unique flag set.

  • storage/IDBBackingStore.h:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):

  • storage/IDBSQLiteBackingStore.h:

LayoutTests:

Test that it's possible to overwrite an object store record even if there
is a derived key for that record in an index with the unique flag set.

  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
00:52 Changeset [92949] by commit-queue@webkit.org

[EFL] Fix after r91815 - restore changes from r91659.
https://bugs.webkit.org/show_bug.cgi?id=64682

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Kenneth Rohde Christiansen.

Restore patch for fix ewk_view_context_menu_forward_event which
has been overwrititen by mistake.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

00:46 Changeset [92948] by commit-queue@webkit.org

[EFL] HTML Saving feature.
https://bugs.webkit.org/show_bug.cgi?id=55455

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Antonio Gomes.

Gets the source and location of resources for document.
TODO:

  1. Support others resources (css, plugins, media files).
  2. Currently only HTML documents are supported.
  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):
(ewk_frame_resources_location_get):

  • ewk/ewk_frame.h:
00:08 Changeset [92947] by lforschler@apple.com

New tag.

08/11/11:

23:44 Changeset [92946] by yutak@chromium.org

WebSocket: Implement "protocol" attribute
https://bugs.webkit.org/show_bug.cgi?id=65248

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/no-subprotocol.html (added)

http/tests/websocket/tests/hybi/set-protocol.html (added)
http/tests/websocket/tests/hybi/workers/no-subprotocol.html (added)
http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
http/tests/websocket/tests/hybi/multiple-subprotocols.html (updated)
http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html (updated)

  • websockets/ThreadableWebSocketChannel.h:

Added subprotocol() function. This function is named differently from the counterpart of
WebSocket class, because the name "protocol" can be confused with the WebSocket protocol.
Added m_useHixie76Protocol and m_subprotocol, because these value may be used after
m_channel has been released. Using bool should be fine, because boolean literals do not
appear in ambiguous context.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::connect):
(WebCore::WebSocket::protocol):
The "protocol" attribute is available only when the hybi-10 protocol is chosen.
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):
(WebCore::WebSocket::didConnect):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::subprotocol):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::subprotocol):
(WebCore::workerContextDidConnect):
Subprotocol value is saved in the client wrapper object after the WebSocket connection is
established.
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
  • http/tests/websocket/tests/hixie76/undefined-attributes.html:

Added a test to check "protocol" attribute.

  • http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt:
  • http/tests/websocket/tests/hybi/multiple-subprotocols.html:

The attribute should return an empty string at first. After the connection is established,
it should return the value of Sec-WebSocket-Protocol header in the server's handshake response.

  • http/tests/websocket/tests/hybi/no-subprotocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/no-subprotocol.html: Added.
  • http/tests/websocket/tests/hybi/set-protocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/set-protocol.html: Added.
  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt:
  • http/tests/websocket/tests/hybi/workers/no-subprotocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/no-subprotocol.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js:

(ws.onopen):
(ws.onclose):
(checkAfterOnClose):

  • http/tests/websocket/tests/hybi/workers/resources/no-subprotocol.js: Added.

(ws.onopen):
(ws.onclose):
(checkAfterOnClose):

23:29 Changeset [92945] by lforschler@apple.com

Merge r92692.

23:27 Changeset [92944] by lforschler@apple.com

Merge r92389.

23:25 Changeset [92943] by lforschler@apple.com

Merge r92384.

23:21 Changeset [92942] by lforschler@apple.com

Merge r92231.

23:17 Changeset [92941] by lforschler@apple.com

Merge r92132.

23:14 Changeset [92940] by lforschler@apple.com

Merge r91965.

23:10 Changeset [92939] by lforschler@apple.com

Merge r91961.

23:08 Changeset [92938] by lforschler@apple.com

Merge r91939.

23:06 Changeset [92937] by lforschler@apple.com

Merge r91908.

23:04 Changeset [92936] by lforschler@apple.com

Merge r91793.

23:01 Changeset [92935] by lforschler@apple.com

Merge r91781.

22:58 Changeset [92934] by lforschler@apple.com

Merge r91728.

22:57 Changeset [92933] by lforschler@apple.com

Merge r91689.

22:47 Changeset [92932] by lforschler@apple.com

Merge r91611.

22:45 Changeset [92931] by lforschler@apple.com

Merge r91559.

22:44 Changeset [92930] by lforschler@apple.com

Merge r91531.

22:41 Changeset [92929] by lforschler@apple.com

Merge r91474.

22:38 Changeset [92928] by morrita@google.com

[Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
https://bugs.webkit.org/show_bug.cgi?id=45438

Reviewed by Kent Tamura.

Tools:

MockSpellCheck was assuming the input of spellCheckWord() is a word.
But it can be a series of word. This change made spellCheckWord()
understand simple word boundary which appears in tests.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord):

LayoutTests:

Added a chromium specific expectation because chromium will use window's (wrong) expectation
unless chromium has its own.

  • platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt: Added
22:27 Changeset [92927] by lforschler@apple.com

Merge r91270.

22:25 Changeset [92926] by lforschler@apple.com

Merge r91152.

22:23 Changeset [92925] by lforschler@apple.com

Merge r91100.

22:22 Changeset [92924] by lforschler@apple.com

Merge r91098.

22:21 Changeset [92923] by lforschler@apple.com

Merge r91097.

22:18 Changeset [92922] by hayato@chromium.org

Implement proper handling of events with a related target in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=65899

Reviewed by Dimitri Glazkov.

Fixes issues in the following corner cases:

  1. When both a target node and a relatedTarget node are immediate children of

the same shadow root, an event is not dispatched.

  1. If a target node is an ancestor of a relatedTarget node, crossing

shadow boundaries, or vice verse, an event is not dispatched or wrongly
dispatched.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-crossing-expected.txt: Renamed from LayoutTests/fast/events/shadow-boundary-crossing-expected.txt.
  • fast/dom/shadow/shadow-boundary-crossing.html: Renamed from LayoutTests/fast/events/shadow-boundary-crossing.html.
  • fast/dom/shadow/shadow-boundary-events-expected.txt: Added.
  • fast/dom/shadow/shadow-boundary-events.html: Added.
22:13 Changeset [92921] by lforschler@apple.com

Merge r91085.

22:12 Changeset [92920] by lforschler@apple.com

Merge r91044.

22:10 Changeset [92919] by lforschler@apple.com

Merge r91040.

21:57 Changeset [92918] by lforschler@apple.com

Merge r90595.

21:54 Changeset [92917] by lforschler@apple.com

Merge r89987.

21:39 Changeset [92916] by lforschler@apple.com

Merge r89214.

21:32 Changeset [92915] by lforschler@apple.com

Merge r88669.

21:16 Changeset [92914] by commit-queue@webkit.org

VectorArgumentCoder doesn't encode/decode enough data for more than one byte vector elements
https://bugs.webkit.org/show_bug.cgi?id=66109

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-11
Reviewed by Anders Carlsson.

Multiply vector size by element size in encode/decode to get correct byte size of vector data.

  • Platform/CoreIPC/ArgumentCoders.h:
21:11 Changeset [92913] by lforschler@apple.com

Merge r88434.

21:10 Changeset [92912] by lforschler@apple.com

Merge r87875.

21:09 Changeset [92911] by fpizlo@apple.com

DFG JIT-specific structure stub info code offset fields are signed
8-bit, but it is possible for the offsets to be greater than 127
https://bugs.webkit.org/show_bug.cgi?id=66122

Reviewed by Gavin Barraclough.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

21:08 Changeset [92910] by lforschler@apple.com

Merge r87863.

20:41 Changeset [92909] by fpizlo@apple.com

DFG JIT speculation failure code sometimes picks the wrong register
as a scratch register.
https://bugs.webkit.org/show_bug.cgi?id=66104

Reviewed by Gavin Barraclough.

Hardened the code with more assertions and fixed the bug. Now a
spilled register is only used for scratch if it also isn't being
used for shuffling.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

20:32 Changeset [92908] by commit-queue@webkit.org

Readback composited webgl results for printing
https://bugs.webkit.org/show_bug.cgi?id=65658

Patch by John Bauman <jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

Source/WebCore:

The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Add support for reading from the composited version of a canvas.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):

  • src/GraphicsContext3DInternal.h:
20:14 Changeset [92907] by commit-queue@webkit.org

REGRESSION: Qt JavaScript bridge signal connection fails
https://bugs.webkit.org/show_bug.cgi?id=66097

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-11
Reviewed by Gavin Barraclough.

Source/WebCore:

Tests in WebKit/qt/tests/qwebframe

Call toThisObject() on exec->lexicalGlobalObject() so the correct
object is passed to the JS signal handler.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):

Source/WebKit/qt:

Unmark tests as expected failures, they pass now.

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::connectAndDisconnect):

20:00 Changeset [92906] by thakis@chromium.org

Remove incorrect comment about m_wheelEventHandlerCount
https://bugs.webkit.org/show_bug.cgi?id=66117

Reviewed by Simon Fraser.

From what I can tell, this number is changed only in
Frame::notifyChromeClientWheelEventHandlerCountChanged(),
and there it just reads the number modified in
Document::didAdd/RemoveWheelEventHandler(). So this is just the number
of event handlers (and not related to horizontal scrollbars), and the
variable name expresses that already.

Source/WebCore:

  • dom/Document.h:

Source/WebKit2:

  • UIProcess/WebPageProxy.h:
19:54 Changeset [92905] by mrowe@apple.com

Versioning.

19:52 Changeset [92904] by mrowe@apple.com

New tag.

19:48 Changeset [92903] by commit-queue@webkit.org

Unreviewed, rolling out r92880.
http://trac.webkit.org/changeset/92880
https://bugs.webkit.org/show_bug.cgi?id=66123

Breaks compile in VS2010 (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-11

  • wtf/PassRefPtr.h:
19:11 Changeset [92902] by mrowe@apple.com

Fix sunspider-compare-results to default to the same suite version as the sunspider script.

Rubber-stamped by Maciej Stachowiak.

  • sunspider-compare-results:
19:11 Changeset [92901] by mrowe@apple.com

Don't conditionalize the use of -fomit-frame-pointer on compiler version as
all of our supported compilers are now new enough to have the same, sane behavior.

Rubber-stamped by Sam Weinig.

  • Configurations/JavaScriptCore.xcconfig:
19:07 Changeset [92900] by commit-queue@webkit.org

[chromium] Defer managed texture creation and destruction until updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=64772

Patch by James Robinson <jamesr@chromium.org> on 2011-08-11
Reviewed by Kenneth Russell.

This adds support for deferring GraphicsContext3D calls for texture creation and destruction for managed
textures and defers these calls until updateCompositorResources() for contents textures. The primary benefit of
this change is that it decouples managing the texture budget for the next frame (which has to happen before
painting layer contents) from the actual GL calls that create/destroy textures. That way, in the threaded
compositing world we can continue to use textures from the previous frame while software painting contents for
the next frame into software buffers or SkPictures.

Also renames LayerTexture to ManagedTexture to better reflect what it is. Not all ManagedTextures we create are
necessarily associated with layers, but they are all managed by a TextureManager.

Covered by compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:

(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::texture):

  • platform/graphics/chromium/ManagedTexture.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.cpp.

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.h.

(WebCore::ManagedTexture::create):
(WebCore::ManagedTexture::format):
(WebCore::ManagedTexture::isReserved):

  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore::TextureManager::create):
(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::contentsTexture):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):

18:12 Changeset [92899] by cevans@google.com

Merge 92630
BUG=88216
Review URL: http://codereview.chromium.org/7637006

17:54 Changeset [92898] by cevans@google.com

Merge 92744
Review URL: http://codereview.chromium.org/7637005

17:52 Changeset [92897] by ddkilzer@apple.com

<http://webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy

Reviewed by Joseph Pecoraro.

This first appeared in ToT WebKit r23462 (Windows merge).

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willCacheResponse): Only retain cachedResponse if we
are returning the same object passed into the method, otherwise
we end up double-retaining the new object created.

17:45 Changeset [92896] by mrowe@apple.com

Rework some Makefile logic to remove a double-negative.

Reviewed by Jon Honeycutt.

  • DumpRenderTree/mac/PerlSupport/Makefile:
17:22 Changeset [92895] by nduca@chromium.org

[chromium] Make WebViewImpl point at CCLayerTreeHost and related separation
https://bugs.webkit.org/show_bug.cgi?id=65791

With this patch, LayerRendererChromium becomes increasingly responsible
for rendering, while render scheduling and tree hosting moves into the
CCLayerTreeHost.

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::settings):
(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::skiaContext):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::setTextureUpdated):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::doComposite):
(WebCore::CCLayerTreeHost::composite):
(WebCore::CCLayerTreeHost::reallocateRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::animating):
(WebCore::CCLayerTreeHost::setAnimating):
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::settings):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::drawLayersOnMainThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::getCompositorSettings):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createRootLayerPainter):
(WebKit::WebViewImpl::animateAndLayout):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):

  • src/WebViewImpl.h:
17:20 Changeset [92894] by jeffm@apple.com

WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification
https://bugs.webkit.org/show_bug.cgi?id=66116

We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing
kCACFContextNeedsFlushNotification to match what we do when we registered for the same
notification with CFNotificationCenterAddObserver().

Reviewed by John Sullivan.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().
(WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.

17:18 Changeset [92893] by thakis@chromium.org

[chromium] Expose "min/max scroll size", "has horizontal/vertical scrollbar", "number of wheel handlers" to clients
https://bugs.webkit.org/show_bug.cgi?id=66094

Reviewed by James Robinson.

We want to implement two-finger-swipe for history like safari does on
os x lion. The way this works is:

  • If a page has no horizontal scrollbars, or the page is all the way to the left, scrolling to the left will go back in history instead.
  • Same for right/forward.

This is modelled after the WebKit2 functions
WKPageIsPinnedToLeftSide(), WKPageIsPinnedToRightSide(),
WKPageHasHorizontalScrollbar(), and
webPageProxy::willHandleHorizontalScrollEvents().

  • public/WebFrame.h:
  • public/WebViewClient.h:

(WebKit::WebViewClient::numWheelEventHandlersChanged):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):

  • src/ChromeClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::hasHorizontalScrollbar):
(WebKit::WebFrameImpl::hasVerticalScrollbar):
(WebKit::WebFrameImpl::isPinnedToLeft):
(WebKit::WebFrameImpl::isPinnedToRight):

  • src/WebFrameImpl.h:
17:11 Changeset [92892] by fpizlo@apple.com

DFG JIT verbose mode does not report the generated types of nodes
https://bugs.webkit.org/show_bug.cgi?id=65830

Reviewed by Sam Weinig.

Added code that prints the type selected for each node's result.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::dataFormatToString):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:43 Changeset [92891] by rniwa@webkit.org

Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan,
isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes
https://bugs.webkit.org/show_bug.cgi?id=66091

Reviewed by Tony Chang.

Source/WebCore:

Extracted common code as hasNoAttributeOrOnlyStyleAttribute. The only behavioral difference is that
replaceWithSpanOrRemoveIfWithoutAttributes will now remove elements with class="Apple-style-span",
for which I'm adding a test.

Test: editing/style/remove-styled-element-with-style-span.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
(WebCore::isUnstyledStyleSpan):
(WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
(WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):

LayoutTests:

Added a test to ensure WebKit removes implicitly styled elements such as em, b, etc...
with class="Apple-style-span" when they're not necessary.

  • editing/style/remove-styled-element-with-style-span-expected.txt: Added.
  • editing/style/remove-styled-element-with-style-span.html: Added.
16:35 Changeset [92890] by commit-queue@webkit.org

Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.
https://bugs.webkit.org/show_bug.cgi?id=41841

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-11
Reviewed by Adam Barth.

Test: fast/html/unknown-tag.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(IsDOMNodeType):

  • dom/make_names.pl:

(defaultParametersHash):
(buildConstructorMap):
(printJSElementIncludes):
(printElementIncludes):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • html/HTMLTagNames.in:
  • html/HTMLUnknownElement.h: Added.

(WebCore::HTMLUnknownElement::create):
(WebCore::HTMLUnknownElement::HTMLUnknownElement):

  • html/HTMLUnknownElement.idl: Added.
  • mathml/mathtags.in:
  • page/DOMWindow.idl:
  • svg/svgtags.in:

LayoutTests: Created tests for HTMLUnknownElement interface.
https://bugs.webkit.org/show_bug.cgi?id=41841.

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-11
Reviewed by Adam Barth.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/html/unknown-tag.html: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
16:20 Changeset [92889] by andersca@apple.com

Add a FIXME.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):

16:19 Changeset [92888] by leviw@chromium.org

Remove dead code: borderInnerRect
https://bugs.webkit.org/show_bug.cgi?id=66087

Reviewed by Adam Barth.

Removing an old and currently unused function: RenderObject::borderInnerRect.

No new tests since I'm just pruning dead code.

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
16:18 Changeset [92887] by andersca@apple.com

Initialize threading before running any tests
https://bugs.webkit.org/show_bug.cgi?id=66112

Reviewed by Adam Barth.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):

15:56 Changeset [92886] by abarth@webkit.org

Add unexpected-passes.html to TestFailures for marking tests as passing
https://bugs.webkit.org/show_bug.cgi?id=66102

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
    • Move some code into the library so it can be shared.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
    • Add round-trip unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
    • I'm not entirely sure this feature should remain a separate HTML file, but it seemed better than cluttering up the main HTML file with too much extra stuff.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
    • The gardening server couldn't handle adding PASS expectations. Now it can.
15:48 Changeset [92885] by abarth@webkit.org

pfeldman says we need to rebaseline this test. The massively complex
baseline fallback graph confused him when he created a platform/mac
fallback.

  • platform/chromium-win/inspector/debugger: Added.
  • platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Added.
15:29 Changeset [92884] by simon.fraser@apple.com

Avoid adding the visible wash layer twice
https://bugs.webkit.org/show_bug.cgi?id=66098

Reviewed by Chris Marrin.

Fix two issues; only create a m_visibleTileWashLayer if we don't have one
already, and avoid adding multiple m_visibleTileWashLayers to the sublayers
array when flipping between tiled and non-tiled.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

15:02 Changeset [92883] by commit-queue@webkit.org

The PageSerializer should always use absolute URL
https://bugs.webkit.org/show_bug.cgi?id=66006

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-11
Reviewed by Adam Barth.

Page serializer resolves every URL for storing the resources.
The MarkupAccumulator used there should use the same rules in order to
create a valid file.

No new tests because the test infrastructure for this
does not exist with layout tests and the Chromium unit test for
the serializer are disabled.

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):

14:59 Changeset [92882] by eric@webkit.org

NRWT has wrong fallback order for Mac now that Lion exists
https://bugs.webkit.org/show_bug.cgi?id=66093

Reviewed by Adam Barth.

ORWT used a different system for fallback orders than NRWT did.
I moved win.py to match ORWT fallback orders in bug 64486.
This bug moves mac.py to match ORWT fallback order
and adds 'lion' as a supported OS version.

Because ChromiumMac shares OS version detection code with AppleMac
this also added support for 'lion' to chromium mac. Hopefully that's a good thing.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
14:56 Changeset [92881] by andersca@apple.com

Move some Snow Leopard test results to the right place.

  • platform/mac-snowleopard/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
  • platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt: Removed.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Removed.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
  • platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
  • platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
14:39 Changeset [92880] by commit-queue@webkit.org

nullptr can't be used for PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=66024

Patch by James Robinson <jamesr@chromium.org> on 2011-08-11
Reviewed by Anders Carlsson.

  • wtf/PassRefPtr.h:

(WTF::PassRefPtr::PassRefPtr):

14:29 Changeset [92879] by abarth@webkit.org

Record that these tests are now passing in these configurations.

  • platform/chromium/test_expectations.txt:
14:20 Changeset [92878] by pfeldman@chromium.org

2011-08-11 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector's scripts-panel test baseline for mac added.

  • platform/mac/inspector/debugger/scripts-panel-expected.txt: Added.
14:08 Changeset [92877] by jamesr@google.com

Merge 92867 - [Chromium] Temporarily disable layer anti-aliasing on ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=65922

Patch by David Reveman <reveman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::draw):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7629002

14:08 Changeset [92876] by abarth@webkit.org

Update test results now that we use absolute URLs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
13:59 Changeset [92875] by abarth@webkit.org

garden-o-matic should be able to determine when tests unexpectedly pass
https://bugs.webkit.org/show_bug.cgi?id=66092

Reviewed by Dimitri Glazkov.

This patch just contains the library methods for extracting this
information. I'll add some UI in a subsequent patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
13:43 Changeset [92874] by enne@google.com

Enable fast path scrolling for composited iframes
https://bugs.webkit.org/show_bug.cgi?id=65056

Reviewed by James Robinson.

Source/WebCore:

iframes with composited layers for content should be able to do fast
path scrolling because they draw into their own backing. To enable
this, useSlowRepaints is modified to return true only for the cases
that apply to composited layers. The fast path scrolling function is
modified to send the invalidation to the backing itself rather than to
the window.

Renamed a number of "slow repaint" functions to be the more accurate
"cannot blit to window" as it will not always force slow path
scrolling.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::setCannotBlitToWindow):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):

  • page/FrameView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::cannotBlitToWindow):

  • rendering/RenderLayer.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

Added test of iframe overlapping another iframe. Mac gets its own
incorrect expectations due to bug 63282.

  • compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • compositing/iframes/overlapped-iframe-iframe.html: Added.
  • platform/chromium-gpu/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
12:44 Changeset [92873] by enne@google.com

Support creating compositing layers for scrollable frames and iframes
https://bugs.webkit.org/show_bug.cgi?id=55257

Reviewed by James Robinson.

Source/WebCore:

When force compositing mode is turned on, iframes with overflow will
become composited (in order to enable faster scrolling).

This patch was originally by Daniel Sievers <sievers@chromium.org>.

Tests: platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html

platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html: Added.
  • platform/chromium/compositing/force-compositing-mode/resources/subframe-big.html: Added.
  • platform/chromium/compositing/force-compositing-mode/resources/subframe-small.html: Added.
12:24 Changeset [92872] by commit-queue@webkit.org

Remove the temporary workaround added by http://trac.webkit.org/changeset/51338
https://bugs.webkit.org/show_bug.cgi?id=65908

Patch by Marja Hölttä <marja@chromium.org> on 2011-08-11
Reviewed by Adam Barth.

SecurityOrigin for a file URL returns "file://", and
SecurityOrigin::createFromString("file://") creates a unique (null)
security origin (because "file://" is first canonicalized to "file:///"
and that is a directory). This means the conversion SecurityOrigin ->
string -> SecurityOrigin doens't give back the same SecurityOrigin in
case of file URLs.

WebStorageNamespaceImpl::createStorageArea contains a workaround which
changes the string "file://" into "file:///a" before giving it to
SecurityOrigin::createFromString.

If SecurityOrigin::m_enforceFilePathSeparation is true, then
SecurityOrigin::toString() returns "null" for file URLs, and this
problem does not exist, and the workaround code is not ran.

This patch removes the workaround.

  • src/WebStorageNamespaceImpl.cpp:

(WebKit::WebStorageNamespaceImpl::createStorageArea):

12:22 Changeset [92871] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=65944
Replace QuotesData::operator==() with QuotesData::equal(const QuotesData*
, const QuotesData*) because QuotesData::operator==() were using non-standard
C++ code that is not supported by all compilers.

Patch by Yong Li <yoli@rim.com> on 2011-08-11
Reviewed by Alexey Proskuryakov.

No new tests because some existing test cases can show the issue,
for example, fast/css/content/content-quotes-01.html.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::styleDidChange):

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::equal):

  • rendering/style/QuotesData.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setQuotes):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):

11:51 WebKit Team edited by kenneth@webkit.org
(diff)
11:08 Changeset [92870] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66075

Source/WebCore:

Turn on regions and exclusions by default. Fix one stray ifdef that I missed.

Reviewed by James Robinson.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

LayoutTests:

Fix the broken test result for layer dumping, since at the moment flow threads don't collect
layers (this will be fixed eventually).

Unskip the regions and exclusions tests now that they are turned on by default.

Reviewed by James Robinson.

  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • platform/mac/Skipped:
10:57 Changeset [92869] by kbalazs@webkit.org

[Qt] fast/dom/HTMLDocument/hasFocus.html fails
https://bugs.webkit.org/show_bug.cgi?id=66076

Unreviewed gardening.

  • platform/qt/Skipped:
10:29 Changeset [92868] by commit-queue@webkit.org

Removed unused variable in StackBounds::initialize() to resolve
compiler warning when building on QNX.
https://bugs.webkit.org/show_bug.cgi?id=66072

Patch by Daniel Bates <dbates@rim.com> on 2011-08-11
Reviewed by Antonio Gomes.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

10:23 Changeset [92867] by commit-queue@webkit.org

[Chromium] Temporarily disable layer anti-aliasing on ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=65922

Patch by David Reveman <reveman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::draw):

10:19 Changeset [92866] by abarth@webkit.org

Merge expectations to mute flakiness.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [92865] by lforschler@apple.com

Versioning.

10:08 Changeset [92864] by lforschler@apple.com

New tag.

10:07 Changeset [92863] by lforschler@apple.com

Versioning.

10:05 Changeset [92862] by lforschler@apple.com

delete tag.

09:56 Changeset [92861] by dglazkov@chromium.org

New expectation entries should be placed next to existing ones.
https://bugs.webkit.org/show_bug.cgi?id=66066

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,

which is computed as the last found reference to the same test.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
09:50 Changeset [92860] by lforschler@apple.com

New tag.

09:48 Changeset [92859] by commit-queue@webkit.org

Implementation of monotonically increasing clock on GTK
https://bugs.webkit.org/show_bug.cgi?id=62175

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-08-11
Reviewed by Martin Robinson.

  • wtf/CurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):
The default implementation of monotonicallyIncreasingTime only
guarantees the result to be non-decreasing.
If the system time is changed to past then default implementation will
still fail and WebCore timers will not fire.

09:47 Changeset [92858] by qi.2.zhang@nokia.com

[Qt] fast/dom/HTMLDocument/hasFocus.html failed
https://bugs.webkit.org/show_bug.cgi?id=62126

This test case passed under the latest revision, remove it from skip list.

Reviewed by Chang Shu.

  • platform/qt/Skipped:
09:44 Changeset [92857] by dglazkov@chromium.org

Unreviewed, rolling out r92847.
http://trac.webkit.org/changeset/92847
https://bugs.webkit.org/show_bug.cgi?id=65986

Broke check-webkit-style

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
09:37 Changeset [92856] by commit-queue@webkit.org

[Qt] PageSerializer is specific to MHTML, we should not compile it
https://bugs.webkit.org/show_bug.cgi?id=66054

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-11
Reviewed by Noam Rosenthal.

PageSerializer is specific to MHTML. Do not build PageSerializer unless MHTML is enabled.

  • WebCore.pro:
09:36 Changeset [92855] by caseq@chromium.org

Web Inspector: [refactoring] make tabbed pane a view
https://bugs.webkit.org/show_bug.cgi?id=66060

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):
(WebInspector.NetworkItemView.prototype.show):
(WebInspector.NetworkItemView.prototype._selectTab.get if):
(WebInspector.NetworkItemView.prototype._selectTab):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):

  • inspector/front-end/inspector.html:
08:57 Changeset [92854] by xan@webkit.org

[GTK] create pot files in builddir, not (read only) srcdir
https://bugs.webkit.org/show_bug.cgi?id=66059

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: write and read pot files from the build dir.
08:53 Changeset [92853] by kov@webkit.org

Add the javascript core dynamic library for gtk-doc's introspection helper.

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-08-11
Reviewed by Xan Lopez.

  • docs/GNUmakefile.am:
08:46 Changeset [92852] by xan@webkit.org

2011-08-11 Xan Lopez <xlopez@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.2 release

Reviewed by Gustavo Noronha.

  • configure.ac: update for release.

Source/WebKit/gtk:

2011-08-11 Xan Lopez <xlopez@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.2 release

Reviewed by Gustavo Noronha.

  • NEWS: update for release.
08:33 Changeset [92851] by kenneth@webkit.org

[Qt/WK2] Add initial support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=65975

Reviewed by Benjamin Poulain.

Redirect the viewport arguments through to the view.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didReceiveViewportArguments):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::geometryChanged):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setViewportArguments):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::updateViewportState):
(WebKit::TouchViewInterface::didReceiveViewportArguments):

  • UIProcess/qt/TouchViewInterface.h:

(WebKit::TouchViewInterface::ViewportState::ViewportState):

  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
08:24 Changeset [92850] by caseq@chromium.org

Web Inspector: source frame popover simetimes pops up after user switches from Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=66057

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js: remove popover timer when removing popover.

(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._hidePopup):

07:59 Changeset [92849] by vsevik@chromium.org

Web Inspector: Scripts panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66048

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.get currentSearchResultIndex):

07:43 Changeset [92848] by xan@webkit.org

2011-08-11 Xan Lopez <xlopez@igalia.com>

[GTK] Add another missing file to GNUmakefile

Reviewed by Gustavo Noronha.

  • GNUmakefile.list.am:
07:40 Changeset [92847] by commit-queue@webkit.org

[Qt] autotests shouldn't require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=65986

Remove the include rules from the style-check for Qt tests.
Since for the most part it's just a matter of using the
API provided by QtWebKit, enforcing the WebCore set of rules
only seems to make sense in the case of MIMESniffing.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-11
Reviewed by Benjamin Poulain.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
07:34 Changeset [92846] by xan@webkit.org

2011-08-11 Xan Lopez <xlopez@igalia.com>

[GTK] Add missing files to GNUMakefile

Reviewed by Gustavo Noronha.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
07:15 Changeset [92845] by andreip@google.com

2011-08-11 Andrei Popescu <andreip@google.com>

[Chromium] Rebaseline these tests on Leopard.

Unreviewed gardening.

  • platform/chromium-mac-leopard/editing/pasteboard/paste-text-016-expected.png: Added
  • platform/chromium-mac-leopard/editing/spelling/inline_spelling_markers-expected.png: Added
07:02 Changeset [92844] by abecsi@webkit.org

WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

fast/encoding/mailto-always-utf-8.html needs eventSender
Move it to the common wk2 Skipped list from the qt-wk2.

Unreviewed gardening.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-11

  • platform/qt-wk2/Skipped:
  • platform/wk2/Skipped:
07:00 Changeset [92843] by yutak@chromium.org

WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=66047

Reviewed by Kent Tamura.

It's safe to use PassRefPtr<> in these functions because:

  • CrossThreadTask knows how to pass a RefPtr<> across threads, and
  • Call sites do not pass the pointers to anywhere else.

No change in functionality, thus no new tests.

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidSend):
(WebCore::workerContextDidGetBufferedAmount):
(WebCore::workerContextDidConnect):
(WebCore::workerContextDidReceiveMessage):
(WebCore::workerContextDidStartClosingHandshake):
(WebCore::workerContextDidClose):

06:59 Changeset [92842] by pfeldman@chromium.org

Web Inspector: [Mac] search as you type does not work with the new indent in the script selector.
https://bugs.webkit.org/show_bug.cgi?id=66039

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

  • inspector/front-end/inspector.css:

(select.status-bar-item):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
05:45 Changeset [92841] by alexis.menard@openbossa.org

Unreviewed build fix for Qt.

Make sure we build when Qt is namespaced.

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
05:44 Changeset [92840] by jeremy@chromium.org

Merge 92269 - [Chromium] Fix OOP font loading to work on 10.6.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=65543

In 10.6.6 the function used to get the unique ID for an NSFont in the
renderer was changed so it fails in the sandbox (it now tries to access
the on-disk font file). In order to work around this, we get the font
ID from the browser process.

To speed things up, we introduce 2 levels of caching in WebKit. A font
name cache where we can perform a quick lookup without the need for the
font id and a font id cache which we can only lookup in after getting
the unique ID from the browser process.

Reviewed by Kenneth Russell.

No new tests since this is not readily testable.

Source/WebCore:

  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/CrossProcessFontLoading.h:
  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

  • public/mac/WebSandboxSupport.h: Plumb font ID parameter through.
  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::loadFont): ditto.

TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/7618010

05:40 Changeset [92839] by ossy@webkit.org

[WK2] Implement waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42330

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-11
Reviewed by Csaba Osztrogonác.

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::navigationTypeToString):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::setCustomPolicyDelegate):
(WTR::LayoutTestController::waitForPolicyDelegate):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::isPolicyDelegateEnabled):
(WTR::LayoutTestController::isPolicyDelegatePermissive):

LayoutTests:

Unskip passing tests.

  • platform/qt-wk2/Skipped:
  • platform/wk2/Skipped:
05:20 Changeset [92838] by podivilov@chromium.org

Web Inspector: use source-file-replaced instead of source-file-changed event.
https://bugs.webkit.org/show_bug.cgi?id=65551

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-frame-count.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileReplaced):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.reload):

  • inspector/front-end/inspector.js:

(WebInspector._createPanels):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-file-expected.txt:
  • inspector/debugger/source-file.html:
  • inspector/debugger/source-frame-count-expected.txt: Added.
  • inspector/debugger/source-frame-count.html: Added.
  • platform/chromium/test_expectations.txt:
04:30 Changeset [92837] by andreip@google.com

2011-08-11 Andrei Popescu <andreip@google.com>

Master: Support CSS3 font feature properties
https://bugs.webkit.org/show_bug.cgi?id=63796

Unreviewed gardening.

css3/font-feature-settings-rendering.html is missing expectations. Looking at the
actual test output, it appears clearly wrong so we cannot rebaseline it either.
We'll therefore update the expectations file to mark this test as missing expected
results and update the bug to say it needs investigation and fixing.

  • platform/chromium/test_expectations.txt:
03:04 Changeset [92836] by reni@webkit.org

[Qt]Fix warnings after r92805.

Reviewed by Csaba Osztrogonác.

Control reached the end non-void functions.

  • src/compiler/ossource_posix.cpp:

(OS_AllocTLSIndex):
(OS_SetTLSValue):

02:34 Changeset [92835] by vsevik@chromium.org

Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
https://bugs.webkit.org/show_bug.cgi?id=66007

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.FrameTreeElement.prototype.resourceByURL):

02:24 Changeset [92834] by abecsi@webkit.org

[GTK] Fix the build after r92792.

Rubber-stamped by Csaba Osztrogonác.

No new tests needed.

  • GNUmakefile.list.am: add missing

RenderFlowThread.{cpp|h}
RenderRegion.{cpp|h}

01:59 Changeset [92833] by abarth@webkit.org

Rebaseline these tests, as requested by morrita.

  • platform/chromium-mac/editing/pasteboard/paste-text-016-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png: Added.
  • platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.png: Added.
01:54 Changeset [92832] by abarth@webkit.org

rebaseline-expectations should use the release bots, not the debug
bots. The debug bots don't all run all the tests. Also, delay
updating test_expectations a long as possible to avoid clearing out
lines that we'll need for other ports.

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
01:48 Changeset [92831] by ossy@webkit.org

[Qt] Enable WebGL by default for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=65998

disable failing tests after https://trac.webkit.org/changeset/92805

  • platform/qt/Skipped: Skip fast/canvas/webgl directory
01:45 Changeset [92830] by reni@webkit.org

[Qt] Fix WebGL on Windows after r92805
https://bugs.webkit.org/show_bug.cgi?id=66042

WEBGL is temporarly disabled, because it broked the bots.

  • features.pri:
01:18 Changeset [92829] by rniwa@webkit.org

Fix Snow Leopard expectation after r92518.

  • platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:
01:10 Changeset [92828] by abarth@webkit.org

Test how SpeechInputResultList behaves with not enough arguments
https://bugs.webkit.org/show_bug.cgi?id=65812

Reviewed by Sam Weinig.

SpeechInputResultList is only exposed via the x-webkit-speech
attribute, which means there is little compatibility risk in aligning
our too-few-arguments behavior with the specification. There's a
question about whether all these "fake array" objects should work
consistently, but we'll probably want the "fake array" objects we
create in the future to match the spec, so even if we're consistent
now, we'll end up not being consistent in the future.

  • fast/speech/speech-input-result-list-not-enough-arguments-expected.txt: Added.
  • fast/speech/speech-input-result-list-not-enough-arguments.html: Added.
00:56 Changeset [92827] by commit-queue@webkit.org

Web Inspector: do not evaluate watch expressions on load.
https://bugs.webkit.org/show_bug.cgi?id=66002

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-11
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype.hide):
(WebInspector.ScriptsPanel.prototype.reset):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.hide):
(WebInspector.WatchExpressionsSidebarPane.prototype.reset):
(WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshExpressionsIfNeeded):
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):

00:25 Changeset [92826] by reni@webkit.org

Build fix on Qt Windows 32-bit Release/Debug after r92805.

Unreviewed.

  • src/compiler/ossource_posix.cpp:

(OS_FreeTLSIndex):

08/10/11:

23:57 Changeset [92825] by rniwa@webkit.org

Skip tests added by r92769 on WebKit2 because TestRunner doesn't support
drag and drop by eventSender yet.

  • platform/wk2/Skipped:
23:40 Changeset [92824] by morrita@google.com

Unreviewed pixel expectations update. New expectations now have
bad grammar markers. (The settings has been enabled since r82159.)

  • platform/mac/editing/pasteboard/paste-text-016-expected.png:
  • platform/mac/editing/selection/move-by-character-005-expected.png:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
23:29 Changeset [92823] by rniwa@webkit.org

Copying can result in span around block elements on the clipboard
https://bugs.webkit.org/show_bug.cgi?id=34564

Reviewed by Tony Chang.

Source/WebCore:

Completely overhauled the way WebKit preserves style in copy and paste. Instead of wrapping the entire
serialized contents by a Apple style span, WebKit now adds inline style to the top level elements,
wrap top level text nodes by a style span.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::collapseTextDecorationProperties): Remove text-decoration property when the value
of -webkit-text-decorations-in-effect is none.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Since display: inline and float: none are now
added on copy, remove these properties on paste.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Takes Element* instead of StyledElement*.
(WebCore::EditingStyle::forceInline): Added.
(WebCore::getPropertiesNotIn): Remove properties only when the base style has them.

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::shouldApplyWrappingStyle): Added.
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Takes highestNodeToBeSerialized.
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendStyleNodeOpenTag and styleNodeCloseTag.
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Extracted from wrapWithStyleNode.
(WebCore::StyledMarkupAccumulator::styleNodeCloseTag): Ditto.
(WebCore::StyledMarkupAccumulator::appendText): Wraps text node with a style span if needed.
Set display: inline and float: none so that it won't be converted to a block on paste side.
(WebCore::StyledMarkupAccumulator::appendElement): Add wrapping style if appropriate; Remove any properties
that are overridden by default style and any style that may conflict with the computed style of node to
avoid modifying the appearance of the serialized nodes.
(WebCore::StyledMarkupAccumulator::serializeNodes): Compute wrapping style; copies of this style are
modified as needed when serializing top-level elements or text nodes. We call traverseNodesForSerialization
with NodeTraversalMode set to DoNotEmitString first to compute the highest node to be serialized. The second
call to the function actually serialize the nodes.
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Extracted from serializeNodes.
Outputs string only if NodeTraversalMode is set to EmitString.
(WebCore::createMarkup): No longer adds wrapping spans.

LayoutTests:

This patch overhauled the way we preserve styles when copying and pasting HTML contents. Many tests progressed
and lost wrapping spans while others are observing different markup on the clipboard as expected.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: span's style attribute now has

a trailing space.

  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: LightGray is now rgb(211, 211, 211).
  • editing/pasteboard/data-transfer-items-expected.txt: Different serialization.
  • editing/pasteboard/onpaste-text-html-expected.txt: Ditto.
  • editing/pasteboard/paste-4039777-fix-expected.txt: No longer nests ul erroneously or aligns the inner list

to the right.

  • editing/pasteboard/paste-code-in-pre-expected.txt: No longer produces erroneous wrapping span.
  • editing/pasteboard/paste-pre-001-expected.txt: Ditto.
  • editing/pasteboard/paste-pre-002-expected.txt: Ditto.
  • editing/pasteboard/paste-text-012-expected.txt: Ditto.
  • editing/pasteboard/paste-text-with-style-4-expected.txt: Ditto.
  • fast/events/ondrop-text-html-expected.txt: Different serialization.
  • platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Removed.
23:16 Changeset [92822] by rniwa@webkit.org

Skip a test added by r92769 on Windows port since drag and drop won't work well on Windows port.

  • platform/win/Skipped:
23:00 Changeset [92821] by rniwa@webkit.org

GTK and Qt rebaselines after r92792.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
22:15 Changeset [92820] by rniwa@webkit.org

r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
22:01 Changeset [92819] by tkent@chromium.org

Move <input type=date> tests to fast/forms/date/
https://bugs.webkit.org/show_bug.cgi?id=66029

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "date" part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-date.html: Removed.
  • fast/forms/date: Added.
  • fast/forms/date-input-visible-strings-expected.txt: Removed.
  • fast/forms/date-input-visible-strings.html: Removed.
  • fast/forms/date/ValidityState-rangeOverflow-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/date/ValidityState-rangeOverflow-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/date/ValidityState-rangeUnderflow-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/date/ValidityState-stepMismatch-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/date/ValidityState-stepMismatch-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/date/ValidityState-typeMismatch-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-date-expected.txt.
  • fast/forms/date/ValidityState-typeMismatch-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-date.js.
  • fast/forms/date/date-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/date/date-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/date/date-input-visible-strings-expected.txt: Copied from LayoutTests/fast/forms/date-input-visible-strings-expected.txt.
  • fast/forms/date/date-input-visible-strings.html: Copied from LayoutTests/fast/forms/date-input-visible-strings.html.
  • fast/forms/date/date-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/date/date-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/date/date-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/date/input-valueasdate-date-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-date-expected.txt.
  • fast/forms/date/input-valueasdate-date.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-date.js.
  • fast/forms/date/input-valueasnumber-date-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-date-expected.txt.
  • fast/forms/date/input-valueasnumber-date.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-date.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed "date" part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-date-expected.txt: Removed.
  • fast/forms/input-valueasdate-date.html: Removed.
  • fast/forms/input-valueasnumber-date-expected.txt: Removed.
  • fast/forms/input-valueasnumber-date.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "date" part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-date.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-date.js: Removed.
21:02 Changeset [92818] by abarth@webkit.org

Test how TouchList behaves with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=65815

Reviewed by Sam Weinig.

This API is very new and the compatibility cost of making this API
match the specification is minimal. We should align with the
specification and (future) implementations in other browsers by making
this argument required.

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js:
21:00 Changeset [92817] by abarth@webkit.org

Test how AudioBufferSourceNode reacts when given too few arguments
https://bugs.webkit.org/show_bug.cgi?id=65816

Reviewed by Sam Weinig.

The WebAudio API is extremely new. It has only been available as an
experimental API in a single browser. The compatibility cost of
tightening up these APIs is tiny and these APIs make very little sense
to call with too-few arguments.

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
20:58 Changeset [92816] by abarth@webkit.org

Add tests of optional arguments for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=65810

Reviewed by Sam Weinig.

Source/WebCore:

Geolocation's treatment of not-enough-arguments almost matches the
spec. getCurrentPosition and watchPosition work properly, but, because
they are custom, we should use the prettier form of the [Optional]
attribute.

Before this series of patches, clearWatch argument was optional, but
that doesn't match the spec or other browsers. Calling this function
with zero arguments is pretty non-sensical, so there shouldn't be much
compat risk to tightening up our behavior here. Matching other
browsers and the spec seems like the bigger win. If we run into compat
problems, we can re-evaluate this decision.

Test: fast/dom/Geolocation/not-enough-arguments.html

  • page/Geolocation.idl:

LayoutTests:

Test what happens when calling geolocation APIs with too few arguments.

  • fast/dom/Geolocation/not-enough-arguments-expected.txt: Added.
  • fast/dom/Geolocation/not-enough-arguments.html: Added.
19:27 Changeset [92815] by jchaffraix@webkit.org

2011-08-10 Julien Chaffraix <jchaffraix@webkit.org>

Unreviewed (4 liners - Chromium only).

Hack to remove the crash from: (properly solved on trunk)
https://bugs.webkit.org/show_bug.cgi?id=62884

This is one of Chromium's top most crashers and merging the fix from the bug (r89445)
did not help as it relies on other SVG changes being in. This change just
mitigates the crash until it naturely gets resolved when we roll WebKit revision
in Chromium.

  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont): Added 2 null-checks here.
18:56 Changeset [92814] by barraclough@apple.com

Merged JavaScriptCore & JavaScriptGlue from 92405 to 92804.

Reviewed by nobody.

../JavaScriptCore:

EXCEPT, Did not merge patches:

92437, 92523.

../JavaScriptGlue:

EXCEPT, Did not merge patches:

92437, 92523.

18:54 Changeset [92813] by andersca@apple.com

Skip some more tests on Lion.

  • platform/mac-lion/Skipped:
18:29 Changeset [92812] by timothy_horton@apple.com

SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
https://bugs.webkit.org/show_bug.cgi?id=66026

Reviewed by Rob Buis.

Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.

No new tests, as it depends on the enabled features.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

18:17 Changeset [92811] by jam@chromium.org

[chromium] Update WebScrollbar so that it works with overlay scrollbars on Lion
https://bugs.webkit.org/show_bug.cgi?id=66008

Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebScrollbar.h:
  • public/WebScrollbarClient.h:
  • src/ScrollbarGroup.cpp: Added.

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setLastMousePosition):
(WebKit::ScrollbarGroup::scrollSize):
(WebKit::ScrollbarGroup::scrollPosition):
(WebKit::ScrollbarGroup::setScrollOffset):
(WebKit::ScrollbarGroup::invalidateScrollbarRect):
(WebKit::ScrollbarGroup::invalidateScrollCornerRect):
(WebKit::ScrollbarGroup::isActive):
(WebKit::ScrollbarGroup::enclosingScrollableArea):
(WebKit::ScrollbarGroup::isScrollCornerVisible):
(WebKit::ScrollbarGroup::getTickmarks):
(WebKit::ScrollbarGroup::convertFromContainingViewToScrollbar):
(WebKit::ScrollbarGroup::horizontalScrollbar):
(WebKit::ScrollbarGroup::verticalScrollbar):
(WebKit::ScrollbarGroup::minimumScrollPosition):
(WebKit::ScrollbarGroup::maximumScrollPosition):
(WebKit::ScrollbarGroup::visibleHeight):
(WebKit::ScrollbarGroup::visibleWidth):
(WebKit::ScrollbarGroup::contentsSize):
(WebKit::ScrollbarGroup::overhangAmount):
(WebKit::ScrollbarGroup::currentMousePosition):
(WebKit::ScrollbarGroup::shouldSuspendScrollAnimations):
(WebKit::ScrollbarGroup::scrollbarStyleChanged):
(WebKit::ScrollbarGroup::isOnActivePage):
(WebKit::ScrollbarGroup::disconnectFromPage):

  • src/ScrollbarGroup.h: Added.

(WebKit::ScrollbarGroup::scrollCornerRect):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit::WebPluginContainerImpl::scrollbarGroup):
(WebKit::WebPluginContainerImpl::willStartLiveResize):
(WebKit::WebPluginContainerImpl::willEndLiveResize):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

  • src/WebPluginContainerImpl.h:
  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbar::createForPlugin):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::~WebScrollbarImpl):
(WebKit::WebScrollbarImpl::setScrollOffset):
(WebKit::WebScrollbarImpl::invalidateScrollbarRect):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::convertFromContainingViewToScrollbar):
(WebKit::WebScrollbarImpl::scrollbarStyleChanged):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseLeave):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):

  • src/WebScrollbarImpl.h:

(WebKit::WebScrollbarImpl::scrollOffset):
(WebKit::WebScrollbarImpl::scrollbar):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willStartLiveResize):
(WebKit::WebViewImpl::willEndLiveResize):

18:08 Changeset [92810] by ggaren@apple.com

Removed some incorrect code that was dead.

Reviewed by Oliver Hunt.

clearSingleTransition() wasn't resetting m_data. Luckily,
no one cares, because its caller was unused. Removed both.

  • runtime/Structure.cpp:
  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::~StructureTransitionTable):

18:02 Changeset [92809] by timothy_horton@apple.com

Crash when clicking an SVG <a> link to the local document
https://bugs.webkit.org/show_bug.cgi?id=66019
<rdar://problem/9933311>

Reviewed by Rob Buis.

Source/WebCore:

Check if the target element of an internal link is valid before
making use of it.

Test: svg/custom/click-internal-anchor-with-use-crash.xhtml

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add a test which programmatically clicks a link referring to "#",
and should crash between r89745 and this commit.

  • svg/custom/click-internal-anchor-with-use-crash-expected.txt: Added.
  • svg/custom/click-internal-anchor-with-use-crash.xhtml: Added.
17:54 Changeset [92808] by commit-queue@webkit.org

[EFL] Return from _ewk_view_smart_add if smart data can not be allocated
https://bugs.webkit.org/show_bug.cgi?id=65853

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

It prevents the crash while allocating a memory for view's smart data.
Others checking are needed for support single and tiled backing store.
As a result an empty window will be displayed.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_add):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_show):
(_ewk_view_smart_hide):

  • ewk/ewk_view_single.c:

(_ewk_view_single_smart_add):
(_ewk_view_single_smart_resize):

  • ewk/ewk_view_tiled.c:

(_ewk_view_tiled_smart_add):

17:50 Changeset [92807] by commit-queue@webkit.org

JSC should always throw when function arg list is too long
https://bugs.webkit.org/show_bug.cgi?id=65869

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-10
Reviewed by Oliver Hunt.

Previous change forgot to update some of the tests in fast/js/function-apply.html so we're doing it now.

  • fast/js/function-apply-expected.txt:
  • fast/js/script-tests/function-apply.js:
17:43 Changeset [92806] by commit-queue@webkit.org

WebViewImpl::selectionRange should return false if there is no selection
https://bugs.webkit.org/show_bug.cgi?id=66012

Patch by Varun Jain <varunjain@google.com> on 2011-08-10
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/src/WebViewImpl.cpp:
17:27 Changeset [92805] by noam.rosenthal@nokia.com

[Qt] Enable WebGL by default for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=65998

Reviewed by Benjamin Poulain.

Make ENABLE_WEBGL true by default when Qt is configured with OpenGL.

No new tests. Build change only.

  • features.pri:
17:17 Changeset [92804] by fpizlo@apple.com

REGRESSION(r92670-r92744): WebKit crashes when opening Gmail
https://bugs.webkit.org/show_bug.cgi?id=66010

Reviewed by Oliver Hunt.

Made sure that Construct calls use() on the this argument.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

17:00 Changeset [92803] by eric@webkit.org

new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486

Unreviewed.

Turns out that we've long had a subtle bug whereby if you didn't
already have DumpRenderTree built, we might end up running unsupported tests
because the DumpRenderTree --print-supported-features check would silently fail.

When I moved the call from using popen to using Executive.run_command, this silent
failure became noisy. (Breaking some bots.)

This re-orders our steps so that we always build DRT before collecting expectations,
as well as adds a warning message when DumpRenderTree can't be found.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:51 Changeset [92802] by dslomov@google.com

[Chromium] Decouple implementation of allowFileSystem, openFileSystem and allowDatabase from WebWorkerBase.
https://bugs.webkit.org/show_bug.cgi?id=65997.

This patch moves implementation of allowFileSystem, openFileSystem and allowDatabase from
WebWorkerBase to respectively LocalFileSystemChromium and DatabaseObserver,
parameterizing them with relevant data from WebWorker.

Reviewed by Jian Li.

  • src/DatabaseObserver.cpp: Move allowDatabase from WebWorkerBase and update the caller.

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::cancel):
(WebKit::AllowDatabaseMainThreadBridge::result):
(WebKit::AllowDatabaseMainThreadBridge::signalCompleted):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::AllowDatabaseMainThreadBridge::didComplete):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/LocalFileSystemChromium.cpp: Move allowFileSystem and openFileSystem from WebWorkerBase and update the caller.

(WebCore::openFileSystemHelper):

  • src/WebWorkerBase.cpp: Move allowFileSystem, openFileSystem and allowDatabase to LocalFileSystemChromium and DatabaseObserver resp.
  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::webView):

  • src/WorkerFileSystemCallbacksBridge.cpp: Generalized WorkerFileSystemCallbacksBridge to work on WorkerLoaderProxy, not on WebWorkerBase.

(WebKit::WorkerFileSystemCallbacksBridge::stop):
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h:

(WebKit::WorkerFileSystemCallbacksBridge::create):

16:19 Changeset [92801] by kevino@webkit.org

[wx] Unreviewed build fix. Do not build LocaleToScriptMappingICU.cpp for now as ICU on Leopard is too old to build this.

16:16 Changeset [92800] by eric@webkit.org

new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486

Unreviewed. Fix test-webkitpy under Python 2.5.

  • Scripts/webkitpy/layout_tests/port/win.py:
14:51 Changeset [92799] by commit-queue@webkit.org

[Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
https://bugs.webkit.org/show_bug.cgi?id=65875

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

For some reason, QWidget send fake mouse event on some platform, under certains conditions.

This causes mouse events to be sent twice in some cases. We work around the problem
by defining the first touch point to be a primary touch point (case which hit some
weird condition in QWidget, skipping the generation of fake mouse events).

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

14:48 Changeset [92798] by inferno@chromium.org

Source/WebCore: Check that we do not need layout before trying to dirty
m_originatingLine for our floats.
https://bugs.webkit.org/show_bug.cgi?id=65938

Reviewed by Dave Hyatt.

Test: fast/block/float/float-originating-line-deleted-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::clearFloats):

LayoutTests: Tests that we do not crash when trying to access a removed
m_originatingLine for a float.
https://bugs.webkit.org/show_bug.cgi?id=65938

Reviewed by Dave Hyatt.

  • fast/block/float/float-originating-line-deleted-crash-expected.txt: Added.
  • fast/block/float/float-originating-line-deleted-crash.html: Added.
14:42 Changeset [92797] by commit-queue@webkit.org

JSC should always throw when function arg list is too long
https://bugs.webkit.org/show_bug.cgi?id=65869

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-10
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Changed the behavior of the interpreter and JIT to throw an exception
when too many arguments are passed rather than truncating the list. Added
a new method to create a "Too many arguments." exception used by this
new functionality.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ExceptionHelpers.cpp:

(JSC::createTooManyParamsError):

  • runtime/ExceptionHelpers.h:

LayoutTests:

Changed the tests to make sure passing too many function arguments throws an exception
rather than truncating the arguments.

  • fast/js/function-apply-many-args-expected.txt:
  • fast/js/script-tests/function-apply-many-args.js:
14:03 Changeset [92796] by hyatt@apple.com

Add missing regions/exclusions-related files to EFL.

  • CMakeLists.txt:
13:59 Changeset [92795] by hyatt@apple.com

Add missing regions/exclusions-related files to Chromium.

  • WebCore.gypi:
13:54 Changeset [92794] by hyatt@apple.com

Fix Qt build bustage. Add missing regions/exclusions-related files to their project.

  • WebCore.pro:
13:39 Changeset [92793] by jamesr@google.com

Update chromium gpu baselines for r92255

  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium/test_expectations.txt:
13:36 Changeset [92792] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66004

Source/WebCore:

Remove ifdefs for CSS Exclusions (since the feature doesn't exist any longer and has morphed into positioned
floats instead). Go ahead and yank the ifdefs for CSS Regions also and just turn them on.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFromFlowContent):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator RegionOverflow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/CSSWrapShapes.cpp:
  • css/CSSWrapShapes.h:
  • css/SVGCSSValueKeywords.in:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderRegion):
(WebCore::RenderObject::isRenderFlowThread):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialWrapShape):
(WebCore::InheritedFlags::initialRegionOverflow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Removing the CSS Regions and Exclusions ifdefs.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Removing the CSS Regions and CSS Exclusions ifdefs.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
the code on by default.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/build-webkit:

LayoutTests:

Removing ifdefs for CSS Exclusions and CSS Regions. The code is now on by default, so the new CSS
properties are showing up in the computed style results.

Reviewed by Adam Roben.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:12 Changeset [92791] by inferno@chromium.org

Source/WebCore: Don't create html renderer for SVG <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=66000

Reviewed by David Hyatt.

Test: svg/text/glyphref-renderer-create-crash.html

  • svg/SVGGlyphRefElement.h:

LayoutTests: ASSERTION FAILED: curr->isRenderInline()
https://bugs.webkit.org/show_bug.cgi?id=66000

Reviewed by David Hyatt.

  • svg/text/glyphref-renderer-create-crash-expected.txt: Added.
  • svg/text/glyphref-renderer-create-crash.html: Added.
12:57 Changeset [92790] by commit-queue@webkit.org

[Chromium] plugins/mouse-events-fixedpos.html should pass on win/mac/linux
https://bugs.webkit.org/show_bug.cgi?id=65841

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-10
Reviewed by Tony Chang.

Add attribute windowPlugin="false" to the <embed> in this test to force the Chromium
Windows and Linux ports to load the test plugin in windowless mode. The plugin will
then receive events and can log them to the console as required by this test.

Also note, the Apple Mac/Win ports report 0 as the line number for all console.log()
messages, whereas, the Chromium ports report the actual line numbers, hence the need
for separate test results for Chromium.

  • platform/chromium-linux/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium-mac/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium-win/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium/test_expectations.txt: New expectations.
  • plugins/mouse-events-fixedpos.html: Add <embed> attribute windowPlugin="false".
12:53 Changeset [92789] by commit-queue@webkit.org

OpenTypeSanitizer in chromium gyp files is linked twice
https://bugs.webkit.org/show_bug.cgi?id=65927

Patch by Scott Graham <scottmg@google.com> on 2011-08-10
Reviewed by Adam Barth.

No new tests, should just build and link properly on all platforms.

  • WebCore.gyp/WebCore.gyp:
12:52 Changeset [92788] by oliver@apple.com

Make GC checks more aggressive in release builds
https://bugs.webkit.org/show_bug.cgi?id=66001

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):
(JSC::HandleHeap::isValidWeakNode):

Increase handle heap validation logic, and make some of
the crashes trigger in release builds as well as debug.

  • heap/HandleHeap.h:

(JSC::HandleHeap::allocate):
(JSC::HandleHeap::makeWeak):

Ditto

  • runtime/JSGlobalData.cpp:

(WTF::Recompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

Fix GC bugs found while testing this patch

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Fix GC bugs found while testing increased validation logic

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

  • bridge/objc/objc_instance.mm:
12:47 Changeset [92787] by commit-queue@webkit.org

[skia] Move calls to makeGrContextCurrent into clipPathAntiAliased from callers
https://bugs.webkit.org/show_bug.cgi?id=65733

This protects against callers of clipPathAntiAliased forgetting to call makeGrContextCurrent.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-10
Reviewed by James Robinson.

No change in functionality, no new tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clip):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

12:45 Changeset [92786] by commit-queue@webkit.org

MarkupAccumulator: make resolution of URLs implicit to appendQuotedURLAttributeValue()
https://bugs.webkit.org/show_bug.cgi?id=65990

Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-08-10
Reviewed by Ryosuke Niwa.

Instead of resolving the URLs in the call site of appendQuotedURLAttributeValue(),
the URL is now resolved if necessary in appendQuotedURLAttributeValue().

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):

  • editing/MarkupAccumulator.h:
12:42 Changeset [92785] by oliver@apple.com

JSEvaluteScript does not return the correct object when given JSONP data
https://bugs.webkit.org/show_bug.cgi?id=66003

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Make sure we propagate the result of the function call rather than the
argument.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

Tools:

Add a test case.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(testStringByEvaluatingJavaScriptFromString):

12:35 Changeset [92784] by eric@webkit.org

WIN: NRWT runs compositing tests on configurations that don't support compositing
https://bugs.webkit.org/show_bug.cgi?id=64472

Reviewed by Adam Barth.

I think the code was just wrong. It was never splitting the string
into list pieces before.
I've now tested the supported_features code and theoretically it
should now work with Windows DRT.

I also made the list-lookup functions always return lists, to make
it possible to clean up the list-transform code in the future
(I opted not to do that cleanup in this patch, but at least now
both types of feature lookup functions match return types.)

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:24 Changeset [92783] by bashi@chromium.org

[Chromium] Implement text shaping with font-feature-settings on Linux
https://bugs.webkit.org/show_bug.cgi?id=65903

Source/WebCore:

  • Modifies Font::codePath() to return Complex when there is font feature settings CSS property.
  • Implements OpenType advanced typography feature using Harfbuzz on Chromium Linux port.

Reviewed by Adam Barth.

Test: css3/font-feature-settings-rendering.html

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): Returns Complex when fontFeatureSettings exists.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::setupFontFeatures): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Calls setupFontFeatures().

LayoutTests:

Adds a rendering test for -webkit-font-feature-settings.
This tests disabled for now expect for chromium-linux port.
FeatureTest.ttf is created from scratch by using FontForge.

Reviewed by Adam Barth.

  • css3/font-feature-settings-rendering.html: Added.
  • css3/resources/FeatureTest.ttf: Added.
  • platform/chromium-linux/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-linux/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Skips css3/font-feature-settings-rendering.html.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
12:13 Changeset [92782] by tonyg@chromium.org

[chromium] Notify MemoryCache of decoded data access
https://bugs.webkit.org/show_bug.cgi?id=65859

Reviewed by James Robinson.

This causes us to call CachedImage::didDraw() which calls CachedResource::didAccessDecodedData()
which updates the LRU for decoded image data and potentially prunes the cache. This is already done
by almost all of the other ports.

The decoded bitmaps obviously use quite a bit of memory, so pruning them when necessary is important.
In my tests, this saves several MB on many popular web pages.

No new tests because no observable difference in functionality.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

11:45 Changeset [92781] by vsevik@chromium.org

Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend.
https://bugs.webkit.org/show_bug.cgi?id=65929

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/network/network-shared-worker.html

http/tests/inspector/network/network-worker.html

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didReceiveScriptResponse):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/Resource.js:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::didReceiveResponse):

  • workers/Worker.cpp:

(WebCore::Worker::didReceiveResponse):

  • workers/Worker.h:
  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didReceiveResponse):

  • workers/WorkerScriptLoaderClient.h:

(WebCore::WorkerScriptLoaderClient::didReceiveResponse):

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::didReceiveResponse):

LayoutTests:

  • http/tests/inspector/network/network-shared-worker-expected.txt: Added.
  • http/tests/inspector/network/network-shared-worker.html: Added.
  • http/tests/inspector/network/network-worker-expected.txt: Added.
  • http/tests/inspector/network/network-worker.html: Added.
  • http/tests/inspector/network/resources/shared-worker.js: Added.

(onconnect):

  • http/tests/inspector/network/resources/worker.js: Added.
  • platform/chromium/test_expectations.txt:
11:41 Changeset [92780] by vsevik@chromium.org

Web Inspector: [Network] Filtering by stylesheet does not update the # reqs, filesizes.
https://bugs.webkit.org/show_bug.cgi?id=65515

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateFilter):

11:37 Changeset [92779] by eric@webkit.org

Clean up ChromiumDriver a little
https://bugs.webkit.org/show_bug.cgi?id=65995

Unreviewed.

Fix NRWT for chromium. Silly python.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:30 Changeset [92778] by ap@apple.com

Accidentally commented out an assertion in BackingStore::incorporateUpdate
https://bugs.webkit.org/show_bug.cgi?id=65989

Reviewed by Anders Carlsson.

I couldn't get this assertion to fire in quick testing, let's bring it back.

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::incorporateUpdate):
10:58 Changeset [92777] by eric@webkit.org

Clean up ChromiumDriver a little
https://bugs.webkit.org/show_bug.cgi?id=65995

Reviewed by Adam Barth.

  • We no longer support threading, so remove threading specific code.
  • Add FIXMEs about using ServerProcess instead.
  • Condense option-mapping if-cascade into a for loop.
  • Unindent long if blocks by using early return.
  • Unwrap lines which are needlessly wrapped.

There should be no functional changes here, just code cleanup/dead-code removal.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:56 Changeset [92776] by vsevik@chromium.org

Web Inspector: console messages markers are lost in Resources panel after page reload
https://bugs.webkit.org/show_bug.cgi?id=60701

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-errors-reload.html

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessage):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessagesToResource):
(WebInspector.ResourceTreeModel.prototype._addConsoleMessageToResource):
(WebInspector.ResourceTreeModel.prototype._consoleCleared):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-errors-reload-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html: Added.
10:08 Changeset [92775] by dglazkov@chromium.org

Unmuddle construction options for TestConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=65988

The TestConfiguration instance is now constructed only using actual values.
Port-based construction is split into a "from_port" class method.

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/base.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
09:35 Changeset [92774] by abarth@webkit.org

Update expectations for this test. It's just a minor flake.

  • platform/chromium/test_expectations.txt:
09:27 Changeset [92773] by commit-queue@webkit.org

Add device specific settings to support viewport computing
https://bugs.webkit.org/show_bug.cgi?id=65984

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by Zalan Bujtas.

Added settings for device size, dpi and layout fallback width
to support viewport computing.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setLayoutFallbackWidth):
(WebCore::Settings::layoutFallbackWidth):
(WebCore::Settings::setDeviceWidth):
(WebCore::Settings::deviceWidth):
(WebCore::Settings::setDeviceHeight):
(WebCore::Settings::deviceHeight):
(WebCore::Settings::setDeviceDPI):
(WebCore::Settings::deviceDPI):

Source/WebKit2:

Expose new viewport related WebCore settings to WebKit2.

  • Shared/WebPreferencesStore.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

08:49 Changeset [92772] by eric@webkit.org

Leaks bot shows python logging prefixes as part of summary display
https://bugs.webkit.org/show_bug.cgi?id=65931

Reviewed by Adam Barth.

The big part of this change is adding a unittesting system for
master.cfg, so mere-mortals can make changes to build.webkit.org
with greatly-reduced risk of breaking the world.

Turns out that in typing up my trival logging fix I made 2 typos,
so hopefully the hour spent getting master.cfg to load was worth it. :)

I also tried to make mastercfg_unittest run as part of test-webkitpy
but right now test-webkitpy requires that unittest files be located in
a module-name-compatible directory. 'build.webkit.org-config' is not
a valid module name.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
    • Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix by using a new _strip_python_logging_prefix function.
    • Also fixed this function to file to work with a more modern simplejson version (which returns unicode objects instead of str objects) and filed a related bug with buildbot.net due to their handling of unicode builder names.
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
    • BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
    • The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
  • Scripts/webkitpy/thirdparty/init.py:
    • Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
08:43 Changeset [92771] by commit-queue@webkit.org

[GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
https://bugs.webkit.org/show_bug.cgi?id=65985

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-08-10
Reviewed by Xan Lopez.

  • webkit/webkitwebview.cpp:
08:34 Changeset [92770] by dglazkov@chromium.org

garden-o-matic should extrapolate failures given a set of known results
https://bugs.webkit.org/show_bug.cgi?id=65882

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
  • Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,

adjusted all call sites.

  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that

makes wider net for specific failures.

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
08:27 Changeset [92769] by commit-queue@webkit.org

Unify the way we generate HTML for an image in the Clipboard
https://bugs.webkit.org/show_bug.cgi?id=58043

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

Unify the way we generate the markup when dragging and image.

Previously, the code was using the special function imageToMarkup() that was
spread from the Chromium port.
That function ignores some edge cases so this patch replace it by the
more generic MarkupAccumulator (which is also used by the other pasteboard
actions).

The MarkupAccumulator was modified because following r61178, the local filepath
are treated differently (the enum was changed to make this behavior
explicit).

Tests: fast/drag-and-drop/drag-and-drop-image-contenteditable.html

fast/drag-and-drop/drag-and-drop-inputimage-contenteditable.html
fast/drag-and-drop/drag-and-drop-objectimage-contenteditable.html

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::resolveURLIfNeeded):
(WebCore::MarkupAccumulator::appendAttribute):

  • editing/MarkupAccumulator.h:
  • editing/markup.cpp:
  • editing/markup.h:
  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeRange):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::declareAndWriteDragImage):
(WebCore::ClipboardGtk::writeRange):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::markup):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):

  • platform/haiku/PasteboardHaiku.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::declareAndWriteDragImage):
(WebCore::ClipboardQt::writeRange):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::declareAndWriteDragImage):

LayoutTests:

Add 3 tests for dragging an image-like element to an editable area.

  • editing/pasteboard/drag-and-drop-image-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-image-contenteditable.html: Added.
  • editing/pasteboard/drag-and-drop-inputimage-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-inputimage-contenteditable.html: Added.
  • editing/pasteboard/drag-and-drop-objectimage-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-objectimage-contenteditable.html: Added.
  • platform/qt/Skipped: Qt does not have support for testing drag and drop.
07:37 Changeset [92768] by pfeldman@chromium.org

Web Inspector: auto-completion for string literals doesn't work
https://bugs.webkit.org/show_bug.cgi?id=65701

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-10
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresenationCallFrame.prototype.evaluate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt:
  • inspector/debugger/debugger-completions-on-call-frame.html:
07:06 Changeset [92767] by caseq@chromium.org

2011-08-10 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Rolled DEPS 95813:96009 to pick data url timing fix.

  • DEPS:
07:01 Changeset [92766] by pfeldman@chromium.org

Web Inspector: CSS editing file containing tabs leads to the whole file change in revision history.
https://bugs.webkit.org/show_bug.cgi?id=65959

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.prototype._innerSetText):

LayoutTests:

  • inspector/editor/text-editor-model-replace-tabs-expected.txt: Removed.
  • inspector/editor/text-editor-model-replace-tabs.html: Removed.
06:41 Changeset [92765] by pfeldman@chromium.org

Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .dimmed):

LayoutTests:

  • inspector/debugger/debugger-expand-scope-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Removed.
06:36 Changeset [92764] by apavlov@chromium.org

Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
https://bugs.webkit.org/show_bug.cgi?id=65918

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-commit-editing.html:
04:53 Changeset [92763] by commit-queue@webkit.org

[EFL] API methods check NULL and return proper value.
https://bugs.webkit.org/show_bug.cgi?id=65844

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

Check NULL before access to the smart and private data of the view object
and return the proper value if error occurred.

  • ewk/ewk_view.cpp:

(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):

  • ewk/ewk_view.h:
03:24 Changeset [92762] by tkent@chromium.org

Move <input type=datetime> tests to fast/forms/datetime/
https://bugs.webkit.org/show_bug.cgi?id=65970

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "datetime" part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-datetime.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed "datetime" part.
  • fast/forms/date-input-visible-strings.html: ditto.
  • fast/forms/datetime: Added.
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/datetime/ValidityState-stepMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/datetime/ValidityState-stepMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetime-expected.txt.
  • fast/forms/datetime/ValidityState-typeMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetime.js.
  • fast/forms/datetime/datetime-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/datetime/datetime-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/datetime/datetime-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/datetime/datetime-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/datetime/datetime-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/datetime/datetime-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/datetime/input-valueasdate-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetime-expected.txt.
  • fast/forms/datetime/input-valueasdate-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetime.js.
  • fast/forms/datetime/input-valueasnumber-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetime-expected.txt.
  • fast/forms/datetime/input-valueasnumber-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetime.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed "datetime" part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-datetime-expected.txt: Removed.
  • fast/forms/input-valueasdate-datetime.html: Removed.
  • fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
  • fast/forms/input-valueasnumber-datetime.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "datetime" part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed "datetime" part.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-datetime.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-datetime.js: Removed.
02:59 Changeset [92761] by ossy@webkit.org

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it isn't Qt 4.8 specific bug.
  • platform/qt/Skipped: Skip http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Update to the correct results.
  • platform/qt/test_expectations.txt: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
02:23 Changeset [92760] by caseq@chromium.org

2011-08-10 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix.

  • inspector/network-status-non-http-expected.txt:
  • inspector/network-status-non-http.html:
02:19 Changeset [92759] by yutak@chromium.org

WebSocket: Add binaryType attribute
https://bugs.webkit.org/show_bug.cgi?id=65967

Reviewed by Kent Tamura.

Source/WebCore:

Add a new attribute "binaryType" to WebSocket. It controls the data type of MessageEvent
for WebSocket's binary frames.

Tests: http/tests/websocket/tests/hixie76/undefined-attributes.html

http/tests/websocket/tests/hybi/binary-type.html

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

LayoutTests:

  • http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/undefined-attributes.html: Added.
  • http/tests/websocket/tests/hybi/binary-type-expected.txt: Added.
  • http/tests/websocket/tests/hybi/binary-type.html: Added.
02:09 Changeset [92758] by commit-queue@webkit.org

[EFL] Remove unused local variable from _ewk_tiled_backing_store_item_process_idler_cb.
https://bugs.webkit.org/show_bug.cgi?id=65846

As Ewk_Tiled_Backing_Store_Item *it is declared as local variable, but it's never referenced anywhere,
it is better to be removed from _ewk_tiled_backing_store_item_process_idler_cb.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_item_process_idler_cb):

02:07 Changeset [92757] by yutak@chromium.org

WebSocket: Accept multiple subprotocols
https://bugs.webkit.org/show_bug.cgi?id=65247

Reviewed by Kent Tamura.

Source/WebCore:

WebSocket constructor should accept an array of subprotocols if hybi-10 protocol is chosen.

Tests: http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html

http/tests/websocket/tests/hybi/invalid-subprotocols.html
http/tests/websocket/tests/hybi/multiple-subprotocols.html
http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):
If the second argument of WebSocket constructor is an array, build a Vector<String> and
pass it to WebSocket::connect().

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
Ditto.

  • websockets/WebSocket.cpp:

(WebCore::isValidProtocolCharacter): Added.
(WebCore::isValidProtocolString): Added.
(WebCore::isValidProtocolStringHixie76): Renamed from isValidProtocolString.
(WebCore::joinStrings):
(WebCore::WebSocket::connect):
If an array is provided as a subprotocol, and if hixie-76 is used for this connection, it
must be converted to a string in the same manner as JavaScript's Array.toString() in order
to keep compatibility.

  • websockets/WebSocket.h:

Removed m_protocol because it was not used at all.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::disconnect):
WebSocketChannel may be released before connect() is called, thus m_handshake may be null.

LayoutTests:

Add tests to check whether WebSocket accepts multiple subprotocols in constructor.

  • http/tests/websocket/tests/hybi/accept-first-subprotocol_wsh.py: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt.
  • http/tests/websocket/tests/hybi/multiple-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space.html:

Removed because hybi-10 does not allow subprotocols containing a space.

  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js: Added.

(ws.onopen):
(ws.onmessage):
(ws.onclose):

  • http/tests/websocket/tests/hybi/workers/resources/protocol-test_wsh.py: Copied from http/tests/websocket/tests/hybi/protocol-test_wsh.py.
01:44 Changeset [92756] by commit-queue@webkit.org

[Chromium] plugins/mouse-events.html should pass on the mac.
https://bugs.webkit.org/show_bug.cgi?id=65957

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-10
Reviewed by Kent Tamura.

Cocoa plugins do not generate adjustCursorEvents. Rebaseline this test result for the
chromium Mac port. Note the WebKit Mac/Win ports report 0 for the line number for all
console.log() events. The Chromium port reports the actual line number, and hence the
need for separate test results for Chromium. Following bug 61721, this test now runs,
and passes on all the Chromium ports. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 11517.

  • platform/chromium-mac/plugins/mouse-events-expected.txt:
  • platform/chromium/test_expectations.txt:
01:25 Changeset [92755] by caseq@chromium.org

2011-08-10 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: Network panel always displays file:// resources as "(pending)"
https://bugs.webkit.org/show_bug.cgi?id=65784

Reviewed by Pavel Feldman.

Test: inspector/network-status-non-http.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isHttpFamily):

2011-08-10 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: Network panel always displays file:// resources as "(pending)"
https://bugs.webkit.org/show_bug.cgi?id=65784

Reviewed by Pavel Feldman.

  • inspector/network-status-non-http-expected.txt: Added.
  • inspector/network-status-non-http.html: Added.
01:06 Changeset [92754] by tkent@chromium.org

Move <input type=datetime-local> tests to fast/forms/datetimelocal/
https://bugs.webkit.org/show_bug.cgi?id=65958

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed datetime-local part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-datetimelocal.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed datetime-local and time parts.
  • fast/forms/date-input-visible-strings.html: ditto.
  • fast/forms/datetimelocal: Added.
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js.
  • fast/forms/datetimelocal/datetimelocal-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/datetimelocal/input-valueasdate-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/input-valueasdate-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetimelocal.js.
  • fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetimelocal.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed datetime-local part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-datetimelocal-expected.txt: Removed.
  • fast/forms/input-valueasdate-datetimelocal.html: Removed.
  • fast/forms/input-valueasnumber-datetimelocal-expected.txt: Removed.
  • fast/forms/input-valueasnumber-datetimelocal.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed datetime-local part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed datetime-local part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed datetime-local part.
  • fast/forms/script-tests/input-type-change3.js: Removed datetime-local part.
  • fast/forms/script-tests/input-valueasdate-datetimelocal.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Removed.
00:39 Changeset [92753] by abarth@webkit.org

Updated results after http://trac.webkit.org/changeset/92744.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png:
00:36 Changeset [92752] by abarth@webkit.org

The URL we were computing for retrieving baselines was missing a slash
character because our mocks had an extra slash character. I've
corrected both the code and the mock.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
00:35 Changeset [92751] by commit-queue@webkit.org

[Chromium] Name an enum used in some template arguments.
https://bugs.webkit.org/show_bug.cgi?id=65953

Patch by Peter Kasting <pkasting@google.com> on 2011-08-10
Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
00:06 Changeset [92750] by fpizlo@apple.com

DFG JIT heap prediction causes regressions when combined with
aggressive integer prediction
https://bugs.webkit.org/show_bug.cgi?id=65954

Reviewed by Gavin Barraclough.

Disabled heap prediction, but did not remove the capability.
This improves V8 crypto performance by 20%.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

08/09/11:

22:35 Changeset [92749] by macpherson@chromium.org

Use setFontDescription helper to set m_fontDirty.
https://bugs.webkit.org/show_bug.cgi?id=65956

Reviewed by Dan Bernstein.

No new tests / trivial cleanup.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

22:28 Changeset [92748] by abarth@webkit.org

Move the quote mark to the right place.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
21:51 Changeset [92747] by dominicc@chromium.org

[V8] The prototype property of DOM constructors should be read-only.
https://bugs.webkit.org/show_bug.cgi?id=39655

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/prototype-property.html

  • bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip test for prototypes.
21:43 Changeset [92746] by tkent@chromium.org

Move <input type=time> tests to fast/forms/time/
https://bugs.webkit.org/show_bug.cgi?id=65955

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed 'time' part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-time-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-time.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed 'time' part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-time-expected.txt: Removed.
  • fast/forms/input-valueasdate-time.html: Removed.
  • fast/forms/input-valueasnumber-time-expected.txt: Removed.
  • fast/forms/input-valueasnumber-time.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed 'time' part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-time.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'time' part.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-time.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-time.js: Removed.
  • fast/forms/time: Added.
  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/time/ValidityState-rangeOverflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/time/ValidityState-rangeUnderflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/time/ValidityState-stepMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-time-expected.txt.
  • fast/forms/time/ValidityState-typeMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-time.js.
  • fast/forms/time/input-valueasdate-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-time-expected.txt.
  • fast/forms/time/input-valueasdate-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-time.js.
  • fast/forms/time/input-valueasnumber-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-time-expected.txt.
  • fast/forms/time/input-valueasnumber-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-time.js.
  • fast/forms/time/time-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/time/time-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/time/time-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/time/time-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/time/time-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/time/time-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/time/time-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
19:10 Changeset [92745] by cevans@google.com

Merge 92744
BUG=88670
Review URL: http://codereview.chromium.org/7497055

19:04 Changeset [92744] by abarth@webkit.org

Source/WebCore: Style change not propagating for before, after content
for table parts.
https://bugs.webkit.org/show_bug.cgi?id=51862

Fix by Chris Evans (cevans@chromium.org).
In the table case, make sure to return the before /
after parent rather then the before / after node
itself.

Patch by Abhishek Arya <inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

  • rendering/RenderObjectChildList.cpp:

(WebCore::findBeforeAfterParent):

LayoutTests: Fix functional bug where style change was not getting propogated to before, after
content.
https://bugs.webkit.org/show_bug.cgi?id=51862

Patch by Abhishek Arya <inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
18:49 Changeset [92743] by abarth@webkit.org

garden-o-matic should use huerstics to narrow regression range
https://bugs.webkit.org/show_bug.cgi?id=65948

Reviewed by Dimitri Glazkov.

When analyzing a regression range, if one of the commit messages
mentions the test in question, we now hueristically assume that
revision caused the failure. (I'm shamelessly stealing this idea from
TestFailures.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
18:44 Changeset [92742] by macpherson@chromium.org

Implement string based properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=65662

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyString::ApplyPropertyString):
Added class to handle string based properties.
(WebCore::ApplyPropertyString::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add initializers for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.

18:40 Changeset [92741] by tkent@chromium.org

Another follow-up for r92728.
https://bugs.webkit.org/show_bug.cgi?id=65916

  • fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated.
18:40 Changeset [92740] by kerz@chromium.org

Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

TBR=caseq@chromium.org
Review URL: http://codereview.chromium.org/7552031

18:35 Changeset [92739] by cevans@google.com

Merge 92347
BUG=91093
Review URL: http://codereview.chromium.org/7497054

18:34 Changeset [92738] by kerz@chromium.org

Merge 92672 - Web Inspector: Resources panel does not show main resource cookies.
https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

  • inspector/InspectorPageAgent.cpp:

(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

  • http/tests/inspector/resource-main-cookies-expected.txt: Added.
  • http/tests/inspector/resource-main-cookies.php: Added.
  • platform/chromium/test_expectations.txt:

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7608014

18:15 Changeset [92737] by cevans@google.com

Merge 92692
BUG=91801
Review URL: http://codereview.chromium.org/7608013

18:12 Changeset [92736] by fpizlo@apple.com

DFG JIT does not speculative integers as aggressively as it should
https://bugs.webkit.org/show_bug.cgi?id=65949

Reviewed by Gavin Barraclough.

Added a tree walk to propagate integer predictions through arithmetic
expressions.

This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
translates to a 19% speed-up on Kraken overall. It's neutral on
other benchmarks.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::predictInt32):

17:59 Changeset [92735] by gyuyoung.kim@samsung.com

[EFL] Sort signal comments by alphabetical order.
http://bugs.webkit.org/show_bug.cgi?id=65520

Reviewed by Kent Tamura.

Signals caused by ewk still are listed without any specific rule.
It sure isn't a nice thing to understand the signal list. So, this patch
lists signals by alphabetical order.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.h:
17:51 Changeset [92734] by fpizlo@apple.com

DFG JIT has no way of propagating predictions to loads and calls
https://bugs.webkit.org/show_bug.cgi?id=65883

Reviewed by Gavin Barraclough.

This introduces the capability to store predictions on graph
nodes. To save space while being somewhat consistent, the
prediction is always stored in the second OpInfo slot (since
a GetById will use the first one for the identifier). This
change is a natural extension of r92593 (global variable
prediction).

This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
win on V8 in the geometric mean. It is neutral on SunSpider
and Kraken. Interestingly, on V8 it regresses crypto by 3%
while progressing deltablue and richards by 2.6% and 4.3%,
respectively.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::getPrediction):
(JSC::DFG::Node::predict):

17:36 Changeset [92733] by tkent@chromium.org

Add a missing </script> for r92728.

  • fast/forms/month/ValidityState-stepMismatch-month.html:
17:30 Changeset [92732] by fpizlo@apple.com

DFG JIT passes the this argument to constructors even though
it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=65943

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

17:28 Changeset [92731] by commit-queue@webkit.org

Fix one MIPS instruction to call JITStubThunked_##op
https://bugs.webkit.org/show_bug.cgi?id=65942

Patch by Chao-ying Fu <fu@mips.com> on 2011-08-09
Reviewed by Gavin Barraclough.

Changed "bal" to "jalr" for a possible processor mode change from
MIPS32 to MIPS16.

  • jit/JITStubs.cpp:
17:28 Changeset [92730] by jianli@chromium.org

Unreviewed, mark 2 webaudio tests as failed on chromium win.

  • platform/chromium/test_expectations.txt:
17:09 Changeset [92729] by sullivan@apple.com

WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
https://bugs.webkit.org/show_bug.cgi?id=65950
<rdar://problem/9925931>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Call clearPendingAPIRequestURL() if the policy decision is PolicyIgnore.

17:05 Changeset [92728] by tkent@chromium.org

Move <input type=month> tests to fast/forms/month/
https://bugs.webkit.org/show_bug.cgi?id=65916

Reviewed by Tony Chang.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed month part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Removed month part.
  • fast/forms/ValidityState-stepMismatch-expected.txt: Removed month part.
  • fast/forms/ValidityState-typeMismatch-month-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-month.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed month part.
  • fast/forms/date-input-visible-strings.html: Removed month part.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed month part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed month part.
  • fast/forms/input-type-change3-expected.txt: Removed month part.
  • fast/forms/input-valueasdate-expected.txt: Removed.
  • fast/forms/input-valueasdate-month-expected.txt: Removed.
  • fast/forms/input-valueasdate-month.html: Removed.
  • fast/forms/input-valueasdate.html: Removed.
  • fast/forms/input-valueasnumber-month-expected.txt: Removed.
  • fast/forms/input-valueasnumber-month.html: Removed.
  • fast/forms/month: Added.
  • fast/forms/month/ValidityState-rangeOverflow-month-expected.txt: Added.
  • fast/forms/month/ValidityState-rangeOverflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt: Added.
  • fast/forms/month/ValidityState-rangeUnderflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Added.
  • fast/forms/month/ValidityState-stepMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/month/ValidityState-typeMismatch-month-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-month-expected.txt.
  • fast/forms/month/ValidityState-typeMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-month.js.
  • fast/forms/month/input-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-expected.txt.
  • fast/forms/month/input-valueasdate-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-month-expected.txt.
  • fast/forms/month/input-valueasdate-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-month.js.
  • fast/forms/month/input-valueasdate.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate.js.
  • fast/forms/month/input-valueasnumber-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-month-expected.txt.
  • fast/forms/month/input-valueasnumber-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-month.js.
  • fast/forms/month/month-input-type-expected.txt: Added.
  • fast/forms/month/month-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/month/month-input-visible-string-expected.txt: Added.
  • fast/forms/month/month-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/month/month-stepup-stepdown-expected.txt: Added.
  • fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/month/month-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/month/month-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed month part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed month part.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: Removed month part.
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed month part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed month part.
  • fast/forms/script-tests/input-type-change3.js: Removed month part.
  • fast/forms/script-tests/input-valueasdate-month.js: Removed.
  • fast/forms/script-tests/input-valueasdate.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-month.js: Removed.
16:54 Changeset [92727] by vangelis@chromium.org

Merge 92639 - Scroll animator changes to nail the framerate
https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7604015

16:39 Changeset [92726] by vangelis@chromium.org

Merge 92002 - Scroll animation refinements.
https://bugs.webkit.org/show_bug.cgi?id=65154

Patch by Scott Byer <scottbyer@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.

Source/WebCore:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7590014

16:25 Changeset [92725] by andersca@apple.com

Add the final batch of Lion specific SVG test results.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • platform/mac-snowleopard/svg/text: Added.
  • platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
16:18 Changeset [92724] by andersca@apple.com

Skip a couple of SVG tests that are missing parts of the content for some odd reason.

  • platform/mac-lion/Skipped:
16:01 Changeset [92723] by lforschler@apple.com

New tag.

15:52 Changeset [92722] by andersca@apple.com

Add Lion tests results for a couple of bidi SVG tests.

  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
15:45 Changeset [92721] by aestes@apple.com

Add a Radar number to a skipped test.

  • platform/mac-lion/Skipped:
15:39 Changeset [92720] by andersca@apple.com

Broken link to LICENSE on contributing code page
https://bugs.webkit.org/show_bug.cgi?id=65947

Reviewed by Ryosuke Niwa.

  • coding/contributing.html:
15:31 Changeset [92719] by andersca@apple.com

Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's
possible to have a pixel test result in a different platform directory from a text result.

  • platform/mac-snowleopard/svg/W3C-I18N: Added.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
15:23 Changeset [92718] by vangelis@chromium.org

Merge 92255 - Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Use an edge distance based method instead of the current linear
filtering method for producing anti-aliased edges on 3D transformed
layers. This removes the outer border handling from TilingData as
it's no longer needed for anti-aliasing.

Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing)

platform/chromium/compositing/huge-layer-rotated.html (existing)
compositing/images/content-image-change.html (existing)
TilingDataTest in webkit_unit_tests

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::screenMatrix):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::windowMatrix):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderTile::VertexShaderTile):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderTile::getShaderString):
(WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding):
(WebCore::FragmentTexAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderTile::vertexTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::alphaLocation):
(WebCore::FragmentTexAlphaAABinding::samplerLocation):
(WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::edgeLocation):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::setIsMask):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::intersectDrawQuad):
(WebCore::TilingData::textureOffset):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Update expected results.

  • platform/chromium/test_expectations.txt:

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7590009

15:12 Changeset [92717] by eric@webkit.org

new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486

Reviewed by Adam Roben.

I've tried to write a patch for bug 64439 twice now, and both times
I've ended up re-writing half the port system. So I'm breaking
things up into smaller pieces, this being the first.

WinPort still does not have any port_name parsing, so when instantiated
with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.

Otherwise this should "just work" for windows. I've not been able to test the
version detection on my mac, but the unit tests show the code behaving as designed.

  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
15:10 Changeset [92716] by andersca@apple.com

Add a WebKit prefix to the user default.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

15:09 Changeset [92715] by mrowe@apple.com

Fix gtest to compile in the release configuration with clang.

This change was made upstream in r443.

  • gtest/src/gtest.cc:
14:53 Changeset [92714] by andersca@apple.com

Tweak an expected result.

  • platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:
14:52 Changeset [92713] by andersca@apple.com

Add a user default to disable the plug-in process message timeout
https://bugs.webkit.org/show_bug.cgi?id=65945

Reviewed by Adam Roben.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a disablePluginProcessMessageTimeout member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Initialize the disablePluginProcessMessageTimeout member variable from the
"DisablePluginProcessMessageTimeout" user default.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::defaultSyncMessageTimeout):
Return NoTimeout if WebProcess::disablePluginProcessMessageTimeout returns true.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
Initialize m_disablePluginProcessMessageTimeout.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::disablePluginProcessMessageTimeout):
Add getter.

14:52 Changeset [92712] by eae@chromium.org

Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65396

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::isPointInOverflowControl):
(WebCore::RenderBlock::hitTestFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):

14:45 Changeset [92711] by barraclough@apple.com

Merged JavaScriptCore & JavaScriptGlue from 86722 to 92405.

Reviewed by nobody.

Source/JavaScriptCore:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/JavaScriptGlue:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebCore:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebKit/mac:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebKit2:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Tools:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

LayoutTests:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

14:38 Changeset [92710] by fpizlo@apple.com

DFG JIT failure loading web site
https://bugs.webkit.org/show_bug.cgi?id=65930

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Put the use() call after the fpr()/gpr() calls, since doing otherwise
breaks the register allocator.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Reproduced the failure seen in
http://www.skinnytaste.com/2011/06/ricotta-cheese-chocolate-chip-muffins.html

  • fast/js/boxed-double-to-int-expected.txt: Added.
  • fast/js/boxed-double-to-int.html: Added.
  • fast/js/script-tests/boxed-double-to-int.js: Added.

(boxedDoubleToInt):

14:32 Changeset [92709] by jpfau@apple.com

Initial pass at a new XML tree builder
https://bugs.webkit.org/show_bug.cgi?id=65803

Reviewed by Adam Barth.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::~NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::finishWasCalled):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLTreeBuilder.cpp: Added.

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::pushCurrentNode):
(WebCore::XMLTreeBuilder::popCurrentNode):
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
(WebCore::XMLTreeBuilder::processCharacter):
(WebCore::XMLTreeBuilder::processCDATA):
(WebCore::XMLTreeBuilder::processComment):
(WebCore::XMLTreeBuilder::processEntity):
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
(WebCore::XMLTreeBuilder::processXMLEntity):
(WebCore::XMLTreeBuilder::processHTMLEntity):
(WebCore::XMLTreeBuilder::add):
(WebCore::XMLTreeBuilder::appendToText):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::exitText):
(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
(WebCore::XMLTreeBuilder::NodeStackItem::hasNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceForPrefix):

  • xml/parser/XMLTreeBuilder.h: Added.

(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::node):
(WebCore::XMLTreeBuilder::NodeStackItem::setNode):

14:21 Changeset [92708] by abarth@webkit.org

Teach build.webkit.org's garden-o-matic how to talk to the local server
https://bugs.webkit.org/show_bug.cgi?id=65940

Reviewed by Dimitri Glazkov.

After this patch, the version of garden-o-matic on build.webkit.org is
fully functional. It can interact with the local server via CORS.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
14:17 Changeset [92707] by abarth@webkit.org

Enable CORS for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65936

Reviewed by Dimitri Glazkov.

This patch will allow the hosted instance of garden-o-matic to
communicate with the local server.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
13:46 Changeset [92706] by commit-queue@webkit.org

Add ParentClass typedef in all JSC classes
https://bugs.webkit.org/show_bug.cgi?id=65731

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-09
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):
(JSC::JSCallbackObject::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::JSCallbackObject):
(JSC::::init):
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getConstructData):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::setPrivate):
(JSC::::getPrivate):
(JSC::::inherits):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • debugger/DebuggerActivation.h:
  • jsc.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.h:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.h:
  • runtime/Error.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.h:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.h:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.h:
  • runtime/GetterSetter.h:
  • runtime/InternalFunction.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSActivation.h:
  • runtime/JSArray.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.h:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.h:
  • runtime/JSVariableObject.h:
  • runtime/JSWrapperObject.h:
  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.h:
  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.h:
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.h:
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/RegExpObject.h:

(JSC::RegExpObject::create):

  • runtime/RegExpPrototype.h:
  • runtime/ScopeChain.h:
  • runtime/StrictEvalActivation.h:
  • runtime/StringConstructor.h:
  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StringPrototype.h:
  • runtime/Structure.h:
  • runtime/StructureChain.h:

Source/JavaScriptGlue:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • JSRun.h:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateConstructorDeclaration):

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bridge/c/CRuntimeObject.h:
  • bridge/c/c_instance.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/objc_runtime.h:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.h:
  • bridge/runtime_method.h:
  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:

(Global::className):

Source/WebKit/mac:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • Plugins/Hosted/ProxyInstance.mm:
  • Plugins/Hosted/ProxyRuntimeObject.h:

Source/WebKit2:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
13:41 Changeset [92705] by andersca@apple.com

Add updated media test results for Lion.

  • platform/mac-snowleopard/media: Added.
  • platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png.
  • platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt.
  • platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png.
  • platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt.
  • platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png.
  • platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt.
  • platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png.
  • platform/mac-snowleopard/media/video-layer-crash-expected.txt: Copied from platform/mac/media/video-layer-crash-expected.txt.
  • platform/mac-snowleopard/media/video-no-audio-expected.png: Copied from platform/mac/media/video-no-audio-expected.png.
  • platform/mac-snowleopard/media/video-no-audio-expected.txt: Copied from platform/mac/media/video-no-audio-expected.txt.
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
13:26 Changeset [92704] by crogers@google.com

Add more Web Audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65786

Reviewed by Kenneth Russell.

  • webaudio/audiobuffersource-expected.wav: Added.
  • webaudio/audiobuffersource-playbackrate-expected.wav: Added.
  • webaudio/audiobuffersource-playbackrate.html: Added.
  • webaudio/audiobuffersource.html: Added.
  • webaudio/mixing-expected.wav: Added.
  • webaudio/mixing.html: Added.
  • webaudio/resources/hyper-reality: Added.
  • webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
  • webaudio/resources/hyper-reality/laughter.wav: Added.
  • webaudio/sample-accurate-scheduling-expected.txt: Added.
  • webaudio/sample-accurate-scheduling.html: Added.
13:18 Changeset [92703] by andersca@apple.com

More Lion skipped list goodness.

  • platform/mac-lion/Skipped:
12:58 Changeset [92702] by abarth@webkit.org

Upgrade jquery in TestFailures
https://bugs.webkit.org/show_bug.cgi?id=65935

Reviewed by Dimitri Glazkov.

Upgrade to a newer version of jQuery with better support for CORS and CSP.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
12:47 Changeset [92701] by lforschler@apple.com

Versioning.

12:46 Changeset [92700] by lforschler@apple.com

New tag.

12:42 Changeset [92699] by commit-queue@webkit.org

[Chromium] Enable rubber banding when scrolling.

https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-09
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

12:29 Changeset [92698] by vsevik@chromium.org

Web Inspector: XHRs end up in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60321

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-no-xhrs.html

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):

LayoutTests:

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.
12:27 Changeset [92697] by enne@google.com

Add testing for --force-compositing-mode to windows.internal
https://bugs.webkit.org/show_bug.cgi?id=65777

Reviewed by Adam Barth.

.:

Add exports for Document::settings().

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html

Move initial initialization to settings caching function so that RLC
picks up changes to the force compositing mode flag.

  • WebCore.exp.in:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • testing/Internals.cpp:

(WebCore::Internals::setForceCompositingMode):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Add exports for Document::settings().

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Add empty page to test that the root gets a graphics layer.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
12:13 Changeset [92696] by hyatt@apple.com

Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65871

PerformanceTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.

  • Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.

No new tests, just a refactor on the floating objects data structure.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

12:10 Changeset [92695] by rniwa@webkit.org

Source/WebCore: Repeated copy and paste result in nested font elements
https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Modified isInlineNodeWithStyle to match font element. Also made the function match strictly with those nodes that
ApplyStyleCommand may add to avoid removing non-styling elements. And fixed a regression from r81887 that
ReplaceSelectionCommand may remove non-editing styles such as border in the attempt to avoid nesting styling elements.

This patch paves the way to fix the bug 34564.

Tests: editing/pasteboard/paste-text-with-style-2.html

editing/pasteboard/paste-text-with-style-3.html
editing/pasteboard/paste-text-with-style-4.html

  • editing/EditingStyle.cpp:

(WebCore::HTMLElementEquivalent::matches): Takes const Element* instead of Element*.
(WebCore::HTMLAttributeEquivalent::matches): Ditto.
(WebCore::htmlElementEquivalents): Extracted from conflictsWithImplicitStyleOfElement.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Calls htmlElementEquivalents.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Added; determines whether an element is style span
or a styling element (e.g. b, i, font) possibly with editing style.

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Calls EditingStyle::elementIsStyledSpanOrHTMLEquivalent.
(WebCore::ReplaceSelectionCommand::doApply): More aggressively avoid nesting styling elements.

  • editing/htmlediting.cpp:

(WebCore::highestEnclosingNodeOfType):

  • editing/htmlediting.h:

LayoutTests: Repeated copy and paste result in nested style elements such as b and font
https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Added tests to ensure WebKit does not nest styling elements and does not remove elements with non-editing styles.
Also rebaselined several tests.

Because WebKit serializes all editing inheritable styles on copy, we should be able to remove all inline styles
at the insertion point on paste. And this patch removes inline style elements such as font and b more aggressively.
WebKit erroneously bolded the last words in paste-after-inline-style-element.html and paste-with-redundant-style.html
before this change set but this is no longer the case.

  • editing/pasteboard/5065605-expected.txt: Lost wrapping font and span elements.
  • editing/pasteboard/merge-end-1-expected.txt: Span is split but visually identical.
  • editing/pasteboard/merge-end-2-expected.txt: Ditto.
  • editing/pasteboard/paste-after-inline-style-element-expected.txt: No longer bolds "line 2" erroneously.
  • editing/pasteboard/paste-text-011-expected.txt: Lost wrapping font, b, and span elements.
  • editing/pasteboard/paste-text-with-style-2-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-2.html: Added.
  • editing/pasteboard/paste-text-with-style-3-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-3.html: Added.
  • editing/pasteboard/paste-text-with-style-4-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-4.html: Added.
  • editing/pasteboard/paste-with-redundant-style-expected.txt: Lost wrapping b.
  • editing/pasteboard/paste-with-redundant-style.html: Updated comments per rebaseline.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
12:01 Changeset [92694] by dslomov@google.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by Dmitry Titov.

Covered by existing tests.

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/V8GCController.cpp:

(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by Dmitry Titov.

  • src/BoundObject.cpp:
11:36 Changeset [92693] by steveblock@google.com

JavaString is not needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65909

Removes the JavaString wrapper class, moves the JSC implementation
to JavaStringJSC.h and removes the V8 implementation.

Reviewed by Alexey Proskuryakov.

No new tests, refactoring only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaString.h: Removed.
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jsc/JavaFieldJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaMethodJSC.h:
  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::init):

  • bridge/jni/v8/JavaStringV8.h: Removed.
11:18 Changeset [92692] by inferno@chromium.org

Source/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information
about full layout which is needed when dirtying lineboxes.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderInline.h:

LayoutTests: Tests that we do not crash when trying to dirty line boxes on
a RenderInline needing full relayout.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

  • fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
  • fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.
11:05 Changeset [92691] by japhet@chromium.org

2011-08-09 Nate Chapin <japhet@chromium.org>

Remove receivedCancellation() from SubresourceLoaderClient.

http://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, no change in functionality intended.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.cpp:
  • loader/WorkerThreadableLoader.h:
  • notifications/Notification.cpp:
  • notifications/Notification.h: Remove receivedCancellation() since it's

identical to didFail(), which is always called immediately after.

  • workers/WorkerScriptLoader.cpp:
  • workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's

identical to didFail(), which is always called immediately after.

  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h: Remove receivedCancellation(). All it does is

set m_response, which is cleared in didFail() before it can be used.

10:08 Changeset [92690] by pfeldman@chromium.org

2011-08-09 Pavel Feldman <pfeldman@google.com>

Not reviewed: rebaselining inspector test.

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
10:00 Changeset [92689] by steveblock@google.com

Java Bridge leaks local references
https://bugs.webkit.org/show_bug.cgi?id=64320

Reviewed by Alexey Proskuryakov.

No new tests as this is just an optimization.

  • bridge/jni/jsc/JavaFieldJSC.cpp:

(JavaField::JavaField):

  • bridge/jni/jsc/JavaMethodJSC.cpp:

(JavaMethod::JavaMethod):

09:09 Changeset [92688] by pfeldman@chromium.org

Web Inspector: files from different domains are mixed in the file selector in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=65601

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):

  • inspector/front-end/inspector.css:

(select.status-bar-item):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
08:22 Changeset [92687] by pfeldman@chromium.org

2011-08-09 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector tests

  • inspector/styles/show-user-agent-styles.html:
08:01 Changeset [92686] by commit-queue@webkit.org

Unreviewed, rolling out r92683.
http://trac.webkit.org/changeset/92683
https://bugs.webkit.org/show_bug.cgi?id=65921

"Breaks Qt --minimal build. Revert pending update of the Qt

minimal configuration" (Requested by simathur on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-09

.:

  • Source/WebKit.pri:

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Tools:

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::openUrlInDefaultBrowser):

07:55 Changeset [92685] by commit-queue@webkit.org

[EFL] Fix warning caused by undefined static api.
https://bugs.webkit.org/show_bug.cgi?id=65301

Both _ewk_tiled_backing_store_item_request_add and _ewk_tiled_backing_store_item_request_del
are declared, but their bodies are not defined and they are not referenced anywhere.
Therefore, I remove both two API's declaration in order to resolve warning message caused by them.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-09
Reviewed by Kenneth Rohde Christiansen.

  • ewk/ewk_tiled_backing_store.c:
07:29 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
07:28 Changeset [92684] by kenneth@webkit.org

[Qt] Redirect didFindZoomableArea thru to the view
https://bugs.webkit.org/show_bug.cgi?id=65913

Reviewed by Andreas Kling.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didFindZoomableArea):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didFindZoomableArea):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::timerEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setContentsScale):

  • UIProcess/qt/qtouchwebpageproxy.h:
07:24 Changeset [92683] by siddharth.mathur@nokia.com

[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
https://bugs.webkit.org/show_bug.cgi?id=65880

Reviewed by Andreas Kling.

.:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • Source/WebKit.pri:

Source/WebKit/qt:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Tools:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::openUrlInDefaultBrowser):

07:24 Changeset [92682] by pfeldman@chromium.org

Web Inspector: provide a way to hide user agent styles
https://bugs.webkit.org/show_bug.cgi?id=37766

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/show-user-agent-styles.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):

LayoutTests:

  • inspector/styles/show-user-agent-styles-expected.txt: Added.
  • inspector/styles/show-user-agent-styles.html: Added.
07:18 Changeset [92681] by steveblock@google.com

JavaMethodJobject is no longer needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65910

Reviewed by Tony Gentilcore.

Removes the JavaMethod interface and moves the JavaMethodJobject
implementation to bridge/jni/jsc/JavaMethodJSC.[cpp|h].

No new tests, refactoring only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaMethod.h: Removed.
  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::JavaClass):

  • bridge/jni/jsc/JavaFieldJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaMethodJSC.cpp: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.cpp.

(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):

  • bridge/jni/jsc/JavaMethodJSC.h: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.h.

(JSC::Bindings::JavaMethod::name):
(JSC::Bindings::JavaMethod::returnTypeClassName):
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::returnType):
(JSC::Bindings::JavaMethod::isStatic):
(JSC::Bindings::JavaMethod::numParameters):

  • bridge/jni/v8/JavaNPObjectV8.cpp:
07:10 Changeset [92680] by kenneth@webkit.org

[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
https://bugs.webkit.org/show_bug.cgi?id=65907

Reviewed by Andreas Kling.

This is upstreaming of the algorithm we are currently using on the N9 browser
and this also fixes a bug with not considering the frame positions when finding
a zoomable area.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

06:32 Changeset [92679] by jochen@chromium.org

[chromium] remove temporary #define from WebURLRequest.h
https://bugs.webkit.org/show_bug.cgi?id=65813

Reviewed by Darin Fisher.

  • public/WebURLRequest.h:
06:24 Changeset [92678] by caseq@chromium.org

Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

06:03 Changeset [92677] by yurys@chromium.org

Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
https://bugs.webkit.org/show_bug.cgi?id=54678

Added two functions for retrieving InstrumentingAgents from Page and WorkerContext.

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.cpp: Copied from Source/WebCore/inspector/WorkerInspectorController.h.

(WebCore::instrumentationForPage):
(WebCore::instrumentationForWorkerContext):

  • inspector/InstrumentingAgents.h:
  • inspector/WorkerInspectorController.h:
05:26 Changeset [92676] by vsevik@chromium.org

Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=65911

Unreviewed. Skipped test failing on qt.

  • platform/qt/Skipped:
05:17 Changeset [92675] by jochen@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
03:39 Changeset [92674] by vsevik@chromium.org

Web Inspector: Add "Refresh" to context menu of resources panel cookies view.
https://bugs.webkit.org/show_bug.cgi?id=65854

Reviewed by Pavel Feldman.

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
(WebInspector.CookieItemsView.prototype._contextMenu):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.get refreshCallback):
(WebInspector.DataGrid.prototype.set refreshCallback):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

03:34 Changeset [92673] by andreip@google.com

2011-08-09 Andrei Popescu <andreip@google.com>

[Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:33 Changeset [92672] by vsevik@chromium.org

Web Inspector: Resources panel does not show main resource cookies.
https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

  • inspector/InspectorPageAgent.cpp:

(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

  • http/tests/inspector/resource-main-cookies-expected.txt: Added.
  • http/tests/inspector/resource-main-cookies.php: Added.
  • platform/chromium/test_expectations.txt:
03:26 Changeset [92671] by commit-queue@webkit.org

Unreviewed, rolling out r92670.
http://trac.webkit.org/changeset/92670
https://bugs.webkit.org/show_bug.cgi?id=65905

It broke 3 inspector tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-09

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype._getProperties.remoteObjectBinder):
(WebInspector.RemoteObject.prototype._getProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .value.dimmed):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Added.
02:05 Changeset [92670] by pfeldman@chromium.org

Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .dimmed):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
01:38 Changeset [92669] by abarth@webkit.org

BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=65891

Reviewed by Eric Seidel.

The problem was that platform/chromium contained a bogus expectation
file that needed to be removed, but by the time we got around to
removing it, we'd already moved the correct baseline into its place.
After this patch, we copy the gold results into memory before
reshuffling things on disk (and we delete bad things before adding good
things).

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
01:34 Changeset [92668] by zimmermann@webkit.org

2011-08-09 Nikolas Zimmermann <nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Not reviewed. More gtk/win gardening.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline, same result on both gtk 32 bit debug/release and 64bit.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Taken from Win7 bot, WinXP still seems to have a problem.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
01:27 Changeset [92667] by reni@webkit.org

Accidentally added build number as revision number in r92666.

00:49 Changeset [92666] by reni@webkit.org

[Qt]REGRESSION(r22030): It made one test failed.

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip the failed test.
00:14 Changeset [92665] by zimmermann@webkit.org

Forgot to add the ChangeLog for r92545. Fixed.

Note: See TracTimeline for information about the timeline view.