Timeline


and

08/16/11:

21:51 Changeset [93195] by macpherson@chromium.org

Represent RenderStyle::textOverflow property using an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.

  • rendering/style/RenderStyleConstants.h:

Define TextOverflow enum.

  • rendering/style/StyleRareNonInheritedData.h:

Change representation of text overflow from bool to one-bit unsigned.

21:49 Changeset [93194] by jeffm@apple.com

Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
18:54 Changeset [93193] by levin@chromium.org

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669011

18:41 Changeset [93192] by levin@chromium.org

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669010

18:41 Changeset [93191] by abarth@webkit.org

Add new chromium-mac-leopard directory to match the chromium-mac that
tonywork added. This directory will house Skia results for Chromium Mac.

  • platform/chromium-mac-leopard: Added.
18:38 Changeset [93190] by abarth@webkit.org

Add a CG qualifier similar to the GPU qualifier
https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
18:34 Changeset [93189] by msaboff@apple.com

Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively. In some cases,
we may get to this generated code with one or both of these
registers trash. One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress(). This patch uses the
values on the stack. A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

18:32 Changeset [93188] by levin@chromium.org

REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

18:29 Changeset [93187] by hayato@chromium.org

Add two sample mismatch reftests to make sure that reftests work correctly.
https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

  • fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-fail-mismatch-reftest.html: Added.
  • fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-mismatch-reftest.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
18:24 Changeset [93186] by commit-queue@webkit.org

Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl). This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the screen space transform.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

  • compositing/backface-visibility-hierarchical-transform-expected.png: Added.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
  • compositing/backface-visibility-hierarchical-transform.html: Added.
18:11 Changeset [93185] by rniwa@webkit.org

More rebaselines for Windows WebKit2 port.

  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
17:57 Changeset [93184] by hayato@chromium.org

Implement proper handling of events which happen in children of shadow hosts.
https://bugs.webkit.org/show_bug.cgi?id=66285

Reviewed by Dimitri Glazkov.

Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.

Source/WebCore:

Test: fast/dom/shadow/shadow-contents-event.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
  • fast/dom/shadow/details-summary-mouseover.html: Removed.
  • fast/dom/shadow/shadow-contents-event-expected.txt: Added.
  • fast/dom/shadow/shadow-contents-event.html: Added.
17:55 Changeset [93183] by eric@webkit.org

REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed. Fixing an exception/typo seen on the bots (and testing to make sure it works).

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
17:16 Changeset [93182] by commit-queue@webkit.org

Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):

  • loader/ThreadableLoader.h:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):

  • notifications/Notification.cpp:

(WebCore::Notification::startLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

17:07 Changeset [93181] by lforschler@apple.com

Versioning.

17:06 Changeset [93180] by lforschler@apple.com

New tag.

17:05 Changeset [93179] by lforschler@apple.com

Versioning.

16:51 Changeset [93178] by abarth@webkit.org

Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:30 Changeset [93177] by rniwa@webkit.org

win-wk2 needs updated baselines for some editing tests
https://bugs.webkit.org/show_bug.cgi?id=66344

win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.

  • platform/win-wk2/editing/deleting: Added.
  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
  • platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
16:30 Changeset [93176] by eric@webkit.org

REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Reviewed by Adam Barth.

WinPort didn't have any port_name parsing logic.
Seemed it was best to just share the logic from MacPort.
Sharing the logic from MacPort seemed easiest with a shared superclass.
Once I created ApplePort (the superclass) there was a bunch of logic to share.
I found LeakDetector was just in the way when switching back and forth
between win.py and mac.py so I moved it into its own file.

The only logic change here is that WinPort should now be
able to parse port_name values like MacPort (and other ports)
can. The fact that ports do this in their constructors is
wrong and a source of many bugs. But at least now WinPort
matches the status-quo.

  • Scripts/webkitpy/layout_tests/port/apple.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
16:26 Changeset [93175] by abarth@webkit.org

Add webkit-patch analyze-baselines, as requested by jamesr.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:16 Changeset [93174] by commit-queue@webkit.org

Fix spelling error.
https://bugs.webkit.org/show_bug.cgi?id=66261

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-16
Reviewed by Adam Barth.

No functional change, no tests needed.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::notifyPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):

16:12 Changeset [93173] by abarth@webkit.org

Fold bulk-optimize-baselines into optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=66345

Reviewed by James Robinson.

bulk-optimize-baselines is now a superset of optimize-baselines, so
they can be combined.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:12 Changeset [93172] by tony@chromium.org

Add placeholder directories so the chromium canary bots can update.

  • platform/chromium-mac: Added.
  • platform/chromium-mac/fast: Added.
  • platform/chromium-mac/fast/events: Added.
  • platform/chromium-mac/http: Added.
  • platform/chromium-mac/http/tests: Added.
  • platform/chromium-mac/http/tests/workers: Added.
  • platform/chromium-mac/storage: Added.
  • platform/chromium-mac/storage/domstorage: Added.
15:58 Changeset [93171] by joepeck@webkit.org

<http://webkit.org/b/66328> ASSERT in fast/css/custom-font-xheight.html

Reviewed by Dan Bernstein.

In r93140 the temporary font created for a remote CSS font face
was created without being retained. We need to protect the
font from being purged while we hold onto it, so add a font cache
purge preventer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/chromium/test_expectations.txt:

Unskipped.

15:35 Changeset [93170] by rniwa@webkit.org

Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
which WebKitTestRunner does not support yet.

  • platform/wk2/Skipped:
15:25 Changeset [93169] by jam@chromium.org

[chromium] cleanup after previous webkit change rolled into chrome
https://bugs.webkit.org/show_bug.cgi?id=66177

Reviewed by James Robinson.

  • DEPS:
  • WebKit.gyp:
  • public/WebScrollbar.h:
15:21 Changeset [93168] by abarth@webkit.org

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

15:20 Changeset [93167] by abarth@webkit.org

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

15:20 Changeset [93166] by abarth@webkit.org

Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
https://bugs.webkit.org/show_bug.cgi?id=66334

Reviewed by Tony Chang.

This patch moves us closer to switching the Chromium port from
CoreGraphics to Skia. This patch teaches our tools that the current
Chromium Mac configuration is actually chromium-cg-mac, which makes
room for a future chromium-mac configuration that uses Skia.

Shortly after this patch lands, I'll do a server-side move of the
chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
and chromium-cg-mac-leopard.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:15 Changeset [93165] by tony@chromium.org

[chromium] fast/css/custom-font-xheight.html is asserting on all
chromium builds.

Also mark 2 repaint tests as failing on mac.

  • platform/chromium/test_expectations.txt:
15:10 Changeset [93164] by tony@chromium.org

[chromium] fast/repaint/canvas-putImageData.html is now passing
because of the win baselines added in r93139.

  • platform/chromium/test_expectations.txt:
15:07 Changeset [93163] by dglazkov@chromium.org

garden-o-matic frontend needs a friendly relative time description method.
https://bugs.webkit.org/show_bug.cgi?id=66324

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
15:01 Changeset [93162] by aroben@apple.com

Add Windows results for scripts-panel.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
14:55 Changeset [93161] by dglazkov@chromium.org

Summary view should not add multiple entries for the same test failure.
https://bugs.webkit.org/show_bug.cgi?id=66318

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for

equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
14:39 Changeset [93160] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 4.

Namespace the now public enum as FontCache::ShouldRetain.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):

14:35 Changeset [93159] by aroben@apple.com

Add Windows results for overlapped-iframe-iframe.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
14:32 Changeset [93158] by aroben@apple.com

Skip another test that relies on eventSender.scalePageBy on Windows

  • platform/win/Skipped: Added fast/repaint/background-scaling.html.
14:32 Changeset [93157] by senorblanco@chromium.org

Canvas resizing can be slow
https://bugs.webkit.org/show_bug.cgi?id=66251

Canvas resizing was slow due to re-allocation of the ImageBuffer on
each size change (width or height). This was introduced inadvertently
by calls to isAccelerated() during canvas reset(). Since we won't
know if we have successfully accelerated until ImageBuffer creation,
move the compositor invalidation to createImageBuffer() as well.
This patch also attempts to unify the Skia and CG accelerated canvas
paths. The DrawingBuffer used by the Skia path is now owned by
ImageBuffer[Skia], similar to how the IOSurface is owned by
ImageBuffer[CG]. Some of the logic for when to accelerate was moved
into HTMLCanvasElement and unified with the CG path. Acceleration is
also now enabled by the same "Accelerated" ImageBuffer create flag
used by the CG path. DrawingBuffer is now re-created even for a
same-size change (same as the memory buffer), but we speed it up
by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
clear it, since it's done with a glClear anyway).

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Don't call isAccelerated() from reset(), since we don't want to
inadvertently create the ImageBuffer. Also, since we won't know if
we have successfully accelerated until createImageBuffer() is
called, defer the compositor invalidation to createImageBuffer() as
well.
(WebCore::HTMLCanvasElement::shouldAccelerate):
Unify the CG and Skia ports' logic for when to accelerate (Skia
logic moved in from CanvasRenderingContext2D).
(WebCore::HTMLCanvasElement::createImageBuffer):
Use the unified shouldAccelerate() logic, and pass it as a flag
to ImageBuffer. Do compositor invalidation as well.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
Expose hasCreatedImageBuffer() publically, so
CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
it.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Remove all acceleration setting and resetting, since it's now done
during ImageBuffer creation.
(WebCore::CanvasRenderingContext2D::isAccelerated):
Check if the image buffer was created, so we don't inadvertently
create it here.
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
WebViewImpl may be null. Ask the render tree instead.
(WebCore::CanvasRenderingContext2D::reset):
Don't reset acceleration here, since we don't own it anymore.
(WebCore::CanvasRenderingContext2D::platformLayer):
Call into the ImageBuffer to get our PlatformLayer.

  • html/canvas/CanvasRenderingContext2D.h:

Remove m_drawingBuffer, and all acceleration-related calls.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

Remove setGraphicsContext3D(), and paintsIntoImageBuffer().

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::platformLayer):
Implement a dummy platformLayer() call for non-skia ports.

  • platform/graphics/ImageBuffer.h:

Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add a DrawingBuffer data member.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::reset):
Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
Since we immediately clear the framebuffer via glClear(), this whole
resource safe business is overkill.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This
functionality is handled by ImageBuffer now.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
Give the ImageBufferData ownership of the DrawingBuffer.
(WebCore::ImageBuffer::platformLayer):
Implement an accessor for the DrawingBuffer's PlatformLayer.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove isPathSkiaSafe() extern (unused).
Remove paintsIntoImageBuffer() (now unused). Remove IntSize param
from setGraphicsContext3D() (unused).

14:19 Changeset [93156] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 3.

Include the proper includes!

  • platform/graphics/FontCache.h:
14:12 Changeset [93155] by aroben@apple.com

Teach TestFailures that tests that have failed or passed many times in a row are not flaky

The basic strategy here is that once a test has failed or passed many times in a row we
never again consider it as a possibly flaky test. It's a simple strategy but seems to result
in many fewer false positives than our current behavior.

Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
flaky, including tests that failed for a while but then were fixed

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
number of non-too-many-failure builds we've seen.
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
tests, keep track of how many times they have passed or failed in a row. If they pass or
fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
considered flaky it doesn't matter how many times it passes or fails.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:

Added tests for the above.

14:12 Changeset [93154] by tony@chromium.org

[chromium] fast/css/custom-font-xheight.html is hitting an assert
in debug on Linux.

  • platform/chromium/test_expectations.txt:
14:01 Changeset [93153] by tony@chromium.org

[chromium] Mark new tests as failing. Will pull results from the
bots when they cycle.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [93152] by dglazkov@chromium.org

garden-o-matic needs a summary view with actions for each problem.
https://bugs.webkit.org/show_bug.cgi?id=66144

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
13:47 Changeset [93151] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 2.

This just makes the troublesome enum public. If this
fixes the build I will file a follow-up bug to clean-up
these build issues and either keep the enum public and
cleanup other functions or restore the enum to private.
There is no harm in making the enum public right now.

  • platform/graphics/FontCache.h:
13:44 Changeset [93150] by commit-queue@webkit.org

Unmatrix algorithm implementation is wrong
https://bugs.webkit.org/show_bug.cgi?id=66080

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
Reviewed by Dean Jackson.

Source/WebCore:

Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.

Test: animations/animation-matrix-negative-scale-unmatrix.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose):

LayoutTests:

  • animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
  • animations/animation-matrix-negative-scale-unmatrix.html: Added.
13:28 Changeset [93149] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
13:13 Changeset [93148] by eric.carlson@apple.com

Make video-controls-no-scripting.html results platform independent.

  • media/video-controls-no-scripting-expected.txt:
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
13:10 Changeset [93147] by joepeck@webkit.org

Unreviewed Windows and Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

12:50 Changeset [93146] by aroben@apple.com

Make placeholder text remain visible until a character is typed on Windows

Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields

Covered by existing tests (which are currently failing on the bots until this patch lands).

Reviewed by Dave Hyatt.

  • rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):

  • rendering/RenderThemeWin.h:

(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.

12:48 Changeset [93145] by dino@apple.com

Adding Ted "hober" O'Connor as a non-committing contributor.

  • Scripts/webkitpy/common/config/committers.py:
12:43 Changeset [93144] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66254

Source/WebCore:

Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
content.

Reviewed by Simon Fraser.

Added new tests in fast/repaint.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThreads):

LayoutTests:

Make regions repaint properly. Added new repaint tests.

Reviewed by Simon Fraser.

  • fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
  • fast/repaint/line-flow-with-floats-in-regions.html: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
12:42 Changeset [93143] by lforschler@apple.com

Merge r93070.

12:40 Changeset [93142] by lforschler@apple.com

Merge r93048.

12:34 Changeset [93141] by lforschler@apple.com

Merge r93047.

12:18 Changeset [93140] by joepeck@webkit.org

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

While a remote CSS font face is loading we fallback to a
temporary font. We don't want to retain the fallback font
because noone takes ownership of the temporary font. This
patch adds a way to get an uncached fallback font, which
plumbs the ShouldRetain enum through the different platform
implementations of getLastResortFallbackFont.

No new tests, no functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getNonRetainedLastResortFallbackFont):

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/haiku/FontCacheHaiku.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/pango/FontCachePango.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

12:12 Changeset [93139] by aroben@apple.com

Add Windows expected results for some <canvas> tests

<canvas> doesn't use accelerated compositing on Windows like it does on Lion.

  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
11:56 Changeset [93138] by dbates@webkit.org

2011-08-16 Daniel Bates <dbates@webkit.org>

Add myself to the list of individual members in the WebKit Security Group.

Rubber-stamped by Eric Seidel.

  • security/security-group-members.html:
11:49 Changeset [93137] by lforschler@apple.com

Merge r92977.

11:45 Changeset [93136] by commit-queue@webkit.org

Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

11:44 Changeset [93135] by lforschler@apple.com

Merge r88444.

11:39 Changeset [93134] by rniwa@webkit.org

Programmatically set selection should not have direction on Mac
https://bugs.webkit.org/show_bug.cgi?id=60529

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified default value of VisibleSelection->m_isDirectional from 'true'
to 'false' by adding a defaulted argument to several VisibleSelection
constructors to make programmatic selection be directionless by default
on Mac. Also modified several calls to VisibleSelection's constructors
to correctly preserve directionality.

Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
a call to setExtent triggers an editing delegate that uses the
FrameSelection. The direction here should have been preserved from before,
but setIsDirectional was not called until after FrameSelection.cpp:869. It
has been moved up to make things behave.

  • WebCore.exp.in:
  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):

  • editing/FrameSelection.cpp:

(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):

  • editing/FrameSelection.h:
  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::doApply):

  • editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection):

  • editing/VisibleSelection.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Added editing/selection/programmatic-selection-on-mac-is-directionless
to test selection direction in programmatically set selections on
windows, unix, and mac, in plain text, editable divs, text-input
fields, and textareas. Modified text baselines for many editing tests,
which had a delegate change as a result of the cpp patch.

  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/selection/after-line-break-expected.txt:
  • platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/mac/editing/deleting/delete-and-undo-expected.txt:
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-01-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-02-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/4076267-expected.txt:
  • platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-015-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/anchor-focus2-expected.txt:
  • platform/mac/editing/selection/anchor-focus3-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/fake-drag-expected.txt:
  • platform/mac/editing/selection/move-by-word-001-expected.txt:
  • platform/mac/editing/selection/transformed-selection-rects-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
11:36 Changeset [93133] by jpfau@apple.com

New XML parser: Add document fragment parser
https://bugs.webkit.org/show_bug.cgi?id=66317

Reviewed by Adam Barth.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::parseXML):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::parseDocumentFragment):

  • xml/parser/NewXMLDocumentParser.h:

(WebCore::NewXMLDocumentParser::create):

  • xml/parser/XMLTokenizer.h:
  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::pushCurrentNode):

  • xml/parser/XMLTreeBuilder.h:

(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::node):

11:36 Changeset [93132] by tony@chromium.org

[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.

  • platform/chromium/test_expectations.txt:
11:23 Changeset [93131] by senorblanco@chromium.org

GraphicsContext3D should allow its hostWindow to be NULL
https://bugs.webkit.org/show_bug.cgi?id=66305

Allow the hostWindow param (and m_webViewImpl) to be NULL. This
makes it much easier to enable GPU acceleration at a lower level
in WebKit's platform/graphics layer, without needing access to the
Page* or HostWindow*. Also bump the chromium DEPS to chrome r96940,
which includes a similar change for the in-process GraphicsContext3D
implementations.

Reviewed by James Robinson.

  • DEPS:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):
(WebCore::GraphicsContext3DInternal::platformTexture):
(WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):

11:07 Changeset [93130] by jpfau@apple.com

New XML parser: Replace assertions regarding character data in the prolog with proper checks
https://bugs.webkit.org/show_bug.cgi?id=66269

Reviewed by Adam Barth.

This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):

  • xml/parser/XMLTreeBuilder.h:
11:04 Changeset [93129] by tony@chromium.org

[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).

  • platform/chromium/test_expectations.txt:
11:03 Changeset [93128] by aroben@apple.com

Add Windows expected results for resource-har-conversion.html

While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
extra fields in the request objects.

  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:58 Changeset [93127] by apavlov@chromium.org

Web Inspector: word wrap long edits
https://bugs.webkit.org/show_bug.cgi?id=65512

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.styles-section .properties li.child-editing):

10:31 Changeset [93126] by mnaganov@chromium.org

Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
https://bugs.webkit.org/show_bug.cgi?id=66316

Reviewed by NOBODY (OOPS!).

  • WebKit.gyp:
10:27 Changeset [93125] by pfeldman@chromium.org

Web Inspector: convert DOM breakpoint types to strings.
https://bugs.webkit.org/show_bug.cgi?id=66304

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane):

10:23 Changeset [93124] by tony@chromium.org

Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir. The mac result (r93112) was getting
picked up by the chromium port.

  • platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:16 Changeset [93123] by tony@chromium.org

Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.

Also add chromium baseline (the top of the video control is in a
different place).

  • media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
10:15 Changeset [93122] by pfeldman@chromium.org

Web Inspector: force pseudo element state when checking it in the styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=66292

This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.

Reviewed by David Hyatt.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • css/CSSStyleSelector.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::forcePseudoStateImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::forcePseudoState):

09:59 Changeset [93121] by lforschler@apple.com

rollout incorrect submit of 93118.

09:57 Changeset [93120] by tony@chromium.org

Unreviewed, rolling out r93114.
http://trac.webkit.org/changeset/93114
https://bugs.webkit.org/show_bug.cgi?id=66226

broke the chromium mac compile

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:
  • platform/ScrollbarThemeComposite.cpp:
  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):

  • platform/mac/ScrollbarThemeMac.h:
09:56 Changeset [93119] by aroben@apple.com

Update Windows results for a fast/text test for Safari 5.1's AAS

The results are now more like Mac's. Dan Bernstein says this is probably a progression.

  • platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
09:55 Changeset [93118] by lforschler@apple.com

Merge r36608.

09:46 Changeset [93117] by tony@chromium.org

[chromium] Mark media/video-source-error.html as flaky in Debug.

  • platform/chromium/test_expectations.txt:
09:44 Changeset [93116] by aroben@apple.com

Update Windows results after r92890

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
09:39 Changeset [93115] by aroben@apple.com

Remove Windows-specific hyphenation test results now that hyphenation works on Windows

  • platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
09:34 Changeset [93114] by commit-queue@webkit.org

Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

09:31 Changeset [93113] by tony@chromium.org

Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir. The mac failing results (r93105) were
getting picked up by the chromium port.

  • platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
09:28 Changeset [93112] by aroben@apple.com

Add Lion/Windows expected results for an Inspector test

The only difference from the cross-platform results is that the .js resources are now given
a MIME type of "text/plain".

This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.

  • platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
09:27 Changeset [93111] by aroben@apple.com

Teach TestFailures how to interpret unfinished test runs

Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
rather than "isStarted" so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.

09:19 Changeset [93110] by macpherson@chromium.org

Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=66273

Reviewed by Simon Fraser.

No new tests - no functionality changed - refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Define cast from CSSPrimitiveValue to ETransformStyle3D.
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
Define cast from ETransformStyle3D to CSSPrimitiveValue.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to handle CSSPropertyWebkitTransformStyle.

09:18 Changeset [93109] by macpherson@chromium.org

Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=66279

Reviewed by Simon Fraser.

No new tests - no functionality changed - simple refactoring only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.

09:13 Changeset [93108] by eric.carlson@apple.com

2011-08-16 Eric Carlson <eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

Tests: media/video-controls-no-scripting-iframe.html

media/video-controls-no-scripting.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code

to configureMediaControls.

(WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
(WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in

attributeChanged and preDispatchEventHandler here.

(WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code

to configureMediaControls.

  • html/HTMLMediaElement.h:

2011-08-16 Eric Carlson <eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

  • media/video-controls-no-scripting-expected.txt: Added.
  • media/video-controls-no-scripting-iframe.html: Added.
  • media/video-controls-no-scripting.html: Added.
09:03 Changeset [93107] by aroben@apple.com

Make Apple's Windows port fall back to Lion results instead of SnowLeopard

Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
should match Lion's behavior.

Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
but doesn't use Lion results

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):
Replaced mac-snowleopard with mac-lion.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
directory, which all Apple Mac platforms and Apple Win platforms could potentially use
results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
will no longer look there for results.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest.test_should_build): Tests for the above changes.

09:00 Changeset [93106] by aroben@apple.com

Stop skipping the web-apps tests I just landed results for on Lion

  • platform/mac-lion/Skipped:
08:57 Changeset [93105] by aroben@apple.com

Check in expected failure results for some web-apps tests on Lion and Windows

Since these failures are likely due to bugs in non-WebKit components, they are tracked by
<rdar://problem/9313271>.

  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
  • platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
08:51 Changeset [93104] by aroben@apple.com

Share Sputnik Unicode results between Lion and Windows

Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.

  • platform/mac-lion/Skipped: Removed these tests.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
08:41 WebKit Team edited by hayato@chromium.org
(diff)
08:33 Changeset [93103] by aroben@apple.com

Update Windows Sputnik results for ICU 4.6

Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.

  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
08:16 Changeset [93102] by aroben@apple.com

Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)

Since these failures are likely to be due to bugs in non-WebKit components, they are tracked
by Radars.

  • platform/win/Skipped: Added http/tests/multipart/invalid-image-data-standalone.html,

http/tests/cookies/simple-cookies-expired.html, and
http/tests/cookies/simple-cookies-max-age.html.

07:53 Changeset [93101] by pfeldman@chromium.org

Web Inspector: hide non-conservative methods from the protocol documentation.
https://bugs.webkit.org/show_bug.cgi?id=66301

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
07:50 Changeset [93100] by steveblock@google.com

Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg

See http://code.google.com/p/chromium/issues/detail?id=93044

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:42 Changeset [93099] by steveblock@google.com

Add TIMEOUT expectation for editing/deleting/regional-indicators.html
https://bugs.webkit.org/show_bug.cgi?id=66268

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:39 Changeset [93098] by abecsi@webkit.org

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Fix the GTK build after r93095.

Unreviewed build fix.

No new tests neede.

  • GNUmakefile.list.am: Remove nonexistent sources.
07:26 Changeset [93097] by abecsi@webkit.org

Reviewed by Csaba Osztrogonác.

Need AtomicStrings for the various font family names
https://bugs.webkit.org/show_bug.cgi?id=28024

.:

  • Source/cmake/WebKitMacros.cmake: Add new macro.

Source/WebCore:

Unify the usage of '-webkit' prefixed font family names by using
global AtomicStrings.
Use a .in file to generate the needed sources through make_names.pl.

No new tests needed.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::fontDataForGenericFamily):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/WebKitFontFamilyNames.in: Added.
  • dom/make_names.pl:
  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getFontData):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::useFixedDefaultSize):

07:15 Changeset [93096] by mnaganov@chromium.org

Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
https://bugs.webkit.org/show_bug.cgi?id=66300

Reviewed by Pavel Feldman.

  • WebKit.gyp:
06:41 Changeset [93095] by pfeldman@chromium.org

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/EventsCollector.cpp: Removed.
  • inspector/EventsCollector.h: Removed.
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: Removed.
  • inspector/InspectorFrontendProxy.h: Removed.
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

LayoutTests:

  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
  • http/tests/inspector/network/network-clear-after-disabled.html: Removed.
  • http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
  • http/tests/inspector/network/network-close-load-open.html: Removed.
  • http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
  • http/tests/inspector/network/network-open-load-reopen.html: Removed.
06:38 Changeset [93094] by steveblock@google.com

fix

06:11 Changeset [93093] by benjamin.poulain@nokia.com

[Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-16
Reviewed by Benjamin Poulain.

Source/WebCore:

Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):

Source/WebKit/qt:

Added a platform plugin to allow spell and grammar check in QtWebKit.

  • Api/qwebkitplatformplugin.h:
  • QtWebKit.pro:
  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::textChecker):

  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createSpellChecker):

  • WebCoreSupport/QtPlatformPlugin.h:
  • WebCoreSupport/TextCheckerClientQt.cpp: Added.

(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):

  • WebCoreSupport/TextCheckerClientQt.h: Added.

(WebCore::TextCheckerClientQt::requestCheckingOfString):

06:01 Changeset [93092] by kov@webkit.org

Add javascriptcoregtk to the introspection build, to fix it.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> in 2011-08-16
Reviewed by Xan Lopez.

  • GNUmakefile.am:
05:46 Changeset [93091] by abecsi@webkit.org

WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

Unreviewed gardening.

  • platform/wk2/Skipped: skip editing/input/style-change-during-input.html
04:35 Changeset [93090] by dino@apple.com

Move me from contributor to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
03:04 Changeset [93089] by vsevik@chromium.org

Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Pavel Feldman.

  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
01:57 Changeset [93088] by zoltan@webkit.org

[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
https://bugs.webkit.org/show_bug.cgi?id=66268

  • platform/qt/Skipped:
00:00 Changeset [93087] by morrita@google.com

REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
https://bugs.webkit.org/show_bug.cgi?id=66216

Reviewed by Ryosuke Niwa.

Source/WebCore:

Element::spellcheckAttributeState() uses Element::hasAttribute(),
which calls updateStyleAttribute(), which potentially makes style
dirty. But that is problematic since Editor calls spellcheckAttributeState()
during the spell-checking phase and make the style dirty,
which can trigger re-layout, which wipes the shadow tree of a textarea
out by pre-committed "value" text.

This change removes the hasAttribute() call from
spellcheckAttributeState().

Test: editing/input/style-change-during-input.html

  • dom/Element.cpp:

(WebCore::Element::spellcheckAttributeState):

LayoutTests:

  • editing/input/style-change-during-input-expected.txt: Added.
  • editing/input/style-change-during-input.html: Added.

08/15/11:

22:18 Changeset [93086] by gyuyoung.kim@samsung.com

[CMAKE] Wrap files of websocket and worker in each macro.
https://bugs.webkit.org/show_bug.cgi?id=65012

Move files of web socket and workers into each macro block in CMakeList.txt.
And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.

Reviewed by Daniel Bates.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/js/WorkerScriptController.cpp:
19:35 Changeset [93085] by mrowe@apple.com

Merge r93005.

19:35 Changeset [93084] by mrowe@apple.com

Merge r93000.

19:35 Changeset [93083] by mrowe@apple.com

Versioning.

19:23 Changeset [93082] by mrowe@apple.com

New tag.

18:37 Changeset [93081] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

  • fast/js/kde/operators-expected.txt:
    • erk! missed new expected results from last commit!
18:10 Changeset [93080] by jpfau@apple.com

New XML parser: add xml namespace to the default map of namespaces
https://bugs.webkit.org/show_bug.cgi?id=66266

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):

18:05 Changeset [93079] by hayato@chromium.org

Fix crash when mouse moves from <summary> element to parent <details> element.
https://bugs.webkit.org/show_bug.cgi?id=66210

Reviewed by Dimitri Glazkov.

This is a regression caused by r92922, which wrongly assumes that
a shadow host always has a shadow root as an immediate child in
ancestors chain. This assumption does not apply to <details>
element. <details> element is implemented as a shadow host, but
may have a <summary> element as an immediate child element in
ancestors chain.

Source/WebCore:

Test: fast/dom/shadow/details-summary-mouseover.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Added.
  • fast/dom/shadow/details-summary-mouseover.html: Added.
17:56 Changeset [93078] by rniwa@webkit.org

A mousedown event is not dispatched when clicking on a disabled INPUT
https://bugs.webkit.org/show_bug.cgi?id=27795

Reviewed by Alexey Proskuryakov.

Add a regression test now that the bug no longer reproduces.

  • fast/forms/disabled-mousedown-event-expected.txt: Added.
  • fast/forms/disabled-mousedown-event.html: Added.
17:46 Changeset [93077] by jamesr@google.com

Merge 92908 - Readback composited webgl results for printing
https://bugs.webkit.org/show_bug.cgi?id=65658
BUG=55927

Patch by John Bauman <jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

Source/WebCore:

The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Add support for reading from the composited version of a canvas.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):

  • src/GraphicsContext3DInternal.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7664004

17:32 Changeset [93076] by dimich@chromium.org

[Chromium] Add WebFrameClient::didAdoptURLLoader() notification
https://bugs.webkit.org/show_bug.cgi?id=66167

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didAdoptURLLoader):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::~ResourceHandle):

  • src/ResourceHandleInternal.h: Added.

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):

17:32 Changeset [93075] by abarth@webkit.org

Note that this new test fails.

  • platform/chromium/test_expectations.txt:
17:27 Changeset [93074] by abarth@webkit.org

Remove expectation for this test, which no longer exists.

  • platform/chromium/test_expectations.txt:
17:24 Changeset [93073] by abarth@webkit.org

Add new passing expectations.

  • platform/chromium/fast/js/kde/operators-expected.txt: Added.
17:17 Changeset [93072] by jpfau@apple.com

New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
https://bugs.webkit.org/show_bug.cgi?id=66264

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

16:51 Changeset [93071] by eae@chromium.org

Switch Element/Node to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66260

Reviewed by Eric Seidel.

Convert Element, Node, ElementRareData and ContainerNode to new layout
abstraction as a part of the ongoing conversion work.

No new tests, no new functionality.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::getRect):

  • dom/ContainerNode.h:
  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::adjustForLocalZoom):
(WebCore::Element::boundsInWindowSpace):
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::screenRect):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):

  • dom/Element.h:
  • dom/ElementRareData.h:
  • dom/Node.cpp:

(WebCore::Node::getRect):
(WebCore::Node::renderRect):
(WebCore::Node::hasNonEmptyBoundingBox):

  • dom/Node.h:
16:44 Changeset [93070] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Change bool return values to a 64-bit type.

LayoutTests:

  • fast/js/kde/script-tests/operators.js:

(nonSpeculativeNotInner):
(nonSpeculativeNot):
(nonSpeculativeLessInner):
(nonSpeculativeLess):
(nonSpeculativeLessEqInner):
(nonSpeculativeLessEq):
(nonSpeculativeGreaterInner):
(nonSpeculativeGreater):
(nonSpeculativeGreaterEqInner):
(nonSpeculativeGreaterEq):
(nonSpeculativeEqualInner):
(nonSpeculativeEqual):
(nonSpeculativeNotEqualInner):
(nonSpeculativeNotEqual):
(nonSpeculativeStrictEqualInner):
(nonSpeculativeStrictEqual):
(nonSpeculativeStrictNotEqualInner):
(nonSpeculativeStrictNotEqual):

  • Add tests cases that will hit the non-spec path.
16:36 Changeset [93069] by ap@apple.com

Committed by accident, restoring the test.

  • editing/deleting/delete-3928305-fix.html:
16:34 Changeset [93068] by ap@apple.com

Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395

Reviewed by Dan Bernstein.

Part one: make backspace work.

Test: editing/deleting/regional-indicators.html

  • rendering/RenderText.cpp: (WebCore::isRegionalIndicator): (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional indicator symbols.
16:18 Changeset [93067] by jpfau@apple.com

New XML parser: Re-entering a character node should not clobber the buffered characters
https://bugs.webkit.org/show_bug.cgi?id=66257

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::enterText):

15:49 Changeset [93066] by dimich@chromium.org

FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
https://bugs.webkit.org/show_bug.cgi?id=66165

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no change in behavior.
The original issue is only reproducible on Chromium in multi-process mode
and is tested there by a browsertest.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::transferLoadingResourcesFromPage):
Passing ResourceLoader* into the FrameLoaderClient notification.
Also, fixed the bug where the same ResourceRequest was passed for all subresources.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
returns the request as it existed before redirects (but after client's will SendRequest).
This is to be able to pass the original request for loading subresources into
FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
assignIdentifierToInitialRequest, which needs original request.

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
15:43 Changeset [93065] by abarth@webkit.org

Unreviewed, rolling out r93060.
http://trac.webkit.org/changeset/93060
https://bugs.webkit.org/show_bug.cgi?id=66259

Does not compile on Chromium Windows (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-15

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):

  • src/WebFontCache.cpp:
15:18 Changeset [93064] by aroben@apple.com

Touch a file to trigger a Windows build

I'm trying to ferret out some issues with our Debug builder.

  • WebView.cpp: Sorted #includes.
15:14 Changeset [93063] by dglazkov@chromium.org

garden-o-matic frontend needs model.commitDataForRevisionRange function.
https://bugs.webkit.org/show_bug.cgi?id=66252

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
14:56 Changeset [93062] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix after r93058.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

  • UIProcess/TiledDrawingAreaProxy.h:
14:31 Changeset [93061] by dglazkov@chromium.org

garden-o-matic frontend needs a generic way to track updates.
https://bugs.webkit.org/show_bug.cgi?id=66245

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
14:28 Changeset [93060] by mnaganov@chromium.org

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Darin Fisher.

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

14:12 Changeset [93059] by commit-queue@webkit.org

Refactor JS objects to allocate in static create methods rather than constructors
https://bugs.webkit.org/show_bug.cgi?id=65347

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-15
Reviewed by Geoffrey Garen.

Source/JavaScriptGlue:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

  • JSRun.h:

(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • bindings/js/JSDOMBinding.h:
  • bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):

  • bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.cpp:

Source/WebKit/mac:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

14:06 Changeset [93058] by aroben@apple.com

Update pages' style and content scale when the window's backing scale factor changes

Unfortunately, I couldn't think of a way to test this in an automated fashion.

Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
scale factor changes

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
  • page/Frame.cpp:

(WebCore::Frame::deviceScaleFactorChanged):

  • page/Frame.h:

Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
queries will be reevaluated, and we tell compositing layers about the new scale factor so
they can rerender at the new resolution.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
factor so that, e.g., scale-factor-dependent media queries will be reevaluated.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WKView _windowDidChangeResolution:]): Tell the WebPageProxy about the change.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:

Added deviceScaleFactorDidChange.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::deviceScaleFactorDidChange): Request a new backing store
since the current one is using an old device scale factor.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Send the device scale factor
along to the web process so it can render accordingly. This is how we tell the web process
about device scale factor changes.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange): Tell the DrawingAreaProxy when the device scale
factor changes.
(WebKit::WebPageProxy::deviceScaleFactor): Added this simple getter that calls through to
the PageClient. DrawingAreaProxy uses this function.

  • UIProcess/WebPageProxy.h: Added new members.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Send the device scale factor in the UpdateBackingStoreState message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState): Tell the WebPage and LayerTreeHost about
the new device scale factor.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

Added deviceScaleFactorDidChange.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor): Store the new scale factor and tell the page about
it so that, e.g., scale-factor-dependent media queries will be reevaluated.

  • WebProcess/WebPage/WebPage.h: Added setDeviceScaleFactor.
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::deviceScaleFactorDidChange): Tell the layer for non-composited
content about the new scale factor.

12:59 Changeset [93057] by caryclark@google.com

Revise Skia on Chrome Mac to return fallback fonts.
https://bugs.webkit.org/show_bug.cgi?id=62986

Reviewed by Darin Fisher.

Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.

This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::canReturnFallbackFontsForComplexText):

12:59 Changeset [93056] by thakis@chromium.org

[chromium] Implement shouldRubberBandInDirection
https://bugs.webkit.org/show_bug.cgi?id=66206

Reviewed by Adam Barth.

History swiping can only start after an unhandled mouse wheel event
came back from the renderer, because mouse wheel javascript handlers
take precedence over history swiping. This means that rubberbanding
must not consume wheel events if they could trigger history, else
history swiping won't be triggered for pages without wheel handlers
either.

This is based on the implementation in
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection):

  • src/ChromeClientImpl.h:
12:52 Changeset [93055] by aa@chromium.org

Pass additional details to client in didCreateIsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=66037

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/IsolatedWorld.cpp:

(WebCore::IsolatedWorld::IsolatedWorld):

  • bindings/v8/IsolatedWorld.h:

(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::id):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
12:37 Changeset [93054] by crogers@google.com

Add shell implementation for Web Audio API's MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=66175

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.idl:
  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/MediaElementAudioSourceNode.cpp: Added.

(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::reset):

  • webaudio/MediaElementAudioSourceNode.h: Added.

(WebCore::MediaElementAudioSourceNode::mediaElement):

  • webaudio/MediaElementAudioSourceNode.idl: Added.

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt: Added.
  • webaudio/mediaelementaudiosourcenode.html: Added.
12:31 Changeset [93053] by eae@chromium.org

Switch mouse events to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66179

Reviewed by Eric Seidel.

Convert mouse events to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

  • dom/MouseRelatedEvent.cpp:

(WebCore::contentsScrollOffset):
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::pageLocation):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::screenLocation):
(WebCore::MouseRelatedEvent::clientLocation):
(WebCore::MouseRelatedEvent::absoluteLocation):
(WebCore::MouseRelatedEvent::setAbsoluteLocation):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::selectionExtentRespectingEditingBoundary):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:
  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):

12:30 Changeset [93052] by aroben@apple.com

Teach TestWebKitAPI/gtest how to print JavaScript failures nicely

Failures now give output of the form: foo should be bar but is baz

Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
test is in TestWebKitAPI's output

Reviewed by David Levin.

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
members.
(TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
object, rather than doing any testing of it here.
(TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
to use a pretty error message when the test fails.

  • TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice

gtest-style macros that wrap it.

  • TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
the test passes, though. Returning early seems to have been an unnecessary optimization.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

12:23 Changeset [93051] by rniwa@webkit.org

webkit-indent-blockquote is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=66195

Reviewed by Tony Chang.

Source/WebCore:

Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
since no other class inherited from ApplyBlockElementCommand uses this feature.

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
(WebCore::ApplyBlockElementCommand::createBlockElement):

  • editing/ApplyBlockElementCommand.h:
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::IndentOutdentCommand):

LayoutTests:

Rebaselined the tests since WebKit longer adds class="webkit-indent-blockquote" on blockquotes
created by execCommand('Indent') and execCommand('Outdent') after this patch.

  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/5658933-2-expected.txt:
  • editing/execCommand/5658933-3-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs-expected.txt:
  • editing/execCommand/indent-pre-expected.txt:
  • editing/execCommand/indent-pre-list-expected.txt:
  • editing/execCommand/indent-pre-paragraphs-expected.txt:
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/execCommand/indent-with-style2-expected.txt:
12:07 Changeset [93050] by leviw@chromium.org

Switch remaining SVG Rendering methods to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=66169

Reviewed by Eric Seidel.

Changing remaining integer SVG methods to use the LayoutUnits abstraction.

No tests as no change in functionality.

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::linesBoundingBox):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::parentOriginToBorderBox):
(WebCore::RenderSVGRoot::borderOriginToContentBox):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):

  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):

  • rendering/svg/SVGRootInlineBox.h:
12:07 Changeset [93049] by commit-queue@webkit.org

[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
https://bugs.webkit.org/show_bug.cgi?id=66222

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-15
Reviewed by Kenneth Rohde Christiansen.

The function QTouchWebPagePrivate::getPageViewPrivate() exposed
the private QTouchWebPage to any object in WebKit.

Instead, use the friend keyword to list which objects can access
the internal of QTouchWebPage.

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::viewportRectUpdated):

11:51 Changeset [93048] by barraclough@apple.com

Crash accessing static property on sealed object
https://bugs.webkit.org/show_bug.cgi?id=66242

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

  • should only check isExtensible if checkReadOnly.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • added test case.
10:41 Changeset [93047] by jeffm@apple.com

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

10:21 Changeset [93046] by eric@webkit.org

Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.

Unreviewed.

  • Scripts/run-webkit-tests:

(usingLeaks):
(useNewRunWebKitTests):

09:56 Changeset [93045] by weinig@apple.com

Fix release build when building with Clang.

Reviewed by Anders Carlsson.

  • runtime/Identifier.cpp:

(JSC::Identifier::checkCurrentIdentifierTable):
Add NO_RETURN_DUE_TO_CRASH.

08:54 Changeset [93044] by kbalazs@webkit.org

Unreviewed.
Fix Qt-WK2 build after r93040.

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::deviceScaleFactor):

08:01 Changeset [93043] by aroben@apple.com

Rename an instance of pageScaleFactorChanged I missed in r93040

I tried to make a test for this but failed. It would probably have been easier if we dumped
layers' content scales in layerTreeAsText output.

Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
the device scale factor

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

Renamed from pageScaleFactorChanged to match the base class.

07:32 Changeset [93042] by pfeldman@chromium.org

Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

07:26 Changeset [93041] by vsevik@chromium.org

Web Inspector: Network panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66051

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
(WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):

06:43 Changeset [93040] by aroben@apple.com

Clear up scale factor terminology

WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.

Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

Removed an unused member. This is unrelated to this patch.

  • css/MediaQueryEvaluator.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
AppKit scale factor terminology. (This is unrelated to the rest of the patch.)

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Shared/UpdateInfo.cpp:
  • Shared/UpdateInfo.h:
  • Shared/WebPageCreationParameters.cpp:
  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/BackingStore.cpp:
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
  • UIProcess/gtk/WebPopupMenuProxyGtk.h:
  • UIProcess/mac/BackingStoreMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/qt/WebPopupMenuProxyQt.h:
  • UIProcess/win/WebPopupMenuProxyWin.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
04:59 Changeset [93039] by reni@webkit.org

Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

04:02 Changeset [93038] by hayato@chromium.org

Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=64249

Reviewed by Dimitri Glazkov.

Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
that we can shrink ancestors of event target node considering shadow
DOM boundaries before dispatching focusin/focusout events.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):

  • dom/Node.h:
  • dom/UIEvent.cpp:

(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/UIEvent.h:

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
03:26 Changeset [93037] by pfeldman@chromium.org

Web Inspector: not all of the properties have valid descriptors on all platforms.
Includes PropertyDescriptor protocol documentation fixes.
https://bugs.webkit.org/show_bug.cgi?id=66215

Source/WebCore:

Activations, LocalStorage and some other properties potentially don't have
valid property descriptors. InjectedScript should use conservative getter in order to
mitigate this.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:

LayoutTests:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/runtime/runtime-localStorage-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-localStorage-getProperties.html: Added.
03:00 Changeset [93036] by vsevik@chromium.org

Merge 92835 - Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
https://bugs.webkit.org/show_bug.cgi?id=66007

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.FrameTreeElement.prototype.resourceByURL):

TBR=vsevik@chromium.org
BUG=92405
Review URL: http://codereview.chromium.org/7648029

02:26 Changeset [93035] by pfeldman@chromium.org

Web Inspector: context menu on the link in the console does not have standard link options.
https://bugs.webkit.org/show_bug.cgi?id=66214

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):

  • inspector/front-end/inspector.js:

(WebInspector.openLinkExternallyLabel):
(WebInspector.copyLinkAddressLabel):
(WebInspector.populateHrefContextMenu):

01:13 Changeset [93034] by pfeldman@chromium.org

Web Inspector: showContextMenu missing in Remote DevTools
https://bugs.webkit.org/show_bug.cgi?id=63725

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/SoftContextMenu.js: Added.

(.WebInspector.SoftContextMenu):
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._highlightPrevious):
(.WebInspector.SoftContextMenu.prototype._highlightNext):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.InspectorFrontendHost.showContextMenu):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu-item):
(.soft-context-menu-separator):
(.soft-context-menu-item-mouse-over):

  • inspector/front-end/inspector.html:

08/14/11:

23:57 Changeset [93033] by reni@webkit.org

[QT]REGRESSION after r93011
https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
16:08 Changeset [93032] by inferno@chromium.org

Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

RefPtr a few ContainerNodes to prevent premature deletion.

Test: fast/html/process-end-tag-for-inbody-crash.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody.
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

  • fast/html/process-end-tag-for-inbody-crash-expected.txt: Added.
  • fast/html/process-end-tag-for-inbody-crash.html: Added.
10:54 Changeset [93031] by lforschler@apple.com

New tag.

05:21 Changeset [93030] by commit-queue@webkit.org

Fix GTK Windows build after r92308.
https://bugs.webkit.org/show_bug.cgi?id=66140

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-14
Reviewed by Xan Lopez.

  • config.h: Don't try to include WebCoreHeaderDetection.h for GTK.
00:02 Changeset [93029] by abarth@webkit.org

Switch results detail view over to new-style object-oriented UI widgets
https://bugs.webkit.org/show_bug.cgi?id=66200

Reviewed by Dimitri Glazkov.

This patch replaces my goofy template-based UI for the results
comparison screen with new object-oriented UI widgets.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

08/13/11:

23:55 Changeset [93028] by mitz@apple.com

Set the svn:mime-type property of some PNG files to image/png

13:38 Changeset [93027] by mitz@apple.com

Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.

Reviewed by Joseph Pecoraro.

../WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:

../WebKit/win:

  • WebPreferenceKeysPrivate.h:
12:27 Changeset [93026] by weinig@apple.com

Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.

  • bindings/objc/WebScriptObject.mm:
12:25 Changeset [93025] by weinig@apple.com

Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined dealloc]):

12:12 Changeset [93024] by weinig@apple.com

Remove unused variables from WebView/WebFullScreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66194

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:

Remove a few variables which were not used.

12:03 Changeset [93023] by weinig@apple.com

Remove unused variables from WKFullScreenWindowController.h
https://bugs.webkit.org/show_bug.cgi?id=66193

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:

Remove _layerViewPlaceholder, _isWindowLoaded and _initialFrame which were not used.

11:57 Changeset [93022] by weinig@apple.com

Remove unused variables from WebVideoFullscreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66192

Reviewed by Dan Bernstein.

  • platform/mac/WebVideoFullscreenController.h:

Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.

11:51 Changeset [93021] by weinig@apple.com

Fix incorrect objective-c initialize in WebCore
https://bugs.webkit.org/show_bug.cgi?id=66191

Reviewed by David Kilzer.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):

  • rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.

11:31 Changeset [93020] by abarth@webkit.org

Fix clang build.

  • platform/chromium/PopupMenuChromium.h:
11:06 Changeset [93019] by ddkilzer@apple.com

<http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate entries

by using uniq. Originally noticed by Xcode 4.

10:54 Changeset [93018] by weinig@apple.com

Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190

Reviewed by David Kilzer.

  • wtf/Assertions.h:

Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.

10:48 Changeset [93017] by weinig@apple.com

Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66182

Reviewed by Dan Bernstein.

Fixes 10 warnings in JavaScriptCore and 2 in testapi.

  • API/tests/testapi.c:

(main):
Remove dead variables.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).

  • wtf/dtoa.cpp:

(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.

08:39 Changeset [93016] by dglazkov@chromium.org

garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
https://bugs.webkit.org/show_bug.cgi?id=66166

Also changed base.RequestTracker to:
a) fire callback immediately if requestsInFlight is 0;
b) not barf if callback is not supplied.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
00:00 Changeset [93015] by mitz@apple.com

Build fix.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

08/12/11:

23:25 Changeset [93014] by mitz@apple.com

Source/WebCore: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
truncated text, try to set the tooltip to the full text of the truncated text, if any.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize new member variable.
(WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.

  • page/Settings.h:

(WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.

  • rendering/HitTestResult.h:
  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Made this public.

Source/WebKit/mac: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Added a default value of NO for the
ShowsToolTipOverTruncatedText preference.
(-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
(-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit/win: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Interfaces/IWebPreferencesPrivate.idl: Added accessors.
  • WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added a default value of
false for the ShowsToolTipOverTruncatedText preference.
(WebPreferences::showsToolTipOverTruncatedText): Added this getter.
(WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit2: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShowsToolTipOverTruncatedText): Added this setter.
(WKPreferencesGetShowsToolTipOverTruncatedText): Added this getter.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Handle the showsToolTipOverTruncatedText preference.

20:26 Changeset [93013] by senorblanco@chromium.org

Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=66154

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::isAccelerated):
Plumb this call through GraphicsContext::isAcceleratedContext().
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
For the ACCELERATED_2D_CANVAS path, plumb this call through
(the new) GraphicsContext::paintsIntoCanvasBuffer().
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):
Remove the use of the m_context3D member; use a temporary instead.

  • html/canvas/CanvasRenderingContext2D.h:

Remove the m_context3D member.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Implement stub versions of these functions for other platforms.

  • platform/graphics/GraphicsContext.h:

Expose isAcceleratedContext() to all platforms. Add
paintsIntoImageBuffer() member function.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setGraphicsContext3D):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Basically gut this class leaving only a static creation function.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
Use isAccelerated() in place of useSkiaGpu().

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
(WebCore::PlatformContextSkia::paintsIntoImageBuffer):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::isAccelerated):
Rename useSkiaGpu() to isAccelerated(). Plumb through
paintsIntoImageBuffer() to GraphicsContext3D.

19:40 Changeset [93012] by weinig@apple.com

Use builtin_trap() for CRASH when building with clang
https://bugs.webkit.org/show_bug.cgi?id=66152

Reviewed by Anders Carlsson.

../JavaScriptCore:

  • wtf/Assertions.h:

Add Clang specific CRASH macro that calls builtin_trap() instead
of silly techniques to crash. This allows the static analyzer to understand
that we are intentionally crashing. As a result, we need to mark some functions
as not returning.

Also adds a macros that annotates a function as never returning due to ASSERT or CRASH.

  • wtf/Compiler.h:

Add COMPILIER(CLANG) and fix some formatting and spelling mistakes.

  • wtf/FastMalloc.cpp:

(WTF::Internal::fastMallocMatchFailed):
Add NO_RETURN_DUE_TO_CRASH.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
Add NO_RETURN_DUE_TO_ASSERT.

../WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::fail):

  • bindings/objc/WebScriptObject.mm:
  • platform/mac/BlockExceptions.h:
  • platform/text/cf/StringImplCF.cpp:

Add NO_RETURN_DUE_TO_ASSERT.

  • bridge/IdentifierRep.h:

Don't define the destructor since it is never called,

../WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
(-[WebBaseNetscapePluginView handleMouseMoved:]):
(-[WebBaseNetscapePluginView handleMouseEntered:]):
(-[WebBaseNetscapePluginView handleMouseExited:]):
(-[WebBaseNetscapePluginView focusChanged]):
(-[WebBaseNetscapePluginView windowFocusChanged:]):
(-[WebBaseNetscapePluginView createPlugin]):
(-[WebBaseNetscapePluginView loadStream]):
(-[WebBaseNetscapePluginView shouldStop]):
(-[WebBaseNetscapePluginView destroyPlugin]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
(-[WebBaseNetscapePluginView pluginLayer]):
(-[WebBaseNetscapePluginView getFormValue:]):
Remove the ASSERT_NOT_REACHED from the base class methods. They were not
adding much value and were getting in the way of making the static analyzer
work. A better way to do this would be to use a formal protocol.

18:44 Changeset [93011] by joepeck@webkit.org

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

No new tests, this is not a functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
If the CSS font-face is loading from a URL then immediately
fallback to a system font matching the description, since we
cannot determine a reasonable family name from the m_string
URL. The URL could be a dataURI.

16:27 Changeset [93010] by fpizlo@apple.com

DFG JIT has inconsistent use of boxDouble and unboxDouble,
inconsistent use of assertions regarding doubles, and those
assertions are not turned on in debug builds
https://bugs.webkit.org/show_bug.cgi?id=66160

Reviewed by Gavin Barraclough.

JIT assertions are now turned on in debug builds. JIT
assertions are now used for boxing and unboxing doubles, and boxing
and unboxing no longer involves code duplication.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):

16:18 Changeset [93009] by fsamuel@chromium.org

Refactoring of PopupMenuChromium For Readability and Maintainability
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
and PopupLisBox.{h|cpp} for readability and maintainability.

No new tests as there's no change in functionality.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
  • tests/PopupMenuTest.cpp:
15:59 Changeset [93008] by abarth@webkit.org

Need a way to selectively use hixie-76 for websocket connections depending on destination and/or origin
https://bugs.webkit.org/show_bug.cgi?id=65835

Patch by Denis Lagno <dilmah@chromium.org> on 2011-08-12
Reviewed by Alexey Proskuryakov and Yuta Kitamura.

WebCore:

No new tests. (because it is temporary solution for transient period between hixie-76 and hybi-NN).

  • page/Settings.cpp:

(WebCore::Settings::addHixie76WebSocketProtocolException):
(WebCore::Settings::useHixie76WebSocketProtocol):

  • page/Settings.h:

(WebCore::Settings::setUseHixie76WebSocketProtocol):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):

WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::addHixie76WebSocketProtocolException):

  • src/WebSettingsImpl.h:
15:56 Changeset [93007] by fsamuel@chromium.org

Expose pageScaleFactor() to Chromium's WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=66067

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):

  • src/WebViewImpl.h:
15:48 Changeset [93006] by rniwa@webkit.org

Skip the test added by r92997 on Qt port because it uses a method on EventSender that hasn't been
implemented by Qt port's DRT. The failure is tracked by the bug 66173.

  • platform/qt/Skipped:
15:35 Changeset [93005] by mrowe@apple.com

Be more forward-looking in the choice of compiler.

Rubber-stamped by Jon Honeycutt.

Source/JavaScriptCore:

  • Configurations/CompilerVersion.xcconfig:

Source/JavaScriptGlue:

  • Configurations/CompilerVersion.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/CompilerVersion.xcconfig:

Source/WebCore:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit/mac:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit2:

  • Configurations/CompilerVersion.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
15:32 Changeset [93004] by commit-queue@webkit.org

[GTK] Fix non-pthreads build after r91906.
https://bugs.webkit.org/show_bug.cgi?id=66151

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-12
Reviewed by David Levin.

r91906 broke the non-pthreads GTK+ build by including a header which
doesn't exist. Fix it by including DateMath.h instead of DateMap.h.

  • wtf/gtk/ThreadingGtk.cpp:
15:00 Changeset [93003] by nduca@chromium.org

[chromium] Fix comile warning on CCLayerTreeHost

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

14:44 Changeset [93002] by abarth@webkit.org

Update expectations to note flakiness.

  • platform/chromium/test_expectations.txt:
14:42 Changeset [93001] by rniwa@webkit.org

Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/execCommand/16049-expected.txt:
  • editing/execCommand/5685604-1.html:
  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/query-font-size-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-expected.txt:
  • editing/execCommand/script-tests/remove-format-multiple-elements.js:
  • editing/execCommand/script-tests/toggle-text-decorations.js:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/execCommand/toggle-text-decorations-expected.txt:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/pasteboard/paste-text-with-style-2-expected.txt:
  • editing/style/apply-font-size-to-multiple-nodes-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/highlight-insert-paragraph-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/invalid-font-size-expected.txt:
  • editing/style/push-down-font-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-font-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-win/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/editing/inserting/5994480-2-expected.txt:
14:42 Changeset [93000] by mrowe@apple.com

Update some configuration settings that were missed back in r92432.

  • Configurations/CompilerVersion.xcconfig:
14:41 Changeset [92999] by nduca@chromium.org

[chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
https://bugs.webkit.org/show_bug.cgi?id=66168

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

14:35 Changeset [92998] by leviw@chromium.org

Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
https://bugs.webkit.org/show_bug.cgi?id=66149

Reviewed by Eric Seidel.

Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
abstraction from ints.

No tests as no change in functionality.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::listHeight):
(WebCore::RenderListBox::baselinePosition):
(WebCore::RenderListBox::itemBoundingBoxRect):
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::itemHeight):
(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::controlClipRect):
(WebCore::RenderListBox::invalidateScrollbarRect):
(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::controlClipRect):
(WebCore::RenderMenuList::showPopup):

  • rendering/RenderMenuList.h:
14:28 Changeset [92997] by commit-queue@webkit.org

Source/WebKit/chromium: Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollBegin):
(EventSender::gestureScrollEnd):
(EventSender::gestureTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • fast/events/touch/gesture/gesture-click-expected.txt: Added.
  • fast/events/touch/gesture/gesture-click.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.
14:10 Changeset [92996] by lforschler@apple.com

Merge r92986.

14:08 Changeset [92995] by lforschler@apple.com

Merge r92911.

14:06 Changeset [92994] by lforschler@apple.com

Merge r92909.

14:02 Changeset [92993] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66133

Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
layer tree (just as we did with painting).

Reviewed by Sam Weinig.

Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.

Source/WebCore:

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::type):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/hit-test-float-expected.txt: Added.
  • fast/regions/hit-test-float.html: Added.
14:01 Changeset [92992] by leviw@chromium.org

Switch RenderTable* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66146

Reviewed by Eric Seidel.

Converting RenderTable* classes to new LayoutUnits from ints.

No new tests as no new functionality.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::firstLineBoxBaseline):
(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:

(WebCore::RenderTable::columnPositions):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
(WebCore::RenderTableSection::getBaseline):

13:58 Changeset [92991] by commit-queue@webkit.org

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-08-12
Reviewed by Alexey Proskuryakov.

EventSource loader should not buffer data
https://bugs.webkit.org/show_bug.cgi?id=61863

Disabled buffering in the EventSource loader.

Added a manual test.

  • manual-tests/eventsource/eventsource-loader-buffering.html: Added.
  • manual-tests/eventsource/eventsource-loader-buffering.php: Added.
  • page/EventSource.cpp:

(WebCore::EventSource::connect):

13:56 Changeset [92990] by rniwa@webkit.org

Skip the test added by r92982 on Qt since it uses a new layoutTestController method
that hasn't been implemented by Qt DRT. The failure is tracked by the bug 66162.

  • platform/qt/Skipped:
13:46 Changeset [92989] by commit-queue@webkit.org

[Chromium] Implement the embedders for the HTML5 Track List objects
https://bugs.webkit.org/show_bug.cgi?id=60260

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-12
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamTrack.h: Added.

(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::isNull):

  • public/WebMediaStreamTrackList.h: Added.

(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::~WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::isNull):

  • src/WebMediaStreamTrack.cpp: Added.

(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator WTF::PassRefPtr<WebCore::MediaStreamTrack>):

  • src/WebMediaStreamTrackList.cpp: Added.

(WebKit::WebMediaStreamTrackList::initialize):
(WebKit::WebMediaStreamTrackList::reset):
(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::operator WTF::PassRefPtr<MediaStreamTrackList>):

13:41 Changeset [92988] by rniwa@webkit.org

GTK rebaselines after r92890.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
13:34 Changeset [92987] by rniwa@webkit.org

Mac rebaselines after r92890.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
13:33 Changeset [92986] by barraclough@apple.com

REGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
Matrix3D.invert)
https://bugs.webkit.org/show_bug.cgi?id=66038

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-12
Reviewed by Gavin Barraclough.

Simplest and lowest-impact fix for the case where the spilled format
of a DFG node differs from the register format: if the format is
converted then indicate that the spilled value is no longer valid
("kill the spill").

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::killSpilled):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

13:33 Changeset [92985] by psolanki@apple.com

ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
https://bugs.webkit.org/show_bug.cgi?id=65926

Reviewed by Alexey Proskuryakov.

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
m_shouldBufferData is set to false.

13:18 Changeset [92984] by aestes@apple.com

allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
https://bugs.webkit.org/show_bug.cgi?id=66158

Reviewed by Dan Bernstein.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback): The third argument is the 'this'
JSObjectRef, not the second.

13:16 Changeset [92983] by abarth@webkit.org

Unreviewed, rolling out r92976.
http://trac.webkit.org/changeset/92976
https://bugs.webkit.org/show_bug.cgi?id=66159

Does not compile on chromium-win (Requested by abarth|gardener
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Removed.
  • platform/chromium/PopupContainer.h: Removed.
  • platform/chromium/PopupListBox.cpp: Removed.
  • platform/chromium/PopupListBox.h: Removed.
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupItem::PopupItem):
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
12:56 Changeset [92982] by aestes@apple.com

Cancel in onbeforeunload dialog sometime causes a button to stop working.
https://bugs.webkit.org/show_bug.cgi?id=26211

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/loader/form-submission-after-beforeunload-cancel.html

If an onbeforeunload handler cancels a navigation that was triggered by
a form submission, WebCore's multiple form submission protection
prevents the form from being submitted a second time even though no
first submission actually took place. Fix this by clearing
m_submittedFormURL if the onbeforeunload handler cancels the load. This
allows the submission to be retried.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
if shouldClose() will return false.

Tools:

Implement a new LayoutTestController method that a test can call to set
the return value of DumpRenderTree's beforeunload UI delegate.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload.
(setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
(LayoutTestController::staticFunctions): Register
'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload and bind
'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
(LayoutTestController::reset): Reset
m_shouldStayOnPageAfterHandlingBeforeUnload to false.
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
from JavaScript.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
return the inverse of
LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Define setShouldStayOnPageAfterHandlingBeforeUnload().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
to the Test Controller telling it what value it should return in its
onbeforeunload UI delegate.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Call InjectedBundle::postNewBeforeUnloadReturnValue().

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize
m_beforeUnloadReturnValue to true.
(WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
the value of TestController::beforeUnloadReturnValue().
(WTR::TestController::resetStateToConsistentValues): Reset
m_beforeUnloadReturnValue to true.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::beforeUnloadReturnValue):
(WTR::TestController::setBeforeUnloadReturnValue):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
message posted from the injected bundle by retrieving the message body
as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().

LayoutTests:

  • fast/loader/form-submission-after-beforeunload-cancel-expected.txt: Added.
  • fast/loader/form-submission-after-beforeunload-cancel.html: Added.
12:53 Changeset [92981] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66130

RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
offset.

Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
They no longer have to subclass their own layout method or worry about all of the painting logic
for anything other than the content area.

Reviewed by Anders Carlsson.

Existing tests have a layer tree example, and so those results are updated to show the tree now.

Source/WebCore:

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png:
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
  • fast/regions/content-flowed-into-regions-expected.png:
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-expected.png:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png:
12:38 Changeset [92980] by abarth@webkit.org

Unreviewed, rolling out r92978.
http://trac.webkit.org/changeset/92978
https://bugs.webkit.org/show_bug.cgi?id=66155

This patch does not compile (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:56 Changeset [92979] by crogers@google.com

Fix mac build when web audio is enabled
https://bugs.webkit.org/show_bug.cgi?id=66150

Unreviewed build fix.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

11:43 Changeset [92978] by fsamuel@chromium.org

Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=66089

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:42 Changeset [92977] by jeffm@apple.com

Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
https://bugs.webkit.org/show_bug.cgi?id=65724

Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).

Reviewed by Eric Carlson.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().

11:36 Changeset [92976] by fsamuel@chromium.org

Refactoring of PopupMenuChromium
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
for readability and maintainability.

No new tests as no functionality has changed.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
11:06 Changeset [92975] by cevans@google.com

Merge 92798
BUG=91972
Review URL: http://codereview.chromium.org/7634029

10:51 Changeset [92974] by weinig@apple.com

Move compiler specific macros to their own header
https://bugs.webkit.org/show_bug.cgi?id=66119

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Add Compiler.h

  • wtf/AlwaysInline.h:

Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h. We can remove this file in a later commit.

  • wtf/Compiler.h: Added.

Put all compiler specific checks and features in this file.

  • wtf/Platform.h:

Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h. Include Compiler.h since it is necessary.

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
10:36 Changeset [92973] by noam.rosenthal@nokia.com

[Qt][REGRESSION] composited content doesn't render since r92651
https://bugs.webkit.org/show_bug.cgi?id=66108

Reviewed by Benjamin Poulain.

Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
the new signature in GraphicsLayer.h.

No new tests. This is a regression that's covered by existing pixel tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::syncCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
10:34 Changeset [92972] by dglazkov@chromium.org

Add a way to extend DOM objects in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=66096

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
10:33 Changeset [92971] by cevans@google.com

Merge 92791
BUG=91362
Review URL: http://codereview.chromium.org/7634026

10:28 Changeset [92970] by fsamuel@chromium.org

Expose pageScaleFactor in Chromium's WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=66139

Reviewed by Darin Fisher.

  • public/WebHistoryItem.h:
  • src/WebHistoryItem.cpp:

(WebKit::WebHistoryItem::pageScaleFactor):
(WebKit::WebHistoryItem::setPageScaleFactor):

10:22 Changeset [92969] by commit-queue@webkit.org

Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.

[CSSRegions]RenderFlowThread should display its content using RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=65627

Source/WebCore:

RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
of RenderRegion objects that get the content from the same flow.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

Tests: fast/regions/content-flowed-into-regions-dynamically-added.html

fast/regions/content-flowed-into-regions-dynamically-removed.html
fast/regions/content-flowed-into-regions-with-dyn-index.html
fast/regions/content-flowed-into-regions-with-index-dom.html
fast/regions/content-flowed-into-regions-with-index.html
fast/regions/content-flowed-into-regions.html
fast/regions/flow-content-basic-vertical-rl.html
fast/regions/flow-content-basic-vertical.html

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::compareRenderRegions):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paint):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

LayoutTests:

Also updated the old tests that expected an 100% by 100% RenderFlowThread. Those tests
require at least a region attached, otherwise the RenderFlowThread would have been 0/0 in size,
and no output would be generated for them in the render tree.

The attached regions are now printed in the render tree, so some tests required updated results.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html: Added.
  • fast/regions/content-flowed-into-regions-expected.png: Added.
  • fast/regions/content-flowed-into-regions-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index.html: Added.
  • fast/regions/content-flowed-into-regions.html: Added.
  • fast/regions/flow-content-basic-vertical-rl.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic-vertical.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic.html:
  • fast/regions/render-region-renderer-expected.txt:
  • fast/regions/resources/region-style.css: Added.

(.greenBox):
(.blueBox):
(.orangeBox):
(.flowArticle):
(.regionArticle):
(.borderBox):

  • fast/regions/webkit-flow-renderer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested-expected.txt:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • platform/mac/fast/regions/flow-content-basic-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
10:17 Changeset [92968] by cevans@google.com

Merge 92966
BUG=92621
Review URL: http://codereview.chromium.org/7640019

10:15 Changeset [92967] by cevans@google.com

Merge 92966
BUG=92621
Review URL: http://codereview.chromium.org/7635022

09:27 Changeset [92966] by inferno@chromium.org

Crash in WebCore::editingIgnoresContent
https://bugs.webkit.org/show_bug.cgi?id=66125

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr a few nodes in case they get blown away in
dispatchEvent calls.

Test: editing/selection/select-start-remove-root-crash.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Tests that we do not crash when we blow away the root
during the firing of selectstart event in selection.

  • editing/selection/select-start-remove-root-crash-expected.txt: Added.
  • editing/selection/select-start-remove-root-crash.html: Added.
09:26 Changeset [92965] by nduca@chromium.org

[chromium] Add WebThread to WebKitClient
https://bugs.webkit.org/show_bug.cgi?id=66013

Reviewed by Darin Fisher.

  • public/WebKitClient.h:

(WebKit::WebKitClient::createThread):

  • public/WebThread.h: Added.

(WebKit::WebThread::~WebThread):

08:34 Changeset [92964] by podivilov@chromium.org

Web Inspector: properly update console message count in source frames and resources panel.
https://bugs.webkit.org/show_bug.cgi?id=57009

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype._updateMessageRepeatCount):

08:15 Changeset [92963] by caio.oliveira@openbossa.org

[Qt] Add test for correct order of load signals in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=66016

Reviewed by Benjamin Poulain.

Add API test to ensure the order of load signals: loadStarted() needs to be emitted
first, then loadProgress(100), followed by loadFinished().

The test is skipped since this right now is broken, the bug
https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.

  • tests/qwebpage/tst_qwebpage.cpp:

(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
(SpyForLoadSignalsOrder::isFinished):
(SpyForLoadSignalsOrder::onLoadProgress):
(tst_QWebPage::loadSignalsOrder_data):
(tst_QWebPage::loadSignalsOrder):

07:56 Changeset [92962] by pfeldman@chromium.org

2011-08-12 Pavel Feldman <pfeldman@google.com>

Not reviewed: follow up to inspector test breakage.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
07:50 Changeset [92961] by yurys@chromium.org

Web Inspector: expand exception properties when wrapping it as object.
https://bugs.webkit.org/show_bug.cgi?id=66035

Source/WebCore:

Use toString() value as a description for value thrown during eval.

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-eval-syntax-error-expected.txt:
  • inspector/console/console-eval-undefined-override-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • platform/chromium/inspector/console/console-eval-global-expected.txt:
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt:
  • platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt:
07:33 Changeset [92960] by alexis.menard@openbossa.org

[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.

In order to build correctly the QtQuick1 plugin we need to explicitly
link to the new library added in Qt5 "qtquick1".

Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
07:05 Changeset [92959] by andreip@google.com

2011-08-12 Andrei Popescu <andreip@google.com>

[Chromium] Rebaseline these tests on Leopard.

Unreviewed gardening.

  • LayoutTests/platform/chromium-linux/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-win-xp/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
06:54 Changeset [92958] by pfeldman@chromium.org

Web Inspector: make folders optional in the Scripts' panel file selector.
https://bugs.webkit.org/show_bug.cgi?id=66100

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
06:03 Changeset [92957] by podivilov@chromium.org

Web Inspector: add space between error info and error message in source frame message bubble.
https://bugs.webkit.org/show_bug.cgi?id=65069

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • inspector/debugger/source-frame-expected.txt:
05:56 Changeset [92956] by pfeldman@chromium.org

Web Inspector: console loses focus upon reloading the page from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=66068

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.revealAndSelect):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._setDocument.selectNode):
(WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._setDocument):
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.selectedDOMNode):
(WebInspector.ElementsPanel.prototype.selectDOMNode):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.updateFocusedNode):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.reset):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype._jumpToSearchResult):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createTopPane):

  • inspector/front-end/inspector.js:
  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.select):

LayoutTests:

  • inspector/console/command-line-api-inspect.html:
05:17 Changeset [92955] by ossy@webkit.org

Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
05:06 Changeset [92954] by yurys@chromium.org

2011-08-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h

  • inspector/InspectorAgent.h:
04:44 Changeset [92953] by vsevik@chromium.org

Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
https://bugs.webkit.org/show_bug.cgi?id=66061

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::requestId):

  • inspector/IdentifiersFactory.h:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::requestId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._requestId):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._appendResource):
(WebInspector.NetworkLogView.prototype._matchResource):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.FormattedRecord):

LayoutTests:

  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-test.js:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
03:57 Changeset [92952] by ossy@webkit.org

Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • fast/html/unknown-tag-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated.
02:32 Changeset [92951] by hans@chromium.org

IndexedDB: Object store records don't need to have keys in all indexes
https://bugs.webkit.org/show_bug.cgi?id=66049

Reviewed by Tony Chang.

Source/WebCore:

Allow inserting records in an object store even though they don't
yield keys in some index. The spec has changed in this regard.

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

LayoutTests:

Update test to make sure it's possible to add an object store record
even though it doesn't yield keys in every index.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
01:51 Changeset [92950] by hans@chromium.org

IndexedDB: Overwriting key in unique index should be possible
https://bugs.webkit.org/show_bug.cgi?id=65993

Reviewed by Tony Chang.

Source/WebCore:

It should be possible to overwrite an object store record even if
there is a derived key for that record in an index with the unique flag set.

  • storage/IDBBackingStore.h:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):

  • storage/IDBSQLiteBackingStore.h:

LayoutTests:

Test that it's possible to overwrite an object store record even if there
is a derived key for that record in an index with the unique flag set.

  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
00:52 Changeset [92949] by commit-queue@webkit.org

[EFL] Fix after r91815 - restore changes from r91659.
https://bugs.webkit.org/show_bug.cgi?id=64682

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Kenneth Rohde Christiansen.

Restore patch for fix ewk_view_context_menu_forward_event which
has been overwrititen by mistake.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

00:46 Changeset [92948] by commit-queue@webkit.org

[EFL] HTML Saving feature.
https://bugs.webkit.org/show_bug.cgi?id=55455

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Antonio Gomes.

Gets the source and location of resources for document.
TODO:

  1. Support others resources (css, plugins, media files).
  2. Currently only HTML documents are supported.
  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):
(ewk_frame_resources_location_get):

  • ewk/ewk_frame.h:
00:08 Changeset [92947] by lforschler@apple.com

New tag.

Note: See TracTimeline for information about the timeline view.