Timeline


and

08/19/11:

23:32 Changeset [93476] by commit-queue@webkit.org

Unreviewed, rolling out r93415.
http://trac.webkit.org/changeset/93415
https://bugs.webkit.org/show_bug.cgi?id=66623

Introduces failing test (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Removed.
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/SourceFile.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Removed.
  • inspector/debugger/breakpoint-manager.html: Removed.
23:19 Changeset [93475] by rniwa@webkit.org

Chromium Windows and Linux rebaselines. These baselines were so wrong.

  • platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:

Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.

  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.

  • platform/chromium/test_expectations.txt:
21:32 Changeset [93474] by rniwa@webkit.org

Skip the test added by r93369 on GTK; the failure is tracked by the bug 66621.

  • platform/gtk/Skipped:
21:27 Changeset [93473] by rniwa@webkit.org

Remove the left over from r93468; also fix Chromium Windows expectation
(Copied it over from fast/css/getComputedStyle/ and replaced Times with 'times new roman')

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
20:41 Changeset [93472] by rniwa@webkit.org

Skip the test added by r93392 on Windows; the failure is tracked by the bug 66620.

  • platform/win/Skipped:
20:36 Changeset [93471] by rniwa@webkit.org

More rebaseline after r93068. Apparently Windows XP needs a separate baseline.

  • platform/win-xp/editing: Added.
  • platform/win-xp/editing/deleting: Added.
  • platform/win-xp/editing/deleting/regional-indicators-expected.txt: Added.
20:29 Changeset [93470] by rniwa@webkit.org

Redo the rebaseline done by r93353. The test that has been failing on GTK is
editing/deleting/regional-indicators.html, not editing/selection/regional-indicators.

The failure is still tracked by the bug 66501.

  • platform/gtk/editing/deleting/regional-indicators-expected.txt: Copied from

LayoutTests/platform/gtk/editing/selection/regional-indicators-expected.txt.

  • platform/gtk/editing/selection/regional-indicators-expected.txt: Removed.
20:19 Changeset [93469] by rniwa@webkit.org

Skip the test added by r93392 on Qt. The failure is tracked by the bug 66619.

  • platform/qt/Skipped:
20:12 Changeset [93468] by rniwa@webkit.org

Rebaseline after r93430. Also removed superfluous expected result from Chromium directories.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced with

LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

  • platform/chromium-cg-mac/fast/css/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt: Removed.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
19:59 Changeset [93467] by dbates@webkit.org

Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617

Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.

Reviewed by Antonio Gomes.

  • heap/MachineStackMarker.cpp:
19:17 Changeset [93466] by fpizlo@apple.com

The JSC JIT currently has no facility to profile and report
the types of values
https://bugs.webkit.org/show_bug.cgi?id=65901

Reviewed by Gavin Barraclough.

Added the ability to profile the values seen at function calls (both
arguments and results) and heap loads. This is done with emphasis
on performance. A value profiling site consists of: add, and,
move, and store; no branching is necessary. Each value profiling
site (called a ValueProfile) has a ring buffer of 8 recently-seen
values. ValueProfiles are stored in the CodeBlock; there will be
one for each argument (excluding this) and each heap load or callsite.
Each time a value profiling site executes, it stores the value into
a pseudo-random element in the ValueProfile buffer. The point is
that for frequently executed code, we will have 8 somewhat recent
values in the buffer and will be able to not only figure out what
type it is, but also to be able to reason about the actual values
if we wish to do so.

This feature is currently disabled by default. When enabled, it
results in a 3.7% slow-down on SunSpider.

(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::numberOfValueProfiles):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):

  • bytecode/ValueProfile.h: Added.

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::computeProbability):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::probabilityOfInt32):
(JSC::ValueProfile::probabilityOfDouble):
(JSC::ValueProfile::probabilityOfCell):
(JSC::getValueProfileBytecodeOffset):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITCall.cpp:

(JSC::JIT::emit_op_call_put_result):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):

  • jit/JSInterfaceJIT.h:
  • wtf/Platform.h:
  • wtf/StdLibExtras.h:

(WTF::binarySearch):
(WTF::genericBinarySearch):

18:55 UsingGitWithWebKit edited by dpranke@chromium.org
Update the git instructions so that git-svn and git update the same branch … (diff)
18:47 Changeset [93465] by dbates@webkit.org

Don't include DisallowCType.h when building on QNX
https://bugs.webkit.org/show_bug.cgi?id=66616

Reviewed by Antonio Gomes.

  • config.h:
18:46 Changeset [93464] by rniwa@webkit.org

Skip the test added by r93369 because Window's DRT actually sleeps for
the amount of time leapForward is called upon. The failure is tracked by the bug 66551.

  • platform/win/Skipped:
18:31 Changeset [93463] by commit-queue@webkit.org

[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606

Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.

The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:17 Changeset [93462] by dbates@webkit.org

Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611

Reviewed by Antonio Gomes.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

18:14 Changeset [93461] by cfleizach@apple.com

AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes
https://bugs.webkit.org/show_bug.cgi?id=61289

Update the code to determine the position of accessibility elements on Mac for WK2,
so that elements within iframes are positioned correctly.

Reviewed by Darin Adler..

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::page):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

17:45 Changeset [93460] by jpfau@apple.com

New XML parser: text nodes outside of root element not created for document fragments
https://bugs.webkit.org/show_bug.cgi?id=66604

When intializing a fragment parser, declare that the first element has been seen. Also, flush the text nodes when finishing parsing a document.

Reviewed by Darin Adler.

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::finish):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::finish):

  • xml/parser/XMLTreeBuilder.h:
17:41 Changeset [93459] by jeffm@apple.com

MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=66612

Reviewed by Darin Adler.

No new tests, should be covered by existing media tests.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.

17:20 Changeset [93458] by andersca@apple.com

Another attempt at fixing the Windows build.

  • UIProcess/PageClient.h:
16:59 Changeset [93457] by lforschler@apple.com

Fix for mis-merge. Radar 9750868

16:56 Changeset [93456] by andersca@apple.com

Fix Windows build.

  • WebProcess/Plugins/PluginController.h:
16:54 Changeset [93455] by jamesr@google.com

[chromium] GPU test expectation baseline update

Update pixel baselines for this test on mac and linux.

  • platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:50 Changeset [93454] by enne@google.com

[chromium] Regression: Fix clang errors from r93424
https://bugs.webkit.org/show_bug.cgi?id=66609

Reviewed by James Robinson.

The invalidateRect function does not appear to be used anywhere
because the setNeedsDisplay function is used instead. Fix the Clang
error by just removing this unused vestigial base class function.

  • platform/graphics/chromium/LayerChromium.h:
16:45 Changeset [93453] by andersca@apple.com

Add new enums to npapi.h
https://bugs.webkit.org/show_bug.cgi?id=66608

Reviewed by Sam Weinig.

  • bridge/npapi.h:
16:37 Changeset [93452] by jpfau@apple.com

libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Reviewed by Darin Adler.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Reviewed by Darin Adler.

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
16:24 Changeset [93451] by commit-queue@webkit.org

Unreviewed, rolling out r93426.
http://trac.webkit.org/changeset/93426
https://bugs.webkit.org/show_bug.cgi?id=66607

Broke the Mac build by not building gtest.framework anymore
(Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/ThirdParty:

  • gtest/README.WebKit:
  • gtest/include/gtest/internal/gtest-port.h:
  • gtest/msvc/gtest-md.vcproj:
  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:
16:22 Changeset [93450] by dbates@webkit.org

Implement WTF::atomic{Increment, Decrement}() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66605

Reviewed by Darin Adler.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

16:18 Changeset [93449] by adamk@chromium.org

[chromium] Remove various unreferenced bits from Chromium API headers
https://bugs.webkit.org/show_bug.cgi?id=66575

Reviewed by Tony Chang.

  • public/WebApplicationCacheHost.h:

(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):

  • public/WebFrame.h:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didReceiveTitle):

  • public/WebVideoFrame.h:
15:53 Changeset [93448] by tony@chromium.org

[chromium] Cleanup some old plugin tests. Rebase plugin-javascript-access.html
on win and run plugin-initiate-popup-window on mac/linux to get results.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/win/plugins/plugin-javascript-access-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/plugin-javascript-access-expected.txt.
15:50 Changeset [93447] by andersca@apple.com

Make the complex text input state a tri-state enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=62245

Reviewed by Sam Weinig.

This is to prepare the infrastructure for supporting the updated Cocoa text input model for plug-ins.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):
(WebKit::PluginControllerProxy::compositingRenderServerPort):

  • Shared/Plugins/mac: Added.
  • Shared/Plugins/mac/PluginComplexTextInputState.h: Added.

(WebKit::isValidPluginComplexTextInputState):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPluginComplexTextInputState):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPluginComplexTextInputState):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::setComplexTextInputEnabled):

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::setComplexTextInputState):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):
(WebKit::PluginView::setComplexTextInputState):
(WebKit::PluginView::compositingRenderServerPort):

  • WebProcess/Plugins/PluginView.h:
15:38 Changeset [93446] by jamesr@google.com

[chromium] Update chromium test expectations

Remove = CRASH expectations for tests fixed by r93441.

  • platform/chromium/test_expectations.txt:
15:34 Changeset [93445] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66590
Re-name scrollbar painter types

Reviewed by Sam Weinig.

Source/JavaScriptCore:

WTF_USE_WK_SCROLLBAR_PAINTER is now WTF_USE_SCROLLBAR_PAINTER since WK no longer
applies.

  • wtf/Platform.h:

Source/WebCore:

Names changed to remove references to WebKitSystemInterface since the
implementation is now in WebCore. And the type names changed to be more Objective-
Cish instead of C++ish
WTF_USE_WK_SCROLLBAR_PAINTER -> WTF_USE_SCROLLBAR_PAINTER
WKScrollbarPainterRef -> ScrollbarPainter
WKScrollbarPainterControllerRef -> ScrollbarPainterController

  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollbarOverlayStyle):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

15:26 Changeset [93444] by jamesr@google.com

[chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
https://bugs.webkit.org/show_bug.cgi?id=66603

Reviewed by Dirk Pranke.

The various ChromiumGpu ports should use the same child worker
selection logic as other ports so they can run with full
parallelization on multicore systems.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
15:20 Changeset [93443] by commit-queue@webkit.org

Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
https://bugs.webkit.org/show_bug.cgi?id=66499

Patch by Van Lam <vanlam@google.com> on 2011-08-19
Reviewed by Ryosuke Niwa.

Renamed VisiblePosition::honorEditableBoundary* to
honorEditingBoundary.

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):

  • editing/VisiblePosition.h:
  • editing/visible_units.cpp:

(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

15:12 Changeset [93442] by tony@chromium.org

[chromium] Update results for japanese-rl-selection-repaint-in-regions.html that
changed after r93428.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
14:50 Changeset [93441] by jamesr@google.com

REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063

Reviewed by Darin Fisher.

Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.

Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.

Patch originally by Tom Hudson.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

14:40 Changeset [93440] by eae@chromium.org

Switch clipping for svg to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66586

Reviewed by Eric Seidel.

No new tests as no new functionality.

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:

(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/svg/RenderSVGText.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

  • svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
(WebCore::SVGImage::setContainerSize):

  • svg/graphics/SVGImage.h:
14:37 Changeset [93439] by commit-queue@webkit.org

Unreviewed, rolling out r93425.
http://trac.webkit.org/changeset/93425
https://bugs.webkit.org/show_bug.cgi?id=66591

"The newly-added ASSERT is being triggered on several bots"
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/WebCore:

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabled):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::disabled):

  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isEnabledViaScript):

LayoutTests:

  • fast/css/link-disabled-attr-expected.txt:
  • fast/css/stylesheet-enable-first-alternate-expected.txt: Removed.
  • fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Removed.
  • fast/css/stylesheet-enable-first-alternate-on-load.html: Removed.
  • fast/css/stylesheet-enable-first-alternate.html: Removed.
  • fast/css/stylesheet-enable-second-alternate-expected.txt: Removed.
  • fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Removed.
  • fast/css/stylesheet-enable-second-alternate-on-load.html: Removed.
  • fast/css/stylesheet-enable-second-alternate.html: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Removed.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Removed.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Removed.
  • http/tests/css/resources/slow-loading-sheet-in-error.php: Removed.
  • http/tests/css/resources/slow-loading-sheet.php: Removed.
14:24 Changeset [93438] by enne@google.com

[chromium] Refactor updateCompositorResources to take an explicit GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=66432

Reviewed by James Robinson.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.h:
14:12 Changeset [93437] by vrk@chromium.org

Tell media player to prepareToPlay() at end of HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-load-preload-none.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):

LayoutTests:

  • media/video-load-preload-none-expected.txt: Added.
  • media/video-load-preload-none.html: Added.
13:57 Changeset [93436] by eae@chromium.org

Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66502

Reviewed by Eric Seidel.

Convert RenderBlock to new layout abstraction. Leave m_lineHight as a 30
bit int for now to avoid unnecessarily increasing the memory usage.

No new tests as no new functionality.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
13:40 Changeset [93435] by eae@chromium.org

Switch RenderBoxModelObject to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66534

Reviewed by Eric Seidel.

Convert RenderBoxModelObject to new layout abstraction.

No new tests as no new functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::set):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::backgroundRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::borderWillArcInnerEdge):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):

  • rendering/RenderBoxModelObject.h:
13:37 Changeset [93434] by fsamuel@chromium.org

Expose Fixed Layout Size mode to Chromium's WebKit API
https://bugs.webkit.org/show_bug.cgi?id=66568

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::isFixedLayoutModeEnabled):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setFixedLayoutSize):

  • src/WebViewImpl.h:
13:22 Changeset [93433] by alokp@chromium.org

[chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=66570

Reviewed by Mihai Parparita.

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:

(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):

  • DumpRenderTree/chromium/WebThemeControlDRTWin.h:
13:03 Changeset [93432] by commit-queue@webkit.org

[CSSRegions]Speed up RenderFlowThread repaint of regions
https://bugs.webkit.org/show_bug.cgi?id=66566

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.

When in printing or the repaint rectangle is empty, there is no need to iterate
the render flow regions in order to repaint.
Covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::shouldRepaint):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
12:44 Changeset [93431] by tony@chromium.org

[chromium] Mark touch tests as failing on OSX 10.5.

  • platform/chromium/test_expectations.txt:
12:27 Changeset [93430] by commit-queue@webkit.org

[CSSRegions]Parse -webkit-region-break(after, before, inside)
https://bugs.webkit.org/show_bug.cgi?id=66559

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionBreakBefore):
(WebCore::InheritedFlags::regionBreakInside):
(WebCore::InheritedFlags::regionBreakAfter):
(WebCore::InheritedFlags::setRegionBreakBefore):
(WebCore::InheritedFlags::setRegionBreakInside):
(WebCore::InheritedFlags::setRegionBreakAfter):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:26 Changeset [93429] by eae@chromium.org

Switch RenderLayer to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66507

Reviewed by Eric Seidel.

Convert RenderLayer to new layout abstraction.

No new tests as no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::flooredLayoutSize):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
12:19 Changeset [93428] by commit-queue@webkit.org

[CSSRegions]Content displayed in regions should not be scrollable
https://bugs.webkit.org/show_bug.cgi?id=66459

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by Darin Adler.

Source/WebCore:

Initially, when creating the style for the RenderFlowThread, overflowX and overflowY were both set to hidden,
so that RenderView did not display scrollbars when a RenderFlowThread exists. However, this allowed the possibility
of scrolling the content displayed in region.

Now, the RenderFlowThread objects are ignored in RenderBlock::insertPositionedObject and the style of the RenderFlowThread
can be set to visible, thus preventing scrolling of the content displayed in regions.

Test: fast/regions/content-flowed-into-regions-no-scroll.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):

LayoutTests:

  • fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-no-scroll.html: Added.
12:15 Changeset [93427] by caio.oliveira@openbossa.org

[Qt] [WK2] Provide API for intercept (and possible ignore) links clicked in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65920

Reviewed by Benjamin Poulain.

This patch makes QDesktopWebView delegate the decision of whether a navigation
should proceed to a slot in QML. The user of the DesktopWebView must implement a
'navigationPolicyForUrl()' if it wants to use the feature.

Such feature is useful for implementing opening links in "new tab" by using a
specific mouse button or mouse button plus keyboard modifiers.

The patch introduces a internal Qt-level interface called PolicyInterface, that
is used by QtWebPageProxy to delegate policy calls. A concrete implementation is
provided for QDesktopWebView.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Implement the serialization of the Request URL, which is the only data
we exposing from the Request.

  • WebKit2.pro:
  • UIProcess/qt/PolicyInterface.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:

Register a Policy Client in the WK2 C API only if there's a PolicyInterface available.

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/ClientImpl.cpp:

(toPolicyInterface):
(toQtMouseButton):
(toQtKeyboardModifiers):
(qt_wk_decidePolicyForNavigationAction):
Implement the callback for the Page Policy Client. It will translate the
arguments to Qt jargon and call PolicyInterface.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::QDesktopWebPageProxy):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(toPolicyAction):
(hasMetaMethod):
(QDesktopWebViewPrivate::navigationPolicyForURL):
The concrete implementation for QDesktopWebView. Its private object implements
the PolicyInterface and try to call a possible function defined in QML (so return
value and arguments all QVariants). If there's no such a function, returns the
default UsePolicy, like if we haven't registered a PolicyClient in WK2 C API.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test2.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:

Add a test for DesktopWebView QML element making use of a button and a modifier to
ignore a navigation.

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
For now, we don't have a PolicyInterface for QTouchWebView.

12:08 Changeset [93426] by dslomov@google.com

TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.

Reviewed by David Levin.

  • gtest/include/gtest/internal/gtest-port.h:
  • gtest/msvc/gtest-md.vcproj:
  • gtest/README.WebKit:
  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:

Tools:

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=66521

Reviewed by David Levin.

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
11:54 Changeset [93425] by jchaffraix@webkit.org

REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140
<rdar://problem/9835905>

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-on-load.html

fast/css/stylesheet-enable-first-alternate.html
fast/css/stylesheet-enable-second-alternate-on-load.html
fast/css/stylesheet-enable-second-alternate.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

The gist of the issue is that we were ignoring calls to HTMLLinkElement::setDisabled that would enable a
style sheet when we were loading a stylesheet (m_sheet was 0 and thus ignored the call per the spec).

FF goes against the CSS OM spec in this case and always keep an associated sheet as long as 'rel' hints
at a stylesheet link and href is present. Instead of siding with FF, I continued to follow the
specification and store the enabled via javascript state into m_scriptState (renamed from
m_isEnabledViaScript). This information gets merged back into the style sheet disabled state when it is
available.

While debugging the case at hand, I found some cases that were not properly handled and were fixed as
part of this change.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setDisabled): Always call setIsEnabledViaScript so that
the information is properly stored (either for recalcStyleSelector or just to store
the state during loading).

(WebCore::HTMLLinkElement::sheetLoaded): Merge back the state from m_scriptState to
the sheet's disabled state.

(WebCore::HTMLLinkElement::disabled): Account for the temporary state and return the
right value. It matches FF and what people would expect.

(WebCore::HTMLLinkElement::areDisabledAndScriptStatesConsistent): Debug only method
that checks that disabled() and isEnabledViaScript() are consistent with each other
(under some circumstances).

  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isEnabledViaScript): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setIsEnabledViaScript): Added setter.

LayoutTests:

  • fast/css/link-disabled-attr-expected.txt: This change is a progression, but we are still

not handling updates to the selected style set properly (already covered by bug 62407).

  • fast/css/stylesheet-enable-first-alternate-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load.html: Added.
  • fast/css/stylesheet-enable-first-alternate.html: Added.
  • fast/css/stylesheet-enable-second-alternate-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load.html: Added.
  • fast/css/stylesheet-enable-second-alternate.html: Added.

Those are a variation on the same theme: we disable some stylesheet and enable others,
either directly or later.

  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
  • http/tests/css/resources/slow-loading-sheet.php: Added.

Those 2 test cases relies on a slow loading stylesheet so that we can test the disabled() value while the alternate
sheet is asynchronously loading and then check them again once the sheet is loaded.

11:07 Changeset [93424] by enne@google.com

[chromium] Split tiler into main thread / compositor thread versions
https://bugs.webkit.org/show_bug.cgi?id=66065

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

LayerTilerChromium is renamed to be CCLayerTilingData. Invalidation
and paint functionality is pushed into TiledLayerChromium and drawing
with GL is pushed into CCTiledLayerImpl. During tree synchronization,
the tiler properties and texture IDs are synchronized into
CCTiledLayerImpl.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::bestTextureFormat):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: Removed.
  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::textureId):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::dirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::dumpLayerProperties):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::tileAt):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateTiles):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectVisibleTileTextures):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp: Added.

(WebCore::CCLayerTilingData::create):
(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
(WebCore::CCLayerTilingData::reset):
(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::contentRectToLayerRect):
(WebCore::CCLayerTilingData::layerRectToContentRect):
(WebCore::CCLayerTilingData::tileContentRect):
(WebCore::CCLayerTilingData::tileLayerRect):
(WebCore::CCLayerTilingData::setLayerPosition):
(WebCore::CCLayerTilingData::growLayerToContain):

  • platform/graphics/chromium/cc/CCLayerTilingData.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h.

(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::numTilesX):
(WebCore::CCLayerTilingData::numTilesY):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::textureOffset):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::hasBorderTexels):
(WebCore::CCLayerTilingData::isEmpty):
(WebCore::CCLayerTilingData::Tile::Tile):
(WebCore::CCLayerTilingData::Tile::i):
(WebCore::CCLayerTilingData::Tile::j):
(WebCore::CCLayerTilingData::Tile::moveTo):
(WebCore::CCLayerTilingData::TileMapKeyTraits::emptyValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::constructDeletedValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::isDeletedValue):
(WebCore::CCLayerTilingData::tiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::DrawableTile):
(WebCore::DrawableTile::textureId):
(WebCore::DrawableTile::setTextureId):
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::tileAt):
(WebCore::CCTiledLayerImpl::createTile):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::setTilingData):
(WebCore::CCTiledLayerImpl::syncTextureId):
(WebCore::isCCW):
(WebCore::computeEdge):
(WebCore::intersect):
(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::setSkipsDraw):
(WebCore::CCTiledLayerImpl::setTextureOrientation):
(WebCore::CCTiledLayerImpl::setSampledTexelFormat):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium:

Add a test for assignment and copy constructor for TilingData.

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

10:51 Changeset [93423] by vitalyr@chromium.org

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Cleaning up test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
10:47 Changeset [93422] by tony@chromium.org

[chromium] Add correct baseline for merge-end-list.html on OSX 10.5.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Added.
09:29 Changeset [93421] by mitz@apple.com

Better build fix after r93384.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use WTF::Unicode wrapper instead of ICU.

09:22 Changeset [93420] by andersca@apple.com

WebProcess crashes during startup if libdispatch is initialized by WebProcessShim.dylib
https://bugs.webkit.org/show_bug.cgi?id=66508
<rdar://problem/9828476>

Reviewed by Mark Rowe.

  • mac/MainMac.cpp:

(closeUnusedFileDescriptors):
Check if a file descriptor is a kqueue and don't close it if that is the case. While this
isn't a complete fix, (it won't work if other initializers end up creating non-kqueue file descriptors)
it's good enough for Snow Leopard. For Lion, we should use the new posix_spawn API that lets you whitelist
file descriptors from the parent process.

09:17 Changeset [93419] by podivilov@chromium.org

Web Inspector: update scope variables upon value changes via console.
https://bugs.webkit.org/show_bug.cgi?id=54720

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

09:16 Changeset [93418] by aroben@apple.com

Add project file changes I left out in r93417

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
09:14 Changeset [93417] by aroben@apple.com

Add a helper class for swizzling ObjC instance methods to TestWebKitAPI

Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
NSScreen

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.

(-[SimpleObject setValue:]): Original implementation.

(TestWebKitAPI::setValue2):
(TestWebKitAPI::setValue3):
Swizzled implementations.

(TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
instance method.

  • TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
  • TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.

(TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
(TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.

09:06 Changeset [93416] by commit-queue@webkit.org

Fix _path_to_apache() error reporting
https://bugs.webkit.org/show_bug.cgi?id=66486

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-19
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
08:50 Changeset [93415] by podivilov@chromium.org

Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/breakpoint-manager.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Added.

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get rawSourceCode):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Added.
  • inspector/debugger/breakpoint-manager.html: Added.
08:39 Changeset [93414] by aroben@apple.com

Windows build fix after r93404

  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
08:37 Changeset [93413] by tonyg@chromium.org

Add leandrogracia to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66552

Also fix line endings in file.

No reviewed required.

  • Scripts/webkitpy/common/config/committers.py:
08:29 Changeset [93412] by commit-queue@webkit.org

Fix compilation issue in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66554

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-19
Reviewed by Martin Robinson.

  • WebKitTestRunner/PixelDumpSupport.cpp:
08:27 Changeset [93411] by aroben@apple.com

Fix typo

  • dom/DOMAllInOne.cpp:
08:25 Changeset [93410] by commit-queue@webkit.org

[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
https://bugs.webkit.org/show_bug.cgi?id=65408

Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_add):

08:19 Changeset [93409] by commit-queue@webkit.org

[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028

As backing store's position and offset change can occur at the same time,
the checking of offset change shouldn't be "else if" statement.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_smart_calculate):

08:11 Changeset [93408] by aroben@apple.com

Windows build fix after r93385

  • dom/DOMAllInOne.cpp: Added EventDispatcMediator.cpp.
07:56 Changeset [93407] by commit-queue@webkit.org

[Qt][WK2] Add a basic engine to control the content of the viewport
https://bugs.webkit.org/show_bug.cgi?id=66383

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-19
Reviewed by Andreas Kling.

Add ViewportInteractionEngine to handle the content of the viewport. The class make
sure the QTouchWebPage stays in the viewport and in the boundaries.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidCommit):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage): Set the transform origin to the top left so
we can asume the position 0, 0 is always the top left of the page.
(QTouchWebPagePrivate::_q_commitScaleChange): Make commitScaleChange a slot
in order to completely decouple the ViewportInteractionEngine and the WebKit classes.

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportRectUpdated): Make _q_viewportRectUpdated() a slot
for reducing coupling.
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebViewPrivate::setViewportArguments):
(QTouchWebView::geometryChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didCommitLoadForFrame):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h: Change the gesture recognizer to talk directly

to the ViewportInteractionEngine instead of interacting through TouchViewInterface.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidCommit): Add the loadCommited callback in order
to reset the viewport state when the page change.

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::loadDidCommit):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/ViewportInteractionEngine.cpp: Added.

(WebKit::visibleRectInContentCoordinate):
(WebKit::contentRectInViewportCoordinate):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::reset):
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::panGestureStarted):
(WebKit::ViewportInteractionEngine::panGestureRequestScroll):
(WebKit::ViewportInteractionEngine::panGestureCancelled):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentGeometryChanged):
(WebKit::ViewportInteractionEngine::contentScaleChanged):
(WebKit::ViewportInteractionEngine::updateContentIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentScaleIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentPositionIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionToBoundaries):
(WebKit::ViewportInteractionEngine::animateContentScaleToBoundaries):
(WebKit::ViewportInteractionEngine::scaleContent):

  • UIProcess/qt/ViewportInteractionEngine.h: Added.

(WebKit::ViewportInteractionEngine::Constraints::Constraints):
(WebKit::operator==):

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
07:55 Changeset [93406] by vitalyr@chromium.org

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:51 Changeset [93405] by aroben@apple.com

Pull some of DynamicDeviceScaleFactor's code up into a shareable base class

This will make it easier to write other WebKit-agnostic tests

Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
code in other WebKit-agnostic tests

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of

code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
(TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
WebKitAgnosticTest handles for us.
(TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.

(TestWebKitAPI::WebKitAgnosticTest::loadSynchronously): Code came from
DynamicDeviceScaleFactor::runTest.

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.

(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
DynamicDeviceScaleFactor.WebKit.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
DynamicDeviceScaleFactor.WebKit2.

07:50 Changeset [93404] by aroben@apple.com

Clean up #includes in TestWebKitAPI

Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++

files and WebKit/WebKit.h for ObjC files.

  • TestWebKitAPI/InjectedBundleController.cpp:
  • TestWebKitAPI/JavaScriptTest.h:
  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  • TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/Find.cpp:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  • TestWebKitAPI/TestsController.cpp:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the

07:47 Changeset [93403] by vitalyr@chromium.org

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating baselines.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Added.
  • platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Added.
  • platform/chromium-cg-mac/editing/pasteboard/paste-text-008-expected.png: Added.
07:46 Changeset [93402] by commit-queue@webkit.org

[Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
https://bugs.webkit.org/show_bug.cgi?id=66549

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-19
Reviewed by Benjamin Poulain.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::paint):

  • UIProcess/qt/QtWebPageProxy.h:
07:12 Changeset [93401] by commit-queue@webkit.org

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-19
Reviewed by Kent Tamura.

Adds doxygen documentation to the structures in ewk_view.cpp.

  • ewk/ewk_view.cpp:
06:41 Changeset [93400] by caseq@chromium.org

Web Inspector: [Extensions API][chromium] webInspector.resources deprecation warning is given even for extensions that don't use webInspector.resources
https://bugs.webkit.org/show_bug.cgi?id=66553

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(WebInspector.platformExtensionAPI):

06:23 Changeset [93399] by commit-queue@webkit.org

[EFL] Modify type of both col and row parameters for backing store's internal api.
https://bugs.webkit.org/show_bug.cgi?id=65302

As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill
and ewk_tiled_backing_store_item_add are different from each other, I modify type of them.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):

05:50 Changeset [93398] by pfeldman@chromium.org

Web Inspector: getAttributes should work on a single node, not array.
https://bugs.webkit.org/show_bug.cgi?id=66544

Reviewed by Adam Roben.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):

05:26 Changeset [93397] by antonm@chromium.org

[v8] CSS wrapper objects retention
https://bugs.webkit.org/show_bug.cgi?id=66377

Reviewed by Pavel Feldman.

Disable object grouping for CSS object wrappers.
This logic leads to hard to debug use-after-free problems.

Source/WebCore:

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

LayoutTests:

  • platform/chromium/test_expectations.txt:
05:23 Changeset [93396] by pfeldman@chromium.org

Web Inspector: introduce NodeId inherited from integer in the DOM domain description.
https://bugs.webkit.org/show_bug.cgi?id=66491

Drive-by rename of couple of DOM domain protocol methods.

Reviewed by Adam Roben.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::requestNode):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):

  • inspector/generate-inspector-idl:
05:13 Changeset [93395] by jochen@chromium.org

IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity.
https://bugs.webkit.org/show_bug.cgi?id=66470

Reviewed by Tony Gentilcore.

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::deleteObjectStore):

04:37 Changeset [93394] by zoltan@webkit.org

[Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369
https://bugs.webkit.org/show_bug.cgi?id=66514

Skip it.

  • platform/qt/Skipped:
03:16 Changeset [93393] by commit-queue@webkit.org

[WebSocket] CloseEvent's code and reason properties support.
https://bugs.webkit.org/show_bug.cgi?id=66362

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-19
Reviewed by Kent Tamura.

Current WebSocket implementation miss code and reason properties
in CloseEvent. This change expose incoming closing frame's code
and reason to JavaScript API.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html

http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::initCloseEvent):
(WebCore::CloseEvent::code):
(WebCore::CloseEvent::reason):
(WebCore::CloseEvent::CloseEvent):

  • websockets/CloseEvent.idl:

Add code and reason properies.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):

  • websockets/WebSocket.h:

Add implement to handle code and reason.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::processFrame):

  • websockets/WebSocketChannel.h:

Add closing frame payload parser.

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didClose):

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):

  • websockets/WorkerThreadableWebSocketChannel.h:

Add implement to handle code and reason.

LayoutTests:

  • http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-code-and-reason.html: Added.
  • http/tests/websocket/tests/hybi/close-code-and-reason_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Added.

(postResult):
(ws.onopen):
(ws.onmessage):
(ws.onclose):

02:43 Changeset [93392] by morrita@google.com

.: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Add export for window.internals object.

  • Source/autotools/symbols.filter:

Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
But these are low-level API and caller should take care of word boundary.
This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
which handles word boundary correctly.

Test: editing/spelling/spelling-insert-html.html

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAndBadGrammar):

  • testing/Internals.cpp:

(WebCore::Internals::markerCountOf): Added.
(WebCore::Internals::markedRangeAt): Added.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Add exports for window.internals object.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Existing expectation was wrong because of some markers on substrings of words.
With this fix, Editor now rejects such markers.

  • editing/spelling/spelling-insert-html-expected.txt: Added.
  • editing/spelling/spelling-insert-html.html: Added.
  • platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/mac/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac/editing/pasteboard/merge-end-table-expected.png:
  • platform/mac/editing/pasteboard/paste-text-008-expected.png:
01:58 Changeset [93391] by commit-queue@webkit.org

Run-time error fix in WebKit-GTK with video support disabled.
https://bugs.webkit.org/show_bug.cgi?id=66541

Definition of the function extraFullScreenStyleSheet() in webkit-gtk
lies outside ENABLE(VIDEO) guard, resulting in runtime error while
trying to launch GtkLauncher with video support disabled.

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-19
Reviewed by Philippe Normand.

Run-time error fix. No test cases were added.

  • platform/gtk/RenderThemeGtk.h:
01:46 Changeset [93390] by commit-queue@webkit.org

input[maxlength=0] should ignore text input.
https://bugs.webkit.org/show_bug.cgi?id=65497

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-19
Reviewed by Kent Tamura.

Source/WebCore:

Changed the valid range of maxlength.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Changed maxlength check condition.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt: Added a case that maxlength=0
  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.

(createFocusedTextAreaWithMaxLength):

  • fast/forms/textarea-maxlength-expected.txt: ditto.
01:42 Changeset [93389] by loislo@chromium.org

Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
https://bugs.webkit.org/show_bug.cgi?id=66482

There are functions in the API with multiple optional arguments.
When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
This can be solved with passing the arguments as an object.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/RemoteObject.js:

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex.html:
00:54 Changeset [93388] by zoltan@webkit.org

[Qt] Build fix after r93384.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

08/18/11:

22:44 Changeset [93387] by commit-queue@webkit.org

Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Source/WebCore:

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the world space transform.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Test: compositing/backface-visibility-hierarchical-transform.html

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms. In particular, this test forces Chromium to create a
hierarchy of RenderSurfaces.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.

  • compositing/backface-visibility-hierarchical-transform-expected.png: Added.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
  • compositing/backface-visibility-hierarchical-transform.html: Added.
21:51 Changeset [93386] by commit-queue@webkit.org

[skia] -webkit-transform breaks -webkit-mask
https://bugs.webkit.org/show_bug.cgi?id=66442

Source/WebCore:

The problem here is that in RenderBox::paintMaskImages, if we are in
a transform with a rotation, scale or skew we set the composite mode to
be DestinationIn and then create a transparency layer, then paint the
mask with SourceOver and end the transparency layer. (The normal case
is just to use DestinationIn to paint the mask.)

In skia when we create transparency layers we don't pass on the composite
mode, so when we end the transparency layer it is composited back using
SourceOver. The fix is to pass on the composite mode when creating
transparency layers in skia.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::getXfermodeMode):

  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.

  • platform/chromium-linux/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-linux/fast/css/transformed-mask-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
21:46 Changeset [93385] by hayato@chromium.org

Isolate EventDispatchMediator into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66458

Reviewed by Ryosuke Niwa.

Extracted EventDispatchMediator.h and EventDispatchMediator.cpp
out of Event.h and Event.cpp Also moved FocusEventDispatchMediator
and BlurEventDispatchMediator from Event.{h|cpp} to
EventDispatchMediator.{h|cpp}.

No new tests since this is just refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventDispatchMediator.cpp: Added.

(WebCore::EventDispatchMediator::create):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::dispatchEvent):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):

  • dom/EventDispatchMediator.h: Added.

(WebCore::EventDispatchMediator::~EventDispatchMediator):
(WebCore::EventDispatchMediator::event):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::setEvent):

  • dom/EventDispatcher.cpp:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.h:
  • dom/Node.cpp:
  • dom/ScopedEventQueue.cpp:
  • dom/UIEvent.h:
  • dom/WheelEvent.h:
20:34 Changeset [93384] by mitz@apple.com

Mid-word break can occur between a character and a combining mark
https://bugs.webkit.org/show_bug.cgi?id=66529

Reviewed by Simon Fraser.

No test added because I could not find a combining mark with a non-zero advance in
any of the system fonts and tests fonts.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a
combining mark.

18:58 Changeset [93383] by dpranke@chromium.org

new-run-webkit-tests hung while acquiring http lock on snow leopard bots
https://bugs.webkit.org/show_bug.cgi?id=64886

Temporarily disable the http locking to work around the issue.
I'm not actually sure if this is going to work or improve things
much.

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/port/mac.py:
18:33 Changeset [93382] by tkent@chromium.org

REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/placeholder-crash-with-scrollbar-corner.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.

LayoutTests:

  • fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
  • fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
18:17 Changeset [93381] by koz@chromium.org

Chromium plumbing for webkitRequestFullScreen
https://bugs.webkit.org/show_bug.cgi?id=66031

Reviewed by Darin Fisher.

  • public/WebView.h:
  • public/WebViewClient.h:

(WebKit::WebViewClient::enterFullscreenForElement):
(WebKit::WebViewClient::exitFullscreenForElement):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::enterFullScreenForElement):
(WebKit::ChromeClientImpl::exitFullScreenForElement):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::exitFullscreen):

  • src/WebViewImpl.h:
18:09 Changeset [93380] by jpfau@apple.com

New XML parser: scripting support
https://bugs.webkit.org/show_bug.cgi?id=66406

Reviewed by Adam Barth.

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::resumeParsing):
(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::notifyFinished):

  • xml/parser/NewXMLDocumentParser.h:

(WebCore::NewXMLDocumentParser::pauseParsing):

  • xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags

(WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):

  • xml/parser/XMLTreeBuilder.h:
18:04 Changeset [93379] by ryuan.choi@samsung.com

[EFL] Broken rendering occured when resized in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=66271

Force rendering when ewk_view resized.
It's because Evas_Object doesn't generate any rendering request although
it was changed.

Reviewed by Tony Chang.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_calculate):

17:58 Changeset [93378] by commit-queue@webkit.org

Move allocation in constructors into separate constructorBody() methods
https://bugs.webkit.org/show_bug.cgi?id=66265

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-18
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.

(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::constructorBody):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::constructorBody):

  • runtime/ErrorPrototype.h:
  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

  • runtime/Executable.h:

(JSC::FunctionExecutable::constructorBody):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

  • runtime/InternalFunction.h:

(JSC::InternalFunction::constructorBody):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::constructorBody):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::constructorBody):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::constructorBody):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::constructorBody):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::constructorBody):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

  • runtime/NativeErrorPrototype.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:

(JSC::StringObject::create):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::create):

Source/WebCore:

No new tests.

Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):

  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

17:44 Changeset [93377] by bdakin@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/NSScrollerImpDetails.h: Added.
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
17:23 Changeset [93376] by mitz@apple.com

<rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline
https://bugs.webkit.org/show_bug.cgi?id=66515

Reviewed by Darin Adler.

No test because none of the system fonts and test fonts have an incorrectly-specified descender value.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant
the same amount, but negative. This is consistent with what Core Text does.

17:18 Changeset [93375] by fpizlo@apple.com

DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025

Reviewed by Gavin Barraclough.

This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
stanford-crypto-sha256-iterative). It looks like it might have
a speed-up in SunSpider (though not statistically significant or
particularly reproducible) and a slight slow-down in V8 (0.14%,
not statistically significant). It does slow down v8-crypto by
1.5%.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):

  • dfg/DFGOperations.cpp:
17:00 Changeset [93374] by tony@chromium.org

[chromium] Fix results. Just copy over the platform independent results.

  • platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png:
  • platform/chromium/fast/frames/frame-set-scaling-skew-expected.png:
16:55 Changeset [93373] by lforschler@apple.com

Versioning.

16:52 Changeset [93372] by lforschler@apple.com

New tag.

16:29 Changeset [93371] by fsamuel@chromium.org

Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac
https://bugs.webkit.org/show_bug.cgi?id=66493

The expected results of the layout tests written for
https://bugs.webkit.org/show_bug.cgi?id=57785
differ between WebKitt Mac and WebKit2 Mac.

WebKit2 Mac matches the cross-platform results.
WebKit1 Mac has a special set of test results.

Reviewed by Tony Chang.

  • platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
  • platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
  • platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
  • platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
  • platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
  • platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
  • platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
  • platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
  • platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
  • platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
  • platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
  • platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
  • platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
  • platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
  • platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
  • platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
  • platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
  • platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
  • platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
  • platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.
16:28 Changeset [93370] by tony@chromium.org

[chromium] Mark editing/selection/regional-indicators.html as timing
out on Linux debug and rebaseline 2 tests.

  • platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
  • platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:07 Changeset [93369] by rniwa@webkit.org

positionForPoint returns wrong VisiblePosition at bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=65356

Reviewed by David Hyatt.

Source/WebCore:

The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.

For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
until the end to obtain the offset 7 from the inline box for "DC".

Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
on the left or the right of the position to compute the appropriate offset following the NSTextView convention.

This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
LTR or RTL text in a RTL or LTR block respectively.

Test: editing/selection/caret-at-bidi-boundary.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::offsetForPosition):

  • rendering/RenderText.cpp:

(WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
(WebCore::createVisiblePositionForBox):
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):

LayoutTests:

  • editing/selection/caret-at-bidi-boundary-expected.txt: Added.
  • editing/selection/caret-at-bidi-boundary.html: Added.
16:05 Changeset [93368] by xji@chromium.org

--webkit-visual-word renaming right/leftWordPositionAcrossBoundary
https://bugs.webkit.org/show_bug.cgi?id=66436

Reviewed by Ryosuke Niwa.

Rename them to right/leftWordPositionIgnoringEditingBoundary.

  • editing/visible_units.cpp:

(WebCore::leftWordPositionIgnoringEditingBoundary):
(WebCore::rightWordPositionIgnoringEditingBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

16:05 Changeset [93367] by crogers@google.com

Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium
https://bugs.webkit.org/show_bug.cgi?id=66441

Reviewed by Darin Fisher.

  • public/WebAudioSourceProvider.h: Added.

(WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::audioSourceProvider):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):

  • src/WebMediaPlayerClientImpl.h:

(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):

16:02 Changeset [93366] by lforschler@apple.com

Merge r92804.

16:01 Changeset [93365] by lforschler@apple.com

Merge r92729.

16:00 Changeset [93364] by lforschler@apple.com

Merge r91998.

15:57 Changeset [93363] by jeffm@apple.com

Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725

Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with declspec(dllimport),
and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
until a media element is used.

Reviewed by Eric Carlson.

No new tests as no change in functionality.

  • WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
  • platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
  • platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
15:49 Changeset [93362] by lforschler@apple.com

Merge r92729. Needed for <rdar://problem/9966800>

15:46 Changeset [93361] by commit-queue@webkit.org

Chromium Mac: Show scrollbar when doing search
https://bugs.webkit.org/show_bug.cgi?id=66209

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Source/WebCore:

Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.

No tests because there are no Mac 10.7 chromium bots yet.

  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):

Source/WebKit/chromium:

Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.

No tests because there are no Mac 10.7 chromium bots yet.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::invalidateArea):

15:42 Changeset [93360] by commit-queue@webkit.org

[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834

Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Kenneth Russell.

Source/WebCore:

Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a

draw-time transform.

*) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel

AA trashing the alpha channel. The root layer is always opaque so this is fine.

*) The root layer does not have border texels and does have subpixel AA for text.

Covered by compositing/

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):

  • platform/graphics/chromium/NonCompositedContentHost.cpp: Added.

(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):

  • platform/graphics/chromium/NonCompositedContentHost.h: Added.

(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

LayoutTests:

Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.

  • compositing/checkerboard-expected.png:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
15:23 Changeset [93359] by commit-queue@webkit.org

Unreviewed, rolling out r93354.
http://trac.webkit.org/changeset/93354
https://bugs.webkit.org/show_bug.cgi?id=66503

"consensus was not reached" (Requested by senorblanco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):

LayoutTests:

  • fast/canvas/drawImage-clipped-source-expected.txt: Removed.
  • fast/canvas/drawImage-clipped-source.html: Removed.
  • fast/canvas/drawImage-clipped-source.js: Removed.
  • fast/canvas/drawImage-with-invalid-args-expected.txt:
  • fast/canvas/drawImage-with-invalid-args.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
15:19 Changeset [93358] by commit-queue@webkit.org

GestureRecognizer: Update how gesture-scroll works.

Source/WebCore:

Instead of just sending a series of 'GestureUpdate' events, send a
single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
and end with a 'GestureEnd' event.
https://bugs.webkit.org/show_bug.cgi?id=66267

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
(WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
(WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
(WebCore::scrollEnd):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::InnerGestureRecognizer::firstTouchPosition):

Source/WebKit/chromium:

Add a unit-test to make sure the correct gesture events are being
generated.
https://bugs.webkit.org/show_bug.cgi?id=66267

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(WebCore::TEST_F):

15:16 Changeset [93357] by rniwa@webkit.org

Fix r93349.

  • platform/gtk/Skipped:
15:14 Changeset [93356] by commit-queue@webkit.org

Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Source/WebCore:

Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterSetEnabled):

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

LayoutTests:

Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.

  • platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.
15:08 Changeset [93355] by tony@chromium.org

add embedded png checksums to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66494

Looks like WebKitTestRunner has never supported embedded checksums. This copies
some code from DRT and adds it to the WebKitTestRunner.

Reviewed by Darin Adler.

  • WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
  • WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
  • WebKitTestRunner/GNUmakefile.am: Add new files
  • WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
  • WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
15:03 Changeset [93354] by commit-queue@webkit.org

Source/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.

Test: fast/canvas/drawImage-clipped-source.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
Removed the unnecessary dom exceptions for out of bounds source rectangles
The overloads that receive video and image elements as source images
now use the normalized versions of the source rectangle, which
GraphicsContext (and its various platform flavors) can handle correctly.
The normalized rectangle is the equivalent rectangle with width and height
greater than 0. The canvas version of this method, which had better layout
test coverage, was already correctly using the normalized rectangle. The
newly added layout test verifies correct behavior with negative
source rectangle dimensions.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
Fixed algorithm that adjusts the destination rectangle to match the clipping
applied to the source rect. The case of scaled filtered images with source
rectangles that overlap the edge of the image was not being handled
correctly. This use case was previously unsupported and used to trigger
a DOM exception.

LayoutTests: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.

  • fast/canvas/drawImage-clipped-source-expected.txt: Added.
  • fast/canvas/drawImage-clipped-source.html: Added.

New test that verifies the clipping behavior when source rectangles
are partially out of the bounds of the source image

  • fast/canvas/drawImage-clipped-source.js: Added.

(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testPattern):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):

  • fast/canvas/drawImage-with-invalid-args-expected.txt:
  • fast/canvas/drawImage-with-invalid-args.html:

This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions

  • platform/chromium/test_expectations.txt:

Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail

  • platform/mac/Skipped:

Skipping canvas/philip/tests/2d.drawImage.outsidesource.html

14:55 Changeset [93353] by ap@apple.com

[Gtk] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66501

  • platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.
14:53 Changeset [93352] by ap@apple.com

Use a correct name for expected results.

  • platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
  • platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.
14:50 Changeset [93351] by ap@apple.com

[Qt] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66500

  • platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.
14:00 Changeset [93350] by commit-queue@webkit.org

Unreviewed, rolling out r93329.
http://trac.webkit.org/changeset/93329
https://bugs.webkit.org/show_bug.cgi?id=66497

Turned text on chromium win blue (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::dumpLayerProperties):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::rootLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
  • platform/graphics/chromium/NonCompositedContentHost.h: Removed.
  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::dumpSurface):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::tilingTransform):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

LayoutTests:

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
13:52 Changeset [93349] by rniwa@webkit.org

Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
which is tracked by the bug 66496.

  • platform/gtk/Skipped:
13:43 Changeset [93348] by rniwa@webkit.org

GTK rebaseline after r93221.

  • platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:

Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.

13:41 Changeset [93347] by rniwa@webkit.org

SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
https://bugs.webkit.org/show_bug.cgi?id=66086

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
Fixing the bug by detecting RenderTextFragment in handleTextNode.

Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
the next call to handleTextNode needs to process the first-letter part of the text fragment.

Test: editing/text-iterator/backward-textiterator-first-letter-crash.html

  • editing/TextIterator.cpp:

(WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
(WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.

  • editing/TextIterator.h:

LayoutTests:

Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
from 0 to 1 because there is unrendered space before "hello".

  • editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
  • editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
  • editing/text-iterator/first-letter-word-boundary-expected.txt:
  • editing/text-iterator/first-letter-word-boundary.html:
13:37 Changeset [93346] by commit-queue@webkit.org

[chromium] Assert that main thread and compositor thread are used safely
https://bugs.webkit.org/show_bug.cgi?id=66145

CCLayerTreeHostImplProxy now has public static methods isMainThread()
and isImplThread(), and we ASSERT these in various places. If threaded
compositing is disabled, we fake isImplThread() by setting a flag for
the duration of compositing, so the assert is still valid.

Patch by Iain Merrick <husky@google.com> on 2011-08-18
Reviewed by James Robinson.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::doComposite):

  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::isMainThread):
(WebCore::CCLayerTreeHostImplProxy::isImplThread):
(WebCore::CCLayerTreeHostImplProxy::setImplThread):
(WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

13:36 Changeset [93345] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=47240

Fixed a cygwin path problem in the chromium port of diff_image;
Also made the return values of the diff_image function more consistent.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
13:32 Changeset [93344] by ap@apple.com

Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395

Reviewed by Dan Bernstein.

Source/WebCore:

Part two: make cursor movement iterator work. This fixes the problem for strings that don't
contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.

Test: editing/selection/regional-indicators.html

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom

rules for regional indicator symbols.

LayoutTests:

  • editing/selection/regional-indicators-expected.txt: Added.
  • editing/selection/regional-indicators.html: Added.
13:22 Changeset [93343] by caryclark@google.com

Fix rubber band gutter drawing for Skia on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=66478

Reviewed by James Robinson.

No new tests. The Skia on Chromium Mac platform has
not been enabled.

This break was detected at compile time; there is no
behavior change.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Convert the CGImage into an SkBitmap if Skia is present.

13:22 Changeset [93342] by commit-queue@webkit.org

Add a bunch of accessors to WebAccessibilityObject to expose more of
AccessibilityObject to Chromium, including range control values,
document load state, live region attributes, and a few other
ARIA attributes.

https://bugs.webkit.org/show_bug.cgi?id=66411

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
Reviewed by Dimitri Glazkov.

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):

13:20 Changeset [93341] by jchaffraix@webkit.org

Implement a faster path for painting tables with overflowing cells
https://bugs.webkit.org/show_bug.cgi?id=65491

This change introduces a smarter way of painting if the table is big enough and we have a small amount
of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
the overflowing cells to the repainting cells.

This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
memory.

Reviewed by David Hyatt.

No new tests as the behavior should be the same.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
care about the cell's information. Make sure that the "has overflowing cells" information is still
properly encoded on our 2 values.

(WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
complicated sort:

  • the old path would sort one (mostly sorted) array by rows only as the stable sort would take care of keeping the column ordering inside a row.
  • the new path basically has to sort an unsorted array (taken partly from the HashSet).

(WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
repaint the same cell twice.

(WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
fast path optimization here.

  • rendering/RenderTableSection.h: Transformed our original boolean into

a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
until we reach the memory threshold. After this is hit, we just set the boolean
to avoid using too much memory.

(WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
if we have any overflowing cell, used only for hit testing.

13:11 Changeset [93340] by commit-queue@webkit.org

An EventSource constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66454

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/eventsource/eventsource-constructor.html

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.

  • bindings/v8/custom/V8EventSourceConstructor.cpp:

(WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

  • fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.
13:09 Changeset [93339] by commit-queue@webkit.org

A SharedWorker constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66455

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/workers/shared-worker-constructor.html

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.

  • bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

  • fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.
13:08 Changeset [93338] by alex@webkit.org

2011-08-17 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073

Reviewed by Martin Robinson.

  • platform/gtk/GtkAuthenticationDialog.cpp: (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added gtk_box_new conditional compilation for gtk+-3.
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have GTK_TYPE_SCALE in gtk+3.

2011-08-17 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main): G_CONST_RETURN was deprecated
  • GtkLauncher/main.c: (createWindow): Added gtk_box_new conditional compilation for gtk+-3.
  • MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we are just supporting gtk+-3 for WebKit2.

2011-08-17 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073

Reviewed by Martin Robinson.

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Added gtk_box_new conditional compilation for gtk+-3.
13:01 Changeset [93337] by darin@apple.com

Made some code even more private to a particular file and class
https://bugs.webkit.org/show_bug.cgi?id=66428

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setDrawingAreaSize:]): Made this file internal.

  • UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
  • UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.
12:43 Changeset [93336] by commit-queue@webkit.org

A Worker constructor should throw TypeError, when the number of arguments is not enough
https://bugs.webkit.org/show_bug.cgi?id=66456

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/workers/worker-constructor.html

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

  • fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.
12:32 Changeset [93335] by commit-queue@webkit.org

Fix logic error causing reverse of desired WebGL rate limiting behavior
https://bugs.webkit.org/show_bug.cgi?id=66445

Patch by John Bates <jbates@google.com> on 2011-08-18
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::setTextureUpdated):

12:28 Changeset [93334] by leviw@chromium.org

Switch RenderTextControl* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66250

Reviewed by Eric Seidel.

Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.

No new tests as no change in behavior.

  • rendering/LayoutTypes.h:

(WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::preferredContentWidth):
(WebCore::RenderTextControlMultiLine::baselinePosition):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):

  • rendering/RenderTextControlSingleLine.h:
12:23 Changeset [93333] by leviw@chromium.org

Switch Inline rendering classes to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66239

Reviewed by Eric Seidel.

Converting inline rendering classes to use the LayoutUnit abstraction from ints.

No new tests as no change in functionality.

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::computeMargin):
(WebCore::RenderInline::culledInlineBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
(WebCore::RenderInline::addDashboardRegions):

  • rendering/RenderInline.h:
12:19 Changeset [93332] by jpfau@apple.com

New XML parser: add doctype to DOM tree
https://bugs.webkit.org/show_bug.cgi?id=66408

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processDOCTYPE):

12:17 Changeset [93331] by rniwa@webkit.org

Add a test to ensure WebKit does not paste contents before
https://bugs.webkit.org/show_bug.cgi?id=66481

Reviewed by Alexey Proskuryakov.

Add a regression test since this bug has been fixed by r92695.

  • editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
  • editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.
12:10 Changeset [93330] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=61016
[WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
This adds an implementation of in-process dedicated workers to chromium port.
The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:

  • In-process dedicated workers (this checkin)
  • Inter-process shared workers
  • Inter-process dedicated workers (defunct after this checkin)

This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
three implementations.
Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
(it will require coordinated changes on chromuium side).

Reviewed by David Levin.

  • public/WebCommonWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
(WebKit::WebWorkerClientImpl::hasPendingActivity):
(WebKit::WebWorkerClientImpl::workerObjectDestroyed):
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::sendMessageToInspector):
(WebKit::WebWorkerClientImpl::postMessageToPageInspector):
(WebKit::WebWorkerClientImpl::postTaskToLoader):
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
(WebKit::WebWorkerClientImpl::reportPendingActivity):
(WebKit::WebWorkerClientImpl::workerContextClosed):
(WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
(WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):

  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp:

(WebKit::WebWorkerImpl::newCommonClient):

  • src/WebWorkerImpl.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:
12:06 Changeset [93329] by commit-queue@webkit.org

[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834

Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Darin Fisher.

Source/WebCore:

Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a

draw-time transform.

*) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha

channel. The root layer is always opaque so this is fine.

*) The root layer does not have border texels and does have subpixel AA for text.

Covered by compositing/

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):

  • platform/graphics/chromium/NonCompositedContentHost.cpp: Added.

(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):

  • platform/graphics/chromium/NonCompositedContentHost.h: Added.

(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

LayoutTests:

Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.

  • compositing/checkerboard-expected.png:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
11:51 Changeset [93328] by thakis@chromium.org

Fix "missing return" gcc warning in ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=66480

Reviewed by Tony Chang.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):

11:49 Changeset [93327] by commit-queue@webkit.org

[GTK] [WK2] Activating sub menus cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=66471

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
Reviewed by Anders Carlsson.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::createGtkMenu):

11:41 Changeset [93326] by simonjam@chromium.org

Revalidate expired resources if they're requested after the initial document load
https://bugs.webkit.org/show_bug.cgi?id=52153

Reviewed by Antti Koivisto.

Source/WebCore:

Test: http/tests/cache/subresource-multiple-instances.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests:

  • http/tests/cache/subresource-multiple-instances-expected.txt: Added.
  • http/tests/cache/subresource-multiple-instances.html: Added.
11:29 Changeset [93325] by tony@chromium.org

[chromium] Marking tests needing win/linux baselines as such in
test_expectations.txt.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [93324] by rniwa@webkit.org

Dump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html
https://bugs.webkit.org/show_bug.cgi?id=66420

Reviewed by Kent Tamura.

Converted the test.

  • editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
  • editing/pasteboard/block-wrappers-necessary.html:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
11:21 Changeset [93323] by rniwa@webkit.org

Dump-as-markup conversion: editing/pasteboard/5368833.html
https://bugs.webkit.org/show_bug.cgi?id=66416

Reviewed by Kent Tamura.

Converted the test and also renamed the test to a more descriptive name.

  • editing/pasteboard/5368833.html: Removed.
  • editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
  • platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
  • platform/mac/editing/pasteboard/5368833-expected.png: Removed.
  • platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5368833-expected.txt: Removed.
11:09 Changeset [93322] by tony@chromium.org

Update chromium gpu expected results after r93275.

  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
10:59 Changeset [93321] by tony@chromium.org

Update baselines for mac and win after test changes/fixes in r93275.

  • platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:48 Changeset [93320] by tony@chromium.org

Add checksums to png results. Still trying to find out why they
went missing in the first place.

  • fast/frames/frame-set-scaling-3d-expected.png:
  • fast/frames/frame-set-scaling-centered-expected.png:
  • fast/frames/frame-set-scaling-expected.png:
  • fast/frames/frame-set-scaling-rotate-expected.png:
  • fast/frames/frame-set-scaling-skew-expected.png:
10:21 Changeset [93319] by andersca@apple.com

Fix libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66479

Reviewed by Adam Roben.

Add missing includes.

  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
10:20 Changeset [93318] by rniwa@webkit.org

dump-as-markup conversion: editing/pasteboard/testcase-9507.html
https://bugs.webkit.org/show_bug.cgi?id=66448

Reviewed by Kent Tamura.

Converted the test.

  • editing/pasteboard/testcase-9507-expected.txt: Added.
  • editing/pasteboard/testcase-9507.html:
  • platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
  • platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
  • platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
  • platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.
10:16 Changeset [93317] by andersca@apple.com

More C++0x libc++ build fixes
https://bugs.webkit.org/show_bug.cgi?id=66476

Reviewed by Adam Roben.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCSetException):
Use a WTF String here instead of an STL string.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
std::make_pair now takes rvalue references, so get rid of the template arguments and let
the compiler deduce them instead.

09:56 Changeset [93316] by andersca@apple.com

Fix clang libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66475

Reviewed by Adam Roben.

Remove calls to isnan and isfinite with integer arguments.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::viewport):

09:43 Changeset [93315] by aroben@apple.com

Update the device scale factor when the WebView's window changes

Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
WebView is moved between windows with different backing scale factors

Reviewed by Anders Carlsson.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.

Tools:

Test that WebKit updates style when a WebView is moved between differently-scaled windows

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::runJSTest): Moved a little bit of code from here...
(TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
gtest's built-in error messages.

  • TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and

WKView * for convenience on Mac. Added compareJSResult helper function for implementing
those overloads.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.

(-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Set up the client.
(TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
SyntheticBackingScaleFactorWindow and returns it.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
window, is moved to a differently-scaled window, and is taken out of the window.
(TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
WebKit1 and WebKit2.
(TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.

  • TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
  • TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.

(TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.

  • TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
  • TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.

(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
initializer.
(-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.

(-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
Overrides of NSWindow methods that WebKit uses to determine the device scale factor.

09:43 Changeset [93314] by aroben@apple.com

Make WebPageProxy keep track of the current device scale factor

The device scale factor is no longer considered part of WebPageProxy's "view state". It now
has its own setter/getter. This made the code a little simpler and more similar to the page
scale factor. Each port-specific WebKit2 view is now responsible for calling
WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
changed.

Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
the current device scale factor

Reviewed by Anders Carlsson.

  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/win/WebView.h:

Removed deviceScaleFactor.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
tells the DrawingAreaProxy about it if it's actually changed.
(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
to the PageClient.

  • UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which

replaces the DeviceScaleFactor ViewStateFlag.
(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.

09:39 Changeset [93313] by tony@chromium.org

Revert r93294, doesn't compile on Chromium Mac.

  • features.gypi:
09:36 Changeset [93312] by caseq@chromium.org

2011-08-18 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460

Reviewed by Pavel Feldman.

Tests: http/tests/inspector/extensions-network-redirect.html

inspector/extensions/extensions-network.html

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Network.requestDispatch): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Network.prototype.getHAR): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._inspectedURLChanged): (WebInspector.ExtensionServer.prototype._notifyRequestFinished): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._requestId): (WebInspector.ExtensionServer.prototype._requestById): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype.initExtensions): (WebInspector.ExtensionServer.prototype._onmessage):

2011-08-18 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460

Reviewed by Pavel Feldman.

  • http/tests/inspector/extensions-network-redirect-expected.txt: Added.
  • http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
  • http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js. (extension_getRequestByUrl.onHAR): (extension_getRequestByUrl):
  • http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
  • http/tests/inspector/extensions-useragent-expected.txt:
  • http/tests/inspector/extensions-useragent.html:
  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
  • inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.
08:51 Changeset [93311] by caio.oliveira@openbossa.org

[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

  • tests/testwebview.c:

(test_webkit_web_view_grab_focus):

08:39 Changeset [93310] by chang.shu@nokia.com

2011-08-18 Chang Shu <cshu@webkit.org>

[Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
failing on Windows since they were added
https://bugs.webkit.org/show_bug.cgi?id=66461

Reviewed by Adam Roben.

Skip the above tests as window.textInputController is not supported on windows.

  • platform/win/Skipped:
07:59 Changeset [93309] by abecsi@webkit.org

iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785

Add missing Qt results for tests added in r93287.

Unreviewed gardening.

  • platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
07:56 Changeset [93308] by podivilov@chromium.org

Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/content-providers.html

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):

LayoutTests:

  • inspector/debugger/content-providers-expected.txt: Added.
  • inspector/debugger/content-providers.html: Added.
07:36 Changeset [93307] by commit-queue@webkit.org

[CSSRegions] RenderRegion should not reference a parent RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142

Source/WebCore:

Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).

There are two cases:

  1. A RenderRegion tries to display the flow thread that laid it out. In this case

the region will be ignored and will not participate in the flow threads regions list.

  1. A RenderRegion tries to display a flow thread that contains another region that

tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

Tests: fast/regions/flows-dependency-dynamic-remove.html

fast/regions/flows-dependency-same-flow.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

  • fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • fast/regions/flows-dependency-dynamic-remove.html: Added.
  • fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • fast/regions/flows-dependency-same-flow.html: Added.
07:32 Changeset [93306] by vitalyr@chromium.org

2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:12 Changeset [93305] by vitalyr@chromium.org

2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:49 Changeset [93304] by podivilov@chromium.org

Web Inspector: add UISourceCode class.
https://bugs.webkit.org/show_bug.cgi?id=66233

Source/WebCore:

This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.

Reviewed by Pavel Feldman.

Test: inspector/debugger/ui-source-code.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/UISourceCode.js: Added.

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/ui-source-code-expected.txt: Added.
  • inspector/debugger/ui-source-code.html: Added.
06:26 Changeset [93303] by aroben@apple.com

Make WebCore keep track of the current device scale factor

Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.
  • css/MediaQueryEvaluator.cpp:

(WebCore::device_pixel_ratioMediaFeatureEval):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::devicePixelRatio):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addDashboardRegions):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::deviceScaleFactor):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:

Removed Chrome[Client]::deviceScaleFactor.

  • page/Frame.cpp:
  • page/Frame.h:

Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.

  • page/Page.cpp:

(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.

  • page/Page.h: Added m_deviceScaleFactor.

(WebCore::Page::deviceScaleFactor): Added simple getter.

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

Removed deviceScaleFactor.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:

Removed deviceScaleFactor.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

Removed deviceScaleFactor.

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

Removed deviceScaleFactor.

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Moved code to calculate the device scale factor from here...

  • WebView/WebView.mm:

(-[WebView _deviceScaleFactor]):
...to here.

(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.

  • Api/qwebpage_p.h: Removed pixelRatio.
  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

Removed deviceScaleFactor.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

Removed deviceScaleFactor.

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

Removed deviceScaleFactor.

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Removed deviceScaleFactor.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

Removed deviceScaleFactor.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):

  • WebProcess/WebPage/WebPage.h:

Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.

06:06 Changeset [93302] by rniwa@webkit.org

Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440

Reviewed by Kent Tamura.

Converted the tests.

  • editing/pasteboard/paste-text-010-expected.txt: Added.
  • editing/pasteboard/paste-text-010.html:
  • editing/pasteboard/paste-text-015-expected.txt: Added.
  • editing/pasteboard/paste-text-015.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.
05:36 Changeset [93301] by rniwa@webkit.org

Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443

Reviewed by Kent Tamura.

Converted the tests.

  • editing/pasteboard/paste-text-017-expected.txt: Added.
  • editing/pasteboard/paste-text-017.html:
  • editing/pasteboard/paste-text-018-expected.txt: Added.
  • editing/pasteboard/paste-text-018.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.
05:25 Changeset [93300] by darin@apple.com

SVG and HTML editing have conflicting inline isWhitespace functions
https://bugs.webkit.org/show_bug.cgi?id=65145

Reviewed by Nikolas Zimmermann.

Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::parsePoint): Call skipOptionalSVGSpaces.

  • svg/SVGAnimationElement.cpp:

(WebCore::parseKeySplines): Ditto.

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox): Ditto.

  • svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.

  • svg/SVGParserUtilities.cpp:

(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.

  • svg/SVGParserUtilities.h:

(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.

  • svg/SVGPathStringSource.cpp:

(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.

  • svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.

  • svg/SVGTransformable.cpp:

(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.

04:52 Changeset [93299] by steveblock@google.com

Remove a superfluous 'using' from WebBindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=66046

Reviewed by Alexey Proskuryakov.

  • src/WebBindings.cpp:
04:47 Changeset [93298] by fpizlo@apple.com

[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66426

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Changed the branchTestPtr to branchTest32.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.

  • fast/js/mod-by-zero-expected.txt: Added.
  • fast/js/mod-by-zero.html: Added.
  • fast/js/script-tests/mod-by-zero.js: Added.

(mod):

04:43 Changeset [93297] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=66425
check-webkit-style should detect incorrectly formatted file change descriptions.
Description, if present, should be separated from colon with a space.

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/changelog.py: Fix.
  • Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
04:10 Changeset [93296] by gavinp@chromium.org

Prepare frames for history navigation.

Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.

https://bugs.webkit.org/show_bug.cgi?id=66322

Reviewed by Darin Fisher.

Source/WebCore:

No new tests, as history navigation is very difficult to test in
DumpRenderTree.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForHistoryNavigation):

  • loader/FrameLoader.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):

04:05 Changeset [93295] by commit-queue@webkit.org

When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
https://bugs.webkit.org/show_bug.cgi?id=66282

Patch by Jing Zhao <jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

No new tests since it only changes the behavior in Android Browser.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):

04:02 Changeset [93294] by thakis@chromium.org

[chromium/mac] Enable smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=66418

Reviewed by Dimitri Glazkov.

  • features.gypi:
03:33 Changeset [93293] by steveblock@google.com

Remove TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html
http://code.google.com/p/chromium/issues/detail?id=93044

This test should now pass after Chromium rolled V8 to 3.5.6 in r97287.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
03:22 Changeset [93292] by adamk@chromium.org

Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
https://bugs.webkit.org/show_bug.cgi?id=66321

Reviewed by Darin Adler.

Source/WebCore:

This is simply a cleanup change: there's no need that I can see for
HTMLFormControlElement and HTMLObjectElement to override
Element::attributeChanged since they can properly handle form
attribute changes in parseMappedAttribute, which they also override.

Though no change in behavior, I've added test coverage of the moved
code to an existing test (fast/forms/form-attribute.html) and added
a new test.

Test: fast/forms/radio-remove-form-attr.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseMappedAttribute):

  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

  • html/HTMLObjectElement.h:

LayoutTests:

Added new coverage to ensure that adding a radio button to a radio
group in the document by removing a form attribute leaves the group in
a valid state (no more than one button checked).

Beefed up coverage of form associated elements to better cover
HTMLObjectElement.

  • fast/forms/form-attribute-expected.txt:
  • fast/forms/radio-remove-form-attr-expected.txt: Added.
  • fast/forms/radio-remove-form-attr.html: Added.
  • fast/forms/script-tests/form-attribute.js:

Added coverage of <object form=""> behavior.

03:19 Changeset [93291] by commit-queue@webkit.org

Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052

Patch by Chang Shu <cshu@webkit.org> on 2011-08-18
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added runtime settings in WebCore.
Added support in window.internals for testing.

Tests: editing/input/password-echo-passnode.html

editing/input/password-echo-passnode2.html
editing/input/password-echo-passnode3.html
editing/input/password-echo-textnode.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):

  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/qt:

Enable password echo under the build flag.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

LayoutTests:

Added tests.

  • editing/input/password-echo-passnode-expected.txt: Added.
  • editing/input/password-echo-passnode.html: Added.
  • editing/input/password-echo-passnode2-expected.txt: Added.
  • editing/input/password-echo-passnode2.html: Added.
  • editing/input/password-echo-passnode3-expected.txt: Added.
  • editing/input/password-echo-passnode3.html: Added.
  • editing/input/password-echo-textnode-expected.txt: Added.
  • editing/input/password-echo-textnode.html: Added.
  • editing/input/resources: Added.
  • editing/input/resources/password-echo.js: Added.

(secureChar):
(secureText):
(log):
(assert):
(run.else):
(run):
(init):

  • platform/wk2/Skipped: No support yet.
01:44 Changeset [93290] by commit-queue@webkit.org

Selecting all and inserting text into a page with a frameset leads to a NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66288

Source/WebCore:

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
a new endingSelection, which isn't a sane state to be in. The code
tries to get a position on a higher node for a better selection, but
cannot go above the frameset (which exists in place of the body tag),
which lacks a renderer, and therefore cannot have a non-NoSelection
VisibleSelection.

Because this is a rare corner case, it seemed more reasonable to bail
out in this circumstance than to change the way VisibleSelection
canonicalization works. The new behavior is to delete the content, but
insert nothing. I investigated the possibility of trying to move above
or below the frameset in this particular case, but there still isn't a
renderer, so it didn't prevent the crash.

Test: editing/inserting/insert-text-into-empty-frameset-crash.html

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

LayoutTests:

This test selects all and inserts text in a page which contains a frameset.
It tests for a crash caused by a NULL ptr which can occur in InsertText::doApply.

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

  • editing/inserting/insert-text-into-empty-frameset-crash-expected.txt: Added.
  • editing/inserting/insert-text-into-empty-frameset-crash.html: Added.
01:09 Changeset [93289] by reni@webkit.org

[Qt] Correct the path in the Skipped list after 93283.

Unreviewed gardening.

  • platform/qt/Skipped:
01:02 Changeset [93288] by commit-queue@webkit.org

Remove arguments from CloseEvent::create().
https://bugs.webkit.org/show_bug.cgi?id=66294

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

CloseEvent objects are initialized by initCloseEvent() in all cases.
Initialization in create() is redundant.

No new tests for no functional difference.

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didClose):

00:23 Changeset [93287] by fsamuel@chromium.org

iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785

Source/WebCore:

Reviewed by Simon Fraser.

Fixed two iframe and frameset scaling bugs:

#1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
#2 frameset does not respect -webkit-transform-origin when scaled

Tests: fast/frames/frame-set-scaling-3d.html

fast/frames/frame-set-scaling-centered.html
fast/frames/frame-set-scaling-rotate.html
fast/frames/frame-set-scaling-skew.html
fast/frames/frame-set-scaling.html
fast/frames/iframe-scaling-with-scroll.html

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.

LayoutTests:

Added tests to verify that framesets and iframes are scaled and positioned correctly.

Reviewed by Simon Fraser.

  • fast/frames/frame-set-scaling-3d-expected.png: Added.
  • fast/frames/frame-set-scaling-3d-expected.txt: Added.
  • fast/frames/frame-set-scaling-3d.html: Added.
  • fast/frames/frame-set-scaling-centered-expected.png: Added.
  • fast/frames/frame-set-scaling-centered-expected.txt: Added.
  • fast/frames/frame-set-scaling-centered.html: Added.
  • fast/frames/frame-set-scaling-expected.png: Added.
  • fast/frames/frame-set-scaling-expected.txt: Added.
  • fast/frames/frame-set-scaling-rotate-expected.png: Added.
  • fast/frames/frame-set-scaling-rotate-expected.txt: Added.
  • fast/frames/frame-set-scaling-rotate.html: Added.
  • fast/frames/frame-set-scaling-skew-expected.png: Added.
  • fast/frames/frame-set-scaling-skew-expected.txt: Added.
  • fast/frames/frame-set-scaling-skew.html: Added.
  • fast/frames/frame-set-scaling.html: Added.
  • fast/frames/iframe-scaling-with-scroll.html: Added.
  • platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
00:21 Changeset [93286] by abarth@webkit.org

webkit-patch pretty-diff should be shown in main help
https://bugs.webkit.org/show_bug.cgi?id=66404

Reviewed by Dimitri Glazkov.

As requested by dglazkov.

  • Scripts/webkitpy/tool/commands/prettydiff.py:

08/17/11:

23:58 Changeset [93285] by ossy@webkit.org

Unreviewed buildfix after r93268.

  • dom/Document.cpp:

(WebCore::disableRangeMutation):

23:37 Changeset [93284] by eae@chromium.org

Switch RenderBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66156

Reviewed by Eric Seidel.

Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.

No new tests as no new functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):

23:34 Changeset [93283] by reni@webkit.org

[Qt] Unreviewed gardening

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-08-17

  • platform/qt/Skipped: Skip new failures.
21:47 Changeset [93282] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=66400
Fix TestWebKitAPI build on Mac OS.

Reviewed by David Levin.

  • TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
21:22 Changeset [93281] by sullivan@chromium.org

Reduce usages of String::createUninitialized
https://bugs.webkit.org/show_bug.cgi?id=66399

Constructs Strings with StringBuilder instead of calling createUninitialized.

Reviewed by Adam Barth.

No new tests; no functional change.

  • dom/StyleElement.cpp:

(WebCore::StyleElement::process):

  • dom/Text.cpp:

(WebCore::Text::wholeText):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

  • platform/graphics/Font.cpp:

(WebCore::Font::normalizeSpaces):

  • platform/text/TextCodecUserDefined.cpp:

(WebCore::TextCodecUserDefined::decode):

21:06 Changeset [93280] by eae@chromium.org

Switch FrameView to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66147

Reviewed by Eric Seidel.

Convert Frame & FrameView to new layout abstraction as a part of the
ongoing conversion work.

No new tests, no new functionality.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::scalePage):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::reset):
(WebCore::FrameView::init):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setMarginWidth):
(WebCore::FrameView::setMarginHeight):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::scrollOffsetForFixedPosition):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

  • page/FrameView.h:

(WebCore::FrameView::marginWidth):
(WebCore::FrameView::marginHeight):

  • page/mac/FrameMac.mm:

(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):

20:38 Changeset [93279] by eae@chromium.org

Switch html/* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66347

Reviewed by Eric Seidel.

Convert HTML* and shadow element to new layout abstraction as a part of
the ongoing conversion work.

No new tests, no new functionality.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::invalidateCachedRegion):
(WebCore::HTMLAreaElement::mapMouseEvent):
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::getRegion):

  • html/HTMLAreaElement.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/HTMLCanvasElement.h:
  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

  • html/HTMLMapElement.h:
  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::continueDrag):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::defaultEventHandler):

  • html/shadow/MediaControlElements.h:
  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::dragFrom):
(WebCore::SliderThumbElement::setPositionFromPoint):

  • html/shadow/SliderThumbElement.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

20:24 Changeset [93278] by commit-queue@webkit.org

Change references to leveldb.gyp to leveldatabase.gyp as part of the
leveldb refactoring going on in chromium: crbug.com/89378
https://bugs.webkit.org/show_bug.cgi?id=66332

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Gentilcore.

Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb

  • WebCore.gyp/WebCore.gyp:
19:56 Changeset [93277] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=66379
implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-08-17
Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):

  • jit/JIT.h:
19:41 Changeset [93276] by hayato@chromium.org

Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=61421

Reviewed by Dimitri Glazkov.

Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
that focus/blue events are stopped at the lowest common shadow boundary.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Event.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):

  • dom/Event.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

  • dom/Node.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchBlurEvent):

  • html/HTMLFormControlElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):

  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):

  • html/HTMLTextFormControlElement.h:
  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events.html:
19:14 Changeset [93275] by commit-queue@webkit.org

Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66036

Source/WebCore:

These modes cannot be passed straight through to the underlying graphics context as the graphics context
and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
the entire canvas.

The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
area being filled.

Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
transformed path being filled contained anti-aliasing at its edges artifacts were introduced.

With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
appropriate mode, with any areas outside the draw area being cleared.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

Test: fast/canvas/canvas-composite-transformclip.html

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

  • fast/canvas/canvas-composite-alpha.html:
  • fast/canvas/canvas-composite-transformclip-expected.txt: Added.
  • fast/canvas/canvas-composite-transformclip.html: Added.
  • platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/canvas/canvas-composite-expected.png:
  • platform/mac/fast/canvas/canvas-composite-transformclip-expected.png: Added.
19:00 Changeset [93274] by eae@chromium.org

Switch inspector to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66358

Reviewed by Eric Seidel.

Convert inspector code to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawNodeHighlight):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willPaint):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createPaintData):

  • inspector/TimelineRecordFactory.h:
18:31 Changeset [93273] by leviw@chromium.org

Switch Editing code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66355

Reviewed by Eric Seidel.

Converting remaining editing code to the LayoutUnit abstraction.

No new tests, no change in functionality.

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::insideVisibleArea):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:
  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

18:18 Changeset [93272] by leviw@chromium.org

Switch Accessibility code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66348

Reviewed by Eric Seidel.

Converting remaining Accessibility code to the LayoutUnit abstraction.

No new tests, no change in functionality

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::elementRect):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::elementAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::elementRect):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::elementRect):

  • accessibility/AccessibilityMenuListOption.h:

(WebCore::AccessibilityMenuListOption::size):

  • accessibility/AccessibilityMenuListPopup.h:

(WebCore::AccessibilityMenuListPopup::elementRect):
(WebCore::AccessibilityMenuListPopup::size):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clickPoint):
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::boundingBoxRect):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::elementRect):
(WebCore::AccessibilityRenderObject::size):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::elementRect):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::elementRect):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):
(WebCore::AccessibilitySliderThumb::size):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

18:02 Changeset [93271] by jonlee@apple.com

Updating the forms survey to include various element sizes.

  • projects/forms/survey.html:
17:49 Changeset [93270] by eae@chromium.org

Switch focus handling to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66331

Reviewed by Eric Seidel.

Convert FocusController and SpatialNavigation to new layout abstraction
as a part of the ongoing conversion work.

No new tests, no new functionality.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/FocusController.h:
  • page/SpatialNavigation.cpp:

(WebCore::alignmentForRects):
(WebCore::start):
(WebCore::middle):
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::deflateIfOverlapped):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::distanceDataForNode):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):

  • page/SpatialNavigation.h:
17:36 Changeset [93269] by leviw@chromium.org

Switch Document, DocumentMarker, Clipboard, and Range to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66330

Reviewed by Eric Seidel.

Converting the remaining DOM classes to use the LayoutUnit abstraction.

No new tests, no new behavior.

  • dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):
(WebCore::nodeFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::prepareMouseEvent):

  • dom/Document.h:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):

  • dom/DocumentMarkerController.h:
  • dom/Range.cpp:

(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):

  • dom/RenderedDocumentMarker.h:

(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setRenderedRect):
(WebCore::RenderedDocumentMarker::renderedRect):
(WebCore::RenderedDocumentMarker::invalidMarkerRect):
(WebCore::RenderedDocumentMarker::invalidate):

17:17 Changeset [93268] by mitz@apple.com

Source/WebCore: Removed an unused setting.

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • page/Settings.cpp:

(WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.

  • page/Settings.h: Removed accessors.

Source/WebKit/mac: Removed some code that is not needed when building for Leopard or later.

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Removed check for Tiger Mail.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::objectContentType):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

17:11 Changeset [93267] by mrowe@apple.com

Merge r93070.

17:11 Changeset [93266] by mrowe@apple.com

Versioning.

17:09 Changeset [93265] by mrowe@apple.com

New tag.

17:08 Changeset [93264] by oliver@apple.com

Move towards supporting user controlled prototypes on CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=66429

Reviewed by Gavin Barraclough.

Start using a per-global object structure for canvas pixel array.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

17:06 Changeset [93263] by macpherson@chromium.org

Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=66281

Reviewed by Eric Seidel.

No new tests - refactoring only.

The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from unsigned to CSSPrimitiveValue
(WebCore::CSSPrimitiveValue::operator unsigned):
Support cast from CSSPrimitiveValue to unsigned

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.

16:55 Changeset [93262] by commit-queue@webkit.org

ScrollAnimatorNone: Remove unused field
https://bugs.webkit.org/show_bug.cgi?id=66312

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-17
Reviewed by Adam Barth.

Source/WebCore:

No functional change; no test needed.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):

16:37 Changeset [93261] by mitz@apple.com

Eliminate the WebCGFloat compatibility definition that was needed for Tiger.

Rubber-stamped by Anders Carlsson.

  • WebView/WebHTMLViewPrivate.h:
16:32 Changeset [93260] by jeffm@apple.com

Work-in-progress on Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725

Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
is enabled.

Reviewed by Anders Carlsson.

No new tests; no functional change.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).

(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.

16:28 Changeset [93259] by dglazkov@chromium.org

garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
https://bugs.webkit.org/show_bug.cgi?id=66427

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.

():

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
16:16 Changeset [93258] by mitz@apple.com

Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
needed for Tiger.

Reviewed by Darin Adler.

  • History/WebBackForwardList.h:
  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLRepresentation.h:
  • WebView/WebPreferences.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebResourceLoadDelegatePrivate.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebTextIterator.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebViewPrivate.h:
16:14 Changeset [93257] by jochen@chromium.org

Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=65877

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
16:08 Changeset [93256] by dglazkov@chromium.org

Remove base.keys and replace it with Object.keys.
https://bugs.webkit.org/show_bug.cgi?id=66422

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
16:04 Changeset [93255] by jamesr@google.com

Merge 92520 - [chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402

Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.

Source/WebCore:

Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.

  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Source/WebKit/chromium:

Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

TBR=apatrick@chromium.org
BUG=80703
Review URL: http://codereview.chromium.org/7671031

15:51 Changeset [93254] by dglazkov@chromium.org

garden-o-matic Summary view should have items in descending chronological order.
https://bugs.webkit.org/show_bug.cgi?id=66403

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
15:41 Changeset [93253] by jamesr@google.com

Merge 92430 - [chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:

TBR=commit-queue@webkit.org
BUG=80703
Review URL: http://codereview.chromium.org/7670046

15:41 Changeset [93252] by dglazkov@chromium.org

Fix a few errors in garden-o-matic frontend unit tests.
https://bugs.webkit.org/show_bug.cgi?id=66421

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
15:31 Changeset [93251] by tony@chromium.org

[chromium] remove stale result and mark 3 new authentication tests as
failing because chromium drt is missing a function. Also mark
midword-break-before-surrogate-pair-2.html as failing on mac.

  • platform/chromium-cg-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:17 Changeset [93250] by tony@chromium.org

[chromium] fast/text/midword-break-before-surrogate-pair-2.html is failing
on win and linux due to missing glyph.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [93249] by mrowe@apple.com

Use the LLVM Compiler for optimized builds when recent enough versions of it are available.

Rubber-stamped by Sam Weinig.

14:57 Changeset [93248] by mrowe@apple.com

Bring some consistency to the CompilerVersion.xcconfig files. They all now include REAL_PLATFORM_NAME in the relevant setting names.

Rubber-stamped by Sam Weinig.

14:43 Changeset [93247] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
Regression: On Lion, redirects lose HTTP authentication headers

Source/WebCore:

Reviewed by Alexey Proskuryakov and Darin Adler.

This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
assuming the redirected URL did not contain credentials directly.

Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html

http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

LayoutTests:

These have to be in different paths to prevent credentials from leaking over from test to test.
Sad sad sad...

Reviewed by Alexey Proskuryakov.

  • http/tests/misc/authentication-redirect-1: Added.
  • http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect-expected.txt.
  • http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect.html.
  • http/tests/misc/authentication-redirect-1/resources: Added.
  • http/tests/misc/authentication-redirect-1/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-redirect-2: Added.
  • http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
  • http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html: Added.
  • http/tests/misc/authentication-redirect-2/resources: Added.
  • http/tests/misc/authentication-redirect-2/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-redirect-3: Added.
  • http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
  • http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html: Added.
  • http/tests/misc/authentication-redirect-3/resources: Added.
  • http/tests/misc/authentication-redirect-3/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php: Added.
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • http/tests/misc/authentication-sent-to-redirect.html: Removed.
  • http/tests/misc/resources/auth-echo.php: Removed.
  • http/tests/misc/resources/auth-then-redirect.php: Removed.
14:34 Changeset [93246] by cfleizach@apple.com

Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174

Reviewed by Darin Adler.

Forgot to commit review comments.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):

14:29 Changeset [93245] by rniwa@webkit.org

Dump-as-markup conversion: editing/inserting/insert-3786362-fix.html
https://bugs.webkit.org/show_bug.cgi?id=66396

Reviewed by Chang Shu.

Converted the test.

  • editing/inserting/insert-3786362-fix-expected.txt: Added.
  • editing/inserting/insert-3786362-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/gtk/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/mac-leopard/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3786362-fix-expected.txt: Removed.
14:26 Changeset [93244] by jamesr@google.com

Merge 91736 - Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=65043

BUG=80703

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7631029

14:24 Changeset [93243] by cfleizach@apple.com

Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174

Source/WebCore:

Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
creation flow. That can lead to loops.

Reviewed by Darin Adler.

Tests: accessibility/crash-determining-aria-role-when-label-present.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/crash-determining-aria-role-when-label-present-expected.txt: Added.
  • accessibility/crash-determining-aria-role-when-label-present.html: Added.
14:16 Changeset [93242] by abarth@webkit.org

Update Tools to account for (CG) being added to Chromium builder names
https://bugs.webkit.org/show_bug.cgi?id=66410

Reviewed by Adam Barth.

Some of these names will change back once we turn on Skia bots.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
14:13 Changeset [93241] by dglazkov@chromium.org

Wire up relative time to garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=66343

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
14:08 Changeset [93240] by aroben@apple.com

Make run-api-tests run tests in alphabetical order

Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order

Reviewed by David Kilzer.

  • Scripts/run-api-tests:

(runAllTests):
(runAllTestsInSuite):
Sort the lists of tests and suites before iterating over them.

13:58 Changeset [93239] by jamesr@google.com

[chromium] Crash if compositing is disabled during updateLayers()
https://bugs.webkit.org/show_bug.cgi?id=66353

Reviewed by Kenneth Russell.

If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
drawLayers() has to return without doing anything if the root layer is null.

Crash fixed based on crash reports. No known reliably repro case, unfortunately.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

13:54 Changeset [93238] by fpizlo@apple.com

JSC verbose debugging output sometimes doesn't work as expected.
https://bugs.webkit.org/show_bug.cgi?id=66107

Reviewed by Gavin Barraclough.

Hardened the CodeBlock::dump() code so that it no longer crashes. Improved
the DFG verbose code so that it prints slightly more useful information.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::debugSize):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfRegExps):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

13:52 Changeset [93237] by mitz@apple.com

<rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=66402

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/midword-break-before-surrogate-pair-2.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
break before a trailing surrogate.

LayoutTests:

  • fast/text/midword-break-before-surrogate-pair-2.html: Added.
13:15 Changeset [93236] by abarth@webkit.org

garden-o-matic should be able to rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=66204

Reviewed by Dimitri Glazkov.

This patch introduces a new view for displaying expect, actual, and
differences between results. The new view also has a fledgling
controller that handles some basic operations. The new view is
exercised by rebaseline.html, which lets you rebaselines expected
failures, but the new view is not fully integrated into
garden-o-matic.html

More patches will be required to make this stuff fully working, but
this patch was already somewhat spiraling out of control. Hopefully
this patch will serve as a good starting point for further development.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
12:59 Changeset [93235] by chang.shu@nokia.com

2011-08-16 Chang Shu <cshu@webkit.org>

Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

New tests will be added when function reset is implemented.

Added framework code in WebCoreTestSupport. The real implementation of
Internals::reset() depends on the need from the settings that require a reset.

  • testing/Internals.cpp: (WebCore::Internals::reset):
  • testing/Internals.h:
  • testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
  • testing/js/WebCoreTestSupport.h:
  • testing/v8/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
  • testing/v8/WebCoreTestSupport.h:

2011-08-16 Chang Shu <cshu@webkit.org>

Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added framework code in WebKit.

  • public/WebTestingSupport.h:
  • src/WebTestingSupport.cpp: (WebKit::WebTestingSupport::resetInternalsObject):

2011-08-16 Chang Shu <cshu@webkit.org>

Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added framework code in WebKit.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::resetInternalsObject):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-08-16 Chang Shu <cshu@webkit.org>

Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added call to resetInternalsObject in DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
12:44 Changeset [93234] by rniwa@webkit.org

Rebaseline for Windows, Chromium Windows, and Chromium Linux after r93221.

  • platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
12:11 Changeset [93233] by andersca@apple.com

Remove unused Core Animation related classes
https://bugs.webkit.org/show_bug.cgi?id=66393

Reviewed by Darin Adler.

  • Shared/mac/CoreAnimationRenderer.h: Removed.
  • Shared/mac/CoreAnimationRenderer.mm: Removed.
  • Shared/mac/ShareableSurface.cpp: Removed.
  • Shared/mac/ShareableSurface.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
12:10 Changeset [93232] by aroben@apple.com

Update Windows Results for svg/W3C-SVG-1.1-SE/text-intro-05-t.svg

  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.

These results were checked in to platform/win but were really XP-specific.

  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:

Updated these results for Windows 7.

11:56 Changeset [93231] by alexis.menard@openbossa.org

Add a new build slave for the Qt port on Mac OS SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=66392

Modify the config file to include the new build slave.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:53 Changeset [93230] by tony@chromium.org

[chromium] Mark fast/canvas/webgl/data-view-crash.html as flaky
on linux debug.

  • platform/chromium/test_expectations.txt:
11:44 Changeset [93229] by tony@chromium.org

Fix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved
and the WebCore.gypi file wasn't updated.

  • WebCore.gypi:
11:39 Changeset [93228] by aa@chromium.org

Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

11:29 Changeset [93227] by inferno@chromium.org

Source/WebCore: Crash in Document::recalcStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.

Test: svg/dom/stylesheet-candidate-node-crash-main.html

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::~HTMLStyleElement):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::~SVGStyleElement):

LayoutTests: Tests that we do not crash when iterating through stylesheet
candidate list hashset.
https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

  • svg/dom/resources/stylesheet-candidate-node-crash.svg: Added.
  • svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added.
  • svg/dom/stylesheet-candidate-node-crash-main.html: Added.
11:28 Changeset [93226] by commit-queue@webkit.org

Source/WebCore: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

Updated accessibilityTable to return level values consistent with other accessibilityObjects that
return level values. This means a value of 0 is now only returned when tableLevel() is called on a
non-table element.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/element-level.html

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableLevel):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

Added the ability to get numeric attribute values using numberAttributeValue. This
function complements the existing stringAttributeValue and boolAttributeValue functions.
The addition of numberAttributeValue was necessary because the stringAttributeValue
function does a type check and will only return strings. This limitation made it
impossible to get values for attributes that returned an NSNumber.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(numberAttributeValueCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::numberAttributeValue):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::numberAttributeValue):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::numberAttributeValue):

LayoutTests: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

This test ensures that all AccessibilityObjects that return a level value return consistent results.
For example, a level of 0 should only be returned by a level function when it is called on an
AccessibilityObject of the wrong type. It's especially important that we enforce this consistency
using layout tests because these level values are not defined by the W3C but are still used by
popular screen readers such as VoiceOver.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/element-level-expected.txt: Added.
  • platform/mac/accessibility/element-level.html: Added.
11:21 Changeset [93225] by aa@chromium.org

Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

11:17 Changeset [93224] by aroben@apple.com

Tell Trac logs always to display all specified revisions in a single page

Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.

Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:

Updated tests for the above.

11:13 Changeset [93223] by aroben@apple.com

Fix TestFailures's link to file a bug about TestFailures itself

Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
bug about itself is broken

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
the host from the path.

11:13 Changeset [93222] by aroben@apple.com

Teach TestFailures to ignore unbelievably short test runs

Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
that caused it not to run any tests at all (as happened for a while due to
<http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Test for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.

11:07 Changeset [93221] by rniwa@webkit.org

An arrow key collapses directionless selection range in the wrong direction in BiDi
https://bugs.webkit.org/show_bug.cgi?id=64626

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.

Test: editing/selection/collapse-selection-in-bidi.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.

  • editing/FrameSelection.h:

LayoutTests:

Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.

  • editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • editing/selection/collapse-selection-in-bidi.html: Added.
11:04 Changeset [93220] by commit-queue@webkit.org

Remove onTimeout from WebIDBTransactionCallbacks.h
https://bugs.webkit.org/show_bug.cgi?id=66326

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.

  • public/WebIDBTransactionCallbacks.h:
10:57 Changeset [93219] by jeffm@apple.com

Some AVFoundation source files should be in platform-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66352

Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.

Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.

Reviewed by Eric Carlson.

No new tests; no functional change.

  • WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.
  • WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.
  • platform/graphics/avfoundation/cf: Added.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.
  • platform/graphics/avfoundation/objc: Added.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.
10:45 Changeset [93218] by macpherson@chromium.org

Only set m_fontDirty if TextSizeAdjust is actually changed.
https://bugs.webkit.org/show_bug.cgi?id=66022

Reviewed by Darin Adler.

No new tests. Refactoring only.

Reduces instances where the font information is dirtied to save recalculation where it is not necessary.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.

10:45 Changeset [93217] by steveblock@google.com

Unreviewed, rolling out r93204.
http://trac.webkit.org/changeset/93204
https://bugs.webkit.org/show_bug.cgi?id=66375

Test no longer crashing since r93171

  • platform/chromium/test_expectations.txt:
10:23 Changeset [93216] by bashi@chromium.org

[Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=66211

Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.

Reviewed by Tony Chang.

No new tests; no functional change.

  • platform/graphics/chromium/HarfbuzzSkia.cpp:

(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.

  • platform/graphics/chromium/HarfbuzzSkia.h:
10:16 Changeset [93215] by jeffm@apple.com

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
10:16 Changeset [93214] by tony@chromium.org

[chromium] Add chromium baselines for tests added in r93144.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/chromium/test_expectations.txt:
09:59 Changeset [93213] by tony@chromium.org

[chromium] Mark svg/custom/repaint-shadow.svg and
media/media-blocked-by-beforeload.html as flaky.

  • platform/chromium/test_expectations.txt:
09:25 Changeset [93212] by tony@chromium.org

[chromium] Fix typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
09:02 Changeset [93211] by aroben@apple.com

Skip another <progress> test on Windows

  • platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.
08:49 Changeset [93210] by steveblock@google.com

Web Inspector: http/tests/inspector/network/disabled-cache-crash.html flaky
https://bugs.webkit.org/show_bug.cgi?id=65558

Add TIMEOUT expectation.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
08:22 Changeset [93209] by aroben@apple.com

Add Windows expected failure results for text-combine-image-test.html

Failure is tracked by <http://webkit.org/b/66376>.

  • platform/win/fast/text/international/text-combine-image-test-expected.png:
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:
08:21 Changeset [93208] by aroben@apple.com

Add Windows expected failure results for new test added in r93068

Failure is tracked by <http://webkit.org/b/66374>.

  • platform/win/editing/deleting/regional-indicators-expected.txt: Added.
08:21 Changeset [93207] by aroben@apple.com

Add Windows results for new test added in r91777

  • platform/win/fast/css/font-family-pictograph-expected.png: Added.
  • platform/win/fast/css/font-family-pictograph-expected.txt: Added.
07:05 Changeset [93206] by aroben@apple.com

Add Windows results for tests that differ from Lion due to font differences

These tests started failing in r93107 when I made Windows fall back to Lion results instead
of SnowLeopard results. This is good in general, but these particular tests happen to give
SnowLeopard-ish results due to some fonts that changed in Lion.

  • platform/win/css1/font_properties/font-expected.png: Added.
  • platform/win/css1/font_properties/font-expected.txt: Copied from platform/mac-snowleopard/css1/font_properties/font-expected.txt.
  • platform/win/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/win/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Added.
  • platform/win/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/win/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt.
  • platform/win/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/win/fast/text/capitalize-boundaries-expected.txt: Copied from platform/win/fast/text/capitalize-boundaries-expected.txt.
07:04 Changeset [93205] by aroben@apple.com

Add Windows expected failures results for new test added in r93144

Failure is tracked by <http://webkit.org/b/56101>.

  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
06:50 Changeset [93204] by steveblock@google.com

http/tests/misc/font-face-in-multiple-segmented-faces.html assertion failure on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66375

Sets a CRASH expectation for Windows debug.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
06:05 Changeset [93203] by steveblock@google.com

Set failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin-in-iframe.html for all build flavors
http://crbug.com/26042

The test already has a failing TEXT expectation for DEBUG and for
LINUX RELEASE, but we're now seeing failures on Mac10.6. It looks like
it's generally flaky.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
04:45 Changeset [93202] by commit-queue@webkit.org

Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=66311

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarMinimumTotalLengthNeededForThumb):

04:42 Changeset [93201] by steveblock@google.com

Unreviewed, rolling out r93186.
http://trac.webkit.org/changeset/93186
https://bugs.webkit.org/show_bug.cgi?id=66114

Breaks LayoutTests on Chromium canary bots

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

LayoutTests:

  • compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Removed.
  • compositing/backface-visibility-hierarchical-transform.html: Removed.
03:54 Changeset [93200] by ossy@webkit.org

[Qt] REGRESSION after r93011
https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
    • Unskip fast/css/font-face-opentype.html.
    • Unskip http/tests/security/cross-frame-access-put.html, because it passes now.
  • platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Update Qt 4.8 specific expected result.
03:52 Changeset [93199] by rniwa@webkit.org

Get rid of calls to deprecatedNode and deprecatedEditingOffset in
AccessibilityRenderObject.cpp and InsertTextCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=66014

Reviewed by Hajime Morita.

Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
and deprecatedEditingOffset.
(WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.

  • dom/Position.h:

(WebCore::Position::rootEditableElement): Added.

  • dom/Range.cpp:

(WebCore::Range::setStart): Added.
(WebCore::Range::setEnd): Added.

  • dom/Range.h:
  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/RenderedPosition.cpp:

(WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.

  • editing/RenderedPosition.h:
03:49 Changeset [93198] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
    • Unskip tests removed by r93095.
    • Skip fast/repaint/japanese-rl-selection-repaint-in-regions.html introduced in r93144.
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added. (test introduced in r93144)
01:28 Changeset [93197] by commit-queue@webkit.org

Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
https://bugs.webkit.org/show_bug.cgi?id=66238

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:

  1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
  2. animation is delayed because shouldSuspendScrollAnimations() is true
  3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
  4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.

It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.

Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterForceFlashScrollers):

01:26 Changeset [93196] by caseq@chromium.org

2011-08-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131

Reviewed by Pavel Feldman.

Test: inspector/view-events.html

  • added a notion of an optional parent to a View
  • maintain a list of View children
  • dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
  • promoted Panel's logic of (re)storing scroll positions to view
  • demoted inheritScrollPositionFromView to a couple of views that need it.
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype.onResize):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.populateStatusBar): (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.onResize): (WebInspector.SimpleCookiesTable.prototype.onResize):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.onResize):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.onResize):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.onResize): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.onResize):
  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.onResize):
  • inspector/front-end/IFrameView.js: (WebInspector.IFrameView):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView.prototype._installHighlightSupport):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView): (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkLogView.prototype.onResize): (WebInspector.NetworkLogView.prototype.wasShown): (WebInspector.NetworkLogView.prototype.willHide): (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.performSearch.processChunk): (WebInspector.Panel.prototype.performSearch): (WebInspector.Panel.prototype.updateSidebarWidth):
  • inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView.prototype.show): (WebInspector.PanelEnablerView.prototype.onResize):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.onResize):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.onResize):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
  • inspector/front-end/ResourceResponseView.js: (WebInspector.ResourceResponseView.prototype.contentLoaded):
  • inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.prototype.show):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.ResourcesPanel.prototype.closeVisibleView): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.willHide): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.inheritScrollPositions):
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TextViewer.prototype.inheritScrollPositions): (WebInspector.TextViewer.prototype.onResize):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.onResize): (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TimelinePanel.prototype.show):
  • inspector/front-end/View.js: (WebInspector.View): (WebInspector.View.prototype.wasShown): (WebInspector.View.prototype.willHide): (WebInspector.View.prototype._innerShow): (WebInspector.View.prototype.show): (WebInspector.View.prototype._innerHide): (WebInspector.View.prototype.hide): (WebInspector.View.prototype._detach): (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.View.prototype.storeScrollPositions): (WebInspector.View.prototype.restoreScrollPositions): (WebInspector.View.prototype.addChildView): (WebInspector.View.prototype.removeChildView): (WebInspector.View.prototype.onResize): (WebInspector.View.prototype.doResize): (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren): (WebInspector.View.prototype.dispatchToVisibleChildren):
  • inspector/front-end/inspector.js: (WebInspector.windowResize):

2011-08-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131

Reviewed by Pavel Feldman.

  • inspector/view-events-expected.txt: Added.
  • inspector/view-events.html: Added.

08/16/11:

21:51 Changeset [93195] by macpherson@chromium.org

Represent RenderStyle::textOverflow property using an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.

  • rendering/style/RenderStyleConstants.h:

Define TextOverflow enum.

  • rendering/style/StyleRareNonInheritedData.h:

Change representation of text overflow from bool to one-bit unsigned.

21:49 Changeset [93194] by jeffm@apple.com

Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
18:54 Changeset [93193] by levin@chromium.org

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669011

18:41 Changeset [93192] by levin@chromium.org

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669010

18:41 Changeset [93191] by abarth@webkit.org

Add new chromium-mac-leopard directory to match the chromium-mac that
tonywork added. This directory will house Skia results for Chromium Mac.

  • platform/chromium-mac-leopard: Added.
18:38 Changeset [93190] by abarth@webkit.org

Add a CG qualifier similar to the GPU qualifier
https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
18:34 Changeset [93189] by msaboff@apple.com

Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively. In some cases,
we may get to this generated code with one or both of these
registers trash. One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress(). This patch uses the
values on the stack. A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

18:32 Changeset [93188] by levin@chromium.org

REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

18:29 Changeset [93187] by hayato@chromium.org

Add two sample mismatch reftests to make sure that reftests work correctly.
https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

  • fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-fail-mismatch-reftest.html: Added.
  • fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-mismatch-reftest.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
18:24 Changeset [93186] by commit-queue@webkit.org

Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl). This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the screen space transform.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

  • compositing/backface-visibility-hierarchical-transform-expected.png: Added.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
  • compositing/backface-visibility-hierarchical-transform.html: Added.
18:11 Changeset [93185] by rniwa@webkit.org

More rebaselines for Windows WebKit2 port.

  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
17:57 Changeset [93184] by hayato@chromium.org

Implement proper handling of events which happen in children of shadow hosts.
https://bugs.webkit.org/show_bug.cgi?id=66285

Reviewed by Dimitri Glazkov.

Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.

Source/WebCore:

Test: fast/dom/shadow/shadow-contents-event.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
  • fast/dom/shadow/details-summary-mouseover.html: Removed.
  • fast/dom/shadow/shadow-contents-event-expected.txt: Added.
  • fast/dom/shadow/shadow-contents-event.html: Added.
17:55 Changeset [93183] by eric@webkit.org

REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed. Fixing an exception/typo seen on the bots (and testing to make sure it works).

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
17:16 Changeset [93182] by commit-queue@webkit.org

Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):

  • loader/ThreadableLoader.h:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):

  • notifications/Notification.cpp:

(WebCore::Notification::startLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

17:07 Changeset [93181] by lforschler@apple.com

Versioning.

17:06 Changeset [93180] by lforschler@apple.com

New tag.

17:05 Changeset [93179] by lforschler@apple.com

Versioning.

16:51 Changeset [93178] by abarth@webkit.org

Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:30 Changeset [93177] by rniwa@webkit.org

win-wk2 needs updated baselines for some editing tests
https://bugs.webkit.org/show_bug.cgi?id=66344

win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.

  • platform/win-wk2/editing/deleting: Added.
  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
  • platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
16:30 Changeset [93176] by eric@webkit.org

REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Reviewed by Adam Barth.

WinPort didn't have any port_name parsing logic.
Seemed it was best to just share the logic from MacPort.
Sharing the logic from MacPort seemed easiest with a shared superclass.
Once I created ApplePort (the superclass) there was a bunch of logic to share.
I found LeakDetector was just in the way when switching back and forth
between win.py and mac.py so I moved it into its own file.

The only logic change here is that WinPort should now be
able to parse port_name values like MacPort (and other ports)
can. The fact that ports do this in their constructors is
wrong and a source of many bugs. But at least now WinPort
matches the status-quo.

  • Scripts/webkitpy/layout_tests/port/apple.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
16:26 Changeset [93175] by abarth@webkit.org

Add webkit-patch analyze-baselines, as requested by jamesr.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:16 Changeset [93174] by commit-queue@webkit.org

Fix spelling error.
https://bugs.webkit.org/show_bug.cgi?id=66261

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-16
Reviewed by Adam Barth.

No functional change, no tests needed.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::notifyPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):

16:12 Changeset [93173] by abarth@webkit.org

Fold bulk-optimize-baselines into optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=66345

Reviewed by James Robinson.

bulk-optimize-baselines is now a superset of optimize-baselines, so
they can be combined.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
16:12 Changeset [93172] by tony@chromium.org

Add placeholder directories so the chromium canary bots can update.

  • platform/chromium-mac: Added.
  • platform/chromium-mac/fast: Added.
  • platform/chromium-mac/fast/events: Added.
  • platform/chromium-mac/http: Added.
  • platform/chromium-mac/http/tests: Added.
  • platform/chromium-mac/http/tests/workers: Added.
  • platform/chromium-mac/storage: Added.
  • platform/chromium-mac/storage/domstorage: Added.
15:58 Changeset [93171] by joepeck@webkit.org

<http://webkit.org/b/66328> ASSERT in fast/css/custom-font-xheight.html

Reviewed by Dan Bernstein.

In r93140 the temporary font created for a remote CSS font face
was created without being retained. We need to protect the
font from being purged while we hold onto it, so add a font cache
purge preventer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/chromium/test_expectations.txt:

Unskipped.

15:35 Changeset [93170] by rniwa@webkit.org

Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
which WebKitTestRunner does not support yet.

  • platform/wk2/Skipped:
15:25 Changeset [93169] by jam@chromium.org

[chromium] cleanup after previous webkit change rolled into chrome
https://bugs.webkit.org/show_bug.cgi?id=66177

Reviewed by James Robinson.

  • DEPS:
  • WebKit.gyp:
  • public/WebScrollbar.h:
15:21 Changeset [93168] by abarth@webkit.org

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

15:20 Changeset [93167] by abarth@webkit.org

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

15:20 Changeset [93166] by abarth@webkit.org

Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
https://bugs.webkit.org/show_bug.cgi?id=66334

Reviewed by Tony Chang.

This patch moves us closer to switching the Chromium port from
CoreGraphics to Skia. This patch teaches our tools that the current
Chromium Mac configuration is actually chromium-cg-mac, which makes
room for a future chromium-mac configuration that uses Skia.

Shortly after this patch lands, I'll do a server-side move of the
chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
and chromium-cg-mac-leopard.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
15:15 Changeset [93165] by tony@chromium.org

[chromium] fast/css/custom-font-xheight.html is asserting on all
chromium builds.

Also mark 2 repaint tests as failing on mac.

  • platform/chromium/test_expectations.txt:
15:10 Changeset [93164] by tony@chromium.org

[chromium] fast/repaint/canvas-putImageData.html is now passing
because of the win baselines added in r93139.

  • platform/chromium/test_expectations.txt:
15:07 Changeset [93163] by dglazkov@chromium.org

garden-o-matic frontend needs a friendly relative time description method.
https://bugs.webkit.org/show_bug.cgi?id=66324

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
15:01 Changeset [93162] by aroben@apple.com

Add Windows results for scripts-panel.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
14:55 Changeset [93161] by dglazkov@chromium.org

Summary view should not add multiple entries for the same test failure.
https://bugs.webkit.org/show_bug.cgi?id=66318

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for

equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
14:39 Changeset [93160] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 4.

Namespace the now public enum as FontCache::ShouldRetain.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):

14:35 Changeset [93159] by aroben@apple.com

Add Windows results for overlapped-iframe-iframe.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
14:32 Changeset [93158] by aroben@apple.com

Skip another test that relies on eventSender.scalePageBy on Windows

  • platform/win/Skipped: Added fast/repaint/background-scaling.html.
14:32 Changeset [93157] by senorblanco@chromium.org

Canvas resizing can be slow
https://bugs.webkit.org/show_bug.cgi?id=66251

Canvas resizing was slow due to re-allocation of the ImageBuffer on
each size change (width or height). This was introduced inadvertently
by calls to isAccelerated() during canvas reset(). Since we won't
know if we have successfully accelerated until ImageBuffer creation,
move the compositor invalidation to createImageBuffer() as well.
This patch also attempts to unify the Skia and CG accelerated canvas
paths. The DrawingBuffer used by the Skia path is now owned by
ImageBuffer[Skia], similar to how the IOSurface is owned by
ImageBuffer[CG]. Some of the logic for when to accelerate was moved
into HTMLCanvasElement and unified with the CG path. Acceleration is
also now enabled by the same "Accelerated" ImageBuffer create flag
used by the CG path. DrawingBuffer is now re-created even for a
same-size change (same as the memory buffer), but we speed it up
by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
clear it, since it's done with a glClear anyway).

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Don't call isAccelerated() from reset(), since we don't want to
inadvertently create the ImageBuffer. Also, since we won't know if
we have successfully accelerated until createImageBuffer() is
called, defer the compositor invalidation to createImageBuffer() as
well.
(WebCore::HTMLCanvasElement::shouldAccelerate):
Unify the CG and Skia ports' logic for when to accelerate (Skia
logic moved in from CanvasRenderingContext2D).
(WebCore::HTMLCanvasElement::createImageBuffer):
Use the unified shouldAccelerate() logic, and pass it as a flag
to ImageBuffer. Do compositor invalidation as well.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
Expose hasCreatedImageBuffer() publically, so
CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
it.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Remove all acceleration setting and resetting, since it's now done
during ImageBuffer creation.
(WebCore::CanvasRenderingContext2D::isAccelerated):
Check if the image buffer was created, so we don't inadvertently
create it here.
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
WebViewImpl may be null. Ask the render tree instead.
(WebCore::CanvasRenderingContext2D::reset):
Don't reset acceleration here, since we don't own it anymore.
(WebCore::CanvasRenderingContext2D::platformLayer):
Call into the ImageBuffer to get our PlatformLayer.

  • html/canvas/CanvasRenderingContext2D.h:

Remove m_drawingBuffer, and all acceleration-related calls.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

Remove setGraphicsContext3D(), and paintsIntoImageBuffer().

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::platformLayer):
Implement a dummy platformLayer() call for non-skia ports.

  • platform/graphics/ImageBuffer.h:

Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add a DrawingBuffer data member.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::reset):
Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
Since we immediately clear the framebuffer via glClear(), this whole
resource safe business is overkill.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This
functionality is handled by ImageBuffer now.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
Give the ImageBufferData ownership of the DrawingBuffer.
(WebCore::ImageBuffer::platformLayer):
Implement an accessor for the DrawingBuffer's PlatformLayer.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove isPathSkiaSafe() extern (unused).
Remove paintsIntoImageBuffer() (now unused). Remove IntSize param
from setGraphicsContext3D() (unused).

14:19 Changeset [93156] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 3.

Include the proper includes!

  • platform/graphics/FontCache.h:
14:12 Changeset [93155] by aroben@apple.com

Teach TestFailures that tests that have failed or passed many times in a row are not flaky

The basic strategy here is that once a test has failed or passed many times in a row we
never again consider it as a possibly flaky test. It's a simple strategy but seems to result
in many fewer false positives than our current behavior.

Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
flaky, including tests that failed for a while but then were fixed

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
number of non-too-many-failure builds we've seen.
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
tests, keep track of how many times they have passed or failed in a row. If they pass or
fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
considered flaky it doesn't matter how many times it passes or fails.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:

Added tests for the above.

14:12 Changeset [93154] by tony@chromium.org

[chromium] fast/css/custom-font-xheight.html is hitting an assert
in debug on Linux.

  • platform/chromium/test_expectations.txt:
14:01 Changeset [93153] by tony@chromium.org

[chromium] Mark new tests as failing. Will pull results from the
bots when they cycle.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [93152] by dglazkov@chromium.org

garden-o-matic needs a summary view with actions for each problem.
https://bugs.webkit.org/show_bug.cgi?id=66144

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
13:47 Changeset [93151] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140. Take 2.

This just makes the troublesome enum public. If this
fixes the build I will file a follow-up bug to clean-up
these build issues and either keep the enum public and
cleanup other functions or restore the enum to private.
There is no harm in making the enum public right now.

  • platform/graphics/FontCache.h:
13:44 Changeset [93150] by commit-queue@webkit.org

Unmatrix algorithm implementation is wrong
https://bugs.webkit.org/show_bug.cgi?id=66080

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
Reviewed by Dean Jackson.

Source/WebCore:

Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.

Test: animations/animation-matrix-negative-scale-unmatrix.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose):

LayoutTests:

  • animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
  • animations/animation-matrix-negative-scale-unmatrix.html: Added.
13:28 Changeset [93149] by joepeck@webkit.org

Unreviewed Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
13:13 Changeset [93148] by eric.carlson@apple.com

Make video-controls-no-scripting.html results platform independent.

  • media/video-controls-no-scripting-expected.txt:
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
13:10 Changeset [93147] by joepeck@webkit.org

Unreviewed Windows and Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

12:50 Changeset [93146] by aroben@apple.com

Make placeholder text remain visible until a character is typed on Windows

Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields

Covered by existing tests (which are currently failing on the bots until this patch lands).

Reviewed by Dave Hyatt.

  • rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):

  • rendering/RenderThemeWin.h:

(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.

12:48 Changeset [93145] by dino@apple.com

Adding Ted "hober" O'Connor as a non-committing contributor.

  • Scripts/webkitpy/common/config/committers.py:
12:43 Changeset [93144] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66254

Source/WebCore:

Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
content.

Reviewed by Simon Fraser.

Added new tests in fast/repaint.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThreads):

LayoutTests:

Make regions repaint properly. Added new repaint tests.

Reviewed by Simon Fraser.

  • fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
  • fast/repaint/line-flow-with-floats-in-regions.html: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
12:42 Changeset [93143] by lforschler@apple.com

Merge r93070.

12:40 Changeset [93142] by lforschler@apple.com

Merge r93048.

12:34 Changeset [93141] by lforschler@apple.com

Merge r93047.

12:18 Changeset [93140] by joepeck@webkit.org

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

While a remote CSS font face is loading we fallback to a
temporary font. We don't want to retain the fallback font
because noone takes ownership of the temporary font. This
patch adds a way to get an uncached fallback font, which
plumbs the ShouldRetain enum through the different platform
implementations of getLastResortFallbackFont.

No new tests, no functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getNonRetainedLastResortFallbackFont):

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/haiku/FontCacheHaiku.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/pango/FontCachePango.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

12:12 Changeset [93139] by aroben@apple.com

Add Windows expected results for some <canvas> tests

<canvas> doesn't use accelerated compositing on Windows like it does on Lion.

  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
11:56 Changeset [93138] by dbates@webkit.org

2011-08-16 Daniel Bates <dbates@webkit.org>

Add myself to the list of individual members in the WebKit Security Group.

Rubber-stamped by Eric Seidel.

  • security/security-group-members.html:
11:49 Changeset [93137] by lforschler@apple.com

Merge r92977.

11:45 Changeset [93136] by commit-queue@webkit.org

Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

11:44 Changeset [93135] by lforschler@apple.com

Merge r88444.

11:39 Changeset [93134] by rniwa@webkit.org

Programmatically set selection should not have direction on Mac
https://bugs.webkit.org/show_bug.cgi?id=60529

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified default value of VisibleSelection->m_isDirectional from 'true'
to 'false' by adding a defaulted argument to several VisibleSelection
constructors to make programmatic selection be directionless by default
on Mac. Also modified several calls to VisibleSelection's constructors
to correctly preserve directionality.

Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
a call to setExtent triggers an editing delegate that uses the
FrameSelection. The direction here should have been preserved from before,
but setIsDirectional was not called until after FrameSelection.cpp:869. It
has been moved up to make things behave.

  • WebCore.exp.in:
  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):

  • editing/FrameSelection.cpp:

(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):

  • editing/FrameSelection.h:
  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::doApply):

  • editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection):

  • editing/VisibleSelection.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Added editing/selection/programmatic-selection-on-mac-is-directionless
to test selection direction in programmatically set selections on
windows, unix, and mac, in plain text, editable divs, text-input
fields, and textareas. Modified text baselines for many editing tests,
which had a delegate change as a result of the cpp patch.

  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/selection/after-line-break-expected.txt:
  • platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/mac/editing/deleting/delete-and-undo-expected.txt:
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-01-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-02-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/4076267-expected.txt:
  • platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-015-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/anchor-focus2-expected.txt:
  • platform/mac/editing/selection/anchor-focus3-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/fake-drag-expected.txt:
  • platform/mac/editing/selection/move-by-word-001-expected.txt:
  • platform/mac/editing/selection/transformed-selection-rects-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
11:36 Changeset [93133] by jpfau@apple.com

New XML parser: Add document fragment parser
https://bugs.webkit.org/show_bug.cgi?id=66317

Reviewed by Adam Barth.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::parseXML):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::parseDocumentFragment):

  • xml/parser/NewXMLDocumentParser.h:

(WebCore::NewXMLDocumentParser::create):

  • xml/parser/XMLTokenizer.h:
  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::pushCurrentNode):

  • xml/parser/XMLTreeBuilder.h:

(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::node):

11:36 Changeset [93132] by tony@chromium.org

[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.

  • platform/chromium/test_expectations.txt:
11:23 Changeset [93131] by senorblanco@chromium.org

GraphicsContext3D should allow its hostWindow to be NULL
https://bugs.webkit.org/show_bug.cgi?id=66305

Allow the hostWindow param (and m_webViewImpl) to be NULL. This
makes it much easier to enable GPU acceleration at a lower level
in WebKit's platform/graphics layer, without needing access to the
Page* or HostWindow*. Also bump the chromium DEPS to chrome r96940,
which includes a similar change for the in-process GraphicsContext3D
implementations.

Reviewed by James Robinson.

  • DEPS:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):
(WebCore::GraphicsContext3DInternal::platformTexture):
(WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):

11:07 Changeset [93130] by jpfau@apple.com

New XML parser: Replace assertions regarding character data in the prolog with proper checks
https://bugs.webkit.org/show_bug.cgi?id=66269

Reviewed by Adam Barth.

This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):

  • xml/parser/XMLTreeBuilder.h:
11:04 Changeset [93129] by tony@chromium.org

[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).

  • platform/chromium/test_expectations.txt:
11:03 Changeset [93128] by aroben@apple.com

Add Windows expected results for resource-har-conversion.html

While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
extra fields in the request objects.

  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:58 Changeset [93127] by apavlov@chromium.org

Web Inspector: word wrap long edits
https://bugs.webkit.org/show_bug.cgi?id=65512

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.styles-section .properties li.child-editing):

10:31 Changeset [93126] by mnaganov@chromium.org

Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
https://bugs.webkit.org/show_bug.cgi?id=66316

Reviewed by NOBODY (OOPS!).

  • WebKit.gyp:
10:27 Changeset [93125] by pfeldman@chromium.org

Web Inspector: convert DOM breakpoint types to strings.
https://bugs.webkit.org/show_bug.cgi?id=66304

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane):

10:23 Changeset [93124] by tony@chromium.org

Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir. The mac result (r93112) was getting
picked up by the chromium port.

  • platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:16 Changeset [93123] by tony@chromium.org

Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.

Also add chromium baseline (the top of the video control is in a
different place).

  • media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
10:15 Changeset [93122] by pfeldman@chromium.org

Web Inspector: force pseudo element state when checking it in the styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=66292

This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.

Reviewed by David Hyatt.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • css/CSSStyleSelector.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::forcePseudoStateImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::forcePseudoState):

09:59 Changeset [93121] by lforschler@apple.com

rollout incorrect submit of 93118.

09:57 Changeset [93120] by tony@chromium.org

Unreviewed, rolling out r93114.
http://trac.webkit.org/changeset/93114
https://bugs.webkit.org/show_bug.cgi?id=66226

broke the chromium mac compile

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:
  • platform/ScrollbarThemeComposite.cpp:
  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):

  • platform/mac/ScrollbarThemeMac.h:
09:56 Changeset [93119] by aroben@apple.com

Update Windows results for a fast/text test for Safari 5.1's AAS

The results are now more like Mac's. Dan Bernstein says this is probably a progression.

  • platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
09:55 Changeset [93118] by lforschler@apple.com

Merge r36608.

09:46 Changeset [93117] by tony@chromium.org

[chromium] Mark media/video-source-error.html as flaky in Debug.

  • platform/chromium/test_expectations.txt:
09:44 Changeset [93116] by aroben@apple.com

Update Windows results after r92890

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
09:39 Changeset [93115] by aroben@apple.com

Remove Windows-specific hyphenation test results now that hyphenation works on Windows

  • platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
09:34 Changeset [93114] by commit-queue@webkit.org

Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

09:31 Changeset [93113] by tony@chromium.org

Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir. The mac failing results (r93105) were
getting picked up by the chromium port.

  • platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
09:28 Changeset [93112] by aroben@apple.com

Add Lion/Windows expected results for an Inspector test

The only difference from the cross-platform results is that the .js resources are now given
a MIME type of "text/plain".

This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.

  • platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
09:27 Changeset [93111] by aroben@apple.com

Teach TestFailures how to interpret unfinished test runs

Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
rather than "isStarted" so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.

09:19 Changeset [93110] by macpherson@chromium.org

Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=66273

Reviewed by Simon Fraser.

No new tests - no functionality changed - refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Define cast from CSSPrimitiveValue to ETransformStyle3D.
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
Define cast from ETransformStyle3D to CSSPrimitiveValue.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to handle CSSPropertyWebkitTransformStyle.

09:18 Changeset [93109] by macpherson@chromium.org

Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=66279

Reviewed by Simon Fraser.

No new tests - no functionality changed - simple refactoring only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.

09:13 Changeset [93108] by eric.carlson@apple.com

2011-08-16 Eric Carlson <eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

Tests: media/video-controls-no-scripting-iframe.html

media/video-controls-no-scripting.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code

to configureMediaControls.

(WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
(WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in

attributeChanged and preDispatchEventHandler here.

(WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code

to configureMediaControls.

  • html/HTMLMediaElement.h:

2011-08-16 Eric Carlson <eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

  • media/video-controls-no-scripting-expected.txt: Added.
  • media/video-controls-no-scripting-iframe.html: Added.
  • media/video-controls-no-scripting.html: Added.
09:03 Changeset [93107] by aroben@apple.com

Make Apple's Windows port fall back to Lion results instead of SnowLeopard

Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
should match Lion's behavior.

Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
but doesn't use Lion results

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):
Replaced mac-snowleopard with mac-lion.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
directory, which all Apple Mac platforms and Apple Win platforms could potentially use
results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
will no longer look there for results.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest.test_should_build): Tests for the above changes.

09:00 Changeset [93106] by aroben@apple.com

Stop skipping the web-apps tests I just landed results for on Lion

  • platform/mac-lion/Skipped:
08:57 Changeset [93105] by aroben@apple.com

Check in expected failure results for some web-apps tests on Lion and Windows

Since these failures are likely due to bugs in non-WebKit components, they are tracked by
<rdar://problem/9313271>.

  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
  • platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
08:51 Changeset [93104] by aroben@apple.com

Share Sputnik Unicode results between Lion and Windows

Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.

  • platform/mac-lion/Skipped: Removed these tests.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
08:41 WebKit Team edited by hayato@chromium.org
(diff)
08:33 Changeset [93103] by aroben@apple.com

Update Windows Sputnik results for ICU 4.6

Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.

  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
08:16 Changeset [93102] by aroben@apple.com

Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)

Since these failures are likely to be due to bugs in non-WebKit components, they are tracked
by Radars.

  • platform/win/Skipped: Added http/tests/multipart/invalid-image-data-standalone.html,

http/tests/cookies/simple-cookies-expired.html, and
http/tests/cookies/simple-cookies-max-age.html.

07:53 Changeset [93101] by pfeldman@chromium.org

Web Inspector: hide non-conservative methods from the protocol documentation.
https://bugs.webkit.org/show_bug.cgi?id=66301

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
07:50 Changeset [93100] by steveblock@google.com

Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg

See http://code.google.com/p/chromium/issues/detail?id=93044

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:42 Changeset [93099] by steveblock@google.com

Add TIMEOUT expectation for editing/deleting/regional-indicators.html
https://bugs.webkit.org/show_bug.cgi?id=66268

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:39 Changeset [93098] by abecsi@webkit.org

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Fix the GTK build after r93095.

Unreviewed build fix.

No new tests neede.

  • GNUmakefile.list.am: Remove nonexistent sources.
07:26 Changeset [93097] by abecsi@webkit.org

Reviewed by Csaba Osztrogonác.

Need AtomicStrings for the various font family names
https://bugs.webkit.org/show_bug.cgi?id=28024

.:

  • Source/cmake/WebKitMacros.cmake: Add new macro.

Source/WebCore:

Unify the usage of '-webkit' prefixed font family names by using
global AtomicStrings.
Use a .in file to generate the needed sources through make_names.pl.

No new tests needed.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::fontDataForGenericFamily):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/WebKitFontFamilyNames.in: Added.
  • dom/make_names.pl:
  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getFontData):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::useFixedDefaultSize):

07:15 Changeset [93096] by mnaganov@chromium.org

Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
https://bugs.webkit.org/show_bug.cgi?id=66300

Reviewed by Pavel Feldman.

  • WebKit.gyp:
06:41 Changeset [93095] by pfeldman@chromium.org

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/EventsCollector.cpp: Removed.
  • inspector/EventsCollector.h: Removed.
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: Removed.
  • inspector/InspectorFrontendProxy.h: Removed.
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

LayoutTests:

  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
  • http/tests/inspector/network/network-clear-after-disabled.html: Removed.
  • http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
  • http/tests/inspector/network/network-close-load-open.html: Removed.
  • http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
  • http/tests/inspector/network/network-open-load-reopen.html: Removed.
06:38 Changeset [93094] by steveblock@google.com

fix

06:11 Changeset [93093] by benjamin.poulain@nokia.com

[Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-16
Reviewed by Benjamin Poulain.

Source/WebCore:

Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):

Source/WebKit/qt:

Added a platform plugin to allow spell and grammar check in QtWebKit.

  • Api/qwebkitplatformplugin.h:
  • QtWebKit.pro:
  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::textChecker):

  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createSpellChecker):

  • WebCoreSupport/QtPlatformPlugin.h:
  • WebCoreSupport/TextCheckerClientQt.cpp: Added.

(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):

  • WebCoreSupport/TextCheckerClientQt.h: Added.

(WebCore::TextCheckerClientQt::requestCheckingOfString):

06:01 Changeset [93092] by kov@webkit.org

Add javascriptcoregtk to the introspection build, to fix it.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> in 2011-08-16
Reviewed by Xan Lopez.

  • GNUmakefile.am:
05:46 Changeset [93091] by abecsi@webkit.org

WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

Unreviewed gardening.

  • platform/wk2/Skipped: skip editing/input/style-change-during-input.html
04:35 Changeset [93090] by dino@apple.com

Move me from contributor to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
03:04 Changeset [93089] by vsevik@chromium.org

Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Pavel Feldman.

  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
01:57 Changeset [93088] by zoltan@webkit.org

[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
https://bugs.webkit.org/show_bug.cgi?id=66268

  • platform/qt/Skipped:
00:00 Changeset [93087] by morrita@google.com

REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
https://bugs.webkit.org/show_bug.cgi?id=66216

Reviewed by Ryosuke Niwa.

Source/WebCore:

Element::spellcheckAttributeState() uses Element::hasAttribute(),
which calls updateStyleAttribute(), which potentially makes style
dirty. But that is problematic since Editor calls spellcheckAttributeState()
during the spell-checking phase and make the style dirty,
which can trigger re-layout, which wipes the shadow tree of a textarea
out by pre-committed "value" text.

This change removes the hasAttribute() call from
spellcheckAttributeState().

Test: editing/input/style-change-during-input.html

  • dom/Element.cpp:

(WebCore::Element::spellcheckAttributeState):

LayoutTests:

  • editing/input/style-change-during-input-expected.txt: Added.
  • editing/input/style-change-during-input.html: Added.

08/15/11:

22:18 Changeset [93086] by gyuyoung.kim@samsung.com

[CMAKE] Wrap files of websocket and worker in each macro.
https://bugs.webkit.org/show_bug.cgi?id=65012

Move files of web socket and workers into each macro block in CMakeList.txt.
And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.

Reviewed by Daniel Bates.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/js/WorkerScriptController.cpp:
19:35 Changeset [93085] by mrowe@apple.com

Merge r93005.

19:35 Changeset [93084] by mrowe@apple.com

Merge r93000.

19:35 Changeset [93083] by mrowe@apple.com

Versioning.

19:23 Changeset [93082] by mrowe@apple.com

New tag.

18:37 Changeset [93081] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

  • fast/js/kde/operators-expected.txt:
    • erk! missed new expected results from last commit!
18:10 Changeset [93080] by jpfau@apple.com

New XML parser: add xml namespace to the default map of namespaces
https://bugs.webkit.org/show_bug.cgi?id=66266

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):

18:05 Changeset [93079] by hayato@chromium.org

Fix crash when mouse moves from <summary> element to parent <details> element.
https://bugs.webkit.org/show_bug.cgi?id=66210

Reviewed by Dimitri Glazkov.

This is a regression caused by r92922, which wrongly assumes that
a shadow host always has a shadow root as an immediate child in
ancestors chain. This assumption does not apply to <details>
element. <details> element is implemented as a shadow host, but
may have a <summary> element as an immediate child element in
ancestors chain.

Source/WebCore:

Test: fast/dom/shadow/details-summary-mouseover.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Added.
  • fast/dom/shadow/details-summary-mouseover.html: Added.
17:56 Changeset [93078] by rniwa@webkit.org

A mousedown event is not dispatched when clicking on a disabled INPUT
https://bugs.webkit.org/show_bug.cgi?id=27795

Reviewed by Alexey Proskuryakov.

Add a regression test now that the bug no longer reproduces.

  • fast/forms/disabled-mousedown-event-expected.txt: Added.
  • fast/forms/disabled-mousedown-event.html: Added.
17:46 Changeset [93077] by jamesr@google.com

Merge 92908 - Readback composited webgl results for printing
https://bugs.webkit.org/show_bug.cgi?id=65658
BUG=55927

Patch by John Bauman <jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

Source/WebCore:

The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Add support for reading from the composited version of a canvas.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):

  • src/GraphicsContext3DInternal.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7664004

17:32 Changeset [93076] by dimich@chromium.org

[Chromium] Add WebFrameClient::didAdoptURLLoader() notification
https://bugs.webkit.org/show_bug.cgi?id=66167

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didAdoptURLLoader):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::~ResourceHandle):

  • src/ResourceHandleInternal.h: Added.

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):

17:32 Changeset [93075] by abarth@webkit.org

Note that this new test fails.

  • platform/chromium/test_expectations.txt:
17:27 Changeset [93074] by abarth@webkit.org

Remove expectation for this test, which no longer exists.

  • platform/chromium/test_expectations.txt:
17:24 Changeset [93073] by abarth@webkit.org

Add new passing expectations.

  • platform/chromium/fast/js/kde/operators-expected.txt: Added.
17:17 Changeset [93072] by jpfau@apple.com

New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
https://bugs.webkit.org/show_bug.cgi?id=66264

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

16:51 Changeset [93071] by eae@chromium.org

Switch Element/Node to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66260

Reviewed by Eric Seidel.

Convert Element, Node, ElementRareData and ContainerNode to new layout
abstraction as a part of the ongoing conversion work.

No new tests, no new functionality.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::getRect):

  • dom/ContainerNode.h:
  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::adjustForLocalZoom):
(WebCore::Element::boundsInWindowSpace):
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::screenRect):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):

  • dom/Element.h:
  • dom/ElementRareData.h:
  • dom/Node.cpp:

(WebCore::Node::getRect):
(WebCore::Node::renderRect):
(WebCore::Node::hasNonEmptyBoundingBox):

  • dom/Node.h:
16:44 Changeset [93070] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Change bool return values to a 64-bit type.

LayoutTests:

  • fast/js/kde/script-tests/operators.js:

(nonSpeculativeNotInner):
(nonSpeculativeNot):
(nonSpeculativeLessInner):
(nonSpeculativeLess):
(nonSpeculativeLessEqInner):
(nonSpeculativeLessEq):
(nonSpeculativeGreaterInner):
(nonSpeculativeGreater):
(nonSpeculativeGreaterEqInner):
(nonSpeculativeGreaterEq):
(nonSpeculativeEqualInner):
(nonSpeculativeEqual):
(nonSpeculativeNotEqualInner):
(nonSpeculativeNotEqual):
(nonSpeculativeStrictEqualInner):
(nonSpeculativeStrictEqual):
(nonSpeculativeStrictNotEqualInner):
(nonSpeculativeStrictNotEqual):

  • Add tests cases that will hit the non-spec path.
16:36 Changeset [93069] by ap@apple.com

Committed by accident, restoring the test.

  • editing/deleting/delete-3928305-fix.html:
16:34 Changeset [93068] by ap@apple.com

Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395

Reviewed by Dan Bernstein.

Part one: make backspace work.

Test: editing/deleting/regional-indicators.html

  • rendering/RenderText.cpp: (WebCore::isRegionalIndicator): (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional indicator symbols.
16:18 Changeset [93067] by jpfau@apple.com

New XML parser: Re-entering a character node should not clobber the buffered characters
https://bugs.webkit.org/show_bug.cgi?id=66257

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::enterText):

15:49 Changeset [93066] by dimich@chromium.org

FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
https://bugs.webkit.org/show_bug.cgi?id=66165

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no change in behavior.
The original issue is only reproducible on Chromium in multi-process mode
and is tested there by a browsertest.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::transferLoadingResourcesFromPage):
Passing ResourceLoader* into the FrameLoaderClient notification.
Also, fixed the bug where the same ResourceRequest was passed for all subresources.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
returns the request as it existed before redirects (but after client's will SendRequest).
This is to be able to pass the original request for loading subresources into
FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
assignIdentifierToInitialRequest, which needs original request.

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
15:43 Changeset [93065] by abarth@webkit.org

Unreviewed, rolling out r93060.
http://trac.webkit.org/changeset/93060
https://bugs.webkit.org/show_bug.cgi?id=66259

Does not compile on Chromium Windows (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-15

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):

  • src/WebFontCache.cpp:
15:18 Changeset [93064] by aroben@apple.com

Touch a file to trigger a Windows build

I'm trying to ferret out some issues with our Debug builder.

  • WebView.cpp: Sorted #includes.
15:14 Changeset [93063] by dglazkov@chromium.org

garden-o-matic frontend needs model.commitDataForRevisionRange function.
https://bugs.webkit.org/show_bug.cgi?id=66252

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
14:56 Changeset [93062] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix after r93058.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

  • UIProcess/TiledDrawingAreaProxy.h:
14:31 Changeset [93061] by dglazkov@chromium.org

garden-o-matic frontend needs a generic way to track updates.
https://bugs.webkit.org/show_bug.cgi?id=66245

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
14:28 Changeset [93060] by mnaganov@chromium.org

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Darin Fisher.

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

14:12 Changeset [93059] by commit-queue@webkit.org

Refactor JS objects to allocate in static create methods rather than constructors
https://bugs.webkit.org/show_bug.cgi?id=65347

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-15
Reviewed by Geoffrey Garen.

Source/JavaScriptGlue:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

  • JSRun.h:

(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • bindings/js/JSDOMBinding.h:
  • bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):

  • bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.cpp:

Source/WebKit/mac:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

14:06 Changeset [93058] by aroben@apple.com

Update pages' style and content scale when the window's backing scale factor changes

Unfortunately, I couldn't think of a way to test this in an automated fashion.

Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
scale factor changes

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
  • page/Frame.cpp:

(WebCore::Frame::deviceScaleFactorChanged):

  • page/Frame.h:

Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
queries will be reevaluated, and we tell compositing layers about the new scale factor so
they can rerender at the new resolution.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
factor so that, e.g., scale-factor-dependent media queries will be reevaluated.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WKView _windowDidChangeResolution:]): Tell the WebPageProxy about the change.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:

Added deviceScaleFactorDidChange.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::deviceScaleFactorDidChange): Request a new backing store
since the current one is using an old device scale factor.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Send the device scale factor
along to the web process so it can render accordingly. This is how we tell the web process
about device scale factor changes.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange): Tell the DrawingAreaProxy when the device scale
factor changes.
(WebKit::WebPageProxy::deviceScaleFactor): Added this simple getter that calls through to
the PageClient. DrawingAreaProxy uses this function.

  • UIProcess/WebPageProxy.h: Added new members.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Send the device scale factor in the UpdateBackingStoreState message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState): Tell the WebPage and LayerTreeHost about
the new device scale factor.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

Added deviceScaleFactorDidChange.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor): Store the new scale factor and tell the page about
it so that, e.g., scale-factor-dependent media queries will be reevaluated.

  • WebProcess/WebPage/WebPage.h: Added setDeviceScaleFactor.
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::deviceScaleFactorDidChange): Tell the layer for non-composited
content about the new scale factor.

12:59 Changeset [93057] by caryclark@google.com

Revise Skia on Chrome Mac to return fallback fonts.
https://bugs.webkit.org/show_bug.cgi?id=62986

Reviewed by Darin Fisher.

Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.

This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::canReturnFallbackFontsForComplexText):

12:59 Changeset [93056] by thakis@chromium.org

[chromium] Implement shouldRubberBandInDirection
https://bugs.webkit.org/show_bug.cgi?id=66206

Reviewed by Adam Barth.

History swiping can only start after an unhandled mouse wheel event
came back from the renderer, because mouse wheel javascript handlers
take precedence over history swiping. This means that rubberbanding
must not consume wheel events if they could trigger history, else
history swiping won't be triggered for pages without wheel handlers
either.

This is based on the implementation in
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection):

  • src/ChromeClientImpl.h:
12:52 Changeset [93055] by aa@chromium.org

Pass additional details to client in didCreateIsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=66037

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/IsolatedWorld.cpp:

(WebCore::IsolatedWorld::IsolatedWorld):

  • bindings/v8/IsolatedWorld.h:

(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::id):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
12:37 Changeset [93054] by crogers@google.com

Add shell implementation for Web Audio API's MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=66175

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.idl:
  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/MediaElementAudioSourceNode.cpp: Added.

(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::reset):

  • webaudio/MediaElementAudioSourceNode.h: Added.

(WebCore::MediaElementAudioSourceNode::mediaElement):

  • webaudio/MediaElementAudioSourceNode.idl: Added.

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt: Added.
  • webaudio/mediaelementaudiosourcenode.html: Added.
12:31 Changeset [93053] by eae@chromium.org

Switch mouse events to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66179

Reviewed by Eric Seidel.

Convert mouse events to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

  • dom/MouseRelatedEvent.cpp:

(WebCore::contentsScrollOffset):
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::pageLocation):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::screenLocation):
(WebCore::MouseRelatedEvent::clientLocation):
(WebCore::MouseRelatedEvent::absoluteLocation):
(WebCore::MouseRelatedEvent::setAbsoluteLocation):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::selectionExtentRespectingEditingBoundary):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:
  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):

12:30 Changeset [93052] by aroben@apple.com

Teach TestWebKitAPI/gtest how to print JavaScript failures nicely

Failures now give output of the form: foo should be bar but is baz

Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
test is in TestWebKitAPI's output

Reviewed by David Levin.

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
members.
(TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
object, rather than doing any testing of it here.
(TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
to use a pretty error message when the test fails.

  • TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice

gtest-style macros that wrap it.

  • TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
the test passes, though. Returning early seems to have been an unnecessary optimization.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

12:23 Changeset [93051] by rniwa@webkit.org

webkit-indent-blockquote is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=66195

Reviewed by Tony Chang.

Source/WebCore:

Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
since no other class inherited from ApplyBlockElementCommand uses this feature.

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
(WebCore::ApplyBlockElementCommand::createBlockElement):

  • editing/ApplyBlockElementCommand.h:
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::IndentOutdentCommand):

LayoutTests:

Rebaselined the tests since WebKit longer adds class="webkit-indent-blockquote" on blockquotes
created by execCommand('Indent') and execCommand('Outdent') after this patch.

  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/5658933-2-expected.txt:
  • editing/execCommand/5658933-3-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs-expected.txt:
  • editing/execCommand/indent-pre-expected.txt:
  • editing/execCommand/indent-pre-list-expected.txt:
  • editing/execCommand/indent-pre-paragraphs-expected.txt:
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/execCommand/indent-with-style2-expected.txt:
12:07 Changeset [93050] by leviw@chromium.org

Switch remaining SVG Rendering methods to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=66169

Reviewed by Eric Seidel.

Changing remaining integer SVG methods to use the LayoutUnits abstraction.

No tests as no change in functionality.

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::linesBoundingBox):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::parentOriginToBorderBox):
(WebCore::RenderSVGRoot::borderOriginToContentBox):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):

  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):

  • rendering/svg/SVGRootInlineBox.h:
12:07 Changeset [93049] by commit-queue@webkit.org

[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
https://bugs.webkit.org/show_bug.cgi?id=66222

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-15
Reviewed by Kenneth Rohde Christiansen.

The function QTouchWebPagePrivate::getPageViewPrivate() exposed
the private QTouchWebPage to any object in WebKit.

Instead, use the friend keyword to list which objects can access
the internal of QTouchWebPage.

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::viewportRectUpdated):

11:51 Changeset [93048] by barraclough@apple.com

Crash accessing static property on sealed object
https://bugs.webkit.org/show_bug.cgi?id=66242

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

  • should only check isExtensible if checkReadOnly.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • added test case.
10:41 Changeset [93047] by jeffm@apple.com

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

10:21 Changeset [93046] by eric@webkit.org

Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.

Unreviewed.

  • Scripts/run-webkit-tests:

(usingLeaks):
(useNewRunWebKitTests):

09:56 Changeset [93045] by weinig@apple.com

Fix release build when building with Clang.

Reviewed by Anders Carlsson.

  • runtime/Identifier.cpp:

(JSC::Identifier::checkCurrentIdentifierTable):
Add NO_RETURN_DUE_TO_CRASH.

08:54 Changeset [93044] by kbalazs@webkit.org

Unreviewed.
Fix Qt-WK2 build after r93040.

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::deviceScaleFactor):

08:01 Changeset [93043] by aroben@apple.com

Rename an instance of pageScaleFactorChanged I missed in r93040

I tried to make a test for this but failed. It would probably have been easier if we dumped
layers' content scales in layerTreeAsText output.

Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
the device scale factor

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

Renamed from pageScaleFactorChanged to match the base class.

07:32 Changeset [93042] by pfeldman@chromium.org

Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

07:26 Changeset [93041] by vsevik@chromium.org

Web Inspector: Network panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66051

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
(WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):

06:43 Changeset [93040] by aroben@apple.com

Clear up scale factor terminology

WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.

Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

Removed an unused member. This is unrelated to this patch.

  • css/MediaQueryEvaluator.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
AppKit scale factor terminology. (This is unrelated to the rest of the patch.)

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Shared/UpdateInfo.cpp:
  • Shared/UpdateInfo.h:
  • Shared/WebPageCreationParameters.cpp:
  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/BackingStore.cpp:
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
  • UIProcess/gtk/WebPopupMenuProxyGtk.h:
  • UIProcess/mac/BackingStoreMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/qt/WebPopupMenuProxyQt.h:
  • UIProcess/win/WebPopupMenuProxyWin.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
04:59 Changeset [93039] by reni@webkit.org

Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

04:02 Changeset [93038] by hayato@chromium.org

Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=64249

Reviewed by Dimitri Glazkov.

Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
that we can shrink ancestors of event target node considering shadow
DOM boundaries before dispatching focusin/focusout events.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):

  • dom/Node.h:
  • dom/UIEvent.cpp:

(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/UIEvent.h:

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
03:26 Changeset [93037] by pfeldman@chromium.org

Web Inspector: not all of the properties have valid descriptors on all platforms.
Includes PropertyDescriptor protocol documentation fixes.
https://bugs.webkit.org/show_bug.cgi?id=66215

Source/WebCore:

Activations, LocalStorage and some other properties potentially don't have
valid property descriptors. InjectedScript should use conservative getter in order to
mitigate this.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:

LayoutTests:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/runtime/runtime-localStorage-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-localStorage-getProperties.html: Added.
03:00 Changeset [93036] by vsevik@chromium.org

Merge 92835 - Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
https://bugs.webkit.org/show_bug.cgi?id=66007

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.FrameTreeElement.prototype.resourceByURL):

TBR=vsevik@chromium.org
BUG=92405
Review URL: http://codereview.chromium.org/7648029

02:26 Changeset [93035] by pfeldman@chromium.org

Web Inspector: context menu on the link in the console does not have standard link options.
https://bugs.webkit.org/show_bug.cgi?id=66214

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):

  • inspector/front-end/inspector.js:

(WebInspector.openLinkExternallyLabel):
(WebInspector.copyLinkAddressLabel):
(WebInspector.populateHrefContextMenu):

01:13 Changeset [93034] by pfeldman@chromium.org

Web Inspector: showContextMenu missing in Remote DevTools
https://bugs.webkit.org/show_bug.cgi?id=63725

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/SoftContextMenu.js: Added.

(.WebInspector.SoftContextMenu):
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._highlightPrevious):
(.WebInspector.SoftContextMenu.prototype._highlightNext):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.InspectorFrontendHost.showContextMenu):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu-item):
(.soft-context-menu-separator):
(.soft-context-menu-item-mouse-over):

  • inspector/front-end/inspector.html:
Note: See TracTimeline for information about the timeline view.