Timeline
Aug 22, 2011:
- 10:45 PM Changeset in webkit [93580] by
-
- 5 edits in trunk
Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587
Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.
Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.
- platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.
- 9:09 PM Changeset in webkit [93579] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673
Reviewed by James Robinson.
This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().
No new tests because no directly observable change in behavior.
- platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
- 8:55 PM Changeset in webkit [93578] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745
Breaks layout tests (Requested by koz2 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
- accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.
- 7:53 PM Changeset in webkit [93577] by
-
- 4 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744
Does not compile on chromium canaries (Requested by jamesr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
- src/WebSettingsImpl.h:
- 7:53 PM Changeset in webkit [93576] by
-
- 2 edits in branches/chromium/835/Source/WebCore
Chromium crash fix, just for this branch.
BUG=93824
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::paintLayerContents):
- 7:15 PM Changeset in webkit [93575] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220
Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
- src/WebSettingsImpl.h:
- 7:07 PM Changeset in webkit [93574] by
-
- 2 edits in trunk/Source/WebCore
Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.
Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)
- dom/Range.cpp:
(WebCore::Range::setEnd):
- 7:05 PM Changeset in webkit [93573] by
-
- 19 edits in trunk/Source/WebCore
Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741
Reviewed by Darin Adler.
PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness. These special
cases can be removed now that Android shares more code with Chromium.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
- bindings/v8/ScriptCachedFrameData.cpp:
- bindings/v8/ScriptCachedFrameData.h:
- bindings/v8/V8GCController.cpp:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):
- history/HistoryItem.h:
- loader/cache/CachedFont.cpp:
- platform/DragImage.h:
- platform/PlatformTouchEvent.h:
- platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
- platform/Widget.h:
- platform/network/NetworkStateNotifier.cpp:
- platform/network/NetworkStateNotifier.h:
- platform/network/NetworkingContext.h:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/ResourceRequestBase.cpp:
- 7:02 PM Changeset in webkit [93572] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.
Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.
This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientEfl.h:
- ewk/ewk_private.h:
- 6:35 PM Changeset in webkit [93571] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731
Reviewed by James Robinson.
The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
- platform/graphics/chromium/LayerRendererChromium.h:
- 6:07 PM Changeset in webkit [93570] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark some tests on Mac as flakily crashing.
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 6:03 PM Changeset in webkit [93569] by
-
- 3 edits2 copies in branches/chromium/835
Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581
Reviewed by Nate Chapin.
Source/WebCore:
This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser. Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky. In the meantime, this null check fixes the
crash.
I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it. Thanks to Berend-Jan Wever for the test
case!
Test: fast/loader/reload-zero-byte-plugin.html
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::endIfNotLoadingMainResource):
LayoutTests:
- fast/loader/reload-zero-byte-plugin-expected.txt: Added.
- fast/loader/reload-zero-byte-plugin.html: Added.
TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7685041
- 5:49 PM Changeset in webkit [93568] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark some tests on Windows as flaky.
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 5:43 PM Changeset in webkit [93567] by
-
- 4 edits in trunk/Source/WebCore
showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
https://bugs.webkit.org/show_bug.cgi?id=53191
<rdar://problem/8629478>
Reviewed by Geoff Garen.
Cannot test domain relaxing, we only have 127.0.0.1 and localhost.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): Added a FIXME about a difference with Firefox.
(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
Changed to fetch returnValue from the global object that's in the frame when the dialog is
dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
if the origin doesn't match opener origin (which the case with domain relaxing).
Re-added a security check for returnValue that got lost in r73829, so that we don't send the
result across origins. This matches Firefox.
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion against a very confusing case that should no longer occur.
- page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive call to avoid changing life support timer behavior in this patch.
- 5:37 PM Changeset in webkit [93566] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704
Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
- 5:24 PM Changeset in webkit [93565] by
-
- 4 edits2 adds in trunk
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.
aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351
Source/WebCore:
Test: accessibility/aria-labelledby-overrides-aria-labeledby.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
- accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.
- 5:14 PM Changeset in webkit [93564] by
-
- 10 edits in trunk/Source
Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708
Reviewed by Kenneth Russell.
Source/WebCore:
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::isResourceSafe):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Source/WebKit/chromium:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):
- src/GraphicsContext3DInternal.h:
- 5:05 PM Changeset in webkit [93563] by
-
- 2 edits in trunk/Tools
Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script. If this doesn't
work we'll just live with the it hung for now.
Unreviewed.
- EWSTools/start-queue.sh:
- 4:53 PM Changeset in webkit [93562] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
in which case the serializer treats all expectations as unparsed.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
- 4:52 PM Changeset in webkit [93561] by
-
- 3 edits3 adds in trunk
HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728
Reviewed by Darin Adler.
Source/WebCore:
If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input. If
the future input is small enough, that will walk off the end of the
input and crash.
Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
LayoutTests:
Test that we don't crash when we get a bad network packet boundary.
- http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
- http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
- http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
- 4:41 PM Changeset in webkit [93560] by
-
- 7 edits2 adds in trunk/Source/JavaScriptCore
Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724
Reviewed by Darin Adler.
Moved SamplingCounter to a separate header in runtime/.
- GNUmakefile.list.am:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/SamplingTool.cpp:
- bytecode/SamplingTool.h:
- runtime/SamplingCounter.cpp: Added.
(JSC::AbstractSamplingCounter::dump):
- runtime/SamplingCounter.h: Added.
(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
- 4:34 PM Changeset in webkit [93559] by
-
- 3 edits in trunk/Source/WebCore
Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721
Reviewed by Ryosuke Niwa.
bidiNext and bidiFirst are horribly confusing.
Even worse is that bidiNext takes a bunch of mutually exclusive options.
It appears that there is a "return me every inline, even if its empty"
mode which is only used for simplified inline layout in RenderBlock.cpp.
To support that mode, there is a endOfInline pointer which keeps track
of if we just returned at the end of an inline to so we don't get stuck in
and empty inline (unable to distinguish the start from the finish).
The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.)
This change renames bidiNext to bidiNextShared (still a horrible name) and moves
all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
It becomes obvious which code uses which.
In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.
No functional change, thus no tests.
- rendering/InlineIterator.h:
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
(WebCore::bidiFirstIncludingEmptyInlines):
(WebCore::InlineWalker::InlineWalker):
(WebCore::InlineWalker::advance):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- 4:30 PM Changeset in webkit [93558] by
-
- 6 edits in trunk/Source/WebCore
Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725
Reviewed by Darin Adler.
No new functionality exposed so no new tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent): Ditto.
- bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage): Ditto.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Ditto.
- workers/SharedWorkerContext.cpp:
(WebCore::createConnectEvent): Added release() when a RefPtr is returned.
- 4:24 PM Changeset in webkit [93557] by
-
- 3 edits in trunk/Source/WebCore
Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648
Reviewed by Dan Bernstein.
No new tests / no functionality changed.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
- 4:15 PM Changeset in webkit [93556] by
-
- 11 edits6 deletes in trunk
Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143
Broke Leopard, SnowLeopard, and Chromium Mac bots
Source/WebCore:
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- rendering/RenderBlock.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
LayoutTests:
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
- 4:08 PM Changeset in webkit [93555] by
-
- 7 edits in trunk/Source/WebKit2
Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717
Reviewed by Anders Carlsson.
Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::releaseObject):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
(WebKit::trySafeReleaseNPObject):
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
- 4:08 PM Changeset in webkit [93554] by
-
- 1 edit1 copy1 delete in trunk/LayoutTests
Move chromium-mac/plugins/keyboard-events-expected.txt to
chromium-cg-mac/plugins/keyboard-events-expected.txt since the results
for chromium-mac are currently in chromium-cg-mac. This result was
added in r93519 and put in the wrong place.
- platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt.
- platform/chromium-mac/plugins: Removed.
- platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed.
- 3:44 PM Changeset in webkit [93553] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711
Reviewed by Tony Chang.
The Chromium side of this patch was submitted as
http://crrev.com/97687.
- public/WebIDBCallbacks.h:
- public/WebIDBCursor.h:
(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
- 3:35 PM Changeset in webkit [93552] by
-
- 3 edits in trunk/Tools
Update unit test expectations after r93530.
- Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
- 3:20 PM Changeset in webkit [93551] by
-
- 14 edits in trunk
Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701
Reviewed by Eric Seidel.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js:
- 3:08 PM Changeset in webkit [93550] by
-
- 4 edits in trunk/Source/WebKit2
Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722
Reviewed by Darin Adler.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
- UIProcess/API/mac/WKView.mm:
(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):
- UIProcess/API/mac/WKViewInternal.h:
- 3:01 PM Changeset in webkit [93549] by
-
- 2 edits in trunk/LayoutTests
Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
because r93529 didn't fix it. The failure is still tracked by the bug 66514.
- platform/qt/Skipped:
- 2:56 PM Changeset in webkit [93548] by
-
- 2 edits in trunk/Source/WebKit2
Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716
Reviewed by Darin Adler.
- UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
- 2:49 PM Changeset in webkit [93547] by
-
- 6 edits2 adds in trunk
handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887
Reviewed by David Hyatt.
Source/WebCore:
Test: css3/flexbox/002.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is
auto, treat it as flex(1 0 0).
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.
LayoutTests:
- css3/flexbox/002-expected.txt: Added.
- css3/flexbox/002.html: Added.
- css3/flexbox/resources/flexbox.js:
(checkHorizontalBoxen):
- 2:46 PM Changeset in webkit [93546] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464
Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.
Reviewed by Anders Carlsson.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
- 2:45 PM Changeset in webkit [93545] by
-
- 3 edits in trunk/Tools
[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
- 2:38 PM Changeset in webkit [93544] by
-
- 2 edits in trunk/Source/WebKit2
Use -[NSApplication updateWindows] to update the current input context
https://bugs.webkit.org/show_bug.cgi?id=66715
Reviewed by Alexey Proskuryakov.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
- 2:35 PM Changeset in webkit [93543] by
-
- 19 edits in trunk/Source/WebKit2
The UI process should keep track of whether a plug-in has focus or not
https://bugs.webkit.org/show_bug.cgi?id=66712
Reviewed by Darin Adler.
This is in preparation for implementing the updated Cocoa text input model.
Pipe through whether a plug-in and its containing window has focus or not, from the
plug-in process and all the way to the UI process.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged):
- UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged):
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
- WebProcess/Plugins/PluginView.h:
- 2:23 PM Changeset in webkit [93542] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696
Reviewed by James Robinson.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
- 2:13 PM Changeset in webkit [93541] by
-
- 2 edits in trunk/LayoutTests
[chromium] Disable compositing tests for Leopard.
Reviewed by James Robinson.
- platform/chromium/test_expectations.txt:
- 2:07 PM Changeset in webkit [93540] by
-
- 2 edits in trunk/Source/WebCore
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703
This error was detected by the debug build of the Chromium WebKit
Canary.
Reviewed by James Robinson.
No new tests. This change suppresses a compile-time warning
but does not affect the generated code.
- platform/graphics/mac/FontCustomPlatformData.h:
Replaced struct with class in a forward reference.
- 2:05 PM Changeset in webkit [93539] by
-
- 2 edits in trunk/Source/WebKit2
Update the current NSTextInputContext whenever the plug-in complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66709
Reviewed by Sam Weinig.
Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input
context. Fixes a rare case when the out-of-line editing window wouldn't appear.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
- 2:04 PM Changeset in webkit [93538] by
-
- 11 edits6 adds in trunk
[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143
Source/WebCore:
When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.
The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-22
Reviewed by David Hyatt.
Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- rendering/RenderBlock.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
- rendering/RenderFlowThread.h:
(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):
LayoutTests:
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-22
Reviewed by David Hyatt.
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
- fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added.
- fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
- 1:53 PM Changeset in webkit [93537] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.
- DEPS: Done it.
- 1:45 PM Changeset in webkit [93536] by
-
- 1 edit6 adds in trunk/LayoutTests
REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340
Reviewed by Darin Adler.
Added tests which are similar to the non worker test with the same name.
- http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added.
- http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added.
- http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added.
- http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added.
- http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added.
- 1:39 PM Changeset in webkit [93535] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to 97698.
- DEPS: Rolled.
- 1:38 PM Changeset in webkit [93534] by
-
- 1 edit1 move in trunk/LayoutTests
[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac
- platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac.
- platform/chromium-gpu-mac: Removed.
- 1:34 PM Changeset in webkit [93533] by
-
- 5 edits in branches/chromium/835/Source
Merge 93296 - Prepare frames for history navigation.
Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.
https://bugs.webkit.org/show_bug.cgi?id=66322
Reviewed by Darin Fisher.
Source/WebCore:
No new tests, as history navigation is very difficult to test in
DumpRenderTree.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
- loader/FrameLoader.h:
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/7711011
- 1:23 PM Changeset in webkit [93532] by
-
- 3 edits3 deletes in trunk
Unreviewed, rolling out r93517.
http://trac.webkit.org/changeset/93517
https://bugs.webkit.org/show_bug.cgi?id=63553
Breaks GTK Linux and Chromium Win
Source/WebCore:
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
LayoutTests:
- svg/animations/animate-end-attribute-expected.txt: Removed.
- svg/animations/animate-end-attribute.html: Removed.
- svg/animations/script-tests/animate-end-attribute.js: Removed.
- 1:05 PM Changeset in webkit [93531] by
-
- 4 edits in trunk/Source/WebCore
FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-22
Reviewed by Darin Adler.
setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
- 12:35 PM Changeset in webkit [93530] by
-
- 4 edits in trunk/Tools
[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693
Reviewed by Dirk Pranke.
Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.
- Scripts/webkitpy/layout_tests/port/builders.py:
- 12:12 PM Changeset in webkit [93529] by
-
- 5 edits in trunk/LayoutTests
editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551
Reviewed by Adam Roben.
Replaced leapForward by dummy clicks to make it work on Windows and other ports.
- editing/selection/caret-at-bidi-boundary.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:08 PM Changeset in webkit [93528] by
-
- 13 edits in trunk
Add CSS parsing of -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=65384
Source/WebCore:
The property is an int described here:
http://dev.w3.org/csswg/css3-flexbox/#flex-order
Doesn't do anything yet, just hooking it up.
Reviewed by Ojan Vafai.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexOrder):
(WebCore::InheritedFlags::setFlexOrder):
(WebCore::InheritedFlags::initialFlexOrder):
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
Reviewed by Ojan Vafai.
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/script-tests/css-properties.js:
- 12:03 PM Changeset in webkit [93527] by
-
- 2 edits in trunk/Tools
fix the GPU bot names on the layout test dashboard
https://bugs.webkit.org/show_bug.cgi?id=66697
Reviewed by Dimitri Glazkov.
- TestResultServer/static-dashboards/builders.js:
- 11:49 AM Changeset in webkit [93526] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691
Reviewed by James Robinson.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectTileTextures):
- 11:30 AM Changeset in webkit [93525] by
-
- 4 edits in branches/chromium/835/Source/WebCore
Merge 93042 - Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221
Reviewed by Yury Semikhatsky.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7708013
- 11:28 AM Changeset in webkit [93524] by
-
- 4 edits in branches/chromium/835
Merge 92764 - Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
https://bugs.webkit.org/show_bug.cgi?id=65918
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):
LayoutTests:
- inspector/styles/styles-commit-editing.html:
TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/7708012
- 11:18 AM Changeset in webkit [93523] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Content and render surface textures not freed when compositor context destroyed
https://bugs.webkit.org/show_bug.cgi?id=66589
Patch by James Robinson <jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.
Explicitly delete all managed textures when destroying the compositor
context. This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.
We sadly don't have a way to construct automated tests for resource
leaks currently.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- 11:15 AM Changeset in webkit [93522] by
-
- 6 edits in trunk/Tools
garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
- 11:12 AM Changeset in webkit [93521] by
-
- 3 edits4 adds in trunk
Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741
Reviewed by Adam Barth.
Test: fast/loader/document-destruction-within-unload.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Prevent unload events
from going into infinite recursion.
(WebCore::FrameLoader::setDocumentLoader): Ensure we don't
let set m_documentLoader to a DocumentLoader with a null Frame*.
(WebCore::FrameLoader::detachChildren): Save off a vector of
children to detach, rather than doing it inline.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.
Reviewed by Adam Barth.
- fast/loader/document-destruction-within-unload-expected.txt: Added.
- fast/loader/document-destruction-within-unload.html: Added.
- fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
- fast/loader/resources/document-destruction-within-unload.svg: Added.
- 11:07 AM Changeset in webkit [93520] by
-
- 2 edits in trunk/LayoutTests
[chromium] Skip rtl-composited, as it causes other tests to crash.
Unreviewed expectation change.
- platform/chromium/test_expectations.txt:
- 11:06 AM Changeset in webkit [93519] by
-
- 2 edits3 adds in trunk/LayoutTests
[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.
Update the Chromium Linux test results following r88712. Also rebaseline test results
for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events. The Chromium port reports the actual line number, hence
the need for separate test results for Chromium. The test now runs, and passes on all
the Chromium ports, following r87855. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 34936.
- platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
- platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:03 AM Changeset in webkit [93518] by
-
- 4 edits3 moves2 deletes in trunk/LayoutTests
Rebaseline for webkit bug 65295
https://bugs.webkit.org/show_bug.cgi?id=66637
Patch by Ben Wells <benwells@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.
- fast/box-shadow/box-shadow-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt.
- fast/layers/self-painting-outline-expected.txt: Renamed from LayoutTests/platform/gtk/fast/layers/self-painting-outline-expected.txt.
- platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
- platform/chromium-win/fast/layers/self-painting-outline-expected.png:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/box-shadow/box-shadow-radius-expected.png: Renamed from LayoutTests/fast/box-shadow/box-shadow-radius-expected.png.
- platform/mac/fast/layers/self-painting-outline-expected.txt: Removed.
- platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
- 11:00 AM Changeset in webkit [93517] by
-
- 3 edits3 adds in trunk
Patch by Young Han Lee <joybro@company100.net> on 2011-08-22
Reviewed by Dirk Schulze.
SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553
calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")
This change makes the function return the animations's true progress instead of 100%
when the animation ends.
Source/WebCore:
Test: svg/animations/animate-end-attribute.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
LayoutTests:
- svg/animations/animate-end-attribute-expected.txt: Added.
- svg/animations/animate-end-attribute.html: Added.
- svg/animations/script-tests/animate-end-attribute.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- 10:49 AM Changeset in webkit [93516] by
-
- 2 edits in trunk/Source/WebCore
Fix build error when inspector is disabled.
https://bugs.webkit.org/show_bug.cgi?id=66644
Reviewed by Darin Adler.
- inspector/InspectorDatabaseResource.h: Add ENABLE(INSPECTOR) macro.
- 10:49 AM Changeset in webkit [93515] by
-
- 3 edits in trunk/Tools
Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-08-22
Reviewed by Tony Chang.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
(buildChromiumMakefile):
(buildChromium):
- 10:33 AM Changeset in webkit [93514] by
-
- 3 edits2 adds in trunk
Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678
Source/WebCore:
RefPtr the focusable node to prevent getting deleted by mutation
event.
Reviewed by Dave Hyatt.
Test: fast/frames/focus-controller-crash-change-event.html
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
LayoutTests:
Reviewed by Dave Hyatt.
- fast/frames/focus-controller-crash-change-event-expected.txt: Added.
- fast/frames/focus-controller-crash-change-event.html: Added.
- 10:07 AM Changeset in webkit [93513] by
-
- 3 edits in trunk/LayoutTests
[GTK] Some GTK+-specific font-face tests fail on the bots
https://bugs.webkit.org/show_bug.cgi?id=65820
Fix the timing issues in this test.
Reviewed by Philippe Normand.
- platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until
after document.readyState moves to "complete" and a short timeout.
- platform/gtk/fonts/font-face-with-complex-text.html: Ditto.
- 9:02 AM Changeset in webkit [93512] by
-
- 4 edits in trunk/Source
Source/WebCore: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Replacing the crash with a more graceful failure: canvas
will not render.
Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
This is the non-crashing version of the factory function.
It returns NULL if allocation fails. Code for handling
NULL pointer was already in place.
Source/WebKit/chromium: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.
- DEPS:
Bumping up the chrome DEPS to pick up 97474, which is
required by this patch.
- 8:52 AM Changeset in webkit [93511] by
-
- 2 edits in trunk/Tools
Add myself to the contributor list.
https://bugs.webkit.org/show_bug.cgi?id=66674
Patch by Peter Beverloo <peter@chromium.org> on 2011-08-22
Reviewed by Tony Gentilcore.
- Scripts/webkitpy/common/config/committers.py:
- 8:36 AM Changeset in webkit [93510] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670
jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.
Reviewed by Pavel Feldman.
- inspector/CodeGeneratorInspector.pm:
(GenerateInterface):
(generateBackendStubJS):
- inspector/front-end/ApplicationCacheItemsView.js:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
- inspector/front-end/DOMStorage.js:
- inspector/front-end/Database.js:
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
- inspector/front-end/TimelineManager.js:
(WebInspector.TimelineDispatcher):
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager):
- inspector/front-end/inspector.js:
- 8:17 AM Changeset in webkit [93509] by
-
- 2 edits in trunk/Tools
[Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299
Reviewed by Csaba Osztrogonác.
- DumpRenderTree/qt/ImageDiff.cpp:
(main):
- 6:43 AM Changeset in webkit [93508] by
-
- 2 edits in trunk/LayoutTests
[NRWT] Fix "Only unexpected results" option of results.html
https://bugs.webkit.org/show_bug.cgi?id=66657
Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.
- fast/harness/results.html:
- 6:26 AM Changeset in webkit [93507] by
-
- 2 edits in trunk/Source/WebCore
Fix generate-inspector-idl for Python3 after r93396
https://bugs.webkit.org/show_bug.cgi?id=66663
Reviewed by Andreas Kling.
In Python3, print is a function instead of a language keyword. Using parentheses
around the argument ensures the code works for both Python 2 and 3.
- inspector/generate-inspector-idl:
- 5:22 AM Changeset in webkit [93506] by
-
- 2 edits in trunk/LayoutTests
2011-08-22 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 5:06 AM Changeset in webkit [93505] by
-
- 3 edits in trunk/LayoutTests
[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
https://bugs.webkit.org/show_bug.cgi?id=66649
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-22
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/close-before-open-expected.txt:
- http/tests/websocket/tests/hybi/close-before-open.html:
Add new URL to reproduce the problem.
- 5:03 AM Changeset in webkit [93504] by
-
- 2 edits in trunk/Tools
Update contributor list.
Reviewed by Zoltan Herczeg.
- Scripts/webkitpy/common/config/committers.py:
- 4:53 AM Changeset in webkit [93503] by
-
- 3 edits in trunk/Source/WebCore
Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658
Reviewed by Kent Tamura.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
- html/ColorInputType.h:
- 3:05 AM Changeset in webkit [93502] by
-
- 2 edits in trunk/Tools
[ORWT] Fix --reset-results --add-platform-exceptions combo
https://bugs.webkit.org/show_bug.cgi?id=65464
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.
- Scripts/old-run-webkit-tests:
- 2:17 AM Changeset in webkit [93501] by
-
- 8 edits3 adds in trunk
Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/breakpoint-manager.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Added.
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt: Added.
- inspector/debugger/breakpoint-manager.html: Added.
- 2:09 AM Changeset in webkit [93500] by
-
- 2 edits in trunk/LayoutTests
[Qt][ARM] Add bug report to flaky tests
http/tests/cache/subresource-multiple-instances.html
https://bugs.webkit.org/show_bug.cgi?id=66652
http/tests/inspector/resource-tree/resource-tree-errors-reload.html
https://bugs.webkit.org/show_bug.cgi?id=66653
- platform/qt-arm/Skipped:
- 2:07 AM Changeset in webkit [93499] by
-
- 4 edits2 copies in branches/chromium/835
Merge 93347
BUG=90357
Review URL: http://codereview.chromium.org/7696023
- 2:04 AM Changeset in webkit [93498] by
-
- 1 edit2 copies in branches/chromium/835
Merge 93032
BUG=92769
Review URL: http://codereview.chromium.org/7693023
- 1:56 AM Changeset in webkit [93497] by
-
- 6 edits3 copies in branches/chromium/835
Merge 93227
BUG=92959
Review URL: http://codereview.chromium.org/7694026
- 1:49 AM Changeset in webkit [93496] by
-
- 1 edit2 copies in branches/chromium/835
Merge 92132
BUG=89991
Review URL: http://codereview.chromium.org/7693022
- 1:39 AM Changeset in webkit [93495] by
-
- 2 edits in branches/chromium/835
Merge 93397
BUG=76771
Review URL: http://codereview.chromium.org/7697013
- 1:05 AM Changeset in webkit [93494] by
-
- 2 edits in trunk/LayoutTests
[Qt][ARM] Skip flaky tests.
- platform/qt-arm/Skipped:
Aug 21, 2011:
- 9:04 PM Changeset in webkit [93493] by
-
- 6 edits in branches/chromium/835/Source/WebCore
Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063
Reviewed by Darin Fisher.
Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.
Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.
Patch originally by Tom Hudson.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
BUG=93558
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7696019
- 6:10 PM Changeset in webkit [93492] by
-
- 5 edits in trunk/Source
Fix 'make dist' for WebKitGTK+.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add a missing header to the sources list.
Source/WebCore:
- GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
- GNUmakefile.list.am: Update the sources list to reflect reality.
- 1:22 PM Changeset in webkit [93491] by
-
- 14 edits in trunk/LayoutTests
Update results for more tests affected by the addition of the
HTMLSourceElement class.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 8:53 AM Changeset in webkit [93490] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fixes premature plugin unload bug
https://bugs.webkit.org/show_bug.cgi?id=66628
Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.
The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.
- WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::loadSpellChecker):
- WebCoreSupport/TextCheckerClientQt.h:
Aug 20, 2011:
- 11:26 PM Changeset in webkit [93489] by
-
- 1 edit2 copies in branches/chromium/835
Merge 93382 - REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
LayoutTests:
- fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
- fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/7703003
- 10:27 PM Changeset in webkit [93488] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
- ewk/ewk_view.h:
Fixes description of method, parameters and returned value of API
related to settings.
- 10:21 PM Changeset in webkit [93487] by
-
- 5 edits in trunk
JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572
Source/JavaScriptCore:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Changed the handling of const to add the dynamic scope depth.
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
LayoutTests:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Added tests that reproduce the failure.
- fast/js/const-expected.txt:
- fast/js/resources/const.js:
(tryCatch1):
(tryCatch2):
(with1):
(with2):
- 10:14 PM Changeset in webkit [93486] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.
- ewk/ewk_view.h:
- 9:50 PM Changeset in webkit [93485] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.
- ewk/ewk_view.h:
- 9:37 PM Changeset in webkit [93484] by
-
- 5 edits in trunk/Source
Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
Covered by existing tests, and no code was changed.
- WebCore.gyp/WebCore.gyp:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
- DEPS:
- 1:37 PM Changeset in webkit [93483] by
-
- 7 edits2 adds in trunk/Tools
garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625
Reviewed by Dimitri Glazkov.
This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction. The
patch also adds an Examine button to failure notifications. In a
future patch, I'll add a controller that wires this button up to
something useful.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
- 11:40 AM Changeset in webkit [93482] by
-
- 14 edits in trunk
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.
Source/WebCore:
Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
- bindings/generic/RuntimeEnabledFeatures.h:
- page/DOMWindow.idl:
LayoutTests:
Updated test results after adding HTMLSourceElement to the DOMWindow
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- 11:11 AM Changeset in webkit [93481] by
-
- 9 edits2 adds in trunk
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/dom/Range/insertNode-empty-fragment-crash.html
- dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.
LayoutTests:
- fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
- fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
- 8:54 AM Changeset in webkit [93480] by
-
- 4 edits in trunk/Tools
garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624
Reviewed by Dimitri Glazkov.
This patch creates a notification-based UI for build failures. The new
UI displays the same information that used to be displayed in the
infobar. There's lots of room for improvement in surfacing more
information, but this is a start.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 5:27 AM Changeset in webkit [93479] by
-
- 2 edits in trunk/LayoutTests
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515
Unreviewed gardening.
- platform/wk2/Skipped: Skip dependent test.
- 5:15 AM Changeset in webkit [93478] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626
Unreviewed gardening.
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [93477] by
-
- 3 edits2 adds in trunk
OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.
Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):
LayoutTests:
Added test case covering keySpline array length problem.
- svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
- svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.
Aug 19, 2011:
- 11:32 PM Changeset in webkit [93476] by
-
- 8 edits3 deletes in trunk
Unreviewed, rolling out r93415.
http://trac.webkit.org/changeset/93415
https://bugs.webkit.org/show_bug.cgi?id=66623
Introduces failing test (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Removed.
- inspector/front-end/DebuggerModel.js:
- inspector/front-end/SourceFile.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt: Removed.
- inspector/debugger/breakpoint-manager.html: Removed.
- 11:19 PM Changeset in webkit [93475] by
-
- 2 edits2 copies2 deletes in trunk/LayoutTests
Chromium Windows and Linux rebaselines. These baselines were so wrong.
- platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
- platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium/test_expectations.txt:
- 9:32 PM Changeset in webkit [93474] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93369 on GTK; the failure is tracked by the bug 66621.
- platform/gtk/Skipped:
- 9:27 PM Changeset in webkit [93473] by
-
- 1 edit1 copy1 delete in trunk/LayoutTests
Remove the left over from r93468; also fix Chromium Windows expectation
(Copied it over from fast/css/getComputedStyle/ and replaced Times with 'times new roman')
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- 8:41 PM Changeset in webkit [93472] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93392 on Windows; the failure is tracked by the bug 66620.
- platform/win/Skipped:
- 8:36 PM Changeset in webkit [93471] by
-
- 1 edit3 adds in trunk/LayoutTests
More rebaseline after r93068. Apparently Windows XP needs a separate baseline.
- platform/win-xp/editing: Added.
- platform/win-xp/editing/deleting: Added.
- platform/win-xp/editing/deleting/regional-indicators-expected.txt: Added.
- 8:29 PM Changeset in webkit [93470] by
-
- 1 edit1 move in trunk/LayoutTests
Redo the rebaseline done by r93353. The test that has been failing on GTK is
editing/deleting/regional-indicators.html, not editing/selection/regional-indicators.
The failure is still tracked by the bug 66501.
- platform/gtk/editing/deleting/regional-indicators-expected.txt: Copied from
LayoutTests/platform/gtk/editing/selection/regional-indicators-expected.txt.
- platform/gtk/editing/selection/regional-indicators-expected.txt: Removed.
- 8:19 PM Changeset in webkit [93469] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93392 on Qt. The failure is tracked by the bug 66619.
- platform/qt/Skipped:
- 8:12 PM Changeset in webkit [93468] by
-
- 1 edit1 copy4 deletes in trunk/LayoutTests
Rebaseline after r93430. Also removed superfluous expected result from Chromium directories.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced with
LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/chromium-cg-mac/fast/css/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt: Removed.
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- 7:59 PM Changeset in webkit [93467] by
-
- 2 edits in trunk/Source/JavaScriptCore
Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617
Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.
Reviewed by Antonio Gomes.
- heap/MachineStackMarker.cpp:
- 7:17 PM Changeset in webkit [93466] by
-
- 12 edits1 add in trunk/Source/JavaScriptCore
The JSC JIT currently has no facility to profile and report
the types of values
https://bugs.webkit.org/show_bug.cgi?id=65901
Reviewed by Gavin Barraclough.
Added the ability to profile the values seen at function calls (both
arguments and results) and heap loads. This is done with emphasis
on performance. A value profiling site consists of: add, and,
move, and store; no branching is necessary. Each value profiling
site (called a ValueProfile) has a ring buffer of 8 recently-seen
values. ValueProfiles are stored in the CodeBlock; there will be
one for each argument (excluding this) and each heap load or callsite.
Each time a value profiling site executes, it stores the value into
a pseudo-random element in the ValueProfile buffer. The point is
that for frequently executed code, we will have 8 somewhat recent
values in the buffer and will be able to not only figure out what
type it is, but also to be able to reason about the actual values
if we wish to do so.
This feature is currently disabled by default. When enabled, it
results in a 3.7% slow-down on SunSpider.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::numberOfValueProfiles):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
- bytecode/ValueProfile.h: Added.
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::computeProbability):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::probabilityOfInt32):
(JSC::ValueProfile::probabilityOfDouble):
(JSC::ValueProfile::probabilityOfCell):
(JSC::getValueProfileBytecodeOffset):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
- jit/JSInterfaceJIT.h:
- wtf/Platform.h:
- wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::genericBinarySearch):
- 6:55 PM UsingGitWithWebKit edited by
- Update the git instructions so that git-svn and git update the same … (diff)
- 6:47 PM Changeset in webkit [93465] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't include DisallowCType.h when building on QNX
https://bugs.webkit.org/show_bug.cgi?id=66616
Reviewed by Antonio Gomes.
- config.h:
- 6:46 PM Changeset in webkit [93464] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93369 because Window's DRT actually sleeps for
the amount of time leapForward is called upon. The failure is tracked by the bug 66551.
- platform/win/Skipped:
- 6:31 PM Changeset in webkit [93463] by
-
- 4 edits in trunk/Tools
[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606
Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.
The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 6:17 PM Changeset in webkit [93462] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611
Reviewed by Antonio Gomes.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 6:14 PM Changeset in webkit [93461] by
-
- 4 edits in trunk/Source/WebCore
AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes
https://bugs.webkit.org/show_bug.cgi?id=61289
Update the code to determine the position of accessibility elements on Mac for WK2,
so that elements within iframes are positioned correctly.
Reviewed by Darin Adler..
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::page):
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
- 5:45 PM Changeset in webkit [93460] by
-
- 4 edits in trunk/Source/WebCore
New XML parser: text nodes outside of root element not created for document fragments
https://bugs.webkit.org/show_bug.cgi?id=66604
When intializing a fragment parser, declare that the first element has been seen. Also, flush the text nodes when finishing parsing a document.
Reviewed by Darin Adler.
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::finish):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::finish):
- xml/parser/XMLTreeBuilder.h:
- 5:41 PM Changeset in webkit [93459] by
-
- 3 edits in trunk/Source/WebCore
MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=66612
Reviewed by Darin Adler.
No new tests, should be covered by existing media tests.
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.
- 5:20 PM Changeset in webkit [93458] by
-
- 2 edits in trunk/Source/WebKit2
Another attempt at fixing the Windows build.
- UIProcess/PageClient.h:
- 4:59 PM Changeset in webkit [93457] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Fix for mis-merge. Radar 9750868
- 4:56 PM Changeset in webkit [93456] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build.
- WebProcess/Plugins/PluginController.h:
- 4:54 PM Changeset in webkit [93455] by
-
- 2 edits4 adds in trunk/LayoutTests
[chromium] GPU test expectation baseline update
Update pixel baselines for this test on mac and linux.
- platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:50 PM Changeset in webkit [93454] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Regression: Fix clang errors from r93424
https://bugs.webkit.org/show_bug.cgi?id=66609
Reviewed by James Robinson.
The invalidateRect function does not appear to be used anywhere
because the setNeedsDisplay function is used instead. Fix the Clang
error by just removing this unused vestigial base class function.
- platform/graphics/chromium/LayerChromium.h:
- 4:45 PM Changeset in webkit [93453] by
-
- 2 edits in trunk/Source/WebCore
Add new enums to npapi.h
https://bugs.webkit.org/show_bug.cgi?id=66608
Reviewed by Sam Weinig.
- bridge/npapi.h:
- 4:37 PM Changeset in webkit [93452] by
-
- 4 edits3 adds in trunk
libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423
Source/WebCore:
This makes the loop over the elements outside of the context actually update the element it's processing.
Reviewed by Darin Adler.
Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
LayoutTests:
Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
Reviewed by Darin Adler.
- fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
- 4:24 PM Changeset in webkit [93451] by
-
- 8 edits in trunk
Unreviewed, rolling out r93426.
http://trac.webkit.org/changeset/93426
https://bugs.webkit.org/show_bug.cgi?id=66607
Broke the Mac build by not building gtest.framework anymore
(Requested by andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/ThirdParty:
- gtest/README.WebKit:
- gtest/include/gtest/internal/gtest-port.h:
- gtest/msvc/gtest-md.vcproj:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
Tools:
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
- 4:22 PM Changeset in webkit [93450] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement WTF::atomic{Increment, Decrement}() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66605
Reviewed by Darin Adler.
- wtf/Atomics.h:
(WTF::atomicIncrement):
(WTF::atomicDecrement):
- 4:18 PM Changeset in webkit [93449] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Remove various unreferenced bits from Chromium API headers
https://bugs.webkit.org/show_bug.cgi?id=66575
Reviewed by Tony Chang.
- public/WebApplicationCacheHost.h:
(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
- public/WebFrame.h:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didReceiveTitle):
- public/WebVideoFrame.h:
- 3:53 PM Changeset in webkit [93448] by
-
- 2 edits1 move1 delete in trunk/LayoutTests
[chromium] Cleanup some old plugin tests. Rebase plugin-javascript-access.html
on win and run plugin-initiate-popup-window on mac/linux to get results.
- platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/win/plugins/plugin-javascript-access-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/plugin-javascript-access-expected.txt.
- 3:50 PM Changeset in webkit [93447] by
-
- 23 edits2 adds in trunk/Source/WebKit2
Make the complex text input state a tri-state enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=62245
Reviewed by Sam Weinig.
This is to prepare the infrastructure for supporting the updated Cocoa text input model for plug-ins.
- PluginProcess/PluginControllerProxy.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setComplexTextInputState):
(WebKit::PluginControllerProxy::compositingRenderServerPort):
- Shared/Plugins/mac: Added.
- Shared/Plugins/mac/PluginComplexTextInputState.h: Added.
(WebKit::isValidPluginComplexTextInputState):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setPluginComplexTextInputState):
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPluginComplexTextInputState):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::setComplexTextInputEnabled):
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::setComplexTextInputState):
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::setComplexTextInputState):
(WebKit::PluginView::compositingRenderServerPort):
- WebProcess/Plugins/PluginView.h:
- 3:38 PM Changeset in webkit [93446] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update chromium test expectations
Remove = CRASH expectations for tests fixed by r93441.
- platform/chromium/test_expectations.txt:
- 3:34 PM Changeset in webkit [93445] by
-
- 9 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=66590
Re-name scrollbar painter types
Reviewed by Sam Weinig.
Source/JavaScriptCore:
WTF_USE_WK_SCROLLBAR_PAINTER is now WTF_USE_SCROLLBAR_PAINTER since WK no longer
applies.
- wtf/Platform.h:
Source/WebCore:
Names changed to remove references to WebKitSystemInterface since the
implementation is now in WebCore. And the type names changed to be more Objective-
Cish instead of C++ish
WTF_USE_WK_SCROLLBAR_PAINTER -> WTF_USE_SCROLLBAR_PAINTER
WKScrollbarPainterRef -> ScrollbarPainter
WKScrollbarPainterControllerRef -> ScrollbarPainterController
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
- 3:26 PM Changeset in webkit [93444] by
-
- 3 edits in trunk/Tools
[chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
https://bugs.webkit.org/show_bug.cgi?id=66603
Reviewed by Dirk Pranke.
The various ChromiumGpu ports should use the same child worker
selection logic as other ports so they can run with full
parallelization on multicore systems.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 3:20 PM Changeset in webkit [93443] by
-
- 4 edits in trunk/Source/WebCore
Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
https://bugs.webkit.org/show_bug.cgi?id=66499
Patch by Van Lam <vanlam@google.com> on 2011-08-19
Reviewed by Ryosuke Niwa.
Renamed VisiblePosition::honorEditableBoundary* to
honorEditingBoundary.
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
- editing/VisiblePosition.h:
- editing/visible_units.cpp:
(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
- 3:12 PM Changeset in webkit [93442] by
-
- 4 edits in trunk/LayoutTests
[chromium] Update results for japanese-rl-selection-repaint-in-regions.html that
changed after r93428.
- platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- 2:50 PM Changeset in webkit [93441] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063
Reviewed by Darin Fisher.
Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.
Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.
Patch originally by Tom Hudson.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
- 2:40 PM Changeset in webkit [93440] by
-
- 14 edits in trunk/Source/WebCore
Switch clipping for svg to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66586
Reviewed by Eric Seidel.
No new tests as no new functionality.
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
- rendering/svg/RenderSVGText.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
- svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
(WebCore::SVGImage::setContainerSize):
- svg/graphics/SVGImage.h:
- 2:37 PM Changeset in webkit [93439] by
-
- 5 edits16 deletes in trunk
Unreviewed, rolling out r93425.
http://trac.webkit.org/changeset/93425
https://bugs.webkit.org/show_bug.cgi?id=66591
"The newly-added ASSERT is being triggered on several bots"
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/WebCore:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabled):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::disabled):
- html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript):
LayoutTests:
- fast/css/link-disabled-attr-expected.txt:
- fast/css/stylesheet-enable-first-alternate-expected.txt: Removed.
- fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Removed.
- fast/css/stylesheet-enable-first-alternate-on-load.html: Removed.
- fast/css/stylesheet-enable-first-alternate.html: Removed.
- fast/css/stylesheet-enable-second-alternate-expected.txt: Removed.
- fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Removed.
- fast/css/stylesheet-enable-second-alternate-on-load.html: Removed.
- fast/css/stylesheet-enable-second-alternate.html: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Removed.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Removed.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Removed.
- http/tests/css/resources/slow-loading-sheet-in-error.php: Removed.
- http/tests/css/resources/slow-loading-sheet.php: Removed.
- 2:24 PM Changeset in webkit [93438] by
-
- 11 edits in trunk/Source/WebCore
[chromium] Refactor updateCompositorResources to take an explicit GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=66432
Reviewed by James Robinson.
Covered by existing tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- 2:12 PM Changeset in webkit [93437] by
-
- 3 edits2 adds in trunk
Tell media player to prepareToPlay() at end of HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-load-preload-none.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
LayoutTests:
- media/video-load-preload-none-expected.txt: Added.
- media/video-load-preload-none.html: Added.
- 1:57 PM Changeset in webkit [93436] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66502
Reviewed by Eric Seidel.
Convert RenderBlock to new layout abstraction. Leave m_lineHight as a 30
bit int for now to avoid unnecessarily increasing the memory usage.
No new tests as no new functionality.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- 1:40 PM Changeset in webkit [93435] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderBoxModelObject to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66534
Reviewed by Eric Seidel.
Convert RenderBoxModelObject to new layout abstraction.
No new tests as no new functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::set):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::backgroundRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::borderWillArcInnerEdge):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):
- rendering/RenderBoxModelObject.h:
- 1:37 PM Changeset in webkit [93434] by
-
- 4 edits in trunk/Source/WebKit/chromium
Expose Fixed Layout Size mode to Chromium's WebKit API
https://bugs.webkit.org/show_bug.cgi?id=66568
Reviewed by Darin Fisher.
- public/WebView.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isFixedLayoutModeEnabled):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setFixedLayoutSize):
- src/WebViewImpl.h:
- 1:22 PM Changeset in webkit [93433] by
-
- 3 edits in trunk/Tools
[chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=66570
Reviewed by Mihai Parparita.
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h:
- 1:03 PM Changeset in webkit [93432] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions]Speed up RenderFlowThread repaint of regions
https://bugs.webkit.org/show_bug.cgi?id=66566
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.
When in printing or the repaint rectangle is empty, there is no need to iterate
the render flow regions in order to repaint.
Covered by existing tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::shouldRepaint):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- 12:44 PM Changeset in webkit [93431] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark touch tests as failing on OSX 10.5.
- platform/chromium/test_expectations.txt:
- 12:27 PM Changeset in webkit [93430] by
-
- 13 edits in trunk
[CSSRegions]Parse -webkit-region-break(after, before, inside)
https://bugs.webkit.org/show_bug.cgi?id=66559
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSMutableStyleDeclaration.cpp:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionBreakBefore):
(WebCore::InheritedFlags::regionBreakInside):
(WebCore::InheritedFlags::regionBreakAfter):
(WebCore::InheritedFlags::setRegionBreakBefore):
(WebCore::InheritedFlags::setRegionBreakInside):
(WebCore::InheritedFlags::setRegionBreakAfter):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:26 PM Changeset in webkit [93429] by
-
- 8 edits in trunk/Source/WebCore
Switch RenderLayer to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66507
Reviewed by Eric Seidel.
Convert RenderLayer to new layout abstraction.
No new tests as no new functionality.
- rendering/LayoutTypes.h:
(WebCore::flooredLayoutSize):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderLayerCompositor.h:
- 12:19 PM Changeset in webkit [93428] by
-
- 3 edits2 adds in trunk
[CSSRegions]Content displayed in regions should not be scrollable
https://bugs.webkit.org/show_bug.cgi?id=66459
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by Darin Adler.
Source/WebCore:
Initially, when creating the style for the RenderFlowThread, overflowX and overflowY were both set to hidden,
so that RenderView did not display scrollbars when a RenderFlowThread exists. However, this allowed the possibility
of scrolling the content displayed in region.
Now, the RenderFlowThread objects are ignored in RenderBlock::insertPositionedObject and the style of the RenderFlowThread
can be set to visible, thus preventing scrolling of the content displayed in regions.
Test: fast/regions/content-flowed-into-regions-no-scroll.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::createFlowThreadStyle):
LayoutTests:
- fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
- fast/regions/content-flowed-into-regions-no-scroll.html: Added.
- 12:15 PM Changeset in webkit [93427] by
-
- 13 edits3 adds in trunk/Source/WebKit2
[Qt] [WK2] Provide API for intercept (and possible ignore) links clicked in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65920
Reviewed by Benjamin Poulain.
This patch makes QDesktopWebView delegate the decision of whether a navigation
should proceed to a slot in QML. The user of the DesktopWebView must implement a
'navigationPolicyForUrl()' if it wants to use the feature.
Such feature is useful for implementing opening links in "new tab" by using a
specific mouse button or mouse button plus keyboard modifiers.
The patch introduces a internal Qt-level interface called PolicyInterface, that
is used by QtWebPageProxy to delegate policy calls. A concrete implementation is
provided for QDesktopWebView.
- Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Implement the serialization of the Request URL, which is the only data
we exposing from the Request.
- WebKit2.pro:
- UIProcess/qt/PolicyInterface.h: Added.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
- UIProcess/qt/QtWebPageProxy.h:
Register a Policy Client in the WK2 C API only if there's a PolicyInterface available.
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/ClientImpl.cpp:
(toPolicyInterface):
(toQtMouseButton):
(toQtKeyboardModifiers):
(qt_wk_decidePolicyForNavigationAction):
Implement the callback for the Page Policy Client. It will translate the
arguments to Qt jargon and call PolicyInterface.
- UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::QDesktopWebPageProxy):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qdesktopwebview.cpp:
(toPolicyAction):
(hasMetaMethod):
(QDesktopWebViewPrivate::navigationPolicyForURL):
The concrete implementation for QDesktopWebView. Its private object implements
the PolicyInterface and try to call a possible function defined in QML (so return
value and arguments all QVariants). If there's no such a function, returns the
default UsePolicy, like if we haven't registered a PolicyClient in WK2 C API.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/test2.html: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
Add a test for DesktopWebView QML element making use of a button and a modifier to
ignore a navigation.
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
For now, we don't have a PolicyInterface for QTouchWebView.
- 12:08 PM Changeset in webkit [93426] by
-
- 8 edits in trunk
TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
Reviewed by David Levin.
- gtest/include/gtest/internal/gtest-port.h:
- gtest/msvc/gtest-md.vcproj:
- gtest/README.WebKit:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
Tools:
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=66521
Reviewed by David Levin.
- TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
- 11:54 AM Changeset in webkit [93425] by
-
- 5 edits16 adds in trunk
REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140
<rdar://problem/9835905>
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/css/stylesheet-enable-first-alternate-on-load.html
fast/css/stylesheet-enable-first-alternate.html
fast/css/stylesheet-enable-second-alternate-on-load.html
fast/css/stylesheet-enable-second-alternate.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
The gist of the issue is that we were ignoring calls to HTMLLinkElement::setDisabled that would enable a
style sheet when we were loading a stylesheet (m_sheet was 0 and thus ignored the call per the spec).
FF goes against the CSS OM spec in this case and always keep an associated sheet as long as 'rel' hints
at a stylesheet link and href is present. Instead of siding with FF, I continued to follow the
specification and store the enabled via javascript state into m_scriptState (renamed from
m_isEnabledViaScript). This information gets merged back into the style sheet disabled state when it is
available.
While debugging the case at hand, I found some cases that were not properly handled and were fixed as
part of this change.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setDisabled): Always call setIsEnabledViaScript so that
the information is properly stored (either for recalcStyleSelector or just to store
the state during loading).
(WebCore::HTMLLinkElement::sheetLoaded): Merge back the state from m_scriptState to
the sheet's disabled state.
(WebCore::HTMLLinkElement::disabled): Account for the temporary state and return the
right value. It matches FF and what people would expect.
(WebCore::HTMLLinkElement::areDisabledAndScriptStatesConsistent): Debug only method
that checks that disabled() and isEnabledViaScript() are consistent with each other
(under some circumstances).
- html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setIsEnabledViaScript): Added setter.
LayoutTests:
- fast/css/link-disabled-attr-expected.txt: This change is a progression, but we are still
not handling updates to the selected style set properly (already covered by bug 62407).
- fast/css/stylesheet-enable-first-alternate-expected.txt: Added.
- fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Added.
- fast/css/stylesheet-enable-first-alternate-on-load.html: Added.
- fast/css/stylesheet-enable-first-alternate.html: Added.
- fast/css/stylesheet-enable-second-alternate-expected.txt: Added.
- fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Added.
- fast/css/stylesheet-enable-second-alternate-on-load.html: Added.
- fast/css/stylesheet-enable-second-alternate.html: Added.
Those are a variation on the same theme: we disable some stylesheet and enable others,
either directly or later.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.
(onSheetLoaded):
(testWhenLoaded):
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.
(onSheetLoaded):
(testWhenLoaded):
- http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
- http/tests/css/resources/slow-loading-sheet.php: Added.
Those 2 test cases relies on a slow loading stylesheet so that we can test the disabled() value while the alternate
sheet is asynchronously loading and then check them again once the sheet is loaded.
- 11:07 AM Changeset in webkit [93424] by
-
- 16 edits2 adds2 deletes in trunk/Source
[chromium] Split tiler into main thread / compositor thread versions
https://bugs.webkit.org/show_bug.cgi?id=66065
Reviewed by James Robinson.
Source/WebCore:
Covered by existing tests.
LayerTilerChromium is renamed to be CCLayerTilingData. Invalidation
and paint functionality is pushed into TiledLayerChromium and drawing
with GL is pushed into CCTiledLayerImpl. During tree synchronization,
the tiler properties and texture IDs are synchronized into
CCTiledLayerImpl.
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::bestTextureFormat):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: Removed.
- platform/graphics/chromium/ManagedTexture.h:
(WebCore::ManagedTexture::textureId):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::dirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::dumpLayerProperties):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::tileAt):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateTiles):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectVisibleTileTextures):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerTilingData.cpp: Added.
(WebCore::CCLayerTilingData::create):
(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
(WebCore::CCLayerTilingData::reset):
(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::contentRectToLayerRect):
(WebCore::CCLayerTilingData::layerRectToContentRect):
(WebCore::CCLayerTilingData::tileContentRect):
(WebCore::CCLayerTilingData::tileLayerRect):
(WebCore::CCLayerTilingData::setLayerPosition):
(WebCore::CCLayerTilingData::growLayerToContain):
- platform/graphics/chromium/cc/CCLayerTilingData.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h.
(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::numTilesX):
(WebCore::CCLayerTilingData::numTilesY):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::textureOffset):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::hasBorderTexels):
(WebCore::CCLayerTilingData::isEmpty):
(WebCore::CCLayerTilingData::Tile::Tile):
(WebCore::CCLayerTilingData::Tile::i):
(WebCore::CCLayerTilingData::Tile::j):
(WebCore::CCLayerTilingData::Tile::moveTo):
(WebCore::CCLayerTilingData::TileMapKeyTraits::emptyValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::constructDeletedValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::isDeletedValue):
(WebCore::CCLayerTilingData::tiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::DrawableTile):
(WebCore::DrawableTile::textureId):
(WebCore::DrawableTile::setTextureId):
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::tileAt):
(WebCore::CCTiledLayerImpl::createTile):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::setTilingData):
(WebCore::CCTiledLayerImpl::syncTextureId):
(WebCore::isCCW):
(WebCore::computeEdge):
(WebCore::intersect):
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::setSkipsDraw):
(WebCore::CCTiledLayerImpl::setTextureOrientation):
(WebCore::CCTiledLayerImpl::setSampledTexelFormat):
- platform/graphics/gpu/TilingData.h:
Source/WebKit/chromium:
Add a test for assignment and copy constructor for TilingData.
- tests/TilingDataTest.cpp:
(WebCore::TEST):
- 10:51 AM Changeset in webkit [93423] by
-
- 2 edits in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Cleaning up test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 10:47 AM Changeset in webkit [93422] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Add correct baseline for merge-end-list.html on OSX 10.5.
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Added.
- 9:29 AM Changeset in webkit [93421] by
-
- 2 edits in trunk/Source/WebCore
Better build fix after r93384.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use WTF::Unicode wrapper instead of ICU.
- 9:22 AM Changeset in webkit [93420] by
-
- 2 edits in trunk/Source/WebKit2
WebProcess crashes during startup if libdispatch is initialized by WebProcessShim.dylib
https://bugs.webkit.org/show_bug.cgi?id=66508
<rdar://problem/9828476>
Reviewed by Mark Rowe.
- mac/MainMac.cpp:
(closeUnusedFileDescriptors):
Check if a file descriptor is a kqueue and don't close it if that is the case. While this
isn't a complete fix, (it won't work if other initializers end up creating non-kqueue file descriptors)
it's good enough for Snow Leopard. For Lion, we should use the new posix_spawn API that lets you whitelist
file descriptors from the parent process.
- 9:17 AM Changeset in webkit [93419] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: update scope variables upon value changes via console.
https://bugs.webkit.org/show_bug.cgi?id=54720
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- 9:16 AM Changeset in webkit [93418] by
-
- 2 edits in trunk/Tools
Add project file changes I left out in r93417
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 9:14 AM Changeset in webkit [93417] by
-
- 1 edit5 adds in trunk/Tools
Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
NSScreen
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
(-[SimpleObject setValue:]): Original implementation.
(TestWebKitAPI::setValue2):
(TestWebKitAPI::setValue3):
Swizzled implementations.
(TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
instance method.
- TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
- TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
(TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
(TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
- 9:06 AM Changeset in webkit [93416] by
-
- 2 edits in trunk/Tools
Fix _path_to_apache() error reporting
https://bugs.webkit.org/show_bug.cgi?id=66486
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-19
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 8:50 AM Changeset in webkit [93415] by
-
- 8 edits3 adds in trunk
Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/breakpoint-manager.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Added.
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt: Added.
- inspector/debugger/breakpoint-manager.html: Added.
- 8:39 AM Changeset in webkit [93414] by
-
- 2 edits in trunk/Tools
Windows build fix after r93404
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
- 8:37 AM Changeset in webkit [93413] by
-
- 2 edits in trunk/Tools
Add leandrogracia to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66552
Also fix line endings in file.
No reviewed required.
- Scripts/webkitpy/common/config/committers.py:
- 8:29 AM Changeset in webkit [93412] by
-
- 2 edits in trunk/Tools
Fix compilation issue in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66554
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-19
Reviewed by Martin Robinson.
- WebKitTestRunner/PixelDumpSupport.cpp:
- 8:27 AM Changeset in webkit [93411] by
-
- 2 edits in trunk/Source/WebCore
Fix typo
- dom/DOMAllInOne.cpp:
- 8:25 AM Changeset in webkit [93410] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
https://bugs.webkit.org/show_bug.cgi?id=65408
Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_frame.cpp:
(_ewk_frame_smart_add):
- 8:19 AM Changeset in webkit [93409] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028
As backing store's position and offset change can occur at the same time,
the checking of offset change shouldn't be "else if" statement.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_smart_calculate):
- 8:11 AM Changeset in webkit [93408] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r93385
- dom/DOMAllInOne.cpp: Added EventDispatcMediator.cpp.
- 7:56 AM Changeset in webkit [93407] by
-
- 24 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Add a basic engine to control the content of the viewport
https://bugs.webkit.org/show_bug.cgi?id=66383
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-19
Reviewed by Andreas Kling.
Add ViewportInteractionEngine to handle the content of the viewport. The class make
sure the QTouchWebPage stays in the viewport and in the boundaries.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::loadDidCommit):
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage): Set the transform origin to the top left so
we can asume the position 0, 0 is always the top left of the page.
(QTouchWebPagePrivate::_q_commitScaleChange): Make commitScaleChange a slot
in order to completely decouple the ViewportInteractionEngine and the WebKit classes.
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebpage_p.h:
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportRectUpdated): Make _q_viewportRectUpdated() a slot
for reducing coupling.
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebViewPrivate::setViewportArguments):
(QTouchWebView::geometryChanged):
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qtouchwebview_p.h:
- UIProcess/qt/ClientImpl.cpp:
(qt_wk_didCommitLoadForFrame):
- UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
- UIProcess/qt/QtGestureRecognizer.h: Change the gesture recognizer to talk directly
to the ViewportInteractionEngine instead of interacting through TouchViewInterface.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
- UIProcess/qt/QtPanGestureRecognizer.h:
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):
- UIProcess/qt/QtPinchGestureRecognizer.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadDidCommit): Add the loadCommited callback in order
to reset the viewport state when the page change.
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::loadDidCommit):
- UIProcess/qt/TouchViewInterface.h:
- UIProcess/qt/ViewInterface.h:
- UIProcess/qt/ViewportInteractionEngine.cpp: Added.
(WebKit::visibleRectInContentCoordinate):
(WebKit::contentRectInViewportCoordinate):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::reset):
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::panGestureStarted):
(WebKit::ViewportInteractionEngine::panGestureRequestScroll):
(WebKit::ViewportInteractionEngine::panGestureCancelled):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentGeometryChanged):
(WebKit::ViewportInteractionEngine::contentScaleChanged):
(WebKit::ViewportInteractionEngine::updateContentIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentScaleIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentPositionIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionToBoundaries):
(WebKit::ViewportInteractionEngine::animateContentScaleToBoundaries):
(WebKit::ViewportInteractionEngine::scaleContent):
- UIProcess/qt/ViewportInteractionEngine.h: Added.
(WebKit::ViewportInteractionEngine::Constraints::Constraints):
(WebKit::operator==):
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
- UIProcess/qt/qtouchwebpageproxy.h:
- WebKit2.pro:
- 7:55 AM Changeset in webkit [93406] by
-
- 2 edits in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:51 AM Changeset in webkit [93405] by
-
- 3 edits1 copy1 add in trunk/Tools
Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
This will make it easier to write other WebKit-agnostic tests
Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
code in other WebKit-agnostic tests
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
(TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
WebKitAgnosticTest handles for us.
(TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
- TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
(TestWebKitAPI::WebKitAgnosticTest::loadSynchronously): Code came from
DynamicDeviceScaleFactor::runTest.
- TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
DynamicDeviceScaleFactor.WebKit.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
DynamicDeviceScaleFactor.WebKit2.
- 7:50 AM Changeset in webkit [93404] by
-
- 46 edits in trunk/Tools
Clean up #includes in TestWebKitAPI
Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
files and WebKit/WebKit.h for ObjC files.
- TestWebKitAPI/InjectedBundleController.cpp:
- TestWebKitAPI/JavaScriptTest.h:
- TestWebKitAPI/PlatformUtilities.h:
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/Test.h:
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
- TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
- TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
- TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
- TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/Find.cpp:
- TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
- TestWebKitAPI/Tests/WebKit2/WKString.cpp:
- TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
- TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
- TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
- TestWebKitAPI/TestsController.cpp:
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
- 7:47 AM Changeset in webkit [93403] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating baselines.
Unreviewed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/paste-text-008-expected.png: Added.
- 7:46 AM Changeset in webkit [93402] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
https://bugs.webkit.org/show_bug.cgi?id=66549
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-19
Reviewed by Benjamin Poulain.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::paint):
- UIProcess/qt/QtWebPageProxy.h:
- 7:12 AM Changeset in webkit [93401] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-19
Reviewed by Kent Tamura.
Adds doxygen documentation to the structures in ewk_view.cpp.
- ewk/ewk_view.cpp:
- 6:41 AM Changeset in webkit [93400] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Extensions API][chromium] webInspector.resources deprecation warning is given even for extensions that don't use webInspector.resources
https://bugs.webkit.org/show_bug.cgi?id=66553
Reviewed by Pavel Feldman.
- src/js/DevTools.js:
(WebInspector.platformExtensionAPI):
- 6:23 AM Changeset in webkit [93399] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Modify type of both col and row parameters for backing store's internal api.
https://bugs.webkit.org/show_bug.cgi?id=65302
As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill
and ewk_tiled_backing_store_item_add are different from each other, I modify type of them.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
- 5:50 AM Changeset in webkit [93398] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: getAttributes should work on a single node, not array.
https://bugs.webkit.org/show_bug.cgi?id=66544
Reviewed by Adam Roben.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getAttributes):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
- 5:26 AM Changeset in webkit [93397] by
-
- 4 edits in trunk
[v8] CSS wrapper objects retention
https://bugs.webkit.org/show_bug.cgi?id=66377
Reviewed by Pavel Feldman.
Disable object grouping for CSS object wrappers.
This logic leads to hard to debug use-after-free problems.
Source/WebCore:
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 5:23 AM Changeset in webkit [93396] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: introduce NodeId inherited from integer in the DOM domain description.
https://bugs.webkit.org/show_bug.cgi?id=66491
Drive-by rename of couple of DOM domain protocol methods.
Reviewed by Adam Roben.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::requestNode):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
- inspector/generate-inspector-idl:
- 5:13 AM Changeset in webkit [93395] by
-
- 2 edits in trunk/Source/WebCore
IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity.
https://bugs.webkit.org/show_bug.cgi?id=66470
Reviewed by Tony Gentilcore.
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::deleteObjectStore):
- 4:37 AM Changeset in webkit [93394] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369
https://bugs.webkit.org/show_bug.cgi?id=66514
Skip it.
- platform/qt/Skipped:
- 3:16 AM Changeset in webkit [93393] by
-
- 13 edits6 adds in trunk
[WebSocket] CloseEvent's code and reason properties support.
https://bugs.webkit.org/show_bug.cgi?id=66362
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-19
Reviewed by Kent Tamura.
Current WebSocket implementation miss code and reason properties
in CloseEvent. This change expose incoming closing frame's code
and reason to JavaScript API.
Source/WebCore:
Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html
http/tests/websocket/tests/hybi/workers/close-code-and-reason.html
- websockets/CloseEvent.h:
(WebCore::CloseEvent::initCloseEvent):
(WebCore::CloseEvent::code):
(WebCore::CloseEvent::reason):
(WebCore::CloseEvent::CloseEvent):
- websockets/CloseEvent.idl:
Add code and reason properies.
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
Add implement to handle code and reason.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::processFrame):
- websockets/WebSocketChannel.h:
Add closing frame payload parser.
- websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
Add implement to handle code and reason.
LayoutTests:
- http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt: Added.
- http/tests/websocket/tests/hybi/close-code-and-reason.html: Added.
- http/tests/websocket/tests/hybi/close-code-and-reason_wsh.py: Added.
- http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt: Added.
- http/tests/websocket/tests/hybi/workers/close-code-and-reason.html: Added.
- http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Added.
(postResult):
(ws.onopen):
(ws.onmessage):
(ws.onclose):
- 2:43 AM Changeset in webkit [93392] by
-
- 19 edits2 adds in trunk
.: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Add export for window.internals object.
- Source/autotools/symbols.filter:
Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
But these are low-level API and caller should take care of word boundary.
This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
which handles word boundary correctly.
Test: editing/spelling/spelling-insert-html.html
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAndBadGrammar):
- testing/Internals.cpp:
(WebCore::Internals::markerCountOf): Added.
(WebCore::Internals::markedRangeAt): Added.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Add exports for window.internals object.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Existing expectation was wrong because of some markers on substrings of words.
With this fix, Editor now rejects such markers.
- editing/spelling/spelling-insert-html-expected.txt: Added.
- editing/spelling/spelling-insert-html.html: Added.
- platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
- platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
- platform/mac/editing/pasteboard/merge-after-delete-expected.png:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/mac/editing/pasteboard/merge-end-list-expected.png:
- platform/mac/editing/pasteboard/merge-end-table-expected.png:
- platform/mac/editing/pasteboard/paste-text-008-expected.png:
- 1:58 AM Changeset in webkit [93391] by
-
- 2 edits in trunk/Source/WebCore
Run-time error fix in WebKit-GTK with video support disabled.
https://bugs.webkit.org/show_bug.cgi?id=66541
Definition of the function extraFullScreenStyleSheet() in webkit-gtk
lies outside ENABLE(VIDEO) guard, resulting in runtime error while
trying to launch GtkLauncher with video support disabled.
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-19
Reviewed by Philippe Normand.
Run-time error fix. No test cases were added.
- platform/gtk/RenderThemeGtk.h:
- 1:46 AM Changeset in webkit [93390] by
-
- 7 edits in trunk
input[maxlength=0] should ignore text input.
https://bugs.webkit.org/show_bug.cgi?id=65497
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-19
Reviewed by Kent Tamura.
Source/WebCore:
Changed the valid range of maxlength.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
Changed maxlength check condition.
LayoutTests:
- fast/forms/input-text-paste-maxlength-expected.txt: Added a case that maxlength=0
- fast/forms/input-text-paste-maxlength.html: ditto.
- fast/forms/script-tests/textarea-maxlength.js: ditto.
(createFocusedTextAreaWithMaxLength):
- fast/forms/textarea-maxlength-expected.txt: ditto.
- 1:42 AM Changeset in webkit [93389] by
-
- 5 edits in trunk
Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
https://bugs.webkit.org/show_bug.cgi?id=66482
There are functions in the API with multiple optional arguments.
When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
This can be solved with passing the arguments as an object.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/CodeGeneratorInspector.pm:
- inspector/front-end/RemoteObject.js:
LayoutTests:
- inspector/debugger/debugger-set-breakpoint-regex.html:
- 12:54 AM Changeset in webkit [93388] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix after r93384.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Aug 18, 2011:
- 10:44 PM Changeset in webkit [93387] by
-
- 5 edits3 adds in trunk
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114
Source/WebCore:
Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).
Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the world space transform.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Test: compositing/backface-visibility-hierarchical-transform.html
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):
LayoutTests:
This case tests if backface visibility properly accounts for a hierarchy
of transforms. In particular, this test forces Chromium to create a
hierarchy of RenderSurfaces.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.
- compositing/backface-visibility-hierarchical-transform-expected.png: Added.
- compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
- compositing/backface-visibility-hierarchical-transform.html: Added.
- 9:51 PM Changeset in webkit [93386] by
-
- 6 edits2 adds in trunk
[skia] -webkit-transform breaks -webkit-mask
https://bugs.webkit.org/show_bug.cgi?id=66442
Source/WebCore:
The problem here is that in RenderBox::paintMaskImages, if we are in
a transform with a rotation, scale or skew we set the composite mode to
be DestinationIn and then create a transparency layer, then paint the
mask with SourceOver and end the transparency layer. (The normal case
is just to use DestinationIn to paint the mask.)
In skia when we create transparency layers we don't pass on the composite
mode, so when we end the transparency layer it is composited back using
SourceOver. The fix is to pass on the composite mode when creating
transparency layers in skia.
Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::getXfermodeMode):
- platform/graphics/skia/PlatformContextSkia.h:
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- platform/chromium-linux/fast/css/transformed-mask-expected.png: Added.
- platform/chromium-linux/fast/css/transformed-mask-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:46 PM Changeset in webkit [93385] by
-
- 16 edits2 adds in trunk/Source/WebCore
Isolate EventDispatchMediator into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66458
Reviewed by Ryosuke Niwa.
Extracted EventDispatchMediator.h and EventDispatchMediator.cpp
out of Event.h and Event.cpp Also moved FocusEventDispatchMediator
and BlurEventDispatchMediator from Event.{h|cpp} to
EventDispatchMediator.{h|cpp}.
No new tests since this is just refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Event.cpp:
- dom/Event.h:
- dom/EventDispatchMediator.cpp: Added.
(WebCore::EventDispatchMediator::create):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::dispatchEvent):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
- dom/EventDispatchMediator.h: Added.
(WebCore::EventDispatchMediator::~EventDispatchMediator):
(WebCore::EventDispatchMediator::event):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::setEvent):
- dom/EventDispatcher.cpp:
- dom/KeyboardEvent.h:
- dom/MouseEvent.h:
- dom/Node.cpp:
- dom/ScopedEventQueue.cpp:
- dom/UIEvent.h:
- dom/WheelEvent.h:
- 8:34 PM Changeset in webkit [93384] by
-
- 2 edits in trunk/Source/WebCore
Mid-word break can occur between a character and a combining mark
https://bugs.webkit.org/show_bug.cgi?id=66529
Reviewed by Simon Fraser.
No test added because I could not find a combining mark with a non-zero advance in
any of the system fonts and tests fonts.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a
combining mark.
- 6:58 PM Changeset in webkit [93383] by
-
- 2 edits in trunk/Tools
new-run-webkit-tests hung while acquiring http lock on snow leopard bots
https://bugs.webkit.org/show_bug.cgi?id=64886
Temporarily disable the http locking to work around the issue.
I'm not actually sure if this is going to work or improve things
much.
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 6:33 PM Changeset in webkit [93382] by
-
- 3 edits2 adds in trunk
REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
LayoutTests:
- fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
- fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
- 6:17 PM Changeset in webkit [93381] by
-
- 6 edits in trunk/Source/WebKit/chromium
Chromium plumbing for webkitRequestFullScreen
https://bugs.webkit.org/show_bug.cgi?id=66031
Reviewed by Darin Fisher.
- public/WebView.h:
- public/WebViewClient.h:
(WebKit::WebViewClient::enterFullscreenForElement):
(WebKit::WebViewClient::exitFullscreenForElement):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::enterFullScreenForElement):
(WebKit::ChromeClientImpl::exitFullScreenForElement):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::exitFullscreen):
- src/WebViewImpl.h:
- 6:09 PM Changeset in webkit [93380] by
-
- 5 edits in trunk/Source/WebCore
New XML parser: scripting support
https://bugs.webkit.org/show_bug.cgi?id=66406
Reviewed by Adam Barth.
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::resumeParsing):
(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::notifyFinished):
- xml/parser/NewXMLDocumentParser.h:
(WebCore::NewXMLDocumentParser::pauseParsing):
- xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags
(WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
- xml/parser/XMLTreeBuilder.h:
- 6:04 PM Changeset in webkit [93379] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Broken rendering occured when resized in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=66271
Force rendering when ewk_view resized.
It's because Evas_Object doesn't generate any rendering request although
it was changed.
Reviewed by Tony Chang.
- ewk/ewk_view.cpp:
(_ewk_view_smart_calculate):
- 5:58 PM Changeset in webkit [93378] by
-
- 35 edits in trunk/Source
Move allocation in constructors into separate constructorBody() methods
https://bugs.webkit.org/show_bug.cgi?id=66265
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-18
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
- runtime/ErrorInstance.h:
(JSC::ErrorInstance::constructorBody):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::constructorBody):
- runtime/ErrorPrototype.h:
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::FunctionExecutable::constructorBody):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/InternalFunction.h:
(JSC::InternalFunction::constructorBody):
- runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
- runtime/JSByteArray.h:
(JSC::JSByteArray::constructorBody):
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::constructorBody):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::constructorBody):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
- runtime/NativeErrorPrototype.h:
- runtime/StringObject.cpp:
- runtime/StringObject.h:
(JSC::StringObject::create):
- runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
- runtime/StringPrototype.h:
(JSC::StringPrototype::create):
Source/WebCore:
No new tests.
Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.mm:
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
- bridge/runtime_array.cpp:
- bridge/runtime_array.h:
(JSC::RuntimeArray::create):
- 5:44 PM Changeset in webkit [93377] by
-
- 18 edits1 add in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
Reviewed by Sam Weinig.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/NSScrollerImpDetails.h: Added.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:23 PM Changeset in webkit [93376] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline
https://bugs.webkit.org/show_bug.cgi?id=66515
Reviewed by Darin Adler.
No test because none of the system fonts and test fonts have an incorrectly-specified descender value.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant
the same amount, but negative. This is consistent with what Core Text does.
- 5:18 PM Changeset in webkit [93375] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025
Reviewed by Gavin Barraclough.
This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
stanford-crypto-sha256-iterative). It looks like it might have
a speed-up in SunSpider (though not statistically significant or
particularly reproducible) and a slight slow-down in V8 (0.14%,
not statistically significant). It does slow down v8-crypto by
1.5%.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
- dfg/DFGOperations.cpp:
- 5:00 PM Changeset in webkit [93374] by
-
- 3 edits in trunk/LayoutTests
[chromium] Fix results. Just copy over the platform independent results.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png:
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.png:
- 4:55 PM Changeset in webkit [93373] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:52 PM Changeset in webkit [93372] by
-
- 1 copy in tags/Safari-534.51.17
New tag.
- 4:29 PM Changeset in webkit [93371] by
-
- 1 edit22 adds in trunk/LayoutTests
Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac
https://bugs.webkit.org/show_bug.cgi?id=66493
The expected results of the layout tests written for
https://bugs.webkit.org/show_bug.cgi?id=57785
differ between WebKitt Mac and WebKit2 Mac.
WebKit2 Mac matches the cross-platform results.
WebKit1 Mac has a special set of test results.
Reviewed by Tony Chang.
- platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.
- 4:28 PM Changeset in webkit [93370] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Mark editing/selection/regional-indicators.html as timing
out on Linux debug and rebaseline 2 tests.
- platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:07 PM Changeset in webkit [93369] by
-
- 4 edits2 adds in trunk
positionForPoint returns wrong VisiblePosition at bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=65356
Reviewed by David Hyatt.
Source/WebCore:
The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.
For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
until the end to obtain the offset 7 from the inline box for "DC".
Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
on the left or the right of the position to compute the appropriate offset following the NSTextView convention.
This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
LTR or RTL text in a RTL or LTR block respectively.
Test: editing/selection/caret-at-bidi-boundary.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
- rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
(WebCore::createVisiblePositionForBox):
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):
LayoutTests:
- editing/selection/caret-at-bidi-boundary-expected.txt: Added.
- editing/selection/caret-at-bidi-boundary.html: Added.
- 4:05 PM Changeset in webkit [93368] by
-
- 2 edits in trunk/Source/WebCore
--webkit-visual-word renaming right/leftWordPositionAcrossBoundary
https://bugs.webkit.org/show_bug.cgi?id=66436
Reviewed by Ryosuke Niwa.
Rename them to right/leftWordPositionIgnoringEditingBoundary.
- editing/visible_units.cpp:
(WebCore::leftWordPositionIgnoringEditingBoundary):
(WebCore::rightWordPositionIgnoringEditingBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
- 4:05 PM Changeset in webkit [93367] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium
https://bugs.webkit.org/show_bug.cgi?id=66441
Reviewed by Darin Fisher.
- public/WebAudioSourceProvider.h: Added.
(WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):
- public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::audioSourceProvider):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
- src/WebMediaPlayerClientImpl.h:
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):
- 4:02 PM Changeset in webkit [93366] by
-
- 1 edit in branches/safari-534.51-branch/Source/JavaScriptCore/ChangeLog
Merge r92804.
- 4:01 PM Changeset in webkit [93365] by
-
- 1 edit in branches/safari-534.51-branch/Source/WebKit2/ChangeLog
Merge r92729.
- 4:00 PM Changeset in webkit [93364] by
-
- 4 edits in branches/safari-534.51-branch/Source
Merge r91998.
- 3:57 PM Changeset in webkit [93363] by
-
- 5 edits2 adds in trunk/Source/WebCore
Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725
Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with declspec(dllimport),
and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
until a media element is used.
Reviewed by Eric Carlson.
No new tests as no change in functionality.
- WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
- platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
- platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
- 3:49 PM Changeset in webkit [93362] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r92729. Needed for <rdar://problem/9966800>
- 3:46 PM Changeset in webkit [93361] by
-
- 5 edits in trunk/Source
Chromium Mac: Show scrollbar when doing search
https://bugs.webkit.org/show_bug.cgi?id=66209
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Source/WebCore:
Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.
No tests because there are no Mac 10.7 chromium bots yet.
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Source/WebKit/chromium:
Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.
No tests because there are no Mac 10.7 chromium bots yet.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::invalidateArea):
- 3:42 PM Changeset in webkit [93360] by
-
- 33 edits2 adds in trunk
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834
Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Kenneth Russell.
Source/WebCore:
Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
draw-time transform.
*) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel
AA trashing the alpha channel. The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.
Covered by compositing/
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
- platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.
- compositing/checkerboard-expected.png:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 3:23 PM Changeset in webkit [93359] by
-
- 8 edits3 deletes in trunk
Unreviewed, rolling out r93354.
http://trac.webkit.org/changeset/93354
https://bugs.webkit.org/show_bug.cgi?id=66503
"consensus was not reached" (Requested by senorblanco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
Source/WebCore:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
LayoutTests:
- fast/canvas/drawImage-clipped-source-expected.txt: Removed.
- fast/canvas/drawImage-clipped-source.html: Removed.
- fast/canvas/drawImage-clipped-source.js: Removed.
- fast/canvas/drawImage-with-invalid-args-expected.txt:
- fast/canvas/drawImage-with-invalid-args.html:
- platform/chromium/test_expectations.txt:
- platform/mac/Skipped:
- 3:19 PM Changeset in webkit [93358] by
-
- 6 edits in trunk/Source
GestureRecognizer: Update how gesture-scroll works.
Source/WebCore:
Instead of just sending a series of 'GestureUpdate' events, send a
single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
and end with a 'GestureEnd' event.
https://bugs.webkit.org/show_bug.cgi?id=66267
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
(WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
(WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
(WebCore::scrollEnd):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
- platform/chromium/GestureRecognizerChromium.h:
(WebCore::InnerGestureRecognizer::firstTouchPosition):
Source/WebKit/chromium:
Add a unit-test to make sure the correct gesture events are being
generated.
https://bugs.webkit.org/show_bug.cgi?id=66267
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.
- tests/InnerGestureRecognizerTest.cpp:
(WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(WebCore::TEST_F):
- 3:16 PM Changeset in webkit [93357] by
-
- 2 edits in trunk/LayoutTests
Fix r93349.
- platform/gtk/Skipped:
- 3:14 PM Changeset in webkit [93356] by
-
- 6 edits1 delete in trunk
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Source/WebCore:
Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
- platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):
LayoutTests:
Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.
- platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.
- 3:08 PM Changeset in webkit [93355] by
-
- 7 edits2 copies2 adds in trunk/Tools
add embedded png checksums to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66494
Looks like WebKitTestRunner has never supported embedded checksums. This copies
some code from DRT and adds it to the WebKitTestRunner.
Reviewed by Darin Adler.
- WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
- WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
- WebKitTestRunner/GNUmakefile.am: Add new files
- WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
- WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
- WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
- 3:03 PM Changeset in webkit [93354] by
-
- 8 edits3 adds in trunk
Source/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.
Test: fast/canvas/drawImage-clipped-source.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
Removed the unnecessary dom exceptions for out of bounds source rectangles
The overloads that receive video and image elements as source images
now use the normalized versions of the source rectangle, which
GraphicsContext (and its various platform flavors) can handle correctly.
The normalized rectangle is the equivalent rectangle with width and height
greater than 0. The canvas version of this method, which had better layout
test coverage, was already correctly using the normalized rectangle. The
newly added layout test verifies correct behavior with negative
source rectangle dimensions.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
Fixed algorithm that adjusts the destination rectangle to match the clipping
applied to the source rect. The case of scaled filtered images with source
rectangles that overlap the edge of the image was not being handled
correctly. This use case was previously unsupported and used to trigger
a DOM exception.
LayoutTests: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- fast/canvas/drawImage-clipped-source-expected.txt: Added.
- fast/canvas/drawImage-clipped-source.html: Added.
New test that verifies the clipping behavior when source rectangles
are partially out of the bounds of the source image
- fast/canvas/drawImage-clipped-source.js: Added.
(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testPattern):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):
- fast/canvas/drawImage-with-invalid-args-expected.txt:
- fast/canvas/drawImage-with-invalid-args.html:
This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions
- platform/chromium/test_expectations.txt:
Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail
- platform/mac/Skipped:
Skipping canvas/philip/tests/2d.drawImage.outsidesource.html
- 2:55 PM Changeset in webkit [93353] by
-
- 1 edit1 add in trunk/LayoutTests
[Gtk] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66501
- platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.
- 2:53 PM Changeset in webkit [93352] by
-
- 1 move in trunk/LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt
Use a correct name for expected results.
- platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
- platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.
- 2:50 PM Changeset in webkit [93351] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66500
- platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.
- 2:00 PM Changeset in webkit [93350] by
-
- 38 edits2 deletes in trunk
Unreviewed, rolling out r93329.
http://trac.webkit.org/changeset/93329
https://bugs.webkit.org/show_bug.cgi?id=66497
Turned text on chromium win blue (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::dumpLayerProperties):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
- platform/graphics/chromium/NonCompositedContentHost.h: Removed.
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::dumpSurface):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::tilingTransform):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 1:52 PM Changeset in webkit [93349] by
-
- 2 edits in trunk/LayoutTests
Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
which is tracked by the bug 66496.
- platform/gtk/Skipped:
- 1:43 PM Changeset in webkit [93348] by
-
- 1 edit1 copy in trunk/LayoutTests
GTK rebaseline after r93221.
- platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:
Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
- 1:41 PM Changeset in webkit [93347] by
-
- 6 edits2 adds in trunk
SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
https://bugs.webkit.org/show_bug.cgi?id=66086
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
Fixing the bug by detecting RenderTextFragment in handleTextNode.
Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
the next call to handleTextNode needs to process the first-letter part of the text fragment.
Test: editing/text-iterator/backward-textiterator-first-letter-crash.html
- editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
(WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
- editing/TextIterator.h:
LayoutTests:
Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
from 0 to 1 because there is unrendered space before "hello".
- editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
- editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
- editing/text-iterator/first-letter-word-boundary-expected.txt:
- editing/text-iterator/first-letter-word-boundary.html:
- 1:37 PM Changeset in webkit [93346] by
-
- 8 edits in trunk/Source/WebCore
[chromium] Assert that main thread and compositor thread are used safely
https://bugs.webkit.org/show_bug.cgi?id=66145
CCLayerTreeHostImplProxy now has public static methods isMainThread()
and isImplThread(), and we ASSERT these in various places. If threaded
compositing is disabled, we fake isImplThread() by setting a flag for
the duration of compositing, so the assert is still valid.
Patch by Iain Merrick <husky@google.com> on 2011-08-18
Reviewed by James Robinson.
Covered by existing tests.
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::doComposite):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::isMainThread):
(WebCore::CCLayerTreeHostImplProxy::isImplThread):
(WebCore::CCLayerTreeHostImplProxy::setImplThread):
(WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
- 1:36 PM Changeset in webkit [93345] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=47240
Fixed a cygwin path problem in the chromium port of diff_image;
Also made the return values of the diff_image function more consistent.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 1:32 PM Changeset in webkit [93344] by
-
- 3 edits2 adds in trunk
Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395
Reviewed by Dan Bernstein.
Source/WebCore:
Part two: make cursor movement iterator work. This fixes the problem for strings that don't
contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.
Test: editing/selection/regional-indicators.html
- platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom
rules for regional indicator symbols.
LayoutTests:
- editing/selection/regional-indicators-expected.txt: Added.
- editing/selection/regional-indicators.html: Added.
- 1:22 PM Changeset in webkit [93343] by
-
- 2 edits in trunk/Source/WebCore
Fix rubber band gutter drawing for Skia on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=66478
Reviewed by James Robinson.
No new tests. The Skia on Chromium Mac platform has
not been enabled.
This break was detected at compile time; there is no
behavior change.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Convert the CGImage into an SkBitmap if Skia is present.
- 1:22 PM Changeset in webkit [93342] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add a bunch of accessors to WebAccessibilityObject to expose more of
AccessibilityObject to Chromium, including range control values,
document load state, live region attributes, and a few other
ARIA attributes.
https://bugs.webkit.org/show_bug.cgi?id=66411
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
Reviewed by Dimitri Glazkov.
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):
- 1:20 PM Changeset in webkit [93341] by
-
- 3 edits in trunk/Source/WebCore
Implement a faster path for painting tables with overflowing cells
https://bugs.webkit.org/show_bug.cgi?id=65491
This change introduces a smarter way of painting if the table is big enough and we have a small amount
of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
the overflowing cells to the repainting cells.
This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
memory.
Reviewed by David Hyatt.
No new tests as the behavior should be the same.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
care about the cell's information. Make sure that the "has overflowing cells" information is still
properly encoded on our 2 values.
(WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
complicated sort:
- the old path would sort one (mostly sorted) array by rows only as the stable sort would take care of keeping the column ordering inside a row.
- the new path basically has to sort an unsorted array (taken partly from the HashSet).
(WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
repaint the same cell twice.
(WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
fast path optimization here.
- rendering/RenderTableSection.h: Transformed our original boolean into
a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
until we reach the memory threshold. After this is hit, we just set the boolean
to avoid using too much memory.
(WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
if we have any overflowing cell, used only for hit testing.
- 1:11 PM Changeset in webkit [93340] by
-
- 5 edits in trunk
An EventSource constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66454
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/eventsource/eventsource-constructor.html
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8EventSourceConstructor.cpp:
(WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.
- 1:09 PM Changeset in webkit [93339] by
-
- 5 edits in trunk
A SharedWorker constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66455
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/workers/shared-worker-constructor.html
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.
- 1:08 PM Changeset in webkit [93338] by
-
- 9 edits in trunk
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- platform/gtk/GtkAuthenticationDialog.cpp: (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added gtk_box_new conditional compilation for gtk+-3.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have GTK_TYPE_SCALE in gtk+3.
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main): G_CONST_RETURN was deprecated
- GtkLauncher/main.c: (createWindow): Added gtk_box_new conditional compilation for gtk+-3.
- MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we are just supporting gtk+-3 for WebKit2.
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Added gtk_box_new conditional compilation for gtk+-3.
- 1:01 PM Changeset in webkit [93337] by
-
- 4 edits in trunk/Source/WebKit2
Made some code even more private to a particular file and class
https://bugs.webkit.org/show_bug.cgi?id=66428
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]): Made this file internal.
- UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
- UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.
- 12:43 PM Changeset in webkit [93336] by
-
- 5 edits in trunk
A Worker constructor should throw TypeError, when the number of arguments is not enough
https://bugs.webkit.org/show_bug.cgi?id=66456
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/workers/worker-constructor.html
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.
- 12:32 PM Changeset in webkit [93335] by
-
- 2 edits in trunk/Source/WebCore
Fix logic error causing reverse of desired WebGL rate limiting behavior
https://bugs.webkit.org/show_bug.cgi?id=66445
Patch by John Bates <jbates@google.com> on 2011-08-18
Reviewed by Kenneth Russell.
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):
- 12:28 PM Changeset in webkit [93334] by
-
- 8 edits in trunk/Source/WebCore
Switch RenderTextControl* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66250
Reviewed by Eric Seidel.
Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.
No new tests as no change in behavior.
- rendering/LayoutTypes.h:
(WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentWidth):
(WebCore::RenderTextControlMultiLine::baselinePosition):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
- rendering/RenderTextControlSingleLine.h:
- 12:23 PM Changeset in webkit [93333] by
-
- 7 edits in trunk/Source/WebCore
Switch Inline rendering classes to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66239
Reviewed by Eric Seidel.
Converting inline rendering classes to use the LayoutUnit abstraction from ints.
No new tests as no change in functionality.
- rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::computeMargin):
(WebCore::RenderInline::culledInlineBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
(WebCore::RenderInline::addDashboardRegions):
- rendering/RenderInline.h:
- 12:19 PM Changeset in webkit [93332] by
-
- 2 edits in trunk/Source/WebCore
New XML parser: add doctype to DOM tree
https://bugs.webkit.org/show_bug.cgi?id=66408
Reviewed by Adam Barth.
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):
- 12:17 PM Changeset in webkit [93331] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test to ensure WebKit does not paste contents before
https://bugs.webkit.org/show_bug.cgi?id=66481
Reviewed by Alexey Proskuryakov.
Add a regression test since this bug has been fixed by r92695.
- editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
- editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.
- 12:10 PM Changeset in webkit [93330] by
-
- 12 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=61016
[WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
This adds an implementation of in-process dedicated workers to chromium port.
The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:
- In-process dedicated workers (this checkin)
- Inter-process shared workers
- Inter-process dedicated workers (defunct after this checkin)
This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
three implementations.
Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
(it will require coordinated changes on chromuium side).
Reviewed by David Levin.
- public/WebCommonWorkerClient.h:
- src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
- src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
- src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::newCommonClient):
- src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
(WebKit::WebWorkerClientImpl::hasPendingActivity):
(WebKit::WebWorkerClientImpl::workerObjectDestroyed):
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::sendMessageToInspector):
(WebKit::WebWorkerClientImpl::postMessageToPageInspector):
(WebKit::WebWorkerClientImpl::postTaskToLoader):
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
(WebKit::WebWorkerClientImpl::reportPendingActivity):
(WebKit::WebWorkerClientImpl::workerContextClosed):
(WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
(WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):
- src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
- src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::newCommonClient):
- src/WebWorkerImpl.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
- src/WorkerFileSystemCallbacksBridge.h:
- 12:06 PM Changeset in webkit [93329] by
-
- 38 edits2 adds in trunk
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834
Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Darin Fisher.
Source/WebCore:
Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
draw-time transform.
*) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha
channel. The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.
Covered by compositing/
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
- platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.
- compositing/checkerboard-expected.png:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 11:51 AM Changeset in webkit [93328] by
-
- 2 edits in trunk/Source/WebCore
Fix "missing return" gcc warning in ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=66480
Reviewed by Tony Chang.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
- 11:49 AM Changeset in webkit [93327] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Activating sub menus cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=66471
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
Reviewed by Anders Carlsson.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::createGtkMenu):
- 11:41 AM Changeset in webkit [93326] by
-
- 3 edits2 adds in trunk
Revalidate expired resources if they're requested after the initial document load
https://bugs.webkit.org/show_bug.cgi?id=52153
Reviewed by Antti Koivisto.
Source/WebCore:
Test: http/tests/cache/subresource-multiple-instances.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
LayoutTests:
- http/tests/cache/subresource-multiple-instances-expected.txt: Added.
- http/tests/cache/subresource-multiple-instances.html: Added.
- 11:29 AM Changeset in webkit [93325] by
-
- 2 edits in trunk/LayoutTests
[chromium] Marking tests needing win/linux baselines as such in
test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [93324] by
-
- 2 edits1 add12 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html
https://bugs.webkit.org/show_bug.cgi?id=66420
Reviewed by Kent Tamura.
Converted the test.
- editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
- editing/pasteboard/block-wrappers-necessary.html:
- platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- 11:21 AM Changeset in webkit [93323] by
-
- 1 edit1 move1 add8 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/5368833.html
https://bugs.webkit.org/show_bug.cgi?id=66416
Reviewed by Kent Tamura.
Converted the test and also renamed the test to a more descriptive name.
- editing/pasteboard/5368833.html: Removed.
- editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
- editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
- platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
- platform/mac/editing/pasteboard/5368833-expected.png: Removed.
- platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
- platform/qt/editing/pasteboard/5368833-expected.txt: Removed.
- 11:09 AM Changeset in webkit [93322] by
-
- 2 edits1 delete in trunk/LayoutTests
Update chromium gpu expected results after r93275.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 10:59 AM Changeset in webkit [93321] by
-
- 4 edits1 add in trunk/LayoutTests
Update baselines for mac and win after test changes/fixes in r93275.
- platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:48 AM Changeset in webkit [93320] by
-
- 6 edits in trunk/LayoutTests
Add checksums to png results. Still trying to find out why they
went missing in the first place.
- fast/frames/frame-set-scaling-3d-expected.png:
- fast/frames/frame-set-scaling-centered-expected.png:
- fast/frames/frame-set-scaling-expected.png:
- fast/frames/frame-set-scaling-rotate-expected.png:
- fast/frames/frame-set-scaling-skew-expected.png:
- 10:21 AM Changeset in webkit [93319] by
-
- 3 edits in trunk/Tools
Fix libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66479
Reviewed by Adam Roben.
Add missing includes.
- DumpRenderTree/LayoutTestController.cpp:
- DumpRenderTree/mac/CheckedMalloc.cpp:
- 10:20 AM Changeset in webkit [93318] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
dump-as-markup conversion: editing/pasteboard/testcase-9507.html
https://bugs.webkit.org/show_bug.cgi?id=66448
Reviewed by Kent Tamura.
Converted the test.
- editing/pasteboard/testcase-9507-expected.txt: Added.
- editing/pasteboard/testcase-9507.html:
- platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.
- 10:16 AM Changeset in webkit [93317] by
-
- 3 edits in trunk/Source/WebKit/mac
More C++0x libc++ build fixes
https://bugs.webkit.org/show_bug.cgi?id=66476
Reviewed by Adam Roben.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCSetException):
Use a WTF String here instead of an STL string.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
std::make_pair now takes rvalue references, so get rid of the template arguments and let
the compiler deduce them instead.
- 9:56 AM Changeset in webkit [93316] by
-
- 3 edits in trunk/Source/WebCore
Fix clang libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66475
Reviewed by Adam Roben.
Remove calls to isnan and isfinite with integer arguments.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::viewport):
- 9:43 AM Changeset in webkit [93315] by
-
- 8 edits3 copies3 adds in trunk
Update the device scale factor when the WebView's window changes
Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
WebView is moved between windows with different backing scale factors
Reviewed by Anders Carlsson.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.
Tools:
Test that WebKit updates style when a WebView is moved between differently-scaled windows
- TestWebKitAPI/JavaScriptTest.cpp:
(TestWebKitAPI::runJSTest): Moved a little bit of code from here...
(TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
gtest's built-in error messages.
- TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
WKView * for convenience on Mac. Added compareJSResult helper function for implementing
those overloads.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
(-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Set up the client.
(TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
SyntheticBackingScaleFactorWindow and returns it.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
window, is moved to a differently-scaled window, and is taken out of the window.
(TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
WebKit1 and WebKit2.
(TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
- TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
- TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
(TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
initializer.
(-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
(-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
- 9:43 AM Changeset in webkit [93314] by
-
- 12 edits in trunk/Source/WebKit2
Make WebPageProxy keep track of the current device scale factor
The device scale factor is no longer considered part of WebPageProxy's "view state". It now
has its own setter/getter. This made the code a little simpler and more similar to the page
scale factor. Each port-specific WebKit2 view is now responsible for calling
WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
changed.
Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
the current device scale factor
Reviewed by Anders Carlsson.
- UIProcess/API/efl/PageClientImpl.cpp:
- UIProcess/API/efl/PageClientImpl.h:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/PageClient.h:
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/win/WebView.h:
Removed deviceScaleFactor.
- UIProcess/API/mac/WKView.mm:
(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
tells the DrawingAreaProxy about it if it's actually changed.
(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
to the PageClient.
- UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
replaces the DeviceScaleFactor ViewStateFlag.
(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.
- 9:39 AM Changeset in webkit [93313] by
-
- 2 edits in trunk/Source/WebKit/chromium
Revert r93294, doesn't compile on Chromium Mac.
- features.gypi:
- 9:36 AM Changeset in webkit [93312] by
-
- 10 edits4 moves1 add1 delete in trunk
2011-08-18 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460
Reviewed by Pavel Feldman.
Tests: http/tests/inspector/extensions-network-redirect.html
inspector/extensions/extensions-network.html
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Network.requestDispatch): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Network.prototype.getHAR): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._inspectedURLChanged): (WebInspector.ExtensionServer.prototype._notifyRequestFinished): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._requestId): (WebInspector.ExtensionServer.prototype._requestById): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype.initExtensions): (WebInspector.ExtensionServer.prototype._onmessage):
2011-08-18 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460
Reviewed by Pavel Feldman.
- http/tests/inspector/extensions-network-redirect-expected.txt: Added.
- http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
- http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js. (extension_getRequestByUrl.onHAR): (extension_getRequestByUrl):
- http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
- http/tests/inspector/extensions-useragent-expected.txt:
- http/tests/inspector/extensions-useragent.html:
- inspector/extensions/extensions-api-expected.txt:
- inspector/extensions/extensions-events-expected.txt:
- inspector/extensions/extensions-events.html:
- inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
- inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.
- 8:51 AM Changeset in webkit [93311] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243
Reviewed by Martin Robinson.
The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.
This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.
- tests/testwebview.c:
(test_webkit_web_view_grab_focus):
- 8:39 AM Changeset in webkit [93310] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Chang Shu <cshu@webkit.org>
[Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
failing on Windows since they were added
https://bugs.webkit.org/show_bug.cgi?id=66461
Reviewed by Adam Roben.
Skip the above tests as window.textInputController is not supported on windows.
- platform/win/Skipped:
- 7:59 AM Changeset in webkit [93309] by
-
- 1 edit2 adds in trunk/LayoutTests
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785
Add missing Qt results for tests added in r93287.
Unreviewed gardening.
- platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
- 7:56 AM Changeset in webkit [93308] by
-
- 4 edits2 adds in trunk
Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/content-providers.html
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
LayoutTests:
- inspector/debugger/content-providers-expected.txt: Added.
- inspector/debugger/content-providers.html: Added.
- 7:36 AM Changeset in webkit [93307] by
-
- 11 edits4 adds in trunk
[CSSRegions] RenderRegion should not reference a parent RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142
Source/WebCore:
Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).
There are two cases:
- A RenderRegion tries to display the flow thread that laid it out. In this case
the region will be ignored and will not participate in the flow threads regions list.
- A RenderRegion tries to display a flow thread that contains another region that
tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-18
Reviewed by David Hyatt.
Tests: fast/regions/flows-dependency-dynamic-remove.html
fast/regions/flows-dependency-same-flow.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):
- rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):
LayoutTests:
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-18
Reviewed by David Hyatt.
- fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- fast/regions/flows-dependency-dynamic-remove.html: Added.
- fast/regions/flows-dependency-same-flow-expected.txt: Added.
- fast/regions/flows-dependency-same-flow.html: Added.
- 7:32 AM Changeset in webkit [93306] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:12 AM Changeset in webkit [93305] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [93304] by
-
- 6 edits3 adds in trunk
Web Inspector: add UISourceCode class.
https://bugs.webkit.org/show_bug.cgi?id=66233
Source/WebCore:
This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.
Reviewed by Pavel Feldman.
Test: inspector/debugger/ui-source-code.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/UISourceCode.js: Added.
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/debugger/ui-source-code-expected.txt: Added.
- inspector/debugger/ui-source-code.html: Added.
- 6:26 AM Changeset in webkit [93303] by
-
- 54 edits in trunk/Source
Make WebCore keep track of the current device scale factor
Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.
- css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::devicePixelRatio):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceScaleFactor):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.
- loader/EmptyClients.h:
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
Removed Chrome[Client]::deviceScaleFactor.
- page/Frame.cpp:
- page/Frame.h:
Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.
- page/Page.cpp:
(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.
- page/Page.h: Added m_deviceScaleFactor.
(WebCore::Page::deviceScaleFactor): Added simple getter.
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
Removed deviceScaleFactor.
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/ChromeClientEfl.h:
Removed deviceScaleFactor.
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
Removed deviceScaleFactor.
Source/WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
Removed deviceScaleFactor.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
Moved code to calculate the device scale factor from here...
- WebView/WebView.mm:
(-[WebView _deviceScaleFactor]):
...to here.
(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.
- Api/qwebpage_p.h: Removed pixelRatio.
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
Removed deviceScaleFactor.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
Removed deviceScaleFactor.
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
Removed deviceScaleFactor.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):
- WebProcess/WebPage/WebPage.h:
Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.
- 6:06 AM Changeset in webkit [93302] by
-
- 3 edits2 adds14 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440
Reviewed by Kent Tamura.
Converted the tests.
- editing/pasteboard/paste-text-010-expected.txt: Added.
- editing/pasteboard/paste-text-010.html:
- editing/pasteboard/paste-text-015-expected.txt: Added.
- editing/pasteboard/paste-text-015.html:
- platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.
- 5:36 AM Changeset in webkit [93301] by
-
- 3 edits1 move1 add15 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443
Reviewed by Kent Tamura.
Converted the tests.
- editing/pasteboard/paste-text-017-expected.txt: Added.
- editing/pasteboard/paste-text-017.html:
- editing/pasteboard/paste-text-018-expected.txt: Added.
- editing/pasteboard/paste-text-018.html:
- platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.
- 5:25 AM Changeset in webkit [93300] by
-
- 11 edits in trunk/Source/WebCore
SVG and HTML editing have conflicting inline isWhitespace functions
https://bugs.webkit.org/show_bug.cgi?id=65145
Reviewed by Nikolas Zimmermann.
Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint): Call skipOptionalSVGSpaces.
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines): Ditto.
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox): Ditto.
- svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.
- svg/SVGParserUtilities.h:
(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.
- svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.
- 4:52 AM Changeset in webkit [93299] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove a superfluous 'using' from WebBindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=66046
Reviewed by Alexey Proskuryakov.
- src/WebBindings.cpp:
- 4:47 AM Changeset in webkit [93298] by
-
- 3 edits3 adds in trunk
[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66426
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Changed the branchTestPtr to branchTest32.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Oliver Hunt.
Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.
- fast/js/mod-by-zero-expected.txt: Added.
- fast/js/mod-by-zero.html: Added.
- fast/js/script-tests/mod-by-zero.js: Added.
(mod):
- 4:43 AM Changeset in webkit [93297] by
-
- 3 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=66425
check-webkit-style should detect incorrectly formatted file change descriptions.
Description, if present, should be separated from colon with a space.
Reviewed by David Levin.
- Scripts/webkitpy/style/checkers/changelog.py: Fix.
- Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
- 4:10 AM Changeset in webkit [93296] by
-
- 5 edits in trunk/Source
Prepare frames for history navigation.
Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.
https://bugs.webkit.org/show_bug.cgi?id=66322
Reviewed by Darin Fisher.
Source/WebCore:
No new tests, as history navigation is very difficult to test in
DumpRenderTree.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
- loader/FrameLoader.h:
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
- 4:05 AM Changeset in webkit [93295] by
-
- 2 edits in trunk/Source/WebCore
When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
https://bugs.webkit.org/show_bug.cgi?id=66282
Patch by Jing Zhao <jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.
No new tests since it only changes the behavior in Android Browser.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
- 4:02 AM Changeset in webkit [93294] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium/mac] Enable smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=66418
Reviewed by Dimitri Glazkov.
- features.gypi:
- 3:33 AM Changeset in webkit [93293] by
-
- 2 edits in trunk/LayoutTests
Remove TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html
http://code.google.com/p/chromium/issues/detail?id=93044
This test should now pass after Chromium rolled V8 to 3.5.6 in r97287.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:22 AM Changeset in webkit [93292] by
-
- 8 edits2 adds in trunk
Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
https://bugs.webkit.org/show_bug.cgi?id=66321
Reviewed by Darin Adler.
Source/WebCore:
This is simply a cleanup change: there's no need that I can see for
HTMLFormControlElement and HTMLObjectElement to override
Element::attributeChanged since they can properly handle form
attribute changes in parseMappedAttribute, which they also override.
Though no change in behavior, I've added test coverage of the moved
code to an existing test (fast/forms/form-attribute.html) and added
a new test.
Test: fast/forms/radio-remove-form-attr.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseMappedAttribute):
- html/HTMLFormControlElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLObjectElement.h:
LayoutTests:
Added new coverage to ensure that adding a radio button to a radio
group in the document by removing a form attribute leaves the group in
a valid state (no more than one button checked).
Beefed up coverage of form associated elements to better cover
HTMLObjectElement.
- fast/forms/form-attribute-expected.txt:
- fast/forms/radio-remove-form-attr-expected.txt: Added.
- fast/forms/radio-remove-form-attr.html: Added.
- fast/forms/script-tests/form-attribute.js:
Added coverage of <object form=""> behavior.
- 3:19 AM Changeset in webkit [93291] by
-
- 10 edits10 adds in trunk
Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052
Patch by Chang Shu <cshu@webkit.org> on 2011-08-18
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Added runtime settings in WebCore.
Added support in window.internals for testing.
Tests: editing/input/password-echo-passnode.html
editing/input/password-echo-passnode2.html
editing/input/password-echo-passnode3.html
editing/input/password-echo-textnode.html
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/qt:
Enable password echo under the build flag.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
LayoutTests:
Added tests.
- editing/input/password-echo-passnode-expected.txt: Added.
- editing/input/password-echo-passnode.html: Added.
- editing/input/password-echo-passnode2-expected.txt: Added.
- editing/input/password-echo-passnode2.html: Added.
- editing/input/password-echo-passnode3-expected.txt: Added.
- editing/input/password-echo-passnode3.html: Added.
- editing/input/password-echo-textnode-expected.txt: Added.
- editing/input/password-echo-textnode.html: Added.
- editing/input/resources: Added.
- editing/input/resources/password-echo.js: Added.
(secureChar):
(secureText):
(log):
(assert):
(run.else):
(run):
(init):
- platform/wk2/Skipped: No support yet.
- 1:44 AM Changeset in webkit [93290] by
-
- 3 edits2 adds in trunk
Selecting all and inserting text into a page with a frameset leads to a NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66288
Source/WebCore:
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.
VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
a new endingSelection, which isn't a sane state to be in. The code
tries to get a position on a higher node for a better selection, but
cannot go above the frameset (which exists in place of the body tag),
which lacks a renderer, and therefore cannot have a non-NoSelection
VisibleSelection.
Because this is a rare corner case, it seemed more reasonable to bail
out in this circumstance than to change the way VisibleSelection
canonicalization works. The new behavior is to delete the content, but
insert nothing. I investigated the possibility of trying to move above
or below the frameset in this particular case, but there still isn't a
renderer, so it didn't prevent the crash.
Test: editing/inserting/insert-text-into-empty-frameset-crash.html
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
LayoutTests:
This test selects all and inserts text in a page which contains a frameset.
It tests for a crash caused by a NULL ptr which can occur in InsertText::doApply.
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.
- editing/inserting/insert-text-into-empty-frameset-crash-expected.txt: Added.
- editing/inserting/insert-text-into-empty-frameset-crash.html: Added.
- 1:09 AM Changeset in webkit [93289] by
-
- 2 edits in trunk/LayoutTests
[Qt] Correct the path in the Skipped list after 93283.
Unreviewed gardening.
- platform/qt/Skipped:
- 1:02 AM Changeset in webkit [93288] by
-
- 3 edits in trunk/Source/WebCore
Remove arguments from CloseEvent::create().
https://bugs.webkit.org/show_bug.cgi?id=66294
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.
CloseEvent objects are initialized by initCloseEvent() in all cases.
Initialization in create() is redundant.
No new tests for no functional difference.
- websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):
- 12:23 AM Changeset in webkit [93287] by
-
- 6 edits20 adds in trunk
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785
Source/WebCore:
Reviewed by Simon Fraser.
Fixed two iframe and frameset scaling bugs:
#1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
#2 frameset does not respect -webkit-transform-origin when scaled
Tests: fast/frames/frame-set-scaling-3d.html
fast/frames/frame-set-scaling-centered.html
fast/frames/frame-set-scaling-rotate.html
fast/frames/frame-set-scaling-skew.html
fast/frames/frame-set-scaling.html
fast/frames/iframe-scaling-with-scroll.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.
LayoutTests:
Added tests to verify that framesets and iframes are scaled and positioned correctly.
Reviewed by Simon Fraser.
- fast/frames/frame-set-scaling-3d-expected.png: Added.
- fast/frames/frame-set-scaling-3d-expected.txt: Added.
- fast/frames/frame-set-scaling-3d.html: Added.
- fast/frames/frame-set-scaling-centered-expected.png: Added.
- fast/frames/frame-set-scaling-centered-expected.txt: Added.
- fast/frames/frame-set-scaling-centered.html: Added.
- fast/frames/frame-set-scaling-expected.png: Added.
- fast/frames/frame-set-scaling-expected.txt: Added.
- fast/frames/frame-set-scaling-rotate-expected.png: Added.
- fast/frames/frame-set-scaling-rotate-expected.txt: Added.
- fast/frames/frame-set-scaling-rotate.html: Added.
- fast/frames/frame-set-scaling-skew-expected.png: Added.
- fast/frames/frame-set-scaling-skew-expected.txt: Added.
- fast/frames/frame-set-scaling-skew.html: Added.
- fast/frames/frame-set-scaling.html: Added.
- fast/frames/iframe-scaling-with-scroll.html: Added.
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
- platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- 12:21 AM Changeset in webkit [93286] by
-
- 2 edits in trunk/Tools
webkit-patch pretty-diff should be shown in main help
https://bugs.webkit.org/show_bug.cgi?id=66404
Reviewed by Dimitri Glazkov.
As requested by dglazkov.
- Scripts/webkitpy/tool/commands/prettydiff.py: