Timeline


and

08/23/11:

22:24 Changeset [93695] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Extra baseline for bug 66036 (canvas fill composite modes)
https://bugs.webkit.org/show_bug.cgi?id=66835

Unreviewed, new baseline for pixel tests.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23

  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
22:15 Changeset [93694] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 93514
BUG=93420
Review URL: http://codereview.chromium.org/7714029

21:37 Changeset [93693] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Change parameter type for some APIs in ewk_tile_matrix.
https://bugs.webkit.org/show_bug.cgi?id=66639

As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch
are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now
using unsigned long type for both col and row parameter, row parameter for ewk_tile_matrix
is also better to be specified as unsigned long type.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_matrix.c:

(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):

  • ewk/ewk_tiled_matrix.h:
21:32 Changeset [93692] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

WebSearchableFormData crashes when given a detached HTMLFormElement
https://bugs.webkit.org/show_bug.cgi?id=66831

Reviewed by Dimitri Glazkov.

We need to null-check the Frame.

  • src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

  • tests/data/form.html: Added.
21:24 Changeset [93691] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Make notifications appear in time order again.
https://bugs.webkit.org/show_bug.cgi?id=66815

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
19:14 Changeset [93690] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Extra baseline for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66833

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

  • platform/chromium-gpu-linux/compositing/masks/multiple-masks-expected.png: Added.
19:11 Changeset [93689] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make WebGL context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66788

We're making changes on the Chromium side for threaded compositing that
will require makeContextCurrent to be called on the appropriate thread
before any other GL calls.

In line with other GraphicsContext3D implementations, we do this
implicitly. This is the minimum change that makes WebGL compliant.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by Kenneth Russell.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initializeExtensions):

19:05 Changeset [93688] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Add checks to ensure allocation does not take place during initialization of GC-managed objects
https://bugs.webkit.org/show_bug.cgi?id=65288

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-23
Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::constructorBody):
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::allocateCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObject):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):

Source/WebCore:

No new tests.

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::operator new):

  • bindings/js/JSDOMWindowShell.h:

Source/WebKit/mac:

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

19:00 Changeset [93687] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Rebaselines for bug 66036 (fills with various canvas compositing modes)
https://bugs.webkit.org/show_bug.cgi?id=66824

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by James Robinson.

  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:57 Changeset [93686] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add more flaky snowleopard GPU tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:55 Changeset [93685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Get the default value for `scripts_window_open' from the right method.
https://bugs.webkit.org/show_bug.cgi?id=66775

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

For some unknown reason, the default value for this setting was being
obtained from Settings::allowScriptsToCloseWindows() instead of
Settings::javaScriptCanOpenWindowsAutomatically(), which makes no
sense at all.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

18:39 Changeset [93684] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix erroneous test expectation.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:39 Changeset [93683] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Change the tiled backing store to use constant size of tile.
https://bugs.webkit.org/show_bug.cgi?id=65848

As current tiled backing store in Webkit EFL is using variable tile size according to the zoom level,
the number of tiles in viewport is not same always and the speed of panning is also not consistent
whenever zoom level is changed.
Therefore, tile size should be constant size in order to make sure the consistent panning speed.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.c:

(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_dbg):

  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.c:

(ewk_tile_new):

18:36 Changeset [93682] by commit-queue@webkit.org
  • 5 edits in trunk/Source

ScrollAnimatorNone coasting implementation
https://bugs.webkit.org/show_bug.cgi?id=66258

Source/WebCore:

Increase the animation time based on the velocity of the scroll, up to a
maximum amount. Fix bugs found by additional unit testing.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Additional tests in ScrollAnimatorNoneTest: CurveMathQuartic, CurveMathCoast,
ScrollOnceQuartic, ScrollTwiceCubic, ScrollLotsCubic, ScrollLotsCubicSmoothed,
ScrollUpToBumperCoast, ScrollDownToBumperCoast, VaryingInputsEquivalency,
VaryingInputsEquivalencyCoast, VaryingInputsEquivalencyCoastLarge,
VaryingInputsEquivalencyCoastSteep

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::coastCurve):
(WebCore::ScrollAnimatorNone::PerAxisData::curveIntegralAt):
(WebCore::ScrollAnimatorNone::PerAxisData::attackArea):
(WebCore::ScrollAnimatorNone::PerAxisData::releaseArea):
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateVisibleLength):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::willEndLiveResize):
(WebCore::ScrollAnimatorNone::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorNone::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorNone::updateVisibleLengths):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):
(ScrollAnimatorNoneTest::SavePerAxisData::SavePerAxisData):
(ScrollAnimatorNoneTest::SavePerAxisData::operator==):
(ScrollAnimatorNoneTest::SetUp):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::attackArea):
(ScrollAnimatorNoneTest::releaseArea):
(ScrollAnimatorNoneTest::coastCurve):
(ScrollAnimatorNoneTest::curveTestInner):
(TEST_F):

18:33 Changeset [93681] by jamesr@google.com
  • 11 edits
    3 adds in trunk

[chromium] Need a way to test lost compositor context recovery
https://bugs.webkit.org/show_bug.cgi?id=66820

Reviewed by Kenneth Russell.

Source/WebCore:

Adds support for recreating a context as if it was lost, and fixes
compositeAndReadback() to attempt context recovery.

Test: platform/chromium/compositing/lost-compositor-context.html

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseCompositorContext):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Adds a testing-only API to simulate a lost compositor context.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::loseCompositorContext):

  • src/WebViewImpl.h:

Tools:

Exposes a LayoutTestController interface in chromium to simulate a
lost compositor context.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::loseCompositorContext):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adds a simple test for losing the compositor context in a recoverable
way on a composited page. Tests that we recover without crashing and
render the updated content on the next frame.

  • platform/chromium/compositing/lost-compositor-context.html: Added.
18:22 Changeset [93680] by nduca@chromium.org
  • 12 edits
    1 move
    1 add in trunk/Source

[chromium] Implement CCThread in terms of WebThread
https://bugs.webkit.org/show_bug.cgi?id=66610

Reviewed by Darin Fisher.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCCompletionEvent.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::client):

  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):

  • platform/graphics/chromium/cc/CCThread.h:

(WebCore::CCThread::~CCThread):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebThread.h:

(WebKit::WebThread::~WebThread):

  • src/CCThreadImpl.cpp: Added.

(WebKit::GetThreadIDTask::GetThreadIDTask):
(WebKit::GetThreadIDTask::~GetThreadIDTask):
(WebKit::GetThreadIDTask::run):
(WebKit::CCThreadTaskAdapter::CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::~CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::run):
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::~CCThreadImpl):
(WebKit::CCThreadImpl::postTask):
(WebKit::CCThreadImpl::threadID):
(WebKit::CCThreadImpl::CCThreadImpl):

  • src/CCThreadImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorThread):

  • src/WebViewImpl.h:
  • tests/CCThreadTest.cpp:
18:18 Changeset [93679] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Source/WebCore:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setParent):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::hasAncestor):

  • platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didRecreateGraphicsContext):

18:08 Changeset [93678] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93420.

18:06 Changeset [93677] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-534.51-branch

Merge r90691.

18:00 Changeset [93676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r93645.
http://trac.webkit.org/changeset/93645
https://bugs.webkit.org/show_bug.cgi?id=66828

Broke webkit_unit_tests on chromium mac (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

17:54 Changeset [93675] by mrowe@apple.com
  • 5 edits
    20 adds in branches/safari-534.51-branch

Merge r93287.

17:54 Changeset [93674] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-534.51-branch

Merge r92417.

17:43 Changeset [93673] by mrowe@apple.com
  • 3 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93546.

17:38 Changeset [93672] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92894.

17:33 Changeset [93671] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-23
Reviewed by Alexey Proskuryakov.

It is still unclear in what scenario the ResourceLoader could have a non-null DocumentLoader
without a Frame, since all loads should be stopped before the DocumentLoader is detached
from its Frame.

Until a reproducible case is found, bail early to prevent crashes.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didFail):
Add an early return if the DocumentLoader does not have a Frame.

17:29 Changeset [93670] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Prepare WKTextInputWindowController for the new text input model
https://bugs.webkit.org/show_bug.cgi?id=66826

Reviewed by Sam Weinig.

Add -[WKTextInputWindowController hasMarkedText] and make interpretKeyEvent take an
additional usingLegacyCocoaTextInput flag. No functionality change.

  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
(-[WKTextInputWindowController hasMarkedText]):
(-[WKTextInputWindowController interpretKeyEvent:usingLegacyCocoaTextInput:string:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView keyDown:]):

17:29 Changeset [93669] by bdakin@apple.com
  • 9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=66244
Cached pages don't fully update when going back after changing the display scale
factor
-and corresponding-
<rdar://problem/9955656>

Reviewed by Darin Adler.

This patch adds a generalized concept of needing a full style recalc to the
BackForwardController. So when the display scale factor is changed, the
BackForwardController can be informed that all pages will need a full style recalc
when they come out of the cache. This same mechanism is also used to fix a long-
standing bug with full-page/text zoom.

Iterate through the HistoryItems and mark all CachedPages as needing a full style
recalc.

  • history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

  • history/BackForwardController.h:

ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full
style recalc is needed when the CachedPage is restored.

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

  • history/CachedPage.h:

(WebCore::CachedPage::markForFullStyleRecalc):

HistoryItem actually takes care of calling into CachedPage.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::markForFullStyleRecalc):

  • history/HistoryItem.h:

Fix style recalc issues for full-page/text zoom by calling our new function on
PageCache.

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

Fix style recalc issues for display scale factor changes by calling our new
function on PageCache.

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

17:15 Changeset [93668] by mrowe@apple.com
  • 5 edits in branches/safari-534.51-branch

Merge r93487.

17:15 Changeset [93667] by mrowe@apple.com
  • 7 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92788.

17:15 Changeset [93666] by mrowe@apple.com
  • 7 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93555.

17:15 Changeset [93665] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-534.51-branch

Merge r93298.

17:15 Changeset [93664] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93264.

17:13 Changeset [93663] by abarth@webkit.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

Fix baselines for fast/block/float/fit_line_below_floats.html. I forgot Windows in my previous patch.

  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Removed.
  • platform/chromium-win/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-win/fast/block/float/fit_line_below_floats-expected.txt: Added.
16:59 Changeset [93662] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove comments formerly associated with now-rebaselined tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
16:39 Changeset [93661] by lforschler@apple.com
  • 5 edits
    2 copies in branches/safari-534.51-branch/Source/WebCore

Merge r93363.

16:37 Changeset [93660] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93260.

16:34 Changeset [93659] by lforschler@apple.com
  • 4 edits
    6 copies
    4 deletes in branches/safari-534.51-branch/Source/WebCore

Merge 93219.

16:33 Changeset [93658] by dglazkov@chromium.org
  • 6 edits in trunk/Tools

Change garden-o-matic frontend builder array to be a configuration map.
https://bugs.webkit.org/show_bug.cgi?id=66816

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
16:32 Changeset [93657] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • inspector/InstrumentingAgents.cpp:
16:31 Changeset [93656] by commit-queue@webkit.org
  • 8 edits in trunk

Added support for momentarily revealing last typed character in password input.
Code change was partially based on Apple's iOS code and Samuel Nevala's work.
https://bugs.webkit.org/show_bug.cgi?id=32509

Patch by Chang Shu <cshu@webkit.org> on 2011-08-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):

  • rendering/RenderText.cpp:

(WebCore::SecureTextTimer::SecureTextTimer):
(WebCore::SecureTextTimer::restartWithNewText):
(WebCore::SecureTextTimer::invalidate):
(WebCore::SecureTextTimer::lastTypedCharacterOffset):
(WebCore::SecureTextTimer::fired):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::secureText):
(WebCore::RenderText::momentarilyRevealLastTypedCharacter):

  • rendering/RenderText.h:

(WebCore::RenderText::isSecure):

  • testing/Internals.cpp:

(WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

LayoutTests:

Updated failed expected files.

  • editing/input/password-echo-passnode-expected.txt:
  • editing/input/password-echo-passnode2-expected.txt:
16:24 Changeset [93655] by commit-queue@webkit.org
  • 2 edits
    1 move
    6 adds in trunk/LayoutTests

Rebaselines for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66757

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

  • platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/chromium-linux/fast/backgrounds/mask-composite-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-composite-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-composite-expected.txt: Added.
  • platform/chromium-win/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-win/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/transformed-mask-expected.txt.
  • platform/chromium/test_expectations.txt:
16:22 Changeset [93654] by commit-queue@webkit.org
  • 5 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=66751
[Chromium]WebWorkerClientImpl should always invoke
InspectorIntrumentation on main thread.
The fix moves calls to InspectorInstrumentation from
WebWorkerClientImpl to unedrlying WorkerMessagingProxy.

Patch by Dmitry Lomov <Dmitry Lomov (dslomov@google.com)> on 2011-08-23
Reviewed by Pavel Feldman.

Source/WebCore:

Covered by existing tests.

  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerContext):

Source/WebKit/chromium:

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):

16:18 Changeset [93653] by caryclark@google.com
  • 2 edits in trunk/Tools

Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=66803

This fixes the WebKit Canaries, in particular avoids a crash on tests
like css1/basic/comments.html.

Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
and treated it as if it were a CGContextRef.

16:12 Changeset [93652] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635

When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.

Patch by Misha Tyutyunik <michael.tyutyunik@nokia.com> on 2011-08-23
Reviewed by Andreas Kling.

Covered by existing tests.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemColor):

16:10 Changeset [93651] by tony@chromium.org
  • 4 edits
    2 adds in trunk

Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723

Reviewed by David Hyatt.

Source/WebCore:

If we flex past a min/max width value, we need to mark the flexitem as
a fixed width and re-start the flexing algorithm. We use a HashMap to
keep track of fixed width items.

This patch also split out the size computation from the actual layout
to avoid unnecessary layouts caused by restarting the flexing algorithm.

Test: css3/flexbox/003.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/003-expected.txt: Added.
  • css3/flexbox/003.html: Added.
16:08 Changeset [93650] by abarth@webkit.org
  • 11 edits
    18 adds
    5 deletes in trunk/LayoutTests

Update expectations for pkasting. The rebaseline script is having
trouble on Cygwin, so I ran the script as instructed by Peter.

  • platform/chromium-cg-mac-leopard/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-cg-mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/css: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates: Removed.
  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/chromium-linux/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-linux/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/058-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win-vista/svg/dynamic-updates: Removed.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/058-expected.txt:
  • platform/chromium-win/fast/css/border-radius-non-negative-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/image-small-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/image-small-width-height-expected.txt: Removed.
  • svg/custom/image-small-width-height-expected.txt: Added.
16:07 Changeset [93649] by paroga@webkit.org
  • 2 edits in trunk/Tools

Fix mergeChangeLogs test on native windows
https://bugs.webkit.org/show_bug.cgi?id=66797

Reviewed by Adam Roben.

Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.

  • Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:

(writeTempFile):

16:05 Changeset [93648] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

ResourceRequest::setStorageSession should update NSURLRequest as well
https://bugs.webkit.org/show_bug.cgi?id=66811

Reviewed by Darin Adler.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::setStorageSession): Update the m_nsRequest field as well since we
have a new CFURLRequestRef.

16:01 Changeset [93647] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Remove obsolete child context list from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66743

Patch by James Robinson <jamesr@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

Before we had proper semantics for flush() in the command buffer, we
used a scheme of latches across contexts to ensure consistent frames
were presented for WebGL and canvas. We no longer have latches and
flush is a proper synchronization primative, so the child context list
no longer does anything. Canvas2DLayerChromium and
WebGLLayerChromium's implementations of updateCompositorResources() do
flushes on the appropriate context already - canvas layers via
DrawingBuffer::publishToPlatformLayer(), and WebGL layers via the call
to prepareTexture().

No new tests since the code being removed doesn't do anything.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::setContext):

  • platform/graphics/chromium/WebGLLayerChromium.h:
16:01 Changeset [93646] by lforschler@apple.com
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge https://bugs.webkit.org/show_bug.cgi?id=62901

15:59 Changeset [93645] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-23
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

15:57 Changeset [93644] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: Prepare to paint slider thumb separately.
Provide proper size values for vertical SliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):
Swap length and thickness for sliderthumb-vertical.

LayoutTests: Swap width and height for sliderthumb-vertical.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
15:35 Changeset [93643] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Typo fix.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:22 Changeset [93642] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Revert unintentional changes to test expectations in r93638.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:10 Changeset [93641] by dglazkov@chromium.org
  • 4 edits in trunk/Tools

garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
15:09 Changeset [93640] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=66808

Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

15:01 Changeset [93639] by lforschler@apple.com
  • 5 edits in tags/Safari-534.49.2/Source

Versioning.

14:51 Changeset [93638] by pkasting@chromium.org
  • 4 edits
    3 deletes in trunk

Unreviewed, rolling out r93452.
http://trac.webkit.org/changeset/93452
https://bugs.webkit.org/show_bug.cgi?id=66423

Broke Leopard, Snowleopard, and Chromium bots

Source/WebCore:

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Removed.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
14:40 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
14:01 Changeset [93637] by demarchi@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit

Source/WebKit: Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

[EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

  • CMakeLists.txt:

Adding necessary files for the patch.

Source/WebKit/efl: [EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

  • CMakeLists.txt:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/EWebKit.h:
  • ewk/ewk_js.cpp: Added.

(ewk_js_variant_to_npvariant):
(ewk_js_npvariant_to_variant):
(ewk_js_property_has):
(ewk_js_property_get):
(ewk_js_property_set):
(ewk_js_property_remove):
(ewk_js_properties_enumerate):
(ewk_js_method_has):
(ewk_js_method_invoke):
(ewk_js_class_new):
(ewk_js_class_free):
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_variant_free):

  • ewk/ewk_js.h: Added.
  • ewk/ewk_main.cpp:

(ewk_init):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_js_window_object_clear):
(ewk_view_js_object_add):

  • ewk/ewk_view.h:
13:48 Changeset [93636] by andreas.kling@nokia.com
  • 1 edit
    3 deletes in trunk/Source/WebKit2

[Qt] Unnecessary folders in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=66583

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-23
Reviewed by Benjamin Poulain.

Remove empty autotest folders that were left over from QGraphicsWKView times.

  • UIProcess/API/qt/tests/qgraphicswkview: Removed.
  • UIProcess/API/qt/tests/qwkhistory: Removed.
  • UIProcess/API/qt/tests/qwkpage: Removed.
13:40 Changeset [93635] by pkasting@chromium.org
  • 1 edit
    8 moves in trunk/LayoutTests

[chromium] Move result images into correct subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=66618

Unreviewed, file misplacement fix.

  • platform/chromium-cg-mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-transformed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png.
  • platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Removed.
13:34 Changeset [93634] by lforschler@apple.com
  • 3 edits in tags/Safari-534.49.2/Source/WebKit2

Merge r93546.

13:32 Changeset [93633] by lforschler@apple.com
  • 1 copy in tags/Safari-534.49.2

New tag.

13:19 Changeset [93632] by adamk@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Remove a few FIXME #defines in API headers
https://bugs.webkit.org/show_bug.cgi?id=66791

Reviewed by James Robinson.

  • DEPS:

Roll chromium_rev to r97891.

  • public/WebFileSystem.h:

#define made obsolete in http://crrev.com/97520.

  • public/WebKitClient.h:

#define made obsolete in http://crrev.com/97524 and
http://crrev.com/97891.

13:10 Changeset [93631] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixed warnings produced by gcc-4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=62168

Patch by Ahmad Sharif <asharif@chromium.org> on 2011-08-23
Reviewed by Adam Barth.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):

  • thirdparty: Copied from Source/WebCore/thirdparty.
13:08 Changeset [93630] by paroga@webkit.org
  • 2 edits in trunk/Tools

Add missing quotes around filenames in mergeChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=66794

Reviewed by Adam Roben.

  • Scripts/VCSUtils.pm:

(mergeChangeLogs):

13:00 BuildingQtOnLinux edited by andreas.kling@nokia.com
(diff)
12:58 Changeset [93629] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Attempt to make test expectations more accurate.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:54 Changeset [93628] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Text overlaps with the floats
https://bugs.webkit.org/show_bug.cgi?id=66671

Source/WebCore:

The problem was that LineWidth::fitBelowFloats is not updating the m_left and m_right fields.
Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded was called the width was recalculated
using the old values, making the line bigger.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Test: fast/block/float/fit_line_below_floats.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitBelowFloats):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/block/float/fit_line_below_floats.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/mac/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/qt/Skipped:
12:44 Changeset [93627] by commit-queue@webkit.org
  • 11 edits
    8 adds in trunk

[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html

fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

  • rendering/RenderFlowThread.h:

(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
12:38 Changeset [93626] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

Text-indent and floats push the text out of the container box
https://bugs.webkit.org/show_bug.cgi?id=66662

Source/WebCore:

Text indent was not propagated when a new float was pushed on the line.
It was only calculated when the logicalLeft/RightOffsetForLine was called.
Because of that RenderBlock::LineBreaker::nextLineBreak used a bigger width
than actually available and made the line render on top of the borders.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/block/float/floats-and-text-indent-rl.html

fast/block/float/floats-and-text-indent.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/block/float/floats-and-text-indent-rl.html: Added.
  • fast/block/float/floats-and-text-indent.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/qt/Skipped:
12:30 Changeset [93625] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Add shareResources flag to 3D graphics context attributes
https://bugs.webkit.org/show_bug.cgi?id=66516

Patch by Al Patrick <apatrick@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):

  • src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):

12:28 Changeset [93624] by barraclough@apple.com
  • 10 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The default value of a NativeErrorPrototype's message
property is "", not the name of the error.

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::create):
(JSC::NativeErrorConstructor::constructorBody):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

  • runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::create):

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
    • Add tests for value of RangeError.proto.{name|message}
12:27 Changeset [93623] by paroga@webkit.org
  • 2 edits in trunk/Tools

webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Reviewed by Adam Roben.

Use the string form of pipe open instead (like we do at all other places).

  • Scripts/VCSUtils.pm:

(mergeChangeLogs):

12:21 Changeset [93622] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

New MainFrame views should inherit fixed layout settings from existing MainFrame view in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=66780

Fixed layout mode is set from WebViewImpl, but new main FrameViews are created on loading new pages. The new page's FrameView should get its
fixed layout settings from the current page.

Reviewed by Darin Fisher.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

12:07 Changeset [93621] by commit-queue@webkit.org
  • 7 edits
    6 deletes in trunk

Unreviewed, rolling out r93616.
http://trac.webkit.org/changeset/93616
https://bugs.webkit.org/show_bug.cgi?id=66796

"causes fast/css/absolute-child-with-percent-height-inside-
relative-parent.html to fail" (Requested by mwenge2 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Removed.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Removed.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Removed.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
11:46 Changeset [93620] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.

  • UIProcess/qt/SGAgent.h:

(WebKit::NodeUpdate::~NodeUpdate):

11:42 Changeset [93619] by kerz@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92159 - Shard webcore_remaining for msvs official builds

https://bugs.webkit.org/show_bug.cgi?id=65475

Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.

webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

  • WebCore.gyp/WebCore.gyp:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7715011

11:30 Changeset [93618] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-23
Reviewed by Tony Chang.

  • WebKit.gyp:
  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
11:27 Changeset [93617] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
https://bugs.webkit.org/show_bug.cgi?id=66692

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Rubber-stamped by Kenneth Rohde Christiansen.

Frame::page() and FrameTree::parent() returning 0 were being considered
failure cases, however it is possible for them to return 0 when some
arbitrary JavaScript is run.

The function's return type has been changed to make it easier to convey
these cases to the caller (which is only ewk_view_frame_create).

This should make tests like
fast/dom/null-page-show-modal-dialog-crash.html stop outputting
erroneous messages to stderr.

  • ewk/ewk_frame.cpp:

(ewk_frame_child_add):

  • ewk/ewk_private.h:
11:11 Changeset [93616] by robert@webkit.org
  • 7 edits
    6 adds in trunk

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/inline/absolute-positioned-block-in-centred-block.html

fast/inline/absolute-positioned-inline-in-centred-block.html

When an element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
(WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
(WebCore::RenderBlock::startAlignedOffsetForLine): ditto

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine.
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
11:08 Changeset [93615] by enne@google.com
  • 15 edits in trunk/Source/WebCore

[chromium] Remove LayerRendererChromium references from TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433

Reviewed by James Robinson.

Covered by existing tests.

Updated TiledLayerChromium and the texture updater classes to not
access LayerRendererChromium or cache GraphicsContext3D. Some settings
like max texture size were moved from LayerRendererChromium to
CCLayerTreeHost in order to facilitate this refactoring.

LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
compositor is not threaded. It will need to be refactored more in
order to not own graphics resources from the main thread.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::LayerTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

(WebCore::LayerTextureUpdaterSkPicture::context):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::layerRenderer):
(WebCore::CCLayerTreeHost::contextSupportsMapSub):
(WebCore::CCLayerTreeHost::maxTextureSize):
(WebCore::CCLayerTreeHost::bestTextureFormat):

11:02 Changeset [93614] by jchaffraix@webkit.org
  • 6 edits
    40 adds in trunk

Reduce the amount of RenderLayer rectangles' update when scrolling
https://bugs.webkit.org/show_bug.cgi?id=66618

Reviewed by David Hyatt.

Source/WebCore:

This patch avoids recomputing the RenderLayers rectangles if not needed.

The current code path for scrolling would update RenderLayers' repaint rectangles
twice. However we do need to update only children of a fixed element as they are
the only type of layers that move during a scroll.

We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
updateLayerPositions being pessimist about the layer's state - because it is called after layout -
it is missing some optimization that can be done during scrolling.

Tests: fast/repaint/scroll-absolute-layer-with-reflection.html

fast/repaint/scroll-fixed-layer-with-reflection.html
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
fast/repaint/scroll-fixed-reflected-layer.html
fast/repaint/scroll-in-clipped-layer.html
fast/repaint/scroll-in-fixed-layer.html
fast/repaint/scroll-in-transformed-layer.html
fast/repaint/scroll-with-transformed-parent-layer.html

  • rendering/RenderLayer.h:
  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
to take care of also updating the layer's position (that sounded like a bug in
the previous code that is covered by the tests above). Note that we don't care
if one of our ancestor has a fixed position as we are scrolling *inside* this
ancestor.

(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
updateLayerPositions.

LayoutTests:

  • fast/repaint/resources/default.css:

Added more shortcuts.

  • fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
  • fast/repaint/scroll-absolute-layer-with-reflection.html: Added.
  • fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-reflection.html: Added.
  • fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html: Added.
  • fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
  • fast/repaint/scroll-fixed-reflected-layer.html: Added.
  • fast/repaint/scroll-in-clipped-layer-expected.txt: Added.
  • fast/repaint/scroll-in-clipped-layer.html: Added.
  • fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
  • fast/repaint/scroll-in-fixed-layer.html: Added.
  • fast/repaint/scroll-in-transformed-layer-expected.txt: Added.
  • fast/repaint/scroll-in-transformed-layer.html: Added.
  • fast/repaint/scroll-with-transformed-parent-layer-expected.txt: Added.
  • fast/repaint/scroll-with-transformed-parent-layer.html: Added.

Those are a variation on the same theme: scrolling inside a layers (sometimes the layer is itself scrolled)
to show that we are still doing the right thing.

  • platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.

Baseline for Chromium and Mac.

10:47 Changeset [93613] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

New XML parser: pretty XML tree viewer
https://bugs.webkit.org/show_bug.cgi?id=66489

Reviewed by Adam Barth.

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::finish):

10:41 Changeset [93612] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Disabled inspector/extensions/extensions-resources.html.
https://bugs.webkit.org/show_bug.cgi?id=66786

  • platform/qt/Skipped:
10:08 Changeset [93611] by leandro@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed build fix after r66685.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
Assert using the right variable name.

09:31 Changeset [93610] by caseq@chromium.org
  • 4 edits in trunk/LayoutTests

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix following r93605.

  • http/tests/inspector/resources/extension-main.js: (trimURL):
  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
09:25 Changeset [93609] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewd, roll chromium reverse DEPS 97698:97834
https://bugs.webkit.org/show_bug.cgi?id=66781

  • DEPS:
09:20 Changeset [93608] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

  • inspector/InspectorDOMAgent.h:

HighlightData is a struct, not a class.

09:02 Changeset [93607] by abarth@webkit.org
  • 10 edits in trunk/Tools

garden-o-matic summary should be able to examine failures
https://bugs.webkit.org/show_bug.cgi?id=66748

Reviewed by Dimitri Glazkov.

This patch refactors a bunch of code from summary.js to independent
controllers in controllers.js. This patch also contains the first
iteration of binding the "examine" event to a the behavior showing the
details view for the tests. There's more work to do here to make this
work properly (and elegantly), but this patch is a start.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
08:48 Changeset [93606] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
https://bugs.webkit.org/show_bug.cgi?id=66698

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

WebCore::History->currentItem() may return NULL, and we'd better treat
it in ewk_history_history_item_current_get itself than propagate the
issue to _ewk_history_item_new.

  • ewk/ewk_history.cpp:

(ewk_history_history_item_current_get):

  • ewk/ewk_history.h:
08:35 Changeset [93605] by caseq@chromium.org
  • 10 edits
    3 adds in trunk

Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-resources.html

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetRequestContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype.initExtensions):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.addRevision):

LayoutTests:

  • http/tests/inspector/resources/extension-main.js:

(trimURL):

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-network-expected.txt:
  • inspector/extensions/extensions-network.html:
  • inspector/extensions/extensions-resources-expected.txt: Added.
  • inspector/extensions/extensions-resources.html: Added.
  • inspector/extensions/resources/Ahem.ttf:
  • inspector/extensions/resources/test-script.js: Added.

(test_function):

08:08 Changeset [93604] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::highlightFrame):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown):
07:38 Changeset [93603] by apavlov@chromium.org
  • 13 edits in trunk/Source/WebCore

Web Inspector: differentiate element highlight colors for margin and padding
https://bugs.webkit.org/show_bug.cgi?id=37768

The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
rather than a generic "highlighting mode". This allows to:

  • use entirely custom colors for highlighting (and vary them over time);
  • display any combination of fill/outline for the highlighted area;
  • highlight any combinations of element parts.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawHighlight):

  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::highlightedNode):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/Color.js:

(WebInspector.Color.fromRGBA):
(WebInspector.Color.prototype.toProtocolRGBA):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.setSearchingForNode):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.set hovered):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._highlightRect):

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:

(WebInspector.buildHighlightConfig):
(WebInspector.highlightDOMNode):

06:37 Changeset [93602] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

EFL's DumpRenderTree implementation needs some private, auxiliary
functions in ewk in order to iterate and dump the history tree when
necessary.

  • ewk/ewk_history.cpp:

(ewk_history_item_target_get):
(ewk_history_item_target_is):
(ewk_history_item_children_get):

  • ewk/ewk_private.h:
06:36 Changeset [93601] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r93579.
http://trac.webkit.org/changeset/93579
https://bugs.webkit.org/show_bug.cgi?id=66774

"ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

06:26 Changeset [93600] by vestbo@webkit.org
  • 5 edits in trunk/Source

[Qt] Fix build on Lion

https://bugs.webkit.org/show_bug.cgi?id=66770

Reviewed by Andreas Kling.

We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).

For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.

Lasty, we need to link against the right system interface library
on Lion.

06:19 Changeset [93599] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

Add some auxiliary functions needed by EFL's DRT implementation. They
all revolve around talking to the garbage collector and counting the
worker threads.

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp:

(ewk_util_javascript_gc_collect):
(ewk_util_javascript_gc_alternate_thread_collect):
(ewk_util_javascript_gc_object_count_get):
(ewk_util_worker_thread_count):
(ewk_util_dpi_get):

06:12 Changeset [93598] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.

  • platform/qt/Skipped:
06:07 Changeset [93597] by steveblock@google.com
  • 4 edits in trunk/Source

Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763

Reviewed by Tony Gentilcore.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

No new tests, removing dead code only.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

05:45 Changeset [93596] by steveblock@google.com
  • 8 edits in trunk/Source/WebCore

Remove Android-specific modifications to non-client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=66759

Reviewed by Tony Gentilcore.

No new tests, removing dead code only.

  • page/Geolocation.cpp:
  • page/Geolocation.h:
  • platform/GeolocationService.h:
  • platform/efl/GeolocationServiceEfl.cpp:
  • platform/efl/GeolocationServiceEfl.h:
  • platform/gtk/GeolocationServiceGtk.cpp:
  • platform/gtk/GeolocationServiceGtk.h:
05:43 Changeset [93595] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: switch to using BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=66225

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

05:40 Changeset [93594] by steveblock@google.com
  • 12 edits in trunk

Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755

Reviewed by Tony Gentilcore.

.:

  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

Source/WebCore:

No new tests, removing dead code only.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • gyp/WebCore.gyp:

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:
05:39 Changeset [93593] by tkent@chromium.org
  • 12 edits
    6 copies
    89 moves
    8 adds
    1 delete in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=66651
Move <input type=range> tests to fast/forms/range/

Reviewed by Tony Chang.

  • fast/forms/ValidityState-stepMismatch-expected.txt: Removed 'range' part.
  • fast/forms/input-appearance-range-rtl-expected.html: Removed.
  • fast/forms/input-appearance-range-rtl.html: Removed.
  • fast/forms/input-appearance-range.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed 'range' part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed 'range' part.
  • fast/forms/input-valueasnumber-range-expected.txt: Removed.
  • fast/forms/input-valueasnumber-range.html: Removed.
  • fast/forms/range: Added.
  • fast/forms/range-default-value-expected.txt: Removed.
  • fast/forms/range-default-value.html: Removed.
  • fast/forms/range-drag-expected.txt: Removed.
  • fast/forms/range-drag.html: Removed.
  • fast/forms/range-input-dynamic-oninput-expected.txt: Removed.
  • fast/forms/range-input-dynamic-oninput.html: Removed.
  • fast/forms/range-keyoperation-expected.txt: Removed.
  • fast/forms/range-keyoperation.html: Removed.
  • fast/forms/range-reset-expected.txt: Removed.
  • fast/forms/range-reset.html: Removed.
  • fast/forms/range-set-attribute-expected.txt: Removed.
  • fast/forms/range-set-attribute.html: Removed.
  • fast/forms/range-thumb-height-percentage.html: Removed.
  • fast/forms/range/ValidityState-stepMismatch-range-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/range/ValidityState-stepMismatch-range.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/range/input-appearance-range-rtl-expected.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl-expected.html.
  • fast/forms/range/input-appearance-range-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl.html.
  • fast/forms/range/input-appearance-range.html: Copied from LayoutTests/fast/forms/input-appearance-range.html.
  • fast/forms/range/input-valueasnumber-range-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-range-expected.txt.
  • fast/forms/range/input-valueasnumber-range.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-range.js.
  • fast/forms/range/range-default-value-expected.txt: Copied from LayoutTests/fast/forms/range-default-value-expected.txt.
  • fast/forms/range/range-default-value.html: Copied from LayoutTests/fast/forms/range-default-value.html.
  • fast/forms/range/range-drag-expected.txt: Copied from LayoutTests/fast/forms/range-drag-expected.txt.
  • fast/forms/range/range-drag.html: Copied from LayoutTests/fast/forms/range-drag.html.
  • fast/forms/range/range-input-dynamic-oninput-expected.txt: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput-expected.txt.
  • fast/forms/range/range-input-dynamic-oninput.html: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput.html.
  • fast/forms/range/range-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/range-keyoperation-expected.txt.
  • fast/forms/range/range-keyoperation.html: Copied from LayoutTests/fast/forms/range-keyoperation.html.
  • fast/forms/range/range-reset-expected.txt: Copied from LayoutTests/fast/forms/range-reset-expected.txt.
  • fast/forms/range/range-reset.html: Copied from LayoutTests/fast/forms/range-reset.html.
  • fast/forms/range/range-set-attribute-expected.txt: Copied from LayoutTests/fast/forms/range-set-attribute-expected.txt.
  • fast/forms/range/range-set-attribute.html: Copied from LayoutTests/fast/forms/range-set-attribute.html.
  • fast/forms/range/range-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/range/range-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/range/range-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/range/range-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/range/range-thumb-height-percentage.html: Copied from LayoutTests/fast/forms/range-thumb-height-percentage.html.
  • fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb-expected.txt.
  • fast/forms/range/slider-delete-while-dragging-thumb.html: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb.html.
  • fast/forms/range/slider-hit-testing-expected.txt: Copied from LayoutTests/fast/forms/slider-hit-testing-expected.txt.
  • fast/forms/range/slider-hit-testing.html: Copied from LayoutTests/fast/forms/slider-hit-testing.html.
  • fast/forms/range/slider-mouse-events-expected.txt: Copied from LayoutTests/fast/forms/slider-mouse-events-expected.txt.
  • fast/forms/range/slider-mouse-events.html: Copied from LayoutTests/fast/forms/slider-mouse-events.html.
  • fast/forms/range/slider-onchange-event-expected.txt: Copied from LayoutTests/fast/forms/slider-onchange-event-expected.txt.
  • fast/forms/range/slider-onchange-event.html: Copied from LayoutTests/fast/forms/slider-onchange-event.html.
  • fast/forms/range/slider-padding.html: Copied from LayoutTests/fast/forms/slider-padding.html.
  • fast/forms/range/slider-thumb-shared-style.html: Copied from LayoutTests/fast/forms/slider-thumb-shared-style.html.
  • fast/forms/range/slider-thumb-stylability.html: Copied from LayoutTests/fast/forms/slider-thumb-stylability.html.
  • fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/fast/forms/slider-transformed-expected.txt.
  • fast/forms/range/slider-transformed.html: Copied from LayoutTests/fast/forms/slider-transformed.html.
  • fast/forms/range/slider-zoomed-expected.txt: Copied from LayoutTests/fast/forms/slider-zoomed-expected.txt.
  • fast/forms/range/slider-zoomed.html: Copied from LayoutTests/fast/forms/slider-zoomed.html.
  • fast/forms/range/thumbslider-crash-expected.txt: Copied from LayoutTests/fast/forms/thumbslider-crash-expected.txt.
  • fast/forms/range/thumbslider-crash.html: Copied from LayoutTests/fast/forms/thumbslider-crash.html.
  • fast/forms/range/thumbslider-no-parent-slider.html: Copied from LayoutTests/fast/forms/thumbslider-no-parent-slider.html.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: Removed 'range' part.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'range' part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed 'range' part.
  • fast/forms/script-tests/input-valueasnumber-range.js: Removed.
  • fast/forms/slider-delete-while-dragging-thumb-expected.txt: Removed.
  • fast/forms/slider-delete-while-dragging-thumb.html: Removed.
  • fast/forms/slider-hit-testing-expected.txt: Removed.
  • fast/forms/slider-hit-testing.html: Removed.
  • fast/forms/slider-mouse-events-expected.txt: Removed.
  • fast/forms/slider-mouse-events.html: Removed.
  • fast/forms/slider-onchange-event-expected.txt: Removed.
  • fast/forms/slider-onchange-event.html: Removed.
  • fast/forms/slider-padding.html: Removed.
  • fast/forms/slider-thumb-shared-style.html: Removed.
  • fast/forms/slider-thumb-stylability.html: Removed.
  • fast/forms/slider-transformed-expected.txt: Removed.
  • fast/forms/slider-transformed.html: Removed.
  • fast/forms/slider-zoomed-expected.txt: Removed.
  • fast/forms/slider-zoomed.html: Removed.
  • fast/forms/thumbslider-crash-expected.txt: Removed.
  • fast/forms/thumbslider-crash.html: Removed.
  • fast/forms/thumbslider-no-parent-slider.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/range: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/range: Added.
  • platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.txt.
  • platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/chromium-linux/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-padding-expected.png.
  • platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-linux/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-linux/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/chromium-win/fast/forms/range: Added.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.txt.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.png.
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png.
  • platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/chromium-win/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-win/fast/forms/slider-padding-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/gtk/fast/forms/range: Added.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-range-expected.txt.
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/gtk/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png.
  • platform/gtk/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt.
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.png.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/gtk/fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-transformed-expected.txt.
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/gtk/fast/forms/slider-padding-expected.png: Removed.
  • platform/gtk/fast/forms/slider-padding-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-transformed-expected.txt: Removed.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/range: Added.
  • platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/mac-leopard/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-padding-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
  • platform/mac-leopard/fast/forms/slider-padding-expected.png: Removed.
  • platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/mac/fast/forms/range: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/mac/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png.
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.txt.
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/mac/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.png.
  • platform/mac/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt.
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.png.
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/mac/fast/forms/slider-padding-expected.png: Removed.
  • platform/mac/fast/forms/slider-padding-expected.txt: Removed.
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/mac/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/range: Added.
  • platform/qt/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/qt/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/qt/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/qt/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/qt/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/wk2/Skipped:
05:38 Changeset [93592] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually
https://bugs.webkit.org/show_bug.cgi?id=66672

Reviewed by Kenneth Rohde Christiansen.

Add the method animateContentIntoBoundariesIfNeeded() to move the content back into both scale and position boundaries.
This method is now used as the entry point for animations in order to avoid bugs regarding scale or position.

The existing animation methods were renamed accordingly for clarity and consistency with the updateContent methods.

  • UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):

  • UIProcess/qt/ViewportInteractionEngine.h:
05:21 Changeset [93591] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):

03:34 Changeset [93590] by abarth@webkit.org
  • 2 edits
    18 deletes in trunk/Source

Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739

Reviewed by Steve Block.

Now that Android shares more code with Chromium, we don't need these
Android-specific files.

Source/JavaScriptCore:

  • wtf/android: Removed.
  • wtf/android/AndroidThreading.h: Removed.
  • wtf/android/MainThreadAndroid.cpp: Removed.

Source/WebCore:

  • editing/android: Removed.
  • editing/android/EditorAndroid.cpp: Removed.
  • history/android: Removed.
  • history/android/AndroidWebHistoryBridge.h: Removed.
  • history/android/HistoryItemAndroid.cpp: Removed.
  • page/android: Removed.
  • page/android/DragControllerAndroid.cpp: Removed.
  • page/android/EventHandlerAndroid.cpp: Removed.
  • platform/network/android: Removed.
  • platform/network/android/AuthenticationChallenge.h: Removed.
  • platform/network/android/CookieJarAndroid.cpp: Removed.
  • platform/network/android/ProxyServerAndroid.cpp: Removed.
  • platform/network/android/ResourceError.h: Removed.
  • platform/network/android/ResourceHandleAndroid.cpp: Removed.
  • platform/network/android/ResourceLoaderAndroid.h: Removed.
  • platform/network/android/ResourceRequest.h: Removed.
  • platform/network/android/ResourceRequestAndroid.cpp: Removed.
  • platform/network/android/ResourceResponse.h: Removed.
  • platform/text/android: Removed.
  • platform/text/android/HyphenationAndroid.cpp: Removed.
  • platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.
02:59 Changeset [93589] by abarth@webkit.org
  • 1 edit
    28 deletes in trunk/Source/WebCore

Remove WebCore/platform/android
https://bugs.webkit.org/show_bug.cgi?id=66734

Reviewed by Steve Block.

This directory is not needed now that Android shares more code with
Chromium.

  • platform/android: Removed.
  • platform/android/ClipboardAndroid.cpp: Removed.
  • platform/android/ClipboardAndroid.h: Removed.
  • platform/android/CursorAndroid.cpp: Removed.
  • platform/android/DragDataAndroid.cpp: Removed.
  • platform/android/EventLoopAndroid.cpp: Removed.
  • platform/android/FileSystemAndroid.cpp: Removed.
  • platform/android/GeolocationServiceAndroid.cpp: Removed.
  • platform/android/GeolocationServiceAndroid.h: Removed.
  • platform/android/GeolocationServiceBridge.cpp: Removed.
  • platform/android/GeolocationServiceBridge.h: Removed.
  • platform/android/KeyEventAndroid.cpp: Removed.
  • platform/android/LanguageAndroid.cpp: Removed.
  • platform/android/LocalizedStringsAndroid.cpp: Removed.
  • platform/android/PlatformBridge.h: Removed.
  • platform/android/PlatformTouchEventAndroid.cpp: Removed.
  • platform/android/PlatformTouchPointAndroid.cpp: Removed.
  • platform/android/PopupMenuAndroid.cpp: Removed.
  • platform/android/RenderThemeAndroid.cpp: Removed.
  • platform/android/RenderThemeAndroid.h: Removed.
  • platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
  • platform/android/ScreenAndroid.cpp: Removed.
  • platform/android/ScrollViewAndroid.cpp: Removed.
  • platform/android/SearchPopupMenuAndroid.cpp: Removed.
  • platform/android/SharedTimerAndroid.cpp: Removed.
  • platform/android/SoundAndroid.cpp: Removed.
  • platform/android/SystemTimeAndroid.cpp: Removed.
  • platform/android/TemporaryLinkStubs.cpp: Removed.
  • platform/android/WidgetAndroid.cpp: Removed.
02:52 Changeset [93588] by abarth@webkit.org
  • 2 edits in trunk/Tools

webkitpy/common/config/build.py shouldn't mention non-existant Android directory
https://bugs.webkit.org/show_bug.cgi?id=66737

Reviewed by Steve Block.

This directory doesn't exist anymore now that the Android port shares
more code with Chromium.

  • Scripts/webkitpy/common/config/build.py:
02:47 Changeset [93587] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Adding a file that slipped from r93586.

  • inspector/generate-protocol-externs: Added.
02:33 Changeset [93586] by pfeldman@chromium.org
  • 10 edits
    2 adds in trunk

Web Inspector: generate protocol externs API for the front-end compilation.
https://bugs.webkit.org/show_bug.cgi?id=66677

Reviewed by Tony Gentilcore.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesText):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/compile-front-end.sh: Added.
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.setAttribute):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):

  • inspector/front-end/externs.js: Added.

(console.warn):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex.html:
02:32 Changeset [93585] by loislo@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for compile error on Windows for r93560.

  • runtime/SamplingCounter.h:
02:23 Changeset [93584] by pfeldman@chromium.org
  • 17 edits in trunk/Source/WebCore

Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656

Removes "this" usage in functions, does not define getters for offsets.

Reviewed by Tony Gentilcore.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):

  • inspector/front-end/Toolbar.js:

(WebInspector.ToolbarDropdown.prototype.show):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

  • inspector/front-end/inspector.js:

(Number.secondsToString):
(Number.bytesToString):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():

01:50 Changeset [93583] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.

  • fast/loader/document-destruction-within-unload-expected.txt:
  • fast/loader/document-destruction-within-unload.html:
01:43 Changeset [93582] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Unreviewed gardening.

  • platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.
01:25 Changeset [93581] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749

Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.

  • platform/qt/Skipped:

08/22/11:

22:45 Changeset [93580] by commit-queue@webkit.org
  • 5 edits in trunk

Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587

Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.

Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.

  • platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.
21:09 Changeset [93579] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

20:55 Changeset [93578] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745

Breaks layout tests (Requested by koz2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
  • accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.
19:53 Changeset [93577] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744

Does not compile on chromium canaries (Requested by jamesr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
19:53 Changeset [93576] by jamesr@google.com
  • 2 edits in branches/chromium/835/Source/WebCore

Chromium crash fix, just for this branch.

BUG=93824

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::paintLayerContents):

19:15 Changeset [93575] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
19:07 Changeset [93574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.

Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)

  • dom/Range.cpp:

(WebCore::Range::setEnd):

19:05 Changeset [93573] by abarth@webkit.org
  • 19 edits in trunk/Source/WebCore

Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741

Reviewed by Darin Adler.

PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness. These special
cases can be removed now that Android shares more code with Chromium.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • bindings/v8/ScriptCachedFrameData.cpp:
  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/V8GCController.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):

  • history/HistoryItem.h:
  • loader/cache/CachedFont.cpp:
  • platform/DragImage.h:
  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/Widget.h:
  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/NetworkingContext.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:
19:02 Changeset [93572] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.

Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.

This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_private.h:
18:35 Changeset [93571] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731

Reviewed by James Robinson.

The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
18:07 Changeset [93570] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark some tests on Mac as flakily crashing.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:03 Changeset [93569] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/835

Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser. Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky. In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it. Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

  • fast/loader/reload-zero-byte-plugin-expected.txt: Added.
  • fast/loader/reload-zero-byte-plugin.html: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7685041

17:49 Changeset [93568] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark some tests on Windows as flaky.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:43 Changeset [93567] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
https://bugs.webkit.org/show_bug.cgi?id=53191
<rdar://problem/8629478>

Reviewed by Geoff Garen.

Cannot test domain relaxing, we only have 127.0.0.1 and localhost.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): Added a FIXME about a difference with Firefox.

(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
Changed to fetch returnValue from the global object that's in the frame when the dialog is
dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
if the origin doesn't match opener origin (which the case with domain relaxing).
Re-added a security check for returnValue that got lost in r73829, so that we don't send the
result across origins. This matches Firefox.

  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion against a very confusing case that should no longer occur.
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive call to avoid changing life support timer behavior in this patch.
17:37 Changeset [93566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704

Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

17:24 Changeset [93565] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.

aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351

Source/WebCore:

Test: accessibility/aria-labelledby-overrides-aria-labeledby.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
  • accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.
17:14 Changeset [93564] by nduca@chromium.org
  • 10 edits in trunk/Source

Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::texImage2DResourceSafe):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::isResourceSafe):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):

  • src/GraphicsContext3DInternal.h:
17:05 Changeset [93563] by eric@webkit.org
  • 2 edits in trunk/Tools

Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script. If this doesn't
work we'll just live with the it hung for now.

Unreviewed.

  • EWSTools/start-queue.sh:
16:53 Changeset [93562] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,

in which case the serializer treats all expectations as unparsed.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
16:52 Changeset [93561] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728

Reviewed by Darin Adler.

Source/WebCore:

If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input. If
the future input is small enough, that will walk off the end of the
input and crash.

Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

LayoutTests:

Test that we don't crash when we get a bad network packet boundary.

  • http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
  • http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
  • http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
16:41 Changeset [93560] by fpizlo@apple.com
  • 7 edits
    2 adds in trunk/Source/JavaScriptCore

Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724

Reviewed by Darin Adler.

Moved SamplingCounter to a separate header in runtime/.

  • GNUmakefile.list.am:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/SamplingTool.cpp:
  • bytecode/SamplingTool.h:
  • runtime/SamplingCounter.cpp: Added.

(JSC::AbstractSamplingCounter::dump):

  • runtime/SamplingCounter.h: Added.

(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):

16:34 Changeset [93559] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721

Reviewed by Ryosuke Niwa.

bidiNext and bidiFirst are horribly confusing.
Even worse is that bidiNext takes a bunch of mutually exclusive options.
It appears that there is a "return me every inline, even if its empty"
mode which is only used for simplified inline layout in RenderBlock.cpp.
To support that mode, there is a endOfInline pointer which keeps track
of if we just returned at the end of an inline to so we don't get stuck in
and empty inline (unable to distinguish the start from the finish).

The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.)

This change renames bidiNext to bidiNextShared (still a horrible name) and moves
all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
It becomes obvious which code uses which.

In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.

No functional change, thus no tests.

  • rendering/InlineIterator.h:

(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
(WebCore::bidiFirstIncludingEmptyInlines):
(WebCore::InlineWalker::InlineWalker):
(WebCore::InlineWalker::advance):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

16:30 Changeset [93558] by levin@chromium.org
  • 6 edits in trunk/Source/WebCore

Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725

Reviewed by Darin Adler.

No new functionality exposed so no new tests.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent): Ditto.

  • bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage): Ditto.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create): Ditto.

  • workers/SharedWorkerContext.cpp:

(WebCore::createConnectEvent): Added release() when a RefPtr is returned.

16:24 Changeset [93557] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648

Reviewed by Dan Bernstein.

No new tests / no functionality changed.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

16:15 Changeset [93556] by pkasting@chromium.org
  • 11 edits
    6 deletes in trunk

Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143

Broke Leopard, SnowLeopard, and Chromium Mac bots

Source/WebCore:

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

LayoutTests:

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
16:08 Changeset [93555] by oliver@apple.com
  • 7 edits in trunk/Source/WebKit2

Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717

Reviewed by Anders Carlsson.

Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::releaseObject):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:

(WebKit::trySafeReleaseNPObject):

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
16:08 Changeset [93554] by tony@chromium.org
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Move chromium-mac/plugins/keyboard-events-expected.txt to
chromium-cg-mac/plugins/keyboard-events-expected.txt since the results
for chromium-mac are currently in chromium-cg-mac. This result was
added in r93519 and put in the wrong place.

  • platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt.
  • platform/chromium-mac/plugins: Removed.
  • platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed.
15:44 Changeset [93553] by adamk@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711

Reviewed by Tony Chang.

The Chromium side of this patch was submitted as
http://crrev.com/97687.

  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:

(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

15:35 Changeset [93552] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Update unit test expectations after r93530.

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
15:20 Changeset [93551] by tony@chromium.org
  • 14 edits in trunk

Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701

Reviewed by Eric Seidel.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
15:08 Changeset [93550] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722

Reviewed by Darin Adler.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):

  • UIProcess/API/mac/WKViewInternal.h:
15:01 Changeset [93549] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
because r93529 didn't fix it. The failure is still tracked by the bug 66514.

  • platform/qt/Skipped:
14:56 Changeset [93548] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:49 Changeset [93547] by tony@chromium.org
  • 6 edits
    2 adds in trunk

handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/002.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is

auto, treat it as flex(1 0 0).

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.

LayoutTests:

  • css3/flexbox/002-expected.txt: Added.
  • css3/flexbox/002.html: Added.
  • css3/flexbox/resources/flexbox.js:

(checkHorizontalBoxen):

14:46 Changeset [93546] by msaboff@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464

Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

14:45 Changeset [93545] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
14:38 Changeset [93544] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use -[NSApplication updateWindows] to update the current input context
https://bugs.webkit.org/show_bug.cgi?id=66715

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:35 Changeset [93543] by andersca@apple.com
  • 19 edits in trunk/Source/WebKit2

The UI process should keep track of whether a plug-in has focus or not
https://bugs.webkit.org/show_bug.cgi?id=66712

Reviewed by Darin Adler.

This is in preparation for implementing the updated Cocoa text input model.

Pipe through whether a plug-in and its containing window has focus or not, from the
plug-in process and all the way to the UI process.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/PluginView.h:
14:23 Changeset [93542] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696

Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

14:13 Changeset [93541] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Disable compositing tests for Leopard.

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
14:07 Changeset [93540] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703

This error was detected by the debug build of the Chromium WebKit
Canary.

Reviewed by James Robinson.

No new tests. This change suppresses a compile-time warning
but does not affect the generated code.

  • platform/graphics/mac/FontCustomPlatformData.h:

Replaced struct with class in a forward reference.

14:05 Changeset [93539] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Update the current NSTextInputContext whenever the plug-in complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66709

Reviewed by Sam Weinig.

Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input
context. Fixes a rare case when the out-of-line editing window wouldn't appear.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:04 Changeset [93538] by commit-queue@webkit.org
  • 11 edits
    6 adds in trunk

[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html

fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

  • rendering/RenderFlowThread.h:

(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
13:53 Changeset [93537] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.

  • DEPS: Done it.
13:45 Changeset [93536] by levin@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Darin Adler.

Added tests which are similar to the non worker test with the same name.

  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added.
  • http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added.
  • http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added.
13:39 Changeset [93535] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to 97698.

  • DEPS: Rolled.
13:38 Changeset [93534] by jamesr@google.com
  • 1 edit
    1 move in trunk/LayoutTests

[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac

  • platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac.
  • platform/chromium-gpu-mac: Removed.
13:34 Changeset [93533] by jam@chromium.org
  • 5 edits in branches/chromium/835/Source

Merge 93296 - Prepare frames for history navigation.

Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.

https://bugs.webkit.org/show_bug.cgi?id=66322

Reviewed by Darin Fisher.

Source/WebCore:

No new tests, as history navigation is very difficult to test in
DumpRenderTree.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForHistoryNavigation):

  • loader/FrameLoader.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):

TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/7711011

13:23 Changeset [93532] by pkasting@chromium.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r93517.
http://trac.webkit.org/changeset/93517
https://bugs.webkit.org/show_bug.cgi?id=63553

Breaks GTK Linux and Chromium Win

Source/WebCore:

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Removed.
  • svg/animations/animate-end-attribute.html: Removed.
  • svg/animations/script-tests/animate-end-attribute.js: Removed.
13:05 Changeset [93531] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-22
Reviewed by Darin Adler.

setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):

12:35 Changeset [93530] by jamesr@google.com
  • 4 edits in trunk/Tools

[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693

Reviewed by Dirk Pranke.

Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.

  • Scripts/webkitpy/layout_tests/port/builders.py:
12:12 Changeset [93529] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551

Reviewed by Adam Roben.

Replaced leapForward by dummy clicks to make it work on Windows and other ports.

  • editing/selection/caret-at-bidi-boundary.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:08 Changeset [93528] by tony@chromium.org
  • 13 edits in trunk

Add CSS parsing of -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=65384

Source/WebCore:

The property is an int described here:
http://dev.w3.org/csswg/css3-flexbox/#flex-order

Doesn't do anything yet, just hooking it up.

Reviewed by Ojan Vafai.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexOrder):
(WebCore::InheritedFlags::setFlexOrder):
(WebCore::InheritedFlags::initialFlexOrder):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/script-tests/css-properties.js:
12:03 Changeset [93527] by dpranke@chromium.org
  • 2 edits in trunk/Tools

fix the GPU bot names on the layout test dashboard
https://bugs.webkit.org/show_bug.cgi?id=66697

Reviewed by Dimitri Glazkov.

  • TestResultServer/static-dashboards/builders.js:
11:49 Changeset [93526] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691

Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::protectTileTextures):

11:30 Changeset [93525] by kerz@chromium.org
  • 4 edits in branches/chromium/835/Source/WebCore

Merge 93042 - Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7708013

11:28 Changeset [93524] by kerz@chromium.org
  • 4 edits in branches/chromium/835

Merge 92764 - Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
https://bugs.webkit.org/show_bug.cgi?id=65918

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-commit-editing.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/7708012

11:18 Changeset [93523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Content and render surface textures not freed when compositor context destroyed
https://bugs.webkit.org/show_bug.cgi?id=66589

Patch by James Robinson <jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

Explicitly delete all managed textures when destroying the compositor
context. This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.

We sadly don't have a way to construct automated tests for resource
leaks currently.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::cleanupSharedObjects):

11:15 Changeset [93522] by dglazkov@chromium.org
  • 6 edits in trunk/Tools

garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
11:12 Changeset [93521] by japhet@chromium.org
  • 3 edits
    4 adds in trunk

Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741

Reviewed by Adam Barth.

Test: fast/loader/document-destruction-within-unload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): Prevent unload events

from going into infinite recursion.

(WebCore::FrameLoader::setDocumentLoader): Ensure we don't

let set m_documentLoader to a DocumentLoader with a null Frame*.

(WebCore::FrameLoader::detachChildren): Save off a vector of

children to detach, rather than doing it inline.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.

Reviewed by Adam Barth.

  • fast/loader/document-destruction-within-unload-expected.txt: Added.
  • fast/loader/document-destruction-within-unload.html: Added.
  • fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
  • fast/loader/resources/document-destruction-within-unload.svg: Added.
11:07 Changeset [93520] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Skip rtl-composited, as it causes other tests to crash.

Unreviewed expectation change.

  • platform/chromium/test_expectations.txt:
11:06 Changeset [93519] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.

Update the Chromium Linux test results following r88712. Also rebaseline test results
for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events. The Chromium port reports the actual line number, hence
the need for separate test results for Chromium. The test now runs, and passes on all
the Chromium ports, following r87855. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 34936.

  • platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
  • platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:03 Changeset [93518] by commit-queue@webkit.org
  • 4 edits
    3 moves
    2 deletes in trunk/LayoutTests

Rebaseline for webkit bug 65295
https://bugs.webkit.org/show_bug.cgi?id=66637

Patch by Ben Wells <benwells@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

  • fast/box-shadow/box-shadow-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt.
  • fast/layers/self-painting-outline-expected.txt: Renamed from LayoutTests/platform/gtk/fast/layers/self-painting-outline-expected.txt.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.png: Renamed from LayoutTests/fast/box-shadow/box-shadow-radius-expected.png.
  • platform/mac/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
11:00 Changeset [93517] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Young Han Lee <joybro@company100.net> on 2011-08-22
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

10:49 Changeset [93516] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Fix build error when inspector is disabled.
https://bugs.webkit.org/show_bug.cgi?id=66644

Reviewed by Darin Adler.

  • inspector/InspectorDatabaseResource.h: Add ENABLE(INSPECTOR) macro.
10:49 Changeset [93515] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):
(buildChromium):

10:33 Changeset [93514] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678

Source/WebCore:

RefPtr the focusable node to prevent getting deleted by mutation
event.

Reviewed by Dave Hyatt.

Test: fast/frames/focus-controller-crash-change-event.html

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/frames/focus-controller-crash-change-event-expected.txt: Added.
  • fast/frames/focus-controller-crash-change-event.html: Added.
10:07 Changeset [93513] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Some GTK+-specific font-face tests fail on the bots
https://bugs.webkit.org/show_bug.cgi?id=65820

Fix the timing issues in this test.

Reviewed by Philippe Normand.

  • platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until

after document.readyState moves to "complete" and a short timeout.

  • platform/gtk/fonts/font-face-with-complex-text.html: Ditto.
09:02 Changeset [93512] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Replacing the crash with a more graceful failure: canvas
will not render.

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
This is the non-crashing version of the factory function.
It returns NULL if allocation fails. Code for handling
NULL pointer was already in place.

Source/WebKit/chromium: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

  • DEPS:

Bumping up the chrome DEPS to pick up 97474, which is
required by this patch.

08:52 Changeset [93511] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add myself to the contributor list.
https://bugs.webkit.org/show_bug.cgi?id=66674

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-22
Reviewed by Tony Gentilcore.

  • Scripts/webkitpy/common/config/committers.py:
08:36 Changeset [93510] by loislo@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670

jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm:

(GenerateInterface):
(generateBackendStubJS):

  • inspector/front-end/ApplicationCacheItemsView.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineDispatcher):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):

  • inspector/front-end/inspector.js:
08:17 Changeset [93509] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299

Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/qt/ImageDiff.cpp:

(main):

06:43 Changeset [93508] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[NRWT] Fix "Only unexpected results" option of results.html
https://bugs.webkit.org/show_bug.cgi?id=66657

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

  • fast/harness/results.html:
06:26 Changeset [93507] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix generate-inspector-idl for Python3 after r93396
https://bugs.webkit.org/show_bug.cgi?id=66663

Reviewed by Andreas Kling.

In Python3, print is a function instead of a language keyword. Using parentheses
around the argument ensures the code works for both Python 2 and 3.

  • inspector/generate-inspector-idl:
05:22 Changeset [93506] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-22 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
05:06 Changeset [93505] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
https://bugs.webkit.org/show_bug.cgi?id=66649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-22
Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • http/tests/websocket/tests/hybi/close-before-open.html:

Add new URL to reproduce the problem.

05:03 Changeset [93504] by ossy@webkit.org
  • 2 edits in trunk/Tools

Update contributor list.

Reviewed by Zoltan Herczeg.

  • Scripts/webkitpy/common/config/committers.py:
04:53 Changeset [93503] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.

  • html/ColorInputType.h:
03:05 Changeset [93502] by ossy@webkit.org
  • 2 edits in trunk/Tools

[ORWT] Fix --reset-results --add-platform-exceptions combo
https://bugs.webkit.org/show_bug.cgi?id=65464

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
02:17 Changeset [93501] by podivilov@chromium.org
  • 8 edits
    3 adds in trunk

Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/breakpoint-manager.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Added.

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get rawSourceCode):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Added.
  • inspector/debugger/breakpoint-manager.html: Added.
02:09 Changeset [93500] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARM] Add bug report to flaky tests

http/tests/cache/subresource-multiple-instances.html
https://bugs.webkit.org/show_bug.cgi?id=66652

http/tests/inspector/resource-tree/resource-tree-errors-reload.html
https://bugs.webkit.org/show_bug.cgi?id=66653

  • platform/qt-arm/Skipped:
02:07 Changeset [93499] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/835

Merge 93347
BUG=90357
Review URL: http://codereview.chromium.org/7696023

02:04 Changeset [93498] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 93032
BUG=92769
Review URL: http://codereview.chromium.org/7693023

01:56 Changeset [93497] by cevans@google.com
  • 6 edits
    3 copies in branches/chromium/835

Merge 93227
BUG=92959
Review URL: http://codereview.chromium.org/7694026

01:49 Changeset [93496] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 92132
BUG=89991
Review URL: http://codereview.chromium.org/7693022

01:39 Changeset [93495] by cevans@google.com
  • 2 edits in branches/chromium/835

Merge 93397
BUG=76771
Review URL: http://codereview.chromium.org/7697013

01:05 Changeset [93494] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARM] Skip flaky tests.

  • platform/qt-arm/Skipped:

08/21/11:

21:04 Changeset [93493] by jamesr@google.com
  • 6 edits in branches/chromium/835/Source/WebCore

Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063

Reviewed by Darin Fisher.

Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.

Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.

Patch originally by Tom Hudson.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

BUG=93558
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7696019

18:10 Changeset [93492] by mrobinson@webkit.org
  • 5 edits in trunk/Source

Fix 'make dist' for WebKitGTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add a missing header to the sources list.

Source/WebCore:

  • GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
  • GNUmakefile.list.am: Update the sources list to reflect reality.
13:22 Changeset [93491] by darin@apple.com
  • 14 edits in trunk/LayoutTests

Update results for more tests affected by the addition of the
HTMLSourceElement class.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
08:53 Changeset [93490] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fixes premature plugin unload bug
https://bugs.webkit.org/show_bug.cgi?id=66628

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.

The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.

  • WebCoreSupport/TextCheckerClientQt.cpp:

(WebCore::TextCheckerClientQt::loadSpellChecker):

  • WebCoreSupport/TextCheckerClientQt.h:

08/20/11:

23:26 Changeset [93489] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 93382 - REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/placeholder-crash-with-scrollbar-corner.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.

LayoutTests:

  • fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
  • fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.

TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/7703003

22:27 Changeset [93488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

  • ewk/ewk_view.h:

Fixes description of method, parameters and returned value of API
related to settings.

22:21 Changeset [93487] by ddkilzer@apple.com
  • 5 edits in trunk

JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Changed the handling of const to add the dynamic scope depth.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ConstDeclNode::emitCodeSingle):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Added tests that reproduce the failure.

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:

(tryCatch1):
(tryCatch2):
(with1):
(with2):

22:14 Changeset [93486] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.

  • ewk/ewk_view.h:
21:50 Changeset [93485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.

  • ewk/ewk_view.h:
21:37 Changeset [93484] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

Covered by existing tests, and no code was changed.

  • WebCore.gyp/WebCore.gyp:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createNewContext):

Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

  • DEPS:
13:37 Changeset [93483] by abarth@webkit.org
  • 7 edits
    2 adds in trunk/Tools

garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625

Reviewed by Dimitri Glazkov.

This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction. The
patch also adds an Examine button to failure notifications. In a
future patch, I'll add a controller that wires this button up to
something useful.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
11:40 Changeset [93482] by commit-queue@webkit.org
  • 14 edits in trunk

instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.

Source/WebCore:

Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):

  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.idl:

LayoutTests:

Updated test results after adding HTMLSourceElement to the DOMWindow

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
11:11 Changeset [93481] by darin@apple.com
  • 9 edits
    2 adds in trunk

If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/dom/Range/insertNode-empty-fragment-crash.html

  • dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion

if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.

LayoutTests:

  • fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
  • fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
08:54 Changeset [93480] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624

Reviewed by Dimitri Glazkov.

This patch creates a notification-based UI for build failures. The new
UI displays the same information that used to be displayed in the
infobar. There's lots of room for improvement in surfacing more
information, but this is a start.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
05:27 Changeset [93479] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening.

  • platform/wk2/Skipped: Skip dependent test.
05:15 Changeset [93478] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626

Unreviewed gardening.

  • platform/qt/Skipped:
00:30 Changeset [93477] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.

Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):

LayoutTests:

Added test case covering keySpline array length problem.

  • svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.

08/19/11:

23:32 Changeset [93476] by commit-queue@webkit.org
  • 8 edits
    3 deletes in trunk

Unreviewed, rolling out r93415.
http://trac.webkit.org/changeset/93415
https://bugs.webkit.org/show_bug.cgi?id=66623

Introduces failing test (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Removed.
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/SourceFile.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Removed.
  • inspector/debugger/breakpoint-manager.html: Removed.
23:19 Changeset [93475] by rniwa@webkit.org
  • 2 edits
    2 copies
    2 deletes in trunk/LayoutTests

Chromium Windows and Linux rebaselines. These baselines were so wrong.

  • platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:

Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.

  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.

  • platform/chromium/test_expectations.txt:
21:32 Changeset [93474] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r93369 on GTK; the failure is tracked by the bug 66621.

  • platform/gtk/Skipped:
21:27 Changeset [93473] by rniwa@webkit.org
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Remove the left over from r93468; also fix Chromium Windows expectation
(Copied it over from fast/css/getComputedStyle/ and replaced Times with 'times new roman')

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
20:41 Changeset [93472] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r93392 on Windows; the failure is tracked by the bug 66620.

  • platform/win/Skipped:
20:36 Changeset [93471] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

More rebaseline after r93068. Apparently Windows XP needs a separate baseline.

  • platform/win-xp/editing: Added.
  • platform/win-xp/editing/deleting: Added.
  • platform/win-xp/editing/deleting/regional-indicators-expected.txt: Added.
20:29 Changeset [93470] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

Redo the rebaseline done by r93353. The test that has been failing on GTK is
editing/deleting/regional-indicators.html, not editing/selection/regional-indicators.

The failure is still tracked by the bug 66501.

  • platform/gtk/editing/deleting/regional-indicators-expected.txt: Copied from

LayoutTests/platform/gtk/editing/selection/regional-indicators-expected.txt.

  • platform/gtk/editing/selection/regional-indicators-expected.txt: Removed.
20:19 Changeset [93469] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r93392 on Qt. The failure is tracked by the bug 66619.

  • platform/qt/Skipped:
20:12 Changeset [93468] by rniwa@webkit.org
  • 1 edit
    1 copy
    4 deletes in trunk/LayoutTests

Rebaseline after r93430. Also removed superfluous expected result from Chromium directories.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced with

LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

  • platform/chromium-cg-mac/fast/css/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt: Removed.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
19:59 Changeset [93467] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617

Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.

Reviewed by Antonio Gomes.

  • heap/MachineStackMarker.cpp:
19:17 Changeset [93466] by fpizlo@apple.com
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

The JSC JIT currently has no facility to profile and report
the types of values
https://bugs.webkit.org/show_bug.cgi?id=65901

Reviewed by Gavin Barraclough.

Added the ability to profile the values seen at function calls (both
arguments and results) and heap loads. This is done with emphasis
on performance. A value profiling site consists of: add, and,
move, and store; no branching is necessary. Each value profiling
site (called a ValueProfile) has a ring buffer of 8 recently-seen
values. ValueProfiles are stored in the CodeBlock; there will be
one for each argument (excluding this) and each heap load or callsite.
Each time a value profiling site executes, it stores the value into
a pseudo-random element in the ValueProfile buffer. The point is
that for frequently executed code, we will have 8 somewhat recent
values in the buffer and will be able to not only figure out what
type it is, but also to be able to reason about the actual values
if we wish to do so.

This feature is currently disabled by default. When enabled, it
results in a 3.7% slow-down on SunSpider.

(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::numberOfValueProfiles):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):

  • bytecode/ValueProfile.h: Added.

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::computeProbability):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::probabilityOfInt32):
(JSC::ValueProfile::probabilityOfDouble):
(JSC::ValueProfile::probabilityOfCell):
(JSC::getValueProfileBytecodeOffset):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITCall.cpp:

(JSC::JIT::emit_op_call_put_result):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):

  • jit/JSInterfaceJIT.h:
  • wtf/Platform.h:
  • wtf/StdLibExtras.h:

(WTF::binarySearch):
(WTF::genericBinarySearch):

18:55 UsingGitWithWebKit edited by dpranke@chromium.org
Update the git instructions so that git-svn and git update the same branch … (diff)
18:47 Changeset [93465] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Don't include DisallowCType.h when building on QNX
https://bugs.webkit.org/show_bug.cgi?id=66616

Reviewed by Antonio Gomes.

  • config.h:
18:46 Changeset [93464] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r93369 because Window's DRT actually sleeps for
the amount of time leapForward is called upon. The failure is tracked by the bug 66551.

  • platform/win/Skipped:
18:31 Changeset [93463] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606

Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.

The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:17 Changeset [93462] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611

Reviewed by Antonio Gomes.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

18:14 Changeset [93461] by cfleizach@apple.com
  • 4 edits in trunk/Source/WebCore

AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes
https://bugs.webkit.org/show_bug.cgi?id=61289

Update the code to determine the position of accessibility elements on Mac for WK2,
so that elements within iframes are positioned correctly.

Reviewed by Darin Adler..

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::page):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

17:45 Changeset [93460] by jpfau@apple.com
  • 4 edits in trunk/Source/WebCore

New XML parser: text nodes outside of root element not created for document fragments
https://bugs.webkit.org/show_bug.cgi?id=66604

When intializing a fragment parser, declare that the first element has been seen. Also, flush the text nodes when finishing parsing a document.

Reviewed by Darin Adler.

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::finish):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::finish):

  • xml/parser/XMLTreeBuilder.h:
17:41 Changeset [93459] by jeffm@apple.com
  • 3 edits in trunk/Source/WebCore

MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=66612

Reviewed by Darin Adler.

No new tests, should be covered by existing media tests.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.

17:20 Changeset [93458] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Another attempt at fixing the Windows build.

  • UIProcess/PageClient.h:
16:59 Changeset [93457] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Fix for mis-merge. Radar 9750868

16:56 Changeset [93456] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • WebProcess/Plugins/PluginController.h:
16:54 Changeset [93455] by jamesr@google.com
  • 2 edits
    4 adds in trunk/LayoutTests

[chromium] GPU test expectation baseline update

Update pixel baselines for this test on mac and linux.

  • platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:50 Changeset [93454] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Regression: Fix clang errors from r93424
https://bugs.webkit.org/show_bug.cgi?id=66609

Reviewed by James Robinson.

The invalidateRect function does not appear to be used anywhere
because the setNeedsDisplay function is used instead. Fix the Clang
error by just removing this unused vestigial base class function.

  • platform/graphics/chromium/LayerChromium.h:
16:45 Changeset [93453] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add new enums to npapi.h
https://bugs.webkit.org/show_bug.cgi?id=66608

Reviewed by Sam Weinig.

  • bridge/npapi.h:
16:37 Changeset [93452] by jpfau@apple.com
  • 4 edits
    3 adds in trunk

libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Reviewed by Darin Adler.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Reviewed by Darin Adler.

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
16:24 Changeset [93451] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r93426.
http://trac.webkit.org/changeset/93426
https://bugs.webkit.org/show_bug.cgi?id=66607

Broke the Mac build by not building gtest.framework anymore
(Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/ThirdParty:

  • gtest/README.WebKit:
  • gtest/include/gtest/internal/gtest-port.h:
  • gtest/msvc/gtest-md.vcproj:
  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:
16:22 Changeset [93450] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Implement WTF::atomic{Increment, Decrement}() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66605

Reviewed by Darin Adler.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

16:18 Changeset [93449] by adamk@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Remove various unreferenced bits from Chromium API headers
https://bugs.webkit.org/show_bug.cgi?id=66575

Reviewed by Tony Chang.

  • public/WebApplicationCacheHost.h:

(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):

  • public/WebFrame.h:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didReceiveTitle):

  • public/WebVideoFrame.h:
15:53 Changeset [93448] by tony@chromium.org
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

[chromium] Cleanup some old plugin tests. Rebase plugin-javascript-access.html
on win and run plugin-initiate-popup-window on mac/linux to get results.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/win/plugins/plugin-javascript-access-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/plugin-javascript-access-expected.txt.
15:50 Changeset [93447] by andersca@apple.com
  • 23 edits
    2 adds in trunk/Source/WebKit2

Make the complex text input state a tri-state enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=62245

Reviewed by Sam Weinig.

This is to prepare the infrastructure for supporting the updated Cocoa text input model for plug-ins.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):
(WebKit::PluginControllerProxy::compositingRenderServerPort):

  • Shared/Plugins/mac: Added.
  • Shared/Plugins/mac/PluginComplexTextInputState.h: Added.

(WebKit::isValidPluginComplexTextInputState):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPluginComplexTextInputState):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPluginComplexTextInputState):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::setComplexTextInputEnabled):

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::setComplexTextInputState):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):
(WebKit::PluginView::setComplexTextInputState):
(WebKit::PluginView::compositingRenderServerPort):

  • WebProcess/Plugins/PluginView.h:
15:38 Changeset [93446] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium test expectations

Remove = CRASH expectations for tests fixed by r93441.

  • platform/chromium/test_expectations.txt:
15:34 Changeset [93445] by bdakin@apple.com
  • 9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=66590
Re-name scrollbar painter types

Reviewed by Sam Weinig.

Source/JavaScriptCore:

WTF_USE_WK_SCROLLBAR_PAINTER is now WTF_USE_SCROLLBAR_PAINTER since WK no longer
applies.

  • wtf/Platform.h:

Source/WebCore:

Names changed to remove references to WebKitSystemInterface since the
implementation is now in WebCore. And the type names changed to be more Objective-
Cish instead of C++ish
WTF_USE_WK_SCROLLBAR_PAINTER -> WTF_USE_SCROLLBAR_PAINTER
WKScrollbarPainterRef -> ScrollbarPainter
WKScrollbarPainterControllerRef -> ScrollbarPainterController

  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollbarOverlayStyle):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

15:26 Changeset [93444] by jamesr@google.com
  • 3 edits in trunk/Tools

[chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
https://bugs.webkit.org/show_bug.cgi?id=66603

Reviewed by Dirk Pranke.

The various ChromiumGpu ports should use the same child worker
selection logic as other ports so they can run with full
parallelization on multicore systems.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
15:20 Changeset [93443] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
https://bugs.webkit.org/show_bug.cgi?id=66499

Patch by Van Lam <vanlam@google.com> on 2011-08-19
Reviewed by Ryosuke Niwa.

Renamed VisiblePosition::honorEditableBoundary* to
honorEditingBoundary.

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):

  • editing/VisiblePosition.h:
  • editing/visible_units.cpp:

(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

15:12 Changeset [93442] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] Update results for japanese-rl-selection-repaint-in-regions.html that
changed after r93428.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
14:50 Changeset [93441] by jamesr@google.com
  • 6 edits in trunk/Source/WebCore

REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063

Reviewed by Darin Fisher.

Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.

Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.

Patch originally by Tom Hudson.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

14:40 Changeset [93440] by eae@chromium.org
  • 14 edits in trunk/Source/WebCore

Switch clipping for svg to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66586

Reviewed by Eric Seidel.

No new tests as no new functionality.

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:

(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/svg/RenderSVGText.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

  • svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
(WebCore::SVGImage::setContainerSize):

  • svg/graphics/SVGImage.h:
14:37 Changeset [93439] by commit-queue@webkit.org
  • 5 edits
    16 deletes in trunk

Unreviewed, rolling out r93425.
http://trac.webkit.org/changeset/93425
https://bugs.webkit.org/show_bug.cgi?id=66591

"The newly-added ASSERT is being triggered on several bots"
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/WebCore:

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabled):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::disabled):

  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isEnabledViaScript):

LayoutTests:

  • fast/css/link-disabled-attr-expected.txt:
  • fast/css/stylesheet-enable-first-alternate-expected.txt: Removed.
  • fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Removed.
  • fast/css/stylesheet-enable-first-alternate-on-load.html: Removed.
  • fast/css/stylesheet-enable-first-alternate.html: Removed.
  • fast/css/stylesheet-enable-second-alternate-expected.txt: Removed.
  • fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Removed.
  • fast/css/stylesheet-enable-second-alternate-on-load.html: Removed.
  • fast/css/stylesheet-enable-second-alternate.html: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Removed.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Removed.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Removed.
  • http/tests/css/resources/slow-loading-sheet-in-error.php: Removed.
  • http/tests/css/resources/slow-loading-sheet.php: Removed.
14:24 Changeset [93438] by enne@google.com
  • 11 edits in trunk/Source/WebCore

[chromium] Refactor updateCompositorResources to take an explicit GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=66432

Reviewed by James Robinson.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.h:
14:12 Changeset [93437] by vrk@chromium.org
  • 3 edits
    2 adds in trunk

Tell media player to prepareToPlay() at end of HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-load-preload-none.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):

LayoutTests:

  • media/video-load-preload-none-expected.txt: Added.
  • media/video-load-preload-none.html: Added.
13:57 Changeset [93436] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66502

Reviewed by Eric Seidel.

Convert RenderBlock to new layout abstraction. Leave m_lineHight as a 30
bit int for now to avoid unnecessarily increasing the memory usage.

No new tests as no new functionality.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
13:40 Changeset [93435] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch RenderBoxModelObject to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66534

Reviewed by Eric Seidel.

Convert RenderBoxModelObject to new layout abstraction.

No new tests as no new functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::set):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::backgroundRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::borderWillArcInnerEdge):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):

  • rendering/RenderBoxModelObject.h:
13:37 Changeset [93434] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Expose Fixed Layout Size mode to Chromium's WebKit API
https://bugs.webkit.org/show_bug.cgi?id=66568

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::isFixedLayoutModeEnabled):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setFixedLayoutSize):

  • src/WebViewImpl.h:
13:22 Changeset [93433] by alokp@chromium.org
  • 3 edits in trunk/Tools

[chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=66570

Reviewed by Mihai Parparita.

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:

(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):

  • DumpRenderTree/chromium/WebThemeControlDRTWin.h:
13:03 Changeset [93432] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSSRegions]Speed up RenderFlowThread repaint of regions
https://bugs.webkit.org/show_bug.cgi?id=66566

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.

When in printing or the repaint rectangle is empty, there is no need to iterate
the render flow regions in order to repaint.
Covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::shouldRepaint):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
12:44 Changeset [93431] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark touch tests as failing on OSX 10.5.

  • platform/chromium/test_expectations.txt:
12:27 Changeset [93430] by commit-queue@webkit.org
  • 13 edits in trunk

[CSSRegions]Parse -webkit-region-break(after, before, inside)
https://bugs.webkit.org/show_bug.cgi?id=66559

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionBreakBefore):
(WebCore::InheritedFlags::regionBreakInside):
(WebCore::InheritedFlags::regionBreakAfter):
(WebCore::InheritedFlags::setRegionBreakBefore):
(WebCore::InheritedFlags::setRegionBreakInside):
(WebCore::InheritedFlags::setRegionBreakAfter):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:26 Changeset [93429] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

Switch RenderLayer to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66507

Reviewed by Eric Seidel.

Convert RenderLayer to new layout abstraction.

No new tests as no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::flooredLayoutSize):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
12:19 Changeset [93428] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSSRegions]Content displayed in regions should not be scrollable
https://bugs.webkit.org/show_bug.cgi?id=66459

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by Darin Adler.

Source/WebCore:

Initially, when creating the style for the RenderFlowThread, overflowX and overflowY were both set to hidden,
so that RenderView did not display scrollbars when a RenderFlowThread exists. However, this allowed the possibility
of scrolling the content displayed in region.

Now, the RenderFlowThread objects are ignored in RenderBlock::insertPositionedObject and the style of the RenderFlowThread
can be set to visible, thus preventing scrolling of the content displayed in regions.

Test: fast/regions/content-flowed-into-regions-no-scroll.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):

LayoutTests:

  • fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-no-scroll.html: Added.
12:15 Changeset [93427] by caio.oliveira@openbossa.org
  • 13 edits
    3 adds in trunk/Source/WebKit2

[Qt] [WK2] Provide API for intercept (and possible ignore) links clicked in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65920

Reviewed by Benjamin Poulain.

This patch makes QDesktopWebView delegate the decision of whether a navigation
should proceed to a slot in QML. The user of the DesktopWebView must implement a
'navigationPolicyForUrl()' if it wants to use the feature.

Such feature is useful for implementing opening links in "new tab" by using a
specific mouse button or mouse button plus keyboard modifiers.

The patch introduces a internal Qt-level interface called PolicyInterface, that
is used by QtWebPageProxy to delegate policy calls. A concrete implementation is
provided for QDesktopWebView.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Implement the serialization of the Request URL, which is the only data
we exposing from the Request.

  • WebKit2.pro:
  • UIProcess/qt/PolicyInterface.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:

Register a Policy Client in the WK2 C API only if there's a PolicyInterface available.

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/ClientImpl.cpp:

(toPolicyInterface):
(toQtMouseButton):
(toQtKeyboardModifiers):
(qt_wk_decidePolicyForNavigationAction):
Implement the callback for the Page Policy Client. It will translate the
arguments to Qt jargon and call PolicyInterface.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::QDesktopWebPageProxy):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(toPolicyAction):
(hasMetaMethod):
(QDesktopWebViewPrivate::navigationPolicyForURL):
The concrete implementation for QDesktopWebView. Its private object implements
the PolicyInterface and try to call a possible function defined in QML (so return
value and arguments all QVariants). If there's no such a function, returns the
default UsePolicy, like if we haven't registered a PolicyClient in WK2 C API.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test2.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:

Add a test for DesktopWebView QML element making use of a button and a modifier to
ignore a navigation.

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
For now, we don't have a PolicyInterface for QTouchWebView.

12:08 Changeset [93426] by dslomov@google.com
  • 8 edits in trunk

TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.

Reviewed by David Levin.

  • gtest/include/gtest/internal/gtest-port.h:
  • gtest/msvc/gtest-md.vcproj:
  • gtest/README.WebKit:
  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:

Tools:

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=66521

Reviewed by David Levin.

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
11:54 Changeset [93425] by jchaffraix@webkit.org
  • 5 edits
    16 adds in trunk

REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140
<rdar://problem/9835905>

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-on-load.html

fast/css/stylesheet-enable-first-alternate.html
fast/css/stylesheet-enable-second-alternate-on-load.html
fast/css/stylesheet-enable-second-alternate.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

The gist of the issue is that we were ignoring calls to HTMLLinkElement::setDisabled that would enable a
style sheet when we were loading a stylesheet (m_sheet was 0 and thus ignored the call per the spec).

FF goes against the CSS OM spec in this case and always keep an associated sheet as long as 'rel' hints
at a stylesheet link and href is present. Instead of siding with FF, I continued to follow the
specification and store the enabled via javascript state into m_scriptState (renamed from
m_isEnabledViaScript). This information gets merged back into the style sheet disabled state when it is
available.

While debugging the case at hand, I found some cases that were not properly handled and were fixed as
part of this change.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setDisabled): Always call setIsEnabledViaScript so that
the information is properly stored (either for recalcStyleSelector or just to store
the state during loading).

(WebCore::HTMLLinkElement::sheetLoaded): Merge back the state from m_scriptState to
the sheet's disabled state.

(WebCore::HTMLLinkElement::disabled): Account for the temporary state and return the
right value. It matches FF and what people would expect.

(WebCore::HTMLLinkElement::areDisabledAndScriptStatesConsistent): Debug only method
that checks that disabled() and isEnabledViaScript() are consistent with each other
(under some circumstances).

  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isEnabledViaScript): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setIsEnabledViaScript): Added setter.

LayoutTests:

  • fast/css/link-disabled-attr-expected.txt: This change is a progression, but we are still

not handling updates to the selected style set properly (already covered by bug 62407).

  • fast/css/stylesheet-enable-first-alternate-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load.html: Added.
  • fast/css/stylesheet-enable-first-alternate.html: Added.
  • fast/css/stylesheet-enable-second-alternate-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load.html: Added.
  • fast/css/stylesheet-enable-second-alternate.html: Added.

Those are a variation on the same theme: we disable some stylesheet and enable others,
either directly or later.

  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
  • http/tests/css/resources/slow-loading-sheet.php: Added.

Those 2 test cases relies on a slow loading stylesheet so that we can test the disabled() value while the alternate
sheet is asynchronously loading and then check them again once the sheet is loaded.

11:07 Changeset [93424] by enne@google.com
  • 16 edits
    2 adds
    2 deletes in trunk/Source

[chromium] Split tiler into main thread / compositor thread versions
https://bugs.webkit.org/show_bug.cgi?id=66065

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

LayerTilerChromium is renamed to be CCLayerTilingData. Invalidation
and paint functionality is pushed into TiledLayerChromium and drawing
with GL is pushed into CCTiledLayerImpl. During tree synchronization,
the tiler properties and texture IDs are synchronized into
CCTiledLayerImpl.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::bestTextureFormat):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: Removed.
  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::textureId):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::dirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::dumpLayerProperties):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::tileAt):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateTiles):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectVisibleTileTextures):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp: Added.

(WebCore::CCLayerTilingData::create):
(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
(WebCore::CCLayerTilingData::reset):
(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::contentRectToLayerRect):
(WebCore::CCLayerTilingData::layerRectToContentRect):
(WebCore::CCLayerTilingData::tileContentRect):
(WebCore::CCLayerTilingData::tileLayerRect):
(WebCore::CCLayerTilingData::setLayerPosition):
(WebCore::CCLayerTilingData::growLayerToContain):

  • platform/graphics/chromium/cc/CCLayerTilingData.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h.

(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::numTilesX):
(WebCore::CCLayerTilingData::numTilesY):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::textureOffset):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::hasBorderTexels):
(WebCore::CCLayerTilingData::isEmpty):
(WebCore::CCLayerTilingData::Tile::Tile):
(WebCore::CCLayerTilingData::Tile::i):
(WebCore::CCLayerTilingData::Tile::j):
(WebCore::CCLayerTilingData::Tile::moveTo):
(WebCore::CCLayerTilingData::TileMapKeyTraits::emptyValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::constructDeletedValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::isDeletedValue):
(WebCore::CCLayerTilingData::tiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::DrawableTile):
(WebCore::DrawableTile::textureId):
(WebCore::DrawableTile::setTextureId):
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::tileAt):
(WebCore::CCTiledLayerImpl::createTile):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::setTilingData):
(WebCore::CCTiledLayerImpl::syncTextureId):
(WebCore::isCCW):
(WebCore::computeEdge):
(WebCore::intersect):
(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::setSkipsDraw):
(WebCore::CCTiledLayerImpl::setTextureOrientation):
(WebCore::CCTiledLayerImpl::setSampledTexelFormat):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium:

Add a test for assignment and copy constructor for TilingData.

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

10:51 Changeset [93423] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Cleaning up test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
10:47 Changeset [93422] by tony@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] Add correct baseline for merge-end-list.html on OSX 10.5.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Added.
09:29 Changeset [93421] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Better build fix after r93384.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use WTF::Unicode wrapper instead of ICU.

09:22 Changeset [93420] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WebProcess crashes during startup if libdispatch is initialized by WebProcessShim.dylib
https://bugs.webkit.org/show_bug.cgi?id=66508
<rdar://problem/9828476>

Reviewed by Mark Rowe.

  • mac/MainMac.cpp:

(closeUnusedFileDescriptors):
Check if a file descriptor is a kqueue and don't close it if that is the case. While this
isn't a complete fix, (it won't work if other initializers end up creating non-kqueue file descriptors)
it's good enough for Snow Leopard. For Lion, we should use the new posix_spawn API that lets you whitelist
file descriptors from the parent process.

09:17 Changeset [93419] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: update scope variables upon value changes via console.
https://bugs.webkit.org/show_bug.cgi?id=54720

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

09:16 Changeset [93418] by aroben@apple.com
  • 2 edits in trunk/Tools

Add project file changes I left out in r93417

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
09:14 Changeset [93417] by aroben@apple.com
  • 1 edit
    5 adds in trunk/Tools

Add a helper class for swizzling ObjC instance methods to TestWebKitAPI

Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
NSScreen

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.

(-[SimpleObject setValue:]): Original implementation.

(TestWebKitAPI::setValue2):
(TestWebKitAPI::setValue3):
Swizzled implementations.

(TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
instance method.

  • TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
  • TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.

(TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
(TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.

09:06 Changeset [93416] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix _path_to_apache() error reporting
https://bugs.webkit.org/show_bug.cgi?id=66486

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-19
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
08:50 Changeset [93415] by podivilov@chromium.org
  • 8 edits
    3 adds in trunk

Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/breakpoint-manager.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Added.

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get rawSourceCode):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Added.
  • inspector/debugger/breakpoint-manager.html: Added.
08:39 Changeset [93414] by aroben@apple.com
  • 2 edits in trunk/Tools

Windows build fix after r93404

  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
08:37 Changeset [93413] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Add leandrogracia to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66552

Also fix line endings in file.

No reviewed required.

  • Scripts/webkitpy/common/config/committers.py:
08:29 Changeset [93412] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix compilation issue in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66554

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-19
Reviewed by Martin Robinson.

  • WebKitTestRunner/PixelDumpSupport.cpp:
08:27 Changeset [93411] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Fix typo

  • dom/DOMAllInOne.cpp:
08:25 Changeset [93410] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
https://bugs.webkit.org/show_bug.cgi?id=65408

Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_add):

08:19 Changeset [93409] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028

As backing store's position and offset change can occur at the same time,
the checking of offset change shouldn't be "else if" statement.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_smart_calculate):

08:11 Changeset [93408] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix after r93385

  • dom/DOMAllInOne.cpp: Added EventDispatcMediator.cpp.
07:56 Changeset [93407] by commit-queue@webkit.org
  • 24 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Add a basic engine to control the content of the viewport
https://bugs.webkit.org/show_bug.cgi?id=66383

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-19
Reviewed by Andreas Kling.

Add ViewportInteractionEngine to handle the content of the viewport. The class make
sure the QTouchWebPage stays in the viewport and in the boundaries.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidCommit):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage): Set the transform origin to the top left so
we can asume the position 0, 0 is always the top left of the page.
(QTouchWebPagePrivate::_q_commitScaleChange): Make commitScaleChange a slot
in order to completely decouple the ViewportInteractionEngine and the WebKit classes.

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportRectUpdated): Make _q_viewportRectUpdated() a slot
for reducing coupling.
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebViewPrivate::setViewportArguments):
(QTouchWebView::geometryChanged):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didCommitLoadForFrame):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h: Change the gesture recognizer to talk directly

to the ViewportInteractionEngine instead of interacting through TouchViewInterface.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidCommit): Add the loadCommited callback in order
to reset the viewport state when the page change.

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::loadDidCommit):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/ViewportInteractionEngine.cpp: Added.

(WebKit::visibleRectInContentCoordinate):
(WebKit::contentRectInViewportCoordinate):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::reset):
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::panGestureStarted):
(WebKit::ViewportInteractionEngine::panGestureRequestScroll):
(WebKit::ViewportInteractionEngine::panGestureCancelled):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentGeometryChanged):
(WebKit::ViewportInteractionEngine::contentScaleChanged):
(WebKit::ViewportInteractionEngine::updateContentIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentScaleIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentPositionIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionToBoundaries):
(WebKit::ViewportInteractionEngine::animateContentScaleToBoundaries):
(WebKit::ViewportInteractionEngine::scaleContent):

  • UIProcess/qt/ViewportInteractionEngine.h: Added.

(WebKit::ViewportInteractionEngine::Constraints::Constraints):
(WebKit::operator==):

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
07:55 Changeset [93406] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:51 Changeset [93405] by aroben@apple.com
  • 3 edits
    1 copy
    1 add in trunk/Tools

Pull some of DynamicDeviceScaleFactor's code up into a shareable base class

This will make it easier to write other WebKit-agnostic tests

Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
code in other WebKit-agnostic tests

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of

code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
(TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
WebKitAgnosticTest handles for us.
(TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.

(TestWebKitAPI::WebKitAgnosticTest::loadSynchronously): Code came from
DynamicDeviceScaleFactor::runTest.

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.

(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
DynamicDeviceScaleFactor.WebKit.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
DynamicDeviceScaleFactor.WebKit2.

07:50 Changeset [93404] by aroben@apple.com
  • 46 edits in trunk/Tools

Clean up #includes in TestWebKitAPI

Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++

files and WebKit/WebKit.h for ObjC files.

  • TestWebKitAPI/InjectedBundleController.cpp:
  • TestWebKitAPI/JavaScriptTest.h:
  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  • TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/Find.cpp:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  • TestWebKitAPI/TestsController.cpp:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the

07:47 Changeset [93403] by vitalyr@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating baselines.

Unreviewed.

  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Added.
  • platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Added.
  • platform/chromium-cg-mac/editing/pasteboard/paste-text-008-expected.png: Added.
07:46 Changeset [93402] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
https://bugs.webkit.org/show_bug.cgi?id=66549

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-19
Reviewed by Benjamin Poulain.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::paint):

  • UIProcess/qt/QtWebPageProxy.h:
07:12 Changeset [93401] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-19
Reviewed by Kent Tamura.

Adds doxygen documentation to the structures in ewk_view.cpp.

  • ewk/ewk_view.cpp:
06:41 Changeset [93400] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Extensions API][chromium] webInspector.resources deprecation warning is given even for extensions that don't use webInspector.resources
https://bugs.webkit.org/show_bug.cgi?id=66553

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(WebInspector.platformExtensionAPI):

06:23 Changeset [93399] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Modify type of both col and row parameters for backing store's internal api.
https://bugs.webkit.org/show_bug.cgi?id=65302

As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill
and ewk_tiled_backing_store_item_add are different from each other, I modify type of them.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):

05:50 Changeset [93398] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: getAttributes should work on a single node, not array.
https://bugs.webkit.org/show_bug.cgi?id=66544

Reviewed by Adam Roben.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):

05:26 Changeset [93397] by antonm@chromium.org
  • 4 edits in trunk

[v8] CSS wrapper objects retention
https://bugs.webkit.org/show_bug.cgi?id=66377

Reviewed by Pavel Feldman.

Disable object grouping for CSS object wrappers.
This logic leads to hard to debug use-after-free problems.

Source/WebCore:

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

LayoutTests:

  • platform/chromium/test_expectations.txt:
05:23 Changeset [93396] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: introduce NodeId inherited from integer in the DOM domain description.
https://bugs.webkit.org/show_bug.cgi?id=66491

Drive-by rename of couple of DOM domain protocol methods.

Reviewed by Adam Roben.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::requestNode):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):

  • inspector/generate-inspector-idl:
05:13 Changeset [93395] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity.
https://bugs.webkit.org/show_bug.cgi?id=66470

Reviewed by Tony Gentilcore.

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::deleteObjectStore):

04:37 Changeset [93394] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369
https://bugs.webkit.org/show_bug.cgi?id=66514

Skip it.

  • platform/qt/Skipped:
03:16 Changeset [93393] by commit-queue@webkit.org
  • 13 edits
    6 adds in trunk

[WebSocket] CloseEvent's code and reason properties support.
https://bugs.webkit.org/show_bug.cgi?id=66362

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-19
Reviewed by Kent Tamura.

Current WebSocket implementation miss code and reason properties
in CloseEvent. This change expose incoming closing frame's code
and reason to JavaScript API.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html

http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::initCloseEvent):
(WebCore::CloseEvent::code):
(WebCore::CloseEvent::reason):
(WebCore::CloseEvent::CloseEvent):

  • websockets/CloseEvent.idl:

Add code and reason properies.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):

  • websockets/WebSocket.h:

Add implement to handle code and reason.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::processFrame):

  • websockets/WebSocketChannel.h:

Add closing frame payload parser.

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didClose):

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):

  • websockets/WorkerThreadableWebSocketChannel.h:

Add implement to handle code and reason.

LayoutTests:

  • http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-code-and-reason.html: Added.
  • http/tests/websocket/tests/hybi/close-code-and-reason_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Added.

(postResult):
(ws.onopen):
(ws.onmessage):
(ws.onclose):

02:43 Changeset [93392] by morrita@google.com
  • 19 edits
    2 adds in trunk

.: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Add export for window.internals object.

  • Source/autotools/symbols.filter:

Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
But these are low-level API and caller should take care of word boundary.
This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
which handles word boundary correctly.

Test: editing/spelling/spelling-insert-html.html

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAndBadGrammar):

  • testing/Internals.cpp:

(WebCore::Internals::markerCountOf): Added.
(WebCore::Internals::markedRangeAt): Added.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Add exports for window.internals object.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902

Reviewed by Ryosuke Niwa.

Existing expectation was wrong because of some markers on substrings of words.
With this fix, Editor now rejects such markers.

  • editing/spelling/spelling-insert-html-expected.txt: Added.
  • editing/spelling/spelling-insert-html.html: Added.
  • platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/mac/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac/editing/pasteboard/merge-end-table-expected.png:
  • platform/mac/editing/pasteboard/paste-text-008-expected.png:
01:58 Changeset [93391] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Run-time error fix in WebKit-GTK with video support disabled.
https://bugs.webkit.org/show_bug.cgi?id=66541

Definition of the function extraFullScreenStyleSheet() in webkit-gtk
lies outside ENABLE(VIDEO) guard, resulting in runtime error while
trying to launch GtkLauncher with video support disabled.

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-19
Reviewed by Philippe Normand.

Run-time error fix. No test cases were added.

  • platform/gtk/RenderThemeGtk.h:
01:46 Changeset [93390] by commit-queue@webkit.org
  • 7 edits in trunk

input[maxlength=0] should ignore text input.
https://bugs.webkit.org/show_bug.cgi?id=65497

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-19
Reviewed by Kent Tamura.

Source/WebCore:

Changed the valid range of maxlength.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Changed maxlength check condition.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt: Added a case that maxlength=0
  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.

(createFocusedTextAreaWithMaxLength):

  • fast/forms/textarea-maxlength-expected.txt: ditto.
01:42 Changeset [93389] by loislo@chromium.org
  • 5 edits in trunk

Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
https://bugs.webkit.org/show_bug.cgi?id=66482

There are functions in the API with multiple optional arguments.
When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
This can be solved with passing the arguments as an object.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/RemoteObject.js:

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex.html:
00:54 Changeset [93388] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix after r93384.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

Note: See TracTimeline for information about the timeline view.