Timeline


and

08/24/11:

23:58 Changeset [93762] by morrita@google.com

Implement an Event constructor.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Adam Barth.

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor.
This patch added the Event constructor to EventConstructors.h using
JavaScript implementation-independent macros. This patch also added the V8
implementation of these macros to V8EventConstructors.cpp.

Source/WebCore:

The bug 63878 has been implementing the Event constructors for JSC.
Our plan is to first implement all the Event constructors for V8
using EventConstructors.h proposed in the JSC patch, and then merge
the JSC patch with these V8 patches. In any case, we are going to split
the patches for V8 and those for JSC in order to avoid hard regression.

Test: fast/events/event-constructors.html

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Added V8EventConstructors.cpp.
  • bindings/generic/EventConstructors.h: Added. The Event constructor. This is written using JavaScript implementation-independent macros. The V8 implementation of these macros is written in bindings/v8/custom/V8EventConstructors.cpp.
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns the value of a given key of type double.
(WebCore::OptionsObject::getKey): Returns true whenever the given key is found, even if the value is null or undefined.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns the value of the given key. We need to overload getKeyValue() for all types required to EventConfiguration members.

  • bindings/v8/custom/V8EventConstructors.cpp: Added. Implemented macros used in EventConstructors.h.

(WebCore::constructV8Event): The Event constructor.

  • dom/Event.cpp:

(WebCore::EventConfiguration::EventConfiguration): A constructor of EventConfiguration.
(WebCore::Event::Event): A constructor of the Event class.

  • dom/Event.h: Added EventConfiguration, which manages attributes of the Event class.

(WebCore::Event::create): A factory method of the Event class with EventConfiguration.

  • dom/Event.idl: Added 'CanBeConstructed' and 'V8CustomConstructor'.

LayoutTests:

  • fast/events/event-constructors-expected.txt: Added.
  • fast/events/event-constructors.html: Added.
  • platform/gtk/Skipped: Skipped event-constructors.html, since Event constructors are not yet implemented in JSC.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
23:06 Changeset [93761] by philn@webkit.org

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

  • configure.ac:

WebCore:

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

Use fast element linking by default.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
23:02 BuildingGtk edited by philn@webkit.org
(diff)
22:50 Changeset [93760] by commit-queue@webkit.org

Some layerTreeAsText compositing tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=66913

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Simon Fraser.

Remove compositingLayerUpdatePending() and unconditionally update compositing layers when
RenderLayerCompositor::layerTreeAsText(). compositingLayerUpdatePending() was only used by test code and is
unreliable.

Covered by compositing/ layerTreeAsText tests.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:
22:31 Changeset [93759] by commit-queue@webkit.org

Implement a keypath parser strictly following the specification
https://bugs.webkit.org/show_bug.cgi?id=62288

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in keypath-basics.html.

Tests: storage/indexeddb/keypath-fetch-key.html

storage/indexeddb/keypath-basics.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath): Replaced IDBKeyPathElement with String
(WebCore::injectIDBKeyIntoSerializedValue): Replaced IDBKeyPathElement with String

  • bindings/v8/IDBBindingUtilities.h:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyStringWithUndefinedOrNullCheck): Returns false when a given value is null or undefined
(WebCore::OptionsObject::getKey): Removed undefined check

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore): Removed null check of a keypath

  • storage/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::currentElement): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lex): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lexIdentifier): Part of the keypath parser
(WebCore::IDBIsValidKeyPath): Checks if a keypath is valid
(WebCore::IDBParseKeyPath): Part of the keypath parser

  • storage/IDBKeyPath.h: Replaced IDBKeyPathElement with String
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBObjectStore.idl:

Source/WebKit/chromium:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in
tests/IDBKeyPathTest.cpp. We replaced IDBKeyPathElement with String here and there.

Tests: IDBKeyPathTest.*

IDBKeyFromValueAndKeyPathTest.*
InjectIDBKeyTest.*

  • public/WebIDBKeyPath.h:
  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::WebIDBKeyPath): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::assign): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Replaced IDBKeyPathElement with String

  • tests/IDBBindingUtilitiesTest.cpp:

(WebCore::checkKeyFromValueAndKeyPathInternal): Replaced IDBKeyPathElement with String
(WebCore::injectKey): Replaced IDBKeyPathElement with String
(WebCore::TEST): Rewrote tests for the new keypath parser

  • tests/IDBKeyPathTest.cpp:

(WebCore::checkKeyPath): Checks if a keypath is an expected keypath or not
(WebCore::TEST): Unit tests for the new keypath parser

LayoutTests:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We removed create-index-null-name.html since this test violates the
specification that says "a |keypath| argument of createIndex() must not be nullable".

  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-fetch-key-expected.txt: Renamed from LayoutTests/storage/indexeddb/keyPath-expected.txt.
  • storage/indexeddb/keypath-fetch-key.html: Renamed from LayoutTests/storage/indexeddb/keyPath.html.
  • storage/indexeddb/mozilla/create-index-null-name-expected.txt: Removed.
  • storage/indexeddb/mozilla/create-index-null-name.html: Removed.
20:35 Changeset [93758] by abarth@webkit.org

The user can't close the details view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66911

Reviewed by Dimitri Glazkov.

In addition to adding a close button, this patch changes the test
selector to use a <select> element and refactors the test selector to
share code with the builder selector.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
19:38 Changeset [93757] by jamesr@google.com

[chromium] Remove expected CRASH lines for tests that don't crash

  • platform/chromium/test_expectations.txt:
19:30 Changeset [93756] by jamesr@google.com

[chromium] Remove expected failure lines from tests that work now.

  • platform/chromium/test_expectations.txt:
18:25 Changeset [93755] by commit-queue@webkit.org

Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-24
Reviewed by Geoffrey Garen.

This patch adds a TopCallFrame to JSC in order to have that information
when an error is thrown to create a stack trace. The TopCallFrame is
updated throughout select points in the Interpreter and the JSC.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubCall.h:

(JSC::JITStubCall::call):

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
18:23 Changeset [93754] by msaboff@apple.com

Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
https://bugs.webkit.org/show_bug.cgi?id=66912

Updated the comment in ArgumentEncoder::grow to reflect that system malloc
currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.

Reviewed by Mark Rowe.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::grow):

18:05 Changeset [93753] by jamesr@google.com

[chromium] Update chromium mac baselines for fast/repaint/japanese-rl-selection-repaint-in-regions.html

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:02 Changeset [93752] by pkasting@chromium.org

[chromium] Mark a test as flaky.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:02 Changeset [93751] by commit-queue@webkit.org

[chromium] Stacktrace not in test output when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=66806

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.

Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
17:59 Changeset [93750] by ericu@chromium.org

Reviewed by Adam Barth.

[filesystem/Chromium] Filesystem paths need proper URL escaping
https://bugs.webkit.org/show_bug.cgi?id=62811

Fix http://code.google.com/p/chromium/issues/detail?id=78860 by making
KURLChromium.cpp's escaping code actually work.

Source/WebCore:

Make encodeWithURLEscapeSequences call into googleurl to do proper
escaping. Tested in WebKit/chromium/tests/KURLTest.cpp.

  • platform/KURLGoogle.cpp:

(WebCore::encodeWithURLEscapeSequences):

Source/WebKit/chromium:

Here I added the needed calls to encodeWithURLEscapeSequences.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::virtualPathToFileSystemURL):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::virtualPathToFileSystemURL):

Here I updated the test to reflect the new functionality in
encodeWithURLEscapeSequences.

  • tests/KURLTest.cpp:
17:35 Changeset [93749] by commit-queue@webkit.org

Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

Patch by Chris Palmer <palmer@google.com> on 2011-08-24
Reviewed by Kenneth Russell.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Check for integer overflow.
(WebCore::AudioArray::at): Document the safety assertion.
(WebCore::AudioArray::zero): Document the safety assertion.
(WebCore::AudioArray::zeroRange): Document the safety assertion.
(WebCore::AudioArray::copyToRange): Document the safety assertion.

16:04 Changeset [93748] by pkasting@chromium.org

[chromium] Update expectations after r93728 and r93737.

Unreviewed, test expectations update.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
16:01 Changeset [93747] by isherman@chromium.org

Remove some dead Autofill code
https://bugs.webkit.org/show_bug.cgi?id=66899
http://code.google.com/p/chromium/issues/detail?id=51644

Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebAutofillClient.h:
  • public/WebFrame.h:
  • public/WebPasswordAutocompleteListener.h: Removed.
  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::EditorClientImpl):
(WebKit::EditorClientImpl::handleKeyboardEvent):
(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/EditorClientImpl.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad):

  • src/WebFrameImpl.cpp:

(WebKit::frameContentAsPlainText):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::~WebFrameImpl):

  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

15:55 WikiStart edited by mjs@apple.com
(diff)
15:44 Changeset [93746] by paroga@webkit.org

[EFL] Fix build with ENABLE_GEOLOCATION.
https://bugs.webkit.org/show_bug.cgi?id=66881

Use adoptPtr() to create a new GeolocationService instance, otherwise
the build will fail when creating the PassOwnPtr object.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

  • platform/efl/GeolocationServiceEfl.cpp:

(WebCore::GeolocationServiceEfl::create):

15:35 Changeset [93745] by dbates@webkit.org

XSS filter bypass via document.write(location.href) and fragments
https://bugs.webkit.org/show_bug.cgi?id=66585

Reviewed by Darin Adler.

Add a test case for a variation of a DOM-based XSS attack using an anchor URL.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2.html: Added.
15:28 Changeset [93744] by paroga@webkit.org

[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=66880

Generate and build some additional files required by these options.

No new tests, as this is a build fix for some build options.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

  • CMakeLists.txt:
15:09 Changeset [93743] by commit-queue@webkit.org

[chromium] Don't call glDeleteTexture(0) in TextureManager
https://bugs.webkit.org/show_bug.cgi?id=66862

Delete(0) is allowed in standard OpenGL, but not in Chrome.
See http://code.google.com/p/chromium/issues/detail?id=85268

Patch by Iain Merrick <husky@google.com> on 2011-08-24
Reviewed by James Robinson.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::deleteEvictedTextures):

15:07 Changeset [93742] by jamesr@google.com

[chromium] Update expectations for tests that no longer crash.

  • platform/chromium/test_expectations.txt:
15:05 Changeset [93741] by abarth@webkit.org

Remove empty directory.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
14:56 Changeset [93740] by enne@google.com

[chromium] Properly initialize CCTiledLayerImpl::m_skipsDraw
https://bugs.webkit.org/show_bug.cgi?id=66889

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):

14:35 Changeset [93739] by cevans@google.com

Merge 93732
BUG=94011
Review URL: http://codereview.chromium.org/7734002

14:33 Changeset [93738] by abarth@webkit.org

Finish writing up details-view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66891

Reviewed by Dimitri Glazkov.

This patch mostly just copies a bunch of CSS from main.css to
summary.css. Presumably we'll delete main.css soon.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
14:27 Changeset [93737] by jamesr@google.com

Some compositing LayoutTests flakily crashing on Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=66740

Reviewed by Adam Barth.

Tools:

Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
chromium configuration.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

LayoutTests:

Remove = CRASH expectations for plugin tests that should no longer crash.

  • platform/chromium/test_expectations.txt:
14:25 Changeset [93736] by cevans@google.com

Merge 93521
BUG=89219
Review URL: http://codereview.chromium.org/7727007

14:20 Changeset [93735] by adauria@apple.com

No review necessary.

Adding myself to list of committers.

14:06 Changeset [93734] by commit-queue@webkit.org

Source/WebCore: chromium WebFrameImpl - don't load javascript URLs against chrome internal
pages. Adds a mechanism for registering sensitive schemes which should
not be subject to manipulation by javascript urls typed into a location bar
or, more importantly, their bookmarklet equivalents.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

Test: Chromium WebKit API unit test in chromium specific directory.

  • platform/SchemeRegistry.cpp:

(WebCore::notAllowingJavascriptURLsSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium: chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

  • public/WebSecurityPolicy.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs):

  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::WebFrameTest):
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::WebFrameTest::serveRequests):
(WebKit::WebFrameTest::loadHttpFrame):
(WebKit::WebFrameTest::loadChromeFrame):
(WebKit::WebFrameTest::registerMockedURLLoad):
(WebKit::WebFrameTest::loadFrame):
(WebKit::TEST_F):

  • tests/data/history.html: Added.
13:39 Changeset [93733] by pkasting@chromium.org

[chromium] More test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:36 Changeset [93732] by ap@apple.com

Plug-in tests are flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=66822

Reviewed by Anders Carlsson.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Protect objects that can be removed by a script.
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto. Also fixed some nonsense code.
13:31 Changeset [93731] by lforschler@apple.com

Versioning.

13:30 Changeset [93730] by lforschler@apple.com

New tag.

13:27 Changeset [93729] by scherkus@chromium.org

Merge 93715: rebaselining media/video-currentTime-set.html

13:20 Changeset [93728] by commit-queue@webkit.org

[CSSRegions] Fix Element::getBoundingClientRect and Element::getClientRects for content flow
https://bugs.webkit.org/show_bug.cgi?id=66641

Original author of the patch is Mihnea Ovidenie <mihnea@adobe.com>.

Source/WebCore:

Redirected the mapLocalToContainer method to the appropriate RenderRegion.

Note: RenderObject::absoluteQuads method needs some refactor to support multiple regions,
will do that in a separate bug.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Tests: fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html

fast/regions/flowed-content-bounding-client-rect-vertical-rl.html
fast/regions/flowed-content-bounding-client-rect-vertical.html
fast/regions/flowed-content-bounding-client-rect.html
fast/regions/flowed-content-transform-bounding-client-rect.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):

  • rendering/RenderFlowThread.h:

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical.html: Added.
  • fast/regions/flowed-content-bounding-client-rect.html: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect.html: Added.
  • fast/regions/resources/helper.js: Added.

(rectToArray):
(areEqualNumbers):
(areEqualRects):
(assertEqualRects):
(testBoundingRects):

13:17 Changeset [93727] by alokp@chromium.org

[chromium] Root layer is not updated when only a portion of tile is updated
https://bugs.webkit.org/show_bug.cgi?id=66506

This only happened in the accelerated path which changes stencil state.
Incorrect stencil state was used to draw the root layer.

Reviewed by James Robinson.

Test: compositing/overflow/overflow-scroll.html (existing)

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

13:16 Changeset [93726] by japhet@chromium.org

2011-08-24 Nate Chapin <japhet@chromium.org>

Fix an intermittent crash in EventSource, when a
reconnect timer triggers after a navigation
away from the current page begins.
https://bugs.webkit.org/show_bug.cgi?id=45202

Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::connect): Don't set m_requestInFlight

to true if ThreadableLoader::create() failed.

13:08 Changeset [93725] by reed@google.com

Change clip routine to promote the clipbounds up to (local) floats and then perform the intersection,
rather than rounding the srcRect down to integers.
https://bugs.webkit.org/show_bug.cgi?id=66810

Reviewed by Kenneth Russell.

No new tests. Existing tests that resize images will exercise this code path

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

13:04 Changeset [93724] by commit-queue@webkit.org

Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=66875

Patch by Avi Drissman <avi@google.com> on 2011-08-24
Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

13:02 Changeset [93723] by andersca@apple.com

Rename -[WKTextInputWindowController keyboardInputSourceChanged] to unmarkText to indicate what the method does
https://bugs.webkit.org/show_bug.cgi?id=66883

Reviewed by Beth Dakin.

  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _unmarkText]):
(-[WKTextInputWindowController unmarkText]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

12:56 Changeset [93722] by pkasting@chromium.org

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [93721] by commit-queue@webkit.org

[CSSRegions] RenderRegion is not used if there's another renderer after it
https://bugs.webkit.org/show_bug.cgi?id=66844

Source/WebCore:

There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
the region was not added to the RenderFlowThread.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.
12:34 Changeset [93720] by oliver@apple.com

JSNPObject and JSNPMethod create their structure in their constructors
https://bugs.webkit.org/show_bug.cgi?id=66879

Reviewed by Anders Carlsson.

It's not safe to create the Structure for an object inside its constructor
so we hoist construction out into their ::create methods and move the methods
into the cpp file.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

12:32 Changeset [93719] by lforschler@apple.com

Update SVN properties to help out the Windows EWS bots.

Reviewed by Adam Roben.

  • win: Modified properties svn:ignore.
  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
12:06 Changeset [93718] by pkasting@chromium.org

[chromium] Organize SLOW section of expectations.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:28 Changeset [93717] by weinig@apple.com

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66864

Reviewed by Anders Carlsson.

In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
JSHTMLImageElement is kept alive forever (and since it references the global object, it
keeps the entire graph alive as well).

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
Set m_firedLoad to true in the case of a canceled load, to reset the state back to
its initial values.

11:27 Changeset [93716] by mrowe@apple.com

Merge r93376.

11:23 Changeset [93715] by scherkus@chromium.org

2011-08-24 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining media/video-currentTime-set.html due to
FFmpeg udpate.

  • platform/chromium-cg-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
11:15 TestExpectations edited by pkasting@chromium.org
(diff)
11:09 Changeset [93714] by commit-queue@webkit.org

Expose fullscreen API on WebElement/WebDocument
https://bugs.webkit.org/show_bug.cgi?id=66746

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-24
Reviewed by Darin Fisher.

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setFullscreen):

  • src/WebPluginContainerImpl.h:
11:07 Changeset [93713] by commit-queue@webkit.org

MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925

Source/WebCore:

This patch introduces the functionality for generating the url associated with a MediaStream,
which can then be assigned to the src attribute of the <video> tag for example.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:
  • html/DOMURL.idl:
  • platform/MediaStreamRegistry.cpp: Added.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

  • platform/MediaStreamRegistry.h: Copied from Source/WebCore/html/DOMURL.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

LayoutTests:

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • fast/files/create-blob-url-crash-expected.txt:
11:00 Changeset [93712] by andersca@apple.com

More plug-in complex text input scaffolding
https://bugs.webkit.org/show_bug.cgi?id=66865

Reviewed by Sam Weinig.

Make -[WKView _doneWithKeyEvent:eventWasHandled:] take an NSEvent * directly. Also
add methods for handling plug-in text input key-down events.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
(-[WKView keyDown:]):
(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
(-[WKView _doneWithKeyEvent:eventWasHandled:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:55 Changeset [93711] by commit-queue@webkit.org

[GTK] WebProcess crash on hitting assertion m_isWaitingForDidUpdate in DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=66640

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-24
Reviewed by Martin Robinson.

The crash happens when a new timer is created in an existing timer callback. Since
TimerBase has a single GSource* it gets overridden and the old timer can never get
stopped. To handle this, keep a copy of the old timer and use it for destruction.

  • Platform/RunLoop.h:
  • Platform/gtk/RunLoopGtk.cpp:

(RunLoop::TimerBase::timerFiredCallback):
Store the timerSource so that even if it is modified by the timer callback,
it can be restored for freeing it.
(RunLoop::TimerBase::start):
Remove destroyNotifyCallback. Destruction is now handled in timerFiredCallback itself.

10:44 Changeset [93710] by fpizlo@apple.com

ErrorInstance::create sometimes has two heap object constructions
in flight at once
https://bugs.webkit.org/show_bug.cgi?id=66845

Reviewed by Darin Adler.

The fix is simple since there is already a second create() method
that takes a UString.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::create):

10:42 Changeset [93709] by levin@chromium.org

MessageEvent.ports shouldn't ever be null.
https://bugs.webkit.org/show_bug.cgi?id=66789

Reviewed by Darin Adler.

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports): Never return null.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter): Ditto.

LayoutTests:

Fix all tests which verified that MessageEvents.ports was null in various cases.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js:

(channel.port2.onmessage):

  • fast/workers/resources/worker-context-multi-port.js:

(worker.onmessage):

  • fast/workers/resources/worker-messageport.js:

(onmessage):

  • fast/workers/resources/worker-thread-multi-port.js:

(onmessage):

  • fast/workers/worker-context-multi-port-expected.txt:
  • fast/workers/worker-messageport-expected.txt:
  • fast/workers/worker-multi-port-expected.txt:
  • platform/chromium-win/fast/events/message-port-multi-expected.txt:
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt:
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:30 Changeset [93708] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=66799
RenderFlowThread creates a list of child elements, so that it can search
the insertion point of a new element without searching the whole DOM.
The issue is that it used addChild/removeChild, but that wasn't taking care of
elements added in anonymous blocks created inside the RenderFlowThread.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/flow-anonymous-children.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addFlowChild):
(WebCore::RenderFlowThread::removeFlowChild):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::renderFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

  • fast/regions/flow-anonymous-children-expected.txt: Added.
  • fast/regions/flow-anonymous-children.html: Added.
08:04 Changeset [93707] by commit-queue@webkit.org

[SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface
https://bugs.webkit.org/show_bug.cgi?id=66809

Patch by Brian Salomon <bsalomon@google.com> on 2011-08-24
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::grGLInterface):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::grContext):

06:35 Changeset [93706] by pfeldman@chromium.org

Web Inspector: Add 9 more javascript files to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=66847

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/Checkbox.js:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleStackFrame):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/CookieParser.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(WebInspector.isMac):

  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.Type.Document.0.Stylesheet.1.Image.2.Font.3.Script.4.XHR.5.WebSocket.7.Other.8.isTextType):
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
(WebInspector.Resource.prototype._checkWarnings):
(WebInspector.ResourceDomainModelBinding):
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
(WebInspector.ResourceDomainModelBinding.prototype.setContent):

  • inspector/front-end/ResourceCategory.js:

(WebInspector.ResourceCategory):
(WebInspector.ResourceCategory.prototype.toString):
(WebInspector.ResourceCategory.prototype.get title):

  • inspector/front-end/ResourceTreeModel.js:
  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterMappingPayload):

  • inspector/front-end/TimelineManager.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(console.assert):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
(WebInspector.UIString):
(Element.prototype.scrollIntoViewIfNeeded):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.UIString):

  • inspector/front-end/treeoutline.js:
  • inspector/front-end/utilities.js:
  • inspector/generate-protocol-externs:
05:52 Changeset [93705] by pfeldman@chromium.org

Web Inspector: extract ConsoleMessage into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66853

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessage.prototype.clearHighlight):
(WebInspector.ConsoleMessage.prototype.highlightSearchResults):
(WebInspector.ConsoleMessage.prototype.matchesRegex):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/WebKit.qrc:
04:40 Changeset [93704] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, chromium rebaseline for gradient-after-transparent-border.

  • platform/chromium-cg-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-cg-mac/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium/test_expectations.txt:
03:52 Changeset [93703] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update test expectations for svg/custom/stroke-opacity-update.

  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium-win/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • platform/qt/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • svg/custom/stroke-opacity-update-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/stroke-opacity-update-expected.txt.
03:51 Changeset [93702] by commit-queue@webkit.org

Source/WebCore: Paint SliderTrack and SliderThumb independently.
https://bugs.webkit.org/show_bug.cgi?id=50453
Also fixes https://bugs.webkit.org/show_bug.cgi?id=65456 crash.

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

RenderSlider works only with <input type=range>. Nowadays RenderTheme
supports painting of SliderTrack and SliderThumb without range input.
In order to be in sync with other platforms this patch gets rid of
upcasting in RenderThemeQt::paintSliderTrack and allows to paint
SliderTrack and SliderThumb independently.

Test: platform/qt/fast/forms/range/slider-crash.html

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSliderTrack): Draw SC_SliderGroove.
Allow paintSliderThumb() to care about SC_SliderHandle. We don't need
to setup value and position anymore, since handle is drawn separately.
Draw focus explicitly, since QStyleOptionSlider doesn't allow to focus
on CC_Slider without handle subcontrol.
(WebCore::RenderThemeQt::paintSliderThumb): Draw SC_SliderHandle.

LayoutTests: Pixel crash test for RenderThemeQt::paintSliderTrack.
https://bugs.webkit.org/show_bug.cgi?id=50453

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

Support -webkit-appearance: slider-horizontal/vertical
painting without range input.

  • platform/qt/fast/forms/range/slider-crash-expected.png: Added.
  • platform/qt/fast/forms/range/slider-crash-expected.txt: Added.
  • platform/qt/fast/forms/range/slider-crash.html: Added.
03:18 Changeset [93701] by pfeldman@chromium.org

Web Inspector: annotate and prepare for compilation first 14 JavaScript files within 4 modules.
https://bugs.webkit.org/show_bug.cgi?id=66776

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ContextMenu.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._inspectElementRequested):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.addEventListener):
(WebInspector.Object.prototype.removeEventListener):
(WebInspector.Object.prototype.hasEventListeners):

  • inspector/front-end/Panel.js:

(WebInspector.Panel):

  • inspector/front-end/Placard.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.show):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.StorageCategoryTreeElement):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.Settings.prototype.createSetting):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):

  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/UserMetrics.js:
  • inspector/front-end/View.js:
  • inspector/front-end/externs.js:

(JSON.parse):
(JSON.stringify):

  • inspector/front-end/inspector.js:

():

  • inspector/generate-protocol-externs:
03:10 Changeset [93700] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix chromium expectations for fast/preloader/script.html.

  • platform/chromium/fast/preloader/script-expected.txt: Added.
02:52 Changeset [93699] by andreas.kling@nokia.com

SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787

Reviewed by Darin Adler.

Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
its data members.

Also added missing initialization of m_userDrivenChange.

  • dom/SelectElement.cpp:

(WebCore::SelectElementData::SelectElementData):

  • dom/SelectElement.h:
02:50 Changeset [93698] by fpizlo@apple.com

There is no facility for profiling how the write barrier is used
https://bugs.webkit.org/show_bug.cgi?id=66747

Reviewed by Geoffrey Garen.

Added facilities for the JIT to specify the kind of write barrier
being executed. Added code for profiling the number of each kind
of barrier encountered.

(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • heap/WriteBarrierSupport.cpp: Added.

(JSC::WriteBarrierCounters::initialize):

  • heap/WriteBarrierSupport.h: Added.

(JSC::WriteBarrierCounters::WriteBarrierCounters):
(JSC::WriteBarrierCounters::jitCounterFor):
(JSC::WriteBarrierCounters::countWriteBarrier):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setWithoutWriteBarrier):

02:48 Changeset [93697] by commit-queue@webkit.org

[EFL] Add dummy IconDatabaseClientEfl.
http://bugs.webkit.org/show_bug.cgi?id=65596

Implements a dummy IconDatabaseClientEfl class.
Adds two files, IconDatabaseClientEfl.h | .cpp.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-08-24
Reviewed by Kent Tamura.

  • CMakeListsEfl.txt:
  • WebCoreSupport/IconDatabaseClientEfl.cpp: Added.

(WebCore::IconDatabaseClientEfl::performImport):
(WebCore::IconDatabaseClientEfl::didRemoveAllIcons):
(WebCore::IconDatabaseClientEfl::didImportIconURLForPageURL):
(WebCore::IconDatabaseClientEfl::didImportIconDataForPageURL):
(WebCore::IconDatabaseClientEfl::didChangeIconForPageURL):
(WebCore::IconDatabaseClientEfl::didFinishURLImport):

  • WebCoreSupport/IconDatabaseClientEfl.h: Added.
02:07 Changeset [93696] by commit-queue@webkit.org

Web Inspector: clearPseudoState should retain Element while clearing
its state.
https://bugs.webkit.org/show_bug.cgi?id=66790

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-24
Reviewed by Yury Semikhatsky.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearPseudoState):

08/23/11:

22:24 Changeset [93695] by koz@chromium.org

Extra baseline for bug 66036 (canvas fill composite modes)
https://bugs.webkit.org/show_bug.cgi?id=66835

Unreviewed, new baseline for pixel tests.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23

  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
22:15 Changeset [93694] by cevans@google.com

Merge 93514
BUG=93420
Review URL: http://codereview.chromium.org/7714029

21:37 Changeset [93693] by commit-queue@webkit.org

[EFL] Change parameter type for some APIs in ewk_tile_matrix.
https://bugs.webkit.org/show_bug.cgi?id=66639

As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch
are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now
using unsigned long type for both col and row parameter, row parameter for ewk_tile_matrix
is also better to be specified as unsigned long type.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_matrix.c:

(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):

  • ewk/ewk_tiled_matrix.h:
21:32 Changeset [93692] by abarth@webkit.org

WebSearchableFormData crashes when given a detached HTMLFormElement
https://bugs.webkit.org/show_bug.cgi?id=66831

Reviewed by Dimitri Glazkov.

We need to null-check the Frame.

  • src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

  • tests/data/form.html: Added.
21:24 Changeset [93691] by dglazkov@chromium.org

Make notifications appear in time order again.
https://bugs.webkit.org/show_bug.cgi?id=66815

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
19:14 Changeset [93690] by commit-queue@webkit.org

Extra baseline for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66833

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

  • platform/chromium-gpu-linux/compositing/masks/multiple-masks-expected.png: Added.
19:11 Changeset [93689] by commit-queue@webkit.org

[chromium] Make WebGL context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66788

We're making changes on the Chromium side for threaded compositing that
will require makeContextCurrent to be called on the appropriate thread
before any other GL calls.

In line with other GraphicsContext3D implementations, we do this
implicitly. This is the minimum change that makes WebGL compliant.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by Kenneth Russell.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initializeExtensions):

19:05 Changeset [93688] by commit-queue@webkit.org

Add checks to ensure allocation does not take place during initialization of GC-managed objects
https://bugs.webkit.org/show_bug.cgi?id=65288

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-23
Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::constructorBody):
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::allocateCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObject):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):

Source/WebCore:

No new tests.

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::operator new):

  • bindings/js/JSDOMWindowShell.h:

Source/WebKit/mac:

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

19:00 Changeset [93687] by commit-queue@webkit.org

Rebaselines for bug 66036 (fills with various canvas compositing modes)
https://bugs.webkit.org/show_bug.cgi?id=66824

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by James Robinson.

  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:57 Changeset [93686] by pkasting@chromium.org

[chromium] Add more flaky snowleopard GPU tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:55 Changeset [93685] by commit-queue@webkit.org

[EFL] Get the default value for `scripts_window_open' from the right method.
https://bugs.webkit.org/show_bug.cgi?id=66775

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

For some unknown reason, the default value for this setting was being
obtained from Settings::allowScriptsToCloseWindows() instead of
Settings::javaScriptCanOpenWindowsAutomatically(), which makes no
sense at all.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

18:39 Changeset [93684] by pkasting@chromium.org

[chromium] Fix erroneous test expectation.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:39 Changeset [93683] by commit-queue@webkit.org

[EFL] Change the tiled backing store to use constant size of tile.
https://bugs.webkit.org/show_bug.cgi?id=65848

As current tiled backing store in Webkit EFL is using variable tile size according to the zoom level,
the number of tiles in viewport is not same always and the speed of panning is also not consistent
whenever zoom level is changed.
Therefore, tile size should be constant size in order to make sure the consistent panning speed.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.c:

(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_dbg):

  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.c:

(ewk_tile_new):

18:36 Changeset [93682] by commit-queue@webkit.org

ScrollAnimatorNone coasting implementation
https://bugs.webkit.org/show_bug.cgi?id=66258

Source/WebCore:

Increase the animation time based on the velocity of the scroll, up to a
maximum amount. Fix bugs found by additional unit testing.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Additional tests in ScrollAnimatorNoneTest: CurveMathQuartic, CurveMathCoast,
ScrollOnceQuartic, ScrollTwiceCubic, ScrollLotsCubic, ScrollLotsCubicSmoothed,
ScrollUpToBumperCoast, ScrollDownToBumperCoast, VaryingInputsEquivalency,
VaryingInputsEquivalencyCoast, VaryingInputsEquivalencyCoastLarge,
VaryingInputsEquivalencyCoastSteep

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::coastCurve):
(WebCore::ScrollAnimatorNone::PerAxisData::curveIntegralAt):
(WebCore::ScrollAnimatorNone::PerAxisData::attackArea):
(WebCore::ScrollAnimatorNone::PerAxisData::releaseArea):
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateVisibleLength):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::willEndLiveResize):
(WebCore::ScrollAnimatorNone::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorNone::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorNone::updateVisibleLengths):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):
(ScrollAnimatorNoneTest::SavePerAxisData::SavePerAxisData):
(ScrollAnimatorNoneTest::SavePerAxisData::operator==):
(ScrollAnimatorNoneTest::SetUp):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::attackArea):
(ScrollAnimatorNoneTest::releaseArea):
(ScrollAnimatorNoneTest::coastCurve):
(ScrollAnimatorNoneTest::curveTestInner):
(TEST_F):

18:33 Changeset [93681] by jamesr@google.com

[chromium] Need a way to test lost compositor context recovery
https://bugs.webkit.org/show_bug.cgi?id=66820

Reviewed by Kenneth Russell.

Source/WebCore:

Adds support for recreating a context as if it was lost, and fixes
compositeAndReadback() to attempt context recovery.

Test: platform/chromium/compositing/lost-compositor-context.html

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseCompositorContext):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Adds a testing-only API to simulate a lost compositor context.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::loseCompositorContext):

  • src/WebViewImpl.h:

Tools:

Exposes a LayoutTestController interface in chromium to simulate a
lost compositor context.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::loseCompositorContext):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adds a simple test for losing the compositor context in a recoverable
way on a composited page. Tests that we recover without crashing and
render the updated content on the next frame.

  • platform/chromium/compositing/lost-compositor-context.html: Added.
18:22 Changeset [93680] by nduca@chromium.org

[chromium] Implement CCThread in terms of WebThread
https://bugs.webkit.org/show_bug.cgi?id=66610

Reviewed by Darin Fisher.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCCompletionEvent.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::client):

  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):

  • platform/graphics/chromium/cc/CCThread.h:

(WebCore::CCThread::~CCThread):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebThread.h:

(WebKit::WebThread::~WebThread):

  • src/CCThreadImpl.cpp: Added.

(WebKit::GetThreadIDTask::GetThreadIDTask):
(WebKit::GetThreadIDTask::~GetThreadIDTask):
(WebKit::GetThreadIDTask::run):
(WebKit::CCThreadTaskAdapter::CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::~CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::run):
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::~CCThreadImpl):
(WebKit::CCThreadImpl::postTask):
(WebKit::CCThreadImpl::threadID):
(WebKit::CCThreadImpl::CCThreadImpl):

  • src/CCThreadImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorThread):

  • src/WebViewImpl.h:
  • tests/CCThreadTest.cpp:
18:18 Changeset [93679] by commit-queue@webkit.org

[chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Source/WebCore:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setParent):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::hasAncestor):

  • platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didRecreateGraphicsContext):

18:08 Changeset [93678] by mrowe@apple.com

Merge r93420.

18:06 Changeset [93677] by mrowe@apple.com

Merge r90691.

18:00 Changeset [93676] by commit-queue@webkit.org

Unreviewed, rolling out r93645.
http://trac.webkit.org/changeset/93645
https://bugs.webkit.org/show_bug.cgi?id=66828

Broke webkit_unit_tests on chromium mac (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

17:54 Changeset [93675] by mrowe@apple.com

Merge r93287.

17:54 Changeset [93674] by mrowe@apple.com

Merge r92417.

17:43 Changeset [93673] by mrowe@apple.com

Merge r93546.

17:38 Changeset [93672] by mrowe@apple.com

Merge r92894.

17:33 Changeset [93671] by mrowe@apple.com

Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-23
Reviewed by Alexey Proskuryakov.

It is still unclear in what scenario the ResourceLoader could have a non-null DocumentLoader
without a Frame, since all loads should be stopped before the DocumentLoader is detached
from its Frame.

Until a reproducible case is found, bail early to prevent crashes.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didFail):
Add an early return if the DocumentLoader does not have a Frame.

17:29 Changeset [93670] by andersca@apple.com

Prepare WKTextInputWindowController for the new text input model
https://bugs.webkit.org/show_bug.cgi?id=66826

Reviewed by Sam Weinig.

Add -[WKTextInputWindowController hasMarkedText] and make interpretKeyEvent take an
additional usingLegacyCocoaTextInput flag. No functionality change.

  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
(-[WKTextInputWindowController hasMarkedText]):
(-[WKTextInputWindowController interpretKeyEvent:usingLegacyCocoaTextInput:string:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView keyDown:]):

17:29 Changeset [93669] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66244
Cached pages don't fully update when going back after changing the display scale
factor
-and corresponding-
<rdar://problem/9955656>

Reviewed by Darin Adler.

This patch adds a generalized concept of needing a full style recalc to the
BackForwardController. So when the display scale factor is changed, the
BackForwardController can be informed that all pages will need a full style recalc
when they come out of the cache. This same mechanism is also used to fix a long-
standing bug with full-page/text zoom.

Iterate through the HistoryItems and mark all CachedPages as needing a full style
recalc.

  • history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

  • history/BackForwardController.h:

ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full
style recalc is needed when the CachedPage is restored.

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

  • history/CachedPage.h:

(WebCore::CachedPage::markForFullStyleRecalc):

HistoryItem actually takes care of calling into CachedPage.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::markForFullStyleRecalc):

  • history/HistoryItem.h:

Fix style recalc issues for full-page/text zoom by calling our new function on
PageCache.

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

Fix style recalc issues for display scale factor changes by calling our new
function on PageCache.

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

17:15 Changeset [93668] by mrowe@apple.com

Merge r93487.

17:15 Changeset [93667] by mrowe@apple.com

Merge r92788.

17:15 Changeset [93666] by mrowe@apple.com

Merge r93555.

17:15 Changeset [93665] by mrowe@apple.com

Merge r93298.

17:15 Changeset [93664] by mrowe@apple.com

Merge r93264.

17:13 Changeset [93663] by abarth@webkit.org

Fix baselines for fast/block/float/fit_line_below_floats.html. I forgot Windows in my previous patch.

  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Removed.
  • platform/chromium-win/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-win/fast/block/float/fit_line_below_floats-expected.txt: Added.
16:59 Changeset [93662] by pkasting@chromium.org

[chromium] Remove comments formerly associated with now-rebaselined tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
16:39 Changeset [93661] by lforschler@apple.com

Merge r93363.

16:37 Changeset [93660] by lforschler@apple.com

Merge r93260.

16:34 Changeset [93659] by lforschler@apple.com

Merge 93219.

16:33 Changeset [93658] by dglazkov@chromium.org

Change garden-o-matic frontend builder array to be a configuration map.
https://bugs.webkit.org/show_bug.cgi?id=66816

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
16:32 Changeset [93657] by andersca@apple.com

Fix build.

  • inspector/InstrumentingAgents.cpp:
16:31 Changeset [93656] by commit-queue@webkit.org

Added support for momentarily revealing last typed character in password input.
Code change was partially based on Apple's iOS code and Samuel Nevala's work.
https://bugs.webkit.org/show_bug.cgi?id=32509

Patch by Chang Shu <cshu@webkit.org> on 2011-08-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):

  • rendering/RenderText.cpp:

(WebCore::SecureTextTimer::SecureTextTimer):
(WebCore::SecureTextTimer::restartWithNewText):
(WebCore::SecureTextTimer::invalidate):
(WebCore::SecureTextTimer::lastTypedCharacterOffset):
(WebCore::SecureTextTimer::fired):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::secureText):
(WebCore::RenderText::momentarilyRevealLastTypedCharacter):

  • rendering/RenderText.h:

(WebCore::RenderText::isSecure):

  • testing/Internals.cpp:

(WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

LayoutTests:

Updated failed expected files.

  • editing/input/password-echo-passnode-expected.txt:
  • editing/input/password-echo-passnode2-expected.txt:
16:24 Changeset [93655] by commit-queue@webkit.org

Rebaselines for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66757

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

  • platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/chromium-linux/fast/backgrounds/mask-composite-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-composite-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-composite-expected.txt: Added.
  • platform/chromium-win/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-win/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/transformed-mask-expected.txt.
  • platform/chromium/test_expectations.txt:
16:22 Changeset [93654] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=66751
[Chromium]WebWorkerClientImpl should always invoke
InspectorIntrumentation on main thread.
The fix moves calls to InspectorInstrumentation from
WebWorkerClientImpl to unedrlying WorkerMessagingProxy.

Patch by Dmitry Lomov <Dmitry Lomov (dslomov@google.com)> on 2011-08-23
Reviewed by Pavel Feldman.

Source/WebCore:

Covered by existing tests.

  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerContext):

Source/WebKit/chromium:

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):

16:18 Changeset [93653] by caryclark@google.com

Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=66803

This fixes the WebKit Canaries, in particular avoids a crash on tests
like css1/basic/comments.html.

Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
and treated it as if it were a CGContextRef.

16:12 Changeset [93652] by commit-queue@webkit.org

[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635

When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.

Patch by Misha Tyutyunik <michael.tyutyunik@nokia.com> on 2011-08-23
Reviewed by Andreas Kling.

Covered by existing tests.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemColor):

16:10 Changeset [93651] by tony@chromium.org

Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723

Reviewed by David Hyatt.

Source/WebCore:

If we flex past a min/max width value, we need to mark the flexitem as
a fixed width and re-start the flexing algorithm. We use a HashMap to
keep track of fixed width items.

This patch also split out the size computation from the actual layout
to avoid unnecessary layouts caused by restarting the flexing algorithm.

Test: css3/flexbox/003.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/003-expected.txt: Added.
  • css3/flexbox/003.html: Added.
16:08 Changeset [93650] by abarth@webkit.org

Update expectations for pkasting. The rebaseline script is having
trouble on Cygwin, so I ran the script as instructed by Peter.

  • platform/chromium-cg-mac-leopard/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-cg-mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/css: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates: Removed.
  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/chromium-linux/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-linux/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/058-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win-vista/svg/dynamic-updates: Removed.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/058-expected.txt:
  • platform/chromium-win/fast/css/border-radius-non-negative-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/image-small-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/image-small-width-height-expected.txt: Removed.
  • svg/custom/image-small-width-height-expected.txt: Added.
16:07 Changeset [93649] by paroga@webkit.org

Fix mergeChangeLogs test on native windows
https://bugs.webkit.org/show_bug.cgi?id=66797

Reviewed by Adam Roben.

Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.

  • Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:

(writeTempFile):

16:05 Changeset [93648] by psolanki@apple.com

ResourceRequest::setStorageSession should update NSURLRequest as well
https://bugs.webkit.org/show_bug.cgi?id=66811

Reviewed by Darin Adler.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::setStorageSession): Update the m_nsRequest field as well since we
have a new CFURLRequestRef.

16:01 Changeset [93647] by commit-queue@webkit.org

[chromium] Remove obsolete child context list from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66743

Patch by James Robinson <jamesr@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

Before we had proper semantics for flush() in the command buffer, we
used a scheme of latches across contexts to ensure consistent frames
were presented for WebGL and canvas. We no longer have latches and
flush is a proper synchronization primative, so the child context list
no longer does anything. Canvas2DLayerChromium and
WebGLLayerChromium's implementations of updateCompositorResources() do
flushes on the appropriate context already - canvas layers via
DrawingBuffer::publishToPlatformLayer(), and WebGL layers via the call
to prepareTexture().

No new tests since the code being removed doesn't do anything.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::setContext):

  • platform/graphics/chromium/WebGLLayerChromium.h:
16:01 Changeset [93646] by lforschler@apple.com

Merge https://bugs.webkit.org/show_bug.cgi?id=62901

15:59 Changeset [93645] by commit-queue@webkit.org

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-23
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

15:57 Changeset [93644] by commit-queue@webkit.org

Source/WebCore: Prepare to paint slider thumb separately.
Provide proper size values for vertical SliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):
Swap length and thickness for sliderthumb-vertical.

LayoutTests: Swap width and height for sliderthumb-vertical.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
15:35 Changeset [93643] by pkasting@chromium.org

[chromium] Typo fix.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:22 Changeset [93642] by pkasting@chromium.org

[chromium] Revert unintentional changes to test expectations in r93638.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:10 Changeset [93641] by dglazkov@chromium.org

garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
15:09 Changeset [93640] by enne@google.com

[chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=66808

Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

15:01 Changeset [93639] by lforschler@apple.com

Versioning.

14:51 Changeset [93638] by pkasting@chromium.org

Unreviewed, rolling out r93452.
http://trac.webkit.org/changeset/93452
https://bugs.webkit.org/show_bug.cgi?id=66423

Broke Leopard, Snowleopard, and Chromium bots

Source/WebCore:

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Removed.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
14:40 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
14:01 Changeset [93637] by demarchi@webkit.org

Source/WebKit: Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

[EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

  • CMakeLists.txt:

Adding necessary files for the patch.

Source/WebKit/efl: [EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

  • CMakeLists.txt:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/EWebKit.h:
  • ewk/ewk_js.cpp: Added.

(ewk_js_variant_to_npvariant):
(ewk_js_npvariant_to_variant):
(ewk_js_property_has):
(ewk_js_property_get):
(ewk_js_property_set):
(ewk_js_property_remove):
(ewk_js_properties_enumerate):
(ewk_js_method_has):
(ewk_js_method_invoke):
(ewk_js_class_new):
(ewk_js_class_free):
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_variant_free):

  • ewk/ewk_js.h: Added.
  • ewk/ewk_main.cpp:

(ewk_init):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_js_window_object_clear):
(ewk_view_js_object_add):

  • ewk/ewk_view.h:
13:48 Changeset [93636] by andreas.kling@nokia.com

[Qt] Unnecessary folders in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=66583

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-23
Reviewed by Benjamin Poulain.

Remove empty autotest folders that were left over from QGraphicsWKView times.

  • UIProcess/API/qt/tests/qgraphicswkview: Removed.
  • UIProcess/API/qt/tests/qwkhistory: Removed.
  • UIProcess/API/qt/tests/qwkpage: Removed.
13:40 Changeset [93635] by pkasting@chromium.org

[chromium] Move result images into correct subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=66618

Unreviewed, file misplacement fix.

  • platform/chromium-cg-mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-in-transformed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png.
  • platform/chromium-cg-mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png.
  • platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Removed.
  • platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Removed.
13:34 Changeset [93634] by lforschler@apple.com

Merge r93546.

13:32 Changeset [93633] by lforschler@apple.com

New tag.

13:19 Changeset [93632] by adamk@chromium.org

[chromium] Remove a few FIXME #defines in API headers
https://bugs.webkit.org/show_bug.cgi?id=66791

Reviewed by James Robinson.

  • DEPS:

Roll chromium_rev to r97891.

  • public/WebFileSystem.h:

#define made obsolete in http://crrev.com/97520.

  • public/WebKitClient.h:

#define made obsolete in http://crrev.com/97524 and
http://crrev.com/97891.

13:10 Changeset [93631] by commit-queue@webkit.org

Fixed warnings produced by gcc-4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=62168

Patch by Ahmad Sharif <asharif@chromium.org> on 2011-08-23
Reviewed by Adam Barth.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):

  • thirdparty: Copied from Source/WebCore/thirdparty.
13:08 Changeset [93630] by paroga@webkit.org

Add missing quotes around filenames in mergeChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=66794

Reviewed by Adam Roben.

  • Scripts/VCSUtils.pm:

(mergeChangeLogs):

13:00 BuildingQtOnLinux edited by andreas.kling@nokia.com
(diff)
12:58 Changeset [93629] by pkasting@chromium.org

[chromium] Attempt to make test expectations more accurate.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:54 Changeset [93628] by commit-queue@webkit.org

Text overlaps with the floats
https://bugs.webkit.org/show_bug.cgi?id=66671

Source/WebCore:

The problem was that LineWidth::fitBelowFloats is not updating the m_left and m_right fields.
Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded was called the width was recalculated
using the old values, making the line bigger.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Test: fast/block/float/fit_line_below_floats.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitBelowFloats):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/block/float/fit_line_below_floats.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/mac/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/qt/Skipped:
12:44 Changeset [93627] by commit-queue@webkit.org

[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html

fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

  • rendering/RenderFlowThread.h:

(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
12:38 Changeset [93626] by commit-queue@webkit.org

Text-indent and floats push the text out of the container box
https://bugs.webkit.org/show_bug.cgi?id=66662

Source/WebCore:

Text indent was not propagated when a new float was pushed on the line.
It was only calculated when the logicalLeft/RightOffsetForLine was called.
Because of that RenderBlock::LineBreaker::nextLineBreak used a bigger width
than actually available and made the line render on top of the borders.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/block/float/floats-and-text-indent-rl.html

fast/block/float/floats-and-text-indent.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

  • fast/block/float/floats-and-text-indent-rl.html: Added.
  • fast/block/float/floats-and-text-indent.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/mac/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/qt/Skipped:
12:30 Changeset [93625] by commit-queue@webkit.org

Add shareResources flag to 3D graphics context attributes
https://bugs.webkit.org/show_bug.cgi?id=66516

Patch by Al Patrick <apatrick@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):

  • src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):

12:28 Changeset [93624] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The default value of a NativeErrorPrototype's message
property is "", not the name of the error.

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::create):
(JSC::NativeErrorConstructor::constructorBody):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

  • runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::create):

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
    • Add tests for value of RangeError.proto.{name|message}
12:27 Changeset [93623] by paroga@webkit.org

webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Reviewed by Adam Roben.

Use the string form of pipe open instead (like we do at all other places).

  • Scripts/VCSUtils.pm:

(mergeChangeLogs):

12:21 Changeset [93622] by fsamuel@chromium.org

New MainFrame views should inherit fixed layout settings from existing MainFrame view in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=66780

Fixed layout mode is set from WebViewImpl, but new main FrameViews are created on loading new pages. The new page's FrameView should get its
fixed layout settings from the current page.

Reviewed by Darin Fisher.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

12:07 Changeset [93621] by commit-queue@webkit.org

Unreviewed, rolling out r93616.
http://trac.webkit.org/changeset/93616
https://bugs.webkit.org/show_bug.cgi?id=66796

"causes fast/css/absolute-child-with-percent-height-inside-
relative-parent.html to fail" (Requested by mwenge2 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Removed.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Removed.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Removed.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
11:46 Changeset [93620] by jocelyn.turcotte@nokia.com

[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.

  • UIProcess/qt/SGAgent.h:

(WebKit::NodeUpdate::~NodeUpdate):

11:42 Changeset [93619] by kerz@chromium.org

Merge 92159 - Shard webcore_remaining for msvs official builds

https://bugs.webkit.org/show_bug.cgi?id=65475

Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.

webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

  • WebCore.gyp/WebCore.gyp:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7715011

11:30 Changeset [93618] by commit-queue@webkit.org

[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-23
Reviewed by Tony Chang.

  • WebKit.gyp:
  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
11:27 Changeset [93617] by commit-queue@webkit.org

[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
https://bugs.webkit.org/show_bug.cgi?id=66692

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Rubber-stamped by Kenneth Rohde Christiansen.

Frame::page() and FrameTree::parent() returning 0 were being considered
failure cases, however it is possible for them to return 0 when some
arbitrary JavaScript is run.

The function's return type has been changed to make it easier to convey
these cases to the caller (which is only ewk_view_frame_create).

This should make tests like
fast/dom/null-page-show-modal-dialog-crash.html stop outputting
erroneous messages to stderr.

  • ewk/ewk_frame.cpp:

(ewk_frame_child_add):

  • ewk/ewk_private.h:
11:11 Changeset [93616] by robert@webkit.org

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/inline/absolute-positioned-block-in-centred-block.html

fast/inline/absolute-positioned-inline-in-centred-block.html

When an element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
(WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
(WebCore::RenderBlock::startAlignedOffsetForLine): ditto

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine.
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
11:08 Changeset [93615] by enne@google.com

[chromium] Remove LayerRendererChromium references from TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433

Reviewed by James Robinson.

Covered by existing tests.

Updated TiledLayerChromium and the texture updater classes to not
access LayerRendererChromium or cache GraphicsContext3D. Some settings
like max texture size were moved from LayerRendererChromium to
CCLayerTreeHost in order to facilitate this refactoring.

LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
compositor is not threaded. It will need to be refactored more in
order to not own graphics resources from the main thread.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::LayerTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

(WebCore::LayerTextureUpdaterSkPicture::context):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::layerRenderer):
(WebCore::CCLayerTreeHost::contextSupportsMapSub):
(WebCore::CCLayerTreeHost::maxTextureSize):
(WebCore::CCLayerTreeHost::bestTextureFormat):

11:02 Changeset [93614] by jchaffraix@webkit.org

Reduce the amount of RenderLayer rectangles' update when scrolling
https://bugs.webkit.org/show_bug.cgi?id=66618

Reviewed by David Hyatt.

Source/WebCore:

This patch avoids recomputing the RenderLayers rectangles if not needed.

The current code path for scrolling would update RenderLayers' repaint rectangles
twice. However we do need to update only children of a fixed element as they are
the only type of layers that move during a scroll.

We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
updateLayerPositions being pessimist about the layer's state - because it is called after layout -
it is missing some optimization that can be done during scrolling.

Tests: fast/repaint/scroll-absolute-layer-with-reflection.html

fast/repaint/scroll-fixed-layer-with-reflection.html
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
fast/repaint/scroll-fixed-reflected-layer.html
fast/repaint/scroll-in-clipped-layer.html
fast/repaint/scroll-in-fixed-layer.html
fast/repaint/scroll-in-transformed-layer.html
fast/repaint/scroll-with-transformed-parent-layer.html

  • rendering/RenderLayer.h:
  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
to take care of also updating the layer's position (that sounded like a bug in
the previous code that is covered by the tests above). Note that we don't care
if one of our ancestor has a fixed position as we are scrolling *inside* this
ancestor.

(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
updateLayerPositions.

LayoutTests:

  • fast/repaint/resources/default.css:

Added more shortcuts.

  • fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
  • fast/repaint/scroll-absolute-layer-with-reflection.html: Added.
  • fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-reflection.html: Added.
  • fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html: Added.
  • fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
  • fast/repaint/scroll-fixed-reflected-layer.html: Added.
  • fast/repaint/scroll-in-clipped-layer-expected.txt: Added.
  • fast/repaint/scroll-in-clipped-layer.html: Added.
  • fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
  • fast/repaint/scroll-in-fixed-layer.html: Added.
  • fast/repaint/scroll-in-transformed-layer-expected.txt: Added.
  • fast/repaint/scroll-in-transformed-layer.html: Added.
  • fast/repaint/scroll-with-transformed-parent-layer-expected.txt: Added.
  • fast/repaint/scroll-with-transformed-parent-layer.html: Added.

Those are a variation on the same theme: scrolling inside a layers (sometimes the layer is itself scrolled)
to show that we are still doing the right thing.

  • platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Added.
  • platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.

Baseline for Chromium and Mac.

10:47 Changeset [93613] by jpfau@apple.com

New XML parser: pretty XML tree viewer
https://bugs.webkit.org/show_bug.cgi?id=66489

Reviewed by Adam Barth.

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::finish):

10:41 Changeset [93612] by caseq@chromium.org

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Disabled inspector/extensions/extensions-resources.html.
https://bugs.webkit.org/show_bug.cgi?id=66786

  • platform/qt/Skipped:
10:08 Changeset [93611] by leandro@webkit.org

Unreviewed build fix after r66685.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
Assert using the right variable name.

09:31 Changeset [93610] by caseq@chromium.org

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix following r93605.

  • http/tests/inspector/resources/extension-main.js: (trimURL):
  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
09:25 Changeset [93609] by nduca@chromium.org

Unreviewd, roll chromium reverse DEPS 97698:97834
https://bugs.webkit.org/show_bug.cgi?id=66781

  • DEPS:
09:20 Changeset [93608] by jberlin@webkit.org

Build fix.

  • inspector/InspectorDOMAgent.h:

HighlightData is a struct, not a class.

09:02 Changeset [93607] by abarth@webkit.org

garden-o-matic summary should be able to examine failures
https://bugs.webkit.org/show_bug.cgi?id=66748

Reviewed by Dimitri Glazkov.

This patch refactors a bunch of code from summary.js to independent
controllers in controllers.js. This patch also contains the first
iteration of binding the "examine" event to a the behavior showing the
details view for the tests. There's more work to do here to make this
work properly (and elegantly), but this patch is a start.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
08:48 Changeset [93606] by commit-queue@webkit.org

[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
https://bugs.webkit.org/show_bug.cgi?id=66698

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

WebCore::History->currentItem() may return NULL, and we'd better treat
it in ewk_history_history_item_current_get itself than propagate the
issue to _ewk_history_item_new.

  • ewk/ewk_history.cpp:

(ewk_history_history_item_current_get):

  • ewk/ewk_history.h:
08:35 Changeset [93605] by caseq@chromium.org

Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-resources.html

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetRequestContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype.initExtensions):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.addRevision):

LayoutTests:

  • http/tests/inspector/resources/extension-main.js:

(trimURL):

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-network-expected.txt:
  • inspector/extensions/extensions-network.html:
  • inspector/extensions/extensions-resources-expected.txt: Added.
  • inspector/extensions/extensions-resources.html: Added.
  • inspector/extensions/resources/Ahem.ttf:
  • inspector/extensions/resources/test-script.js: Added.

(test_function):

08:08 Changeset [93604] by pfeldman@chromium.org

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::highlightFrame):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown):
07:38 Changeset [93603] by apavlov@chromium.org

Web Inspector: differentiate element highlight colors for margin and padding
https://bugs.webkit.org/show_bug.cgi?id=37768

The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
rather than a generic "highlighting mode". This allows to:

  • use entirely custom colors for highlighting (and vary them over time);
  • display any combination of fill/outline for the highlighted area;
  • highlight any combinations of element parts.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawHighlight):

  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::highlightedNode):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/Color.js:

(WebInspector.Color.fromRGBA):
(WebInspector.Color.prototype.toProtocolRGBA):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.setSearchingForNode):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.set hovered):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._highlightRect):

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:

(WebInspector.buildHighlightConfig):
(WebInspector.highlightDOMNode):

06:37 Changeset [93602] by commit-queue@webkit.org

[EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

EFL's DumpRenderTree implementation needs some private, auxiliary
functions in ewk in order to iterate and dump the history tree when
necessary.

  • ewk/ewk_history.cpp:

(ewk_history_item_target_get):
(ewk_history_item_target_is):
(ewk_history_item_children_get):

  • ewk/ewk_private.h:
06:36 Changeset [93601] by commit-queue@webkit.org

Unreviewed, rolling out r93579.
http://trac.webkit.org/changeset/93579
https://bugs.webkit.org/show_bug.cgi?id=66774

"ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

06:26 Changeset [93600] by vestbo@webkit.org

[Qt] Fix build on Lion

https://bugs.webkit.org/show_bug.cgi?id=66770

Reviewed by Andreas Kling.

We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).

For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.

Lasty, we need to link against the right system interface library
on Lion.

06:19 Changeset [93599] by commit-queue@webkit.org

[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

Add some auxiliary functions needed by EFL's DRT implementation. They
all revolve around talking to the garbage collector and counting the
worker threads.

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp:

(ewk_util_javascript_gc_collect):
(ewk_util_javascript_gc_alternate_thread_collect):
(ewk_util_javascript_gc_object_count_get):
(ewk_util_worker_thread_count):
(ewk_util_dpi_get):

06:12 Changeset [93598] by ossy@webkit.org

[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.

  • platform/qt/Skipped:
06:07 Changeset [93597] by steveblock@google.com

Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763

Reviewed by Tony Gentilcore.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

No new tests, removing dead code only.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

05:45 Changeset [93596] by steveblock@google.com

Remove Android-specific modifications to non-client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=66759

Reviewed by Tony Gentilcore.

No new tests, removing dead code only.

  • page/Geolocation.cpp:
  • page/Geolocation.h:
  • platform/GeolocationService.h:
  • platform/efl/GeolocationServiceEfl.cpp:
  • platform/efl/GeolocationServiceEfl.h:
  • platform/gtk/GeolocationServiceGtk.cpp:
  • platform/gtk/GeolocationServiceGtk.h:
05:43 Changeset [93595] by podivilov@chromium.org

Web Inspector: switch to using BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=66225

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

05:40 Changeset [93594] by steveblock@google.com

Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755

Reviewed by Tony Gentilcore.

.:

  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

Source/WebCore:

No new tests, removing dead code only.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • gyp/WebCore.gyp:

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:
05:39 Changeset [93593] by tkent@chromium.org

https://bugs.webkit.org/show_bug.cgi?id=66651
Move <input type=range> tests to fast/forms/range/

Reviewed by Tony Chang.

  • fast/forms/ValidityState-stepMismatch-expected.txt: Removed 'range' part.
  • fast/forms/input-appearance-range-rtl-expected.html: Removed.
  • fast/forms/input-appearance-range-rtl.html: Removed.
  • fast/forms/input-appearance-range.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed 'range' part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed 'range' part.
  • fast/forms/input-valueasnumber-range-expected.txt: Removed.
  • fast/forms/input-valueasnumber-range.html: Removed.
  • fast/forms/range: Added.
  • fast/forms/range-default-value-expected.txt: Removed.
  • fast/forms/range-default-value.html: Removed.
  • fast/forms/range-drag-expected.txt: Removed.
  • fast/forms/range-drag.html: Removed.
  • fast/forms/range-input-dynamic-oninput-expected.txt: Removed.
  • fast/forms/range-input-dynamic-oninput.html: Removed.
  • fast/forms/range-keyoperation-expected.txt: Removed.
  • fast/forms/range-keyoperation.html: Removed.
  • fast/forms/range-reset-expected.txt: Removed.
  • fast/forms/range-reset.html: Removed.
  • fast/forms/range-set-attribute-expected.txt: Removed.
  • fast/forms/range-set-attribute.html: Removed.
  • fast/forms/range-thumb-height-percentage.html: Removed.
  • fast/forms/range/ValidityState-stepMismatch-range-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/range/ValidityState-stepMismatch-range.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/range/input-appearance-range-rtl-expected.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl-expected.html.
  • fast/forms/range/input-appearance-range-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl.html.
  • fast/forms/range/input-appearance-range.html: Copied from LayoutTests/fast/forms/input-appearance-range.html.
  • fast/forms/range/input-valueasnumber-range-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-range-expected.txt.
  • fast/forms/range/input-valueasnumber-range.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-range.js.
  • fast/forms/range/range-default-value-expected.txt: Copied from LayoutTests/fast/forms/range-default-value-expected.txt.
  • fast/forms/range/range-default-value.html: Copied from LayoutTests/fast/forms/range-default-value.html.
  • fast/forms/range/range-drag-expected.txt: Copied from LayoutTests/fast/forms/range-drag-expected.txt.
  • fast/forms/range/range-drag.html: Copied from LayoutTests/fast/forms/range-drag.html.
  • fast/forms/range/range-input-dynamic-oninput-expected.txt: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput-expected.txt.
  • fast/forms/range/range-input-dynamic-oninput.html: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput.html.
  • fast/forms/range/range-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/range-keyoperation-expected.txt.
  • fast/forms/range/range-keyoperation.html: Copied from LayoutTests/fast/forms/range-keyoperation.html.
  • fast/forms/range/range-reset-expected.txt: Copied from LayoutTests/fast/forms/range-reset-expected.txt.
  • fast/forms/range/range-reset.html: Copied from LayoutTests/fast/forms/range-reset.html.
  • fast/forms/range/range-set-attribute-expected.txt: Copied from LayoutTests/fast/forms/range-set-attribute-expected.txt.
  • fast/forms/range/range-set-attribute.html: Copied from LayoutTests/fast/forms/range-set-attribute.html.
  • fast/forms/range/range-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/range/range-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/range/range-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/range/range-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/range/range-thumb-height-percentage.html: Copied from LayoutTests/fast/forms/range-thumb-height-percentage.html.
  • fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb-expected.txt.
  • fast/forms/range/slider-delete-while-dragging-thumb.html: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb.html.
  • fast/forms/range/slider-hit-testing-expected.txt: Copied from LayoutTests/fast/forms/slider-hit-testing-expected.txt.
  • fast/forms/range/slider-hit-testing.html: Copied from LayoutTests/fast/forms/slider-hit-testing.html.
  • fast/forms/range/slider-mouse-events-expected.txt: Copied from LayoutTests/fast/forms/slider-mouse-events-expected.txt.
  • fast/forms/range/slider-mouse-events.html: Copied from LayoutTests/fast/forms/slider-mouse-events.html.
  • fast/forms/range/slider-onchange-event-expected.txt: Copied from LayoutTests/fast/forms/slider-onchange-event-expected.txt.
  • fast/forms/range/slider-onchange-event.html: Copied from LayoutTests/fast/forms/slider-onchange-event.html.
  • fast/forms/range/slider-padding.html: Copied from LayoutTests/fast/forms/slider-padding.html.
  • fast/forms/range/slider-thumb-shared-style.html: Copied from LayoutTests/fast/forms/slider-thumb-shared-style.html.
  • fast/forms/range/slider-thumb-stylability.html: Copied from LayoutTests/fast/forms/slider-thumb-stylability.html.
  • fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/fast/forms/slider-transformed-expected.txt.
  • fast/forms/range/slider-transformed.html: Copied from LayoutTests/fast/forms/slider-transformed.html.
  • fast/forms/range/slider-zoomed-expected.txt: Copied from LayoutTests/fast/forms/slider-zoomed-expected.txt.
  • fast/forms/range/slider-zoomed.html: Copied from LayoutTests/fast/forms/slider-zoomed.html.
  • fast/forms/range/thumbslider-crash-expected.txt: Copied from LayoutTests/fast/forms/thumbslider-crash-expected.txt.
  • fast/forms/range/thumbslider-crash.html: Copied from LayoutTests/fast/forms/thumbslider-crash.html.
  • fast/forms/range/thumbslider-no-parent-slider.html: Copied from LayoutTests/fast/forms/thumbslider-no-parent-slider.html.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: Removed 'range' part.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'range' part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed 'range' part.
  • fast/forms/script-tests/input-valueasnumber-range.js: Removed.
  • fast/forms/slider-delete-while-dragging-thumb-expected.txt: Removed.
  • fast/forms/slider-delete-while-dragging-thumb.html: Removed.
  • fast/forms/slider-hit-testing-expected.txt: Removed.
  • fast/forms/slider-hit-testing.html: Removed.
  • fast/forms/slider-mouse-events-expected.txt: Removed.
  • fast/forms/slider-mouse-events.html: Removed.
  • fast/forms/slider-onchange-event-expected.txt: Removed.
  • fast/forms/slider-onchange-event.html: Removed.
  • fast/forms/slider-padding.html: Removed.
  • fast/forms/slider-thumb-shared-style.html: Removed.
  • fast/forms/slider-thumb-stylability.html: Removed.
  • fast/forms/slider-transformed-expected.txt: Removed.
  • fast/forms/slider-transformed.html: Removed.
  • fast/forms/slider-zoomed-expected.txt: Removed.
  • fast/forms/slider-zoomed.html: Removed.
  • fast/forms/thumbslider-crash-expected.txt: Removed.
  • fast/forms/thumbslider-crash.html: Removed.
  • fast/forms/thumbslider-no-parent-slider.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/range: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/range: Added.
  • platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.txt.
  • platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/chromium-linux/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-padding-expected.png.
  • platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-linux/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-linux/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/chromium-win/fast/forms/range: Added.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.png.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.txt.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.png.
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png.
  • platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/chromium-win/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-win/fast/forms/slider-padding-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/gtk/fast/forms/range: Added.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-range-expected.txt.
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/gtk/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png.
  • platform/gtk/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt.
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.png.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/gtk/fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-transformed-expected.txt.
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/gtk/fast/forms/slider-padding-expected.png: Removed.
  • platform/gtk/fast/forms/slider-padding-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/gtk/fast/forms/slider-transformed-expected.txt: Removed.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/range: Added.
  • platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/mac-leopard/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-padding-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
  • platform/mac-leopard/fast/forms/slider-padding-expected.png: Removed.
  • platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-range-expected.txt: Removed.
  • platform/mac/fast/forms/range: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Removed.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/mac/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png.
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.txt.
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.png.
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/mac/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.png.
  • platform/mac/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt.
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.png.
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png.
  • platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/mac/fast/forms/slider-padding-expected.png: Removed.
  • platform/mac/fast/forms/slider-padding-expected.txt: Removed.
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/mac/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/range: Added.
  • platform/qt/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/range-thumb-height-percentage-expected.txt.
  • platform/qt/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-shared-style-expected.txt.
  • platform/qt/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-stylability-expected.txt.
  • platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.
  • platform/qt/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
  • platform/qt/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/wk2/Skipped:
05:38 Changeset [93592] by benjamin.poulain@nokia.com

[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually
https://bugs.webkit.org/show_bug.cgi?id=66672

Reviewed by Kenneth Rohde Christiansen.

Add the method animateContentIntoBoundariesIfNeeded() to move the content back into both scale and position boundaries.
This method is now used as the entry point for animations in order to avoid bugs regarding scale or position.

The existing animation methods were renamed accordingly for clarity and consistency with the updateContent methods.

  • UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):

  • UIProcess/qt/ViewportInteractionEngine.h:
05:21 Changeset [93591] by mnaganov@chromium.org

Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):

03:34 Changeset [93590] by abarth@webkit.org

Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739

Reviewed by Steve Block.

Now that Android shares more code with Chromium, we don't need these
Android-specific files.

Source/JavaScriptCore:

  • wtf/android: Removed.
  • wtf/android/AndroidThreading.h: Removed.
  • wtf/android/MainThreadAndroid.cpp: Removed.

Source/WebCore:

  • editing/android: Removed.
  • editing/android/EditorAndroid.cpp: Removed.
  • history/android: Removed.
  • history/android/AndroidWebHistoryBridge.h: Removed.
  • history/android/HistoryItemAndroid.cpp: Removed.
  • page/android: Removed.
  • page/android/DragControllerAndroid.cpp: Removed.
  • page/android/EventHandlerAndroid.cpp: Removed.
  • platform/network/android: Removed.
  • platform/network/android/AuthenticationChallenge.h: Removed.
  • platform/network/android/CookieJarAndroid.cpp: Removed.
  • platform/network/android/ProxyServerAndroid.cpp: Removed.
  • platform/network/android/ResourceError.h: Removed.
  • platform/network/android/ResourceHandleAndroid.cpp: Removed.
  • platform/network/android/ResourceLoaderAndroid.h: Removed.
  • platform/network/android/ResourceRequest.h: Removed.
  • platform/network/android/ResourceRequestAndroid.cpp: Removed.
  • platform/network/android/ResourceResponse.h: Removed.
  • platform/text/android: Removed.
  • platform/text/android/HyphenationAndroid.cpp: Removed.
  • platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.
02:59 Changeset [93589] by abarth@webkit.org

Remove WebCore/platform/android
https://bugs.webkit.org/show_bug.cgi?id=66734

Reviewed by Steve Block.

This directory is not needed now that Android shares more code with
Chromium.

  • platform/android: Removed.
  • platform/android/ClipboardAndroid.cpp: Removed.
  • platform/android/ClipboardAndroid.h: Removed.
  • platform/android/CursorAndroid.cpp: Removed.
  • platform/android/DragDataAndroid.cpp: Removed.
  • platform/android/EventLoopAndroid.cpp: Removed.
  • platform/android/FileSystemAndroid.cpp: Removed.
  • platform/android/GeolocationServiceAndroid.cpp: Removed.
  • platform/android/GeolocationServiceAndroid.h: Removed.
  • platform/android/GeolocationServiceBridge.cpp: Removed.
  • platform/android/GeolocationServiceBridge.h: Removed.
  • platform/android/KeyEventAndroid.cpp: Removed.
  • platform/android/LanguageAndroid.cpp: Removed.
  • platform/android/LocalizedStringsAndroid.cpp: Removed.
  • platform/android/PlatformBridge.h: Removed.
  • platform/android/PlatformTouchEventAndroid.cpp: Removed.
  • platform/android/PlatformTouchPointAndroid.cpp: Removed.
  • platform/android/PopupMenuAndroid.cpp: Removed.
  • platform/android/RenderThemeAndroid.cpp: Removed.
  • platform/android/RenderThemeAndroid.h: Removed.
  • platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
  • platform/android/ScreenAndroid.cpp: Removed.
  • platform/android/ScrollViewAndroid.cpp: Removed.
  • platform/android/SearchPopupMenuAndroid.cpp: Removed.
  • platform/android/SharedTimerAndroid.cpp: Removed.
  • platform/android/SoundAndroid.cpp: Removed.
  • platform/android/SystemTimeAndroid.cpp: Removed.
  • platform/android/TemporaryLinkStubs.cpp: Removed.
  • platform/android/WidgetAndroid.cpp: Removed.
02:52 Changeset [93588] by abarth@webkit.org

webkitpy/common/config/build.py shouldn't mention non-existant Android directory
https://bugs.webkit.org/show_bug.cgi?id=66737

Reviewed by Steve Block.

This directory doesn't exist anymore now that the Android port shares
more code with Chromium.

  • Scripts/webkitpy/common/config/build.py:
02:47 Changeset [93587] by pfeldman@chromium.org

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Adding a file that slipped from r93586.

  • inspector/generate-protocol-externs: Added.
02:33 Changeset [93586] by pfeldman@chromium.org

Web Inspector: generate protocol externs API for the front-end compilation.
https://bugs.webkit.org/show_bug.cgi?id=66677

Reviewed by Tony Gentilcore.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesText):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/compile-front-end.sh: Added.
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.setAttribute):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):

  • inspector/front-end/externs.js: Added.

(console.warn):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex.html:
02:32 Changeset [93585] by loislo@chromium.org

2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for compile error on Windows for r93560.

  • runtime/SamplingCounter.h:
02:23 Changeset [93584] by pfeldman@chromium.org

Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656

Removes "this" usage in functions, does not define getters for offsets.

Reviewed by Tony Gentilcore.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):

  • inspector/front-end/Toolbar.js:

(WebInspector.ToolbarDropdown.prototype.show):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

  • inspector/front-end/inspector.js:

(Number.secondsToString):
(Number.bytesToString):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():

01:50 Changeset [93583] by ossy@webkit.org

Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.

  • fast/loader/document-destruction-within-unload-expected.txt:
  • fast/loader/document-destruction-within-unload.html:
01:43 Changeset [93582] by ossy@webkit.org

[WK2] Unreviewed gardening.

  • platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.
01:25 Changeset [93581] by reni@webkit.org

[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749

Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.

  • platform/qt/Skipped:

08/22/11:

22:45 Changeset [93580] by commit-queue@webkit.org

Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587

Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.

Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.

  • platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.
21:09 Changeset [93579] by tonyg@chromium.org

[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

20:55 Changeset [93578] by commit-queue@webkit.org

Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745

Breaks layout tests (Requested by koz2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
  • accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.
19:53 Changeset [93577] by commit-queue@webkit.org

Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744

Does not compile on chromium canaries (Requested by jamesr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
19:53 Changeset [93576] by jamesr@google.com

Chromium crash fix, just for this branch.

BUG=93824

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::paintLayerContents):

19:15 Changeset [93575] by commit-queue@webkit.org

[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

  • src/WebSettingsImpl.h:
19:07 Changeset [93574] by commit-queue@webkit.org

Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.

Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)

  • dom/Range.cpp:

(WebCore::Range::setEnd):

19:05 Changeset [93573] by abarth@webkit.org

Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741

Reviewed by Darin Adler.

PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness. These special
cases can be removed now that Android shares more code with Chromium.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • bindings/v8/ScriptCachedFrameData.cpp:
  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/V8GCController.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):

  • history/HistoryItem.h:
  • loader/cache/CachedFont.cpp:
  • platform/DragImage.h:
  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/Widget.h:
  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/NetworkingContext.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:
19:02 Changeset [93572] by commit-queue@webkit.org

[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.

Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.

This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_private.h:
18:35 Changeset [93571] by enne@google.com

[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731

Reviewed by James Robinson.

The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):

  • platform/graphics/chromium/LayerRendererChromium.h:
18:07 Changeset [93570] by pkasting@chromium.org

[chromium] Mark some tests on Mac as flakily crashing.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:03 Changeset [93569] by kerz@chromium.org

Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser. Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky. In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it. Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

  • fast/loader/reload-zero-byte-plugin-expected.txt: Added.
  • fast/loader/reload-zero-byte-plugin.html: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7685041

17:49 Changeset [93568] by pkasting@chromium.org

[chromium] Mark some tests on Windows as flaky.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:43 Changeset [93567] by ap@apple.com

showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
https://bugs.webkit.org/show_bug.cgi?id=53191
<rdar://problem/8629478>

Reviewed by Geoff Garen.

Cannot test domain relaxing, we only have 127.0.0.1 and localhost.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): Added a FIXME about a difference with Firefox.

(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
Changed to fetch returnValue from the global object that's in the frame when the dialog is
dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
if the origin doesn't match opener origin (which the case with domain relaxing).
Re-added a security check for returnValue that got lost in r73829, so that we don't send the
result across origins. This matches Firefox.

  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion against a very confusing case that should no longer occur.
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive call to avoid changing life support timer behavior in this patch.
17:37 Changeset [93566] by commit-queue@webkit.org

[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704

Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

17:24 Changeset [93565] by commit-queue@webkit.org

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.

aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351

Source/WebCore:

Test: accessibility/aria-labelledby-overrides-aria-labeledby.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
  • accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.
17:14 Changeset [93564] by nduca@chromium.org

Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::texImage2DResourceSafe):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::isResourceSafe):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):

  • src/GraphicsContext3DInternal.h:
17:05 Changeset [93563] by eric@webkit.org

Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script. If this doesn't
work we'll just live with the it hung for now.

Unreviewed.

  • EWSTools/start-queue.sh:
16:53 Changeset [93562] by dglazkov@chromium.org

webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,

in which case the serializer treats all expectations as unparsed.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
16:52 Changeset [93561] by abarth@webkit.org

HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728

Reviewed by Darin Adler.

Source/WebCore:

If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input. If
the future input is small enough, that will walk off the end of the
input and crash.

Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

LayoutTests:

Test that we don't crash when we get a bad network packet boundary.

  • http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
  • http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
  • http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
16:41 Changeset [93560] by fpizlo@apple.com

Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724

Reviewed by Darin Adler.

Moved SamplingCounter to a separate header in runtime/.

  • GNUmakefile.list.am:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/SamplingTool.cpp:
  • bytecode/SamplingTool.h:
  • runtime/SamplingCounter.cpp: Added.

(JSC::AbstractSamplingCounter::dump):

  • runtime/SamplingCounter.h: Added.

(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):

16:34 Changeset [93559] by eric@webkit.org

Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721

Reviewed by Ryosuke Niwa.

bidiNext and bidiFirst are horribly confusing.
Even worse is that bidiNext takes a bunch of mutually exclusive options.
It appears that there is a "return me every inline, even if its empty"
mode which is only used for simplified inline layout in RenderBlock.cpp.
To support that mode, there is a endOfInline pointer which keeps track
of if we just returned at the end of an inline to so we don't get stuck in
and empty inline (unable to distinguish the start from the finish).

The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.)

This change renames bidiNext to bidiNextShared (still a horrible name) and moves
all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
It becomes obvious which code uses which.

In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.

No functional change, thus no tests.

  • rendering/InlineIterator.h:

(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
(WebCore::bidiFirstIncludingEmptyInlines):
(WebCore::InlineWalker::InlineWalker):
(WebCore::InlineWalker::advance):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

16:30 Changeset [93558] by levin@chromium.org

Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725

Reviewed by Darin Adler.

No new functionality exposed so no new tests.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent): Ditto.

  • bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage): Ditto.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create): Ditto.

  • workers/SharedWorkerContext.cpp:

(WebCore::createConnectEvent): Added release() when a RefPtr is returned.

16:24 Changeset [93557] by macpherson@chromium.org

Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648

Reviewed by Dan Bernstein.

No new tests / no functionality changed.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

16:15 Changeset [93556] by pkasting@chromium.org

Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143

Broke Leopard, SnowLeopard, and Chromium Mac bots

Source/WebCore:

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

LayoutTests:

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
16:08 Changeset [93555] by oliver@apple.com

Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717

Reviewed by Anders Carlsson.

Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::releaseObject):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:

(WebKit::trySafeReleaseNPObject):

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
16:08 Changeset [93554] by tony@chromium.org

Move chromium-mac/plugins/keyboard-events-expected.txt to
chromium-cg-mac/plugins/keyboard-events-expected.txt since the results
for chromium-mac are currently in chromium-cg-mac. This result was
added in r93519 and put in the wrong place.

  • platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt.
  • platform/chromium-mac/plugins: Removed.
  • platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed.
15:44 Changeset [93553] by adamk@chromium.org

[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711

Reviewed by Tony Chang.

The Chromium side of this patch was submitted as
http://crrev.com/97687.

  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:

(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

15:35 Changeset [93552] by dglazkov@chromium.org

Update unit test expectations after r93530.

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
15:20 Changeset [93551] by tony@chromium.org

Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701

Reviewed by Eric Seidel.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
15:08 Changeset [93550] by andersca@apple.com

Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722

Reviewed by Darin Adler.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):

  • UIProcess/API/mac/WKViewInternal.h:
15:01 Changeset [93549] by rniwa@webkit.org

Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
because r93529 didn't fix it. The failure is still tracked by the bug 66514.

  • platform/qt/Skipped:
14:56 Changeset [93548] by andersca@apple.com

Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:49 Changeset [93547] by tony@chromium.org

handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/002.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is

auto, treat it as flex(1 0 0).

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.

LayoutTests:

  • css3/flexbox/002-expected.txt: Added.
  • css3/flexbox/002.html: Added.
  • css3/flexbox/resources/flexbox.js:

(checkHorizontalBoxen):

14:46 Changeset [93546] by msaboff@apple.com

REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464

Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

14:45 Changeset [93545] by dglazkov@chromium.org

[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
14:38 Changeset [93544] by andersca@apple.com

Use -[NSApplication updateWindows] to update the current input context
https://bugs.webkit.org/show_bug.cgi?id=66715

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:35 Changeset [93543] by andersca@apple.com

The UI process should keep track of whether a plug-in has focus or not
https://bugs.webkit.org/show_bug.cgi?id=66712

Reviewed by Darin Adler.

This is in preparation for implementing the updated Cocoa text input model.

Pipe through whether a plug-in and its containing window has focus or not, from the
plug-in process and all the way to the UI process.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginFocusOrWindowFocusChanged):

  • WebProcess/Plugins/PluginView.h:
14:23 Changeset [93542] by nduca@chromium.org

[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696

Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

14:13 Changeset [93541] by pkasting@chromium.org

[chromium] Disable compositing tests for Leopard.

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
14:07 Changeset [93540] by caryclark@google.com

Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703

This error was detected by the debug build of the Chromium WebKit
Canary.

Reviewed by James Robinson.

No new tests. This change suppresses a compile-time warning
but does not affect the generated code.

  • platform/graphics/mac/FontCustomPlatformData.h:

Replaced struct with class in a forward reference.

14:05 Changeset [93539] by andersca@apple.com

Update the current NSTextInputContext whenever the plug-in complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66709

Reviewed by Sam Weinig.

Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input
context. Fixes a rare case when the out-of-line editing window wouldn't appear.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

14:04 Changeset [93538] by commit-queue@webkit.org

[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html

fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

  • rendering/RenderFlowThread.h:

(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
13:53 Changeset [93537] by dglazkov@chromium.org

Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.

  • DEPS: Done it.
13:45 Changeset [93536] by levin@chromium.org

REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Darin Adler.

Added tests which are similar to the non worker test with the same name.

  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added.
  • http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added.
  • http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added.
13:39 Changeset [93535] by dglazkov@chromium.org

Roll Chromium DEPS to 97698.

  • DEPS: Rolled.
13:38 Changeset [93534] by jamesr@google.com

[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac

  • platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac.
  • platform/chromium-gpu-mac: Removed.
13:34 Changeset [93533] by jam@chromium.org

Merge 93296 - Prepare frames for history navigation.

Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.

https://bugs.webkit.org/show_bug.cgi?id=66322

Reviewed by Darin Fisher.

Source/WebCore:

No new tests, as history navigation is very difficult to test in
DumpRenderTree.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForHistoryNavigation):

  • loader/FrameLoader.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):

TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/7711011

13:23 Changeset [93532] by pkasting@chromium.org

Unreviewed, rolling out r93517.
http://trac.webkit.org/changeset/93517
https://bugs.webkit.org/show_bug.cgi?id=63553

Breaks GTK Linux and Chromium Win

Source/WebCore:

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Removed.
  • svg/animations/animate-end-attribute.html: Removed.
  • svg/animations/script-tests/animate-end-attribute.js: Removed.
13:05 Changeset [93531] by commit-queue@webkit.org

FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-22
Reviewed by Darin Adler.

setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):

12:35 Changeset [93530] by jamesr@google.com

[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693

Reviewed by Dirk Pranke.

Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.

  • Scripts/webkitpy/layout_tests/port/builders.py:
12:12 Changeset [93529] by rniwa@webkit.org

editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551

Reviewed by Adam Roben.

Replaced leapForward by dummy clicks to make it work on Windows and other ports.

  • editing/selection/caret-at-bidi-boundary.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:08 Changeset [93528] by tony@chromium.org

Add CSS parsing of -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=65384

Source/WebCore:

The property is an int described here:
http://dev.w3.org/csswg/css3-flexbox/#flex-order

Doesn't do anything yet, just hooking it up.

Reviewed by Ojan Vafai.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexOrder):
(WebCore::InheritedFlags::setFlexOrder):
(WebCore::InheritedFlags::initialFlexOrder):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/script-tests/css-properties.js:
12:03 Changeset [93527] by dpranke@chromium.org

fix the GPU bot names on the layout test dashboard
https://bugs.webkit.org/show_bug.cgi?id=66697

Reviewed by Dimitri Glazkov.

  • TestResultServer/static-dashboards/builders.js:
11:49 Changeset [93526] by enne@google.com

[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691

Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::protectTileTextures):

11:30 Changeset [93525] by kerz@chromium.org

Merge 93042 - Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7708013

11:28 Changeset [93524] by kerz@chromium.org

Merge 92764 - Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
https://bugs.webkit.org/show_bug.cgi?id=65918

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-commit-editing.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/7708012

11:18 Changeset [93523] by commit-queue@webkit.org

[chromium] Content and render surface textures not freed when compositor context destroyed
https://bugs.webkit.org/show_bug.cgi?id=66589

Patch by James Robinson <jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

Explicitly delete all managed textures when destroying the compositor
context. This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.

We sadly don't have a way to construct automated tests for resource
leaks currently.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::cleanupSharedObjects):

11:15 Changeset [93522] by dglazkov@chromium.org

garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
11:12 Changeset [93521] by japhet@chromium.org

Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741

Reviewed by Adam Barth.

Test: fast/loader/document-destruction-within-unload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): Prevent unload events

from going into infinite recursion.

(WebCore::FrameLoader::setDocumentLoader): Ensure we don't

let set m_documentLoader to a DocumentLoader with a null Frame*.

(WebCore::FrameLoader::detachChildren): Save off a vector of

children to detach, rather than doing it inline.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.

Reviewed by Adam Barth.

  • fast/loader/document-destruction-within-unload-expected.txt: Added.
  • fast/loader/document-destruction-within-unload.html: Added.
  • fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
  • fast/loader/resources/document-destruction-within-unload.svg: Added.
11:07 Changeset [93520] by enne@google.com

[chromium] Skip rtl-composited, as it causes other tests to crash.

Unreviewed expectation change.

  • platform/chromium/test_expectations.txt:
11:06 Changeset [93519] by commit-queue@webkit.org

[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.

Update the Chromium Linux test results following r88712. Also rebaseline test results
for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events. The Chromium port reports the actual line number, hence
the need for separate test results for Chromium. The test now runs, and passes on all
the Chromium ports, following r87855. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 34936.

  • platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
  • platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:03 Changeset [93518] by commit-queue@webkit.org

Rebaseline for webkit bug 65295
https://bugs.webkit.org/show_bug.cgi?id=66637

Patch by Ben Wells <benwells@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

  • fast/box-shadow/box-shadow-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt.
  • fast/layers/self-painting-outline-expected.txt: Renamed from LayoutTests/platform/gtk/fast/layers/self-painting-outline-expected.txt.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.png: Renamed from LayoutTests/fast/box-shadow/box-shadow-radius-expected.png.
  • platform/mac/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
11:00 Changeset [93517] by commit-queue@webkit.org

Patch by Young Han Lee <joybro@company100.net> on 2011-08-22
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

10:49 Changeset [93516] by gyuyoung.kim@samsung.com

Fix build error when inspector is disabled.
https://bugs.webkit.org/show_bug.cgi?id=66644

Reviewed by Darin Adler.

  • inspector/InspectorDatabaseResource.h: Add ENABLE(INSPECTOR) macro.
10:49 Changeset [93515] by commit-queue@webkit.org

Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):
(buildChromium):

10:33 Changeset [93514] by inferno@chromium.org

Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678

Source/WebCore:

RefPtr the focusable node to prevent getting deleted by mutation
event.

Reviewed by Dave Hyatt.

Test: fast/frames/focus-controller-crash-change-event.html

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/frames/focus-controller-crash-change-event-expected.txt: Added.
  • fast/frames/focus-controller-crash-change-event.html: Added.
10:07 Changeset [93513] by mrobinson@webkit.org

[GTK] Some GTK+-specific font-face tests fail on the bots
https://bugs.webkit.org/show_bug.cgi?id=65820

Fix the timing issues in this test.

Reviewed by Philippe Normand.

  • platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until

after document.readyState moves to "complete" and a short timeout.

  • platform/gtk/fonts/font-face-with-complex-text.html: Ditto.
09:02 Changeset [93512] by commit-queue@webkit.org

Source/WebCore: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Replacing the crash with a more graceful failure: canvas
will not render.

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
This is the non-crashing version of the factory function.
It returns NULL if allocation fails. Code for handling
NULL pointer was already in place.

Source/WebKit/chromium: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

  • DEPS:

Bumping up the chrome DEPS to pick up 97474, which is
required by this patch.

08:52 Changeset [93511] by commit-queue@webkit.org

Add myself to the contributor list.
https://bugs.webkit.org/show_bug.cgi?id=66674

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-22
Reviewed by Tony Gentilcore.

  • Scripts/webkitpy/common/config/committers.py:
08:36 Changeset [93510] by loislo@chromium.org

Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670

jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm:

(GenerateInterface):
(generateBackendStubJS):

  • inspector/front-end/ApplicationCacheItemsView.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineDispatcher):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):

  • inspector/front-end/inspector.js:
08:17 Changeset [93509] by kbalazs@webkit.org

[Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299

Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/qt/ImageDiff.cpp:

(main):

06:43 Changeset [93508] by ossy@webkit.org

[NRWT] Fix "Only unexpected results" option of results.html
https://bugs.webkit.org/show_bug.cgi?id=66657

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

  • fast/harness/results.html:
06:26 Changeset [93507] by benjamin.poulain@nokia.com

Fix generate-inspector-idl for Python3 after r93396
https://bugs.webkit.org/show_bug.cgi?id=66663

Reviewed by Andreas Kling.

In Python3, print is a function instead of a language keyword. Using parentheses
around the argument ensures the code works for both Python 2 and 3.

  • inspector/generate-inspector-idl:
05:22 Changeset [93506] by vitalyr@chromium.org

2011-08-22 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Updating test expectations.

Unreviewed.

  • platform/chromium/test_expectations.txt:
05:06 Changeset [93505] by commit-queue@webkit.org

[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
https://bugs.webkit.org/show_bug.cgi?id=66649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-22
Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • http/tests/websocket/tests/hybi/close-before-open.html:

Add new URL to reproduce the problem.

05:03 Changeset [93504] by ossy@webkit.org

Update contributor list.

Reviewed by Zoltan Herczeg.

  • Scripts/webkitpy/common/config/committers.py:
04:53 Changeset [93503] by keishi@webkit.org

Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.

  • html/ColorInputType.h:
03:05 Changeset [93502] by ossy@webkit.org

[ORWT] Fix --reset-results --add-platform-exceptions combo
https://bugs.webkit.org/show_bug.cgi?id=65464

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
02:17 Changeset [93501] by podivilov@chromium.org

Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/breakpoint-manager.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Added.

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get rawSourceCode):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt: Added.
  • inspector/debugger/breakpoint-manager.html: Added.
02:09 Changeset [93500] by zoltan@webkit.org

[Qt][ARM] Add bug report to flaky tests

http/tests/cache/subresource-multiple-instances.html
https://bugs.webkit.org/show_bug.cgi?id=66652

http/tests/inspector/resource-tree/resource-tree-errors-reload.html
https://bugs.webkit.org/show_bug.cgi?id=66653

  • platform/qt-arm/Skipped:
02:07 Changeset [93499] by cevans@google.com

Merge 93347
BUG=90357
Review URL: http://codereview.chromium.org/7696023

02:04 Changeset [93498] by cevans@google.com

Merge 93032
BUG=92769
Review URL: http://codereview.chromium.org/7693023

01:56 Changeset [93497] by cevans@google.com

Merge 93227
BUG=92959
Review URL: http://codereview.chromium.org/7694026

01:49 Changeset [93496] by cevans@google.com

Merge 92132
BUG=89991
Review URL: http://codereview.chromium.org/7693022

01:39 Changeset [93495] by cevans@google.com

Merge 93397
BUG=76771
Review URL: http://codereview.chromium.org/7697013

01:05 Changeset [93494] by zoltan@webkit.org

[Qt][ARM] Skip flaky tests.

  • platform/qt-arm/Skipped:

08/21/11:

21:04 Changeset [93493] by jamesr@google.com

Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063

Reviewed by Darin Fisher.

Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.

Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.

Patch originally by Tom Hudson.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

BUG=93558
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7696019

18:10 Changeset [93492] by mrobinson@webkit.org

Fix 'make dist' for WebKitGTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add a missing header to the sources list.

Source/WebCore:

  • GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
  • GNUmakefile.list.am: Update the sources list to reflect reality.
13:22 Changeset [93491] by darin@apple.com

Update results for more tests affected by the addition of the
HTMLSourceElement class.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
08:53 Changeset [93490] by commit-queue@webkit.org

[Qt] Fixes premature plugin unload bug
https://bugs.webkit.org/show_bug.cgi?id=66628

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.

The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.

  • WebCoreSupport/TextCheckerClientQt.cpp:

(WebCore::TextCheckerClientQt::loadSpellChecker):

  • WebCoreSupport/TextCheckerClientQt.h:

08/20/11:

23:26 Changeset [93489] by tkent@chromium.org

Merge 93382 - REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/placeholder-crash-with-scrollbar-corner.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.

LayoutTests:

  • fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
  • fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.

TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/7703003

22:27 Changeset [93488] by commit-queue@webkit.org

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

  • ewk/ewk_view.h:

Fixes description of method, parameters and returned value of API
related to settings.

22:21 Changeset [93487] by ddkilzer@apple.com

JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Changed the handling of const to add the dynamic scope depth.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ConstDeclNode::emitCodeSingle):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Added tests that reproduce the failure.

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:

(tryCatch1):
(tryCatch2):
(with1):
(with2):

22:14 Changeset [93486] by commit-queue@webkit.org

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.

  • ewk/ewk_view.h:
21:50 Changeset [93485] by commit-queue@webkit.org

[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.

  • ewk/ewk_view.h:
21:37 Changeset [93484] by commit-queue@webkit.org

Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

Covered by existing tests, and no code was changed.

  • WebCore.gyp/WebCore.gyp:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createNewContext):

Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

  • DEPS:
13:37 Changeset [93483] by abarth@webkit.org

garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625

Reviewed by Dimitri Glazkov.

This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction. The
patch also adds an Examine button to failure notifications. In a
future patch, I'll add a controller that wires this button up to
something useful.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
11:40 Changeset [93482] by commit-queue@webkit.org

instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.

Source/WebCore:

Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):

  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.idl:

LayoutTests:

Updated test results after adding HTMLSourceElement to the DOMWindow

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
11:11 Changeset [93481] by darin@apple.com

If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/dom/Range/insertNode-empty-fragment-crash.html

  • dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion

if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.

LayoutTests:

  • fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
  • fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
08:54 Changeset [93480] by abarth@webkit.org

garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624

Reviewed by Dimitri Glazkov.

This patch creates a notification-based UI for build failures. The new
UI displays the same information that used to be displayed in the
infobar. There's lots of room for improvement in surfacing more
information, but this is a start.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
05:27 Changeset [93479] by kbalazs@webkit.org

eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening.

  • platform/wk2/Skipped: Skip dependent test.
05:15 Changeset [93478] by kbalazs@webkit.org

[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626

Unreviewed gardening.

  • platform/qt/Skipped:
00:30 Changeset [93477] by commit-queue@webkit.org

OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.

Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):

LayoutTests:

Added test case covering keySpline array length problem.

  • svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.
Note: See TracTimeline for information about the timeline view.