Timeline


and

08/28/11:

23:49 WebKitGtkLayoutTests edited by nayankk@motorola.com
(diff)
23:09 Changeset [93954] by loislo@chromium.org

Merge 93868 - Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7778006

20:49 Changeset [93953] by keishi@webkit.org

Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

  • fast/css/square-button-appearance-expected.txt: Added.
  • fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
  • platform/gtk/test_expectations.txt: Added this test as expected to fail.
  • platform/mac/fast/css/square-button-appearance-expected.png: Added.
  • platform/qt/test_expectations.txt: Added this test as expected to fail.
17:26 Changeset [93952] by macpherson@chromium.org

Fix reference counting of values in CSSSelector.
https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

  • css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

16:58 Changeset [93951] by weinig@apple.com

Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support. This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add files.

  • bindings/generic/EventConstructors.h: Added.

Add binding agnostic header that defines the Event initializers
using a macro based DSL.

  • bindings/js/JSEventConstructors.cpp: Added.

(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

  • dom/Event.cpp:

(WebCore::EventInit::EventInit):
(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::create):
Add Event initializer interface for base Event.

  • dom/Event.idl:

Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

  • fast/events/constructors/event-constructors-expected.txt: Added.
  • fast/events/constructors/event-constructors.html: Added.
12:24 Changeset [93950] by commit-queue@webkit.org

Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

  • wtf/Platform.h:
12:14 Changeset [93949] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

08/27/11:

15:01 Changeset [93948] by robert@webkit.org

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
14:49 Changeset [93947] by fpizlo@apple.com

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

14:31 Changeset [93946] by commit-queue@webkit.org

Add a build bot for Chromium with OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:12 Changeset [93945] by commit-queue@webkit.org

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

14:03 Changeset [93944] by robert@webkit.org

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
13:22 Changeset [93943] by andersca@apple.com

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 Changeset [93942] by commit-queue@webkit.org

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 Changeset [93941] by commit-queue@webkit.org

Shrink RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 Changeset [93940] by enne@google.com

[chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < jamesr@chromium.org> on 2011-08-26
From http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 Changeset [93939] by commit-queue@webkit.org

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 Changeset [93938] by commit-queue@webkit.org

Patch by Young Han Lee <joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

04:06 Changeset [93937] by commit-queue@webkit.org

[Qt] Need spin-button implementation
https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
00:54 Changeset [93936] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.

08/26/11:

21:42 Changeset [93935] by xji@chromium.org

Regression(91788): Bad cast in WebCore::blockWithNextLineBox
https://bugs.webkit.org/show_bug.cgi?id=66090

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is more like (but not exactly) a revert of r91788.
It does not search for previous or next root inline box in different
render object, which completely eliminates the cause of this issue.
And it removes createPositionAvoidingIgnoredNode(), changed its caller
to use createLegacyEditingPosition(). createPositionAvoidingIgnoredNode
is not correct when node is a replaced element whose caretMaxOffset
could be greater than 1.

Tests: editing/selection/move-by-word-visually-crash-test-1.html

editing/selection/move-by-word-visually-crash-test-2.html
editing/selection/move-by-word-visually-crash-test-3.html
editing/selection/move-by-word-visually-crash-test-4.html

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::leftmostPositionInRTLBoxInLTRBlock):
(WebCore::rightmostPositionInLTRBoxInRTLBlock):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-1-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-1.html: Added.
  • editing/selection/move-by-word-visually-crash-test-2-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-2.html: Added.
  • editing/selection/move-by-word-visually-crash-test-3-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-3.html: Added.
  • editing/selection/move-by-word-visually-crash-test-4-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-4.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/resources/move-by-word-visually.js:

(runMoveLeftRight):

21:19 Changeset [93934] by barraclough@apple.com

DFG JIT - ArithMod may clobber operands.
https://bugs.webkit.org/show_bug.cgi?id=67085

Reviewed by Sam Weinig.

Source/JavaScriptCore:

unboxDouble must be called on a temporary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

LayoutTests:

Added test case.

  • fast/js/mod-crash-expected.txt:
  • fast/js/script-tests/mod-crash.js:

(nonSpeculativeModReuseInner):
(nonSpeculativeModReuse):

20:51 Changeset [93933] by abarth@webkit.org

garden-o-matic should let me know that I need to run the local server
https://bugs.webkit.org/show_bug.cgi?id=66985

Reviewed by Dimitri Glazkov.

The patch triggers an alert dialog whenever the user tries to use a
feature that requires the local server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
19:15 Changeset [93932] by commit-queue@webkit.org

Cleanup resulting text of media/track tests.
https://bugs.webkit.org/show_bug.cgi?id=67073

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-26
Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/video-test.js:

(testCues):

18:05 Changeset [93931] by weinig@apple.com

Stop using custom NSErrors for WebKit2 WebErrors
https://bugs.webkit.org/show_bug.cgi?id=67075

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):
(WebKit::cancelledError):
(WebKit::fileDoesNotExistError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
There is no reason to use custom registered NSErrors anymore, so don't.

18:05 Changeset [93930] by levin@chromium.org

[chromium] Update tests expectations due to r93909 and r93913.

  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium-linux/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:52 Changeset [93929] by andersca@apple.com

Fix build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
17:41 Changeset [93928] by commit-queue@webkit.org

[chromium] Add MockWebGraphicsContext3D, for compositor unit testing
https://bugs.webkit.org/show_bug.cgi?id=67006

MockWebGraphicsContext3D is a no-op implementation of the pure virtual
interface WebGraphicsContext3D. I've included a test with a couple of
example usages: subclassing it manually, and using it with GMock.

Patch by Iain Merrick <husky@google.com> on 2011-08-26
Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • tests/MockWebGraphicsContext3D.h: Added.

(WebKit::MockWebGraphicsContext3D::initialize):
(WebKit::MockWebGraphicsContext3D::makeContextCurrent):
(WebKit::MockWebGraphicsContext3D::width):
(WebKit::MockWebGraphicsContext3D::height):
(WebKit::MockWebGraphicsContext3D::reshape):
(WebKit::MockWebGraphicsContext3D::isGLES2Compliant):
(WebKit::MockWebGraphicsContext3D::readBackFramebuffer):
(WebKit::MockWebGraphicsContext3D::getPlatformTextureId):
(WebKit::MockWebGraphicsContext3D::prepareTexture):
(WebKit::MockWebGraphicsContext3D::synthesizeGLError):
(WebKit::MockWebGraphicsContext3D::isContextLost):
(WebKit::MockWebGraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::getRequestableExtensionsCHROMIUM):
(WebKit::MockWebGraphicsContext3D::requestExtensionCHROMIUM):
(WebKit::MockWebGraphicsContext3D::blitFramebufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::renderbufferStorageMultisampleCHROMIUM):
(WebKit::MockWebGraphicsContext3D::activeTexture):
(WebKit::MockWebGraphicsContext3D::attachShader):
(WebKit::MockWebGraphicsContext3D::bindAttribLocation):
(WebKit::MockWebGraphicsContext3D::bindBuffer):
(WebKit::MockWebGraphicsContext3D::bindFramebuffer):
(WebKit::MockWebGraphicsContext3D::bindRenderbuffer):
(WebKit::MockWebGraphicsContext3D::bindTexture):
(WebKit::MockWebGraphicsContext3D::blendColor):
(WebKit::MockWebGraphicsContext3D::blendEquation):
(WebKit::MockWebGraphicsContext3D::blendEquationSeparate):
(WebKit::MockWebGraphicsContext3D::blendFunc):
(WebKit::MockWebGraphicsContext3D::blendFuncSeparate):
(WebKit::MockWebGraphicsContext3D::bufferData):
(WebKit::MockWebGraphicsContext3D::bufferSubData):
(WebKit::MockWebGraphicsContext3D::checkFramebufferStatus):
(WebKit::MockWebGraphicsContext3D::clear):
(WebKit::MockWebGraphicsContext3D::clearColor):
(WebKit::MockWebGraphicsContext3D::clearDepth):
(WebKit::MockWebGraphicsContext3D::clearStencil):
(WebKit::MockWebGraphicsContext3D::colorMask):
(WebKit::MockWebGraphicsContext3D::compileShader):
(WebKit::MockWebGraphicsContext3D::copyTexImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::cullFace):
(WebKit::MockWebGraphicsContext3D::depthFunc):
(WebKit::MockWebGraphicsContext3D::depthMask):
(WebKit::MockWebGraphicsContext3D::depthRange):
(WebKit::MockWebGraphicsContext3D::detachShader):
(WebKit::MockWebGraphicsContext3D::disable):
(WebKit::MockWebGraphicsContext3D::disableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::drawArrays):
(WebKit::MockWebGraphicsContext3D::drawElements):
(WebKit::MockWebGraphicsContext3D::enable):
(WebKit::MockWebGraphicsContext3D::enableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::finish):
(WebKit::MockWebGraphicsContext3D::flush):
(WebKit::MockWebGraphicsContext3D::framebufferRenderbuffer):
(WebKit::MockWebGraphicsContext3D::framebufferTexture2D):
(WebKit::MockWebGraphicsContext3D::frontFace):
(WebKit::MockWebGraphicsContext3D::generateMipmap):
(WebKit::MockWebGraphicsContext3D::getActiveAttrib):
(WebKit::MockWebGraphicsContext3D::getActiveUniform):
(WebKit::MockWebGraphicsContext3D::getAttachedShaders):
(WebKit::MockWebGraphicsContext3D::getAttribLocation):
(WebKit::MockWebGraphicsContext3D::getBooleanv):
(WebKit::MockWebGraphicsContext3D::getBufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getContextAttributes):
(WebKit::MockWebGraphicsContext3D::getError):
(WebKit::MockWebGraphicsContext3D::getFloatv):
(WebKit::MockWebGraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebKit::MockWebGraphicsContext3D::getIntegerv):
(WebKit::MockWebGraphicsContext3D::getProgramiv):
(WebKit::MockWebGraphicsContext3D::getProgramInfoLog):
(WebKit::MockWebGraphicsContext3D::getRenderbufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getShaderiv):
(WebKit::MockWebGraphicsContext3D::getShaderInfoLog):
(WebKit::MockWebGraphicsContext3D::getShaderSource):
(WebKit::MockWebGraphicsContext3D::getString):
(WebKit::MockWebGraphicsContext3D::getTexParameterfv):
(WebKit::MockWebGraphicsContext3D::getTexParameteriv):
(WebKit::MockWebGraphicsContext3D::getUniformfv):
(WebKit::MockWebGraphicsContext3D::getUniformiv):
(WebKit::MockWebGraphicsContext3D::getUniformLocation):
(WebKit::MockWebGraphicsContext3D::getVertexAttribfv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribiv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribOffset):
(WebKit::MockWebGraphicsContext3D::hint):
(WebKit::MockWebGraphicsContext3D::isBuffer):
(WebKit::MockWebGraphicsContext3D::isEnabled):
(WebKit::MockWebGraphicsContext3D::isFramebuffer):
(WebKit::MockWebGraphicsContext3D::isProgram):
(WebKit::MockWebGraphicsContext3D::isRenderbuffer):
(WebKit::MockWebGraphicsContext3D::isShader):
(WebKit::MockWebGraphicsContext3D::isTexture):
(WebKit::MockWebGraphicsContext3D::lineWidth):
(WebKit::MockWebGraphicsContext3D::linkProgram):
(WebKit::MockWebGraphicsContext3D::pixelStorei):
(WebKit::MockWebGraphicsContext3D::polygonOffset):
(WebKit::MockWebGraphicsContext3D::readPixels):
(WebKit::MockWebGraphicsContext3D::releaseShaderCompiler):
(WebKit::MockWebGraphicsContext3D::renderbufferStorage):
(WebKit::MockWebGraphicsContext3D::sampleCoverage):
(WebKit::MockWebGraphicsContext3D::scissor):
(WebKit::MockWebGraphicsContext3D::shaderSource):
(WebKit::MockWebGraphicsContext3D::stencilFunc):
(WebKit::MockWebGraphicsContext3D::stencilFuncSeparate):
(WebKit::MockWebGraphicsContext3D::stencilMask):
(WebKit::MockWebGraphicsContext3D::stencilMaskSeparate):
(WebKit::MockWebGraphicsContext3D::stencilOp):
(WebKit::MockWebGraphicsContext3D::stencilOpSeparate):
(WebKit::MockWebGraphicsContext3D::texImage2D):
(WebKit::MockWebGraphicsContext3D::texParameterf):
(WebKit::MockWebGraphicsContext3D::texParameteri):
(WebKit::MockWebGraphicsContext3D::texSubImage2D):
(WebKit::MockWebGraphicsContext3D::uniform1f):
(WebKit::MockWebGraphicsContext3D::uniform1fv):
(WebKit::MockWebGraphicsContext3D::uniform1i):
(WebKit::MockWebGraphicsContext3D::uniform1iv):
(WebKit::MockWebGraphicsContext3D::uniform2f):
(WebKit::MockWebGraphicsContext3D::uniform2fv):
(WebKit::MockWebGraphicsContext3D::uniform2i):
(WebKit::MockWebGraphicsContext3D::uniform2iv):
(WebKit::MockWebGraphicsContext3D::uniform3f):
(WebKit::MockWebGraphicsContext3D::uniform3fv):
(WebKit::MockWebGraphicsContext3D::uniform3i):
(WebKit::MockWebGraphicsContext3D::uniform3iv):
(WebKit::MockWebGraphicsContext3D::uniform4f):
(WebKit::MockWebGraphicsContext3D::uniform4fv):
(WebKit::MockWebGraphicsContext3D::uniform4i):
(WebKit::MockWebGraphicsContext3D::uniform4iv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix2fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix3fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix4fv):
(WebKit::MockWebGraphicsContext3D::useProgram):
(WebKit::MockWebGraphicsContext3D::validateProgram):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4fv):
(WebKit::MockWebGraphicsContext3D::vertexAttribPointer):
(WebKit::MockWebGraphicsContext3D::viewport):
(WebKit::MockWebGraphicsContext3D::createBuffer):
(WebKit::MockWebGraphicsContext3D::createFramebuffer):
(WebKit::MockWebGraphicsContext3D::createProgram):
(WebKit::MockWebGraphicsContext3D::createRenderbuffer):
(WebKit::MockWebGraphicsContext3D::createShader):
(WebKit::MockWebGraphicsContext3D::createTexture):
(WebKit::MockWebGraphicsContext3D::deleteBuffer):
(WebKit::MockWebGraphicsContext3D::deleteFramebuffer):
(WebKit::MockWebGraphicsContext3D::deleteProgram):
(WebKit::MockWebGraphicsContext3D::deleteRenderbuffer):
(WebKit::MockWebGraphicsContext3D::deleteShader):
(WebKit::MockWebGraphicsContext3D::deleteTexture):

  • tests/MockWebGraphicsContext3DTest.cpp: Added.

(TEST):
(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):

17:38 Changeset [93927] by commit-queue@webkit.org

[Chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson <jamesr@chromium.org> on 2011-08-26
Reviewed by Kenneth Russell.

Fix a number of reference cycle leaks that prevent LayerRendererChromiums from being destroyed when a tab is
closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):

17:23 Changeset [93926] by dglazkov@chromium.org

garden-o-matic summary view should have pretty commit data information.
https://bugs.webkit.org/show_bug.cgi?id=67069

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
16:44 Changeset [93925] by weinig@apple.com

Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67063

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(+[NSError _webkit_errorWithDomain:code:URL:]):

16:42 Changeset [93924] by levin@chromium.org

[chromium] Update tests expectations due to r93909.

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
16:31 Changeset [93923] by japhet@chromium.org

Move allowCredentials from ThreadableLoaderOptions down
to ResourceLoaderOptions. This allows us to remove
getShouldUseCredentialStorage() from SubresourceLoaderClient
and check allowCredentials in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refractor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldUseCredentialStorage): Check

m_options.allowCredentials instead of calling a client.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
15:55 Changeset [93922] by levin@chromium.org

[chromium] Update tests expectations due to r93913.

  • platform/chromium-cg-mac/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium-win/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Added.
15:40 Changeset [93921] by ojan@chromium.org

change the default preferred width of the flex() function to 0px per the new spec
https://bugs.webkit.org/show_bug.cgi?id=67067

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/001.html:
  • css3/flexbox/002.html:
  • css3/flexbox/flex-parsing-expected.txt:
  • css3/flexbox/script-tests/flex-parsing.js:
15:32 Changeset [93920] by commit-queue@webkit.org

Unzip initialization lists and constructors in JSCell hierarchy (2/7)
https://bugs.webkit.org/show_bug.cgi?id=66957

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-26
Reviewed by Darin Adler.

Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):

15:26 Changeset [93919] by mdelaney@apple.com

Remove offset hack from GraphicsContextCG setShadow code
https://bugs.webkit.org/show_bug.cgi?id=67052

Reviewed by Simon Fraser.

No new tests - current tests cover it.

  • platform/graphics/cg/GraphicsContextCG.cpp:

Removing the offset hack introduced in http://trac.webkit.org/changeset/28714
for an issue with offsets in an old version of CoreGraphics that's long since been fixed.

15:23 Changeset [93918] by fpizlo@apple.com

The GC does not have a facility for profiling the kinds of objects
that occupy the heap
https://bugs.webkit.org/show_bug.cgi?id=66849

Reviewed by Geoffrey Garen.

Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.

(JSC::Heap::destroy):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

  • heap/MarkedBlock.h:
  • heap/VTableSpectrum.cpp: Added.

(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h: Added.
  • wtf/Platform.h:
15:20 Changeset [93917] by dglazkov@chromium.org

Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=67066

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
15:18 Changeset [93916] by commit-queue@webkit.org

Rebasing media/video-layer-crash & media/video-transformed images.
https://bugs.webkit.org/show_bug.cgi?id=67065

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-26
Reviewed by David Levin.

  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
14:46 Changeset [93915] by commit-queue@webkit.org

Update topCallFrame when calling host functions in the JIT
https://bugs.webkit.org/show_bug.cgi?id=67010

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-26
Reviewed by Oliver Hunt.

The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (https://bugs.webkit.org/show_bug.cgi?id=66994).

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

14:41 Changeset [93914] by commit-queue@webkit.org

[DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
https://bugs.webkit.org/show_bug.cgi?id=67041

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Martin Robinson.

This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
PixelDumpSupportCairo.h, but the latter was #including cairo.h only
when the GTK+ port was being built.

  • DumpRenderTree/cairo/PixelDumpSupportCairo.h:
14:40 Changeset [93913] by ap@apple.com

Get rid of frame life support timer
https://bugs.webkit.org/show_bug.cgi?id=66874

Reviewed by Geoff Garen. V8 fixes courtesy of Dmitry Titov.

Test: fast/frames/detached-frame-property.html

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page): Removed all code that dealt with the life support timer. Protect Frame inside runScript() and callFunction() for v8 bindings.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): Replaced ref/deref calls on self with a RefPtr.
14:36 Changeset [93912] by andersca@apple.com

Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
https://bugs.webkit.org/show_bug.cgi?id=67062

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_ScheduleTimer):
Call NetscapePlugin::scheduleTimer.

(WebKit::NPN_UnscheduleTimer):
Call NetscapePlugin::unscheduleTimer.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_nextTimerID.

(WebKit::NetscapePlugin::Timer::start):
Start the timer.

(WebKit::NetscapePlugin::Timer::stop):
Stop the timer.

(WebKit::NetscapePlugin::Timer::timerFired):
Call the right callback and unschedule the timer object if it's not a repeating timer.

(WebKit::NetscapePlugin::scheduleTimer):
Create a new timer and start it.

(WebKit::NetscapePlugin::unscheduleTimer):
Get the timer from the map and destroy it.

(WebKit::NetscapePlugin::destroy):
Destroy all timers.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add Timer class.

14:36 Changeset [93911] by commit-queue@webkit.org

fast/js/const.html is opening a modal print dialog, leading to a timeout on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=67061

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-08-26
Reviewed by Oliver Hunt.

Update this test to remove inadvertant calls to window.print().

  • fast/js/resources/const.js:

(tryCatch1): Remove call to window.print()
(tryCatch2): Ditto.

13:47 Changeset [93910] by commit-queue@webkit.org

Fix MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=67046

Patch by Chao-ying Fu <fu@mips.com> on 2011-08-26
Reviewed by Gavin Barraclough.

  • jit/JIT.h:
13:43 Changeset [93909] by mitz@apple.com

RenderText::computePreferredLogicalWidths() should measure words with trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=66733

Source/WebCore:

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-08-26
Reviewed by Dan Bernstein.

Test: fast/text/complex-preferred-logical-widths.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Apply logic from RenderBlock::LineBreaker::nextLineBreak().

LayoutTests:

  • fast/text/complex-preferred-logical-widths.html: Added.
  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
13:42 Changeset [93908] by tony@chromium.org

Add CSS parsing for -webkit-flex-align
https://bugs.webkit.org/show_bug.cgi?id=66726

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexAlign):
(WebCore::InheritedFlags::setFlexAlign):
(WebCore::InheritedFlags::initialFlexAlign):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
13:41 Changeset [93907] by japhet@chromium.org

2011-08-26 Nate Chapin <japhet@chromium.org>

Fix http/tests/misc/willCacheResponse-delegate-callback.html
after r93886. We're implicitly converting an enum to a bool.

Rubber-stamped by David Levin.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse):
13:38 Changeset [93906] by dglazkov@chromium.org

Clean up and line up layout in garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=67057

1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2) Rearranged DOM structure a bit to accommodate recent changes;
3) Added minimal CSS to line things up.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
13:37 Changeset [93905] by weinig@apple.com

Fix typo in Connection.cpp
https://bugs.webkit.org/show_bug.cgi?id=67060

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):
We want timedOut, not timeout. There is not a current way to cause this
to be an issue. This issue was caught by the Clang Static Analyzer.

13:05 Changeset [93904] by mrobinson@webkit.org

Skip two tests on GTK+ that are failing due to known issues.

  • platform/gtk/Skipped: Update the skipped list.
12:29 Changeset [93903] by crogers@google.com

Add MediaPlayer::audioSourceProvider() method for audio stream access by the Web Audio API.
https://bugs.webkit.org/show_bug.cgi?id=66398

Reviewed by Eric Carlson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::ensureMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

MediaPlayer creation has now been put into createMediaPlayer() instead of it being created
separately in these various methods. It has been made thread-safe for use with the Web Audio API
in conjunction with an MediaElementAudioSourceNode.

(WebCore::HTMLMediaElement::setAudioSourceNode):
(WebCore::HTMLMediaElement::audioSourceProvider):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::audioSourceNode):

The HTMLMediaElement now keeps track of an optional MediaElementAudioSourceNode if
the audio stream is being processed using the Web Audio API.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::audioSourceProvider):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::audioSourceProvider):

MediaPlayer now has an audioSourceProvider() method with a default "empty" implementation.
audioSourceProvider() returns an AudioSourceProvider object which the Web Audio API's
MediaElementAudioSourceNode uses (indirectly through an HTMLMediaElement method) to get the rendered audio stream.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:

AudioContext::createMediaElementSource() is now more careful to check that an HTMLMediaElement
doesn't already have a MediaElementAudioSourceNode attached to it.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::~MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • webaudio/MediaElementAudioSourceNode.h:

Implement thread-safe processing (replacing the old stub implementation).

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt:
  • webaudio/mediaelementaudiosourcenode.html:
12:23 Changeset [93902] by alice.liu@apple.com

https://bugs.webkit.org/show_bug.cgi?id=66823
Add the request info to the WebPageProxy::CreateNewPage message

Reviewed by Anders Carlsson.

Source/WebKit2:

Update function declarations with additional ResourceRequest parameter:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):
Pass the ResourceRequest within the FrameLoadRequest.

Tools:

Update function declarations with additional parameter:

  • MiniBrowser/gtk/BrowserWindow.c:

(createNewPage):

  • MiniBrowser/mac/BrowserWindowController.m:

(createNewPage):

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):

  • WebKitTestRunner/TestController.h:
12:11 Changeset [93901] by senorblanco@chromium.org

Assertion fires if canvas is resized while save() active
https://bugs.webkit.org/show_bug.cgi?id=66710

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/resize-while-save-active.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Call CanvasRenderingContext2D::reset() before resizing the canvas,
so that the GraphicsContext state stack can be unwound.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Refactor the state stack unwinding code from the destructor to
unwindStateStack() (new).
(WebCore::CanvasRenderingContext2D::reset):
Unwind the GraphicsContext state stack when the context is reset.

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/resize-while-save-active-expected.txt: Added.
  • fast/canvas/resize-while-save-active.html: Added.
11:59 Changeset [93900] by darin@apple.com

[Mac] Use the progress cursor instead of the wristwatch for CSS "wait" cursor
https://bugs.webkit.org/show_bug.cgi?id=67049

Reviewed by Beth Dakin.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use BusyButClickable cursor for wait
as well as for Progress.

11:41 Changeset [93899] by japhet@chromium.org

2011-08-26 Nate Chapin <japhet@chromium.org>

Fix gtk build after r93886.

  • platform/track/CueParser.cpp: (WebCore::CueParser::load):
11:31 Changeset [93898] by mrobinson@webkit.org

Add some new baselines for GTK+ and unskip tests that now have them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
11:24 Changeset [93897] by alexis.menard@openbossa.org

[Qt][WK2]REGRESSION(r93784): It made many tests crash
https://bugs.webkit.org/show_bug.cgi?id=66958

Reviewed by Anders Carlsson.

Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::~QtWebPageProxy):

11:23 Changeset [93896] by mrobinson@webkit.org

Import the last set of GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xml: Import the last set of results.
11:15 Changeset [93895] by mrobinson@webkit.org

Continue importing GTK+ CSS3 selector test results.

  • platform/gtk/css3/selectors3/xml: Import the next set of results.
11:08 Changeset [93894] by mrobinson@webkit.org

Begin importing the last directory of CSS3 selector results for GTK+.

  • platform/gtk/css3/selectors3/xml: Import the first set of files in this directory.
11:07 Changeset [93893] by commit-queue@webkit.org

WebViewImpl::selectionRange should return range in the right order.
https://bugs.webkit.org/show_bug.cgi?id=66973

Patch by Varun Jain <varunjain@google.com> on 2011-08-26
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
11:04 Changeset [93892] by commit-queue@webkit.org

[EFL] Update searchableIndexIntroduction() to match GTK+'s.
https://bugs.webkit.org/show_bug.cgi?id=66885

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Using this new string allows us to share the test expectations with
other ports, and thus makes
fast/replaced/table-percent-height-text-controls.html pass.

No new tests, as this is covered by an existing one.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::searchableIndexIntroduction):

10:59 Changeset [93891] by vrk@chromium.org

Unreviewed; adding files missing from r93885.

  • media/track/captions-webvtt/tc000-empty.vtt: Added.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Added.
  • media/track/captions-webvtt/tc001-utf8.vtt: Added.
  • media/track/captions-webvtt/tc002-bom.vtt: Added.
  • media/track/captions-webvtt/tc003-newlines.vtt: Added.
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Added.
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Added.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Added.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Added.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Added.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Added.
  • media/track/captions-webvtt/tc011-cues.vtt: Added.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Added.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Added.
  • media/track/captions-webvtt/tc013-settings.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
10:59 Changeset [93890] by commit-queue@webkit.org

[EFL] Do not log an error if a fallback cursor cannot be found.
https://bugs.webkit.org/show_bug.cgi?id=67037

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Ecore_X does not necessarily have to be used (DumpRenderTree does not
use it, for example), so showing an error message here is bogus.

No new tests, as it just removes erroneous error messages from
when running DRT with existing tests.

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

10:53 Changeset [93889] by mrobinson@webkit.org

Continue importing GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xhtml: Import this directory.
10:48 Changeset [93888] by mrobinson@webkit.org

Begin importing CSS3 selector test results for GTK+.

  • platform/gtk/css3/selectors3/html: Import this directory.
10:45 Changeset [93887] by andersca@apple.com

Fix handling of keyup events in the new Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67045

Reviewed by Sam Weinig.

Use a counter instead of a boolean for deciding when to ignore keyup events, because
if multiple keys are pressed simultaneously then we need to ignore more than one keyup event in a row.

Also if a keyboard event is an autorepeating event we won't get a keyup event so don't increment the counter
in that case.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

10:41 Changeset [93886] by japhet@chromium.org

Source/WebCore: Change a bunch of nondescript bools to
descriptive enums in ResourceLoaderOptions and
ThreadableLoaderOptions.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

No new tests, no functionality change intended.

  • WebCore.exp.in:
  • fileapi/FileReaderLoader.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.cpp:
  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • page/EventSource.cpp:
  • platform/network/ResourceHandle.h:
  • workers/WorkerScriptLoader.cpp:
  • xml/XMLHttpRequest.cpp:

Source/WebKit/chromium: Use enums instead of bools for ThreadableLoaderOptions
variables.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

10:21 Changeset [93885] by vrk@chromium.org

Tests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
https://bugs.webkit.org/show_bug.cgi?id=65884

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-25
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/tc000-empty.vtt: Renamed from media/track/captions/tc000_empty.vtt.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Renamed from media/track/captions/tc001_iso2022jp3.vtt.
  • media/track/captions-webvtt/tc001-utf8.vtt: Renamed from media/track/captions/tc001_utf8.vtt.
  • media/track/captions-webvtt/tc002-bom.vtt: Renamed from media/track/captions/tc002_bom.vtt.
  • media/track/captions-webvtt/tc003-newlines.vtt: Renamed from media/track/captions/tc003_newlines.vtt
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Renamed from media/track/captions/tc003_nonewlineateof.vtt
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Renamed from media/track/captions/tc004_nowebvtt.vtt.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Renamed from media/track/captions/tc004_webvttfile.vtt.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Renamed from media/track/captions/tc004_webvttrubbish.vtt.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Renamed from media/track/captions/tc005_defaultstyles.vtt.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Renamed from media/track/captions/tc005_metadataarea.vtt.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Renamed from media/track/captions/tc006_cueiderror.vtt.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Renamed from media/track/captions/tc006_cueid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Renamed from media/track/captions/tc007_cuenoid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Renamed from media/track/captions/tc007_cuenoiderror.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Renamed from media/track/captions/tc008_timingsnohourerrors.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Renamed from media/track/captions/tc008_timingsnohour.vtt.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Renamed from media/track/captions/tc009_timingshourerror.vtt.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Renamed from media/track/captions/tc009_timingshour.vtt.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Renamed from media/track/captions/tc010_notimings.vtt.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Copied from media/track/captions/tc011_cuesnosep.vtt.
  • media/track/captions-webvtt/tc011-cues.vtt: Renamed from media/track/captions/tc011_cues.vtt.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Renamed from media/track/captions/tc012_outoforder.vtt.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Renamed from media/track/captions/tc013_settingsbadsep.vtt.
  • media/track/captions-webvtt/tc013-settings.vtt: Renamed from media/track/captions/tc013_settings.vtt.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Renamed from media/track/track-webvtt-tc004-magicheader-expected.txt.
  • media/track/track-webvtt-tc004-magic-header.html: Renamed from media/track/track-webvtt-tc004-magicheader.html.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Renamed from media/track/track-webvtt-tc005-headercomment-expected.txt.
  • media/track/track-webvtt-tc005-header-comment.html: Renamed from media/track/track-webvtt-tc005-headercomment.html.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Renamed from media/track/track-webvtt-tc006-cueidentifiers-expected.txt.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Renamed from media/track/track-webvtt-tc006-cueidentifiers.html.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Renamed from media/track/track-webvtt-tc007-cuenoid-expected.txt.
  • media/track/track-webvtt-tc007-cue-no-id.html: Renamed media/track/track-webvtt-tc007-cuenoid.html.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Renamed from media/track/track-webvtt-tc008-timingsnohours-expected.txt.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Renamed from media/track/track-webvtt-tc008-timingsnohours.html.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Renamed from media/track/track-webvtt-tc009-timingshour-expected.txt.
  • media/track/track-webvtt-tc009-timings-hour.html: Renamed from media/track/track-webvtt-tc009-timingshour.html.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Copied from media/track/track-webvtt-tc010-notimings-expected.txt.
  • media/track/track-webvtt-tc010-no-timings.html: Renamed from media/track/track-webvtt-tc012-outoforder.html.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Renamed from media/track/track-webvtt-tc011-blanklines-expected.txt.
  • media/track/track-webvtt-tc011-blank-lines.html: Renamed from media/track/track-webvtt-tc011-blanklines.html.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Renamed from media/track/track-webvtt-tc012-outoforder-expected.txt.
  • media/track/track-webvtt-tc012-out-of-order.html: Copied from media/track/track-webvtt-tc000-empty.html.
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
  • media/video-test.js:

(testCues):
(allTestsEnded):

10:19 Changeset [93884] by andreas.kling@nokia.com

HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
https://bugs.webkit.org/show_bug.cgi?id=67040

Reviewed by Darin Adler.

  • html/HTMLMetaElement.h: Remove m_equiv and m_content members,

shrinking HTMLMetaElement by 16 bytes (on 64-bit.)

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseMappedAttribute):
(WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().

10:17 Changeset [93883] by cevans@google.com

Merge 93794
BUG=93587
Review URL: http://codereview.chromium.org/7753041

09:57 Changeset [93882] by pfeldman@chromium.org

Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

09:26 Changeset [93881] by podivilov@chromium.org

Unreviewed, rolling out r93870.
http://trac.webkit.org/changeset/93870
https://bugs.webkit.org/show_bug.cgi?id=65203

Broke i18n chromium tests

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
09:15 Changeset [93880] by commit-queue@webkit.org

Gut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
https://bugs.webkit.org/show_bug.cgi?id=66979.

Removing the function altogether would break the nightlies.
This patch removes the code behind it so that it is clear that
WKPageCreateSnapshotOfVisibleContent should not be used, and so that the code isn't just
left rotting in the tree.

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-26
Reviewed by Brian Weinstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCreateSnapshotOfVisibleContent):
Return 0.

  • UIProcess/API/C/WKPagePrivate.h:

Update the comment and add a link to the bug.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
08:29 Changeset [93879] by commit-queue@webkit.org

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Also roll Chromium revision to 98101, to include dependency: http://codereview.chromium.org/7714036/

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-26
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

08:14 Changeset [93878] by eric.carlson@apple.com

<video> playlist can not advance when playing in background tab
https://bugs.webkit.org/show_bug.cgi?id=66978

Reviewed by Darin Adler.

No new tests added because it isn't possible to simulate a background tab in DRT.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
(WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever

allowed a file to load.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
(WebCore::HTMLMediaElement::removeBehaviorRestriction): New.

08:06 Changeset [93877] by mrobinson@webkit.org

Removing some tests from the GTK+ skipped lists that have results now
or no longer exist.

  • platform/gtk/Skipped: Clean up.
  • platform/gtk/test_expectations.txt: Ditto.
07:57 Changeset [93876] by andreas.kling@nokia.com

Rebaseline Qt (4.7) after r93873.

  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
07:06 Changeset [93875] by podivilov@chromium.org

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
07:02 Changeset [93874] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
06:35 Changeset [93873] by andreas.kling@nokia.com

[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Reviewed by Benjamin Poulain.

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

LayoutTests:

Rebaseline SVG tests after Path::boundingRect() change.
This brings Qt quite a bit closer to CG and Skia metrics.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-4.8/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/qt/svg/custom/animate-path-morphing-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
  • platform/qt/svg/custom/second-inline-text-expected.txt:
  • platform/qt/svg/custom/use-nested-transform-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/shapes/path/001-expected.txt:
06:22 Changeset [93872] by philn@webkit.org

Unreviewed, another rebaseline after switch to GTK+3.x.

  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
06:15 Changeset [93871] by gavinp@chromium.org

add a state enumeration to track down cause of null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=66939

Reviewed by Alexey Proskuryakov.

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I
have a bug I cannot reproduce. I added an earlier crash in
https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
gotten many good stacks, all coming in through a failed request that
eventually calls notifyFinished() on a ScriptElement with a NULL
m_cachedScript.

I'd like to know how this got NULL. This enumeration should let
me find that in stack dumps from reproductions.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
06:12 Changeset [93870] by reed@google.com

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
05:50 Changeset [93869] by podivilov@chromium.org

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium fast/borders/* tests.

  • fast/borders/borderRadiusArcs01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusArcs01-expected.txt.
  • fast/borders/borderRadiusDashed02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed02-expected.txt.
  • fast/borders/borderRadiusDashed03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed03-expected.txt.
  • fast/borders/borderRadiusDotted01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDotted01-expected.txt.
  • fast/borders/borderRadiusDouble01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble01-expected.txt.
  • fast/borders/borderRadiusDouble02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble02-expected.txt.
  • fast/borders/borderRadiusDouble03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble03-expected.txt.
  • fast/borders/borderRadiusGroove01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove01-expected.txt.
  • fast/borders/borderRadiusGroove02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove02-expected.txt.
  • fast/borders/borderRadiusInset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusInset01-expected.txt.
  • fast/borders/borderRadiusOutset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusOutset01-expected.txt.
  • fast/borders/borderRadiusRidge01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusRidge01-expected.txt.
  • fast/borders/borderRadiusSolid01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid01-expected.txt.
  • fast/borders/borderRadiusSolid02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid02-expected.txt.
  • fast/borders/borderRadiusSolid03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid03-expected.txt.
  • fast/borders/borderRadiusSolid04-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid04-expected.txt.
  • fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted01-expected.txt: Removed.
  • platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
05:32 Changeset [93868] by loislo@chromium.org

Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

05:28 Changeset [93867] by kov@webkit.org

Minor style fix in the sample code for WebKitWebFrame.

  • webkit/webkitwebframe.cpp:
04:31 Changeset [93866] by philn@webkit.org

Unreviewed, GTK rebaseline of some svg tests after switch to
GTK+-3.x.

  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
04:24 Changeset [93865] by philn@webkit.org

Unreviewed, GTK rebaseline of some fast/ tests after switch to
GTK+-3.x.

  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
04:19 Changeset [93864] by zimmermann@webkit.org

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Not reviewed. Unskip this test on Qt, it's fixed now.

  • platform/qt/Skipped:
04:10 Changeset [93863] by philn@webkit.org

Unreviewed, GTK rebaseline of some editing tests after switch to
GTK+-3.x.

  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Added.
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
03:02 Changeset [93862] by zimmermann@webkit.org

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Reviewed by Zoltan Herczeg.

Fix intrinsic size negotiation flakiness, most visible on the Qt port.

The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.

The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
on our parent frame view - this is only an optimization to avoid doing layout() twice.

The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::collectFrameViewChildren): (WebCore::FrameView::forceLayoutParentViewIfNeeded): (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
  • page/FrameView.h:
02:56 Changeset [93861] by mnaganov@chromium.org

Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
https://bugs.webkit.org/show_bug.cgi?id=66988

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):

02:06 Changeset [93860] by koz@chromium.org

Unreviewed, rolling out r93853.
http://trac.webkit.org/changeset/93853
https://bugs.webkit.org/show_bug.cgi?id=67016

Turns bots red

  • platform/chromium/test_expectations.txt:
02:05 Changeset [93859] by ossy@webkit.org

[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced in r93794.

  • platform/qt/Skipped:
  • platform/qt/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt: Added.
01:59 Changeset [93858] by commit-queue@webkit.org

REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
https://bugs.webkit.org/show_bug.cgi?id=67015

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-26
Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Checks the validity of maxlength attribute when converting it to integer.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt:

Added maxlength="" and maxlength="invalid" tests.

  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.
  • fast/forms/textarea-maxlength-expected.txt: ditto.
01:52 Changeset [93857] by noel.gordon@gmail.com

Make show-pretty-diff work on linux
https://bugs.webkit.org/show_bug.cgi?id=67017

Reviewed by Adam Barth.

  • Scripts/show-pretty-diff:

08/25/11:

23:48 Changeset [93856] by yutak@chromium.org

WebSocket: Fix indentation of WebSocket header files
https://bugs.webkit.org/show_bug.cgi?id=67018

Reviewed by Kent Tamura.

No new tests. Style fix only.

  • websockets/WebSocket.h:

(WebCore::WebSocket::create):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):

  • websockets/WebSocketChannel.h:

Removed formal parameter name of resumeTimerFired().
(WebCore::WebSocketChannel::create):
(WebCore::WebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

  • websockets/WebSocketHandshake.h:

Removed formal parameter name of setClientProtocol().

23:44 Changeset [93855] by koz@chromium.org

Update expectations to remove conflict
https://bugs.webkit.org/show_bug.cgi?id=67020

Unreviewed, expectations update.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25

  • platform/chromium/test_expectations.txt:
23:41 Changeset [93854] by mrobinson@webkit.org

Touch GtkVersioning.c so that the release bot rebuilds it. This
is necessary because of the switch to GTK+ 3.x.

  • platform/gtk/GtkVersioning.c: Touch this file.
23:23 Changeset [93853] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=67016

Unreviewed, test expectations update.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25

  • platform/chromium/test_expectations.txt:
22:35 Changeset [93852] by mrobinson@webkit.org

Reviewed by Xan Lopez.

.:

[GTK] Switch to GTK+ 3.x by default
https://bugs.webkit.org/show_bug.cgi?id=63047

  • configure.ac: Modify the default value of the --with-gtk option to be 3.0.

LayoutTests:

Update GTK+ result that depend on the GTK+ version.

  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.png:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.png:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.png:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.png:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.png:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.png:
  • platform/gtk/fast/forms/menulist-clip-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.png:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.png:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.png:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.png:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-background-none-expected.png:
  • platform/gtk/fast/forms/select-background-none-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.png:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.png:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.png:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.png:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.png:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/table-percent-height-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.png:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-radio-expected.png:
  • platform/gtk/fast/replaced/width100percent-radio-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
21:59 Changeset [93851] by commit-queue@webkit.org

Enable fullscreen API in Chromium by default.
https://bugs.webkit.org/show_bug.cgi?id=66993

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25
Reviewed by Adam Barth.

  • features.gypi:
21:27 Changeset [93850] by commit-queue@webkit.org

Use PATH_BASED_BORDER_RADIUS_DRAWING for skia
https://bugs.webkit.org/show_bug.cgi?id=65583

Source/WebCore:

This change brings in the new border rendering for Skia. To support this without aliasing the skia
graphics context has been updated to support anti-aliased clipping around convex polygons and also
anti-aliased clipping outside a path.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

  • rendering/RenderObject.h:

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

Update expectations: added failures for baselines to come. removed some
failure expectations for tests that now pass and moved some expectations
into the group of tests to be rebaselined.

  • platform/chromium/test_expectations.txt:
19:54 Changeset [93849] by mrobinson@webkit.org

Skip some tests on GTK+ that are missing DRT functionality. Also
reorganize some failures on the skipped list.

  • platform/gtk/Skipped: Update the skipped list.
18:32 Changeset [93848] by macpherson@chromium.org

Implement animation and transition properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66126

Reviewed by Dean Jackson.

No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.

  • css/CSSStyleApplyProperty.cpp:

Added new class ApplyPropertyAnimation to handle animation and transition properties.
(WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Removed animation and transition macros (celebrate!)
(WebCore::CSSStyleSelector::applyProperty):
Removed old implementations of animation and transition properties.

  • platform/animation/Animation.h:

Changed return types of initial values to match the setters and getters.
(WebCore::Animation::initialAnimationDelay):
(WebCore::Animation::initialAnimationName):
(WebCore::Animation::initialAnimationTimingFunction):

18:06 Changeset [93847] by dglazkov@chromium.org

Reorganize garden-o-matic CSS files to match JS-built views.
https://bugs.webkit.org/show_bug.cgi?id=66998

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
18:05 Changeset [93846] by pkasting@chromium.org

Temporarily mark some tests as crashing (assertion failure) after r93794.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
18:02 Changeset [93845] by andersca@apple.com

kNPEventStartIME doesn't work correctly for NPAPI
https://bugs.webkit.org/show_bug.cgi?id=65264
<rdar://problem/9996476>

Reviewed by Sam Weinig.

In order to remain compatible with older plug-ins, the updated input model won't
be turned on unless a plug-in explicitly asks whether we support it. The plug-in must do
this before any keyboard events have been processed.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):
Add the CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply flag to this message since we want
the web process to handle it while it's waiting for a reply to the PluginControllerProxy::HandleMouseEvent
synchronous message.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Implement the logic for when to turn off the legacy Cocoa text input model support.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_ignoreNextKeyUpEvent to false.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_ignoreNextKeyUpEvent member variable.

(WebKit::NetscapePlugin::hasHandledAKeyDownEvent):
Add a getter.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Don't send keydown and keyup events when complex text input is enabled in the updated model.

17:54 Changeset [93844] by andersca@apple.com

Correctly handle events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67005

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
When using the updated model, always return a string even for 'simple' characters.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Only let the input method have a crack at the event in the legacy model.

17:51 Changeset [93843] by jeffm@apple.com

Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=67002

Reviewed by Brian Weinstein.

  • UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.


  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.

17:41 Changeset [93842] by pkasting@chromium.org

[chromium] Some tests are apparently slow on Mac debug too.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:41 Changeset [93841] by jchaffraix@webkit.org

Fixing broken build due to unused variables in release mode
https://bugs.webkit.org/show_bug.cgi?id=67004

Unreviewed, release build fix.

Fixing broken build due to unused variables in ASSERTs in release build.

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::finishCreation):

17:36 Changeset [93840] by abarth@webkit.org

garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=66982

Reviewed by Dimitri Glazkov.

This patch just wires the rollout event through the controller to the
local server, which is already set up to perform rollouts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
17:34 Changeset [93839] by andersca@apple.com

Handle key-down events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67001

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _disableComplexTextInputIfNecessary]):
If the plug-in is using the updated Cocoa text input model specification, disable text input
if the text input window has been dismissed for whatever reason.

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
If the plug-in is using the updated Cocoa text input model specification, let the input methods
have a go at the keyboard event.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Actually set m_isComplexTextInputEnabled to the right value.

17:06 Changeset [93838] by andersca@apple.com

Factor code to send a key-down event to the plug-in out into a new function
https://bugs.webkit.org/show_bug.cgi?id=66999

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _handlePluginComplexTextInputKeyDown:]):
(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):

16:39 Changeset [93837] by jchaffraix@webkit.org

Concentrate RenderLayer repaint rects updates
https://bugs.webkit.org/show_bug.cgi?id=64993

Reviewed by David Hyatt.

The change moves the update of the repaint rects to 2 methods
(computeRepaintRects and clearRepaintRects) to better track
those changes.

No new test, refactoring covered by the existing test cases.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Reverse the logic and
calculate the new bounds upfront. This should have no impact as none
of the methods rely on the internal value.

(WebCore::RenderLayer::computeRepaintRects): Added the cachedOffset parameter
to avoid breaking the performance optimization in updateLayerPositions. Added
some ASSERTS.

(WebCore::RenderLayer::clearRepaintRects): Added some ASSERTs here.
(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Added a FIXME as this
method could use the cachedOffset trick too.

(WebCore::RenderLayer::setHasVisibleContent): Changed the code to use
computeRepaintRects.

  • rendering/RenderLayer.h: Updated the signature of computeRepaintRects and moved

those 2 methods into the private section of the class.

16:33 Changeset [93836] by pkasting@chromium.org

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
16:30 Changeset [93835] by commit-queue@webkit.org

Unzip initialization lists and constructors in JSCell hierarchy (1/7)
https://bugs.webkit.org/show_bug.cgi?id=66827

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25
Reviewed by Geoffrey Garen.

Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors. Part of a larger refactoring to "unzip" initialization
lists and constructor bodies. Also renamed JSCell's constructorBody() method
to finishCreation().

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):

  • runtime/JSObject.h:

(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::constructorBody):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):

  • runtime/RegExp.h:
  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):

16:19 Changeset [93834] by commit-queue@webkit.org

Remove use of magic number -1 in WebCore/editing/visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=66980

Patch by Van Lam <vanlam@google.com> on 2011-08-25
Reviewed by Ryosuke Niwa.

Replaced use of magic number -1 with constant offsetNotFound.

  • editing/visible_units.cpp:

(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):

16:08 Changeset [93833] by commit-queue@webkit.org

[EFL] Add API to allow scripts to close windows automatically via JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=66777

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

Make it possible to allow or prevent scripts from closing windows
automatically (via window.close, for example).

Besides being useful in general, this is required by DRT.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_close_windows_get):
(ewk_view_setting_scripts_can_close_windows_set):

  • ewk/ewk_view.h:
16:08 Changeset [93832] by loki@webkit.org

REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
https://bugs.webkit.org/show_bug.cgi?id=66956

Rebaseline constants for patching GetByIdSlowCaseCall on ARM.

Reviewed by Oliver Hunt.

  • jit/JIT.h:
16:06 Changeset [93831] by commit-queue@webkit.org

[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
https://bugs.webkit.org/show_bug.cgi?id=66951

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-25
Reviewed by Andreas Kling.

Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
width and height one by one and setWidth cause geometryChange event in QTouchWebView.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::resizeEvent):

16:02 Changeset [93830] by dglazkov@chromium.org

garden-o-matic summary view should provide information on builders still in flight.
https://bugs.webkit.org/show_bug.cgi?id=66992

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
15:58 Changeset [93829] by abarth@webkit.org

webkit-patch rebaseline-expectations don't work when run outside the root
https://bugs.webkit.org/show_bug.cgi?id=66966

Reviewed by Eric Seidel.

Turns out tool.path() used to be relative, which caused problems when
running webkit-patch outside the root directory. This patch makes it
absolute. I checked all callers, and they all appear to want this
behavior.

It was unclear to me how to test this change because we only really
have a testing strategy for webkitpy, not for the main script.

  • Scripts/webkit-patch:
15:56 Changeset [93828] by crogers@google.com

Merge 93749 - Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

BUG=94025
Review URL: http://codereview.chromium.org/7741034

15:54 Changeset [93827] by andersca@apple.com

WKView should keep track of the plug-in complex text input state
https://bugs.webkit.org/show_bug.cgi?id=66990

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

Add a _pluginComplexTextInputState ivar to WKViewData.

(-[WKView _setPluginComplexTextInputState:]):
Set the _pluginComplexTextInputState variable. If text input is being disabled, send back an empty string to the plug-in.

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
Call -[WKView _setPluginComplexTextInputState:].

15:34 Changeset [93826] by pkasting@chromium.org

[chromium] Apparently, expectations without WONTFIX or BUGxxx are ignored.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:33 Changeset [93825] by andersca@apple.com

Move file internal methods to a class continuation in WKView
https://bugs.webkit.org/show_bug.cgi?id=66983

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _deviceScaleFactor]):
(-[WKView _setDrawingAreaSize:]):

14:20 Changeset [93824] by andersca@apple.com

More work on the updated Cocoa text input specification
https://bugs.webkit.org/show_bug.cgi?id=66977

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

(WebKit::NetscapePlugin::setPluginWantsLegacyCocoaTextInput):
Add setter. Not called yet.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set m_hasHandledAKeyDownEvent to true if we get a KeyDown event.

(WebKit::NetscapePlugin::sendComplexTextInput):
If the plug-in is using the updated Cocoa text input spec, we can disable text input here.

(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
If the plug-in is using the updated Cocoa text input spec, text input is not enabled when
the plug-in is focused.

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Set the right text input state based on whether the plug-in is using the updated spec or not.

14:09 Changeset [93823] by dglazkov@chromium.org

garden-o-matic summary needs a mock view that could be used for working on styling
https://bugs.webkit.org/show_bug.cgi?id=66971

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
14:00 Changeset [93822] by pkasting@chromium.org

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:58 Changeset [93821] by gavinp@chromium.org

Added myself to committers.

13:56 Changeset [93820] by igor.oliveira@openbossa.org

2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):
(WebCore::RenderBox::controlClipRect):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • fast/css/button-overflow-ellipsis.html: Removed.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Removed.
13:50 Changeset [93819] by crogers@google.com

Merge 91802 - V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222

BUG=94273
Review URL: http://codereview.chromium.org/7740035

13:37 Changeset [93818] by crogers@google.com

Merge 92658 - Fix thread-safety of AudioNode deletion
https://bugs.webkit.org/show_bug.cgi?id=65888

BUG=94278
Review URL: http://codereview.chromium.org/7749016

13:29 Changeset [93817] by ademar.reis@openbossa.org

[Qt] Enable password echo on Symbian builds
https://bugs.webkit.org/show_bug.cgi?id=66954

Reviewed by Chang Shu.

No tests, as this is just a build change.

  • config.h:
13:28 Changeset [93816] by crogers@google.com

Merge 91801 - AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217

BUG=94271
Review URL: http://codereview.chromium.org/7741029

13:27 Changeset [93815] by japhet@chromium.org

2011-08-25 Nate Chapin <japhet@chromium.org>

Windows build fix after r93811.

  • loader/cf/ResourceLoaderCFNet.cpp: (WebCore::ResourceLoader::shouldCacheResponse):
13:26 Changeset [93814] by andersca@apple.com

Return the correct value for NPNVsupportsCarbonBool
https://bugs.webkit.org/show_bug.cgi?id=66964

Source/WebKit2:

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Remove a FIXME and set the value to true.

Tools:

Add a test.

Reviewed by Adam Roben.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.

(SupportsCarbonEventModel::SupportsCarbonEventModel):
(SupportsCarbonEventModel::testConvert):
(SupportsCarbonEventModel::runTest):
(SupportsCarbonEventModel::NPP_New):

LayoutTests:

Reviewed by Adam Roben.

Add test.

  • platform/mac/plugins/supports-carbon-event-model-expected.txt: Added.
  • platform/mac/plugins/supports-carbon-event-model.html: Added.
13:21 Changeset [93813] by commit-queue@webkit.org

[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
https://bugs.webkit.org/show_bug.cgi?id=66690

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

The implementation is mostly based on the GTK+ port's, as we just need
to transfer the ownership of the frame to a new view and adjust the
smart object part accordingly.

This should help make fast/frames/iframe-reparenting-adopt-node.html
pass.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):

  • ewk/ewk_frame.cpp:

(ewk_frame_view_set):
(ewk_frame_view_create_for_view):

  • ewk/ewk_private.h:
12:57 Changeset [93812] by pkasting@chromium.org

[chromium] Further attempts to clean up the test expectations by being
more consistent about handling SKIPped and WONTFIXed tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:55 Changeset [93811] by japhet@chromium.org

Split some of the variables out of ThreadableLoaderOptions
into a superclass, ResourceLoaderOptions. Use ResourceLoaderOptions
all the way down to ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=63301

Reviewed by David Levin.

No new tests, refractor only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h: Added.
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/mac/ResourceLoaderMac.mm:
12:53 Changeset [93810] by crogers@google.com

Merge 92408 - Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize):

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/7745029

12:44 Changeset [93809] by adamk@chromium.org

use strict in CodeGeneratorJS and CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=66915

Reviewed by Darin Adler.

Making these files "use strict" makes changing them less
time-consuming and error-prone, and helps avoid accidentally
adding dead code (added a FIXME for one such case).

No expected change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(NativeToJSValue):
(GenerateHashValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateNormalAttrSetter):
(GetFunctionTemplateCallbackName):
(GenerateNewFunctionTemplate):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
():

12:21 Changeset [93808] by commit-queue@webkit.org

Enable incremental linking for component build on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66950

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-25
Reviewed by Darin Fisher.

Turns on Use Library Dependency Inputs for webkit.vcproj on Windows
build, when incremental_chrome_dll gyp flag is set. This is to get
faster incremental links on Windows builds.

  • WebKit.gyp:
12:17 Changeset [93807] by dino@apple.com

https://bugs.webkit.org/show_bug.cgi?id=21586
Apply CSS animations and transitions to SVG properties

Reviewed by Simon Fraser.

Expose the applicable SVG properties from SVGRenderStyle to
RenderStyle and add them to the list of animatable
properties. There aren't many SVG properties that are
animatable directly. SVGPaint (used in "fill" and "stroke")
is supported only when both ends of the animation are
a Color. Also updated SVGLength to have some methods
for converting to and from user space units.

12:09 Changeset [93806] by dglazkov@chromium.org

garden-o-matic summary view should not be broken.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:

(table.comparison): Added more specificity.

12:06 Changeset [93805] by abarth@webkit.org

This command has been broken for a while. This patch updates the
callsite to the new API.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
12:02 Changeset [93804] by igor.oliveira@openbossa.org

[Qt] Unreviewed, rebaseline for bug 53438.

  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt:
11:48 Changeset [93803] by inferno@chromium.org

Unreviewed. Chromium rebaselines for r93794.

  • platform/chromium-cg-mac-leopard/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win-vista/fast/table: Removed.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt: Added.
11:09 Changeset [93802] by inferno@chromium.org

REGRESSION(r90971): Fix an assertion failure with textarea placeholder.
https://bugs.webkit.org/show_bug.cgi?id=66164

Source/WebCore:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

Minor patch nits addressed by inferno@chromium.org, on Hyatt's
review.

Test: fast/forms/textarea-placeholder-relayout-assertion.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Pass 'false' to the 'markParents' argument of setChildNeedsLayout().
We don't need to propagate needsLayout for ancestors because
layoutSpecialExcludedChild() is called from layout() of the
parent.

LayoutTests:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

  • fast/forms/textarea-placeholder-relayout-assertion-expected.txt: Added.
  • fast/forms/textarea-placeholder-relayout-assertion.html: Added.
11:07 Changeset [93801] by dglazkov@chromium.org

garden-o-matic needs a way to report where and how tests are failing in the summary view.
https://bugs.webkit.org/show_bug.cgi?id=66955

Introduce FailureGrid, your one-stop failure-indicating destination.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
11:05 Changeset [93800] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests until check them.
11:04 Changeset [93799] by igor.oliveira@openbossa.org

2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Fix text-overflow for button elements. Make the element inside
the button inherit the button controlClip.

Reviewed by David Hyatt.

Test: fast/css/button-overflow-ellipsis.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::controlClipRect):

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Add button text-overflow test.

Reviewed by David Hyatt.

  • fast/css/button-overflow-ellipsis.html: Added.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Added.
10:56 Changeset [93798] by ap@apple.com

Fix build when GCC 4.2 is not installed.

  • gtest/xcode/Config/CompilerVersion.xcconfig: Copied from Source/WebCore/Configurations/CompilerVersion.xcconfig.
  • gtest/xcode/Config/General.xcconfig: Use the same compiler version as other projects do.
10:33 QtWebKit edited by ademar.reis@openbossa.org
(diff)
10:32 QtWebKit edited by ademar.reis@openbossa.org
(diff)
10:27 Changeset [93797] by pkasting@chromium.org

[chromium] Several test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
10:24 Changeset [93796] by enne@google.com

[chromium] Update VideoLayerChromium to not access GC3D on the main thread
https://bugs.webkit.org/show_bug.cgi?id=66434

Reviewed by James Robinson.

Covered by existing tests.

This change allows the main thread VideoLayerChromium to not depend on
compositor thread resources (GC3D, LayerRendererChromium). The texture
allocation in VideoLayerChromium was changed to use ManagedTexture so
that textures can now be evicted when there is texture memory pressure
and so that destruction can be automatically deferred until a GC3D is
available.

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/ManagedTexture.cpp:
  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::size):
(WebCore::ManagedTexture::format):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::reserveTextures):
(WebCore::VideoLayerChromium::updateTexture):
(WebCore::VideoLayerChromium::releaseCurrentFrame):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::contentsTextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setTexture):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
10:13 Changeset [93795] by podivilov@chromium.org

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix chromium devtools tests.

  • src/js/Tests.js: (.TestSuite.prototype.evaluateInConsole_):
09:58 Changeset [93794] by inferno@chromium.org

Incorrect layout of :before and :after content, with display
table, table-row and table-cell.
https://bugs.webkit.org/show_bug.cgi?id=66699

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-after-child-in-table.html

fast/table/table-before-child-in-table.html
fast/table/table-cell-after-child-in-block.html
fast/table/table-cell-after-child-in-table.html
fast/table/table-cell-before-child-in-block.html
fast/table/table-cell-before-child-in-table.html
fast/table/table-row-after-child-in-block.html
fast/table/table-row-after-child-in-table.html
fast/table/table-row-before-child-in-block.html
fast/table/table-row-before-child-in-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
Fix the looping condition to detect :after child correctly.
isAnonymousBlock() does not apply to tables, instead
using isAnonymous().

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

LayoutTests:

  • fast/table/table-after-child-in-table.html: Added.
  • fast/table/table-before-child-in-table.html: Added.
  • fast/table/table-cell-after-child-in-block.html: Added.
  • fast/table/table-cell-after-child-in-table.html: Added.
  • fast/table/table-cell-before-child-in-block.html: Added.
  • fast/table/table-cell-before-child-in-table.html: Added.
  • fast/table/table-row-after-child-in-block.html: Added.
  • fast/table/table-row-after-child-in-table.html: Added.
  • fast/table/table-row-before-child-in-block.html: Added.
  • fast/table/table-row-before-child-in-table.html: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt: Added.
09:50 Changeset [93793] by weinig@apple.com

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66906

Reviewed by Darin Adler.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
Very similar fix to the one in r93717 except this patches the case where the image load was
canceled via beforeload.

09:42 Changeset [93792] by commit-queue@webkit.org

[chromium] Leaking SkBitmaps for background images
https://bugs.webkit.org/show_bug.cgi?id=66488

Patch by John Bates <jbates@google.com> on 2011-08-25
Reviewed by Stephen White.

This patch simply changes NativeImageSkia to have a SkBitmap instead of
deriving from SkBitmap. All dependent code updated to access the member
instead of calling SkBitmap methods on NativeImageSkia objects. This
may or may not fix the memory leak, but it's definitely a bug that could
cause memory leaks.

Source/WebCore:

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

  • platform/graphics/chromium/PlatformImage.cpp:

(WebCore::PlatformImage::updateFromImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::size):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::checkForSolidColor):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::decodedSize):
(WebCore::NativeImageSkia::resizedBitmap):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::bitmap):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/chromium:

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::clipboardWriteImage):

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::operator=):

09:14 Changeset [93791] by commit-queue@webkit.org

[SKIA] Move forward decl of skia type outside namespace Webkit
https://bugs.webkit.org/show_bug.cgi?id=66942

Patch by Brian Salomon <bsalomon@google.com> on 2011-08-25
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:
08:56 Changeset [93790] by commit-queue@webkit.org

Unreviewed, rolling out r93774.
http://trac.webkit.org/changeset/93774
https://bugs.webkit.org/show_bug.cgi?id=66945

It broke 26 tests on the Qt bot (Requested by ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke):

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect):

08:47 Changeset [93789] by caseq@chromium.org

Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=66858

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.initializeView):
(WebInspector.NetworkLogView.prototype.willHide):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._showPopover):

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.dispose):
(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove.doHide):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype.hidePopover):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopupTimer):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._scroll):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._onHidePopover):
(WebInspector.SourceFrame.prototype._shouldShowPopover):
(WebInspector.SourceFrame.prototype._getPopoverAnchor):
(WebInspector.SourceFrame.prototype._highlightExpression):
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePanel.prototype._closeRecordDetails):

08:46 Changeset [93788] by igor.oliveira@openbossa.org

Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66941

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/config/committers.py:
08:29 Changeset [93787] by ademar.reis@openbossa.org

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

08:22 Changeset [93786] by pfeldman@chromium.org

[Qt] REGRESSION(93769): inspector/console/console-tests.html fails
https://bugs.webkit.org/show_bug.cgi?id=66930

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-repeat-count.html

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleModel.prototype.interruptRepeatCount):
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleMessageAdded):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/console/console-repeat-count-expected.txt: Added.
  • inspector/console/console-repeat-count.html: Added.
08:18 Changeset [93785] by ademar.reis@openbossa.org

Unreviewed, rolling out r93783.
http://trac.webkit.org/changeset/93783
https://bugs.webkit.org/show_bug.cgi?id=66943

Commited wrong stuff by accident. (Requested by ademar on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • Api/qwebview.cpp:

(QWebView::load):
(QWebView::setHtml):
(QWebView::setContent):
(QWebView::setUrl):

08:13 Changeset [93784] by alexis.menard@openbossa.org

[Qt][WK2] Remove QWKContext class and make sure the WebProcessProxy life is correctly managed.
https://bugs.webkit.org/show_bug.cgi?id=66886

Reviewed by Benjamin Poulain.

Remove QWKContext class from Qt APIs as it is too low level for the vision
of the Qt5 API. QtWebPageProxy now holds directly a WebContext which can be a custom one
or default created one. This patch also ensure that the WebProcessProxy is correctly
destroyed at application exit by removing the circular references between the WebContext,
WebProcessProxy, and WebPageProxy.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_setStatusText):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::QDesktopWebPageProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • UIProcess/qt/qwkcontext.cpp: Removed.
  • UIProcess/qt/qwkcontext.h: Removed.
  • UIProcess/qt/qwkcontext_p.h: Removed.
  • WebKit2.pro:
07:59 Changeset [93783] by ademar.reis@openbossa.org

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

07:37 Changeset [93782] by mnaganov@chromium.org

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Tony Gentilcore.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::prune):
(WebCore::MemoryCache::pruneToPercentage):

  • loader/cache/MemoryCache.h: Methods moved from .h to .cpp to work around compilation problem with the Win Chromium port.
  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):
(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

06:08 Changeset [93781] by podivilov@chromium.org

Unreviewed, rolling out r93771.
http://trac.webkit.org/changeset/93771
https://bugs.webkit.org/show_bug.cgi?id=66933

Broke css3/font-feature-settings-rendering.html on chromium
mac 10.5 (Requested by podivilov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

05:52 Changeset [93780] by jocelyn.turcotte@nokia.com

[Qt][WK2] Drive tiling from the WebProcess and reuse TiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=66771

Reviewed by Tor Arne Vestbø.

We need the tiling logic to be moved to the web process to allow invalidated tile rects to be
rendered with the same layout. This also allows the web process to render tiles into
buffers readable directly by the GPU (on supported platforms). We also take the opportunity
to use the TiledBackingStore in WebCore to have only one tiling implementation.

Before this patch:

  • TiledDrawingAreaProxy manages tiles from the UI process.
  • TiledDrawingArea received rendering requests for a rect and returns the result to the proxy through shared memory.

After this patch:

  • TiledDrawingArea uses a TiledBackingStore to manage tiles from the web process.
  • TiledBackingStoreRemoteTile forwards tile creations, update and removals to the proxy.
  • TiledDrawingAreaProxy updates the scene graph directly from requests.

It also implements tile buffer swapping correctly in SGTileNode, triggered by the DidRenderFrame message.
Render throttling is implemented by waiting in TiledDrawingArea for the UI process to
notify us when the last rendered frame is ready to make it to the screen.
TiledDrawingAreaTileSets have been replaced by using two instances of TiledBackingStore instead.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

(WebCore::TiledBackingStoreClient::tiledBackingStoreIsUpdatingAllowed):

Source/WebKit2:

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportState):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::createTile):
(WebKit::DrawingAreaProxy::updateTile):
(WebKit::DrawingAreaProxy::didRenderFrame):
(WebKit::DrawingAreaProxy::removeTile):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::renderNextFrame):
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h: Removed.
  • UIProcess/qt/SGAgent.cpp:

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGAgent::SGAgent):
(WebKit::SGAgent::createTileNode):
(WebKit::SGAgent::removeTileNode):
(WebKit::SGAgent::setNodeBackBuffer):
(WebKit::SGAgent::swapTileBuffers):
(WebKit::SGAgent::updatePaintNode):
(WebKit::SGAgent::getScaleNode):
Make the parenting logic more strict to allow SGAgent to handle the scale nodes itself (remove NodeUpdateCreateScale and use the scale in CreateTile).
Delete the scale node when the last of its child tiles has been removed.

  • UIProcess/qt/SGAgent.h:

(WebKit::SGAgent::isSwapPending):

  • UIProcess/qt/SGTileNode.cpp:

(WebKit::SGTileNode::SGTileNode):
(WebKit::SGTileNode::setBackBuffer):
(WebKit::SGTileNode::swapIfNeeded):
Replace setTargetRect, setSourceRect and setTexture by a single setBackBuffer method.
This allows all those values to be used only when swapIfNeeded is called later.

  • UIProcess/qt/SGTileNode.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Removed.
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRect):
(WebKit::DrawingArea::setContentsScale):
(WebKit::DrawingArea::renderNextFrame):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp: Added.

(WebKit::TiledBackingStoreRemoteTile::TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::~TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::isDirty):
(WebKit::TiledBackingStoreRemoteTile::invalidate):
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::swapBackBufferToFront):
(WebKit::TiledBackingStoreRemoteTile::isReadyToPaint):
(WebKit::TiledBackingStoreRemoteTile::paint):
(WebKit::TiledBackingStoreRemoteTileBackend::TiledBackingStoreRemoteTileBackend):
(WebKit::TiledBackingStoreRemoteTileBackend::createTile):
(WebKit::TiledBackingStoreRemoteTileBackend::paintCheckerPattern):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h: Added.

(WebKit::TiledBackingStoreRemoteTile::create):
(WebKit::TiledBackingStoreRemoteTile::coordinate):
(WebKit::TiledBackingStoreRemoteTile::rect):
(WebKit::TiledBackingStoreRemoteTileClient::~TiledBackingStoreRemoteTileClient):
(WebKit::TiledBackingStoreRemoteTileBackend::create):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::setNeedsDisplay):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::setVisibleContentRect):
(WebKit::TiledDrawingArea::setContentsScale):
(WebKit::TiledDrawingArea::renderNextFrame):
(WebKit::TiledDrawingArea::suspendPainting):
(WebKit::TiledDrawingArea::resumePainting):
(WebKit::TiledDrawingArea::tiledBackingStorePaintBegin):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::tiledBackingStoreIsUpdatingAllowed):
(WebKit::TiledDrawingArea::tiledBackingStoreContentsRect):
(WebKit::TiledDrawingArea::tiledBackingStoreVisibleRect):
(WebKit::TiledDrawingArea::tiledBackingStoreBackgroundColor):
(WebKit::TiledDrawingArea::createTile):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::removeTile):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Removed.
05:52 Changeset [93779] by kbalazs@webkit.org

Unreviewed, rolling out r93775.
http://trac.webkit.org/changeset/93775
https://bugs.webkit.org/show_bug.cgi?id=66932

"Patch introduced the failures was rolled out." (Requested by
kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • platform/qt/Skipped:
05:49 Changeset [93778] by podivilov@chromium.org

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium expectations.

  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
05:31 Changeset [93777] by jocelyn.turcotte@nokia.com

TiledBackingStore: Untie the tile implementation from the platform.
https://bugs.webkit.org/show_bug.cgi?id=66760

Reviewed by Kenneth Rohde Christiansen.

Make the Tile class polymorphic and introduce TiledBackingStoreBackend as a Tile factory.

  • platform/graphics/Tile.h:

(WebCore::Tile::~Tile):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::client):

  • platform/graphics/TiledBackingStoreBackend.h: Added.

(WebCore::TiledBackingStoreBackend::create):
(WebCore::TiledBackingStoreBackend::~TiledBackingStoreBackend):
(WebCore::TiledBackingStoreBackend::TiledBackingStoreBackend):

  • platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::TileQt):
(WebCore::TileQt::~TileQt):
(WebCore::TileQt::isDirty):
(WebCore::TileQt::isReadyToPaint):
(WebCore::TileQt::invalidate):
(WebCore::TileQt::updateBackBuffer):
(WebCore::TileQt::swapBackBufferToFront):
(WebCore::TileQt::paint):
(WebCore::TiledBackingStoreBackend::paintCheckerPattern):
(WebCore::TiledBackingStoreBackend::createTile):

  • platform/graphics/qt/TileQt.h: Copied from Source/WebCore/platform/graphics/Tile.h.

(WebCore::TileQt::create):
(WebCore::TileQt::coordinate):
(WebCore::TileQt::rect):

05:30 Changeset [93776] by commit-queue@webkit.org

Unreviewed, rolling out r93767.
http://trac.webkit.org/changeset/93767
https://bugs.webkit.org/show_bug.cgi?id=66931

Broke Qt bot. (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • Scripts/webkitpy/thirdparty/init.py:
05:02 Changeset [93775] by kbalazs@webkit.org

Unreviewed Qt gardening.

  • platform/qt/Skipped:

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-25

04:48 Changeset [93774] by commit-queue@webkit.org

[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Patch by Andreas Kling <kling@webkit.org> on 2011-08-25
Reviewed by Benjamin Poulain.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

04:31 Changeset [93773] by yutak@chromium.org

WebSocket: Queue messages to be sent
https://bugs.webkit.org/show_bug.cgi?id=66298

Reviewed by Kent Tamura.

Blobs must be read asynchronously and thus cannot be sent immediately. Therefore, we need to
create a queue of messages to be sent in order to handle pending requests.

No new tests. Strictly speaking, there is a small change in behavior but it is hard to
reproduce in tests. See description of WebSocketChannel::send below.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
Now, this function always returns true if hybi-10 protocol is selected. The impact of this change
should be minimum, because the current WebSocket API defines the return type of WebSocket.send()
is void (see also bug 65850).
It's hard to make SocketStreamHandle::send() fail deliberately, therefore it's difficult to write
a test to detect this behavior change.
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):

  • websockets/WebSocketChannel.h:
03:30 Changeset [93772] by apavlov@chromium.org

Web Inspector: Directional arrow on element info box looks terrible
https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
03:18 Changeset [93771] by jeremy@chromium.org

Remove ATSFont*() functions in favor of CGFont in FontCustomPlatformData.cpp
https://bugs.webkit.org/show_bug.cgi?id=66629

As of r72774 and dropping support for OS X 10.4, we can safely
remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the
CGFont code.

This change is motivated by a bug in ATSFontDeactivite() on 10.7 which
affects the Chromium port, due to its compiling once against the 10.5
SDK for all platforms - See crbug.com/93191 or rdar://9976774 .

Reviewed by Dan Bernstein.

No new tests - covered by existing tests.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

03:05 Changeset [93770] by pfeldman@chromium.org

2011-08-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: rollout r93768 for breaking build.

  • inspector/DOMNodeHighlighter.cpp:
03:01 Changeset [93769] by pfeldman@chromium.org

Web Inspector: split ConsoleView into the View and the Model.
https://bugs.webkit.org/show_bug.cgi?id=66861

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ConsoleModel.js: Added.

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype._setConsoleMessageExpiredCount):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype._incrementErrorWarningCount):
(WebInspector.ConsoleModel.prototype.requestClearMessages):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleDispatcher):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleCommand):
(WebInspector.ConsoleView.prototype._appendConsoleCommandResult):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._requestClearMessages):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):

  • inspector/front-end/NetworkLog.js: Copied from Source/WebCore/inspector/front-end/externs.js.

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get resources):
(WebInspector.NetworkLog.prototype._frameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set finished):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._scriptForRawLocation):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.linkifyURLAsNode):
(WebInspector.formatLinkText):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._updateErrorAndWarningCounts):
(WebInspector.showConsole):

LayoutTests:

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
(initialize_ConsoleTest.InspectorTest.expandConsoleMessages):
(initialize_ConsoleTest):

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):
(initialize_InspectorTest):

  • http/tests/inspector/network/disabled-cache-crash.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-completions-on-call-frame.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
02:52 Changeset [93768] by apavlov@chromium.org

Web Inspector: Directional arrow on element info box looks terrible
https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
02:38 Changeset [93767] by commit-queue@webkit.org

[WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-25
Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:
02:25 Changeset [93766] by yutak@chromium.org

Let MessageEvent.data hold SerializedScriptValue or String selectively
https://bugs.webkit.org/show_bug.cgi?id=66841

Reviewed by Adam Barth.

MessageEvent from WebSocket contains a String in its "data" attribute, but it does not have
to be serialized.

No new tests are added, because this is refactoring and the behavior should not change.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
To call putAnonymousValue(), "this" needs to be converted to non-const using const_cast<>.
(WebCore::JSMessageEvent::initMessageEvent):
Update the cache value as well.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
ForceSet() is used to cache a value. This is the same as what the code generated by
CodeGeneratorV8 does.
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::data):
This is only used within the Objective-C bindings (JSC and V8 have the custom functions).
Since Objective-C code generator does not support [CustomGetter] IDL attribute, there is
no good way to return a variant value for Objective-C bindings.

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):

  • dom/MessageEvent.idl:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):
Construct a MessageEvent without serializing the received message.

01:38 Changeset [93765] by podivilov@chromium.org

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviwed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
01:13 Changeset [93764] by morrita@google.com

Unreviewed, rolling out r93762.
http://trac.webkit.org/changeset/93762
https://bugs.webkit.org/show_bug.cgi?id=66756

IndexedDb tests crash

Source/WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/generic/EventConstructors.h: Removed.
  • bindings/v8/OptionsObject.cpp:
  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/Event.idl:

LayoutTests:

  • fast/events/event-constructors-expected.txt: Removed.
  • fast/events/event-constructors.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
01:04 Changeset [93763] by zherczeg@webkit.org

[Qt] Add Qt specific expected after r93713 since ENABLE_MEDIA_STREAM is disabled.

Unreviewed, test expectations update.

  • platform/qt/fast/files/create-blob-url-crash-expected.txt: Added.

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-25

08/24/11:

23:58 Changeset [93762] by morrita@google.com

Implement an Event constructor.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Adam Barth.

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor.
This patch added the Event constructor to EventConstructors.h using
JavaScript implementation-independent macros. This patch also added the V8
implementation of these macros to V8EventConstructors.cpp.

Source/WebCore:

The bug 63878 has been implementing the Event constructors for JSC.
Our plan is to first implement all the Event constructors for V8
using EventConstructors.h proposed in the JSC patch, and then merge
the JSC patch with these V8 patches. In any case, we are going to split
the patches for V8 and those for JSC in order to avoid hard regression.

Test: fast/events/event-constructors.html

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Added V8EventConstructors.cpp.
  • bindings/generic/EventConstructors.h: Added. The Event constructor. This is written using JavaScript implementation-independent macros. The V8 implementation of these macros is written in bindings/v8/custom/V8EventConstructors.cpp.
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns the value of a given key of type double.
(WebCore::OptionsObject::getKey): Returns true whenever the given key is found, even if the value is null or undefined.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns the value of the given key. We need to overload getKeyValue() for all types required to EventConfiguration members.

  • bindings/v8/custom/V8EventConstructors.cpp: Added. Implemented macros used in EventConstructors.h.

(WebCore::constructV8Event): The Event constructor.

  • dom/Event.cpp:

(WebCore::EventConfiguration::EventConfiguration): A constructor of EventConfiguration.
(WebCore::Event::Event): A constructor of the Event class.

  • dom/Event.h: Added EventConfiguration, which manages attributes of the Event class.

(WebCore::Event::create): A factory method of the Event class with EventConfiguration.

  • dom/Event.idl: Added 'CanBeConstructed' and 'V8CustomConstructor'.

LayoutTests:

  • fast/events/event-constructors-expected.txt: Added.
  • fast/events/event-constructors.html: Added.
  • platform/gtk/Skipped: Skipped event-constructors.html, since Event constructors are not yet implemented in JSC.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
23:06 Changeset [93761] by philn@webkit.org

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

  • configure.ac:

WebCore:

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

Use fast element linking by default.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
23:02 BuildingGtk edited by philn@webkit.org
(diff)
22:50 Changeset [93760] by commit-queue@webkit.org

Some layerTreeAsText compositing tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=66913

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Simon Fraser.

Remove compositingLayerUpdatePending() and unconditionally update compositing layers when
RenderLayerCompositor::layerTreeAsText(). compositingLayerUpdatePending() was only used by test code and is
unreliable.

Covered by compositing/ layerTreeAsText tests.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:
22:31 Changeset [93759] by commit-queue@webkit.org

Implement a keypath parser strictly following the specification
https://bugs.webkit.org/show_bug.cgi?id=62288

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in keypath-basics.html.

Tests: storage/indexeddb/keypath-fetch-key.html

storage/indexeddb/keypath-basics.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath): Replaced IDBKeyPathElement with String
(WebCore::injectIDBKeyIntoSerializedValue): Replaced IDBKeyPathElement with String

  • bindings/v8/IDBBindingUtilities.h:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyStringWithUndefinedOrNullCheck): Returns false when a given value is null or undefined
(WebCore::OptionsObject::getKey): Removed undefined check

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore): Removed null check of a keypath

  • storage/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::currentElement): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lex): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lexIdentifier): Part of the keypath parser
(WebCore::IDBIsValidKeyPath): Checks if a keypath is valid
(WebCore::IDBParseKeyPath): Part of the keypath parser

  • storage/IDBKeyPath.h: Replaced IDBKeyPathElement with String
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBObjectStore.idl:

Source/WebKit/chromium:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in
tests/IDBKeyPathTest.cpp. We replaced IDBKeyPathElement with String here and there.

Tests: IDBKeyPathTest.*

IDBKeyFromValueAndKeyPathTest.*
InjectIDBKeyTest.*

  • public/WebIDBKeyPath.h:
  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::WebIDBKeyPath): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::assign): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Replaced IDBKeyPathElement with String

  • tests/IDBBindingUtilitiesTest.cpp:

(WebCore::checkKeyFromValueAndKeyPathInternal): Replaced IDBKeyPathElement with String
(WebCore::injectKey): Replaced IDBKeyPathElement with String
(WebCore::TEST): Rewrote tests for the new keypath parser

  • tests/IDBKeyPathTest.cpp:

(WebCore::checkKeyPath): Checks if a keypath is an expected keypath or not
(WebCore::TEST): Unit tests for the new keypath parser

LayoutTests:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We removed create-index-null-name.html since this test violates the
specification that says "a |keypath| argument of createIndex() must not be nullable".

  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-fetch-key-expected.txt: Renamed from LayoutTests/storage/indexeddb/keyPath-expected.txt.
  • storage/indexeddb/keypath-fetch-key.html: Renamed from LayoutTests/storage/indexeddb/keyPath.html.
  • storage/indexeddb/mozilla/create-index-null-name-expected.txt: Removed.
  • storage/indexeddb/mozilla/create-index-null-name.html: Removed.
20:35 Changeset [93758] by abarth@webkit.org

The user can't close the details view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66911

Reviewed by Dimitri Glazkov.

In addition to adding a close button, this patch changes the test
selector to use a <select> element and refactors the test selector to
share code with the builder selector.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
19:38 Changeset [93757] by jamesr@google.com

[chromium] Remove expected CRASH lines for tests that don't crash

  • platform/chromium/test_expectations.txt:
19:30 Changeset [93756] by jamesr@google.com

[chromium] Remove expected failure lines from tests that work now.

  • platform/chromium/test_expectations.txt:
18:25 Changeset [93755] by commit-queue@webkit.org

Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-24
Reviewed by Geoffrey Garen.

This patch adds a TopCallFrame to JSC in order to have that information
when an error is thrown to create a stack trace. The TopCallFrame is
updated throughout select points in the Interpreter and the JSC.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubCall.h:

(JSC::JITStubCall::call):

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
18:23 Changeset [93754] by msaboff@apple.com

Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
https://bugs.webkit.org/show_bug.cgi?id=66912

Updated the comment in ArgumentEncoder::grow to reflect that system malloc
currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.

Reviewed by Mark Rowe.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::grow):

18:05 Changeset [93753] by jamesr@google.com

[chromium] Update chromium mac baselines for fast/repaint/japanese-rl-selection-repaint-in-regions.html

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:02 Changeset [93752] by pkasting@chromium.org

[chromium] Mark a test as flaky.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:02 Changeset [93751] by commit-queue@webkit.org

[chromium] Stacktrace not in test output when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=66806

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.

Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
17:59 Changeset [93750] by ericu@chromium.org

Reviewed by Adam Barth.

[filesystem/Chromium] Filesystem paths need proper URL escaping
https://bugs.webkit.org/show_bug.cgi?id=62811

Fix http://code.google.com/p/chromium/issues/detail?id=78860 by making
KURLChromium.cpp's escaping code actually work.

Source/WebCore:

Make encodeWithURLEscapeSequences call into googleurl to do proper
escaping. Tested in WebKit/chromium/tests/KURLTest.cpp.

  • platform/KURLGoogle.cpp:

(WebCore::encodeWithURLEscapeSequences):

Source/WebKit/chromium:

Here I added the needed calls to encodeWithURLEscapeSequences.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::virtualPathToFileSystemURL):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::virtualPathToFileSystemURL):

Here I updated the test to reflect the new functionality in
encodeWithURLEscapeSequences.

  • tests/KURLTest.cpp:
17:35 Changeset [93749] by commit-queue@webkit.org

Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

Patch by Chris Palmer <palmer@google.com> on 2011-08-24
Reviewed by Kenneth Russell.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Check for integer overflow.
(WebCore::AudioArray::at): Document the safety assertion.
(WebCore::AudioArray::zero): Document the safety assertion.
(WebCore::AudioArray::zeroRange): Document the safety assertion.
(WebCore::AudioArray::copyToRange): Document the safety assertion.

16:04 Changeset [93748] by pkasting@chromium.org

[chromium] Update expectations after r93728 and r93737.

Unreviewed, test expectations update.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
16:01 Changeset [93747] by isherman@chromium.org

Remove some dead Autofill code
https://bugs.webkit.org/show_bug.cgi?id=66899
http://code.google.com/p/chromium/issues/detail?id=51644

Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebAutofillClient.h:
  • public/WebFrame.h:
  • public/WebPasswordAutocompleteListener.h: Removed.
  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::EditorClientImpl):
(WebKit::EditorClientImpl::handleKeyboardEvent):
(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/EditorClientImpl.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad):

  • src/WebFrameImpl.cpp:

(WebKit::frameContentAsPlainText):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::~WebFrameImpl):

  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

15:55 WikiStart edited by mjs@apple.com
(diff)
15:44 Changeset [93746] by paroga@webkit.org

[EFL] Fix build with ENABLE_GEOLOCATION.
https://bugs.webkit.org/show_bug.cgi?id=66881

Use adoptPtr() to create a new GeolocationService instance, otherwise
the build will fail when creating the PassOwnPtr object.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

  • platform/efl/GeolocationServiceEfl.cpp:

(WebCore::GeolocationServiceEfl::create):

15:35 Changeset [93745] by dbates@webkit.org

XSS filter bypass via document.write(location.href) and fragments
https://bugs.webkit.org/show_bug.cgi?id=66585

Reviewed by Darin Adler.

Add a test case for a variation of a DOM-based XSS attack using an anchor URL.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2.html: Added.
15:28 Changeset [93744] by paroga@webkit.org

[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=66880

Generate and build some additional files required by these options.

No new tests, as this is a build fix for some build options.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

  • CMakeLists.txt:
15:09 Changeset [93743] by commit-queue@webkit.org

[chromium] Don't call glDeleteTexture(0) in TextureManager
https://bugs.webkit.org/show_bug.cgi?id=66862

Delete(0) is allowed in standard OpenGL, but not in Chrome.
See http://code.google.com/p/chromium/issues/detail?id=85268

Patch by Iain Merrick <husky@google.com> on 2011-08-24
Reviewed by James Robinson.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::deleteEvictedTextures):

15:07 Changeset [93742] by jamesr@google.com

[chromium] Update expectations for tests that no longer crash.

  • platform/chromium/test_expectations.txt:
15:05 Changeset [93741] by abarth@webkit.org

Remove empty directory.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
14:56 Changeset [93740] by enne@google.com

[chromium] Properly initialize CCTiledLayerImpl::m_skipsDraw
https://bugs.webkit.org/show_bug.cgi?id=66889

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):

14:35 Changeset [93739] by cevans@google.com

Merge 93732
BUG=94011
Review URL: http://codereview.chromium.org/7734002

14:33 Changeset [93738] by abarth@webkit.org

Finish writing up details-view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66891

Reviewed by Dimitri Glazkov.

This patch mostly just copies a bunch of CSS from main.css to
summary.css. Presumably we'll delete main.css soon.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
14:27 Changeset [93737] by jamesr@google.com

Some compositing LayoutTests flakily crashing on Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=66740

Reviewed by Adam Barth.

Tools:

Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
chromium configuration.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

LayoutTests:

Remove = CRASH expectations for plugin tests that should no longer crash.

  • platform/chromium/test_expectations.txt:
14:25 Changeset [93736] by cevans@google.com

Merge 93521
BUG=89219
Review URL: http://codereview.chromium.org/7727007

14:20 Changeset [93735] by adauria@apple.com

No review necessary.

Adding myself to list of committers.

14:06 Changeset [93734] by commit-queue@webkit.org

Source/WebCore: chromium WebFrameImpl - don't load javascript URLs against chrome internal
pages. Adds a mechanism for registering sensitive schemes which should
not be subject to manipulation by javascript urls typed into a location bar
or, more importantly, their bookmarklet equivalents.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

Test: Chromium WebKit API unit test in chromium specific directory.

  • platform/SchemeRegistry.cpp:

(WebCore::notAllowingJavascriptURLsSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium: chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

  • public/WebSecurityPolicy.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs):

  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::WebFrameTest):
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::WebFrameTest::serveRequests):
(WebKit::WebFrameTest::loadHttpFrame):
(WebKit::WebFrameTest::loadChromeFrame):
(WebKit::WebFrameTest::registerMockedURLLoad):
(WebKit::WebFrameTest::loadFrame):
(WebKit::TEST_F):

  • tests/data/history.html: Added.
13:39 Changeset [93733] by pkasting@chromium.org

[chromium] More test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:36 Changeset [93732] by ap@apple.com

Plug-in tests are flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=66822

Reviewed by Anders Carlsson.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Protect objects that can be removed by a script.
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto. Also fixed some nonsense code.
13:31 Changeset [93731] by lforschler@apple.com

Versioning.

13:30 Changeset [93730] by lforschler@apple.com

New tag.

13:27 Changeset [93729] by scherkus@chromium.org

Merge 93715: rebaselining media/video-currentTime-set.html

13:20 Changeset [93728] by commit-queue@webkit.org

[CSSRegions] Fix Element::getBoundingClientRect and Element::getClientRects for content flow
https://bugs.webkit.org/show_bug.cgi?id=66641

Original author of the patch is Mihnea Ovidenie <mihnea@adobe.com>.

Source/WebCore:

Redirected the mapLocalToContainer method to the appropriate RenderRegion.

Note: RenderObject::absoluteQuads method needs some refactor to support multiple regions,
will do that in a separate bug.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Tests: fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html

fast/regions/flowed-content-bounding-client-rect-vertical-rl.html
fast/regions/flowed-content-bounding-client-rect-vertical.html
fast/regions/flowed-content-bounding-client-rect.html
fast/regions/flowed-content-transform-bounding-client-rect.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):

  • rendering/RenderFlowThread.h:

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical.html: Added.
  • fast/regions/flowed-content-bounding-client-rect.html: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect.html: Added.
  • fast/regions/resources/helper.js: Added.

(rectToArray):
(areEqualNumbers):
(areEqualRects):
(assertEqualRects):
(testBoundingRects):

13:17 Changeset [93727] by alokp@chromium.org

[chromium] Root layer is not updated when only a portion of tile is updated
https://bugs.webkit.org/show_bug.cgi?id=66506

This only happened in the accelerated path which changes stencil state.
Incorrect stencil state was used to draw the root layer.

Reviewed by James Robinson.

Test: compositing/overflow/overflow-scroll.html (existing)

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

13:16 Changeset [93726] by japhet@chromium.org

2011-08-24 Nate Chapin <japhet@chromium.org>

Fix an intermittent crash in EventSource, when a
reconnect timer triggers after a navigation
away from the current page begins.
https://bugs.webkit.org/show_bug.cgi?id=45202

Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::connect): Don't set m_requestInFlight

to true if ThreadableLoader::create() failed.

13:08 Changeset [93725] by reed@google.com

Change clip routine to promote the clipbounds up to (local) floats and then perform the intersection,
rather than rounding the srcRect down to integers.
https://bugs.webkit.org/show_bug.cgi?id=66810

Reviewed by Kenneth Russell.

No new tests. Existing tests that resize images will exercise this code path

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

13:04 Changeset [93724] by commit-queue@webkit.org

Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=66875

Patch by Avi Drissman <avi@google.com> on 2011-08-24
Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

13:02 Changeset [93723] by andersca@apple.com

Rename -[WKTextInputWindowController keyboardInputSourceChanged] to unmarkText to indicate what the method does
https://bugs.webkit.org/show_bug.cgi?id=66883

Reviewed by Beth Dakin.

  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _unmarkText]):
(-[WKTextInputWindowController unmarkText]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

12:56 Changeset [93722] by pkasting@chromium.org

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [93721] by commit-queue@webkit.org

[CSSRegions] RenderRegion is not used if there's another renderer after it
https://bugs.webkit.org/show_bug.cgi?id=66844

Source/WebCore:

There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
the region was not added to the RenderFlowThread.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.
12:34 Changeset [93720] by oliver@apple.com

JSNPObject and JSNPMethod create their structure in their constructors
https://bugs.webkit.org/show_bug.cgi?id=66879

Reviewed by Anders Carlsson.

It's not safe to create the Structure for an object inside its constructor
so we hoist construction out into their ::create methods and move the methods
into the cpp file.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

12:32 Changeset [93719] by lforschler@apple.com

Update SVN properties to help out the Windows EWS bots.

Reviewed by Adam Roben.

  • win: Modified properties svn:ignore.
  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
12:06 Changeset [93718] by pkasting@chromium.org

[chromium] Organize SLOW section of expectations.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:28 Changeset [93717] by weinig@apple.com

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66864

Reviewed by Anders Carlsson.

In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
JSHTMLImageElement is kept alive forever (and since it references the global object, it
keeps the entire graph alive as well).

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
Set m_firedLoad to true in the case of a canceled load, to reset the state back to
its initial values.

11:27 Changeset [93716] by mrowe@apple.com

Merge r93376.

11:23 Changeset [93715] by scherkus@chromium.org

2011-08-24 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining media/video-currentTime-set.html due to
FFmpeg udpate.

  • platform/chromium-cg-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
11:15 TestExpectations edited by pkasting@chromium.org
(diff)
11:09 Changeset [93714] by commit-queue@webkit.org

Expose fullscreen API on WebElement/WebDocument
https://bugs.webkit.org/show_bug.cgi?id=66746

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-24
Reviewed by Darin Fisher.

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setFullscreen):

  • src/WebPluginContainerImpl.h:
11:07 Changeset [93713] by commit-queue@webkit.org

MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925

Source/WebCore:

This patch introduces the functionality for generating the url associated with a MediaStream,
which can then be assigned to the src attribute of the <video> tag for example.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:
  • html/DOMURL.idl:
  • platform/MediaStreamRegistry.cpp: Added.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

  • platform/MediaStreamRegistry.h: Copied from Source/WebCore/html/DOMURL.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

LayoutTests:

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • fast/files/create-blob-url-crash-expected.txt:
11:00 Changeset [93712] by andersca@apple.com

More plug-in complex text input scaffolding
https://bugs.webkit.org/show_bug.cgi?id=66865

Reviewed by Sam Weinig.

Make -[WKView _doneWithKeyEvent:eventWasHandled:] take an NSEvent * directly. Also
add methods for handling plug-in text input key-down events.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
(-[WKView keyDown:]):
(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
(-[WKView _doneWithKeyEvent:eventWasHandled:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:55 Changeset [93711] by commit-queue@webkit.org

[GTK] WebProcess crash on hitting assertion m_isWaitingForDidUpdate in DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=66640

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-24
Reviewed by Martin Robinson.

The crash happens when a new timer is created in an existing timer callback. Since
TimerBase has a single GSource* it gets overridden and the old timer can never get
stopped. To handle this, keep a copy of the old timer and use it for destruction.

  • Platform/RunLoop.h:
  • Platform/gtk/RunLoopGtk.cpp:

(RunLoop::TimerBase::timerFiredCallback):
Store the timerSource so that even if it is modified by the timer callback,
it can be restored for freeing it.
(RunLoop::TimerBase::start):
Remove destroyNotifyCallback. Destruction is now handled in timerFiredCallback itself.

10:44 Changeset [93710] by fpizlo@apple.com

ErrorInstance::create sometimes has two heap object constructions
in flight at once
https://bugs.webkit.org/show_bug.cgi?id=66845

Reviewed by Darin Adler.

The fix is simple since there is already a second create() method
that takes a UString.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::create):

10:42 Changeset [93709] by levin@chromium.org

MessageEvent.ports shouldn't ever be null.
https://bugs.webkit.org/show_bug.cgi?id=66789

Reviewed by Darin Adler.

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports): Never return null.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter): Ditto.

LayoutTests:

Fix all tests which verified that MessageEvents.ports was null in various cases.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js:

(channel.port2.onmessage):

  • fast/workers/resources/worker-context-multi-port.js:

(worker.onmessage):

  • fast/workers/resources/worker-messageport.js:

(onmessage):

  • fast/workers/resources/worker-thread-multi-port.js:

(onmessage):

  • fast/workers/worker-context-multi-port-expected.txt:
  • fast/workers/worker-messageport-expected.txt:
  • fast/workers/worker-multi-port-expected.txt:
  • platform/chromium-win/fast/events/message-port-multi-expected.txt:
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt:
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:30 Changeset [93708] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=66799
RenderFlowThread creates a list of child elements, so that it can search
the insertion point of a new element without searching the whole DOM.
The issue is that it used addChild/removeChild, but that wasn't taking care of
elements added in anonymous blocks created inside the RenderFlowThread.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-24
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/flow-anonymous-children.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addFlowChild):
(WebCore::RenderFlowThread::removeFlowChild):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::renderFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

  • fast/regions/flow-anonymous-children-expected.txt: Added.
  • fast/regions/flow-anonymous-children.html: Added.
08:04 Changeset [93707] by commit-queue@webkit.org

[SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface
https://bugs.webkit.org/show_bug.cgi?id=66809

Patch by Brian Salomon <bsalomon@google.com> on 2011-08-24
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::grGLInterface):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::grContext):

06:35 Changeset [93706] by pfeldman@chromium.org

Web Inspector: Add 9 more javascript files to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=66847

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/Checkbox.js:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleStackFrame):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/CookieParser.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(WebInspector.isMac):

  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.Type.Document.0.Stylesheet.1.Image.2.Font.3.Script.4.XHR.5.WebSocket.7.Other.8.isTextType):
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
(WebInspector.Resource.prototype._checkWarnings):
(WebInspector.ResourceDomainModelBinding):
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
(WebInspector.ResourceDomainModelBinding.prototype.setContent):

  • inspector/front-end/ResourceCategory.js:

(WebInspector.ResourceCategory):
(WebInspector.ResourceCategory.prototype.toString):
(WebInspector.ResourceCategory.prototype.get title):

  • inspector/front-end/ResourceTreeModel.js:
  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterMappingPayload):

  • inspector/front-end/TimelineManager.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(console.assert):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
(WebInspector.UIString):
(Element.prototype.scrollIntoViewIfNeeded):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.UIString):

  • inspector/front-end/treeoutline.js:
  • inspector/front-end/utilities.js:
  • inspector/generate-protocol-externs:
05:52 Changeset [93705] by pfeldman@chromium.org

Web Inspector: extract ConsoleMessage into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66853

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessage.prototype.clearHighlight):
(WebInspector.ConsoleMessage.prototype.highlightSearchResults):
(WebInspector.ConsoleMessage.prototype.matchesRegex):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/WebKit.qrc:
04:40 Changeset [93704] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, chromium rebaseline for gradient-after-transparent-border.

  • platform/chromium-cg-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-cg-mac/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium/test_expectations.txt:
03:52 Changeset [93703] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update test expectations for svg/custom/stroke-opacity-update.

  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium-win/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • platform/qt/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • svg/custom/stroke-opacity-update-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/stroke-opacity-update-expected.txt.
03:51 Changeset [93702] by commit-queue@webkit.org

Source/WebCore: Paint SliderTrack and SliderThumb independently.
https://bugs.webkit.org/show_bug.cgi?id=50453
Also fixes https://bugs.webkit.org/show_bug.cgi?id=65456 crash.

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

RenderSlider works only with <input type=range>. Nowadays RenderTheme
supports painting of SliderTrack and SliderThumb without range input.
In order to be in sync with other platforms this patch gets rid of
upcasting in RenderThemeQt::paintSliderTrack and allows to paint
SliderTrack and SliderThumb independently.

Test: platform/qt/fast/forms/range/slider-crash.html

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSliderTrack): Draw SC_SliderGroove.
Allow paintSliderThumb() to care about SC_SliderHandle. We don't need
to setup value and position anymore, since handle is drawn separately.
Draw focus explicitly, since QStyleOptionSlider doesn't allow to focus
on CC_Slider without handle subcontrol.
(WebCore::RenderThemeQt::paintSliderThumb): Draw SC_SliderHandle.

LayoutTests: Pixel crash test for RenderThemeQt::paintSliderTrack.
https://bugs.webkit.org/show_bug.cgi?id=50453

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

Support -webkit-appearance: slider-horizontal/vertical
painting without range input.

  • platform/qt/fast/forms/range/slider-crash-expected.png: Added.
  • platform/qt/fast/forms/range/slider-crash-expected.txt: Added.
  • platform/qt/fast/forms/range/slider-crash.html: Added.
03:18 Changeset [93701] by pfeldman@chromium.org

Web Inspector: annotate and prepare for compilation first 14 JavaScript files within 4 modules.
https://bugs.webkit.org/show_bug.cgi?id=66776

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ContextMenu.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._inspectElementRequested):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.addEventListener):
(WebInspector.Object.prototype.removeEventListener):
(WebInspector.Object.prototype.hasEventListeners):

  • inspector/front-end/Panel.js:

(WebInspector.Panel):

  • inspector/front-end/Placard.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.show):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.StorageCategoryTreeElement):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.Settings.prototype.createSetting):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):

  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/UserMetrics.js:
  • inspector/front-end/View.js:
  • inspector/front-end/externs.js:

(JSON.parse):
(JSON.stringify):

  • inspector/front-end/inspector.js:

():

  • inspector/generate-protocol-externs:
03:10 Changeset [93700] by podivilov@chromium.org

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix chromium expectations for fast/preloader/script.html.

  • platform/chromium/fast/preloader/script-expected.txt: Added.
02:52 Changeset [93699] by andreas.kling@nokia.com

SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787

Reviewed by Darin Adler.

Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
its data members.

Also added missing initialization of m_userDrivenChange.

  • dom/SelectElement.cpp:

(WebCore::SelectElementData::SelectElementData):

  • dom/SelectElement.h:
02:50 Changeset [93698] by fpizlo@apple.com

There is no facility for profiling how the write barrier is used
https://bugs.webkit.org/show_bug.cgi?id=66747

Reviewed by Geoffrey Garen.

Added facilities for the JIT to specify the kind of write barrier
being executed. Added code for profiling the number of each kind
of barrier encountered.

(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • heap/WriteBarrierSupport.cpp: Added.

(JSC::WriteBarrierCounters::initialize):

  • heap/WriteBarrierSupport.h: Added.

(JSC::WriteBarrierCounters::WriteBarrierCounters):
(JSC::WriteBarrierCounters::jitCounterFor):
(JSC::WriteBarrierCounters::countWriteBarrier):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setWithoutWriteBarrier):

02:48 Changeset [93697] by commit-queue@webkit.org

[EFL] Add dummy IconDatabaseClientEfl.
http://bugs.webkit.org/show_bug.cgi?id=65596

Implements a dummy IconDatabaseClientEfl class.
Adds two files, IconDatabaseClientEfl.h | .cpp.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-08-24
Reviewed by Kent Tamura.

  • CMakeListsEfl.txt:
  • WebCoreSupport/IconDatabaseClientEfl.cpp: Added.

(WebCore::IconDatabaseClientEfl::performImport):
(WebCore::IconDatabaseClientEfl::didRemoveAllIcons):
(WebCore::IconDatabaseClientEfl::didImportIconURLForPageURL):
(WebCore::IconDatabaseClientEfl::didImportIconDataForPageURL):
(WebCore::IconDatabaseClientEfl::didChangeIconForPageURL):
(WebCore::IconDatabaseClientEfl::didFinishURLImport):

  • WebCoreSupport/IconDatabaseClientEfl.h: Added.
02:07 Changeset [93696] by commit-queue@webkit.org

Web Inspector: clearPseudoState should retain Element while clearing
its state.
https://bugs.webkit.org/show_bug.cgi?id=66790

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-24
Reviewed by Yury Semikhatsky.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearPseudoState):

Note: See TracTimeline for information about the timeline view.