Timeline



Aug 29, 2011:

11:40 PM Changeset in webkit [94053] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Touch Internals.cpp in an attempt to fix GTK+ build.

  • testing/Internals.cpp:
11:37 PM Changeset in webkit [94052] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk/LayoutTests

Fix two layout tests which fails on Qt port with latest pywebsocket.
https://bugs.webkit.org/show_bug.cgi?id=66929

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-29
Reviewed by Kent Tamura.

hanging-handshake_wsh.py read socket to hang in opening handshake.
Then client initiated closing handshakes or abnormal closures caused
exception or resulted in http error response on hybi-10 compliant new
pywebsocket. Because tests finished at closure, it depends on timing
whether tests detects the error response. Actually, two tests failed on
Qt port by chance.
Essentially, hangings is unnecessary because open event must be queued
and WebSocket's readyState could not be changed to OPEN until the next
event loop is executed. That's why we can use echo_wsh.py instead of
hanging-handshake_wsh.py safely.

close-unref-websocket tests call close() before GC. These tests expect
GC cause close event. But close() itself also queues close event.
These close() are redandant. If GC doesn't cause close event, these
tests can pass by close event that close() queues. This change also
remove these redandant close() calls.

  • http/tests/websocket/tests/hixie76/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hybi/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

11:29 PM Changeset in webkit [94051] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Another Windows build fix after r94047.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
11:19 PM Changeset in webkit [94050] by rniwa@webkit.org
  • 2 edits in trunk

Build fix attempt after r94038.

  • Source/autotools/symbols.filter:
11:07 PM Changeset in webkit [94049] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):

10:55 PM Changeset in webkit [94048] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add exception due to missing results for r94037.

  • platform/chromium/test_expectations.txt:
10:51 PM Changeset in webkit [94047] by rniwa@webkit.org
  • 12 edits in trunk/Source/WebCore

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement.

Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement
and related inline functions from RenderTextControl to HTMLTextFormControlElement.
Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated,
added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement
and HTMLTextAreaElement.

This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false
when input or textarea don't have renderer (e.g. invisible).

Unfortunately, there is no way to test this behavioral change from layout tests.

  • WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of

that of HTMLInputElement and HTMLTextAreaElement.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon): Ditto.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true
as it used to do via respondToChangeByUser.
(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Moved from RenderTextControl.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::setLastChangeWasNotUserEdit): Added.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl): No longer initializes m_lastChangeWasUserEdit.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Calls setInnerTextValue.

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::updateFromElement): Ditto.

10:27 PM Changeset in webkit [94046] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed marking skip.

  • platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html
10:22 PM Changeset in webkit [94045] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

  • fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
  • fast/forms/file/disabling-file-busy-loop.html: Added.
10:01 PM Changeset in webkit [94044] by dbates@webkit.org
  • 4 edits in trunk/Source

Add HAVE(VASPRINTF) macro to test for vasprintf() support
https://bugs.webkit.org/show_bug.cgi?id=67156

Reviewed by Darin Adler.

Source/JavaScriptCore:

Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.

  • wtf/Platform.h:

Source/WebCore:

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).

9:57 PM Changeset in webkit [94043] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Minor update for test that is timing out.

  • platform/chromium/test_expectations.txt:
9:51 PM Changeset in webkit [94042] by levin@chromium.org
  • 2 edits
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[chromium] Misc test expectations updates.

  • platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.
  • platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.

Added due to it being different from normal OSX result.

  • platform/chromium/test_expectations.txt: Changes due to expectation update for media-document-audio-repaint.html leading to only an image mismatch and a test that is a slow on OS X as well as Linux and Windows.
8:38 PM Changeset in webkit [94041] by yutak@chromium.org
  • 14 edits
    10 adds in trunk

WebSocket: Receive binary message as Blob
https://bugs.webkit.org/show_bug.cgi?id=67115

Reviewed by Kent Tamura.

Source/WebCore:

Make WebSocketChannel be able to receive WebSocket binary messages and deliver them via
didReceiveBinaryData() callback of WebSocketChannelClient.

Tests: http/tests/websocket/tests/hybi/fragmented-binary-frames.html

http/tests/websocket/tests/hybi/receive-blob.html
http/tests/websocket/tests/hybi/workers/receive-blob.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Convert Blob to JSValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Convert Blob to v8::Value.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

Added DataTypeBlob and Blob-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsBlob):

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):
If binaryType attribute is "blob", construct a Blob using BlobData filled with the given
binary message.

  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):
Create continuousFrameData as OwnPtr<> rather than stack-allocated value so we can easily
pass it to didReceiveBinaryData() callback.
Save the content of a fragmented message even if it is a binary opcode.

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didReceiveBinaryData):

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
Pass binaryData as PassOwnPtr<Vector<char> > to deliver the value efficiently (without
copying the content) across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/binary-frames_wsh.py: Added. Used from receive-blob.html.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames.html:

Added. The content of this test is almost identical to receive-blob.html.

  • http/tests/websocket/tests/hybi/fragmented-binary-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/receive-blob.html:

Added. It is a bit complicated to validate the content of a Blob, because a Blob must be read
asynchronously. FileReader is used to read a blob as an ArrayBuffer, each byte of which is
compared with the expected result.

  • http/tests/websocket/tests/hybi/workers/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/receive-blob.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/binary-frames_wsh.py:

Added. Same as above binary-frames_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/receive-blob.js: Added.
7:29 PM Changeset in webkit [94040] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Export more symbols for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
7:19 PM Changeset in webkit [94039] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Windows build fix for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
7:03 PM Changeset in webkit [94038] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=67173

Reviewed by Darin Adler.

Source/WebCore:

Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.

Test: fast/forms/textfield-lastchange-was-useredit.html

  • testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.

  • fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
  • fast/forms/textfield-lastchange-was-useredit.html: Added.
6:49 PM Changeset in webkit [94037] by macpherson@chromium.org
  • 3 edits
    4 adds in trunk

Implement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67106

Reviewed by Darin Adler.

Tests:
LayoutTests/fast/multicol/inherit-column-values.html
LayoutTests/fast/multicol/initial-column-values.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handler for CSSPropertyWebkitColumns.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementation for CSSPropertyWebkitColumns.

6:43 PM Changeset in webkit [94036] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

sheriffbot "usage" help statements are wrong
https://bugs.webkit.org/show_bug.cgi?id=67170

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
6:43 PM Changeset in webkit [94035] by commit-queue@webkit.org
  • 27 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):

  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
(JSC::Arguments::finishCreation):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::finishCreation):

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
Moved the assignment of m_firstLine and m_lastLine into the
FunctionExecutable::finishCreation() method in Executable.h

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::finishCreation):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::finishCreation):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):

  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::finishCreation):

  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):

  • runtime/ObjectPrototype.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

Source/JavaScriptGlue:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • UserObjectImp.cpp:

(UserObjectImp::UserObjectImp):

Source/WebCore:

No new tests.

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::finishCreation):

  • bindings/js/JSDOMWindowShell.h:
6:29 PM Changeset in webkit [94034] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

[EFL] Add missing API documentation.
https://bugs.webkit.org/show_bug.cgi?id=66927

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-29
Reviewed by Kent Tamura.

Adds missing documentation for ewk_context_menu_item_checked_get/set.
Moves API documentation from cpp to the headers.
Adds brief and file commands for ewk_js.h.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_js.h:
4:47 PM Changeset in webkit [94033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QTouchWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67159

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
4:42 PM Changeset in webkit [94032] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 94001
BUG=91911
Review URL: http://codereview.chromium.org/7795013

4:39 PM Changeset in webkit [94031] by abarth@webkit.org
  • 12 edits in trunk/Tools

Add support for chomium-mac (non-CoreGraphics) baselines
https://bugs.webkit.org/show_bug.cgi?id=67163

Reviewed by Eric Seidel.

This patch teaches the non-CG chromium-mac bots to look at non-CG
baselines. However, the patch still leaves CG as the default set of
baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4:37 PM Changeset in webkit [94030] by jonlee@apple.com
  • 2 edits in trunk/Websites/webkit.org

Updating forms survey with non-standard wrap for textarea and more data-list driven text fields.

  • projects/forms/survey.html:
4:35 PM Changeset in webkit [94029] by cevans@google.com
  • 2 edits in branches/chromium/835/Source/WebCore/webaudio

Merge 94002
BUG=93978
Review URL: http://codereview.chromium.org/7793016

4:21 PM Changeset in webkit [94028] by imasaki@chromium.org
  • 6 edits
    5 adds in trunk/LayoutTests

[Chromium] Added new rebaselines for media/media-document-audio-repaint.
These are obtained by the rebaseline tool.
https://bugs.webkit.org/show_bug.cgi?id=67070

Reviewed by David Levin.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
4:19 PM Changeset in webkit [94027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
3:54 PM Changeset in webkit [94026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884

Patch by John Bauman <jbauman@chromium.org> on 2011-08-29
Reviewed by Kenneth Russell.

BGRA input is common coming from skia, so optimize BGRA->RGBA
conversion and also avoid the pointless RGBA to RGBA conversion.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doUnpackingAndPacking):

3:53 PM Changeset in webkit [94025] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Fix path to style sheet in fast/events/constructors/event-constructors.html.

Reviewed by Gavin Barraclough.

  • fast/events/constructors/event-constructors.html:
3:52 PM Changeset in webkit [94024] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
https://bugs.webkit.org/show_bug.cgi?id=67099

Reviewed by Simon Fraser.

No new tests. Testing the "fallback to old path" behavior is not easily testable.

  • platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to old path if IOSurface creation path fails.

(WebCore::ImageBuffer::ImageBuffer):

3:51 PM Changeset in webkit [94023] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update results for fast/files/create-blob-url-crash.html to match
exception text.

  • fast/files/create-blob-url-crash-expected.txt:
3:43 PM Changeset in webkit [94022] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93793.

3:41 PM Changeset in webkit [94021] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93717.

3:30 PM Changeset in webkit [94020] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.4

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • configure.ac: Update library version.

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • NEWS: Update the news.
2:57 PM Changeset in webkit [94019] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Only enable font smoothing as requested (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=67143

This adjusts LayoutTest pixel output to more closely
match other platforms.

Reviewed by Kenneth Russell.

No new tests. This platform is not yet enabled.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.

2:47 PM Changeset in webkit [94018] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test_expectation.txt typo.

  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [94017] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Update test expections due to r94006 and r93978.

  • platform/chromium/test_expectations.txt: Add failing test due to r93978.
  • platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and behavior change in r94006.
2:32 PM Changeset in webkit [94016] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

Assertion failure in RenderLayer::computeRepaintRects when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67140

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/scroll-fixed-layer-with-no-visible-content.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeRepaintRects): Fixed style after r93837.

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Tweaked the code
to bail early if our layer has no visible content. This avoids the ASSERT
and also makes sense as we shouldn't repaint / update empty layers.

LayoutTests:

This test checks that a fixed element with no visible content does not ASSERT and
renders properly.

  • fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-no-visible-content.html: Added.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
2:12 PM Changeset in webkit [94015] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r90368

1:59 PM Changeset in webkit [94014] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r86118

1:58 PM Changeset in webkit [94013] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r86116

1:56 PM Changeset in webkit [94012] by Martin Robinson
  • 14 edits
    2 adds in releases/WebKitGTK/webkit-1.4/Source

Merging r86102

1:47 PM Changeset in webkit [94011] by commit-queue@webkit.org
  • 12 edits
    1 copy
    2 adds in trunk/Source/WebCore

Implement WebVTT Cue Text Parsing rules and DOM construction
https://bugs.webkit.org/show_bug.cgi?id=64132

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-29
Reviewed by Adam Barth.

Tests in media/track, particularly track-webvtt-tc[022 - 028]*.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCue.cpp:
  • html/TextTrackCue.h:
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
  • platform/track/WebVTTParser.cpp:
  • platform/track/WebVTTParser.h:
  • platform/track/WebVTTToken.h: Added.
  • platform/track/WebVTTTokenizer.cpp: Added.
  • platform/track/WebVTTTokenizer.h: Added.
1:32 PM Changeset in webkit [94010] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Add parsing support for extended attributes on IDL constants
https://bugs.webkit.org/show_bug.cgi?id=65046

Reviewed by Brent Fulgham.

With support for extended attributes on constants we can
replace some preprocessor lines from the IDL files with
the corresponding [Conditional=XXX] later.
Using the preprocessor causes much pain on native windows.

CodeGenerator support will be added in separate patches.

  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
1:18 PM Changeset in webkit [94009] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
https://bugs.webkit.org/show_bug.cgi?id=67141

Reviewed by Eric Seidel.

No new tests since this is a refactoring.

  • dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
  • html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
to avoid the conflict with value().

  • html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
HTMLInputElement.cpp and HTMLTextAreaElement.cpp.

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.

1:16 PM Changeset in webkit [94008] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Small fix in chromium port of new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=67078

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-29
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:09 PM Changeset in webkit [94007] by commit-queue@webkit.org
  • 28 edits in trunk

Unreviewed, rolling out r93987, r93992, r93995, r93998, and
r93999.
http://trac.webkit.org/changeset/93987
http://trac.webkit.org/changeset/93992
http://trac.webkit.org/changeset/93995
http://trac.webkit.org/changeset/93998
http://trac.webkit.org/changeset/93999
https://bugs.webkit.org/show_bug.cgi?id=67147

Many failing tests (Requested by ap on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-29

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/CookieJar.mm:

(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/network/CookieStorage.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::privateStorageSession):
(WebCore::privateBrowsingStorageSessionIdentifierBase):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::defaultSessionCookieStorage):
(WebCore::defaultCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
(WebCore::ResourceHandle::currentStorageSession):
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::setCookieStoragePrivateBrowsingEnabled):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

  • WebCookieManagerCFNet.cpp:

(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):

  • WebView.cpp:

(updateSharedSettingsFromPreferencesIfNeeded):

Source/WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

1:06 PM Changeset in webkit [94006] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

As per HTML specification, default font style of dfn tag should be italic.
https://bugs.webkit.org/show_bug.cgi?id=56670

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-29
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/dfn-default-font-style.html

  • css/html.css:

(i, cite, em, var, address, dfn):

LayoutTests:

  • fast/css/dfn-default-font-style-expected.txt: Added.
  • fast/css/dfn-default-font-style.html: Added.
1:03 PM Changeset in webkit [94005] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
https://bugs.webkit.org/show_bug.cgi?id=65040

Reviewed by Brent Fulgham.

JSValueToNative and NativeToJSValue add additional include statements
to the implementation and need to handle the Conditional attribute from
the IDL file. The Conditional attribute adds appropriate #if ENABLE()
lines for the preprocessor around the include statements to remove
some unneeded build dependencies.

  • bindings/scripts/CodeGeneratorJS.pm:
12:35 PM Changeset in webkit [94004] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add ability to do static SerializedScriptValue deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877

Patch by Greg Billock <gbillock@google.com> on 2011-08-29
Reviewed by Darin Fisher.

  • public/WebSerializedScriptValue.h:
  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::serialize):

12:26 PM Changeset in webkit [94003] by Nate Chapin
  • 8 edits in trunk/Source/WebCore

Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
https://bugs.webkit.org/show_bug.cgi?id=66018

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::load):

(WebCore::CachedResource::setResourceLoaderOptions):
(WebCore::CachedResource::sendResourceLoadCallbacks):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):

  • loader/cache/CachedResourceRequest.h:
12:23 PM Changeset in webkit [94002] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Fix failures when FFT size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

Test: webaudio/fft-sizing.html

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.

  • webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).

LayoutTests: Fix failures when FFT array size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

  • webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
  • webaudio/realtimeanalyser-fft-sizing.html: Added.
12:19 PM Changeset in webkit [94001] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/line-layout/inline-box-wrapper-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.

LayoutTests:

  • fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
  • fast/block/line-layout/inline-box-wrapper-crash.html: Added.
12:19 PM Changeset in webkit [94000] by Martin Robinson
  • 3 edits in trunk

Reviewed by Xan Lopez.

[GTK] Build WebKit2 unconditionally
https://bugs.webkit.org/show_bug.cgi?id=62749

Build WebKit2 by default. This will make the bots build it and catch
build errors when they occur.

  • GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2

PC file, which should not be shipped until WebKit2 is actually shipped officially.

12:07 PM Changeset in webkit [93999] by ap@apple.com
  • 4 edits in trunk/Source

Windows build fix.

WebKit/win:

  • WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated for new function name and signature: currentCFHTTPCookieStorage().

WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:59 AM Changeset in webkit [93998] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Lion build fix.

  • WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions of Mac OS X, and need separate exports.
11:54 AM Changeset in webkit [93997] by cmarrin@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixing LayoutTests broken by http://trac.webkit.org/changeset/93980

Unreviewed.


Add Mac specific tests to take into account new requestAnimationFrame functionality

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/mac/fast/dom/prototype-inheritance-expected.txt: Added.
11:53 AM Changeset in webkit [93996] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Implement -webkit-flex-pack for horizontal flexboxen
https://bugs.webkit.org/show_bug.cgi?id=66898

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/004.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::hasPackingSpace):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal):

LayoutTests:

  • css3/flexbox/004-expected.txt: Added.
  • css3/flexbox/004.html: Added.
11:46 AM Changeset in webkit [93995] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/network/cf/CookieJarCFNet.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): (WebCore::getHostnamesWithCookies): (WebCore::deleteCookiesForHostname): (WebCore::deleteAllCookies): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:46 AM Changeset in webkit [93994] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

Update tests after landing Event constructors.

Reviewed by Anders Carlsson.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
11:45 AM Changeset in webkit [93993] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing
after r93988.

  • platform/chromium/test_expectations.txt:
11:34 AM Changeset in webkit [93992] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix.

  • platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN).
11:31 AM Changeset in webkit [93991] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r93990.

  • wtf/HashTable.h:
11:24 AM Changeset in webkit [93990] by andreas.kling@nokia.com
  • 6 edits in trunk/Source

Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.

  • runtime/StructureTransitionTable.h:
  • wtf/HashTable.h:

(WTF::HashTable::shouldShrink):
(WTF::::expand):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

Source/WebCore:

Specialize the HashMap used to store registered listeners on an EventTarget
to have a minimum size of 32 (rather than the default 64.)
It's very rare for pages to register listeners for so many different events
and this cuts memory consumption in half for the common case.

As an example, for a typical post on the reddit.com front page,
this reduces memory used by ~700kB on 64-bit.

  • dom/EventTarget.h:
11:22 AM Changeset in webkit [93989] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Temporary suppression for new test added in r93982.

  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [93988] by senorblanco@chromium.org
  • 14 edits in trunk/Source/WebCore

Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=67050

Reviewed by Kenneth Russell.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawsContent):
Construct Canvas2DLayerChromium with a GraphicsContext3D, not a
DrawingBuffer.
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
Flush the GrContext and GraphicsContext3D on compositor update.

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

Put textureId() back on the base class (CanvasLayerChromium) and
de-virtualize it.
(WebCore::CanvasLayerChromium::textureId):
(WebCore::CanvasLayerChromium::setTextureId):
Move m_textureId from WebGLLayerChromium, since canvas2D now uses
it too. Provide getters and setters.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
Remove all Canvas2D-related calls from DrawingBuffer.
(WebCore::DrawingBuffer::publishToPlatformLayer):
Remove GrContext::flush call, since it's now handled by the platform layer.
(WebCore::DrawingBuffer::platformLayer):
Return NULL for now (WebGL may rescussitate this later).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

Remove a useless #include.

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add ownership of the Canvas2DLayerChromium.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Remove all texture ID stuff (now on base class).

  • platform/graphics/gpu/DrawingBuffer.h:

Remove Canvas2DLayerChromium and all Ganesh datatypes from
DrawingBuffer, since it's no longer used by canvas2D.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
On accelerated ImageBuffer creation, create a GrTexture instead of a
DrawingBuffer. If all is cool, create and set the SkGpuDevice here,
and create a Canvas2DLayerChromium platform layer.
(WebCore::ImageBuffer::platformLayer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove all GrContext creation and DrawingBuffer "scraping" from
PlatformContextSkia::setGraphicsContext3D(). This is handled in
the ImageBuffer constructor instead.

11:15 AM Changeset in webkit [93987] by ap@apple.com
  • 25 edits in trunk

DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>

Reviewed by Darin Adler.

Use a clean CFURLStorageSession when this functionality is available.

  • WebCore.exp.in: Added exports
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::setCookies): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): Updated for privateBrowsingCookieStorage->currentCFHTTPCookieStorage change.
  • platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.
  • platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp. This file contains cross platform functionality, and we no longer need to put code in it to share it between Mac and Windows.
  • platform/network/ResourceHandle.h: Expose methods to manipulate default session on Mac, too.
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API. (WebCore::overrideCookieStorage): Ditto. (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable, unless it has been overridden on Windows. We can always get it from a session. (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just use private session's storage. Note that Mac has a separate code path for OS versions that don't support sessions.
  • platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK), as this function is also used with NSURLConnection when sessions are enabled. (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session is now supported on Mac, too. (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK). (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer adopt the session, because nothing in method name says that it will steal a reference from the caller. (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK). (WebCore::privateStorageSession): Moved from ResourceHandle.cpp. (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.
  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): We no longer store a reference to cookie storage in a static variable, so nothing to do here. On older OS versiosn, we still need to enable legacy private browsing mode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function.
10:57 AM Changeset in webkit [93986] by levin@chromium.org
  • 12 edits in trunk

postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
https://bugs.webkit.org/show_bug.cgi?id=66713

Reviewed by Dmitry Titov.

Source/WebCore:

See http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages for postMessage

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::getMessagePortArray):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):

LayoutTests:

  • fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
  • fast/events/message-port-multi-expected.txt: Ditto.
  • fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • fast/workers/worker-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.
10:37 AM Changeset in webkit [93985] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 93802
BUG=91973
Review URL: http://codereview.chromium.org/7797001

10:31 AM Changeset in webkit [93984] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Assertion failure in WebCore::RenderFlow::rightmostPosition
https://bugs.webkit.org/show_bug.cgi?id=12085

Reviewed by Alexey Proskuryakov.

The bug got solved. Landed the test to avoid regressing.

  • fast/css/assert-marquee-not-last-element-expected.txt: Added.
  • fast/css/assert-marquee-not-last-element.html: Added.
10:30 AM Changeset in webkit [93983] by podivilov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.

  • platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.
10:14 AM Changeset in webkit [93982] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

canvas arc() missing line to start of arc if swing is zero
https://bugs.webkit.org/show_bug.cgi?id=55696

Source/WebCore:

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Test: fast/canvas/canvas-arc-zero-lineto.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::arc):

LayoutTests:

LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement
https://bugs.webkit.org/show_bug.cgi?id=66832

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the
next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html

  • canvas/philip/tests/2d.path.stroke.prune.arc.html:
  • fast/canvas/canvas-arc-zero-lineto-expected.txt: Added.
  • fast/canvas/canvas-arc-zero-lineto.html: Added.
10:12 AM Changeset in webkit [93981] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixed a build problem caused by http://trac.webkit.org/changeset/93980

Unreviewed.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
9:38 AM Changeset in webkit [93980] by cmarrin@apple.com
  • 44 edits
    1 add in trunk

[mac] requestAnimationFrame support for mac port
https://bugs.webkit.org/show_bug.cgi?id=59146

Reviewed by Simon Fraser.

Source/WebCore:

Enable REQUEST_ANIMATION_FRAME logic and add ScriptedAnimationController
to build. Added JavaScript support for Mac, too.

  • CodeGenerators.pri:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp: Added.

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):

  • dom/RequestAnimationFrameCallback.idl:

Source/WebKit/mac:

Implement requestAnimationFrame for WebKit. Add a
CFRunLoopObserver to WebView, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleAnimation):

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _unscheduleAnimation]):
(-[WebView _scheduleCompositingLayerSync]):
(requestAnimationFrameRunLoopObserverCallback):
(-[WebView _scheduleAnimation]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WebKit2:

Implement requestAnimationFrame for WebKit2. Add a
CFRunLoopObserver to WebPage, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleAnimation):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::requestAnimationFrameRunLoopObserverCallback):
(WebKit::WebPage::scheduleAnimation):
(WebKit::WebPage::unscheduleAnimation):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.cpp:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

Tools:

Add support for request-animation-callback flag

  • Scripts/build-webkit:

LayoutTests:

Enable requestAnimationFrame tests for Mac. Tests were also
modified to work on Mac. Before the tests would assume the
requestAnimationFrame callbacks would be called by calling
LayoutTestController.display(). This is not a valid assumption
for Mac, since it skips display() if nothing was dirty.

Tests were changed to use timeouts to wait for callbacks and
ensure they get called. Also added more positive indications
that test failed or succeeded, rather than relying on the lack
of an error message to indicate success.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-during-modal-expected.txt:
  • fast/animation/request-animation-frame-during-modal.html:
  • fast/animation/request-animation-frame-timestamps.html:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/request-animation-frame-cancel.js:

(window):
(if):

  • fast/animation/script-tests/request-animation-frame-cancel2.js:

(if):

  • fast/animation/script-tests/request-animation-frame-display.js:

(if):

  • fast/animation/script-tests/request-animation-frame-timestamps.js:

(var):

  • fast/animation/script-tests/request-animation-frame-within-callback.js:
  • fast/animation/script-tests/request-animation-frame.js:

(if):

  • platform/mac/Skipped:
9:07 AM Changeset in webkit [93979] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API define in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67123

We could simply use the defines already in place for this.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-29
Reviewed by Andreas Kling.

  • WebKit2.pro:
8:15 AM Changeset in webkit [93978] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: <button hidden>..</button> has a different computed "display" value than "none"
https://bugs.webkit.org/show_bug.cgi?id=67124

Source/WebCore:

Attribute styles have a higher priority than user agent styles and thus should be rendered above them.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:
8:14 AM Changeset in webkit [93977] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=66769

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresenationCallFrame.prototype.sourceLine.didGetUILocation):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.UILocation):

LayoutTests:

  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-file.html:
7:55 AM Changeset in webkit [93976] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The square-button-appearance test is wrong
https://bugs.webkit.org/show_bug.cgi?id=67128

Unreviewed skip until square-button fix on qt-arm.

  • platform/qt-arm/Skipped:
7:14 AM Changeset in webkit [93975] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Zsolt Fehér <feherzs@inf.u-szeged.hu>

Unreviewed Qt gardening.

  • platform/qt/Skipped:
7:11 AM Changeset in webkit [93974] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: cached permanent redirects don't show redirect code and text in Network panel.
https://bugs.webkit.org/show_bug.cgi?id=67126

Reviewed by Yury Semikhatsky.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceResponse):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

5:34 AM Changeset in webkit [93973] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:19 AM Changeset in webkit [93972] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: extract FormattedContentProvider from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66938

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
5:03 AM Changeset in webkit [93971] by podivilov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark fast/dom/dom-constructors.html as TEXT in chromium.

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:45 AM Changeset in webkit [93970] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
4:36 AM Changeset in webkit [93969] by podivilov@chromium.org
  • 4 edits in trunk

Web Inspector: link UISourceCode to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66944

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get rawSourceCode):

LayoutTests:

  • inspector/debugger/ui-source-code.html:
4:19 AM Changeset in webkit [93968] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing and flaky results after r93937
https://bugs.webkit.org/show_bug.cgi?id=67118

  • platform/qt/Skipped:
2:55 AM Changeset in webkit [93967] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

REGRESSION(r93637) Build break because header file is missing.
https://bugs.webkit.org/show_bug.cgi?id=67113

Unreviewed build fix after r93637.

  • CMakeListsEfl.txt: Add ewk_js.h in EWebKit_HEADERS.
2:35 AM Changeset in webkit [93966] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark overflow-scroll-overlap.html as flaky on chromium gpu.

  • platform/chromium/test_expectations.txt:
2:17 AM Changeset in webkit [93965] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add new chromium mac cg baseline for square-button-appearance added in r93953.

  • platform/chromium-cg-mac-leopard/fast/css/square-button-appearance-expected.png: Added.
2:09 AM Changeset in webkit [93964] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium expectations. Mark frame-removed-during-resize.html and scrollbar-buttons.html
as crashing on win linux debug only.

  • platform/chromium/test_expectations.txt:
2:06 AM Changeset in webkit [93963] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: remove RawSourceCode.setFormatted.
https://bugs.webkit.org/show_bug.cgi?id=66947

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

LayoutTests:

  • inspector/debugger/source-file.html:
1:53 AM Changeset in webkit [93962] by podivilov@chromium.org
  • 3 edits
    2 moves in trunk

Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
https://bugs.webkit.org/show_bug.cgi?id=67030

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/set-breakpoint.html

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

LayoutTests:

  • inspector/debugger/set-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint-expected.txt.
  • inspector/debugger/set-breakpoint.html: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint.html.
1:37 AM Changeset in webkit [93961] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
1:22 AM Changeset in webkit [93960] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] Compilation error in WebKit2 GTK - Revision 93953
https://bugs.webkit.org/show_bug.cgi?id=67111

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-08-29
Reviewed by Martin Robinson.

WebKit2 GTK build error.

  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

Include <WebCore/ResourceError.h> explicitly to remove WebCore::ResourceError
inclusion error.

1:10 AM Changeset in webkit [93959] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark event-constructors.html as failing in chromium.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/test_expectations.txt:
12:40 AM Changeset in webkit [93958] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, adding custom expectation for dom-constructors test in chromium
until bug 66756 is resolved.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Added.
12:34 AM Changeset in webkit [93957] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

fast/canvas/shadow-offset-*.html fail on Leopard/Snow Leopard when removing the work around for <rdar://problem/5539388>.
https://bugs.webkit.org/show_bug.cgi?id=67107

Reviewed by David Levin.

No new tests. Effectively reverting the change from https://bugs.webkit.org/show_bug.cgi?id=67052 for Leopard and SL
because it caused test regressions on Leopard and SL, but not Lion.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

12:16 AM Changeset in webkit [93956] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark scrollbars/scrollbar-buttons.html as crashing in chromium.

  • platform/chromium/test_expectations.txt:
12:07 AM Changeset in webkit [93955] by zherczeg@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unreviewed minimal-build buildfix after r93937.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-29

Aug 28, 2011:

11:49 PM WebKitGtkLayoutTests edited by nayankk@motorola.com
(diff)
11:09 PM Changeset in webkit [93954] by loislo@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/Popover.js

Merge 93868 - Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7778006

8:49 PM Changeset in webkit [93953] by keishi@webkit.org
  • 5 edits
    5 adds in trunk

Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

  • fast/css/square-button-appearance-expected.txt: Added.
  • fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
  • platform/gtk/test_expectations.txt: Added this test as expected to fail.
  • platform/mac/fast/css/square-button-appearance-expected.png: Added.
  • platform/qt/test_expectations.txt: Added this test as expected to fail.
5:26 PM Changeset in webkit [93952] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix reference counting of values in CSSSelector.
https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

  • css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

4:58 PM Changeset in webkit [93951] by weinig@apple.com
  • 12 edits
    5 adds in trunk

Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support. This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add files.

  • bindings/generic/EventConstructors.h: Added.

Add binding agnostic header that defines the Event initializers
using a macro based DSL.

  • bindings/js/JSEventConstructors.cpp: Added.

(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

  • dom/Event.cpp:

(WebCore::EventInit::EventInit):
(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::create):
Add Event initializer interface for base Event.

  • dom/Event.idl:

Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

  • fast/events/constructors/event-constructors-expected.txt: Added.
  • fast/events/constructors/event-constructors.html: Added.
12:24 PM Changeset in webkit [93950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

  • wtf/Platform.h:
12:14 PM Changeset in webkit [93949] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed build fix.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

Aug 27, 2011:

3:01 PM Changeset in webkit [93948] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
2:49 PM Changeset in webkit [93947] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

2:31 PM Changeset in webkit [93946] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add a build bot for Chromium with OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:12 PM Changeset in webkit [93945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

2:03 PM Changeset in webkit [93944] by robert@webkit.org
  • 3 edits
    2 adds in trunk

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
1:22 PM Changeset in webkit [93943] by andersca@apple.com
  • 3 edits
    3 adds in trunk

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 PM Changeset in webkit [93942] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 PM Changeset in webkit [93941] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 AM Changeset in webkit [93940] by enne@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

[chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < jamesr@chromium.org> on 2011-08-26
From http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 AM Changeset in webkit [93939] by commit-queue@webkit.org
  • 7 edits in trunk

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 AM Changeset in webkit [93938] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Young Han Lee <joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

4:06 AM Changeset in webkit [93937] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Qt] Need spin-button implementation
https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
12:54 AM Changeset in webkit [93936] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.

Aug 26, 2011:

9:42 PM Changeset in webkit [93935] by xji@chromium.org
  • 7 edits
    8 adds in trunk

Regression(91788): Bad cast in WebCore::blockWithNextLineBox
https://bugs.webkit.org/show_bug.cgi?id=66090

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is more like (but not exactly) a revert of r91788.
It does not search for previous or next root inline box in different
render object, which completely eliminates the cause of this issue.
And it removes createPositionAvoidingIgnoredNode(), changed its caller
to use createLegacyEditingPosition(). createPositionAvoidingIgnoredNode
is not correct when node is a replaced element whose caretMaxOffset
could be greater than 1.

Tests: editing/selection/move-by-word-visually-crash-test-1.html

editing/selection/move-by-word-visually-crash-test-2.html
editing/selection/move-by-word-visually-crash-test-3.html
editing/selection/move-by-word-visually-crash-test-4.html

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::leftmostPositionInRTLBoxInLTRBlock):
(WebCore::rightmostPositionInLTRBoxInRTLBlock):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-1-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-1.html: Added.
  • editing/selection/move-by-word-visually-crash-test-2-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-2.html: Added.
  • editing/selection/move-by-word-visually-crash-test-3-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-3.html: Added.
  • editing/selection/move-by-word-visually-crash-test-4-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-4.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/resources/move-by-word-visually.js:

(runMoveLeftRight):

9:19 PM Changeset in webkit [93934] by barraclough@apple.com
  • 8 edits in trunk

DFG JIT - ArithMod may clobber operands.
https://bugs.webkit.org/show_bug.cgi?id=67085

Reviewed by Sam Weinig.

Source/JavaScriptCore:

unboxDouble must be called on a temporary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

LayoutTests:

Added test case.

  • fast/js/mod-crash-expected.txt:
  • fast/js/script-tests/mod-crash.js:

(nonSpeculativeModReuseInner):
(nonSpeculativeModReuse):

8:51 PM Changeset in webkit [93933] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should let me know that I need to run the local server
https://bugs.webkit.org/show_bug.cgi?id=66985

Reviewed by Dimitri Glazkov.

The patch triggers an alert dialog whenever the user tries to use a
feature that requires the local server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
7:15 PM Changeset in webkit [93932] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

Cleanup resulting text of media/track tests.
https://bugs.webkit.org/show_bug.cgi?id=67073

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-26
Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/video-test.js:

(testCues):

6:05 PM Changeset in webkit [93931] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using custom NSErrors for WebKit2 WebErrors
https://bugs.webkit.org/show_bug.cgi?id=67075

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):
(WebKit::cancelledError):
(WebKit::fileDoesNotExistError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
There is no reason to use custom registered NSErrors anymore, so don't.

6:05 PM Changeset in webkit [93930] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Update tests expectations due to r93909 and r93913.

  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium-linux/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [93929] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
5:41 PM Changeset in webkit [93928] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Add MockWebGraphicsContext3D, for compositor unit testing
https://bugs.webkit.org/show_bug.cgi?id=67006

MockWebGraphicsContext3D is a no-op implementation of the pure virtual
interface WebGraphicsContext3D. I've included a test with a couple of
example usages: subclassing it manually, and using it with GMock.

Patch by Iain Merrick <husky@google.com> on 2011-08-26
Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • tests/MockWebGraphicsContext3D.h: Added.

(WebKit::MockWebGraphicsContext3D::initialize):
(WebKit::MockWebGraphicsContext3D::makeContextCurrent):
(WebKit::MockWebGraphicsContext3D::width):
(WebKit::MockWebGraphicsContext3D::height):
(WebKit::MockWebGraphicsContext3D::reshape):
(WebKit::MockWebGraphicsContext3D::isGLES2Compliant):
(WebKit::MockWebGraphicsContext3D::readBackFramebuffer):
(WebKit::MockWebGraphicsContext3D::getPlatformTextureId):
(WebKit::MockWebGraphicsContext3D::prepareTexture):
(WebKit::MockWebGraphicsContext3D::synthesizeGLError):
(WebKit::MockWebGraphicsContext3D::isContextLost):
(WebKit::MockWebGraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::getRequestableExtensionsCHROMIUM):
(WebKit::MockWebGraphicsContext3D::requestExtensionCHROMIUM):
(WebKit::MockWebGraphicsContext3D::blitFramebufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::renderbufferStorageMultisampleCHROMIUM):
(WebKit::MockWebGraphicsContext3D::activeTexture):
(WebKit::MockWebGraphicsContext3D::attachShader):
(WebKit::MockWebGraphicsContext3D::bindAttribLocation):
(WebKit::MockWebGraphicsContext3D::bindBuffer):
(WebKit::MockWebGraphicsContext3D::bindFramebuffer):
(WebKit::MockWebGraphicsContext3D::bindRenderbuffer):
(WebKit::MockWebGraphicsContext3D::bindTexture):
(WebKit::MockWebGraphicsContext3D::blendColor):
(WebKit::MockWebGraphicsContext3D::blendEquation):
(WebKit::MockWebGraphicsContext3D::blendEquationSeparate):
(WebKit::MockWebGraphicsContext3D::blendFunc):
(WebKit::MockWebGraphicsContext3D::blendFuncSeparate):
(WebKit::MockWebGraphicsContext3D::bufferData):
(WebKit::MockWebGraphicsContext3D::bufferSubData):
(WebKit::MockWebGraphicsContext3D::checkFramebufferStatus):
(WebKit::MockWebGraphicsContext3D::clear):
(WebKit::MockWebGraphicsContext3D::clearColor):
(WebKit::MockWebGraphicsContext3D::clearDepth):
(WebKit::MockWebGraphicsContext3D::clearStencil):
(WebKit::MockWebGraphicsContext3D::colorMask):
(WebKit::MockWebGraphicsContext3D::compileShader):
(WebKit::MockWebGraphicsContext3D::copyTexImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::cullFace):
(WebKit::MockWebGraphicsContext3D::depthFunc):
(WebKit::MockWebGraphicsContext3D::depthMask):
(WebKit::MockWebGraphicsContext3D::depthRange):
(WebKit::MockWebGraphicsContext3D::detachShader):
(WebKit::MockWebGraphicsContext3D::disable):
(WebKit::MockWebGraphicsContext3D::disableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::drawArrays):
(WebKit::MockWebGraphicsContext3D::drawElements):
(WebKit::MockWebGraphicsContext3D::enable):
(WebKit::MockWebGraphicsContext3D::enableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::finish):
(WebKit::MockWebGraphicsContext3D::flush):
(WebKit::MockWebGraphicsContext3D::framebufferRenderbuffer):
(WebKit::MockWebGraphicsContext3D::framebufferTexture2D):
(WebKit::MockWebGraphicsContext3D::frontFace):
(WebKit::MockWebGraphicsContext3D::generateMipmap):
(WebKit::MockWebGraphicsContext3D::getActiveAttrib):
(WebKit::MockWebGraphicsContext3D::getActiveUniform):
(WebKit::MockWebGraphicsContext3D::getAttachedShaders):
(WebKit::MockWebGraphicsContext3D::getAttribLocation):
(WebKit::MockWebGraphicsContext3D::getBooleanv):
(WebKit::MockWebGraphicsContext3D::getBufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getContextAttributes):
(WebKit::MockWebGraphicsContext3D::getError):
(WebKit::MockWebGraphicsContext3D::getFloatv):
(WebKit::MockWebGraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebKit::MockWebGraphicsContext3D::getIntegerv):
(WebKit::MockWebGraphicsContext3D::getProgramiv):
(WebKit::MockWebGraphicsContext3D::getProgramInfoLog):
(WebKit::MockWebGraphicsContext3D::getRenderbufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getShaderiv):
(WebKit::MockWebGraphicsContext3D::getShaderInfoLog):
(WebKit::MockWebGraphicsContext3D::getShaderSource):
(WebKit::MockWebGraphicsContext3D::getString):
(WebKit::MockWebGraphicsContext3D::getTexParameterfv):
(WebKit::MockWebGraphicsContext3D::getTexParameteriv):
(WebKit::MockWebGraphicsContext3D::getUniformfv):
(WebKit::MockWebGraphicsContext3D::getUniformiv):
(WebKit::MockWebGraphicsContext3D::getUniformLocation):
(WebKit::MockWebGraphicsContext3D::getVertexAttribfv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribiv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribOffset):
(WebKit::MockWebGraphicsContext3D::hint):
(WebKit::MockWebGraphicsContext3D::isBuffer):
(WebKit::MockWebGraphicsContext3D::isEnabled):
(WebKit::MockWebGraphicsContext3D::isFramebuffer):
(WebKit::MockWebGraphicsContext3D::isProgram):
(WebKit::MockWebGraphicsContext3D::isRenderbuffer):
(WebKit::MockWebGraphicsContext3D::isShader):
(WebKit::MockWebGraphicsContext3D::isTexture):
(WebKit::MockWebGraphicsContext3D::lineWidth):
(WebKit::MockWebGraphicsContext3D::linkProgram):
(WebKit::MockWebGraphicsContext3D::pixelStorei):
(WebKit::MockWebGraphicsContext3D::polygonOffset):
(WebKit::MockWebGraphicsContext3D::readPixels):
(WebKit::MockWebGraphicsContext3D::releaseShaderCompiler):
(WebKit::MockWebGraphicsContext3D::renderbufferStorage):
(WebKit::MockWebGraphicsContext3D::sampleCoverage):
(WebKit::MockWebGraphicsContext3D::scissor):
(WebKit::MockWebGraphicsContext3D::shaderSource):
(WebKit::MockWebGraphicsContext3D::stencilFunc):
(WebKit::MockWebGraphicsContext3D::stencilFuncSeparate):
(WebKit::MockWebGraphicsContext3D::stencilMask):
(WebKit::MockWebGraphicsContext3D::stencilMaskSeparate):
(WebKit::MockWebGraphicsContext3D::stencilOp):
(WebKit::MockWebGraphicsContext3D::stencilOpSeparate):
(WebKit::MockWebGraphicsContext3D::texImage2D):
(WebKit::MockWebGraphicsContext3D::texParameterf):
(WebKit::MockWebGraphicsContext3D::texParameteri):
(WebKit::MockWebGraphicsContext3D::texSubImage2D):
(WebKit::MockWebGraphicsContext3D::uniform1f):
(WebKit::MockWebGraphicsContext3D::uniform1fv):
(WebKit::MockWebGraphicsContext3D::uniform1i):
(WebKit::MockWebGraphicsContext3D::uniform1iv):
(WebKit::MockWebGraphicsContext3D::uniform2f):
(WebKit::MockWebGraphicsContext3D::uniform2fv):
(WebKit::MockWebGraphicsContext3D::uniform2i):
(WebKit::MockWebGraphicsContext3D::uniform2iv):
(WebKit::MockWebGraphicsContext3D::uniform3f):
(WebKit::MockWebGraphicsContext3D::uniform3fv):
(WebKit::MockWebGraphicsContext3D::uniform3i):
(WebKit::MockWebGraphicsContext3D::uniform3iv):
(WebKit::MockWebGraphicsContext3D::uniform4f):
(WebKit::MockWebGraphicsContext3D::uniform4fv):
(WebKit::MockWebGraphicsContext3D::uniform4i):
(WebKit::MockWebGraphicsContext3D::uniform4iv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix2fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix3fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix4fv):
(WebKit::MockWebGraphicsContext3D::useProgram):
(WebKit::MockWebGraphicsContext3D::validateProgram):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4fv):
(WebKit::MockWebGraphicsContext3D::vertexAttribPointer):
(WebKit::MockWebGraphicsContext3D::viewport):
(WebKit::MockWebGraphicsContext3D::createBuffer):
(WebKit::MockWebGraphicsContext3D::createFramebuffer):
(WebKit::MockWebGraphicsContext3D::createProgram):
(WebKit::MockWebGraphicsContext3D::createRenderbuffer):
(WebKit::MockWebGraphicsContext3D::createShader):
(WebKit::MockWebGraphicsContext3D::createTexture):
(WebKit::MockWebGraphicsContext3D::deleteBuffer):
(WebKit::MockWebGraphicsContext3D::deleteFramebuffer):
(WebKit::MockWebGraphicsContext3D::deleteProgram):
(WebKit::MockWebGraphicsContext3D::deleteRenderbuffer):
(WebKit::MockWebGraphicsContext3D::deleteShader):
(WebKit::MockWebGraphicsContext3D::deleteTexture):

  • tests/MockWebGraphicsContext3DTest.cpp: Added.

(TEST):
(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):

5:38 PM Changeset in webkit [93927] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson <jamesr@chromium.org> on 2011-08-26
Reviewed by Kenneth Russell.

Fix a number of reference cycle leaks that prevent LayerRendererChromiums from being destroyed when a tab is
closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):

5:23 PM Changeset in webkit [93926] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic summary view should have pretty commit data information.
https://bugs.webkit.org/show_bug.cgi?id=67069

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
4:44 PM Changeset in webkit [93925] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67063

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(+[NSError _webkit_errorWithDomain:code:URL:]):

4:42 PM Changeset in webkit [93924] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update tests expectations due to r93909.

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
4:31 PM Changeset in webkit [93923] by Nate Chapin
  • 13 edits in trunk/Source/WebCore

Move allowCredentials from ThreadableLoaderOptions down
to ResourceLoaderOptions. This allows us to remove
getShouldUseCredentialStorage() from SubresourceLoaderClient
and check allowCredentials in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refractor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldUseCredentialStorage): Check

m_options.allowCredentials instead of calling a client.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
3:55 PM Changeset in webkit [93922] by levin@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Update tests expectations due to r93913.

  • platform/chromium-cg-mac/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium-win/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Added.
3:40 PM Changeset in webkit [93921] by ojan@chromium.org
  • 7 edits in trunk

change the default preferred width of the flex() function to 0px per the new spec
https://bugs.webkit.org/show_bug.cgi?id=67067

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/001.html:
  • css3/flexbox/002.html:
  • css3/flexbox/flex-parsing-expected.txt:
  • css3/flexbox/script-tests/flex-parsing.js:
3:32 PM Changeset in webkit [93920] by commit-queue@webkit.org
  • 13 edits in trunk/Source/JavaScriptCore

Unzip initialization lists and constructors in JSCell hierarchy (2/7)
https://bugs.webkit.org/show_bug.cgi?id=66957

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-26
Reviewed by Darin Adler.

Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):

3:26 PM Changeset in webkit [93919] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

Remove offset hack from GraphicsContextCG setShadow code
https://bugs.webkit.org/show_bug.cgi?id=67052

Reviewed by Simon Fraser.

No new tests - current tests cover it.

  • platform/graphics/cg/GraphicsContextCG.cpp:

Removing the offset hack introduced in http://trac.webkit.org/changeset/28714
for an issue with offsets in an old version of CoreGraphics that's long since been fixed.

3:23 PM Changeset in webkit [93918] by fpizlo@apple.com
  • 13 edits
    2 adds in trunk/Source/JavaScriptCore

The GC does not have a facility for profiling the kinds of objects
that occupy the heap
https://bugs.webkit.org/show_bug.cgi?id=66849

Reviewed by Geoffrey Garen.

Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.

(JSC::Heap::destroy):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

  • heap/MarkedBlock.h:
  • heap/VTableSpectrum.cpp: Added.

(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h: Added.
  • wtf/Platform.h:
3:20 PM Changeset in webkit [93917] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=67066

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3:18 PM Changeset in webkit [93916] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Rebasing media/video-layer-crash & media/video-transformed images.
https://bugs.webkit.org/show_bug.cgi?id=67065

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-26
Reviewed by David Levin.

  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [93915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update topCallFrame when calling host functions in the JIT
https://bugs.webkit.org/show_bug.cgi?id=67010

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-26
Reviewed by Oliver Hunt.

The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (https://bugs.webkit.org/show_bug.cgi?id=66994).

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

2:41 PM Changeset in webkit [93914] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
https://bugs.webkit.org/show_bug.cgi?id=67041

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Martin Robinson.

This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
PixelDumpSupportCairo.h, but the latter was #including cairo.h only
when the GTK+ port was being built.

  • DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2:40 PM Changeset in webkit [93913] by ap@apple.com
  • 17 edits
    2 adds in trunk

Get rid of frame life support timer
https://bugs.webkit.org/show_bug.cgi?id=66874

Reviewed by Geoff Garen. V8 fixes courtesy of Dmitry Titov.

Test: fast/frames/detached-frame-property.html

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page): Removed all code that dealt with the life support timer. Protect Frame inside runScript() and callFunction() for v8 bindings.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): Replaced ref/deref calls on self with a RefPtr.
2:36 PM Changeset in webkit [93912] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
https://bugs.webkit.org/show_bug.cgi?id=67062

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_ScheduleTimer):
Call NetscapePlugin::scheduleTimer.

(WebKit::NPN_UnscheduleTimer):
Call NetscapePlugin::unscheduleTimer.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_nextTimerID.

(WebKit::NetscapePlugin::Timer::start):
Start the timer.

(WebKit::NetscapePlugin::Timer::stop):
Stop the timer.

(WebKit::NetscapePlugin::Timer::timerFired):
Call the right callback and unschedule the timer object if it's not a repeating timer.

(WebKit::NetscapePlugin::scheduleTimer):
Create a new timer and start it.

(WebKit::NetscapePlugin::unscheduleTimer):
Get the timer from the map and destroy it.

(WebKit::NetscapePlugin::destroy):
Destroy all timers.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add Timer class.

2:36 PM Changeset in webkit [93911] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/js/const.html is opening a modal print dialog, leading to a timeout on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=67061

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-08-26
Reviewed by Oliver Hunt.

Update this test to remove inadvertant calls to window.print().

  • fast/js/resources/const.js:

(tryCatch1): Remove call to window.print()
(tryCatch2): Ditto.

1:47 PM Changeset in webkit [93910] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=67046

Patch by Chao-ying Fu <fu@mips.com> on 2011-08-26
Reviewed by Gavin Barraclough.

  • jit/JIT.h:
1:43 PM Changeset in webkit [93909] by mitz@apple.com
  • 3 edits
    3 adds in trunk

RenderText::computePreferredLogicalWidths() should measure words with trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=66733

Source/WebCore:

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-08-26
Reviewed by Dan Bernstein.

Test: fast/text/complex-preferred-logical-widths.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Apply logic from RenderBlock::LineBreaker::nextLineBreak().

LayoutTests:

  • fast/text/complex-preferred-logical-widths.html: Added.
  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
1:42 PM Changeset in webkit [93908] by tony@chromium.org
  • 15 edits in trunk

Add CSS parsing for -webkit-flex-align
https://bugs.webkit.org/show_bug.cgi?id=66726

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexAlign):
(WebCore::InheritedFlags::setFlexAlign):
(WebCore::InheritedFlags::initialFlexAlign):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
1:41 PM Changeset in webkit [93907] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <Nate Chapin>

Fix http/tests/misc/willCacheResponse-delegate-callback.html
after r93886. We're implicitly converting an enum to a bool.

Rubber-stamped by David Levin.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse):
1:38 PM Changeset in webkit [93906] by Dimitri Glazkov
  • 11 edits in trunk/Tools

Clean up and line up layout in garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=67057

1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2) Rearranged DOM structure a bit to accommodate recent changes;
3) Added minimal CSS to line things up.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1:37 PM Changeset in webkit [93905] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in Connection.cpp
https://bugs.webkit.org/show_bug.cgi?id=67060

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):
We want timedOut, not timeout. There is not a current way to cause this
to be an issue. This issue was caught by the Clang Static Analyzer.

1:05 PM Changeset in webkit [93904] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip two tests on GTK+ that are failing due to known issues.

  • platform/gtk/Skipped: Update the skipped list.
12:29 PM Changeset in webkit [93903] by crogers@google.com
  • 14 edits in trunk

Add MediaPlayer::audioSourceProvider() method for audio stream access by the Web Audio API.
https://bugs.webkit.org/show_bug.cgi?id=66398

Reviewed by Eric Carlson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::ensureMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

MediaPlayer creation has now been put into createMediaPlayer() instead of it being created
separately in these various methods. It has been made thread-safe for use with the Web Audio API
in conjunction with an MediaElementAudioSourceNode.

(WebCore::HTMLMediaElement::setAudioSourceNode):
(WebCore::HTMLMediaElement::audioSourceProvider):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::audioSourceNode):

The HTMLMediaElement now keeps track of an optional MediaElementAudioSourceNode if
the audio stream is being processed using the Web Audio API.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::audioSourceProvider):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::audioSourceProvider):

MediaPlayer now has an audioSourceProvider() method with a default "empty" implementation.
audioSourceProvider() returns an AudioSourceProvider object which the Web Audio API's
MediaElementAudioSourceNode uses (indirectly through an HTMLMediaElement method) to get the rendered audio stream.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:

AudioContext::createMediaElementSource() is now more careful to check that an HTMLMediaElement
doesn't already have a MediaElementAudioSourceNode attached to it.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::~MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • webaudio/MediaElementAudioSourceNode.h:

Implement thread-safe processing (replacing the old stub implementation).

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt:
  • webaudio/mediaelementaudiosourcenode.html:
12:23 PM Changeset in webkit [93902] by alice.liu@apple.com
  • 16 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=66823
Add the request info to the WebPageProxy::CreateNewPage message

Reviewed by Anders Carlsson.

Source/WebKit2:

Update function declarations with additional ResourceRequest parameter:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):
Pass the ResourceRequest within the FrameLoadRequest.

Tools:

Update function declarations with additional parameter:

  • MiniBrowser/gtk/BrowserWindow.c:

(createNewPage):

  • MiniBrowser/mac/BrowserWindowController.m:

(createNewPage):

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):

  • WebKitTestRunner/TestController.h:
12:11 PM Changeset in webkit [93901] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

Assertion fires if canvas is resized while save() active
https://bugs.webkit.org/show_bug.cgi?id=66710

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/resize-while-save-active.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Call CanvasRenderingContext2D::reset() before resizing the canvas,
so that the GraphicsContext state stack can be unwound.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Refactor the state stack unwinding code from the destructor to
unwindStateStack() (new).
(WebCore::CanvasRenderingContext2D::reset):
Unwind the GraphicsContext state stack when the context is reset.

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/resize-while-save-active-expected.txt: Added.
  • fast/canvas/resize-while-save-active.html: Added.
11:59 AM Changeset in webkit [93900] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Use the progress cursor instead of the wristwatch for CSS "wait" cursor
https://bugs.webkit.org/show_bug.cgi?id=67049

Reviewed by Beth Dakin.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use BusyButClickable cursor for wait
as well as for Progress.

11:41 AM Changeset in webkit [93899] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <Nate Chapin>

Fix gtk build after r93886.

  • platform/track/CueParser.cpp: (WebCore::CueParser::load):
11:31 AM Changeset in webkit [93898] by Martin Robinson
  • 2 edits
    6 adds in trunk/LayoutTests

Add some new baselines for GTK+ and unskip tests that now have them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
11:24 AM Changeset in webkit [93897] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]REGRESSION(r93784): It made many tests crash
https://bugs.webkit.org/show_bug.cgi?id=66958

Reviewed by Anders Carlsson.

Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::~QtWebPageProxy):

11:23 AM Changeset in webkit [93896] by Martin Robinson
  • 1 edit
    190 adds in trunk/LayoutTests

Import the last set of GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xml: Import the last set of results.
11:15 AM Changeset in webkit [93895] by Martin Robinson
  • 1 edit
    201 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector test results.

  • platform/gtk/css3/selectors3/xml: Import the next set of results.
11:08 AM Changeset in webkit [93894] by Martin Robinson
  • 1 edit
    202 adds in trunk/LayoutTests

Begin importing the last directory of CSS3 selector results for GTK+.

  • platform/gtk/css3/selectors3/xml: Import the first set of files in this directory.
11:07 AM Changeset in webkit [93893] by commit-queue@webkit.org
  • 3 edits in trunk

WebViewImpl::selectionRange should return range in the right order.
https://bugs.webkit.org/show_bug.cgi?id=66973

Patch by Varun Jain <varunjain@google.com> on 2011-08-26
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
11:04 AM Changeset in webkit [93892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Update searchableIndexIntroduction() to match GTK+'s.
https://bugs.webkit.org/show_bug.cgi?id=66885

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Using this new string allows us to share the test expectations with
other ports, and thus makes
fast/replaced/table-percent-height-text-controls.html pass.

No new tests, as this is covered by an existing one.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::searchableIndexIntroduction):

10:59 AM Changeset in webkit [93891] by vrk@chromium.org
  • 1 edit
    105 adds in trunk/LayoutTests

Unreviewed; adding files missing from r93885.

  • media/track/captions-webvtt/tc000-empty.vtt: Added.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Added.
  • media/track/captions-webvtt/tc001-utf8.vtt: Added.
  • media/track/captions-webvtt/tc002-bom.vtt: Added.
  • media/track/captions-webvtt/tc003-newlines.vtt: Added.
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Added.
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Added.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Added.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Added.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Added.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Added.
  • media/track/captions-webvtt/tc011-cues.vtt: Added.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Added.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Added.
  • media/track/captions-webvtt/tc013-settings.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
10:59 AM Changeset in webkit [93890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not log an error if a fallback cursor cannot be found.
https://bugs.webkit.org/show_bug.cgi?id=67037

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Ecore_X does not necessarily have to be used (DumpRenderTree does not
use it, for example), so showing an error message here is bogus.

No new tests, as it just removes erroneous error messages from
when running DRT with existing tests.

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

10:53 AM Changeset in webkit [93889] by Martin Robinson
  • 1 edit
    593 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xhtml: Import this directory.
10:48 AM Changeset in webkit [93888] by Martin Robinson
  • 1 edit
    346 adds in trunk/LayoutTests

Begin importing CSS3 selector test results for GTK+.

  • platform/gtk/css3/selectors3/html: Import this directory.
10:45 AM Changeset in webkit [93887] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix handling of keyup events in the new Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67045

Reviewed by Sam Weinig.

Use a counter instead of a boolean for deciding when to ignore keyup events, because
if multiple keys are pressed simultaneously then we need to ignore more than one keyup event in a row.

Also if a keyboard event is an autorepeating event we won't get a keyup event so don't increment the counter
in that case.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

10:41 AM Changeset in webkit [93886] by Nate Chapin
  • 32 edits in trunk/Source

Source/WebCore: Change a bunch of nondescript bools to
descriptive enums in ResourceLoaderOptions and
ThreadableLoaderOptions.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

No new tests, no functionality change intended.

  • WebCore.exp.in:
  • fileapi/FileReaderLoader.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.cpp:
  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • page/EventSource.cpp:
  • platform/network/ResourceHandle.h:
  • workers/WorkerScriptLoader.cpp:
  • xml/XMLHttpRequest.cpp:

Source/WebKit/chromium: Use enums instead of bools for ThreadableLoaderOptions
variables.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

10:21 AM Changeset in webkit [93885] by vrk@chromium.org
  • 11 edits
    43 deletes in trunk/LayoutTests

Tests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
https://bugs.webkit.org/show_bug.cgi?id=65884

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-25
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/tc000-empty.vtt: Renamed from media/track/captions/tc000_empty.vtt.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Renamed from media/track/captions/tc001_iso2022jp3.vtt.
  • media/track/captions-webvtt/tc001-utf8.vtt: Renamed from media/track/captions/tc001_utf8.vtt.
  • media/track/captions-webvtt/tc002-bom.vtt: Renamed from media/track/captions/tc002_bom.vtt.
  • media/track/captions-webvtt/tc003-newlines.vtt: Renamed from media/track/captions/tc003_newlines.vtt
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Renamed from media/track/captions/tc003_nonewlineateof.vtt
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Renamed from media/track/captions/tc004_nowebvtt.vtt.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Renamed from media/track/captions/tc004_webvttfile.vtt.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Renamed from media/track/captions/tc004_webvttrubbish.vtt.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Renamed from media/track/captions/tc005_defaultstyles.vtt.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Renamed from media/track/captions/tc005_metadataarea.vtt.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Renamed from media/track/captions/tc006_cueiderror.vtt.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Renamed from media/track/captions/tc006_cueid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Renamed from media/track/captions/tc007_cuenoid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Renamed from media/track/captions/tc007_cuenoiderror.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Renamed from media/track/captions/tc008_timingsnohourerrors.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Renamed from media/track/captions/tc008_timingsnohour.vtt.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Renamed from media/track/captions/tc009_timingshourerror.vtt.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Renamed from media/track/captions/tc009_timingshour.vtt.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Renamed from media/track/captions/tc010_notimings.vtt.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Copied from media/track/captions/tc011_cuesnosep.vtt.
  • media/track/captions-webvtt/tc011-cues.vtt: Renamed from media/track/captions/tc011_cues.vtt.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Renamed from media/track/captions/tc012_outoforder.vtt.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Renamed from media/track/captions/tc013_settingsbadsep.vtt.
  • media/track/captions-webvtt/tc013-settings.vtt: Renamed from media/track/captions/tc013_settings.vtt.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Renamed from media/track/track-webvtt-tc004-magicheader-expected.txt.
  • media/track/track-webvtt-tc004-magic-header.html: Renamed from media/track/track-webvtt-tc004-magicheader.html.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Renamed from media/track/track-webvtt-tc005-headercomment-expected.txt.
  • media/track/track-webvtt-tc005-header-comment.html: Renamed from media/track/track-webvtt-tc005-headercomment.html.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Renamed from media/track/track-webvtt-tc006-cueidentifiers-expected.txt.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Renamed from media/track/track-webvtt-tc006-cueidentifiers.html.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Renamed from media/track/track-webvtt-tc007-cuenoid-expected.txt.
  • media/track/track-webvtt-tc007-cue-no-id.html: Renamed media/track/track-webvtt-tc007-cuenoid.html.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Renamed from media/track/track-webvtt-tc008-timingsnohours-expected.txt.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Renamed from media/track/track-webvtt-tc008-timingsnohours.html.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Renamed from media/track/track-webvtt-tc009-timingshour-expected.txt.
  • media/track/track-webvtt-tc009-timings-hour.html: Renamed from media/track/track-webvtt-tc009-timingshour.html.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Copied from media/track/track-webvtt-tc010-notimings-expected.txt.
  • media/track/track-webvtt-tc010-no-timings.html: Renamed from media/track/track-webvtt-tc012-outoforder.html.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Renamed from media/track/track-webvtt-tc011-blanklines-expected.txt.
  • media/track/track-webvtt-tc011-blank-lines.html: Renamed from media/track/track-webvtt-tc011-blanklines.html.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Renamed from media/track/track-webvtt-tc012-outoforder-expected.txt.
  • media/track/track-webvtt-tc012-out-of-order.html: Copied from media/track/track-webvtt-tc000-empty.html.
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
  • media/video-test.js:

(testCues):
(allTestsEnded):

10:19 AM Changeset in webkit [93884] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
https://bugs.webkit.org/show_bug.cgi?id=67040

Reviewed by Darin Adler.

  • html/HTMLMetaElement.h: Remove m_equiv and m_content members,

shrinking HTMLMetaElement by 16 bytes (on 64-bit.)

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseMappedAttribute):
(WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().

10:17 AM Changeset in webkit [93883] by cevans@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/rendering

Merge 93794
BUG=93587
Review URL: http://codereview.chromium.org/7753041

9:57 AM Changeset in webkit [93882] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

9:26 AM Changeset in webkit [93881] by podivilov@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r93870.
http://trac.webkit.org/changeset/93870
https://bugs.webkit.org/show_bug.cgi?id=65203

Broke i18n chromium tests

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
9:15 AM Changeset in webkit [93880] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Gut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
https://bugs.webkit.org/show_bug.cgi?id=66979.

Removing the function altogether would break the nightlies.
This patch removes the code behind it so that it is clear that
WKPageCreateSnapshotOfVisibleContent should not be used, and so that the code isn't just
left rotting in the tree.

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-26
Reviewed by Brian Weinstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCreateSnapshotOfVisibleContent):
Return 0.

  • UIProcess/API/C/WKPagePrivate.h:

Update the comment and add a link to the bug.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
8:29 AM Changeset in webkit [93879] by commit-queue@webkit.org
  • 3 edits in trunk/Source

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Also roll Chromium revision to 98101, to include dependency: http://codereview.chromium.org/7714036/

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-26
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

8:14 AM Changeset in webkit [93878] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

<video> playlist can not advance when playing in background tab
https://bugs.webkit.org/show_bug.cgi?id=66978

Reviewed by Darin Adler.

No new tests added because it isn't possible to simulate a background tab in DRT.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
(WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever

allowed a file to load.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
(WebCore::HTMLMediaElement::removeBehaviorRestriction): New.

8:06 AM Changeset in webkit [93877] by Martin Robinson
  • 3 edits in trunk/LayoutTests

Removing some tests from the GTK+ skipped lists that have results now
or no longer exist.

  • platform/gtk/Skipped: Clean up.
  • platform/gtk/test_expectations.txt: Ditto.
7:57 AM Changeset in webkit [93876] by andreas.kling@nokia.com
  • 14 edits in trunk/LayoutTests

Rebaseline Qt (4.7) after r93873.

  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
7:06 AM Changeset in webkit [93875] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
7:02 AM Changeset in webkit [93874] by Philippe Normand
  • 1 edit
    18 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
6:35 AM Changeset in webkit [93873] by andreas.kling@nokia.com
  • 30 edits in trunk

[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Reviewed by Benjamin Poulain.

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

LayoutTests:

Rebaseline SVG tests after Path::boundingRect() change.
This brings Qt quite a bit closer to CG and Skia metrics.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-4.8/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/qt/svg/custom/animate-path-morphing-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
  • platform/qt/svg/custom/second-inline-text-expected.txt:
  • platform/qt/svg/custom/use-nested-transform-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/shapes/path/001-expected.txt:
6:22 AM Changeset in webkit [93872] by Philippe Normand
  • 77 edits in trunk/LayoutTests

Unreviewed, another rebaseline after switch to GTK+3.x.

  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
6:15 AM Changeset in webkit [93871] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

add a state enumeration to track down cause of null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=66939

Reviewed by Alexey Proskuryakov.

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I
have a bug I cannot reproduce. I added an earlier crash in
https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
gotten many good stacks, all coming in through a failed request that
eventually calls notifyFinished() on a ScriptElement with a NULL
m_cachedScript.

I'd like to know how this got NULL. This enumeration should let
me find that in stack dumps from reproductions.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
6:12 AM Changeset in webkit [93870] by reed@google.com
  • 9 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:50 AM Changeset in webkit [93869] by podivilov@chromium.org
  • 63 edits
    17 moves
    8 deletes in trunk/LayoutTests

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium fast/borders/* tests.

  • fast/borders/borderRadiusArcs01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusArcs01-expected.txt.
  • fast/borders/borderRadiusDashed02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed02-expected.txt.
  • fast/borders/borderRadiusDashed03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed03-expected.txt.
  • fast/borders/borderRadiusDotted01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDotted01-expected.txt.
  • fast/borders/borderRadiusDouble01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble01-expected.txt.
  • fast/borders/borderRadiusDouble02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble02-expected.txt.
  • fast/borders/borderRadiusDouble03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble03-expected.txt.
  • fast/borders/borderRadiusGroove01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove01-expected.txt.
  • fast/borders/borderRadiusGroove02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove02-expected.txt.
  • fast/borders/borderRadiusInset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusInset01-expected.txt.
  • fast/borders/borderRadiusOutset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusOutset01-expected.txt.
  • fast/borders/borderRadiusRidge01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusRidge01-expected.txt.
  • fast/borders/borderRadiusSolid01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid01-expected.txt.
  • fast/borders/borderRadiusSolid02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid02-expected.txt.
  • fast/borders/borderRadiusSolid03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid03-expected.txt.
  • fast/borders/borderRadiusSolid04-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid04-expected.txt.
  • fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted01-expected.txt: Removed.
  • platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
5:32 AM Changeset in webkit [93868] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

5:28 AM Changeset in webkit [93867] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Minor style fix in the sample code for WebKitWebFrame.

  • webkit/webkitwebframe.cpp:
4:31 AM Changeset in webkit [93866] by Philippe Normand
  • 24 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some svg tests after switch to
GTK+-3.x.

  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
4:24 AM Changeset in webkit [93865] by Philippe Normand
  • 56 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some fast/ tests after switch to
GTK+-3.x.

  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
4:19 AM Changeset in webkit [93864] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Not reviewed. Unskip this test on Qt, it's fixed now.

  • platform/qt/Skipped:
4:10 AM Changeset in webkit [93863] by Philippe Normand
  • 11 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline of some editing tests after switch to
GTK+-3.x.

  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Added.
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
3:02 AM Changeset in webkit [93862] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Reviewed by Zoltan Herczeg.

Fix intrinsic size negotiation flakiness, most visible on the Qt port.

The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.

The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
on our parent frame view - this is only an optimization to avoid doing layout() twice.

The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::collectFrameViewChildren): (WebCore::FrameView::forceLayoutParentViewIfNeeded): (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
  • page/FrameView.h:
2:56 AM Changeset in webkit [93861] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
https://bugs.webkit.org/show_bug.cgi?id=66988

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):

2:06 AM Changeset in webkit [93860] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93853.
http://trac.webkit.org/changeset/93853
https://bugs.webkit.org/show_bug.cgi?id=67016

Turns bots red

  • platform/chromium/test_expectations.txt:
2:05 AM Changeset in webkit [93859] by Csaba Osztrogonác
  • 2 edits
    20 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced in r93794.

  • platform/qt/Skipped:
  • platform/qt/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt: Added.
1:59 AM Changeset in webkit [93858] by commit-queue@webkit.org
  • 7 edits in trunk

REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
https://bugs.webkit.org/show_bug.cgi?id=67015

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-26
Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Checks the validity of maxlength attribute when converting it to integer.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt:

Added maxlength="" and maxlength="invalid" tests.

  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.
  • fast/forms/textarea-maxlength-expected.txt: ditto.
1:52 AM Changeset in webkit [93857] by noel.gordon@gmail.com
  • 2 edits in trunk/Tools

Make show-pretty-diff work on linux
https://bugs.webkit.org/show_bug.cgi?id=67017

Reviewed by Adam Barth.

  • Scripts/show-pretty-diff:

Aug 25, 2011:

11:48 PM Changeset in webkit [93856] by yutak@chromium.org
  • 4 edits in trunk/Source/WebCore

WebSocket: Fix indentation of WebSocket header files
https://bugs.webkit.org/show_bug.cgi?id=67018

Reviewed by Kent Tamura.

No new tests. Style fix only.

  • websockets/WebSocket.h:

(WebCore::WebSocket::create):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):

  • websockets/WebSocketChannel.h:

Removed formal parameter name of resumeTimerFired().
(WebCore::WebSocketChannel::create):
(WebCore::WebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

  • websockets/WebSocketHandshake.h:

Removed formal parameter name of setClientProtocol().

11:44 PM Changeset in webkit [93855] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations to remove conflict
https://bugs.webkit.org/show_bug.cgi?id=67020

Unreviewed, expectations update.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25

  • platform/chromium/test_expectations.txt:
11:41 PM Changeset in webkit [93854] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Touch GtkVersioning.c so that the release bot rebuilds it. This
is necessary because of the switch to GTK+ 3.x.

  • platform/gtk/GtkVersioning.c: Touch this file.
11:23 PM Changeset in webkit [93853] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=67016

Unreviewed, test expectations update.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25

  • platform/chromium/test_expectations.txt:
10:35 PM Changeset in webkit [93852] by Martin Robinson
  • 206 edits
    1 add in trunk

Reviewed by Xan Lopez.

.:

[GTK] Switch to GTK+ 3.x by default
https://bugs.webkit.org/show_bug.cgi?id=63047

  • configure.ac: Modify the default value of the --with-gtk option to be 3.0.

LayoutTests:

Update GTK+ result that depend on the GTK+ version.

  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.png:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.png:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.png:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.png:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.png:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.png:
  • platform/gtk/fast/forms/menulist-clip-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.png:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.png:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.png:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.png:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-background-none-expected.png:
  • platform/gtk/fast/forms/select-background-none-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.png:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.png:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.png:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.png:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.png:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/table-percent-height-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.png:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-radio-expected.png:
  • platform/gtk/fast/replaced/width100percent-radio-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
9:59 PM Changeset in webkit [93851] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable fullscreen API in Chromium by default.
https://bugs.webkit.org/show_bug.cgi?id=66993

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25
Reviewed by Adam Barth.

  • features.gypi:
9:27 PM Changeset in webkit [93850] by commit-queue@webkit.org
  • 6 edits in trunk

Use PATH_BASED_BORDER_RADIUS_DRAWING for skia
https://bugs.webkit.org/show_bug.cgi?id=65583

Source/WebCore:

This change brings in the new border rendering for Skia. To support this without aliasing the skia
graphics context has been updated to support anti-aliased clipping around convex polygons and also
anti-aliased clipping outside a path.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

  • rendering/RenderObject.h:

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

Update expectations: added failures for baselines to come. removed some
failure expectations for tests that now pass and moved some expectations
into the group of tests to be rebaselined.

  • platform/chromium/test_expectations.txt:
7:54 PM Changeset in webkit [93849] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip some tests on GTK+ that are missing DRT functionality. Also
reorganize some failures on the skipped list.

  • platform/gtk/Skipped: Update the skipped list.
6:32 PM Changeset in webkit [93848] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement animation and transition properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66126

Reviewed by Dean Jackson.

No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.

  • css/CSSStyleApplyProperty.cpp:

Added new class ApplyPropertyAnimation to handle animation and transition properties.
(WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Removed animation and transition macros (celebrate!)
(WebCore::CSSStyleSelector::applyProperty):
Removed old implementations of animation and transition properties.

  • platform/animation/Animation.h:

Changed return types of initial values to match the setters and getters.
(WebCore::Animation::initialAnimationDelay):
(WebCore::Animation::initialAnimationName):
(WebCore::Animation::initialAnimationTimingFunction):

6:06 PM Changeset in webkit [93847] by Dimitri Glazkov
  • 3 edits
    3 adds
    1 delete in trunk/Tools

Reorganize garden-o-matic CSS files to match JS-built views.
https://bugs.webkit.org/show_bug.cgi?id=66998

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
6:05 PM Changeset in webkit [93846] by pkasting@chromium.org
  • 6 edits in trunk/LayoutTests

Temporarily mark some tests as crashing (assertion failure) after r93794.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
6:02 PM Changeset in webkit [93845] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

kNPEventStartIME doesn't work correctly for NPAPI
https://bugs.webkit.org/show_bug.cgi?id=65264
<rdar://problem/9996476>

Reviewed by Sam Weinig.

In order to remain compatible with older plug-ins, the updated input model won't
be turned on unless a plug-in explicitly asks whether we support it. The plug-in must do
this before any keyboard events have been processed.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):
Add the CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply flag to this message since we want
the web process to handle it while it's waiting for a reply to the PluginControllerProxy::HandleMouseEvent
synchronous message.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Implement the logic for when to turn off the legacy Cocoa text input model support.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_ignoreNextKeyUpEvent to false.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_ignoreNextKeyUpEvent member variable.

(WebKit::NetscapePlugin::hasHandledAKeyDownEvent):
Add a getter.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Don't send keydown and keyup events when complex text input is enabled in the updated model.

5:54 PM Changeset in webkit [93844] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Correctly handle events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67005

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
When using the updated model, always return a string even for 'simple' characters.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Only let the input method have a crack at the event in the legacy model.

5:51 PM Changeset in webkit [93843] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=67002

Reviewed by Brian Weinstein.

  • UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.


  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.

5:41 PM Changeset in webkit [93842] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Some tests are apparently slow on Mac debug too.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
5:41 PM Changeset in webkit [93841] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fixing broken build due to unused variables in release mode
https://bugs.webkit.org/show_bug.cgi?id=67004

Unreviewed, release build fix.

Fixing broken build due to unused variables in ASSERTs in release build.

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::finishCreation):

5:36 PM Changeset in webkit [93840] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=66982

Reviewed by Dimitri Glazkov.

This patch just wires the rollout event through the controller to the
local server, which is already set up to perform rollouts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
5:34 PM Changeset in webkit [93839] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Handle key-down events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67001

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _disableComplexTextInputIfNecessary]):
If the plug-in is using the updated Cocoa text input model specification, disable text input
if the text input window has been dismissed for whatever reason.

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
If the plug-in is using the updated Cocoa text input model specification, let the input methods
have a go at the keyboard event.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Actually set m_isComplexTextInputEnabled to the right value.

5:06 PM Changeset in webkit [93838] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Factor code to send a key-down event to the plug-in out into a new function
https://bugs.webkit.org/show_bug.cgi?id=66999

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _handlePluginComplexTextInputKeyDown:]):
(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):

4:39 PM Changeset in webkit [93837] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Concentrate RenderLayer repaint rects updates
https://bugs.webkit.org/show_bug.cgi?id=64993

Reviewed by David Hyatt.

The change moves the update of the repaint rects to 2 methods
(computeRepaintRects and clearRepaintRects) to better track
those changes.

No new test, refactoring covered by the existing test cases.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Reverse the logic and
calculate the new bounds upfront. This should have no impact as none
of the methods rely on the internal value.

(WebCore::RenderLayer::computeRepaintRects): Added the cachedOffset parameter
to avoid breaking the performance optimization in updateLayerPositions. Added
some ASSERTS.

(WebCore::RenderLayer::clearRepaintRects): Added some ASSERTs here.
(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Added a FIXME as this
method could use the cachedOffset trick too.

(WebCore::RenderLayer::setHasVisibleContent): Changed the code to use
computeRepaintRects.

  • rendering/RenderLayer.h: Updated the signature of computeRepaintRects and moved

those 2 methods into the private section of the class.

4:33 PM Changeset in webkit [93836] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
4:30 PM Changeset in webkit [93835] by commit-queue@webkit.org
  • 16 edits in trunk/Source/JavaScriptCore

Unzip initialization lists and constructors in JSCell hierarchy (1/7)
https://bugs.webkit.org/show_bug.cgi?id=66827

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25
Reviewed by Geoffrey Garen.

Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors. Part of a larger refactoring to "unzip" initialization
lists and constructor bodies. Also renamed JSCell's constructorBody() method
to finishCreation().

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):

  • runtime/JSObject.h:

(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::constructorBody):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):

  • runtime/RegExp.h:
  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):

4:19 PM Changeset in webkit [93834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove use of magic number -1 in WebCore/editing/visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=66980

Patch by Van Lam <vanlam@google.com> on 2011-08-25
Reviewed by Ryosuke Niwa.

Replaced use of magic number -1 with constant offsetNotFound.

  • editing/visible_units.cpp:

(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):

4:08 PM Changeset in webkit [93833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add API to allow scripts to close windows automatically via JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=66777

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

Make it possible to allow or prevent scripts from closing windows
automatically (via window.close, for example).

Besides being useful in general, this is required by DRT.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_close_windows_get):
(ewk_view_setting_scripts_can_close_windows_set):

  • ewk/ewk_view.h:
4:08 PM Changeset in webkit [93832] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
https://bugs.webkit.org/show_bug.cgi?id=66956

Rebaseline constants for patching GetByIdSlowCaseCall on ARM.

Reviewed by Oliver Hunt.

  • jit/JIT.h:
4:06 PM Changeset in webkit [93831] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
https://bugs.webkit.org/show_bug.cgi?id=66951

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-25
Reviewed by Andreas Kling.

Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
width and height one by one and setWidth cause geometryChange event in QTouchWebView.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::resizeEvent):

4:02 PM Changeset in webkit [93830] by Dimitri Glazkov
  • 6 edits in trunk/Tools

garden-o-matic summary view should provide information on builders still in flight.
https://bugs.webkit.org/show_bug.cgi?id=66992

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3:58 PM Changeset in webkit [93829] by abarth@webkit.org
  • 2 edits in trunk/Tools

webkit-patch rebaseline-expectations don't work when run outside the root
https://bugs.webkit.org/show_bug.cgi?id=66966

Reviewed by Eric Seidel.

Turns out tool.path() used to be relative, which caused problems when
running webkit-patch outside the root directory. This patch makes it
absolute. I checked all callers, and they all appear to want this
behavior.

It was unclear to me how to test this change because we only really
have a testing strategy for webkitpy, not for the main script.

  • Scripts/webkit-patch:
3:56 PM Changeset in webkit [93828] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/audio/AudioArray.h

Merge 93749 - Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

BUG=94025
Review URL: http://codereview.chromium.org/7741034

3:54 PM Changeset in webkit [93827] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WKView should keep track of the plug-in complex text input state
https://bugs.webkit.org/show_bug.cgi?id=66990

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

Add a _pluginComplexTextInputState ivar to WKViewData.

(-[WKView _setPluginComplexTextInputState:]):
Set the _pluginComplexTextInputState variable. If text input is being disabled, send back an empty string to the plug-in.

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
Call -[WKView _setPluginComplexTextInputState:].

3:34 PM Changeset in webkit [93826] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Apparently, expectations without WONTFIX or BUGxxx are ignored.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [93825] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move file internal methods to a class continuation in WKView
https://bugs.webkit.org/show_bug.cgi?id=66983

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _deviceScaleFactor]):
(-[WKView _setDrawingAreaSize:]):

2:20 PM Changeset in webkit [93824] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

More work on the updated Cocoa text input specification
https://bugs.webkit.org/show_bug.cgi?id=66977

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

(WebKit::NetscapePlugin::setPluginWantsLegacyCocoaTextInput):
Add setter. Not called yet.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set m_hasHandledAKeyDownEvent to true if we get a KeyDown event.

(WebKit::NetscapePlugin::sendComplexTextInput):
If the plug-in is using the updated Cocoa text input spec, we can disable text input here.

(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
If the plug-in is using the updated Cocoa text input spec, text input is not enabled when
the plug-in is focused.

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Set the right text input state based on whether the plug-in is using the updated spec or not.

2:09 PM Changeset in webkit [93823] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/Tools

garden-o-matic summary needs a mock view that could be used for working on styling
https://bugs.webkit.org/show_bug.cgi?id=66971

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2:00 PM Changeset in webkit [93822] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [93821] by gavinp@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself to committers.

1:56 PM Changeset in webkit [93820] by igor.oliveira@openbossa.org
  • 6 edits
    2 deletes in trunk

2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):
(WebCore::RenderBox::controlClipRect):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • fast/css/button-overflow-ellipsis.html: Removed.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Removed.
1:50 PM Changeset in webkit [93819] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp

Merge 91802 - V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222

BUG=94273
Review URL: http://codereview.chromium.org/7740035

1:37 PM Changeset in webkit [93818] by crogers@google.com
  • 2 edits in branches/chromium/835/Source/WebCore/webaudio

Merge 92658 - Fix thread-safety of AudioNode deletion
https://bugs.webkit.org/show_bug.cgi?id=65888

BUG=94278
Review URL: http://codereview.chromium.org/7749016

1:29 PM Changeset in webkit [93817] by Ademar Reis
  • 2 edits in trunk/Source/WebCore

[Qt] Enable password echo on Symbian builds
https://bugs.webkit.org/show_bug.cgi?id=66954

Reviewed by Chang Shu.

No tests, as this is just a build change.

  • config.h:
1:28 PM Changeset in webkit [93816] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/AudioContext.cpp

Merge 91801 - AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217

BUG=94271
Review URL: http://codereview.chromium.org/7741029

1:27 PM Changeset in webkit [93815] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-25 Nate Chapin <Nate Chapin>

Windows build fix after r93811.

  • loader/cf/ResourceLoaderCFNet.cpp: (WebCore::ResourceLoader::shouldCacheResponse):
1:26 PM Changeset in webkit [93814] by andersca@apple.com
  • 5 edits
    3 adds in trunk

Return the correct value for NPNVsupportsCarbonBool
https://bugs.webkit.org/show_bug.cgi?id=66964

Source/WebKit2:

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Remove a FIXME and set the value to true.

Tools:

Add a test.

Reviewed by Adam Roben.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.

(SupportsCarbonEventModel::SupportsCarbonEventModel):
(SupportsCarbonEventModel::testConvert):
(SupportsCarbonEventModel::runTest):
(SupportsCarbonEventModel::NPP_New):

LayoutTests:

Reviewed by Adam Roben.

Add test.

  • platform/mac/plugins/supports-carbon-event-model-expected.txt: Added.
  • platform/mac/plugins/supports-carbon-event-model.html: Added.
1:21 PM Changeset in webkit [93813] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
https://bugs.webkit.org/show_bug.cgi?id=66690

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

The implementation is mostly based on the GTK+ port's, as we just need
to transfer the ownership of the frame to a new view and adjust the
smart object part accordingly.

This should help make fast/frames/iframe-reparenting-adopt-node.html
pass.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):

  • ewk/ewk_frame.cpp:

(ewk_frame_view_set):
(ewk_frame_view_create_for_view):

  • ewk/ewk_private.h:
12:57 PM Changeset in webkit [93812] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Further attempts to clean up the test expectations by being
more consistent about handling SKIPped and WONTFIXed tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [93811] by Nate Chapin
  • 17 edits
    1 add in trunk/Source/WebCore

Split some of the variables out of ThreadableLoaderOptions
into a superclass, ResourceLoaderOptions. Use ResourceLoaderOptions
all the way down to ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=63301

Reviewed by David Levin.

No new tests, refractor only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h: Added.
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/mac/ResourceLoaderMac.mm:
12:53 PM Changeset in webkit [93810] by crogers@google.com
  • 5 edits in branches/chromium/835/Source/WebCore

Merge 92408 - Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize):

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/7745029

12:44 PM Changeset in webkit [93809] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

use strict in CodeGeneratorJS and CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=66915

Reviewed by Darin Adler.

Making these files "use strict" makes changing them less
time-consuming and error-prone, and helps avoid accidentally
adding dead code (added a FIXME for one such case).

No expected change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(NativeToJSValue):
(GenerateHashValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateNormalAttrSetter):
(GetFunctionTemplateCallbackName):
(GenerateNewFunctionTemplate):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
():

12:21 PM Changeset in webkit [93808] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable incremental linking for component build on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66950

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-25
Reviewed by Darin Fisher.

Turns on Use Library Dependency Inputs for webkit.vcproj on Windows
build, when incremental_chrome_dll gyp flag is set. This is to get
faster incremental links on Windows builds.

  • WebKit.gyp:
12:17 PM Changeset in webkit [93807] by dino@apple.com
  • 8 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=21586
Apply CSS animations and transitions to SVG properties

Reviewed by Simon Fraser.

Expose the applicable SVG properties from SVGRenderStyle to
RenderStyle and add them to the list of animatable
properties. There aren't many SVG properties that are
animatable directly. SVGPaint (used in "fill" and "stroke")
is supported only when both ends of the animation are
a Color. Also updated SVGLength to have some methods
for converting to and from user space units.

12:09 PM Changeset in webkit [93806] by Dimitri Glazkov
  • 2 edits in trunk/Tools

garden-o-matic summary view should not be broken.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:

(table.comparison): Added more specificity.

12:06 PM Changeset in webkit [93805] by abarth@webkit.org
  • 2 edits in trunk/Tools

This command has been broken for a while. This patch updates the
callsite to the new API.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
12:02 PM Changeset in webkit [93804] by igor.oliveira@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed, rebaseline for bug 53438.

  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt:
11:48 AM Changeset in webkit [93803] by inferno@chromium.org
  • 1 edit
    40 adds
    1 delete in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r93794.

  • platform/chromium-cg-mac-leopard/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win-vista/fast/table: Removed.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt: Added.
11:09 AM Changeset in webkit [93802] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r90971): Fix an assertion failure with textarea placeholder.
https://bugs.webkit.org/show_bug.cgi?id=66164

Source/WebCore:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

Minor patch nits addressed by inferno@chromium.org, on Hyatt's
review.

Test: fast/forms/textarea-placeholder-relayout-assertion.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Pass 'false' to the 'markParents' argument of setChildNeedsLayout().
We don't need to propagate needsLayout for ancestors because
layoutSpecialExcludedChild() is called from layout() of the
parent.

LayoutTests:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

  • fast/forms/textarea-placeholder-relayout-assertion-expected.txt: Added.
  • fast/forms/textarea-placeholder-relayout-assertion.html: Added.
11:07 AM Changeset in webkit [93801] by Dimitri Glazkov
  • 5 edits
    2 adds in trunk/Tools

garden-o-matic needs a way to report where and how tests are failing in the summary view.
https://bugs.webkit.org/show_bug.cgi?id=66955

Introduce FailureGrid, your one-stop failure-indicating destination.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
11:05 AM Changeset in webkit [93800] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests until check them.
11:04 AM Changeset in webkit [93799] by igor.oliveira@openbossa.org
  • 6 edits
    2 adds in trunk

2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Fix text-overflow for button elements. Make the element inside
the button inherit the button controlClip.

Reviewed by David Hyatt.

Test: fast/css/button-overflow-ellipsis.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::controlClipRect):

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Add button text-overflow test.

Reviewed by David Hyatt.

  • fast/css/button-overflow-ellipsis.html: Added.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Added.
10:56 AM Changeset in webkit [93798] by ap@apple.com
  • 2 edits
    1 copy in trunk/Source/ThirdParty

Fix build when GCC 4.2 is not installed.

  • gtest/xcode/Config/CompilerVersion.xcconfig: Copied from Source/WebCore/Configurations/CompilerVersion.xcconfig.
  • gtest/xcode/Config/General.xcconfig: Use the same compiler version as other projects do.
10:33 AM QtWebKit edited by Ademar Reis
(diff)
10:32 AM QtWebKit edited by Ademar Reis
(diff)
10:27 AM Changeset in webkit [93797] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Several test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [93796] by enne@google.com
  • 11 edits in trunk/Source/WebCore

[chromium] Update VideoLayerChromium to not access GC3D on the main thread
https://bugs.webkit.org/show_bug.cgi?id=66434

Reviewed by James Robinson.

Covered by existing tests.

This change allows the main thread VideoLayerChromium to not depend on
compositor thread resources (GC3D, LayerRendererChromium). The texture
allocation in VideoLayerChromium was changed to use ManagedTexture so
that textures can now be evicted when there is texture memory pressure
and so that destruction can be automatically deferred until a GC3D is
available.

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/ManagedTexture.cpp:
  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::size):
(WebCore::ManagedTexture::format):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::reserveTextures):
(WebCore::VideoLayerChromium::updateTexture):
(WebCore::VideoLayerChromium::releaseCurrentFrame):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::contentsTextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setTexture):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
10:13 AM Changeset in webkit [93795] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix chromium devtools tests.

  • src/js/Tests.js: (.TestSuite.prototype.evaluateInConsole_):
9:58 AM Changeset in webkit [93794] by inferno@chromium.org
  • 5 edits
    30 adds in trunk

Incorrect layout of :before and :after content, with display
table, table-row and table-cell.
https://bugs.webkit.org/show_bug.cgi?id=66699

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-after-child-in-table.html

fast/table/table-before-child-in-table.html
fast/table/table-cell-after-child-in-block.html
fast/table/table-cell-after-child-in-table.html
fast/table/table-cell-before-child-in-block.html
fast/table/table-cell-before-child-in-table.html
fast/table/table-row-after-child-in-block.html
fast/table/table-row-after-child-in-table.html
fast/table/table-row-before-child-in-block.html
fast/table/table-row-before-child-in-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
Fix the looping condition to detect :after child correctly.
isAnonymousBlock() does not apply to tables, instead
using isAnonymous().

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

LayoutTests:

  • fast/table/table-after-child-in-table.html: Added.
  • fast/table/table-before-child-in-table.html: Added.
  • fast/table/table-cell-after-child-in-block.html: Added.
  • fast/table/table-cell-after-child-in-table.html: Added.
  • fast/table/table-cell-before-child-in-block.html: Added.
  • fast/table/table-cell-before-child-in-table.html: Added.
  • fast/table/table-row-after-child-in-block.html: Added.
  • fast/table/table-row-after-child-in-table.html: Added.
  • fast/table/table-row-before-child-in-block.html: Added.
  • fast/table/table-row-before-child-in-table.html: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt: Added.
9:50 AM Changeset in webkit [93793] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66906

Reviewed by Darin Adler.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
Very similar fix to the one in r93717 except this patches the case where the image load was
canceled via beforeload.

9:42 AM Changeset in webkit [93792] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] Leaking SkBitmaps for background images
https://bugs.webkit.org/show_bug.cgi?id=66488

Patch by John Bates <jbates@google.com> on 2011-08-25
Reviewed by Stephen White.

This patch simply changes NativeImageSkia to have a SkBitmap instead of
deriving from SkBitmap. All dependent code updated to access the member
instead of calling SkBitmap methods on NativeImageSkia objects. This
may or may not fix the memory leak, but it's definitely a bug that could
cause memory leaks.

Source/WebCore:

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

  • platform/graphics/chromium/PlatformImage.cpp:

(WebCore::PlatformImage::updateFromImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::size):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::checkForSolidColor):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::decodedSize):
(WebCore::NativeImageSkia::resizedBitmap):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::bitmap):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/chromium:

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::clipboardWriteImage):

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::operator=):

9:14 AM Changeset in webkit [93791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[SKIA] Move forward decl of skia type outside namespace Webkit
https://bugs.webkit.org/show_bug.cgi?id=66942

Patch by Brian Salomon <bsalomon@google.com> on 2011-08-25
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:
8:56 AM Changeset in webkit [93790] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r93774.
http://trac.webkit.org/changeset/93774
https://bugs.webkit.org/show_bug.cgi?id=66945

It broke 26 tests on the Qt bot (Requested by ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke):

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect):

8:47 AM Changeset in webkit [93789] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=66858

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.initializeView):
(WebInspector.NetworkLogView.prototype.willHide):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._showPopover):

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.dispose):
(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove.doHide):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype.hidePopover):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopupTimer):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._scroll):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._onHidePopover):
(WebInspector.SourceFrame.prototype._shouldShowPopover):
(WebInspector.SourceFrame.prototype._getPopoverAnchor):
(WebInspector.SourceFrame.prototype._highlightExpression):
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePanel.prototype._closeRecordDetails):

8:46 AM Changeset in webkit [93788] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Tools

Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66941

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/config/committers.py:
8:29 AM Changeset in webkit [93787] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

8:22 AM Changeset in webkit [93786] by pfeldman@chromium.org
  • 8 edits
    2 adds in trunk

[Qt] REGRESSION(93769): inspector/console/console-tests.html fails
https://bugs.webkit.org/show_bug.cgi?id=66930

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-repeat-count.html

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleModel.prototype.interruptRepeatCount):
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleMessageAdded):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/console/console-repeat-count-expected.txt: Added.
  • inspector/console/console-repeat-count.html: Added.
8:18 AM Changeset in webkit [93785] by Ademar Reis
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r93783.
http://trac.webkit.org/changeset/93783
https://bugs.webkit.org/show_bug.cgi?id=66943

Commited wrong stuff by accident. (Requested by ademar on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • Api/qwebview.cpp:

(QWebView::load):
(QWebView::setHtml):
(QWebView::setContent):
(QWebView::setUrl):

8:13 AM Changeset in webkit [93784] by alexis.menard@openbossa.org
  • 12 edits
    3 deletes in trunk/Source/WebKit2

[Qt][WK2] Remove QWKContext class and make sure the WebProcessProxy life is correctly managed.
https://bugs.webkit.org/show_bug.cgi?id=66886

Reviewed by Benjamin Poulain.

Remove QWKContext class from Qt APIs as it is too low level for the vision
of the Qt5 API. QtWebPageProxy now holds directly a WebContext which can be a custom one
or default created one. This patch also ensure that the WebProcessProxy is correctly
destroyed at application exit by removing the circular references between the WebContext,
WebProcessProxy, and WebPageProxy.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_setStatusText):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::QDesktopWebPageProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • UIProcess/qt/qwkcontext.cpp: Removed.
  • UIProcess/qt/qwkcontext.h: Removed.
  • UIProcess/qt/qwkcontext_p.h: Removed.
  • WebKit2.pro:
7:59 AM Changeset in webkit [93783] by Ademar Reis
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

7:37 AM Changeset in webkit [93782] by mnaganov@chromium.org
  • 8 edits in trunk/Source

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Tony Gentilcore.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::prune):
(WebCore::MemoryCache::pruneToPercentage):

  • loader/cache/MemoryCache.h: Methods moved from .h to .cpp to work around compilation problem with the Win Chromium port.
  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):
(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

6:08 AM Changeset in webkit [93781] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r93771.
http://trac.webkit.org/changeset/93771
https://bugs.webkit.org/show_bug.cgi?id=66933

Broke css3/font-feature-settings-rendering.html on chromium
mac 10.5 (Requested by podivilov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

5:52 AM Changeset in webkit [93780] by jocelyn.turcotte@nokia.com
  • 24 edits
    2 adds
    3 deletes in trunk/Source

[Qt][WK2] Drive tiling from the WebProcess and reuse TiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=66771

Reviewed by Tor Arne Vestbø.

We need the tiling logic to be moved to the web process to allow invalidated tile rects to be
rendered with the same layout. This also allows the web process to render tiles into
buffers readable directly by the GPU (on supported platforms). We also take the opportunity
to use the TiledBackingStore in WebCore to have only one tiling implementation.

Before this patch:

  • TiledDrawingAreaProxy manages tiles from the UI process.
  • TiledDrawingArea received rendering requests for a rect and returns the result to the proxy through shared memory.

After this patch:

  • TiledDrawingArea uses a TiledBackingStore to manage tiles from the web process.
  • TiledBackingStoreRemoteTile forwards tile creations, update and removals to the proxy.
  • TiledDrawingAreaProxy updates the scene graph directly from requests.

It also implements tile buffer swapping correctly in SGTileNode, triggered by the DidRenderFrame message.
Render throttling is implemented by waiting in TiledDrawingArea for the UI process to
notify us when the last rendered frame is ready to make it to the screen.
TiledDrawingAreaTileSets have been replaced by using two instances of TiledBackingStore instead.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

(WebCore::TiledBackingStoreClient::tiledBackingStoreIsUpdatingAllowed):

Source/WebKit2:

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportState):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::createTile):
(WebKit::DrawingAreaProxy::updateTile):
(WebKit::DrawingAreaProxy::didRenderFrame):
(WebKit::DrawingAreaProxy::removeTile):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::renderNextFrame):
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h: Removed.
  • UIProcess/qt/SGAgent.cpp:

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGAgent::SGAgent):
(WebKit::SGAgent::createTileNode):
(WebKit::SGAgent::removeTileNode):
(WebKit::SGAgent::setNodeBackBuffer):
(WebKit::SGAgent::swapTileBuffers):
(WebKit::SGAgent::updatePaintNode):
(WebKit::SGAgent::getScaleNode):
Make the parenting logic more strict to allow SGAgent to handle the scale nodes itself (remove NodeUpdateCreateScale and use the scale in CreateTile).
Delete the scale node when the last of its child tiles has been removed.

  • UIProcess/qt/SGAgent.h:

(WebKit::SGAgent::isSwapPending):

  • UIProcess/qt/SGTileNode.cpp:

(WebKit::SGTileNode::SGTileNode):
(WebKit::SGTileNode::setBackBuffer):
(WebKit::SGTileNode::swapIfNeeded):
Replace setTargetRect, setSourceRect and setTexture by a single setBackBuffer method.
This allows all those values to be used only when swapIfNeeded is called later.

  • UIProcess/qt/SGTileNode.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Removed.
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRect):
(WebKit::DrawingArea::setContentsScale):
(WebKit::DrawingArea::renderNextFrame):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp: Added.

(WebKit::TiledBackingStoreRemoteTile::TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::~TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::isDirty):
(WebKit::TiledBackingStoreRemoteTile::invalidate):
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::swapBackBufferToFront):
(WebKit::TiledBackingStoreRemoteTile::isReadyToPaint):
(WebKit::TiledBackingStoreRemoteTile::paint):
(WebKit::TiledBackingStoreRemoteTileBackend::TiledBackingStoreRemoteTileBackend):
(WebKit::TiledBackingStoreRemoteTileBackend::createTile):
(WebKit::TiledBackingStoreRemoteTileBackend::paintCheckerPattern):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h: Added.

(WebKit::TiledBackingStoreRemoteTile::create):
(WebKit::TiledBackingStoreRemoteTile::coordinate):
(WebKit::TiledBackingStoreRemoteTile::rect):
(WebKit::TiledBackingStoreRemoteTileClient::~TiledBackingStoreRemoteTileClient):
(WebKit::TiledBackingStoreRemoteTileBackend::create):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::setNeedsDisplay):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::setVisibleContentRect):
(WebKit::TiledDrawingArea::setContentsScale):
(WebKit::TiledDrawingArea::renderNextFrame):
(WebKit::TiledDrawingArea::suspendPainting):
(WebKit::TiledDrawingArea::resumePainting):
(WebKit::TiledDrawingArea::tiledBackingStorePaintBegin):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::tiledBackingStoreIsUpdatingAllowed):
(WebKit::TiledDrawingArea::tiledBackingStoreContentsRect):
(WebKit::TiledDrawingArea::tiledBackingStoreVisibleRect):
(WebKit::TiledDrawingArea::tiledBackingStoreBackgroundColor):
(WebKit::TiledDrawingArea::createTile):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::removeTile):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Removed.
5:52 AM Changeset in webkit [93779] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93775.
http://trac.webkit.org/changeset/93775
https://bugs.webkit.org/show_bug.cgi?id=66932

"Patch introduced the failures was rolled out." (Requested by
kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • platform/qt/Skipped:
5:49 AM Changeset in webkit [93778] by podivilov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium expectations.

  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
5:31 AM Changeset in webkit [93777] by jocelyn.turcotte@nokia.com
  • 5 edits
    1 copy
    1 add in trunk/Source/WebCore

TiledBackingStore: Untie the tile implementation from the platform.
https://bugs.webkit.org/show_bug.cgi?id=66760

Reviewed by Kenneth Rohde Christiansen.

Make the Tile class polymorphic and introduce TiledBackingStoreBackend as a Tile factory.

  • platform/graphics/Tile.h:

(WebCore::Tile::~Tile):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::client):

  • platform/graphics/TiledBackingStoreBackend.h: Added.

(WebCore::TiledBackingStoreBackend::create):
(WebCore::TiledBackingStoreBackend::~TiledBackingStoreBackend):
(WebCore::TiledBackingStoreBackend::TiledBackingStoreBackend):

  • platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::TileQt):
(WebCore::TileQt::~TileQt):
(WebCore::TileQt::isDirty):
(WebCore::TileQt::isReadyToPaint):
(WebCore::TileQt::invalidate):
(WebCore::TileQt::updateBackBuffer):
(WebCore::TileQt::swapBackBufferToFront):
(WebCore::TileQt::paint):
(WebCore::TiledBackingStoreBackend::paintCheckerPattern):
(WebCore::TiledBackingStoreBackend::createTile):

  • platform/graphics/qt/TileQt.h: Copied from Source/WebCore/platform/graphics/Tile.h.

(WebCore::TileQt::create):
(WebCore::TileQt::coordinate):
(WebCore::TileQt::rect):

5:30 AM Changeset in webkit [93776] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r93767.
http://trac.webkit.org/changeset/93767
https://bugs.webkit.org/show_bug.cgi?id=66931

Broke Qt bot. (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-25

  • Scripts/webkitpy/thirdparty/init.py:
5:02 AM Changeset in webkit [93775] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

  • platform/qt/Skipped:

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-25

4:48 AM Changeset in webkit [93774] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Patch by Andreas Kling <kling@webkit.org> on 2011-08-25
Reviewed by Benjamin Poulain.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

4:31 AM Changeset in webkit [93773] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

WebSocket: Queue messages to be sent
https://bugs.webkit.org/show_bug.cgi?id=66298

Reviewed by Kent Tamura.

Blobs must be read asynchronously and thus cannot be sent immediately. Therefore, we need to
create a queue of messages to be sent in order to handle pending requests.

No new tests. Strictly speaking, there is a small change in behavior but it is hard to
reproduce in tests. See description of WebSocketChannel::send below.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
Now, this function always returns true if hybi-10 protocol is selected. The impact of this change
should be minimum, because the current WebSocket API defines the return type of WebSocket.send()
is void (see also bug 65850).
It's hard to make SocketStreamHandle::send() fail deliberately, therefore it's difficult to write
a test to detect this behavior change.
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):

  • websockets/WebSocketChannel.h:
3:30 AM Changeset in webkit [93772] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Directional arrow on element info box looks terrible
https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
3:18 AM Changeset in webkit [93771] by jeremy@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove ATSFont*() functions in favor of CGFont in FontCustomPlatformData.cpp
https://bugs.webkit.org/show_bug.cgi?id=66629

As of r72774 and dropping support for OS X 10.4, we can safely
remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the
CGFont code.

This change is motivated by a bug in ATSFontDeactivite() on 10.7 which
affects the Chromium port, due to its compiling once against the 10.5
SDK for all platforms - See crbug.com/93191 or rdar://9976774 .

Reviewed by Dan Bernstein.

No new tests - covered by existing tests.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

3:05 AM Changeset in webkit [93770] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-25 Pavel Feldman <pfeldman@google.com>

Not reviewed: rollout r93768 for breaking build.

  • inspector/DOMNodeHighlighter.cpp:
3:01 AM Changeset in webkit [93769] by pfeldman@chromium.org
  • 63 edits
    1 copy
    1 add in trunk

Web Inspector: split ConsoleView into the View and the Model.
https://bugs.webkit.org/show_bug.cgi?id=66861

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ConsoleModel.js: Added.

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype._setConsoleMessageExpiredCount):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype._incrementErrorWarningCount):
(WebInspector.ConsoleModel.prototype.requestClearMessages):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleDispatcher):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleCommand):
(WebInspector.ConsoleView.prototype._appendConsoleCommandResult):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._requestClearMessages):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):

  • inspector/front-end/NetworkLog.js: Copied from Source/WebCore/inspector/front-end/externs.js.

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get resources):
(WebInspector.NetworkLog.prototype._frameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set finished):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._scriptForRawLocation):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.linkifyURLAsNode):
(WebInspector.formatLinkText):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._updateErrorAndWarningCounts):
(WebInspector.showConsole):

LayoutTests:

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
(initialize_ConsoleTest.InspectorTest.expandConsoleMessages):
(initialize_ConsoleTest):

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):
(initialize_InspectorTest):

  • http/tests/inspector/network/disabled-cache-crash.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-completions-on-call-frame.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
2:52 AM Changeset in webkit [93768] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Directional arrow on element info box looks terrible
https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
2:38 AM Changeset in webkit [93767] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-25
Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:
2:25 AM Changeset in webkit [93766] by yutak@chromium.org
  • 8 edits in trunk

Let MessageEvent.data hold SerializedScriptValue or String selectively
https://bugs.webkit.org/show_bug.cgi?id=66841

Reviewed by Adam Barth.

MessageEvent from WebSocket contains a String in its "data" attribute, but it does not have
to be serialized.

No new tests are added, because this is refactoring and the behavior should not change.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
To call putAnonymousValue(), "this" needs to be converted to non-const using const_cast<>.
(WebCore::JSMessageEvent::initMessageEvent):
Update the cache value as well.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
ForceSet() is used to cache a value. This is the same as what the code generated by
CodeGeneratorV8 does.
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::data):
This is only used within the Objective-C bindings (JSC and V8 have the custom functions).
Since Objective-C code generator does not support [CustomGetter] IDL attribute, there is
no good way to return a variant value for Objective-C bindings.

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):

  • dom/MessageEvent.idl:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):
Construct a MessageEvent without serializing the received message.

1:38 AM Changeset in webkit [93765] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-25 Pavel Podivilov <podivilov@chromium.org>

Unreviwed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
1:13 AM Changeset in webkit [93764] by morrita@google.com
  • 14 edits
    4 deletes in trunk

Unreviewed, rolling out r93762.
http://trac.webkit.org/changeset/93762
https://bugs.webkit.org/show_bug.cgi?id=66756

IndexedDb tests crash

Source/WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/generic/EventConstructors.h: Removed.
  • bindings/v8/OptionsObject.cpp:
  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/Event.idl:

LayoutTests:

  • fast/events/event-constructors-expected.txt: Removed.
  • fast/events/event-constructors.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
1:04 AM Changeset in webkit [93763] by zherczeg@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Add Qt specific expected after r93713 since ENABLE_MEDIA_STREAM is disabled.

Unreviewed, test expectations update.

  • platform/qt/fast/files/create-blob-url-crash-expected.txt: Added.

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-25

Note: See TracTimeline for information about the timeline view.