Timeline


and

08/30/11:

23:59 Changeset [94154] by philn@webkit.org
  • 2 edits in trunk/Tools

[webkitpy] missing log import in common/net/resultsjsonparser.py
https://bugs.webkit.org/show_bug.cgi?id=65606

Reviewed by Martin Robinson.

  • Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
23:55 Changeset [94153] by philn@webkit.org
  • 3 edits in trunk/Tools

[stylechecker] complains about NULL usage in some gst_structure_ calls
https://bugs.webkit.org/show_bug.cgi?id=67194

Reviewed by Martin Robinson.

Don't warn about NULL in some gst_structure_ calls. 0 can't be
used for these, a proper sentinel is required.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:21 Changeset [94152] by levin@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

[chromium] Update result due to r94114.

  • platform/chromium-win/svg/custom/pan-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pan-direction-expected.png.
  • platform/chromium/test_expectations.txt:
22:58 Changeset [94151] by levin@chromium.org
  • 2 edits
    1 copy
    5 adds in trunk/LayoutTests

[chromium] Update due to r94147.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt.
  • platform/chromium-mac/fast/events/constructors/custom-event-constructor-expected.txt: Added.

Several of these results are failures but that should be fixed by bug 66756.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Added.
21:56 Changeset [94150] by abarth@webkit.org
  • 3 edits
    4 deletes in trunk/Tools

Remove old-style UI from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67257

Reviewed by Dimitri Glazkov.

This code is nowhere near as awesome as the new hotness. Let's remove
it so it doesn't weigh us down.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
21:45 Changeset [94149] by rniwa@webkit.org
  • 24 edits in trunk/Source

Unreviewed, rolling out r94142, r94144, r94145, and r94148.
http://trac.webkit.org/changeset/94142
http://trac.webkit.org/changeset/94144
http://trac.webkit.org/changeset/94145
http://trac.webkit.org/changeset/94148
https://bugs.webkit.org/show_bug.cgi?id=67262

Broke isindex element (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

Source/WebCore:

  • WebCore.order:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/Node.cpp:

(WebCore::Node::toInputElement):

  • dom/Node.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::isInPasswordField):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::toInputElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebInputElement.cpp:

(WebKit::toWebInputElement):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

21:34 Changeset [94148] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Quick fix for crashing tests caused by r94142.

Tests:

editing/execCommand/remove-format-elements.html
fast/block/child-not-removed-from-parent-lineboxes-crash.html
fast/forms/implicit-submission.html

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Allow
for isIndex element which is derived from HTMLInputElement.

21:04 Changeset [94147] by weinig@apple.com
  • 13 edits
    2 adds in trunk

Add constructor for CustomEvent
https://bugs.webkit.org/show_bug.cgi?id=67248

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

  • bindings/generic/EventConstructors.h:

Add definition for CustomEvent constructor.

  • bindings/js/JSEventConstructors.cpp:

Add CustomEvent #includes.

  • dom/CustomEvent.cpp:

(WebCore::CustomEventInit::CustomEventInit):
(WebCore::CustomEvent::CustomEvent):

  • dom/CustomEvent.h:

(WebCore::CustomEvent::create):
Add Initializer./

  • dom/CustomEvent.idl:

Make constructible.

  • page/DOMWindow.idl:

Add CustomEvent attribute.

LayoutTests:

  • fast/events/constructors/custom-event-constructor-expected.txt: Added.
  • fast/events/constructors/custom-event-constructor.html: Added.

New test.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Updated for add window.CustomEvent.

19:48 Changeset [94146] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.6b5.
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
0.6b3 or later supports a closing handshake handler and it is useful to
verify client's closing handshake implementation.
0.6b4 supports AbortedByUserException. It is useful to eliminate
unnecessary server warning messages on intended abnormal closures.
0.6b5 supports Python 2.5.1 or Mac 10.5.

  • Scripts/webkitpy/thirdparty/init.py:

Update download URL and directory path.

19:13 Changeset [94145] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

GTK build fix after r94142.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

18:41 Changeset [94144] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Chromium build fix after r94142.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

18:23 Changeset [94143] by levin@chromium.org
  • 9 edits
    2 adds
    8 deletes in trunk/LayoutTests

[chromium] New baselines due to r94109.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Removed.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Removed.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-style-update-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-style-update-expected.png: Added.
18:20 Changeset [94142] by rniwa@webkit.org
  • 21 edits in trunk/Source

Get rid of toInputElement()
https://bugs.webkit.org/show_bug.cgi?id=67175

Reviewed by Darin Adler.

Source/WebCore:

Got rid of Node::toInputElement and HTMLInputElement::toInputElement and replaced them by
a global toHTMLInputElement.

  • WebCore.order:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/Node.cpp:
  • dom/Node.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::isInPasswordField):

  • html/HTMLInputElement.h:

(WebCore::toHTMLInputElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::toWebInputElement):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

18:14 Changeset [94141] by cevans@google.com
  • 4 edits
    1 copy in branches/chromium/835/Source/WebCore

Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7776026

18:10 Changeset [94140] by cevans@google.com
  • 4 edits
    1 delete in branches/chromium/835/Source/WebCore

Revert 94131 - Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7811011

18:09 Changeset [94139] by crogers@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/webaudio

Remove AudioContext createChannelMerger() method until thread safety issues can be properly addressed.
BUG=94834
R=cevans@chromium.org
Review URL: http://codereview.chromium.org/7740069

18:05 Changeset [94138] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCairo build fix after r94093.

  • platform/network/ResourceHandle.h:
17:29 Changeset [94137] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

add a test for border/padding/margin on the flexbox container
https://bugs.webkit.org/show_bug.cgi?id=67243

Reviewed by Tony Chang.

  • css3/flexbox/001-expected.txt:
  • css3/flexbox/001.html:
  • css3/flexbox/resources/flexbox.js:
17:26 Changeset [94136] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r94128.

  • WebCore.xcodeproj/project.pbxproj:
17:25 Changeset [94135] by cevans@google.com
  • 3 edits
    6 copies in branches/chromium/835

Merge 94109
BUG=94800
Review URL: http://codereview.chromium.org/7785020

17:21 Changeset [94134] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Correctly report selected text range for accessibility APIs for role=textbox
https://bugs.webkit.org/show_bug.cgi?id=65900

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-30
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/textbox-role-reports-selection.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
(WebCore::AccessibilityRenderObject::rootEditableElementForPosition):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/textbox-role-reports-selection-expected.txt: Added.
  • accessibility/textbox-role-reports-selection.html: Added.
17:18 Changeset [94133] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, fix WebGL layout tests due to missing WebView pointer.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):

17:13 Changeset [94132] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

The "port" property of an <a> whose href does not specify a port returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=66081

Source/WebCore:

HTMLAnchorElement now returns "" instead of "0" for unset port
Fixed KURLGoogle.cpp to have same behavior as KURL.cpp when setting port 0
Fixed Location.cpp to have same behavior as KURL.cpp when setting port 0

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

Tests: fast/dom/HTMLAnchorElement/get-href-attribute-port.html

fast/dom/HTMLAnchorElement/set-href-attribute-port.html
fast/loader/location-port.html
fast/url/segments-from-data-url.html
fast/url/segments.html
fast/url/trivial-segments.html
platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::port):

  • page/Location.cpp:

(WebCore::Location::host):
(WebCore::Location::port):
(WebCore::Location::setPort):

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort):

LayoutTests:

Updated tests to reflect behavior change around invalid port strings.
Updated chromium location-port test to reflect chromium issues

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

  • fast/dom/HTMLAnchorElement/get-href-attribute-port-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/get-href-attribute-port.html: Added.
  • fast/dom/HTMLAnchorElement/script-tests/get-href-attribute-port.js: Added.
  • fast/loader/location-port-expected.txt:
  • fast/loader/location-port.html:
  • fast/url/script-tests/segments-from-data-url.js:
  • fast/url/script-tests/segments.js:
  • fast/url/script-tests/trivial-segments.js:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/trivial-segments-expected.txt:
  • platform/chromium-cg-mac/fast/loader/location-port-expected.txt:
  • platform/chromium-win/fast/loader/location-port-expected.txt:
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:
17:13 Changeset [94131] by cevans@google.com
  • 4 edits
    1 copy in branches/chromium/835/Source/WebCore

Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7810012

17:03 Changeset [94130] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Fix pan scrolling on Windows to be clamped
https://bugs.webkit.org/show_bug.cgi?id=66910

Source/WebCore:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

Test: platform/win/fast/events/panScroll-correct-direction.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::panScrollFromPoint):
(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:

LayoutTests:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

  • platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png:
  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/win/fast/events/panScroll-correct-direction-expected.txt: Added.
  • platform/win/fast/events/panScroll-correct-direction.html: Added.
17:01 Changeset [94129] by cevans@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/AudioNode.cpp

Merge 94127
BUG=94820
Review URL: http://codereview.chromium.org/7809009

16:55 Changeset [94128] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

This patch makes the XMLHttpRequest method/header validation logic available as
static methods so URL loaders can perform the same checks for untrusted HTTP requests
coming from plugins.
https://bugs.webkit.org/show_bug.cgi?id=66909

Patch by Bill Budge <bbudge@chromium.org> on 2011-08-30
Reviewed by David Levin.

No new tests. Exposes no new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/HTTPValidation.cpp: Added.

(WebCore::isValidHTTPToken):
(WebCore::isValidHTTPHeaderValue):

  • platform/network/HTTPValidation.h: Added.
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::isAllowedHTTPMethod):
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::setRequestHeader):

  • xml/XMLHttpRequest.h:
16:45 Changeset [94127] by crogers@google.com
  • 5 edits in trunk

Don't allow nodes of one context to be connected to nodes of another context
https://bugs.webkit.org/show_bug.cgi?id=67245

Source/WebCore:

Reviewed by Dimitri Glazkov.

Tests: updated webaudio/audionode.html

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
16:42 Changeset [94126] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/wince

WinCE build fix attempt after r94080.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::scrollRectIntoView):

16:40 Changeset [94125] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 94112
BUG=89330
Review URL: http://codereview.chromium.org/7776023

16:36 Changeset [94124] by mitz@apple.com
  • 14 edits
    2 adds in trunk

Source/WebCore: WebCore part of <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

Test: TestWebKitAPI/Tests/mac/DOMRangeOfString.

  • WebCore.exp.in: Export Page::rangeOfString().
  • dom/Range.h: Added a default ASSERT_NO_EXCEPTION to a few more member functions.
  • editing/Editor.cpp:

(WebCore::Editor::findString): Moved most of the logic into rangeOfString(), which this function
now calls, passing in the current selection as the reference range and setting the selection to
the returned range.
(WebCore::Editor::rangeOfString): Added. Contains the find logic from findString().

  • editing/Editor.h:
  • page/Page.cpp:

(WebCore::Page::rangeOfString): Added. This function is similar to findString(), but it takes an optional
reference range and returns a Range, rather than using the current selection as the reference range and setting the
selection to the next match.

  • page/Page.h:

Source/WebKit/mac: <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm:

(coreOptions): Moved this function from WebHTMLView.mm to here and made
it accessible from both this file and WebHTMLView.mm.
(-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Tools: Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.

(-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

16:34 Changeset [94123] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Add additional convertValue overloads to JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=67244

Reviewed by Darin Adler.

Add overloads for convertValue that will be needed for Event
constructors.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

Add overloads. Remove #include of <runtime/Error.h> and just include
<interpreter/CallFrame.h>

  • bindings/js/JSEventConstructors.cpp:

Add now necessary #include of <runtime/Error.h>.

16:31 Changeset [94122] by bdakin@apple.com
  • 9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=67150
Would like API to use a custom device scale factor for a particular WebView/WKView
-and corresponding-
<rdar://problem/10041016>

Reviewed by Darin Adler.

Source/WebKit/mac:

New API is _setOverrideBackingScaleFactor:(CGFloat)

  • WebView/WebView.mm:

(-[WebView _setOverrideBackingScaleFactor:]):
(-[WebView _deviceScaleFactor]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

New API is setOverrideBackingScaleFactor() on WKPage

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetOverrideBackingScaleFactor):
(WKPageSetOverrideBackingScaleFactor):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::deviceScaleFactor):
(WebKit::WebPageProxy::setOverrideBackingScaleFactor):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::overrideBackingScaleFactor):

16:15 Changeset [94121] by commit-queue@webkit.org
  • 35 edits
    31 adds in trunk

Add MediaSource API to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=64731

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-30
Reviewed by Eric Carlson.

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Tests: http/tests/media/media-source/webm/video-media-source-errors.html

http/tests/media/media-source/webm/video-media-source-play.html
http/tests/media/media-source/webm/video-media-source-seek.html
http/tests/media/media-source/webm/video-media-source-state-changes.html

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • dom/EventNames.h:
  • features.pri:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Added initializers for new member variables.
(WebCore::HTMLMediaElement::prepareForLoad): Close the media source before starting a new load.
(WebCore::HTMLMediaElement::loadResource):

Fail loading if the media source url from another media element is used.

(WebCore::HTMLMediaElement::mediaEngineError):

Make sure the source is in the closed state before firing an emptied event.

(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):

New method called by WebCore::MediaPlayer to signal when the source is open.

(WebCore::HTMLMediaElement::mediaPlayerSourceURL):

New method called by the WebCore::MediaPlayer to determine what the media source URL is for this
HTMLMediaElement instance.

(WebCore::HTMLMediaElement::seek):

Disabled noSeekRequired optimization if a media source is open and resets the source state to SOURCE_OPEN if
it was in the SOURCE_ENDED state when seek() was called.

(WebCore::HTMLMediaElement::webkitSourceAppend):

New method for passing media data from JavaScript to the WebCore::MediaPlayer.

(WebCore::HTMLMediaElement::webkitSourceEndOfStream):

New method that allows JavaScript to signal the end of the stream.

(WebCore::HTMLMediaElement::webkitSourceState): New method allowing JavaScript to read the current source state.
(WebCore::HTMLMediaElement::setSourceState): New method for updating the current source state.
(WebCore::HTMLMediaElement::userCancelledLoad):

Transitions an open source to the closed state before firing an emptied event.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::webkitMediaSourceURL):

New method providing the media source URL to JavaScript for this HTMLMediaElement instance.

  • html/HTMLMediaElement.idl: Added new methods, attributes, and constants for the media source api.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAppend):

Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceAppend.

(WebCore::NullMediaPlayerPrivate::sourceEndOfStream):

Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceEndOfStream.

(WebCore::MediaPlayer::sourceAppend): New method for receiving media data from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceEndOfStream): New method for receiving end of stream from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceOpened):

New method called by the MediaPlayerPrivate object to notify the MediaPlayer when the source has opened.

(WebCore::MediaPlayer::sourceURL):

New method called by the MediaPlayerPrivate implementation to get the media source URL from the MediaPlayer.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerSourceOpened):

Interface method used by the MediaPlayer to tell the HTMLMediaElement when the media source has been opened.

(WebCore::MediaPlayerClient::mediaPlayerSourceURL):

Interface method used by the MediaPlayer to get the media source URL from the HTMLMediaElement.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAppend):

Interface method used by the MediaPlayer to pass media data to the MediaPlayerPrivate object.

(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream):

Interface method used by the MediaPlayer to pass end of stream information to the MediaPlayerPrivate object.

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAppend):
(WebKit::WebMediaPlayer::sourceEndOfStream):

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):

  • src/WebMediaPlayerClientImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • http/tests/media/media-source/webm/video-media-source-errors-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-errors.html: Added.
  • http/tests/media/media-source/webm/video-media-source-play-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-play.html: Added.
  • http/tests/media/media-source/webm/video-media-source-seek-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-seek.html: Added.
  • http/tests/media/media-source/webm/video-media-source-state-changes-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-state-changes.html: Added.
  • http/tests/media/media-source/webm/webm-media-source.js: Added.

(getData):
(getHeaders):
(getClusterCount):
(getCluster):
(getClusterTimeForIndex):
(getClusterIndexForTimestamp):
(setSrcToMediaSourceURL):
(appendHeaders):
(appendCluster):
(appendUntilEndOfStream):
(logSourceState):
(getSourceStateName):
(expectSourceState):

  • http/tests/media/resources/media-source/webm/test.webm: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-0: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-1: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-10: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-11: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-12: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-13: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-14: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-15: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-2: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-3: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-4: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-5: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-6: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-7: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-8: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-9: Added.
  • http/tests/media/resources/media-source/webm/test.webm.headers: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
16:09 Changeset [94120] by inferno@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r94109.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-before-child-style-update-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-style-update-expected.png: Added.
15:49 Changeset [94119] by weinig@apple.com
  • 10 edits
    2 adds in trunk/Source/WebCore

Refactor JS dictionary code into helper class and covert geolocation code to use it
https://bugs.webkit.org/show_bug.cgi?id=67213

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add new files.

  • bindings/js/JSDictionary.cpp: Added.

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h: Added.

(WebCore::JSDictionary::JSDictionary):
(WebCore::JSDictionary::tryGetProperty):
Encapsulate dictionary initialization code into JSDictionary class.

  • bindings/js/JSEventConstructors.cpp:

(WebCore::constructJSEventWithInitializer):
Use JSDictionary.

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::setEnableHighAccuracy):
(WebCore::setTimeout):
(WebCore::setMaximumAge):
(WebCore::createPositionOptions):
Use JSDictionary.

15:39 Changeset [94118] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Switch chromium to use ScrollAnimatorNone on Windows.
https://bugs.webkit.org/show_bug.cgi?id=67000

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

Testing covered by Chromium webkit_unit_tests ScrollAnimatorNoneTest.*

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
15:33 Changeset [94117] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

refactor and cleanup RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=67165

Reviewed by Ojan Vafai.

No new tests, just refactoring code.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal): Make childSizes a param so we can pass the results to layoutAndPlaceChildrenHorizontal.
(WebCore::hasPackingSpace): Move closer to where it's used.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):

Pull this code out into its own function because it's not part of running the free space allocation algorithm.

  • rendering/RenderFlexibleBox.h:
15:12 Changeset [94116] by timothy_horton@apple.com
  • 4 edits
    2 adds in trunk

getBBox() on a SVGPathElement with curves incorrectly includes control points
https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Dirk Schulze.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

15:09 Changeset [94115] by adachan@apple.com
  • 15 edits
    2 adds in trunk/Source/WebKit2

Laying some groundwork to fetch performance statistics from WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Add WKContextGetStatistics() which sends a message to WebProcess to fetch the performance statistics.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::getWebCoreStatistics):
(WebKit::WebContext::didGetWebCoreStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add the DidGetWebCoreStatistics message that WebProcess can send when it has

the performance statistics ready.

Add WebProcess::getWebCoreStatistics(). Currently it just sends back an empty StatisticsData object.
It will gather the performance statistics to store in the StatisticsData object in a future patch.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add the skeleton for StatisticsData.

  • Scripts/webkit2/messages.py:
  • Shared/StatisticsData.cpp: Added.

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
(WebKit::StatisticsData::StatisticsData):

  • Shared/StatisticsData.h: Added.

Add StatisticsData.h/cpp to project.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:02 Changeset [94114] by timothy_horton@apple.com
  • 4 edits
    4 adds in trunk

SVG panning y-axis is flipped in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=65800
<rdar://problem/9908012>

Reviewed by Darin Adler.

We previously were not transforming the pointer coordinates passed
to SVGDocument's panning implementation into the coordinate space of
the contents, so on different platforms, the drag direction was different.

Test: svg/custom/pan-direction.svg

14:37 Changeset [94113] by caryclark@google.com
  • 1 edit
    83 adds in trunk/LayoutTests

LayoutTest expected results for Skia on Mac (animations and canvas directories only)
https://bugs.webkit.org/show_bug.cgi?id=67218

Reviewed by Adam Barth.

  • platform/chromium-mac/animations: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac/animations/state-at-end-event-expected.png: Added.
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
  • platform/chromium-mac/canvas: Added.
  • platform/chromium-mac/canvas/philip: Added.
  • platform/chromium-mac/canvas/philip/tests: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.operation.clear-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.operation.darker-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.outside3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.object.round-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.object.wrap-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.missingargs-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.5-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.string-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.norepeat.coord3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeatx.coord1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeaty.coord1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.align.center-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/type.prototype-expected.txt: Added.
14:31 Changeset [94112] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Flaky crash with JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=66360

Reviewed by Nate Chapin.

Source/WebCore:

This patch teaches DocumentWriter::begin to make a copy of the URL
before beginning a new document to avoid a crash.

Test: fast/loader/javascript-url-iframe-crash.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

LayoutTests:

  • fast/loader/javascript-url-iframe-crash-expected.txt: Added.
  • fast/loader/javascript-url-iframe-crash.html: Added.
14:27 Changeset [94111] by tonyg@chromium.org
  • 4 edits
    2 adds in trunk

PreloadScanner shouldn't load images inside noscript via doc.write
https://bugs.webkit.org/show_bug.cgi?id=67214

Reviewed by Adam Barth.

Source/WebCore:

The problem was that the tokenizer state was lost between each call to document.write.
This works around that bug by making all document.write()s in the same script block share
the same tokenizer state.

Test: fast/preloader/document-write-noscript.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLDocumentParser.h:

LayoutTests:

  • fast/preloader/document-write-noscript-expected.txt: Added.
  • fast/preloader/document-write-noscript.html: Added.
14:25 Changeset [94110] by dimich@chromium.org
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67210
[Chromium] Use after free in ScheduledAction::execute(WebCore::V8Proxy*)

Reviewed by David Levin.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):
Removed usage of V8Proxy instance after it could have been deleted.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):

  • bindings/v8/V8Proxy.h:

Removed unused timerCallback() and setTimerCallback().

14:22 Changeset [94109] by inferno@chromium.org
  • 11 edits
    6 adds in trunk

Source/WebCore: Style not updated for table parts in :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=66141

Reviewed by Dave Hyatt.

Tests: fast/table/table-before-child-style-update.html

fast/table/table-row-before-child-style-update.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests: Style not updated for table parts in :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=66141

  1. 2 new tests show that the blue and green boxes don't overlap

after the fix.

  1. update r93794 tests showing that style info is propagated.

Reviewed by Dave Hyatt.

  • fast/table/table-before-child-style-update-expected.png: Added.
  • fast/table/table-before-child-style-update-expected.txt: Added.
  • fast/table/table-before-child-style-update.html: Added.
  • fast/table/table-row-before-child-style-update-expected.png: Added.
  • fast/table/table-row-before-child-style-update-expected.txt: Added.
  • fast/table/table-row-before-child-style-update.html: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
13:53 Changeset [94108] by tony@chromium.org
  • 3 edits
    2 adds in trunk

refactor box-ordinal-group handling so we don't timeout on large values
https://bugs.webkit.org/show_bug.cgi?id=65783

Reviewed by David Hyatt.

Source/WebCore:

The old code walked from 1 to the last box-ordinal-group while
iterating over each flex item. The new code collects ordinals as
we do the first walk and sorts them. Each additional iteration
through the flex items gets the next oridnal from the sorted list.

This maintains the single pass for the common case of no
box-ordinal-groups specified. If there are ordinal groups,
the runtime is O(n*m + m lg m) where n is the # of flex items and
m is the number of unique box-ordinal-group values. The memory
usage is O(2m).

Test: fast/flexbox/box-ordinal-group.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):
(WebCore::FlexBoxIterator::compareFlexOrder):

LayoutTests:

  • fast/flexbox/box-ordinal-group-expected.txt: Added.
  • fast/flexbox/box-ordinal-group.html: Added.
13:45 Changeset [94107] by inferno@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

Removed m_owner accessed in custom scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=64737

Reviewed by David Hyatt.

Problem does not reproduce in DRT, even with Eventhandler tricks
and gc(). So, adding a manual test.

  • manual-tests/custom-scrollbar-renderer-removed-crash.html: Added.
  • page/FrameView.cpp:

(WebCore::FrameView::clearOwningRendererForCustomScrollbars):

  • page/FrameView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed): when this renderbox is getting
destroyed, clear the custom scrollbar in this frameview having this renderbox
as its owning renderer.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::getScrollbarPseudoStyle): fix the null check.

13:43 Changeset [94106] by nduca@chromium.org
  • 4 edits
    1 move in trunk/Source/WebKit/chromium

[chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts
https://bugs.webkit.org/show_bug.cgi?id=67179

Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::create):
(WebCore::GraphicsContext3DInternal::createFromWebContext):
(WebCore::GraphicsContext3D::create):

  • src/GraphicsContext3DInternal.h:
  • tests/MockGraphicsContext3DTest.cpp: Renamed from Source/WebKit/chromium/tests/MockWebGraphicsContext3DTest.cpp.

(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):
(TEST):

13:42 Changeset [94105] by caio.oliveira@openbossa.org
  • 19 edits
    2 adds in trunk

Emit last progress notification before calling dispatchDidFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=28851

Reviewed by Adam Barth.

Source/WebCore:

Original patch by Xan Lopez. Change FrameLoader to dispatch the notifications in
a more natural sequence.

Test: http/tests/loading/progress-finished-callback.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

Source/WebKit/qt:

Add infrastructure to dump progressFinishedNotification callback in DRT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::dumpProgressFinishedCallback):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):

  • WebCoreSupport/FrameLoaderClientQt.h:

Tools:

Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
Chromium and GTK ports. The first two were simple changes.

Some refactoring was needed in GTK port to assure that the dumps are emitted
correctly and the processing after the page load finished is in the right place.

To detect the load finished, we use the callback for the "load-status" notifier
signal of the top loading frame. And we use the deprecated "load-finished" signal
for dumping (if enabled) the progress finished expected output.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpProgressFinishedCallbackCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpProgressFinishedCallback):
(LayoutTestController::setDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpProgressFinishedCallback):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController::setShouldDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didStopLoading):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewLoadFinished):
(topLoadingFrameLoadFinished):
(webFrameLoadStatusNotified):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):
(LayoutTestController::dumpProgressFinishedCallback):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Keep track of the order expected for the progressFinishedNotification, which is
before the didFinishLoadForFrame.

  • http/tests/loading/progress-finished-callback-expected.txt: Added.
  • http/tests/loading/progress-finished-callback.html: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
13:39 Changeset [94104] by ojan@chromium.org
  • 15 edits in trunk

CSS parsing for -webkit-flex-flow
https://bugs.webkit.org/show_bug.cgi?id=67224

Source/WebCore:

Reviewed by Tony Chang.

Adds support for the first value of -webkit-flex-flow.
Later we'll need to add support for the second "wrap" value,
but that can wait until we are ready to implement multiline
flex and the spec has stabilized a bit.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexFlow):
(WebCore::InheritedFlags::setFlexFlow):
(WebCore::InheritedFlags::initialFlexFlow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Reviewed by Tony Chang.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
13:26 Changeset [94103] by fpizlo@apple.com
  • 1 edit
    1 add in trunk/Tools

JavaScriptCore does not have a good mechanism for performance
regression testing
https://bugs.webkit.org/show_bug.cgi?id=67177

Reviewed by Darin Adler.

Added a new script, which allows for testing one, two, or more VMs
at once on SunSpider, V8, and Kraken benchmarks. Benchmark/VM runs
are interleaved at random to minimize systematics. The results
that bencher prints includes all possible relevant information about
how bencher was invoked. Bencher can be easily used to measure
performance changes down to fractions of a percent.

Bencher also includes experimental support for running benchmarks in
a DumpRenderTree release build. This works in SunSpider and V8, but
not yet in Kraken. Running benchmarks in DumpRenderTree more
closely mimics the performance when running in browser.

  • Scripts/bencher: Added.
13:23 Changeset [94102] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Add null checks for document()->loader()
https://bugs.webkit.org/show_bug.cgi?id=67077

Reviewed by Nate Chapin.

Document::loader can return 0 for a number of reasons. Call sites need
to null check the result, like we do for Document::frame. I suspect
some of these are real crashes, along the lines of
http://trac.webkit.org/changeset/93692, but null checking this function
is just good practice.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

  • src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageEncoding):

13:17 Changeset [94101] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Replace QLibrary("libgtk-x11-2.0.so.0") with QLibrary("libgtk-x11-2.0", 0)
https://bugs.webkit.org/show_bug.cgi?id=66627

Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-30
Reviewed by Simon Hausmann.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::initializeGtk):

13:10 Changeset [94100] by levin@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

[chromium] Add baselines for due to r94092 and r93909.

  • platform/chromium-cg-mac/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-cg-mac/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-linux/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:08 Changeset [94099] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/loader/document-destruction-within-unload.html causes an assertion failure in the next
test (currently, document-with-fragment-url-1.html)
https://bugs.webkit.org/show_bug.cgi?id=66783

  • platform/mac/Skipped: Skipping the offending test.
13:06 Changeset [94098] by lforschler@apple.com
  • 8 edits in branches/safari-534.51-branch

Merge r93934.

13:01 Changeset [94097] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Rollout 93664.

12:26 Changeset [94096] by darin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-08-29 Darin Fisher <darin@chromium.org>

[chromium] DumpRenderTree should be explicit about its dependency on
GoogleURL
https://bugs.webkit.org/show_bug.cgi?id=67169

Reviewed by Ryosuke Niwa.

DumpRenderTree uses GoogleURL code directly, and it should be explicit
about that instead of picking up this dependency transitively, which
only works for the static build.

This is needed to support the "component" build of DumpRenderTree, in
which the various Chromium dependencies are built as separate DLLs.

  • WebKit.gyp:
12:13 Changeset [94095] by oliver@apple.com
  • 7 edits in trunk

TypedArrays don't ensure that denormalised values are normalised
https://bugs.webkit.org/show_bug.cgi?id=67178

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add test to ensure that we create a non-signalling nan when reading
a singaling nan from a typed array.

  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a couple of assertions to jsNumber() to ensure that
we block signaling NaNs

  • runtime/JSValue.h:

(JSC::jsDoubleNumber):
(JSC::jsNumber):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Ensure that we convert singaling nans to silent nans when loading
from a typed array.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

12:03 Changeset [94094] by levin@chromium.org
  • 17 edits
    4 adds
    2 deletes in trunk/LayoutTests

[chromium] Update baselines after r94084 and r94088 and r93909.

  • platform/chromium-cg-mac/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-win/fast/multicol/positive-leading-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
11:57 Changeset [94093] by ap@apple.com
  • 33 edits in trunk

DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>

Reviewed by Darin Adler.

Use a clean CFURLStorageSession when this functionality is available.

  • WebCore.exp.in: Added exports.
  • WebCore.xcodeproj/project.pbxproj: Made CookieStorageCFNet.h private, as currentCFHTTPCookieStorage is used in WebKit.
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::setCookies): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): Updated to use currentCFHTTPCookieStorage().
  • platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.
  • platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp.
  • platform/network/ResourceHandle.h: Exposed default session support on Mac, too. Made privateBrowsingStorageSession() private, as callers shouldn't be concerned about where the current sssion came from.
  • platform/network/cf/CookieJarCFNet.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): (WebCore::getHostnamesWithCookies): (WebCore::deleteCookiesForHostname): (WebCore::deleteAllCookies): Updated to use currentCFHTTPCookieStorage().
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API. (WebCore::overrideCookieStorage): Ditto. (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable, unless it has been overridden on Windows. We can always get it from a session. (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just use private session's storage. Note that Mac has a separate code path for OS versions that don't support sessions. (WebCore::startObservingCookieChanges): Updated to use currentCFHTTPCookieStorage(). (WebCore::stopObservingCookieChanges): Ditto.
  • platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK), as this function is also used with NSURLConnection when sessions are enabled. (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session is now supported on Mac, too. (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK). (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer adopt the session, because nothing in method name says that it will steal a reference from the caller. (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK). (WebCore::privateStorageSession): Moved from ResourceHandle.cpp. (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.
  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): We no longer store a reference to cookie storage in a static variable, so nothing to do here. On older OS versiosn, we still need to enable legacy private browsing mode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function. (WebCore::ResourceHandle::createNSURLConnection): Updated to use currentStorageSession() instead of privateBrowsingStorageSession(). (WebCore::ResourceHandle::willSendRequest): Ditto.
11:28 Changeset [94092] by hyatt@apple.com
  • 6 edits
    6 adds in trunk

<rdar://problem/10002140> 9A309: Text gets clipped in book because of overflow:auto

https://bugs.webkit.org/show_bug.cgi?id=67212 - Text gets clipped in multi-column layouts when overflow:auto
is used.

Revise our overflow:auto pagination behavior. If the overflow block doesn't specify any logical height
information, then we'll just assume the plan is for it to enclose its contents, and we will be willing
to paginate in those circumstances.

Reviewed by Dan Bernstein.

Added overflow-across-columns.html and overflow-unsplittable.html

Source/WebCore:

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasUnsplittableScrollingOverflow):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/multicol/overflow-across-columns.html: Added.
  • fast/multicol/overflow-unsplittable.html: Added.
  • platform/mac/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/mac/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/mac/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/mac/fast/multicol/overflow-unsplittable-expected.txt: Added.
10:58 Changeset [94091] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix chromium compile when using clang. Another compile error due
to r94080.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::scrollRectIntoView):

10:47 Changeset [94090] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93924.
http://trac.webkit.org/changeset/93924
https://bugs.webkit.org/show_bug.cgi?id=67209

Bad baseline submitted for OS X. Should be chromium specific.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
10:43 Changeset [94089] by antti@apple.com
  • 11 edits
    2 adds
    2 deletes in trunk/Source/WebCore

querySelector/querySelectorAll should use selector checker fast path
https://bugs.webkit.org/show_bug.cgi?id=67161

Reviewed by Sam Weinig.

Descendant and child selectors can be matches substantially faster using
SelectorChecker::fastCheckSelector() path. Currently it is used for style matching only.

Add SelectorQuery class that can do both querySelector and querySelectorAll efficiently using
fast path. Use inlined loop for DOM traversal.

The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/.
Some individual subtests (using child or descendant selectors) execute twice as fast.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::isFastCheckableSelector):
(WebCore::RuleData::RuleData):

  • css/CSSStyleSelector.h:


Make fast path checking available outside CSSStyleSelector.


  • dom/DOMAllInOne.cpp:
  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

Switch to SelectorQuery.


  • dom/SelectorNodeList.cpp: Removed.
  • dom/SelectorNodeList.h: Removed.


SelectorQuery makes these obsolete.

  • dom/SelectorQuery.cpp: Added.

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):

  • dom/SelectorQuery.h: Added.


Class for selector matching in tree.

10:35 Changeset [94088] by dimich@chromium.org
  • 4 edits in trunk/Source/WebCore

REGRESSION (r93913): Failures in fast/replaced/frame-removed-during-resize.html and scrollbars/scrollable-iframe-remove-crash.html
https://bugs.webkit.org/show_bug.cgi?id=67074

Reviewed by Darin Adler.

Added flag m_isClosed to prevent events that cause Frame to be destroyed
from posting more events into EventQueue of a dying Document.

The tests mentioned above should now pass.

  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/EventQueue.cpp:

(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::close): Renamed method to reflect better what it does.

  • dom/EventQueue.h:
10:34 Changeset [94087] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Make mouse over work again for QDesktopWebView.
https://bugs.webkit.org/show_bug.cgi?id=67200

Reviewed by Noam Rosenthal.

The API has changed after QGraphicsView, SceneGraph sends
QHoverEvents now.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverMoveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
10:09 Changeset [94086] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS to r98771.

  • DEPS:
10:06 Changeset [94085] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix compile warning on clang:
error: 'WebKit::ChromeClientImpl::scrollRectIntoView' hides overloaded virtual function [-Werror,-Woverloaded-virtual]

virtual void scrollRectIntoView(


../../WebCore/page/ChromeClient.h:171:22: note: hidden overloaded virtual function 'WebCore::ChromeClient::scrollRectIntoView' declared here

virtual void scrollRectIntoView(const IntRect&) { }; Currently only Mac has a non empty implementation.

  • page/ChromeClient.h:

(WebCore::ChromeClient::scrollRectIntoView):

09:57 Changeset [94084] by hyatt@apple.com
  • 7 edits
    3 adds in trunk

<rdar://problem/8832814> With large line-height, column break can happen anywhere in the
inter-line gap, causing staggered lines.

https://bugs.webkit.org/show_bug.cgi?id=67202 Handle positive leading when paginating lines.

Technically we should paginate lines based solely off their line top and line bottom with
leading included. However there are two issues with always doing so. The first is that overflow
can cause lines to overlap, and the second is that negative leading can cause lines to overlap.

Since we're incapable of dealing with overlap until we stop clipping column boxes and allow them
to have a form of specialized overflow, we still have to at least factor in overflow and ignore
negative leading for now. However we can at least honor positive leading when the lines don't
overlap. This patch provides basic support for paginating when positive leading is involved.

Reviewed by Dan Bernstein.

Added fast/multicol/positive-leading.html.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markLinesDirtyInBlockRange):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

(WebCore::RenderBlock::adjustLinePositionForPagination):
Grow the top and extent of the line to include our leading when deciding how to paginate
the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::lineTopWithLeading):
(WebCore::RootInlineBox::lineBottomWithLeading):
(WebCore::RootInlineBox::setLineTopBottomPositions):
Instead of one member variable, blockLogicalHeight(), RootInlineBoxes now know both their top and
bottom including leading. These values are obtainable using lineTopWithLeading() and lineBottomWithLeading().
Add these two values to the setLineTopBottomPositions setter and remove setBlockLogicalHeight.

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutRootBox):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

LayoutTests:

  • fast/multicol/positive-leading.html: Added.
  • platform/mac/fast/multicol/positive-leading-expected.png: Added.
  • platform/mac/fast/multicol/positive-leading-expected.txt: Added.
09:55 Changeset [94083] by cmarrin@apple.com
  • 12 edits
    2 moves in trunk/Source

Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Reviewed by Kenneth Russell.

Source/WebCore:

  • GNUmakefile.list.am:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

  • platform/graphics/gtk/GraphicsContext3DInternal.h: Removed.
  • platform/graphics/gtk/GraphicsContext3DPrivate.h: Copied from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.h.
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::getViewportGLWidget):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::boundingRect):
(WebCore::GraphicsContext3DPrivate::paint):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::platformLayer):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):

  • src/GraphicsContext3DInternal.h: Removed.
  • src/GraphicsContext3DPrivate.h: Copied from Source/WebKit/chromium/src/GraphicsContext3DInternal.h.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::graphicsContext3D):

09:35 Changeset [94082] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on webcore_bindings_sources
and compiles these files. Previously, the other webcore libs (webcore_svg,
webcore_html, webcore_remaining, etc) depended on webcore_bindings. This changes the
dependency on webocre_bindings_sources so the build can parallelize the compile of
webcore_bindings and the other webcore_* libs.

No new tests, just changing the build dependencies. Manually copy over the
include dirs that we used to get from webcore_bindings' direct_dependent_settings.

  • WebCore.gyp/WebCore.gyp:
09:35 Changeset [94081] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] svg/animations/animate-end-attribute.html r93949
https://bugs.webkit.org/show_bug.cgi?id=67130

Skip a svg test on WebKit2 that rely on unimplemented test harness API.

Patch by Young Han Lee <joybro@company100.net> on 2011-08-30
Reviewed by Noam Rosenthal.

  • platform/wk2/Skipped:
09:10 Changeset [94080] by commit-queue@webkit.org
  • 27 edits in trunk/Source

The unused ScrollView* argument can and should be removed from
scrollRectIntoView.
https://bugs.webkit.org/show_bug.cgi?id=67117

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::scrollRectIntoView):

  • page/Chrome.cpp:

(WebCore::Chrome::scrollRectIntoView):

  • page/ChromeClient.h:

(WebCore::ChromeClient::scrollRectIntoView):

Source/WebKit/chromium:

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::scrollRectIntoView):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::scrollRectIntoView):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::scrollRectIntoView):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::scrollRectIntoView):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::scrollRectIntoView):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollRectIntoView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
09:00 Changeset [94079] by commit-queue@webkit.org
  • 6 edits in trunk

Update registerProtocolHandler scheme whitelist to match spec
https://bugs.webkit.org/show_bug.cgi?id=67104

Patch by Ben Wells <benwells@chromium.org> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

  • page/Navigator.cpp:

(WebCore::initProtocolHandlerWhitelist):

LayoutTests:

  • fast/dom/register-protocol-handler-expected.txt:
  • fast/dom/register-protocol-handler.html:
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt:
08:28 Changeset [94078] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Reviewed by Pavel Feldman.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFailLoading):

08:16 Changeset [94077] by commit-queue@webkit.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r94076.
http://trac.webkit.org/changeset/94076
https://bugs.webkit.org/show_bug.cgi?id=67201

Results will be different on each platform (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

  • fast/multicol/huge-column-count-expected.png: Removed.
  • fast/multicol/inherit-column-values-expected.png: Removed.
  • fast/multicol/initial-column-values-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
07:41 Changeset [94076] by apavlov@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, add missing multicol test baselines.

  • fast/multicol/huge-column-count-expected.png: Added.
  • fast/multicol/inherit-column-values-expected.png: Added.
  • fast/multicol/initial-column-values-expected.png: Added.
  • platform/chromium/test_expectations.txt: Remove huge-column-count-expected.png MISSING expectation.
06:57 Changeset [94075] by ademar.reis@openbossa.org
  • 4 edits in trunk/Source

[Qt] Do not unconditionally use pkg-config in .pro files
https://bugs.webkit.org/show_bug.cgi?id=67055

Reviewed by Andreas Kling.

Original patch from Rohan McGovern <rohan.mcgovern@nokia.com>

Using the first pkg-config in PATH is prone to errors when cross
compiling inside the Qt repository (using Qt's build-system).

This patch protect calls for pkg-config with
!contains(QT_CONFIG, no-pkg-config). no-pkg-config is added to
QT_CONFIG by Qt's 'configure' when cross-compiling on systems
without pkg-config.

The respective change in Qt's configure has been submited already.

No new tests as this is just a build change.

Source/JavaScriptCore:

  • wtf/wtf.pri: protect pkg-config calls

Source/WebCore:

  • features.pri: protect pkg-config calls
06:16 Changeset [94074] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLImageElement: Don't cache "ismap" and "usemap" attributes.
https://bugs.webkit.org/show_bug.cgi?id=66784

Patch by Andreas Kling <kling@webkit.org> on 2011-08-30
Reviewed by Darin Adler.

  • html/HTMLImageElement.h: Remove the "ismap" and "usemap" members,

shrinking HTMLImageElement by 16 bytes (on 64-bit.)

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::parseMappedAttribute): Most of the logic
for "ismap" and "usemap" moved into isServerMap().
(WebCore::HTMLImageElement::isServerMap): Out-of-lined and implemented
using fast*Attribute().

05:39 Changeset [94073] by ossy@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt-4.8/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
05:27 Changeset [94072] by ossy@webkit.org
  • 8 edits
    10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip now passing tests.
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/qt/fast/borders/border-fit-2-expected.png: Added.
  • platform/qt/fast/borders/border-fit-2-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
05:18 Changeset [94071] by apavlov@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

REGRESSION(93978): inspector/styles/styles-computed-trace.html fails
https://bugs.webkit.org/show_bug.cgi?id=67185

Reviewed by Yury Semikhatsky.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:
  • platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
05:14 Changeset [94070] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations for userscripts/window-onerror-for-isolated-world-1.html

  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt:
05:04 Changeset [94069] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 3 test started crashing somewhere between r93878-r93935
https://bugs.webkit.org/show_bug.cgi?id=67197

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-08-30

  • platform/qt/Skipped:
04:23 Changeset [94068] by rniwa@webkit.org
  • 7 edits in trunk

lastChangeWasUserEdit continues to return true when innerText or textContent is modified
https://bugs.webkit.org/show_bug.cgi?id=67183

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by calling setLastChangeWasNotUserEdit in HTMLTextAreaElement::childrenChanged.

Also got rid of HTMLTextFormControlElement::subtreeHasChanged because it was a needless indirection.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): No longer calls HTMLTextFormControlElement::subtreeHasChanged.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged): Calls setLastChangeWasNotUserEdit.
(WebCore::HTMLTextAreaElement::subtreeHasChanged): No longer calls HTMLTextFormControlElement::subtreeHasChanged.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::defaultEventHandler): Merged subtreeHasChanged.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): No longer set m_lastChangeWasUserEdit to false
since this is now done when renderers are set dirty.

  • html/HTMLTextFormControlElement.h: Made subtreeHasChanged a pure virtual function.

LayoutTests:

Two test cases now pass.

  • fast/forms/textfield-lastchange-was-useredit-expected.txt:
03:57 Changeset [94067] by yurys@chromium.org
  • 5 edits in trunk

Web Inspector: wrong script display name when there is a slash in its URL query parameters
https://bugs.webkit.org/show_bug.cgi?id=67120

Source/WebCore:

Fixed folder name computation in ScriptsPanel. Now search query is ignored
when searching for the script folder name.

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
03:54 Changeset [94066] by yurys@chromium.org
  • 6 edits in trunk/LayoutTests

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update window.onerror tests after r94061 to match new semantics
of window.onerror return value.

  • fast/workers/resources/shared-worker-script-error.js:
  • http/tests/security/cross-origin-script-window-onerror-redirected.html:
  • http/tests/security/cross-origin-script-window-onerror.html:
  • userscripts/window-onerror-for-isolated-world-1.html:
  • userscripts/window-onerror-for-isolated-world-2.html:
03:25 Changeset [94065] by yurys@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for new test.

  • platform/chromium/fast/events/window-onerror13-expected.txt: Added.
03:05 Changeset [94064] by commit-queue@webkit.org
  • 22 edits in trunk

Unreviewed, rolling out r94055 and r94057.
http://trac.webkit.org/changeset/94055
http://trac.webkit.org/changeset/94057
https://bugs.webkit.org/show_bug.cgi?id=67191

Many failures on Mac 10.5 (Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

Tools:

  • Scripts/webkitpy/thirdparty/init.py:

LayoutTests:

  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py:
02:39 Changeset [94063] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit/efl

[EFL] Add const modifier to passed objects where it's recommended
https://bugs.webkit.org/show_bug.cgi?id=67110

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-30
Reviewed by Kent Tamura.

Add const modifier to passed Evas_Object if the function doesn't change its
property (the most cases to the getter functions).

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_item_list_get):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_custom_get):
(ewk_context_menu_show):

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_text_matches_nth_pos_get):
(ewk_frame_text_selection_type_get):
(ewk_frame_source_get):
(ewk_frame_resources_location_get):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_get):
(ewk_view_imh_get):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_page_cache_get):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_page_rect_get):
(ewk_view_mode_get):

  • ewk/ewk_view.h:
  • ewk/ewk_window_features.cpp:

(ewk_window_features_bool_property_get):
(ewk_window_features_int_property_get):

  • ewk/ewk_window_features.h:
02:36 Changeset [94062] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Qt Linux Release bot has four failed tests.
They are skipped.

Unreviewed gardening.

  • platform/qt/Skipped:
02:28 Changeset [94061] by yurys@chromium.org
  • 18 edits
    1 copy
    1 add in trunk

Return value of window.onerror has inverted semantics
https://bugs.webkit.org/show_bug.cgi?id=67119

Source/WebCore:

Error is now treated as handled only when window.onerror function returns true.

Reviewed by Darin Adler.

Test: fast/events/window-onerror13.html

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

LayoutTests:

Reviewed by Darin Adler.

  • fast/events/window-onerror1.html:
  • fast/events/window-onerror11.html:
  • fast/events/window-onerror12.html:
  • fast/events/window-onerror13-expected.txt: Added.
  • fast/events/window-onerror13.html: Copied from LayoutTests/fast/events/window-onerror11.html.
  • fast/events/window-onerror2.html:
  • fast/events/window-onerror3.html:
  • fast/events/window-onerror4.html:
  • fast/events/window-onerror5.html:
  • fast/events/window-onerror6.html:
  • fast/events/window-onerror8.html:
  • fast/events/window-onerror9.html:
  • fast/workers/resources/worker-script-error-bubbled.js:

(onerror):

  • fast/workers/resources/worker-script-error-handled.js:

(onerror):

  • http/tests/security/window-onerror-exception-in-iframe.html:
02:09 Changeset [94060] by abarth@webkit.org
  • 3 edits in trunk/Tools

Chromium Android should not be a core builder
https://bugs.webkit.org/show_bug.cgi?id=67184

Reviewed by Ryosuke Niwa.

This bot hasn't been consistently green yet because it has never actually run!

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
01:07 Changeset [94059] by tkent@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/rendering/RenderFileUploadControl.cpp

Merge 94045 - REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

  • fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
  • fast/forms/file/disabling-file-busy-loop.html: Added.

TBR=tkent@chromium.org
BUG=94710
Review URL: http://codereview.chromium.org/7792032

01:04 Changeset [94058] by jeremy@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 92809 - Crash when clicking an SVG <a> link to the local document
https://bugs.webkit.org/show_bug.cgi?id=66019
<rdar://problem/9933311>

Reviewed by Rob Buis.

Source/WebCore:

Check if the target element of an internal link is valid before
making use of it.

Test: svg/custom/click-internal-anchor-with-use-crash.xhtml

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add a test which programmatically clicks a link referring to "#",
and should crash between r89745 and this commit.

  • svg/custom/click-internal-anchor-with-use-crash-expected.txt: Added.
  • svg/custom/click-internal-anchor-with-use-crash.xhtml: Added.

TBR=timothy_horton@apple.com
Review URL: http://codereview.chromium.org/7807001

01:02 Changeset [94057] by commit-queue@webkit.org
  • 20 edits in trunk/LayoutTests

[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67182

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

Some layout tests for WebSocket raised Exception to prevent unnecessary
pywebsocket warning. But it doesn't work any more on pywebsocket 0.6b4.
Now pywebsocket support AbortedByUserException to prevent warning.
This change make raise AbortedByUserException instead of Exception.

handshake-fail-by-prepended-null_wsh.py didn't use Exception, but
expected abnormal closure on sending response could raise unexpected
Exception by chance. This change also takes care of it.

  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py:

Use AbortedByUserException instead of Exception.

00:54 Changeset [94056] by rniwa@webkit.org
  • 2 edits in trunk

Cleanup after r94050 and r94054.

  • Source/autotools/symbols.filter:
00:47 Changeset [94055] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.6b4.
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
0.6b3 or later supports a closing handshake handler and it is useful to
verify client's closing handshake implementation.
0.6b4 supports AbortedByUserException. It is useful to eliminate
unnecessary server warning messages on intended abnormal closures.

  • Scripts/webkitpy/thirdparty/init.py:

Update download URL and directory path.

00:43 Changeset [94054] by philn@webkit.org
  • 2 edits in trunk

Unreviewed, another attempt to fix GTK build after r94038.

  • Source/autotools/symbols.filter:

08/29/11:

23:40 Changeset [94053] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Touch Internals.cpp in an attempt to fix GTK+ build.

  • testing/Internals.cpp:
23:37 Changeset [94052] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk/LayoutTests

Fix two layout tests which fails on Qt port with latest pywebsocket.
https://bugs.webkit.org/show_bug.cgi?id=66929

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-29
Reviewed by Kent Tamura.

hanging-handshake_wsh.py read socket to hang in opening handshake.
Then client initiated closing handshakes or abnormal closures caused
exception or resulted in http error response on hybi-10 compliant new
pywebsocket. Because tests finished at closure, it depends on timing
whether tests detects the error response. Actually, two tests failed on
Qt port by chance.
Essentially, hangings is unnecessary because open event must be queued
and WebSocket's readyState could not be changed to OPEN until the next
event loop is executed. That's why we can use echo_wsh.py instead of
hanging-handshake_wsh.py safely.

close-unref-websocket tests call close() before GC. These tests expect
GC cause close event. But close() itself also queues close event.
These close() are redandant. If GC doesn't cause close event, these
tests can pass by close event that close() queues. This change also
remove these redandant close() calls.

  • http/tests/websocket/tests/hixie76/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hybi/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

23:29 Changeset [94051] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Another Windows build fix after r94047.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
23:19 Changeset [94050] by rniwa@webkit.org
  • 2 edits in trunk

Build fix attempt after r94038.

  • Source/autotools/symbols.filter:
23:07 Changeset [94049] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):

22:55 Changeset [94048] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add exception due to missing results for r94037.

  • platform/chromium/test_expectations.txt:
22:51 Changeset [94047] by rniwa@webkit.org
  • 12 edits in trunk/Source/WebCore

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement.

Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement
and related inline functions from RenderTextControl to HTMLTextFormControlElement.
Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated,
added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement
and HTMLTextAreaElement.

This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false
when input or textarea don't have renderer (e.g. invisible).

Unfortunately, there is no way to test this behavioral change from layout tests.

  • WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of

that of HTMLInputElement and HTMLTextAreaElement.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon): Ditto.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true
as it used to do via respondToChangeByUser.
(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Moved from RenderTextControl.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::setLastChangeWasNotUserEdit): Added.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl): No longer initializes m_lastChangeWasUserEdit.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Calls setInnerTextValue.

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::updateFromElement): Ditto.

22:27 Changeset [94046] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed marking skip.

  • platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html
22:22 Changeset [94045] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

  • fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
  • fast/forms/file/disabling-file-busy-loop.html: Added.
22:01 Changeset [94044] by dbates@webkit.org
  • 4 edits in trunk/Source

Add HAVE(VASPRINTF) macro to test for vasprintf() support
https://bugs.webkit.org/show_bug.cgi?id=67156

Reviewed by Darin Adler.

Source/JavaScriptCore:

Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.

  • wtf/Platform.h:

Source/WebCore:

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).

21:57 Changeset [94043] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Minor update for test that is timing out.

  • platform/chromium/test_expectations.txt:
21:51 Changeset [94042] by levin@chromium.org
  • 2 edits
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[chromium] Misc test expectations updates.

  • platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.
  • platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.

Added due to it being different from normal OSX result.

  • platform/chromium/test_expectations.txt: Changes due to expectation update for media-document-audio-repaint.html leading to only an image mismatch and a test that is a slow on OS X as well as Linux and Windows.
20:38 Changeset [94041] by yutak@chromium.org
  • 14 edits
    10 adds in trunk

WebSocket: Receive binary message as Blob
https://bugs.webkit.org/show_bug.cgi?id=67115

Reviewed by Kent Tamura.

Source/WebCore:

Make WebSocketChannel be able to receive WebSocket binary messages and deliver them via
didReceiveBinaryData() callback of WebSocketChannelClient.

Tests: http/tests/websocket/tests/hybi/fragmented-binary-frames.html

http/tests/websocket/tests/hybi/receive-blob.html
http/tests/websocket/tests/hybi/workers/receive-blob.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Convert Blob to JSValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Convert Blob to v8::Value.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

Added DataTypeBlob and Blob-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsBlob):

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):
If binaryType attribute is "blob", construct a Blob using BlobData filled with the given
binary message.

  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):
Create continuousFrameData as OwnPtr<> rather than stack-allocated value so we can easily
pass it to didReceiveBinaryData() callback.
Save the content of a fragmented message even if it is a binary opcode.

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didReceiveBinaryData):

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
Pass binaryData as PassOwnPtr<Vector<char> > to deliver the value efficiently (without
copying the content) across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/binary-frames_wsh.py: Added. Used from receive-blob.html.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames.html:

Added. The content of this test is almost identical to receive-blob.html.

  • http/tests/websocket/tests/hybi/fragmented-binary-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/receive-blob.html:

Added. It is a bit complicated to validate the content of a Blob, because a Blob must be read
asynchronously. FileReader is used to read a blob as an ArrayBuffer, each byte of which is
compared with the expected result.

  • http/tests/websocket/tests/hybi/workers/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/receive-blob.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/binary-frames_wsh.py:

Added. Same as above binary-frames_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/receive-blob.js: Added.
19:29 Changeset [94040] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Export more symbols for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
19:19 Changeset [94039] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit2

Windows build fix for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
19:03 Changeset [94038] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=67173

Reviewed by Darin Adler.

Source/WebCore:

Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.

Test: fast/forms/textfield-lastchange-was-useredit.html

  • testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.

  • fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
  • fast/forms/textfield-lastchange-was-useredit.html: Added.
18:49 Changeset [94037] by macpherson@chromium.org
  • 3 edits
    4 adds in trunk

Implement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67106

Reviewed by Darin Adler.

Tests:
LayoutTests/fast/multicol/inherit-column-values.html
LayoutTests/fast/multicol/initial-column-values.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handler for CSSPropertyWebkitColumns.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementation for CSSPropertyWebkitColumns.

18:43 Changeset [94036] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

sheriffbot "usage" help statements are wrong
https://bugs.webkit.org/show_bug.cgi?id=67170

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
18:43 Changeset [94035] by commit-queue@webkit.org
  • 27 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):

  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
(JSC::Arguments::finishCreation):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::finishCreation):

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
Moved the assignment of m_firstLine and m_lastLine into the
FunctionExecutable::finishCreation() method in Executable.h

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::finishCreation):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::finishCreation):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):

  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::finishCreation):

  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):

  • runtime/ObjectPrototype.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

Source/JavaScriptGlue:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • UserObjectImp.cpp:

(UserObjectImp::UserObjectImp):

Source/WebCore:

No new tests.

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::finishCreation):

  • bindings/js/JSDOMWindowShell.h:
18:29 Changeset [94034] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

[EFL] Add missing API documentation.
https://bugs.webkit.org/show_bug.cgi?id=66927

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-29
Reviewed by Kent Tamura.

Adds missing documentation for ewk_context_menu_item_checked_get/set.
Moves API documentation from cpp to the headers.
Adds brief and file commands for ewk_js.h.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_js.h:
16:47 Changeset [94033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QTouchWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67159

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
16:42 Changeset [94032] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 94001
BUG=91911
Review URL: http://codereview.chromium.org/7795013

16:39 Changeset [94031] by abarth@webkit.org
  • 12 edits in trunk/Tools

Add support for chomium-mac (non-CoreGraphics) baselines
https://bugs.webkit.org/show_bug.cgi?id=67163

Reviewed by Eric Seidel.

This patch teaches the non-CG chromium-mac bots to look at non-CG
baselines. However, the patch still leaves CG as the default set of
baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
16:37 Changeset [94030] by jonlee@apple.com
  • 2 edits in trunk/Websites/webkit.org

Updating forms survey with non-standard wrap for textarea and more data-list driven text fields.

  • projects/forms/survey.html:
16:35 Changeset [94029] by cevans@google.com
  • 2 edits in branches/chromium/835/Source/WebCore/webaudio

Merge 94002
BUG=93978
Review URL: http://codereview.chromium.org/7793016

16:21 Changeset [94028] by imasaki@chromium.org
  • 6 edits
    5 adds in trunk/LayoutTests

[Chromium] Added new rebaselines for media/media-document-audio-repaint.
These are obtained by the rebaseline tool.
https://bugs.webkit.org/show_bug.cgi?id=67070

Reviewed by David Levin.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
16:19 Changeset [94027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
15:54 Changeset [94026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884

Patch by John Bauman <jbauman@chromium.org> on 2011-08-29
Reviewed by Kenneth Russell.

BGRA input is common coming from skia, so optimize BGRA->RGBA
conversion and also avoid the pointless RGBA to RGBA conversion.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doUnpackingAndPacking):

15:53 Changeset [94025] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Fix path to style sheet in fast/events/constructors/event-constructors.html.

Reviewed by Gavin Barraclough.

  • fast/events/constructors/event-constructors.html:
15:52 Changeset [94024] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
https://bugs.webkit.org/show_bug.cgi?id=67099

Reviewed by Simon Fraser.

No new tests. Testing the "fallback to old path" behavior is not easily testable.

  • platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to old path if IOSurface creation path fails.

(WebCore::ImageBuffer::ImageBuffer):

15:51 Changeset [94023] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update results for fast/files/create-blob-url-crash.html to match
exception text.

  • fast/files/create-blob-url-crash-expected.txt:
15:43 Changeset [94022] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93793.

15:41 Changeset [94021] by lforschler@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93717.

15:30 Changeset [94020] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • configure.ac: Update library version.

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • NEWS: Update the news.
14:57 Changeset [94019] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Only enable font smoothing as requested (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=67143

This adjusts LayoutTest pixel output to more closely
match other platforms.

Reviewed by Kenneth Russell.

No new tests. This platform is not yet enabled.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.

14:47 Changeset [94018] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test_expectation.txt typo.

  • platform/chromium/test_expectations.txt:
14:36 Changeset [94017] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Update test expections due to r94006 and r93978.

  • platform/chromium/test_expectations.txt: Add failing test due to r93978.
  • platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and behavior change in r94006.
14:32 Changeset [94016] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

Assertion failure in RenderLayer::computeRepaintRects when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67140

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/scroll-fixed-layer-with-no-visible-content.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeRepaintRects): Fixed style after r93837.

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Tweaked the code
to bail early if our layer has no visible content. This avoids the ASSERT
and also makes sense as we shouldn't repaint / update empty layers.

LayoutTests:

This test checks that a fixed element with no visible content does not ASSERT and
renders properly.

  • fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-no-visible-content.html: Added.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
14:12 Changeset [94015] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r90368

13:59 Changeset [94014] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r86118

13:58 Changeset [94013] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r86116

13:56 Changeset [94012] by mrobinson@webkit.org
  • 14 edits
    2 adds in releases/WebKitGTK/webkit-1.4/Source

Merging r86102

13:47 Changeset [94011] by commit-queue@webkit.org
  • 12 edits
    1 copy
    2 adds in trunk/Source/WebCore

Implement WebVTT Cue Text Parsing rules and DOM construction
https://bugs.webkit.org/show_bug.cgi?id=64132

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-29
Reviewed by Adam Barth.

Tests in media/track, particularly track-webvtt-tc[022 - 028]*.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCue.cpp:
  • html/TextTrackCue.h:
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
  • platform/track/WebVTTParser.cpp:
  • platform/track/WebVTTParser.h:
  • platform/track/WebVTTToken.h: Added.
  • platform/track/WebVTTTokenizer.cpp: Added.
  • platform/track/WebVTTTokenizer.h: Added.
13:32 Changeset [94010] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

Add parsing support for extended attributes on IDL constants
https://bugs.webkit.org/show_bug.cgi?id=65046

Reviewed by Brent Fulgham.

With support for extended attributes on constants we can
replace some preprocessor lines from the IDL files with
the corresponding [Conditional=XXX] later.
Using the preprocessor causes much pain on native windows.

CodeGenerator support will be added in separate patches.

  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
13:18 Changeset [94009] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
https://bugs.webkit.org/show_bug.cgi?id=67141

Reviewed by Eric Seidel.

No new tests since this is a refactoring.

  • dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
  • html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
to avoid the conflict with value().

  • html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
HTMLInputElement.cpp and HTMLTextAreaElement.cpp.

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.

13:16 Changeset [94008] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Small fix in chromium port of new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=67078

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-29
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
13:09 Changeset [94007] by commit-queue@webkit.org
  • 28 edits in trunk

Unreviewed, rolling out r93987, r93992, r93995, r93998, and
r93999.
http://trac.webkit.org/changeset/93987
http://trac.webkit.org/changeset/93992
http://trac.webkit.org/changeset/93995
http://trac.webkit.org/changeset/93998
http://trac.webkit.org/changeset/93999
https://bugs.webkit.org/show_bug.cgi?id=67147

Many failing tests (Requested by ap on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-29

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/CookieJar.mm:

(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/network/CookieStorage.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::privateStorageSession):
(WebCore::privateBrowsingStorageSessionIdentifierBase):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::defaultSessionCookieStorage):
(WebCore::defaultCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
(WebCore::ResourceHandle::currentStorageSession):
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::setCookieStoragePrivateBrowsingEnabled):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

  • WebCookieManagerCFNet.cpp:

(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):

  • WebView.cpp:

(updateSharedSettingsFromPreferencesIfNeeded):

Source/WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

13:06 Changeset [94006] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

As per HTML specification, default font style of dfn tag should be italic.
https://bugs.webkit.org/show_bug.cgi?id=56670

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-29
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/dfn-default-font-style.html

  • css/html.css:

(i, cite, em, var, address, dfn):

LayoutTests:

  • fast/css/dfn-default-font-style-expected.txt: Added.
  • fast/css/dfn-default-font-style.html: Added.
13:03 Changeset [94005] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
https://bugs.webkit.org/show_bug.cgi?id=65040

Reviewed by Brent Fulgham.

JSValueToNative and NativeToJSValue add additional include statements
to the implementation and need to handle the Conditional attribute from
the IDL file. The Conditional attribute adds appropriate #if ENABLE()
lines for the preprocessor around the include statements to remove
some unneeded build dependencies.

  • bindings/scripts/CodeGeneratorJS.pm:
12:35 Changeset [94004] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add ability to do static SerializedScriptValue deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877

Patch by Greg Billock <gbillock@google.com> on 2011-08-29
Reviewed by Darin Fisher.

  • public/WebSerializedScriptValue.h:
  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::serialize):

12:26 Changeset [94003] by japhet@chromium.org
  • 8 edits in trunk/Source/WebCore

Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
https://bugs.webkit.org/show_bug.cgi?id=66018

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::load):

(WebCore::CachedResource::setResourceLoaderOptions):
(WebCore::CachedResource::sendResourceLoadCallbacks):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):

  • loader/cache/CachedResourceRequest.h:
12:23 Changeset [94002] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Fix failures when FFT size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

Test: webaudio/fft-sizing.html

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.

  • webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).

LayoutTests: Fix failures when FFT array size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

  • webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
  • webaudio/realtimeanalyser-fft-sizing.html: Added.
12:19 Changeset [94001] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/line-layout/inline-box-wrapper-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.

LayoutTests:

  • fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
  • fast/block/line-layout/inline-box-wrapper-crash.html: Added.
12:19 Changeset [94000] by mrobinson@webkit.org
  • 3 edits in trunk

Reviewed by Xan Lopez.

[GTK] Build WebKit2 unconditionally
https://bugs.webkit.org/show_bug.cgi?id=62749

Build WebKit2 by default. This will make the bots build it and catch
build errors when they occur.

  • GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2

PC file, which should not be shipped until WebKit2 is actually shipped officially.

12:07 Changeset [93999] by ap@apple.com
  • 4 edits in trunk/Source

Windows build fix.

WebKit/win:

  • WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated for new function name and signature: currentCFHTTPCookieStorage().

WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:59 Changeset [93998] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Lion build fix.

  • WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions of Mac OS X, and need separate exports.
11:54 Changeset [93997] by cmarrin@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixing LayoutTests broken by http://trac.webkit.org/changeset/93980

Unreviewed.


Add Mac specific tests to take into account new requestAnimationFrame functionality

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/mac/fast/dom/prototype-inheritance-expected.txt: Added.
11:53 Changeset [93996] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Implement -webkit-flex-pack for horizontal flexboxen
https://bugs.webkit.org/show_bug.cgi?id=66898

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/004.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::hasPackingSpace):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal):

LayoutTests:

  • css3/flexbox/004-expected.txt: Added.
  • css3/flexbox/004.html: Added.
11:46 Changeset [93995] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/network/cf/CookieJarCFNet.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): (WebCore::getHostnamesWithCookies): (WebCore::deleteCookiesForHostname): (WebCore::deleteAllCookies): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:46 Changeset [93994] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

Update tests after landing Event constructors.

Reviewed by Anders Carlsson.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
11:45 Changeset [93993] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing
after r93988.

  • platform/chromium/test_expectations.txt:
11:34 Changeset [93992] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix.

  • platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN).
11:31 Changeset [93991] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r93990.

  • wtf/HashTable.h:
11:24 Changeset [93990] by andreas.kling@nokia.com
  • 6 edits in trunk/Source

Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.

  • runtime/StructureTransitionTable.h:
  • wtf/HashTable.h:

(WTF::HashTable::shouldShrink):
(WTF::::expand):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

Source/WebCore:

Specialize the HashMap used to store registered listeners on an EventTarget
to have a minimum size of 32 (rather than the default 64.)
It's very rare for pages to register listeners for so many different events
and this cuts memory consumption in half for the common case.

As an example, for a typical post on the reddit.com front page,
this reduces memory used by ~700kB on 64-bit.

  • dom/EventTarget.h:
11:22 Changeset [93989] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Temporary suppression for new test added in r93982.

  • platform/chromium/test_expectations.txt:
11:16 Changeset [93988] by senorblanco@chromium.org
  • 14 edits in trunk/Source/WebCore

Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=67050

Reviewed by Kenneth Russell.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawsContent):
Construct Canvas2DLayerChromium with a GraphicsContext3D, not a
DrawingBuffer.
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
Flush the GrContext and GraphicsContext3D on compositor update.

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

Put textureId() back on the base class (CanvasLayerChromium) and
de-virtualize it.
(WebCore::CanvasLayerChromium::textureId):
(WebCore::CanvasLayerChromium::setTextureId):
Move m_textureId from WebGLLayerChromium, since canvas2D now uses
it too. Provide getters and setters.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
Remove all Canvas2D-related calls from DrawingBuffer.
(WebCore::DrawingBuffer::publishToPlatformLayer):
Remove GrContext::flush call, since it's now handled by the platform layer.
(WebCore::DrawingBuffer::platformLayer):
Return NULL for now (WebGL may rescussitate this later).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

Remove a useless #include.

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add ownership of the Canvas2DLayerChromium.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Remove all texture ID stuff (now on base class).

  • platform/graphics/gpu/DrawingBuffer.h:

Remove Canvas2DLayerChromium and all Ganesh datatypes from
DrawingBuffer, since it's no longer used by canvas2D.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
On accelerated ImageBuffer creation, create a GrTexture instead of a
DrawingBuffer. If all is cool, create and set the SkGpuDevice here,
and create a Canvas2DLayerChromium platform layer.
(WebCore::ImageBuffer::platformLayer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove all GrContext creation and DrawingBuffer "scraping" from
PlatformContextSkia::setGraphicsContext3D(). This is handled in
the ImageBuffer constructor instead.

11:15 Changeset [93987] by ap@apple.com
  • 25 edits in trunk

DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>

Reviewed by Darin Adler.

Use a clean CFURLStorageSession when this functionality is available.

  • WebCore.exp.in: Added exports
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::setCookies): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): Updated for privateBrowsingCookieStorage->currentCFHTTPCookieStorage change.
  • platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.
  • platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp. This file contains cross platform functionality, and we no longer need to put code in it to share it between Mac and Windows.
  • platform/network/ResourceHandle.h: Expose methods to manipulate default session on Mac, too.
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API. (WebCore::overrideCookieStorage): Ditto. (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable, unless it has been overridden on Windows. We can always get it from a session. (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just use private session's storage. Note that Mac has a separate code path for OS versions that don't support sessions.
  • platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK), as this function is also used with NSURLConnection when sessions are enabled. (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session is now supported on Mac, too. (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK). (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer adopt the session, because nothing in method name says that it will steal a reference from the caller. (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK). (WebCore::privateStorageSession): Moved from ResourceHandle.cpp. (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.
  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): We no longer store a reference to cookie storage in a static variable, so nothing to do here. On older OS versiosn, we still need to enable legacy private browsing mode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function.
10:57 Changeset [93986] by levin@chromium.org
  • 12 edits in trunk

postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
https://bugs.webkit.org/show_bug.cgi?id=66713

Reviewed by Dmitry Titov.

Source/WebCore:

See http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages for postMessage

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::getMessagePortArray):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):

LayoutTests:

  • fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
  • fast/events/message-port-multi-expected.txt: Ditto.
  • fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • fast/workers/worker-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.
10:37 Changeset [93985] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 93802
BUG=91973
Review URL: http://codereview.chromium.org/7797001

10:31 Changeset [93984] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Assertion failure in WebCore::RenderFlow::rightmostPosition
https://bugs.webkit.org/show_bug.cgi?id=12085

Reviewed by Alexey Proskuryakov.

The bug got solved. Landed the test to avoid regressing.

  • fast/css/assert-marquee-not-last-element-expected.txt: Added.
  • fast/css/assert-marquee-not-last-element.html: Added.
10:30 Changeset [93983] by podivilov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.

  • platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.
10:14 Changeset [93982] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

canvas arc() missing line to start of arc if swing is zero
https://bugs.webkit.org/show_bug.cgi?id=55696

Source/WebCore:

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Test: fast/canvas/canvas-arc-zero-lineto.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::arc):

LayoutTests:

LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement
https://bugs.webkit.org/show_bug.cgi?id=66832

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the
next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html

  • canvas/philip/tests/2d.path.stroke.prune.arc.html:
  • fast/canvas/canvas-arc-zero-lineto-expected.txt: Added.
  • fast/canvas/canvas-arc-zero-lineto.html: Added.
10:12 Changeset [93981] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixed a build problem caused by http://trac.webkit.org/changeset/93980

Unreviewed.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
09:38 Changeset [93980] by cmarrin@apple.com
  • 44 edits
    1 add in trunk

[mac] requestAnimationFrame support for mac port
https://bugs.webkit.org/show_bug.cgi?id=59146

Reviewed by Simon Fraser.

Source/WebCore:

Enable REQUEST_ANIMATION_FRAME logic and add ScriptedAnimationController
to build. Added JavaScript support for Mac, too.

  • CodeGenerators.pri:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp: Added.

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):

  • dom/RequestAnimationFrameCallback.idl:

Source/WebKit/mac:

Implement requestAnimationFrame for WebKit. Add a
CFRunLoopObserver to WebView, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleAnimation):

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _unscheduleAnimation]):
(-[WebView _scheduleCompositingLayerSync]):
(requestAnimationFrameRunLoopObserverCallback):
(-[WebView _scheduleAnimation]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WebKit2:

Implement requestAnimationFrame for WebKit2. Add a
CFRunLoopObserver to WebPage, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleAnimation):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::requestAnimationFrameRunLoopObserverCallback):
(WebKit::WebPage::scheduleAnimation):
(WebKit::WebPage::unscheduleAnimation):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.cpp:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

Tools:

Add support for request-animation-callback flag

  • Scripts/build-webkit:

LayoutTests:

Enable requestAnimationFrame tests for Mac. Tests were also
modified to work on Mac. Before the tests would assume the
requestAnimationFrame callbacks would be called by calling
LayoutTestController.display(). This is not a valid assumption
for Mac, since it skips display() if nothing was dirty.

Tests were changed to use timeouts to wait for callbacks and
ensure they get called. Also added more positive indications
that test failed or succeeded, rather than relying on the lack
of an error message to indicate success.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-during-modal-expected.txt:
  • fast/animation/request-animation-frame-during-modal.html:
  • fast/animation/request-animation-frame-timestamps.html:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/request-animation-frame-cancel.js:

(window):
(if):

  • fast/animation/script-tests/request-animation-frame-cancel2.js:

(if):

  • fast/animation/script-tests/request-animation-frame-display.js:

(if):

  • fast/animation/script-tests/request-animation-frame-timestamps.js:

(var):

  • fast/animation/script-tests/request-animation-frame-within-callback.js:
  • fast/animation/script-tests/request-animation-frame.js:

(if):

  • platform/mac/Skipped:
09:07 Changeset [93979] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API define in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67123

We could simply use the defines already in place for this.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-29
Reviewed by Andreas Kling.

  • WebKit2.pro:
08:15 Changeset [93978] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: <button hidden>..</button> has a different computed "display" value than "none"
https://bugs.webkit.org/show_bug.cgi?id=67124

Source/WebCore:

Attribute styles have a higher priority than user agent styles and thus should be rendered above them.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:
08:14 Changeset [93977] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=66769

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresenationCallFrame.prototype.sourceLine.didGetUILocation):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.UILocation):

LayoutTests:

  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-file.html:
07:55 Changeset [93976] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The square-button-appearance test is wrong
https://bugs.webkit.org/show_bug.cgi?id=67128

Unreviewed skip until square-button fix on qt-arm.

  • platform/qt-arm/Skipped:
07:14 Changeset [93975] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Zsolt Fehér <feherzs@inf.u-szeged.hu>

Unreviewed Qt gardening.

  • platform/qt/Skipped:
07:11 Changeset [93974] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: cached permanent redirects don't show redirect code and text in Network panel.
https://bugs.webkit.org/show_bug.cgi?id=67126

Reviewed by Yury Semikhatsky.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceResponse):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

05:34 Changeset [93973] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
05:19 Changeset [93972] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: extract FormattedContentProvider from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66938

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
05:03 Changeset [93971] by podivilov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark fast/dom/dom-constructors.html as TEXT in chromium.

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
04:45 Changeset [93970] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
04:36 Changeset [93969] by podivilov@chromium.org
  • 4 edits in trunk

Web Inspector: link UISourceCode to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66944

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get rawSourceCode):

LayoutTests:

  • inspector/debugger/ui-source-code.html:
04:19 Changeset [93968] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing and flaky results after r93937
https://bugs.webkit.org/show_bug.cgi?id=67118

  • platform/qt/Skipped:
02:55 Changeset [93967] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

REGRESSION(r93637) Build break because header file is missing.
https://bugs.webkit.org/show_bug.cgi?id=67113

Unreviewed build fix after r93637.

  • CMakeListsEfl.txt: Add ewk_js.h in EWebKit_HEADERS.
02:35 Changeset [93966] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark overflow-scroll-overlap.html as flaky on chromium gpu.

  • platform/chromium/test_expectations.txt:
02:17 Changeset [93965] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add new chromium mac cg baseline for square-button-appearance added in r93953.

  • platform/chromium-cg-mac-leopard/fast/css/square-button-appearance-expected.png: Added.
02:09 Changeset [93964] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium expectations. Mark frame-removed-during-resize.html and scrollbar-buttons.html
as crashing on win linux debug only.

  • platform/chromium/test_expectations.txt:
02:06 Changeset [93963] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: remove RawSourceCode.setFormatted.
https://bugs.webkit.org/show_bug.cgi?id=66947

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

LayoutTests:

  • inspector/debugger/source-file.html:
01:53 Changeset [93962] by podivilov@chromium.org
  • 3 edits
    2 moves in trunk

Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
https://bugs.webkit.org/show_bug.cgi?id=67030

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/set-breakpoint.html

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

LayoutTests:

  • inspector/debugger/set-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint-expected.txt.
  • inspector/debugger/set-breakpoint.html: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint.html.
01:37 Changeset [93961] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
01:22 Changeset [93960] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] Compilation error in WebKit2 GTK - Revision 93953
https://bugs.webkit.org/show_bug.cgi?id=67111

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-08-29
Reviewed by Martin Robinson.

WebKit2 GTK build error.

  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

Include <WebCore/ResourceError.h> explicitly to remove WebCore::ResourceError
inclusion error.

01:10 Changeset [93959] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark event-constructors.html as failing in chromium.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/test_expectations.txt:
00:40 Changeset [93958] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, adding custom expectation for dom-constructors test in chromium
until bug 66756 is resolved.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Added.
00:34 Changeset [93957] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

fast/canvas/shadow-offset-*.html fail on Leopard/Snow Leopard when removing the work around for <rdar://problem/5539388>.
https://bugs.webkit.org/show_bug.cgi?id=67107

Reviewed by David Levin.

No new tests. Effectively reverting the change from https://bugs.webkit.org/show_bug.cgi?id=67052 for Leopard and SL
because it caused test regressions on Leopard and SL, but not Lion.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

00:16 Changeset [93956] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark scrollbars/scrollbar-buttons.html as crashing in chromium.

  • platform/chromium/test_expectations.txt:
00:07 Changeset [93955] by zherczeg@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unreviewed minimal-build buildfix after r93937.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-29

08/28/11:

23:49 WebKitGtkLayoutTests edited by nayankk@motorola.com
(diff)
23:09 Changeset [93954] by loislo@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/Popover.js

Merge 93868 - Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7778006

20:49 Changeset [93953] by keishi@webkit.org
  • 5 edits
    5 adds in trunk

Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

  • fast/css/square-button-appearance-expected.txt: Added.
  • fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
  • platform/gtk/test_expectations.txt: Added this test as expected to fail.
  • platform/mac/fast/css/square-button-appearance-expected.png: Added.
  • platform/qt/test_expectations.txt: Added this test as expected to fail.
17:26 Changeset [93952] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix reference counting of values in CSSSelector.
https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

  • css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

16:58 Changeset [93951] by weinig@apple.com
  • 12 edits
    5 adds in trunk

Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support. This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add files.

  • bindings/generic/EventConstructors.h: Added.

Add binding agnostic header that defines the Event initializers
using a macro based DSL.

  • bindings/js/JSEventConstructors.cpp: Added.

(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

  • dom/Event.cpp:

(WebCore::EventInit::EventInit):
(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::create):
Add Event initializer interface for base Event.

  • dom/Event.idl:

Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

  • fast/events/constructors/event-constructors-expected.txt: Added.
  • fast/events/constructors/event-constructors.html: Added.
12:24 Changeset [93950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

  • wtf/Platform.h:
12:14 Changeset [93949] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed build fix.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

08/27/11:

15:01 Changeset [93948] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
14:49 Changeset [93947] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

14:31 Changeset [93946] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add a build bot for Chromium with OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:12 Changeset [93945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

14:03 Changeset [93944] by robert@webkit.org
  • 3 edits
    2 adds in trunk

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
13:22 Changeset [93943] by andersca@apple.com
  • 3 edits
    3 adds in trunk

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 Changeset [93942] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 Changeset [93941] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 Changeset [93940] by enne@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

[chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < jamesr@chromium.org> on 2011-08-26
From http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 Changeset [93939] by commit-queue@webkit.org
  • 7 edits in trunk

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 Changeset [93938] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Young Han Lee <joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

04:06 Changeset [93937] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Qt] Need spin-button implementation
https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
00:54 Changeset [93936] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.

08/26/11:

21:42 Changeset [93935] by xji@chromium.org
  • 7 edits
    8 adds in trunk

Regression(91788): Bad cast in WebCore::blockWithNextLineBox
https://bugs.webkit.org/show_bug.cgi?id=66090

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is more like (but not exactly) a revert of r91788.
It does not search for previous or next root inline box in different
render object, which completely eliminates the cause of this issue.
And it removes createPositionAvoidingIgnoredNode(), changed its caller
to use createLegacyEditingPosition(). createPositionAvoidingIgnoredNode
is not correct when node is a replaced element whose caretMaxOffset
could be greater than 1.

Tests: editing/selection/move-by-word-visually-crash-test-1.html

editing/selection/move-by-word-visually-crash-test-2.html
editing/selection/move-by-word-visually-crash-test-3.html
editing/selection/move-by-word-visually-crash-test-4.html

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::leftmostPositionInRTLBoxInLTRBlock):
(WebCore::rightmostPositionInLTRBoxInRTLBlock):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-1-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-1.html: Added.
  • editing/selection/move-by-word-visually-crash-test-2-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-2.html: Added.
  • editing/selection/move-by-word-visually-crash-test-3-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-3.html: Added.
  • editing/selection/move-by-word-visually-crash-test-4-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-4.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/resources/move-by-word-visually.js:

(runMoveLeftRight):

21:19 Changeset [93934] by barraclough@apple.com
  • 8 edits in trunk

DFG JIT - ArithMod may clobber operands.
https://bugs.webkit.org/show_bug.cgi?id=67085

Reviewed by Sam Weinig.

Source/JavaScriptCore:

unboxDouble must be called on a temporary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

LayoutTests:

Added test case.

  • fast/js/mod-crash-expected.txt:
  • fast/js/script-tests/mod-crash.js:

(nonSpeculativeModReuseInner):
(nonSpeculativeModReuse):

20:51 Changeset [93933] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should let me know that I need to run the local server
https://bugs.webkit.org/show_bug.cgi?id=66985

Reviewed by Dimitri Glazkov.

The patch triggers an alert dialog whenever the user tries to use a
feature that requires the local server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
19:15 Changeset [93932] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

Cleanup resulting text of media/track tests.
https://bugs.webkit.org/show_bug.cgi?id=67073

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-26
Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/video-test.js:

(testCues):

18:05 Changeset [93931] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using custom NSErrors for WebKit2 WebErrors
https://bugs.webkit.org/show_bug.cgi?id=67075

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):
(WebKit::cancelledError):
(WebKit::fileDoesNotExistError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
There is no reason to use custom registered NSErrors anymore, so don't.

18:05 Changeset [93930] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Update tests expectations due to r93909 and r93913.

  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium-linux/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:52 Changeset [93929] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
17:41 Changeset [93928] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Add MockWebGraphicsContext3D, for compositor unit testing
https://bugs.webkit.org/show_bug.cgi?id=67006

MockWebGraphicsContext3D is a no-op implementation of the pure virtual
interface WebGraphicsContext3D. I've included a test with a couple of
example usages: subclassing it manually, and using it with GMock.

Patch by Iain Merrick <husky@google.com> on 2011-08-26
Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • tests/MockWebGraphicsContext3D.h: Added.

(WebKit::MockWebGraphicsContext3D::initialize):
(WebKit::MockWebGraphicsContext3D::makeContextCurrent):
(WebKit::MockWebGraphicsContext3D::width):
(WebKit::MockWebGraphicsContext3D::height):
(WebKit::MockWebGraphicsContext3D::reshape):
(WebKit::MockWebGraphicsContext3D::isGLES2Compliant):
(WebKit::MockWebGraphicsContext3D::readBackFramebuffer):
(WebKit::MockWebGraphicsContext3D::getPlatformTextureId):
(WebKit::MockWebGraphicsContext3D::prepareTexture):
(WebKit::MockWebGraphicsContext3D::synthesizeGLError):
(WebKit::MockWebGraphicsContext3D::isContextLost):
(WebKit::MockWebGraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::getRequestableExtensionsCHROMIUM):
(WebKit::MockWebGraphicsContext3D::requestExtensionCHROMIUM):
(WebKit::MockWebGraphicsContext3D::blitFramebufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::renderbufferStorageMultisampleCHROMIUM):
(WebKit::MockWebGraphicsContext3D::activeTexture):
(WebKit::MockWebGraphicsContext3D::attachShader):
(WebKit::MockWebGraphicsContext3D::bindAttribLocation):
(WebKit::MockWebGraphicsContext3D::bindBuffer):
(WebKit::MockWebGraphicsContext3D::bindFramebuffer):
(WebKit::MockWebGraphicsContext3D::bindRenderbuffer):
(WebKit::MockWebGraphicsContext3D::bindTexture):
(WebKit::MockWebGraphicsContext3D::blendColor):
(WebKit::MockWebGraphicsContext3D::blendEquation):
(WebKit::MockWebGraphicsContext3D::blendEquationSeparate):
(WebKit::MockWebGraphicsContext3D::blendFunc):
(WebKit::MockWebGraphicsContext3D::blendFuncSeparate):
(WebKit::MockWebGraphicsContext3D::bufferData):
(WebKit::MockWebGraphicsContext3D::bufferSubData):
(WebKit::MockWebGraphicsContext3D::checkFramebufferStatus):
(WebKit::MockWebGraphicsContext3D::clear):
(WebKit::MockWebGraphicsContext3D::clearColor):
(WebKit::MockWebGraphicsContext3D::clearDepth):
(WebKit::MockWebGraphicsContext3D::clearStencil):
(WebKit::MockWebGraphicsContext3D::colorMask):
(WebKit::MockWebGraphicsContext3D::compileShader):
(WebKit::MockWebGraphicsContext3D::copyTexImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::cullFace):
(WebKit::MockWebGraphicsContext3D::depthFunc):
(WebKit::MockWebGraphicsContext3D::depthMask):
(WebKit::MockWebGraphicsContext3D::depthRange):
(WebKit::MockWebGraphicsContext3D::detachShader):
(WebKit::MockWebGraphicsContext3D::disable):
(WebKit::MockWebGraphicsContext3D::disableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::drawArrays):
(WebKit::MockWebGraphicsContext3D::drawElements):
(WebKit::MockWebGraphicsContext3D::enable):
(WebKit::MockWebGraphicsContext3D::enableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::finish):
(WebKit::MockWebGraphicsContext3D::flush):
(WebKit::MockWebGraphicsContext3D::framebufferRenderbuffer):
(WebKit::MockWebGraphicsContext3D::framebufferTexture2D):
(WebKit::MockWebGraphicsContext3D::frontFace):
(WebKit::MockWebGraphicsContext3D::generateMipmap):
(WebKit::MockWebGraphicsContext3D::getActiveAttrib):
(WebKit::MockWebGraphicsContext3D::getActiveUniform):
(WebKit::MockWebGraphicsContext3D::getAttachedShaders):
(WebKit::MockWebGraphicsContext3D::getAttribLocation):
(WebKit::MockWebGraphicsContext3D::getBooleanv):
(WebKit::MockWebGraphicsContext3D::getBufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getContextAttributes):
(WebKit::MockWebGraphicsContext3D::getError):
(WebKit::MockWebGraphicsContext3D::getFloatv):
(WebKit::MockWebGraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebKit::MockWebGraphicsContext3D::getIntegerv):
(WebKit::MockWebGraphicsContext3D::getProgramiv):
(WebKit::MockWebGraphicsContext3D::getProgramInfoLog):
(WebKit::MockWebGraphicsContext3D::getRenderbufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getShaderiv):
(WebKit::MockWebGraphicsContext3D::getShaderInfoLog):
(WebKit::MockWebGraphicsContext3D::getShaderSource):
(WebKit::MockWebGraphicsContext3D::getString):
(WebKit::MockWebGraphicsContext3D::getTexParameterfv):
(WebKit::MockWebGraphicsContext3D::getTexParameteriv):
(WebKit::MockWebGraphicsContext3D::getUniformfv):
(WebKit::MockWebGraphicsContext3D::getUniformiv):
(WebKit::MockWebGraphicsContext3D::getUniformLocation):
(WebKit::MockWebGraphicsContext3D::getVertexAttribfv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribiv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribOffset):
(WebKit::MockWebGraphicsContext3D::hint):
(WebKit::MockWebGraphicsContext3D::isBuffer):
(WebKit::MockWebGraphicsContext3D::isEnabled):
(WebKit::MockWebGraphicsContext3D::isFramebuffer):
(WebKit::MockWebGraphicsContext3D::isProgram):
(WebKit::MockWebGraphicsContext3D::isRenderbuffer):
(WebKit::MockWebGraphicsContext3D::isShader):
(WebKit::MockWebGraphicsContext3D::isTexture):
(WebKit::MockWebGraphicsContext3D::lineWidth):
(WebKit::MockWebGraphicsContext3D::linkProgram):
(WebKit::MockWebGraphicsContext3D::pixelStorei):
(WebKit::MockWebGraphicsContext3D::polygonOffset):
(WebKit::MockWebGraphicsContext3D::readPixels):
(WebKit::MockWebGraphicsContext3D::releaseShaderCompiler):
(WebKit::MockWebGraphicsContext3D::renderbufferStorage):
(WebKit::MockWebGraphicsContext3D::sampleCoverage):
(WebKit::MockWebGraphicsContext3D::scissor):
(WebKit::MockWebGraphicsContext3D::shaderSource):
(WebKit::MockWebGraphicsContext3D::stencilFunc):
(WebKit::MockWebGraphicsContext3D::stencilFuncSeparate):
(WebKit::MockWebGraphicsContext3D::stencilMask):
(WebKit::MockWebGraphicsContext3D::stencilMaskSeparate):
(WebKit::MockWebGraphicsContext3D::stencilOp):
(WebKit::MockWebGraphicsContext3D::stencilOpSeparate):
(WebKit::MockWebGraphicsContext3D::texImage2D):
(WebKit::MockWebGraphicsContext3D::texParameterf):
(WebKit::MockWebGraphicsContext3D::texParameteri):
(WebKit::MockWebGraphicsContext3D::texSubImage2D):
(WebKit::MockWebGraphicsContext3D::uniform1f):
(WebKit::MockWebGraphicsContext3D::uniform1fv):
(WebKit::MockWebGraphicsContext3D::uniform1i):
(WebKit::MockWebGraphicsContext3D::uniform1iv):
(WebKit::MockWebGraphicsContext3D::uniform2f):
(WebKit::MockWebGraphicsContext3D::uniform2fv):
(WebKit::MockWebGraphicsContext3D::uniform2i):
(WebKit::MockWebGraphicsContext3D::uniform2iv):
(WebKit::MockWebGraphicsContext3D::uniform3f):
(WebKit::MockWebGraphicsContext3D::uniform3fv):
(WebKit::MockWebGraphicsContext3D::uniform3i):
(WebKit::MockWebGraphicsContext3D::uniform3iv):
(WebKit::MockWebGraphicsContext3D::uniform4f):
(WebKit::MockWebGraphicsContext3D::uniform4fv):
(WebKit::MockWebGraphicsContext3D::uniform4i):
(WebKit::MockWebGraphicsContext3D::uniform4iv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix2fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix3fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix4fv):
(WebKit::MockWebGraphicsContext3D::useProgram):
(WebKit::MockWebGraphicsContext3D::validateProgram):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4fv):
(WebKit::MockWebGraphicsContext3D::vertexAttribPointer):
(WebKit::MockWebGraphicsContext3D::viewport):
(WebKit::MockWebGraphicsContext3D::createBuffer):
(WebKit::MockWebGraphicsContext3D::createFramebuffer):
(WebKit::MockWebGraphicsContext3D::createProgram):
(WebKit::MockWebGraphicsContext3D::createRenderbuffer):
(WebKit::MockWebGraphicsContext3D::createShader):
(WebKit::MockWebGraphicsContext3D::createTexture):
(WebKit::MockWebGraphicsContext3D::deleteBuffer):
(WebKit::MockWebGraphicsContext3D::deleteFramebuffer):
(WebKit::MockWebGraphicsContext3D::deleteProgram):
(WebKit::MockWebGraphicsContext3D::deleteRenderbuffer):
(WebKit::MockWebGraphicsContext3D::deleteShader):
(WebKit::MockWebGraphicsContext3D::deleteTexture):

  • tests/MockWebGraphicsContext3DTest.cpp: Added.

(TEST):
(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):

17:38 Changeset [93927] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson <jamesr@chromium.org> on 2011-08-26
Reviewed by Kenneth Russell.

Fix a number of reference cycle leaks that prevent LayerRendererChromiums from being destroyed when a tab is
closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):

17:23 Changeset [93926] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

garden-o-matic summary view should have pretty commit data information.
https://bugs.webkit.org/show_bug.cgi?id=67069

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
16:44 Changeset [93925] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67063

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(+[NSError _webkit_errorWithDomain:code:URL:]):

16:42 Changeset [93924] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update tests expectations due to r93909.

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
16:31 Changeset [93923] by japhet@chromium.org
  • 13 edits in trunk/Source/WebCore

Move allowCredentials from ThreadableLoaderOptions down
to ResourceLoaderOptions. This allows us to remove
getShouldUseCredentialStorage() from SubresourceLoaderClient
and check allowCredentials in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refractor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldUseCredentialStorage): Check

m_options.allowCredentials instead of calling a client.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
15:55 Changeset [93922] by levin@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Update tests expectations due to r93913.

  • platform/chromium-cg-mac/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium-win/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Added.
15:40 Changeset [93921] by ojan@chromium.org
  • 7 edits in trunk

change the default preferred width of the flex() function to 0px per the new spec
https://bugs.webkit.org/show_bug.cgi?id=67067

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/001.html:
  • css3/flexbox/002.html:
  • css3/flexbox/flex-parsing-expected.txt:
  • css3/flexbox/script-tests/flex-parsing.js:
15:32 Changeset [93920] by commit-queue@webkit.org
  • 13 edits in trunk/Source/JavaScriptCore

Unzip initialization lists and constructors in JSCell hierarchy (2/7)
https://bugs.webkit.org/show_bug.cgi?id=66957

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-26
Reviewed by Darin Adler.

Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):

15:26 Changeset [93919] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

Remove offset hack from GraphicsContextCG setShadow code
https://bugs.webkit.org/show_bug.cgi?id=67052

Reviewed by Simon Fraser.

No new tests - current tests cover it.

  • platform/graphics/cg/GraphicsContextCG.cpp:

Removing the offset hack introduced in http://trac.webkit.org/changeset/28714
for an issue with offsets in an old version of CoreGraphics that's long since been fixed.

15:23 Changeset [93918] by fpizlo@apple.com
  • 13 edits
    2 adds in trunk/Source/JavaScriptCore

The GC does not have a facility for profiling the kinds of objects
that occupy the heap
https://bugs.webkit.org/show_bug.cgi?id=66849

Reviewed by Geoffrey Garen.

Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.

(JSC::Heap::destroy):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

  • heap/MarkedBlock.h:
  • heap/VTableSpectrum.cpp: Added.

(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h: Added.
  • wtf/Platform.h:
15:20 Changeset [93917] by dglazkov@chromium.org
  • 3 edits in trunk/Tools

Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=67066

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
15:18 Changeset [93916] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Rebasing media/video-layer-crash & media/video-transformed images.
https://bugs.webkit.org/show_bug.cgi?id=67065

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-26
Reviewed by David Levin.

  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
14:46 Changeset [93915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update topCallFrame when calling host functions in the JIT
https://bugs.webkit.org/show_bug.cgi?id=67010

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-26
Reviewed by Oliver Hunt.

The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (https://bugs.webkit.org/show_bug.cgi?id=66994).

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

14:41 Changeset [93914] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
https://bugs.webkit.org/show_bug.cgi?id=67041

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Martin Robinson.

This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
PixelDumpSupportCairo.h, but the latter was #including cairo.h only
when the GTK+ port was being built.

  • DumpRenderTree/cairo/PixelDumpSupportCairo.h:
14:40 Changeset [93913] by ap@apple.com
  • 17 edits
    2 adds in trunk

Get rid of frame life support timer
https://bugs.webkit.org/show_bug.cgi?id=66874

Reviewed by Geoff Garen. V8 fixes courtesy of Dmitry Titov.

Test: fast/frames/detached-frame-property.html

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page): Removed all code that dealt with the life support timer. Protect Frame inside runScript() and callFunction() for v8 bindings.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): Replaced ref/deref calls on self with a RefPtr.
14:36 Changeset [93912] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
https://bugs.webkit.org/show_bug.cgi?id=67062

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_ScheduleTimer):
Call NetscapePlugin::scheduleTimer.

(WebKit::NPN_UnscheduleTimer):
Call NetscapePlugin::unscheduleTimer.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_nextTimerID.

(WebKit::NetscapePlugin::Timer::start):
Start the timer.

(WebKit::NetscapePlugin::Timer::stop):
Stop the timer.

(WebKit::NetscapePlugin::Timer::timerFired):
Call the right callback and unschedule the timer object if it's not a repeating timer.

(WebKit::NetscapePlugin::scheduleTimer):
Create a new timer and start it.

(WebKit::NetscapePlugin::unscheduleTimer):
Get the timer from the map and destroy it.

(WebKit::NetscapePlugin::destroy):
Destroy all timers.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add Timer class.

14:36 Changeset [93911] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/js/const.html is opening a modal print dialog, leading to a timeout on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=67061

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-08-26
Reviewed by Oliver Hunt.

Update this test to remove inadvertant calls to window.print().

  • fast/js/resources/const.js:

(tryCatch1): Remove call to window.print()
(tryCatch2): Ditto.

13:47 Changeset [93910] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=67046

Patch by Chao-ying Fu <fu@mips.com> on 2011-08-26
Reviewed by Gavin Barraclough.

  • jit/JIT.h:
13:43 Changeset [93909] by mitz@apple.com
  • 3 edits
    3 adds in trunk

RenderText::computePreferredLogicalWidths() should measure words with trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=66733

Source/WebCore:

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-08-26
Reviewed by Dan Bernstein.

Test: fast/text/complex-preferred-logical-widths.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Apply logic from RenderBlock::LineBreaker::nextLineBreak().

LayoutTests:

  • fast/text/complex-preferred-logical-widths.html: Added.
  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
13:42 Changeset [93908] by tony@chromium.org
  • 15 edits in trunk

Add CSS parsing for -webkit-flex-align
https://bugs.webkit.org/show_bug.cgi?id=66726

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexAlign):
(WebCore::InheritedFlags::setFlexAlign):
(WebCore::InheritedFlags::initialFlexAlign):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
13:41 Changeset [93907] by japhet@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <japhet@chromium.org>

Fix http/tests/misc/willCacheResponse-delegate-callback.html
after r93886. We're implicitly converting an enum to a bool.

Rubber-stamped by David Levin.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse):
13:38 Changeset [93906] by dglazkov@chromium.org
  • 11 edits in trunk/Tools

Clean up and line up layout in garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=67057

1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2) Rearranged DOM structure a bit to accommodate recent changes;
3) Added minimal CSS to line things up.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
13:37 Changeset [93905] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in Connection.cpp
https://bugs.webkit.org/show_bug.cgi?id=67060

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):
We want timedOut, not timeout. There is not a current way to cause this
to be an issue. This issue was caught by the Clang Static Analyzer.

13:05 Changeset [93904] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Skip two tests on GTK+ that are failing due to known issues.

  • platform/gtk/Skipped: Update the skipped list.
12:29 Changeset [93903] by crogers@google.com
  • 14 edits in trunk

Add MediaPlayer::audioSourceProvider() method for audio stream access by the Web Audio API.
https://bugs.webkit.org/show_bug.cgi?id=66398

Reviewed by Eric Carlson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::ensureMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

MediaPlayer creation has now been put into createMediaPlayer() instead of it being created
separately in these various methods. It has been made thread-safe for use with the Web Audio API
in conjunction with an MediaElementAudioSourceNode.

(WebCore::HTMLMediaElement::setAudioSourceNode):
(WebCore::HTMLMediaElement::audioSourceProvider):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::audioSourceNode):

The HTMLMediaElement now keeps track of an optional MediaElementAudioSourceNode if
the audio stream is being processed using the Web Audio API.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::audioSourceProvider):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::audioSourceProvider):

MediaPlayer now has an audioSourceProvider() method with a default "empty" implementation.
audioSourceProvider() returns an AudioSourceProvider object which the Web Audio API's
MediaElementAudioSourceNode uses (indirectly through an HTMLMediaElement method) to get the rendered audio stream.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:

AudioContext::createMediaElementSource() is now more careful to check that an HTMLMediaElement
doesn't already have a MediaElementAudioSourceNode attached to it.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::~MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • webaudio/MediaElementAudioSourceNode.h:

Implement thread-safe processing (replacing the old stub implementation).

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt:
  • webaudio/mediaelementaudiosourcenode.html:
12:23 Changeset [93902] by alice.liu@apple.com
  • 16 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=66823
Add the request info to the WebPageProxy::CreateNewPage message

Reviewed by Anders Carlsson.

Source/WebKit2:

Update function declarations with additional ResourceRequest parameter:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):
Pass the ResourceRequest within the FrameLoadRequest.

Tools:

Update function declarations with additional parameter:

  • MiniBrowser/gtk/BrowserWindow.c:

(createNewPage):

  • MiniBrowser/mac/BrowserWindowController.m:

(createNewPage):

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):

  • WebKitTestRunner/TestController.h:
12:11 Changeset [93901] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

Assertion fires if canvas is resized while save() active
https://bugs.webkit.org/show_bug.cgi?id=66710

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/resize-while-save-active.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Call CanvasRenderingContext2D::reset() before resizing the canvas,
so that the GraphicsContext state stack can be unwound.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Refactor the state stack unwinding code from the destructor to
unwindStateStack() (new).
(WebCore::CanvasRenderingContext2D::reset):
Unwind the GraphicsContext state stack when the context is reset.

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/resize-while-save-active-expected.txt: Added.
  • fast/canvas/resize-while-save-active.html: Added.
11:59 Changeset [93900] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Use the progress cursor instead of the wristwatch for CSS "wait" cursor
https://bugs.webkit.org/show_bug.cgi?id=67049

Reviewed by Beth Dakin.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use BusyButClickable cursor for wait
as well as for Progress.

11:41 Changeset [93899] by japhet@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <japhet@chromium.org>

Fix gtk build after r93886.

  • platform/track/CueParser.cpp: (WebCore::CueParser::load):
11:31 Changeset [93898] by mrobinson@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Add some new baselines for GTK+ and unskip tests that now have them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
11:24 Changeset [93897] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]REGRESSION(r93784): It made many tests crash
https://bugs.webkit.org/show_bug.cgi?id=66958

Reviewed by Anders Carlsson.

Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::~QtWebPageProxy):

11:23 Changeset [93896] by mrobinson@webkit.org
  • 1 edit
    190 adds in trunk/LayoutTests

Import the last set of GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xml: Import the last set of results.
11:15 Changeset [93895] by mrobinson@webkit.org
  • 1 edit
    201 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector test results.

  • platform/gtk/css3/selectors3/xml: Import the next set of results.
11:08 Changeset [93894] by mrobinson@webkit.org
  • 1 edit
    202 adds in trunk/LayoutTests

Begin importing the last directory of CSS3 selector results for GTK+.

  • platform/gtk/css3/selectors3/xml: Import the first set of files in this directory.
11:07 Changeset [93893] by commit-queue@webkit.org
  • 3 edits in trunk

WebViewImpl::selectionRange should return range in the right order.
https://bugs.webkit.org/show_bug.cgi?id=66973

Patch by Varun Jain <varunjain@google.com> on 2011-08-26
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
11:04 Changeset [93892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Update searchableIndexIntroduction() to match GTK+'s.
https://bugs.webkit.org/show_bug.cgi?id=66885

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Using this new string allows us to share the test expectations with
other ports, and thus makes
fast/replaced/table-percent-height-text-controls.html pass.

No new tests, as this is covered by an existing one.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::searchableIndexIntroduction):

10:59 Changeset [93891] by vrk@chromium.org
  • 1 edit
    105 adds in trunk/LayoutTests

Unreviewed; adding files missing from r93885.

  • media/track/captions-webvtt/tc000-empty.vtt: Added.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Added.
  • media/track/captions-webvtt/tc001-utf8.vtt: Added.
  • media/track/captions-webvtt/tc002-bom.vtt: Added.
  • media/track/captions-webvtt/tc003-newlines.vtt: Added.
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Added.
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Added.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Added.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Added.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Added.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Added.
  • media/track/captions-webvtt/tc011-cues.vtt: Added.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Added.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Added.
  • media/track/captions-webvtt/tc013-settings.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
10:59 Changeset [93890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not log an error if a fallback cursor cannot be found.
https://bugs.webkit.org/show_bug.cgi?id=67037

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Ecore_X does not necessarily have to be used (DumpRenderTree does not
use it, for example), so showing an error message here is bogus.

No new tests, as it just removes erroneous error messages from
when running DRT with existing tests.

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

10:53 Changeset [93889] by mrobinson@webkit.org
  • 1 edit
    593 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xhtml: Import this directory.
10:48 Changeset [93888] by mrobinson@webkit.org
  • 1 edit
    346 adds in trunk/LayoutTests

Begin importing CSS3 selector test results for GTK+.

  • platform/gtk/css3/selectors3/html: Import this directory.
10:45 Changeset [93887] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix handling of keyup events in the new Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67045

Reviewed by Sam Weinig.

Use a counter instead of a boolean for deciding when to ignore keyup events, because
if multiple keys are pressed simultaneously then we need to ignore more than one keyup event in a row.

Also if a keyboard event is an autorepeating event we won't get a keyup event so don't increment the counter
in that case.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

10:41 Changeset [93886] by japhet@chromium.org
  • 32 edits in trunk/Source

Source/WebCore: Change a bunch of nondescript bools to
descriptive enums in ResourceLoaderOptions and
ThreadableLoaderOptions.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

No new tests, no functionality change intended.

  • WebCore.exp.in:
  • fileapi/FileReaderLoader.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.cpp:
  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • page/EventSource.cpp:
  • platform/network/ResourceHandle.h:
  • workers/WorkerScriptLoader.cpp:
  • xml/XMLHttpRequest.cpp:

Source/WebKit/chromium: Use enums instead of bools for ThreadableLoaderOptions
variables.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

10:21 Changeset [93885] by vrk@chromium.org
  • 11 edits
    43 deletes in trunk/LayoutTests

Tests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
https://bugs.webkit.org/show_bug.cgi?id=65884

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-25
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/tc000-empty.vtt: Renamed from media/track/captions/tc000_empty.vtt.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Renamed from media/track/captions/tc001_iso2022jp3.vtt.
  • media/track/captions-webvtt/tc001-utf8.vtt: Renamed from media/track/captions/tc001_utf8.vtt.
  • media/track/captions-webvtt/tc002-bom.vtt: Renamed from media/track/captions/tc002_bom.vtt.
  • media/track/captions-webvtt/tc003-newlines.vtt: Renamed from media/track/captions/tc003_newlines.vtt
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Renamed from media/track/captions/tc003_nonewlineateof.vtt
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Renamed from media/track/captions/tc004_nowebvtt.vtt.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Renamed from media/track/captions/tc004_webvttfile.vtt.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Renamed from media/track/captions/tc004_webvttrubbish.vtt.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Renamed from media/track/captions/tc005_defaultstyles.vtt.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Renamed from media/track/captions/tc005_metadataarea.vtt.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Renamed from media/track/captions/tc006_cueiderror.vtt.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Renamed from media/track/captions/tc006_cueid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Renamed from media/track/captions/tc007_cuenoid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Renamed from media/track/captions/tc007_cuenoiderror.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Renamed from media/track/captions/tc008_timingsnohourerrors.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Renamed from media/track/captions/tc008_timingsnohour.vtt.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Renamed from media/track/captions/tc009_timingshourerror.vtt.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Renamed from media/track/captions/tc009_timingshour.vtt.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Renamed from media/track/captions/tc010_notimings.vtt.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Copied from media/track/captions/tc011_cuesnosep.vtt.
  • media/track/captions-webvtt/tc011-cues.vtt: Renamed from media/track/captions/tc011_cues.vtt.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Renamed from media/track/captions/tc012_outoforder.vtt.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Renamed from media/track/captions/tc013_settingsbadsep.vtt.
  • media/track/captions-webvtt/tc013-settings.vtt: Renamed from media/track/captions/tc013_settings.vtt.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Renamed from media/track/track-webvtt-tc004-magicheader-expected.txt.
  • media/track/track-webvtt-tc004-magic-header.html: Renamed from media/track/track-webvtt-tc004-magicheader.html.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Renamed from media/track/track-webvtt-tc005-headercomment-expected.txt.
  • media/track/track-webvtt-tc005-header-comment.html: Renamed from media/track/track-webvtt-tc005-headercomment.html.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Renamed from media/track/track-webvtt-tc006-cueidentifiers-expected.txt.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Renamed from media/track/track-webvtt-tc006-cueidentifiers.html.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Renamed from media/track/track-webvtt-tc007-cuenoid-expected.txt.
  • media/track/track-webvtt-tc007-cue-no-id.html: Renamed media/track/track-webvtt-tc007-cuenoid.html.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Renamed from media/track/track-webvtt-tc008-timingsnohours-expected.txt.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Renamed from media/track/track-webvtt-tc008-timingsnohours.html.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Renamed from media/track/track-webvtt-tc009-timingshour-expected.txt.
  • media/track/track-webvtt-tc009-timings-hour.html: Renamed from media/track/track-webvtt-tc009-timingshour.html.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Copied from media/track/track-webvtt-tc010-notimings-expected.txt.
  • media/track/track-webvtt-tc010-no-timings.html: Renamed from media/track/track-webvtt-tc012-outoforder.html.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Renamed from media/track/track-webvtt-tc011-blanklines-expected.txt.
  • media/track/track-webvtt-tc011-blank-lines.html: Renamed from media/track/track-webvtt-tc011-blanklines.html.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Renamed from media/track/track-webvtt-tc012-outoforder-expected.txt.
  • media/track/track-webvtt-tc012-out-of-order.html: Copied from media/track/track-webvtt-tc000-empty.html.
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
  • media/video-test.js:

(testCues):
(allTestsEnded):

10:19 Changeset [93884] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
https://bugs.webkit.org/show_bug.cgi?id=67040

Reviewed by Darin Adler.

  • html/HTMLMetaElement.h: Remove m_equiv and m_content members,

shrinking HTMLMetaElement by 16 bytes (on 64-bit.)

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseMappedAttribute):
(WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().

10:17 Changeset [93883] by cevans@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/rendering

Merge 93794
BUG=93587
Review URL: http://codereview.chromium.org/7753041

09:57 Changeset [93882] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

09:26 Changeset [93881] by podivilov@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r93870.
http://trac.webkit.org/changeset/93870
https://bugs.webkit.org/show_bug.cgi?id=65203

Broke i18n chromium tests

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
09:15 Changeset [93880] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Gut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
https://bugs.webkit.org/show_bug.cgi?id=66979.

Removing the function altogether would break the nightlies.
This patch removes the code behind it so that it is clear that
WKPageCreateSnapshotOfVisibleContent should not be used, and so that the code isn't just
left rotting in the tree.

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-26
Reviewed by Brian Weinstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCreateSnapshotOfVisibleContent):
Return 0.

  • UIProcess/API/C/WKPagePrivate.h:

Update the comment and add a link to the bug.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
08:29 Changeset [93879] by commit-queue@webkit.org
  • 3 edits in trunk/Source

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Also roll Chromium revision to 98101, to include dependency: http://codereview.chromium.org/7714036/

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-26
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

08:14 Changeset [93878] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

<video> playlist can not advance when playing in background tab
https://bugs.webkit.org/show_bug.cgi?id=66978

Reviewed by Darin Adler.

No new tests added because it isn't possible to simulate a background tab in DRT.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
(WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever

allowed a file to load.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
(WebCore::HTMLMediaElement::removeBehaviorRestriction): New.

08:06 Changeset [93877] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

Removing some tests from the GTK+ skipped lists that have results now
or no longer exist.

  • platform/gtk/Skipped: Clean up.
  • platform/gtk/test_expectations.txt: Ditto.
07:57 Changeset [93876] by andreas.kling@nokia.com
  • 14 edits in trunk/LayoutTests

Rebaseline Qt (4.7) after r93873.

  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
07:06 Changeset [93875] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
07:02 Changeset [93874] by philn@webkit.org
  • 1 edit
    18 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
06:35 Changeset [93873] by andreas.kling@nokia.com
  • 30 edits in trunk

[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Reviewed by Benjamin Poulain.

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

LayoutTests:

Rebaseline SVG tests after Path::boundingRect() change.
This brings Qt quite a bit closer to CG and Skia metrics.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-4.8/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/qt/svg/custom/animate-path-morphing-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
  • platform/qt/svg/custom/second-inline-text-expected.txt:
  • platform/qt/svg/custom/use-nested-transform-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/shapes/path/001-expected.txt:
06:22 Changeset [93872] by philn@webkit.org
  • 77 edits in trunk/LayoutTests

Unreviewed, another rebaseline after switch to GTK+3.x.

  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
06:15 Changeset [93871] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

add a state enumeration to track down cause of null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=66939

Reviewed by Alexey Proskuryakov.

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I
have a bug I cannot reproduce. I added an earlier crash in
https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
gotten many good stacks, all coming in through a failed request that
eventually calls notifyFinished() on a ScriptElement with a NULL
m_cachedScript.

I'd like to know how this got NULL. This enumeration should let
me find that in stack dumps from reproductions.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
06:12 Changeset [93870] by reed@google.com
  • 9 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
05:50 Changeset [93869] by podivilov@chromium.org
  • 63 edits
    17 moves
    8 deletes in trunk/LayoutTests

2011-08-26 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium fast/borders/* tests.

  • fast/borders/borderRadiusArcs01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusArcs01-expected.txt.
  • fast/borders/borderRadiusDashed02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed02-expected.txt.
  • fast/borders/borderRadiusDashed03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed03-expected.txt.
  • fast/borders/borderRadiusDotted01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDotted01-expected.txt.
  • fast/borders/borderRadiusDouble01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble01-expected.txt.
  • fast/borders/borderRadiusDouble02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble02-expected.txt.
  • fast/borders/borderRadiusDouble03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble03-expected.txt.
  • fast/borders/borderRadiusGroove01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove01-expected.txt.
  • fast/borders/borderRadiusGroove02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove02-expected.txt.
  • fast/borders/borderRadiusInset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusInset01-expected.txt.
  • fast/borders/borderRadiusOutset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusOutset01-expected.txt.
  • fast/borders/borderRadiusRidge01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusRidge01-expected.txt.
  • fast/borders/borderRadiusSolid01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid01-expected.txt.
  • fast/borders/borderRadiusSolid02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid02-expected.txt.
  • fast/borders/borderRadiusSolid03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid03-expected.txt.
  • fast/borders/borderRadiusSolid04-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid04-expected.txt.
  • fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted01-expected.txt: Removed.
  • platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
05:32 Changeset [93868] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

05:28 Changeset [93867] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Minor style fix in the sample code for WebKitWebFrame.

  • webkit/webkitwebframe.cpp:
04:31 Changeset [93866] by philn@webkit.org
  • 24 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some svg tests after switch to
GTK+-3.x.

  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
04:24 Changeset [93865] by philn@webkit.org
  • 56 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some fast/ tests after switch to
GTK+-3.x.

  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
04:19 Changeset [93864] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Not reviewed. Unskip this test on Qt, it's fixed now.

  • platform/qt/Skipped:
04:10 Changeset [93863] by philn@webkit.org
  • 11 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline of some editing tests after switch to
GTK+-3.x.

  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Added.
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
03:02 Changeset [93862] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Reviewed by Zoltan Herczeg.

Fix intrinsic size negotiation flakiness, most visible on the Qt port.

The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.

The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
on our parent frame view - this is only an optimization to avoid doing layout() twice.

The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::collectFrameViewChildren): (WebCore::FrameView::forceLayoutParentViewIfNeeded): (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
  • page/FrameView.h:
02:56 Changeset [93861] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
https://bugs.webkit.org/show_bug.cgi?id=66988

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):

02:06 Changeset [93860] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93853.
http://trac.webkit.org/changeset/93853
https://bugs.webkit.org/show_bug.cgi?id=67016

Turns bots red

  • platform/chromium/test_expectations.txt:
02:05 Changeset [93859] by ossy@webkit.org
  • 2 edits
    20 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced in r93794.

  • platform/qt/Skipped:
  • platform/qt/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt: Added.
01:59 Changeset [93858] by commit-queue@webkit.org
  • 7 edits in trunk

REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
https://bugs.webkit.org/show_bug.cgi?id=67015

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-26
Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Checks the validity of maxlength attribute when converting it to integer.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt:

Added maxlength="" and maxlength="invalid" tests.

  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.
  • fast/forms/textarea-maxlength-expected.txt: ditto.
01:52 Changeset [93857] by noel.gordon@gmail.com
  • 2 edits in trunk/Tools

Make show-pretty-diff work on linux
https://bugs.webkit.org/show_bug.cgi?id=67017

Reviewed by Adam Barth.

  • Scripts/show-pretty-diff:
Note: See TracTimeline for information about the timeline view.