Timeline


and

08/31/11:

23:29 Changeset [94276] by levin@chromium.org

[chromium] Add baseline due to r94258.

  • platform/chromium-linux/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.
23:23 Changeset [94275] by abarth@webkit.org

[Chromium] Rename PlatformBridge to PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67349

Reviewed by Darin Fisher.

This matches the WebKitPlatformSupport embedder API.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/NPV8Object.cpp:

(_NPN_Evaluate):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalErrorInV8):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::evaluate):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):

  • page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):

  • platform/audio/chromium/AudioBusChromium.cpp:

(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::getSequenceNumber):
(WebCore::ChromiumDataObject::containsFilenames):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

  • platform/chromium/LanguageChromium.cpp:

(WebCore::platformDefaultLanguage):

  • platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):

  • platform/chromium/PlatformBridge.h: Removed.
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h: Copied from Source/WebCore/platform/chromium/PlatformBridge.h.
  • platform/chromium/SSLKeyGeneratorChromium.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):

  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

  • platform/chromium/SuddenTerminationChromium.cpp:

(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):

  • platform/chromium/TraceEvent.h:

(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::drawGlyphsWin):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::scriptFontProperties):

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

(WebCore::FontPlatformData::querySystemForRenderStyle):

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::fillBMPGlyphs):

  • platform/graphics/chromium/ImageChromium.cpp:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/chromium/ImageChromiumMac.mm:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::tryToPreloadFont):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/network/chromium/CookieJarChromium.cpp:

(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/network/chromium/DNSChromium.cpp:

(WebCore::prefetchDNS):

  • platform/qt/PlatformBridge.h: Removed.
  • platform/qt/PlatformBridgeQt.cpp: Removed.
  • platform/qt/PlatformSupport.h: Copied from Source/WebCore/platform/qt/PlatformBridge.h.
  • platform/qt/PlatformSupportQt.cpp: Copied from Source/WebCore/platform/qt/PlatformBridgeQt.cpp.

(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):

  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  • plugins/chromium/PluginDataChromium.cpp:

(WebCore::PluginCache::plugins):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

  • storage/chromium/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

  • storage/chromium/IDBKeyPathBackendImpl.cpp:

(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

  • src/PlatformBridge.cpp: Removed.
  • src/ResourceHandle.cpp:

(WebCore::ResourceHandle::cacheMetadata):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::~WebFrameImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

23:11 Changeset [94274] by rniwa@webkit.org

Crash when inserting text with a trailing newline into a textarea via JS
https://bugs.webkit.org/show_bug.cgi?id=66241

Reviewed by Darin Adler and Kent Tamura.

Source/WebCore:

The crash was caused by updateFromElement biting on the editing code.

When there is a style rule that applies on text nodes inside the shadow DOM, DOM modifications made
by the editing code may trigger style recalculation on input or textarea elements in the midst of editing
commands. In response to this style recalculation, HTMLInputElement::updateFromElement and
HTMLTextAreaElement::updateFromElement call setInnerTextValue to re-create the text nodes in the
shadow DOM. The editing code blows up because setInnerTextValue detaches old text nodes referenced by
Positions and VisiblePositions held by the editing commands in progress.

Fixed the crash by stop calling setInnerTextValue in updateFromElement. Instead, WebKit now creates
the text nodes when attributes, descendent nodes, etc... of input or textarea element changes.

Tests: fast/forms/update-from-element-during-editing-crash-1.html

fast/forms/update-from-element-during-editing-crash-2.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Force calling setInnerTextValue when input type changes.
(WebCore::HTMLInputElement::updateInnerTextValue): Extracted from RenderTextControlSingleLine's
updateElement.
(WebCore::HTMLInputElement::parseMappedAttribute): Calls updateInnerTextValue; force calling
setInnerTextValue when -webkit-speech attribute changes. In the theory, we should be able to call it less
frequently but there are too many cases to consider at the moment.
(WebCore::HTMLInputElement::setValue): Calls updateInnerTextValue when the value actually changed.
Note we need to call it before we set or restore selection.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged): Calls updateInnerTextValue when textarea's descendants
nodes are changed by parser or scripts.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls updateInnerTextValue when the value changes.

  • html/HTMLTextFormControlElement.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::willBlur): Calls updateInnerTextValue because input[type=number] forces
the value to be valid on blur.

  • rendering/RenderTextControlMultiLine.cpp: Removed RenderTextControlMultiLine::updateFromElement.
  • rendering/RenderTextControlMultiLine.h: Ditto.
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

LayoutTests:

Add regressions tests to ensure WebKit doesn't crash even when style recalc happens
in the midst of editing commands.

  • fast/forms/update-from-element-during-editing-crash-1-expected.txt: Added.
  • fast/forms/update-from-element-during-editing-crash-1.html: Added.
  • fast/forms/update-from-element-during-editing-crash-2-expected.txt: Added.
  • fast/forms/update-from-element-during-editing-crash-2.html: Added.
23:07 Changeset [94273] by commit-queue@webkit.org

Fix snow-leopard regression caused by r93982
https://bugs.webkit.org/show_bug.cgi?id=67301

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-31
Reviewed by Kenneth Russell.

Test: canvas/philip/tests/2d.path.stroke.prune.arc.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::arc):

22:56 Changeset [94272] by levin@chromium.org

[chromium] Add baselines due to r94253 and r94258.

  • platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
22:47 Changeset [94271] by tkent@chromium.org

Merge 94268 - REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
https://bugs.webkit.org/show_bug.cgi?id=67181

Reviewed by Dimitri Glazkov.

Source/WebCore:

r88115 removed the code to make inherited style of the owner input
element, and html.css contains "font: -webkit-small-control" for
input element. So -webkit-file-upload-button always had
-webkit-small-control font.

Test: fast/forms/file/file-style-inheritance.html

  • css/html.css:

(input[type="file"]::-webkit-file-upload-button):
Specify font-size:inherit explicitly.

LayoutTests:

  • fast/forms/file/file-style-inheritance-expected.txt: Added.
  • fast/forms/file/file-style-inheritance.html: Added.

TBR=tkent@chromium.org
BUG=94602
Review URL: http://codereview.chromium.org/7828001

22:33 Changeset [94270] by keishi@webkit.org

Rename closeColorChooser to cleanupColorChooser
https://bugs.webkit.org/show_bug.cgi?id=67270

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::cleanupColorChooserIfCurrentClient): NSColorPanel shouldn't be closed but the color
chooser listeners need to be taken care of. Therefore closeColorChooser will be renamed to cleanupColorChooser.
This will close the color chooser on platforms where appropriate.

  • html/ColorInputType.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::cleanupColorChooser): Rename.

  • page/Chrome.cpp:

(WebCore::Chrome::cleanupColorChooser): Rename.

  • page/Chrome.h:
  • page/ChromeClient.h:
20:23 Changeset [94269] by levin@chromium.org

[chromium] Add baselines for test added by r94253.

  • platform/chromium-cg-mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/chromium-linux/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
19:40 Changeset [94268] by tkent@chromium.org

REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
https://bugs.webkit.org/show_bug.cgi?id=67181

Reviewed by Dimitri Glazkov.

Source/WebCore:

r88115 removed the code to make inherited style of the owner input
element, and html.css contains "font: -webkit-small-control" for
input element. So -webkit-file-upload-button always had
-webkit-small-control font.

Test: fast/forms/file/file-style-inheritance.html

  • css/html.css:

(input[type="file"]::-webkit-file-upload-button):
Specify font-size:inherit explicitly.

LayoutTests:

  • fast/forms/file/file-style-inheritance-expected.txt: Added.
  • fast/forms/file/file-style-inheritance.html: Added.
19:28 Changeset [94267] by crogers@google.com

Merge 94262 - Add defensive bounds checking for AudioNode methods
https://bugs.webkit.org/show_bug.cgi?id=67346

BUG=95012
Review URL: http://codereview.chromium.org/7821023

19:24 Changeset [94266] by crogers@google.com

Merge 94265 - Do more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=67351

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/7756026

19:08 Changeset [94265] by crogers@google.com

Do more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=67351

Reviewed by Dirk Pranke.

No new tests since this does not change JavaScript API.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

18:56 Changeset [94264] by keishi@webkit.org

Remove closeColorChooser call from FrameLoader::transitionToCommitted
https://bugs.webkit.org/show_bug.cgi?id=67267

Reviewed by Darin Adler.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Moved order to match header.

  • html/ColorInputType.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Remove ColorInputType::closeColorChooserIfCurrentClient call.
It wasn't the right place to directly manipulate the UI.

18:46 Changeset [94263] by abarth@webkit.org

Move DumpRenderTree to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67331

Reviewed by Darin Fisher.

This patch update DumpRenderTree to account for the WebKitClient =>
WebKitPlatformSupport rename.

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::show):

  • DumpRenderTree/chromium/Task.cpp:

(postTask):

18:43 Changeset [94262] by crogers@google.com

Add defensive bounds checking for AudioNode methods
https://bugs.webkit.org/show_bug.cgi?id=67346

Reviewed by Anders Carlsson.

No new tests since this does not change JavaScript API.

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::input):
(WebCore::AudioNode::output):

18:31 Changeset [94261] by commit-queue@webkit.org

Chromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger gesture on Lion
https://bugs.webkit.org/show_bug.cgi?id=66599

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

Overlay scrollbars over a pdf wouldn't stay visible if a gesture was in progress. Normally we use a beginScrollGesture and endScrollGesture to keep the scrollbars visible. Unfortunately PDFs didn't handle gesture events so we didn't get the begin/end gesture events.

This change pipes gesture events to WebPluginContainerImpl if possible. This fixes this bug.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleGestureEvent):

  • src/WebPluginContainerImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

18:22 Changeset [94260] by arv@chromium.org

shouldBeEqualToString should encode special characters
https://bugs.webkit.org/show_bug.cgi?id=67223

Reviewed by Darin Adler.

  • fast/js/resources/standalone-pre.js:

(shouldBeEqualToString): Encode \, ", \n, \r

  • http/tests/cookies/resources/cookies-test-pre.js:

(shouldBeEqualToString): Encode \, ", \n, \r

18:20 Changeset [94259] by simon.fraser@apple.com

TransformState.move() should be negated in the unapply code path
https://bugs.webkit.org/show_bug.cgi?id=66246

Reviewed by Chris Marrin.

Code using TransformState was confused about when to negate the arguments
to move() in the "UnapplyInverseTransform" direction (used by mapAbsoluteToLocal).

Made the move() path equivalent to the applyTransform() path by not requiring
the caller to negate, and instead negating inside move().

Fixed the erroneous negation in TransformState::move() when accumulating;
that negation will happen later via matrix inversion.

No behavior change.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapAbsoluteToLocalPoint):

18:11 Changeset [94258] by inferno@chromium.org

Add test for testing non-existent eventsource and
fix typo in previous test.
https://bugs.webkit.org/show_bug.cgi?id=49448

Reviewed by Alexey Proskuryakov.

  • http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt: Removed.
  • http/tests/eventsource/eventsource-status-error-iframe-crash.html: Removed.
  • http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Copied from LayoutTests/http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt.
  • http/tests/eventsource/existent-eventsource-status-error-iframe-crash.html: Copied from LayoutTests/http/tests/eventsource/eventsource-status-error-iframe-crash.html.
  • http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash-expected.txt: Added.
  • http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash.html: Added.
  • http/tests/eventsource/resources/request-existent-eventsource-error.html: Copied from LayoutTests/http/tests/eventsource/resources/request-status-error.htm.
  • http/tests/eventsource/resources/request-non-existent-eventsource-error.html: Added.
  • http/tests/eventsource/resources/request-status-error.htm: Removed.
17:36 Changeset [94257] by andersca@apple.com

Jagged text shown in find-in-page highlight
https://bugs.webkit.org/show_bug.cgi?id=67347
<rdar://problem/9870444>

Reviewed by Dan Bernstein.

When painting each text line in the find indicator, make sure to clip it against
the text rect and not paint the entire rect over and over.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

17:28 Changeset [94256] by oliver@apple.com

Fix build.

17:26 Changeset [94255] by psolanki@apple.com

Fix compile issues when enabling HAVE(CFNETWORK_DATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=67332

Reviewed by Darin Adler.

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray):

  • platform/network/cf/ResourceHandleCFNet.cpp:
17:21 Changeset [94254] by oliver@apple.com

fast/regex/overflow.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=67326

Reviewed by Gavin Barraclough.

The deliberate overflows in these expressions don't interact nicely
with Checked<32bit-type> so we just bump up to Checked<int64_t> for the
intermediate calculations.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):

17:14 Changeset [94253] by mitz@apple.com

Source/WebCore: Refined the heuristic introduced to fix <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

Test: fast/multicol/overflow-across-columns-percent-height.html

  • rendering/RenderBox.cpp:

(WebCore::percentageLogicalHeightIsResolvable): Added. This follows logic similar to the one
in computePercentageLogicalHeight() to determine whether percentage values for height properties
are resolved or treated as "auto".
(WebCore::RenderBox::hasUnsplittableScrollingOverflow): If min-height or max-height are specified
as a percentage but actually resolve to "auto", don’t let that prevent splitting.

LayoutTests: Additional test for <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

  • fast/multicol/overflow-across-columns-percent-height.html: Added.
  • platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
17:00 Changeset [94252] by rniwa@webkit.org

Move text() and textWithHardLineBreaks() from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67320

Reviewed by Darin Adler.

Source/WebCore:

Moved and renamed RenderText::text and RenderText::textWithHardLineBreaks to
HTMLTextFormControlElement::innerTextValue and HTMLTextFormControlElement::valueWithHardLineBreaks.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::text):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData): Calls valueWithHardLineBreaks. It doesn't have to check
the existence of renderer anymore because valueWithHardLineBreaks returns value() when renderer do not
exist unlike RenderText::textWithHardLineBreaks returned emptyString() in such cases. This is the only place
valueWithHardLineBreaks is ever called; but we can't move valueWithHardLineBreaks because it calls
finishText.
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::updateValue):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
(WebCore::finishText): Moved from RenderText.cpp
(WebCore::HTMLTextFormControlElement::innerTextValue): Ditto.
(WebCore::getNextSoftBreak): Ditto.
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks): Ditto; this function returns value()
when there are no renderers or root inline boxes instead of emptyString().

  • html/HTMLTextFormControlElement.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::hasUnacceptableValue):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::startSearchEventTimer):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:

Source/WebKit/qt:

Call HTMLTextFormControlElement::value() instead of RenderText::text()

  • Api/qwebpage.cpp:

(QWebPage::inputMethodQuery):

16:55 Changeset [94251] by jeffm@apple.com

Source/JavaScriptCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to JavaScriptCore/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

  • wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.

Source/WebCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to JavaScriptCore/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

No new tests, covered by existing media tests.

  • config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.
16:54 Changeset [94250] by ojan@chromium.org

fix bug in flexbox test with offsetWidth/offsetLeft of 0
https://bugs.webkit.org/show_bug.cgi?id=67330

Reviewed by Tony Chang.

  • css3/flexbox/resources/flexbox.js:
16:54 Changeset [94249] by lforschler@apple.com

Versioning.

16:52 Changeset [94248] by lforschler@apple.com

New tag.

16:32 Changeset [94247] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67322
Re-name overrideBackingScaleFactor

Reviewed by John Sullivan.

Source/WebKit/mac:

_setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor

  • WebView/WebView.mm:

(-[WebView _setCustomBackingScaleFactor:]):
(-[WebView _deviceScaleFactor]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

API is now WKPageSetCustomBackingScaleFactor() and WKPageGetBackingScaleFactor()
which returns the custom scale factor if one was set, and the intrinsic scale
factor otherwise.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetBackingScaleFactor):
(WKPageSetCustomBackingScaleFactor):

  • UIProcess/API/C/WKPage.h:

Re-named _deviceScaleFactor to _intrinsicDeviceScaleFactor since it only ever
refers to the intrinsic value.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidChangeResolution:]):
(-[WKView _intrinsicDeviceScaleFactor]):

WebPageProxy stores both the customDeviceScaleFactor and the
intrinsicDeviceScaleFactor. deviceScaleFactor() returns the appropriate value that
should be the one used.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
(WebKit::WebPageProxy::deviceScaleFactor):
(WebKit::WebPageProxy::setCustomDeviceScaleFactor):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
16:16 Changeset [94246] by andersca@apple.com

REGRESSION(r93902): Can't open external links on gmail
https://bugs.webkit.org/show_bug.cgi?id=67234
<rdar://problem/10053636>

Reviewed by Alexey Proskuryakov.

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
If we encounter an empty URL string, create an empty url by using NSURL, just
like we do in WebCore when converting an empty KURL to an NSURL.

  • WebKit2.xcodeproj/project.pbxproj:

Compile ArgumentCodersCF.cpp as Objective-C++ for now.

16:14 Changeset [94245] by imasaki@chromium.org

[Chromium] Update a bug number in test expectation file and skip
media-document-audio-repaint.html for GPU due to an unimplented
feature.
https://bugs.webkit.org/show_bug.cgi?id=67328

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
16:12 Changeset [94244] by levin@chromium.org

[chromium] Test expectation updates due to r94211.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-009-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-012-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-013-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-014-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.txt.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/margin-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.txt.
16:06 Changeset [94243] by commit-queue@webkit.org

[Chromium] Switching between overlay and opaque scrollbars causes glitches
https://bugs.webkit.org/show_bug.cgi?id=62686

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Beth Dakin.

When switching from opaque scrollbars to overlay scrollbars the page content size wouldn't change leaving a empty region under the overlay scrollbar.

The problem was that we were relying on ScrollView::updateScrollbars() to kick off a layout. Unfortunately this doesn't happen because updateScrollbars doesn't distinguish between overlay and opaque scrollbars.

To fix this I'm explicitly invalidating the layout when ScrollView::scrollbarStyleChanged() is called.

No tests because there are no Mac 10.7 chromium bots yet. Bug 66504 will track the work to add these tests once the bots are in place.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):

16:01 Changeset [94242] by ap@apple.com

http/tests/eventsource/workers/eventsource-simple.html is a flaky crash because of
eventsource-status-error-iframe-crash.html
https://bugs.webkit.org/show_bug.cgi?id=61523

Reviewed by Nate Chapin.

Source/WebCore:

The problem here was that canceling EventSource during frame removal erroneously resulted
in event dispatch, and event handler re-entered frame destruction code.

  • page/EventSource.h: Renamed endRequest() to networkRequestEnded(), because this method

doesn't end request. It implements "reestablish the connection" or "fail the connection"
algotithms from the spec, depending on current state.
Removed m_failSilently, since we can make this decision with existing data, and want to
fail silently by default (e.g. when detaching a frame cancels all loads).

  • page/EventSource.cpp:

(WebCore::EventSource::EventSource): Don't initialize m_failSilently.
(WebCore::EventSource::~EventSource): Assert taht we are in a correct state.
(WebCore::EventSource::connect): Ditto.
(WebCore::EventSource::networkRequestEnded): Moved errorevent dispatch elsewhere.
(WebCore::EventSource::scheduleReconnect): Error event should always be queued when
reconnecting; firing it synchronously after starting m_reconnectTimer implements that.
(WebCore::EventSource::reconnectTimerFired): Assert that state is correct (the timer is
stopped if EventSource is stopped while waiting on the timer).
(WebCore::EventSource::close): Don't set m_state before calling cancel() - it will indirectly
call didFail(), which asserts that EventSource is not stopped yet.
(WebCore::EventSource::didReceiveResponse): Explicitly dispatch an error event, since it
is no longer dispatched when canceling, and canceling is the only way to stop a ThreadableLoader.
Removed a special case for 2xx responses, since it's no longer in the spec.
(WebCore::EventSource::didReceiveData): Assert that state is correct.
(WebCore::EventSource::didFinishLoading): Don't set state to CONNECTING after parsing remaining
response bytes - that may well result in dispatching an event whose handler calls close().
(WebCore::EventSource::didFail): It's simple now - we always reconnect unless the request
got canceled.
(WebCore::EventSource::didFailRedirectCheck): Dispatch error event explicitly, as we are
not going to attempt reconnecting.

LayoutTests:

  • http/tests/eventsource/eventsource-status-code-states-expected.txt:
  • http/tests/eventsource/eventsource-status-code-states.html:

2xx responses are no longer different from any other failures.

15:44 Changeset [94241] by cevans@google.com

Merge 94237
BUG=91197
Review URL: http://codereview.chromium.org/7822005

15:40 Changeset [94240] by commit-queue@webkit.org

Chromium Mac: Add fallback for drawing PDF overhang area
https://bugs.webkit.org/show_bug.cgi?id=66614

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

This change adds a fallback for overhang drawing for PDF content. This fallback is needed until the PDF plugin uses the linen pattern to draw its own overhang.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::paintCustomOverhangArea):

  • src/ChromeClientImpl.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paintCustomOverhangArea):

  • src/WebPluginContainerImpl.h:
15:26 Changeset [94239] by levin@chromium.org

[chromium] Fix expectations due to r94213.

  • platform/chromium-cg-mac/fast/tokenizer/script_extra_close-expected.txt: Removed.
15:20 Changeset [94238] by levin@chromium.org

empty-urls.html is non-deterministic.
https://bugs.webkit.org/show_bug.cgi?id=67327

Reviewed by Adam Barth.

  • http/tests/loading/empty-urls-expected.txt:
  • http/tests/loading/empty-urls.html: Ensure the ordering of the pass messages and remove the loader events which also seem to produce non-deterministic results.
14:51 Changeset [94237] by commit-queue@webkit.org

[chromium] Have the FrameLoaderClient release any plugin widget
reference is holding when the FrameLoader detaches it, to ensure that
the plugin won't out-live the containing page.
https://bugs.webkit.org/show_bug.cgi?id=66517

Patch by James Weatherall <wez@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::detachedFromParent3):

14:51 Changeset [94236] by commit-queue@webkit.org

Unreviewed, rolling out r94116.
http://trac.webkit.org/changeset/94116
https://bugs.webkit.org/show_bug.cgi?id=67323

caused a lot of tests failures (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

Source/WebCore:

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • svg/custom/getBBox-path-expected.txt: Removed.
  • svg/custom/getBBox-path.svg: Removed.
14:48 Changeset [94235] by commit-queue@webkit.org

Add Android's platform specification and the right atomic functions.
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-31
Reviewed by Adam Barth.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

  • wtf/Platform.h:
14:24 Changeset [94234] by commit-queue@webkit.org

Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.
https://bugs.webkit.org/show_bug.cgi?id=67289

Chromium bug: http://crbug.com/93228

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-31
Reviewed by Dimitri Glazkov.

No new tests, since this merely tweaks Chromium overhang area appearance.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paintGivenTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

14:19 Changeset [94233] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
svg/batik/text/textLayout through svg/text/multichar-glyph

  • platform/chromium-mac/svg/batik/text/textLayout-expected.png: Added.

(remaining files omitted for brevity)

14:12 Changeset [94232] by tony@chromium.org

Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources, debugger_script_source, injected_script_source, and
inspector_protocol_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on *_sources and compiles
these files. Previously, the other webcore libs (webcore_svg, webcore_html,
webcore_remaining, etc) depended on webcore_bindings. This moves the *_sources
dependencies from webcore_bindings to the other webcore libs so the build can
parallelize the compile of webcore_bindings and the other webcore_* libs.

Also copy over the include dirs that we used to get from webcore_bindings'
direct_dependent_settings.

No new tests, just changing the build dependencies.

  • WebCore.gyp/WebCore.gyp:
14:10 Changeset [94231] by abarth@webkit.org

[Chromium] Rename WebKitClient to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67309

Reviewed by Darin Fisher.

WebKitClient doesn't actually represent the WebKit Client. Instead, it
represents supporting code for the WebKit Platform. This patch renames
WebKitClient to WebKitPlatformSupport to make it easier for folks to
understand the difference between the Client and the Platform.

This patch includes shims so as not to break the Chromium build. Once
the Chromium side is updated, I'll remove the shims.

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebKit.h:

(WebKit::webKitClient):

  • public/WebKitClient.h: Removed.
  • public/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitClient.h.

(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):

  • src/ApplicationCacheHostInternal.h:
  • src/AssociatedURLLoader.cpp:
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):

  • src/BlobRegistryProxy.cpp:

(WebCore::BlobRegistryProxy::BlobRegistryProxy):

  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::CCThreadImpl):

  • src/ChromiumCurrentTime.cpp:

(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

  • src/ChromiumOSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

  • src/ChromiumThreading.cpp:

(WTF::ChromiumThreading::callOnMainThread):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMEType):
(WebKit::FrameLoaderClientImpl::userAgent):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

  • src/LocalizedStrings.cpp:

(WebCore::query):

  • src/PlatformBridge.cpp:

(WebCore::getCookieJar):
(WebCore::PlatformBridge::cacheMetadata):
(WebCore::PlatformBridge::clipboardIsFormatAvailable):
(WebCore::PlatformBridge::clipboardReadPlainText):
(WebCore::PlatformBridge::clipboardReadHTML):
(WebCore::PlatformBridge::clipboardReadImage):
(WebCore::PlatformBridge::clipboardGetSequenceNumber):
(WebCore::PlatformBridge::clipboardWriteSelection):
(WebCore::PlatformBridge::clipboardWritePlainText):
(WebCore::PlatformBridge::clipboardWriteURL):
(WebCore::PlatformBridge::clipboardWriteImage):
(WebCore::PlatformBridge::clipboardWriteData):
(WebCore::PlatformBridge::clipboardReadAvailableTypes):
(WebCore::PlatformBridge::clipboardReadData):
(WebCore::PlatformBridge::clipboardReadFilenames):
(WebCore::PlatformBridge::prefetchDNS):
(WebCore::PlatformBridge::fileExists):
(WebCore::PlatformBridge::deleteFile):
(WebCore::PlatformBridge::deleteEmptyDirectory):
(WebCore::PlatformBridge::getFileSize):
(WebCore::PlatformBridge::revealFolderInOS):
(WebCore::PlatformBridge::getFileModificationTime):
(WebCore::PlatformBridge::directoryName):
(WebCore::PlatformBridge::pathByAppendingComponent):
(WebCore::PlatformBridge::makeAllDirectories):
(WebCore::PlatformBridge::getAbsolutePath):
(WebCore::PlatformBridge::isDirectory):
(WebCore::PlatformBridge::filePathToURL):
(WebCore::PlatformBridge::openFile):
(WebCore::PlatformBridge::closeFile):
(WebCore::PlatformBridge::seekFile):
(WebCore::PlatformBridge::truncateFile):
(WebCore::PlatformBridge::readFromFile):
(WebCore::PlatformBridge::writeToFile):
(WebCore::PlatformBridge::ensureFontLoaded):
(WebCore::PlatformBridge::loadFont):
(WebCore::PlatformBridge::getFontFamilyForCharacters):
(WebCore::PlatformBridge::getRenderStyleForStrike):
(WebCore::PlatformBridge::databaseOpenFile):
(WebCore::PlatformBridge::databaseDeleteFile):
(WebCore::PlatformBridge::databaseGetFileAttributes):
(WebCore::PlatformBridge::databaseGetFileSize):
(WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
(WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::PlatformBridge::injectIDBKeyIntoSerializedValue):
(WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
(WebCore::PlatformBridge::computedDefaultLanguage):
(WebCore::PlatformBridge::isSupportedImageMIMEType):
(WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
(WebCore::PlatformBridge::isSupportedNonImageMIMEType):
(WebCore::PlatformBridge::mimeTypeForExtension):
(WebCore::PlatformBridge::wellKnownMimeTypeForExtension):
(WebCore::PlatformBridge::mimeTypeFromFile):
(WebCore::PlatformBridge::preferredExtensionForMIMEType):
(WebCore::PlatformBridge::plugins):
(WebCore::PlatformBridge::loadPlatformImageResource):
(WebCore::PlatformBridge::loadPlatformAudioResource):
(WebCore::PlatformBridge::decodeAudioFileData):
(WebCore::PlatformBridge::sandboxEnabled):
(WebCore::PlatformBridge::setSharedTimerFiredFunction):
(WebCore::PlatformBridge::setSharedTimerFireInterval):
(WebCore::PlatformBridge::stopSharedTimer):
(WebCore::PlatformBridge::decrementStatsCounter):
(WebCore::PlatformBridge::incrementStatsCounter):
(WebCore::PlatformBridge::histogramCustomCounts):
(WebCore::PlatformBridge::histogramEnumeration):
(WebCore::PlatformBridge::suddenTerminationChanged):
(WebCore::PlatformBridge::paintButton):
(WebCore::PlatformBridge::paintMenuList):
(WebCore::PlatformBridge::paintScrollbarArrow):
(WebCore::PlatformBridge::paintScrollbarThumb):
(WebCore::PlatformBridge::paintScrollbarTrack):
(WebCore::PlatformBridge::paintSpinButton):
(WebCore::PlatformBridge::paintTextField):
(WebCore::PlatformBridge::paintTrackbar):
(WebCore::PlatformBridge::paintProgressBar):
(WebCore::PlatformBridge::getThemePartSize):
(WebCore::PlatformBridge::paintThemePart):
(WebCore::PlatformBridge::traceEventBegin):
(WebCore::PlatformBridge::traceEventEnd):
(WebCore::PlatformBridge::visitedLinkHash):
(WebCore::PlatformBridge::isLinkVisited):
(WebCore::PlatformBridge::memoryUsageMB):
(WebCore::PlatformBridge::actualMemoryUsageMB):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerRepository::isAvailable):
(WebCore::SharedWorkerRepository::connect):
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):

  • src/StorageEventDispatcherChromium.cpp:

(WebCore::StorageEventDispatcher::dispatch):

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

  • src/WebKit.cpp:

(WebKit::generateEntropy):
(WebKit::initialize):
(WebKit::shutdown):
(WebKit::webKitPlatformSupport):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::copy):

  • src/WebViewImpl.cpp:
  • src/WebWorkerClientImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

  • src/WorkerFileWriterCallbacksBridge.cpp:

(WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):

  • tests/RunAllTests.cpp:
14:07 Changeset [94230] by abarth@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

  • DEPS:
14:03 Changeset [94229] by tonyg@chromium.org

Minor cleanup: remove inScriptExecution()
https://bugs.webkit.org/show_bug.cgi?id=67276

Reviewed by Adam Barth.

At one point inScriptExecution() existed as a non-virtual duplicate of isExecutingScript()
to avoid virtual method calls from a tight loop. Now we aren't calling it anywhere perf
sensitive, so remove the duplication.

No new tests because no change in functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::isExecutingScript):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):

  • html/parser/HTMLDocumentParser.h:

(WebCore::HTMLDocumentParser::shouldDelayEnd):

13:58 Changeset [94228] by eric@webkit.org

Add queues.webkit.org/active-bots page to make it easy to see which bots are down
https://bugs.webkit.org/show_bug.cgi?id=67314

Reviewed by Adam Barth.

Very simple page. Just lists all the bots, what queue they belong to and what we last heard from them.
If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
This makes it very easy for me to see which of my cr-jail bots might be down at any one time.

I also moved a bunch of code into dashboard.css which belonged there.

  • QueueStatusServer/handlers/activebots.py: Added.
  • QueueStatusServer/main.py:
  • QueueStatusServer/stylesheets/dashboard.css:

(.queue_bubble):
(.queue_name):
(.last_heard_from):
(.status_text):
(.alive):
(.behind):
(.dead):

  • QueueStatusServer/templates/activebots.html: Added.
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/recentstatus.html:
13:56 Changeset [94227] by robert@webkit.org

Add new platform-specific results from r94211

Unreviewed.

  • platform/gtk/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
13:53 Changeset [94226] by levin@chromium.org

[chromium] Update test expectation due to r94206 and r94211.

  • platform/chromium-win/fast/borders/border-image-source-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-source-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
13:52 Changeset [94225] by commit-queue@webkit.org

Fix XSS filter bypass by multiply decoding both the URL and the body
snippet until they are in the most minimal form before comparison.
https://bugs.webkit.org/show_bug.cgi?id=66585

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-31
Reviewed by Adam Barth.

Source/WebCore:

  • html/parser/XSSAuditor.cpp:

(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isContainedInRequest):

LayoutTests:

  • http/tests/security/xssAuditor/anchor-url-dom-write-location2.html:
  • http/tests/security/xssAuditor/resources/echo-dom-write-unescaped-location.html: Added.
13:46 Changeset [94224] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
fast/overflow through svg/batik/text

  • platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.

(remaining files omitted for brevity)

13:32 Changeset [94223] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
Most files were inadvertantly excluded from earlier checkins.

  • platform/chromium-mac/fast/overflow: Added.

(remaining files omitted for brevity)

13:16 Changeset [94222] by robert@webkit.org

Update platform-specific results after r94211

Unreviewed, update platform-specifc results.

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:
13:14 Changeset [94221] by oliver@apple.com

Move CheckedArithmeticOperations.cpp to the intended location

13:12 Changeset [94220] by lforschler@apple.com

Merged r92982.

13:09 Changeset [94219] by commit-queue@webkit.org

add unittest to validate the complete set of Chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=67211

Patch by Elliot Poger <epoger@google.com> on 2011-08-31
Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
12:42 Changeset [94218] by lforschler@apple.com

Merge r93459.

12:29 Changeset [94217] by vangelis@chromium.org

Direct commit into chromium 835 branch:

Fix handling of lost context recovery for windows XP. The existing code didn't always
succeed creating a GC3D right after recovering from a lost device and ended up in an inconsistent
state of doing s/w rendering but without having properly cleared the composited layers.
The new code attempts to create a GC3D a few times before giving up and switching to s/w rendering.
Upon repeated failure we now switch to s/w rendering and force a style recalc on the document
to make sure that composited layers are properly disposed.

This code is checked in to the 835 branch directly as handling of the lost context events on the trunk has significantly diverged. A similar change must be made to the trunk as well.

CHROME BUG=http://code.google.com/p/chromium/issues/detail?id=94183
TEST=Open pages using the compositor like the poster circle on windows XP and trigger repeated lost device events
by locking the screen. Verify that upon return the page renders correctly.

12:21 Changeset [94216] by vsevik@chromium.org

Merge 94078 - Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Reviewed by Pavel Feldman.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFailLoading):

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7819001

12:12 Changeset [94215] by simon.fraser@apple.com

Crash with -webkit-radial-gradient(top) gradient
https://bugs.webkit.org/show_bug.cgi?id=66686

Source/WebCore:

Reviewed by Darin Adler.

Null-check the current value after calling parseFillPosition(),
since it may be null for gradients with degenerate arguments.

Test: fast/gradients/css3-radial-gradient-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseRadialGradient):

LayoutTests:

Reviewed by Darin Adler.

Test case with degenerate arguments in a radial gradient.

  • fast/gradients/css3-radial-gradient-crash-expected.txt: Added.
  • fast/gradients/css3-radial-gradient-crash.html: Added.
12:08 Changeset [94214] by thakis@chromium.org

Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
https://bugs.webkit.org/show_bug.cgi?id=67297

Reviewed by Tony Chang.

Source/WebCore:

I need this to disable smooth scrolling in chromium tests. I'm making
the change to ScrollAnimatorMac to make unforking the file easier. I
changed scrollAnimatorEnabled() to default to true so that this change
is a no-op for Safari; in chromium the flag is set explicitly to true
or false anyway.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::scroll):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll):

Tools:

Explicitly disable smooth scrolling in chromium's DRT.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

12:01 Changeset [94213] by japhet@chromium.org

Source/WebCore: Don't load resources with empty urls, since this
will resolve to the current document.
https://bugs.webkit.org/show_bug.cgi?id=30303

Reviewed by Darin Adler.

Test: http/tests/loading/empty-urls.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript): If src="", fail through

to the error event case.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseMappedAttribute): Ensure the url

stays empty if we try to resolve an empty href.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Throw an error instead of

loading if the src is empty in all cases, not just local files.

LayoutTests: Test updates for https://bugs.webkit.org/show_bug.cgi?id=30303.

Reviewed by Darin Adler.

  • fast/images/load-img-with-empty-src-expected.txt:
  • fast/images/load-img-with-empty-src.html: Expect the same behavior whether or not an empty src

is in a local file document.

  • fast/tokenizer/002-expected.txt: Added.
  • fast/tokenizer/002.html: Make dumpAsText().
  • fast/tokenizer/external-script-document-write_2-expected.txt: Added.
  • fast/tokenizer/external-script-document-write_2.html:: Make dumpAsText().
  • fast/tokenizer/script_extra_close-expected.txt: Added.
  • fast/tokenizer/script_extra_close.html:: Make dumpAsText().
  • http/tests/loading/empty-urls-expected.txt: Added.
  • http/tests/loading/empty-urls.html: Added. Test empty urls with a bunch of subresource types

and ensure their error event behavior matches the spec.

  • platform/chromium-cg-mac/fast/tokenizer/002-expected.txt: Removed.
  • platform/chromium-cg-mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
  • platform/chromium-linux/fast/tokenizer/002-expected.png: Removed.
  • platform/chromium-linux/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/chromium-linux/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/002-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/002-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/002-expected.png: Removed.
  • platform/gtk/fast/tokenizer/002-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
  • platform/mac-leopard/fast/tokenizer/002-expected.png: Removed.
  • platform/mac-leopard/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/mac-leopard/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/mac/fast/tokenizer/002-expected.png: Removed.
  • platform/mac/fast/tokenizer/002-expected.txt: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
  • platform/mac/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/mac/fast/tokenizer/script_extra_close-expected.txt: Removed.
  • platform/qt/fast/tokenizer/002-expected.png: Removed.
  • platform/qt/fast/tokenizer/002-expected.txt: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
  • platform/qt/fast/tokenizer/script_extra_close-expected.png: Removed.
  • platform/qt/fast/tokenizer/script_extra_close-expected.txt: Removed.
11:57 Changeset [94212] by simon.fraser@apple.com

Improve appearance and performance of layout test results.html
https://bugs.webkit.org/show_bug.cgi?id=67252

Reviewed by Adam Barth, Ojan Vafai.

Improve the appearance of the pixel result comparison overlay.

Change the overlay from painting pixels into a canvas one by one
to using images enlarged with 'image-rendering: -webkit-optimize-contrast",
which is very much faster.

  • fast/harness/results.html:
11:48 Changeset [94211] by robert@webkit.org

CSS 2.1 failure: margin-applies-to-015 fails, WebKit does not respect top margin for table captions
https://bugs.webkit.org/show_bug.cgi?id=34763

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustLogicalHeightForCaption): Added the caption's margin to the position calculation.

LayoutTests:

  • css2.1/20110323/margin-applies-to-001.htm: Added.
  • css2.1/20110323/margin-applies-to-002.htm: Added.
  • css2.1/20110323/margin-applies-to-003.htm: Added.
  • css2.1/20110323/margin-applies-to-004.htm: Added.
  • css2.1/20110323/margin-applies-to-005.htm: Added.
  • css2.1/20110323/margin-applies-to-006.htm: Added.
  • css2.1/20110323/margin-applies-to-007.htm: Added.
  • css2.1/20110323/margin-applies-to-008.htm: Added.
  • css2.1/20110323/margin-applies-to-009.htm: Added.
  • css2.1/20110323/margin-applies-to-010.htm: Added.
  • css2.1/20110323/margin-applies-to-012.htm: Added.
  • css2.1/20110323/margin-applies-to-013.htm: Added.
  • css2.1/20110323/margin-applies-to-014.htm: Added.
  • css2.1/20110323/margin-applies-to-015.htm: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
    • Updated to reflect position of table caption taking account of margin, matching Firefox where appropriate. Still some unrelated failures that prevent matching Firefox exactly.
11:48 Changeset [94210] by lforschler@apple.com

Merge r93900.

11:46 Changeset [94209] by lforschler@apple.com

Merge r93878.

11:37 Changeset [94208] by oliver@apple.com

2011-08-31 Oliver Hunt <oliver@apple.com>

Add Checked<> tests to windows build

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
11:16 Changeset [94207] by oliver@apple.com

Add support for checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=67095

Reviewed by Sam Weinig.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a checked arithmetic class Checked<T> that provides overflow-safe
arithmetic over all integral types. Checked<T> supports addition, subtraction
and multiplication, along with "bool" conversions and equality operators.

Checked<> can be used in either CRASH() on overflow or delayed failure modes,
although the default is to CRASH().

To ensure the code is actually in use (rather than checking in dead code) I've
made a couple of properties in YARR use Checked<int> and Checked<unsigned>
instead of raw value arithmetic. This has resulted in a moderate set of changes,
to YARR - mostly adding .get() calls, but a couple of casts from unsigned long
to unsigned for some uses of sizeof, as Checked<> currently does not support
mixed signed-ness of types wider that 32 bits.

Happily the increased type safety of Checked<> means that it's not possible to
accidentally assign away precision, nor accidentally call integer overload of
a function instead of the bool version.

No measurable regression in performance, and SunSpider claims this patch to be
a progression of 0.3%.

(WTF::CrashOnOverflow::overflowed):
(WTF::CrashOnOverflow::clearOverflow):
(WTF::CrashOnOverflow::hasOverflowed):
(WTF::RecordOverflow::RecordOverflow):
(WTF::RecordOverflow::overflowed):
(WTF::RecordOverflow::clearOverflow):
(WTF::RecordOverflow::hasOverflowed):
(WTF::isInBounds):
(WTF::safeAdd):
(WTF::safeSub):
(WTF::safeMultiply):
(WTF::safeEquals):
(WTF::workAroundClangBug):
(WTF::Checked::Checked):
(WTF::Checked::operator=):
(WTF::Checked::operator++):
(WTF::Checked::operator--):
(WTF::Checked::operator!):
(WTF::Checked::operator UnspecifiedBoolType*):
(WTF::Checked::get):
(WTF::Checked::operator+=):
(WTF::Checked::operator-=):
(WTF::Checked::operator*=):
(WTF::Checked::operator==):
(WTF::Checked::operator!=):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::UncheckInput):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):

  • yarr/YarrPattern.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header for CheckedArithmetic.h

  • ForwardingHeaders/wtf/CheckedArithmetic.h: Added.

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

Add test cases for Checked<>

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
11:11 Changeset [94206] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67300

Add the new border-image-source property (and its corresponding analogue for masks, mask-box-image-source).
Change the border-image parsing code to no longer consider "none" to represent the entire border-image
expression, but instead to just mean "none" for the image component of the expression.

Change the pending image code for border-image and mask-box-image to use the new *-source properties when
loading the image so that they're considered the same.

This is the first step towards eliminating the border-image parsing code in favor of just parsing it as
a shorthand instead, but for now I'm implementing each property one by one, and once they're all there,
we can cut over to border-image as a true shorthand.

Reviewed by Beth Dakin.

Added fast/borders/border-image-source.html.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBorderImage):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImage):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::borderImageSource):
(WebCore::InheritedFlags::maskBoxImageSource):
(WebCore::InheritedFlags::setBorderImageSource):
(WebCore::InheritedFlags::setMaskBoxImageSource):
(WebCore::InheritedFlags::initialBorderImageSource):
(WebCore::InheritedFlags::initialMaskBoxImageSource):

LayoutTests:

  • fast/borders/border-image-source.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:54 Changeset [94205] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, remainder of fast directory)

  • platform/chromium-mac/fast/blockflow: Added.

(remaining files omitted for brevity)

10:53 Changeset [94204] by abarth@webkit.org

Move summary.html to garden-o-matic.html.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
10:44 Changeset [94203] by noel.gordon@gmail.com

[chromium] DRT linux should pass nativeKeyCode to plugins
https://bugs.webkit.org/show_bug.cgi?id=66679

Reviewed by Tony Chang.

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown): Call a Chromium Linux GTK helper routine that returns the
(simulated) nativeKeyCode for the given input keyboard code.

LayoutTests:

  • platform/chromium-linux/plugins/keyboard-events-expected.txt:
10:41 Changeset [94202] by senorblanco@chromium.org

[chromium] Set the GrContext before SkGpuDevice is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=67296

When SkGpuDevice is destroyed, it frees the FBO used for accelerated
rendering. If the wrong context is set (e.g., compositor context),
a crash may result.

Reviewed by Kenneth Russell.

No new tests. (Unfortunately, wrong-context bugs are difficult to
express in a layout test).

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::~ImageBuffer):

10:32 Changeset [94201] by abarth@webkit.org

Tighen up UI for garden-o-matic tab strip
https://bugs.webkit.org/show_bug.cgi?id=67266

Reviewed by Dimitri Glazkov.

This patch add CSS to move the tab strip to the edges of the page and
to remove some gratuitous border-radius.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
10:30 Changeset [94200] by abarth@webkit.org

garden-o-matic results view shouldn't be horrifically ugly
https://bugs.webkit.org/show_bug.cgi?id=67264

Reviewed by Dimitri Glazkov.

Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
10:20 Changeset [94199] by nduca@chromium.org

[Chromium] Unreviewed, fix inconsistent WebKit.gypi after r94106
https://bugs.webkit.org/show_bug.cgi?id=67288

  • WebKit.gypi:
09:37 Changeset [94198] by abarth@webkit.org

garden-o-matic needs a tabstrip
https://bugs.webkit.org/show_bug.cgi?id=67263

Reviewed by Dimitri Glazkov.

This patch adds a basic tabstrip to garden-o-matic. The results
details view now opens in the "Results" tab, and the user can flip back
and forth between the Summary and the Results tab quickly. There's
also a stub for a "Commits" tab, which is disabled.

This patch isn't the most beautiful in the world, but it gets the ball
rolling on a multi-modal UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
09:34 Changeset [94197] by kbalazs@webkit.org

[Qt] Unreviewed gardening.
Unskip fast/files/create-blob-url.html after r94187

  • platform/qt/Skipped:
09:31 Changeset [94196] by eric.carlson@apple.com

Clean up HTMLMediaElement behavior restrictions
https://bugs.webkit.org/show_bug.cgi?id=67231

Reviewed by Darin Adler.

No new tests, cleanup only.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::load): Call userGestureRequiredForLoad() instead of testing bits

directly.

(WebCore::HTMLMediaElement::loadInternal): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::play): Call userGestureRequiredForRateChange() instead of testing bits

directly.

(WebCore::HTMLMediaElement::pause): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::userGestureRequiredForLoad): Renamed.
(WebCore::HTMLMediaElement::userGestureRequiredForRateChange):
(WebCore::HTMLMediaElement::userGestureRequiredForFullscreen):
(WebCore::HTMLMediaElement::pageConsentRequiredForLoad):
(WebCore::HTMLMediaElement::addBehaviorRestriction):
(WebCore::HTMLMediaElement::removeBehaviorRestriction):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen): requireUserGestureForFullScreen renamed to

userGestureRequiredForFullscreen.

09:20 Changeset [94195] by caryclark@google.com

unreviewed; new baselines (Skia on Mac, css3, edit, partial fast directories)

  • platform/chromium-mac/css3: Added.
  • platform/chromium-mac/edit: Added.
  • platform/chromium-mac/fast/backgrounds: Added.

(remaining files omitted for brevity)

09:09 Changeset [94194] by mrobinson@webkit.org

Unskip a test which now seems to be passing on GTK+.

  • platform/gtk/Skipped: Unskip a test.
08:25 Changeset [94193] by kbalazs@webkit.org

[Qt] Incorrect results for new fast/multicol tests added in r94084
https://bugs.webkit.org/show_bug.cgi?id=67293

Unreviwed gardening.

  • platform/qt/Skipped:
08:25 Changeset [94192] by andreip@google.com

2011-08-31 Andrei Popescu <andreip@google.com>

Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Unreviewed, build fix for ARM platforms.

  • wtf/Platform.h:
08:10 Changeset [94191] by andreip@google.com

Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Reviewed by Darin Adler.

Remove the last legacy Android code.

No new tests needed as the code wasn't tested in the first place.

Source/JavaScriptCore:

  • wtf/Atomics.h:
  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):

Source/WebCore:

  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::getJNIEnv):

08:02 Changeset [94190] by caryclark@google.com

unreviewed; new baselines (Skia on Mac, css2.1 directory only)

  • platform/chromium-mac/css2.1: Added.
  • platform/chromium-mac/css2.1/20110323: Added.
  • platform/chromium-mac/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.

(remaining files omitted for brevity)

07:52 Changeset [94189] by commit-queue@webkit.org

Unreviewed, rolling out r94082.
http://trac.webkit.org/changeset/94082
https://bugs.webkit.org/show_bug.cgi?id=67291

Breaks trunk (not canary) Chromium Mac builders upon WebKit
roll (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

  • WebCore.gyp/WebCore.gyp:
07:50 Changeset [94188] by noam.rosenthal@nokia.com

[Qt] Add a convenience function to cast a QTransform to TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=67246

Reviewed by Andreas Kling.

No new functionality so no new tests.

  • platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::TransformationMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:
07:43 Changeset [94187] by philn@webkit.org

Unreviewed, revert part of r94168, the test didn't need result
update. Proper fix is worked on in bug 66045.

  • fast/files/create-blob-url-crash-expected.txt:
07:37 Changeset [94186] by commit-queue@webkit.org

Unreviewed, rolling out r94176.
http://trac.webkit.org/changeset/94176
https://bugs.webkit.org/show_bug.cgi?id=67290

This does not fix the build failure on Macs (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

  • WebCore.gyp/WebCore.gyp:
07:03 Changeset [94185] by reed@google.com

[skia] antialias images if we're rotated
https://bugs.webkit.org/show_bug.cgi?id=67207

Reviewed by Stephen White.

Source/WebCore:

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):

LayoutTests:

  • platform/chromium/test_expectations.txt:
06:37 Changeset [94184] by kbalazs@webkit.org

[Qt] Unreviewedly skip new failures.

It covers the following bugs:

  • platform/qt/Skipped:
06:24 Changeset [94183] by philn@webkit.org

Unreviewed, rebaseline GTK-specific font tests.

  • platform/gtk/fonts/complex-text-shadows-expected.txt:
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt:
06:11 Changeset [94182] by caio.oliveira@openbossa.org

[Qt] Unskip API test for load signals order
https://bugs.webkit.org/show_bug.cgi?id=67285

Reviewed by Andreas Kling.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadSignalsOrder):

05:53 Changeset [94181] by apavlov@chromium.org

Web Inspector: Having the "Metrics" pane open affects the node highlight display
https://bugs.webkit.org/show_bug.cgi?id=67278

Reviewed by Yury Semikhatsky.

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._updateMetrics):

05:50 Changeset [94180] by podivilov@chromium.org

2011-08-31 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix after r94167.

  • inspector/debugger/script-formatter.html:
05:49 Changeset [94179] by kbalazs@webkit.org

[Qt] Unreviewed gardening.
Skipped the wrong test in a previous gardening.

  • platform/qt/Skipped:
05:13 Changeset [94178] by loislo@chromium.org

Web Inspector: console view does a style recalculation per each addMessage call.
https://bugs.webkit.org/show_bug.cgi?id=67198

It is bad from the performance point of view.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._isScrollIntoViewScheduled):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):

05:07 Changeset [94177] by kbalazs@webkit.org

[Qt] Incorrect results for svg/custom/getBBox-js.svg
Unreviewed gardening.

  • platform/qt/Skipped:
04:09 Changeset [94176] by apavlov@chromium.org

[Chromium] Unreviewed build fix. Restore debugger_script_source target dependency
broken in http://trac.webkit.org/changeset/94082.

  • WebCore.gyp/WebCore.gyp:
04:02 Changeset [94175] by philn@webkit.org

Unreviewed, unskip fast/css/square-button-appearance.html which
got baselines in r93953.

  • platform/gtk/test_expectations.txt:
03:55 Changeset [94174] by ossy@webkit.org

[Qt] 3 test started crashing somewhere between r93878-r93935
https://bugs.webkit.org/show_bug.cgi?id=67197

  • platform/qt/Skipped: Unskip tests, because bug was fixed by r94088.
03:53 Changeset [94173] by philn@webkit.org

Unreviewed, skip failing fast/loader/location-port.html test on
GTK.

  • platform/gtk/Skipped:
03:52 Changeset [94172] by ossy@webkit.org

[Qt] Unreviewed gardening.

Add Qt specific expected files after r94111, update Qt specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/qt/fast/preloader/document-write-noscript-expected.png: Added.
  • platform/qt/fast/preloader/document-write-noscript-expected.txt: Added.
03:42 Changeset [94171] by ossy@webkit.org

[Qt] Unreviewed gardening. Add and update platform specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

  • platform/qt/fast/table/table-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-before-child-style-update-expected.png: Added.
  • platform/qt/fast/table/table-before-child-style-update-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-style-update-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-style-update-expected.txt: Added.
03:37 Changeset [94170] by ossy@webkit.org

[Qt] Unreviewed gardening. Update platform specific expected files after r94147.

Based on digging of Gabor Rapcsanyi.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
03:20 Changeset [94169] by apavlov@chromium.org

Early return in CSSPrimitiveValue::getDoubleValueInternal() omits additional invalid enums
https://bugs.webkit.org/show_bug.cgi?id=67139

Reviewed by Darin Adler.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion): Check if a given unit type can be converted to a double.
(WebCore::CSSPrimitiveValue::getDoubleValueInternal): Make use of the new method that explicitly lists all unit types.

03:11 Changeset [94168] by philn@webkit.org

Unreviewed, GTK rebaseline after r93713 and r93909.

  • fast/files/create-blob-url-crash-expected.txt:
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.txt:
  • platform/gtk/css2.1/t090204-display-change-01-b-ao-expected.txt:
03:02 Changeset [94167] by podivilov@chromium.org

Web Inspector: rename sourceFile to uiSourceCode and get rid of sourceFileId where possible.
https://bugs.webkit.org/show_bug.cgi?id=67136

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.set reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
(WebInspector.CallStackSidebarPane.prototype.update):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.get url):
(WebInspector.PresenationCallFrame.prototype.select):
(WebInspector.PresenationCallFrame.prototype.sourceLine):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
(WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/scripts-panel.html:
02:20 Changeset [94166] by apavlov@chromium.org

[Chromium] Unreviewed, rebaseline another multicol test expectation.

  • platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-expected.png: Added.
02:12 Changeset [94165] by apavlov@chromium.org

[Chromium] Unreviewed, update Mac-Leopard expectations for multicol tests.

  • platform/chromium-cg-mac-leopard/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/multicol/positive-leading-expected.png: Added.
02:06 Changeset [94164] by commit-queue@webkit.org

[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67182

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-31
Reviewed by Kent Tamura.

Some layout tests for WebSocket raised Exception to prevent unnecessary
pywebsocket warning. But it doesn't work any more on pywebsocket 0.6b4.
Now pywebsocket support AbortedByUserException to prevent warning.
This change make raise AbortedByUserException instead of Exception.

handshake-fail-by-prepended-null_wsh.py didn't use Exception, but
expected abnormal closure on sending response could raise unexpected
Exception by chance. This change also takes care of it.

  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py:

Use AbortedByUserException instead of Exception.

01:45 Changeset [94163] by commit-queue@webkit.org

[EFL] Fonts API refactoring.
https://bugs.webkit.org/show_bug.cgi?id=66654

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-31
Reviewed by Hajime Morita.

There are too many similar API regarding to fonts.
Add one consistent API to set/get the font name for the font family.
Remove the previous font API.

  • ewk/ewk_view.cpp:

(ewk_view_font_family_name_get):
(ewk_view_font_family_name_set):

  • ewk/ewk_view.h:
01:35 Changeset [94162] by yutak@chromium.org

WebSocket: Load Blob in WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=67013

Reviewed by Kent Tamura.

Add WebSocketChannel::enqueueBlobFrame(). It makes WebSocketChannel start loading a Blob
and send a WebSocket frame after the Blob is loaded.

While a Blob is being loaded, subsequent send() requests cannot be processed and are blocked.
Pending requests are stored in m_outgoingFrameQueue. When we have finished loading a Blob,
requests in the queue are allowed to get processed.

No new tests are added, because nobody uses enqueueBlobFrame() yet. New tests will be added
when WebSocket.send(Blob) is implemented, and they will cover this code change.

  • websockets/WebSocketChannel.cpp:

ref() is called when m_blobLoader is allocated, and deref() is called in didFinishLoading()
or didFail(). This is necessary because WebSocketChannel must be able to receive callbacks
from FileReaderLoader even if the channel is referred from no other objects.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
When we have failed to load a Blob, fail() is called, and eventually didCloseSocketStream()
will be called. It will clean up the pending requests in the queue.
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):
Cancel the Blob loader when the outgoing request queue is about to be aborted. The loader
will not invoke didFail() callback once it is canceled, thus we need to call didFail()
manually so that we can free up the loader and decrement the reference count.

01:33 Changeset [94161] by yutak@chromium.org

WebSocket: Receive binary message as ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=67180

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/receive-arraybuffer.html

http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Convert ArrayBuffer to JSValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Convert ArrayBuffer to v8::Value.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

Added DataTypeArrayBuffer and ArrayBuffer-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsArrayBuffer):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):
Construct an ArrayBuffer from binaryData and raise MessageEvent.

LayoutTests:

  • http/tests/websocket/tests/hybi/receive-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/receive-arraybuffer.html:

Added. Connect to binary-frames_wsh.py (which is also used from receive-blob.html) and
check the content of MessageEvent's data attribute.

  • http/tests/websocket/tests/hybi/receive-blob.html:

Update function names to match ones in receive-arraybuffer.html.

  • http/tests/websocket/tests/hybi/workers/receive-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/receive-arraybuffer.js: Added.
  • http/tests/websocket/tests/hybi/workers/resources/receive-blob.js:

Same as receive-blob.html above.

01:18 Changeset [94160] by commit-queue@webkit.org

Extract reference links from reftest test file.
https://bugs.webkit.org/show_bug.cgi?id=66838

Patch by Ai Makabi <makabi@google.com> on 2011-08-31
Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/layout_tests/reftests/init.py: Added.
  • Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
  • Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
01:11 Changeset [94159] by philn@webkit.org

Unreviewed, GTK rebaseline after r94109 and r93909.

  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/gtk/fast/multicol/inherit-column-values-expected.txt: Added.
  • platform/gtk/fast/multicol/initial-column-values-expected.txt: Added.
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-before-child-style-update-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-style-update-expected.txt: Added.
01:08 Changeset [94158] by keishi@webkit.org

input color: onchange event is not fired when changing color from color chooser
https://bugs.webkit.org/show_bug.cgi?id=66848

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/color/input-color-onchange-event.html

  • WebCore.exp.in: Added calls used in Internals.cpp.
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::colorSelected): Dispatch change event.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::connectToColorChooser): Added. Called from Internals::connectColorChooserClient.

  • html/HTMLInputElement.h:
  • testing/Internals.cpp:

(WebCore::Internals::connectColorChooserClient): Added. Connects element as client to color chooser.
(WebCore::Internals::selectColorInColorChooser): Added. Simulate color selection in color chooser.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/forms/color/input-color-onchange-event-expected.txt: Added.
  • fast/forms/color/input-color-onchange-event.html: Added. Tests if change event is fired when user selects color from color chooser.
00:38 Changeset [94157] by philn@webkit.org

Unreviewed, GTK rebaseline after r94147.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
00:35 Changeset [94156] by commit-queue@webkit.org

Implement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm.
https://bugs.webkit.org/show_bug.cgi?id=66536

Patch by Kentaro Hara <haraken@google.com> on 2011-08-31
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#Constructor

[1] Introduced Web IDL 'Constructor' extended attribute.

[2] Added 'ConstructorWith=ScriptExecutionContext' extended attribute.

  • The constructor passes ScriptExecutionContext to a XXX::create() method,

like XXX::create(..., context, ...).

[3] Added 'V8ConstructorSetsActiveDOMWrapper' extended attribute.

  • The constructor calls V8DOMWrapper::setJSWrapperForActiveDOMObject()

instead of V8DOMWrapper::setJSWrapperForDOMObject().

[4] Added 'ConstructorRaisesException' extended attribute.

  • A placeholder for ExceptionCode is passed to a XXX::create() method,

like XXX::create(..., ec).

  • We can use 'ConstructorRaisesException' and 'ConstructorWith=ScriptExecutionContext' together.

Note:

  • Constructor overloading is not yet implemented.
  • We cannot yet specify [Optional] without CallWithDefaultValue.

Test: Source/WebCore/bindings/scripts/test/TestInterface.idl

Source/WebCore/bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Generates constructorCallback() header, if 'Constructor' is specified.
(GenerateFunctionCallback): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateFunctionCallback() for reuse.
(GenerateParametersCheck): Ditto.
(GenerateConstructorCallback): Generates constructorCallback() definition.
(GenerateImplementation):

  • bindings/scripts/IDLParser.pm:

(parseExtendedAttributes): Previously, only a string in the "A=B, C, D, E=F" format can be parsed. This patch enables to parse a string in the "A=B, C, D, E=F, G(in DOMString s, in [H, I, J] DOMString t)" format.
(parseParameters): Splits out of ParseInterface() for reuse.
(ParseInterface): Uses parseParameters().

  • bindings/scripts/IDLStructure.pm: Added domClass{constructor}. Changed the regular expression to extract the list of extended attributes.
  • bindings/scripts/test/TestInterface.idl: Added all the extended attributes that this patch is going to introduce.
  • bindings/scripts/test/TestObj.idl: Added 'Constructor'.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Updated the test result.

(WebCore::V8TestInterface::constructorCallback):
(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
00:02 Changeset [94155] by philn@webkit.org

[GTK] gstreamer/ files directly related to the MediaPlayer need VIDEO guards
https://bugs.webkit.org/show_bug.cgi?id=67196

Reviewed by Martin Robinson.

Guard those files with ENABLE(VIDEO) so other features using
GStreamer can be built even with VIDEO disabled.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCG.mm:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/PlatformVideoWindow.h:
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

08/30/11:

23:59 Changeset [94154] by philn@webkit.org

[webkitpy] missing log import in common/net/resultsjsonparser.py
https://bugs.webkit.org/show_bug.cgi?id=65606

Reviewed by Martin Robinson.

  • Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
23:55 Changeset [94153] by philn@webkit.org

[stylechecker] complains about NULL usage in some gst_structure_ calls
https://bugs.webkit.org/show_bug.cgi?id=67194

Reviewed by Martin Robinson.

Don't warn about NULL in some gst_structure_ calls. 0 can't be
used for these, a proper sentinel is required.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:21 Changeset [94152] by levin@chromium.org

[chromium] Update result due to r94114.

  • platform/chromium-win/svg/custom/pan-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pan-direction-expected.png.
  • platform/chromium/test_expectations.txt:
22:58 Changeset [94151] by levin@chromium.org

[chromium] Update due to r94147.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt.
  • platform/chromium-mac/fast/events/constructors/custom-event-constructor-expected.txt: Added.

Several of these results are failures but that should be fixed by bug 66756.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Added.
21:56 Changeset [94150] by abarth@webkit.org

Remove old-style UI from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67257

Reviewed by Dimitri Glazkov.

This code is nowhere near as awesome as the new hotness. Let's remove
it so it doesn't weigh us down.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
21:45 Changeset [94149] by rniwa@webkit.org

Unreviewed, rolling out r94142, r94144, r94145, and r94148.
http://trac.webkit.org/changeset/94142
http://trac.webkit.org/changeset/94144
http://trac.webkit.org/changeset/94145
http://trac.webkit.org/changeset/94148
https://bugs.webkit.org/show_bug.cgi?id=67262

Broke isindex element (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

Source/WebCore:

  • WebCore.order:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/Node.cpp:

(WebCore::Node::toInputElement):

  • dom/Node.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::isInPasswordField):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::toInputElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebInputElement.cpp:

(WebKit::toWebInputElement):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

21:34 Changeset [94148] by levin@chromium.org

Quick fix for crashing tests caused by r94142.

Tests:

editing/execCommand/remove-format-elements.html
fast/block/child-not-removed-from-parent-lineboxes-crash.html
fast/forms/implicit-submission.html

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Allow
for isIndex element which is derived from HTMLInputElement.

21:04 Changeset [94147] by weinig@apple.com

Add constructor for CustomEvent
https://bugs.webkit.org/show_bug.cgi?id=67248

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

  • bindings/generic/EventConstructors.h:

Add definition for CustomEvent constructor.

  • bindings/js/JSEventConstructors.cpp:

Add CustomEvent #includes.

  • dom/CustomEvent.cpp:

(WebCore::CustomEventInit::CustomEventInit):
(WebCore::CustomEvent::CustomEvent):

  • dom/CustomEvent.h:

(WebCore::CustomEvent::create):
Add Initializer./

  • dom/CustomEvent.idl:

Make constructible.

  • page/DOMWindow.idl:

Add CustomEvent attribute.

LayoutTests:

  • fast/events/constructors/custom-event-constructor-expected.txt: Added.
  • fast/events/constructors/custom-event-constructor.html: Added.

New test.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Updated for add window.CustomEvent.

19:48 Changeset [94146] by commit-queue@webkit.org

[WebSocket] update pywebsocket to 0.6b5.
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
0.6b3 or later supports a closing handshake handler and it is useful to
verify client's closing handshake implementation.
0.6b4 supports AbortedByUserException. It is useful to eliminate
unnecessary server warning messages on intended abnormal closures.
0.6b5 supports Python 2.5.1 or Mac 10.5.

  • Scripts/webkitpy/thirdparty/init.py:

Update download URL and directory path.

19:13 Changeset [94145] by rniwa@webkit.org

GTK build fix after r94142.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

18:41 Changeset [94144] by rniwa@webkit.org

Chromium build fix after r94142.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

18:23 Changeset [94143] by levin@chromium.org

[chromium] New baselines due to r94109.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Removed.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Removed.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Removed.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-style-update-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-style-update-expected.png: Added.
18:20 Changeset [94142] by rniwa@webkit.org

Get rid of toInputElement()
https://bugs.webkit.org/show_bug.cgi?id=67175

Reviewed by Darin Adler.

Source/WebCore:

Got rid of Node::toInputElement and HTMLInputElement::toInputElement and replaced them by
a global toHTMLInputElement.

  • WebCore.order:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/Node.cpp:
  • dom/Node.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::isInPasswordField):

  • html/HTMLInputElement.h:

(WebCore::toHTMLInputElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::toWebInputElement):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

18:14 Changeset [94141] by cevans@google.com

Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7776026

18:10 Changeset [94140] by cevans@google.com

Revert 94131 - Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7811011

18:09 Changeset [94139] by crogers@google.com

Remove AudioContext createChannelMerger() method until thread safety issues can be properly addressed.
BUG=94834
R=cevans@chromium.org
Review URL: http://codereview.chromium.org/7740069

18:05 Changeset [94138] by rniwa@webkit.org

Speculative WinCairo build fix after r94093.

  • platform/network/ResourceHandle.h:
17:29 Changeset [94137] by ojan@chromium.org

add a test for border/padding/margin on the flexbox container
https://bugs.webkit.org/show_bug.cgi?id=67243

Reviewed by Tony Chang.

  • css3/flexbox/001-expected.txt:
  • css3/flexbox/001.html:
  • css3/flexbox/resources/flexbox.js:
17:26 Changeset [94136] by rniwa@webkit.org

Mac build fix after r94128.

  • WebCore.xcodeproj/project.pbxproj:
17:25 Changeset [94135] by cevans@google.com

Merge 94109
BUG=94800
Review URL: http://codereview.chromium.org/7785020

17:21 Changeset [94134] by commit-queue@webkit.org

Correctly report selected text range for accessibility APIs for role=textbox
https://bugs.webkit.org/show_bug.cgi?id=65900

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-30
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/textbox-role-reports-selection.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
(WebCore::AccessibilityRenderObject::rootEditableElementForPosition):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/textbox-role-reports-selection-expected.txt: Added.
  • accessibility/textbox-role-reports-selection.html: Added.
17:18 Changeset [94133] by nduca@chromium.org

Unreviewed, fix WebGL layout tests due to missing WebView pointer.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):

17:13 Changeset [94132] by commit-queue@webkit.org

The "port" property of an <a> whose href does not specify a port returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=66081

Source/WebCore:

HTMLAnchorElement now returns "" instead of "0" for unset port
Fixed KURLGoogle.cpp to have same behavior as KURL.cpp when setting port 0
Fixed Location.cpp to have same behavior as KURL.cpp when setting port 0

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

Tests: fast/dom/HTMLAnchorElement/get-href-attribute-port.html

fast/dom/HTMLAnchorElement/set-href-attribute-port.html
fast/loader/location-port.html
fast/url/segments-from-data-url.html
fast/url/segments.html
fast/url/trivial-segments.html
platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::port):

  • page/Location.cpp:

(WebCore::Location::host):
(WebCore::Location::port):
(WebCore::Location::setPort):

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort):

LayoutTests:

Updated tests to reflect behavior change around invalid port strings.
Updated chromium location-port test to reflect chromium issues

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

  • fast/dom/HTMLAnchorElement/get-href-attribute-port-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/get-href-attribute-port.html: Added.
  • fast/dom/HTMLAnchorElement/script-tests/get-href-attribute-port.js: Added.
  • fast/loader/location-port-expected.txt:
  • fast/loader/location-port.html:
  • fast/url/script-tests/segments-from-data-url.js:
  • fast/url/script-tests/segments.js:
  • fast/url/script-tests/trivial-segments.js:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/trivial-segments-expected.txt:
  • platform/chromium-cg-mac/fast/loader/location-port-expected.txt:
  • platform/chromium-win/fast/loader/location-port-expected.txt:
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:
17:13 Changeset [94131] by cevans@google.com

Merge 94107
BUG=88684
Review URL: http://codereview.chromium.org/7810012

17:03 Changeset [94130] by commit-queue@webkit.org

Fix pan scrolling on Windows to be clamped
https://bugs.webkit.org/show_bug.cgi?id=66910

Source/WebCore:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

Test: platform/win/fast/events/panScroll-correct-direction.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::panScrollFromPoint):
(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:

LayoutTests:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

  • platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png:
  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/win/fast/events/panScroll-correct-direction-expected.txt: Added.
  • platform/win/fast/events/panScroll-correct-direction.html: Added.
17:01 Changeset [94129] by cevans@google.com

Merge 94127
BUG=94820
Review URL: http://codereview.chromium.org/7809009

16:55 Changeset [94128] by commit-queue@webkit.org

This patch makes the XMLHttpRequest method/header validation logic available as
static methods so URL loaders can perform the same checks for untrusted HTTP requests
coming from plugins.
https://bugs.webkit.org/show_bug.cgi?id=66909

Patch by Bill Budge <bbudge@chromium.org> on 2011-08-30
Reviewed by David Levin.

No new tests. Exposes no new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/HTTPValidation.cpp: Added.

(WebCore::isValidHTTPToken):
(WebCore::isValidHTTPHeaderValue):

  • platform/network/HTTPValidation.h: Added.
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::isAllowedHTTPMethod):
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::setRequestHeader):

  • xml/XMLHttpRequest.h:
16:45 Changeset [94127] by crogers@google.com

Don't allow nodes of one context to be connected to nodes of another context
https://bugs.webkit.org/show_bug.cgi?id=67245

Source/WebCore:

Reviewed by Dimitri Glazkov.

Tests: updated webaudio/audionode.html

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
16:42 Changeset [94126] by rniwa@webkit.org

WinCE build fix attempt after r94080.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::scrollRectIntoView):

16:40 Changeset [94125] by cevans@google.com

Merge 94112
BUG=89330
Review URL: http://codereview.chromium.org/7776023

16:36 Changeset [94124] by mitz@apple.com

Source/WebCore: WebCore part of <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

Test: TestWebKitAPI/Tests/mac/DOMRangeOfString.

  • WebCore.exp.in: Export Page::rangeOfString().
  • dom/Range.h: Added a default ASSERT_NO_EXCEPTION to a few more member functions.
  • editing/Editor.cpp:

(WebCore::Editor::findString): Moved most of the logic into rangeOfString(), which this function
now calls, passing in the current selection as the reference range and setting the selection to
the returned range.
(WebCore::Editor::rangeOfString): Added. Contains the find logic from findString().

  • editing/Editor.h:
  • page/Page.cpp:

(WebCore::Page::rangeOfString): Added. This function is similar to findString(), but it takes an optional
reference range and returns a Range, rather than using the current selection as the reference range and setting the
selection to the next match.

  • page/Page.h:

Source/WebKit/mac: <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm:

(coreOptions): Moved this function from WebHTMLView.mm to here and made
it accessible from both this file and WebHTMLView.mm.
(-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Tools: Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.

(-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

16:34 Changeset [94123] by weinig@apple.com

Add additional convertValue overloads to JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=67244

Reviewed by Darin Adler.

Add overloads for convertValue that will be needed for Event
constructors.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

Add overloads. Remove #include of <runtime/Error.h> and just include
<interpreter/CallFrame.h>

  • bindings/js/JSEventConstructors.cpp:

Add now necessary #include of <runtime/Error.h>.

16:31 Changeset [94122] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67150
Would like API to use a custom device scale factor for a particular WebView/WKView
-and corresponding-
<rdar://problem/10041016>

Reviewed by Darin Adler.

Source/WebKit/mac:

New API is _setOverrideBackingScaleFactor:(CGFloat)

  • WebView/WebView.mm:

(-[WebView _setOverrideBackingScaleFactor:]):
(-[WebView _deviceScaleFactor]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

New API is setOverrideBackingScaleFactor() on WKPage

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetOverrideBackingScaleFactor):
(WKPageSetOverrideBackingScaleFactor):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::deviceScaleFactor):
(WebKit::WebPageProxy::setOverrideBackingScaleFactor):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::overrideBackingScaleFactor):

16:15 Changeset [94121] by commit-queue@webkit.org

Add MediaSource API to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=64731

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-30
Reviewed by Eric Carlson.

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Tests: http/tests/media/media-source/webm/video-media-source-errors.html

http/tests/media/media-source/webm/video-media-source-play.html
http/tests/media/media-source/webm/video-media-source-seek.html
http/tests/media/media-source/webm/video-media-source-state-changes.html

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • dom/EventNames.h:
  • features.pri:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Added initializers for new member variables.
(WebCore::HTMLMediaElement::prepareForLoad): Close the media source before starting a new load.
(WebCore::HTMLMediaElement::loadResource):

Fail loading if the media source url from another media element is used.

(WebCore::HTMLMediaElement::mediaEngineError):

Make sure the source is in the closed state before firing an emptied event.

(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):

New method called by WebCore::MediaPlayer to signal when the source is open.

(WebCore::HTMLMediaElement::mediaPlayerSourceURL):

New method called by the WebCore::MediaPlayer to determine what the media source URL is for this
HTMLMediaElement instance.

(WebCore::HTMLMediaElement::seek):

Disabled noSeekRequired optimization if a media source is open and resets the source state to SOURCE_OPEN if
it was in the SOURCE_ENDED state when seek() was called.

(WebCore::HTMLMediaElement::webkitSourceAppend):

New method for passing media data from JavaScript to the WebCore::MediaPlayer.

(WebCore::HTMLMediaElement::webkitSourceEndOfStream):

New method that allows JavaScript to signal the end of the stream.

(WebCore::HTMLMediaElement::webkitSourceState): New method allowing JavaScript to read the current source state.
(WebCore::HTMLMediaElement::setSourceState): New method for updating the current source state.
(WebCore::HTMLMediaElement::userCancelledLoad):

Transitions an open source to the closed state before firing an emptied event.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::webkitMediaSourceURL):

New method providing the media source URL to JavaScript for this HTMLMediaElement instance.

  • html/HTMLMediaElement.idl: Added new methods, attributes, and constants for the media source api.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAppend):

Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceAppend.

(WebCore::NullMediaPlayerPrivate::sourceEndOfStream):

Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceEndOfStream.

(WebCore::MediaPlayer::sourceAppend): New method for receiving media data from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceEndOfStream): New method for receiving end of stream from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceOpened):

New method called by the MediaPlayerPrivate object to notify the MediaPlayer when the source has opened.

(WebCore::MediaPlayer::sourceURL):

New method called by the MediaPlayerPrivate implementation to get the media source URL from the MediaPlayer.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerSourceOpened):

Interface method used by the MediaPlayer to tell the HTMLMediaElement when the media source has been opened.

(WebCore::MediaPlayerClient::mediaPlayerSourceURL):

Interface method used by the MediaPlayer to get the media source URL from the HTMLMediaElement.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAppend):

Interface method used by the MediaPlayer to pass media data to the MediaPlayerPrivate object.

(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream):

Interface method used by the MediaPlayer to pass end of stream information to the MediaPlayerPrivate object.

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAppend):
(WebKit::WebMediaPlayer::sourceEndOfStream):

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):

  • src/WebMediaPlayerClientImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • http/tests/media/media-source/webm/video-media-source-errors-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-errors.html: Added.
  • http/tests/media/media-source/webm/video-media-source-play-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-play.html: Added.
  • http/tests/media/media-source/webm/video-media-source-seek-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-seek.html: Added.
  • http/tests/media/media-source/webm/video-media-source-state-changes-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-state-changes.html: Added.
  • http/tests/media/media-source/webm/webm-media-source.js: Added.

(getData):
(getHeaders):
(getClusterCount):
(getCluster):
(getClusterTimeForIndex):
(getClusterIndexForTimestamp):
(setSrcToMediaSourceURL):
(appendHeaders):
(appendCluster):
(appendUntilEndOfStream):
(logSourceState):
(getSourceStateName):
(expectSourceState):

  • http/tests/media/resources/media-source/webm/test.webm: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-0: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-1: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-10: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-11: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-12: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-13: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-14: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-15: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-2: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-3: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-4: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-5: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-6: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-7: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-8: Added.
  • http/tests/media/resources/media-source/webm/test.webm.cluster-9: Added.
  • http/tests/media/resources/media-source/webm/test.webm.headers: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
16:09 Changeset [94120] by inferno@chromium.org

Unreviewed. Chromium rebaselines for r94109.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-before-child-style-update-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-style-update-expected.png: Added.
15:49 Changeset [94119] by weinig@apple.com

Refactor JS dictionary code into helper class and covert geolocation code to use it
https://bugs.webkit.org/show_bug.cgi?id=67213

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add new files.

  • bindings/js/JSDictionary.cpp: Added.

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h: Added.

(WebCore::JSDictionary::JSDictionary):
(WebCore::JSDictionary::tryGetProperty):
Encapsulate dictionary initialization code into JSDictionary class.

  • bindings/js/JSEventConstructors.cpp:

(WebCore::constructJSEventWithInitializer):
Use JSDictionary.

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::setEnableHighAccuracy):
(WebCore::setTimeout):
(WebCore::setMaximumAge):
(WebCore::createPositionOptions):
Use JSDictionary.

15:39 Changeset [94118] by commit-queue@webkit.org

Switch chromium to use ScrollAnimatorNone on Windows.
https://bugs.webkit.org/show_bug.cgi?id=67000

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

Testing covered by Chromium webkit_unit_tests ScrollAnimatorNoneTest.*

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
15:33 Changeset [94117] by tony@chromium.org

refactor and cleanup RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=67165

Reviewed by Ojan Vafai.

No new tests, just refactoring code.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal): Make childSizes a param so we can pass the results to layoutAndPlaceChildrenHorizontal.
(WebCore::hasPackingSpace): Move closer to where it's used.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):

Pull this code out into its own function because it's not part of running the free space allocation algorithm.

  • rendering/RenderFlexibleBox.h:
15:12 Changeset [94116] by timothy_horton@apple.com

getBBox() on a SVGPathElement with curves incorrectly includes control points
https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Dirk Schulze.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

15:09 Changeset [94115] by adachan@apple.com

Laying some groundwork to fetch performance statistics from WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Add WKContextGetStatistics() which sends a message to WebProcess to fetch the performance statistics.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::getWebCoreStatistics):
(WebKit::WebContext::didGetWebCoreStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add the DidGetWebCoreStatistics message that WebProcess can send when it has

the performance statistics ready.

Add WebProcess::getWebCoreStatistics(). Currently it just sends back an empty StatisticsData object.
It will gather the performance statistics to store in the StatisticsData object in a future patch.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add the skeleton for StatisticsData.

  • Scripts/webkit2/messages.py:
  • Shared/StatisticsData.cpp: Added.

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
(WebKit::StatisticsData::StatisticsData):

  • Shared/StatisticsData.h: Added.

Add StatisticsData.h/cpp to project.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:02 Changeset [94114] by timothy_horton@apple.com

SVG panning y-axis is flipped in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=65800
<rdar://problem/9908012>

Reviewed by Darin Adler.

We previously were not transforming the pointer coordinates passed
to SVGDocument's panning implementation into the coordinate space of
the contents, so on different platforms, the drag direction was different.

Test: svg/custom/pan-direction.svg

14:37 Changeset [94113] by caryclark@google.com

LayoutTest expected results for Skia on Mac (animations and canvas directories only)
https://bugs.webkit.org/show_bug.cgi?id=67218

Reviewed by Adam Barth.

  • platform/chromium-mac/animations: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac/animations/state-at-end-event-expected.png: Added.
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
  • platform/chromium-mac/canvas: Added.
  • platform/chromium-mac/canvas/philip: Added.
  • platform/chromium-mac/canvas/philip/tests: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.operation.clear-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.operation.darker-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.outside3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.object.round-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.object.wrap-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.missingargs-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.5-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.string-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.norepeat.coord3-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeatx.coord1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeaty.coord1-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.align.center-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/type.prototype-expected.txt: Added.
14:31 Changeset [94112] by abarth@webkit.org

Flaky crash with JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=66360

Reviewed by Nate Chapin.

Source/WebCore:

This patch teaches DocumentWriter::begin to make a copy of the URL
before beginning a new document to avoid a crash.

Test: fast/loader/javascript-url-iframe-crash.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

LayoutTests:

  • fast/loader/javascript-url-iframe-crash-expected.txt: Added.
  • fast/loader/javascript-url-iframe-crash.html: Added.
14:27 Changeset [94111] by tonyg@chromium.org

PreloadScanner shouldn't load images inside noscript via doc.write
https://bugs.webkit.org/show_bug.cgi?id=67214

Reviewed by Adam Barth.

Source/WebCore:

The problem was that the tokenizer state was lost between each call to document.write.
This works around that bug by making all document.write()s in the same script block share
the same tokenizer state.

Test: fast/preloader/document-write-noscript.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLDocumentParser.h:

LayoutTests:

  • fast/preloader/document-write-noscript-expected.txt: Added.
  • fast/preloader/document-write-noscript.html: Added.
14:25 Changeset [94110] by dimich@chromium.org

https://bugs.webkit.org/show_bug.cgi?id=67210
[Chromium] Use after free in ScheduledAction::execute(WebCore::V8Proxy*)

Reviewed by David Levin.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):
Removed usage of V8Proxy instance after it could have been deleted.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):

  • bindings/v8/V8Proxy.h:

Removed unused timerCallback() and setTimerCallback().

14:22 Changeset [94109] by inferno@chromium.org

Source/WebCore: Style not updated for table parts in :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=66141

Reviewed by Dave Hyatt.

Tests: fast/table/table-before-child-style-update.html

fast/table/table-row-before-child-style-update.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests: Style not updated for table parts in :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=66141

  1. 2 new tests show that the blue and green boxes don't overlap

after the fix.

  1. update r93794 tests showing that style info is propagated.

Reviewed by Dave Hyatt.

  • fast/table/table-before-child-style-update-expected.png: Added.
  • fast/table/table-before-child-style-update-expected.txt: Added.
  • fast/table/table-before-child-style-update.html: Added.
  • fast/table/table-row-before-child-style-update-expected.png: Added.
  • fast/table/table-row-before-child-style-update-expected.txt: Added.
  • fast/table/table-row-before-child-style-update.html: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
13:53 Changeset [94108] by tony@chromium.org

refactor box-ordinal-group handling so we don't timeout on large values
https://bugs.webkit.org/show_bug.cgi?id=65783

Reviewed by David Hyatt.

Source/WebCore:

The old code walked from 1 to the last box-ordinal-group while
iterating over each flex item. The new code collects ordinals as
we do the first walk and sorts them. Each additional iteration
through the flex items gets the next oridnal from the sorted list.

This maintains the single pass for the common case of no
box-ordinal-groups specified. If there are ordinal groups,
the runtime is O(n*m + m lg m) where n is the # of flex items and
m is the number of unique box-ordinal-group values. The memory
usage is O(2m).

Test: fast/flexbox/box-ordinal-group.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):
(WebCore::FlexBoxIterator::compareFlexOrder):

LayoutTests:

  • fast/flexbox/box-ordinal-group-expected.txt: Added.
  • fast/flexbox/box-ordinal-group.html: Added.
13:45 Changeset [94107] by inferno@chromium.org

Removed m_owner accessed in custom scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=64737

Reviewed by David Hyatt.

Problem does not reproduce in DRT, even with Eventhandler tricks
and gc(). So, adding a manual test.

  • manual-tests/custom-scrollbar-renderer-removed-crash.html: Added.
  • page/FrameView.cpp:

(WebCore::FrameView::clearOwningRendererForCustomScrollbars):

  • page/FrameView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed): when this renderbox is getting
destroyed, clear the custom scrollbar in this frameview having this renderbox
as its owning renderer.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::getScrollbarPseudoStyle): fix the null check.

13:43 Changeset [94106] by nduca@chromium.org

[chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts
https://bugs.webkit.org/show_bug.cgi?id=67179

Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::create):
(WebCore::GraphicsContext3DInternal::createFromWebContext):
(WebCore::GraphicsContext3D::create):

  • src/GraphicsContext3DInternal.h:
  • tests/MockGraphicsContext3DTest.cpp: Renamed from Source/WebKit/chromium/tests/MockWebGraphicsContext3DTest.cpp.

(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):
(TEST):

13:42 Changeset [94105] by caio.oliveira@openbossa.org

Emit last progress notification before calling dispatchDidFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=28851

Reviewed by Adam Barth.

Source/WebCore:

Original patch by Xan Lopez. Change FrameLoader to dispatch the notifications in
a more natural sequence.

Test: http/tests/loading/progress-finished-callback.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

Source/WebKit/qt:

Add infrastructure to dump progressFinishedNotification callback in DRT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::dumpProgressFinishedCallback):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):

  • WebCoreSupport/FrameLoaderClientQt.h:

Tools:

Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
Chromium and GTK ports. The first two were simple changes.

Some refactoring was needed in GTK port to assure that the dumps are emitted
correctly and the processing after the page load finished is in the right place.

To detect the load finished, we use the callback for the "load-status" notifier
signal of the top loading frame. And we use the deprecated "load-finished" signal
for dumping (if enabled) the progress finished expected output.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpProgressFinishedCallbackCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpProgressFinishedCallback):
(LayoutTestController::setDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpProgressFinishedCallback):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController::setShouldDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didStopLoading):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewLoadFinished):
(topLoadingFrameLoadFinished):
(webFrameLoadStatusNotified):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):
(LayoutTestController::dumpProgressFinishedCallback):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Keep track of the order expected for the progressFinishedNotification, which is
before the didFinishLoadForFrame.

  • http/tests/loading/progress-finished-callback-expected.txt: Added.
  • http/tests/loading/progress-finished-callback.html: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
13:39 Changeset [94104] by ojan@chromium.org

CSS parsing for -webkit-flex-flow
https://bugs.webkit.org/show_bug.cgi?id=67224

Source/WebCore:

Reviewed by Tony Chang.

Adds support for the first value of -webkit-flex-flow.
Later we'll need to add support for the second "wrap" value,
but that can wait until we are ready to implement multiline
flex and the spec has stabilized a bit.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexFlow):
(WebCore::InheritedFlags::setFlexFlow):
(WebCore::InheritedFlags::initialFlexFlow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Reviewed by Tony Chang.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
13:26 Changeset [94103] by fpizlo@apple.com

JavaScriptCore does not have a good mechanism for performance
regression testing
https://bugs.webkit.org/show_bug.cgi?id=67177

Reviewed by Darin Adler.

Added a new script, which allows for testing one, two, or more VMs
at once on SunSpider, V8, and Kraken benchmarks. Benchmark/VM runs
are interleaved at random to minimize systematics. The results
that bencher prints includes all possible relevant information about
how bencher was invoked. Bencher can be easily used to measure
performance changes down to fractions of a percent.

Bencher also includes experimental support for running benchmarks in
a DumpRenderTree release build. This works in SunSpider and V8, but
not yet in Kraken. Running benchmarks in DumpRenderTree more
closely mimics the performance when running in browser.

  • Scripts/bencher: Added.
13:23 Changeset [94102] by abarth@webkit.org

[Chromium] Add null checks for document()->loader()
https://bugs.webkit.org/show_bug.cgi?id=67077

Reviewed by Nate Chapin.

Document::loader can return 0 for a number of reasons. Call sites need
to null check the result, like we do for Document::frame. I suspect
some of these are real crashes, along the lines of
http://trac.webkit.org/changeset/93692, but null checking this function
is just good practice.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

  • src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageEncoding):

13:17 Changeset [94101] by commit-queue@webkit.org

[Qt] Replace QLibrary("libgtk-x11-2.0.so.0") with QLibrary("libgtk-x11-2.0", 0)
https://bugs.webkit.org/show_bug.cgi?id=66627

Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-30
Reviewed by Simon Hausmann.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::initializeGtk):

13:10 Changeset [94100] by levin@chromium.org

[chromium] Add baselines for due to r94092 and r93909.

  • platform/chromium-cg-mac/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-cg-mac/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-linux/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:08 Changeset [94099] by ap@apple.com

fast/loader/document-destruction-within-unload.html causes an assertion failure in the next
test (currently, document-with-fragment-url-1.html)
https://bugs.webkit.org/show_bug.cgi?id=66783

  • platform/mac/Skipped: Skipping the offending test.
13:06 Changeset [94098] by lforschler@apple.com

Merge r93934.

13:01 Changeset [94097] by lforschler@apple.com

Rollout 93664.

12:26 Changeset [94096] by darin@chromium.org

2011-08-29 Darin Fisher <darin@chromium.org>

[chromium] DumpRenderTree should be explicit about its dependency on
GoogleURL
https://bugs.webkit.org/show_bug.cgi?id=67169

Reviewed by Ryosuke Niwa.

DumpRenderTree uses GoogleURL code directly, and it should be explicit
about that instead of picking up this dependency transitively, which
only works for the static build.

This is needed to support the "component" build of DumpRenderTree, in
which the various Chromium dependencies are built as separate DLLs.

  • WebKit.gyp:
12:13 Changeset [94095] by oliver@apple.com

TypedArrays don't ensure that denormalised values are normalised
https://bugs.webkit.org/show_bug.cgi?id=67178

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add test to ensure that we create a non-signalling nan when reading
a singaling nan from a typed array.

  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a couple of assertions to jsNumber() to ensure that
we block signaling NaNs

  • runtime/JSValue.h:

(JSC::jsDoubleNumber):
(JSC::jsNumber):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Ensure that we convert singaling nans to silent nans when loading
from a typed array.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

12:03 Changeset [94094] by levin@chromium.org

[chromium] Update baselines after r94084 and r94088 and r93909.

  • platform/chromium-cg-mac/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/positive-leading-expected.png: Added.
  • platform/chromium-win/fast/multicol/positive-leading-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
11:57 Changeset [94093] by ap@apple.com

DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>

Reviewed by Darin Adler.

Use a clean CFURLStorageSession when this functionality is available.

  • WebCore.exp.in: Added exports.
  • WebCore.xcodeproj/project.pbxproj: Made CookieStorageCFNet.h private, as currentCFHTTPCookieStorage is used in WebKit.
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::setCookies): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): Updated to use currentCFHTTPCookieStorage().
  • platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.
  • platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp.
  • platform/network/ResourceHandle.h: Exposed default session support on Mac, too. Made privateBrowsingStorageSession() private, as callers shouldn't be concerned about where the current sssion came from.
  • platform/network/cf/CookieJarCFNet.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): (WebCore::getHostnamesWithCookies): (WebCore::deleteCookiesForHostname): (WebCore::deleteAllCookies): Updated to use currentCFHTTPCookieStorage().
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API. (WebCore::overrideCookieStorage): Ditto. (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable, unless it has been overridden on Windows. We can always get it from a session. (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just use private session's storage. Note that Mac has a separate code path for OS versions that don't support sessions. (WebCore::startObservingCookieChanges): Updated to use currentCFHTTPCookieStorage(). (WebCore::stopObservingCookieChanges): Ditto.
  • platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK), as this function is also used with NSURLConnection when sessions are enabled. (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session is now supported on Mac, too. (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK). (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer adopt the session, because nothing in method name says that it will steal a reference from the caller. (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK). (WebCore::privateStorageSession): Moved from ResourceHandle.cpp. (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.
  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): We no longer store a reference to cookie storage in a static variable, so nothing to do here. On older OS versiosn, we still need to enable legacy private browsing mode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function. (WebCore::ResourceHandle::createNSURLConnection): Updated to use currentStorageSession() instead of privateBrowsingStorageSession(). (WebCore::ResourceHandle::willSendRequest): Ditto.
11:28 Changeset [94092] by hyatt@apple.com

<rdar://problem/10002140> 9A309: Text gets clipped in book because of overflow:auto

https://bugs.webkit.org/show_bug.cgi?id=67212 - Text gets clipped in multi-column layouts when overflow:auto
is used.

Revise our overflow:auto pagination behavior. If the overflow block doesn't specify any logical height
information, then we'll just assume the plan is for it to enclose its contents, and we will be willing
to paginate in those circumstances.

Reviewed by Dan Bernstein.

Added overflow-across-columns.html and overflow-unsplittable.html

Source/WebCore:

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasUnsplittableScrollingOverflow):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/multicol/overflow-across-columns.html: Added.
  • fast/multicol/overflow-unsplittable.html: Added.
  • platform/mac/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/mac/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/mac/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/mac/fast/multicol/overflow-unsplittable-expected.txt: Added.
10:58 Changeset [94091] by tony@chromium.org

Fix chromium compile when using clang. Another compile error due
to r94080.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::scrollRectIntoView):

10:47 Changeset [94090] by commit-queue@webkit.org

Unreviewed, rolling out r93924.
http://trac.webkit.org/changeset/93924
https://bugs.webkit.org/show_bug.cgi?id=67209

Bad baseline submitted for OS X. Should be chromium specific.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
10:43 Changeset [94089] by antti@apple.com

querySelector/querySelectorAll should use selector checker fast path
https://bugs.webkit.org/show_bug.cgi?id=67161

Reviewed by Sam Weinig.

Descendant and child selectors can be matches substantially faster using
SelectorChecker::fastCheckSelector() path. Currently it is used for style matching only.

Add SelectorQuery class that can do both querySelector and querySelectorAll efficiently using
fast path. Use inlined loop for DOM traversal.

The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/.
Some individual subtests (using child or descendant selectors) execute twice as fast.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::isFastCheckableSelector):
(WebCore::RuleData::RuleData):

  • css/CSSStyleSelector.h:


Make fast path checking available outside CSSStyleSelector.


  • dom/DOMAllInOne.cpp:
  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

Switch to SelectorQuery.


  • dom/SelectorNodeList.cpp: Removed.
  • dom/SelectorNodeList.h: Removed.


SelectorQuery makes these obsolete.

  • dom/SelectorQuery.cpp: Added.

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):

  • dom/SelectorQuery.h: Added.


Class for selector matching in tree.

10:35 Changeset [94088] by dimich@chromium.org

REGRESSION (r93913): Failures in fast/replaced/frame-removed-during-resize.html and scrollbars/scrollable-iframe-remove-crash.html
https://bugs.webkit.org/show_bug.cgi?id=67074

Reviewed by Darin Adler.

Added flag m_isClosed to prevent events that cause Frame to be destroyed
from posting more events into EventQueue of a dying Document.

The tests mentioned above should now pass.

  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/EventQueue.cpp:

(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::close): Renamed method to reflect better what it does.

  • dom/EventQueue.h:
10:34 Changeset [94087] by alexis.menard@openbossa.org

[Qt][WK2] Make mouse over work again for QDesktopWebView.
https://bugs.webkit.org/show_bug.cgi?id=67200

Reviewed by Noam Rosenthal.

The API has changed after QGraphicsView, SceneGraph sends
QHoverEvents now.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverMoveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
10:09 Changeset [94086] by tony@chromium.org

Roll chromium DEPS to r98771.

  • DEPS:
10:06 Changeset [94085] by tony@chromium.org

Fix compile warning on clang:
error: 'WebKit::ChromeClientImpl::scrollRectIntoView' hides overloaded virtual function [-Werror,-Woverloaded-virtual]

virtual void scrollRectIntoView(


../../WebCore/page/ChromeClient.h:171:22: note: hidden overloaded virtual function 'WebCore::ChromeClient::scrollRectIntoView' declared here

virtual void scrollRectIntoView(const IntRect&) { }; Currently only Mac has a non empty implementation.

  • page/ChromeClient.h:

(WebCore::ChromeClient::scrollRectIntoView):

09:57 Changeset [94084] by hyatt@apple.com

<rdar://problem/8832814> With large line-height, column break can happen anywhere in the
inter-line gap, causing staggered lines.

https://bugs.webkit.org/show_bug.cgi?id=67202 Handle positive leading when paginating lines.

Technically we should paginate lines based solely off their line top and line bottom with
leading included. However there are two issues with always doing so. The first is that overflow
can cause lines to overlap, and the second is that negative leading can cause lines to overlap.

Since we're incapable of dealing with overlap until we stop clipping column boxes and allow them
to have a form of specialized overflow, we still have to at least factor in overflow and ignore
negative leading for now. However we can at least honor positive leading when the lines don't
overlap. This patch provides basic support for paginating when positive leading is involved.

Reviewed by Dan Bernstein.

Added fast/multicol/positive-leading.html.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markLinesDirtyInBlockRange):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

(WebCore::RenderBlock::adjustLinePositionForPagination):
Grow the top and extent of the line to include our leading when deciding how to paginate
the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::lineTopWithLeading):
(WebCore::RootInlineBox::lineBottomWithLeading):
(WebCore::RootInlineBox::setLineTopBottomPositions):
Instead of one member variable, blockLogicalHeight(), RootInlineBoxes now know both their top and
bottom including leading. These values are obtainable using lineTopWithLeading() and lineBottomWithLeading().
Add these two values to the setLineTopBottomPositions setter and remove setBlockLogicalHeight.

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutRootBox):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

LayoutTests:

  • fast/multicol/positive-leading.html: Added.
  • platform/mac/fast/multicol/positive-leading-expected.png: Added.
  • platform/mac/fast/multicol/positive-leading-expected.txt: Added.
09:55 Changeset [94083] by cmarrin@apple.com

Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Reviewed by Kenneth Russell.

Source/WebCore:

  • GNUmakefile.list.am:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

  • platform/graphics/gtk/GraphicsContext3DInternal.h: Removed.
  • platform/graphics/gtk/GraphicsContext3DPrivate.h: Copied from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.h.
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::getViewportGLWidget):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::boundingRect):
(WebCore::GraphicsContext3DPrivate::paint):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::platformLayer):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):

  • src/GraphicsContext3DInternal.h: Removed.
  • src/GraphicsContext3DPrivate.h: Copied from Source/WebKit/chromium/src/GraphicsContext3DInternal.h.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::graphicsContext3D):

09:35 Changeset [94082] by tony@chromium.org

Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on webcore_bindings_sources
and compiles these files. Previously, the other webcore libs (webcore_svg,
webcore_html, webcore_remaining, etc) depended on webcore_bindings. This changes the
dependency on webocre_bindings_sources so the build can parallelize the compile of
webcore_bindings and the other webcore_* libs.

No new tests, just changing the build dependencies. Manually copy over the
include dirs that we used to get from webcore_bindings' direct_dependent_settings.

  • WebCore.gyp/WebCore.gyp:
09:35 Changeset [94081] by commit-queue@webkit.org

[Qt][WK2] svg/animations/animate-end-attribute.html r93949
https://bugs.webkit.org/show_bug.cgi?id=67130

Skip a svg test on WebKit2 that rely on unimplemented test harness API.

Patch by Young Han Lee <joybro@company100.net> on 2011-08-30
Reviewed by Noam Rosenthal.

  • platform/wk2/Skipped:
09:10 Changeset [94080] by commit-queue@webkit.org

The unused ScrollView* argument can and should be removed from
scrollRectIntoView.
https://bugs.webkit.org/show_bug.cgi?id=67117

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::scrollRectIntoView):

  • page/Chrome.cpp:

(WebCore::Chrome::scrollRectIntoView):

  • page/ChromeClient.h:

(WebCore::ChromeClient::scrollRectIntoView):

Source/WebKit/chromium:

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::scrollRectIntoView):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::scrollRectIntoView):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::scrollRectIntoView):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::scrollRectIntoView):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::scrollRectIntoView):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollRectIntoView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
09:00 Changeset [94079] by commit-queue@webkit.org

Update registerProtocolHandler scheme whitelist to match spec
https://bugs.webkit.org/show_bug.cgi?id=67104

Patch by Ben Wells <benwells@chromium.org> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

  • page/Navigator.cpp:

(WebCore::initProtocolHandlerWhitelist):

LayoutTests:

  • fast/dom/register-protocol-handler-expected.txt:
  • fast/dom/register-protocol-handler.html:
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt:
08:28 Changeset [94078] by vsevik@chromium.org

Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Reviewed by Pavel Feldman.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFailLoading):

08:16 Changeset [94077] by commit-queue@webkit.org

Unreviewed, rolling out r94076.
http://trac.webkit.org/changeset/94076
https://bugs.webkit.org/show_bug.cgi?id=67201

Results will be different on each platform (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

  • fast/multicol/huge-column-count-expected.png: Removed.
  • fast/multicol/inherit-column-values-expected.png: Removed.
  • fast/multicol/initial-column-values-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
07:41 Changeset [94076] by apavlov@chromium.org

Unreviewed, add missing multicol test baselines.

  • fast/multicol/huge-column-count-expected.png: Added.
  • fast/multicol/inherit-column-values-expected.png: Added.
  • fast/multicol/initial-column-values-expected.png: Added.
  • platform/chromium/test_expectations.txt: Remove huge-column-count-expected.png MISSING expectation.
06:57 Changeset [94075] by ademar.reis@openbossa.org

[Qt] Do not unconditionally use pkg-config in .pro files
https://bugs.webkit.org/show_bug.cgi?id=67055

Reviewed by Andreas Kling.

Original patch from Rohan McGovern <rohan.mcgovern@nokia.com>

Using the first pkg-config in PATH is prone to errors when cross
compiling inside the Qt repository (using Qt's build-system).

This patch protect calls for pkg-config with
!contains(QT_CONFIG, no-pkg-config). no-pkg-config is added to
QT_CONFIG by Qt's 'configure' when cross-compiling on systems
without pkg-config.

The respective change in Qt's configure has been submited already.

No new tests as this is just a build change.

Source/JavaScriptCore:

  • wtf/wtf.pri: protect pkg-config calls

Source/WebCore:

  • features.pri: protect pkg-config calls
06:16 Changeset [94074] by commit-queue@webkit.org

HTMLImageElement: Don't cache "ismap" and "usemap" attributes.
https://bugs.webkit.org/show_bug.cgi?id=66784

Patch by Andreas Kling <kling@webkit.org> on 2011-08-30
Reviewed by Darin Adler.

  • html/HTMLImageElement.h: Remove the "ismap" and "usemap" members,

shrinking HTMLImageElement by 16 bytes (on 64-bit.)

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::parseMappedAttribute): Most of the logic
for "ismap" and "usemap" moved into isServerMap().
(WebCore::HTMLImageElement::isServerMap): Out-of-lined and implemented
using fast*Attribute().

05:39 Changeset [94073] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-4.8/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt-4.8/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
05:27 Changeset [94072] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip now passing tests.
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
  • platform/qt/fast/borders/border-fit-2-expected.png: Added.
  • platform/qt/fast/borders/border-fit-2-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
05:18 Changeset [94071] by apavlov@chromium.org

REGRESSION(93978): inspector/styles/styles-computed-trace.html fails
https://bugs.webkit.org/show_bug.cgi?id=67185

Reviewed by Yury Semikhatsky.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:
  • platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
05:14 Changeset [94070] by yurys@chromium.org

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations for userscripts/window-onerror-for-isolated-world-1.html

  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt:
05:04 Changeset [94069] by kbalazs@webkit.org

[Qt] 3 test started crashing somewhere between r93878-r93935
https://bugs.webkit.org/show_bug.cgi?id=67197

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-08-30

  • platform/qt/Skipped:
04:23 Changeset [94068] by rniwa@webkit.org

lastChangeWasUserEdit continues to return true when innerText or textContent is modified
https://bugs.webkit.org/show_bug.cgi?id=67183

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by calling setLastChangeWasNotUserEdit in HTMLTextAreaElement::childrenChanged.

Also got rid of HTMLTextFormControlElement::subtreeHasChanged because it was a needless indirection.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): No longer calls HTMLTextFormControlElement::subtreeHasChanged.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged): Calls setLastChangeWasNotUserEdit.
(WebCore::HTMLTextAreaElement::subtreeHasChanged): No longer calls HTMLTextFormControlElement::subtreeHasChanged.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::defaultEventHandler): Merged subtreeHasChanged.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): No longer set m_lastChangeWasUserEdit to false
since this is now done when renderers are set dirty.

  • html/HTMLTextFormControlElement.h: Made subtreeHasChanged a pure virtual function.

LayoutTests:

Two test cases now pass.

  • fast/forms/textfield-lastchange-was-useredit-expected.txt:
03:57 Changeset [94067] by yurys@chromium.org

Web Inspector: wrong script display name when there is a slash in its URL query parameters
https://bugs.webkit.org/show_bug.cgi?id=67120

Source/WebCore:

Fixed folder name computation in ScriptsPanel. Now search query is ignored
when searching for the script folder name.

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
03:54 Changeset [94066] by yurys@chromium.org

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update window.onerror tests after r94061 to match new semantics
of window.onerror return value.

  • fast/workers/resources/shared-worker-script-error.js:
  • http/tests/security/cross-origin-script-window-onerror-redirected.html:
  • http/tests/security/cross-origin-script-window-onerror.html:
  • userscripts/window-onerror-for-isolated-world-1.html:
  • userscripts/window-onerror-for-isolated-world-2.html:
03:25 Changeset [94065] by yurys@chromium.org

2011-08-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for new test.

  • platform/chromium/fast/events/window-onerror13-expected.txt: Added.
03:05 Changeset [94064] by commit-queue@webkit.org

Unreviewed, rolling out r94055 and r94057.
http://trac.webkit.org/changeset/94055
http://trac.webkit.org/changeset/94057
https://bugs.webkit.org/show_bug.cgi?id=67191

Many failures on Mac 10.5 (Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

Tools:

  • Scripts/webkitpy/thirdparty/init.py:

LayoutTests:

  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py:
02:39 Changeset [94063] by commit-queue@webkit.org

[EFL] Add const modifier to passed objects where it's recommended
https://bugs.webkit.org/show_bug.cgi?id=67110

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-30
Reviewed by Kent Tamura.

Add const modifier to passed Evas_Object if the function doesn't change its
property (the most cases to the getter functions).

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_item_list_get):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_custom_get):
(ewk_context_menu_show):

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_text_matches_nth_pos_get):
(ewk_frame_text_selection_type_get):
(ewk_frame_source_get):
(ewk_frame_resources_location_get):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_get):
(ewk_view_imh_get):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_page_cache_get):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_page_rect_get):
(ewk_view_mode_get):

  • ewk/ewk_view.h:
  • ewk/ewk_window_features.cpp:

(ewk_window_features_bool_property_get):
(ewk_window_features_int_property_get):

  • ewk/ewk_window_features.h:
02:36 Changeset [94062] by reni@webkit.org

[Qt] Qt Linux Release bot has four failed tests.
They are skipped.

Unreviewed gardening.

  • platform/qt/Skipped:
02:28 Changeset [94061] by yurys@chromium.org

Return value of window.onerror has inverted semantics
https://bugs.webkit.org/show_bug.cgi?id=67119

Source/WebCore:

Error is now treated as handled only when window.onerror function returns true.

Reviewed by Darin Adler.

Test: fast/events/window-onerror13.html

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

LayoutTests:

Reviewed by Darin Adler.

  • fast/events/window-onerror1.html:
  • fast/events/window-onerror11.html:
  • fast/events/window-onerror12.html:
  • fast/events/window-onerror13-expected.txt: Added.
  • fast/events/window-onerror13.html: Copied from LayoutTests/fast/events/window-onerror11.html.
  • fast/events/window-onerror2.html:
  • fast/events/window-onerror3.html:
  • fast/events/window-onerror4.html:
  • fast/events/window-onerror5.html:
  • fast/events/window-onerror6.html:
  • fast/events/window-onerror8.html:
  • fast/events/window-onerror9.html:
  • fast/workers/resources/worker-script-error-bubbled.js:

(onerror):

  • fast/workers/resources/worker-script-error-handled.js:

(onerror):

  • http/tests/security/window-onerror-exception-in-iframe.html:
02:09 Changeset [94060] by abarth@webkit.org

Chromium Android should not be a core builder
https://bugs.webkit.org/show_bug.cgi?id=67184

Reviewed by Ryosuke Niwa.

This bot hasn't been consistently green yet because it has never actually run!

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
01:07 Changeset [94059] by tkent@chromium.org

Merge 94045 - REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

  • fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
  • fast/forms/file/disabling-file-busy-loop.html: Added.

TBR=tkent@chromium.org
BUG=94710
Review URL: http://codereview.chromium.org/7792032

01:04 Changeset [94058] by jeremy@chromium.org

Merge 92809 - Crash when clicking an SVG <a> link to the local document
https://bugs.webkit.org/show_bug.cgi?id=66019
<rdar://problem/9933311>

Reviewed by Rob Buis.

Source/WebCore:

Check if the target element of an internal link is valid before
making use of it.

Test: svg/custom/click-internal-anchor-with-use-crash.xhtml

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add a test which programmatically clicks a link referring to "#",
and should crash between r89745 and this commit.

  • svg/custom/click-internal-anchor-with-use-crash-expected.txt: Added.
  • svg/custom/click-internal-anchor-with-use-crash.xhtml: Added.

TBR=timothy_horton@apple.com
Review URL: http://codereview.chromium.org/7807001

01:02 Changeset [94057] by commit-queue@webkit.org

[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67182

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

Some layout tests for WebSocket raised Exception to prevent unnecessary
pywebsocket warning. But it doesn't work any more on pywebsocket 0.6b4.
Now pywebsocket support AbortedByUserException to prevent warning.
This change make raise AbortedByUserException instead of Exception.

handshake-fail-by-prepended-null_wsh.py didn't use Exception, but
expected abnormal closure on sending response could raise unexpected
Exception by chance. This change also takes care of it.

  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
  • http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/hybi/masked-frames_wsh.py:

Use AbortedByUserException instead of Exception.

00:54 Changeset [94056] by rniwa@webkit.org

Cleanup after r94050 and r94054.

  • Source/autotools/symbols.filter:
00:47 Changeset [94055] by commit-queue@webkit.org

[WebSocket] update pywebsocket to 0.6b4.
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
0.6b3 or later supports a closing handshake handler and it is useful to
verify client's closing handshake implementation.
0.6b4 supports AbortedByUserException. It is useful to eliminate
unnecessary server warning messages on intended abnormal closures.

  • Scripts/webkitpy/thirdparty/init.py:

Update download URL and directory path.

00:43 Changeset [94054] by philn@webkit.org

Unreviewed, another attempt to fix GTK build after r94038.

  • Source/autotools/symbols.filter:

08/29/11:

23:40 Changeset [94053] by rniwa@webkit.org

Touch Internals.cpp in an attempt to fix GTK+ build.

  • testing/Internals.cpp:
23:37 Changeset [94052] by commit-queue@webkit.org

Fix two layout tests which fails on Qt port with latest pywebsocket.
https://bugs.webkit.org/show_bug.cgi?id=66929

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-29
Reviewed by Kent Tamura.

hanging-handshake_wsh.py read socket to hang in opening handshake.
Then client initiated closing handshakes or abnormal closures caused
exception or resulted in http error response on hybi-10 compliant new
pywebsocket. Because tests finished at closure, it depends on timing
whether tests detects the error response. Actually, two tests failed on
Qt port by chance.
Essentially, hangings is unnecessary because open event must be queued
and WebSocket's readyState could not be changed to OPEN until the next
event loop is executed. That's why we can use echo_wsh.py instead of
hanging-handshake_wsh.py safely.

close-unref-websocket tests call close() before GC. These tests expect
GC cause close event. But close() itself also queues close event.
These close() are redandant. If GC doesn't cause close event, these
tests can pass by close event that close() queues. This change also
remove these redandant close() calls.

  • http/tests/websocket/tests/hixie76/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-before-open.html:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

  • http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/hybi/close-unref-websocket.html:

Used echo_wsh.py, remove ws.close() and fix expectation.

  • http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:

Use echo_wsh.py instead of hanging-handshake_wsh.py.

23:29 Changeset [94051] by rniwa@webkit.org

Another Windows build fix after r94047.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
23:19 Changeset [94050] by rniwa@webkit.org

Build fix attempt after r94038.

  • Source/autotools/symbols.filter:
23:07 Changeset [94049] by rniwa@webkit.org

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):

22:55 Changeset [94048] by levin@chromium.org

[chromium] Add exception due to missing results for r94037.

  • platform/chromium/test_expectations.txt:
22:51 Changeset [94047] by rniwa@webkit.org

Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement.

Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement
and related inline functions from RenderTextControl to HTMLTextFormControlElement.
Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated,
added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement
and HTMLTextAreaElement.

This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false
when input or textarea don't have renderer (e.g. invisible).

Unfortunately, there is no way to test this behavioral change from layout tests.

  • WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of

that of HTMLInputElement and HTMLTextAreaElement.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon): Ditto.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true
as it used to do via respondToChangeByUser.
(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Moved from RenderTextControl.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::setLastChangeWasNotUserEdit): Added.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl): No longer initializes m_lastChangeWasUserEdit.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Calls setInnerTextValue.

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::updateFromElement): Ditto.

22:27 Changeset [94046] by morrita@google.com

Unreviewed marking skip.

  • platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html
22:22 Changeset [94045] by tkent@chromium.org

REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

  • fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
  • fast/forms/file/disabling-file-busy-loop.html: Added.
22:01 Changeset [94044] by dbates@webkit.org

Add HAVE(VASPRINTF) macro to test for vasprintf() support
https://bugs.webkit.org/show_bug.cgi?id=67156

Reviewed by Darin Adler.

Source/JavaScriptCore:

Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.

  • wtf/Platform.h:

Source/WebCore:

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).

21:57 Changeset [94043] by levin@chromium.org

[chromium] Minor update for test that is timing out.

  • platform/chromium/test_expectations.txt:
21:51 Changeset [94042] by levin@chromium.org

[chromium] Misc test expectations updates.

  • platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.
  • platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.

Added due to it being different from normal OSX result.

  • platform/chromium/test_expectations.txt: Changes due to expectation update for media-document-audio-repaint.html leading to only an image mismatch and a test that is a slow on OS X as well as Linux and Windows.
20:38 Changeset [94041] by yutak@chromium.org

WebSocket: Receive binary message as Blob
https://bugs.webkit.org/show_bug.cgi?id=67115

Reviewed by Kent Tamura.

Source/WebCore:

Make WebSocketChannel be able to receive WebSocket binary messages and deliver them via
didReceiveBinaryData() callback of WebSocketChannelClient.

Tests: http/tests/websocket/tests/hybi/fragmented-binary-frames.html

http/tests/websocket/tests/hybi/receive-blob.html
http/tests/websocket/tests/hybi/workers/receive-blob.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Convert Blob to JSValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Convert Blob to v8::Value.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

Added DataTypeBlob and Blob-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsBlob):

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):
If binaryType attribute is "blob", construct a Blob using BlobData filled with the given
binary message.

  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):
Create continuousFrameData as OwnPtr<> rather than stack-allocated value so we can easily
pass it to didReceiveBinaryData() callback.
Save the content of a fragmented message even if it is a binary opcode.

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didReceiveBinaryData):

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
Pass binaryData as PassOwnPtr<Vector<char> > to deliver the value efficiently (without
copying the content) across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/binary-frames_wsh.py: Added. Used from receive-blob.html.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames-expected.txt: Added.
  • http/tests/websocket/tests/hybi/fragmented-binary-frames.html:

Added. The content of this test is almost identical to receive-blob.html.

  • http/tests/websocket/tests/hybi/fragmented-binary-frames_wsh.py: Added.
  • http/tests/websocket/tests/hybi/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/receive-blob.html:

Added. It is a bit complicated to validate the content of a Blob, because a Blob must be read
asynchronously. FileReader is used to read a blob as an ArrayBuffer, each byte of which is
compared with the expected result.

  • http/tests/websocket/tests/hybi/workers/receive-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/receive-blob.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/binary-frames_wsh.py:

Added. Same as above binary-frames_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/receive-blob.js: Added.
19:29 Changeset [94040] by rniwa@webkit.org

Export more symbols for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
19:19 Changeset [94039] by rniwa@webkit.org

Windows build fix for r94038.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
19:03 Changeset [94038] by rniwa@webkit.org

Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=67173

Reviewed by Darin Adler.

Source/WebCore:

Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.

Test: fast/forms/textfield-lastchange-was-useredit.html

  • testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.

  • fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
  • fast/forms/textfield-lastchange-was-useredit.html: Added.
18:49 Changeset [94037] by macpherson@chromium.org

Implement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67106

Reviewed by Darin Adler.

Tests:
LayoutTests/fast/multicol/inherit-column-values.html
LayoutTests/fast/multicol/initial-column-values.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handler for CSSPropertyWebkitColumns.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementation for CSSPropertyWebkitColumns.

18:43 Changeset [94036] by commit-queue@webkit.org

sheriffbot "usage" help statements are wrong
https://bugs.webkit.org/show_bug.cgi?id=67170

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
18:43 Changeset [94035] by commit-queue@webkit.org

Unzip initialization lists and constructors in JSCell hierarchy (3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):

  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
(JSC::Arguments::finishCreation):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::finishCreation):

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
Moved the assignment of m_firstLine and m_lastLine into the
FunctionExecutable::finishCreation() method in Executable.h

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::finishCreation):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::finishCreation):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):

  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::finishCreation):

  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):

  • runtime/ObjectPrototype.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

Source/JavaScriptGlue:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • UserObjectImp.cpp:

(UserObjectImp::UserObjectImp):

Source/WebCore:

No new tests.

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::finishCreation):

  • bindings/js/JSDOMWindowShell.h:
18:29 Changeset [94034] by commit-queue@webkit.org

[EFL] Add missing API documentation.
https://bugs.webkit.org/show_bug.cgi?id=66927

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-29
Reviewed by Kent Tamura.

Adds missing documentation for ewk_context_menu_item_checked_get/set.
Moves API documentation from cpp to the headers.
Adds brief and file commands for ewk_js.h.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_js.h:
16:47 Changeset [94033] by commit-queue@webkit.org

[Qt] QTouchWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67159

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
16:42 Changeset [94032] by cevans@google.com

Merge 94001
BUG=91911
Review URL: http://codereview.chromium.org/7795013

16:39 Changeset [94031] by abarth@webkit.org

Add support for chomium-mac (non-CoreGraphics) baselines
https://bugs.webkit.org/show_bug.cgi?id=67163

Reviewed by Eric Seidel.

This patch teaches the non-CG chromium-mac bots to look at non-CG
baselines. However, the patch still leaves CG as the default set of
baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
16:37 Changeset [94030] by jonlee@apple.com

Updating forms survey with non-standard wrap for textarea and more data-list driven text fields.

  • projects/forms/survey.html:
16:35 Changeset [94029] by cevans@google.com

Merge 94002
BUG=93978
Review URL: http://codereview.chromium.org/7793016

16:21 Changeset [94028] by imasaki@chromium.org

[Chromium] Added new rebaselines for media/media-document-audio-repaint.
These are obtained by the rebaseline tool.
https://bugs.webkit.org/show_bug.cgi?id=67070

Reviewed by David Levin.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
16:19 Changeset [94027] by commit-queue@webkit.org

[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
15:54 Changeset [94026] by commit-queue@webkit.org

Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884

Patch by John Bauman <jbauman@chromium.org> on 2011-08-29
Reviewed by Kenneth Russell.

BGRA input is common coming from skia, so optimize BGRA->RGBA
conversion and also avoid the pointless RGBA to RGBA conversion.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doUnpackingAndPacking):

15:53 Changeset [94025] by weinig@apple.com

Fix path to style sheet in fast/events/constructors/event-constructors.html.

Reviewed by Gavin Barraclough.

  • fast/events/constructors/event-constructors.html:
15:52 Changeset [94024] by mdelaney@apple.com

[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
https://bugs.webkit.org/show_bug.cgi?id=67099

Reviewed by Simon Fraser.

No new tests. Testing the "fallback to old path" behavior is not easily testable.

  • platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to old path if IOSurface creation path fails.

(WebCore::ImageBuffer::ImageBuffer):

15:51 Changeset [94023] by weinig@apple.com

Update results for fast/files/create-blob-url-crash.html to match
exception text.

  • fast/files/create-blob-url-crash-expected.txt:
15:43 Changeset [94022] by lforschler@apple.com

Merge r93793.

15:41 Changeset [94021] by lforschler@apple.com

Merge r93717.

15:30 Changeset [94020] by mrobinson@webkit.org

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • configure.ac: Update library version.

2011-08-29 Martin Robinson <mrobinson@igalia.com>

Update NEWS and library versioning for the 1.4.3 release.

Reviewed by Gustavo Noronha.

  • NEWS: Update the news.
14:57 Changeset [94019] by caryclark@google.com

Only enable font smoothing as requested (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=67143

This adjusts LayoutTest pixel output to more closely
match other platforms.

Reviewed by Kenneth Russell.

No new tests. This platform is not yet enabled.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.

14:47 Changeset [94018] by levin@chromium.org

Fix test_expectation.txt typo.

  • platform/chromium/test_expectations.txt:
14:36 Changeset [94017] by levin@chromium.org

Update test expections due to r94006 and r93978.

  • platform/chromium/test_expectations.txt: Add failing test due to r93978.
  • platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and behavior change in r94006.
14:32 Changeset [94016] by jchaffraix@webkit.org

Assertion failure in RenderLayer::computeRepaintRects when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67140

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/scroll-fixed-layer-with-no-visible-content.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeRepaintRects): Fixed style after r93837.

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Tweaked the code
to bail early if our layer has no visible content. This avoids the ASSERT
and also makes sense as we shouldn't repaint / update empty layers.

LayoutTests:

This test checks that a fixed element with no visible content does not ASSERT and
renders properly.

  • fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
  • fast/repaint/scroll-fixed-layer-with-no-visible-content.html: Added.
  • platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
14:12 Changeset [94015] by mrobinson@webkit.org

Merging r90368

13:59 Changeset [94014] by mrobinson@webkit.org

Merging r86118

13:58 Changeset [94013] by mrobinson@webkit.org

Merging r86116

13:56 Changeset [94012] by mrobinson@webkit.org

Merging r86102

13:47 Changeset [94011] by commit-queue@webkit.org

Implement WebVTT Cue Text Parsing rules and DOM construction
https://bugs.webkit.org/show_bug.cgi?id=64132

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-29
Reviewed by Adam Barth.

Tests in media/track, particularly track-webvtt-tc[022 - 028]*.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCue.cpp:
  • html/TextTrackCue.h:
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
  • platform/track/WebVTTParser.cpp:
  • platform/track/WebVTTParser.h:
  • platform/track/WebVTTToken.h: Added.
  • platform/track/WebVTTTokenizer.cpp: Added.
  • platform/track/WebVTTTokenizer.h: Added.
13:32 Changeset [94010] by paroga@webkit.org

Add parsing support for extended attributes on IDL constants
https://bugs.webkit.org/show_bug.cgi?id=65046

Reviewed by Brent Fulgham.

With support for extended attributes on constants we can
replace some preprocessor lines from the IDL files with
the corresponding [Conditional=XXX] later.
Using the preprocessor causes much pain on native windows.

CodeGenerator support will be added in separate patches.

  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
13:18 Changeset [94009] by rniwa@webkit.org

Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
https://bugs.webkit.org/show_bug.cgi?id=67141

Reviewed by Eric Seidel.

No new tests since this is a refactoring.

  • dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
  • html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
to avoid the conflict with value().

  • html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
HTMLInputElement.cpp and HTMLTextAreaElement.cpp.

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.

13:16 Changeset [94008] by commit-queue@webkit.org

Small fix in chromium port of new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=67078

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-29
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
13:09 Changeset [94007] by commit-queue@webkit.org

Unreviewed, rolling out r93987, r93992, r93995, r93998, and
r93999.
http://trac.webkit.org/changeset/93987
http://trac.webkit.org/changeset/93992
http://trac.webkit.org/changeset/93995
http://trac.webkit.org/changeset/93998
http://trac.webkit.org/changeset/93999
https://bugs.webkit.org/show_bug.cgi?id=67147

Many failing tests (Requested by ap on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-29

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/CookieJar.mm:

(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/network/CookieStorage.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::privateStorageSession):
(WebCore::privateBrowsingStorageSessionIdentifierBase):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::defaultSessionCookieStorage):
(WebCore::defaultCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
(WebCore::ResourceHandle::currentStorageSession):
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::setCookieStoragePrivateBrowsingEnabled):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

  • WebCookieManagerCFNet.cpp:

(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):

  • WebView.cpp:

(updateSharedSettingsFromPreferencesIfNeeded):

Source/WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

13:06 Changeset [94006] by commit-queue@webkit.org

As per HTML specification, default font style of dfn tag should be italic.
https://bugs.webkit.org/show_bug.cgi?id=56670

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-29
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/dfn-default-font-style.html

  • css/html.css:

(i, cite, em, var, address, dfn):

LayoutTests:

  • fast/css/dfn-default-font-style-expected.txt: Added.
  • fast/css/dfn-default-font-style.html: Added.
13:03 Changeset [94005] by paroga@webkit.org

Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
https://bugs.webkit.org/show_bug.cgi?id=65040

Reviewed by Brent Fulgham.

JSValueToNative and NativeToJSValue add additional include statements
to the implementation and need to handle the Conditional attribute from
the IDL file. The Conditional attribute adds appropriate #if ENABLE()
lines for the preprocessor around the include statements to remove
some unneeded build dependencies.

  • bindings/scripts/CodeGeneratorJS.pm:
12:35 Changeset [94004] by commit-queue@webkit.org

[Chromium] Add ability to do static SerializedScriptValue deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877

Patch by Greg Billock <gbillock@google.com> on 2011-08-29
Reviewed by Darin Fisher.

  • public/WebSerializedScriptValue.h:
  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::serialize):

12:26 Changeset [94003] by japhet@chromium.org

Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
https://bugs.webkit.org/show_bug.cgi?id=66018

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::load):

(WebCore::CachedResource::setResourceLoaderOptions):
(WebCore::CachedResource::sendResourceLoadCallbacks):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):

  • loader/cache/CachedResourceRequest.h:
12:23 Changeset [94002] by commit-queue@webkit.org

Source/WebCore: Fix failures when FFT size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

Test: webaudio/fft-sizing.html

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.

  • webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).

LayoutTests: Fix failures when FFT array size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

  • webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
  • webaudio/realtimeanalyser-fft-sizing.html: Added.
12:19 Changeset [94001] by inferno@chromium.org

Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/line-layout/inline-box-wrapper-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.

LayoutTests:

  • fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
  • fast/block/line-layout/inline-box-wrapper-crash.html: Added.
12:19 Changeset [94000] by mrobinson@webkit.org

Reviewed by Xan Lopez.

[GTK] Build WebKit2 unconditionally
https://bugs.webkit.org/show_bug.cgi?id=62749

Build WebKit2 by default. This will make the bots build it and catch
build errors when they occur.

  • GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2

PC file, which should not be shipped until WebKit2 is actually shipped officially.

12:07 Changeset [93999] by ap@apple.com

Windows build fix.

WebKit/win:

  • WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated for new function name and signature: currentCFHTTPCookieStorage().

WebKit2:

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:59 Changeset [93998] by ap@apple.com

Lion build fix.

  • WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions of Mac OS X, and need separate exports.
11:54 Changeset [93997] by cmarrin@apple.com

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixing LayoutTests broken by http://trac.webkit.org/changeset/93980

Unreviewed.


Add Mac specific tests to take into account new requestAnimationFrame functionality

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/mac/fast/dom/prototype-inheritance-expected.txt: Added.
11:53 Changeset [93996] by tony@chromium.org

Implement -webkit-flex-pack for horizontal flexboxen
https://bugs.webkit.org/show_bug.cgi?id=66898

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/004.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::hasPackingSpace):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal):

LayoutTests:

  • css3/flexbox/004-expected.txt: Added.
  • css3/flexbox/004.html: Added.
11:46 Changeset [93995] by ap@apple.com

Windows build fix.

  • platform/network/cf/CookieJarCFNet.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): (WebCore::getHostnamesWithCookies): (WebCore::deleteCookiesForHostname): (WebCore::deleteAllCookies): Updated for new function name and signature: currentCFHTTPCookieStorage().
11:46 Changeset [93994] by weinig@apple.com

Update tests after landing Event constructors.

Reviewed by Anders Carlsson.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
11:45 Changeset [93993] by senorblanco@chromium.org

Unreviewed gardening.

Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing
after r93988.

  • platform/chromium/test_expectations.txt:
11:34 Changeset [93992] by ap@apple.com

Mac build fix.

  • platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN).
11:31 Changeset [93991] by andreas.kling@nokia.com

Unreviewed build fix after r93990.

  • wtf/HashTable.h:
11:24 Changeset [93990] by andreas.kling@nokia.com

Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.

  • runtime/StructureTransitionTable.h:
  • wtf/HashTable.h:

(WTF::HashTable::shouldShrink):
(WTF::::expand):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

Source/WebCore:

Specialize the HashMap used to store registered listeners on an EventTarget
to have a minimum size of 32 (rather than the default 64.)
It's very rare for pages to register listeners for so many different events
and this cuts memory consumption in half for the common case.

As an example, for a typical post on the reddit.com front page,
this reduces memory used by ~700kB on 64-bit.

  • dom/EventTarget.h:
11:22 Changeset [93989] by levin@chromium.org

Temporary suppression for new test added in r93982.

  • platform/chromium/test_expectations.txt:
11:16 Changeset [93988] by senorblanco@chromium.org

Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=67050

Reviewed by Kenneth Russell.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawsContent):
Construct Canvas2DLayerChromium with a GraphicsContext3D, not a
DrawingBuffer.
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
Flush the GrContext and GraphicsContext3D on compositor update.

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

Put textureId() back on the base class (CanvasLayerChromium) and
de-virtualize it.
(WebCore::CanvasLayerChromium::textureId):
(WebCore::CanvasLayerChromium::setTextureId):
Move m_textureId from WebGLLayerChromium, since canvas2D now uses
it too. Provide getters and setters.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
Remove all Canvas2D-related calls from DrawingBuffer.
(WebCore::DrawingBuffer::publishToPlatformLayer):
Remove GrContext::flush call, since it's now handled by the platform layer.
(WebCore::DrawingBuffer::platformLayer):
Return NULL for now (WebGL may rescussitate this later).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

Remove a useless #include.

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add ownership of the Canvas2DLayerChromium.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Remove all texture ID stuff (now on base class).

  • platform/graphics/gpu/DrawingBuffer.h:

Remove Canvas2DLayerChromium and all Ganesh datatypes from
DrawingBuffer, since it's no longer used by canvas2D.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
On accelerated ImageBuffer creation, create a GrTexture instead of a
DrawingBuffer. If all is cool, create and set the SkGpuDevice here,
and create a Canvas2DLayerChromium platform layer.
(WebCore::ImageBuffer::platformLayer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove all GrContext creation and DrawingBuffer "scraping" from
PlatformContextSkia::setGraphicsContext3D(). This is handled in
the ImageBuffer constructor instead.

11:15 Changeset [93987] by ap@apple.com

DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>

Reviewed by Darin Adler.

Use a clean CFURLStorageSession when this functionality is available.

  • WebCore.exp.in: Added exports
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::setCookies): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): Updated for privateBrowsingCookieStorage->currentCFHTTPCookieStorage change.
  • platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.
  • platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp. This file contains cross platform functionality, and we no longer need to put code in it to share it between Mac and Windows.
  • platform/network/ResourceHandle.h: Expose methods to manipulate default session on Mac, too.
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API. (WebCore::overrideCookieStorage): Ditto. (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable, unless it has been overridden on Windows. We can always get it from a session. (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just use private session's storage. Note that Mac has a separate code path for OS versions that don't support sessions.
  • platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK), as this function is also used with NSURLConnection when sessions are enabled. (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session is now supported on Mac, too. (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK). (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer adopt the session, because nothing in method name says that it will steal a reference from the caller. (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK). (WebCore::privateStorageSession): Moved from ResourceHandle.cpp. (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.
  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): We no longer store a reference to cookie storage in a static variable, so nothing to do here. On older OS versiosn, we still need to enable legacy private browsing mode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function.
10:57 Changeset [93986] by levin@chromium.org

postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
https://bugs.webkit.org/show_bug.cgi?id=66713

Reviewed by Dmitry Titov.

Source/WebCore:

See http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages for postMessage

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::getMessagePortArray):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):

LayoutTests:

  • fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
  • fast/events/message-port-multi-expected.txt: Ditto.
  • fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • fast/workers/worker-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.
10:37 Changeset [93985] by cevans@google.com

Merge 93802
BUG=91973
Review URL: http://codereview.chromium.org/7797001

10:31 Changeset [93984] by jchaffraix@webkit.org

Assertion failure in WebCore::RenderFlow::rightmostPosition
https://bugs.webkit.org/show_bug.cgi?id=12085

Reviewed by Alexey Proskuryakov.

The bug got solved. Landed the test to avoid regressing.

  • fast/css/assert-marquee-not-last-element-expected.txt: Added.
  • fast/css/assert-marquee-not-last-element.html: Added.
10:30 Changeset [93983] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.

  • platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.
10:14 Changeset [93982] by commit-queue@webkit.org

canvas arc() missing line to start of arc if swing is zero
https://bugs.webkit.org/show_bug.cgi?id=55696

Source/WebCore:

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Test: fast/canvas/canvas-arc-zero-lineto.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::arc):

LayoutTests:

LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement
https://bugs.webkit.org/show_bug.cgi?id=66832

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the
next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html

  • canvas/philip/tests/2d.path.stroke.prune.arc.html:
  • fast/canvas/canvas-arc-zero-lineto-expected.txt: Added.
  • fast/canvas/canvas-arc-zero-lineto.html: Added.
10:12 Changeset [93981] by cmarrin@apple.com

2011-08-29 Chris Marrin <cmarrin@apple.com>

Fixed a build problem caused by http://trac.webkit.org/changeset/93980

Unreviewed.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
09:38 Changeset [93980] by cmarrin@apple.com

[mac] requestAnimationFrame support for mac port
https://bugs.webkit.org/show_bug.cgi?id=59146

Reviewed by Simon Fraser.

Source/WebCore:

Enable REQUEST_ANIMATION_FRAME logic and add ScriptedAnimationController
to build. Added JavaScript support for Mac, too.

  • CodeGenerators.pri:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp: Added.

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):

  • dom/RequestAnimationFrameCallback.idl:

Source/WebKit/mac:

Implement requestAnimationFrame for WebKit. Add a
CFRunLoopObserver to WebView, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleAnimation):

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _unscheduleAnimation]):
(-[WebView _scheduleCompositingLayerSync]):
(requestAnimationFrameRunLoopObserverCallback):
(-[WebView _scheduleAnimation]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WebKit2:

Implement requestAnimationFrame for WebKit2. Add a
CFRunLoopObserver to WebPage, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleAnimation):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::requestAnimationFrameRunLoopObserverCallback):
(WebKit::WebPage::scheduleAnimation):
(WebKit::WebPage::unscheduleAnimation):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.cpp:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

Tools:

Add support for request-animation-callback flag

  • Scripts/build-webkit:

LayoutTests:

Enable requestAnimationFrame tests for Mac. Tests were also
modified to work on Mac. Before the tests would assume the
requestAnimationFrame callbacks would be called by calling
LayoutTestController.display(). This is not a valid assumption
for Mac, since it skips display() if nothing was dirty.

Tests were changed to use timeouts to wait for callbacks and
ensure they get called. Also added more positive indications
that test failed or succeeded, rather than relying on the lack
of an error message to indicate success.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-during-modal-expected.txt:
  • fast/animation/request-animation-frame-during-modal.html:
  • fast/animation/request-animation-frame-timestamps.html:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/request-animation-frame-cancel.js:

(window):
(if):

  • fast/animation/script-tests/request-animation-frame-cancel2.js:

(if):

  • fast/animation/script-tests/request-animation-frame-display.js:

(if):

  • fast/animation/script-tests/request-animation-frame-timestamps.js:

(var):

  • fast/animation/script-tests/request-animation-frame-within-callback.js:
  • fast/animation/script-tests/request-animation-frame.js:

(if):

  • platform/mac/Skipped:
09:07 Changeset [93979] by commit-queue@webkit.org

[Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API define in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67123

We could simply use the defines already in place for this.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-29
Reviewed by Andreas Kling.

  • WebKit2.pro:
08:15 Changeset [93978] by apavlov@chromium.org

Web Inspector: <button hidden>..</button> has a different computed "display" value than "none"
https://bugs.webkit.org/show_bug.cgi?id=67124

Source/WebCore:

Attribute styles have a higher priority than user agent styles and thus should be rendered above them.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:
08:14 Changeset [93977] by podivilov@chromium.org

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=66769

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresenationCallFrame.prototype.sourceLine.didGetUILocation):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.UILocation):

LayoutTests:

  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-file.html:
07:55 Changeset [93976] by loki@webkit.org

[Qt] The square-button-appearance test is wrong
https://bugs.webkit.org/show_bug.cgi?id=67128

Unreviewed skip until square-button fix on qt-arm.

  • platform/qt-arm/Skipped:
07:14 Changeset [93975] by loki@webkit.org

2011-08-29 Zsolt Fehér <feherzs@inf.u-szeged.hu>

Unreviewed Qt gardening.

  • platform/qt/Skipped:
07:11 Changeset [93974] by loislo@chromium.org

Web Inspector: cached permanent redirects don't show redirect code and text in Network panel.
https://bugs.webkit.org/show_bug.cgi?id=67126

Reviewed by Yury Semikhatsky.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceResponse):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

05:34 Changeset [93973] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
05:19 Changeset [93972] by podivilov@chromium.org

Web Inspector: extract FormattedContentProvider from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66938

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
05:03 Changeset [93971] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark fast/dom/dom-constructors.html as TEXT in chromium.

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
04:45 Changeset [93970] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
04:36 Changeset [93969] by podivilov@chromium.org

Web Inspector: link UISourceCode to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66944

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get rawSourceCode):

LayoutTests:

  • inspector/debugger/ui-source-code.html:
04:19 Changeset [93968] by zoltan@webkit.org

[Qt] Skip failing and flaky results after r93937
https://bugs.webkit.org/show_bug.cgi?id=67118

  • platform/qt/Skipped:
02:55 Changeset [93967] by ryuan.choi@samsung.com

REGRESSION(r93637) Build break because header file is missing.
https://bugs.webkit.org/show_bug.cgi?id=67113

Unreviewed build fix after r93637.

  • CMakeListsEfl.txt: Add ewk_js.h in EWebKit_HEADERS.
02:35 Changeset [93966] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark overflow-scroll-overlap.html as flaky on chromium gpu.

  • platform/chromium/test_expectations.txt:
02:17 Changeset [93965] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add new chromium mac cg baseline for square-button-appearance added in r93953.

  • platform/chromium-cg-mac-leopard/fast/css/square-button-appearance-expected.png: Added.
02:09 Changeset [93964] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium expectations. Mark frame-removed-during-resize.html and scrollbar-buttons.html
as crashing on win linux debug only.

  • platform/chromium/test_expectations.txt:
02:06 Changeset [93963] by podivilov@chromium.org

Web Inspector: remove RawSourceCode.setFormatted.
https://bugs.webkit.org/show_bug.cgi?id=66947

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

LayoutTests:

  • inspector/debugger/source-file.html:
01:53 Changeset [93962] by podivilov@chromium.org

Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
https://bugs.webkit.org/show_bug.cgi?id=67030

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/set-breakpoint.html

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

LayoutTests:

  • inspector/debugger/set-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint-expected.txt.
  • inspector/debugger/set-breakpoint.html: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint.html.
01:37 Changeset [93961] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix event-constructors.html test.
https://bugs.webkit.org/show_bug.cgi?id=63878

  • fast/events/constructors/event-constructors.html:
01:22 Changeset [93960] by commit-queue@webkit.org

[GTK][WK2] Compilation error in WebKit2 GTK - Revision 93953
https://bugs.webkit.org/show_bug.cgi?id=67111

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-08-29
Reviewed by Martin Robinson.

WebKit2 GTK build error.

  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

Include <WebCore/ResourceError.h> explicitly to remove WebCore::ResourceError
inclusion error.

01:10 Changeset [93959] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark event-constructors.html as failing in chromium.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/test_expectations.txt:
00:40 Changeset [93958] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, adding custom expectation for dom-constructors test in chromium
until bug 66756 is resolved.
https://bugs.webkit.org/show_bug.cgi?id=66756

  • platform/chromium/fast/dom/dom-constructors-expected.txt: Added.
00:34 Changeset [93957] by mdelaney@apple.com

fast/canvas/shadow-offset-*.html fail on Leopard/Snow Leopard when removing the work around for <rdar://problem/5539388>.
https://bugs.webkit.org/show_bug.cgi?id=67107

Reviewed by David Levin.

No new tests. Effectively reverting the change from https://bugs.webkit.org/show_bug.cgi?id=67052 for Leopard and SL
because it caused test regressions on Leopard and SL, but not Lion.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

00:16 Changeset [93956] by podivilov@chromium.org

2011-08-29 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark scrollbars/scrollbar-buttons.html as crashing in chromium.

  • platform/chromium/test_expectations.txt:
00:07 Changeset [93955] by zherczeg@webkit.org

[Qt] Unreviewed minimal-build buildfix after r93937.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-29

08/28/11:

23:49 WebKitGtkLayoutTests edited by nayankk@motorola.com
(diff)
23:09 Changeset [93954] by loislo@chromium.org

Merge 93868 - Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7778006

20:49 Changeset [93953] by keishi@webkit.org

Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

  • fast/css/square-button-appearance-expected.txt: Added.
  • fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
  • platform/gtk/test_expectations.txt: Added this test as expected to fail.
  • platform/mac/fast/css/square-button-appearance-expected.png: Added.
  • platform/qt/test_expectations.txt: Added this test as expected to fail.
17:26 Changeset [93952] by macpherson@chromium.org

Fix reference counting of values in CSSSelector.
https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

  • css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

16:58 Changeset [93951] by weinig@apple.com

Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support. This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add files.

  • bindings/generic/EventConstructors.h: Added.

Add binding agnostic header that defines the Event initializers
using a macro based DSL.

  • bindings/js/JSEventConstructors.cpp: Added.

(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

  • dom/Event.cpp:

(WebCore::EventInit::EventInit):
(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::create):
Add Event initializer interface for base Event.

  • dom/Event.idl:

Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

  • fast/events/constructors/event-constructors-expected.txt: Added.
  • fast/events/constructors/event-constructors.html: Added.
12:24 Changeset [93950] by commit-queue@webkit.org

Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

  • wtf/Platform.h:
12:14 Changeset [93949] by kbalazs@webkit.org

[Qt][WK2] Unreviewed build fix.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

08/27/11:

15:01 Changeset [93948] by robert@webkit.org

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
14:49 Changeset [93947] by fpizlo@apple.com

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

14:31 Changeset [93946] by commit-queue@webkit.org

Add a build bot for Chromium with OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:12 Changeset [93945] by commit-queue@webkit.org

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

14:03 Changeset [93944] by robert@webkit.org

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
13:22 Changeset [93943] by andersca@apple.com

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 Changeset [93942] by commit-queue@webkit.org

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 Changeset [93941] by commit-queue@webkit.org

Shrink RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 Changeset [93940] by enne@google.com

[chromium] Possible leak of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < jamesr@chromium.org> on 2011-08-26
From http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 Changeset [93939] by commit-queue@webkit.org

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 Changeset [93938] by commit-queue@webkit.org

Patch by Young Han Lee <joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

04:06 Changeset [93937] by commit-queue@webkit.org

[Qt] Need spin-button implementation
https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
00:54 Changeset [93936] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.