Timeline


and

09/05/11:

23:58 Changeset [94551] by reni@webkit.org

[Qt] Update expecteds after r94545.

Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:52 Changeset [94550] by inferno@chromium.org

Unreviewed. GTK rebaselines for r94541, r94543.

  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/gtk/fast/table/table-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • platform/gtk/fast/table/table-style-not-updated-expected.txt: Added.
20:45 Changeset [94549] by jamesr@google.com

[chromium] Remove unnecessary expectation, results match the fallback path.

  • platform/chromium-cg-mac/fast/dom/wrapper-classes-expected.txt: Removed.
20:06 Changeset [94548] by inferno@chromium.org

Unreviewed. Chromium rebaselines for r94541, r94543.

  • platform/chromium-cg-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-cg-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-style-not-updated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
19:38 Changeset [94547] by inferno@chromium.org

Unreviewed. Qt rebaselines for r94543.

  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-style-not-updated-expected.txt: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • platform/qt/fast/table/table-style-not-updated-expected.txt: Added.
19:13 Changeset [94546] by inferno@chromium.org

Unreviewed. Rebaselines for r94541.

  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
18:52 Changeset [94545] by abarth@webkit.org

window.HTMLSpanElement does not exist
https://bugs.webkit.org/show_bug.cgi?id=67571

Reviewed by Sam Weinig.

Source/WebCore:

We have these objects for most other elements and HTMLSpanElement
exists in Firefox and in the HTML5 spec. This patch adds it.

Test: fast/dom/wrapper-classes.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLSpanElement.cpp: Added.

(WebCore::HTMLSpanElement::HTMLSpanElement):
(WebCore::HTMLSpanElement::create):

  • html/HTMLSpanElement.h: Added.
  • html/HTMLSpanElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

Update tests to account for HTMLSpanElement existing. I also took the
liberty of changing fast/tokenizer/external-script-document-write.html
into a text test and cleaning up the platform-specific results.

  • editing/selection/extend-after-mouse-selection-expected.txt:
  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.txt: Added.
  • fast/tokenizer/resources/external-script-document-write.js:
  • platform/chromium-linux/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/mac-leopard/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write-expected.txt: Removed.
18:49 Changeset [94544] by inferno@chromium.org

Merge 94543 - Style not propagated to anonymous boxes and anonymous
inline-blocks.

BUG=92651
Review URL: http://codereview.chromium.org/7833032

18:45 Changeset [94543] by inferno@chromium.org

Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html

fast/ruby/ruby-block-style-not-updated.html
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
fast/ruby/ruby-inline-style-not-updated.html
fast/table/table-row-style-not-updated-with-after-content.html
fast/table/table-row-style-not-updated-with-before-content.html
fast/table/table-row-style-not-updated.html
fast/table/table-style-not-updated.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isBeforeAfterContent):

  • rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):

  • rendering/RenderRuby.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):

  • rendering/RenderTableSection.h:

LayoutTests:

None of the different color boxes should overlap. If they overlap, test fails.

  • fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content.html: Added.
  • fast/ruby/ruby-block-style-not-updated.html: Added.
  • fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html: Added.
  • fast/ruby/ruby-inline-style-not-updated.html: Added.
  • fast/table/table-row-style-not-updated-expected.png: Added.
  • fast/table/table-row-style-not-updated-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-after-content.html: Added.
  • fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-before-content.html: Added.
  • fast/table/table-row-style-not-updated.html: Added.
  • fast/table/table-style-not-updated-expected.png: Added.
  • fast/table/table-style-not-updated-expected.txt: Added.
  • fast/table/table-style-not-updated.html: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/mac/fast/table/table-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
18:21 Changeset [94542] by inferno@chromium.org

Merge 94541 - Crash in RenderObjectChildList::destroyLeftOverChildren()

BUG=89580
Review URL: http://codereview.chromium.org/7737033

18:16 Changeset [94541] by inferno@chromium.org

Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

  • fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
  • fast/multicol/column-span-parent-continuation-crash.html: Added.
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
16:18 Changeset [94540] by abarth@webkit.org

Add a tab to garden-o-matic for viewing expected failures
https://bugs.webkit.org/show_bug.cgi?id=67619

Reviewed by Dimitri Glazkov.

This patch adds a basic tab to garden-o-matic that shows all the tests
failing on the bots, including the expected failures. This patch
mostly involves refactoring existing classes to allow new subclasses.

This view is useful for when gardeners mark tests as expected to fail
and then rebaseline them later.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
15:58 Changeset [94539] by abarth@webkit.org

Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617

Reviewed by Dimitri Glazkov.

Caught by running the unit tests with noglobals turned on.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
14:07 Changeset [94538] by commit-queue@webkit.org

Unreviewed, rolling out r94537.
http://trac.webkit.org/changeset/94537
https://bugs.webkit.org/show_bug.cgi?id=67618

Does not compile on Chromium Mac (Requested by abarth_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):

12:56 Changeset [94537] by noel.gordon@gmail.com

[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Adam Barth.

Change the row converter function signatures to be the same. Call them via a function
pointer during the encoding loop. Minor webkit stlye cleanup, remove unused include.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: Remove SkUnPreMultiply.h (not used).

(WebCore::preMultipliedBGRAtoRGB): Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB): pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels): Move contants out of the encoding loop: use a function pointer to
call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures) during the
image row encoding loop. Add/use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode): webkit style: no need to split lines.

09:55 Changeset [94536] by jknotten@chromium.org

Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

  • fast/events/page-scaled-mouse-click-expected.txt: Added.
  • fast/events/page-scaled-mouse-click.html: Added.
  • fast/events/script-tests/page-scaled-mouse-click.js: Added.
09:51 Changeset [94535] by kbalazs@webkit.org

D'oh! Missed the name of the test in the previous gardening.
Unreviewed regardening.

  • platform/qt-wk2/Skipped:
09:47 Changeset [94534] by kbalazs@webkit.org

[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67607

Unreviewed gardening.

  • platform/qt-wk2/Skipped:
08:42 Changeset [94533] by kbalazs@webkit.org

[Qt] Unreviewed gardening - move expectation to the correct place.

  • platform/qt/fast/borders/border-image-repeat-expected.txt: Renamed from LayoutTests/platform/qt/border-image-repeat-expected.txt.
08:35 Changeset [94532] by podivilov@chromium.org

Web Inspector: rename RawSourceCode.reload to contentEdited.
https://bugs.webkit.org/show_bug.cgi?id=67504

Make RawSourceCode.reload private and remove RawSourceCode.content getter and setter
(RawSourceCode isn't supposed to have any content).

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._didRequestContent):

08:01 Changeset [94531] by leandrogracia@chromium.org

Fix the regression of bug 65333 introduced by 60170.
This caused the speech input bubble to appear in the wrong side for RTL text inputs.
https://bugs.webkit.org/show_bug.cgi?id=67597

Reviewed by Tony Gentilcore.

No new tests. Fixing regression.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

07:46 Changeset [94530] by podivilov@chromium.org

Web Inspector: cleanup scripts-panel.html test.
https://bugs.webkit.org/show_bug.cgi?id=67497

ScriptsPanel test should not depend on presentation model internals.

Reviewed by Yury Semikhatsky.

  • inspector/debugger/scripts-panel.html:
07:40 Changeset [94529] by apavlov@chromium.org

Web Inspector: F5 results in a Web Inspector frontend reload on non-Macs
https://bugs.webkit.org/show_bug.cgi?id=67602

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

07:20 Changeset [94528] by kbalazs@webkit.org

[Qt] Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-05

  • platform/qt/border-image-repeat-expected.txt: Added.
07:11 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt to 4.7.4 and Mobility to 1.2.0 on Qt Linux Release bot (diff)
05:57 Changeset [94527] by loislo@chromium.org

Unreviewed, rolling out r94525.
http://trac.webkit.org/changeset/94525
https://bugs.webkit.org/show_bug.cgi?id=67599

WinCE compilation failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

  • platform/text/TextBoundaries.cpp:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
05:55 Changeset [94526] by kbalazs@webkit.org

2011-09-05 Balazs Kelemen <kbalazs@webkit.org>

[Qt] Update expectations.

Unreviewed gardening.

  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
05:08 Changeset [94525] by commit-queue@webkit.org

[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
https://bugs.webkit.org/show_bug.cgi?id=67391

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-09-05
Reviewed by Kenneth Rohde Christiansen.

  • platform/text/TextBoundaries.cpp:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
03:53 Changeset [94524] by kbalazs@webkit.org

[Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Reviewed by Andreas Kling.

Source/WebKit2:

  • Shared/API/c/qt/WKImageQt.cpp: Added.

(WKImageCreateQImage): C style (private) API to get the contents of the backing
store as an image.

  • Shared/API/c/qt/WKImageQt.h: Added.
  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage): Typo. Remove useless ifdef.

  • WebKit2API.pri:

Tools:

Implemented pixel result generation by reusing the logic
that we have in DumpRenderTree.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::dumpImage):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

03:50 Changeset [94523] by zoltan@webkit.org

[Qt] Update expected result after r94425
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Kristof Kosztyo <kkristof@inf.u-szeged.hu> on 2011-09-05

  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
03:43 Changeset [94522] by commit-queue@webkit.org

Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595

It broke everything (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

03:22 Changeset [94521] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium MAC.
The test was introduced at r94492.

  • platform/chromium-cg-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-cg-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
02:41 Changeset [94520] by paroga@webkit.org

Unreviewed build fix for r94452.

Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.

  • wtf/dtoa/bignum-dtoa.cc:
  • wtf/dtoa/bignum.cc:
  • wtf/dtoa/cached-powers.cc:
  • wtf/dtoa/diy-fp.cc:
  • wtf/dtoa/double-conversion.cc:
  • wtf/dtoa/fast-dtoa.cc:
  • wtf/dtoa/fixed-dtoa.cc:
  • wtf/dtoa/strtod.cc:
  • wtf/dtoa/utils.h:
01:49 Changeset [94519] by abecsi@webkit.org

[Qt][WK2] Fix the build

Rubber-stamped by Csaba Osztrogonác.

Source/JavaScriptCore:

  • wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.

The variable fractional_part is only set but never used.

Source/WebKit2:

  • DerivedSources.pro: Add missing PluginProcessConnection.messages.in after r94456.
01:36 Changeset [94518] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium Linux.
The test was introduced at r94492.

  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
00:52 Changeset [94517] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for chromium: fast/repaint/block-layout-inline-children-float-positioned.html

  • platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
00:46 Changeset [94516] by commit-queue@webkit.org

Logic from HTMLElement::deprecatedCreateContextualFragment moved into
Range::createContextualFragment function.
https://bugs.webkit.org/show_bug.cgi?id=67056

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-05
Reviewed by Ryosuke Niwa.

Code Refactoring for deprecatedCreateContextualFragment.

Source/WebCore:

No new tests. Code Re-factoring.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Range.cpp:

(WebCore::insertIntoFragment):
(WebCore::Range::createDocumentFragmentForElement):
(WebCore::Range::createContextualFragment):

  • dom/Range.h:
  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

  • html/HTMLElement.cpp:
  • html/HTMLElement.h:

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

00:38 Changeset [94515] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for fast/inline/absolute-positioned-inline-in-centred-block

  • platform/chromium-cg-mac-leopard/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.

09/04/11:

23:48 Changeset [94514] by commit-queue@webkit.org

REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-04
Reviewed by Darin Adler.

Fixing the build (again which was broken by the dtoa patch. Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • wtf/dtoa/cached-powers.cc:
  • wtf/dtoa/utils.h:
23:43 Changeset [94513] by koz@chromium.org

Unreviewed, rolling out r94510.
http://trac.webkit.org/changeset/94510
https://bugs.webkit.org/show_bug.cgi?id=66531

Causes layout test crashes.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::wrapWithRenderFullScreen):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::createFullScreenStyle):

  • rendering/RenderFullScreen.h:

LayoutTests:

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Removed.
  • plugins/fullscreen-plugins-dont-reload.html: Removed.
22:59 Changeset [94512] by inferno@chromium.org

Unreviewed. Compile fix for r94511.

  • dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

22:22 Changeset [94511] by inferno@chromium.org

Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556

Reviewed by Ryosuke Niwa.

Source/WebCore:

Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.

Test: fast/dom/Range/range-delete-contents-event-fire-crash.html

  • dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

LayoutTests:

Tests that we do not crash when removing contents of
a range from the document.

  • fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt: Added.
  • fast/dom/Range/range-delete-contents-event-fire-crash.html: Added.
21:46 Changeset [94510] by commit-queue@webkit.org

Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

Test: plugins/fullscreen-plugins-dont-reload.html

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):

  • rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
  • plugins/fullscreen-plugins-dont-reload.html: Added.
21:18 Changeset [94509] by ryuan.choi@samsung.com

[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
https://bugs.webkit.org/show_bug.cgi?id=66542

Use a C++ compiler for these files, so that they can include the C++-using
ewk_private.h.

Reviewed by Daniel Bates.

  • CMakeListsEfl.txt:
  • ewk/ewk_view_single.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_single.c.

(_ewk_view_single_on_del):
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_backing_store_add):
(_ewk_view_single_smart_resize):
(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
(_ewk_view_single_smart_repaints_process):
(_ewk_view_single_smart_zoom_weak_set):
(_ewk_view_single_smart_zoom_weak_smooth_scale_set):
(_ewk_view_single_smart_bg_color_set):
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):

  • ewk/ewk_view_tiled.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_tiled.c.

(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_add):
(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):
(_ewk_view_tiled_smart_contents_resize):
(_ewk_view_tiled_smart_zoom_set):
(_ewk_view_tiled_smart_zoom_weak_set):
(_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
(_ewk_view_tiled_smart_flush):
(_ewk_view_tiled_smart_pre_render_region):
(_ewk_view_tiled_smart_pre_render_relative_radius):
(_ewk_view_tiled_smart_pre_render_cancel):
(_ewk_view_tiled_smart_disable_render):
(_ewk_view_tiled_smart_enable_render):
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):
(ewk_view_tiled_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

17:01 Changeset [94508] by mitz@apple.com

<rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.

  • dom/Document.cpp:

(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.

  • dom/Document.h:

(WebCore::Document::retireCustomFont): Added.

LayoutTests:

  • fast/css/font-face-used-after-retired-expected.txt: Added.
  • fast/css/font-face-used-after-retired.html: Added.
14:24 Changeset [94507] by abarth@webkit.org

[Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Reviewed by Darin Fisher.

This flag requests that the embedder allow multiple selection for the
popup menu. (See also https://bugs.webkit.org/show_bug.cgi?id=67574.)

  • public/WebPopupMenuInfo.h:
  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::getPopupMenuInfo):

14:19 Changeset [94506] by weinig@apple.com

Forgot to check in new results for fast/events/event-creation.html

  • fast/events/event-creation-expected.txt:
14:04 Changeset [94505] by weinig@apple.com

Document.createEvent should support all the interfaces of Event we got
https://bugs.webkit.org/show_bug.cgi?id=67568

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/events/event-creation.html

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
Added empty create.

  • dom/Document.cpp:

(WebCore::Document::createEvent):
Add missing interfaces.

  • dom/HashChangeEvent.h:

(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
Added empty create.

  • page/SpeechInputEvent.cpp:

(WebCore::SpeechInputEvent::create):
(WebCore::SpeechInputEvent::SpeechInputEvent):
(WebCore::SpeechInputEvent::~SpeechInputEvent):

  • page/SpeechInputEvent.h:

Added empty create.

LayoutTests:

  • fast/events/event-creation.html:

Converted to shouldBe style test, changed prototype check to us instanceof and constructor check,
added enumeration based catchall.

  • fast/events/event-instanceof-expected.txt: Removed.
  • fast/events/event-instanceof.html: Removed.
  • fast/events/script-tests/event-instanceof.js: Removed.

Moved contents to fast/events/event-creation.html.

11:10 Changeset [94504] by abarth@webkit.org

[Chromium] Add memory threshold values to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=67575

Reviewed by Darin Fisher.

Source/WebCore:

Grab these memory thresholds from PlatformSupport rather than hard-coding them.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • platform/chromium/PlatformSupport.h:
  • platform/qt/PlatformSupport.h:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

Source/WebKit/chromium:

Instead of hard-coding these values, we now grab them from
WebKitPlatformSupport because Android wishes to configure them on a
per-device basis.

One could view grabing these values from PlatformSupport as a bit of a
layering violation (because they feel like policy), but another view is
that the alternative implementation is to query the OS for various
memory parameters. In either case, getting these values via
PlatformSupport is much easier and consistent with the other memory
related queries in PlatformSupport already.

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::lowMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highUsageDeltaMB):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

11:04 Changeset [94503] by loislo@chromium.org

2011-09-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium expectations.
The expectations for http/tests/security/xssAuditor/dom-write-innerHTML.html
were in conflict. The first was for LINUX the second was for DEBUG. I just added RELEASE flag for LINUX one.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [94502] by kevino@webkit.org

[wx] Unreviewed build fix. Add new / moved files missing from last commit.

09:49 Changeset [94501] by kevino@webkit.org

[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
https://bugs.webkit.org/show_bug.cgi?id=67577

Reviewed by Kevin Ollivier.

09/03/11:

22:43 Changeset [94500] by fpizlo@apple.com

ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

19:58 Changeset [94499] by laszlo.1.gombos@nokia.com

REGRESSION (r86268): Fix for qt_networkAccessAllowed()
https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has been removed a while back.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

16:31 Changeset [94498] by rniwa@webkit.org

Remove the corresponding entry from the skipped list.

16:30 Changeset [94497] by rniwa@webkit.org

REGRESSION(r94274): selection-change-closes-typing.html fails
https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

  • editing/Editor.cpp:

(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

  • platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.

  • platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

15:43 Changeset [94496] by commit-queue@webkit.org

Test that document.all.tags() matches IE behavior with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

  • fast/dom/document-all-tags-expected.txt: Added.
  • fast/dom/document-all-tags.html: Added.
14:00 Changeset [94495] by robert@webkit.org

Add platform-specific results for r94492

Unreviewed.

  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
13:08 Changeset [94494] by kevino@webkit.org

[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

12:26 Changeset [94493] by weinig@apple.com

Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

  • page/DOMWindow.idl:

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

11:28 Changeset [94492] by robert@webkit.org

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html

  • Ensure positioned block elements inherit alignment. fast/css/bug4860-absolute-inline-child-inherits-alignment.html
  • Ensure positioned inline elements inherit alignment. fast/inline/absolute-positioned-inline-in-centred-block.html
  • Ensure positioned inline element that's the sole or first child of a rendered block obeys parents alignment. fast/inline/absolute-positioned-block-in-centred-block.html
  • As above, but a positioned block should not inherit alignment.
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
  • fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.
11:18 Changeset [94491] by andreas.kling@nokia.com

Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

  • dom/Element.cpp:
  • dom/Element.h:
10:13 Changeset [94490] by mitz@apple.com

32-bit build fix.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):

09:13 Changeset [94489] by commit-queue@webkit.org

[Qt] Enable support for WebGL OES_standard_derivatives for Qt
https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

08:57 Changeset [94488] by mitz@apple.com

Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.

  • TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.

(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD): Added.

01:29 Changeset [94487] by abarth@webkit.org

garden-o-matic results view should have a better results selector
https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view. Currently, this grid just shows how the tests fail on the
various bots. A future patch will let you select which failure to view
and to mark the failures for rebaselining.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Add some more basic functions for manipulating dictionaries.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
01:27 Changeset [94486] by abarth@webkit.org

garden-o-matic results view should show Actual and Expected results for text failures
https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid. Now that we do, we can move show these results.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Fixed some typos that were preventing these unit tests from running.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
    • Report -actual.txt and -expected.txt as possible results URLs.
01:25 Changeset [94485] by abarth@webkit.org

garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
00:49 Changeset [94484] by fpizlo@apple.com

DFG variable predictions only work for local variables, not temporaries
https://bugs.webkit.org/show_bug.cgi?id=67554

Reviewed by Gavin Barraclough.

This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

00:45 Changeset [94483] by rniwa@webkit.org

Unreviewed, rolling out r94458.
http://trac.webkit.org/changeset/94458
https://bugs.webkit.org/show_bug.cgi?id=67558

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
00:45 Changeset [94482] by yutak@chromium.org

WebSocket: Send ArrayBuffer as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67477

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/send-arraybuffer.html

http/tests/websocket/tests/hybi/workers/send-arraybuffer.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

Rename "sent" to "sendRequestResult" to clarify the meaning. Messages from the script may not
be sent immediately, thus the return value of WebSocketChannel::send() indicates whether the
message has been queued successfully, rather than whether the message has been sent or not.

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
Case of sending "[object ArrayBuffer]" is covered by an existing test
http/tests/websocket/tests/{hybi,hixie76}/send-object.html.

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
Construct an ArrayBuffer from the data on Vector<char>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Copy the content into temporary buffer of Vector<char>, and send it to the main thread.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Add tests to send ArrayBuffers.

  • http/tests/websocket/tests/hybi/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/send-blob_wsh.py, because this handler
is used from send-blob.html and send-arraybuffer.html.

  • http/tests/websocket/tests/hybi/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-arraybuffer.html:

Added. Send three small binary messages as ArrayBuffers.

  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/send-arraybuffer.js:

Added. Same as send-arraybuffer.html, except that this test is run on the worker.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Removed the definition of unnecessary function startsWith().

  • http/tests/websocket/tests/hybi/workers/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-arraybuffer.html: Added
00:29 Changeset [94481] by rniwa@webkit.org

Unreviewed, rolling out r94453.
http://trac.webkit.org/changeset/94453
https://bugs.webkit.org/show_bug.cgi?id=67557

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:

09/02/11:

23:04 Changeset [94480] by commit-queue@webkit.org

Implement a CustomEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67527

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns ScriptValue corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added the CustomEvent constructor.
  • dom/CustomEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

  • platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Updated the result.
22:45 Changeset [94479] by abarth@webkit.org

Remove WebKitClient.h
https://bugs.webkit.org/show_bug.cgi?id=67539

Reviewed by Sam Weinig.

This API no longer has any callers.

  • WebKit.gyp:
  • public/WebKit.h:
  • public/WebKitClient.h: Removed.
  • src/WebKit.cpp:
22:23 Changeset [94478] by fpizlo@apple.com

DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
https://bugs.webkit.org/show_bug.cgi?id=67551

Reviewed by Sam Weinig.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

22:14 Changeset [94477] by fpizlo@apple.com

ValueProfile does not make it safe to introspect cell values
after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=67354

Reviewed by Gavin Barraclough.

ValueProfile buckets are now weak references, implemented using a
light-weight weak reference mechanism that this patch also adds (the
WeakReferenceHarvester). If a cell stored in a ValueProfile bucket
is not marked, then the bucket is transformed into a Structure
pointer. If the Structure is not marked either, then it is turned
into a ClassInfo pointer.

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::probabilityOfArray):
(JSC::ValueProfile::WeakBucket::WeakBucket):
(JSC::ValueProfile::WeakBucket::operator!):
(JSC::ValueProfile::WeakBucket::isEmpty):
(JSC::ValueProfile::WeakBucket::isClassInfo):
(JSC::ValueProfile::WeakBucket::isStructure):
(JSC::ValueProfile::WeakBucket::asStructure):
(JSC::ValueProfile::WeakBucket::asClassInfo):
(JSC::ValueProfile::WeakBucket::getClassInfo):

  • heap/Heap.cpp:

(JSC::Heap::harvestWeakReferences):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::appendUnbarrieredPointer):

  • heap/SlotVisitor.h:
  • heap/WeakReferenceHarvester.h: Added.

(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

18:20 Changeset [94476] by commit-queue@webkit.org

Unreviewed, rolling out r94473.
http://trac.webkit.org/changeset/94473
https://bugs.webkit.org/show_bug.cgi?id=67547

Putting http://trac.webkit.org/changeset/94454 back in as
http://trac.webkit.org/changeset/94472 fixed the problem
(Requested by msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
18:08 Changeset [94475] by msaboff@apple.com

Replace local implementation of string equals() methods with UString versions
https://bugs.webkit.org/show_bug.cgi?id=67342

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.

Reviewed by Gavin Barraclough.

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):

  • runtime/Identifier.h:

(JSC::Identifier::equal):

  • wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):

  • wtf/text/StringImpl.cpp:

(WTF::equal):

  • wtf/text/StringImpl.h:
18:06 Changeset [94474] by enne@google.com

[chromium] Move updateLayers from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67438

Reviewed by James Robinson.

Covered by existing tests.

Move functionality used by both CCLayerTreeHost and
LayerRendererChromium into CCLayerTreeHostCommon. Move update, paint,
and updateCompositorResource functions into CClayerTreeHost.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Added.

(WebCore::CCLayerTreeHostCommon::isScaleOrTranslation):
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Added.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitIfNeeded):

18:02 Changeset [94473] by commit-queue@webkit.org

Unreviewed, rolling out r94454.
http://trac.webkit.org/changeset/94454
https://bugs.webkit.org/show_bug.cgi?id=67546

"Broke Windows and SnowLeopard, also no reply on the bug."
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
18:01 Changeset [94472] by msaboff@apple.com

2011-09-02 Michael Saboff <msaboff@apple.com>

Fixed release build by removing #ifndef NDEBUG to
allow definition of gcController().

Rubber-stamp by Sam Weinig.

  • WebProcess/WebProcess.cpp:
17:42 Changeset [94471] by cmarrin@apple.com

2011-09-02 Chris Marrin <cmarrin@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=67510
Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction

Reviewed by Simon Fraser.


Do a null check in two places to avoid sending nulls to CACF ValueFunction API.

Test: animations/pause-crash.html

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::valueFunction): (PlatformCAAnimation::setValueFunction):
17:41 Changeset [94470] by msaboff@apple.com

Add JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67339

Source/JavaScriptCore:

Added new test driver program (testRegExp) and corresponding data file
along with build scripts changes.

Reviewed by Gavin Barraclough.

(Options::Options):
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(RegExpTest::RegExpTest):
(GlobalObject::create):
(GlobalObject::className):
(GlobalObject::GlobalObject):
(main):
(cleanupGlobalData):
(testOneRegExp):
(scanString):
(parseRegExpLine):
(parseTestLine):
(runFromFiles):
(printUsageStatement):
(parseArguments):
(realMain):

  • tests/regexp: Added.
  • tests/regexp/RegExpTest.data: Added.

Tools:

New perl script to build JavaScriptCore and run the RegExp tests.

Reviewed by Gavin Barraclough.

  • Scripts/run-regexp-tests: Added.
17:31 Changeset [94469] by jamesr@google.com

[chromium] Update baselines and expectations.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
17:20 Changeset [94468] by msaboff@apple.com

Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519

Add a data generator for regular expressions. To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
regular expressions. The resulting data will be in /tmp/RegExpTestsData.

Reviewed by Gavin Barraclough.

  • runtime/RegExp.cpp:

(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

17:20 Changeset [94467] by enne@google.com

[chromium] Fix crash when compositing is disabled during painting
https://bugs.webkit.org/show_bug.cgi?id=66981

Reviewed by James Robinson.

This fixes a use-after-free and a null pointer deref introduced by r93940.
See also: http://codereview.chromium.org/7739008/

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::updateLayers):

17:17 Changeset [94466] by commit-queue@webkit.org

Source/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader,
SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient,
and ThreadableLoaderClient for the Chromium port only, so we can pass
these notifications from our ResourceHandle implementation through the
WebCore loader framework.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

No new tests. Exposes no new functionality.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:

(WebCore::SubresourceLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::didDownloadData):

  • loader/chromium: Added.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp: Added.

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/chromium/ResourceLoaderChromium.cpp: Added.

(WebCore::ResourceLoader::didDownloadData):

  • loader/chromium/SubresourceLoaderChromium.cpp: Added.

(WebCore::SubresourceLoader::didDownloadData):

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didDownloadData):

Source/WebKit/chromium: Add a 'didDownloadData' method to ResourceHandleInternal and pass these
notifications to WebURLLoaderClients.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didDownloadData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::didDownloadData):

  • src/ResourceHandleInternal.h:
17:16 Changeset [94465] by jeffm@apple.com

Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=67541

Reviewed by Simon Fraser.

No new tests, covered by existing media tests.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.

17:07 Changeset [94464] by jchaffraix@webkit.org

Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
https://bugs.webkit.org/show_bug.cgi?id=66901

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/assert-RenderLayer-update-positions.html

Also covered by existing tests under the new ASSERT.

This change extends the range of callers making use of the cachedOffset optimization.

Most callers did not make use of cachedOffset as it did not work when called on a subtree.
This limitation is now gone thus we can enable it more widely.

The semantics of the optimization are changed a bit as we now return if it is enabled whereas
the old code would check if it was *disabled*. Also there were some renames done to match more
closely what was going on (s/cachedOffset/offsetFromRoot/ and s/cachedOffsetDisabled/hasLayerOffset/).

Note that this is an optimistic optimization: if cachedOffset is not used, then we have
done at least an extra traversal up to the root. I have found it to be a wash on file
cycler (alexa) but to be a nice improvement (~20%) on some table benchmarks (modifying
a cell, scrolling).

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Extended the use of cachedOffset to subtree layouts.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Forbid the use cachedOffset in this
case as we have only a single layer to update.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeOffsetFromRoot): Added this function to get the offset from the root
layer at a certain point in the RenderLayer's tree. It gets the root layer's checking if no layer
in between would prevent convertToLayerCoords to work and return the position relative to
this layer.

(WebCore::RenderLayer::updateLayerPositions): Added a new ASSERT to make sure our cachedOffset
is always fine. Also added a comment about calling convertToLayerCoords.

(WebCore::RenderLayer::removeOnlyThisLayer): Added cachedOffset here too as we may have to
update several layers. We save the offset prior to being removed from the hierarchy for
correctness.

(WebCore::RenderLayer::paintChildLayerIntoColumns): Added a comment here about calling convertToLayerCoords.

  • rendering/RenderLayer.h: Swapped the argument in updateLayerPositions to make

cachedOffset a mandatory field. Patched all the callers.

(WebCore::RenderLayer::canUseConvertToLayerCoords): Added this helper method to know when a
renderer prevents convertToLayerCoords from working. Added some FIXME around suspicious use
of convertToLayerCoords.

LayoutTests:

  • fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
  • fast/layers/crash-RenderLayer-update-positions.html: Added.

Test that some changes in the layers does not cause an ASSERT failure.

16:58 Changeset [94463] by commit-queue@webkit.org

Fix the broken build due to dtoa patch
https://bugs.webkit.org/show_bug.cgi?id=67534

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Fixing the build.

  • GNUmakefile.list.am:
  • wtf/dtoa/bignum.cc:
  • wtf/dtoa/fast-dtoa.cc:
  • wtf/dtoa/utils.h:
16:39 Changeset [94462] by commit-queue@webkit.org

[Qt][Symbian] REGRESSION(93235) Missing .def update
https://bugs.webkit.org/show_bug.cgi?id=67307

Patch by Jade Han <jade.han@nokia.com> on 2011-09-02
Reviewed by Laszlo Gombos.

  • symbian/eabi/QtWebKitu.def:
16:33 Changeset [94461] by oliver@apple.com

Remove OldSpace classes
https://bugs.webkit.org/show_bug.cgi?id=67533

Reviewed by Gavin Barraclough.

Remove the unused OldSpace classes

(JSC::Heap::writeBarrierSlowCase):

  • heap/MarkedBlock.h:
  • heap/OldSpace.cpp: Removed.
  • heap/OldSpace.h: Removed.
16:25 Changeset [94460] by jamesr@google.com

Compile fix for mac build.

  • wtf/CheckedArithmetic.h:

(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

16:07 Changeset [94459] by commit-queue@webkit.org

Need API for getting surrounding text from webkit in chromium
https://bugs.webkit.org/show_bug.cgi?id=66681

Patch by Peng Huang <penghuang@chromium.org> on 2011-09-02
Reviewed by Ryosuke Niwa.

Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
WebViewImpl. This function is for supporting some input methods which
need input context around the edit caret.

  • public/WebWidget.h:

(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.h:
15:33 Changeset [94458] by eric@webkit.org

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Unreviewed. Fixing typo from previous commit.

Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block
which exercises the code I previously made a typo in.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
15:32 Changeset [94457] by mdelaney@apple.com

Read out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
https://bugs.webkit.org/show_bug.cgi?id=65352

Reviewed by Simon Fraser.

New test: fast/canvas/canvas-getImageData-large-crash.html

Source/JavaScriptCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC
is just to add a new helper method described below.

  • wtf/MathExtras.h:

(isWithinIntRange): Reports if a float's value is within the range expressible by an int.

Source/WebCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice): Removed dependency on ints, using FloatRects/Sizes instead.
(WebCore::HTMLCanvasElement::createImageBuffer): Moved the check for max canvas area and dimensions here.

Added in check that prevents us from having canvases of sizes that will cause overflows.

(WebCore::HTMLCanvasElement::baseTransform): Updated use of convertLogicalToDevice.

  • html/HTMLCanvasElement.h: Updated method signatures.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData): Added in check to prevent creating ImageData objects that will cause overflow when computing their size.
(WebCore::CanvasRenderingContext2D::createImageData): Avoid creating ImageData objects of size that will overflow later.
(WebCore::CanvasRenderingContext2D::getImageData): Added in check to prevent trying to get ImageData objects that will cause overflow when computing their size.

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::isExpressibleAsIntRect): New method that tests whether a FloatRect can become an IntRect without overflow or having to be clamped.

  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isExpressibleAsIntSize): Same as FloatRect, but for FloatSize->IntSize.

  • platform/graphics/FloatSize.h:
  • platform/graphics/cg/ImageBufferCG.cpp: Added check for overflow.

(WebCore::ImageBuffer::ImageBuffer):

15:22 Changeset [94456] by andersca@apple.com

NPN_SetException doesn't work with OOP plug-ins
https://bugs.webkit.org/show_bug.cgi?id=67524

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProcessConnection.messages.in.

  • GNUmakefile.am:

Add generated files.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassPluginProcessConnection.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initialize):
Set the set exception function.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::ConnectionStack::current):
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher):
Add a helper class for managing a stack of CoreIPC connections, along with a RAII
object to push/pop connections onto it.

(WebKit::connectionStack):
Add getter.

(WebKit::WebProcessConnection::setGlobalException):
Get the current connection and send a PluginProcessConnection::SetException message to it.

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
Create connection pushers.

  • PluginProcess/WebProcessConnection.h:

Add setGlobalException.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setSetExceptionFunction):
New function for setting the 'setException' function.

(WebKit::NetscapePlugin::setException):
Call the 'setException' function.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveSyncMessage):
Call the message receiver function.

(WebKit::PluginProcessConnection::setException):
Call the NPRuntimeObjectMap.

  • WebProcess/Plugins/PluginProcessConnection.messages.in:

Add new messages file.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
When not using the plug-in process, make sure to call NetscapePlugin::setSetExceptionFunction.

15:22 Changeset [94455] by mitz@apple.com

<rdar://problem/9755843> anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node

Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/operator-hijacks-fenced-node.xhtml

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().

LayoutTests:

  • mathml/operator-hijacks-fenced-node-expected.txt: Added.
  • mathml/operator-hijacks-fenced-node.xhtml: Added.
15:21 Changeset [94454] by adachan@apple.com

Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=67526

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.
15:19 Changeset [94453] by eric@webkit.org

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Reviewed by Adam Barth.

No functional change, just reshuffling code.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:09 Changeset [94452] by commit-queue@webkit.org

Incorporate newer, faster dtoa library
https://bugs.webkit.org/show_bug.cgi?id=66346

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/UString.cpp:

(JSC::UString::number):

  • wtf/CMakeLists.txt:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::dtoa):

  • wtf/dtoa.h:
  • wtf/dtoa/COPYING: Added.
  • wtf/dtoa/LICENSE: Added.
  • wtf/dtoa/README: Added.
  • wtf/dtoa/bignum-dtoa.cc: Added.
  • wtf/dtoa/bignum-dtoa.h: Added.
  • wtf/dtoa/bignum.cc: Added.
  • wtf/dtoa/bignum.h: Added.

(WTF::double_conversion::Bignum::Times10):
(WTF::double_conversion::Bignum::Equal):
(WTF::double_conversion::Bignum::LessEqual):
(WTF::double_conversion::Bignum::Less):
(WTF::double_conversion::Bignum::PlusEqual):
(WTF::double_conversion::Bignum::PlusLessEqual):
(WTF::double_conversion::Bignum::PlusLess):
(WTF::double_conversion::Bignum::EnsureCapacity):
(WTF::double_conversion::Bignum::BigitLength):

  • wtf/dtoa/cached-powers.cc: Added.
  • wtf/dtoa/cached-powers.h: Added.
  • wtf/dtoa/diy-fp.cc: Added.
  • wtf/dtoa/diy-fp.h: Added.

(WTF::double_conversion::DiyFp::DiyFp):
(WTF::double_conversion::DiyFp::Subtract):
(WTF::double_conversion::DiyFp::Minus):
(WTF::double_conversion::DiyFp::Times):
(WTF::double_conversion::DiyFp::Normalize):
(WTF::double_conversion::DiyFp::f):
(WTF::double_conversion::DiyFp::e):
(WTF::double_conversion::DiyFp::set_f):
(WTF::double_conversion::DiyFp::set_e):

  • wtf/dtoa/double-conversion.cc: Added.
  • wtf/dtoa/double-conversion.h: Added.

(WTF::double_conversion::DoubleToStringConverter::DoubleToStringConverter):
(WTF::double_conversion::StringToDoubleConverter::StringToDoubleConverter):

  • wtf/dtoa/double.h: Added.

(WTF::double_conversion::double_to_uint64):
(WTF::double_conversion::uint64_to_double):
(WTF::double_conversion::Double::Double):
(WTF::double_conversion::Double::AsDiyFp):
(WTF::double_conversion::Double::AsNormalizedDiyFp):
(WTF::double_conversion::Double::AsUint64):
(WTF::double_conversion::Double::NextDouble):
(WTF::double_conversion::Double::Exponent):
(WTF::double_conversion::Double::Significand):
(WTF::double_conversion::Double::IsDenormal):
(WTF::double_conversion::Double::IsSpecial):
(WTF::double_conversion::Double::IsNan):
(WTF::double_conversion::Double::IsInfinite):
(WTF::double_conversion::Double::Sign):
(WTF::double_conversion::Double::UpperBoundary):
(WTF::double_conversion::Double::NormalizedBoundaries):
(WTF::double_conversion::Double::value):
(WTF::double_conversion::Double::SignificandSizeForOrderOfMagnitude):
(WTF::double_conversion::Double::Infinity):
(WTF::double_conversion::Double::NaN):
(WTF::double_conversion::Double::DiyFpToUint64):

  • wtf/dtoa/fast-dtoa.cc: Added.
  • wtf/dtoa/fast-dtoa.h: Added.
  • wtf/dtoa/fixed-dtoa.cc: Added.
  • wtf/dtoa/fixed-dtoa.h: Added.
  • wtf/dtoa/strtod.cc: Added.
  • wtf/dtoa/strtod.h: Added.
  • wtf/dtoa/utils.h: Added.

(WTF::double_conversion::Max):
(WTF::double_conversion::Min):
(WTF::double_conversion::StrLength):
(WTF::double_conversion::Vector::Vector):
(WTF::double_conversion::Vector::SubVector):
(WTF::double_conversion::Vector::length):
(WTF::double_conversion::Vector::is_empty):
(WTF::double_conversion::Vector::start):
(WTF::double_conversion::Vector::operator[]):
(WTF::double_conversion::Vector::first):
(WTF::double_conversion::Vector::last):
(WTF::double_conversion::StringBuilder::StringBuilder):
(WTF::double_conversion::StringBuilder::~StringBuilder):
(WTF::double_conversion::StringBuilder::size):
(WTF::double_conversion::StringBuilder::position):
(WTF::double_conversion::StringBuilder::Reset):
(WTF::double_conversion::StringBuilder::AddCharacter):
(WTF::double_conversion::StringBuilder::AddString):
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::AddPadding):
(WTF::double_conversion::StringBuilder::Finalize):
(WTF::double_conversion::StringBuilder::is_finalized):
(WTF::double_conversion::BitCast):

  • wtf/wtf.pri:

Source/WebCore:

No new tests.

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

  • ForwardingHeaders/wtf/dtoa/double-conversion.h: Added.
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorBasicValue::writeJSON):

  • platform/graphics/Color.cpp:

(WebCore::Color::serialized):

14:57 Changeset [94451] by commit-queue@webkit.org

Add LayoutTest for the case where long strings are processed by the XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=66580

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-02
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/resources/xss-filter-bypass-long-string-reply.html: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string.html: Added.
14:35 Changeset [94450] by nduca@chromium.org

[chromium] Check for null context when reinitializing compositor
https://bugs.webkit.org/show_bug.cgi?id=67507

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

14:16 Changeset [94449] by fpizlo@apple.com

DFG graph has no way of distinguishing or reconciling between static
and dynamic predictions
https://bugs.webkit.org/show_bug.cgi?id=67343

Reviewed by Gavin Barraclough.

PredictedType now stores the source of the prediction. Merging predictions,
which was previously done with a bitwise or, is now done via the
mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
functions, which correctly handle combinations of static and dynamic.

This is performance-neutral, since all predictions are currently static and
so the code has no visible effects.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::staticallyPredictArray):
(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):

  • dfg/DFGNode.h:

(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isDynamicPrediction):
(JSC::DFG::mergePredictions):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::predict):

14:08 Changeset [94448] by oliver@apple.com

Fix 32bit build.

13:49 Changeset [94447] by lforschler@apple.com

Versioning.

13:48 Changeset [94446] by jer.noble@apple.com

Some media layout tests fail because of ambiguous ordering of canplaythough event.
https://bugs.webkit.org/show_bug.cgi?id=67520

Reviewed by Eric Carlson.

The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.

  • media/audio-play-event-expected.txt:
  • media/audio-play-event.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-during-playback.html:
13:41 Changeset [94445] by oliver@apple.com

Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Gavin Barraclough.

Switch to a bump allocator for the initial out of line
property storage. This gives us slightly faster allocation
for short lived objects that need out of line storage at
the cost of an additional memcpy when the object survives
a GC pass.

No performance impact.

(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursary):

  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursary):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursary):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

13:33 Changeset [94444] by darin@apple.com

Added Subversion ignore for .pyc generated files.

  • Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
  • Scripts/webkitpy/tool/servers: Added property svn:ignore.
13:25 Changeset [94443] by jamesr@google.com

[chromium] Update expectations for tests with animations and reflections

  • platform/chromium/test_expectations.txt:
12:55 Changeset [94442] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • DEPS:
12:48 Changeset [94441] by abarth@webkit.org

Enable testing on mac-ews
https://bugs.webkit.org/show_bug.cgi?id=67505

Reviewed by Eric Seidel.

This patch enables testing on the Mac EWS, which should help
contributors not turn the Mac bots red.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:40 Changeset [94440] by jamesr@google.com

[chromium] Update some chromium gpu baselines

  • platform/chromium-gpu-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 Changeset [94439] by andersca@apple.com

Remove plug-in paths from web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=67518

Reviewed by Adam Roben.

Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile.

  • WebProcess/com.apple.WebProcess.sb:
12:19 Changeset [94438] by andersca@apple.com

Assertion/crash when running netscape-plugin-property-access-exception.html test
https://bugs.webkit.org/show_bug.cgi?id=67517

Reviewed by Adam Roben.

Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
but doesn't set the result NPVariant to anything.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::getProperty):

11:55 Changeset [94437] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67451
Add a test for going back to a cached page after changing the device scale factor

Reviewed by Adam Roben.

New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.

(TestWebKitAPI::DeviceScaleFactorOnBack::url):
(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
(TestWebKitAPI::TEST_F):

Added new function to WebKitAgnosticTest to goBack. Separated
waitForLoadToFinish() into its own function (instead of being a part of
loadAndWaitUntilFinished()) so that it can be called from goBack as
well. Also added initializeView() so we can set the cache model.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h:

(TestWebKitAPI::WebKitAgnosticTest::initializeView):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
(TestWebKitAPI::WebKitAgnosticTest::loadURL):
(TestWebKitAPI::WebKitAgnosticTest::goBack):
(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):

11:35 Changeset [94436] by ap@apple.com

Flaky Test: http/tests/appcache/origin-usage.html
https://bugs.webkit.org/show_bug.cgi?id=60928

Reviewed by Joseph Pecoraro.

Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.

  • http/tests/appcache/origin-usage-expected.txt:
  • http/tests/appcache/origin-usage.html: Increase the range for success. It's OK because data is added in larger chunks anyway.
11:17 Changeset [94435] by andersca@apple.com

The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508

Reviewed by Sam Weinig.

Source/WebKit2:

Store the new private browsing state so subsequent queries for it
will return the right value.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::privateBrowsingStateChanged):

LayoutTests:

Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.

  • platform/wk2/Skipped:
11:02 Changeset [94434] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

  • platform/chromium-mac/media/controls-after-reload-expected.txt: Added.

(remaining files omitted for brevity)

10:42 Changeset [94433] by weinig@apple.com

Remove BeforeProcessEvent, it was never meant to be
https://bugs.webkit.org/show_bug.cgi?id=67493

Reviewed by Anders Carlsson.

BeforeProcessEvent was added, never hooked up, and never removed.
Now it is being removed.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeProcessEvent.cpp: Removed.
  • dom/BeforeProcessEvent.h: Removed.
  • dom/BeforeProcessEvent.idl: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:
  • dom/EventNames.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseMappedAttribute):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseMappedAttribute):

10:41 Changeset [94432] by andersca@apple.com

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:

(PrivateBrowsing::ScriptableObject::pluginTest):

10:36 Changeset [94431] by enne@google.com

[chromium] Remove LayerRendererChromium references from the LayerChromium tree
https://bugs.webkit.org/show_bug.cgi?id=66430

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

Replace references to LayerRendererChromium in the LayerChromium tree
with references to LayerTreeHost. The LayerRendererChromium property
is no longer synced and instead is set recursively on the CCLayerImpl
tree during commit.

WebGLLayerChromium's paintRenderedResultsToCanvas function is
temporarily turned off for threaded compositing because it needs
access to the compositor context.

Previously, changing the layer renderer on a layer called cleanup
resources on that layer. Now, call that explicitly clean up all
resources explicitly from the proxy when the layer renderer gets
created. This cleans up all of the ManagedTexture objects which may be
hanging onto stale GraphicsContext3D pointers.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::cleanupResourcesRecursive):
(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::textureManager):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::reserveTextures):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setTextureUpdated):
(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setLayerRendererRecursive):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

Source/WebKit/chromium:

Change references to LayerRendererChromium to CCLayerTreeHost.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):

10:33 Changeset [94430] by andersca@apple.com

Move private browsing test to a PluginTest subclass
https://bugs.webkit.org/show_bug.cgi?id=67498

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginGetProperty):

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.

(PrivateBrowsing::PrivateBrowsing):
(PrivateBrowsing::privateBrowsingEnabled):
(PrivateBrowsing::cachedPrivateBrowsingEnabled):
(PrivateBrowsing::ScriptableObject::hasProperty):
(PrivateBrowsing::ScriptableObject::getProperty):
(PrivateBrowsing::ScriptableObject::pluginTest):
(PrivateBrowsing::NPP_New):
(PrivateBrowsing::NPP_GetValue):
(PrivateBrowsing::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
(NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

Set the 'test' attribute to 'private-browsing'.

  • plugins/private-browsing-mode-2.html:
  • plugins/private-browsing-mode.html:
10:24 Changeset [94429] by apavlov@chromium.org

[Chromium] Unreviewed, update expectations after r94420.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
10:09 Changeset [94428] by ap@apple.com

Build fix.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.
10:07 Changeset [94427] by commit-queue@webkit.org

Unreviewed, rolling out r94421.
http://trac.webkit.org/changeset/94421
https://bugs.webkit.org/show_bug.cgi?id=67496

Broke a number of tests on Chromium builders (including the
"cr-linux" EWS bot) (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

10:02 Changeset [94426] by ap@apple.com

REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=67356

Reviewed by Darin Adler.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Don't enable old-style private browsing when using sessions - it would take precedence over session cookie storage on Snow Leopard.
10:01 Changeset [94425] by commit-queue@webkit.org

BORDER attribute percent with the input image tag not working.
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-09-02
Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes 2 issues regarding the border attribute of an input image element.

  1. The border attribute, if specified, is now taken into account and the border of the input image element is displayed.
  2. If the border attribute contains percent, the border is displayed.

The value of the border attribute for input image element is now parsed according to the rules for parsing non-negative integers.
This implies that when percent is specified in the border attribute, parsing takes place and the percent is ignored.
If after parsing, the value of the border is greater than zero, the border of the input image element is displayed.

  • html/HTMLElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttribute):

  • html/HTMLElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Test border-width-percent was modified with tests for input image element.
Expected results for input-image-alt-test were regenerated since an image input element
takes border attribute into account.
Also, mark the test as failure for chromium.

  • fast/borders/border-width-percent-expected.txt:
  • fast/borders/border-width-percent.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
09:59 Changeset [94424] by rolandsteiner@chromium.org

Implement the Event constructor for V8.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Source/WebCore:

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor
This patch implements the Event constructor for V8 in V8EventConstructors.cpp,
similar to the implementation for JSC in JSEventConstructors.cpp.

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added.

(WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback().

  • dom/Event.idl: Added |V8CustomConstructor|.

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html.
09:50 Changeset [94423] by antonm@chromium.org

[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=67484

Reviewed by Yury Semikhatsky.

No new tests, minor cleanup.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyEnumerator):

09:38 Changeset [94422] by commit-queue@webkit.org

Unreviewed, rolling out r94404.
http://trac.webkit.org/changeset/94404
https://bugs.webkit.org/show_bug.cgi?id=67490

"Patch is wrong, new API needs two reviewers, we are already
working on how to add notifications elsewhere" (Requested by
xan_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • bindings/gobject/GNUmakefile.am:
09:13 Changeset [94421] by andreas.kling@nokia.com

Use fastGetAttribute() and fastHasAttribute() where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=67394

Reviewed by Darin Adler.

Change call sites that don't check the "style" or SVG animatable
attributes to use fastGetAttribute()/fastHasAttribute() instead
of getAttribute()/hasAttribute().

No new tests, this is a minor performance optimization.

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

09:00 Changeset [94420] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67431

Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two
repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we
handle border radius).

Reviewed by Beth Dakin.

Added fast/borders/border-image-repeat.html.

Source/WebCore:

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Modified the CSSBorderImageValue (you're living on borrowed time, my friend!) to have a CSSValue that
contains a Pair.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForRepeatRule):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for the new properties. Break out the value retrieval for the image repeat rules into its
own function, valueForNinePieceImageRepeat.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitWidth):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modified the parsing of border image to call into parseBorderImageRepeat for the repeat values.

(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
The new parsing code for border-image-repeat is here. It will build up a CSSValue containing a Pair and
return the result.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:

Add the new properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageRepeat):

  • css/CSSStyleSelector.h:

The mapping into the front end is done the same way as border-image-slice. Factor out the image repeat rules
portion into mapNinePieceImageRepeat.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

Add the new 'space' value as a valid image tiling rule. It's not yet supported and, like the 'round' value,
is just mapped to 'repeat' for now.

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::copyRepeatFrom):
Helper for copying only the repeat rules from another NinePieceImage.

LayoutTests:

  • fast/borders/border-image-repeat.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/borders/border-image-repeat-expected.png: Added.
  • platform/mac/fast/borders/border-image-repeat-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
08:57 Changeset [94419] by commit-queue@webkit.org

Source/WebCore: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

Properly render Qt's number input with RTL direction, and fix Plastique styling.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

LayoutTests: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

New baseline for Qt number input with RTL direction.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png:
08:35 Changeset [94418] by commit-queue@webkit.org

Source/WebCore: Resetting media controls when the src is changed from a valid url to an
invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

Test: media/media-controls-invalid-url.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaLoadingFailed):

LayoutTests: Controls not reset when media element url changed from a valid url to an invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

  • media/media-controls-invalid-url-expected.txt: Added.
  • media/media-controls-invalid-url.html: Added.
07:09 Changeset [94417] by commit-queue@webkit.org

[WK2] Anchor elements doesn't get focus on TAB key press.
https://bugs.webkit.org/show_bug.cgi?id=66949

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-02
Reviewed by Adam Roben.

Setting the default property value of TabsToLinks to true
only for GTK platform since Win & Mac platforms doesn't want
it to be set to true by default.

  • Shared/WebPreferencesStore.h:

Set the default value of key TabsToLinks to true for GTK platform only.

07:05 Changeset [94416] by zoltan@webkit.org

[Qt][WK2] 4 tests are failing, skip them
https://bugs.webkit.org/show_bug.cgi?id=67485

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-02

  • platform/qt-wk2/Skipped:
07:02 Changeset [94415] by dominicc@chromium.org

Unreviewed test fix.

Sadly window-property-descriptors enumerates functions in the test
harness. r94362 added a couple of functions, so these results need
to be updated.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
06:22 Changeset [94414] by leandro@webkit.org

Unreviewed build fix after r67110.

  • ewk/ewk_view.cpp:

(ewk_view_need_touch_events_get): Make the function signature match
its declaration.

06:09 Changeset [94413] by reni@webkit.org

[Qt] Two tests are passing after r94324. They are unskipped:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

Unreviewed gardening.

  • platform/qt/Skipped:
05:46 Changeset [94412] by apavlov@chromium.org

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
05:35 Changeset [94411] by kbalazs@webkit.org

[Qt][WK2] Cannot gathering glyph page statistics
https://bugs.webkit.org/show_bug.cgi?id=67475

Rubber stamped by Csaba Osztrogonác.

Fix Qt WK2 build without having QRAWFONT.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

04:49 Changeset [94410] by vsevik@chromium.org

Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/networkPanel.css:

(.resource-headers-view .outline-disclosure li .status-from-cache):

04:41 Changeset [94409] by vsevik@chromium.org

Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):

04:39 Changeset [94408] by vsevik@chromium.org

Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):

04:36 Changeset [94407] by ossy@webkit.org

[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Trivial fix after r94288.

Rubber-stamped by Andras Becsi.

  • Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.

(buildQMakeProject):

04:19 Changeset [94406] by antti@apple.com

De-virtualize recalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=67378

Reviewed by Dimitri Glazkov.

Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will
also make it possible to de-recursify it later.

Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc.
These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Element.h:

(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

  • dom/Node.h:

(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/ShadowRoot.h:
  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didRecalcStyle):

  • html/HTMLFormControlElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willRecalcStyle):

  • html/HTMLFrameSetElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::didRecalcStyle):

  • html/HTMLMediaElement.h:
  • html/HTMLNoScriptElement.cpp:

(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::willRecalcStyle):

  • html/HTMLNoScriptElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::willRecalcStyle):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::didRecalcStyle):

  • svg/SVGUseElement.h:
04:16 Changeset [94405] by yutak@chromium.org

WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Re-lands r94399 with a fix for Leopard builds.

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
04:10 Changeset [94404] by paroga@webkit.org

[GTK] Generate gobject bindings for Notification and NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=67380

Reviewed by Philippe Normand.

  • bindings/gobject/GNUmakefile.am:
03:54 Changeset [94403] by bashi@chromium.org

[chromium] editing/selection/regional-indicators.html timing out on Linux
https://bugs.webkit.org/show_bug.cgi?id=66510

Reviewed by Kent Tamura.

Source/WebCore:

Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly.

No new tests. editing/selection/regional-indicators.html should pass with this patch.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run.
(WebCore::surrogatePairAwareFirstCharacter): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData.

LayoutTests:

ComplexTextControllerLinux is now surrogate pairs aware, therefore;

  • editing/selection/regional-indicators.html should pass.
  • editing/deleting/regional-indicators.html should not timeout.
  • fast/text/regional-indicator-symbols.html should pass.
  • platform/chromium/test_expectations.txt:
03:51 Changeset [94402] by commit-queue@webkit.org

Unreviewed, rolling out r94399.
http://trac.webkit.org/changeset/94399
https://bugs.webkit.org/show_bug.cgi?id=67471

Broke Leopard build (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-empty.html: Removed.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-object.html: Removed.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-empty.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
03:40 Changeset [94401] by commit-queue@webkit.org

Unreviewed, rolling out r94393.
http://trac.webkit.org/changeset/94393
https://bugs.webkit.org/show_bug.cgi?id=67470

It broke Qt-SL build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • WebCore.pro:
03:38 Changeset [94400] by bashi@chromium.org

[Chromium] Webfonts display bold in Windows
https://bugs.webkit.org/show_bug.cgi?id=67387

Uses font's default weight for webfonts by setting FW_DONTCARE.

Reviewed by Kent Tamura.

No new tests. We don't have fonts to test this change.

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight.

03:36 Changeset [94399] by yutak@chromium.org

WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hixie76/send-empty.html

http/tests/websocket/tests/hixie76/send-object.html
http/tests/websocket/tests/hybi/send-blob.html
http/tests/websocket/tests/hybi/send-empty.html
http/tests/websocket/tests/hybi/send-file-blob-fail.html
http/tests/websocket/tests/hybi/send-file-blob.html
http/tests/websocket/tests/hybi/workers/send-blob.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

Fixing code generator did not sound easy, because there are some classes depending on
broken behavior of current code generator (one such example is CanvasRenderingContext2D).
As a temporary workaround, new custom handlers for send() are added.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
A Blob can be deserialized from url, type and size.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
KURL, String and long long (corresponding to url, type and size, respectively) can be passed
safely across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Updated. Added tests to send Blobs.

  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html:

Added. Send three Blobs each of which contains a small binary message.

  • http/tests/websocket/tests/hybi/send-blob_wsh.py:

Added. receive_message() returns a unicode value if the received message was text, or
a str value if the message was binary.

  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:

Added. If we delete a file before reading it, FileReaderLoader reliably fails.

  • http/tests/websocket/tests/hybi/send-file-blob.html:

Added. Create a File and try to send it as a Blob.

  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Added. Same as send-blob.html above.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py:

Added. Same as send-blob_wsh.py above.

  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:

send-file-blob.html and send-file-blob-fail.html depend on availability of File API.

  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
03:21 Changeset [94398] by mrowe@apple.com

<http://webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.

02:58 Changeset [94397] by philn@webkit.org

[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
02:53 Changeset [94396] by abecsi@webkit.org

Remove my old e-mail address and add my new one.

Rubber-stamped by Tor Arne Vestbø.

  • Scripts/webkitpy/common/config/committers.py:
02:33 WebKit Team edited by abecsi@webkit.org
(diff)
02:09 Changeset [94395] by philn@webkit.org

Unreviewed, GTK rebaseline after r94304.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
01:49 Changeset [94394] by reni@webkit.org

[Qt] Update Qt specific expected files after r94304.

Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
01:26 Changeset [94393] by ossy@webkit.org

[Qt][WK2] Unreviewed speculative buildfix.

  • WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES.
01:25 Changeset [94392] by reni@webkit.org

[Qt] Add Qt expecteds for new tests.

Unreviewed gardening.

  • platform/qt/fast/borders/border-image-slices-expected.png: Added.
  • platform/qt/fast/borders/border-image-slices-expected.txt: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
00:58 Changeset [94391] by commit-queue@webkit.org

Unreviewed, rolling out r94389.
http://trac.webkit.org/changeset/94389
https://bugs.webkit.org/show_bug.cgi?id=67468

breaks mac build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
00:41 Changeset [94390] by commit-queue@webkit.org

Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67459

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Tests: fast/eventsource/eventsource-constructor.html

fast/eventsource/eventsource-attribute-listeners.html

  • WebCore.gypi: Removed V8EventSourceConstructor.cpp.
  • WebCore.pro: Removed V8EventSourceConstructor.cpp.
  • bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
  • page/EventSource.idl: Added the 'Constructor' extended attribute.
00:35 Changeset [94389] by philn@webkit.org

[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
00:32 Changeset [94388] by philn@webkit.org

[GTK] run-gtk-tests leaves a zombie Xvfb process
https://bugs.webkit.org/show_bug.cgi?id=67389

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests: Properly close STDIN and STDERR on the child process instead of doing shell redirection.

09/01/11:

23:33 Changeset [94387] by commit-queue@webkit.org

[WebSocket] Implement WebSocket::close() code and reason handling.
https://bugs.webkit.org/show_bug.cgi?id=66925

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-09-01
Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close.html

http/tests/websocket/tests/hybi/workers/close.html

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::close):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::closeCallback):
Add custom bridge for WebSocket::close().

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::close):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::close):
Add code and reason arguments handling.
(WebCore::WebSocketChannel::startClosingHandshake):
Send a close frame without code and reason on server initiated closing handshakes.
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::close):
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):

  • websockets/WorkerThreadableWebSocketChannel.h:

Add code and reason arguments handling.

LayoutTests:

  • http/tests/websocket/tests/hybi/close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close.html: Added.
  • http/tests/websocket/tests/hybi/close_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/close.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/close.js: Added.

(postResult):
(testFailed):
(debug):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):
(handleOpen):
(handleError):
(handleClose):
(handleMessage):
(setDefaultHandlers):
(runCodeTest.else.ws.onclose):
(runCodeTest):
(runInvalidStringTest):
(runReasonTest.else.ws.onclose):
(runReasonTest):
(runCodeAndReasonTest.):
(runCodeAndReasonTest):

21:57 Changeset [94386] by mrowe@apple.com

Fix the build by adding some more missing return types.

Source/WebCore:

  • page/mac/WebCoreViewFactory.m:

(-[WebCoreViewFactory init]):

Source/WebKit/mac:

  • WebView/WebDashboardRegion.h:
  • WebView/WebDashboardRegion.mm:

(-[WebDashboardRegion initWithRect:clip:type:]):

Tools:

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

21:03 Changeset [94385] by dominicc@chromium.org

Unreviewed test fix.

r94362 erroneously changed the description wording generated by
the js-test-pre.

  • fast/js/resources/js-test-pre.js:

(description): add the word 'see'

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
20:59 Changeset [94384] by jamesr@google.com

[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text

  • platform/chromium-cg-mac-leopard/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-gaps-expected.png: Added.
19:27 Changeset [94383] by michaeln@google.com

[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
https://bugs.webkit.org/show_bug.cgi?id=67457

The removeOpenDatabase() method can get called multiple times.
Subsequent calls to it should be harmeless instead of cause a crash.

Reviewed by David Levin.

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::removeOpenDatabase):

19:12 Changeset [94382] by tkent@chromium.org

The filename text color of a file upload control should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=67368

Reviewed by Darin Adler.

Source/WebCore:

  • css/html.css:

(input[type="file"]):
Add 'color: inherit'.
The declaration for 'input' contains 'color: initial;'. So a file
upload control has had black foreground color unless it has been
specified 'color' property explicitly.
Because a file upload control uses inherited background color, the
foreground color also should be inherited.

LayoutTests:

  • fast/forms/file/file-style-inheritance-expected.txt:
  • fast/forms/file/file-style-inheritance.html: Add a testcase.
18:37 Changeset [94381] by commit-queue@webkit.org

Generate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67447

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/workers/worker-constructor.html

fast/workers/worker-event-listener.html

  • bindings/v8/custom/V8WorkerCustom.cpp: Removed constructorCallback().
  • workers/Worker.idl: Added the 'Constructor' extended attribute.
18:35 Changeset [94380] by gyuyoung.kim@samsung.com

[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=67012

Reviewed by Kenneth Russell.

Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
to better minimum value for performance. Mac, android, chromium and window ports already
use 4ms instead of 10ms.

It is desirable to be able to change the minimum DOMTimer interval on per-page basis
in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
other ports have already used this setting by means of Bug 54312.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_default_timer_interval_get):

  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_minimum_timer_interval_get):

  • ewk/ewk_view.h:
18:33 Changeset [94379] by jamesr@google.com

[chromium] Add chromium leopard baselines

  • platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.
18:25 Changeset [94378] by commit-queue@webkit.org

[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=63377

priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
So removal of this api and some codes related with it is required.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-01
Reviewed by Antonio Gomes.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_smart_add):
(ewk_tiled_backing_store_enable_render):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.c:

(ewk_view_tiled_unused_cache_set):

18:00 Changeset [94377] by jamesr@google.com

[chromium] Remove expectation lines for tests that pass

  • platform/chromium/test_expectations.txt:
17:51 Changeset [94376] by mrowe@apple.com

Fix the build.

17:49 Changeset [94375] by commit-queue@webkit.org

Generate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67412

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Adam Barth.

Test: fast/files/blob-slice-test.html

fast/files/file-reader-abort.html

  • bindings/v8/custom/V8FileReaderCustom.cpp: Removed constructorCallback().
  • fileapi/FileReader.idl: Added the 'Constructor' extended attribute.
17:42 Changeset [94374] by mitz@apple.com

Added Snow Leopard expected results to the test added in r94352.

  • platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
17:32 Changeset [94373] by commit-queue@webkit.org

Source/WebCore: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
Fixed a bug noticed by a benjaminp while reviewing a different
ndonned patch where global positions were not being set correctly
on gesture-driven mouse wheel events.

  • platform/chromium/GestureRecognizerChromium.cpp:

Changed static per-edge functions into methods and improves
encapsulation. No new functionality is present.
(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::addEdgeFunction):
(WebCore::GestureRecognizerChromium::isInClickTimeWindow):
(WebCore::GestureRecognizerChromium::isInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::appendClickGestureEvent):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::appendScrollGestureBegin):
(WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
(WebCore::GestureRecognizerChromium::appendScrollGestureUpdate):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::signature):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::scrollEnd):
(WebCore::GestureRecognizerChromium::noGesture):
(WebCore::GestureRecognizerChromium::click):
(WebCore::GestureRecognizerChromium::isClickOrScroll):
(WebCore::GestureRecognizerChromium::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::setState):

Source/WebKit/chromium: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Updated GestureRecognizer unit tests for more encapsulated
gesture recognizer implementation.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(InspectableGestureRecognizerChromium::InspectableGestureRecognizerChromium):
(InspectableGestureRecognizerChromium::signature):
(InspectableGestureRecognizerChromium::edgeFunction):
(InspectableGestureRecognizerChromium::updateValues):
(InspectableGestureRecognizerChromium::addEdgeFunction):
(InspectableGestureRecognizerChromium::setStateTest):
(InspectableGestureRecognizerChromium::isInsideManhattanSquare):
(InspectableGestureRecognizerChromium::isInClickTimeWindow):
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(GestureRecognizerTest::GestureRecognizerTest):
(TEST_F):

17:29 Changeset [94372] by jchaffraix@webkit.org

Move LayoutRepainter to its own class
https://bugs.webkit.org/show_bug.cgi?id=66255

Reviewed by Hajime Morita.

No new tests, code movement only.

  • rendering/RenderObject.h: Moved code from here ...
  • rendering/LayoutRepainter.cpp: Added.

(WebCore::LayoutRepainter::LayoutRepainter):
(WebCore::LayoutRepainter::repaintAfterLayout):

  • rendering/LayoutRepainter.h: Added.

(WebCore::LayoutRepainter::checkForRepaint):
... to those 2 files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Updated our build systems.

  • rendering/RenderingAllInOne.cpp:

Needed for the Windows bot.

  • rendering/RenderBlock.cpp:
  • rendering/RenderDeprecatedFlexibleBox.cpp:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderTable.cpp:
  • rendering/svg/RenderSVGContainer.cpp:
  • rendering/svg/RenderSVGForeignObject.cpp:
  • rendering/svg/RenderSVGImage.cpp:
  • rendering/svg/RenderSVGPath.cpp:
  • rendering/svg/RenderSVGRoot.cpp:
  • rendering/svg/RenderSVGText.cpp:

Added #include "LayoutRepainter".

17:20 Changeset [94371] by adachan@apple.com

Source/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160

Don't ifdef out the data member xslStyleSheets in MemoryCache::Statistics to cut down
the ifdefs in getWebCoreMemoryCacheStatistics() in WebKit2/WebProcess/WebProcess.cpp.

Reviewed by Darin Adler.

No new tests required. Just small code refactoring.

  • loader/cache/MemoryCache.h:

Source/WebKit2: Cut down the ifdefs in WebKit::getWebCoreMemoryCacheStatistics() now that
MemoryCache::Statistics always has the xslStyleSheets field.

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):

17:20 Changeset [94370] by jamesr@google.com

[chromium] Update leopard pixel baselines for svg tests

  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-cg-mac/svg/custom/pattern-rotate-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/pattern-rotate-gaps-expected.png: Added.
17:18 Changeset [94369] by jchaffraix@webkit.org

REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-link.html

fast/css/stylesheet-enable-first-alternate-on-load-link.html
fast/css/stylesheet-enable-first-alternate-on-load-sheet.html
fast/css/stylesheet-enable-second-alternate-link.html
fast/css/stylesheet-enable-second-alternate-on-load-link.html
fast/css/stylesheet-enable-second-alternate-on-load-sheet.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

This patch basically reverts 88479 and 84329 while keeping the tests
we developped during the implementation.

Following discussion, it looks like HTML5 will need to be amended.
In the meantime, we will just revert the changes so that we can come
up with a better change.

  • dom/Document.cpp:

(WebCore::Document::recalcStyleSelector):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
Revert those method to their original content.

  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isDisabled):
(WebCore::HTMLLinkElement::isEnabledViaScript):
(WebCore::HTMLLinkElement::isAlternate):
Re-introduced the DisabledState enum.

  • html/HTMLLinkElement.idl: |disabled| is Reflect'ed again.

LayoutTests:

  • fast/css/stylesheet-enable-first-alternate-link-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-link.html: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-link-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-link.html: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-sheet-expected.txt: Added.
  • fast/css/stylesheet-enable-first-alternate-on-load-sheet.html: Added.
  • fast/css/stylesheet-enable-second-alternate-link-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-link.html: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-link-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-link.html: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-sheet-expected.txt: Added.
  • fast/css/stylesheet-enable-second-alternate-on-load-sheet.html: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.

(onSheetLoaded):
(testWhenLoaded):

  • http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
  • http/tests/css/resources/slow-loading-sheet.php: Added.

New tests developped for 65140. The baselines matches what FF and Opera are doing (IE does not support
link.sheet at the moment). Those failures are covered by bug 67436.

  • fast/css/link-disabled-attr-expected.txt:
  • fast/dom/HTMLLinkElement/disabled-attribute-expected.txt:

Fixed the baseline to match our behavior. The FAIL are our current deviation from the spec. Those
failures are covered by bug 67436.

  • fast/dom/boolean-attribute-reflection-expected.txt:
  • fast/dom/script-tests/boolean-attribute-reflection.js:

Re-added link.disabled as a reflected attribute.

17:16 Changeset [94368] by mitz@apple.com

Fix layout test regressions from r94352.

Reviewed by Anders Carlsson.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters): In the custom font case (that is, when there is
not base NSFont) always get and use the best variation.

17:11 Changeset [94367] by rniwa@webkit.org

Revert r94355 because it caused bunch of builds to break.

Source/WebCore:

  • page/DOMWindow.idl:

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
16:57 Changeset [94366] by jamesr@google.com

[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup.html

  • platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-linux/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/chromium-linux/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:53 Changeset [94365] by mrowe@apple.com

<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without a return type.

Rubber-stamped by Anders Carlsson.

  • bridge/objc/WebScriptObject.h:
16:49 Changeset [94364] by commit-queue@webkit.org

Unzip initialization lists and constructors in JSCell hierarchy (4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-01
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):

  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

  • API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):
(JSC::::finishCreation):

(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::create):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):

  • runtime/BooleanObject.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):

  • runtime/DateInstance.h:
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):

  • runtime/ErrorPrototype.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):

  • runtime/InternalFunction.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::create):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):

  • runtime/JSFunction.h:

(JSC::JSFunction::create):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):

  • runtime/JSONObject.h:
  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):

  • runtime/MathObject.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):

  • runtime/NumberObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):

  • runtime/RegExpMatchesArray.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):

  • runtime/RegExpObject.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

  • runtime/StringObject.cpp:

(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):

  • runtime/StringObject.h:

Source/JavaScriptGlue:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • UserObjectImp.cpp:

(UserObjectImp::UserObjectImp):

  • UserObjectImp.h:

(UserObjectImp::create):

Source/WebCore:

No new tests.

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::create):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObjPrototype::JSTestObjPrototype):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):

  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):

  • bridge/runtime_object.h:

Source/WebKit2:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
16:45 Changeset [94363] by enne@google.com

[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
https://bugs.webkit.org/show_bug.cgi?id=67003

Reviewed by James Robinson.

ProgramBinding now takes an explicit cleanup call to destroy its
resources. This will assert if it is not called and will leak no
longer potentially dereference a dead pointer.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/ProgramBinding.cpp:

(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):

  • platform/graphics/chromium/ProgramBinding.h:

(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):

16:41 Changeset [94362] by jamesr@google.com

fast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way too fragile
https://bugs.webkit.org/show_bug.cgi?id=67452

Reviewed by Darin Adler.

Modifies these tests to not print PASS lines for all of the expected successes, since that means they have to be
updated whenever the set of properties on the global object is changed. That is not the point of these tests
and it just causes excessive churn.

  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/resources/js-test-pre.js:

(description):
(descriptionQuiet):
(shouldBe):
(shouldBeTrueQuiet):

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/dom/global-constructors-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Removed.
16:32 Changeset [94361] by mitz@apple.com

Added Windows expected results to the test added in r94352.

  • platform/win/fast/text/fallback-traits-fixup-expected.txt: Added.
16:29 Changeset [94360] by paroga@webkit.org

Don't include unnecessary headers in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=67435

Reviewed by Darin Adler.

When an IDL attribue is Conditonal the corresponding headers
need to be surrounded with the correct #if ENABLE().

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
16:25 Changeset [94359] by commit-queue@webkit.org

[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by Kenneth Russell.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::grContext):

  • src/WebGraphicsContext3D.cpp: Added.

(WebKit::WebGraphicsContext3D::createGrGLInterface):

16:22 Changeset [94358] by psolanki@apple.com

Rename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
https://bugs.webkit.org/show_bug.cgi?id=67348

Reviewed by Alexey Proskuryakov.

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

  • platform/network/mac/ResourceHandleMac.mm:
16:06 Changeset [94357] by commit-queue@webkit.org

TypeError should be thrown when a constructor is called as a normal function.
https://bugs.webkit.org/show_bug.cgi?id=67381

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Darin Adler.

The spec is here: http://www.w3.org/TR/WebIDL/#es-interface-call
For example, "Image()" or "XMLHttpRequest()" should throw TypeError.

Source/WebCore:

Test: fast/dom/call-a-constructor-as-a-function.html

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback): Throws TypeError if args.IsConstructCall() is false.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray): Ditto.

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback): Ditto.

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback): Ditto.

  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:

(WebCore::v8HTMLAudioElementConstructorCallback): Ditto.

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Ditto.

  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:

(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback): Ditto.

  • bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::V8SharedWorker::constructorCallback): Ditto.

  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:

(WebCore::V8WebKitCSSMatrix::constructorCallback): Ditto.

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback): Ditto.

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): Ditto.

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::constructorCallback): Ditto.

LayoutTests:

  • fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for JSC.
  • fast/dom/call-a-constructor-as-a-function.html: Added. Checks if TypeError is thrown.
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for V8.
16:03 Changeset [94356] by enne@google.com

[chromium] TextureManager overestimates the size of non-RGBA texture formats
https://bugs.webkit.org/show_bug.cgi?id=66917

Reviewed by James Robinson.

Use GraphicsContext3D to determine the size of a given texture format.
Also, make TextureManager use more GraphicsContext3D types.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::memoryUseBytes):

  • platform/graphics/chromium/TextureManager.h:
15:48 Changeset [94355] by weinig@apple.com

Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

  • page/DOMWindow.idl:

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

15:42 Changeset [94354] by paroga@webkit.org

Consider Conditional attribute in CodeGenerator for methods
https://bugs.webkit.org/show_bug.cgi?id=67409

Reviewed by Darin Adler.

This change adds appropriate #if ENABLE() lines for the preprocessor around the
generated functions depending on the Conditional attribute in the IDL file.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
15:40 Changeset [94353] by nduca@chromium.org

[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=66807

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRendererRecursive):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::isContextLost):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::capabilities):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::contextSupportsMapSub):
(WebCore::LayerRendererChromium::viewportSize):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::reserveTextures):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::preCommit):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::createCompositorThread):
(WebCore::CCLayerTreeHost::createLayerTreeHostContext3D):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::layerRendererCapabilities):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::skiaContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::loseCompositorContext):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::layerRendererCapabilities):
(WebCore::CCLayerTreeHostImpl::present):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::updateLayers):
(WebCore::CCLayerTreeHostImpl::setViewport):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::layerRenderer):
(WebCore::CCLayerTreeHostImpl::rootLayer):
(WebCore::CCLayerTreeHostImpl::viewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h:

(WebCore::MainThreadTask4::create):
(WebCore::MainThreadTask4::MainThreadTask4):
(WebCore::MainThreadTask4::performTask):
(WebCore::MainThreadTask5::create):
(WebCore::MainThreadTask5::MainThreadTask5):
(WebCore::MainThreadTask5::performTask):
(WebCore::createMainThreadTask):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCProxy.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp.

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):

  • platform/graphics/chromium/cc/CCProxy.h: Added.

(WebCore::CCProxy::~CCProxy):
(WebCore::CCProxy::CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Added.

(WebCore::ScopedSetImplThread::ScopedSetImplThread):
(WebCore::ScopedSetImplThread::~ScopedSetImplThread):
(WebCore::CCSingleThreadProxy::create):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::isStarted):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
(WebCore::CCSingleThreadProxy::loseCompositorContext):
(WebCore::CCSingleThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::skiaContext):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::compositeIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
  • platform/graphics/chromium/cc/CCThreadProxy.cpp: Added.

(WebCore::CCThreadProxy::create):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::loseCompositorContext):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::skiaContext):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
  • platform/graphics/chromium/cc/CCThreadTask.h:

(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::CCThreadTask5::performTask):
(WebCore::createCCThreadTask):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):

  • tests/CCThreadTaskTest.cpp:

(WebCore::TEST):

15:32 Changeset [94352] by mitz@apple.com

<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
https://bugs.webkit.org/show_bug.cgi?id=67444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/fallback-traits-fixup.html

After obtaining STIX Regular as a fallback font for some characters, getFontDataForCharacters()
proceeded to ask for a font from the same family having the desired traits and weight (because
wkGetFontInLanguageForRange() does not preserve traits and weight). The returned font was different
and happened to not contain the desired character.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters): Only ask for a family member with the desired
traits and weight if the substitute font does not already have them, and only use the returned
member if it actually contains the desired character.

LayoutTests:

  • fast/text/fallback-traits-fixup.html: Added.
  • platform/mac/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/mac/fast/text/fallback-traits-fixup-expected.txt: Added.
15:27 Changeset [94351] by jamesr@google.com

[chromium] Update more SVG baselines

  • platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
  • platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Removed.
  • platform/qt/svg/custom/non-scaling-stroke-expected.txt: Removed.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Removed.
  • svg/custom/non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/non-scaling-stroke-expected.txt.
  • svg/custom/pattern-skew-transformed-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-skew-transformed-expected.txt.
15:16 Changeset [94350] by commit-queue@webkit.org

Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67414

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/dom/Window/custom-constructors.html

fast/xsl/default-html.html

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: Removed constructorCallback().
  • xml/XSLTProcessor.idl: Added the 'Constructor' extended attribute.
15:02 Changeset [94349] by jamesr@google.com

[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)

  • platform/chromium/test_expectations.txt:
14:52 BuildingQtOnLinux edited by benjamin@webkit.org
Remove the section about debugging from a Qt build. This is not supported … (diff)
14:40 Changeset [94348] by jamesr@google.com

[chromium] Update chromium baselines for 94338 for windows/mac

  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/chromium-cg-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium/test_expectations.txt:
14:30 Changeset [94347] by jonlee@apple.com

Adding control rendering at various sizes.

  • projects/forms/survey.html:
14:30 Changeset [94346] by jamesr@google.com

[chromium] Update chromium baselines for 94338

  • platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/qt/svg/custom/pattern-rotate-expected.txt: Removed.
  • svg/custom/pattern-rotate-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-rotate-expected.txt.
14:29 Changeset [94345] by eric@webkit.org

REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
https://bugs.webkit.org/show_bug.cgi?id=66228

Reviewed by Dirk Pranke.

ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
The LeaksViewer tool globs for all *-leaks.txt files.
This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.

In order to test this I had to fix a limitation in our MockFileSystem.glob
method. However, doing so uncovered a typo and bug in the integration tests.
I've disabled the offending integration tests.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
14:22 Changeset [94344] by eric.carlson@apple.com

HTMLMediaElement should use fastHasAttribute instead of hasAttribute
https://bugs.webkit.org/show_bug.cgi?id=67421

Reviewed by Simon Fraser.

Use fastHasAttribute instead of hasAttribute because it is faster, and HTMLMediaElement
doesn't ever need to check style or SVG animated attributes.

No new tests required, this is just an optimization.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource): hasAttribute -> fastHasAttribute.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::loop): Ditto.
(WebCore::HTMLMediaElement::controls): Ditto.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.

14:14 Changeset [94343] by commit-queue@webkit.org

Source/WebCore: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/speech/input-text-speechstart.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput):

  • html/shadow/TextControlInnerElements.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::speechButtonElement):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

  • public/WebInputElement.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebInputElement.cpp:

(WebKit::WebInputElement::isSpeechInputEnabled):
(WebKit::WebInputElement::getSpeechInputState):
(WebKit::WebInputElement::startSpeechInput):
(WebKit::WebInputElement::stopSpeechInput):

Tools: Adds a LayoutTestController method to make it possible to test
starting speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::startSpeechInput):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::startSpeechInput):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::startSpeechInput):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::startSpeechInput):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::startSpeechInput):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::startSpeechInput):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::startSpeechInput):

LayoutTests: Adds a new test that checks triggering speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

  • fast/speech/input-text-speechtrigger-expected.txt: Added.
  • fast/speech/input-text-speechtrigger.html: Added.
14:06 Changeset [94342] by dbates@webkit.org

QNX GCC distribution doesn't support vasprintf()
https://bugs.webkit.org/show_bug.cgi?id=67423

Reviewed by Antonio Gomes.

  • wtf/Platform.h: Don't enable HAVE_VASPRINTF when building with GCC on QNX.
13:46 Changeset [94341] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Some images incorrectly created with LCD text replaced with gray-scale.
Updated newer tests with reference images.
Deleted images with correct fallbacks.

  • platform/chromium-mac/http/tests/navigation/error404-basic-expected.png: Removed.

(remaining files omitted for brevity)

13:39 Changeset [94340] by adachan@apple.com

Gather memory cache statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode webCoreCacheStatistics data member in StatisticsData.

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):

  • Shared/StatisticsData.h:

Convert the cache statistics data into an ImmutableArray and return it in WebContext::didGetWebCoreStatistics().

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didGetWebCoreStatistics):

Store memory cache statistics into the StatisticsData object.

  • WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

13:38 Changeset [94339] by jamesr@google.com

[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode-vertical.html

  • platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/chromium-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
13:27 Changeset [94338] by timothy_horton@apple.com

REGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Make use of wkCGPatternCreateWithImageAndTransform
when tiling patterns in both directions. This helps to avoid
pixel-cracking along pattern tiling boundaries.

Ignore 2D rotation when computing the size of a pattern's tile image,
as it artificially inflates the size of the tile, which can cause
pixel-cracking.

Test: svg/custom/pattern-rotate-gaps.svg

  • platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern):

  • rendering/svg/RenderSVGResourcePattern.cpp:
  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::roundedImageBufferSize):

  • rendering/svg/SVGImageBufferTools.h:

Add a test that makes pixel cracking in transformed SVG patterns quite blatant,
and rebaseline some other tests affected by the change.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/mac/svg/custom/pattern-rotate-gaps-expected.txt: Added.
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • svg/custom/pattern-rotate-gaps.svg: Added.
13:09 Changeset [94337] by jamesr@google.com

[chromium] Update expectations and baselines

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
13:04 Changeset [94336] by msaboff@apple.com

Remove simple usage of UString::characters() from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=67340

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Most of the changes below
change s->characters()[0] to s[0].

Reviewed by Geoffrey Garen.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::jsToNumber):
(JSC::parseFloat):

  • runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

  • runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/RegExp.cpp:

(JSC::regExpFlags):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

12:56 Changeset [94335] by timothy_horton@apple.com

Fix TestWebKitAPI build on clang-2.0

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
12:51 Changeset [94334] by paroga@webkit.org

Unreviewed, rolling out r94284.
http://trac.webkit.org/changeset/94284
https://bugs.webkit.org/show_bug.cgi?id=65050

Broke building without SVG enabled on Chromium.

  • page/DOMWindow.idl:
12:50 Changeset [94333] by ap@apple.com

REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=67374

Reviewed by Simon Fraser.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader):
Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
repeat its value twice, this is not one of those headers that allow comma separated lists
of values.

12:40 Changeset [94332] by noel.gordon@gmail.com

[chromium] Move ImageBuffer::platformLayer()
https://bugs.webkit.org/show_bug.cgi?id=67372

Reviewed by Kenneth Russell.

No new tests: refactoring only, covered by existting tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::platformLayer): Move it away from the toDataURL code.

12:38 Changeset [94331] by commit-queue@webkit.org

Focus ring is rendered incorrectly for a block with -webkit-writing-mode
https://bugs.webkit.org/show_bug.cgi?id=62915

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-09-01
Reviewed by Simon Fraser.

Source/WebCore:

RenderBlock::addFocusRingRects() should consider physical box position and
dimension instead of logical values for focus ring rects calculation.

Test: fast/css/focus-ring-multiline-writingmode-vertical.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects):

LayoutTests:

  • fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
  • platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
12:33 Changeset [94330] by philn@webkit.org

Unreviewed, GTK build fix after r94299.

  • GNUmakefile.list.am:
12:28 Changeset [94329] by commit-queue@webkit.org

[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=67419

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by James Robinson.

Accelerated drawing is not enabled in layout tests. However, once it is this change will be tested by every test.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::contextSupportsAcceleratedPainting):
(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
12:27 Changeset [94328] by commit-queue@webkit.org

Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Build fix, completing rename for GTK file.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2011-09-01
Reviewed by Chris Marrin.

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp: Renamed from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp.

(sharedDisplay):
(WebCore::activeGraphicsContexts):
(WebCore::GraphicsContext3DPrivate::addActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::removeActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::cleanupActiveContextsAtExit):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createPbufferContext):
(WebCore::GraphicsContext3DPrivate::createPixmapContext):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

12:12 Changeset [94327] by simon.fraser@apple.com

r93794 results in ruby tests causing assertion failure in RenderBlock.cpp
https://bugs.webkit.org/show_bug.cgi?id=67007

Reviewed by Beth Dakin.

Disable these asserting ruby tests until the underlying issue can be fixed.

  • fast/ruby/after-block-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html.
  • fast/ruby/after-table-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html.
  • fast/ruby/generated-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html.
  • fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html.
12:01 Changeset [94326] by jamesr@google.com

[chromium] Update baselines for vertical-text-glyph-test.html

  • platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
11:57 Changeset [94325] by jamesr@google.com

Remove unused "extension" parameter from rebaseline gardeningserver handler
https://bugs.webkit.org/show_bug.cgi?id=67384

Patch by Adam Barth <abarth@webkit.org> on 2011-09-01
Reviewed by James Robinson.

This parameter hasn't done anything in a while.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
11:44 Changeset [94324] by simon.fraser@apple.com

REGRESSION (r94259): Two tests doing hit testing were broken by this change.
https://bugs.webkit.org/show_bug.cgi?id=67353

Reviewed by Chris Marrin.

Fix a regression from r94259; that change missed a fix in RenderView,
which affects coordinate transforms in position:fixed elements.

This fixes these tests:

fast/events/document-elementFromPoint.html
fast/events/offsetX-offsetY.html
plugins/mouse-events-fixedpos.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapAbsoluteToLocalPoint):

11:41 Changeset [94323] by tonyg@chromium.org

[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

11:39 Changeset [94322] by mnaganov@chromium.org

Web Inspector: [Chromium] Perform a more effective JS GC
https://bugs.webkit.org/show_bug.cgi?id=67304

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectGarbage):

11:39 Changeset [94321] by caio.oliveira@openbossa.org

[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
https://bugs.webkit.org/show_bug.cgi?id=67344

Reviewed by Andreas Kling.

Renamed QtFallbackWebPopup to QtWebComboBox and decoupled it from
QtFallbackWebPopup. The new class is a QComboBox with the features that
we need for QtWebKit: tracking when the popup is hidden (via the didHide()
signal) and a convenience method to show its popup in the cursor position.

An important change was made to the combobox: instead of hooking our actions in
showPopup() and hidePopup(), as well as watching for popup visibility events, we
now just watch for the visibility events. This allowed us to get rid of
m_popupVisible and tracking the Show event.

This commit also removed a workaround for input focus added in r40970 after
reviewers request. See bug report for details.

  • QtWebKit.pro:
  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::deleteComboBox):

  • WebCoreSupport/QtFallbackWebPopup.h:
  • WebCoreSupport/QtWebComboBox.cpp: Added.

(WebCore::QtWebComboBox::QtWebComboBox):
(WebCore::QtWebComboBox::showPopupAtCursorPosition):
(WebCore::QtWebComboBox::eventFilter):

  • WebCoreSupport/QtWebComboBox.h: Added.
  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::popupFocus):
Change the test to use QObject::findChild(). The old method couldn't find our
new class because we defined a new metaclass for it.

11:37 Changeset [94320] by japhet@chromium.org

http/tests/loading/empty-urls.html shouldn't
fail if the load event fires before we finish.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

  • http/tests/loading/empty-urls-expected.txt:
  • http/tests/loading/empty-urls.html:
11:20 Changeset [94319] by weinig@apple.com

WebGLContextEvent should have its own JS wrapper
https://bugs.webkit.org/show_bug.cgi?id=67352

Reviewed by Anders Carlsson.

Source/WebCore:

The WebGLContextEvent was missing a proper JS wrapper, and thus
anyone using one in an EventListener was actually just getting
a plain old Event. Rectify this by generating the wrapper and
wrapping it on creating.

Test: fast/canvas/webgl/WebGLContextEvent.html

  • CodeGenerators.pri:

Add WebGLContextEvent.idl

  • DerivedSources.make:

Add WebGLContextEvent and sort.

  • WebCore.xcodeproj/project.pbxproj:

Add generated JSWebGLContextEvent.h/cpp.

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):
Wrap WebGLContextEvents as JSWebGLContextEvents.

  • dom/Event.cpp:

(WebCore::Event::isWebGLContextEvent):

  • dom/Event.h:
  • html/canvas/WebGLContextEvent.cpp:

(WebCore::WebGLContextEvent::isWebGLContextEvent):

  • html/canvas/WebGLContextEvent.h:

Add predicate for WebGLContextEvent.

LayoutTests:

  • fast/canvas/webgl/WebGLContextEvent-expected.txt: Added.
  • fast/canvas/webgl/WebGLContextEvent.html: Added.

Add a test that shows that WebGLContextEvents are not just base Events.

11:10 Changeset [94318] by eric.carlson@apple.com

Add 'muted' content attribute to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=58369

Source/WebCore:

Reviewed by Darin Adler.

Test: media/video-defaultmuted.html

  • html/HTMLAttributeNames.in: Add muted.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Deal with the 'muted' attribute.

  • html/HTMLMediaElement.idl: Add defaultMuted.

LayoutTests:

Reviewed by Darin Adler.

  • media/video-defaultmuted-expected.txt: Added.
  • media/video-defaultmuted.html: Added.
11:03 Changeset [94317] by timothy_horton@apple.com

REGRESSION: Rendering artifacts on a rotated, pattern filled shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Introduce wkCGPatternCreateWithImageAndTransform.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:01 Changeset [94316] by eric@webkit.org

Unreviewed.

Fix a typo in unittests. Unfortunately fixing it
caused several assertions. Just disabling the test
instead, since it was providing no value before due to the typo.

  • Scripts/webkitpy/layout_tests/port/test.py:
10:58 Changeset [94315] by enne@google.com

[chromium] Fix scissor rects on clipped nested iframes
https://bugs.webkit.org/show_bug.cgi?id=67221

Reviewed by James Robinson.

Source/WebCore:

Layers that mask to bounds (like iframes) weren't being properly
clipped if their parent scissor rect was empty. This case happens
when a parent iframe is clipped. Fixed by propagating the empty
scissor rect to child layers rather than ignoring it.

Test: compositing/iframes/nested-composited-iframe.html

  • platform/graphics/chromium/LayerRendererChromium.cpp:

LayoutTests:

  • compositing/iframes/nested-composited-iframe-expected.png: Added.
  • compositing/iframes/nested-composited-iframe-expected.txt: Added.
  • compositing/iframes/nested-composited-iframe.html: Added.
  • compositing/iframes/resources/composited-red.html: Added.
  • compositing/iframes/resources/has-composited-iframe-child.html: Added.
10:57 Changeset [94314] by abarth@webkit.org

Add a "rebaseline" button to the garden-o-matic summary page
https://bugs.webkit.org/show_bug.cgi?id=67382

Reviewed by Dimitri Glazkov.

As much as we might wish folks to not rebaseline entire test groups at
once, the truth is that doing so is a common operation. Adding a
button for this operation is likely to make folks happy.

This patch also cleans up a bunch of plumbing surrounding failureInfo
objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
10:56 Changeset [94313] by commit-queue@webkit.org

[Qt] TouchWebView crashes with segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=67308

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-01
Reviewed by Benjamin Poulain.

If you instantiate TouchWebView element with height and width in a qml file and
load a url it crashes.
The functions setWidth() and setHeight() are called sequentially therefore it can happen
that computeViewportAttributes was called with a size like (width, 0) breaking the
assumption of the function that the size is valid. The patch makes sure we compute the
viewport when both height and width are valid.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
10:54 Changeset [94312] by abarth@webkit.org

garden-o-matic should let the gardener assign blame for a group of test failures
https://bugs.webkit.org/show_bug.cgi?id=67379

Reviewed by Dimitri Glazkov.

If a group of test failures has a large revision range, the gardener
might wish to blame a specific revision for the failure. Currently,
this only effect of assigning blame in this way is to hide the other
suspect commits.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
10:53 Changeset [94311] by abarth@webkit.org

Hide garden-o-matic failure table until hover
https://bugs.webkit.org/show_bug.cgi?id=67376

Reviewed by Dimitri Glazkov.

This patch removes the failure table for build failures (because it
does not make sense) and hides the failure table for test groups until
the user hovers over the test failure block, reducing visual noise.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
10:51 Changeset [94310] by abarth@webkit.org

Switch garden-o-matic from commitData.title to commitData.summary
https://bugs.webkit.org/show_bug.cgi?id=67375

Reviewed by Dimitri Glazkov.

commitData.title is a string provided by Trac, which isn't great in all
cases. commitData.summary is my attempt to find the most important
one-line summary of the commit. This patch switches garden-o-matic
over to summary.

Also, this patch tweaks a bunch of CSS to tighten up the summary page
and reduce visual noise.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
10:48 Changeset [94309] by abarth@webkit.org

Group failing tests in garden-o-matic if there are more than three in a folder
https://bugs.webkit.org/show_bug.cgi?id=67373

Reviewed by Dimitri Glazkov.

Sometimes a failure will cause many tests in a given directory to fail.
When that happens, it's better to list the directory as a single item
(with a count) rather than spamming all the test names.

(This patch also updates a bunch of unit test expected results after my last commit.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
10:47 Changeset [94308] by abarth@webkit.org

Lower the visual noise from the failing builders display
https://bugs.webkit.org/show_bug.cgi?id=67369

Reviewed by Dimitri Glazkov.

This patch ensures that the "Building" row in the failing builders
display is always last and dims it by 50% to reduce visual noise. This
lets the gardener focus on the actual failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
10:39 Changeset [94307] by yurys@chromium.org

Web Inspector: close dedicated worker inspectors when page inspector is closing
https://bugs.webkit.org/show_bug.cgi?id=67366

Close all dedicated worker inspector windows when page inspector is closing.

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):

  • inspector/front-end/inspector.js:

(WebInspector.close):

10:36 Changeset [94306] by yurys@chromium.org

[Chromium] Web Inspector: dedicated worker inspection is broken
https://bugs.webkit.org/show_bug.cgi?id=67279

Provide transport for inspector messages between Page and DedicatedWorker inspectors
in case of in-process workers.

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm: sendMessageObjectToBackend should accept message

object which is ready for sending to backend. This method is overriden in WorkerManager
for dedicated workers and we don't want to replicate request id assignment there.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):

  • workers/WorkerMessagingProxy.h:
10:25 Changeset [94305] by apavlov@chromium.org

[Chromium] Unreviewed, rebaseline tests after r94299.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win/fast/borders/border-image-slices-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-slices-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
10:22 Changeset [94304] by ossy@webkit.org

[CSS3 Backgrounds and Borders] Implement border-image-slice
https://bugs.webkit.org/show_bug.cgi?id=67321

  • WebCore.pro: Unreviewed buildfix after Dave "scattered" Hyatt (r94299).
10:20 Changeset [94303] by commit-queue@webkit.org

Typesetting features need not force complex for single-character runs
https://bugs.webkit.org/show_bug.cgi?id=66498

Typesetting features have no effect on a solitary character, so they shouldn't enable complex layout
unless multiple characters are present.

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-01
Reviewed by Dan Bernstein.

No new tests, this is merely a performance optimization.

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): typesettingFeatures() only forces Complex for multiple-character runs.

10:15 Changeset [94302] by jeffm@apple.com

Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
https://bugs.webkit.org/show_bug.cgi?id=66253

Reviewed by Jon Honeycutt.

No new tests, should be covered by existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Use the same code on Mac and Windows to only create the AVPlayer and AVPlayerItem when needed.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Assign any existing AVPlayerItem to the new AVPlayer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Allow creation of the AVPlayerItem before the AVPlayer.

09:15 WebKitGtkLayoutTests edited by philn@webkit.org
(diff)
09:10 Changeset [94301] by commit-queue@webkit.org

New baselines needed after changes in r94185
https://bugs.webkit.org/show_bug.cgi?id=67350

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-01
Reviewed by Eric Carlson.

  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/test_expectations.txt:
09:03 Changeset [94300] by commit-queue@webkit.org

Unreviewed, rolling out r94194.
http://trac.webkit.org/changeset/94194
https://bugs.webkit.org/show_bug.cgi?id=67410

Broke a test on the GTK+ bots. (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-01

  • platform/gtk/Skipped:
09:01 Changeset [94299] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=67321

Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSBorderImageSliceValue.cpp: Added.

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::cssText):

  • css/CSSBorderImageSliceValue.h: Added.

(WebCore::CSSBorderImageSliceValue::create):
(WebCore::CSSBorderImageSliceValue::isBorderImageSliceValue):
Add a new CSSBorderImageSliceValue that holds both the four slices (as a CSS rect) and the
fill keyword (as a boolean). Note that the cssText() dumping of the slices has been refined
to be smarter, and it will no longer dump repeating values.

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
CSSBorderImageValue now owns a CSSBorderImageSliceValue instead of just a CSS rect.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImage):
Add a new method, valueForNinePieceImageSlice, for getting the slices plus the fill value
from the NinePieceImage and putting it into a CSSBorderImageSliceValue. This method is now used by
valueForNinePieceImage to get the CSSBorderImageSliceValue that is part of the overall
CSSBorderImageValue.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Adding support for the new properties: border-image-slice and -webkit-mask-box-image-slice.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modify parseBorderImage to no longer parse the slices itself. Instead it farms out the parsing
to parseBorderImageSlice.

(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::allowNumber):
(WebCore::BorderImageSliceParseContext::allowFill):
(WebCore::BorderImageSliceParseContext::allowFinalCommit):
(WebCore::BorderImageSliceParseContext::top):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitFill):
(WebCore::BorderImageSliceParseContext::setAllowFinalCommit):
(WebCore::BorderImageSliceParseContext::setTop):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
Slice parsing has now been broken out so that it can be parsed as a single property. In addition
support for the "fill" keyword has been added to control image filling.

  • css/CSSParser.h:

Modified to add the new parseBorderImageSlice method.

  • css/CSSPropertyNames.in:

Add the new properties: border-image-slice and -webkit-mask-box-image-slice.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
Rework mapNinePieceImage to call mapNinePieceImageSlice so that the mapping can be done just for
the slices.

(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
A new method that handles mapping just the slices into the front-end NinePieceImage.

(WebCore::CSSStyleSelector::loadPendingImages):
Modified to ensure the fill value is preserved when box-reflect makes a new NinePieceImage.

  • css/CSSStyleSelector.h:

Added the new mapNinePieceImageSlice method.

  • css/CSSValue.h:

(WebCore::CSSValue::isBorderImageSliceValue):
Virtual function for identifying border image slice values.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):
The painting of the nine piece image has been modified to match the specification. The "fill"
keyword controls whether or not the middle is painted.

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::operator==):
The fill keyword has to be checked now for equality.

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
Added the fill keyword to the front end NinePieceImage.

(WebCore::NinePieceImage::copySlicesFrom):
Added a helper to copy only the slices over from another NinePieceImage. Used when inheriting
the border-image-slice property from a parent style.

LayoutTests: Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

  • fast/borders/border-image-slices.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
  • fast/css/uri-token-parsing-expected.txt:
  • fast/css/uri-token-parsing.html:
  • platform/mac/fast/borders/border-image-slices-expected.png: Added.
  • platform/mac/fast/borders/border-image-slices-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
08:09 Changeset [94298] by adachan@apple.com

Source/JavaScriptCore: Export fastMallocStatistics and Heap::objectTypeCounts for https://bugs.webkit.org/show_bug.cgi?id=67160.

Reviewed by Darin Adler.

Source/WebKit2: Gather JavaScript, FastMalloc, icon, font, and glyph page statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode the data members in StatisticsData.

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
(WebKit::StatisticsData::StatisticsData):

Add three data members to StatisticsData:

  • statisticsNumbers: Map containing statistics values that are numbers, mapped by their names, such as

JavaScriptObjectsCount, CachedFontDataCount, etc.

  • javaScriptProtectedObjectTypeCounts
  • javaScriptObjectTypeCounts
  • Shared/StatisticsData.h:

Create a WK::Dictionary containing statistics values mapped by their names and return that dictionary
in WebContext::didGetWebCoreStatistics().

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):
(WebKit::WebContext::didGetWebCoreStatistics):

Package JavaScript, FastMalloc, icon, font, and glyph page statistics into a StatisticsData object
and send it to the UIProcess.

  • WebProcess/WebProcess.cpp:

(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::getWebCoreStatistics):

07:41 Changeset [94297] by loki@webkit.org

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=67392

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

  • platform/qt-wk2/Skipped:
07:22 Changeset [94296] by vsevik@chromium.org

Web Inspector: Decode query/form parameters names as well as values.
https://bugs.webkit.org/show_bug.cgi?id=67393

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._decodeURIComponent):
(WebInspector.ResourceHeadersView.prototype._refreshParms):

07:22 Changeset [94295] by philn@webkit.org

Unreviewed, skip 2 GTK a11y failing tests.

  • platform/gtk/Skipped:
07:20 Changeset [94294] by podivilov@chromium.org

Web Inspector: remove PresentationBreakpoint class.
https://bugs.webkit.org/show_bug.cgi?id=67275

Reviewed by Yury Semikhatsky.

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):

07:09 Changeset [94293] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/borders/border-fit-2-expected.png: Added.
  • platform/gtk/fast/borders/border-fit-2-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-source-expected.png: Added.
  • platform/gtk/fast/borders/border-image-source-expected.txt: Added.
  • platform/gtk/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/gtk/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
  • platform/gtk/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/gtk/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/gtk/fast/multicol/positive-leading-expected.png: Added.
  • platform/gtk/fast/multicol/positive-leading-expected.txt: Added.
  • platform/gtk/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/gtk/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/gtk/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
06:06 Changeset [94292] by loki@webkit.org

Unreviewed, rebaseline Qt-specific tests.

  • platform/qt/fast/borders/border-image-source-expected.png: Added.
  • platform/qt/fast/borders/border-image-source-expected.txt: Added.
  • platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
05:46 Changeset [94291] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
tables/mozilla/bugs/bug8361 through transitions/svg-text-shadow-transition

  • platform/chromium-mac/transforms: Added.

(remaining files omitted for brevity)

05:37 Changeset [94290] by steveblock@google.com

Clean up all mentions of Android in comments
https://bugs.webkit.org/show_bug.cgi?id=67303

Also removes some superfluous guards and methods added for Android.

Reviewed by Darin Adler.

No new tests, removing dead code only.

(WebCore::Document::Document):
(WebCore::Document::isLayoutTimerActive):
(WebCore::Document::minimumLayoutDelay):

05:36 Changeset [94289] by loki@webkit.org

Unreviewed Qt gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

  • platform/qt-wk2/Skipped:
05:24 Changeset [94288] by ossy@webkit.org

[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Make clean build after the defines are changed.

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-01
Reviewed by Csaba Osztrogonác.

Source/WebCore:

  • features.pri:

Tools:

  • Scripts/webkitdirs.pm:

(buildQMakeProject):

05:16 Changeset [94287] by vsevik@chromium.org

Web Inspector: Network error messages in console should link to the respective request in network panel if there is one.
https://bugs.webkit.org/show_bug.cgi?id=65550

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype.searchCanceled):
(WebInspector.NetworkLogView.prototype.revealAndHighlightResource):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkLogView.prototype._highlightNode):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):

  • inspector/front-end/networkLogView.css:

(.network-log-grid tr.highlighted-row):
(from):
(to):

LayoutTests:

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
05:06 Changeset [94286] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
svg/svg/text/scaled-font through tables/mozilla/bugs/bug82946-1

  • platform/chromium-mac/svg/zoom: Added.

(remaining files omitted for brevity)

04:18 Changeset [94285] by xan@webkit.org

2011-09-01 Xan Lopez <xlopez@igalia.com>

[GTK] Add XRender lib dependencies explicitly

Reviewed by Philippe Normand.

This is needed when using the GNU/Gold linker, since we use
XRender directly.

  • GNUmakefile.am:
03:24 Changeset [94284] by paroga@webkit.org

Replace preprocessor statements in DOMWindow.idl with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=65050

Reviewed by Brent Fulgham.

Many attributes use the [Conditional=XXX] syntax already.
Unify the declaration of conditional attributes of DOMWindow
with the corresponding Conditional attribute.
This reduces the need of the preprocessor which is the
the source of much pain on native windows.

  • page/DOMWindow.idl:
03:22 Changeset [94283] by zherczeg@webkit.org

Unreviewed, skipping failing tests after r94259.

r94259 fails on Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=67383

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
02:58 Changeset [94282] by yutak@chromium.org

WebSocket: Fix bufferedAmount after WebSocket is closed
https://bugs.webkit.org/show_bug.cgi?id=67363

Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
(WebCore::WebSocket::getFramingOverhead):

  • websockets/WebSocket.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Try to send messages having various lengths to make sure we correctly calculate
the framing overhead.

02:40 Changeset [94281] by commit-queue@webkit.org

Define PTHREAD_KEYS_MAX to fix Android port build.
https://bugs.webkit.org/show_bug.cgi?id=67362

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it.

  • wtf/ThreadIdentifierDataPthreads.cpp:
01:44 Changeset [94280] by rniwa@webkit.org

Temporarily skip a test that started failing after r94274.
The failure is tracked by the bug 67377.

  • platform/mac/Skipped:
00:40 Changeset [94279] by keishi@webkit.org

Rename colorSelected to didChooseColor
https://bugs.webkit.org/show_bug.cgi?id=67271

Reviewed by Kent Tamura.

  • WebCore.exp.in:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::didChooseColor): Renamed colorSelected to didChooseColor so it follows common naming practice.

  • html/ColorInputType.h:
  • platform/ColorChooser.cpp:

(WebCore::ColorChooser::didChooseColor): Renamed.

  • platform/ColorChooser.h:
00:27 Changeset [94278] by abarth@webkit.org

Attempt to fix Windows build.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
00:00 Changeset [94277] by commit-queue@webkit.org

Add pass-throughs for NPObject/v8::Value marshalling to WebBindings
https://bugs.webkit.org/show_bug.cgi?id=67302

Patch by Greg Billock <gbillock@google.com> on 2011-08-31
Reviewed by Darin Fisher.

  • public/WebBindings.h:
  • src/WebBindings.cpp:

(WebKit::WebBindings::toNPVariant):
(WebKit::WebBindings::toV8Value):

  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

Note: See TracTimeline for information about the timeline view.