Timeline


and

09/06/11:

23:53 Changeset [94643] by yurys@chromium.org

fast/workers/worker-script-error.html fails on Chromium after r94061
https://bugs.webkit.org/show_bug.cgi?id=67206

Source/WebCore:

Default action should be prevented if window.onerror returned true and stay
not prevented otherwise.

Reviewed by Dmitry Titov.

Tests: fast/events/window-onerror14.html

fast/events/window-onerror15.html
fast/events/window-onerror16.html

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):
(WebCore::V8AbstractEventListener::shouldPreventDefault): allow specific
event listeners to decide when to prevent default action based on the handler
return value.

  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):
(WebCore::V8WindowErrorHandler::shouldPreventDefault):

  • bindings/v8/V8WindowErrorHandler.h:
  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
(WebCore::V8WorkerContextErrorHandler::shouldPreventDefault):

  • bindings/v8/V8WorkerContextErrorHandler.h:

LayoutTests:

Add a couple more tests for window.onerror handler that check whether
error message is printed to the console pending on the handler return
value.

Reviewed by Dmitry Titov.

  • fast/events/window-onerror14-expected.txt: Added.
  • fast/events/window-onerror14.html: Added.
  • fast/events/window-onerror15-expected.txt: Added.
  • fast/events/window-onerror15.html: Added.
  • fast/events/window-onerror16-expected.txt: Added.
  • fast/events/window-onerror16.html: Added.
  • platform/chromium/fast/events/window-onerror16-expected.txt: Added.
23:49 Changeset [94642] by yurys@chromium.org

[Chromium] Web Inspector: repair console sniffing for interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=67608

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.evaluateInConsole_):

23:41 Changeset [94641] by ossy@webkit.org

Unreviewed buildfix after r94620.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createFrame):

22:43 Changeset [94640] by commit-queue@webkit.org

Replace usages of Vector<UChar> with existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67079

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-06
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

This is part of work to support 8-bit string buffers.
Adds StringBuilder::characters() because the original Vector<UChar>::data()
is widely used.
Sets the minimum size of buffer to 16 to prevent possible performance
regression. Further performance investigation should be done in
https://bugs.webkit.org/show_bug.cgi?id=67084.

  • wtf/Forward.h:
  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendUninitialized): Sets minimum buffer size to 16 bytes.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters): Added.

Source/WebCore:

No new tests. All existing unit tests and layout tests should run
as before.

  • css/CSSOMUtils.cpp:

(WebCore::appendCharacter):
(WebCore::serializeCharacter):
(WebCore::serializeCharacterAsCodePoint):
(WebCore::serializeIdentifier):
(WebCore::serializeString):

  • css/CSSOMUtils.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase):

  • css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapeRect::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
(WebCore::CSSWrapShapePolygon::cssText):

  • editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat):

  • editing/MarkupAccumulator.cpp:

(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendAttributeValue):
(WebCore::MarkupAccumulator::appendCustomAttributes):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::MarkupAccumulator::appendEndMarkup):

  • editing/MarkupAccumulator.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::takeResults):
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::urlToMarkup):

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::removeToken):

  • html/HTMLFontElement.cpp:

(WebCore::parseFontSize):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/CSSPreloadScanner.h:
  • html/parser/HTMLEntityParser.cpp:

(WebCore::consumeHTMLEntity):

  • html/parser/HTMLEntityParser.h:
  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):
(WebCore::parseHTMLNonNegativeInteger):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processEntity):
(WebCore::HTMLTokenizer::nextToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo):
(WebCore::HTMLTreeBuilder::defaultForInTableText):

  • html/parser/HTMLTreeBuilder.h:
  • inspector/InspectorValues.cpp:

(WebCore::InspectorValue::toJSONString):
(WebCore::InspectorValue::writeJSON):
(WebCore::InspectorBasicValue::writeJSON):
(WebCore::InspectorString::writeJSON):
(WebCore::InspectorObject::writeJSON):
(WebCore::InspectorArray::writeJSON):

  • inspector/InspectorValues.h:
  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendText):
(WebCore::SerializerMarkupAccumulator::appendElement):
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString):

  • platform/KURL.cpp:

(WebCore::KURL::deprecatedString):
(WebCore::decodeURLEscapeSequences):

  • platform/LinkHash.cpp:

(WebCore::squeezeOutNullCharacters):
(WebCore::cleanSlashDotDotSlashes):
(WebCore::mergeDoubleSlashes):
(WebCore::cleanSlashDotSlashes):
(WebCore::cleanPath):
(WebCore::visitedURLInline):
(WebCore::visitedURL):
(WebCore::visitedLinkHash):

  • platform/LinkHash.h:
  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURL):

  • platform/network/HTTPParsers.cpp:

(WebCore::extractMIMETypeFromMediaType):

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode):

  • platform/text/TextStream.cpp:

(WebCore::TextStream::operator<<):
(WebCore::TextStream::release):

  • platform/text/TextStream.h:
  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen):

  • rendering/InlineTextBox.h:

(WebCore::BufferForAppendingHyphen::BufferForAppendingHyphen):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::markerTextWithSuffix):

  • rendering/RenderListMarker.cpp:

(WebCore::toSymbolic):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::suffix):

  • rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::decodeString):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):
(WebCore::XPath::FunConcat::evaluate):

  • xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):
(WebCore::saveResultToString):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::unconsumeCharacters):
(WebCore::consumeCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.cpp:

(WebCore::consumeXMLCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.h:
  • xml/parser/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::nextToken):

22:33 Changeset [94639] by tkent@chromium.org

REGRESSION (Safari 5.1 - ToT): File input retains its file icon when the value is reset
https://bugs.webkit.org/show_bug.cgi?id=67567

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • Introduce InputType::setValue(), which is called by HTMLInputElement::setValue().
  • Clear m_icon in FileInputType::setValue().

Tests: fast/forms/file/file-reset-in-change-expected.html

fast/forms/file/file-reset-in-change.html

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):
Implemenation for the "default" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default

  • html/BaseButtonInputType.h:
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):
Implemenation for the "default/on" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default-on

  • html/BaseCheckableInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::setValue):
Implemenation for the "filename" mode, and clearing m_icon.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-filename

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Move some code to InputType::setValue().
(WebCore::HTMLInputElement::setValueInternal): A helper for InputType::setValue().

  • html/HTMLInputElement.h:
  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):
Implementation for the "default" mode.

  • html/HiddenInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::setValue):
Implementation for the "value" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-value

  • html/InputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):
In addition to the "value" mode processing, updates placeholder visibililty.

  • html/TextFieldInputType.h:

LayoutTests:

  • fast/forms/file/file-reset-in-change-expected.html: Added.
  • fast/forms/file/file-reset-in-change.html: Added.
22:06 Changeset [94638] by rniwa@webkit.org

Qt rebaseline after r94614.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:43 Changeset [94637] by rniwa@webkit.org

REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
https://bugs.webkit.org/show_bug.cgi?id=67681

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.

Test: fast/forms/suggested-value-after-setvalue.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

LayoutTests:

Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.

  • fast/forms/suggested-value-after-setvalue-expected.txt: Added.
  • fast/forms/suggested-value-after-setvalue.html: Added.
21:35 Changeset [94636] by abarth@webkit.org

Attempt to fix GTK build.

  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

21:35 Changeset [94635] by commit-queue@webkit.org

[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-06
Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

  • public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):

  • src/WebInputEventConversion.h:

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

21:34 Changeset [94634] by ap@apple.com

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67653

Reviewed by James Robinson.

  • fast/dom/HTMLMeterElement/meter-element-crash.html: Added waitUntilDone/notifyDone,

and changed "1" that's displayed after testing to "PASS".

21:25 Changeset [94633] by rniwa@webkit.org

fast/forms/suggested-value-crash.html crashes on Windows
https://bugs.webkit.org/show_bug.cgi?id=67688

Reviewed by Adam Barth.

Source/WebCore:

The crash was caused because functions in internals were accessing uninitialized QualifiedNames.
Fixed the bug by avoiding to link to inputTag and textareaTag. Instead, we resort to toInputElement
and string comparison.

  • testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):

Source/WebKit2:

Removed sybmols for inputTag and textareaTag. Added the symbol for StringImpl::equal.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
21:22 Changeset [94632] by commit-queue@webkit.org

Fix broken snow leopard build
https://bugs.webkit.org/show_bug.cgi?id=67693

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Daniel Bates.

Removed unnecessary symbol export.

20:41 Changeset [94631] by abarth@webkit.org

garden-o-matic details view should having working rebaseline and next/previous buttons
https://bugs.webkit.org/show_bug.cgi?id=67659

Reviewed by Dimitri Glazkov.

This patch wires up basic back/forward buttons that let you traverse
through the results we're examining in the details view. This ended up
being more code than I expected, but I wanted to keep all the state
information in the DOM itself.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
20:00 Changeset [94630] by commit-queue@webkit.org

[chromium] Fix WebFrameClient receiving isRedirect when reloading
https://bugs.webkit.org/show_bug.cgi?id=63591

Patch by Ben Smith <binji@chromium.org> on 2011-09-06
Reviewed by Adam Barth.

Fix bug when quickly reloading a WebFrame where the
WebFrameClient would get called with decidePolicyForNavigation
isRedirect=true.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

  • src/WebDataSourceImpl.h:

(WebKit::WebDataSourceImpl::isRedirect):

  • tests/WebFrameTest.cpp:

(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):
(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
(WebKit::TEST_F):

19:47 Changeset [94629] by fpizlo@apple.com

DFG JIT does not optimize booleans
https://bugs.webkit.org/show_bug.cgi?id=67670

Reviewed by Gavin Barraclough.

This adds boolean value profiling, boolean prediction in the DFG,
boolean forward flow propagation in the DFGPropagator, boolean
data format in DFG generation info, and comprehensive optimizations
based on both boolean prediction and boolean generation info.
This is brings the speed-up on v8-richards to 12%, and gives slight
speed-ups elsewhere as well.

Making this work right required navigating some subtleties in
value profiling. Some functions get compiled with insufficient
information because some important path of the function never
executed. In these cases, we wish to fall back on static
speculation. But to do so, we need to ensure that predictions that
are inherent in the code (like that GetById almost certainly takes
a cell operand) are reflected in predictions that we make in
DFGPropagator. Thus, DFGPropagator now does both backward and
forward flow, using a both forward and backward fixpoint.

The backward flow in DFGPropagator is a separate static analysis,
and needs to keep a set of backward flow abstract values for
variables, arguments, and globals. To make this easy, this patch
factors out DFGGraph's prediction tracking capability into
DFGPredictionTracker, which now gets used by both DFGGraph (for
forward flow predictions) and DFGPropagator (for backward flow
predictions). Backward flow predictions eventually get merged
into forward flow ones, but the two are not equivalent: a forward
flow prediction is a superset of the backward flow prediction.

Debugging these prediction issues required a better understanding
of where we fail speculation, and what our value predictions look
like. This patch also adds optional verbose speculation failure
(so an informative printf fires whenever speculation failure occurs)
and slight improvements to the verbosity in other places.

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::probabilityOfBoolean):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predictions):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isBooleanConstant):
(JSC::DFG::JITCodeGenerator::valueOfBooleanConstant):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::isBooleanConstant):
(JSC::DFG::JITCompiler::valueOfBooleanConstant):

  • dfg/DFGNode.h:

(JSC::DFG::isBooleanPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePredictions):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::valueOfBooleanConstant):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::hasNumericResult):
(JSC::DFG::Node::predict):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionTracker.h: Added.

(JSC::DFG::operandIsArgument):
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::PredictionTracker::PredictionTracker):
(JSC::DFG::PredictionTracker::initializeSimilarTo):
(JSC::DFG::PredictionTracker::numberOfArguments):
(JSC::DFG::PredictionTracker::numberOfVariables):
(JSC::DFG::PredictionTracker::argumentIndexForOperand):
(JSC::DFG::PredictionTracker::predictArgument):
(JSC::DFG::PredictionTracker::predict):
(JSC::DFG::PredictionTracker::predictGlobalVar):
(JSC::DFG::PredictionTracker::getArgumentPrediction):
(JSC::DFG::PredictionTracker::getPrediction):
(JSC::DFG::PredictionTracker::getGlobalVarPrediction):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::~SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::index):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):

  • runtime/JSGlobalData.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::description):

19:35 Changeset [94628] by commit-queue@webkit.org

Rebaseline for bug 65583 (path based border radius drawing on skia)
https://bugs.webkit.org/show_bug.cgi?id=67596

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Kenneth Russell.

  • fast/backgrounds/gradient-background-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt.
  • fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt.
  • fast/box-shadow/spread-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/spread-expected.txt.
  • fast/css/box-shadow-and-border-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt.
  • fast/css/color-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/color-leakage-expected.txt.
  • fast/css/nested-rounded-corners-expected.txt:
  • platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/fast/: 17 changes
  • platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/fast/: 19 changes
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Renamed from LayoutTests/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png.
  • platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
  • platform/mac/fast/: 5 files removed
  • platform/mac/fast/css/nested-rounded-corners-expected.txt: Copied from LayoutTests/fast/css/nested-rounded-corners-expected.txt.
  • platform/qt/: 6 files removed
19:13 Changeset [94627] by commit-queue@webkit.org

Unzip initialization lists and constructors in JSCell hierarchy (5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

  • API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::finishCreation):

  • API/JSCallbackFunction.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

  • jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::finishCreation):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

  • runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):
(JSC::BooleanConstructor::finishCreation):

  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

  • runtime/BooleanObject.h:

(JSC::BooleanObject::create):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::finishCreation):

  • runtime/DateConstructor.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

  • runtime/DateInstance.h:

(JSC::DateInstance::create):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):
(JSC::DatePrototype::finishCreation):

  • runtime/DatePrototype.h:
  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):
(JSC::ErrorConstructor::finishCreation):

  • runtime/ErrorConstructor.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):
(JSC::FunctionConstructor::finishCreation):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::finishCreation):

  • runtime/FunctionPrototype.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

  • runtime/InternalFunction.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):

  • runtime/JSONObject.h:

(JSC::JSONObject::create):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

  • runtime/JSString.cpp:

(JSC::StringObject::create):

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

  • runtime/MathObject.h:

(JSC::MathObject::create):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):
(JSC::NumberConstructor::finishCreation):

  • runtime/NumberConstructor.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

  • runtime/NumberObject.h:

(JSC::NumberObject::create):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::finishCreation):

  • runtime/ObjectConstructor.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpMatchesArray::RegExpMatchesArray):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::create):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::finishCreation):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

  • runtime/StringObject.h:

(JSC::StringObject::create):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):

  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

No new tests.

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • WebCore.exp.in:
  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::create):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

  • bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):

  • bridge/c/CRuntimeObject.h:
  • bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
(JSC::Bindings::JavaRuntimeObject::finishCreation):

  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):
(JSC::RuntimeMethod::finishCreation):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • Plugins/Hosted/ProxyRuntimeObject.h:
  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):

Source/WebKit2:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::finishCreation):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

19:09 Changeset [94626] by jamesr@google.com

[chromium] Update chromium gpu baseline due to skia roll

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
19:07 Changeset [94625] by macpherson@chromium.org

Implement list style properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67103

Reviewed by Eric Seidel.

No new tests / no behavioral changes.

  • css/CSSStyleApplyProperty.cpp:

Add class to wrap call to CSSStyleSelector::styleImage().
(WebCore::ApplyPropertyStyleImage::ApplyPropertyStyleImage):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handlers for list style properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing property implementations.

19:05 Changeset [94624] by jamesr@google.com

[chromium] Update various chromium baselines.

  • platform/chromium-cg-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-cg-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt.
  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/wrapper-classes-expected.txt.
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium/fast/dom/wrapper-classes-expected.txt:
19:05 Changeset [94623] by fpizlo@apple.com

Accessibility tests crashing in BasicRawSentinelNode code
https://bugs.webkit.org/show_bug.cgi?id=67682

Reviewed by Geoffrey Garen.

A CodeBlock should ensure that no other CodeBlocks have references to it after
it is destroyed.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

19:00 Changeset [94622] by commit-queue@webkit.org

Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=67486
This reverts r65993 which gives wrong results for rshift
in some corner cases (see the test).

Patch by Yong Li <yoli@rim.com> on 2011-09-06
Reviewed by Gavin Barraclough.

New test: fast/js/floating-point-truncate-rshift.html

  • assembler/ARMAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=67486
Add a test case for branchTruncateDoubleToInt32() which is
used in right shift optimization when the assembler
"supportsFloatingPointTruncate".

Patch by Yong Li <yoli@rim.com> on 2011-09-06
Reviewed by Gavin Barraclough.

  • fast/js/floating-point-truncate-rshift-expected.txt: Added.
  • fast/js/floating-point-truncate-rshift.html: Added.
18:58 Changeset [94621] by mrowe@apple.com

Versioning.

18:55 Changeset [94620] by alexis.menard@openbossa.org

[Qt] Move away from QPointer as it is slow and it has a replacement QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=67673

Reviewed by Ariya Hidayat.

Source/WebCore:

Move away from QPointer to QWeakPointer, it is faster.

No new tests, the existing ones should cover.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::getClass):
(JSC::Bindings::QtField::name):
(JSC::Bindings::QtField::valueFromInstance):

  • bridge/qt/qt_instance.h:

(JSC::Bindings::QtInstance::getObject):

  • bridge/qt/qt_runtime.h:
  • platform/qt/SharedTimerQt.cpp:

(WebCore::SharedTimerQt::inst):

Source/WebKit/qt:

Move away from QPointer as Qt provides a better and faster solution : QWeakPointer.

  • Api/qwebframe.cpp:

(QWebHitTestResult::linkTargetFrame):
(QWebHitTestResult::frame):

  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::acceptNavigationRequest):
(QWebPagePrivate::createMainFrame):
(QWebPagePrivate::updateAction):
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPage::createStandardContextMenu):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::focusInEvent):
(QWebPage::setPalette):
(QWebPagePrivate::touchEvent):
(QWebPage::~QWebPage):
(QWebPage::mainFrame):
(QWebPage::viewportSize):
(QWebPage::preferredContentsSize):
(QWebPage::setContentEditable):
(QWebPage::updatePositionDependentActions):

  • Api/qwebpage_p.h:
  • Api/qwebview.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::contextMenu):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createFrame):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::ownership):

  • tests/qwebpage/tst_qwebpage.cpp:

(PluginCounterPage::PluginCounterPage):
(PluginTracerPage::createPlugin):
(tst_QWebPage::createViewlessPlugin):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):

18:54 Changeset [94619] by mrowe@apple.com

New tag.

18:43 Changeset [94618] by dpranke@chromium.org

fix MockFileSystem.glob(), refactor filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=67462

Reviewed by Eric Seidel.

In debugging why my proposed change for MockFileSystem.glob()
in bug 66228 didn't work, I stumbled across two real bugs
that cancelled each other out for the unit tests. I fixed those
(glob shouldn't recurse into subdirs, and we weren't populating
self.dirs from self.files properly).

I have also created a "mixin" class for tests that can be shared
between the real filesystem and the mock filesystem - MockFileSystem
is being used enough it needs its own tests.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
18:25 Changeset [94617] by oliver@apple.com

Update expected results of bindings tests.

16:36 Changeset [94616] by fpizlo@apple.com

Unreviewed build fix for r94559.

Marked the relevant parameters as unused if !ENABLE(JIT), and surrounded
new out-of-line JIT-specific method definitions with !ENABLE(JIT).

  • bytecode/CodeBlock.cpp:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

16:30 Changeset [94615] by abarth@webkit.org

editing/selection/mixed-editability-10.html is failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=67683

Update editing/selection/mixed-editability-10.html baselines after
HTMLSpanElement introduction.

  • editing/selection/mixed-editability-10-expected.txt:
  • platform/qt/editing/selection/mixed-editability-10-expected.png: Removed.
    • This test is no longer an image test.
  • platform/qt/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
16:26 Changeset [94614] by eric@webkit.org

Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1)
https://bugs.webkit.org/show_bug.cgi?id=67678

Reviewed by Darin Adler.

This is why we can't have nice things.

There was some confusion in the original DOM HTML 1 spec about
the existence of HTMlBlockquoteElement which was clarified by
a later errata, removing HTMLBlockquoteElement:
http://www.w3.org/DOM/updates/REC-DOM-Level-1-19981001-errata.html
"This interface is an error and must be ignored. The Interface HTMLQuoteElement is used for both the Q and BLOCKQUOTE elements"

Le sigh. Personally I think having a separate HTMLBlockquoteElement
is clearer, but thats not how the web works. Removed it and updated test results.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • editing/IndentOutdentCommand.cpp:
  • html/HTMLBlockquoteElement.cpp: Removed.
  • html/HTMLBlockquoteElement.h: Removed.
  • html/HTMLBlockquoteElement.idl: Removed.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::HTMLQuoteElement):
(WebCore::HTMLQuoteElement::insertedIntoDocument):

  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
16:06 Changeset [94613] by rniwa@webkit.org

Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
https://bugs.webkit.org/show_bug.cgi?id=67569

Reviewed by Antonio Gomes.

Source/WebCore:

Renamed Editor::confirmCompositionWithoutDisturbingSelection to Editor::cancelComposition.
Also renamed the shared function from confirmComposition to setComposition.

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::confirmComposition):
(WebCore::Editor::cancelComposition):
(WebCore::Editor::setComposition):

  • editing/Editor.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::unmarkText):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::resetIME):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView resignFirstResponder]):
(-[WKView _updateTextInputStateIncludingSecureInputState:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::cancelComposition):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::cancelComposition):

15:57 Changeset [94612] by jamesr@google.com

[chromium] Update expectations for a few tests that render oddly on xp due to r94589

  • platform/chromium/test_expectations.txt:
15:56 Changeset [94611] by mrowe@apple.com

Versioning.

15:56 Changeset [94610] by mrowe@apple.com

New tag.

15:52 Changeset [94609] by weinig@apple.com

WebVTTTokenizer files in the wrong place in the Xcode project.

  • WebCore.xcodeproj/project.pbxproj:

Move WebVTTTokenizer files so they are in the right place in the project.

15:51 Changeset [94608] by crogers@google.com

MediaElementAudioSourceNode destruction triggers ASSERTS
https://bugs.webkit.org/show_bug.cgi?id=67665

Reviewed by Nate Chapin.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode-gc.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setAudioSourceNode):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::uninitializeDispatch):
(WebCore::AudioContext::stop):

  • webaudio/AudioContext.h:

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-gc-expected.txt: Added.
  • webaudio/mediaelementaudiosourcenode-gc.html: Added.
15:45 Changeset [94607] by mrowe@apple.com

Fix broken PPC build due to new dtoa library
https://bugs.webkit.org/show_bug.cgi?id=67654

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Dan Bernstein.

Added condition for PPC in the new dtoa compatibility check so that
building won't fail.

  • wtf/dtoa/utils.h:
15:36 Changeset [94606] by kbr@google.com

Merge http://trac.webkit.org/changeset/93131 : GraphicsContext3D should allow its hostWindow to be NULL .

Pass 0 to SharedGraphicsContext3D::create.

Merge definition of CanvasRenderingContext2D::paintsIntoCanvasBuffer from http://trac.webkit.org/changeset/93157 .

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=94163

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7839014

15:29 Changeset [94605] by jamesr@google.com

[chromium] Update pixel baselines for r94597

  • platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/chromium-cg-mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/chromium-cg-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-win/fast/borders/border-image-longhand-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-longhand-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-scaled-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
15:19 Changeset [94604] by abarth@webkit.org

[Chromium] Add WebFloatQuad.h for Android
https://bugs.webkit.org/show_bug.cgi?id=67573

Reviewed by Darin Fisher.

Android uses this wrapper of WebCore::FloatQuad in some API methods
(which will appear in subsequent patches).

  • WebKit.gyp:
  • public/WebFloatQuad.h: Added.
  • src/WebFloatQuad.cpp: Added.
15:19 Changeset [94603] by mrowe@apple.com

Merge r94251.

15:17 WebKit Team edited by davidbarr@chromium.org
(diff)
15:17 Changeset [94602] by mrowe@apple.com

Merge r94478.

15:15 Changeset [94601] by alexis.menard@openbossa.org

[Qt] Fix API test failure after r92823 and r93001.
https://bugs.webkit.org/show_bug.cgi?id=67676

Reviewed by Kenneth Rohde Christiansen.

r92823 and r93001 make WebKit no longer produce wrapping style
spans on copy and paste and class="Apple-style-span" anymore.
Our expectations need to be updated.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::cursorMovements):
(tst_QWebPage::textSelection):
(tst_QWebPage::findText):

14:51 Changeset [94600] by abarth@webkit.org

[Chromium] Add didAcceptIndices to ExternalPopupMenuClient for Android
https://bugs.webkit.org/show_bug.cgi?id=67574

Reviewed by Darin Fisher.

In Android, external popup menus can admit multiple selection (e.g.,
for listboxes presented using external UI).

  • public/WebExternalPopupMenuClient.h:
  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):

  • src/ExternalPopupMenu.h:
14:51 Changeset [94599] by oliver@apple.com

An object's structure should reference the global object responsible for its creation
https://bugs.webkit.org/show_bug.cgi?id=67624

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add a reference to a GlobalObject to Structure, and update all calls to
Structure::create() to pass the global object that is the origin for that
structure. For objects where the appropriate global object isn't available
at construction time (global object prototypes, etc), or objects that
logically don't have a global object (strings, etc) we just pass null.

This change is largely mechanical (passing a new globalObject parameter
around).

  • API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::createStructure):

  • API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::createStructure):

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):

  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::createStructure):

  • runtime/Arguments.h:

(JSC::Arguments::createStructure):

  • runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

  • runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::createStructure):

  • runtime/BooleanObject.h:

(JSC::BooleanObject::createStructure):

  • runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

  • runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

  • runtime/DateInstance.h:

(JSC::DateInstance::createStructure):

  • runtime/DatePrototype.h:

(JSC::DatePrototype::createStructure):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::createStructure):

  • runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure):

  • runtime/Executable.h:

(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::createStructure):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

  • runtime/InternalFunction.h:

(JSC::InternalFunction::createStructure):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

  • runtime/JSActivation.h:

(JSC::JSActivation::createStructure):

  • runtime/JSArray.h:

(JSC::JSArray::createStructure):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::createStructure):

  • runtime/JSByteArray.h:
  • runtime/JSFunction.h:

(JSC::JSFunction::createStructure):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::createStructure):

  • runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

  • runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):

  • runtime/JSObject.h:

(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):
(JSC::createEmptyObjectStructure):

  • runtime/JSObjectWithGlobalObject.h:

(JSC::JSObjectWithGlobalObject::createStructure):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::createStructure):

  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::createStructure):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::createStructure):

  • runtime/MathObject.h:

(JSC::MathObject::createStructure):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::createStructure):
(JSC::NativeErrorConstructor::constructorBody):

  • runtime/NumberConstructor.h:

(JSC::NumberConstructor::createStructure):

  • runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

  • runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

  • runtime/RegExp.h:

(JSC::RegExp::createStructure):

  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::createStructure):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::createStructure):

  • runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::createStructure):

  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

  • runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure):

  • runtime/StringObject.h:

(JSC::StringObject::createStructure):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::createStructure):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::globalObject):
(JSC::Structure::setGlobalObject):

  • runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

Source/JavaScriptGlue:

Update for Structure::create() requiring a global object.

  • JSRun.h:

(JSGlueGlobalObject::create):

  • UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

Update calls to Structure::create() to pass the globalObject in,
and update the CodeGenerator to generate appropriate createStructure
methods.

  • bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::createStructure):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::createStructure):
(WebCore::getDOMStructure):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::createStructure):
(WebCore::getDOMConstructor):

  • bindings/js/JSDOMWindowBase.h:

(WebCore::JSDOMWindowBase::createStructure):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::createStructure):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::createStructure):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::createStructure):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::createStructure):

  • bindings/js/JSWorkerContextBase.h:

(WebCore::JSWorkerContextBase::createStructure):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::createStructure):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::createStructure):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::createStructure):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::createStructure):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::createStructure):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::createStructure):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::createStructure):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::createStructure):

Source/WebKit/mac:

Update for new Structure::create() globalObject parameter.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::createStructure):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

Source/WebKit2:

Update for new Structure::create globalObject parameter.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

14:50 Changeset [94598] by andersca@apple.com

Move NPAPI headers in bridge to plugins
https://bugs.webkit.org/show_bug.cgi?id=67661

Source/WebCore:

Reviewed by Darin Adler.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update build systems.

  • bridge/npapi.h: Removed.
  • bridge/npruntime.h: Removed.
  • bridge/nptypes.h: Removed.
  • plugins/npapi.h: Copied from Source/WebCore/bridge/npapi.h.
  • plugins/npruntime.h: Copied from Source/WebCore/bridge/npruntime.h.
  • plugins/nptypes.h: Copied from Source/WebCore/bridge/nptypes.h.

Tools:

Update forwarding headers.

  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
14:45 Changeset [94597] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67672

Improve background-size parsing. Make it actually dump auto values properly, and also make it omit
auto if it is the second value. Fix the parsing to not create a value list when only a singleton value
is specified.

Reviewed by Beth Dakin.

Covered well by existing tests.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillSizeToCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapFillSize):

LayoutTests:

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/parsing-inherit-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:
  • fast/backgrounds/size/resources/parsing-inherit.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt:
  • fast/css/value-list-out-of-bounds-crash.html:
  • svg/css/getComputedStyle-basic-expected.txt:
14:18 Changeset [94596] by hyatt@apple.com

Fix build bustage from accidental project file addition.

13:41 Changeset [94595] by hyatt@apple.com

Update some layout test results following the improved Pair parsing code that landed in r94593.

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:
  • fast/reflections/reflection-computed-style-expected.txt:
  • inspector/elements/elements-panel-styles-expected.txt:
13:37 Changeset [94594] by fpizlo@apple.com

LayoutTests does not include a test for DFG speculation recovery of additions
https://bugs.webkit.org/show_bug.cgi?id=67667

Reviewed by Geoffrey Garen.

  • fast/js/add-recovery-expected.txt: Added.
  • fast/js/add-recovery.html: Added.
  • fast/js/script-tests/add-recovery.js: Added.

(destructiveAddForBoxedInteger):

13:32 Changeset [94593] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67657

Implement border-image-width. This patch stops short of converting -webkit-border-image to a shorthand.
I'll do that in the next patch.

Note that unlike the -webkit-border-image syntax, border-image-width does not actually set the border
width values. It simply makes cuts into the border image drawing area (which for now is just the border
box, but that will change once border-image-outset is implemented).

This means we need additional storage for the slices, since they are now separate from the border widths.

For backwards compatibility, -webkit-border-image will continue to set the border widths when
border-image-width is specified in the -webkit-border-image shorthand.

Reviewed by Beth Dakin.

Source/WebCore:

Added new tests in fast/borders.

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::cssText):

  • css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::create):
(WebCore::CSSBorderImageSliceValue::slices):
Rename slices() to imageSlices() and add borderSlices() and m_borderSlices to hold the desired cuts
for the border image drawing area. Converted the slices over to the new Quad primitive value (a RectBase
subclass that is identical to Rect but dumps as a quad instead of a rect primitive).

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Make CSSBorderImageValue take the border slices during construction now.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageWidth):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for computed style via valueForNinePieceImageWidth. Patch all of the border image properties
to dump the most compact form possible for the property values, e.g., "stretch stretch" becomes "stretch."

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageWidthParseContext::BorderImageWidthParseContext):
(WebCore::BorderImageWidthParseContext::allowNumber):
(WebCore::BorderImageWidthParseContext::allowFinalCommit):
(WebCore::BorderImageWidthParseContext::top):
(WebCore::BorderImageWidthParseContext::commitNumber):
(WebCore::BorderImageWidthParseContext::setAllowFinalCommit):
(WebCore::BorderImageWidthParseContext::setTop):
(WebCore::BorderImageWidthParseContext::commitBorderImageWidth):
(WebCore::CSSParser::parseBorderImageWidth):

  • css/CSSParser.h:

Modify the border-image code to pass off border-image-width parsing to parseBorderImageWidth.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getQuadValue):
Add the new Quad value to CSSPrimitiveValue.

  • css/CSSPropertyNames.in:

Add the new properties for border-image-width and -webkit-mask-box-image-width.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:

Add the code to map the image width into border slices.

  • css/Rect.h:

(WebCore::RectBase::top):
(WebCore::RectBase::right):
(WebCore::RectBase::bottom):
(WebCore::RectBase::left):
(WebCore::RectBase::setTop):
(WebCore::RectBase::setRight):
(WebCore::RectBase::setBottom):
(WebCore::RectBase::setLeft):
(WebCore::RectBase::RectBase):
(WebCore::RectBase::~RectBase):
(WebCore::Rect::create):
(WebCore::Rect::Rect):
(WebCore::Quad::create):
(WebCore::Quad::Quad):
Adding the new Quad value.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Modify painting to treat the border slices as separate from the border widths.

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::operator==):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):

  • rendering/style/StyleRareNonInheritedData.cpp:

Add the border slices.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleReflection.h:

(WebCore::StyleReflection::StyleReflection):
Make sure masks and reflections default border-image-width to auto instead of 1, since that matches
old behavior.

LayoutTests:

  • fast/borders/border-image-longhand.html: Added.
  • fast/borders/border-image-scaled.html: Added.
  • fast/borders/border-image-side-reduction.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
  • fast/css/large-value-csstext-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:32 Changeset [94592] by tony@chromium.org

[chromium] Check in 'build' for compiled binaries first
https://bugs.webkit.org/show_bug.cgi?id=67549

Reviewed by Dirk Pranke.

I'm working on moving the windows build output to a common location
rather than relative to the sln file. Because of that, we need to
check those build locations first for DumpRenderTree.exe.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
12:50 Changeset [94591] by noel.gordon@gmail.com

[chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Kenneth Russell.

Change the row converter function signatures to be the same. Call them via a function
pointer during the encoding loop. Minor webkit style cleanup, remove unused include.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: Remove SkUnPreMultiply.h (not used).

(WebCore::preMultipliedBGRAtoRGB): Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB): pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels): Move constants out of the encoding loop: use a function pointer
to call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures), define
and use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode):

12:37 Changeset [94590] by commit-queue@webkit.org

Allow MediaSource API to be enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=67306

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-09-06
Reviewed by Eric Carlson.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitMediaSourceEnabled):

  • html/HTMLMediaElement.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

12:21 Changeset [94589] by reed@google.com

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:18 Changeset [94588] by ossy@webkit.org

[Qt][Symbian] REGRESSION[94105] DumpRenderTree.exe doesn't build on Symbian
https://bugs.webkit.org/show_bug.cgi?id=67644

Patch by Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> on 2011-09-06
Reviewed by Csaba Osztrogonác.

  • symbian/eabi/QtWebKitu.def: add missing entry for

FrameLoaderClientQt::dumpProgressFinishedCallback(bool)

12:03 Changeset [94587] by nduca@chromium.org

[chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621

CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
12:00 Changeset [94586] by rniwa@webkit.org

REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium
https://bugs.webkit.org/show_bug.cgi?id=67453

Reviewed by Kent Tamura.

.:

Add symbols for internals.

  • Source/autotools/symbols.filter:

Source/WebCore:

Fixed the bug by updating inner text value in setSuggestedValue.

Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.

Test: fast/forms/suggested-value.html

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.

  • src/WebNode.cpp:

(WebKit::WebNode::isFocusable):

Source/WebKit2:

Add symbols for internals.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.

  • fast/forms/suggested-value-expected.txt: Added.
  • fast/forms/suggested-value.html: Added.
11:56 Changeset [94585] by laszlo.1.gombos@nokia.com

2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460

Unreviewed, renaming tests in WK2 skiplists after r93312.

  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
11:49 Changeset [94584] by eric.carlson@apple.com

load() does not reset the resource selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=64917

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-source-load.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource): Reset m_nextChildNodeToConsider, update

comments and rearrange logic to more closely match logic in spec.

(WebCore::HTMLMediaElement::noneSupported): Update comments.

LayoutTests:

  • media/video-source-load-expected.txt: Added.
  • media/video-source-load.html: Added.
11:26 Changeset [94583] by commit-queue@webkit.org

[GTK] Use soup_session_add_feature_by_type uniformly in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=67593

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-06
Reviewed by Martin Robinson.

Using soup_session_add_feature_by_type for adding all soup features
instead of adding using GRefPtr.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

11:19 Changeset [94582] by inferno@chromium.org

Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Source/WebCore:

Reviewed by James Robinson.

Share propagateStyleToAnonymousChildren with RenderBlock::styleDidChange.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderObject.h:

LayoutTests:

Add comments explaining what the test does.

Reviewed by James Robinson.

  • fast/ruby/ruby-block-style-not-updated-with-before-after-content.html:
  • fast/ruby/ruby-block-style-not-updated.html:
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html:
  • fast/ruby/ruby-inline-style-not-updated.html:
  • fast/table/table-before-child-style-update.html:
  • fast/table/table-row-before-child-style-update.html:
  • fast/table/table-row-style-not-updated-with-after-content.html:
  • fast/table/table-row-style-not-updated-with-before-content.html:
  • fast/table/table-style-not-updated.html:
11:13 Changeset [94581] by commit-queue@webkit.org

[skia] States of GraphicsContext may never be restored after clipToImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=67358

Source/WebCore:

beginLayerClippedToImage/applyClipFromImage are mismatched when clipping to
an empty ImageBuffer, which will make states of GraphicsContext incorrect.

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

Test: fast/repaint/background-clip-text.html

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

LayoutTests:

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

  • fast/repaint/background-clip-text-expected.png: Added.
  • fast/repaint/background-clip-text-expected.txt: Added.
  • fast/repaint/background-clip-text.html: Added.
  • platform/qt/Skipped: Missing layoutController.testRepaint().
11:02 Changeset [94580] by abarth@webkit.org

Use a hierarchial structure for the garden-o-matic results view
https://bugs.webkit.org/show_bug.cgi?id=67620

Reviewed by Dimitri Glazkov.

This patch re-organizes the results view to use a hierachial structure
for selection. At the top-level are sections for each test. Expanding
the test section shows a tab selector for builders.

This structure prepares us for wiring up various actions to this view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

():

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

(.results-view>.toolbar):
(.results-view>.toolbar ul.actions):
(.results-view>.toolbar ul.actions li):
(.results-grid table):
(.results-grid table td, .results-view table th):
(.results-grid table th):
(.results-grid .text-result):
(.results-grid .image-result):

11:00 Changeset [94579] by abarth@webkit.org

garden-o-matic's base.probe generates spam in the JavaScript console
https://bugs.webkit.org/show_bug.cgi?id=67622

Reviewed by Dimitri Glazkov.

Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
instead of HTMLScriptElement to test whether results exist. This
reduces the console.log spam and saves bandwidth because we can use a
HEAD request instead of a GET request.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
10:49 Changeset [94578] by commit-queue@webkit.org

[EFL] Do not allocate memory for extremely large surfaces.
https://bugs.webkit.org/show_bug.cgi?id=65192

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-06
Reviewed by Martin Robinson.

So far, RenderThemeEfl tried to allocate a buffer and a cairo surface
the size of the whole form element passed to it.

In the case of
fast/overflow/overflow-height-float-not-removed-crash.html and others,
this meant extremely large widgets, which crashed the code.

We now only render the widgets if they are smaller than some hardcoded
and sufficiently large values which should work in most cases.

No new tests, as this was uncovered by existing ones.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::isFormElementTooLargeToDisplay):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):

  • platform/efl/RenderThemeEfl.h:
10:36 Changeset [94577] by podivilov@chromium.org

Web Inspector: implement source map v3 consumer.
https://bugs.webkit.org/show_bug.cgi?id=67205

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/compiler-source-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CompilerSourceMapping.js: Added.

(WebInspector.CompilerSourceMapping):
(WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.CompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._findMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parsePayload):
(WebInspector.ClosureCompilerSourceMapping.prototype._isSeparator):
(WebInspector.ClosureCompilerSourceMapping.prototype._decodeVLQ):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.next):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.peek):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.hasNext):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt: Added.
  • inspector/debugger/compiler-source-mapping.html: Added.
10:12 UsingGitWithWebKit edited by davidbarr@chromium.org
Add details about tuning aggressive gc (diff)
09:41 Changeset [94576] by philn@webkit.org

Unreviewed, unskip tests now passing because bug 61523 was fixed.

  • platform/gtk/Skipped:
09:19 Changeset [94575] by msaboff@apple.com

Add windows changes for JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67521

Windows build changes for regular expression functional test.

Rubber-stamped by Gavin Barraclough.

09:01 Changeset [94574] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip one more failing test.
08:53 Changeset [94573] by apavlov@chromium.org

[Chromium] Unreviewed, update expectation for inspector/elements/elements-panel-styles.html,
which no longer looks flaky.
https://bugs.webkit.org/show_bug.cgi?id=63056

  • platform/chromium/test_expectations.txt:
08:37 Changeset [94572] by ossy@webkit.org

[Qt] Unreviewed gardening after r94331.

  • platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png.
  • platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
08:25 Changeset [94571] by podivilov@chromium.org

Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

RawSourceCode content and source mapping loading logic is too complex, re-implement it using simpler semantics:
1) Initially, RawSourceCode doesn't have any content or mapping because content loading and
formatting operations are asynchronous, it only has scripts metadata. We don't update UI right
after RawSourceCode creation until full RawSourceCode representation is ready (content + mapping).
2) When RawSourceCode representation is ready (e.g. resource is finished, or content is formatted
if in pretty-print mode) we dispatch SourceMappingUpdated event to notify the listeners that
source code should be shown to user and raw locations should be converted to ui locations
(to show breakpoins, messages, call frames etc in UI). At this moment, all source file's content
is ready for loading and source mapping is available.
3) Later, RawSourceCode representation may change again, e.g. if pretty-print mode is toggled, or
blocked resource is finished etc., in that case SourceMappingUpdated is dispatched again to update
source code, links and decorations in UI.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.sourceMappingUpdated):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
08:23 Changeset [94570] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
07:30 Changeset [94569] by laszlo.1.gombos@nokia.com

2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Regression: On Lion, redirects lose HTTP authentication headers
https://bugs.webkit.org/show_bug.cgi?id=66354

Unreviewed, renaming tests in WK2 skiplist after r93247.

  • platform/wk2/Skipped:
07:11 Changeset [94568] by ossy@webkit.org

Unreviewed, rolling out r94564.
http://trac.webkit.org/changeset/94564
https://bugs.webkit.org/show_bug.cgi?id=67555

It broke many tests

Source/WebCore:

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):

LayoutTests:

  • svg/custom/tref-clone-crash-expected.txt: Removed.
  • svg/custom/tref-clone-crash.html: Removed.
07:07 Changeset [94567] by laszlo.1.gombos@nokia.com

2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

  • platform/wk2/Skipped: Remove non-existent tests from the Skipped list as well.
06:56 Changeset [94566] by andreas.kling@nokia.com

Unreviewed, removing non-existent test from Qt skiplist.

  • platform/qt/Skipped:
06:38 Changeset [94565] by ossy@webkit.org

[Qt][ARM] http/tests/loading/empty-urls.html fails
https://bugs.webkit.org/show_bug.cgi?id=67638

[Qt][ARM]fast/dom/call-a-constructor-as-a-function.html fails
https://bugs.webkit.org/show_bug.cgi?id=67639

  • platform/qt-arm/Skipped: Skip failing tests.
05:57 Changeset [94564] by rwlbuis@webkit.org

2011-09-06 Rob Buis <rbuis@rim.com>

use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555

Reviewed by Nikolas Zimmermann.

Do not install event listener if tref is not part of any document.

Test: svg/custom/tref-clone-crash.html

  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
05:48 Changeset [94563] by ossy@webkit.org

[Qt][ARM] Missing WebGLContextEvent window property
https://bugs.webkit.org/show_bug.cgi?id=67637

  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Added.
04:58 Changeset [94562] by yurys@chromium.org

Unreviewed, rolling out r94560.
http://trac.webkit.org/changeset/94560
https://bugs.webkit.org/show_bug.cgi?id=67636

It made inspector/debugger/script-formatter.html flakey
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.set reset):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.PresenationCallFrame.prototype.select):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._requestContent):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._hasPendingResource):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
04:15 Changeset [94561] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67480
[Chromium] [REGRESSION] Layout Test svg/batik/text/textStyles.svg is failing

Reviewed by Dimitri Glazkov.

The text node needs willRecalcStyle mechanism too.

  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:

(WebCore::Text::willRecalcTextStyle):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::SVGShadowText):
(WebCore::SVGShadowText::willRecalcTextStyle):

02:34 Changeset [94560] by podivilov@chromium.org

Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

RawSourceCode content and source mapping loading logic is too complex, re-implement it using simpler semantics:
1) Initially, RawSourceCode doesn't have any content or mapping because content loading and
formatting operations are asynchronous, it only has scripts metadata. We don't update UI right
after RawSourceCode creation until full RawSourceCode representation is ready (content + mapping).
2) When RawSourceCode representation is ready (e.g. resource is finished, or content is formatted
if in pretty-print mode) we dispatch SourceMappingUpdated event to notify the listeners that
source code should be shown to user and raw locations should be converted to ui locations
(to show breakpoins, messages, call frames etc in UI). At this moment, all source file's content
is ready for loading and source mapping is available.
3) Later, RawSourceCode representation may change again, e.g. if pretty-print mode is toggled, or
blocked resource is finished etc., in that case SourceMappingUpdated is dispatched again to update
source code, links and decorations in UI.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.sourceMappingUpdated):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
02:23 Changeset [94559] by fpizlo@apple.com

JavaScriptCore does not have tiered compilation
https://bugs.webkit.org/show_bug.cgi?id=67176

Reviewed by Gavin Barraclough.

This adds the ability to have multiple CodeBlocks associated with
a particular role in an Executable. These are stored in
descending order of compiler tier. CodeBlocks are optimized when
a counter (m_executeCounter) that is incremented in loops and
epilogues becomes positive. Optimizing means that all calls to
the old CodeBlock are unlinked.

The DFG can now pull in predictions from ValueProfiles, and
propagate them along the graph. To support the new phase while
maintaing some level of abstraction, a DFGDriver was introduced
that encapsulates how to run the DFG compiler.

This is turned off by default because it's not yet a performance
win on all benchmarks. It speeds up crypto and richards by
10% and 6% respectively, but still does not do as good of a job
as it could. Notably, the DFG backend has not changed, and
is largely oblivious to the new information being made available
to it.

When turned off (the default), this patch is performance neutral.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branchAdd32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchAdd32):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CallLinkInfo::unlink):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::clearEvalCache):
(JSC::replaceExistingEntries):
(JSC::CodeBlock::copyDataFromAlternative):
(JSC::ProgramCodeBlock::replacement):
(JSC::EvalCodeBlock::replacement):
(JSC::FunctionCodeBlock::replacement):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):

  • bytecode/CodeBlock.h:

(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::dynamicallyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::parse):

  • dfg/DFGDriver.cpp: Added.

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h: Added.

(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfDoubleConstant):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isConstant):
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):

  • dfg/DFGNode.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::valueOfInt32Constant):
(JSC::DFG::Node::valueOfDoubleConstant):
(JSC::DFG::Node::predict):

  • dfg/DFGPropagation.cpp: Added.

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):

  • dfg/DFGPropagation.h: Added.

(JSC::DFG::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • heap/HandleHeap.h:

(JSC::HandleHeap::Node::Node):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):

  • jit/JIT.h:

(JSC::JIT::emitOptimizationCheck):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

  • jit/JITCode.h:

(JSC::JITCode::JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileOptimizedFor):

  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::setPrev):
(WTF::BasicRawSentinelNode::setNext):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::BasicRawSentinelNode::isOnList):
(WTF::::remove):
(WTF::::SentinelLinkedList):
(WTF::::begin):
(WTF::::end):
(WTF::::push):

01:18 Changeset [94558] by krit@webkit.org

Return to transform multiplication: motion transform * other transforms
https://bugs.webkit.org/show_bug.cgi?id=67601

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Right now we take the current transform of a transformable SVG element, post multiply the animation transform
and post multiply the motion transform to the other both:

transform * animation transform * motion transform

We switched to this behavior with the clean up of AffineTransform.
While the specification of SVG demands us to do so, no other SVG viewer is doing it that way. Now switching back to:

motion transform * transform * animation transform

This is done by other SVG viewers as well. While their is no consense about how to multiply the different transforms
on the SVG WG, their is a consense that the current specified behavior is unwanted. See
http://lists.w3.org/Archives/Public/www-svg/2011Jan/0055.html for more details.

We pass the following tests of the official W3C SVG test suite again now:

  • animate-elem-24-t.svg
  • animate-elem-30-t.svg
  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Change the expected results of nested transformations to match new behavior
on matrices multiplications.

  • svg/animations/animate-path-nested-transforms-expected.txt:
  • svg/animations/animate-text-nested-transforms-expected.txt:
  • svg/animations/script-tests/animate-path-nested-transforms.js:

(startSample):
(endSample):

  • svg/animations/script-tests/animate-text-nested-transforms.js:

(startSample):
(endSample):

  • svg/animations/svgtransform-animation-discrete-expected.txt:
  • svg/animations/svgtransform-animation-discrete.html:
00:55 Changeset [94557] by abecsi@webkit.org

[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=49321

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-wk2/Skipped:

The issue is not reproducible any more, so the bug can be closed and the test unskipped.

00:50 Changeset [94556] by fpizlo@apple.com

Updated expectations on Mac for fast/js/global-constructors.html.

Rubber-stampted by Gavin Barraclough.

  • platform/mac/fast/js/global-constructors-expected.txt:
00:49 Changeset [94555] by commit-queue@webkit.org

Unreviewed, rolling out r94554.
http://trac.webkit.org/changeset/94554
https://bugs.webkit.org/show_bug.cgi?id=67631

This patch did not quite fix the problem (Requested by
benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
00:26 Changeset [94554] by commit-queue@webkit.org

PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
See this email from the git mailing list archive for info
http://marc.info/?l=git&m=114682417113315&w=2

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Shinichiro Hamaji.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
00:13 Changeset [94553] by philn@webkit.org

Unreviewed, GTK rebaseline after r94545.

  • platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
00:05 Changeset [94552] by philn@webkit.org

Unreviewed, fullscreen tests rebaseline after r94545.

  • fullscreen/full-screen-cancel-expected.txt:
  • fullscreen/full-screen-css-expected.txt:
  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-children-expected.txt:
  • fullscreen/full-screen-remove-expected.txt:
  • fullscreen/full-screen-twice-expected.txt:

09/05/11:

23:58 Changeset [94551] by reni@webkit.org

[Qt] Update expecteds after r94545.

Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:52 Changeset [94550] by inferno@chromium.org

Unreviewed. GTK rebaselines for r94541, r94543.

  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/gtk/fast/table/table-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/gtk/fast/table/table-row-style-not-updated-expected.txt: Added.
  • platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • platform/gtk/fast/table/table-style-not-updated-expected.txt: Added.
20:45 Changeset [94549] by jamesr@google.com

[chromium] Remove unnecessary expectation, results match the fallback path.

  • platform/chromium-cg-mac/fast/dom/wrapper-classes-expected.txt: Removed.
20:06 Changeset [94548] by inferno@chromium.org

Unreviewed. Chromium rebaselines for r94541, r94543.

  • platform/chromium-cg-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-cg-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • platform/chromium-linux/fast/table/table-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/chromium-win/fast/table/table-row-style-not-updated-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • platform/chromium-win/fast/table/table-style-not-updated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
19:38 Changeset [94547] by inferno@chromium.org

Unreviewed. Qt rebaselines for r94543.

  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-style-not-updated-expected.txt: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • platform/qt/fast/table/table-style-not-updated-expected.txt: Added.
19:13 Changeset [94546] by inferno@chromium.org

Unreviewed. Rebaselines for r94541.

  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
18:52 Changeset [94545] by abarth@webkit.org

window.HTMLSpanElement does not exist
https://bugs.webkit.org/show_bug.cgi?id=67571

Reviewed by Sam Weinig.

Source/WebCore:

We have these objects for most other elements and HTMLSpanElement
exists in Firefox and in the HTML5 spec. This patch adds it.

Test: fast/dom/wrapper-classes.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLSpanElement.cpp: Added.

(WebCore::HTMLSpanElement::HTMLSpanElement):
(WebCore::HTMLSpanElement::create):

  • html/HTMLSpanElement.h: Added.
  • html/HTMLSpanElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

Update tests to account for HTMLSpanElement existing. I also took the
liberty of changing fast/tokenizer/external-script-document-write.html
into a text test and cleaning up the platform-specific results.

  • editing/selection/extend-after-mouse-selection-expected.txt:
  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.txt: Added.
  • fast/tokenizer/resources/external-script-document-write.js:
  • platform/chromium-linux/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/gtk/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/mac-leopard/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/mac/fast/tokenizer/external-script-document-write-expected.txt: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write-expected.png: Removed.
  • platform/qt/fast/tokenizer/external-script-document-write-expected.txt: Removed.
18:49 Changeset [94544] by inferno@chromium.org

Merge 94543 - Style not propagated to anonymous boxes and anonymous
inline-blocks.

BUG=92651
Review URL: http://codereview.chromium.org/7833032

18:45 Changeset [94543] by inferno@chromium.org

Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html

fast/ruby/ruby-block-style-not-updated.html
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
fast/ruby/ruby-inline-style-not-updated.html
fast/table/table-row-style-not-updated-with-after-content.html
fast/table/table-row-style-not-updated-with-before-content.html
fast/table/table-row-style-not-updated.html
fast/table/table-style-not-updated.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isBeforeAfterContent):

  • rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):

  • rendering/RenderRuby.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):

  • rendering/RenderTableSection.h:

LayoutTests:

None of the different color boxes should overlap. If they overlap, test fails.

  • fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
  • fast/ruby/ruby-block-style-not-updated-with-before-after-content.html: Added.
  • fast/ruby/ruby-block-style-not-updated.html: Added.
  • fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
  • fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html: Added.
  • fast/ruby/ruby-inline-style-not-updated.html: Added.
  • fast/table/table-row-style-not-updated-expected.png: Added.
  • fast/table/table-row-style-not-updated-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-after-content.html: Added.
  • fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
  • fast/table/table-row-style-not-updated-with-before-content.html: Added.
  • fast/table/table-row-style-not-updated.html: Added.
  • fast/table/table-style-not-updated-expected.png: Added.
  • fast/table/table-style-not-updated-expected.txt: Added.
  • fast/table/table-style-not-updated.html: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/mac/fast/table/table-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
18:21 Changeset [94542] by inferno@chromium.org

Merge 94541 - Crash in RenderObjectChildList::destroyLeftOverChildren()

BUG=89580
Review URL: http://codereview.chromium.org/7737033

18:16 Changeset [94541] by inferno@chromium.org

Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

  • fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
  • fast/multicol/column-span-parent-continuation-crash.html: Added.
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
16:18 Changeset [94540] by abarth@webkit.org

Add a tab to garden-o-matic for viewing expected failures
https://bugs.webkit.org/show_bug.cgi?id=67619

Reviewed by Dimitri Glazkov.

This patch adds a basic tab to garden-o-matic that shows all the tests
failing on the bots, including the expected failures. This patch
mostly involves refactoring existing classes to allow new subclasses.

This view is useful for when gardeners mark tests as expected to fail
and then rebaseline them later.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
15:58 Changeset [94539] by abarth@webkit.org

Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617

Reviewed by Dimitri Glazkov.

Caught by running the unit tests with noglobals turned on.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
14:07 Changeset [94538] by commit-queue@webkit.org

Unreviewed, rolling out r94537.
http://trac.webkit.org/changeset/94537
https://bugs.webkit.org/show_bug.cgi?id=67618

Does not compile on Chromium Mac (Requested by abarth_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):

12:56 Changeset [94537] by noel.gordon@gmail.com

[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Adam Barth.

Change the row converter function signatures to be the same. Call them via a function
pointer during the encoding loop. Minor webkit stlye cleanup, remove unused include.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: Remove SkUnPreMultiply.h (not used).

(WebCore::preMultipliedBGRAtoRGB): Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB): pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels): Move contants out of the encoding loop: use a function pointer to
call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures) during the
image row encoding loop. Add/use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode): webkit style: no need to split lines.

09:55 Changeset [94536] by jknotten@chromium.org

Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

  • fast/events/page-scaled-mouse-click-expected.txt: Added.
  • fast/events/page-scaled-mouse-click.html: Added.
  • fast/events/script-tests/page-scaled-mouse-click.js: Added.
09:51 Changeset [94535] by kbalazs@webkit.org

D'oh! Missed the name of the test in the previous gardening.
Unreviewed regardening.

  • platform/qt-wk2/Skipped:
09:47 Changeset [94534] by kbalazs@webkit.org

[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67607

Unreviewed gardening.

  • platform/qt-wk2/Skipped:
08:42 Changeset [94533] by kbalazs@webkit.org

[Qt] Unreviewed gardening - move expectation to the correct place.

  • platform/qt/fast/borders/border-image-repeat-expected.txt: Renamed from LayoutTests/platform/qt/border-image-repeat-expected.txt.
08:35 Changeset [94532] by podivilov@chromium.org

Web Inspector: rename RawSourceCode.reload to contentEdited.
https://bugs.webkit.org/show_bug.cgi?id=67504

Make RawSourceCode.reload private and remove RawSourceCode.content getter and setter
(RawSourceCode isn't supposed to have any content).

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._didRequestContent):

08:01 Changeset [94531] by leandrogracia@chromium.org

Fix the regression of bug 65333 introduced by 60170.
This caused the speech input bubble to appear in the wrong side for RTL text inputs.
https://bugs.webkit.org/show_bug.cgi?id=67597

Reviewed by Tony Gentilcore.

No new tests. Fixing regression.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

07:46 Changeset [94530] by podivilov@chromium.org

Web Inspector: cleanup scripts-panel.html test.
https://bugs.webkit.org/show_bug.cgi?id=67497

ScriptsPanel test should not depend on presentation model internals.

Reviewed by Yury Semikhatsky.

  • inspector/debugger/scripts-panel.html:
07:40 Changeset [94529] by apavlov@chromium.org

Web Inspector: F5 results in a Web Inspector frontend reload on non-Macs
https://bugs.webkit.org/show_bug.cgi?id=67602

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

07:20 Changeset [94528] by kbalazs@webkit.org

[Qt] Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-05

  • platform/qt/border-image-repeat-expected.txt: Added.
07:11 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt to 4.7.4 and Mobility to 1.2.0 on Qt Linux Release bot (diff)
05:57 Changeset [94527] by loislo@chromium.org

Unreviewed, rolling out r94525.
http://trac.webkit.org/changeset/94525
https://bugs.webkit.org/show_bug.cgi?id=67599

WinCE compilation failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

  • platform/text/TextBoundaries.cpp:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
05:55 Changeset [94526] by kbalazs@webkit.org

2011-09-05 Balazs Kelemen <kbalazs@webkit.org>

[Qt] Update expectations.

Unreviewed gardening.

  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
05:08 Changeset [94525] by commit-queue@webkit.org

[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
https://bugs.webkit.org/show_bug.cgi?id=67391

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-09-05
Reviewed by Kenneth Rohde Christiansen.

  • platform/text/TextBoundaries.cpp:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
03:53 Changeset [94524] by kbalazs@webkit.org

[Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Reviewed by Andreas Kling.

Source/WebKit2:

  • Shared/API/c/qt/WKImageQt.cpp: Added.

(WKImageCreateQImage): C style (private) API to get the contents of the backing
store as an image.

  • Shared/API/c/qt/WKImageQt.h: Added.
  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage): Typo. Remove useless ifdef.

  • WebKit2API.pri:

Tools:

Implemented pixel result generation by reusing the logic
that we have in DumpRenderTree.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::dumpImage):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

03:50 Changeset [94523] by zoltan@webkit.org

[Qt] Update expected result after r94425
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Kristof Kosztyo <kkristof@inf.u-szeged.hu> on 2011-09-05

  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
03:43 Changeset [94522] by commit-queue@webkit.org

Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595

It broke everything (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

03:22 Changeset [94521] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium MAC.
The test was introduced at r94492.

  • platform/chromium-cg-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-cg-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
02:41 Changeset [94520] by paroga@webkit.org

Unreviewed build fix for r94452.

Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.

  • wtf/dtoa/bignum-dtoa.cc:
  • wtf/dtoa/bignum.cc:
  • wtf/dtoa/cached-powers.cc:
  • wtf/dtoa/diy-fp.cc:
  • wtf/dtoa/double-conversion.cc:
  • wtf/dtoa/fast-dtoa.cc:
  • wtf/dtoa/fixed-dtoa.cc:
  • wtf/dtoa/strtod.cc:
  • wtf/dtoa/utils.h:
01:49 Changeset [94519] by abecsi@webkit.org

[Qt][WK2] Fix the build

Rubber-stamped by Csaba Osztrogonác.

Source/JavaScriptCore:

  • wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.

The variable fractional_part is only set but never used.

Source/WebKit2:

  • DerivedSources.pro: Add missing PluginProcessConnection.messages.in after r94456.
01:36 Changeset [94518] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium Linux.
The test was introduced at r94492.

  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
00:52 Changeset [94517] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for chromium: fast/repaint/block-layout-inline-children-float-positioned.html

  • platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
00:46 Changeset [94516] by commit-queue@webkit.org

Logic from HTMLElement::deprecatedCreateContextualFragment moved into
Range::createContextualFragment function.
https://bugs.webkit.org/show_bug.cgi?id=67056

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-05
Reviewed by Ryosuke Niwa.

Code Refactoring for deprecatedCreateContextualFragment.

Source/WebCore:

No new tests. Code Re-factoring.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Range.cpp:

(WebCore::insertIntoFragment):
(WebCore::Range::createDocumentFragmentForElement):
(WebCore::Range::createContextualFragment):

  • dom/Range.h:
  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

  • html/HTMLElement.cpp:
  • html/HTMLElement.h:

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

00:38 Changeset [94515] by loislo@chromium.org

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for fast/inline/absolute-positioned-inline-in-centred-block

  • platform/chromium-cg-mac-leopard/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.

09/04/11:

23:48 Changeset [94514] by commit-queue@webkit.org

REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-04
Reviewed by Darin Adler.

Fixing the build (again which was broken by the dtoa patch. Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • wtf/dtoa/cached-powers.cc:
  • wtf/dtoa/utils.h:
23:43 Changeset [94513] by koz@chromium.org

Unreviewed, rolling out r94510.
http://trac.webkit.org/changeset/94510
https://bugs.webkit.org/show_bug.cgi?id=66531

Causes layout test crashes.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::wrapWithRenderFullScreen):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::createFullScreenStyle):

  • rendering/RenderFullScreen.h:

LayoutTests:

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Removed.
  • plugins/fullscreen-plugins-dont-reload.html: Removed.
22:59 Changeset [94512] by inferno@chromium.org

Unreviewed. Compile fix for r94511.

  • dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

22:22 Changeset [94511] by inferno@chromium.org

Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556

Reviewed by Ryosuke Niwa.

Source/WebCore:

Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.

Test: fast/dom/Range/range-delete-contents-event-fire-crash.html

  • dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

LayoutTests:

Tests that we do not crash when removing contents of
a range from the document.

  • fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt: Added.
  • fast/dom/Range/range-delete-contents-event-fire-crash.html: Added.
21:46 Changeset [94510] by commit-queue@webkit.org

Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

Test: plugins/fullscreen-plugins-dont-reload.html

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):

  • rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
  • plugins/fullscreen-plugins-dont-reload.html: Added.
21:18 Changeset [94509] by ryuan.choi@samsung.com

[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
https://bugs.webkit.org/show_bug.cgi?id=66542

Use a C++ compiler for these files, so that they can include the C++-using
ewk_private.h.

Reviewed by Daniel Bates.

  • CMakeListsEfl.txt:
  • ewk/ewk_view_single.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_single.c.

(_ewk_view_single_on_del):
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_backing_store_add):
(_ewk_view_single_smart_resize):
(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
(_ewk_view_single_smart_repaints_process):
(_ewk_view_single_smart_zoom_weak_set):
(_ewk_view_single_smart_zoom_weak_smooth_scale_set):
(_ewk_view_single_smart_bg_color_set):
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):

  • ewk/ewk_view_tiled.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_tiled.c.

(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_add):
(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):
(_ewk_view_tiled_smart_contents_resize):
(_ewk_view_tiled_smart_zoom_set):
(_ewk_view_tiled_smart_zoom_weak_set):
(_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
(_ewk_view_tiled_smart_flush):
(_ewk_view_tiled_smart_pre_render_region):
(_ewk_view_tiled_smart_pre_render_relative_radius):
(_ewk_view_tiled_smart_pre_render_cancel):
(_ewk_view_tiled_smart_disable_render):
(_ewk_view_tiled_smart_enable_render):
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):
(ewk_view_tiled_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

17:01 Changeset [94508] by mitz@apple.com

<rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.

  • dom/Document.cpp:

(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.

  • dom/Document.h:

(WebCore::Document::retireCustomFont): Added.

LayoutTests:

  • fast/css/font-face-used-after-retired-expected.txt: Added.
  • fast/css/font-face-used-after-retired.html: Added.
14:24 Changeset [94507] by abarth@webkit.org

[Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Reviewed by Darin Fisher.

This flag requests that the embedder allow multiple selection for the
popup menu. (See also https://bugs.webkit.org/show_bug.cgi?id=67574.)

  • public/WebPopupMenuInfo.h:
  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::getPopupMenuInfo):

14:19 Changeset [94506] by weinig@apple.com

Forgot to check in new results for fast/events/event-creation.html

  • fast/events/event-creation-expected.txt:
14:04 Changeset [94505] by weinig@apple.com

Document.createEvent should support all the interfaces of Event we got
https://bugs.webkit.org/show_bug.cgi?id=67568

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/events/event-creation.html

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
Added empty create.

  • dom/Document.cpp:

(WebCore::Document::createEvent):
Add missing interfaces.

  • dom/HashChangeEvent.h:

(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
Added empty create.

  • page/SpeechInputEvent.cpp:

(WebCore::SpeechInputEvent::create):
(WebCore::SpeechInputEvent::SpeechInputEvent):
(WebCore::SpeechInputEvent::~SpeechInputEvent):

  • page/SpeechInputEvent.h:

Added empty create.

LayoutTests:

  • fast/events/event-creation.html:

Converted to shouldBe style test, changed prototype check to us instanceof and constructor check,
added enumeration based catchall.

  • fast/events/event-instanceof-expected.txt: Removed.
  • fast/events/event-instanceof.html: Removed.
  • fast/events/script-tests/event-instanceof.js: Removed.

Moved contents to fast/events/event-creation.html.

11:10 Changeset [94504] by abarth@webkit.org

[Chromium] Add memory threshold values to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=67575

Reviewed by Darin Fisher.

Source/WebCore:

Grab these memory thresholds from PlatformSupport rather than hard-coding them.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • platform/chromium/PlatformSupport.h:
  • platform/qt/PlatformSupport.h:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

Source/WebKit/chromium:

Instead of hard-coding these values, we now grab them from
WebKitPlatformSupport because Android wishes to configure them on a
per-device basis.

One could view grabing these values from PlatformSupport as a bit of a
layering violation (because they feel like policy), but another view is
that the alternative implementation is to query the OS for various
memory parameters. In either case, getting these values via
PlatformSupport is much easier and consistent with the other memory
related queries in PlatformSupport already.

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::lowMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highUsageDeltaMB):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

11:04 Changeset [94503] by loislo@chromium.org

2011-09-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium expectations.
The expectations for http/tests/security/xssAuditor/dom-write-innerHTML.html
were in conflict. The first was for LINUX the second was for DEBUG. I just added RELEASE flag for LINUX one.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [94502] by kevino@webkit.org

[wx] Unreviewed build fix. Add new / moved files missing from last commit.

09:49 Changeset [94501] by kevino@webkit.org

[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
https://bugs.webkit.org/show_bug.cgi?id=67577

Reviewed by Kevin Ollivier.

09/03/11:

22:43 Changeset [94500] by fpizlo@apple.com

ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

19:58 Changeset [94499] by laszlo.1.gombos@nokia.com

REGRESSION (r86268): Fix for qt_networkAccessAllowed()
https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has been removed a while back.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

16:31 Changeset [94498] by rniwa@webkit.org

Remove the corresponding entry from the skipped list.

16:30 Changeset [94497] by rniwa@webkit.org

REGRESSION(r94274): selection-change-closes-typing.html fails
https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

  • editing/Editor.cpp:

(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

  • platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.

  • platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

15:43 Changeset [94496] by commit-queue@webkit.org

Test that document.all.tags() matches IE behavior with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

  • fast/dom/document-all-tags-expected.txt: Added.
  • fast/dom/document-all-tags.html: Added.
14:00 Changeset [94495] by robert@webkit.org

Add platform-specific results for r94492

Unreviewed.

  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
13:08 Changeset [94494] by kevino@webkit.org

[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

12:26 Changeset [94493] by weinig@apple.com

Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

  • page/DOMWindow.idl:

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

11:28 Changeset [94492] by robert@webkit.org

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html

  • Ensure positioned block elements inherit alignment. fast/css/bug4860-absolute-inline-child-inherits-alignment.html
  • Ensure positioned inline elements inherit alignment. fast/inline/absolute-positioned-inline-in-centred-block.html
  • Ensure positioned inline element that's the sole or first child of a rendered block obeys parents alignment. fast/inline/absolute-positioned-block-in-centred-block.html
  • As above, but a positioned block should not inherit alignment.
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
  • fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.
11:18 Changeset [94491] by andreas.kling@nokia.com

Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

  • dom/Element.cpp:
  • dom/Element.h:
10:13 Changeset [94490] by mitz@apple.com

32-bit build fix.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):

09:13 Changeset [94489] by commit-queue@webkit.org

[Qt] Enable support for WebGL OES_standard_derivatives for Qt
https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

08:57 Changeset [94488] by mitz@apple.com

Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.

  • TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.

(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD): Added.

01:29 Changeset [94487] by abarth@webkit.org

garden-o-matic results view should have a better results selector
https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view. Currently, this grid just shows how the tests fail on the
various bots. A future patch will let you select which failure to view
and to mark the failures for rebaselining.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Add some more basic functions for manipulating dictionaries.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
01:27 Changeset [94486] by abarth@webkit.org

garden-o-matic results view should show Actual and Expected results for text failures
https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid. Now that we do, we can move show these results.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Fixed some typos that were preventing these unit tests from running.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
    • Report -actual.txt and -expected.txt as possible results URLs.
01:25 Changeset [94485] by abarth@webkit.org

garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
00:49 Changeset [94484] by fpizlo@apple.com

DFG variable predictions only work for local variables, not temporaries
https://bugs.webkit.org/show_bug.cgi?id=67554

Reviewed by Gavin Barraclough.

This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

00:45 Changeset [94483] by rniwa@webkit.org

Unreviewed, rolling out r94458.
http://trac.webkit.org/changeset/94458
https://bugs.webkit.org/show_bug.cgi?id=67558

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
00:45 Changeset [94482] by yutak@chromium.org

WebSocket: Send ArrayBuffer as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67477

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/send-arraybuffer.html

http/tests/websocket/tests/hybi/workers/send-arraybuffer.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

Rename "sent" to "sendRequestResult" to clarify the meaning. Messages from the script may not
be sent immediately, thus the return value of WebSocketChannel::send() indicates whether the
message has been queued successfully, rather than whether the message has been sent or not.

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
Case of sending "[object ArrayBuffer]" is covered by an existing test
http/tests/websocket/tests/{hybi,hixie76}/send-object.html.

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
Construct an ArrayBuffer from the data on Vector<char>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Copy the content into temporary buffer of Vector<char>, and send it to the main thread.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Add tests to send ArrayBuffers.

  • http/tests/websocket/tests/hybi/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/send-blob_wsh.py, because this handler
is used from send-blob.html and send-arraybuffer.html.

  • http/tests/websocket/tests/hybi/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-arraybuffer.html:

Added. Send three small binary messages as ArrayBuffers.

  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/send-arraybuffer.js:

Added. Same as send-arraybuffer.html, except that this test is run on the worker.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Removed the definition of unnecessary function startsWith().

  • http/tests/websocket/tests/hybi/workers/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-arraybuffer.html: Added
00:29 Changeset [94481] by rniwa@webkit.org

Unreviewed, rolling out r94453.
http://trac.webkit.org/changeset/94453
https://bugs.webkit.org/show_bug.cgi?id=67557

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:

09/02/11:

23:04 Changeset [94480] by commit-queue@webkit.org

Implement a CustomEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67527

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns ScriptValue corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added the CustomEvent constructor.
  • dom/CustomEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

  • platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Updated the result.
22:45 Changeset [94479] by abarth@webkit.org

Remove WebKitClient.h
https://bugs.webkit.org/show_bug.cgi?id=67539

Reviewed by Sam Weinig.

This API no longer has any callers.

  • WebKit.gyp:
  • public/WebKit.h:
  • public/WebKitClient.h: Removed.
  • src/WebKit.cpp:
22:23 Changeset [94478] by fpizlo@apple.com

DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
https://bugs.webkit.org/show_bug.cgi?id=67551

Reviewed by Sam Weinig.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

22:14 Changeset [94477] by fpizlo@apple.com

ValueProfile does not make it safe to introspect cell values
after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=67354

Reviewed by Gavin Barraclough.

ValueProfile buckets are now weak references, implemented using a
light-weight weak reference mechanism that this patch also adds (the
WeakReferenceHarvester). If a cell stored in a ValueProfile bucket
is not marked, then the bucket is transformed into a Structure
pointer. If the Structure is not marked either, then it is turned
into a ClassInfo pointer.

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::probabilityOfArray):
(JSC::ValueProfile::WeakBucket::WeakBucket):
(JSC::ValueProfile::WeakBucket::operator!):
(JSC::ValueProfile::WeakBucket::isEmpty):
(JSC::ValueProfile::WeakBucket::isClassInfo):
(JSC::ValueProfile::WeakBucket::isStructure):
(JSC::ValueProfile::WeakBucket::asStructure):
(JSC::ValueProfile::WeakBucket::asClassInfo):
(JSC::ValueProfile::WeakBucket::getClassInfo):

  • heap/Heap.cpp:

(JSC::Heap::harvestWeakReferences):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::appendUnbarrieredPointer):

  • heap/SlotVisitor.h:
  • heap/WeakReferenceHarvester.h: Added.

(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

18:20 Changeset [94476] by commit-queue@webkit.org

Unreviewed, rolling out r94473.
http://trac.webkit.org/changeset/94473
https://bugs.webkit.org/show_bug.cgi?id=67547

Putting http://trac.webkit.org/changeset/94454 back in as
http://trac.webkit.org/changeset/94472 fixed the problem
(Requested by msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
18:08 Changeset [94475] by msaboff@apple.com

Replace local implementation of string equals() methods with UString versions
https://bugs.webkit.org/show_bug.cgi?id=67342

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.

Reviewed by Gavin Barraclough.

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):

  • runtime/Identifier.h:

(JSC::Identifier::equal):

  • wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):

  • wtf/text/StringImpl.cpp:

(WTF::equal):

  • wtf/text/StringImpl.h:
18:06 Changeset [94474] by enne@google.com

[chromium] Move updateLayers from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67438

Reviewed by James Robinson.

Covered by existing tests.

Move functionality used by both CCLayerTreeHost and
LayerRendererChromium into CCLayerTreeHostCommon. Move update, paint,
and updateCompositorResource functions into CClayerTreeHost.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Added.

(WebCore::CCLayerTreeHostCommon::isScaleOrTranslation):
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Added.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitIfNeeded):

18:02 Changeset [94473] by commit-queue@webkit.org

Unreviewed, rolling out r94454.
http://trac.webkit.org/changeset/94454
https://bugs.webkit.org/show_bug.cgi?id=67546

"Broke Windows and SnowLeopard, also no reply on the bug."
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
18:01 Changeset [94472] by msaboff@apple.com

2011-09-02 Michael Saboff <msaboff@apple.com>

Fixed release build by removing #ifndef NDEBUG to
allow definition of gcController().

Rubber-stamp by Sam Weinig.

  • WebProcess/WebProcess.cpp:
17:42 Changeset [94471] by cmarrin@apple.com

2011-09-02 Chris Marrin <cmarrin@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=67510
Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction

Reviewed by Simon Fraser.


Do a null check in two places to avoid sending nulls to CACF ValueFunction API.

Test: animations/pause-crash.html

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::valueFunction): (PlatformCAAnimation::setValueFunction):
17:41 Changeset [94470] by msaboff@apple.com

Add JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67339

Source/JavaScriptCore:

Added new test driver program (testRegExp) and corresponding data file
along with build scripts changes.

Reviewed by Gavin Barraclough.

(Options::Options):
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(RegExpTest::RegExpTest):
(GlobalObject::create):
(GlobalObject::className):
(GlobalObject::GlobalObject):
(main):
(cleanupGlobalData):
(testOneRegExp):
(scanString):
(parseRegExpLine):
(parseTestLine):
(runFromFiles):
(printUsageStatement):
(parseArguments):
(realMain):

  • tests/regexp: Added.
  • tests/regexp/RegExpTest.data: Added.

Tools:

New perl script to build JavaScriptCore and run the RegExp tests.

Reviewed by Gavin Barraclough.

  • Scripts/run-regexp-tests: Added.
17:31 Changeset [94469] by jamesr@google.com

[chromium] Update baselines and expectations.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
17:20 Changeset [94468] by msaboff@apple.com

Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519

Add a data generator for regular expressions. To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
regular expressions. The resulting data will be in /tmp/RegExpTestsData.

Reviewed by Gavin Barraclough.

  • runtime/RegExp.cpp:

(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

17:20 Changeset [94467] by enne@google.com

[chromium] Fix crash when compositing is disabled during painting
https://bugs.webkit.org/show_bug.cgi?id=66981

Reviewed by James Robinson.

This fixes a use-after-free and a null pointer deref introduced by r93940.
See also: http://codereview.chromium.org/7739008/

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::updateLayers):

17:17 Changeset [94466] by commit-queue@webkit.org

Source/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader,
SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient,
and ThreadableLoaderClient for the Chromium port only, so we can pass
these notifications from our ResourceHandle implementation through the
WebCore loader framework.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

No new tests. Exposes no new functionality.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:

(WebCore::SubresourceLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::didDownloadData):

  • loader/chromium: Added.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp: Added.

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/chromium/ResourceLoaderChromium.cpp: Added.

(WebCore::ResourceLoader::didDownloadData):

  • loader/chromium/SubresourceLoaderChromium.cpp: Added.

(WebCore::SubresourceLoader::didDownloadData):

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didDownloadData):

Source/WebKit/chromium: Add a 'didDownloadData' method to ResourceHandleInternal and pass these
notifications to WebURLLoaderClients.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didDownloadData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::didDownloadData):

  • src/ResourceHandleInternal.h:
17:16 Changeset [94465] by jeffm@apple.com

Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=67541

Reviewed by Simon Fraser.

No new tests, covered by existing media tests.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.

17:07 Changeset [94464] by jchaffraix@webkit.org

Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
https://bugs.webkit.org/show_bug.cgi?id=66901

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/assert-RenderLayer-update-positions.html

Also covered by existing tests under the new ASSERT.

This change extends the range of callers making use of the cachedOffset optimization.

Most callers did not make use of cachedOffset as it did not work when called on a subtree.
This limitation is now gone thus we can enable it more widely.

The semantics of the optimization are changed a bit as we now return if it is enabled whereas
the old code would check if it was *disabled*. Also there were some renames done to match more
closely what was going on (s/cachedOffset/offsetFromRoot/ and s/cachedOffsetDisabled/hasLayerOffset/).

Note that this is an optimistic optimization: if cachedOffset is not used, then we have
done at least an extra traversal up to the root. I have found it to be a wash on file
cycler (alexa) but to be a nice improvement (~20%) on some table benchmarks (modifying
a cell, scrolling).

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Extended the use of cachedOffset to subtree layouts.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Forbid the use cachedOffset in this
case as we have only a single layer to update.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeOffsetFromRoot): Added this function to get the offset from the root
layer at a certain point in the RenderLayer's tree. It gets the root layer's checking if no layer
in between would prevent convertToLayerCoords to work and return the position relative to
this layer.

(WebCore::RenderLayer::updateLayerPositions): Added a new ASSERT to make sure our cachedOffset
is always fine. Also added a comment about calling convertToLayerCoords.

(WebCore::RenderLayer::removeOnlyThisLayer): Added cachedOffset here too as we may have to
update several layers. We save the offset prior to being removed from the hierarchy for
correctness.

(WebCore::RenderLayer::paintChildLayerIntoColumns): Added a comment here about calling convertToLayerCoords.

  • rendering/RenderLayer.h: Swapped the argument in updateLayerPositions to make

cachedOffset a mandatory field. Patched all the callers.

(WebCore::RenderLayer::canUseConvertToLayerCoords): Added this helper method to know when a
renderer prevents convertToLayerCoords from working. Added some FIXME around suspicious use
of convertToLayerCoords.

LayoutTests:

  • fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
  • fast/layers/crash-RenderLayer-update-positions.html: Added.

Test that some changes in the layers does not cause an ASSERT failure.

16:58 Changeset [94463] by commit-queue@webkit.org

Fix the broken build due to dtoa patch
https://bugs.webkit.org/show_bug.cgi?id=67534

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Fixing the build.

  • GNUmakefile.list.am:
  • wtf/dtoa/bignum.cc:
  • wtf/dtoa/fast-dtoa.cc:
  • wtf/dtoa/utils.h:
16:39 Changeset [94462] by commit-queue@webkit.org

[Qt][Symbian] REGRESSION(93235) Missing .def update
https://bugs.webkit.org/show_bug.cgi?id=67307

Patch by Jade Han <jade.han@nokia.com> on 2011-09-02
Reviewed by Laszlo Gombos.

  • symbian/eabi/QtWebKitu.def:
16:33 Changeset [94461] by oliver@apple.com

Remove OldSpace classes
https://bugs.webkit.org/show_bug.cgi?id=67533

Reviewed by Gavin Barraclough.

Remove the unused OldSpace classes

(JSC::Heap::writeBarrierSlowCase):

  • heap/MarkedBlock.h:
  • heap/OldSpace.cpp: Removed.
  • heap/OldSpace.h: Removed.
16:25 Changeset [94460] by jamesr@google.com

Compile fix for mac build.

  • wtf/CheckedArithmetic.h:

(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

16:07 Changeset [94459] by commit-queue@webkit.org

Need API for getting surrounding text from webkit in chromium
https://bugs.webkit.org/show_bug.cgi?id=66681

Patch by Peng Huang <penghuang@chromium.org> on 2011-09-02
Reviewed by Ryosuke Niwa.

Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
WebViewImpl. This function is for supporting some input methods which
need input context around the edit caret.

  • public/WebWidget.h:

(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.h:
15:33 Changeset [94458] by eric@webkit.org

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Unreviewed. Fixing typo from previous commit.

Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block
which exercises the code I previously made a typo in.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
15:32 Changeset [94457] by mdelaney@apple.com

Read out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
https://bugs.webkit.org/show_bug.cgi?id=65352

Reviewed by Simon Fraser.

New test: fast/canvas/canvas-getImageData-large-crash.html

Source/JavaScriptCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC
is just to add a new helper method described below.

  • wtf/MathExtras.h:

(isWithinIntRange): Reports if a float's value is within the range expressible by an int.

Source/WebCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice): Removed dependency on ints, using FloatRects/Sizes instead.
(WebCore::HTMLCanvasElement::createImageBuffer): Moved the check for max canvas area and dimensions here.

Added in check that prevents us from having canvases of sizes that will cause overflows.

(WebCore::HTMLCanvasElement::baseTransform): Updated use of convertLogicalToDevice.

  • html/HTMLCanvasElement.h: Updated method signatures.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData): Added in check to prevent creating ImageData objects that will cause overflow when computing their size.
(WebCore::CanvasRenderingContext2D::createImageData): Avoid creating ImageData objects of size that will overflow later.
(WebCore::CanvasRenderingContext2D::getImageData): Added in check to prevent trying to get ImageData objects that will cause overflow when computing their size.

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::isExpressibleAsIntRect): New method that tests whether a FloatRect can become an IntRect without overflow or having to be clamped.

  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isExpressibleAsIntSize): Same as FloatRect, but for FloatSize->IntSize.

  • platform/graphics/FloatSize.h:
  • platform/graphics/cg/ImageBufferCG.cpp: Added check for overflow.

(WebCore::ImageBuffer::ImageBuffer):

15:22 Changeset [94456] by andersca@apple.com

NPN_SetException doesn't work with OOP plug-ins
https://bugs.webkit.org/show_bug.cgi?id=67524

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProcessConnection.messages.in.

  • GNUmakefile.am:

Add generated files.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassPluginProcessConnection.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initialize):
Set the set exception function.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::ConnectionStack::current):
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher):
Add a helper class for managing a stack of CoreIPC connections, along with a RAII
object to push/pop connections onto it.

(WebKit::connectionStack):
Add getter.

(WebKit::WebProcessConnection::setGlobalException):
Get the current connection and send a PluginProcessConnection::SetException message to it.

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
Create connection pushers.

  • PluginProcess/WebProcessConnection.h:

Add setGlobalException.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setSetExceptionFunction):
New function for setting the 'setException' function.

(WebKit::NetscapePlugin::setException):
Call the 'setException' function.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveSyncMessage):
Call the message receiver function.

(WebKit::PluginProcessConnection::setException):
Call the NPRuntimeObjectMap.

  • WebProcess/Plugins/PluginProcessConnection.messages.in:

Add new messages file.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
When not using the plug-in process, make sure to call NetscapePlugin::setSetExceptionFunction.

15:22 Changeset [94455] by mitz@apple.com

<rdar://problem/9755843> anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node

Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/operator-hijacks-fenced-node.xhtml

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().

LayoutTests:

  • mathml/operator-hijacks-fenced-node-expected.txt: Added.
  • mathml/operator-hijacks-fenced-node.xhtml: Added.
15:21 Changeset [94454] by adachan@apple.com

Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=67526

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.
15:19 Changeset [94453] by eric@webkit.org

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Reviewed by Adam Barth.

No functional change, just reshuffling code.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:09 Changeset [94452] by commit-queue@webkit.org

Incorporate newer, faster dtoa library
https://bugs.webkit.org/show_bug.cgi?id=66346

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/UString.cpp:

(JSC::UString::number):

  • wtf/CMakeLists.txt:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::dtoa):

  • wtf/dtoa.h:
  • wtf/dtoa/COPYING: Added.
  • wtf/dtoa/LICENSE: Added.
  • wtf/dtoa/README: Added.
  • wtf/dtoa/bignum-dtoa.cc: Added.
  • wtf/dtoa/bignum-dtoa.h: Added.
  • wtf/dtoa/bignum.cc: Added.
  • wtf/dtoa/bignum.h: Added.

(WTF::double_conversion::Bignum::Times10):
(WTF::double_conversion::Bignum::Equal):
(WTF::double_conversion::Bignum::LessEqual):
(WTF::double_conversion::Bignum::Less):
(WTF::double_conversion::Bignum::PlusEqual):
(WTF::double_conversion::Bignum::PlusLessEqual):
(WTF::double_conversion::Bignum::PlusLess):
(WTF::double_conversion::Bignum::EnsureCapacity):
(WTF::double_conversion::Bignum::BigitLength):

  • wtf/dtoa/cached-powers.cc: Added.
  • wtf/dtoa/cached-powers.h: Added.
  • wtf/dtoa/diy-fp.cc: Added.
  • wtf/dtoa/diy-fp.h: Added.

(WTF::double_conversion::DiyFp::DiyFp):
(WTF::double_conversion::DiyFp::Subtract):
(WTF::double_conversion::DiyFp::Minus):
(WTF::double_conversion::DiyFp::Times):
(WTF::double_conversion::DiyFp::Normalize):
(WTF::double_conversion::DiyFp::f):
(WTF::double_conversion::DiyFp::e):
(WTF::double_conversion::DiyFp::set_f):
(WTF::double_conversion::DiyFp::set_e):

  • wtf/dtoa/double-conversion.cc: Added.
  • wtf/dtoa/double-conversion.h: Added.

(WTF::double_conversion::DoubleToStringConverter::DoubleToStringConverter):
(WTF::double_conversion::StringToDoubleConverter::StringToDoubleConverter):

  • wtf/dtoa/double.h: Added.

(WTF::double_conversion::double_to_uint64):
(WTF::double_conversion::uint64_to_double):
(WTF::double_conversion::Double::Double):
(WTF::double_conversion::Double::AsDiyFp):
(WTF::double_conversion::Double::AsNormalizedDiyFp):
(WTF::double_conversion::Double::AsUint64):
(WTF::double_conversion::Double::NextDouble):
(WTF::double_conversion::Double::Exponent):
(WTF::double_conversion::Double::Significand):
(WTF::double_conversion::Double::IsDenormal):
(WTF::double_conversion::Double::IsSpecial):
(WTF::double_conversion::Double::IsNan):
(WTF::double_conversion::Double::IsInfinite):
(WTF::double_conversion::Double::Sign):
(WTF::double_conversion::Double::UpperBoundary):
(WTF::double_conversion::Double::NormalizedBoundaries):
(WTF::double_conversion::Double::value):
(WTF::double_conversion::Double::SignificandSizeForOrderOfMagnitude):
(WTF::double_conversion::Double::Infinity):
(WTF::double_conversion::Double::NaN):
(WTF::double_conversion::Double::DiyFpToUint64):

  • wtf/dtoa/fast-dtoa.cc: Added.
  • wtf/dtoa/fast-dtoa.h: Added.
  • wtf/dtoa/fixed-dtoa.cc: Added.
  • wtf/dtoa/fixed-dtoa.h: Added.
  • wtf/dtoa/strtod.cc: Added.
  • wtf/dtoa/strtod.h: Added.
  • wtf/dtoa/utils.h: Added.

(WTF::double_conversion::Max):
(WTF::double_conversion::Min):
(WTF::double_conversion::StrLength):
(WTF::double_conversion::Vector::Vector):
(WTF::double_conversion::Vector::SubVector):
(WTF::double_conversion::Vector::length):
(WTF::double_conversion::Vector::is_empty):
(WTF::double_conversion::Vector::start):
(WTF::double_conversion::Vector::operator[]):
(WTF::double_conversion::Vector::first):
(WTF::double_conversion::Vector::last):
(WTF::double_conversion::StringBuilder::StringBuilder):
(WTF::double_conversion::StringBuilder::~StringBuilder):
(WTF::double_conversion::StringBuilder::size):
(WTF::double_conversion::StringBuilder::position):
(WTF::double_conversion::StringBuilder::Reset):
(WTF::double_conversion::StringBuilder::AddCharacter):
(WTF::double_conversion::StringBuilder::AddString):
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::AddPadding):
(WTF::double_conversion::StringBuilder::Finalize):
(WTF::double_conversion::StringBuilder::is_finalized):
(WTF::double_conversion::BitCast):

  • wtf/wtf.pri:

Source/WebCore:

No new tests.

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

  • ForwardingHeaders/wtf/dtoa/double-conversion.h: Added.
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorBasicValue::writeJSON):

  • platform/graphics/Color.cpp:

(WebCore::Color::serialized):

14:57 Changeset [94451] by commit-queue@webkit.org

Add LayoutTest for the case where long strings are processed by the XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=66580

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-02
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/resources/xss-filter-bypass-long-string-reply.html: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string.html: Added.
14:35 Changeset [94450] by nduca@chromium.org

[chromium] Check for null context when reinitializing compositor
https://bugs.webkit.org/show_bug.cgi?id=67507

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

14:16 Changeset [94449] by fpizlo@apple.com

DFG graph has no way of distinguishing or reconciling between static
and dynamic predictions
https://bugs.webkit.org/show_bug.cgi?id=67343

Reviewed by Gavin Barraclough.

PredictedType now stores the source of the prediction. Merging predictions,
which was previously done with a bitwise or, is now done via the
mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
functions, which correctly handle combinations of static and dynamic.

This is performance-neutral, since all predictions are currently static and
so the code has no visible effects.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::staticallyPredictArray):
(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):

  • dfg/DFGNode.h:

(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isDynamicPrediction):
(JSC::DFG::mergePredictions):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::predict):

14:08 Changeset [94448] by oliver@apple.com

Fix 32bit build.

13:49 Changeset [94447] by lforschler@apple.com

Versioning.

13:48 Changeset [94446] by jer.noble@apple.com

Some media layout tests fail because of ambiguous ordering of canplaythough event.
https://bugs.webkit.org/show_bug.cgi?id=67520

Reviewed by Eric Carlson.

The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.

  • media/audio-play-event-expected.txt:
  • media/audio-play-event.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-during-playback.html:
13:41 Changeset [94445] by oliver@apple.com

Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Gavin Barraclough.

Switch to a bump allocator for the initial out of line
property storage. This gives us slightly faster allocation
for short lived objects that need out of line storage at
the cost of an additional memcpy when the object survives
a GC pass.

No performance impact.

(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursary):

  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursary):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursary):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

13:33 Changeset [94444] by darin@apple.com

Added Subversion ignore for .pyc generated files.

  • Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
  • Scripts/webkitpy/tool/servers: Added property svn:ignore.
13:25 Changeset [94443] by jamesr@google.com

[chromium] Update expectations for tests with animations and reflections

  • platform/chromium/test_expectations.txt:
12:55 Changeset [94442] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • DEPS:
12:48 Changeset [94441] by abarth@webkit.org

Enable testing on mac-ews
https://bugs.webkit.org/show_bug.cgi?id=67505

Reviewed by Eric Seidel.

This patch enables testing on the Mac EWS, which should help
contributors not turn the Mac bots red.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:40 Changeset [94440] by jamesr@google.com

[chromium] Update some chromium gpu baselines

  • platform/chromium-gpu-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 Changeset [94439] by andersca@apple.com

Remove plug-in paths from web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=67518

Reviewed by Adam Roben.

Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile.

  • WebProcess/com.apple.WebProcess.sb:
12:19 Changeset [94438] by andersca@apple.com

Assertion/crash when running netscape-plugin-property-access-exception.html test
https://bugs.webkit.org/show_bug.cgi?id=67517

Reviewed by Adam Roben.

Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
but doesn't set the result NPVariant to anything.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::getProperty):

11:55 Changeset [94437] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67451
Add a test for going back to a cached page after changing the device scale factor

Reviewed by Adam Roben.

New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.

(TestWebKitAPI::DeviceScaleFactorOnBack::url):
(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
(TestWebKitAPI::TEST_F):

Added new function to WebKitAgnosticTest to goBack. Separated
waitForLoadToFinish() into its own function (instead of being a part of
loadAndWaitUntilFinished()) so that it can be called from goBack as
well. Also added initializeView() so we can set the cache model.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h:

(TestWebKitAPI::WebKitAgnosticTest::initializeView):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
(TestWebKitAPI::WebKitAgnosticTest::loadURL):
(TestWebKitAPI::WebKitAgnosticTest::goBack):
(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):

11:35 Changeset [94436] by ap@apple.com

Flaky Test: http/tests/appcache/origin-usage.html
https://bugs.webkit.org/show_bug.cgi?id=60928

Reviewed by Joseph Pecoraro.

Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.

  • http/tests/appcache/origin-usage-expected.txt:
  • http/tests/appcache/origin-usage.html: Increase the range for success. It's OK because data is added in larger chunks anyway.
11:17 Changeset [94435] by andersca@apple.com

The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508

Reviewed by Sam Weinig.

Source/WebKit2:

Store the new private browsing state so subsequent queries for it
will return the right value.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::privateBrowsingStateChanged):

LayoutTests:

Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.

  • platform/wk2/Skipped:
11:02 Changeset [94434] by caryclark@google.com

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

  • platform/chromium-mac/media/controls-after-reload-expected.txt: Added.

(remaining files omitted for brevity)

10:42 Changeset [94433] by weinig@apple.com

Remove BeforeProcessEvent, it was never meant to be
https://bugs.webkit.org/show_bug.cgi?id=67493

Reviewed by Anders Carlsson.

BeforeProcessEvent was added, never hooked up, and never removed.
Now it is being removed.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeProcessEvent.cpp: Removed.
  • dom/BeforeProcessEvent.h: Removed.
  • dom/BeforeProcessEvent.idl: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:
  • dom/EventNames.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseMappedAttribute):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseMappedAttribute):

10:41 Changeset [94432] by andersca@apple.com

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:

(PrivateBrowsing::ScriptableObject::pluginTest):

10:36 Changeset [94431] by enne@google.com

[chromium] Remove LayerRendererChromium references from the LayerChromium tree
https://bugs.webkit.org/show_bug.cgi?id=66430

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

Replace references to LayerRendererChromium in the LayerChromium tree
with references to LayerTreeHost. The LayerRendererChromium property
is no longer synced and instead is set recursively on the CCLayerImpl
tree during commit.

WebGLLayerChromium's paintRenderedResultsToCanvas function is
temporarily turned off for threaded compositing because it needs
access to the compositor context.

Previously, changing the layer renderer on a layer called cleanup
resources on that layer. Now, call that explicitly clean up all
resources explicitly from the proxy when the layer renderer gets
created. This cleans up all of the ManagedTexture objects which may be
hanging onto stale GraphicsContext3D pointers.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::cleanupResourcesRecursive):
(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::textureManager):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::reserveTextures):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setTextureUpdated):
(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setLayerRendererRecursive):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

Source/WebKit/chromium:

Change references to LayerRendererChromium to CCLayerTreeHost.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):

10:33 Changeset [94430] by andersca@apple.com

Move private browsing test to a PluginTest subclass
https://bugs.webkit.org/show_bug.cgi?id=67498

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginGetProperty):

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.

(PrivateBrowsing::PrivateBrowsing):
(PrivateBrowsing::privateBrowsingEnabled):
(PrivateBrowsing::cachedPrivateBrowsingEnabled):
(PrivateBrowsing::ScriptableObject::hasProperty):
(PrivateBrowsing::ScriptableObject::getProperty):
(PrivateBrowsing::ScriptableObject::pluginTest):
(PrivateBrowsing::NPP_New):
(PrivateBrowsing::NPP_GetValue):
(PrivateBrowsing::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
(NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

Set the 'test' attribute to 'private-browsing'.

  • plugins/private-browsing-mode-2.html:
  • plugins/private-browsing-mode.html:
10:24 Changeset [94429] by apavlov@chromium.org

[Chromium] Unreviewed, update expectations after r94420.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
10:09 Changeset [94428] by ap@apple.com

Build fix.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.
10:07 Changeset [94427] by commit-queue@webkit.org

Unreviewed, rolling out r94421.
http://trac.webkit.org/changeset/94421
https://bugs.webkit.org/show_bug.cgi?id=67496

Broke a number of tests on Chromium builders (including the
"cr-linux" EWS bot) (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

10:02 Changeset [94426] by ap@apple.com

REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=67356

Reviewed by Darin Adler.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Don't enable old-style private browsing when using sessions - it would take precedence over session cookie storage on Snow Leopard.
10:01 Changeset [94425] by commit-queue@webkit.org

BORDER attribute percent with the input image tag not working.
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-09-02
Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes 2 issues regarding the border attribute of an input image element.

  1. The border attribute, if specified, is now taken into account and the border of the input image element is displayed.
  2. If the border attribute contains percent, the border is displayed.

The value of the border attribute for input image element is now parsed according to the rules for parsing non-negative integers.
This implies that when percent is specified in the border attribute, parsing takes place and the percent is ignored.
If after parsing, the value of the border is greater than zero, the border of the input image element is displayed.

  • html/HTMLElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttribute):

  • html/HTMLElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Test border-width-percent was modified with tests for input image element.
Expected results for input-image-alt-test were regenerated since an image input element
takes border attribute into account.
Also, mark the test as failure for chromium.

  • fast/borders/border-width-percent-expected.txt:
  • fast/borders/border-width-percent.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
09:59 Changeset [94424] by rolandsteiner@chromium.org

Implement the Event constructor for V8.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Source/WebCore:

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor
This patch implements the Event constructor for V8 in V8EventConstructors.cpp,
similar to the implementation for JSC in JSEventConstructors.cpp.

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added.

(WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback().

  • dom/Event.idl: Added |V8CustomConstructor|.

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html.
09:50 Changeset [94423] by antonm@chromium.org

[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=67484

Reviewed by Yury Semikhatsky.

No new tests, minor cleanup.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyEnumerator):

09:38 Changeset [94422] by commit-queue@webkit.org

Unreviewed, rolling out r94404.
http://trac.webkit.org/changeset/94404
https://bugs.webkit.org/show_bug.cgi?id=67490

"Patch is wrong, new API needs two reviewers, we are already
working on how to add notifications elsewhere" (Requested by
xan_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • bindings/gobject/GNUmakefile.am:
09:13 Changeset [94421] by andreas.kling@nokia.com

Use fastGetAttribute() and fastHasAttribute() where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=67394

Reviewed by Darin Adler.

Change call sites that don't check the "style" or SVG animatable
attributes to use fastGetAttribute()/fastHasAttribute() instead
of getAttribute()/hasAttribute().

No new tests, this is a minor performance optimization.

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

09:00 Changeset [94420] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=67431

Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two
repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we
handle border radius).

Reviewed by Beth Dakin.

Added fast/borders/border-image-repeat.html.

Source/WebCore:

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Modified the CSSBorderImageValue (you're living on borrowed time, my friend!) to have a CSSValue that
contains a Pair.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForRepeatRule):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for the new properties. Break out the value retrieval for the image repeat rules into its
own function, valueForNinePieceImageRepeat.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitWidth):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modified the parsing of border image to call into parseBorderImageRepeat for the repeat values.

(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
The new parsing code for border-image-repeat is here. It will build up a CSSValue containing a Pair and
return the result.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:

Add the new properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageRepeat):

  • css/CSSStyleSelector.h:

The mapping into the front end is done the same way as border-image-slice. Factor out the image repeat rules
portion into mapNinePieceImageRepeat.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

Add the new 'space' value as a valid image tiling rule. It's not yet supported and, like the 'round' value,
is just mapped to 'repeat' for now.

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::copyRepeatFrom):
Helper for copying only the repeat rules from another NinePieceImage.

LayoutTests:

  • fast/borders/border-image-repeat.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/borders/border-image-repeat-expected.png: Added.
  • platform/mac/fast/borders/border-image-repeat-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
08:57 Changeset [94419] by commit-queue@webkit.org

Source/WebCore: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

Properly render Qt's number input with RTL direction, and fix Plastique styling.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

LayoutTests: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

New baseline for Qt number input with RTL direction.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png:
08:35 Changeset [94418] by commit-queue@webkit.org

Source/WebCore: Resetting media controls when the src is changed from a valid url to an
invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

Test: media/media-controls-invalid-url.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaLoadingFailed):

LayoutTests: Controls not reset when media element url changed from a valid url to an invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

  • media/media-controls-invalid-url-expected.txt: Added.
  • media/media-controls-invalid-url.html: Added.
07:09 Changeset [94417] by commit-queue@webkit.org

[WK2] Anchor elements doesn't get focus on TAB key press.
https://bugs.webkit.org/show_bug.cgi?id=66949

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-02
Reviewed by Adam Roben.

Setting the default property value of TabsToLinks to true
only for GTK platform since Win & Mac platforms doesn't want
it to be set to true by default.

  • Shared/WebPreferencesStore.h:

Set the default value of key TabsToLinks to true for GTK platform only.

07:05 Changeset [94416] by zoltan@webkit.org

[Qt][WK2] 4 tests are failing, skip them
https://bugs.webkit.org/show_bug.cgi?id=67485

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-02

  • platform/qt-wk2/Skipped:
07:02 Changeset [94415] by dominicc@chromium.org

Unreviewed test fix.

Sadly window-property-descriptors enumerates functions in the test
harness. r94362 added a couple of functions, so these results need
to be updated.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
06:22 Changeset [94414] by leandro@webkit.org

Unreviewed build fix after r67110.

  • ewk/ewk_view.cpp:

(ewk_view_need_touch_events_get): Make the function signature match
its declaration.

06:09 Changeset [94413] by reni@webkit.org

[Qt] Two tests are passing after r94324. They are unskipped:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

Unreviewed gardening.

  • platform/qt/Skipped:
05:46 Changeset [94412] by apavlov@chromium.org

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
05:35 Changeset [94411] by kbalazs@webkit.org

[Qt][WK2] Cannot gathering glyph page statistics
https://bugs.webkit.org/show_bug.cgi?id=67475

Rubber stamped by Csaba Osztrogonác.

Fix Qt WK2 build without having QRAWFONT.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

04:49 Changeset [94410] by vsevik@chromium.org

Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/networkPanel.css:

(.resource-headers-view .outline-disclosure li .status-from-cache):

04:41 Changeset [94409] by vsevik@chromium.org

Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):

04:39 Changeset [94408] by vsevik@chromium.org

Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):

04:36 Changeset [94407] by ossy@webkit.org

[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Trivial fix after r94288.

Rubber-stamped by Andras Becsi.

  • Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.

(buildQMakeProject):

04:19 Changeset [94406] by antti@apple.com

De-virtualize recalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=67378

Reviewed by Dimitri Glazkov.

Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will
also make it possible to de-recursify it later.

Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc.
These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Element.h:

(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

  • dom/Node.h:

(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/ShadowRoot.h:
  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didRecalcStyle):

  • html/HTMLFormControlElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willRecalcStyle):

  • html/HTMLFrameSetElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::didRecalcStyle):

  • html/HTMLMediaElement.h:
  • html/HTMLNoScriptElement.cpp:

(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::willRecalcStyle):

  • html/HTMLNoScriptElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::willRecalcStyle):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::didRecalcStyle):

  • svg/SVGUseElement.h:
04:16 Changeset [94405] by yutak@chromium.org

WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Re-lands r94399 with a fix for Leopard builds.

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
04:10 Changeset [94404] by paroga@webkit.org

[GTK] Generate gobject bindings for Notification and NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=67380

Reviewed by Philippe Normand.

  • bindings/gobject/GNUmakefile.am:
03:54 Changeset [94403] by bashi@chromium.org

[chromium] editing/selection/regional-indicators.html timing out on Linux
https://bugs.webkit.org/show_bug.cgi?id=66510

Reviewed by Kent Tamura.

Source/WebCore:

Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly.

No new tests. editing/selection/regional-indicators.html should pass with this patch.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run.
(WebCore::surrogatePairAwareFirstCharacter): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData.

LayoutTests:

ComplexTextControllerLinux is now surrogate pairs aware, therefore;

  • editing/selection/regional-indicators.html should pass.
  • editing/deleting/regional-indicators.html should not timeout.
  • fast/text/regional-indicator-symbols.html should pass.
  • platform/chromium/test_expectations.txt:
03:51 Changeset [94402] by commit-queue@webkit.org

Unreviewed, rolling out r94399.
http://trac.webkit.org/changeset/94399
https://bugs.webkit.org/show_bug.cgi?id=67471

Broke Leopard build (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-empty.html: Removed.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-object.html: Removed.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-empty.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
03:40 Changeset [94401] by commit-queue@webkit.org

Unreviewed, rolling out r94393.
http://trac.webkit.org/changeset/94393
https://bugs.webkit.org/show_bug.cgi?id=67470

It broke Qt-SL build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • WebCore.pro:
03:38 Changeset [94400] by bashi@chromium.org

[Chromium] Webfonts display bold in Windows
https://bugs.webkit.org/show_bug.cgi?id=67387

Uses font's default weight for webfonts by setting FW_DONTCARE.

Reviewed by Kent Tamura.

No new tests. We don't have fonts to test this change.

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight.

03:36 Changeset [94399] by yutak@chromium.org

WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hixie76/send-empty.html

http/tests/websocket/tests/hixie76/send-object.html
http/tests/websocket/tests/hybi/send-blob.html
http/tests/websocket/tests/hybi/send-empty.html
http/tests/websocket/tests/hybi/send-file-blob-fail.html
http/tests/websocket/tests/hybi/send-file-blob.html
http/tests/websocket/tests/hybi/workers/send-blob.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

Fixing code generator did not sound easy, because there are some classes depending on
broken behavior of current code generator (one such example is CanvasRenderingContext2D).
As a temporary workaround, new custom handlers for send() are added.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
A Blob can be deserialized from url, type and size.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
KURL, String and long long (corresponding to url, type and size, respectively) can be passed
safely across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Updated. Added tests to send Blobs.

  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html:

Added. Send three Blobs each of which contains a small binary message.

  • http/tests/websocket/tests/hybi/send-blob_wsh.py:

Added. receive_message() returns a unicode value if the received message was text, or
a str value if the message was binary.

  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:

Added. If we delete a file before reading it, FileReaderLoader reliably fails.

  • http/tests/websocket/tests/hybi/send-file-blob.html:

Added. Create a File and try to send it as a Blob.

  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Added. Same as send-blob.html above.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py:

Added. Same as send-blob_wsh.py above.

  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:

send-file-blob.html and send-file-blob-fail.html depend on availability of File API.

  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
03:21 Changeset [94398] by mrowe@apple.com

<http://webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.

02:58 Changeset [94397] by philn@webkit.org

[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
02:53 Changeset [94396] by abecsi@webkit.org

Remove my old e-mail address and add my new one.

Rubber-stamped by Tor Arne Vestbø.

  • Scripts/webkitpy/common/config/committers.py:
02:33 WebKit Team edited by abecsi@webkit.org
(diff)
02:09 Changeset [94395] by philn@webkit.org

Unreviewed, GTK rebaseline after r94304.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
01:49 Changeset [94394] by reni@webkit.org

[Qt] Update Qt specific expected files after r94304.

Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
01:26 Changeset [94393] by ossy@webkit.org

[Qt][WK2] Unreviewed speculative buildfix.

  • WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES.
01:25 Changeset [94392] by reni@webkit.org

[Qt] Add Qt expecteds for new tests.

Unreviewed gardening.

  • platform/qt/fast/borders/border-image-slices-expected.png: Added.
  • platform/qt/fast/borders/border-image-slices-expected.txt: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
00:58 Changeset [94391] by commit-queue@webkit.org

Unreviewed, rolling out r94389.
http://trac.webkit.org/changeset/94389
https://bugs.webkit.org/show_bug.cgi?id=67468

breaks mac build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
00:41 Changeset [94390] by commit-queue@webkit.org

Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67459

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Tests: fast/eventsource/eventsource-constructor.html

fast/eventsource/eventsource-attribute-listeners.html

  • WebCore.gypi: Removed V8EventSourceConstructor.cpp.
  • WebCore.pro: Removed V8EventSourceConstructor.cpp.
  • bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
  • page/EventSource.idl: Added the 'Constructor' extended attribute.
00:35 Changeset [94389] by philn@webkit.org

[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
00:32 Changeset [94388] by philn@webkit.org

[GTK] run-gtk-tests leaves a zombie Xvfb process
https://bugs.webkit.org/show_bug.cgi?id=67389

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests: Properly close STDIN and STDERR on the child process instead of doing shell redirection.
Note: See TracTimeline for information about the timeline view.