Timeline



Sep 19, 2011:

11:33 PM Changeset in webkit [95517] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

  • platform/mac/DisplaySleepDisabler.h:
9:33 PM Changeset in webkit [95516] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Darin Adler.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
9:30 PM Changeset in webkit [95515] by ggaren@apple.com
  • 1 edit in trunk/Source/cmake/OptionsWinCE.cmake

Removing one last case of DENABLE_JSC_MULTIPLE_THREADS -- the cmake folder doesn't seem to have a ChangeLog

9:24 PM Changeset in webkit [95514] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

Missed this one case before.

  • features.gypi:
9:14 PM Changeset in webkit [95513] by mrowe@apple.com
  • 11 edits
    2 copies in trunk/Source

<http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect

On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
a NoIdleSleep assertion as the latter is implied by the former.

Source/WebCore:

Since there were multiple copies of the same code to disable display sleep spread across WebCore, WebKit and WebKit2
this patch takes the approach of moving this functionality to a new DisplaySleepDisabler class that lives in WebCore.
A class is used as it makes it easier to reason about the lifetime of the assertions and to ensure that the assertions will
always be released when their owning objects go away.

Reviewed by Dan Bernstein.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler): Register for the NoDisplaySleep assertion, and start our
system activity timer when on Leopard.
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): Unregister for the assertion.
(WebCore::DisplaySleepDisabler::systemActivityTimerFired): Call UpdateSystemActivity to prevent the screensaver from
triggering on Leopard.

  • platform/mac/DisplaySleepDisabler.h:

(WebCore::DisplaySleepDisabler::create):

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController setupVideoOverlay:]): Remove the now-unnecessary explicit use of the WebCore namespace.
(-[WebVideoFullscreenController mediaElement]): Ditto.
(-[WebVideoFullscreenController setMediaElement:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Ditto.
(-[WebVideoFullscreenController updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit/mac:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController dealloc]):
(-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit2:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WKFullScreenWindowController.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own. Also adds a FIXME about an error that was noticed while working in this code.

9:05 PM Changeset in webkit [95512] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed ENABLE_LAZY_BLOCK_FREEING and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68424

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

  • heap/Heap.h:
  • wtf/Platform.h:
8:55 PM Changeset in webkit [95511] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_WTF_MULTIPLE_THREADS and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68423

As discussed on webkit-dev. All ports build with threads enabled in WTF now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • wtf/CryptographicallyRandomNumber.cpp:

(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):

  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::pow5mult):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

8:35 PM Changeset in webkit [95510] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Sam Weinig.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

  • API/JSContextRef.cpp:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::gatherConservativeRoots):

  • heap/MachineStackMarker.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):
(JSC::initializeThreading):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/JSLock.cpp:
  • runtime/Structure.cpp:
  • wtf/Platform.h:
7:48 PM Changeset in webkit [95509] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element (any immediate child of render view with a render layer)
since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

  • editing/selection/click-on-body-margin-expected.txt: Added.
  • editing/selection/click-on-body-margin.html: Added.
  • editing/selection/click-on-head-margin-expected.txt: Added.
  • editing/selection/click-on-head-margin.html: Added.
7:07 PM Changeset in webkit [95508] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Ask for audio hardware buffer size instead of using hardwired constants.
https://bugs.webkit.org/show_bug.cgi?id=67952

Patch by Raymond Toy <Raymond Toy> on 2011-09-19
Reviewed by Kenneth Russell.

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::audioHardwareBufferSize): Declare
new member function audioHardwareBufferSize.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Call audioHardwareBufferSize() to get buffer size; update
m_callbackBuffersize and m_renderCountPerCallback appropriately.
Remove global variables callbackBufferSize and
renderCountPerCallback. Add constant for maximum
allowed buffer size and verify we don't exceed it.
(WebCore::AudioDestinationChromium::render): Use new member
variables instead of globals.

  • src/AudioDestinationChromium.h:

Define new member variables m_callbackBufferSize and
m_renderCountPerCallback

6:53 PM Changeset in webkit [95507] by commit-queue@webkit.org
  • 15 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r95493 and r95496.
http://trac.webkit.org/changeset/95493
http://trac.webkit.org/changeset/95496
https://bugs.webkit.org/show_bug.cgi?id=68418

Broke Windows build (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/JavaScriptCore:

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Removed.
  • heap/AllocationSpace.h: Removed.
  • heap/Heap.cpp:

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

Source/WebCore:

  • ForwardingHeaders/heap/AllocationSpace.h: Removed.
6:49 PM Changeset in webkit [95506] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

6:44 PM Changeset in webkit [95505] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, missed stylebot comments in last commit.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

6:41 PM Changeset in webkit [95504] by barraclough@apple.com
  • 9 edits
    3 adds in trunk

String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::jsStringWithReuse):

  • added helper function to reuse original JSString value.

(JSC::stringProtoFuncSplit):

  • Rewritten from the spec.
  • tests/mozilla/ecma/String/15.5.4.8-2.js:

(getTestCases):

  • This test is not ES5 compliant.

LayoutTests:

  • fast/js/script-tests/string-split-conformance.js: Added.
  • fast/js/string-split-conformance-expected.txt: Added.
  • fast/js/string-split-conformance.html: Added.
    • Added new Layout test based on:

http://stevenlevithan.com/demo/split.cfm

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T7-expected.txt:
6:21 PM Changeset in webkit [95503] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Removed lots of friend declarations from JSCell, so we can more
effectively make use of private and protected.

Reviewed by Sam Weinig.

  • runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of

confusion for not much safety.
(JSC::JSCell::operator new): Made this public because it is used by a
few clients, and not really dangerous.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasCustomProperties):
(JSC::JSObject::hasGetterSetterProperties):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::finishCreation):
(JSC::JSObject::prototype):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
structure() / setStructure(), so we don't have to be a friend of JSCell.

  • runtime/Structure.h:

(JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
to JSCell::m_structure.

6:20 PM Changeset in webkit [95502] by macpherson@chromium.org
  • 17 edits in trunk/Source/WebCore

Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType.
https://bugs.webkit.org/show_bug.cgi?id=68057

Reviewed by Darin Adler.

There appear to be many cases where -1 is actually a valid Length.
Encoding the validity of Length separately to the value is a natural solution.

No new tests / no behavioral changes.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

  • platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::value):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialMaxSize):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):

6:04 PM Changeset in webkit [95501] by abarth@webkit.org
  • 33 edits in trunk

Always enable ENABLE(EVENTSOURCE)
https://bugs.webkit.org/show_bug.cgi?id=68414

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

EventSource seems to be here to stay. This patch makes WebKit more
hackable by removing this ENABLE macro, as discussed on webkit-dev.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • features.pri:
  • page/DOMWindow.idl:
  • page/EventSource.cpp:
  • page/EventSource.h:
  • page/EventSource.idl:
  • workers/WorkerContext.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
5:56 PM Changeset in webkit [95500] by levin@chromium.org
  • 4 edits in trunk/Tools

Sheriffbot rollout should be more intuitive.
https://bugs.webkit.org/show_bug.cgi?id=68415

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args and a few others cases.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
5:38 PM Changeset in webkit [95499] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
https://bugs.webkit.org/show_bug.cgi?id=68391

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py: Skip asm lines when doing style checks on a line.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
5:35 PM Changeset in webkit [95498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Enable JSC_MULTIPLE_THREADS for OS(QNX).
https://bugs.webkit.org/show_bug.cgi?id=68047

Patch by Eli Fidler <efidler@rim.com> on 2011-09-19
Reviewed by Daniel Bates.

SA_RESTART was required for SIGUSR2-based debugging, but is not
present on QNX. This debugging doesn't seem critical to
JSC_MULTIPLE_THREADS, so allow it to proceed.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

  • wtf/Platform.h: enable PTHREADS for OS(QNX)
5:19 PM Changeset in webkit [95497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a use-after-free: clear the fullscreen change event target queue at
detach time, rather than at destruction time. If this isn't done, it's
possible for the event target queue to be the only thing that
references the document. Then when the document is popped off the queue
and dereferenced in Document::fullScreenChangeDelayTimerFired, the
document is destroyed and the subsequent access to
m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

4:50 PM Changeset in webkit [95496] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

4:49 PM Changeset in webkit [95495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Suppress flakey test on windows in Chromium gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=68408

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

4:48 PM Changeset in webkit [95494] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r95482.
http://trac.webkit.org/changeset/95482
https://bugs.webkit.org/show_bug.cgi?id=68410

Broke chromium webkit-tests (Requested by dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
4:15 PM Changeset in webkit [95493] by oliver@apple.com
  • 14 edits
    3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

  • heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

  • ForwardingHeaders/heap/AllocationSpace.h: Added.
4:13 PM Changeset in webkit [95492] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Unreviewed coding style fix.

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qweberror.h:
4:04 PM Changeset in webkit [95491] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Expose AXObjectCache methods so that WebAccessibilityCache
can be deleted.
https://bugs.webkit.org/show_bug.cgi?id=68225

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-19
Reviewed by Dimitri Glazkov.

This patch exposes the functionality needed from AXObjectCache
with new methods in WebAccessibilityObject and WebDocument.
Next, Chromium will be updated to use only these methods and
not WebAccessibilityCache. Then, WebAccessibilityCache can be
deleted from WebKit.

  • public/WebAccessibilityObject.h:
  • public/WebDocument.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::enableAccessibility):
(WebKit::WebAccessibilityObject::accessibilityEnabled):
(WebKit::WebAccessibilityObject::axID):

  • src/WebDocument.cpp:

(WebKit::WebDocument::accessibilityObject):
(WebKit::WebDocument::accessibilityObjectFromID):

4:02 PM Changeset in webkit [95490] by bbudge@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Perform HTTP method and header validation in AssociatedURLLoader for
requests coming from untrusted code (eg. Native Client in Chrome). Use
the same code as XMLHttpRequest to reduce code duplication and have
behavior identical to XHR in Javascript. Add an 'untrustedHTTP' option
to WebURLLoaderOptions, which AssociatedURLLoader can use to determine
if it should check the request method and headers.
https://bugs.webkit.org/show_bug.cgi?id=67655

Reviewed by Darin Fisher.

  • public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::setDelayedError):
(WebKit::AssociatedURLLoader::loadAsynchronously):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckFails):
(WebKit::TEST_F):

3:57 PM Changeset in webkit [95489] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

[V8] document.all gets confused about its prototype chain
https://bugs.webkit.org/show_bug.cgi?id=68393

Reviewed by Eric Seidel.

Source/WebCore:

GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
not a good idea to use its return value. It turns out that all the
callers of the API only cared about whether it returns a null handle.

Test: http/tests/security/document-all.html

  • bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

LayoutTests:

Test how document.all behaves when you change its prototype chain.

  • http/tests/security/document-all-expected.txt: Added.
  • http/tests/security/document-all.html: Added.
3:56 PM Changeset in webkit [95488] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

Named property confusion with proto
https://bugs.webkit.org/show_bug.cgi?id=68221

Reviewed by Eric Seidel.

Source/WebCore:

The proto property is super magical because it's not a real named
property and it has higher precedence than even interceptors. This
confuses this check, which is meant to detech which names will get
handled by our interceptor.

Test: http/tests/security/window-named-proto.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

LayoutTests:

  • http/tests/security/resources/innocent-victim-with-iframe.html: Added.
  • http/tests/security/window-named-proto-expected.txt: Added.
  • http/tests/security/window-named-proto.html: Added.
3:54 PM Changeset in webkit [95487] by abarth@webkit.org
  • 9 edits in trunk/Source

Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
https://bugs.webkit.org/show_bug.cgi?id=68292

Reviewed by Eric Seidel.

Source/WebCore:

OpenType Sanitizer is a library for sanitizing type and not a feature.
Therefore this macro should say that we USE the library.

  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/WOFFFileFormat.h:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/opentype/OpenTypeSanitizer.cpp:
  • platform/graphics/opentype/OpenTypeSanitizer.h:
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Source/WebKit/chromium:

  • features.gypi:
3:53 PM Changeset in webkit [95486] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.
3:32 PM Changeset in webkit [95485] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.

3:27 PM Changeset in webkit [95484] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

DFG speculation failures should act as additional value profiles
https://bugs.webkit.org/show_bug.cgi?id=68335

Reviewed by Oliver Hunt.

This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.

This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.

By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.

This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::linkDummySlowCase):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

  • jit/JITInlineMethods.h:

(JSC::JIT::addSlowCase):

3:26 PM Changeset in webkit [95483] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r95385 and r95457.
http://trac.webkit.org/changeset/95385
http://trac.webkit.org/changeset/95457
https://bugs.webkit.org/show_bug.cgi?id=68395

Broke chromium browser_tests (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

  • tests/data/context_notifications_test.html: Removed.
  • tests/data/context_notifications_test_frame.html: Removed.
3:23 PM Changeset in webkit [95482] by commit-queue@webkit.org
  • 5 edits in trunk

Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
3:20 PM Changeset in webkit [95481] by Adam Roben
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Let Xcode 4 do its thang with ANGLE.xcodeproj

  • ANGLE.xcodeproj/project.pbxproj:
3:20 PM Changeset in webkit [95480] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r94575

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp

now builds just before FindSafari.

2:56 PM Changeset in webkit [95479] by cmarrin@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-09-19 Chris Marrin <cmarrin@apple.com>

Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Reviewed by Adam Roben.


Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.


This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.

This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
  • platform/win/StructuredExceptionHandlerSupressor.h: Added. (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor): (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):
2:51 PM Changeset in webkit [95478] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect selection with absolutely positioned div
https://bugs.webkit.org/show_bug.cgi?id=39503

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
whether a given point is inside or below the last child box.

Fixed the bug by using the last hit-test candidate instead.

Test: editing/selection/block-with-positioned-lastchild.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Added a regression test for placing the caret inside a block with multiple logical lines
with an absolutely positioned last child. WebKit should place the caret on the left of the first line
(instead of after the last line) when the user clicks on the left of the first line.

  • editing/selection/block-with-positioned-lastchild-expected.txt: Added.
  • editing/selection/block-with-positioned-lastchild.html: Added.
2:48 PM Changeset in webkit [95477] by inferno@chromium.org
  • 1 edit
    15 adds in trunk/LayoutTests

Unreviewed. Chromium Rebaselines for r95461.

  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.
2:47 PM Changeset in webkit [95476] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix crashes when running WebKit1 tests.

-[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
equivalent code directly into -[WebHTMLView drawRect:].

  • WebView/WebHTMLView.mm:

(-[WebHTMLView drawRect:]):

  • WebView/WebViewInternal.h:
2:28 PM Changeset in webkit [95475] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95466.
http://trac.webkit.org/changeset/95466
https://bugs.webkit.org/show_bug.cgi?id=68389

Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toPrimitive):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
2:25 PM Changeset in webkit [95474] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Remove the last remains of viewless WebKit1
https://bugs.webkit.org/show_bug.cgi?id=68388

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::forceLayoutForNonHTML):
Remove null check.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove usesDocumentViews parameter and checks.

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
Add an assertion that usesDocumentViews is always true.

(-[WebView _isUsingAcceleratedCompositing]):
Remove usesDocumentViews check.

(-[WebView _isSoftwareRenderable]):
Remove usesDocumentViews check.

(-[WebView initWithFrame:frameName:groupName:]):
Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.

(-[WebView initWithCoder:]):
Remove usesDocumentViews parameter.

(-[WebView _frameViewAtWindowPoint:]):
Remove usesDocumentViews check.

  • WebView/WebViewData.h:

Remove usesDocumentViews ivar.

  • WebView/WebViewPrivate.h:

Remove usesDocumentViews parameters.

2:10 PM Changeset in webkit [95473] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/loader

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
BUG=86758
Review URL: http://codereview.chromium.org/7945015

2:09 PM Changeset in webkit [95472] by alexis.menard@openbossa.org
  • 12 edits in trunk/Source/WebKit2

[Qt][WK2] Make loading errors API easier to use.
https://bugs.webkit.org/show_bug.cgi?id=68357

Reviewed by Tor Arne Vestbø.

Make the API to get loading errors easier to use. 95197 introduced
a QJSValue API that is a bit opaque for the client code. Rather than
using a dedicated object, we can just pass the needed information as
parameters of the slot.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
2:05 PM Changeset in webkit [95471] by dimich@chromium.org
  • 5 edits
    4 adds in trunk

[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):

  • html/HTMLFrameElementBase.h:

LayoutTests:

  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
  • fast/frames/iframe-reparenting-embed-elements.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.
1:55 PM Changeset in webkit [95470] by andersca@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit

Remove WebViewEventHandling.mm
https://bugs.webkit.org/show_bug.cgi?id=68387

Reviewed by Adam Roben.

../..:

Remove WebViewEventHandling.mm from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

../../mac:

WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
we're getting rid of viewless WebKit1.

  • WebView/WebView.mm:

(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewEventHandling.mm: Removed.
  • WebView/WebViewInternal.h:
1:52 PM Changeset in webkit [95469] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95461 - Child not placed correctly when beforeChild (table part)
has both :before, :after content.
BUG=95520
Review URL: http://codereview.chromium.org/7946014

1:48 PM Changeset in webkit [95468] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: http://codereview.chromium.org/7941019

1:39 PM Changeset in webkit [95467] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
https://bugs.webkit.org/show_bug.cgi?id=68385

Reviewed by Adam Roben.

Move these functions back into the respective clients and remove usesDocumentViews checks.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setToolTip):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::respondToChangedSelection):

  • WebView/WebView.mm:
  • WebView/WebViewEventHandling.mm:
  • WebView/WebViewInternal.h:
1:32 PM Changeset in webkit [95466] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Geoffrey Garen.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:

(JSC::JSValue::toPrimitive):

1:27 PM Changeset in webkit [95465] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Begin removing -[WebView _usesDocumentCalls] from WebView.mm
https://bugs.webkit.org/show_bug.cgi?id=68383

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebView/WebView.mm:

(-[WebView selectedFrame]):
(-[WebView setHostWindow:]):
(-[WebView acceptsFirstResponder]):
(-[WebView becomeFirstResponder]):
(-[WebView _webcore_effectiveFirstResponder]):
(-[WebView setNextKeyView:]):
(-[WebView setHoverFeedbackSuspended:]):

1:22 PM Changeset in webkit [95464] by levin@chromium.org
  • 1 edit in branches/chromium/874/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

  • src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7942006

1:20 PM Changeset in webkit [95463] by levin@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/platform

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

  • platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

  • platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7946013

1:20 PM Changeset in webkit [95462] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

1) Change fromBeforeChild to beforeChild to match
webkit rendering naming conventions.
2) Add assert to verify ruby base is indeed emptied
after collecting all children in a single base.
3) Fix condition in mergeBlockChildren to bail out only
when we have no children and there is no work to merge
children to toBase.

Test: fast/ruby/ruby-overhang-crash.html

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

ASSERTION FAILED: !needsLayout() in RenderRubyRun::getOverhang.

  • fast/ruby/ruby-overhang-crash-expected.txt: Added.
  • fast/ruby/ruby-overhang-crash.html: Added.
1:17 PM Changeset in webkit [95461] by inferno@chromium.org
  • 8 edits
    15 adds in trunk

Child not placed correctly when beforeChild (table part)
has both :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/table/table-cell-before-after-content-around-table-block.html

fast/table/table-cell-before-after-content-around-table-row.html
fast/table/table-cell-before-after-content-around-table.html
fast/table/table-row-before-after-content-around-block.html
fast/table/table-row-before-after-content-around-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  1. Use the new helper functions findAfterContentRenderer, anonymousContainer.
  2. Rename anonymousChild to better name - beforeChildAnonymousContainer.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
When adding a new child, if beforeChild is a table part(
Table/TableSection/TableRow), we need to check if both
:before, :after content are shoved in one of the anonymous child.
If yes, we need to split the :before, :after content before adding
newChild. Easiest approach is to destroy the :before content, then add
the newChild and then call updateBeforeAfterContent to recreate the
:before content.

  • rendering/RenderObject.h:

(WebCore::RenderObject::findBeforeContentRenderer): same as
beforePseudoElementRenderer, but ignores text childs since they are
sequentially added.
(WebCore::RenderObject::findAfterContentRenderer): same.
(WebCore::RenderObject::anonymousContainer):
(WebCore::objectIsRelayoutBoundary):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): use the new helpers and functionally
correct functions - findAfterContentRenderer, anonymousContainer. previous
implementation was wrong since it would not go inside, if :after content
is embedded deeper than one level.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): same.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): same.

LayoutTests:

  • fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-block.html: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row.html: Added.
  • fast/table/table-cell-before-after-content-around-table.html: Added.
  • fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-block.html: Added.
  • fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • fast/table/table-row-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-table.html: Added.
1:09 PM Changeset in webkit [95460] by abarth@webkit.org
  • 1 edit in branches/chromium/874/Source/WebCore/loader/FrameLoader.cpp

Manual merge of 94902 to 874 branch.

1:07 PM Changeset in webkit [95459] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::hasHTMLView):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):

  • WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _hasSelection]):
(-[WebFrame _clearSelection]):
(-[WebFrame _shouldFlattenCompositingLayers:]):
(-[WebFrame _dragSourceEndedAt:operation:]):
(-[WebFrame frameView]):

12:46 PM Changeset in webkit [95458] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews]
https://bugs.webkit.org/show_bug.cgi?id=68377

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::windowResizerRect):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::screenToWindow):
(WebChromeClient::windowToScreen):
(WebChromeClient::platformPageClient):
(WebChromeClient::scrollRectIntoView):
(WebChromeClient::print):

  • WebView/WebDataSource.mm:

(-[WebDataSource _receivedData:]):

12:44 PM Changeset in webkit [95457] by aa@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

r95385 broke Chromium. Fix it.
https://bugs.webkit.org/show_bug.cgi?id=68378

Unreviewed, build fix.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

12:38 PM Changeset in webkit [95456] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, build fix

It's not enough to disable clang plugins.

  • gyp_webkit:
12:33 PM Changeset in webkit [95455] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

12:19 PM Changeset in webkit [95454] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Disable clang when building chromium in WebKit
https://bugs.webkit.org/show_bug.cgi?id=68343

Reviewed by Adam Barth.

  • DEPS:
  • gyp_webkit:
12:14 PM Changeset in webkit [95453] by oliver@apple.com
  • 9 edits
    1 move
    1 add
    1 delete in trunk/Source/JavaScriptCore

Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=68376

Reviewed by Gavin Barraclough.

Renamed the the MarkedSpace files to match new name, and
updated the relevant references.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • runtime/JSCell.h:
12:13 PM Changeset in webkit [95452] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Gesture recognizer fires taptype only every other touch
down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. This change simplifies the logic
and handles all outgoing edges.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::click):

  • platform/chromium/GestureRecognizerChromium.h:

Source/WebKit/chromium:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. Thsi change simplifies the logic
and handles all outgoing edges.

  • tests/InnerGestureRecognizerTest.cpp:

Additional tests added to ensure that all edges in the state
machine are accounted for.
(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TEST_F):

11:59 AM Changeset in webkit [95451] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
and the HTMLParser interact more closely with each other. HTMLParser should be
setting the end range for the token itself to account for buffering that the
HTMLSourceTracker can't know about, but there are a lot of paths that would need
updating. First step is to cover this one path.
https://bugs.webkit.org/show_bug.cgi?id=68281

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::end):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html: Added.
11:54 AM Changeset in webkit [95450] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Rename NewSpace to MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=68375

Reviewed by Gavin Barraclough.

Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • heap/NewSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/NewSpace.h:

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

11:45 AM Changeset in webkit [95449] by commit-queue@webkit.org
  • 51 edits in trunk/Source

TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-19
Reviewed by Adam Barth.

Source/JavaScriptCore:

  • parser/SourceProvider.h:

(JSC::SourceProvider::startPosition):

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):

Source/WebCore:

No new tests because this patch is not changing behavior.

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::update):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerLineNumber):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::startPosition):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

  • dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

  • dom/ScriptElement.h:
  • dom/ScriptableDocumentParser.h:
  • dom/ViewportArguments.cpp:

(WebCore::parserLineNumber):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLInputStream.h:
  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::runScript):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::uninitializedPositionValue1):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):

  • platform/text/SegmentedString.h:
  • svg/SVGDocumentExtensions.cpp:

(WebCore::parserLineNumber):

  • xml/XMLErrors.cpp:

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):

  • xml/XMLErrors.h:
  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::lineNumber):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):

11:36 AM Changeset in webkit [95448] by mitz@apple.com
  • 28 edits
    6 moves
    1 add
    2 deletes in trunk/Source

Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):

Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
Renamed CascadeList to WebCascadeList.
Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
Renamed LanguageChangeObserver to WebLanguageChangeObserver.
Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.

  • WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/mac/AccessibilityObjectWrapper.h: Removed.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.

(convertToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/mac/Language.mm:

(WebCore::platformDefaultLanguage):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::startObservingCookieChanges):

Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.

  • English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
  • English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:

Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed NonBlockingPanel to WebNonBlockingPanel.
Renamed ThreadEnabler to WebCocoaThreadingEnabler.
Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.

  • Misc/WebIconDatabase.mm:

(+[WebCocoaThreadingEnabler enableThreading]):
(importToWebCoreFormat):

  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
  • Panels/WebAuthenticationPanel.h:
  • Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to

WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
cause nightly builds to log an error message when showing the Safari
HTTP authentication sheet and disable the Quit command while the sheet
is disaplyed.

  • WebView/WebPDFView.mm:

(-[WebPDFView initWithFrame:]):
(-[WebPDFView _updatePreferencesSoon]):

Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::accessibilityRemoteObject):

  • WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.

(+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::fullKeyboardAccessEnabled):

11:30 AM Changeset in webkit [95447] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove direct property slot pointers from the instruction stream
https://bugs.webkit.org/show_bug.cgi?id=68373

Reviewed by Gavin Barraclough.

Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream. This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

  • runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyStorage):

11:29 AM Changeset in webkit [95446] by alexis.menard@openbossa.org
  • 3 edits in trunk/Tools

Style checker should not check public Qt WK2 API for parameter_name.
https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
11:27 AM Changeset in webkit [95445] by caryclark@google.com
  • 3 edits in trunk/Source/WebCore

Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
https://bugs.webkit.org/show_bug.cgi?id=68358

Reviewed by Dan Bernstein.

No new tests.

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.

11:18 AM Changeset in webkit [95444] by commit-queue@webkit.org
  • 5 edits in trunk

GTK DRT leaks memory while comparing history items
https://bugs.webkit.org/show_bug.cgi?id=68086

Source/WebKit/gtk:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() function returns a g_strdup()'d
string, so it should return "gchar*" instead of "const gchar*".

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_get_target): Change return type to "gchar*".

  • webkit/webkitwebhistoryitemprivate.h: Ditto.

Tools:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() returns a g_strdup()'d string,
so memory must be freed before compareHistoryItems() returns.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(compareHistoryItems): Use GOwnPtr to manage memory automatically.

11:16 AM Changeset in webkit [95443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Fix paths used by update-po, and avoid changing directory
unnecessarily.

[GTK] make update-po is b0rked
https://bugs.webkit.org/show_bug.cgi?id=68352

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-09-19
Reviewed by Martin Robinson.

  • GNUmakefile.am:
11:12 AM Changeset in webkit [95442] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectations and file WK68372.

  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [95441] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11:00 AM Changeset in webkit [95440] by jberlin@webkit.org
  • 6 edits
    2 adds in trunk

Sites that use history pushState or replaceState are recorded in history in Private Browsing
mode.
https://bugs.webkit.org/show_bug.cgi?id=68208

Reviewed by Brady Eidson.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.

Add the privateBrowsingEnabled check that is used in other places in HistoryController
before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

Tools:

Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.

  • TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.

(TestWebKitAPI::didNavigateWithNavigationData):
This is a context history client callback, so it should not be called when in Private
Browsing. Add a call to FAIL().
(TestWebKitAPI::didSameDocumentNavigationForFrame):
This is a page load client callback that happens after the didNavigateWithNavigationData
callback. End the test.
(TestWebKitAPI::TEST):
Enable Private Browsing and load a page that uses history.pushState.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.

  • TestWebKitAPI/Tests/WebKit2/push-state.html: Added.

Ditto.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

  • TestWebKitAPI/win/copy-resources.cmd:

Ditto.

10:41 AM Changeset in webkit [95439] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove bump allocator
https://bugs.webkit.org/show_bug.cgi?id=68370

Reviewed by Sam Weinig.

Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code. Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::allocate):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):

  • runtime/StorageBarrier.h:

(JSC::StorageBarrier::set):

10:34 AM Changeset in webkit [95438] by dslomov@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline expectations due to r95402.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
10:18 AM Changeset in webkit [95437] by leandro@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed: ScrollbarThemeMock.cpp is already referenced in the
global CMakeLists.txt.

  • CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp.
  • CMakeListsWinCE.txt: Ditto.
10:14 AM Changeset in webkit [95436] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
https://bugs.webkit.org/show_bug.cgi?id=67938

Reviewed by Andreas Kling.

Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
explicitly avoids running a nested mainloop.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Since we don't run a nested mainloop, we need to keep the client pointer to call
valueChangedForPopupMenu().

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.

(WebKit::WebPopupMenuProxyQtDesktop::create):

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • WebKit2.pro:
10:13 AM Changeset in webkit [95435] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124
BUG=96150
Review URL: http://codereview.chromium.org/7945008

10:12 AM Changeset in webkit [95434] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984
BUG=96150
Review URL: http://codereview.chromium.org/7944005

10:09 AM Changeset in webkit [95433] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/css/CSSPrimitiveValue.cpp

Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
BUG=60653
Review URL: http://codereview.chromium.org/7941005

10:07 AM Changeset in webkit [95432] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/accessibility

Merge 94716
BUG=84160
Review URL: http://codereview.chromium.org/7944004

10:05 AM Changeset in webkit [95431] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Merge 94864
BUG=84885
Review URL: http://codereview.chromium.org/7948002

10:02 AM Changeset in webkit [95430] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95054
BUG=92226

9:58 AM Changeset in webkit [95429] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore

Merge 94905
BUG=1092
Review URL: http://codereview.chromium.org/7942002

9:54 AM Changeset in webkit [95428] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 94991
BUG=94810
Review URL: http://codereview.chromium.org/7943004

9:52 AM Changeset in webkit [95427] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95301
BUG=95072
Review URL: http://codereview.chromium.org/7947002

9:49 AM Changeset in webkit [95426] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp

Merge 94857
BUG=95672
Review URL: http://codereview.chromium.org/7946005

9:47 AM Changeset in webkit [95425] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95204
BUG=95761
Review URL: http://codereview.chromium.org/7950001

9:43 AM Changeset in webkit [95424] by inferno@chromium.org
  • 5 edits in branches/chromium/874/Source/WebCore

Merge 95093
BUG=96170
Review URL: http://codereview.chromium.org/7945005

9:42 AM Changeset in webkit [95423] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95074
BUG=96444
Review URL: http://codereview.chromium.org/7945004

9:40 AM Changeset in webkit [95422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r95416.
http://trac.webkit.org/changeset/95416
https://bugs.webkit.org/show_bug.cgi?id=68367

Broke chromium-mac (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
9:38 AM Changeset in webkit [95421] by inferno@chromium.org
  • 2 edits in branches/chromium/874

Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/7948001

9:35 AM Changeset in webkit [95420] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp

Merge 94820 - REGRESSION (r66874): Missing RefPtr in ScriptController
BUG=95669
Review URL: http://codereview.chromium.org/7946004

9:33 AM Changeset in webkit [95419] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore

Merge 94608 - MediaElementAudioSourceNode destruction triggers ASSERTS
https://bugs.webkit.org/show_bug.cgi?id=67665
BUG=94186
Review URL: http://codereview.chromium.org/7947001

9:26 AM Changeset in webkit [95418] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.

  • platform/win/Skipped:
9:22 AM Changeset in webkit [95417] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68346

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-19
Reviewed by Philippe Normand.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebKit/gtk:

  • tests/testmimehandling.c: Remove ogg tests, since the behavious

has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
(server_callback):
(mime_type_policy_decision_requested_cb):
(main):

  • webkit/webkitwebplugin.cpp: Fix introspection annotation.
9:07 AM Changeset in webkit [95416] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
8:15 AM Changeset in webkit [95415] by loislo@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed fix for flaky tests.

  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
  • platform/qt/Skipped:
7:45 AM Changeset in webkit [95414] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68360

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-19

  • platform/qt/Skipped:
7:23 AM Changeset in webkit [95413] by Ademar Reis
  • 2 edits in trunk/Source/WebCore

Unreviewed: dos2unix on bindings/js/JSExceptionBase.h

Visual Studio is choking on this file when generating packages for
Qt-4.8 on Windows:

"""
Source\WebCore\Bindings\js\JSExceptionBase.h:
error C4335: Mac file format detected: please convert the source file
to either DOS or UNIX format
"""

Since from all .cpp or .h files shared by all ports this is the only
one with CRLF line terminations, I'm assuming this was a mistake.

  • bindings/js/JSExceptionBase.h:
7:09 AM Changeset in webkit [95412] by kbalazs@webkit.org
  • 1 edit
    240 adds in trunk/LayoutTests

[Qt][WK2] Add some pixel baselines.

Unreviewed expectation update.

These baselines was produced in the same environment where the
Szeged WK2 bot runs. The validity of the results had been checked manually.

  • platform/qt-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c24-first-lttr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t060401-c32-cascading-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-01-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-01-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-03-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-00-a-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1601-c547-indent-01-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-33-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-35-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize16-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/014-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/016-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/white-space-pre-wraps-expected.png: Added.
  • platform/qt-wk2/fast/block/float/003-expected.png: Added.
  • platform/qt-wk2/fast/block/float/020-expected.png: Added.
  • platform/qt-wk2/fast/block/float/021-expected.png: Added.
  • platform/qt-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt-wk2/fast/block/float/nopaint-after-layer-destruction2-expected.png: Added.
  • platform/qt-wk2/fast/block/float/width-update-after-clear-expected.png: Added.
  • platform/qt-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto-height-with-top-and-bottom-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto/005-expected.png: Added.
  • platform/qt-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-fit-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-01-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-02-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-03-expected.png: Added.
  • platform/qt-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt-wk2/fast/canvas/arc360-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/qt-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt-wk2/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/qt-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/012-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/013-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-order-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
  • platform/qt-wk2/fast/css/004-expected.png: Added.
  • platform/qt-wk2/fast/css/005-expected.png: Added.
  • platform/qt-wk2/fast/css/MarqueeLayoutTest-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers2-expected.png: Added.
  • platform/qt-wk2/fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • platform/qt-wk2/fast/css/begin-end-contain-selector-empty-value-expected.png: Added.
  • platform/qt-wk2/fast/css/css1_forward_compatible_parsing-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-modsel-22-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-nth-child-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-detach-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-hover-expected.png: Added.
  • platform/qt-wk2/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/qt-wk2/fast/css/hsl-color-expected.png: Added.
  • platform/qt-wk2/fast/css/inline-properties-important-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-2-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-expected.png: Added.
  • platform/qt-wk2/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/qt-wk2/fast/css/outline-auto-location-expected.png: Added.
  • platform/qt-wk2/fast/css/selector-set-attribute-expected.png: Added.
  • platform/qt-wk2/fast/css/text-align-expected.png: Added.
  • platform/qt-wk2/fast/css/textCapitalizeEdgeCases-expected.png: Added.
  • platform/qt-wk2/fast/css/zoom-font-size-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/qt-wk2/fast/dom/children-nodes-expected.png: Added.
  • platform/qt-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
  • platform/qt-wk2/fast/dom/css-rule-functions-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-selects-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/qt-wk2/fast/forms/minWidthPercent-expected.png: Added.
  • platform/qt-wk2/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/qt-wk2/fast/gradients/radial-centered-expected.png: Added.
  • platform/qt-wk2/fast/html/details-writing-mode-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-with-layers-expected.png: Added.
  • platform/qt-wk2/fast/lists/001-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/007-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/008-vertical-expected.png: Added.
  • platform/qt-wk2/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/qt-wk2/fast/multicol/client-rects-expected.png: Added.
  • platform/qt-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt-wk2/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt-wk2/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt-wk2/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/qt-wk2/fast/overflow/table-overflow-float-expected.png: Added.
  • platform/qt-wk2/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/qt-wk2/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/qt-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selected-replaced-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/qt-wk2/fast/replaced/001-expected.png: Added.
  • platform/qt-wk2/fast/replaced/002-expected.png: Added.
  • platform/qt-wk2/fast/replaced/003-expected.png: Added.
  • platform/qt-wk2/fast/replaced/005-expected.png: Added.
  • platform/qt-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.
6:33 AM Changeset in webkit [95411] by loislo@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Web Inspector: extend UI perf tests coverage. Elements Panel.
https://bugs.webkit.org/show_bug.cgi?id=68263

Reviewed by Pavel Feldman.

  • inspector/performance/resources/show-panel-elements.html: Added.
6:32 AM Changeset in webkit [95410] by loislo@chromium.org
  • 5 edits
    4 adds in trunk

Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
  • inspector/timeline/timeline-dom-content-loaded-event.html: Added.
  • inspector/timeline/timeline-load-event-expected.txt: Added.
  • inspector/timeline/timeline-load-event.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

6:04 AM Changeset in webkit [95409] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=66543

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2011-08-31
Reviewed by Gustavo Noronha.

  • uk.po: updated.
6:04 AM Changeset in webkit [95408] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
5:48 AM Changeset in webkit [95407] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail
https://bugs.webkit.org/show_bug.cgi?id=68341

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19

  • platform/qt-arm/Skipped: Skip the failing tests
2:19 AM Changeset in webkit [95406] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Re-name LayerChromium border functions to reflect that
they are only for debug use.
https://bugs.webkit.org/show_bug.cgi?id=68212

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-19
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setDebugBorderColor):
(WebCore::LayerChromium::setDebugBorderWidth):

  • platform/graphics/chromium/LayerChromium.h:
1:17 AM Changeset in webkit [95405] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: extend timeline coverage.
https://bugs.webkit.org/show_bug.cgi?id=68260

Another place with js function call from native.

Reviewed by Pavel Feldman.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

12:36 AM Changeset in webkit [95404] by loislo@chromium.org
  • 18 edits
    3 adds in trunk

2011-09-18 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Test: inspector/timeline/timeline-animation-frame.html

WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::callFunctionWithoutFrame): (WebCore::V8Proxy::instrumentedCallFunction):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Added.
  • inspector/timeline/timeline-animation-frame.html: Added.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
  • inspector/timeline/timeline-test.js:
12:31 AM Changeset in webkit [95403] by Carlos Garcia Campos
  • 6 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:

Sep 18, 2011:

11:50 PM Changeset in webkit [95402] by koz@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.
10:34 PM Changeset in webkit [95401] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

6:29 PM Changeset in webkit [95400] by mitz@apple.com
  • 5 edits
    2 deletes in trunk/Source/JavaScriptCore

Removed ProfilerServer.

Reviewed by Mark Rowe.

  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/ProfilerServer.h: Removed.
  • profiler/ProfilerServer.mm: Removed.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • wscript:
3:29 PM Changeset in webkit [95399] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

2:35 PM Changeset in webkit [95398] by thakis@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

11:38 AM Changeset in webkit [95397] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

11:18 AM Changeset in webkit [95396] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
11:05 AM Changeset in webkit [95395] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
10:27 AM Changeset in webkit [95394] by mitz@apple.com
  • 5 edits
    1 move in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
  • platform/graphics/SimpleFontData.h: Ditto.
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this

Objective-C++ file to .mm.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.
10:16 AM Changeset in webkit [95393] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Snow Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

10:02 AM Changeset in webkit [95392] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

9:52 AM Changeset in webkit [95391] by mitz@apple.com
  • 11 edits
    3 adds in trunk

Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

  • WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.

I am going to rename this file in a followup patch.

  • platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().
  • platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added

a member variable to cache the results of calling this function.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.

  • Renamed the local variable newC to uppercaseCharacter.
  • Changed to use advanceByCombiningCharacterSequence().
  • Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). If there are combining marks and none of the fonts in the fallback list can render the sequence alone, use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() to allow Core Text to perform its own fallback.
  • Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData differs from the normal variant.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

  • platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
9:21 AM Changeset in webkit [95390] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected results for two tests after r95362.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

Sep 17, 2011:

8:47 PM Changeset in webkit [95389] by fpizlo@apple.com
  • 8 edits
    1 delete in trunk/Source/JavaScriptCore

DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316

Reviewed by Oliver Hunt.

This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.

This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAliasTracker.h: Removed.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:33 PM Changeset in webkit [95388] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294

Reviewed by Gavin Barraclough.

Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.

This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/Structure.h:

(JSC::Structure::transitivelyTransitionedFrom):

4:31 PM Changeset in webkit [95387] by mihaip@chromium.org
  • 35 edits in trunk/Source

FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • history/BackForwardListImpl.cpp:

(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
4:12 PM Changeset in webkit [95386] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68307

Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/borders/border-image-slice-omission.html

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::cssText):

LayoutTests:

  • fast/borders/border-image-slice-omission.html: Added.
3:47 PM Changeset in webkit [95385] by aa@chromium.org
  • 11 edits
    2 adds in trunk/Source

Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.h:
1:10 PM Changeset in webkit [95384] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315

  • platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.
10:43 AM Changeset in webkit [95383] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

8:58 AM Changeset in webkit [95382] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r95372.

  • dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"
3:57 AM Changeset in webkit [95381] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/media-element-focus-tab.html

fast/spatial-navigation/snav-media-elements.html

Return true from supportsFocus() if control's attribute is present or a tabindex is specified.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsFocus):

  • html/HTMLMediaElement.h:

LayoutTests:

For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.

  • fast/events/media-element-focus-tab-expected.txt: Added.
  • fast/events/media-element-focus-tab.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js:

(test):

  • fast/events/tabindex-focus-blur-all-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt: Added.
  • fast/spatial-navigation/snav-media-elements.html: Added.
2:49 AM Changeset in webkit [95380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162

Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::clearFocusedNode):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.

  • tests/data/autofocus_input_field_iframe.html: Added.
  • tests/data/iframe_clear_focused_node_test.html: Added.
2:28 AM Changeset in webkit [95379] by ryuan.choi@samsung.com
  • 3 edits in trunk

[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226

Reviewed by Adam Barth.

  • Source/cmake/FindCairo.cmake: Check required version.
  • Source/cmake/OptionsEfl.cmake:
2:08 AM Changeset in webkit [95378] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.
1:59 AM Changeset in webkit [95377] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r95337.

  • platform/qt-wk2/Skipped: Skip one more test.
1:06 AM Changeset in webkit [95376] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309

  • platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.
12:57 AM Changeset in webkit [95375] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r95335.

  • platform/qt-wk2/Skipped: Skip new failing tests.
12:49 AM Changeset in webkit [95374] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
  • platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.

Sep 16, 2011:

11:52 PM Changeset in webkit [95373] by abarth@webkit.org
  • 20 edits in trunk/Source

Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290

Reviewed by Darin Adler.

Source/WebCore:

LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.

  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • platform/leveldb/LevelDBComparator.h:
  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/leveldb/LevelDBDatabase.h:
  • platform/leveldb/LevelDBIterator.h:
  • platform/leveldb/LevelDBSlice.h:
  • platform/leveldb/LevelDBTransaction.cpp:
  • platform/leveldb/LevelDBTransaction.h:
  • platform/leveldb/LevelDBWriteBatch.cpp:
  • platform/leveldb/LevelDBWriteBatch.h:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):

  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBLevelDBCoding.cpp:
  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

  • features.gypi:
  • tests/IDBLevelDBCodingTest.cpp:
11:34 PM Changeset in webkit [95372] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk/Source/WebCore

Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.

http://webkit.org/b/68105

Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.

Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.

When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Adding files.

  • WebCore.exp.in:

Export EventListenerMap::contains() for WebKit/mac.

  • dom/EventListenerMap.cpp: Added.

(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):

  • dom/EventListenerMap.h: Added.
  • dom/EventTarget.cpp:

(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

  • dom/EventTarget.h:

(WebCore::EventTarget::visitJSEventListeners):

Use EventListenerIterator to visit listeners. (JSC specific.)

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):

Call EventListenerMap::eventTypes() go get the list of event types
currently listened for.

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferEventListenersToShadowTree):

Move implementations of SVG-specific hacks into EventListenerMap and
call them from here.

11:07 PM Changeset in webkit [95371] by koz@chromium.org
  • 6 edits
    2 adds in trunk

Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Reviewed by James Robinson.

Test: plugins/fullscreen-plugins-dont-reload.html

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):

  • rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Reviewed by James Robinson.

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
  • plugins/fullscreen-plugins-dont-reload.html: Added.
10:53 PM Changeset in webkit [95370] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265

Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.

As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
10:52 PM Changeset in webkit [95369] by jochen@chromium.org
  • 17 edits
    7 adds in trunk

Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.

Reviewed by Adam Barth.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowImage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):

Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowImage):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowImage):

  • src/FrameLoaderClientImpl.h:

Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowImage):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • http/tests/permissionclient/resources/bostin.gif:
  • http/tests/permissionclient/resources/redir.php:
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/http/tests/permissionclient/image-permissions-expected.txt:
  • platform/http/tests/permissionclient/image-permissions.html:
10:30 PM Changeset in webkit [95368] by dslomov@google.com
  • 3 edits in trunk/Source/WebKit/chromium

https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.

Reviewed by Darin Fisher.

  • public/WebKit.h:
  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):

10:24 PM Changeset in webkit [95367] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-16
Reviewed by Chang Shu.

Added test case to check load progress for QTouchWebView

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
10:16 PM Changeset in webkit [95366] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Make XSSAuditor truncate inline snippets at a reasonable length before comparison
respecting boundaries of multiply urlencoded sequences.
https://bugs.webkit.org/show_bug.cgi?id=68092

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/property-escape-long.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::isContainedInRequest):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/property-escape-long-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-long.html: Added.
9:39 PM Changeset in webkit [95365] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove m_contentsDirty from LayerChromium because it
is redundant with m_dirtyRect.
https://bugs.webkit.org/show_bug.cgi?id=68213

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::resetNeedsDisplay):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

9:28 PM Changeset in webkit [95364] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).

  • wtf/Platform.h:
9:15 PM Changeset in webkit [95363] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

update-webkit-chromium should retry the gclient call if it fails once
https://bugs.webkit.org/show_bug.cgi?id=68252

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.

  • Scripts/update-webkit-chromium:
9:01 PM Changeset in webkit [95362] by dslomov@google.com
  • 26 edits in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.

Based on patch by Luke Zarko.

Reviewed by David Levin.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::webkitPostMessage):

  • bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore::JSDedicatedWorkerContext::webkitPostMessage):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::webkitInitMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::webkitPostMessage):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorker::postMessage):
(WebCore::JSWorker::webkitPostMessage):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallback):
(WebCore::V8MessageEvent::webkitInitMessageEventCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):

  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • page/DOMWindow.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
The tests ensure that webkitPostMessage and postMessage behave identically.

Based on patch by Luke Zarko.

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/events/message-port-expected.txt:
  • fast/events/message-port.html:
  • fast/workers/resources/worker-call.js:
  • fast/workers/worker-call-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
8:47 PM Changeset in webkit [95361] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Chromium: Fix repaint of rubber-band overhang area under composited path
https://bugs.webkit.org/show_bug.cgi?id=68246

I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

LayoutTests:

  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html: Added.
8:36 PM Changeset in webkit [95360] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

Removed unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independent files
https://bugs.webkit.org/show_bug.cgi?id=68249

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-16
Reviewed by Martin Robinson.

  • Shared/Plugins/NPIdentifierData.cpp: Removed NotImplemented.h inclusion.
  • Shared/Plugins/NPRemoteObjectMap.cpp: Removed NotImplemented.h inclusion.
  • Shared/Plugins/NPVariantData.cpp: Removed NotImplemented.h inclusion.
  • UIProcess/gtk/WebContextGtk.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Cookies/WebCookieManager.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp: Removed NotImplemented.h inclusion.
8:23 PM Changeset in webkit [95359] by scheib@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add movementX/Y members to WebMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=68174

Reviewed by Dimitri Glazkov.

  • public/WebInputEvent.h:

(WebKit::WebMouseEvent::WebMouseEvent):

7:57 PM Changeset in webkit [95358] by weinig@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306

Reviewed by Anders Carlsson.

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):
Update name.

  • runtime/JSType.h:

Update name and un-indent.

  • runtime/Structure.h:

(JSC::JSCell::isAPIValueWrapper):
Update name.

7:47 PM Changeset in webkit [95357] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305

Reviewed by Anders Carlsson.

  • runtime/JSObject.h:

(JSC::JSObject::isStrictModeFunction):

7:42 PM Changeset in webkit [95356] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/PopupListBox.cpp:
7:40 PM Changeset in webkit [95355] by tony@chromium.org
  • 8 edits in trunk

Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
7:31 PM Changeset in webkit [95354] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.

Call the binding script lazily on the first run of the set() method of
a typed array.

  • ../../Source/WebCore/WebCore.gypi:
  • ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
  • ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
  • ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
  • ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
7:24 PM Changeset in webkit [95353] by rniwa@webkit.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Chromium pixel test rebaseline for r95335.

  • platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-win-vista/editing: Removed.
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [95352] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent

Test: fast/events/constructors/error-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
  • dom/ErrorEvent.cpp:

(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):

  • dom/ErrorEvent.h: Added a definition for ErrorEventInit.

(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):

  • dom/ErrorEvent.idl: Makes ErrorEvent constructible.

LayoutTests:

error-event-constructor.html checks the behavior of the ErrorEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
  • fast/events/constructors/error-event-constructor-expected.txt: Added.
  • fast/events/constructors/error-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.
6:47 PM Changeset in webkit [95351] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011

Reviewed by Darin Adler.

I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.

  • http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
  • http/tests/security/canvas-cors-with-two-hosts.html: Added.
  • http/tests/security/resources/canvas-cors-subtest.html: Added.
6:36 PM Changeset in webkit [95350] by haraken@google.com
  • 4 edits
    12 adds
    2 deletes in trunk

Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684

Reviewed by Dan Bernstein.

Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal-no-overlap1.html

fast/ruby/overhang-horizontal-no-overlap2.html
fast/ruby/overhang-vertical-no-overlap1.html
fast/ruby/overhang-vertical-no-overlap2.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.

LayoutTests:

  • fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
  • fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
  • fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
  • fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
  • fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
  • fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
  • fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
  • fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
  • fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
  • platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
  • platform/chromium/test_expectations.txt: Skips overhang-horizontal.html. We will update the result image as a rebase line.
6:32 PM Changeset in webkit [95349] by rniwa@webkit.org
  • 17 edits in trunk/Source/WebCore

Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299

Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
6:14 PM Changeset in webkit [95348] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::NonCompositedContentHost):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

6:12 PM Changeset in webkit [95347] by Simon Fraser
  • 13 edits in trunk/Source

Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Source/WebCore:

Reviewed by Sam Weinig.

Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.

  • page/Settings.h:

(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):

Source/WebKit/mac:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

6:02 PM Changeset in webkit [95346] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

Test: fast/canvas/canvas-large-fills.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

  • fast/canvas/canvas-large-fills-expected.txt: Added.
  • fast/canvas/canvas-large-fills.html: Added.
5:55 PM Changeset in webkit [95345] by bashi@chromium.org
  • 8 edits
    2 copies in branches/chromium/835

Merge 94508 - <rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.

  • dom/Document.cpp:

(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.

  • dom/Document.h:

(WebCore::Document::retireCustomFont): Added.

LayoutTests:

  • fast/css/font-face-used-after-retired-expected.txt: Added.
  • fast/css/font-face-used-after-retired.html: Added.

TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7932007

5:50 PM Changeset in webkit [95344] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

  • platform/graphics/chromium/LayerChromium.h:
5:45 PM Changeset in webkit [95343] by levin@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline fix up due to r95239.

Add back in a baseline that was removed in my last change.

  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:44 PM Changeset in webkit [95342] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Fix the rebaseline in r95325 and also rebaseline for r95335.

  • inspector/styles/styles-update-from-js-expected.txt:
  • platform/chromium/test_expectations.txt
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
5:33 PM Changeset in webkit [95341] by enne@google.com
  • 12 edits in trunk/Source/WebCore

[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272

Reviewed by James Robinson.

All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.

Just moving code around. Tested by existing compositor tests.

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::drawDebugBorder):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

5:22 PM Changeset in webkit [95340] by weinig@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289

Reviewed by Anders Carlsson.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.

  • runtime/JSObject.h:

(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.

  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.

(JSC::TypeInfo::isFinalObject):
Added.

(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
Use new isFinalObject() predicate.

5:22 PM Changeset in webkit [95339] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop installing source and header files in to WebKit2.framework after r95303.

  • WebKit2.xcodeproj/project.pbxproj:
5:20 PM Changeset in webkit [95338] by barraclough@apple.com
  • 5 edits in trunk

Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166

Reviewed by Geoff Garen.

Source/JavaScriptCore:

The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate). The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):

LayoutTests:

Added layout test.

  • fast/js/floating-point-truncate-rshift-expected.txt:
  • fast/js/floating-point-truncate-rshift.html:
5:08 PM Changeset in webkit [95337] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.

  • platform/chromium/test_expectations.txt:
  • editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-blockquote.html: Added.
5:07 PM Changeset in webkit [95336] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):

5:00 PM Changeset in webkit [95335] by rniwa@webkit.org
  • 7 edits
    15 adds in trunk

Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.

We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...

Tests: editing/deleting/merge-paragraph-from-address.html

editing/deleting/merge-paragraph-from-h6-with-style.html
editing/deleting/merge-paragraph-from-h6.html
editing/deleting/merge-paragraph-from-listing.html
editing/deleting/merge-paragraph-into-h1-with-style.html
editing/deleting/merge-paragraph-into-h1.html
editing/deleting/merge-paragraph-into-pre.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/markup.cpp:

(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.

  • editing/deleting/merge-paragraph-from-address-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-address.html: Added.
  • editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
  • editing/deleting/merge-paragraph-from-h6.html: Added.
  • editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-listing.html: Added.
  • editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
  • editing/deleting/merge-paragraph-into-h1.html: Added.
  • editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-pre.html: Added.
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
4:33 PM Changeset in webkit [95334] by nduca@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288

Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

  • src/GraphicsContext3DPrivate.h:
4:24 PM Changeset in webkit [95333] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::process):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaButton):

4:07 PM Changeset in webkit [95332] by levin@chromium.org
  • 6 edits
    16 adds in trunk/LayoutTests

[chromium] Rebaseline fix up due to r95239.

Expectation removal due to r95322 and r95325.

  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [95331] by ggaren@apple.com
  • 10 edits
    4 deletes in trunk

Removed undetectable style.filter.

Reviewed by Sam Weinig.

This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.

Source/JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSTypeInfo.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.

Source/WebCore:

  • ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
  • WebCore.order:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

LayoutTests:

  • fast/dom/undetectable-style-filter-expected.txt: Removed.
  • fast/dom/undetectable-style-filter.html: Removed.
3:50 PM Changeset in webkit [95330] by rwlbuis@webkit.org
  • 2 edits in trunk/Tools

2011-09-16 Rob Buis <rbuis@rim.com>

Add Eli's rim address and change the nick.

  • Scripts/webkitpy/common/config/committers.py:
3:29 PM Changeset in webkit [95329] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282

Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • platform/chromium/test_expectations.txt:
3:27 PM Changeset in webkit [95328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078

Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.

  • tests/WebFrameTest.cpp:

(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):

3:02 PM Changeset in webkit [95327] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Update JSC results to account for intrinsics change.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
2:34 PM Changeset in webkit [95326] by weinig@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchIfNotObject):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitJumpIfNotObject):

  • runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):

  • runtime/JSType.h:
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

  • runtime/Operations.cpp:

(JSC::jsIsObjectType):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC::Structure::isObject):
(JSC::JSCell::isObject):

2:12 PM Changeset in webkit [95325] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline from r95242.

2:05 PM Changeset in webkit [95324] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled back in r95201 with test failure fixed.

I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.

  • jit/JIT.h:
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitStoreAndMapInt32):

1:59 PM Changeset in webkit [95323] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Replace use of access to nodeList using call, with array style notation.

  • editing/pasteboard/paste-noscript.html:
1:43 PM Changeset in webkit [95322] by mihaip@chromium.org
  • 5 edits in trunk/LayoutTests

http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

  • http/tests/history/back-with-fragment-change.php:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
1:42 PM Changeset in webkit [95321] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed Windows build fix after 95318.

1:33 PM Changeset in webkit [95320] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277

It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

1:33 PM Changeset in webkit [95319] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

include path so DFGIntrinsic.h can be found.

1:32 PM Changeset in webkit [95318] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274

Reviewed by Sam Weinig.

Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.

(GlobalObject::finishCreation):
(GlobalObject::addFunction):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):

  • runtime/JSObject.h:

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::lookupPut):

1:22 PM Changeset in webkit [95317] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new expectations (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).

  • LayoutTests/platform/chromium/test_expectations.txt:
1:18 PM Changeset in webkit [95316] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Windows.

1:12 PM Changeset in webkit [95315] by andersca@apple.com
  • 8 edits in trunk

Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269

Reviewed by Geoffrey Garen.

Source/WebKit2:

Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

Update client function signatures.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowUIClientInit):

  • MiniBrowser/mac/BrowserWindowController.m:

(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

1:06 PM Changeset in webkit [95314] by ap@apple.com
  • 4 edits
    1 copy in trunk/Source/WebKit2

Give local builds of WebProcess different icon to distinguish them from built-in Safari’s WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68268

Reviewed by Darin Adler.

  • Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds. The empty value for production resulted in WebKit not adding the key to plist at all, which is what we want (but I don't know if it's a supported feature). Also, don't copy the icon file to built framework in production builds.
  • WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.
  • WebProcess/Info.plist: Added a key for the icon.
  • WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.
1:05 PM Changeset in webkit [95313] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-DFG builds.

  • runtime/Executable.h:

(JSC::NativeExecutable::finishCreation):

1:05 PM Changeset in webkit [95312] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271

Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):

12:29 PM Changeset in webkit [95311] by andersca@apple.com
  • 5 edits in trunk

Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266

Reviewed by John Sullivan.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(mouseDidMoveOverElement):

11:50 AM Changeset in webkit [95310] by fpizlo@apple.com
  • 26 edits
    1 add in trunk/Source

DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.

On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.

Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h

This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):

  • dfg/DFGIntrinsic.h: Added.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/DateInstanceCache.h:
  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

Source/WebCore:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.

  • CMakeLists.txt:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

Source/WebKit:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

  • CMakeLists.txt:

Source/WebKit2:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

  • CMakeLists.txt:
11:43 AM Changeset in webkit [95309] by jamesr@google.com
  • 8 edits in trunk/Source

[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418

Source/WebCore:

This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

  • src/GraphicsContext3DPrivate.h:
  • tests/CCLayerTreeHostTest.cpp:

(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

11:43 AM Changeset in webkit [95308] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220

Reviewed by Oliver Hunt.

Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

11:32 AM Changeset in webkit [95307] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262

Broke a bunch of SVG tests (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformContentsSize):

  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::platformContentsSize):

11:26 AM Changeset in webkit [95306] by simonjam@chromium.org
  • 4 edits in trunk

2011-09-16 James Simonsen <simonjam@chromium.org>

Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147

Reviewed by Eric Seidel.

  • html5lib/resources/webkit02.dat:

2011-09-16 James Simonsen <simonjam@chromium.org>

Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147

Reviewed by Eric Seidel.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
11:22 AM Changeset in webkit [95305] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Tools/MiniBrowser

Unreviewed commit. Fix Windows and MacOSX compilation after r95303.

11:06 AM Changeset in webkit [95304] by abarth@webkit.org
  • 17 edits in trunk/Source/WebCore

CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256

Reviewed by Darin Adler.

This patch should have not behavioral effect. It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
10:31 AM Changeset in webkit [95303] by igor.oliveira@openbossa.org
  • 16 edits
    2 adds in trunk/Source/WebKit2

2011-09-16 Igor Oliveira <igor.oliveira@openbossa.org>

[WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.
https://bugs.webkit.org/show_bug.cgi?id=68125

This patch implements support for the UiProcess to know what is the link url of a hovered element.

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebHitTestResult.cpp: Added.

WebHitTestResult has hovered element information.

(WebKit::WebHitTestResult::create):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h: Added. (WebKit::WebHitTestResult::absoluteImageURL): (WebKit::WebHitTestResult::absoluteLinkURL): (WebKit::WebHitTestResult::absoluteMediaURL): (WebKit::WebHitTestResult::linkLabel): (WebKit::WebHitTestResult::linkTitle): (WebKit::WebHitTestResult::WebHitTestResult): (WebKit::WebHitTestResult::type):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::mouseDidMoveOverElement):
  • UIProcess/WebUIClient.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
  • win/WebKit2.vcproj:
10:28 AM Changeset in webkit [95302] by Csaba Osztrogonác
  • 19 edits
    3 deletes in trunk

[Qt] REGRESSION(r95091) It made many tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed rolling out r95091 and followup patches.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::callFunction):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willCallFunction):

  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Removed.
  • inspector/timeline/timeline-animation-frame.html: Removed.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-test.js:
  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
10:23 AM Changeset in webkit [95301] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

cachedFont not getting updated for inline SVG text.
https://bugs.webkit.org/show_bug.cgi?id=68060

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The cached scaledFont needs to be updated on every style set call. It
is not similar to m_style which can get derived from parent's style and
hence will get automatically updated on ancestor's style change. This is
required, otherwise we will maintain stale font list in cached scaledFont
when custom fonts are retired on Document::recalcStyle.

Test: svg/text/text-style-recalc-crash.html

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::styleDidChange):
(WebCore::RenderSVGInlineText::setStyle):

  • rendering/svg/RenderSVGInlineText.h:

LayoutTests:

  • svg/text/text-style-recalc-crash-expected.txt: Added.
  • svg/text/text-style-recalc-crash.html: Added.
9:58 AM Changeset in webkit [95300] by Adam Roben
  • 4 edits in trunk/Source/WebKit2

Add support for attributes on message parameters

Parameter attributes are specified as a space-separated list inside square brackets before
the parameter's type. WebKit2 doesn't use this, but other projects that use these scripts
would like to.

Fixes <http://webkit.org/b/68219> Would like a way to specify attributes on message
parameters

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages_unittest.py: Added tests for parameter attributes.
  • Scripts/webkit2/model.py:

(Parameter.init): Added a new attributes parameter, which is stored in the self.attributes
property.
(Parameter.has_attribute): Added. Returns true if this parameter has the given attribute.

  • Scripts/webkit2/parser.py:

(parse): Moved attributes-parsing code from here...
(parse_attributes_string): ...to here.
(parse_parameters_string): Renamed from parse_parameter_string. Now also parses parameter
attributes.

9:58 AM Changeset in webkit [95299] by Adam Roben
  • 4 edits in trunk/Source/WebKit2

Make WebKit2's message-generation model and parser scripts accessible to other projects

We copy them into the build products directory so other projects can find them.

Fixes <http://webkit.org/b/68169> Would like to be able to use WebKit2's message-generation
scripts in other projects

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj: Copy the scripts to PrivateHeaders.
  • win/WebKit2.make: Copy the scripts from obj/WebKit2/scripts to

tools/scripts, like WebCore does.

  • win/WebKit2Generated.make: Copy the scripts to obj/WebKit2/scripts, which is similar to what

WebCore does for its bindings scripts.

9:57 AM Changeset in webkit [95298] by Adam Roben
  • 9 edits
    2 adds in trunk/Source/WebKit2

Split some of the message-generation code into separate modules

This is in preparation for making these modules scripts usable by other projects.

Fixes <http://webkit.org/b/68217> Model and parsing functionality for WebKit2's
message-generation scripts is trapped inside a much larger module

Reviewed by Darin Adler.

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:

Added new files.

  • Scripts/webkit2/messages.py: Moved some code from here...
  • Scripts/webkit2/model.py: Added.
  • Scripts/webkit2/parser.py: Added.

...to here. MessageReceiver.parse was split out into a function in the new parser module.

  • Scripts/webkit2/messages_unittest.py: Updated for renames.
9:36 AM Changeset in webkit [95297] by Csaba Osztrogonác
  • 6 edits in trunk

Source/JavaScriptCore: REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed rolling out r95201.

  • jit/JIT.h:
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):

  • jit/JITInlineMethods.h:

LayoutTests: Unreviewed rolling out r95277.

  • platform/qt/Skipped:
9:26 AM Changeset in webkit [95296] by loislo@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234

The idea is to create a set of tests which cover frequently used UI actions
and print the average time of these actions.
There are two pilot tests. The common part was extracted into performance-test helper.

Reviewed by Pavel Feldman.

  • inspector/performance/resources/network-append-30-requests.html: Added.
  • inspector/performance/resources/performance-test.js: Added.

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):

  • inspector/performance/resources/show-panel-network.html: Added.
9:25 AM Changeset in webkit [95295] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r95052): SelectorChecker identifier filter not working
https://bugs.webkit.org/show_bug.cgi?id=68244

Reviewed by Dan Bernstein.

Missing &.

  • css/SelectorChecker.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):

9:08 AM Changeset in webkit [95294] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix after r95271.

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
8:58 AM Changeset in webkit [95293] by scheib@chromium.org
  • 2 edits in trunk/Tools

Add Vincent Scheib to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:50 AM Changeset in webkit [95292] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a flakey test.

  • platform/qt/Skipped:
8:42 AM Changeset in webkit [95291] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced in r95239.

  • platform/qt/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/qt/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/qt/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
8:24 AM Changeset in webkit [95290] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r95285.
http://trac.webkit.org/changeset/95285
https://bugs.webkit.org/show_bug.cgi?id=68247

It broke a webkitpy test (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
6:30 AM Changeset in webkit [95289] by caseq@chromium.org
  • 10 edits
    1 add
    1 delete in trunk/Source

2011-09-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Pavel Feldman.

  • Merge ExtensionCommon.js into ExtensionAPI.js
  • refactor building of extension API for better reuse
  • expose interface for extension registration
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionAPI.js: (defineCommonExtensionSymbols): (buildExtensionAPIInjectedScript):
  • inspector/front-end/ExtensionCommon.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerExtension): (WebInspector.ExtensionServer.prototype._expandResourcePath):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-09-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Pavel Feldman.

  • expose extension API as a single, standalone file for easy reuse in remote extension scripts.
  • WebKit.gyp:
  • scripts/generate_devtools_extension_api.py: Added.
  • scripts/generate_devtools_zip.py:
6:19 AM Changeset in webkit [95288] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix for r95287.

  • inspector/debugger/debugger-expand-scope.html:
5:55 AM Changeset in webkit [95287] by loislo@chromium.org
  • 15 edits in trunk

Web Inspector: change WebInspector.currentPanel getter/setter to functions.
https://bugs.webkit.org/show_bug.cgi?id=68242

This is necessary for the panel switching performance tests.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.switchToAndFocus):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):

  • inspector/front-end/inspector.js:

(WebInspector.currentPanel):
(WebInspector._updateFocusedNode):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.goForward):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype.showPanel):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):

  • inspector/debugger/debugger-expand-scope.html:
  • inspector/debugger/debugger-proto-property.html:
  • inspector/storage-panel-dom-storage.html:
5:42 AM Changeset in webkit [95286] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] bot lucks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243

Unreviwed test skipping.

  • platform/qt-wk2/Skipped:
5:04 AM Changeset in webkit [95285] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-16
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
5:00 AM Changeset in webkit [95284] by mnaganov@chromium.org
  • 1 edit in trunk/Source/WebCore/rendering/LayoutState.cpp

Unreviewed. Fix release compilation after r95264

4:43 AM Changeset in webkit [95283] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
https://bugs.webkit.org/show_bug.cgi?id=68178

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-16
Reviewed by Xan Lopez.

.:

  • configure.ac: Do not build WebKit2 by default. Re-add pkgconfig support

for WebKit2.

Source/WebKit2:

  • GNUmakefile.am: Do not build WebKit2 by default. Re-add pkgconfig support

for WebKit2.

Tools:

Add a work-around to enable WebKit2 when using build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

2:29 AM Changeset in webkit [95282] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
https://bugs.webkit.org/show_bug.cgi?id=68165

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::clearConsoleMessages):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearMessages):

  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype.requestClearMessages):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
2:13 AM Changeset in webkit [95281] by keishi@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Rebaselines due to r95203 and r95207.

  • platform/chromium-cg-mac-leopard/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium/test_expectations.txt:
1:39 AM Changeset in webkit [95280] by alex
  • 2 edits in trunk/Source/WebCore

2011-09-16 Alejandro G. Castro <alex@igalia.com>

Fix build after r95245.

  • GNUmakefile.list.am:
1:35 AM Changeset in webkit [95279] by reni@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Update expecteds of failing tests after r95260 and r95242.

Unreviewed gardening.

  • editing/style/non-inheritable-styles-expected.txt: after r95242.
  • fast/dom/constructed-objects-prototypes-expected.txt: after r95260.
  • inspector/styles/styles-new-API-expected.txt: after r95242.
  • inspector/styles/styles-source-lines-expected.txt: after r95242.
1:26 AM Changeset in webkit [95278] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] One test failed after r95203
https://bugs.webkit.org/show_bug.cgi?id=68233

Unreviewed gardening.

  • platform/qt/Skipped: failed test is skipped.
1:21 AM Changeset in webkit [95277] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] One test runs out of time after r95091
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed gardening.

  • platform/qt/Skipped:
1:16 AM Changeset in webkit [95276] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests fail after r95201
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed gardening.

  • platform/qt/Skipped:
12:15 AM Changeset in webkit [95275] by leo.yang@torchmobile.com.cn
  • 3 edits
    2 adds in trunk

[Qt] Crash when dragging google maps.
https://bugs.webkit.org/show_bug.cgi?id=68223

Source/WebCore:

The custom image for a cursor might not be ready when WebKit trying
to use it to construct the cursor in Qt porting. This patch is using
arrow image to substitute the unready custom image.

Reviewed by Adam Barth.

Test: fast/css/crash-on-custom-cursor-when-loading.html

  • platform/qt/CursorQt.cpp:

(WebCore::createCustomCursor):
(WebCore::Cursor::ensurePlatformCursor):

LayoutTests:

Test case to use an unready custom cursor.

Reviewed by Adam Barth.

  • fast/css/crash-on-custom-cursor-when-loading-expected.txt: Added.
  • fast/css/crash-on-custom-cursor-when-loading.html: Added.

Sep 15, 2011:

11:52 PM Changeset in webkit [95274] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Add slow to calculate-percentage.html

  • platform/chromium/test_expectations.txt:
11:33 PM Changeset in webkit [95273] by fpizlo@apple.com
  • 20 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize method_check
https://bugs.webkit.org/show_bug.cgi?id=68215

Reviewed by Oliver Hunt.

MethodCallLinkInfo and StructureStubInfo are now searchable by
bytecodeIndex, so that DFG::ByteCodeParser can use that information
to determine how to optimize GetMethod.

A new node op has been added to DFG: CheckMethod. This is a variant
of GetMethod that has been optimized for the case that GetMethod
always takes the fast path. CheckMethod results in only a very
small amount of code (two loads and two branches in the worst case,
one load and one branch in the best case). CheckMethod behaves as
if it were a constant.

Introduced the notion that a DFG node that is not JSConstant
behaves as a constant. CheckMethod uses this functionality.

This is a 3% speed-up on Kraken, and a small speed-up on V8.
Appears to be neutral on SunSpider.

  • bytecode/CodeBlock.h:

(JSC::getStructureStubInfoBytecodeIndex):
(JSC::getMethodCallLinkInfoBytecodeIndex):

  • bytecode/PredictedType.cpp:

(JSC::predictionFromCell):
(JSC::predictionFromValue):

  • bytecode/PredictedType.h:
  • bytecode/StructureStubInfo.h:
  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordGetMethod):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfJSConstantNode):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasMethodCheckData):
(JSC::DFG::Node::methodCheckDataIndex):
(JSC::DFG::Node::valueOfJSConstant):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::structureAddress):

10:43 PM Changeset in webkit [95272] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Sigh. Missed this one.

  • features.gypi:
10:41 PM Changeset in webkit [95271] by abarth@webkit.org
  • 199 edits in trunk

Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

As discussed on webkit-dev.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::databaseId):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • bindings/js/JSSQLTransactionSyncCustom.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:
  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp:
  • bindings/scripts/test/V8/V8TestCallback.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::databaseIdCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • features.pri:
  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::init):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseInstrumentation.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/ChromeClient.h:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteFileSystem.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • platform/sql/SQLiteTransaction.cpp:
  • storage/AbstractDatabase.cpp:
  • storage/AbstractDatabase.h:
  • storage/ChangeVersionWrapper.cpp:
  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/Database.idl:
  • storage/DatabaseAuthorizer.cpp:
  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl:
  • storage/DatabaseDetails.h:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl:
  • storage/DatabaseTask.cpp:
  • storage/DatabaseTask.h:
  • storage/DatabaseThread.cpp:
  • storage/DatabaseThread.h:
  • storage/DatabaseTracker.cpp:
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h:
  • storage/OriginQuotaManager.cpp:
  • storage/OriginQuotaManager.h:
  • storage/OriginUsageRecord.cpp:
  • storage/OriginUsageRecord.h:
  • storage/SQLCallbackWrapper.h:
  • storage/SQLError.h:
  • storage/SQLError.idl:
  • storage/SQLException.h:
  • storage/SQLException.idl:
  • storage/SQLResultSet.cpp:
  • storage/SQLResultSet.h:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.cpp:
  • storage/SQLResultSetRowList.h:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLStatement.cpp:
  • storage/SQLStatement.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementCallback.idl:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLStatementErrorCallback.idl:
  • storage/SQLStatementSync.cpp:
  • storage/SQLStatementSync.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransaction.h:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionCallback.idl:
  • storage/SQLTransactionClient.cpp:
  • storage/SQLTransactionClient.h:
  • storage/SQLTransactionCoordinator.cpp:
  • storage/SQLTransactionCoordinator.h:
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionErrorCallback.idl:
  • storage/SQLTransactionSync.cpp:
  • storage/SQLTransactionSync.h:
  • storage/SQLTransactionSync.idl:
  • storage/SQLTransactionSyncCallback.h:
  • storage/SQLTransactionSyncCallback.idl:
  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:
  • storage/chromium/QuotaTracker.cpp:
  • storage/chromium/QuotaTracker.h:
  • storage/chromium/SQLTransactionClientChromium.cpp:
  • workers/WorkerContext.cpp:
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):

Source/WebKit/chromium:

  • src/DatabaseObserver.cpp:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::updateSpaceAvailable):
(WebKit::WebDatabase::resetSpaceAvailable):
(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:
  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitsecurityorigin.cpp:

(webkit_security_origin_get_web_database_usage):
(webkit_security_origin_get_web_database_quota):
(webkit_security_origin_set_web_database_quota):
(webkit_security_origin_get_all_web_databases):

  • webkit/webkitwebdatabase.cpp:

(webkit_web_database_get_display_name):
(webkit_web_database_get_expected_size):
(webkit_web_database_get_size):
(webkit_web_database_get_filename):
(webkit_web_database_remove):
(webkit_remove_all_web_databases):
(webkit_get_web_database_directory_path):
(webkit_set_web_database_directory_path):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • Storage/WebDatabaseManager.mm:
  • Storage/WebDatabaseManagerInternal.h:
  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebDatabaseQuotaManager.mm:

(-[WebDatabaseQuotaManager usage]):
(-[WebDatabaseQuotaManager quota]):
(-[WebDatabaseQuotaManager setQuota:]):

  • Storage/WebDatabaseTrackerClient.h:
  • Storage/WebDatabaseTrackerClient.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebdatabase.cpp:

(QWebDatabase::displayName):
(QWebDatabase::expectedSize):
(QWebDatabase::size):
(QWebDatabase::fileName):
(QWebDatabase::removeDatabase):
(QWebDatabase::removeAllDatabases):

  • Api/qwebsecurityorigin.cpp:

(QWebSecurityOrigin::databaseUsage):
(QWebSecurityOrigin::databaseQuota):
(QWebSecurityOrigin::setDatabaseQuota):
(QWebSecurityOrigin::allOrigins):
(QWebSecurityOrigin::databases):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::setOfflineStoragePath):
(QWebSettings::offlineStoragePath):

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • ForEachCoClass.h:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebDatabaseManager.cpp:
  • WebDatabaseManager.h:
  • WebSecurityOrigin.cpp:

(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:
  • WebView.cpp:

(wxWebView::Create):
(wxWebView::SetDatabaseDirectory):
(wxWebView::GetDatabaseDirectory):
(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
9:07 PM Changeset in webkit [95270] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] add timeout to test expectation of styles-source-lines.html

  • platform/chromium/test_expectations.txt:
9:01 PM Changeset in webkit [95269] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] add timeout to test expectation of styles-new-API.html

  • platform/chromium/test_expectations.txt:
8:59 PM Changeset in webkit [95268] by keishi@webkit.org
  • 3 edits in trunk/LayoutTests

[chromium] rebaseline expectations due to r95264

  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
8:52 PM Changeset in webkit [95267] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] added fail expectation for back-with-fragment-change.php

  • platform/chromium/test_expectations.txt:
8:48 PM Changeset in webkit [95266] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] adding text_expectation for zoom-svg-through-object-with-percentage-size.xhtml

  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [95265] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] adding fail to test_expectations due to r95188

  • platform/chromium/test_expectations.txt:
7:56 PM Changeset in webkit [95264] by Alexandru Chiculita
  • 17 edits
    10 adds in trunk

[CSSRegions] Regions should not slice line box rendering
https://bugs.webkit.org/show_bug.cgi?id=66198

Source/WebCore:

Created a new LayoutState constructor for the RenderFlowThread. It will
set m_isPaginated to true and force a pageHeight if 1. The actual pageHeight is
not used, because pageLogicalHeightForOffset will actually redirect the call
to RenderFlowThread.

Removed some of the duplicate code that calculated the page logical offset.
Added new methods like logicalPageOffset, pageLogicalHeightForOffset,
pageRemainingLogicalHeightForOffset.

There are still some issues related to incremental layout and different region widths.
Those issues will be addressed in different patches.

Reviewed by David Hyatt.

Tests: fast/regions/text-region-breaks.html

fast/regions/text-region-split-horizontal-bt.html
fast/regions/text-region-split-vertical-rl.html
fast/regions/text-region-split-vertical.html
fast/regions/text-region-split.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::logicalPageOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):

  • rendering/RenderFlowThread.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::pushLayoutState):

  • rendering/RenderView.h:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

LayoutTests:

Also updated the results for some older tests that now work correctly.

Reviewed by David Hyatt.

  • fast/regions/resources/helper.js:

(isDebugEnabled):
(assertEqualRects):
(testBoundingRects):
(assertRectContains):
(addPageLevelDebugBox):
(testContentToRegionsMapping):

  • fast/regions/text-region-breaks-expected.txt: Added.
  • fast/regions/text-region-breaks.html: Added.
  • fast/regions/text-region-split-expected.txt: Added.
  • fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
  • fast/regions/text-region-split-horizontal-bt.html: Added.
  • fast/regions/text-region-split-vertical-expected.txt: Added.
  • fast/regions/text-region-split-vertical-rl-expected.txt: Added.
  • fast/regions/text-region-split-vertical-rl.html: Added.
  • fast/regions/text-region-split-vertical.html: Added.
  • fast/regions/text-region-split.html: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
7:53 PM Changeset in webkit [95263] by keishi@webkit.org
  • 4 edits in trunk/LayoutTests

[chromium] rebaseline expectations due to r95239

  • platform/chromium-cg-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
7:45 PM Changeset in webkit [95262] by haraken@google.com
  • 8 edits
    2 adds in trunk

Implement a PopStateEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67977

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/pop-state-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the PopStateEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for PopStateEvent.
  • dom/PopStateEvent.cpp:

(WebCore::PopStateEventInit::PopStateEventInit):
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):

  • dom/PopStateEvent.h: Added a definition for PopStateEventInit.
  • dom/PopStateEvent.idl: Makes PopStateEvent constructible.

LayoutTests:

pop-state-event-constructor.html checks the behavior of the PopStateEvent constructor.

  • fast/events/constructors/pop-state-event-constructor-expected.txt: Added.
  • fast/events/constructors/pop-state-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped pop-state-event-constructor.html, since V8 does not yet have the PopStateEvent constructor.
7:43 PM Changeset in webkit [95261] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] remove duplicate entries in test_expectations.txt

  • platform/chromium/test_expectations.txt:
7:16 PM Changeset in webkit [95260] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp

[chromium] Fix updateCompositorResources crash.

Reviewed by Nat Duca.

Landing directly on the branch, due to code divergence.
See: http://codereview.chromium.org/7866017/

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers)
(WebCore::LayerRendererChromium::updateCompositorResources)
(WebCore::LayerRendererChromium::drawLayer)

7:16 PM Changeset in webkit [95259] by mihaip@chromium.org
  • 6 edits
    5 adds in trunk

Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556

Source/WebCore:

Reviewed by Adam Barth.

Tests: http/tests/history/back-with-fragment-change.php

http/tests/navigation/navigation-interrupted-by-fragment.html

  • loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
  • loader/HistoryController.cpp: Don't commit the wrong provisional item.

LayoutTests:

Reviewed by Adam Barth.

Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.

  • fast/loader/page-dismissal-modal-dialogs.html:
  • fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
  • http/tests/history/back-with-fragment-change-expected.txt: Added.
  • http/tests/history/back-with-fragment-change.php: Added.
  • http/tests/history/resources/back-with-fragment-change-target.html: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment.html: Added.
7:14 PM Changeset in webkit [95258] by jamesr@google.com
  • 2 edits in trunk/Tools

Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.

  • Scripts/webkitpy/common/config/committers.py:
7:03 PM Changeset in webkit [95257] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
https://bugs.webkit.org/show_bug.cgi?id=68003

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
6:54 PM Changeset in webkit [95256] by enne@google.com
  • 4 edits in trunk/Source

[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
https://bugs.webkit.org/show_bug.cgi?id=68204

Reviewed by James Robinson.

Add CRASH calls to determine which assumptions are being violated.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

6:32 PM Changeset in webkit [95255] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove TestWebKitAPI from the chromium build until it is made to work
with the shared component build.

  • WebKit.gyp:
6:32 PM Changeset in webkit [95254] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

6:30 PM Changeset in webkit [95253] by mrowe@apple.com
  • 1 copy in tags/Safari-535.3

New tag.

6:25 PM Changeset in webkit [95252] by fsamuel@chromium.org
  • 4 edits in trunk

Add method to scroll current node to specific position in Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=68192

Patch by Varun Jain <varunjain@google.com> on 2011-09-15
Reviewed by Dimitri Glazkov.

  • Source/WebKit/chromium/public/WebView.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
  • Source/WebKit/chromium/src/WebViewImpl.h:
6:24 PM Changeset in webkit [95251] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] skipping tests due to r95188

  • platform/chromium/test_expectations.txt:
6:19 PM Changeset in webkit [95250] by mhahnenberg@apple.com
  • 23 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (7/7)
https://bugs.webkit.org/show_bug.cgi?id=68122

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

JSCallbackObject was missed in previous patches due to the fact that
it's non-obvious (at least to my script) that it is in the JSCell hierarchy, so
this is just a bit of retroactive cleanup.

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

  • API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):

Source/WebCore:

No new tests.

Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This consists of moving the finishCreation() method call into the create methods
of the sixth level of the hierarchy as was done in previous patches.

The special cases for JSAudioConstructor, JSOptionConstructor, and JSImageConstructor
were also lumped in and given finishCreation() methods that are called in their
create methods because we are at the end and want to avoid a trivial patch just
for moving their finishCreation() methods from their constructor to their create method.

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::JSAudioConstructor::JSAudioConstructor):
(WebCore::JSAudioConstructor::finishCreation):

  • bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::create):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::JSOptionConstructor::JSOptionConstructor):
(WebCore::JSOptionConstructor::finishCreation):

  • bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::create):

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

The bindings generation script was also changed to move the finishCreation() call into the
create methods for descendants of JSWorkerContextBase and JSDOMWindowBase because those base
classes had it removed from their constructors.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):

Source/WebKit/mac:

Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

6:17 PM Changeset in webkit [95249] by haraken@google.com
  • 18 edits
    2 adds in trunk

A single line must not be split into two pages.
https://bugs.webkit.org/show_bug.cgi?id=65005

Reviewed by David Hyatt.

When the document width of a page is overflowed, the last line of the page can be
split into the next page. This is the regression caused by r88737. r88737 tried to
fix rounding errors in rendering calculations by expanding and shrinking a page
using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
a document width gets overflowed.

Source/WebCore:

This patch fixes the problem by also using resizePageRectsKeepingRatio() for the case
where the document width gets overflowed.

Test: printing/single-line-must-not-be-split-into-two-pages.html

  • WebCore.exp.in: Updated the signature of forceLayoutForPagination().
  • page/Frame.cpp:

(WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrunk.

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination): Uses resizePageRectsKeepingRatio() in the case where the document width gets overflowed.

  • page/FrameView.h:
  • page/PrintContext.cpp:

(WebCore::PrintContext::begin): Passes an original page size to setPrinting().
(WebCore::PrintContext::end): Ditto.

Source/WebKit/mac:

Test: printing/single-line-must-not-be-split-into-two-pages.html

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
(-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
(-[WebHTMLView _endPrintMode]): Ditto.
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
(-[WebHTMLView _endScreenPaginationMode]): Ditto.
(-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
(-[WebHTMLView layout]): Ditto.
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
(-[WebHTMLView setPageWidthForPrinting:]): Ditto.

Source/WebKit/win:

Test: printing/single-line-must-not-be-split-into-two-pages.html

  • WebFrame.cpp:

(WebFrame::setPrinting): Passes an original page size to setPrinting().
(WebFrame::setInPrintingMode): Ditto.

  • WebFrame.h:

LayoutTests:

The added test checks if the last line does not split across pages.

  • platform/chromium/test_expectations.txt: Skipped the added test since setPrinting() is not yet implemented.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
  • printing/single-line-must-not-be-split-into-two-pages.html: Added.
6:10 PM Changeset in webkit [95248] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r95243 and r95246.
http://trac.webkit.org/changeset/95243
http://trac.webkit.org/changeset/95246
https://bugs.webkit.org/show_bug.cgi?id=68202

Broke the Windows build (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::hookCallback):

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimation::copy):

  • platform/win/StructuredExceptionHandlerSupressor.h: Removed.
5:39 PM Changeset in webkit [95247] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Python version check is confusing in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=68004

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.

  • Scripts/test-webkitpy:
5:33 PM Changeset in webkit [95246] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Attempt to fix Windows build after r95243.

  • WebCore.vcproj/WebCore.vcproj:
5:18 PM Changeset in webkit [95245] by Simon Fraser
  • 9 edits
    2 adds in trunk/Source/WebCore

Make custom scrollbar theme for use in DRT, to reduce pixel differences between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Reviewed by James Robinson.

Add new scrollbar theme, called ScrollbarThemeMock, for use in layout
tests. The mock scrollbar simply draws a light gray box in the track,
with a dark gray box for the thumb.

Add ScrollbarThemeMock files to the build on all platforms. It isn't hooked up yet.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarTheme::nativeTheme):

  • platform/mock/ScrollbarThemeMock.cpp: Added.

(WebCore::ScrollbarThemeMock::trackRect):
(WebCore::ScrollbarThemeMock::scrollbarThickness):
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):

  • platform/mock/ScrollbarThemeMock.h: Added.

(WebCore::ScrollbarThemeMock::hasButtons):
(WebCore::ScrollbarThemeMock::hasThumb):
(WebCore::ScrollbarThemeMock::backButtonRect):
(WebCore::ScrollbarThemeMock::forwardButtonRect):

5:17 PM Changeset in webkit [95244] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67884
Delete button icon does not properly update when the device resolution changes
dynamically
-and corresponding-
<rdar://problem/10104632>

Reviewed by Darin Adler.

In DeleteButtonController::deviceScaleFactorChanged(), if the delete button is
currently showing, hide it and re-show it, forcing it to re-create the deletion
UI.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::deviceScaleFactorChanged):

  • editing/DeleteButtonController.h:
  • editing/Editor.cpp:

(WebCore::Editor::deviceScaleFactorChanged):

  • editing/Editor.h:

Iterate through all of the frames and propagate the deviceScaleFactorChange()
message to Editor.

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

4:50 PM Changeset in webkit [95243] by cmarrin@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-09-15 Chris Marrin <cmarrin@apple.com>

Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Reviewed by Adam Roben.


Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.


This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
  • platform\win\StructuredExceptionHandlerSupressor.h: New file to encapsulate the exception handling supression.
4:45 PM Changeset in webkit [95242] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=27579

Make sure that the border shorthand also resets border-image.

Reviewed by Beth Dakin.

Source/WebCore:

Added fast/borders/border-image-reset-by-border-shorthand.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

LayoutTests:

  • fast/borders/border-image-reset-by-border-shorthand-expected.txt: Added.
  • fast/borders/border-image-reset-by-border-shorthand.html: Added.
  • fast/borders/border-image-scaled-gradient.html:
4:35 PM Changeset in webkit [95241] by levin@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Rebaselines due to r95203 and r95207.

Also misc test_expectations additions.

  • platform/chromium-cg-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [95240] by fpizlo@apple.com
  • 25 edits
    2 deletes in trunk/Source/JavaScriptCore

The DFG non-speculative JIT is no longer used and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=68177

Reviewed by Geoffrey Garen.

This removes the non-speculative JIT and everything that relied on it,
including the ability to turn on DFG but not tiered compilation the,
ability to perform speculation failure into non-speculative JIT code,
and the ability to statically terminate speculation.

  • GNUmakefile.list.am:
  • JavaScriptCore.pro:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoopHint):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCodeGenerator.cpp:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp: Removed.
  • dfg/DFGNonSpeculativeJIT.h: Removed.
  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGPropagator.cpp:
  • dfg/DFGPropagator.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationRecovery):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITCode.h:

(JSC::JITCode::bottomTierJIT):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/Platform.h:
3:53 PM Changeset in webkit [95239] by hyatt@apple.com
  • 8 edits
    9 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=50072

Make overflow clipping to border-radius work across layers. This patch makes painting
work but does not attempt to fix hit testing. It also doesn't work when a composited
layer is clipped by a non-composited ancestor.

Add a new ClipRect class (used by ClipRects and RenderLayer) that is basically just tracking
a rect and a border radius taint. At the time we set a clip, if the rectangle is listed
as also being clipped by a radius, then we walk up the layer tree and push those inner border
rounded rect clips for any overflow areas in the containing block chain.

Reviewed by Beth Dakin.

Source/WebCore:

Added new tests in fast/clip.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderLayer.cpp:

(WebCore::inContainingBlockChain):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):

  • rendering/RenderLayer.h:

(WebCore::ClipRect::ClipRect):
(WebCore::ClipRect::rect):
(WebCore::ClipRect::setRect):
(WebCore::ClipRect::hasRadius):
(WebCore::ClipRect::setHasRadius):
(WebCore::ClipRect::operator==):
(WebCore::ClipRect::intersect):
(WebCore::ClipRect::move):
(WebCore::ClipRect::isEmpty):
(WebCore::ClipRect::intersects):
(WebCore::intersection):
(WebCore::ClipRects::overflowClipRect):
(WebCore::ClipRects::setOverflowClipRect):
(WebCore::ClipRects::fixedClipRect):
(WebCore::ClipRects::setFixedClipRect):
(WebCore::ClipRects::posClipRect):
(WebCore::ClipRects::setPosClipRect):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

LayoutTests:

  • fast/clip/overflow-border-radius-combinations.html: Added.
  • fast/clip/overflow-border-radius-composited.html: Added.
  • fast/clip/overflow-border-radius-transformed.html: Added.
  • platform/mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/mac/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/mac/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
3:10 PM Changeset in webkit [95238] by eric@webkit.org
  • 4 edits
    2 adds in trunk/Tools

Reviewed by Adam Barth.

webkit-patch should be able to find users and add them to bugzilla groups
https://bugs.webkit.org/show_bug.cgi?id=63351

These are both very basic commands. But it's now possible to find
all users matching a regexp, as well as add all users matching a regexp
to a set of groups.

bugzilla.py already knew how to find users (for validate-committer-lists)
but now it has the ability to modify the user records.

I split some of the logic out into a new EditUsersParser class
to try and reduce the amount of code in Bugzilla/BugzillaQueries.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
  • Scripts/webkitpy/tool/commands/findusers.py: Added.
3:06 PM Changeset in webkit [95237] by mrowe@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

3:05 PM Changeset in webkit [95236] by mrowe@apple.com
  • 1 copy in tags/Safari-534.51.22

New tag.

2:59 PM Changeset in webkit [95235] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: Crash in RenderBox::paintMaskImages due to a mask without an associated image
https://bugs.webkit.org/show_bug.cgi?id=50151

Reviewed by Simon Fraser.

Test: fast/css/empty-webkit-mask-crash.html

The crash stems from the fact that FillLayer::hasImage would walk over the linked list
of FillLayers and return true if one had an image. This means that hasImage() is true
does not mean that image() is non-NULL on all FillLayers.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages): Simplify the logic by doing the hasImage() check up-front
and properly check image() for each FillLayers. This has the nice benefit of changing the complexity
from O(n2) to O(n), which was what the code expected anyway.

LayoutTests: Test for: Crash in RenderBox::paintMaskImages due to a mask without an associated image
https://bugs.webkit.org/show_bug.cgi?id=50151

Reviewed by Simon Fraser.

  • fast/css/empty-webkit-mask-crash-expected.png: Added.
  • fast/css/empty-webkit-mask-crash-expected.txt: Added.
  • fast/css/empty-webkit-mask-crash.html: Added.
2:57 PM Changeset in webkit [95234] by eric@webkit.org
  • 22 edits in trunk

Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68182

Reviewed by Adam Barth.

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • features.pri:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::createImage):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
2:53 PM Changeset in webkit [95233] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG speculative JIT sometimes asserts that a value is not a number
even when it doesn't know anything about the number
https://bugs.webkit.org/show_bug.cgi?id=68189

Reviewed by Oliver Hunt.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::isUnknownJS):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotNumber):

2:49 PM Changeset in webkit [95232] by eric@webkit.org
  • 4 edits in trunk/Tools

Unreviewed. Make contributor email look-up case-insensitive.

validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
was missing from committers.py due to case sensitivity.

This also includes a test expectations update to committers_unittest.py
after my previous change.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2:43 PM Changeset in webkit [95231] by eric@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Updated this based on webkit-patch suggest-nominations and validate-committer-list output.

Add a bunch of email aliases to committers.py for regular contributors
who are committing using other email addresses than they have listed in the file.

  • Scripts/webkitpy/common/config/committers.py:
2:41 PM Changeset in webkit [95230] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

All of the functionality in the non-speculative JIT should be
available to the speculative JIT via helper methods
https://bugs.webkit.org/show_bug.cgi?id=68186

Reviewed by Oliver Hunt.

Stole all of the goodness from NonSpeculativeJIT and placed it
in JITCodeGenerator. Left all of the badness (i.e. subtle code
duplication with SpeculativeJIT, etc). This is in preparation
for removing the NonSpeculativeJIT entirely, but having its
goodness available for reuse in the SpeculativeJIT if necessary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::nonSpeculativeAdd):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithSub):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
2:24 PM Changeset in webkit [95229] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95167.
http://trac.webkit.org/changeset/95167
https://bugs.webkit.org/show_bug.cgi?id=68191

Patch needs further work. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15

(JSC::JSCell::toBoolean):

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toBoolean):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toBoolean):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::toBoolean):

2:21 PM Changeset in webkit [95228] by aestes@apple.com
  • 3 edits
    2 adds in trunk

Having an empty listener to beforeload events changes the behavior of other scripts
https://bugs.webkit.org/show_bug.cgi?id=45586

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/beforeload/cached-image-before-load.html

When loading a cached image after a beforeload handler has been
installed on the document, ImageLoader would dispatch both the
beforeload and load events asynchronously in such a way that caused
load to fire first. Since a side effect of firing the beforeload event
is to wire up the CachedImage to its associated RenderImage object,
this work was not done by the time load fired, and scripts that queried
renderer-dependent attributes of the image in an onload handler would
get bogus values in return.

Fix this by ensuring load fires after beforeload in the cached image case.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Call setClient() after
dispatching beforeload, since setClient() will dispatch the load event
if the image is cached.

LayoutTests:

  • fast/dom/beforeload/cached-image-before-load-expected.txt: Added.
  • fast/dom/beforeload/cached-image-before-load.html: Added.
2:10 PM Changeset in webkit [95227] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188

Reviewed by Darin Adler.

Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/wx/ScrollViewWx.cpp:
2:04 PM Changeset in webkit [95226] by jonlee@apple.com
  • 6 edits
    3 adds in trunk

Submitting a form with target=_blank works only once
https://bugs.webkit.org/show_bug.cgi?id=28633
<rdar://problem/7357787>

Reviewed by Andy Estes.

Source/WebCore:

Test: fast/forms/submit-to-blank-multiple-times.html

The call to reset the multiple form submission bool is pushed down from the mouseDown handler to
handleMousePressEvent(), to include WK2 coverage, similar to keyEvent.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent): clarified old FIXME comment. Both key events and mouse events
may submit a form multiple times, but the call to reset the handler should probably be in another
abstraction layer.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::mouseDown):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown): Remove call to resetMultipleFormSubmissionProtection() since
it will be made in platform-independent function EventHandler::handleMousePressEvent().

LayoutTests:

New test that simulates mouse clicking submit button twice (which didn't work), as well as using the keyboard twice (which did work).

  • fast/forms/resources/submit-to-blank-multiple-times-form-action.html: Added.
  • fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
  • fast/forms/submit-to-blank-multiple-times.html: Added.
2:00 PM Changeset in webkit [95225] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for platforms that expect a linkable symbol
for primitive static const's.

  • bytecode/CodeBlock.h:
  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

1:57 PM Changeset in webkit [95224] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add missing GPU-CG to one of the expectations.

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [95223] by commit-queue@webkit.org
  • 30 edits in trunk

XMLDocumentParserQt.cpp incorrectly converts 0-based number into 1-based number
https://bugs.webkit.org/show_bug.cgi?id=63540

Source/WebCore:

ZeroBasedNumber/OneBasedNumber are used in more places, inconsistency
in xml parser is fixed.

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-15
Reviewed by Adam Barth.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerLineNumber):

  • dom/ScriptableDocumentParser.h:
  • dom/StyleElement.cpp:

(WebCore::StyleElement::StyleElement):

  • dom/ViewportArguments.cpp:

(WebCore::parserLineNumber):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::lineNumber):

  • html/parser/HTMLDocumentParser.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::parserLineNumber):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::lineNumber):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

LayoutTests:

Bug is fixed, incorrect test expectations are properly fixed (line
number '0' is reported no more).

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-15
Reviewed by Adam Barth.

  • fast/parser/changing-attrbutes-crash-expected.txt:
  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/poly-parsing-error-expected.txt:
  • svg/custom/svg-parse-overflow-1-expected.txt:
  • svg/custom/svg-parse-overflow-2-expected.txt:
  • svg/custom/svg-parse-overflow-3-expected.txt:
  • svg/custom/svg-parse-overflow-4-expected.txt:
  • svg/custom/svg-parse-overflow-5-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/points-parser-expected.txt:
1:43 PM Changeset in webkit [95222] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix WebCore.gypi after r95130.

Unreviewed, build fix.

  • WebCore.gypi:
1:05 PM Changeset in webkit [95221] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for assertion on existence of alternative
CodeBlock.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

1:02 PM Changeset in webkit [95220] by mrowe@apple.com
  • 8 edits
    2 adds in branches/safari-534.51-branch

Merge r89705.

12:56 PM Changeset in webkit [95219] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Value profiles collect no information for global variables
https://bugs.webkit.org/show_bug.cgi?id=68143

Reviewed by Geoffrey Garen.

17% speed-up on string-fasta. Neutral elsewhere.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_global_var):

12:49 PM Changeset in webkit [95218] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add temporary exception while bots catch up to r95203.

  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [95217] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-534.51-branch

Merge r91386.

12:43 PM Changeset in webkit [95216] by eric@webkit.org
  • 86 edits in trunk

Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68022

Reviewed by Ryosuke Niwa.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • features.pri:
  • page/DOMWindow.idl:
  • svg/svgtags.in:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
12:39 PM Changeset in webkit [95215] by mrowe@apple.com
  • 5 edits in branches/safari-534.51-branch/Source/WebCore

Merge r88139.

12:32 PM Changeset in webkit [95214] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Ooops, revert accidentally commited unreviewed changes.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):

  • jit/JSInterfaceJIT.h:
  • runtime/JSValue.h:
12:29 PM Changeset in webkit [95213] by mrowe@apple.com
  • 3 edits
    6 adds in branches/safari-534.51-branch

Merge r90568.

12:24 PM Changeset in webkit [95212] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r95163.
http://trac.webkit.org/changeset/95163
https://bugs.webkit.org/show_bug.cgi?id=68180

[Qt] The QT_GCC_X variables were removed in Qt5 by accident.
(Requested by darktears on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15

.:

  • Source/WebKit.pri:

Source/JavaScriptCore:

12:20 PM Changeset in webkit [95211] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r95057.

12:18 PM Changeset in webkit [95210] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-534.51-branch

Merge r95056.

12:12 PM Changeset in webkit [95209] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r94818.

12:05 PM Changeset in webkit [95208] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Windows build fix p1.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):

  • jit/JSInterfaceJIT.h:
  • runtime/JSValue.h:
12:00 PM Changeset in webkit [95207] by mdelaney@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (Safari 5.1-r95043): Incorrect box-shadow offset
https://bugs.webkit.org/show_bug.cgi?id=68041

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/box-shadow/no-blur-multiple-offsets.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow): Add hack back in for Lion if
context is not accelerated.

LayoutTests:

  • fast/box-shadow/no-blur-multiple-offsets-expected.txt: Added.
  • fast/box-shadow/no-blur-multiple-offsets.html: Added.
  • platform/mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
11:54 AM Changeset in webkit [95206] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Tiered compilation should be enabled by default on platforms
that support the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68136

Reviewed by Sam Weinig.

Neutral on SunSpider, 4% speed-up on V8, and 19% speed-up on
Kraken. Large progressions on some benchmarks, including
3x on imaging-desaturate.

  • wtf/Platform.h:
11:47 AM Changeset in webkit [95205] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

devirtualize preventExtensions
https://bugs.webkit.org/show_bug.cgi?id=68176

Reviewed by Oliver Hunt.

This is virtual due to problems in JSFunction putting the prototype
property, but we can fix this problem a different way, just setting
the checkReadOnly flag to false in the put.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSFunction.h:
  • runtime/JSObject.h:
11:40 AM Changeset in webkit [95204] by simonjam@chromium.org
  • 6 edits
    2 adds in trunk

2011-09-15 James Simonsen <simonjam@chromium.org>

Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014

Reviewed by Adam Barth.

  • plugins/destroy-during-npp-new-object-with-fallback-content-expected.txt: Added.
  • plugins/destroy-during-npp-new-object-with-fallback-content.html: Added. Derivative of destroy-during-npp-new.html.

2011-09-15 James Simonsen <simonjam@chromium.org>

Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014

Reviewed by Adam Barth.

Test: plugins/destroy-during-npp-new.html under valgrind

plugins/destroy-during-npp-new-object-with-fallback-content.html under valgrind

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):

2011-09-15 James Simonsen <simonjam@chromium.org>

Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014

Reviewed by Adam Barth.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin): Moved protection up to HTMLObjectElement and HTMLEmbedElement.
11:27 AM Changeset in webkit [95203] by weinig@apple.com
  • 14 edits
    2 deletes in trunk

Experiment with removing ability to call a collection (except document.all)
https://bugs.webkit.org/show_bug.cgi?id=67579

Reviewed by Anders Carlsson.

Source/WebCore:

At the request of the public-script-coord mailing list (specifically Brendan Eich, see
http://lists.w3.org/Archives/Public/public-script-coord/2011JulSep/0360.html), this
patch removes the ability to call a collection (either a NodeList or HTMLCollection,
but not an HTMLAllCollection) as function, a syntax that we adopted to emulate IE.
It is being landed to find out if there are any sites relying on this behavior of WebKit,
or, if it is only used in IE only paths. If we find sites are breaking, it should be rolled
out and we should inform the public-script-coord mailing list.

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

Update comment.

  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSNodeListCustom.cpp:

Remove custom call code.

  • bindings/scripts/CodeGeneratorV8.pm:

Add support for V8CustomCall.

  • dom/NodeList.idl:
  • html/HTMLCollection.idl:

Remove CustomCall.

LayoutTests:

  • fast/dom/Element/id-in-formcollection-expected.txt:
  • fast/dom/Element/id-in-formcollection.html:
  • fast/dom/HTMLOptionElement/collection-setter-getter-expected.txt:
  • fast/dom/HTMLOptionElement/collection-setter-getter.html:

Don't use call syntax for tests that aren't explicitly testing it.

  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js:

Update test to show that we throw on call.

  • fast/profiler/call-nodelist-as-function-expected.txt: Removed.
  • fast/profiler/call-nodelist-as-function.html: Removed.

Remove test of removed feature.

11:17 AM Changeset in webkit [95202] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Attempt to fix the shared build after r95188.

  • WebKit.gyp:
10:58 AM Changeset in webkit [95201] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Value chaining for JSValue32_64 bitops.

Reviewed by Sam Weinig.

SunSpider says 2.3% faster, v8 ~1% faster (mostly due to crypto).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitStoreAndMapInt32): New int32 helper function for stores
that can chain their results, which is the common case.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec): Deployed new function.
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec): Had to reorder these functions so they
computed their result values last, to make them elligible for chaining.

10:58 AM Changeset in webkit [95200] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.6

Branching WebkitGTK+ for 1.6

10:53 AM Changeset in webkit [95199] by andersca@apple.com
  • 17 edits in trunk/Tools

Fix Mac build by including config.h where needed.

  • TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
  • TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
  • TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
  • TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
  • TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
  • TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
  • TestWebKitAPI/mac/JavaScriptTestMac.mm:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  • TestWebKitAPI/mac/main.mm:
10:11 AM Changeset in webkit [95198] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CanvasRenderingContext2D::State copy ctor should use initializer list.
https://bugs.webkit.org/show_bug.cgi?id=68152

Patch by Andreas Kling <kling@webkit.org> on 2011-09-15
Reviewed by Darin Adler.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):

9:54 AM Changeset in webkit [95197] by alexis.menard@openbossa.org
  • 14 edits in trunk/Source/WebKit2

[Qt][WK2] Make QWebError more friendly to QML.
https://bugs.webkit.org/show_bug.cgi?id=67785

Reviewed by Simon Hausmann.

Make sure that we can use the loading errors in QML. We send it via a QJSValue which
has the properties needed to get the error code, the url and the type of error.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::engine):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/testwindow.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):
(WebKit::TouchViewInterface::engine):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
9:46 AM Changeset in webkit [95196] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add expectation for flaky tests.

  • platform/chromium/test_expectations.txt:
9:43 AM Changeset in webkit [95195] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Remove WebKit2-specific knowledge from the Message class

This is in preparation for making some of our message-generations scripts usable by other
projects.

Fixes <http://webkit.org/b/68170> Model classes in WebKit2's message-generation scripts know
too much about WebKit2 details

Reviewed by Anders Carlsson.

  • Scripts/webkit2/messages.py: Added constants for the message attributes we support.

(MessageReceiver.parse): Instead of recognizing individual attributes, just stick the
attributes into a set and pass it to the Message constructor.
(Message.init): Changed to take a generic set of attributes instead of individual
attributes.
(Message.has_attribute): Added. Returns true if the message has an attribute.
(message_is_variadic): Renamed from parameter_type_is_variadic. Code came from
Message.init, which set the old message.is_variadic property.

(decode_type):
(message_to_struct_declaration):
(forward_declarations_and_headers):
(async_case_statement):
(sync_case_statement):
(generate_message_handler):
Updated to use Message.has_attribute and message_is_variadic.

9:14 AM Changeset in webkit [95194] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Clang build fix after r95172

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
Added parentheses to make precendence clear.

9:09 AM Changeset in webkit [95193] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't bother calculating dirty rect for accelerated 2D canvases.
https://bugs.webkit.org/show_bug.cgi?id=68158

Patch by Andreas Kling <kling@webkit.org> on 2011-09-15
Reviewed by Kenneth Rohde Christiansen.

For accelerated CanvasRenderingContext2D, didDraw() simply calls out
to RenderLayer::contentChanged(). Move this to the top of didDraw()
so we don't waste time calculating a precise dirty rect.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

8:13 AM Changeset in webkit [95192] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Source/WebCore: [Skia/Chrome] Cleanup unneeded code now that GrGLInterface is used to set GL ctx per GL call.
https://bugs.webkit.org/show_bug.cgi?id=68096

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-15
Reviewed by Stephen White.

This change removes PlatformContextSkia::makeGrContextCurrent now that
GrGLInterface is used to set the context on every Skia GL call.

Tested by every canvas layout test.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

Source/WebKit/chromium: [Skia/Chrome]
https://bugs.webkit.org/show_bug.cgi?id=68096

This change removes WebGraphicsContext3D::grGLInterface(). It has been
superceded by WebGraphicsContext3D::createGrGLInterface which sets up
the per-GL call callback used to set the correct context.

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-15
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::grContext):

  • src/WebGraphicsContext3D.cpp:

(WebKit::WebGraphicsContext3D::createGrGLInterface):

7:42 AM Changeset in webkit [95191] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new expectations (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac.

  • LayoutTests/platform/chromium/test_expectations.txt:
7:39 AM Changeset in webkit [95190] by caryclark@google.com
  • 1 edit
    7 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-relative-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
7:36 AM Changeset in webkit [95189] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, rolling out r95186.
http://trac.webkit.org/changeset/95186
https://bugs.webkit.org/show_bug.cgi?id=68159

Invalid rebaseline. (Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15

  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
7:08 AM Changeset in webkit [95188] by commit-queue@webkit.org
  • 62 edits
    1 move
    1 add in trunk

Let TestWebKitAPI work for chromium
https://bugs.webkit.org/show_bug.cgi?id=67756

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-15
Reviewed by Sam Weinig.

Source/WebKit/chromium:

  • WebKit.gyp:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:

(isSupportedPlatform):
(runTest):
(populateTests):

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/InjectedBundleController.cpp:
  • TestWebKitAPI/InjectedBundleMain.cpp:
  • TestWebKitAPI/JavaScriptTest.cpp:
  • TestWebKitAPI/PlatformUtilities.cpp:
  • TestWebKitAPI/TestWebKitAPI.gypi: Added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  • TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/Find.cpp:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
  • TestWebKitAPI/TestsController.cpp:
  • TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
  • TestWebKitAPI/win/PlatformWebViewWin.cpp:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/main.cpp:
6:47 AM Changeset in webkit [95187] by caryclark@google.com
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
  • LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
6:46 AM Changeset in webkit [95186] by keishi@webkit.org
  • 4 edits in trunk/LayoutTests

[chromium] rebaseline expectations due to r95180

  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
5:30 AM Changeset in webkit [95185] by caryclark@google.com
  • 10 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • platform/chromium-mac/fast/borders/border-image-border-radius-expected.png:
  • platform/chromium-mac/fast/borders/border-image-01-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slices-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-repeat-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-source-expected.png:
  • platform/chromium-mac/fast/borders/border-image-longhand-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Removed.
5:25 AM Changeset in webkit [95184] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Make sure that the ARM NEON files build with -marm
https://bugs.webkit.org/show_bug.cgi?id=68088

Simply adding the -marm cflag for OS=Android compiles results in it
being overridden by an -mthumb cflag later in the project generating
process. Therefore we should explicitly exclude -mthumb.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-15
Reviewed by Tony Gentilcore.

  • WebCore.gyp/WebCore.gyp:
5:11 AM Changeset in webkit [95183] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARMv5] Two timeline tests of inspector fail
https://bugs.webkit.org/show_bug.cgi?id=68151

Unreviewed gardening, adding timeout tests to skip list.

  • platform/qt-arm/Skipped:
3:51 AM Changeset in webkit [95182] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Add slow to debug version of repeat-cached-vm-reentry.html and sandboxed-iframe-navigation-parent.html.

  • platform/chromium/test_expectations.txt:
3:46 AM Changeset in webkit [95181] by keishi@webkit.org
  • 4 edits
    4 deletes in trunk/LayoutTests

[chromium] rebaseline expectations due to r95096, r95121, and r95129

  • platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
2:36 AM BuildingQtOnWindows edited by Csaba Osztrogonác
Add pthread as dependency (diff)
2:10 AM Changeset in webkit [95180] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] extract normalization of LayoutTests URLs to a method of TestShell
https://bugs.webkit.org/show_bug.cgi?id=68145

This will allow for other classes in DumpRenderTree to reuse this functionality

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestShell.cpp:

(normalizeLayoutTestURLInternal):
(dumpHistoryItem):
(TestShell::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/TestShell.h:
1:37 AM Changeset in webkit [95179] by zherczeg@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Adding new test expectations.

  • platform/qt/fast/borders/border-image-massive-scale-expected.txt: Added.
  • platform/qt/fast/borders/border-image-scaled-gradient-expected.txt: Added.
  • platform/qt/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
1:09 AM Changeset in webkit [95178] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

Renaming PeerConnection to webkitPeerConnection affects all ports,
not just chromium. Updating layout test after r95151.

Unreviewed gardening.

  • fast/dom/call-a-constructor-as-a-function-expected.txt:
12:56 AM Changeset in webkit [95177] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Build fix: Remove use of GraphicsContext::setIsAcceleratedContext

r95174 introduced GraphicsContext::setIsAcceleratedContext into Skia code and caused chromium builds to fail.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

12:41 AM Changeset in webkit [95176] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
https://bugs.webkit.org/show_bug.cgi?id=67908

Reviewed by David Levin.

Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.

ThreadableWebSocketChannelClientWrapper is derived from ThreadSafeRefCounted. It may be
destroyed on different threads, which will affect String's refcounting. Therefore, classes
derived from ThreadSafeRefCounted must not have a String member variable.

No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>. Note that String constructor taking an empty vector returns
a null string, not an empty string. We want an empty string in that case, so I had to add
special-case handling for an empty vector.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
12:11 AM Changeset in webkit [95175] by keishi@webkit.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

[chromium] rebaseline expectations due to r95121

  • platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.