Timeline


and

09/20/11:

23:31 WikiStart edited by larry3930@gmail.com
(diff)
22:58 Changeset [95600] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
https://bugs.webkit.org/show_bug.cgi?id=68228

Reviewed by Dimitri Glazkov.

Currently style changes on forwarded shadow child triggers
Node::reattach() only for the forwarded node. But it should
invalidate whole renderers on the shadow tree because
ShadowContentElement expects its inclusions to be attached and to
create renderers in the inclusion order. But single node
reattach() violates the expectation and possibly creates
inconsistent render tree.

This change makes NodeRenderingContext to go
AttachContentForwarded, where the ShadowContentElement::attach()
happens, only during ShadowRoot::attach(), not for style-change
triggered Node::attach() on the forwarded nodes.

Note that the altering phase AttachContentLight doesn't create
renderers for the forwarded nodes. Instead of that, it possibly
triggers shadow subtree reconstruction on
NodeRenderingContext::hostChildrenChanged().

No new tests. This is a defensive change. There is no visible
difference at this time.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::isInclusionSelectorActive):

  • dom/ShadowRoot.h:
22:41 Changeset [95599] by morrita@google.com
  • 7 edits
    3 adds in trunk

<meter> doesn't update rendering when its value is changed.
https://bugs.webkit.org/show_bug.cgi?id=67614

Reviewed by Dimitri Glazkov.

Source/WebCore:

It lacks repaint() when the value is changed.

For non-native appearance it works because the indicator is
implemented in shadow DOM, for native appearance, repainting should be
handled explicitly.

Test: fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::didElementStateChange):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateFromElement):

  • rendering/RenderMeter.h:
  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::updateAnimationState):

LayoutTests:

  • fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html: Added.
22:38 Changeset [95598] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=67989

Reviewed by Ryosuke Niwa.

No new tests because of no behavior change.

  • rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary): Moved from RenderObject.h.
(WebCore::RenderObject::markContainingBlocksForLayout): Moved from RenderObject.h

  • rendering/RenderObject.h:
22:23 Changeset [95597] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] changed test expectations for zoom-svg-through-object-with-auto-size.html:wq

  • platform/chromium/test_expectations.txt:
21:19 Changeset [95596] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some Heap cleanup.

Reviewed by Beth Dakin.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::blessNewBlock): Removed blessNewBlockForSlowPath()
because it was unused; renamed blessNewBlockForFastPath() to blessNewBlock()
since there is only one now.

  • heap/MarkedBlock.h: Removed ownerSet-related stuff since it was unused.

Updated mark bit overhead calculation. Deployed atomsPerBlock in one
place where we were recalculating it.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::addBlock): Updated for rename.

20:37 Changeset [95595] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
https://bugs.webkit.org/show_bug.cgi?id=68496

Reviewed by Dimitri Glazkov.

This patch adds a bunch of sorting to make sure things happen in a
predictable order in both JavaScriptCore and V8. We've talked before
about whether these two JavaScript engines should enumerate
dictionaries in the same order, but the consensus has been that they
shouldn't. Personally, I disagree with that consensus, but such is life.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
19:22 Changeset [95594] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT always speculates integer on modulo
https://bugs.webkit.org/show_bug.cgi?id=68485

Reviewed by Oliver Hunt.

Added support for double modulo, which is a call to fmod().
Also added support for recording the old JIT's statistics
on op_mod and propagating them along the graph. Finally,
fixed a goof in the ArithNodeFlags propagation logic that
was made obvious when I started testing ArithMod.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

18:49 Changeset [95593] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Support for multiple <link rel="icon"> favicon elements.
https://bugs.webkit.org/show_bug.cgi?id=65564

Patch by Rachel Blum <groby@chromium.org> on 2011-09-20
Reviewed by Darin Fisher.

No tests - purely an API change. (And API is not exposed to LayoutTests)

  • dom/Document.cpp:

(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):

  • dom/Document.h:
  • dom/IconURL.cpp:

(WebCore::toIconIndex):

  • dom/IconURL.h:

(WebCore::IconURL::IconURL):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • loader/LinkLoader.h:
  • loader/icon/IconController.cpp:

(WebCore::IconController::urlsForTypes):
(WebCore::IconController::appendToIconURLs):
(WebCore::IconController::defaultURL):

18:48 Changeset [95592] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=68495

Reviewed by Dimitri Glazkov.

This patch adds an implementation of Function.prototype.bind if the browser lacks one.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
18:30 Changeset [95591] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

[css3-flexbox] cleanup padding width calculations
https://bugs.webkit.org/show_bug.cgi?id=68490

Reviewed by Tony Chang.

No new tests. Existing tests cover the refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:
18:07 Changeset [95590] by jcivelli@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

This CL makes it possible to create a blob from Chromium.
https://bugs.webkit.org/show_bug.cgi?id=68286

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebBlob.h: Added.
  • src/WebBlob.cpp: Added.
18:04 Changeset [95589] by keishi@webkit.org
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

[chromium] rebaseline caused by r95567

  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-linux-x86/fast/clip: Removed.
  • platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
17:48 Changeset [95588] by eric@webkit.org
  • 4 edits in trunk

[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781

Reviewed by Ryosuke Niwa.

Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
For http tests, since the test url is an http url, we can't resolve relative
to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
for resolving.

I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.

It turns out that there was a second use for pathToLocalResource, used by one
test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
To support this test I made the new pathToLocalResource smart enough to map
/tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::pathToLocalResource):

  • Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
17:34 Changeset [95587] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Need to specify a django version, instead of using default
https://bugs.webkit.org/show_bug.cgi?id=68398

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

  • QueueStatusServer/init.py:
  • QueueStatusServer/main.py:
17:16 Changeset [95586] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang compile errors in Web Audio
https://bugs.webkit.org/show_bug.cgi?id=68384

Reviewed by David Levin.

No new tests; no net change in functionality.

  • platform/graphics/MediaPlayer.h: Forward declare (instead of including directly)

AudioSourceProvider.

  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput): Remove unused parameter name.

17:05 Changeset [95585] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of PluginView::setBoundsSize from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68489

Reviewed by Dan Bernstein.

Remove m_boundsSize and the setter since they aren't used anywhere.

  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Plugins/PluginView.h:
17:04 Changeset [95584] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update committers.py with a few more contributor contacts
https://bugs.webkit.org/show_bug.cgi?id=68487

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
16:53 Changeset [95583] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix webkitpy unit tests after 95547 and 95549
https://bugs.webkit.org/show_bug.cgi?id=68483

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Adam Barth.

Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing

parse_entries_from_file(), use StringIO and entry.reviewer_text().
While testing parse_latest_entry_from_file(), expect the correct
touched_files() list.

16:49 Changeset [95582] by johnnyg@google.com
  • 4 edits in trunk

Directory Upload: parent path can truncate first char of the correct path
https://bugs.webkit.org/show_bug.cgi?id=66695

Source/WebCore:

In some cases, if the parent path we compute ends with a separator
character like '/' or 'C:\', by adding one in an attempt to grab the
subsequent separator we actually grab a character of the real path,
which is incorrect.

Reviewed by Darin Fisher.

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFileList):

LayoutTests:

Add a test case for when the parent path is '/'.

Reviewed by Darin Fisher.

  • fast/forms/input-file-directory-upload.html:
16:43 Changeset [95581] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic makes it hard to compare images when scroll bars appear
https://bugs.webkit.org/show_bug.cgi?id=68482

Reviewed by Eric Seidel.

Because we autoscale image width, the images rescale if we overflow
vertically and get a scrollbar. That makes it hard to compare two sets
of images. This patch reserves space for the scrollbar so we won't
have the layout change.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
16:31 Changeset [95580] by jochen@chromium.org
  • 6 edits
    3 adds in trunk

Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
https://bugs.webkit.org/show_bug.cgi?id=68279

Reviewed by Adam Barth.

Source/WebCore:

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::willSendRequest):

LayoutTests:

  • http/tests/security/resources/cross-origin-xsl-redirect.xml:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
  • platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
  • platform/chromium/http/tests/permissionclient/image-permissions.html:
16:17 Changeset [95579] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045

Fix per Daniel's review comment since I had misunderstood the code.

  • team.html:
15:57 Changeset [95578] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/Websites/webkit.org

Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045

Reviewed by Daniel Bates.

Add the initial implementation of team.html. This page automatically pulls data from committers.py
There are no areas of expertise but that'll be added once the bug 68061 is fixed.

  • team.html: Added.
15:46 Changeset [95577] by ojan@chromium.org
  • 7 edits
    2 adds in trunk

change RenderFlexibleBox to act on logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=68129

Reviewed by David Hyatt.

Source/WebCore:

This makes RenderFlexibleBox respect direction and writing-mode.
We now properly support the default flex-flow value of "row".

Test: css3/flexbox/writing-modes.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setLogicalLocationForChild):

  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
(WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/resources/flexbox.js:
  • css3/flexbox/writing-modes-expected.txt: Added.
  • css3/flexbox/writing-modes.html: Added.
15:39 Changeset [95576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object returned from
FontPlatformData::hashTableDeletedFontValue() to avoid global destructor ordering problems.
https://bugs.webkit.org/show_bug.cgi?id=67906

Patch by Marshall Greenblatt <marshall@chromium.org> on 2011-09-20
Reviewed by Adam Barth.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
15:37 Changeset [95575] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] remove obsolete WebPermissionClient::allowImages method
https://bugs.webkit.org/show_bug.cgi?id=68380

Reviewed by Darin Fisher.

  • DEPS:
  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowImage):

15:33 Changeset [95574] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

  • editing/selection/click-on-body-margin-expected.txt: Added.
  • editing/selection/click-on-body-margin.html: Added.
  • editing/selection/click-on-head-margin-expected.txt: Added.
  • editing/selection/click-on-head-margin.html: Added.
15:23 Changeset [95573] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=68480

De-virtualize containingBlock() and make RenderView return 0 instead
of itself to make the construction of normal loops that terminate via
a null-check possible.

Fix the only two places in the tree that needed null checks.

Eliminating RenderTableCell::containingBlock() is fine since the base class
does the same thing anyway.

Reviewed by Simon Fraser.

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
15:16 Changeset [95572] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt] QTouchWebView missing signal tests for loadProgress
https://bugs.webkit.org/show_bug.cgi?id=68442

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Chang Shu.

Added test case to check load progress signal for QTouchWebView

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
14:59 Changeset [95571] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[CSSRegions] Need test case for 66198 (sliced line box rendering)
https://bugs.webkit.org/show_bug.cgi?id=68257

Patch by Alan Stearns <stearns@adobe.com> on 2011-09-20
Reviewed by David Hyatt.

  • fast/regions/resources/helper.js:

(assertTopLeftMatch):
(sameTopLeft):

  • fast/regions/no-split-line-box-expected.txt: Added.
  • fast/regions/no-split-line-box.html: Added.
14:47 Changeset [95570] by andersca@apple.com
  • 7 edits in trunk/Source

Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188

Reviewed by Darin Adler.

../WebCore:

Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/wx/ScrollViewWx.cpp:

../WebKit/mac:

When creating the document view, make sure it's zero sized which matches the initial size
of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
size to a zero size anyway.

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]):

14:14 Changeset [95569] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r95565.
http://trac.webkit.org/changeset/95565
https://bugs.webkit.org/show_bug.cgi?id=68470

Broke builds (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20

Source/WebKit2:

  • GNUmakefile.am:
  • Shared/API/c/WKHitTestResult.cpp: Removed.
  • Shared/API/c/WKHitTestResult.h: Removed.
  • UIProcess/API/C/WebKit2.h:

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(mouseDidMoveOverElement):

14:08 Rebaseline edited by scottmg@chromium.org
example out of date (?) (diff)
14:01 Changeset [95568] by alexis.menard@openbossa.org
  • 9 edits
    1 add in trunk/Source

[Qt] [WK2] Implement a persistent cookie storage.
https://bugs.webkit.org/show_bug.cgi?id=65309

Reviewed by Chang Shu.

Source/WebCore:

Implement a cookie storage for the Qt port on WebKit2.
The implementation is using a SQLite database to store the cookies
and restore them. It uses a static object as CookieJar is not an
object but a set of global functions. The actual saving/restoring is on
the WebProcess side where our network stack lives.

Existing tests cover the new implementation. Unfortunately there is one
case that we can't easily simulate : login in a website, make sure that the webprocess
is not running and then going back to this website and see that we are logged.

  • WebCore.pri:
  • WebCore.pro:
  • platform/qt/CookieJarQt.cpp:

(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
(WebCore::SharedCookieJarQt::shared):
(WebCore::SharedCookieJarQt::create):
(WebCore::SharedCookieJarQt::destroy):
(WebCore::SharedCookieJarQt::getHostnamesWithCookies):
(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
(WebCore::SharedCookieJarQt::~SharedCookieJarQt):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::ensureDatabaseTable):
(WebCore::SharedCookieJarQt::loadCookies):

  • platform/qt/CookieJarQt.h: Added.

Source/WebKit2:

Add parameter to the WebProcess creation to specify where cookies should be saved.
It also use the new cookie storage implementation and set it to our network stack
so cookies are used when using it.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

13:26 Changeset [95567] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68314

Make sure that the containing block loop when clipping to border-radius
terminates by checking if you hit the RenderView. Null checking isn't sufficient
for stupid historical reasons that should be fixed (i.e., the RenderView returns itself
as its own containing block, even though this should just be changed).

Reviewed by Simon Fraser and Darin Adler.

Added new test in fast/clip.

  • rendering/RenderLayer.cpp:

(WebCore::inContainingBlockChain):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68314

Added some more clipping tests for overflow to make sure the right things happen
when border-radius is specified.

Reviewed by Simon Fraser and Darin Adler.

  • fast/clip/overflow-border-radius-fixed-position.html: Added.
  • platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
13:21 Changeset [95566] by mitz@apple.com
  • 38 edits in trunk

MathML renderers do not override RenderObject::renderName()
https://bugs.webkit.org/show_bug.cgi?id=68461

Reviewed by Darin Adler.

Source/WebCore:

Added implementations of renderName() in MathML RenderObject subclasses.

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::renderName):

  • rendering/mathml/RenderMathMLFenced.h:

(WebCore::RenderMathMLFenced::renderName):

  • rendering/mathml/RenderMathMLFraction.h:

(WebCore::RenderMathMLFraction::renderName):

  • rendering/mathml/RenderMathMLMath.h:

(WebCore::RenderMathMLMath::renderName):

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::renderName):

  • rendering/mathml/RenderMathMLRoot.h:

(WebCore::RenderMathMLRoot::renderName):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::renderName):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(WebCore::RenderMathMLSquareRoot::renderName):

  • rendering/mathml/RenderMathMLSubSup.h:

(WebCore::RenderMathMLSubSup::renderName):

  • rendering/mathml/RenderMathMLUnderOver.h:

(WebCore::RenderMathMLUnderOver::renderName):

LayoutTests:

  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/msub-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msub-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/msup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
13:16 Changeset [95565] by commit-queue@webkit.org
  • 5 edits
    2 copies in trunk

Source/WebKit2: Added WKHitTestResult API's.

WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Shared/API/c/WKHitTestResult.cpp: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.

(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):

  • Shared/API/c/WKHitTestResult.h: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
  • UIProcess/API/C/WebKit2.h:

Tools: Get hover'ed element URL from HitTest.

mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

  • MiniBrowser/gtk/BrowserWindow.c:

(mouseDidMoveOverElement):

13:13 Changeset [95564] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] requestAnimationFrame support for gtk port
https://bugs.webkit.org/show_bug.cgi?id=66280

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-09-20
Reviewed by Martin Robinson.

.:

  • configure.ac: Add an option to enable requestAnimationFrame for gtk port.

Source/JavaScriptCore:

Let GTK port use REQUEST_ANIMATION_FRAME_TIMER.

  • wtf/Platform.h:

Source/WebCore:

Add some files to build-target & activate ENABLE_REQUEST_ANIMATION_FRAME flag
when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • GNUmakefile.am:
  • GNUmakefile.list.am:
13:10 Changeset [95563] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT performs too many negative zero checks, and too many
overflow checks
https://bugs.webkit.org/show_bug.cgi?id=68430

Reviewed by Oliver Hunt.

This adds comprehensive support for deciding how to perform an
arithmetic operations based on a combination of overflow profiling,
negative zero profiling, value profiling, and a static analysis of
how the results of these operations get used.

This is a 72% speed-up on stanford-crypto-sha256-iterative, and a
2.5% speed-up on the Kraken average, a 1.4% speed-up on the V8
geomean, and neutral on SunSpider. It's also an 8.5% speed-up on
V8-crypto, because apparenty everything we do speeds up crypto.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::weaklyPredictInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):

  • dfg/DFGNode.h:

(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::arithNodeFlagsAsString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::rawArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::arithNodeFlagsForCompare):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

13:05 Changeset [95562] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.

  • LayoutTests/platform/chromium/test_expectations.txt:
12:05 Changeset [95561] by mihaip@chromium.org
  • 2 edits
    5 copies in branches/chromium/874/LayoutTests

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556

Source/WebCore:

Reviewed by Adam Barth.

Tests: http/tests/history/back-with-fragment-change.php

http/tests/navigation/navigation-interrupted-by-fragment.html

  • loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
  • loader/HistoryController.cpp: Don't commit the wrong provisional item.

LayoutTests:

Reviewed by Adam Barth.

Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.

  • fast/loader/page-dismissal-modal-dialogs.html:
  • fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
  • http/tests/history/back-with-fragment-change-expected.txt: Added.
  • http/tests/history/back-with-fragment-change.php: Added.
  • http/tests/history/resources/back-with-fragment-change-target.html: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment.html: Added.

TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/7983013

11:58 Changeset [95560] by aa@chromium.org
  • 11 edits
    2 adds in trunk/Source

Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.h:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::~Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Equals):
(WebKit::ContextLifetimeTestWebFrameClient::~ContextLifetimeTestWebFrameClient):
(WebKit::ContextLifetimeTestWebFrameClient::reset):
(WebKit::ContextLifetimeTestWebFrameClient::didCreateScriptContext):
(WebKit::ContextLifetimeTestWebFrameClient::willReleaseScriptContext):

  • tests/data/context_notifications_test.html: Added.
  • tests/data/context_notifications_test_frame.html: Added.
11:31 Changeset [95559] by oliver@apple.com
  • 15 edits
    3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

  • heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

  • ForwardingHeaders/heap/AllocationSpace.h: Added.
11:20 Changeset [95558] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCorePrefix.h: Removed stray text from accidental paste.
11:17 Changeset [95557] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-09-20 Pavel Feldman <pfeldman@google.com>

Not reviewed: one line inspector's script-formatter.html fix.

  • inspector/debugger/script-formatter.html:
11:09 Changeset [95556] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
https://bugs.webkit.org/show_bug.cgi?id=66855

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-20
Reviewed by Antonio Gomes.

Most other ports call this method somewhere when the frame is being
removed, as it performs some destruction calls which, in our case, at
least makes sure onunload events get delivered properly in
fast/frames/iframe-reparenting-adopt-node.html.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_del): Call FrameLoader::detachFromParent()

11:02 Changeset [95555] by ggaren@apple.com
  • 39 edits in trunk/Source

Removed BREWMP* platform #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68425

BREWMP* has no maintainer, and this is dead code.

Reviewed by Darin Adler.

../JavaScriptCore:

  • heap/MarkStack.h:

(JSC::::shrinkAllocation):

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

  • runtime/TimeoutChecker.cpp:

(JSC::getCPUTime):

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/CurrentTime.cpp:
  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset):

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastMallocSize):

  • wtf/FastMalloc.h:
  • wtf/MainThread.cpp:
  • wtf/MathExtras.h:
  • wtf/OwnPtrCommon.h:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

  • wtf/text/WTFString.h:
  • wtf/unicode/Unicode.h:

../WebCore:

  • WebCorePrefix.h:
  • loader/cache/CachedFont.cpp:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/Widget.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/text/TextBoundaries.cpp:
  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:
  • plugins/PluginViewNone.cpp:
10:47 Changeset [95554] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Copy Stack Trace lacks newlines on Windows
https://bugs.webkit.org/show_bug.cgi?id=68447

Reviewed by Joseph Pecoraro.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

10:44 Changeset [95553] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-09-20 Pavel Feldman <pfeldman@google.com>

Not reviewed: inspector sanity test fix.

  • inspector/front-end/inspector.js: (WebInspector.showConsole):
10:15 Changeset [95552] by jamesr@google.com
  • 8 edits in branches/chromium/874/Source/WebCore

Merge 95506 - [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7982004

10:08 Changeset [95551] by alexis.menard@openbossa.org
  • 6 edits
    4 adds in trunk/Source

[Qt][WK2] Add stubs for FULLSCREEN_API on Qt.
https://bugs.webkit.org/show_bug.cgi?id=68444

Reviewed by Andreas Kling.

Create all the stubs necessary for enabling FULLSCREEN_API on the Qt port.

Source/WebCore:

No new tests : just stubs.

  • CodeGenerators.pri:
  • WebCore.pro:
  • features.pri:

Source/WebKit2:

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Added.

(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::getFullScreenRect):

  • WebKit2.pro:
  • WebProcess/FullScreen/qt: Added.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Added.

(WebKit::WebFullScreenManagerQt::WebFullScreenManagerQt):
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManagerQt::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerQt::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerQt::beginExitFullScreenAnimation):

  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Added.
09:46 Changeset [95550] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r95509.
http://trac.webkit.org/changeset/95509
https://bugs.webkit.org/show_bug.cgi?id=68446

crashes chromium fast/repaint/japanese-rl-selection-repaint-
in-regions.html on Win and Linux (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

  • editing/selection/click-on-body-margin-expected.txt: Removed.
  • editing/selection/click-on-body-margin.html: Removed.
  • editing/selection/click-on-head-margin-expected.txt: Removed.
  • editing/selection/click-on-head-margin.html: Removed.
09:45 Changeset [95549] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Changelog class should have a method to return all entries
https://bugs.webkit.org/show_bug.cgi?id=68399

Implement ChangeLog.parse_entries_from_file(). This method returns a generator
of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()

and adapt it to become a generator.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
09:41 Changeset [95548] by commit-queue@webkit.org
  • 10 edits
    8 adds in trunk

Source/WebCore: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath):

Source/WebKit/qt: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

New test case makes sure a qrc URL will properly load a user stylesheet.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

(tst_QWebPage::userStyleSheetFromQrcUrl):

  • tests/qwebpage/tst_qwebpage.qrc:

Tools: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTree.qrc: Added.
  • DumpRenderTree/qt/resources/user.css: Added.

(body):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
  • WebKitTestRunner/qt/resources/user.css: Added.

(body):

LayoutTests: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

New platform layout test since user style sheet is testable from DRT.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/loader/user-stylesheet-qrc-path-expected.txt: Added.
  • platform/qt/fast/loader/user-stylesheet-qrc-path.html: Added.
09:31 Changeset [95547] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

ChangeLogEntry class should contain a list of touched files
https://bugs.webkit.org/show_bug.cgi?id=68115

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Eric Seidel.

Add method to return the list of files touched in a ChangeLog entry.

  • Scripts/webkitpy/common/checkout/changelog.py: Add

touched_files_regexp and touched_files() method.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement

unit tests for touched_files() method.

09:27 Changeset [95546] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectationd and file WK68445.

  • platform/chromium/test_expectations.txt:
09:08 Changeset [95545] by alexis.menard@openbossa.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Export QNetworkReply in the QtWebKit QML module.
https://bugs.webkit.org/show_bug.cgi?id=68401

Reviewed by Simon Hausmann.

Add QNetworkReply in the QtWebKit module. We use the enum QNetworkReply::NetworkError
as the error code when the load fails. It is not used in the QtQuick module therefore
the QML team thinks it should belong here. Also added some auto-tests to cover the
loading errors.

  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Added.
08:46 Changeset [95544] by ossy@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r95526 and r95541.
http://trac.webkit.org/changeset/95526
http://trac.webkit.org/changeset/95541
https://bugs.webkit.org/show_bug.cgi?id=68443

It broke 6 tests (Requested by ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20

  • DumpRenderTree/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

08:43 Changeset [95543] by commit-queue@webkit.org
  • 16 edits in trunk/Tools

Fix patch and bug numbering in the mocktool simulation code
https://bugs.webkit.org/show_bug.cgi?id=68374

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
07:57 Changeset [95542] by ossy@webkit.org
  • 5 edits in trunk/Source

Source/WebCore: [Qt][Mac] Buildfix after r95513.
Forwarding headers for WebCore should be generated based on WebCore sources instead of WebKit2.

Rubber-stamped by Andras Becsi.

  • DerivedSources.pro:
  • WebCore.pro: Add platform/mac/DisplaySleepDisabler.cpp to SOURCES.

Source/WebKit2: [Qt][Mac] Buildfix after r95513.

Rubber-stamped by Andras Becsi.

  • Scripts/generate-forwarding-headers.pl: Add mm file supporting.
07:22 Changeset [95541] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't override default QApplication font for DRT and WTR

Revision 95526 moved the relevant code below the QApplication
constructor, to fix a potential crash, and that made the code
take effect, breaking 6 tests.

We should rely on the QWebSettings to set default fonts, and
this QApplication::setFont() is a relic from when we didn't
have that option, so we remove the code.

Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/qt/main.cpp:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
07:08 Changeset [95540] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95523

  • wtf/CheckedArithmetic.h: Added stdint.h so we can have int64_t defined.
07:03 Changeset [95539] by caryclark@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed.
  • LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
07:00 Changeset [95538] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: document Debugger.paused, introduce types for ids in Debugger domain.
https://bugs.webkit.org/show_bug.cgi?id=68363

Migrates from poorly documented "details" object to explicit parameters
containing break type and data.

Reviewed by Tony Gentilcore.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

():

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::pause):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerDispatcher.prototype.paused):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresentationCallFrame.prototype.evaluate):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

06:58 Changeset [95537] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[Qt] QDesktopWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68280

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Andreas Kling.

Added test case to check load progress property and signal for QDesktopWebView

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
06:51 Changeset [95536] by pfeldman@chromium.org
  • 9 edits in trunk

Source/WebCore: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio. Remove animation
from drawer -> panel transition.
https://bugs.webkit.org/show_bug.cgi?id=68155

ConsoleView, ConsolePanel and Drawer are all Views with custom show/hide implementations
and weird DOM element containment. As a result, we have a number of cases when switching
console from full panel to drawer mode and back result in UI glitches.
For the sake of code clarity and no glitches, I'd like to sacrifice the "grow into full
screen" console animation.

Reviewed by Tony Gentilcore.

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.get statusBarItems):
(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.createFilterElement):
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.wasShown):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.get visible):
(WebInspector.Drawer.prototype._constrainHeight):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._animationDuration):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._toggleConsoleButtonClicked):
(WebInspector.set attached):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):

LayoutTests: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio.
https://bugs.webkit.org/show_bug.cgi?id=68155

Reviewed by Tony Gentilcore.

  • inspector/console/console-dir.html:
06:46 Changeset [95535] by pfeldman@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: streamline Console's MessageType and MessageSource semantics.
https://bugs.webkit.org/show_bug.cgi?id=68342

Source/WebCore:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype.toString):

  • page/Console.cpp:

(WebCore::printMessageSourceAndLevelPrefix):
(WebCore::Console::addMessage):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):

  • page/ConsoleTypes.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream):

Source/WebKit/mac:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageSource):
(stringForMessageType):

  • WebView/WebUIDelegatePrivate.h:

LayoutTests:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • inspector/protocol/console-agent-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
06:37 Changeset [95534] by timothy@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Make WebViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WebView
and WebHTMLView need to also observe the will order on/off screen notifications.

https://webkit.org/b/68402
rdar://problem/9754099

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
(-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
(-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
which can be the case for NSPopovers.
(-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
(-[WebView removeWindowObservers]): Remove order off screen notification obverser.
(-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
(-[WebView _windowWillOrderOffScreen:]): Ditto.

05:45 Changeset [95533] by philn@webkit.org
  • 1 edit
    58 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/css3/bdi-element-expected.png: Added.
  • platform/gtk/css3/bdi-element-expected.txt: Added.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Added.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
  • platform/gtk/css3/unicode-bidi-isolate-basic-expected.png: Added.
  • platform/gtk/css3/unicode-bidi-isolate-basic-expected.txt: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-longhand-expected.png: Added.
  • platform/gtk/fast/borders/border-image-longhand-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/gtk/fast/borders/border-image-massive-scale-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-repeat-expected.png: Added.
  • platform/gtk/fast/borders/border-image-repeat-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scaled-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scaled-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scaled-gradient-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-slices-expected.png: Added.
  • platform/gtk/fast/borders/border-image-slices-expected.txt: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/gtk/fast/css/line-after-floating-div-expected.png: Added.
  • platform/gtk/fast/css/line-after-floating-div-expected.txt: Added.
  • platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.txt: Added.
  • platform/gtk/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/gtk/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/gtk/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/gtk/svg/custom/pattern-rotate-gaps-expected.txt: Added.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Added.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Added.
05:34 Changeset [95532] by vestbo@webkit.org
  • 2 edits in trunk/Tools

WebKitTestRunner: Provide usage if run without arguments

If WTR is run without either one or more filenames, or
a '-' to indicate server mode, we don't need to start
up the test machinery. Doing so might actually crash,
as we'll exit the application immedeatly after anyways.

Reviewed by Simon Hausmann.

05:25 Changeset [95531] by philn@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r95489 and r95488.

  • platform/gtk/http/tests/security/document-all-expected.txt: Added.
  • platform/gtk/http/tests/security/window-named-proto-expected.txt: Added.
05:14 Changeset [95530] by philn@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r95461.

  • platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
05:10 Changeset [95529] by reni@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Rebase and unskip tests introduced in r95489 and r95488.

Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/document-all-expected.txt: Added.
  • platform/qt/http/tests/security/window-named-proto-expected.txt: Added.
04:50 Changeset [95528] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing fast/files/create-blob-url-crash.html on
GTK because of bug 66045.

  • platform/gtk/Skipped:
04:43 Changeset [95527] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95178 and r95362.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
04:36 Changeset [95526] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't use QFont before initializing QApplication

Could potentially result in crash.

Reviewed by Simon Hausmann.

03:41 Changeset [95525] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Qt] resizeToContent seems to trigger infinite resize on some pages
https://bugs.webkit.org/show_bug.cgi?id=43852

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

InnerHeight and InnerWidth are now calculated using ScrollView::visibleContentRect
including the scrollbars (if any) instead of using ScrollView::frameRect as before.

This makes no behavior change while not using the tiled backing
store and is compliant with the W3C definition stated in the CSSOM
View Module.

Plus it will return the correct values for tiled backing store,
thus fixing the original bug report by avoiding infinite resize
events caused by wrong innerHeight and innerWidth values.

Test: innerWidth/Height are covered by existing tests. The
non-infinite resizing is covered by a new Qt autotest at
test_qgraphicswebview::windowResizeEvent()

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight): using ScrollView::visibleContentRect.
(WebCore::DOMWindow::innerWidth): using ScrollView::visibleContentRect.

Source/WebKit/qt:

Test by Luiz Agostini.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(ResizeSpy::receiveResize):
(ResizeSpy::size):
(tst_QGraphicsWebView::windowResizeEvent):

03:22 Changeset [95524] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: implement reverse mapping for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=67850

Source/WebCore:

Implement the mapping from source code to compiled code. It will be used for
setting breakpoints on source code.

Reviewed by Pavel Feldman.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/compiler-source-mapping.html:
02:41 Changeset [95523] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG JIT does not speculate aggressively enough on GetById
https://bugs.webkit.org/show_bug.cgi?id=68320

Reviewed by Oliver Hunt.

This adds the ability to access properties directly, by offset.
This optimization kicks in when at the time of DFG compilation,
it appears that the given get_by_id is self-cached by the old JIT.
Two new opcodes get introduced: CheckStructure and GetByOffset.
CheckStructure performs a speculation check on the object's
structure, and returns the storage pointer. GetByOffset performs
a direct read of the field from the storage pointer. Both
CheckStructure and GetByOffset can be CSE'd, so that we can
eliminate redundant structure checks, and redundant reads of the
same field.

This is a 4% speed-up on V8, a 2% slow-down on Kraken, and
neutral on SunSpider.

  • bytecode/PredictedType.cpp:

(JSC::predictionFromClassInfo):
(JSC::predictionFromStructure):
(JSC::predictionFromCell):

  • bytecode/PredictedType.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::fillStorage):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::storageResult):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):

  • dfg/DFGNode.h:

(JSC::DFG::OpInfo::OpInfo):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::structure):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::storageAccessDataIndex):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • wtf/StdLibExtras.h:

(WTF::safeCast):

02:28 Changeset [95522] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: extract RawSourceCode source mapping logic to helper classes.
https://bugs.webkit.org/show_bug.cgi?id=67789

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.get uiSourceCode):

01:58 Changeset [95521] by carlosgc@webkit.org
  • 11 edits
    2 adds in trunk/Source

[GTK] WebProcess shouldn't use the GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68062

Reviewed by Martin Robinson.

Source/WebCore:

Move errors code that is common between webki1 and webkit2 to
WebCore so that it can be shared.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/ErrorsGtk.cpp: Added.

(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):

  • platform/gtk/ErrorsGtk.h: Added.

Source/WebKit/gtk:

Use WebCore API to create errors in frame loader.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::cancelledError):
(WebKit::FrameLoaderClient::blockedError):
(WebKit::FrameLoaderClient::cannotShowURLError):
(WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
(WebKit::FrameLoaderClient::cannotShowMIMETypeError):
(WebKit::FrameLoaderClient::fileDoesNotExistError):
(WebKit::FrameLoaderClient::pluginWillHandleLoadError):

  • webkit/webkiterror.cpp:

(webkit_network_error_quark):
(webkit_policy_error_quark):
(webkit_plugin_error_quark):

Source/WebKit/gtk/po:

  • POTFILES: Remove FrameLoaderGtk.cpp and add ErrorsGtk.cpp.

Source/WebKit2:

Use WebCore API to create errors in WebProcess.

  • GNUmakefile.am: Don't use webkit/webkierror.h.
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):

01:36 Changeset [95520] by reni@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

[Qt] Add Qt specific expecteds to new tests introduced in r95461.

Unreviewed gardening.

  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
01:05 Changeset [95519] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests fail after r95488 & r95489
https://bugs.webkit.org/show_bug.cgi?id=68428

Skip the failing tests.

Unreviewed gardening.

  • platform/qt/Skipped:
00:57 Changeset [95518] by carlosgc@webkit.org
  • 4 edits in trunk

2011-09-20 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.90 release

Reviewed by Martin Robinson.

  • configure.ac:

2011-09-20 Philippe Normand <pnormand@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.90 release

Reviewed by Martin Robinson.

  • NEWS:

09/19/11:

23:33 Changeset [95517] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

  • platform/mac/DisplaySleepDisabler.h:
21:33 Changeset [95516] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Darin Adler.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
21:30 Changeset [95515] by ggaren@apple.com
  • 1 edit in trunk/Source/cmake/OptionsWinCE.cmake

Removing one last case of DENABLE_JSC_MULTIPLE_THREADS -- the cmake folder doesn't seem to have a ChangeLog

21:24 Changeset [95514] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

Missed this one case before.

  • features.gypi:
21:14 Changeset [95513] by mrowe@apple.com
  • 11 edits
    2 copies in trunk/Source

<http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect

On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
a NoIdleSleep assertion as the latter is implied by the former.

Source/WebCore:

Since there were multiple copies of the same code to disable display sleep spread across WebCore, WebKit and WebKit2
this patch takes the approach of moving this functionality to a new DisplaySleepDisabler class that lives in WebCore.
A class is used as it makes it easier to reason about the lifetime of the assertions and to ensure that the assertions will
always be released when their owning objects go away.

Reviewed by Dan Bernstein.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler): Register for the NoDisplaySleep assertion, and start our
system activity timer when on Leopard.
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): Unregister for the assertion.
(WebCore::DisplaySleepDisabler::systemActivityTimerFired): Call UpdateSystemActivity to prevent the screensaver from
triggering on Leopard.

  • platform/mac/DisplaySleepDisabler.h:

(WebCore::DisplaySleepDisabler::create):

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController setupVideoOverlay:]): Remove the now-unnecessary explicit use of the WebCore namespace.
(-[WebVideoFullscreenController mediaElement]): Ditto.
(-[WebVideoFullscreenController setMediaElement:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Ditto.
(-[WebVideoFullscreenController updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit/mac:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController dealloc]):
(-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit2:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WKFullScreenWindowController.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own. Also adds a FIXME about an error that was noticed while working in this code.

21:05 Changeset [95512] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed ENABLE_LAZY_BLOCK_FREEING and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68424

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

  • heap/Heap.h:
  • wtf/Platform.h:
20:55 Changeset [95511] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_WTF_MULTIPLE_THREADS and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68423

As discussed on webkit-dev. All ports build with threads enabled in WTF now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • wtf/CryptographicallyRandomNumber.cpp:

(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):

  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::pow5mult):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

20:35 Changeset [95510] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Sam Weinig.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

  • API/JSContextRef.cpp:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::gatherConservativeRoots):

  • heap/MachineStackMarker.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):
(JSC::initializeThreading):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/JSLock.cpp:
  • runtime/Structure.cpp:
  • wtf/Platform.h:
19:48 Changeset [95509] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element (any immediate child of render view with a render layer)
since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

  • editing/selection/click-on-body-margin-expected.txt: Added.
  • editing/selection/click-on-body-margin.html: Added.
  • editing/selection/click-on-head-margin-expected.txt: Added.
  • editing/selection/click-on-head-margin.html: Added.
19:07 Changeset [95508] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Ask for audio hardware buffer size instead of using hardwired constants.
https://bugs.webkit.org/show_bug.cgi?id=67952

Patch by Raymond Toy <rtoy@google.com> on 2011-09-19
Reviewed by Kenneth Russell.

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::audioHardwareBufferSize): Declare
new member function audioHardwareBufferSize.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Call audioHardwareBufferSize() to get buffer size; update
m_callbackBuffersize and m_renderCountPerCallback appropriately.
Remove global variables callbackBufferSize and
renderCountPerCallback. Add constant for maximum
allowed buffer size and verify we don't exceed it.
(WebCore::AudioDestinationChromium::render): Use new member
variables instead of globals.

  • src/AudioDestinationChromium.h:

Define new member variables m_callbackBufferSize and
m_renderCountPerCallback

18:53 Changeset [95507] by commit-queue@webkit.org
  • 15 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r95493 and r95496.
http://trac.webkit.org/changeset/95493
http://trac.webkit.org/changeset/95496
https://bugs.webkit.org/show_bug.cgi?id=68418

Broke Windows build (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/JavaScriptCore:

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Removed.
  • heap/AllocationSpace.h: Removed.
  • heap/Heap.cpp:

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

Source/WebCore:

  • ForwardingHeaders/heap/AllocationSpace.h: Removed.
18:49 Changeset [95506] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

18:44 Changeset [95505] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, missed stylebot comments in last commit.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

18:41 Changeset [95504] by barraclough@apple.com
  • 9 edits
    3 adds in trunk

String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::jsStringWithReuse):

  • added helper function to reuse original JSString value.

(JSC::stringProtoFuncSplit):

  • Rewritten from the spec.
  • tests/mozilla/ecma/String/15.5.4.8-2.js:

(getTestCases):

  • This test is not ES5 compliant.

LayoutTests:

  • fast/js/script-tests/string-split-conformance.js: Added.
  • fast/js/string-split-conformance-expected.txt: Added.
  • fast/js/string-split-conformance.html: Added.
    • Added new Layout test based on:

http://stevenlevithan.com/demo/split.cfm

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T7-expected.txt:
18:21 Changeset [95503] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Removed lots of friend declarations from JSCell, so we can more
effectively make use of private and protected.

Reviewed by Sam Weinig.

  • runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of

confusion for not much safety.
(JSC::JSCell::operator new): Made this public because it is used by a
few clients, and not really dangerous.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasCustomProperties):
(JSC::JSObject::hasGetterSetterProperties):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::finishCreation):
(JSC::JSObject::prototype):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
structure() / setStructure(), so we don't have to be a friend of JSCell.

  • runtime/Structure.h:

(JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
to JSCell::m_structure.

18:20 Changeset [95502] by macpherson@chromium.org
  • 17 edits in trunk/Source/WebCore

Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType.
https://bugs.webkit.org/show_bug.cgi?id=68057

Reviewed by Darin Adler.

There appear to be many cases where -1 is actually a valid Length.
Encoding the validity of Length separately to the value is a natural solution.

No new tests / no behavioral changes.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

  • platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::value):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialMaxSize):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):

18:04 Changeset [95501] by abarth@webkit.org
  • 33 edits in trunk

Always enable ENABLE(EVENTSOURCE)
https://bugs.webkit.org/show_bug.cgi?id=68414

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

EventSource seems to be here to stay. This patch makes WebKit more
hackable by removing this ENABLE macro, as discussed on webkit-dev.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • features.pri:
  • page/DOMWindow.idl:
  • page/EventSource.cpp:
  • page/EventSource.h:
  • page/EventSource.idl:
  • workers/WorkerContext.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
17:56 Changeset [95500] by levin@chromium.org
  • 4 edits in trunk/Tools

Sheriffbot rollout should be more intuitive.
https://bugs.webkit.org/show_bug.cgi?id=68415

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args and a few others cases.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
17:38 Changeset [95499] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
https://bugs.webkit.org/show_bug.cgi?id=68391

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py: Skip asm lines when doing style checks on a line.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
17:35 Changeset [95498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Enable JSC_MULTIPLE_THREADS for OS(QNX).
https://bugs.webkit.org/show_bug.cgi?id=68047

Patch by Eli Fidler <efidler@rim.com> on 2011-09-19
Reviewed by Daniel Bates.

SA_RESTART was required for SIGUSR2-based debugging, but is not
present on QNX. This debugging doesn't seem critical to
JSC_MULTIPLE_THREADS, so allow it to proceed.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

  • wtf/Platform.h: enable PTHREADS for OS(QNX)
17:19 Changeset [95497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a use-after-free: clear the fullscreen change event target queue at
detach time, rather than at destruction time. If this isn't done, it's
possible for the event target queue to be the only thing that
references the document. Then when the document is popped off the queue
and dereferenced in Document::fullScreenChangeDelayTimerFired, the
document is destroyed and the subsequent access to
m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

16:50 Changeset [95496] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

16:49 Changeset [95495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Suppress flakey test on windows in Chromium gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=68408

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

16:48 Changeset [95494] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r95482.
http://trac.webkit.org/changeset/95482
https://bugs.webkit.org/show_bug.cgi?id=68410

Broke chromium webkit-tests (Requested by dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
16:15 Changeset [95493] by oliver@apple.com
  • 14 edits
    3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

  • heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

  • ForwardingHeaders/heap/AllocationSpace.h: Added.
16:13 Changeset [95492] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Unreviewed coding style fix.

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qweberror.h:
16:04 Changeset [95491] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Expose AXObjectCache methods so that WebAccessibilityCache
can be deleted.
https://bugs.webkit.org/show_bug.cgi?id=68225

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-19
Reviewed by Dimitri Glazkov.

This patch exposes the functionality needed from AXObjectCache
with new methods in WebAccessibilityObject and WebDocument.
Next, Chromium will be updated to use only these methods and
not WebAccessibilityCache. Then, WebAccessibilityCache can be
deleted from WebKit.

  • public/WebAccessibilityObject.h:
  • public/WebDocument.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::enableAccessibility):
(WebKit::WebAccessibilityObject::accessibilityEnabled):
(WebKit::WebAccessibilityObject::axID):

  • src/WebDocument.cpp:

(WebKit::WebDocument::accessibilityObject):
(WebKit::WebDocument::accessibilityObjectFromID):

16:02 Changeset [95490] by bbudge@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Perform HTTP method and header validation in AssociatedURLLoader for
requests coming from untrusted code (eg. Native Client in Chrome). Use
the same code as XMLHttpRequest to reduce code duplication and have
behavior identical to XHR in Javascript. Add an 'untrustedHTTP' option
to WebURLLoaderOptions, which AssociatedURLLoader can use to determine
if it should check the request method and headers.
https://bugs.webkit.org/show_bug.cgi?id=67655

Reviewed by Darin Fisher.

  • public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::setDelayedError):
(WebKit::AssociatedURLLoader::loadAsynchronously):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckFails):
(WebKit::TEST_F):

15:57 Changeset [95489] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

[V8] document.all gets confused about its prototype chain
https://bugs.webkit.org/show_bug.cgi?id=68393

Reviewed by Eric Seidel.

Source/WebCore:

GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
not a good idea to use its return value. It turns out that all the
callers of the API only cared about whether it returns a null handle.

Test: http/tests/security/document-all.html

  • bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

LayoutTests:

Test how document.all behaves when you change its prototype chain.

  • http/tests/security/document-all-expected.txt: Added.
  • http/tests/security/document-all.html: Added.
15:56 Changeset [95488] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

Named property confusion with proto
https://bugs.webkit.org/show_bug.cgi?id=68221

Reviewed by Eric Seidel.

Source/WebCore:

The proto property is super magical because it's not a real named
property and it has higher precedence than even interceptors. This
confuses this check, which is meant to detech which names will get
handled by our interceptor.

Test: http/tests/security/window-named-proto.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

LayoutTests:

  • http/tests/security/resources/innocent-victim-with-iframe.html: Added.
  • http/tests/security/window-named-proto-expected.txt: Added.
  • http/tests/security/window-named-proto.html: Added.
15:54 Changeset [95487] by abarth@webkit.org
  • 9 edits in trunk/Source

Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
https://bugs.webkit.org/show_bug.cgi?id=68292

Reviewed by Eric Seidel.

Source/WebCore:

OpenType Sanitizer is a library for sanitizing type and not a feature.
Therefore this macro should say that we USE the library.

  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/WOFFFileFormat.h:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/opentype/OpenTypeSanitizer.cpp:
  • platform/graphics/opentype/OpenTypeSanitizer.h:
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Source/WebKit/chromium:

  • features.gypi:
15:53 Changeset [95486] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.
15:32 Changeset [95485] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.

15:27 Changeset [95484] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

DFG speculation failures should act as additional value profiles
https://bugs.webkit.org/show_bug.cgi?id=68335

Reviewed by Oliver Hunt.

This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.

This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.

By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.

This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::linkDummySlowCase):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

  • jit/JITInlineMethods.h:

(JSC::JIT::addSlowCase):

15:26 Changeset [95483] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r95385 and r95457.
http://trac.webkit.org/changeset/95385
http://trac.webkit.org/changeset/95457
https://bugs.webkit.org/show_bug.cgi?id=68395

Broke chromium browser_tests (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

  • tests/data/context_notifications_test.html: Removed.
  • tests/data/context_notifications_test_frame.html: Removed.
15:23 Changeset [95482] by commit-queue@webkit.org
  • 5 edits in trunk

Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
15:20 Changeset [95481] by aroben@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Let Xcode 4 do its thang with ANGLE.xcodeproj

  • ANGLE.xcodeproj/project.pbxproj:
15:20 Changeset [95480] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r94575

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp

now builds just before FindSafari.

14:56 Changeset [95479] by cmarrin@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-09-19 Chris Marrin <cmarrin@apple.com>

Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Reviewed by Adam Roben.


Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.


This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.

This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
  • platform/win/StructuredExceptionHandlerSupressor.h: Added. (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor): (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):
14:51 Changeset [95478] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect selection with absolutely positioned div
https://bugs.webkit.org/show_bug.cgi?id=39503

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
whether a given point is inside or below the last child box.

Fixed the bug by using the last hit-test candidate instead.

Test: editing/selection/block-with-positioned-lastchild.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Added a regression test for placing the caret inside a block with multiple logical lines
with an absolutely positioned last child. WebKit should place the caret on the left of the first line
(instead of after the last line) when the user clicks on the left of the first line.

  • editing/selection/block-with-positioned-lastchild-expected.txt: Added.
  • editing/selection/block-with-positioned-lastchild.html: Added.
14:48 Changeset [95477] by inferno@chromium.org
  • 1 edit
    15 adds in trunk/LayoutTests

Unreviewed. Chromium Rebaselines for r95461.

  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.
14:47 Changeset [95476] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix crashes when running WebKit1 tests.

-[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
equivalent code directly into -[WebHTMLView drawRect:].

  • WebView/WebHTMLView.mm:

(-[WebHTMLView drawRect:]):

  • WebView/WebViewInternal.h:
14:28 Changeset [95475] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95466.
http://trac.webkit.org/changeset/95466
https://bugs.webkit.org/show_bug.cgi?id=68389

Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toPrimitive):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
14:25 Changeset [95474] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Remove the last remains of viewless WebKit1
https://bugs.webkit.org/show_bug.cgi?id=68388

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::forceLayoutForNonHTML):
Remove null check.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove usesDocumentViews parameter and checks.

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
Add an assertion that usesDocumentViews is always true.

(-[WebView _isUsingAcceleratedCompositing]):
Remove usesDocumentViews check.

(-[WebView _isSoftwareRenderable]):
Remove usesDocumentViews check.

(-[WebView initWithFrame:frameName:groupName:]):
Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.

(-[WebView initWithCoder:]):
Remove usesDocumentViews parameter.

(-[WebView _frameViewAtWindowPoint:]):
Remove usesDocumentViews check.

  • WebView/WebViewData.h:

Remove usesDocumentViews ivar.

  • WebView/WebViewPrivate.h:

Remove usesDocumentViews parameters.

14:10 Changeset [95473] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/loader

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
BUG=86758
Review URL: http://codereview.chromium.org/7945015

14:09 Changeset [95472] by alexis.menard@openbossa.org
  • 12 edits in trunk/Source/WebKit2

[Qt][WK2] Make loading errors API easier to use.
https://bugs.webkit.org/show_bug.cgi?id=68357

Reviewed by Tor Arne Vestbø.

Make the API to get loading errors easier to use. 95197 introduced
a QJSValue API that is a bit opaque for the client code. Rather than
using a dedicated object, we can just pass the needed information as
parameters of the slot.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
14:05 Changeset [95471] by dimich@chromium.org
  • 5 edits
    4 adds in trunk

[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):

  • html/HTMLFrameElementBase.h:

LayoutTests:

  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
  • fast/frames/iframe-reparenting-embed-elements.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.
13:55 Changeset [95470] by andersca@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit

Remove WebViewEventHandling.mm
https://bugs.webkit.org/show_bug.cgi?id=68387

Reviewed by Adam Roben.

../..:

Remove WebViewEventHandling.mm from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

../../mac:

WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
we're getting rid of viewless WebKit1.

  • WebView/WebView.mm:

(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewEventHandling.mm: Removed.
  • WebView/WebViewInternal.h:
13:52 Changeset [95469] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95461 - Child not placed correctly when beforeChild (table part)
has both :before, :after content.
BUG=95520
Review URL: http://codereview.chromium.org/7946014

13:48 Changeset [95468] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: http://codereview.chromium.org/7941019

13:39 Changeset [95467] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
https://bugs.webkit.org/show_bug.cgi?id=68385

Reviewed by Adam Roben.

Move these functions back into the respective clients and remove usesDocumentViews checks.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setToolTip):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::respondToChangedSelection):

  • WebView/WebView.mm:
  • WebView/WebViewEventHandling.mm:
  • WebView/WebViewInternal.h:
13:32 Changeset [95466] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Geoffrey Garen.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:

(JSC::JSValue::toPrimitive):

13:27 Changeset [95465] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Begin removing -[WebView _usesDocumentCalls] from WebView.mm
https://bugs.webkit.org/show_bug.cgi?id=68383

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebView/WebView.mm:

(-[WebView selectedFrame]):
(-[WebView setHostWindow:]):
(-[WebView acceptsFirstResponder]):
(-[WebView becomeFirstResponder]):
(-[WebView _webcore_effectiveFirstResponder]):
(-[WebView setNextKeyView:]):
(-[WebView setHoverFeedbackSuspended:]):

13:22 Changeset [95464] by levin@chromium.org
  • 1 edit in branches/chromium/874/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

  • src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7942006

13:20 Changeset [95463] by levin@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/platform

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

  • platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

  • platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7946013

13:20 Changeset [95462] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

1) Change fromBeforeChild to beforeChild to match
webkit rendering naming conventions.
2) Add assert to verify ruby base is indeed emptied
after collecting all children in a single base.
3) Fix condition in mergeBlockChildren to bail out only
when we have no children and there is no work to merge
children to toBase.

Test: fast/ruby/ruby-overhang-crash.html

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

ASSERTION FAILED: !needsLayout() in RenderRubyRun::getOverhang.

  • fast/ruby/ruby-overhang-crash-expected.txt: Added.
  • fast/ruby/ruby-overhang-crash.html: Added.
13:17 Changeset [95461] by inferno@chromium.org
  • 8 edits
    15 adds in trunk

Child not placed correctly when beforeChild (table part)
has both :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/table/table-cell-before-after-content-around-table-block.html

fast/table/table-cell-before-after-content-around-table-row.html
fast/table/table-cell-before-after-content-around-table.html
fast/table/table-row-before-after-content-around-block.html
fast/table/table-row-before-after-content-around-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  1. Use the new helper functions findAfterContentRenderer, anonymousContainer.
  2. Rename anonymousChild to better name - beforeChildAnonymousContainer.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
When adding a new child, if beforeChild is a table part(
Table/TableSection/TableRow), we need to check if both
:before, :after content are shoved in one of the anonymous child.
If yes, we need to split the :before, :after content before adding
newChild. Easiest approach is to destroy the :before content, then add
the newChild and then call updateBeforeAfterContent to recreate the
:before content.

  • rendering/RenderObject.h:

(WebCore::RenderObject::findBeforeContentRenderer): same as
beforePseudoElementRenderer, but ignores text childs since they are
sequentially added.
(WebCore::RenderObject::findAfterContentRenderer): same.
(WebCore::RenderObject::anonymousContainer):
(WebCore::objectIsRelayoutBoundary):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): use the new helpers and functionally
correct functions - findAfterContentRenderer, anonymousContainer. previous
implementation was wrong since it would not go inside, if :after content
is embedded deeper than one level.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): same.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): same.

LayoutTests:

  • fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-block.html: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row.html: Added.
  • fast/table/table-cell-before-after-content-around-table.html: Added.
  • fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-block.html: Added.
  • fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • fast/table/table-row-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-table.html: Added.
13:09 Changeset [95460] by abarth@webkit.org
  • 1 edit in branches/chromium/874/Source/WebCore/loader/FrameLoader.cpp

Manual merge of 94902 to 874 branch.

13:07 Changeset [95459] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::hasHTMLView):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):

  • WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _hasSelection]):
(-[WebFrame _clearSelection]):
(-[WebFrame _shouldFlattenCompositingLayers:]):
(-[WebFrame _dragSourceEndedAt:operation:]):
(-[WebFrame frameView]):

12:46 Changeset [95458] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews]
https://bugs.webkit.org/show_bug.cgi?id=68377

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::windowResizerRect):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::screenToWindow):
(WebChromeClient::windowToScreen):
(WebChromeClient::platformPageClient):
(WebChromeClient::scrollRectIntoView):
(WebChromeClient::print):

  • WebView/WebDataSource.mm:

(-[WebDataSource _receivedData:]):

12:44 Changeset [95457] by aa@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

r95385 broke Chromium. Fix it.
https://bugs.webkit.org/show_bug.cgi?id=68378

Unreviewed, build fix.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

12:38 Changeset [95456] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, build fix

It's not enough to disable clang plugins.

  • gyp_webkit:
12:33 Changeset [95455] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

12:19 Changeset [95454] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Disable clang when building chromium in WebKit
https://bugs.webkit.org/show_bug.cgi?id=68343

Reviewed by Adam Barth.

  • DEPS:
  • gyp_webkit:
12:14 Changeset [95453] by oliver@apple.com
  • 9 edits
    1 move
    1 add
    1 delete in trunk/Source/JavaScriptCore

Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=68376

Reviewed by Gavin Barraclough.

Renamed the the MarkedSpace files to match new name, and
updated the relevant references.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • runtime/JSCell.h:
12:13 Changeset [95452] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Gesture recognizer fires taptype only every other touch
down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. This change simplifies the logic
and handles all outgoing edges.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::click):

  • platform/chromium/GestureRecognizerChromium.h:

Source/WebKit/chromium:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. Thsi change simplifies the logic
and handles all outgoing edges.

  • tests/InnerGestureRecognizerTest.cpp:

Additional tests added to ensure that all edges in the state
machine are accounted for.
(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TEST_F):

11:59 Changeset [95451] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
and the HTMLParser interact more closely with each other. HTMLParser should be
setting the end range for the token itself to account for buffering that the
HTMLSourceTracker can't know about, but there are a lot of paths that would need
updating. First step is to cover this one path.
https://bugs.webkit.org/show_bug.cgi?id=68281

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::end):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html: Added.
11:54 Changeset [95450] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Rename NewSpace to MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=68375

Reviewed by Gavin Barraclough.

Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • heap/NewSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/NewSpace.h:

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

11:45 Changeset [95449] by commit-queue@webkit.org
  • 51 edits in trunk/Source

TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-19
Reviewed by Adam Barth.

Source/JavaScriptCore:

  • parser/SourceProvider.h:

(JSC::SourceProvider::startPosition):

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):

Source/WebCore:

No new tests because this patch is not changing behavior.

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::update):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerLineNumber):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::startPosition):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

  • dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

  • dom/ScriptElement.h:
  • dom/ScriptableDocumentParser.h:
  • dom/ViewportArguments.cpp:

(WebCore::parserLineNumber):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLInputStream.h:
  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::runScript):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::uninitializedPositionValue1):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):

  • platform/text/SegmentedString.h:
  • svg/SVGDocumentExtensions.cpp:

(WebCore::parserLineNumber):

  • xml/XMLErrors.cpp:

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):

  • xml/XMLErrors.h:
  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::lineNumber):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):

11:36 Changeset [95448] by mitz@apple.com
  • 28 edits
    6 moves
    1 add
    2 deletes in trunk/Source

Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):

Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
Renamed CascadeList to WebCascadeList.
Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
Renamed LanguageChangeObserver to WebLanguageChangeObserver.
Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.

  • WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/mac/AccessibilityObjectWrapper.h: Removed.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.

(convertToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/mac/Language.mm:

(WebCore::platformDefaultLanguage):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::startObservingCookieChanges):

Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.

  • English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
  • English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:

Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed NonBlockingPanel to WebNonBlockingPanel.
Renamed ThreadEnabler to WebCocoaThreadingEnabler.
Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.

  • Misc/WebIconDatabase.mm:

(+[WebCocoaThreadingEnabler enableThreading]):
(importToWebCoreFormat):

  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
  • Panels/WebAuthenticationPanel.h:
  • Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to

WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
cause nightly builds to log an error message when showing the Safari
HTTP authentication sheet and disable the Quit command while the sheet
is disaplyed.

  • WebView/WebPDFView.mm:

(-[WebPDFView initWithFrame:]):
(-[WebPDFView _updatePreferencesSoon]):

Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::accessibilityRemoteObject):

  • WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.

(+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::fullKeyboardAccessEnabled):

11:30 Changeset [95447] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove direct property slot pointers from the instruction stream
https://bugs.webkit.org/show_bug.cgi?id=68373

Reviewed by Gavin Barraclough.

Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream. This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

  • runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyStorage):

11:29 Changeset [95446] by alexis.menard@openbossa.org
  • 3 edits in trunk/Tools

Style checker should not check public Qt WK2 API for parameter_name.
https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
11:27 Changeset [95445] by caryclark@google.com
  • 3 edits in trunk/Source/WebCore

Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
https://bugs.webkit.org/show_bug.cgi?id=68358

Reviewed by Dan Bernstein.

No new tests.

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.

11:18 Changeset [95444] by commit-queue@webkit.org
  • 5 edits in trunk

GTK DRT leaks memory while comparing history items
https://bugs.webkit.org/show_bug.cgi?id=68086

Source/WebKit/gtk:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() function returns a g_strdup()'d
string, so it should return "gchar*" instead of "const gchar*".

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_get_target): Change return type to "gchar*".

  • webkit/webkitwebhistoryitemprivate.h: Ditto.

Tools:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() returns a g_strdup()'d string,
so memory must be freed before compareHistoryItems() returns.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(compareHistoryItems): Use GOwnPtr to manage memory automatically.

11:16 Changeset [95443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Fix paths used by update-po, and avoid changing directory
unnecessarily.

[GTK] make update-po is b0rked
https://bugs.webkit.org/show_bug.cgi?id=68352

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-09-19
Reviewed by Martin Robinson.

  • GNUmakefile.am:
11:12 Changeset [95442] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectations and file WK68372.

  • platform/chromium/test_expectations.txt:
11:03 Changeset [95441] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11:00 Changeset [95440] by jberlin@webkit.org
  • 6 edits
    2 adds in trunk

Sites that use history pushState or replaceState are recorded in history in Private Browsing
mode.
https://bugs.webkit.org/show_bug.cgi?id=68208

Reviewed by Brady Eidson.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.

Add the privateBrowsingEnabled check that is used in other places in HistoryController
before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

Tools:

Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.

  • TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.

(TestWebKitAPI::didNavigateWithNavigationData):
This is a context history client callback, so it should not be called when in Private
Browsing. Add a call to FAIL().
(TestWebKitAPI::didSameDocumentNavigationForFrame):
This is a page load client callback that happens after the didNavigateWithNavigationData
callback. End the test.
(TestWebKitAPI::TEST):
Enable Private Browsing and load a page that uses history.pushState.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.

  • TestWebKitAPI/Tests/WebKit2/push-state.html: Added.

Ditto.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

  • TestWebKitAPI/win/copy-resources.cmd:

Ditto.

10:41 Changeset [95439] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove bump allocator
https://bugs.webkit.org/show_bug.cgi?id=68370

Reviewed by Sam Weinig.

Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code. Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::allocate):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):

  • runtime/StorageBarrier.h:

(JSC::StorageBarrier::set):

10:34 Changeset [95438] by dslomov@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline expectations due to r95402.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
10:18 Changeset [95437] by leandro@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed: ScrollbarThemeMock.cpp is already referenced in the
global CMakeLists.txt.

  • CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp.
  • CMakeListsWinCE.txt: Ditto.
10:14 Changeset [95436] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
https://bugs.webkit.org/show_bug.cgi?id=67938

Reviewed by Andreas Kling.

Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
explicitly avoids running a nested mainloop.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Since we don't run a nested mainloop, we need to keep the client pointer to call
valueChangedForPopupMenu().

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.

(WebKit::WebPopupMenuProxyQtDesktop::create):

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • WebKit2.pro:
10:13 Changeset [95435] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124
BUG=96150
Review URL: http://codereview.chromium.org/7945008

10:12 Changeset [95434] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984
BUG=96150
Review URL: http://codereview.chromium.org/7944005

10:09 Changeset [95433] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/css/CSSPrimitiveValue.cpp

Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
BUG=60653
Review URL: http://codereview.chromium.org/7941005

10:07 Changeset [95432] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/accessibility

Merge 94716
BUG=84160
Review URL: http://codereview.chromium.org/7944004

10:05 Changeset [95431] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Merge 94864
BUG=84885
Review URL: http://codereview.chromium.org/7948002

10:02 Changeset [95430] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95054
BUG=92226

09:58 Changeset [95429] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore

Merge 94905
BUG=1092
Review URL: http://codereview.chromium.org/7942002

09:54 Changeset [95428] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 94991
BUG=94810
Review URL: http://codereview.chromium.org/7943004

09:52 Changeset [95427] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95301
BUG=95072
Review URL: http://codereview.chromium.org/7947002

09:49 Changeset [95426] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp

Merge 94857
BUG=95672
Review URL: http://codereview.chromium.org/7946005

09:47 Changeset [95425] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95204
BUG=95761
Review URL: http://codereview.chromium.org/7950001

09:43 Changeset [95424] by inferno@chromium.org
  • 5 edits in branches/chromium/874/Source/WebCore

Merge 95093
BUG=96170
Review URL: http://codereview.chromium.org/7945005

09:42 Changeset [95423] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95074
BUG=96444
Review URL: http://codereview.chromium.org/7945004

09:40 Changeset [95422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r95416.
http://trac.webkit.org/changeset/95416
https://bugs.webkit.org/show_bug.cgi?id=68367

Broke chromium-mac (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
09:38 Changeset [95421] by inferno@chromium.org
  • 2 edits in branches/chromium/874

Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/7948001

09:35 Changeset [95420] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp

Merge 94820 - REGRESSION (r66874): Missing RefPtr in ScriptController
BUG=95669
Review URL: http://codereview.chromium.org/7946004

09:33 Changeset [95419] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore

Merge 94608 - MediaElementAudioSourceNode destruction triggers ASSERTS
https://bugs.webkit.org/show_bug.cgi?id=67665
BUG=94186
Review URL: http://codereview.chromium.org/7947001

09:26 Changeset [95418] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.

  • platform/win/Skipped:
09:22 Changeset [95417] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68346

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-19
Reviewed by Philippe Normand.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebKit/gtk:

  • tests/testmimehandling.c: Remove ogg tests, since the behavious

has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
(server_callback):
(mime_type_policy_decision_requested_cb):
(main):

  • webkit/webkitwebplugin.cpp: Fix introspection annotation.
09:07 Changeset [95416] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
08:15 Changeset [95415] by loislo@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed fix for flaky tests.

  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
  • platform/qt/Skipped:
07:45 Changeset [95414] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68360

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-19

  • platform/qt/Skipped:
07:23 Changeset [95413] by ademar.reis@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: dos2unix on bindings/js/JSExceptionBase.h

Visual Studio is choking on this file when generating packages for
Qt-4.8 on Windows:

"""
Source\WebCore\Bindings\js\JSExceptionBase.h:
error C4335: Mac file format detected: please convert the source file
to either DOS or UNIX format
"""

Since from all .cpp or .h files shared by all ports this is the only
one with CRLF line terminations, I'm assuming this was a mistake.

  • bindings/js/JSExceptionBase.h:
07:09 Changeset [95412] by kbalazs@webkit.org
  • 1 edit
    240 adds in trunk/LayoutTests

[Qt][WK2] Add some pixel baselines.

Unreviewed expectation update.

These baselines was produced in the same environment where the
Szeged WK2 bot runs. The validity of the results had been checked manually.

  • platform/qt-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c24-first-lttr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t060401-c32-cascading-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-01-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-01-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-03-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-00-a-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1601-c547-indent-01-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-33-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-35-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize16-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/014-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/016-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/white-space-pre-wraps-expected.png: Added.
  • platform/qt-wk2/fast/block/float/003-expected.png: Added.
  • platform/qt-wk2/fast/block/float/020-expected.png: Added.
  • platform/qt-wk2/fast/block/float/021-expected.png: Added.
  • platform/qt-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt-wk2/fast/block/float/nopaint-after-layer-destruction2-expected.png: Added.
  • platform/qt-wk2/fast/block/float/width-update-after-clear-expected.png: Added.
  • platform/qt-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto-height-with-top-and-bottom-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto/005-expected.png: Added.
  • platform/qt-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-fit-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-01-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-02-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-03-expected.png: Added.
  • platform/qt-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt-wk2/fast/canvas/arc360-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/qt-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt-wk2/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/qt-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/012-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/013-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-order-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
  • platform/qt-wk2/fast/css/004-expected.png: Added.
  • platform/qt-wk2/fast/css/005-expected.png: Added.
  • platform/qt-wk2/fast/css/MarqueeLayoutTest-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers2-expected.png: Added.
  • platform/qt-wk2/fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • platform/qt-wk2/fast/css/begin-end-contain-selector-empty-value-expected.png: Added.
  • platform/qt-wk2/fast/css/css1_forward_compatible_parsing-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-modsel-22-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-nth-child-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-detach-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-hover-expected.png: Added.
  • platform/qt-wk2/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/qt-wk2/fast/css/hsl-color-expected.png: Added.
  • platform/qt-wk2/fast/css/inline-properties-important-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-2-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-expected.png: Added.
  • platform/qt-wk2/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/qt-wk2/fast/css/outline-auto-location-expected.png: Added.
  • platform/qt-wk2/fast/css/selector-set-attribute-expected.png: Added.
  • platform/qt-wk2/fast/css/text-align-expected.png: Added.
  • platform/qt-wk2/fast/css/textCapitalizeEdgeCases-expected.png: Added.
  • platform/qt-wk2/fast/css/zoom-font-size-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/qt-wk2/fast/dom/children-nodes-expected.png: Added.
  • platform/qt-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
  • platform/qt-wk2/fast/dom/css-rule-functions-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-selects-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/qt-wk2/fast/forms/minWidthPercent-expected.png: Added.
  • platform/qt-wk2/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/qt-wk2/fast/gradients/radial-centered-expected.png: Added.
  • platform/qt-wk2/fast/html/details-writing-mode-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-with-layers-expected.png: Added.
  • platform/qt-wk2/fast/lists/001-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/007-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/008-vertical-expected.png: Added.
  • platform/qt-wk2/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/qt-wk2/fast/multicol/client-rects-expected.png: Added.
  • platform/qt-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt-wk2/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt-wk2/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt-wk2/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/qt-wk2/fast/overflow/table-overflow-float-expected.png: Added.
  • platform/qt-wk2/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/qt-wk2/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/qt-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selected-replaced-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/qt-wk2/fast/replaced/001-expected.png: Added.
  • platform/qt-wk2/fast/replaced/002-expected.png: Added.
  • platform/qt-wk2/fast/replaced/003-expected.png: Added.
  • platform/qt-wk2/fast/replaced/005-expected.png: Added.
  • platform/qt-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.
06:33 Changeset [95411] by loislo@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Web Inspector: extend UI perf tests coverage. Elements Panel.
https://bugs.webkit.org/show_bug.cgi?id=68263

Reviewed by Pavel Feldman.

  • inspector/performance/resources/show-panel-elements.html: Added.
06:32 Changeset [95410] by loislo@chromium.org
  • 5 edits
    4 adds in trunk

Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
  • inspector/timeline/timeline-dom-content-loaded-event.html: Added.
  • inspector/timeline/timeline-load-event-expected.txt: Added.
  • inspector/timeline/timeline-load-event.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

06:04 Changeset [95409] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=66543

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2011-08-31
Reviewed by Gustavo Noronha.

  • uk.po: updated.
06:04 Changeset [95408] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
05:48 Changeset [95407] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail
https://bugs.webkit.org/show_bug.cgi?id=68341

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19

  • platform/qt-arm/Skipped: Skip the failing tests
02:19 Changeset [95406] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Re-name LayerChromium border functions to reflect that
they are only for debug use.
https://bugs.webkit.org/show_bug.cgi?id=68212

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-19
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setDebugBorderColor):
(WebCore::LayerChromium::setDebugBorderWidth):

  • platform/graphics/chromium/LayerChromium.h:
01:17 Changeset [95405] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: extend timeline coverage.
https://bugs.webkit.org/show_bug.cgi?id=68260

Another place with js function call from native.

Reviewed by Pavel Feldman.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

00:36 Changeset [95404] by loislo@chromium.org
  • 18 edits
    3 adds in trunk

2011-09-18 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Test: inspector/timeline/timeline-animation-frame.html

WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::callFunctionWithoutFrame): (WebCore::V8Proxy::instrumentedCallFunction):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Added.
  • inspector/timeline/timeline-animation-frame.html: Added.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
  • inspector/timeline/timeline-test.js:
00:31 Changeset [95403] by carlosgc@webkit.org
  • 6 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:

09/18/11:

23:50 Changeset [95402] by koz@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.
22:34 Changeset [95401] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

18:29 Changeset [95400] by mitz@apple.com
  • 5 edits
    2 deletes in trunk/Source/JavaScriptCore

Removed ProfilerServer.

Reviewed by Mark Rowe.

  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/ProfilerServer.h: Removed.
  • profiler/ProfilerServer.mm: Removed.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • wscript:
15:29 Changeset [95399] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

14:35 Changeset [95398] by thakis@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

11:38 Changeset [95397] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

11:18 Changeset [95396] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
11:05 Changeset [95395] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
10:27 Changeset [95394] by mitz@apple.com
  • 5 edits
    1 move in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
  • platform/graphics/SimpleFontData.h: Ditto.
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this

Objective-C++ file to .mm.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.
10:16 Changeset [95393] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Snow Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

10:02 Changeset [95392] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

09:52 Changeset [95391] by mitz@apple.com
  • 11 edits
    3 adds in trunk

Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

  • WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.

I am going to rename this file in a followup patch.

  • platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().
  • platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added

a member variable to cache the results of calling this function.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.

  • Renamed the local variable newC to uppercaseCharacter.
  • Changed to use advanceByCombiningCharacterSequence().
  • Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). If there are combining marks and none of the fonts in the fallback list can render the sequence alone, use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() to allow Core Text to perform its own fallback.
  • Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData differs from the normal variant.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

  • platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
09:21 Changeset [95390] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected results for two tests after r95362.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

09/17/11:

20:47 Changeset [95389] by fpizlo@apple.com
  • 8 edits
    1 delete in trunk/Source/JavaScriptCore

DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316

Reviewed by Oliver Hunt.

This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.

This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAliasTracker.h: Removed.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:33 Changeset [95388] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294

Reviewed by Gavin Barraclough.

Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.

This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/Structure.h:

(JSC::Structure::transitivelyTransitionedFrom):

16:31 Changeset [95387] by mihaip@chromium.org
  • 35 edits in trunk/Source

FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • history/BackForwardListImpl.cpp:

(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
16:12 Changeset [95386] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68307

Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/borders/border-image-slice-omission.html

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::cssText):

LayoutTests:

  • fast/borders/border-image-slice-omission.html: Added.
15:47 Changeset [95385] by aa@chromium.org
  • 11 edits
    2 adds in trunk/Source

Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.h:
13:10 Changeset [95384] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315

  • platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.
10:43 Changeset [95383] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

08:58 Changeset [95382] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r95372.

  • dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"
03:57 Changeset [95381] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/media-element-focus-tab.html

fast/spatial-navigation/snav-media-elements.html

Return true from supportsFocus() if control's attribute is present or a tabindex is specified.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsFocus):

  • html/HTMLMediaElement.h:

LayoutTests:

For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.

  • fast/events/media-element-focus-tab-expected.txt: Added.
  • fast/events/media-element-focus-tab.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js:

(test):

  • fast/events/tabindex-focus-blur-all-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt: Added.
  • fast/spatial-navigation/snav-media-elements.html: Added.
02:49 Changeset [95380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162

Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::clearFocusedNode):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.

  • tests/data/autofocus_input_field_iframe.html: Added.
  • tests/data/iframe_clear_focused_node_test.html: Added.
02:28 Changeset [95379] by ryuan.choi@samsung.com
  • 3 edits in trunk

[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226

Reviewed by Adam Barth.

  • Source/cmake/FindCairo.cmake: Check required version.
  • Source/cmake/OptionsEfl.cmake:
02:08 Changeset [95378] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.
01:59 Changeset [95377] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r95337.

  • platform/qt-wk2/Skipped: Skip one more test.
01:06 Changeset [95376] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309

  • platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.
00:57 Changeset [95375] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r95335.

  • platform/qt-wk2/Skipped: Skip new failing tests.
00:49 Changeset [95374] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
  • platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.

09/16/11:

23:52 Changeset [95373] by abarth@webkit.org
  • 20 edits in trunk/Source

Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290

Reviewed by Darin Adler.

Source/WebCore:

LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.

  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • platform/leveldb/LevelDBComparator.h:
  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/leveldb/LevelDBDatabase.h:
  • platform/leveldb/LevelDBIterator.h:
  • platform/leveldb/LevelDBSlice.h:
  • platform/leveldb/LevelDBTransaction.cpp:
  • platform/leveldb/LevelDBTransaction.h:
  • platform/leveldb/LevelDBWriteBatch.cpp:
  • platform/leveldb/LevelDBWriteBatch.h:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):

  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBLevelDBCoding.cpp:
  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

  • features.gypi:
  • tests/IDBLevelDBCodingTest.cpp:
23:34 Changeset [95372] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk/Source/WebCore

Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.

http://webkit.org/b/68105

Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.

Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.

When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Adding files.

  • WebCore.exp.in:

Export EventListenerMap::contains() for WebKit/mac.

  • dom/EventListenerMap.cpp: Added.

(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):

  • dom/EventListenerMap.h: Added.
  • dom/EventTarget.cpp:

(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

  • dom/EventTarget.h:

(WebCore::EventTarget::visitJSEventListeners):

Use EventListenerIterator to visit listeners. (JSC specific.)

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):

Call EventListenerMap::eventTypes() go get the list of event types
currently listened for.

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferEventListenersToShadowTree):

Move implementations of SVG-specific hacks into EventListenerMap and
call them from here.

23:07 Changeset [95371] by koz@chromium.org
  • 6 edits
    2 adds in trunk

Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Reviewed by James Robinson.

Test: plugins/fullscreen-plugins-dont-reload.html

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • rendering/RenderFullScreen.cpp:

(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):

  • rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Reviewed by James Robinson.

  • plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
  • plugins/fullscreen-plugins-dont-reload.html: Added.
22:53 Changeset [95370] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265

Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.

As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
22:52 Changeset [95369] by jochen@chromium.org
  • 17 edits
    7 adds in trunk

Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.

Reviewed by Adam Barth.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowImage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):

Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowImage):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowImage):

  • src/FrameLoaderClientImpl.h:

Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowImage):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

  • http/tests/permissionclient/resources/bostin.gif:
  • http/tests/permissionclient/resources/redir.php:
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/http/tests/permissionclient/image-permissions-expected.txt:
  • platform/http/tests/permissionclient/image-permissions.html:
22:30 Changeset [95368] by dslomov@google.com
  • 3 edits in trunk/Source/WebKit/chromium

https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.

Reviewed by Darin Fisher.

  • public/WebKit.h:
  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):

22:24 Changeset [95367] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-16
Reviewed by Chang Shu.

Added test case to check load progress for QTouchWebView

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
22:16 Changeset [95366] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Make XSSAuditor truncate inline snippets at a reasonable length before comparison
respecting boundaries of multiply urlencoded sequences.
https://bugs.webkit.org/show_bug.cgi?id=68092

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/property-escape-long.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::isContainedInRequest):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/property-escape-long-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-long.html: Added.
21:39 Changeset [95365] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove m_contentsDirty from LayerChromium because it
is redundant with m_dirtyRect.
https://bugs.webkit.org/show_bug.cgi?id=68213

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::resetNeedsDisplay):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

21:28 Changeset [95364] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).

  • wtf/Platform.h:
21:15 Changeset [95363] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

update-webkit-chromium should retry the gclient call if it fails once
https://bugs.webkit.org/show_bug.cgi?id=68252

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.

  • Scripts/update-webkit-chromium:
21:01 Changeset [95362] by dslomov@google.com
  • 26 edits in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.

Based on patch by Luke Zarko.

Reviewed by David Levin.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::webkitPostMessage):

  • bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore::JSDedicatedWorkerContext::webkitPostMessage):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::webkitInitMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::webkitPostMessage):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorker::postMessage):
(WebCore::JSWorker::webkitPostMessage):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallback):
(WebCore::V8MessageEvent::webkitInitMessageEventCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):

  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • page/DOMWindow.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
The tests ensure that webkitPostMessage and postMessage behave identically.

Based on patch by Luke Zarko.

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/events/message-port-expected.txt:
  • fast/events/message-port.html:
  • fast/workers/resources/worker-call.js:
  • fast/workers/worker-call-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
20:47 Changeset [95361] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Chromium: Fix repaint of rubber-band overhang area under composited path
https://bugs.webkit.org/show_bug.cgi?id=68246

I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

LayoutTests:

  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
  • platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html: Added.
20:36 Changeset [95360] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

Removed unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independent files
https://bugs.webkit.org/show_bug.cgi?id=68249

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-16
Reviewed by Martin Robinson.

  • Shared/Plugins/NPIdentifierData.cpp: Removed NotImplemented.h inclusion.
  • Shared/Plugins/NPRemoteObjectMap.cpp: Removed NotImplemented.h inclusion.
  • Shared/Plugins/NPVariantData.cpp: Removed NotImplemented.h inclusion.
  • UIProcess/gtk/WebContextGtk.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Cookies/WebCookieManager.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Removed NotImplemented.h inclusion.
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp: Removed NotImplemented.h inclusion.
20:23 Changeset [95359] by scheib@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add movementX/Y members to WebMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=68174

Reviewed by Dimitri Glazkov.

  • public/WebInputEvent.h:

(WebKit::WebMouseEvent::WebMouseEvent):

19:57 Changeset [95358] by weinig@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306

Reviewed by Anders Carlsson.

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):
Update name.

  • runtime/JSType.h:

Update name and un-indent.

  • runtime/Structure.h:

(JSC::JSCell::isAPIValueWrapper):
Update name.

19:47 Changeset [95357] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305

Reviewed by Anders Carlsson.

  • runtime/JSObject.h:

(JSC::JSObject::isStrictModeFunction):

19:42 Changeset [95356] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/PopupListBox.cpp:
19:40 Changeset [95355] by tony@chromium.org
  • 8 edits in trunk

Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
19:31 Changeset [95354] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.

Call the binding script lazily on the first run of the set() method of
a typed array.

  • ../../Source/WebCore/WebCore.gypi:
  • ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
  • ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
  • ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
  • ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
19:24 Changeset [95353] by rniwa@webkit.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Chromium pixel test rebaseline for r95335.

  • platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-win-vista/editing: Removed.
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium/test_expectations.txt:
19:01 Changeset [95352] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent

Test: fast/events/constructors/error-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
  • dom/ErrorEvent.cpp:

(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):

  • dom/ErrorEvent.h: Added a definition for ErrorEventInit.

(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):

  • dom/ErrorEvent.idl: Makes ErrorEvent constructible.

LayoutTests:

error-event-constructor.html checks the behavior of the ErrorEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
  • fast/events/constructors/error-event-constructor-expected.txt: Added.
  • fast/events/constructors/error-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.
18:47 Changeset [95351] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011

Reviewed by Darin Adler.

I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.

  • http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
  • http/tests/security/canvas-cors-with-two-hosts.html: Added.
  • http/tests/security/resources/canvas-cors-subtest.html: Added.
18:36 Changeset [95350] by haraken@google.com
  • 4 edits
    12 adds
    2 deletes in trunk

Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684

Reviewed by Dan Bernstein.

Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal-no-overlap1.html

fast/ruby/overhang-horizontal-no-overlap2.html
fast/ruby/overhang-vertical-no-overlap1.html
fast/ruby/overhang-vertical-no-overlap2.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.

LayoutTests:

  • fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
  • fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
  • fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
  • fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
  • fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
  • fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
  • fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
  • fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
  • fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
  • platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
  • platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
  • platform/chromium/test_expectations.txt: Skips overhang-horizontal.html. We will update the result image as a rebase line.
18:32 Changeset [95349] by rniwa@webkit.org
  • 17 edits in trunk/Source/WebCore

Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299

Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
18:14 Changeset [95348] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::NonCompositedContentHost):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

18:12 Changeset [95347] by simon.fraser@apple.com
  • 13 edits in trunk/Source

Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Source/WebCore:

Reviewed by Sam Weinig.

Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.

  • page/Settings.h:

(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):

Source/WebKit/mac:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

18:02 Changeset [95346] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

Test: fast/canvas/canvas-large-fills.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

  • fast/canvas/canvas-large-fills-expected.txt: Added.
  • fast/canvas/canvas-large-fills.html: Added.
17:55 Changeset [95345] by bashi@chromium.org
  • 8 edits
    2 copies in branches/chromium/835

Merge 94508 - <rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.

  • dom/Document.cpp:

(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.

  • dom/Document.h:

(WebCore::Document::retireCustomFont): Added.

LayoutTests:

  • fast/css/font-face-used-after-retired-expected.txt: Added.
  • fast/css/font-face-used-after-retired.html: Added.

TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7932007

17:50 Changeset [95344] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

  • platform/graphics/chromium/LayerChromium.h:
17:45 Changeset [95343] by levin@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline fix up due to r95239.

Add back in a baseline that was removed in my last change.

  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:44 Changeset [95342] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Fix the rebaseline in r95325 and also rebaseline for r95335.

  • inspector/styles/styles-update-from-js-expected.txt:
  • platform/chromium/test_expectations.txt
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
17:33 Changeset [95341] by enne@google.com
  • 12 edits in trunk/Source/WebCore

[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272

Reviewed by James Robinson.

All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.

Just moving code around. Tested by existing compositor tests.

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::drawDebugBorder):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

17:22 Changeset [95340] by weinig@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289

Reviewed by Anders Carlsson.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.

  • runtime/JSObject.h:

(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.

  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.

(JSC::TypeInfo::isFinalObject):
Added.

(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
Use new isFinalObject() predicate.

17:22 Changeset [95339] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop installing source and header files in to WebKit2.framework after r95303.

  • WebKit2.xcodeproj/project.pbxproj:
17:20 Changeset [95338] by barraclough@apple.com
  • 5 edits in trunk

Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166

Reviewed by Geoff Garen.

Source/JavaScriptCore:

The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate). The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):

LayoutTests:

Added layout test.

  • fast/js/floating-point-truncate-rshift-expected.txt:
  • fast/js/floating-point-truncate-rshift.html:
17:08 Changeset [95337] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.

  • platform/chromium/test_expectations.txt:
  • editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-blockquote.html: Added.
17:07 Changeset [95336] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):

17:00 Changeset [95335] by rniwa@webkit.org
  • 7 edits
    15 adds in trunk

Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.

We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...

Tests: editing/deleting/merge-paragraph-from-address.html

editing/deleting/merge-paragraph-from-h6-with-style.html
editing/deleting/merge-paragraph-from-h6.html
editing/deleting/merge-paragraph-from-listing.html
editing/deleting/merge-paragraph-into-h1-with-style.html
editing/deleting/merge-paragraph-into-h1.html
editing/deleting/merge-paragraph-into-pre.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/markup.cpp:

(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.

  • editing/deleting/merge-paragraph-from-address-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-address.html: Added.
  • editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
  • editing/deleting/merge-paragraph-from-h6.html: Added.
  • editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-listing.html: Added.
  • editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
  • editing/deleting/merge-paragraph-into-h1.html: Added.
  • editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-pre.html: Added.
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
16:33 Changeset [95334] by nduca@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288

Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

  • src/GraphicsContext3DPrivate.h:
16:24 Changeset [95333] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::process):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaButton):

16:07 Changeset [95332] by levin@chromium.org
  • 6 edits
    16 adds in trunk/LayoutTests

[chromium] Rebaseline fix up due to r95239.

Expectation removal due to r95322 and r95325.

  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium/test_expectations.txt:
16:02 Changeset [95331] by ggaren@apple.com
  • 10 edits
    4 deletes in trunk

Removed undetectable style.filter.

Reviewed by Sam Weinig.

This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.

Source/JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSTypeInfo.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.

Source/WebCore:

  • ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
  • WebCore.order:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

LayoutTests:

  • fast/dom/undetectable-style-filter-expected.txt: Removed.
  • fast/dom/undetectable-style-filter.html: Removed.
15:50 Changeset [95330] by rwlbuis@webkit.org
  • 2 edits in trunk/Tools

2011-09-16 Rob Buis <rbuis@rim.com>

Add Eli's rim address and change the nick.

  • Scripts/webkitpy/common/config/committers.py:
15:29 Changeset [95329] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282

Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • platform/chromium/test_expectations.txt:
15:27 Changeset [95328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078

Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.

  • tests/WebFrameTest.cpp:

(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):

15:02 Changeset [95327] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Update JSC results to account for intrinsics change.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
14:34 Changeset [95326] by weinig@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchIfNotObject):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitJumpIfNotObject):

  • runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):

  • runtime/JSType.h:
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

  • runtime/Operations.cpp:

(JSC::jsIsObjectType):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC::Structure::isObject):
(JSC::JSCell::isObject):

14:12 Changeset [95325] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline from r95242.

14:05 Changeset [95324] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled back in r95201 with test failure fixed.

I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.

  • jit/JIT.h:
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitStoreAndMapInt32):

13:59 Changeset [95323] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Replace use of access to nodeList using call, with array style notation.

  • editing/pasteboard/paste-noscript.html:
13:43 Changeset [95322] by mihaip@chromium.org
  • 5 edits in trunk/LayoutTests

http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

  • http/tests/history/back-with-fragment-change.php:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
13:42 Changeset [95321] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed Windows build fix after 95318.

13:33 Changeset [95320] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277

It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

13:33 Changeset [95319] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

include path so DFGIntrinsic.h can be found.

13:32 Changeset [95318] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274

Reviewed by Sam Weinig.

Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.

(GlobalObject::finishCreation):
(GlobalObject::addFunction):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):

  • runtime/JSObject.h:

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::lookupPut):

13:22 Changeset [95317] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new expectations (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).

  • LayoutTests/platform/chromium/test_expectations.txt:
13:18 Changeset [95316] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Windows.

13:12 Changeset [95315] by andersca@apple.com
  • 8 edits in trunk

Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269

Reviewed by Geoffrey Garen.

Source/WebKit2:

Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

Update client function signatures.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowUIClientInit):

  • MiniBrowser/mac/BrowserWindowController.m:

(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

13:06 Changeset [95314] by ap@apple.com
  • 4 edits
    1 copy in trunk/Source/WebKit2

Give local builds of WebProcess different icon to distinguish them from built-in Safari’s WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68268

Reviewed by Darin Adler.

  • Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds. The empty value for production resulted in WebKit not adding the key to plist at all, which is what we want (but I don't know if it's a supported feature). Also, don't copy the icon file to built framework in production builds.
  • WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.
  • WebProcess/Info.plist: Added a key for the icon.
  • WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.
13:05 Changeset [95313] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-DFG builds.

  • runtime/Executable.h:

(JSC::NativeExecutable::finishCreation):

13:05 Changeset [95312] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271

Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):

12:29 Changeset [95311] by andersca@apple.com
  • 5 edits in trunk

Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266

Reviewed by John Sullivan.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(mouseDidMoveOverElement):

11:50 Changeset [95310] by fpizlo@apple.com
  • 26 edits
    1 add in trunk/Source

DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.

On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.

Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h

This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):

  • dfg/DFGIntrinsic.h: Added.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/DateInstanceCache.h:
  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

Source/WebCore:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.

  • CMakeLists.txt:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

Source/WebKit:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

  • CMakeLists.txt:

Source/WebKit2:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

  • CMakeLists.txt:
11:43 Changeset [95309] by jamesr@google.com
  • 8 edits in trunk/Source

[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418

Source/WebCore:

This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

  • src/GraphicsContext3DPrivate.h:
  • tests/CCLayerTreeHostTest.cpp:

(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

11:43 Changeset [95308] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220

Reviewed by Oliver Hunt.

Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

11:32 Changeset [95307] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262

Broke a bunch of SVG tests (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformContentsSize):

  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::platformContentsSize):

11:26 Changeset [95306] by simonjam@chromium.org
  • 4 edits in trunk

2011-09-16 James Simonsen <simonjam@chromium.org>

Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147

Reviewed by Eric Seidel.

  • html5lib/resources/webkit02.dat:

2011-09-16 James Simonsen <simonjam@chromium.org>

Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147

Reviewed by Eric Seidel.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
11:22 Changeset [95305] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Tools/MiniBrowser

Unreviewed commit. Fix Windows and MacOSX compilation after r95303.

11:06 Changeset [95304] by abarth@webkit.org
  • 17 edits in trunk/Source/WebCore

CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256

Reviewed by Darin Adler.

This patch should have not behavioral effect. It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
10:31 Changeset [95303] by igor.oliveira@openbossa.org
  • 16 edits
    2 adds in trunk/Source/WebKit2

2011-09-16 Igor Oliveira <igor.oliveira@openbossa.org>

[WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.
https://bugs.webkit.org/show_bug.cgi?id=68125

This patch implements support for the UiProcess to know what is the link url of a hovered element.

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebHitTestResult.cpp: Added.

WebHitTestResult has hovered element information.

(WebKit::WebHitTestResult::create):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h: Added. (WebKit::WebHitTestResult::absoluteImageURL): (WebKit::WebHitTestResult::absoluteLinkURL): (WebKit::WebHitTestResult::absoluteMediaURL): (WebKit::WebHitTestResult::linkLabel): (WebKit::WebHitTestResult::linkTitle): (WebKit::WebHitTestResult::WebHitTestResult): (WebKit::WebHitTestResult::type):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::mouseDidMoveOverElement):
  • UIProcess/WebUIClient.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
  • win/WebKit2.vcproj:
10:28 Changeset [95302] by ossy@webkit.org
  • 19 edits
    3 deletes in trunk

[Qt] REGRESSION(r95091) It made many tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed rolling out r95091 and followup patches.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::callFunction):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willCallFunction):

  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Removed.
  • inspector/timeline/timeline-animation-frame.html: Removed.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-test.js:
  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
10:23 Changeset [95301] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

cachedFont not getting updated for inline SVG text.
https://bugs.webkit.org/show_bug.cgi?id=68060

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The cached scaledFont needs to be updated on every style set call. It
is not similar to m_style which can get derived from parent's style and
hence will get automatically updated on ancestor's style change. This is
required, otherwise we will maintain stale font list in cached scaledFont
when custom fonts are retired on Document::recalcStyle.

Test: svg/text/text-style-recalc-crash.html

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::styleDidChange):
(WebCore::RenderSVGInlineText::setStyle):

  • rendering/svg/RenderSVGInlineText.h:

LayoutTests:

  • svg/text/text-style-recalc-crash-expected.txt: Added.
  • svg/text/text-style-recalc-crash.html: Added.
09:58 Changeset [95300] by aroben@apple.com
  • 4 edits in trunk/Source/WebKit2

Add support for attributes on message parameters

Parameter attributes are specified as a space-separated list inside square brackets before
the parameter's type. WebKit2 doesn't use this, but other projects that use these scripts
would like to.

Fixes <http://webkit.org/b/68219> Would like a way to specify attributes on message
parameters

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages_unittest.py: Added tests for parameter attributes.
  • Scripts/webkit2/model.py:

(Parameter.init): Added a new attributes parameter, which is stored in the self.attributes
property.
(Parameter.has_attribute): Added. Returns true if this parameter has the given attribute.

  • Scripts/webkit2/parser.py:

(parse): Moved attributes-parsing code from here...
(parse_attributes_string): ...to here.
(parse_parameters_string): Renamed from parse_parameter_string. Now also parses parameter
attributes.

09:58 Changeset [95299] by aroben@apple.com
  • 4 edits in trunk/Source/WebKit2

Make WebKit2's message-generation model and parser scripts accessible to other projects

We copy them into the build products directory so other projects can find them.

Fixes <http://webkit.org/b/68169> Would like to be able to use WebKit2's message-generation
scripts in other projects

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj: Copy the scripts to PrivateHeaders.
  • win/WebKit2.make: Copy the scripts from obj/WebKit2/scripts to

tools/scripts, like WebCore does.

  • win/WebKit2Generated.make: Copy the scripts to obj/WebKit2/scripts, which is similar to what

WebCore does for its bindings scripts.

09:57 Changeset [95298] by aroben@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

Split some of the message-generation code into separate modules

This is in preparation for making these modules scripts usable by other projects.

Fixes <http://webkit.org/b/68217> Model and parsing functionality for WebKit2's
message-generation scripts is trapped inside a much larger module

Reviewed by Darin Adler.

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:

Added new files.

  • Scripts/webkit2/messages.py: Moved some code from here...
  • Scripts/webkit2/model.py: Added.
  • Scripts/webkit2/parser.py: Added.

...to here. MessageReceiver.parse was split out into a function in the new parser module.

  • Scripts/webkit2/messages_unittest.py: Updated for renames.
09:36 Changeset [95297] by ossy@webkit.org
  • 6 edits in trunk

Source/JavaScriptCore: REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed rolling out r95201.

  • jit/JIT.h:
  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):

  • jit/JITInlineMethods.h:

LayoutTests: Unreviewed rolling out r95277.

  • platform/qt/Skipped:
09:26 Changeset [95296] by loislo@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234

The idea is to create a set of tests which cover frequently used UI actions
and print the average time of these actions.
There are two pilot tests. The common part was extracted into performance-test helper.

Reviewed by Pavel Feldman.

  • inspector/performance/resources/network-append-30-requests.html: Added.
  • inspector/performance/resources/performance-test.js: Added.

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):

  • inspector/performance/resources/show-panel-network.html: Added.
09:25 Changeset [95295] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r95052): SelectorChecker identifier filter not working
https://bugs.webkit.org/show_bug.cgi?id=68244

Reviewed by Dan Bernstein.

Missing &.

  • css/SelectorChecker.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):

09:08 Changeset [95294] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix after r95271.

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
08:58 Changeset [95293] by scheib@chromium.org
  • 2 edits in trunk/Tools

Add Vincent Scheib to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
08:50 Changeset [95292] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a flakey test.

  • platform/qt/Skipped:
08:42 Changeset [95291] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced in r95239.

  • platform/qt/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/qt/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/qt/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
08:24 Changeset [95290] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r95285.
http://trac.webkit.org/changeset/95285
https://bugs.webkit.org/show_bug.cgi?id=68247

It broke a webkitpy test (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
06:30 Changeset [95289] by caseq@chromium.org
  • 10 edits
    1 add
    1 delete in trunk/Source

2011-09-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Pavel Feldman.

  • Merge ExtensionCommon.js into ExtensionAPI.js
  • refactor building of extension API for better reuse
  • expose interface for extension registration
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionAPI.js: (defineCommonExtensionSymbols): (buildExtensionAPIInjectedScript):
  • inspector/front-end/ExtensionCommon.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerExtension): (WebInspector.ExtensionServer.prototype._expandResourcePath):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-09-16 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Pavel Feldman.

  • expose extension API as a single, standalone file for easy reuse in remote extension scripts.
  • WebKit.gyp:
  • scripts/generate_devtools_extension_api.py: Added.
  • scripts/generate_devtools_zip.py:
06:19 Changeset [95288] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix for r95287.

  • inspector/debugger/debugger-expand-scope.html:
05:55 Changeset [95287] by loislo@chromium.org
  • 15 edits in trunk

Web Inspector: change WebInspector.currentPanel getter/setter to functions.
https://bugs.webkit.org/show_bug.cgi?id=68242

This is necessary for the panel switching performance tests.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.switchToAndFocus):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):

  • inspector/front-end/inspector.js:

(WebInspector.currentPanel):
(WebInspector._updateFocusedNode):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.goForward):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype.showPanel):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):

  • inspector/debugger/debugger-expand-scope.html:
  • inspector/debugger/debugger-proto-property.html:
  • inspector/storage-panel-dom-storage.html:
05:42 Changeset [95286] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] bot lucks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243

Unreviwed test skipping.

  • platform/qt-wk2/Skipped:
05:04 Changeset [95285] by ossy@webkit.org
  • 2 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-16
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
05:00 Changeset [95284] by mnaganov@chromium.org
  • 1 edit in trunk/Source/WebCore/rendering/LayoutState.cpp

Unreviewed. Fix release compilation after r95264

04:43 Changeset [95283] by carlosgc@webkit.org
  • 6 edits in trunk

[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
https://bugs.webkit.org/show_bug.cgi?id=68178

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-16
Reviewed by Xan Lopez.

.:

  • configure.ac: Do not build WebKit2 by default. Re-add pkgconfig support

for WebKit2.

Source/WebKit2:

  • GNUmakefile.am: Do not build WebKit2 by default. Re-add pkgconfig support

for WebKit2.

Tools:

Add a work-around to enable WebKit2 when using build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

02:29 Changeset [95282] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
https://bugs.webkit.org/show_bug.cgi?id=68165

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::clearConsoleMessages):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearMessages):

  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype.requestClearMessages):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
02:13 Changeset [95281] by keishi@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Rebaselines due to r95203 and r95207.

  • platform/chromium-cg-mac-leopard/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium/test_expectations.txt:
01:39 Changeset [95280] by alex@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-09-16 Alejandro G. Castro <alex@igalia.com>

Fix build after r95245.

  • GNUmakefile.list.am:
01:35 Changeset [95279] by reni@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Update expecteds of failing tests after r95260 and r95242.

Unreviewed gardening.

  • editing/style/non-inheritable-styles-expected.txt: after r95242.
  • fast/dom/constructed-objects-prototypes-expected.txt: after r95260.
  • inspector/styles/styles-new-API-expected.txt: after r95242.
  • inspector/styles/styles-source-lines-expected.txt: after r95242.
01:26 Changeset [95278] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] One test failed after r95203
https://bugs.webkit.org/show_bug.cgi?id=68233

Unreviewed gardening.

  • platform/qt/Skipped: failed test is skipped.
01:21 Changeset [95277] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] One test runs out of time after r95091
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed gardening.

  • platform/qt/Skipped:
01:16 Changeset [95276] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests fail after r95201
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed gardening.

  • platform/qt/Skipped:
00:15 Changeset [95275] by leo.yang@torchmobile.com.cn
  • 3 edits
    2 adds in trunk

[Qt] Crash when dragging google maps.
https://bugs.webkit.org/show_bug.cgi?id=68223

Source/WebCore:

The custom image for a cursor might not be ready when WebKit trying
to use it to construct the cursor in Qt porting. This patch is using
arrow image to substitute the unready custom image.

Reviewed by Adam Barth.

Test: fast/css/crash-on-custom-cursor-when-loading.html

  • platform/qt/CursorQt.cpp:

(WebCore::createCustomCursor):
(WebCore::Cursor::ensurePlatformCursor):

LayoutTests:

Test case to use an unready custom cursor.

Reviewed by Adam Barth.

  • fast/css/crash-on-custom-cursor-when-loading-expected.txt: Added.
  • fast/css/crash-on-custom-cursor-when-loading.html: Added.
Note: See TracTimeline for information about the timeline view.