Timeline
Sep 24, 2011:
- 11:04 PM Changeset in webkit [95919] by
-
- 126 edits in trunk
Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=68767
Reviewed by Eric Seidel.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
As discussed on webkit-dev, almost everyone has this enable turned on
and this feature is unlikely to be removed from the web platform given
its popularity.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.pro:
- bindings/cpp/WebDOMEventTarget.cpp:
(toWebKit):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/EventTarget.cpp:
(WebCore::EventTarget::toDOMApplicationCache):
- dom/EventTarget.h:
- features.pri:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::insertedByParser):
- html/HTMLHtmlElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::handledOnloadEvents):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::applicationCacheHost):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
(WebCore::MainResourceLoader::load):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCache.cpp:
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/ApplicationCacheHost.cpp:
- loader/appcache/ApplicationCacheHost.h:
- loader/appcache/ApplicationCacheResource.cpp:
- loader/appcache/ApplicationCacheResource.h:
- loader/appcache/ApplicationCacheStorage.cpp:
- loader/appcache/ApplicationCacheStorage.h:
- loader/appcache/DOMApplicationCache.cpp:
- loader/appcache/DOMApplicationCache.h:
- loader/appcache/DOMApplicationCache.idl:
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
- loader/appcache/ManifestParser.h:
- loader/chromium/ResourceLoaderChromium.cpp:
(WebCore::ResourceLoader::didDownloadData):
- page/ChromeClient.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::applicationCache):
- page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache):
- page/DOMWindow.idl:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseStartElement):
Source/WebKit/chromium:
- features.gypi:
- src/ApplicationCacheHost.cpp:
- src/ApplicationCacheHostInternal.h:
- src/AssertMatchingEnums.cpp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::reachedApplicationCacheOriginQuota):
- src/ChromeClientImpl.h:
- src/WebDataSourceImpl.cpp:
(WebKit::WebDataSourceImpl::applicationCacheHost):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableApplicationCache):
(WebKit::WebRuntimeFeatures::isApplicationCacheEnabled):
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientEfl.h:
- ewk/ewk_main.cpp:
(_ewk_init_body):
- ewk/ewk_settings.cpp:
(ewk_settings_cache_directory_path_set):
(ewk_settings_cache_directory_path_get):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientGtk.h:
- webkit/webkitapplicationcache.cpp:
(webkit_application_cache_get_maximum_size):
(webkit_application_cache_set_maximum_size):
(webkit_application_cache_get_database_directory_path):
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientHaiku.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- Misc/WebCache.mm:
(+[WebCache empty]):
- WebCoreSupport/WebApplicationCache.mm:
- WebCoreSupport/WebApplicationCacheQuotaManager.mm:
(-[WebApplicationCacheQuotaManager usage]):
(-[WebApplicationCacheQuotaManager quota]):
(-[WebApplicationCacheQuotaManager setQuota:]):
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
- WebView/WebDataSource.mm:
(-[WebDataSource _transferApplicationCache:]):
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
Source/WebKit/qt:
- Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::setApplicationCacheQuota):
- Api/qwebsettings.cpp:
(QWebSettings::setOfflineWebApplicationCachePath):
(QWebSettings::offlineWebApplicationCachePath):
(QWebSettings::setOfflineWebApplicationCacheQuota):
(QWebSettings::offlineWebApplicationCacheQuota):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearAllApplicationCaches):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::reachedApplicationCacheOriginQuota):
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientWinCE.h:
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
- WebKitSupport/ChromeClientWx.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::applicationCacheDirectory):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearApplicationCache):
- WebProcess/WebProcess.h:
Tools:
- Scripts/build-webkit:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 7:20 PM Changeset in webkit [95918] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT implementation of put_by_val increments m_length instead of setting
it to index+1
https://bugs.webkit.org/show_bug.cgi?id=68766
Reviewed by Geoffrey Garen.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
- 3:53 PM Changeset in webkit [95917] by
-
- 2 edits in trunk/Source/JavaScriptCore
More build fixage.
- heap/ConservativeRoots.cpp: Our system of #includes, it is chaos.
- 3:39 PM Changeset in webkit [95916] by
-
- 8 edits in trunk/Source/JavaScriptCore
The DFG should not attempt to guess types in the absence of value
profiles
https://bugs.webkit.org/show_bug.cgi?id=68677
Reviewed by Oliver Hunt.
This adds the ForceOSRExit node, which is ignored by the propagator
and virtual register allocator (and hence ensuring that liveness analysis
works correctly), but forces terminateSpeculativeExecution() in the
back-end. This appears to be a slight speed-up on benchmark averages,
with ~5% swings on individual benchmarks, in both directions. But it's
never a regression on any average, and appears to be a ~1% progression
in the SunSpider average.
This also adds a bit better debugging support in the old JIT and in DFG,
as this was necessary to debug the much more frequent OSR transitions
that occur with this change.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- 3:38 PM Changeset in webkit [95915] by
-
- 2 edits in trunk/LayoutTests
Remove Chromium failing expectations for WCSS tests now that they're
been removed with r95911.
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [95914] by
-
- 4 edits in trunk/Source/JavaScriptCore
Some Windows build fixage.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive): Show the compiler that all control paths
return a value. There, there, compiler. Everything's going to be OK.
- runtime/JSCell.h:
(JSC::JSCell::setVPtr): Oops! Unrename this function.
- 3:35 PM Changeset in webkit [95913] by
-
- 2 edits1 delete in trunk/LayoutTests
Mark an svg/ test as slow, and remove incorrect baselines for another.
- platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 3:15 PM Changeset in webkit [95912] by
-
- 15 edits in trunk
Allocate new objects unmarked
https://bugs.webkit.org/show_bug.cgi?id=68764
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This is a pre-requisite to using the mark bit to determine object age.
~2% v8 speedup, mostly due to a 12% v8-splay speedup.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive):
(JSC::MarkedBlock::isLiveCell): These two functions are the reason for
this patch. They can now determine object liveness without relying on
newly allocated objects having their mark bits set. Each MarkedBlock
now has a state variable that tells us how to determine whether its
cells are live. (This new state variable supercedes the old one about
destructor state. The rest of this patch is just refactoring to support
the invariants of this new state variable without introducing a
performance regression.)
(JSC::MarkedBlock::didConsumeFreeList): New function for updating interal
state when a block becomes fully allocated.
(JSC::MarkedBlock::clearMarks): Folded a state change to 'Marked' into
this function because, logically, clearing all mark bits is the first
step in saying "mark bits now exactly reflect object liveness".
(JSC::MarkedBlock::markCountIsZero): Renamed from isEmpty() to clarify
that this function only tells you about the mark bits, so it's only
meaningful if you've put the mark bits into a meaningful state before
calling it.
(JSC::MarkedBlock::forEachCell): Changed to use isLive() helper function
instead of testing mark bits, since mark bits are not always the right
way to find out if an object is live anymore. (New objects are live, but
not marked.)
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock): Folded all initialization -- even
initialization when recycling an old block -- into the MarkedBlock
constructor, for simplicity.
(JSC::MarkedBlock::callDestructor): Inlined for speed. Always check for
a zapped cell before running a destructor, and always zap after
running a destructor. This does not seem to be expensive, and the
alternative just creates a too-confusing matrix of possible cell states
((zombie undestructed cell + zombie destructed cell + zapped destructed
cell) * 5! permutations for progressing through block states = "Oh my!").
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep): Maintained and expanded a pre-existing
optimization to use template specialization to constant fold lots of
branches and elide certain operations entirely during a sweep. Merged
four or five functions that were logically about sweeping into this one
function pair, so there's only one way to do things now, it's
automatically correct, and it's always fast.
(JSC::MarkedBlock::zapFreeList): Renamed this function to be more explicit
about exactly what it does, and to honor the new block state system.
- heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateBlock): Updated for rename.
(JSC::AllocationSpace::freeBlocks): Updated for changed interface.
(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue): Just like isEmpty() above, renamed
to clarify that this functor only tests the mark bits, so it's only
valid if you've put the mark bits into a meaningful state before
calling it.
(JSC::AllocationSpace::shrink): Updated for rename.
- heap/AllocationSpace.h:
(JSC::AllocationSpace::canonicalizeCellLivenessData): Renamed to be a
little more specific about what we're making canonical.
(JSC::AllocationSpace::forEachCell): Updated for rename.
(JSC::AllocationSpace::forEachBlock): No need to canonicalize cell
liveness data before iterating blocks -- clients that want iterated
blocks to have valid cell lieveness data should make this call for
themselves. (And not all clients want it.)
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer): Updated for rename. Removed
obsolete comment.
- heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()): Removed call to notify...()
because clearMarks() now does that implicitly.
(JSC::Heap::destroy): Make sure to canonicalize before tear-down, since
tear-down tests cell liveness when running destructors.
(JSC::Heap::markRoots):
(JSC::Heap::collect): Moved weak reference harvesting out of markRoots()
and into collect, since it strictly depends on root marking, and does
not contribute to root marking.
(JSC::Heap::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.
- heap/Heap.h:
(JSC::Heap::forEachProtectedCell): No need to canonicalize cell liveness
data before iterating protected cells, since we know they're all live,
and don't need to test for it.
- heap/Local.h:
(JSC::::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock): Updated for interface change.
(JSC::MarkedSpace::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::zapFreeList): Simplified this allocator
functionality a bit. We now track only one block -- "currentBlock" --
and rely on its internal state to know whether it has more cells to
allocate.
- heap/Weak.h:
(JSC::Weak::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.
- runtime/JSCell.h:
(JSC::JSCell::vptr):
(JSC::JSCell::zap):
(JSC::JSCell::isZapped):
(JSC::isZapped): Made zapping a property of JSCell, for a little abstraction.
In the future, exactly how a JSCell zaps itself will change, as the
internal representation of JSCell changes.
LayoutTests:
Reviewed by Oliver Hunt.
Made this flaky test less flaky. (Just enough to make my patch not fail.)
- fast/dom/gc-10.html: Count objects immediately after GC to get an
exact count. Call 'reload' a few times to improve test coverage. Preload
properties in case they're lazily instantiated, which would change
object count numbers. Also, use the 'var' keyword like a good little
JavaScripter.
- 3:03 PM Changeset in webkit [95911] by
-
- 24 edits6 deletes in trunk
Remove ENABLE(WCSS) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68759
Reviewed by Darin Adler.
.:
- configure.ac:
Source/WebCore:
As discussed on webkit-dev, we are removing this feature from trunk to
reduce the number of different configurations.
- CodeGenerators.pri:
- GNUmakefile.am:
- WebCore.pro:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/WCSSPropertyNames.in: Removed.
- css/WCSSValueKeywords.in: Removed.
- features.pri:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
- html/HTMLInputElement.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::sanitizeValue):
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/style/RenderStyleConstants.h:
Tools:
- Scripts/build-webkit:
- Scripts/old-run-webkit-tests:
- Scripts/webkitperl/features.pm:
(hasFeature):
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
LayoutTests:
- fast/wcss: Removed.
- fast/wcss/wap-input-format-expected.txt: Removed.
- fast/wcss/wap-input-format.xhtml: Removed.
- fast/wcss/wap-input-required-expected.txt: Removed.
- fast/wcss/wap-input-required.xhtml: Removed.
- 2:23 PM Changeset in webkit [95910] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG JIT should not eagerly initialize integer tags in the register file
https://bugs.webkit.org/show_bug.cgi?id=68763
Reviewed by Oliver Hunt.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- 12:13 PM Changeset in webkit [95909] by
-
- 1 edit1 add in trunk/LayoutTests
Added Snow Leopard-specific expected results.
- platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
- 2:58 AM Changeset in webkit [95908] by
-
- 2 edits in trunk/Tools
2011-09-24 Alejandro G. Castro <alex@igalia.com>
Fixed GTK compilation after r95878, the operator== was defined
twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
- 1:17 AM Changeset in webkit [95907] by
-
- 4 edits3 adds in trunk
SVGAnimation does not support 'values' for from-to animations
https://bugs.webkit.org/show_bug.cgi?id=64859
Patch by Young Han Lee <joybro@company100.net> on 2011-09-24
Reviewed by Dirk Schulze.
If from-to animation have discrete calc-mode and have a 'keyTimes' list, values of
the keyTimes indicate the begin and the end of the animation respectively.[1][2]
When keyTimes is given, calculate the progress percentage of the animation with it
even for from-to animation.
[1] http://www.w3.org/TR/SVG/animate.html#ValueAttributes
[2] http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncValues
Source/WebCore:
Test: svg/animations/animate-from-to-keyTimes.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculatePercentForFromTo):
(WebCore::SVGAnimationElement::updateAnimation):
- svg/SVGAnimationElement.h:
LayoutTests:
- svg/animations/animate-from-to-keyTimes-expected.txt: Added.
- svg/animations/animate-from-to-keyTimes.html: Added.
- svg/animations/script-tests/animate-from-to-keyTimes.js: Added.
(sample1):
(sample2):
(executeTest):
- 12:00 AM Changeset in webkit [95906] by
-
- 5 edits in trunk
WebKit does not expose AXPlaceholder value on password fields
https://bugs.webkit.org/show_bug.cgi?id=68745
Reviewed by Oliver Hunt.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
- accessibility/placeholder-expected.txt:
- accessibility/placeholder.html:
Sep 23, 2011:
- 10:42 PM Changeset in webkit [95905] by
-
- 3 edits in trunk
Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.
Add cmake options to enable DFG JIT compilation for EFL port
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
- 10:30 PM Changeset in webkit [95904] by
-
- 2 edits in trunk/Tools
[DRT] Include the right config file for EFL's DRT.
https://bugs.webkit.org/show_bug.cgi?id=67042
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Martin Robinson.
Ports which use CMake as their buildsystem (such as the EFL one) also
have config.h files, but they are named differently, so include the
right one depending on the buildsystem being used.
- DumpRenderTree/config.h:
- 10:11 PM Changeset in webkit [95903] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck): Get rid of the exit-time destructor.
- 10:04 PM Changeset in webkit [95902] by
-
- 21 edits4 adds in trunk/Source/JavaScriptCore
Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.
This is the initial attempt to add JSVALUE32_64 support to DFG JIT.
It's tested on IA32 Linux EFL port currently. It still cannot run
all the test cases and benchmarks so should be turned off now.
The major work includes:
1) dealing with JSVALUE32_64 data format in DFG JIT;
2) bindings between 64-bit JS Value and 32-bit registers;
3) handling of function calls. Currently for DFG operation function
calls we follow the X86 cdecl calling convention on Linux, and the
implementation is in a naive way by pushing the arguments into stack
one by one.
The known issues include:
1) some code duplicates unnecessarily, especially in Speculative JIT
code generation, where most of the operations on SpeculataInteger /
SpeculateDouble should be identical to the JSVALUE64 code. Refactoring
is needed in the future;
2) lack of op_call and op_construct support, comparing to current
JSVALUE64 DFG;
3) currently integer speculations assume to be StrictInt32;
4) lack of JSBoolean speculations;
5) boxing and unboxing doubles could be improved;
6) DFG X86 register description is different with the baseline JIT,
the timeoutCheckRegister is used for general purpose usage;
7) calls to runtime functions with primitive double parameters (e.g.
fmod) don't work. Support needs to be added to the assembler to
implement the mechanism of passing double parameters for X86 cdecl
convention.
And there should be many other hidden bugs which should be exposed and
resolved in later debugging process.
- CMakeListsEfl.txt:
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::storeDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::movsd_rm):
- bytecode/StructureStubInfo.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::tagGPR):
(JSC::DFG::GenerationInfo::payloadGPR):
(JSC::DFG::GenerationInfo::fpr):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillDouble):
- dfg/DFGJITCodeGenerator.cpp:
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::registersMatched):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::addressOfDoubleConstant):
(JSC::DFG::integerResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::setupResults):
(JSC::DFG::callOperation):
(JSC::JSValueOperand::JSValueOperand):
(JSC::JSValueOperand::~JSValueOperand):
(JSC::JSValueOperand::isDouble):
(JSC::JSValueOperand::fill):
(JSC::JSValueOperand::tagGPR):
(JSC::JSValueOperand::payloadGPR):
(JSC::JSValueOperand::fpr):
(JSC::GPRTemporary::~GPRTemporary):
(JSC::GPRTemporary::gpr):
(JSC::GPRResult2::GPRResult2):
- dfg/DFGJITCodeGenerator32_64.cpp: Added.
(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::isStrictInt32):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
(JSC::DFG::JITCodeGenerator::emitCall):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::dataFormatString):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagForGlobalVar):
(JSC::DFG::JITCompiler::payloadForGlobalVar):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
- dfg/DFGJITCompiler32_64.cpp: Added.
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
(JSC::DFG::JITCompiler::jitAssertIsCell):
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
- dfg/DFGJITCompilerInlineMethods.h: Added.
(JSC::DFG::JITCompiler::emitLoadTag):
(JSC::DFG::JITCompiler::emitLoadPayload):
(JSC::DFG::JITCompiler::emitLoad):
(JSC::DFG::JITCompiler::emitLoad2):
(JSC::DFG::JITCompiler::emitLoadDouble):
(JSC::DFG::JITCompiler::emitLoadInt32ToDouble):
(JSC::DFG::JITCompiler::emitStore):
(JSC::DFG::JITCompiler::emitStoreInt32):
(JSC::DFG::JITCompiler::emitStoreCell):
(JSC::DFG::JITCompiler::emitStoreBool):
(JSC::DFG::JITCompiler::emitStoreDouble):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inPair):
(JSC::DFG::ValueRecovery::tagGPR):
(JSC::DFG::ValueRecovery::payloadGPR):
- dfg/DFGSpeculativeJIT32_64.cpp: Added.
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- runtime/JSValue.h:
- 9:23 PM Changeset in webkit [95901] by
-
- 6034 edits in trunk/Source
Set eol-style to native on many source files where it was unset.
- 8:51 PM Changeset in webkit [95900] by
-
- 3 edits in trunk/Source/WebCore
Canvas security checks show up on HTML5GamingTest benchmark
https://bugs.webkit.org/show_bug.cgi?id=68743
Reviewed by Oliver Hunt.
Prior to this patch, the canvas security checks took as much as 4% of
the time on the HTML5GamingTest benchmark:
http://craftymind.com/factory/guimark2/HTML5GamingTest.html
This patch uses a couple of AtomicStrings and shuffles around the order
of the security check to take this down to around 0.1% (which is near
the noise floor of what I can measure with my profiler).
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
- 8:24 PM Changeset in webkit [95899] by
-
- 7 edits in trunk
Source/WebCore: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
Return early without throwing an exception if source rectangle is out of
bounds to match the spec.
LayoutTests: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect is out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.
- fast/canvas/drawImage-with-invalid-args-expected.txt:
- fast/canvas/drawImage-with-invalid-args.html:
This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions
- platform/chromium/test_expectations.txt:
Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail
- platform/mac/Skipped:
Skipping canvas/philip/tests/2d.drawImage.outsidesource.html
- 8:20 PM Changeset in webkit [95898] by
-
- 2 edits in trunk/Source/WebCore
Printing of notImplemented() when logging enabled.
https://bugs.webkit.org/show_bug.cgi?id=64590
Printing of notImplemented() method was enabled on Debug builds only.
Now it is enabled when logging is enabled.
Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-09-23
Reviewed by Oliver Hunt.
No new tests because there is no new functionality.
- platform/NotImplemented.h: Non-debug mode replaced with non-logging mode.
- 8:12 PM Changeset in webkit [95897] by
-
- 3 edits2 adds in trunk
[Chromium] REGRESSION (r95725): Resizing a window doesn't resize the contents
https://bugs.webkit.org/show_bug.cgi?id=68730
Reviewed by James Robinson.
Source/WebCore:
Adds a missing contentsResized() call in ScrollView::setFrameRect.
Test: fast/dom/Window/window-resize-contents.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
LayoutTests:
Test for resizing of the window triggering resizing of contents.
- fast/dom/Window/window-resize-contents-expected.txt: Added.
- fast/dom/Window/window-resize-contents.html: Added.
- 8:12 PM Changeset in webkit [95896] by
-
- 2 edits in trunk
[CMake] Detect amd64 as a valid 64-bit architecture.
https://bugs.webkit.org/show_bug.cgi?id=67481
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Oliver Hunt.
Some operating systems (generally the BSDs) use amd64 instead of x86_64
to report they're running on 64 bits, so consider it a valid value.
- Source/CMakeLists.txt:
- 7:07 PM Changeset in webkit [95895] by
-
- 7 edits1 add in trunk/Source/JavaScriptCore
wtf/BitVector.h has a variety of bugs which manifest when the
vector grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746
Reviewed by Oliver Hunt.
Out-of-lined slow path code in BitVector so that not every user
of CodeBlock ends up having to compile it. Fixed a variety of
index computation and size computation bugs.
I have not seen these issues manifest themselves, but they are
blocking a patch that uses BitVector more aggressively.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/BitVector.cpp: Added.
(BitVector::BitVector):
(BitVector::operator=):
(BitVector::resize):
(BitVector::clearAll):
(BitVector::OutOfLineBits::create):
(BitVector::OutOfLineBits::destroy):
(BitVector::resizeOutOfLine):
- wtf/BitVector.h:
(WTF::BitVector::ensureSize):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::byteCount):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::outOfLineBits):
- wtf/CMakeLists.txt:
- wtf/wtf.pri:
- 6:25 PM Changeset in webkit [95894] by
-
- 18 edits in trunk
Add ENABLE_MUTATION_OBSERVERS feature flag
https://bugs.webkit.org/show_bug.cgi?id=68732
Reviewed by Ojan Vafai.
This flag will guard an implementation of the "Mutation Observers" proposed in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
.:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 6:19 PM Changeset in webkit [95893] by
-
- 11 edits in trunk/Source/JavaScriptCore
De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651
Reviewed by Oliver Hunt.
Added a new JSType to check whether or not something is a
NumberObject (which includes NumberPrototype) in TypeInfo::isNumberObject because there's not
currently a better way to determine whether something is indeed a NumberObject.
Also de-virtualized JSCell::getJSNumber, having it check the TypeInfo
for whether the object is a NumberObject or not. This patch is part of
the larger process of de-virtualizing JSCell.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSCell.cpp:
(JSC::JSCell::getJSNumber):
- runtime/JSCell.h:
(JSC::JSValue::getJSNumber):
- runtime/JSType.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::isNumberObject):
- runtime/JSValue.h:
- runtime/NumberObject.cpp:
(JSC::NumberObject::getJSNumber):
- runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
- runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
- 6:12 PM Changeset in webkit [95892] by
-
- 2 edits3 adds in trunk/LayoutTests
Rebaseline fast/ruby/ruby-text-before-after-content.html for Chromium Mac.
Mark media/controls-right-click-on-timebar.html as flaky.
- platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
- platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:44 PM Changeset in webkit [95891] by
-
- 2 edits in trunk/Source/WebKit/chromium
Making some WebBlob methods exportable.
This is needed by the shared lib chromium build.
https://bugs.webkit.org/show_bug.cgi?id=68709
Reviewed by Darin Fisher.
- public/WebBlob.h:
- 5:23 PM Changeset in webkit [95890] by
-
- 16 edits4 adds in trunk
.: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198
Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.
- Source/autotools/symbols.filter:
Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198
Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.
Tests: fast/dom/scroll-element-to-rect-centered.html
fast/dom/scroll-element-to-rect.html
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect):
- page/FrameView.h:
- testing/Internals.cpp:
(WebCore::Internals::scrollElementToRect):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198
Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.
- public/WebView.h:
(WebKit::WebView::scrollFocusedNodeIntoRect):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198
Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198
Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.
- fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
- fast/dom/scroll-element-to-rect-centered.html: Added.
- fast/dom/scroll-element-to-rect-expected.txt: Added.
- fast/dom/scroll-element-to-rect.html: Added.
- 5:07 PM Changeset in webkit [95889] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r95860.
http://trac.webkit.org/changeset/95860
https://bugs.webkit.org/show_bug.cgi?id=68648
Breaks overhang rendering on Chromium Mac
Source/WebCore:
- platform/chromium/ScrollbarThemeChromium.cpp:
- platform/chromium/ScrollbarThemeChromium.h:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
Source/WebKit/chromium:
- features.gypi:
- 4:43 PM Changeset in webkit [95888] by
-
- 10 edits6 adds in trunk
Add -webkit-filter to CSSPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=68675
Reviewed by Simon Fraser.
Add property and rudimentary parsing for -webkit-filter. The
property value isn't preserved anywhere yet. Add
stub definition for computed style.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilter):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
New test for rudimentary parsing of -webkit-filter.
Since currently only the Apple port enables the
feature, add this new test to the platform skip lists
for GTK, QT and Chromium.
- css3/filters/filter-property-expected.txt: Added.
- css3/filters/filter-property.html: Added.
- css3/filters/script-tests/TEMPLATE.html: Added.
- css3/filters/script-tests/filter-property.js: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:28 PM Changeset in webkit [95887] by
-
- 8 edits in trunk/Source/JavaScriptCore
Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723
Reviewed by Oliver Hunt.
This adds value profiling to all forms of op_resolve in the
old JIT, and patches that information into the DFG along with
performing the appropriate type propagation.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasPrediction):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- 4:25 PM Changeset in webkit [95886] by
-
- 5 edits in trunk/Source/WebCore
Remove preserves3D() from CCLayerDelegate, replacing it by setting the
value explicitly after creating a layer, or setting its delegate.
https://bugs.webkit.org/show_bug.cgi?id=68295
Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
Reviewed by James Robinson.
Covered by compositing/ layeout tests.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setPreserves3D):
(WebCore::LayerChromium::preserves3D):
- 4:24 PM Changeset in webkit [95885] by
-
- 1 edit2 adds in trunk/LayoutTests
chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639
Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
Reviewed by Tony Chang.
Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.
- editing/style/justify-without-enclosing-block-expected.txt: Added.
- editing/style/justify-without-enclosing-block.xhtml: Added.
- 4:19 PM Changeset in webkit [95884] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix windows build.
- 4:17 PM Changeset in webkit [95883] by
-
- 2 edits in trunk/LayoutTests
Note flaky test.
- platform/chromium/test_expectations.txt:
- 4:16 PM Changeset in webkit [95882] by
-
- 5 edits in trunk/Source
Versioning.
- 4:14 PM Changeset in webkit [95881] by
-
- 1 copy in tags/Safari-535.4
New tag.
- 4:12 PM Changeset in webkit [95880] by
-
- 1 edit4 adds in trunk/LayoutTests
Add a few more possiblities to the test cases for xss denial.
https://bugs.webkit.org/show_bug.cgi?id=47120
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-23
Reviewed by Adam Barth.
- http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Added.
- http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces.html: Added.
- 4:11 PM Changeset in webkit [95879] by
-
- 2 edits in trunk/Source/WebCore
Implicit conversion double to float in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68722
Reviewed by Simon Fraser.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
conversions.
- 4:02 PM Changeset in webkit [95878] by
-
- 13 edits in trunk
[WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68556
Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
Source/WebKit2:
Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.
- Shared/API/c/WKGeometry.h:
(operator==):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"
Tools:
Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButton):
(WTR::getModifiers):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::postEvent):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
LayoutTests:
Unskip passed tests.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.
- platform/qt-wk2/Skipped:
- 3:59 PM Changeset in webkit [95877] by
-
- 4 edits3 adds in trunk
Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740
Reviewed by Oliver Hunt.
Function-info caching does not preserve all state that it should.
- parser/JSParser.cpp:
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):
- parser/SourceProviderCacheItem.h:
LayoutTests: gh@apple.com>
Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740
Reviewed by Oliver Hunt.
Function-info caching does not preserve all state that it should.
- fast/js/nested-functions-expected.txt: Added.
- fast/js/nested-functions.html: Added.
- fast/js/script-tests/nested-functions.js: Added.
(runTests.test1):
(runTests.test2):
(runTests.test3):
(runTests):
- 3:58 PM Changeset in webkit [95876] by
-
- 2 edits in trunk/Source/JavaScriptCore
ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=68724
Reviewed by Oliver Hunt.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- 3:47 PM Changeset in webkit [95875] by
-
- 2 edits in trunk/Tools
[chromium] Make the layout test script's kill timeout proportional to --time-out-ms
https://bugs.webkit.org/show_bug.cgi?id=68026
Patch by Lei Zhang <thestig@chromium.org> on 2011-09-23
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:45 PM Changeset in webkit [95874] by
-
- 3 edits2 adds in trunk
<rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
https://bugs.webkit.org/show_bug.cgi?id=68737
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/text/combining-character-sequence-fallback-crash.html
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
number of FontData instances in the fallback list rather than the number of font families in the
font description.
LayoutTests:
- fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
- fast/text/combining-character-sequence-fallback-crash.html: Added.
- 3:44 PM Changeset in webkit [95873] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove WEBWIDGET_HAS_ANIMATE_CHANGES #define
https://bugs.webkit.org/show_bug.cgi?id=68720
Reviewed by James Robinson.
References to this macro were removed in http://crrev.com/102314.
- public/WebWidget.h:
- 3:41 PM Changeset in webkit [95872] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 3:34 PM Changeset in webkit [95871] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Crash in WebCore::DatabaseObserver
https://bugs.webkit.org/show_bug.cgi?id=67805
Patch by Stephen Chenney <schenney@chromium.org> on 2011-09-23
Reviewed by David Levin.
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase): Added a check for a
null frame or page, and return false if null. Investigated
changing the fall-through return value to false but decided against
it given the way the code is used and existing default values for
related code. Reproduction and testing depends on having a document
with no frame or no page, which sometimes happens in practice but is
hard to construct explicitly.
- 3:28 PM Changeset in webkit [95870] by
-
- 10 edits4 adds1 delete in trunk
[Chromium] Fix CSS 3D corner anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=68087
Patch by David Reveman <reveman@chromium.org> on 2011-09-23
Reviewed by James Robinson.
Source/WebCore:
Render sharp corners more correctly by adding bounding box
edges to anti-aliasing shaders.
Test: platform/chromium/compositing/3d-corners.html
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
LayoutTests:
Add a test to check sharp corner rendering of CSS 3D transformed
elements.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
- platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
- platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium/compositing/3d-corners-expected.txt: Added.
- platform/chromium/compositing/3d-corners.html: Added.
- platform/chromium/test_expectations.txt:
- 3:22 PM Changeset in webkit [95869] by
-
- 2 edits in trunk/LayoutTests
Add failing expectations for tests added by r95852.
- platform/chromium/test_expectations.txt:
- 3:13 PM Changeset in webkit [95868] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG implementation of PutScopedVar corrupts register allocation
https://bugs.webkit.org/show_bug.cgi?id=68735
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-23
Reviewed by Oliver Hunt.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:10 PM Changeset in webkit [95867] by
-
- 3 edits in trunk/LayoutTests
Updating now-passing Layout test.
Rubber stamped by geoff garen
- fast/js/Object-getOwnPropertyNames-expected.txt:
- fast/js/script-tests/Object-getOwnPropertyNames.js:
- 3:08 PM Changeset in webkit [95866] by
-
- 2 edits in branches/chromium/874/Source/WebCore/rendering
Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8037003
- 3:05 PM Changeset in webkit [95865] by
-
- 17 edits2 adds in trunk/Source
Make write barriers actually do something when enabled
https://bugs.webkit.org/show_bug.cgi?id=68717
Reviewed by Geoffrey Garen.
../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
Add a basic card marking style write barrier to JSC (currently
turned off). This requires two scratch registers in the JIT
so there was some register re-arranging to satisfy that requirement.
Happily this produced a minor perf bump in sunspider (~0.5%).
Turning the barriers on causes an overall regression of around 1.5%
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
- assembler/X86Assembler.h:
(JSC::X86Assembler::movb_i8m):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotCell):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::markCellCard):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- heap/CardSet.h: Added.
(JSC::CardSet::CardSet):
(JSC::::cardForAtom):
(JSC::::cardMarkedForAtom):
(JSC::::markCardForAtom):
- heap/Heap.cpp:
- heap/Heap.h:
(JSC::Heap::addressOfCardFor):
(JSC::Heap::writeBarrierFastCase):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
(JSC::MarkedBlock::offsetOfCards):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
Add a forwarding header, and fix an evaluation ordering
issue that shows up if you try to use write barriers.
- ForwardingHeaders/heap/CardSet.h: Added.
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- 2:59 PM Changeset in webkit [95864] by
-
- 3 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=68077
SH4 assemblers doesn't refer to executable memory handle.
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-23
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branch8):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
- 2:51 PM Changeset in webkit [95863] by
-
- 4 edits in trunk/Source/WebCore
Avoid updating compositing state during paint
https://bugs.webkit.org/show_bug.cgi?id=68727
Reviewed by Simon Fraser.
We shouldn't update our compositing state in the middle of a paint. The call to
updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
- rendering/RenderLayerCompositor.h:
- 2:51 PM Changeset in webkit [95862] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed. Chromium rebaselines for r95857.
- platform/chromium-linux/fast/ruby/ruby-text-before-after-content-expected.png: Added.
- platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.png: Added.
- platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
- 2:48 PM Changeset in webkit [95861] by
-
- 2 edits in trunk/Source/WebKit/chromium
occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.
Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):
- 2:39 PM Changeset in webkit [95860] by
-
- 7 edits in trunk/Source
Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
https://bugs.webkit.org/show_bug.cgi?id=68648
Reviewed by Dimitri Glazkov.
Source/WebCore:
No new tests because there's no change in functionality (yet).
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::paintOverhangAreas):
- platform/chromium/ScrollbarThemeChromium.h:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Source/WebKit/chromium:
- features.gypi:
- 2:35 PM Changeset in webkit [95859] by
-
- 8 edits in trunk
remove physical flex-flow values to match the updated spec
https://bugs.webkit.org/show_bug.cgi?id=68728
Reviewed by Tony Chang.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js:
- 2:31 PM Changeset in webkit [95858] by
-
- 1 copy in tags/Safari-535.3.1-Win
New tag
- 2:01 PM Changeset in webkit [95857] by
-
- 4 edits3 adds in trunk
Source/WebCore: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625
Reviewed by Dave Hyatt.
Test: fast/ruby/ruby-text-before-after-content.html
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::updateBeforeAfterContent):
- rendering/RenderRubyText.h:
LayoutTests: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625
Reviewed by Dave Hyatt.
- fast/ruby/ruby-text-before-after-content-expected.png: Added.
- fast/ruby/ruby-text-before-after-content-expected.txt: Added.
- fast/ruby/ruby-text-before-after-content.html: Added.
- 1:32 PM Changeset in webkit [95856] by
-
- 5 edits in trunk/Source/WebCore
refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665
Reviewed by Tony Chang.
This is just a refactor. Just move the all the code that needs to
be flow aware into helper functions. Actually making them flow-aware
can be done in a followup patch.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
- 1:25 PM Changeset in webkit [95855] by
-
- 7 edits6 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68719
Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
columns, when regions have a non-uniform height, we may need to push through multiple regions
in order to find one that fits.
Added an optimization for quickly noticing if regions do have a uniform height so that we can
treat them like columns and pages if so.
Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
the new tests.
Reviewed by Anders Carlsson.
Source/WebCore:
Added new tests in fast/regions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::matchedEndLine):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
- rendering/RenderFlowThread.h:
LayoutTests:
- fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
- fast/regions/webkit-flow-float-unable-to-push.html: Added.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
- 1:21 PM Changeset in webkit [95854] by
-
- 2 edits in trunk/Source/JavaScriptCore
PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721
Reviewed by Anders Carlsson.
Another assertion fix.
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
- 1:11 PM Changeset in webkit [95853] by
-
- 2 edits in trunk/Source/WebKit2
Move WebHitTestResult files to Shared/ in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=68718
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- 12:56 PM Changeset in webkit [95852] by
-
- 10 edits47 adds in trunk
Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546
Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
Reviewed by David Hyatt.
Source/WebCore:
Move CollapsedBorderValues into RenderTable.h.
Calculate collapsed borders only once and re-use during paintObject().
Invalidate cache when cell, row, row group, col, col group or table border is changed.
Tests: fast/table/border-collapsing/cached-cell-append.html
fast/table/border-collapsing/cached-cell-remove.html
fast/table/border-collapsing/cached-change-cell-border-color.html
fast/table/border-collapsing/cached-change-cell-border-width.html
fast/table/border-collapsing/cached-change-col-border-color.html
fast/table/border-collapsing/cached-change-col-border-width.html
fast/table/border-collapsing/cached-change-colgroup-border-color.html
fast/table/border-collapsing/cached-change-colgroup-border-width.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-row-border-width.html
fast/table/border-collapsing/cached-change-table-border-color.html
fast/table/border-collapsing/cached-change-table-border-width.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-width.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
(WebCore::RenderTable::layout): Invalidate cache if layout changed.
(WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
(WebCore::RenderTable::paintObject): Use cached collapsed borders.
- rendering/RenderTable.h:
(WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
(WebCore::RenderTable::currentBorderValue): Rename to use word "value".
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.
Rename to use word "value".
(WebCore::addBorderStyle):
(WebCore::RenderTableCell::collectBorderValues):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::sortBorderValues):
(WebCore::RenderTableCell::paintCollapsedBorder):
- rendering/RenderTableCell.h:
If border changed, invalidate cache.
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
LayoutTests:
Tests for invalidating collapsed borders cache.
- fast/table/border-collapsing/cached-cell-append-expected.png: Added.
- fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
- fast/table/border-collapsing/cached-cell-append.html: Added.
- fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
- fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
- fast/table/border-collapsing/cached-cell-remove.html: Added.
- fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
- fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
- fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-col-border-color.html: Added.
- fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-col-border-width.html: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
- fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-row-border-color.html: Added.
- fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-row-border-width.html: Added.
- fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-table-border-color.html: Added.
- fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-table-border-width.html: Added.
- fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
- fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
- fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
- fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
- 12:48 PM Changeset in webkit [95851] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716
Reviewed by Darin Adler.
Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- 12:46 PM Changeset in webkit [95850] by
-
- 5 edits in trunk
update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698
Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).
Also updates layout_test code to work with that change.
Patch by Elliot Poger <epoger@google.com> on 2011-09-23
Reviewed by Mihai Parparita.
Source/WebKit/chromium:
- DEPS:
Tools:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- 12:40 PM Changeset in webkit [95849] by
-
- 81 edits in trunk
Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
.:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- Source/autotools/symbols.filter:
Source/JavaScriptCore:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):
- debugger/DebuggerActivation.h:
- heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):
- runtime/Arguments.cpp:
(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):
- runtime/Arguments.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):
- runtime/Executable.h:
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):
- runtime/GetterSetter.h:
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
- runtime/JSArray.cpp:
(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):
- runtime/JSArray.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):
- runtime/JSBoundFunction.h:
- runtime/JSCell.h:
(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):
- runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):
- runtime/JSObject.h:
(JSC::JSObject::visitChildrenDirect):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):
- runtime/JSPropertyNameIterator.h:
- runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):
- runtime/JSStaticScopeObject.h:
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):
- runtime/JSWrapperObject.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):
- runtime/NativeErrorConstructor.h:
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h:
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):
- runtime/ScopeChain.h:
- runtime/Structure.cpp:
(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
- runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):
- runtime/StructureChain.h:
Source/JavaScriptGlue:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- UserObjectImp.cpp:
(UserObjectImp::visitChildrenVirtual):
(UserObjectImp::visitChildren):
- UserObjectImp.h:
Source/WebCore:
No new tests.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- WebCore.exp.in:
- bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):
- bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):
- bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):
- bindings/scripts/test/JS/JSTestObj.h:
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
- bridge/qt/qt_runtime.h:
- workers/WorkerContext.h:
- 12:31 PM Changeset in webkit [95848] by
-
- 3 edits1 delete in trunk/Source/WebKit
Axe WebImageRendererFactory
https://bugs.webkit.org/show_bug.cgi?id=68715
Reviewed by Darin Adler.
../..:
Remove WebImageRendererFactory.m from the Xcode project.
- WebKit.xcodeproj/project.pbxproj:
../../mac:
Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
- WebCoreSupport/WebImageRendererFactory.m: Removed.
- 12:24 PM Changeset in webkit [95847] by
-
- 15 edits in trunk/Source/WebKit
Add OVERRIDE to a bunch of virtual member functions on clients
https://bugs.webkit.org/show_bug.cgi?id=68712
Reviewed by Sam Weinig.
../..:
- WebKit.xcodeproj/project.pbxproj:
../../mac:
- Configurations/Base.xcconfig:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebDeviceOrientationClient.h:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebGeolocationClient.h:
- WebCoreSupport/WebIconDatabaseClient.h:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebPlatformStrategies.h:
- 12:19 PM Changeset in webkit [95846] by
-
- 2 edits in trunk/Source/JavaScriptCore
Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713
Reviewed by Sam Weinig.
This was causing assertion failures.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- 12:19 PM Changeset in webkit [95845] by
-
- 17 edits4 copies in trunk/LayoutTests
Clarify wording in cross origin XSL tests and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=68683
The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.
Reviewed by Alexey Proskuryakov.
- http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- http/tests/security/cross-origin-xsl-BLOCKED.html:
- http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
- platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/gtk/Skipped:
- platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/wk2/Skipped:
- 12:17 PM Changeset in webkit [95844] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make sure to define OVERRIDE and FINAL for older builds of clang.
- wtf/Compiler.h:
- 12:07 PM Changeset in webkit [95843] by
-
- 2 edits in trunk/LayoutTests
Mark two more tests as flaky.
- platform/chromium/test_expectations.txt:
- 12:07 PM Changeset in webkit [95842] by
-
- 2 edits4 copies in branches/chromium/874
Merge 95410 - Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: inspector/timeline/timeline-dom-content-loaded-event.html
inspector/timeline/timeline-load-event.html
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
LayoutTests:
- inspector/timeline/timeline-animation-frame.html:
- inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
- inspector/timeline/timeline-dom-content-loaded-event.html: Added.
- inspector/timeline/timeline-load-event-expected.txt: Added.
- inspector/timeline/timeline-load-event.html: Added.
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8021012
- 11:57 AM Changeset in webkit [95841] by
-
- 2 edits in branches/chromium/874/Source/WebCore/inspector/front-end
Merge 95401 - Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313
windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineModel.prototype._saveToFile):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8018012
- 11:52 AM Changeset in webkit [95840] by
-
- 6 edits in trunk/Source/JavaScriptCore
Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704
Reviewed by Oliver Hunt.
This is performance neutral, but increases coverage.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:51 AM Changeset in webkit [95839] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove extra space at the beginning of the last line.
https://bugs.webkit.org/show_bug.cgi?id=68710
Reviewed by Gustavo Noronha Silva.
- platform/network/soup/SocketStreamHandleSoup.cpp:
- 11:41 AM Changeset in webkit [95838] by
-
- 2 edits in trunk/LayoutTests
Mark a test as flaky.
- platform/chromium/test_expectations.txt:
- 11:24 AM Changeset in webkit [95837] by
-
- 2 edits in trunk/Source/WebCore
2011-09-23 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Fix coding style issues in ResourceRequestSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68707
Reviewed by Xan Lopez.
This patch fixes some issues as reported by check-webkit-style.
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
- 11:18 AM Changeset in webkit [95836] by
-
- 1370 edits476 copies30 deletes in releases/WebKitGTK/webkit-1.6
Updating WebKitGTK+ branch to to the state of the 1.5.90 release
- 11:15 AM Changeset in webkit [95835] by
-
- 1 edit in branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php
Merge 95322 - http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242
Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).
- http/tests/history/back-with-fragment-change.php:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8018010
- 11:07 AM Changeset in webkit [95834] by
-
- 18 edits in trunk/Source/WebKit2
Add OVERRIDE to overrides of virtual member functions in client classes
https://bugs.webkit.org/show_bug.cgi?id=68702
Reviewed by Darin Adler.
Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
they have been removed from their respective base classes.
- Configurations/Base.xcconfig:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
- win/WebKit2Common.vsprops:
- 10:46 AM Changeset in webkit [95833] by
-
- 2 edits in trunk/Source/JavaScriptCore
Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.
- wtf/Platform.h:
- 10:46 AM Changeset in webkit [95832] by
-
- 2 edits in trunk/Tools
Fix the build.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
the WTF namespace.
- 10:38 AM Changeset in webkit [95831] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit
Include MSVC2010 in the list of compilers where incremental
build is disabled (INCREMENTAL:NO).
Change suggested by Simo Falt <simo.falt@nokia.com>, already present
in the Qt-4.8 repository where the problem was identified.
- WebCore.pri:
- 10:11 AM Changeset in webkit [95830] by
-
- 2 edits in branches/chromium/874/Source/WebCore
Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558
Reviewed by Stephen White.
The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8020006
- 10:04 AM Changeset in webkit [95829] by
-
- 11 edits in branches/chromium/874
Merge 94582 - Style not propagated to anonymous boxes and anonymous
inline-blocks.
BUG=95520
Review URL: http://codereview.chromium.org/8017007
- 10:03 AM Changeset in webkit [95828] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Normalize test names.
- inspector/performance/resources/first-open-elements.html:
- inspector/performance/resources/first-open-resources.html:
- 10:01 AM Changeset in webkit [95827] by
-
- 5 edits4 copies in branches/chromium/874/LayoutTests/platform
Merge 95696 - Unreviewed. Chromium rebaselines for r95671.
BUG=95520
Review URL: http://codereview.chromium.org/8018006
- 9:59 AM Changeset in webkit [95826] by
-
- 2 edits in trunk/Source/WebCore
Try to fix warning seen in some 32-bit builds.
- rendering/RenderBoxModelObject.cpp:
(WebCore::backgroundRectAdjustedForBleedAvoidance):
Use an explicit cast for the conversion from a double to a LayoutUnit.
- 9:59 AM Changeset in webkit [95825] by
-
- 15 copies in branches/chromium/874/LayoutTests/platform
Merge 95477 - Unreviewed. Chromium Rebaselines for r95461.
BUG=95520
Review URL: http://codereview.chromium.org/8015011
- 9:57 AM Changeset in webkit [95824] by
-
- 14 edits3 copies in branches/chromium/874
Merge 95671 - Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
BUG=95520
Review URL: http://codereview.chromium.org/8016006
- 9:49 AM Changeset in webkit [95823] by
-
- 2 edits in trunk/Source/JavaScriptCore
We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654
Reviewed by David Hyatt.
Add OVERRIDE and FINAL macros for compilers that support them.
- wtf/Compiler.h:
- 9:47 AM Changeset in webkit [95822] by
-
- 1 edit1 move in trunk/LayoutTests
Fix typo in file name from http://trac.webkit.org/changeset/95813.
Unreviewed.
- platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
- platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
- 9:45 AM Changeset in webkit [95821] by
-
- 3 edits in branches/chromium/874/Source/WebCore/dom
Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8002029
- 9:43 AM Changeset in webkit [95820] by
-
- 1 edit in branches/chromium/874/Source/WebCore/dom/Document.cpp
Merge 95497
BUG=95639
Review URL: http://codereview.chromium.org/8016005
- 9:41 AM Changeset in webkit [95819] by
-
- 1 edit2 copies in branches/chromium/874
Merge 95059 - Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
BUG=95639
Review URL: http://codereview.chromium.org/8018005
- 9:39 AM Changeset in webkit [95818] by
-
- 1 edit2 adds in trunk/LayoutTests
Rebaseline after http://trac.webkit.org/changeset/95799
Unreviewed.
- platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
- platform/mac/media/video-playing-and-pause-expected.txt: Added.
- 9:38 AM Changeset in webkit [95817] by
-
- 15 copies in branches/chromium/874/LayoutTests/fast/table
Merge 95461 - Child not placed correctly when beforeChild (table part)
BUG=95520
Review URL: http://codereview.chromium.org/8008019
- 9:31 AM Changeset in webkit [95816] by
-
- 2 edits2 copies in branches/chromium/874
Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8015009
- 9:26 AM Changeset in webkit [95815] by
-
- 1 edit3 copies in branches/chromium/874
Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8020005
- 9:20 AM Changeset in webkit [95814] by
-
- 6 edits2 copies in branches/chromium/874
Merge 95489 - [V8] document.all gets confused about its prototype chain
BUG=96885
Review URL: http://codereview.chromium.org/8015008
- 9:19 AM Changeset in webkit [95813] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline after http://trac.webkit.org/changeset/95799
Unreviewed.
- platform/gtk/media/video-playing-and-pause-actual.txt: Added.
- 9:17 AM Changeset in webkit [95812] by
-
- 2 edits3 copies in branches/chromium/874
Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8002026
- 9:14 AM Changeset in webkit [95811] by
-
- 1 edit2 copies in branches/chromium/874
Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8015007
- 9:13 AM Changeset in webkit [95810] by
-
- 1 edit2 copies in branches/chromium/874
Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8016003
- 9:10 AM Changeset in webkit [95809] by
-
- 2 edits in trunk/LayoutTests
2011-09-23 Xan Lopez <xlopez@igalia.com>
[GTK] Skip crashing test fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=68700
Unreviewed.
- platform/gtk/Skipped:
- 9:09 AM Changeset in webkit [95808] by
-
- 4 edits2 copies in branches/chromium/874
Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8015006
- 8:57 AM Changeset in webkit [95807] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Clicking on error doesn't point on the correct line if user searched something
https://bugs.webkit.org/show_bug.cgi?id=68627
Reviewed by Yury Semikhatsky.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
- inspector/front-end/inspector.js:
(WebInspector._showAnchorLocationInPanel):
- 8:48 AM QtWebKitReleases edited by
- (diff)
- 8:22 AM Changeset in webkit [95806] by
-
- 4 edits6 adds in trunk
Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
https://bugs.webkit.org/show_bug.cgi?id=68631
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/styles/styles-redirected-css.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):
- http/tests/inspector/styles/resources/styles-redirected-css.css: Added.
(div):
- http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
- http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
- http/tests/inspector/styles/styles-redirected-css.html: Added.
- 8:08 AM Changeset in webkit [95805] by
-
- 3 edits2 adds in trunk
Web Inspector: XHRs requests with the same url as main resource should have correct category.
https://bugs.webkit.org/show_bug.cgi?id=68646
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
LayoutTests:
- http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
- http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.
- 8:06 AM Changeset in webkit [95804] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
https://bugs.webkit.org/show_bug.cgi?id=68696
Reviewed by Andreas Kling.
Instead of connecting signals and calling QtFileDownloader::onReadyRead()
on its constructor, QtFileDownloader will now handle this in start().
- WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
- WebProcess/Downloads/qt/QtFileDownloader.cpp:
(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::start):
- WebProcess/Downloads/qt/QtFileDownloader.h:
- 7:59 AM Changeset in webkit [95803] by
-
- 2 edits3 copies in branches/chromium/874
Merge 95083 - Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/debugger-pause-in-internal.html
- bindings/v8/DebuggerScript.js:
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
LayoutTests:
- inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
- inspector/debugger/debugger-pause-in-internal.html: Added.
- inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
- platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8017006
- 7:58 AM Changeset in webkit [95802] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update expectation for pservers-grad-14-b.svg on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=68697
Unreviewed rebaseline.
- platform/chromium/test_expectations.txt:
- 7:35 AM Changeset in webkit [95801] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
https://bugs.webkit.org/show_bug.cgi?id=68657
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
- inspector/front-end/inspector.js:
(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):
- 7:14 AM Changeset in webkit [95800] by
-
- 3 edits in trunk/Source/WebCore
[Gtk] Title attribute is not respected on option elements.
https://bugs.webkit.org/show_bug.cgi?id=68615
Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
Reviewed by Martin Robinson.
Set tooltip on PopupMenuGtk items created from GtkActions.
- platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()
to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text
from client when creating a GtkAction.
- 7:03 AM Changeset in webkit [95799] by
-
- 4 edits3 adds in trunk
[Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
https://bugs.webkit.org/show_bug.cgi?id=68589
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-playing-and-pause.html
As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
in MediaPlayerGstreamerPrivate::paused().
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::paused):
LayoutTests:
- media/video-playing-and-pause.html: Added.
- media/video-paint-test.js:
- platform/qt/media/video-playing-and-pause-expected.txt: Added.
- platform/qt/media/video-playing-and-pause-expected.png: Added.
- 6:48 AM Changeset in webkit [95798] by
-
- 1 edit2 moves4 adds2 deletes in trunk/LayoutTests
[chromium, gtk, qt] Rebaseline following r95726
https://bugs.webkit.org/show_bug.cgi?id=68694
Unreviewed rebaseline.
- css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt.
- css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt.
- platform/chromium/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/chromium/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
- 6:17 AM Changeset in webkit [95797] by
-
- 5 edits in trunk
Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144
Source/WebCore:
Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
Reviewed by Pavel Feldman.
- inspector/front-end/SourceFile.js:
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/debugger/content-providers-expected.txt:
- inspector/debugger/content-providers.html:
- 6:04 AM Changeset in webkit [95796] by
-
- 2 edits in trunk/LayoutTests
2011-09-23 Xan Lopez <xlopez@igalia.com>
Unreviewed rebaseline.
- platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
- 5:43 AM Changeset in webkit [95795] by
-
- 7 edits in trunk/LayoutTests
[chromium] Rebaseline following r95745, r95725
https://bugs.webkit.org/show_bug.cgi?id=68685
Unreviewed rebaseline.
- platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/chromium/test_expectations.txt:
- 5:06 AM Changeset in webkit [95794] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 4:43 AM Changeset in webkit [95793] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r95383.
http://trac.webkit.org/changeset/95383
https://bugs.webkit.org/show_bug.cgi?id=68690
It broke WebInspector.Timeline.LoadFromFile feature.
(Requested by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 3:59 AM Changeset in webkit [95792] by
-
- 1 edit1 add in trunk/LayoutTests
Web Inspector: UI performance test for Scripts panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68541
The test's body has dummy scripts section copied from inspector-test.jss
Reviewed by Yury Semikhatsky.
- inspector/performance/resources/first-open-scripts.html:
- 3:56 AM Changeset in webkit [95791] by
-
- 4 edits2 adds in trunk
use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555
Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Event listeners can outlive the tref element that created them when
the tref is cloned and then garbage collected, causing a dangling pointer to the
tref. To fix this do not install event listener until the tref is inserted into the document.
Test: svg/custom/tref-clone-crash.html
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged):
(WebCore::SVGTRefElement::insertedIntoDocument):
- svg/SVGTRefElement.h:
LayoutTests:
Test that cloned tref does not cause a crash.
- svg/custom/tref-clone-crash-expected.txt: Added.
- svg/custom/tref-clone-crash.html: Added.
- 3:46 AM Changeset in webkit [95790] by
-
- 5 edits in trunk/Source/WebCore
ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
https://bugs.webkit.org/show_bug.cgi?id=68291
Reviewed by Tony Chang.
- dom/Document.cpp:
(WebCore::Document::finishedParsing):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
- 3:35 AM Changeset in webkit [95789] by
-
- 2 edits in trunk/LayoutTests
2011-09-23 Xan Lopez <xlopez@igalia.com>
Crash on editing/pasteboard/drag-drop-input-in-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68686
Unreviewed, skip crashing test.
- platform/gtk/Skipped:
- 2:19 AM Changeset in webkit [95788] by
-
- 3 edits in trunk/LayoutTests
plugins/mouse-click-iframe-to-plugin.html should not use flash plugin
https://bugs.webkit.org/show_bug.cgi?id=68601
Use the test plugin that we always have.
- platform/qt-wk2/Skipped: Unskip the test.
- plugins/mouse-click-iframe-to-plugin.html:
- 12:18 AM Changeset in webkit [95787] by
-
- 6 edits3 adds in trunk
Source/JavaScriptCore: GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Oliver Hunt.
Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasPrediction):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
LayoutTests: [Qt] Unreviewed gardening, update expected file after r95745.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2011-09-22
- platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
Sep 22, 2011:
- 11:59 PM Changeset in webkit [95786] by
-
- 6 edits in trunk/Source/JavaScriptCore
GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676
Reviewed by Oliver Hunt.
Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasPrediction):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
- 10:58 PM Changeset in webkit [95785] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected file after r95745.
- platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- 10:53 PM Changeset in webkit [95784] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix after r95764, update expected fail to expected pass.
- ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
- 9:54 PM Changeset in webkit [95783] by
-
- 5 edits3 adds in trunk
implement -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=67432
Reviewed by Ojan Vafai.
Source/WebCore:
flex-order can be an int (including negative), but we disallow the two
smallest values so we can put the numbers into a hash set.
Also, create two iterators: one that goes in render tree order (we use
this for the first pass and to collect the possible flex order values)
and one that goes in flex order.
Test: css3/flexbox/flex-order.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- rendering/RenderFlexibleBox.cpp:
(WebCore::FlexOrderHashTraits::emptyValue):
(WebCore::FlexOrderHashTraits::constructDeletedValue):
(WebCore::FlexOrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator
that goes in render tree order.
(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
(WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that
goes in flex-order order. Creating this involves sorting, so only create it once
and pass it around.
(WebCore::RenderFlexibleBox::FlexOrderIterator::first):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/flex-order-expected.png: Added.
- css3/flexbox/flex-order-expected.txt: Added.
- css3/flexbox/flex-order.html: Added.
- 9:10 PM Changeset in webkit [95782] by
-
- 2 edits in trunk/Source/WebCore
Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68667
Reviewed by Simon Fraser.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
AffineTransform::yScale instead of the custom code here that seems to do
the same thing.
- 9:00 PM Changeset in webkit [95781] by
-
- 2 edits in trunk/Tools
enable NRWT for run-webkit-tests on Lion
https://bugs.webkit.org/show_bug.cgi?id=68673
Reviewed by Eric Seidel.
- Scripts/run-webkit-tests:
(useNewRunWebKitTests):
- 8:35 PM Changeset in webkit [95780] by
-
- 50 edits in trunk/LayoutTests
Rebaseline for bug 65583 (path based border radius drawing on skia) part 6
https://bugs.webkit.org/show_bug.cgi?id=68671
Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.
- platform/chromium-linux/tables/mozilla/marvin/: 9 changes
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/: 14 changes
- platform/chromium-linux/transforms/svg-vs-css-expected.png:
- platform/chromium-win/tables/mozilla/marvin/: 9 changes
- platform/chromium-win/tables/mozilla_expected_failures/marvin/: 14 changes
- platform/chromium-win/transforms/svg-vs-css-expected.png:
- platform/chromium/test_expectations.txt:
- 8:27 PM Changeset in webkit [95779] by
-
- 2 edits in trunk/Source/JavaScriptCore
PPC build fix, part 3.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForConstructInternal):
- 8:21 PM Changeset in webkit [95778] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded type conversion from background bleed code
https://bugs.webkit.org/show_bug.cgi?id=68669
Reviewed by Geoffrey Garen.
- rendering/RenderBoxModelObject.cpp:
(WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
and eliminate superflous conversion to float and use of FloatSize. Also added
a "why" comment.
- 8:00 PM Changeset in webkit [95777] by
-
- 6 edits in trunk/Source/WebCore
Refactor checks for antialiasing lines to share a single function
https://bugs.webkit.org/show_bug.cgi?id=68666
Reviewed by Dan Bernstein.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.
- rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorder): Ditto.
- 7:41 PM Changeset in webkit [95776] by
-
- 3 edits in trunk/Source/WebCore
Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297
Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.
No functional change, no new test needed.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
- 7:40 PM Changeset in webkit [95775] by
-
- 2 edits in trunk/LayoutTests
Adding testTracks() function to video-test.js
https://bugs.webkit.org/show_bug.cgi?id=68643
Reviewed by Eric Carlson.
- media/video-test.js:
(testTracks):
- 7:28 PM Changeset in webkit [95774] by
-
- 5 edits6 adds in trunk
Make XSSAuditor extract meaningful snippet from script blocks for comparison
against the URL when checking for reflection. Avoids getting caugh up in
trailing comments.
https://bugs.webkit.org/show_bug.cgi?id=68094
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-22
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::extractCodeFragment):
- html/parser/XSSAuditor.h:
LayoutTests:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.
- 7:27 PM Changeset in webkit [95773] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] TouchWebView load test not running
https://bugs.webkit.org/show_bug.cgi?id=68620
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-22
Reviewed by Chang Shu.
Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 7:16 PM Changeset in webkit [95772] by
-
- 3 edits in trunk/Source/JavaScriptCore
Another PPC build fix.
- runtime/Executable.cpp:
- runtime/Executable.h:
- 6:56 PM Changeset in webkit [95771] by
-
- 55 edits2 moves1 add in trunk/LayoutTests
Rebaseline for bug 65583 (path based border radius drawing on skia) part 5
https://bugs.webkit.org/show_bug.cgi?id=68608
Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.
- platform/chromium-linux/css2.1/: 14 changes
- platform/chromium-linux/editing/execCommand/5138441-expected.png:
- platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
- platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
- platform/chromium-linux/fast/: 9 changes
- platform/chromium-win/css2.1/: 14 changes
- platform/chromium-win/editing/execCommand/5138441-expected.png:
- platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
- platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
- platform/chromium-win/fast/: 10 changes
- platform/chromium/test_expectations.txt:
- platform/win-xp/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt.
- platform/win/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
- 6:42 PM Changeset in webkit [95770] by
-
- 3 edits1 add in trunk/Tools
Add unit test for existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67080
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-22
Reviewed by Darin Adler.
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
(operator<<):
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):
- 6:33 PM WebKit Team edited by
- Moving me around (diff)
- 6:33 PM AddingFeatures created by
- Figured it was worth documenting how to add a feature
- 6:29 PM Changeset in webkit [95769] by
-
- 2 edits in trunk/LayoutTests
Updated expectations and filed WK68674.
- platform/chromium/test_expectations.txt:
- 6:21 PM WikiStart edited by
- Adding link to new ENABLE page (diff)
- 6:12 PM Changeset in webkit [95768] by
-
- 16 edits in trunk/Source/WebCore
Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
Instead, add a load-specific policy for showing the user authentication
challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330
Reviewed by Alexey Proskuryakov.
No new tests, refactor only.
- loader/DocumentThreadableLoader.cpp:
- loader/DocumentThreadableLoader.h:
- loader/MainResourceLoader.cpp:
- loader/NetscapePlugInStreamLoader.cpp:
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
For resource types that always send a challenge to the embedder,
this patch doesn't change anything. For those that don't, we will
always try to continue without credentials when they are forbidden
and the platform supports it.
When continuing without credentials was initially implemented in
DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
then canceled the SubresourceLoader. This was necessary because of the
quirks of ThreadableLoader cancellation (we sever the client/loader connections
before the load actually cancels), but a simple didFail() should suffice at
the ResourceLoader layer.
- loader/ResourceLoaderOptions.h:
- loader/SubresourceLoader.cpp:
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResourceLoader.cpp:
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconLoader.cpp: The ResourceLoader implementation of
didReceiveAuthenticationChallege means that IconLoader will now
try to continue with credentials on platforms that support it,
rather than just canceling outright. We still will never prompt
for authentication for icons.
- loader/icon/IconLoader.h:
- 5:43 PM Changeset in webkit [95767] by
-
- 2 edits in trunk/Tools
[EFL] Use ewk_view to navigate in history instead of ewk_history.
https://bugs.webkit.org/show_bug.cgi?id=68455
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.
BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.
This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.
- DumpRenderTree/efl/WorkQueueItemEfl.cpp:
(BackForwardItem::invoke):
- 5:38 PM Changeset in webkit [95766] by
-
- 13 edits in trunk
Add ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=68652
Reviewed by Simon Fraser.
- Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
- Source/WebCore/Configurations/FeatureDefines.xcconfig:
- Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
- Source/WebKit2/Configurations/FeatureDefines.xcconfig:
- WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
- WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
- Tools/Scripts/build-webkit:
- 5:02 PM Changeset in webkit [95765] by
-
- 2 edits in trunk/Source/WebCore
Make sure to update scrollbars in ScrollView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=68663
Reviewed by Sam Weinig.
Call updateScrollbars after setting the frame rect. This was previously done by the
call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
completely in http://trac.webkit.org/changeset/95725.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
- 4:57 PM Changeset in webkit [95764] by
-
- 5 edits in trunk
Function.prototype.bind.length shoudl be 1.
Rubber stamped by Olier Hunt.
Source/JavaScriptCore:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
LayoutTests:
- fast/js/function-bind-expected.txt:
- fast/js/script-tests/function-bind.js:
- 4:24 PM Changeset in webkit [95763] by
-
- 2 edits in trunk/Source/JavaScriptCore
PPC build fix.
- bytecode/CodeBlock.h:
- 4:22 PM Changeset in webkit [95762] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix pt. 2
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:05 PM Changeset in webkit [95761] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix pt. 1
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:58 PM Changeset in webkit [95760] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac]Unreviewed gardening.
New Qt specific results were added by r95723, but they fail on Qt-Mac platform
- platform/qt-mac/Skipped: Skip css3/selectors3 tests.
- 3:49 PM Changeset in webkit [95759] by
-
- 11 edits1 copy1 add in trunk/Source/WebKit2
Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644
Reviewed by Sam Weinig.
Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.
Make some inline helper methods to create WKSize, WKPoint and WKRect
types.
- GNUmakefile.am:
- Shared/API/c/WKBase.h:
- Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.
(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):
- Shared/API/c/WKGeometry.h:
(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):
- Shared/API/c/WKSharedAPICast.h:
- Shared/APIObject.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebGeometry.h: Added.
(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2API.pri:
- win/WebKit2.vcproj:
- 3:42 PM Changeset in webkit [95758] by
-
- 13 edits in trunk/Source/JavaScriptCore
DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582
Reviewed by Darin Adler.
This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.
When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
(JSC::JSGlobalData::scratchBufferForSize):
- 3:35 PM Changeset in webkit [95757] by
-
- 4 edits in trunk/Source/WebCore
Progress control gets cropped on the bottom
https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/10069915>
Reviewed by Kent Tamura.
As it turns out the smaller control type does not get rendered either, so this patch
fixes both.
- manual-tests/dom/progressbar.html: Altered to show both sizes of controls
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.
- 3:28 PM Changeset in webkit [95756] by
-
- 5 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68658
Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.
Reviewed by Anders Carlsson.
Source/WebCore:
Added new tests in fast/regions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
- rendering/RenderBlock.h:
Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.
(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.
LayoutTests:
- fast/regions/webkit-flow-inlines-dynamic.html: Added.
- platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
- 3:13 PM Changeset in webkit [95755] by
-
- 2 edits in trunk/Tools
EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
https://bugs.webkit.org/show_bug.cgi?id=68660
Reviewed by Adam Barth.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseUp):
- 3:02 PM Changeset in webkit [95754] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597
Reviewed by Darin Adler.
This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).
This is a 4% win on Kraken and a 1% loss on V8.
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
- 2:55 PM Changeset in webkit [95753] by
-
- 6 edits in trunk/Source/JavaScriptCore
Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653
Reviewed by Gavin Barraclough.
Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:43 PM Changeset in webkit [95752] by
-
- 2 edits in trunk/LayoutTests
Skip test that need new baselines.
- platform/mac/Skipped:
- 2:22 PM Changeset in webkit [95751] by
-
- 58 edits5 adds in trunk
Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382
Reviewed by Sam Weinig.
Source/JavaScriptCore:
This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.
- JavaScriptCore.JSVALUE32_64only.exp:
- JavaScriptCore.JSVALUE64only.exp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITStubs.h:
- jsc.cpp:
(GlobalObject::addFunction):
- runtime/CommonIdentifiers.h:
- runtime/ConstructData.h:
- runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
- runtime/FunctionPrototype.h:
- runtime/JSBoundFunction.cpp: Added.
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):
- runtime/JSBoundFunction.h: Added.
(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):
- runtime/JSFunction.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundFunctionStructure):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
Source/WebCore:
Test: fast/js/function-bind.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
- Function::create no longer requires functionStructure() to be passed.
LayoutTests:
We now pass Function.bind tests.
- fast/js/Object-getOwnPropertyNames-expected.txt:
- fast/js/basic-strict-mode-expected.txt:
- fast/js/function-bind-expected.txt: Added.
- fast/js/function-bind.html: Added.
- fast/js/mozilla/strict/15.3.4.5-expected.txt:
- fast/js/script-tests/function-bind.js: Added.
- ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
- ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
- ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
- ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
- ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
- ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
- ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
- ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
- ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
- ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
- ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
- ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
- 1:50 PM Changeset in webkit [95750] by
-
- 11 edits1 add1 delete in trunk
https://bugs.webkit.org/show_bug.cgi?id=68650
Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.
Reviewed by Sam Weinig.
Source/WebCore:
Covered by existing fast/regions tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.
(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.
(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.
(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.
(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.
LayoutTests:
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
- 1:37 PM Changeset in webkit [95749] by
-
- 5 edits in trunk/Source/WebCore
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570
Reviewed by Darin Adler.
These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.
This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
- rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
- 12:59 PM Changeset in webkit [95748] by
-
- 48 edits in branches/chromium/874
Revert 93001 - Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248
Reviewed by Justin Garcia.
Source/WebCore:
Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.
Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".
LayoutTests:
Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".
- editing/deleting/delete-br-012-expected.txt:
- editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
- editing/deleting/delete-select-all-001-expected.txt:
- editing/execCommand/16049-expected.txt:
- editing/execCommand/5685604-1.html:
- editing/execCommand/delete-image-in-anchor-expected.txt:
- editing/execCommand/hilitecolor-expected.txt:
- editing/execCommand/modifyForeColorByCharacter-expected.txt:
- editing/execCommand/query-font-size-expected.txt:
- editing/execCommand/remove-format-multiple-elements-expected.txt:
- editing/execCommand/script-tests/remove-format-multiple-elements.js:
- editing/execCommand/script-tests/toggle-text-decorations.js:
- editing/execCommand/script-tests/toggle-unlink.js:
- editing/execCommand/toggle-style-2-expected.txt:
- editing/execCommand/toggle-text-decorations-expected.txt:
- editing/execCommand/toggle-unlink-expected.txt:
- editing/inserting/5994480-2-expected.txt:
- editing/pasteboard/5065605-expected.txt:
- editing/pasteboard/copy-null-characters-expected.txt:
- editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
- editing/pasteboard/data-transfer-items-expected.txt:
- editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
- editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
- editing/pasteboard/onpaste-text-html-expected.txt:
- editing/pasteboard/paste-text-with-style-2-expected.txt:
- editing/style/apply-font-size-to-multiple-nodes-expected.txt:
- editing/style/block-style-004-expected.txt:
- editing/style/block-style-005-expected.txt:
- editing/style/block-style-006-expected.txt:
- editing/style/fontsize-1-expected.txt:
- editing/style/fore-color-by-name-expected.txt:
- editing/style/highlight-insert-paragraph-expected.txt:
- editing/style/inline-style-container-expected.txt:
- editing/style/inline-style-extend-run-expected.txt:
- editing/style/invalid-font-size-expected.txt:
- editing/style/push-down-font-styles-expected.txt:
- editing/style/script-tests/inline-style-container.js:
- editing/style/script-tests/inline-style-extend-run.js:
- editing/style/script-tests/push-down-font-styles.js:
- editing/style/style-text-node-without-editable-parent-expected.txt:
- fast/events/ondrop-text-html-expected.txt:
- platform/chromium-win/editing/inserting/5994480-2-expected.txt:
- platform/gtk/editing/inserting/5994480-2-expected.txt:
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/7973008
- 12:41 PM Changeset in webkit [95747] by
-
- 8 edits in trunk/Source/WebKit2
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Reviewed by Anders Carlsson.
Re-landing with a slightly less aggressive check.
- 12:38 PM Changeset in webkit [95746] by
-
- 1 edit3 adds in trunk/LayoutTests
Platform-specific results for test introduced by r95726
- platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
- platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
- platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
- 12:25 PM Changeset in webkit [95745] by
-
- 10 edits17 deletes in trunk
Unreviewed, rolling out r95335 and r95645.
http://trac.webkit.org/changeset/95335
http://trac.webkit.org/changeset/95645
https://bugs.webkit.org/show_bug.cgi?id=68649
Wrong fix (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
Source/WebCore:
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
- editing/EditingStyle.h:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
- editing/markup.h:
LayoutTests:
- editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
- editing/deleting/merge-paragraph-from-address.html: Removed.
- editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
- editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
- editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
- editing/deleting/merge-paragraph-from-h6.html: Removed.
- editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
- editing/deleting/merge-paragraph-from-listing.html: Removed.
- editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
- editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
- editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
- editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
- editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
- editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
- editing/deleting/merge-paragraph-into-h1.html: Removed.
- editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
- editing/deleting/merge-paragraph-into-pre.html: Removed.
- platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
- 12:14 PM Changeset in webkit [95744] by
-
- 7 edits in trunk/LayoutTests
Unreviewed, update expected results after r95726
- platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
- platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
- 12:12 PM QtWebKitSecurity edited by
- (diff)
- 12:11 PM QtWebKitSecurity edited by
- (diff)
- 12:11 PM QtWebKitSecurity edited by
- (diff)
- 11:55 AM Changeset in webkit [95743] by
-
- 5 edits in trunk/Source/WebCore
Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):
- rendering/RenderWidget.cpp:
- 11:51 AM Changeset in webkit [95742] by
-
- 6 edits in trunk/Source/JavaScriptCore
Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640
Reviewed by Gavin Barraclough.
Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:31 AM Changeset in webkit [95741] by
-
- 1 edit24 adds11 deletes in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=68645
Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.
Reviewed by Beth Dakin.
- fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
- fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- fast/regions/flows-dependency-same-flow-expected.txt: Removed.
- fast/regions/render-region-renderer-expected.txt: Removed.
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
- fast/regions/webkit-flow-renderer-expected.txt: Removed.
- fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
- fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
- platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
- platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
- platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
- platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
- platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
- platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
- platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
- platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
- platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
- platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/mac/fast/regions/no-split-line-box-expected.png: Added.
- platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
- 11:12 AM Changeset in webkit [95740] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=68638
Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.
Reviewed by Dan Bernstein and Adam Roben.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
- rendering/RenderFlowThread.h:
- 11:03 AM Changeset in webkit [95739] by
-
- 2 edits in branches/chromium/874/Source/WebCore
Merge 94587 - [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621
CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
TBR=nduca@chromium.org
Review URL: http://codereview.chromium.org/7995010
- 11:02 AM QtWebKitReleases edited by
- (diff)
- 11:02 AM QtWebKitRelease22 edited by
- (diff)
- 11:01 AM QtWebKitRelease22 edited by
- (diff)
- 11:01 AM Changeset in webkit [95738] by
-
- 3 edits in trunk/Source/WebCore
FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=68639
Reviewed by David Hyatt.
FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).
- page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
- page/FrameView.h:
- 10:56 AM QtWebKitPackaging edited by
- (diff)
- 10:54 AM QtWebKitReleases edited by
- (diff)
- 10:54 AM QtWebKitRelease21 edited by
- (diff)
- 10:53 AM QtWebKitRelease21 edited by
- (diff)
- 10:52 AM Changeset in webkit [95737] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix (fixes warning about too many parens).
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
- 10:51 AM Changeset in webkit [95736] by
-
- 2 edits in trunk/Source/WebCore
Widget::frameRect shouldn't be virtual
https://bugs.webkit.org/show_bug.cgi?id=68637
Reviewed by Sam Weinig.
Nobody overrides Widget::frameRect and nobody should.
- platform/Widget.h:
- 10:48 AM Changeset in webkit [95735] by
-
- 1 edit1 delete in trunk/Tools
Remove FindSafari
It isn't used or built anymore.
Fixes <http://webkit.org/b/68628>
Reviewed by Darin Adler.
- FindSafari: Removed this directory and its contents.
- 10:48 AM Changeset in webkit [95734] by
-
- 7 edits in trunk
Remove FindSafari from all our .sln files
It isn't used anymore, so there's no point in building it.
Part of <http://webkit.org/b/68628> Remove FindSafari
Reviewed by Steve Falkenburg.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore.sln:
Source/WebKit/win:
- WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
Tools:
- DumpRenderTree/DumpRenderTree.sln:
- WebKitTestRunner/WebKitTestRunner.sln:
- 10:47 AM Changeset in webkit [95733] by
-
- 3 edits1 delete in trunk/Tools
Remove all uses of FindSafari
It isn't really needed anymore.
Fixes <http://webkit.org/b/68626>.
Reviewed by Darin Adler.
- Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
- Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
WebKit, but now we use WebKit.exe for that.
- Scripts/webkitdirs.pm:
(installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
do the same thing.
(readRegistryString):
(writeRegistryString):
Moved here from old-run-webkit-tests.
- 10:47 AM Changeset in webkit [95732] by
-
- 2 edits in trunk/Tools
Use the "direct object" form of system() to run WebKit.exe
This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.
Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%
Reviewed by Steve Falkenburg.
- Scripts/webkitdirs.pm:
(runSafari):
- 10:46 AM Changeset in webkit [95731] by
-
- 2 edits in trunk/Tools
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
spaces in the path to the WebKit source tree
Reviewed by John Sullivan.
- Scripts/webkitdirs.pm:
(setupCygwinEnv):
- 10:46 AM Changeset in webkit [95730] by
-
- 2 edits in trunk/Source/WebKit/win
Add testRegExp.vcproj to WebKit.sln
Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
Reviewed by Brian Weinstein.
- WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
does when built as part of JavaScriptCore.sln.
- 10:40 AM Changeset in webkit [95729] by
-
- 23 edits in trunk
[Qt] Use same DPI for application font as rest of app in DRT and WTR
QApplication will initialize the default application font based
on the application DPI at construction time, but we then override
the application DPI using QX11Info (hard-coding it to 96 for
consistency). This hard-coding is not reflected in the application
font, so we explicitly have update the font ourselves.
The 6 test results that are updated were originally produced with
a DPI of 75, as this is the default fallback DPI when a QFont is
constructed before QApplication. This was wrong, and the results
are updated to match a DPI of 96.
Reviewed by Csaba Osztrogonác.
- 10:36 AM Changeset in webkit [95728] by
-
- 6 edits2 adds in trunk
Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
https://bugs.webkit.org/show_bug.cgi?id=68630
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-22
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/canvas/webgl/shader-deleted-by-accessor.html
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getAttachedShaders):
- html/canvas/WebGLRenderingContext.h:
LayoutTests:
- fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
- fast/canvas/webgl/shader-deleted-by-accessor.html: Added.
- 10:30 AM Changeset in webkit [95727] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, platform-specific results for r95721.
- platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
- platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.
- 10:16 AM Changeset in webkit [95726] by
-
- 9 edits11 moves3 adds11 deletes in trunk
CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
https://bugs.webkit.org/show_bug.cgi?id=47148
Reviewed by David Hyatt.
Source/WebCore:
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::startAlignedOffsetForLine):
Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
- rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
- The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the containing block's direction) when computing static distance. The container block's direction is still used in the other width and offset related calculations.
- In the context of this function, the logicalRight value is just an element that will be used later to calculate the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft() in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get logicalLeft in computePositionedLogicalWidthUsing().
(WebCore::RenderBox::computePositionedLogicalWidth):
- Update comments and use the container block's direction except when calculating the static distance.
- Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
- Update comments and use the container block's direction except when calculating the static distance.
(WebCore::RenderBox::computePositionedLogicalHeight):
- Update comments.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
- Update comments and use the container block's direction except when calculating the static distance.
- If the containing block is RTL, always assume that values are over-constrained.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- Update comments.
LayoutTests:
- platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
- platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: New results for CSS 2.1 reference tests. These match exactly the reference test results.
- fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
- platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
- platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added. New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.
- fast/block/positioning/absolute-position-direction-strict.html: Removed.
- fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
- platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
- platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
- platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
- platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
- platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
- platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
- platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
- platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
- platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
- platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
- platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed. These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.
- 10:09 AM Changeset in webkit [95725] by
-
- 16 edits in trunk/Source
Get rid of Widget::setBoundsSize
https://bugs.webkit.org/show_bug.cgi?id=68491
Reviewed by Sam Weinig.
This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
Source/WebCore:
- WebCore.exp.in:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
- page/FrameView.cpp:
(WebCore::FrameView::create):
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/Widget.cpp:
- platform/Widget.h:
(WebCore::Widget::resize):
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::refresh):
- platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::visibleContentRect):
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
- rendering/RenderWidget.h:
Source/WebKit/mac:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
- WebView/WebFrameView.mm:
- 9:33 AM Changeset in webkit [95724] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=68590
Floats pushed to next page, column or region don't reposition properly if the amount of
available logical width at the new position changes. Refactor the code so that we can
run the float placement algorithm again when this happens.
Source/WebCore:
Covered by an existing regions test that exposes the issue.
Reviewed by Adam Roben.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):
- rendering/RenderBlock.h:
LayoutTests:
Reviewed by Adam Roben.
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
- 9:31 AM Changeset in webkit [95723] by
-
- 2 edits1532 adds in trunk/LayoutTests
[Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests.
All of them pass, they are compared to mac png results manually.
- platform/qt/Skipped:
- platform/qt/css3/selectors3/ [...]: Added.
- 9:18 AM Changeset in webkit [95722] by
-
- 5 edits2 adds in trunk
Source/WebCore: Fire TextInput events on speech input, but not set/add any inputMethod attribute.
https://bugs.webkit.org/show_bug.cgi?id=60451
Reviewed by Ryosuke Niwa.
Introduce code to dispatch TextInput events when text is introduced via
the speech input feature. Handle also the cases where speech input is
started programmatically from the LayoutTestController.
Test: fast/speech/input-ontextinput-event.html
- dom/TextEventInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
LayoutTests: Testing text events triggered by speech input.
https://bugs.webkit.org/show_bug.cgi?id=60451
Reviewed by Ryosuke Niwa.
- fast/speech/input-ontextinput-event-expected.txt: Added.
- fast/speech/input-ontextinput-event.html: Added.
- fast/speech/input-text-speechstart.html:
- 9:14 AM Changeset in webkit [95721] by
-
- 3 edits5 adds in trunk
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.
CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793
Patch by Jason Liu <jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <robert@webkit.org>
Source/WebCore:
Test: fast/css/outline-narrowLine.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
LayoutTests:
- fast/css/outline-narrowLine.html: Added.
- platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
- platform/qt/fast/css/outline-narrowLine-expected.png: Added.
- platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
- platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
- 9:08 AM Changeset in webkit [95720] by
-
- 2 edits in trunk/Source/WebCore
[GTK]Popup drop-down menu contains extra empty spaces at beginning and
occupies whole screen when items in popup reaches the height of display device.
https://bugs.webkit.org/show_bug.cgi?id=68533
When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.
Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.
- platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.
- 8:42 AM Changeset in webkit [95719] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
- DEPS:
- 7:48 AM Changeset in webkit [95718] by
-
- 1 edit4 adds in trunk/LayoutTests
[chromium] Rebaseline following r95715
https://bugs.webkit.org/show_bug.cgi?id=68619
Unreviewed, rebaseline.
- platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
- platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
- platform/chromium-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
- platform/chromium-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
- 6:54 AM Changeset in webkit [95717] by
-
- 2 edits in trunk/Source/WebCore
Define export symbol correctly due to rename of pageScaleFactor to
frameScaleFactor.
Not reviewed. Build fix.
- WebCore.exp.in:
- 6:43 AM Changeset in webkit [95716] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.wasShown):
(WebInspector.ConsoleView.prototype.storeScrollPositions):
(WebInspector.ConsoleView.prototype.restoreScrollPositions):
(WebInspector.ConsoleView.prototype.onResize):
(WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
(WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleCleared):
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/inspector.js:
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
- 6:30 AM Changeset in webkit [95715] by
-
- 11 edits12 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.
Reviewed by Simon Fraser.
The following things are done in this patch:
- Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
- Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
- scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.
Tests: fast/events/scale-and-scroll-body.html
fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html
- html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
- page/Frame.cpp:
(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
main frame, otherwise 1.0
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.
Reviewed by Simon Fraser.
- WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.
(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.
Reviewed by Simon Fraser.
Add tests to cover the following cases:
- Scale and scroll window
- Scale and scroll document.body
- Scale and scroll iframe's contentWindow
- Scale and scroll iframe's contentDocument.body
- fast/events/scale-and-scroll-body-expected.png: Added.
- fast/events/scale-and-scroll-body-expected.txt: Added.
- fast/events/scale-and-scroll-body.html: Added.
- fast/events/scale-and-scroll-iframe-body-expected.png: Added.
- fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
- fast/events/scale-and-scroll-iframe-body.html: Added.
- fast/events/scale-and-scroll-iframe-window-expected.png: Added.
- fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
- fast/events/scale-and-scroll-iframe-window.html: Added.
- fast/events/scale-and-scroll-window-expected.png: Added.
- fast/events/scale-and-scroll-window-expected.txt: Added.
- fast/events/scale-and-scroll-window.html: Added.
- 6:25 AM Changeset in webkit [95714] by
-
- 3 edits3 adds in trunk
CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666
Patch by Andreas Kling <kling@webkit.org> on 2011-09-22
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/getComputedStyle/computed-style-font.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
This function will always return a CSSValueList, as opposed to the previous
implementation which would return a CSSPrimitiveValue if there was only one family.
getCSSPropertyValue() will return the first element of the list for 1-element lists
to preserve the current behavior of getPropertyCSSValue('font-family').
(WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
(WebCore::fontSizeFromStyle): Ditto.
(WebCore::fontStyleFromStyle): Ditto.
(WebCore::fontVariantFromStyle): Ditto.
(WebCore::fontWeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
implementation of the computed 'font' property (CSSPropertyFont.)
LayoutTests:
- fast/css/getComputedStyle/computed-style-font-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-font.html: Added.
- fast/css/getComputedStyle/script-tests/computed-style-font.js: Added.
(computedFont):
(computedFontCSSValue):
- 6:05 AM Changeset in webkit [95713] by
-
- 2 edits in trunk/Source/WebKit/gtk
Remove useless empty WebKit namespace.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-22
Reviewed by Xan Lopez.
- webkit/webkitglobals.cpp:
(webkitInit):
- 6:01 AM Changeset in webkit [95712] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreivewed gardening.
- platform/qt-wk2/Skipped: Skip new failing test introduced in r95645.
- 5:50 AM Changeset in webkit [95711] by
-
- 64 edits in trunk/LayoutTests
[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721
Unreviewed gardening. Update Qt 4.8 specific expected files after r95706.
- platform/qt-4.8/ [...]: Updated.
- 5:43 AM Changeset in webkit [95710] by
-
- 4 edits in trunk/Source
[Qt] Redirection overflow errors have wrong error domain
https://bugs.webkit.org/show_bug.cgi?id=68612
Reviewed by Andreas Kling.
Source/WebCore:
Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::redirect):
Source/WebKit2:
Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().
- UIProcess/API/qt/qweberror.cpp:
(QWebError::type):
- 5:23 AM Changeset in webkit [95709] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add Qt specific expected files for new test introduced in r95671.
- platform/qt/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/qt/fast/table/quote-text-around-iframe-expected.txt: Added.
- 4:50 AM Changeset in webkit [95708] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION(r95679): It broke everything.
https://bugs.webkit.org/show_bug.cgi?id=68611
Unreviewed rolling out r95679 and r95690, because it broke everything.
- UIProcess/API/mac/WKView.mm:
(maybeCreateSandboxExtensionFromPasteboard):
(-[WKView performDragOperation:]):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::getPluginPath):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::initializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::missingPluginButtonClicked):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):
- 4:05 AM Changeset in webkit [95707] by
-
- 2 edits in trunk/Source/JavaScriptCore
32-bit call code clobbers the function cell tag
https://bugs.webkit.org/show_bug.cgi?id=68606
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Csaba Osztrogonác.
This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- 3:23 AM Changeset in webkit [95706] by
-
- 134 edits2 adds in trunk/LayoutTests
[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721
Unreviewed gardening. Update Qt specific expected files.
- 3:17 AM Changeset in webkit [95705] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test expectation following r95685
https://bugs.webkit.org/show_bug.cgi?id=68604
Unreviewed, update test expectation.
- platform/chromium/test_expectations.txt:
- 3:05 AM Changeset in webkit [95704] by
-
- 13 edits1 add in trunk/LayoutTests
[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596
Update Qt specific expected files.
- platform/qt/fast/css-generated-content/table-cell-before-content-expected.png:
- platform/qt/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
- platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
- platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
- platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- 2:29 AM Changeset in webkit [95703] by
-
- 2 edits in trunk/LayoutTests
[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596
Unreviewed gardening. Typo fixes.
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22
- platform/qt/Skipped:
- 12:53 AM Changeset in webkit [95702] by
-
- 15 edits in trunk/Source
Unreviewed, rolling out r95699.
http://trac.webkit.org/changeset/95699
https://bugs.webkit.org/show_bug.cgi?id=67417
Makes many chromium compositor tests crash
Source/WebCore:
- platform/CrossThreadCopier.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::TEST_F):
- tests/TreeSynchronizerTest.cpp:
(WebCore::TEST):
- 12:40 AM Changeset in webkit [95701] by
-
- 11 edits2 adds in trunk/LayoutTests
Unreviewed, GTK rebaseline after r95671.
- platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/gtk/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/gtk/fast/table/quote-text-around-iframe-expected.txt: Added.
- platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- 12:35 AM Changeset in webkit [95700] by
-
- 2 edits in trunk/LayoutTests
[Qt] 11 tests failed after r95671.
https://bugs.webkit.org/show_bug.cgi?id=68596
Unreviewed gardening.
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22
- platform/qt/Skipped:
- 12:22 AM Changeset in webkit [95699] by
-
- 15 edits in trunk/Source
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417
Source/WebCore:
Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.
Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.
- platform/graphics/IntRect.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418
Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
Sep 21, 2011:
- 9:06 PM Changeset in webkit [95698] by
-
- 3 edits in trunk/Source/WebKit/chromium
Implement WebKit side of IDBFactory::getDatabaseNames
https://bugs.webkit.org/show_bug.cgi?id=68037
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.
Interface changes and stub implementations for
new IndexedDB IDBFactory.getDatabaseNames. This is
part one of a two-sided patch.
- public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
- public/WebIDBFactory.h:
(WebKit::WebIDBFactory::getDatabaseNames):
- 8:29 PM Changeset in webkit [95697] by
-
- 7 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=67415
Text drawn via -webkit-background-clip:text is blurry at device scale factors >1.0
-and corresponding-
<rdar://problem/10060379>
Reviewed by Darin Adler.
New helper function RenderBoxModelObject scales the mask image by the
deviceScaleFactor to get an image of the appropriate resolution. It also scales
the image's GraphicsContext so that the clip is set up on the same scale. Back in
paintFillLayerExtended() we still clip the image to the original maskRect to get
everything scaled back to the appropriate size.
- rendering/RenderBoxModelObject.cpp:
(WebCore::createDeviceScaledImageBuffer):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Make the deviceScaleFactor convenience function just a namespace-level function in
Page rather than a static member or Page.
- page/Page.cpp:
(WebCore::deviceScaleFactor):
- page/Page.h:
Pre-existing callers of Page::deviceScaleFactor(Frame*) must now use
WebCore::deviceScaleFactor(Frame*)
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
- 7:14 PM Changeset in webkit [95696] by
-
- 6 edits4 adds in trunk/LayoutTests
Unreviewed. Chromium rebaselines for r95671.
- platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt: Added.
- platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
- platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
- 7:04 PM Changeset in webkit [95695] by
-
- 2 edits in trunk/Source/WebCore
[CG] ImageBufferData::getData has an invariant comparison in the inner part of a loop which doesn't get optimized out
https://bugs.webkit.org/show_bug.cgi?id=68588
<rdar://problem/10164955>
Reviewed by Simon Fraser.
Factor the unmultiplied check out of the inner loop, resulting in a
speed bump in ImageBufferData::getData.
No new tests, performance improvement.
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
- 6:52 PM Changeset in webkit [95694] by
-
- 3 edits2 adds in trunk
:hover selector fails when hovering over a child select element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=67594
Patch by Sameer Patil <mkrp87@motorola.com> on 2011-09-21
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/hover-affects-ancestor.html
This patch addresses the problem of deactivation of the ancestor element :hover rules
when hovered its contained elements.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):
LayoutTests:
- fast/css/hover-affects-ancestor-expected.txt: Added.
- fast/css/hover-affects-ancestor.html: Added.
- 6:46 PM Changeset in webkit [95693] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing addPtr->add32 mapping for X86.
Rubber stamped by Sam Weinig.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::addPtr):
- 6:10 PM Changeset in webkit [95692] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add missing addDouble for AbsoluteAddress to X86
Rubber stamped by Geoff Garen.
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::addDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::addsd_mr):
(JSC::X86Assembler::cvtsi2sd_rr):
(JSC::X86Assembler::cvtsi2sd_mr):
- 6:06 PM Changeset in webkit [95691] by
-
- 34 edits12 adds in trunk/LayoutTests
Rebaseline for bug 65583 (path based border radius drawing on skia) part 4
https://bugs.webkit.org/show_bug.cgi?id=68339
Patch by Ben Wells <benwells@chromium.org> on 2011-09-21
Reviewed by James Robinson.
- platform/chromium-linux/css1/box_properties/border_style-expected.png:
- platform/chromium-linux/css1/box_properties/border_style_inline-expected.png:
- platform/chromium-linux/css2.1/: 14 changes
- platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png: Added.
- platform/chromium-linux/fast/borders/border-styles-split-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
- platform/chromium-win/css1/box_properties/border_style-expected.png:
- platform/chromium-win/css1/box_properties/border_style_inline-expected.png:
- platform/chromium-win/css2.1/: 14 changes
- platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png: Added.
- platform/chromium-win/fast/borders/border-radius-inset-outset-expected.txt: Added.
- platform/chromium-win/fast/borders/border-styles-split-expected.png: Added.
- platform/chromium-win/fast/borders/border-styles-split-expected.txt: Added.
- platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:01 PM Changeset in webkit [95690] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Unreviewed follow-up fix.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Just like we allow null URLs, also allow empty strings.
- 5:17 PM Changeset in webkit [95689] by
-
- 3 edits2 adds in trunk
[Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
https://bugs.webkit.org/show_bug.cgi?id=68584
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/message-port-deleted-by-accessor.html
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::portsAccessorGetter):
LayoutTests:
- fast/dom/message-port-deleted-by-accessor-expected.txt: Added.
- fast/dom/message-port-deleted-by-accessor.html: Added.
- 5:05 PM Changeset in webkit [95688] by
-
- 3 edits6 adds1 delete in trunk/LayoutTests
[chromium] Rebaselines for passing tests and expectation updates/narrowing.
- platform/chromium-cg-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/t090204-display-change-01-b-ao-expected.png: Added.
- platform/chromium-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
- platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.png:
- platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 5:04 PM Changeset in webkit [95687] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix following fix for bug #68586.
- jit/JIT.cpp:
- jit/JITInlineMethods.h:
- 4:58 PM Changeset in webkit [95686] by
-
- 2 edits in trunk/Source/WebCore
Add back protection against the NSView going away while handling mouseDown
https://bugs.webkit.org/show_bug.cgi?id=68585
Reviewed by Darin Adler.
Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
as a followup fix to https://bugs.webkit.org/show_bug.cgi?id=68570.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
- 4:50 PM Changeset in webkit [95685] by
-
- 21 edits10 adds in trunk
Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled
https://bugs.webkit.org/show_bug.cgi?id=68133
Reviewed by Darin Adler.
.:
- Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals
Source/WebCore:
Tests: fast/css/webkit-mask-crash-fieldset-legend.html
fast/css/webkit-mask-crash-figure.html
fast/css/webkit-mask-crash-table.html
fast/css/webkit-mask-crash-td-2.html
fast/css/webkit-mask-crash-td.html
GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
disabled. RenderBox::paintMaskImages would thus crash if called in this condition.
This change just modifies the different GraphicsContext::getCTM method to bail early
if painting is disabled on the GraphicsContext. The rest of the change is exposing
paintControlTints that exposes this.
- WebCore.exp.in: Added symbols of the newly export window.internals function.
- page/FrameView.cpp:
(WebCore::FrameView::updateControlTints): Split this function in 2 so that
I can expose the internal paintControlTints.
(WebCore::FrameView::paintControlTints):
This is the one exposed to Internals as we want to be testable regardless of
whether the platform supports control tints.
- page/FrameView.h: Added paintControlTints.
- testing/Internals.cpp:
(WebCore::Internals::paintControlTints):
- testing/Internals.h:
- testing/Internals.idl:
Added a way to force a fake painting so that we can easily reproduce the bugs.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getCTM):
Fixed all our back-end to exit early if painting is disabled.
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Exported the new FrameView::paintControlTints function.
LayoutTests:
Those tests checks that we do not crash when calling internals.paintControlTints.
- platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to
this change on Mac.
- fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
- fast/css/webkit-mask-crash-fieldset-legend.html: Added.
- fast/css/webkit-mask-crash-figure-expected.txt: Added.
- fast/css/webkit-mask-crash-figure.html: Added.
- fast/css/webkit-mask-crash-table-expected.txt: Added.
- fast/css/webkit-mask-crash-table.html: Added.
- fast/css/webkit-mask-crash-td-2-expected.txt: Added.
- fast/css/webkit-mask-crash-td-2.html: Added.
- fast/css/webkit-mask-crash-td-expected.txt: Added.
- fast/css/webkit-mask-crash-td.html: Added.
- 4:49 PM Changeset in webkit [95684] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG JIT should be able to compile op_throw
https://bugs.webkit.org/show_bug.cgi?id=68571
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-21
Reviewed by Geoffrey Garen.
This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:46 PM Changeset in webkit [95683] by
-
- 6 edits in trunk/Source/JavaScriptCore
DFG JIT should be able to compile op_throw
https://bugs.webkit.org/show_bug.cgi?id=68571
Reviewed by Geoffrey Garen.
This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:44 PM Changeset in webkit [95682] by
-
- 4 edits in trunk
IndexedDB: compare strings without decoding
https://bugs.webkit.org/show_bug.cgi?id=68554
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.
Resolves a FIXME in IndexedDB that was also identified as a hotspot
during profiling. Yields a small performance improvement.
- Source/WebCore/storage/IDBLevelDBCoding.cpp:
- Source/WebCore/storage/IDBLevelDBCoding.h:
- Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:
- 4:36 PM Changeset in webkit [95681] by
-
- 24 edits3 adds in trunk/Source/JavaScriptCore
DFG should support continuous optimization
https://bugs.webkit.org/show_bug.cgi?id=68329
Reviewed by Geoffrey Garen.
This adds the ability to reoptimize a code block if speculation
failures happen frequently. 6% speed-up on Kraken, 1% slow-down
on V8, neutral on SunSpider.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getStrongPrediction):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
(JSC::DFG::getOSREntryDataBytecodeIndex):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
(JSC::ConservativeRoots::add):
- heap/ConservativeRoots.h:
- heap/Heap.cpp:
(JSC::Heap::addJettisonCodeBlock):
(JSC::Heap::markRoots):
- heap/Heap.h:
- heap/JettisonedCodeBlocks.cpp: Added.
(JSC::JettisonedCodeBlocks::JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::~JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::addCodeBlock):
(JSC::JettisonedCodeBlocks::clearMarks):
(JSC::JettisonedCodeBlocks::deleteUnmarkedCodeBlocks):
(JSC::JettisonedCodeBlocks::traceCodeBlocks):
- heap/JettisonedCodeBlocks.h: Added.
(JSC::JettisonedCodeBlocks::mark):
- interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
- interpreter/RegisterFile.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
- runtime/Executable.h:
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
- wtf/BitVector.h: Added.
(WTF::BitVector::BitVector):
(WTF::BitVector::~BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::size):
(WTF::BitVector::ensureSize):
(WTF::BitVector::resize):
(WTF::BitVector::clearAll):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::bitsInPointer):
(WTF::BitVector::maxInlineBits):
(WTF::BitVector::byteCount):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::OutOfLineBits::numBits):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::OutOfLineBits::create):
(WTF::BitVector::OutOfLineBits::destroy):
(WTF::BitVector::OutOfLineBits::OutOfLineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::bits):
- 4:32 PM Changeset in webkit [95680] by
-
- 2 edits in trunk/Tools
Update committers.py with a new contributor contact
https://bugs.webkit.org/show_bug.cgi?id=68565
Reviewed by Eric Carlson.
- Scripts/webkitpy/common/config/committers.py:
- 4:25 PM Changeset in webkit [95679] by
-
- 8 edits in trunk/Source/WebKit2
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm: (maybeCreateSandboxExtensionFromPasteboard): Return a boolean, telling the caller whether an extension actually needed to be created (-[WKView performDragOperation:]): Tell process proxy when the process is going to get universal file read sandbox extension.
- UIProcess/WebContext.cpp: (WebKit::WebContext::didPerformClientRedirect): Check the URLs. (WebKit::WebContext::didPerformServerRedirect): Ditto. (WebKit::WebContext::didUpdateHistoryTitle): Ditto. (WebKit::WebContext::getPluginPath): Ditto. Also, properly parse the URL - we can never assume that a string coming from WebProcess is a ParsedURLString.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcessWithItem): Tell process proxy when the process is going to get universal file read sandbox extension. (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): Changed to return a boolean, telling the caller whether an extension actually needed to be created. (WebKit::WebPageProxy::loadURL): Tell process proxy about extension. (WebKit::WebPageProxy::loadURLRequest): Ditto. (WebKit::WebPageProxy::loadHTMLString): Tell process proxy if a file URL was used as a base one for a string. In this case, WebKit2 assumes that WebProcess has access to a subdirectory, (typically, one where error page resources live), and can load from it. (WebKit::WebPageProxy::loadAlternateHTMLString): Ditto. (WebKit::WebPageProxy::goForward): Tell process proxy about extension. (WebKit::WebPageProxy::goBack): Tell process proxy about extension. (WebKit::WebPageProxy::goToBackForwardItem): Tell process proxy about extension. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Check the URL. (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto. (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Ditto. (WebKit::WebPageProxy::decidePolicyForNewWindowAction): Ditto. (WebKit::WebPageProxy::decidePolicyForResponse): Ditto. (WebKit::WebPageProxy::didInitiateLoadForResource): Ditto. (WebKit::WebPageProxy::didSendRequestForResource): Ditto. (WebKit::WebPageProxy::didReceiveResponseForResource): Ditto. (WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
- UIProcess/WebPageProxy.h: Changed initializeSandboxExtensionHandle() to return a bool, and renamed to maybeInitializeSandboxExtensionHandle (matching WKView counterpart).
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): Initialize m_mayHaveUniversalFileReadSandboxExtension. It's going to be true if we ever granted an extension for "/". (WebKit::WebProcessProxy::willLoadHTMLStringWithBaseURL): Remember the path, we should expect that WebProcess will load subresources from it. (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Check that it's reasonable to expect WebProcess send us a URL like this. (WebKit::WebProcessProxy::addBackForwardItem): Check the URLs.
- UIProcess/WebProcessProxy.h: Added data members remembering what to expect from this process.
- UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Tell process proxy when the process is going to get universal file read sandbox extension.
- 4:06 PM Changeset in webkit [95678] by
-
- 9 edits in trunk/Source
Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=68382
Source/WebCore:
Reviewed by Darin Adler.
Only create a AudioContext object if the Web Audio feature is runtime-enabled in Settings.
No new tests, as this feature is not yet enabled by default.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitAudioContext):
Source/WebKit/mac:
Reviewed by Darin Adler.
Initialize the webAudioEnabled preference to NO by default.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
Add support for the webAudioEnabled preference in WebKit2.
Reviewed by Darin Adler.
- Shared/WebPreferencesStore.h: Add WebAudioEnabled getter and setter macro.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebAudioEnabled): Added.
(WKPreferencesGetWebAudioEnabled): Added.
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update the webAudioEnabled preference.
- 3:54 PM Changeset in webkit [95677] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Code cleanup in gesture recognizer unit tests
https://bugs.webkit.org/show_bug.cgi?id=68561
Fix some style nits in the gesture recognizer unit tests.
Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-21
Reviewed by David Levin.
- tests/InnerGestureRecognizerTest.cpp:
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(TEST_F):
- 3:43 PM Changeset in webkit [95676] by
-
- 7 edits in trunk/Source/JavaScriptCore
Should support value profiling on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=68575
Reviewed by Sam Weinig.
Fix verbose profiling in ToT (SlowCaseProfile had been
partially renamed to RareCaseProfile), add in-memory
bucket counter for CPU(X86), move JIT::m_canBeOptimized
out of the DFG_JIT ifdef.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- 3:41 PM Changeset in webkit [95675] by
-
- 7 edits in trunk/Source
Remove checks for Leopard-only Objective-C APIs
https://bugs.webkit.org/show_bug.cgi?id=68579
Reviewed by Sam Weinig.
We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
../WebCore:
- bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
- bridge/objc/objc_instance.mm:
(allocateAutoReleasePool):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcField::ObjcField):
- page/mac/EventHandlerMac.mm:
../WebKit/mac:
- Misc/WebNSObjectExtras.h:
- 3:33 PM Changeset in webkit [95674] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix resolve-Changelog's strange butchery of the LayoutTests/Changelog.
- 3:20 PM Changeset in webkit [95673] by
-
- 5 edits in trunk/Source/WebCore
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570
Reviewed by Sam Weinig.
These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
- rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
- 3:17 PM Changeset in webkit [95672] by
-
- 10 edits in trunk/Source/JavaScriptCore
DFG does not support compiling functions as constructors
https://bugs.webkit.org/show_bug.cgi?id=68500
Reviewed by Oliver Hunt.
This adds support for compiling constructors to the DFG. It's a
1% speed-up on V8, mostly due to a 6% speed-up on early-boyer.
It's also a 13% win on access-binary-trees, but it's neutral in
the SunSpider and Kraken averages.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):
- 3:05 PM Changeset in webkit [95671] by
-
- 16 edits3 adds in trunk
Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
https://bugs.webkit.org/show_bug.cgi?id=67656
Reviewed by David Hyatt.
Test: fast/table/quote-text-around-iframe.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
LayoutTests: Not use anonymousContainer on beforeChild calculation
and let later code handle it.
https://bugs.webkit.org/show_bug.cgi?id=67656
Reviewed by David Hyatt.
- fast/table/quote-text-around-iframe.html: Added.
- fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/mac/fast/table/quote-text-around-iframe-expected.png: Added.
- platform/mac/fast/table/quote-text-around-iframe-expected.txt: Added.
and lot of style propagation rebaselines.
- 2:56 PM Changeset in webkit [95670] by
-
- 4 edits3 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68562
Pagination struts don't update properly when collapsing margin estimates are wrong.
Refactor the pagination adjustments that happen during block layout to allow for
a 3-pass layout system instead of just a 2-pass layout system. The basic idea is
to come up with an estimate that includes collapsing, clearance and pagination.
If the estimate only with collapsing and clearance was wrong, then we lay out again
using the correct collapsing margin values and clearance before applying pagination breaks.
After this second layout, the normal code that runs when unpaginated compares estimates
and lays out a third time to account for adjustments as a result of pagination movement.
Reviewed by Sam Weinig.
Added fast/regions/text-regions-split-small-pagination.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::adjustBlockChildForPagination):
- rendering/RenderBlock.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68562
Pagination struts don't update properly when collapsing margin estimates are wrong.
Add a new regions result to test the bug fix.
Reviewed by Sam Weinig.
- fast/regions/text-region-split-small-pagination.html: Added.
- platform/mac/fast/regions/text-region-split-small-pagination-expected.png: Added.
- platform/mac/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- 2:21 PM Changeset in webkit [95669] by
-
- 3 edits in trunk/Source/WebKit/chromium
Remove old and busted context notification APIs
https://bugs.webkit.org/show_bug.cgi?id=68381
Reviewed by David Levin.
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
- 1:39 PM Changeset in webkit [95668] by
-
- 2 edits in trunk/Source/WebCore
[chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558
Reviewed by Stephen White.
The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):
- 1:13 PM Changeset in webkit [95667] by
-
- 3 edits2 adds in trunk
[Chromium] Protect the Frame in V8HTMLDocument::openCallback
https://bugs.webkit.org/show_bug.cgi?id=68555
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/dom/frame-deleted-in-document-open.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
LayoutTests:
- fast/dom/frame-deleted-in-document-open-expected.txt: Added.
- fast/dom/frame-deleted-in-document-open.html: Added.
- 12:59 PM Changeset in webkit [95666] by
-
- 16 edits in trunk/Source/JavaScriptCore
Replace jsFunctionVPtr compares with a type check on the Structure.
https://bugs.webkit.org/show_bug.cgi?id=68557
Reviewed by Oliver Hunt.
This will permit calls to still optimize to subclasses of JSFunction
that have the correct type (but a different C++ vptr).
This patch stops passing the globalData into numerous functions.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotType):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.h:
(JSC::isHostFunction):
- runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
- runtime/JSObject.h:
(JSC::getJSFunction):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/JSType.h:
- 12:49 PM Changeset in webkit [95665] by
-
- 3 edits in trunk
Unreviewed. Remove unused ENABLE_AS_IMAGE flag after r95234 from
Options{Efl,WinCE}.cmake.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- 12:47 PM Changeset in webkit [95664] by
-
- 8 edits2 adds in trunk
Clean up CSS Counter code
https://bugs.webkit.org/show_bug.cgi?id=68492
Reviewed by Tony Chang.
Source/WebCore:
Several cleanups/fixes:
- Make Counter::listStyle() return the actual list style string, rather than empty string.
- Handle a specified list style of "none" correctly when generating cssText and in Counter::listStyle().
- Use StringBuilder when generating cssText.
Test: fast/css/counters/getCounterValue.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCounterContent):
Simplify processing (moving conversion to CSSStyleSelector),
pass a CSS_IDENT as the listStyle to Counter::create.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
Use StringBuilder.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Convert from a CSS_IDENT to an EListStyleType.
- css/Counter.h:
(WebCore::Counter::listStyleIdent):
Renamed from listStyleNumber to match its new functionality.
LayoutTests:
Added tests for setting the list style to "none"
as well as tests for getCounterValue.
- fast/css/counters/counter-cssText-expected.txt:
- fast/css/counters/counter-cssText.html:
- fast/css/counters/getCounterValue-expected.txt: Added.
- fast/css/counters/getCounterValue.html: Added.
- 12:34 PM Changeset in webkit [95663] by
-
- 3 edits in trunk/Source/JavaScriptCore
Removed WTFTHREADDATA_MULTITHREADED, making it always true
https://bugs.webkit.org/show_bug.cgi?id=68549
Reviewed by Darin Adler.
Another part of making threads exist in WebKit.
- wtf/WTFThreadData.cpp:
- wtf/WTFThreadData.h:
(WTF::wtfThreadData):
- 12:33 PM Changeset in webkit [95662] by
-
- 2 edits in trunk/Source/WebCore
2011-09-21 Chris Marrin <cmarrin@apple.com>
Check in WebCore.vcproj file unchanged but written like MSDev likes it
Unreviewed.
- WebCode.vcproj/WebCore.vcproj:
- 12:30 PM Changeset in webkit [95661] by
-
- 8 edits in trunk/Source/WebKit2
Use the prefix "WK" instead of "Web" for Objective-C classes defined in WebKit2.
Reviewed by Anders Carlsson.
Renamed WebInspectorProxyObjCAdapter to WKWebInspectorProxyObjCAdapter.
Renamed WebInspectorWKView to WKWebInspectorWKView.
Renamed WebFindIndicatorWindowAnimation to WKFindIndicatorWindowAnimation.
Renamed WebFindIndicatorView to WKFindIndicatorView.
Renamed WebUserDataWrapper to WKUserDataWrapper.
Updated the build phase checking for inappropriate Objective-C class names to disallow the prefix
"Web" and only allow "WK".
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
- UIProcess/WebInspectorProxy.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItemVector):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac):
- 12:24 PM Changeset in webkit [95660] by
-
- 18 edits in trunk
[WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68108
This patch implements the event sender mouse events through WebKit2 UIProcess which is
closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
platform as the first step so the existing code is still kept for other platforms.
Source/WebKit2:
Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetShouldSendEventsSynchronously):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setShouldSendEventsSynchronously):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.
- WebKitTestRunner/EventSenderProxy.h:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::currentEventTime):
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::keyDown):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::eventTypeForMouseButtonAndAction):
(WTR::operator==):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
LayoutTests:
Unskip the passed tests.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.
- platform/mac-wk2/Skipped:
- platform/wk2/Skipped:
- 12:17 PM Changeset in webkit [95659] by
-
- 28 edits in trunk/Source/WebKit/efl
[EFL] Revert pointer operator coding style in ewk
https://bugs.webkit.org/show_bug.cgi?id=68231
Reviewed by Antonio Gomes.
The WebKit coding style mandates that "(...) in C++ code - Both pointer
types and reference types should be written with no space between the
type name and the * or &.". Until now EFL port was using the
coding-style of the library for platform code instead of WebKit's.
We are now trying to be more compliant with WebKit coding-style so it's
easier for other reviewers to review EFL code. The first step in this
direction is to move the '*' and '&' of pointers and references to the
right place.
This patch was generated with 'uncrustify' with the configure file
attached to the respective but report. There was one fix that had to be
manually made in order to keep the 'check-webkit-style' happy: a
function definition with a meaningless name. Other functions like this
exist but they will be fixed by a later patch.
Some nice side-effects of using uncrustify:
- Whitespace cleanup on comments
- Function parameters are aligned to the open parenthesis
- Remove tab characters
- 12:11 PM Changeset in webkit [95658] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Optimize ImageBuffer constructor when accelerated
https://bugs.webkit.org/show_bug.cgi?id=68501
If the accelerated rendering mode is passed in to ImageBuffer, instead
of creating a bitmap PlatformCanvas and subsequently replacing its
device with an SkGpuDevice, create an SkCanvas and SkGpuDevice first,
and fall back to raster creation only failure. This saves on system
RAM for the backing store (and possibly GDI resources).
Reviewed by James Robinson.
Covered by existing tests.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
Rename "SharedGraphicsContext3D::create()" to "get()" to more
accurately reflect its function.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
Refactor creation of accelerated ImageBuffer.
(WebCore::ImageBuffer::ImageBuffer):
Attempt creation of accelerated ImageBuffer first, and only fall back
to bitmap-backed canvas creation if it fails.
- 12:06 PM Changeset in webkit [95657] by
-
- 3 edits4 copies in branches/chromium/874
Merge 95471 - [Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/frames/iframe-reparenting-embed-elements.html
- dom/Document.cpp:
(WebCore::Document::adoptNode):
- html/HTMLFrameElementBase.cpp:
(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):
- html/HTMLFrameElementBase.h:
LayoutTests:
- fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
- fast/frames/iframe-reparenting-embed-elements.html: Added.
- fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
- fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/7980042
- 11:59 AM Changeset in webkit [95656] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Don't try to free user-provided list
https://bugs.webkit.org/show_bug.cgi?id=68356
Reviewed by Antonio Gomes.
A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
wrong manner. If we intended to free the data, we should call free()
(or whatever function is required to destroy it). However not only did
it use the wrong EFL api but it also introduced a change in behavior,
freeing user-provided data.
- ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event): do not free user-provided data.
- 11:48 AM Changeset in webkit [95655] by
-
- 9 edits1 copy in trunk
Source/JavaScriptCore: JavaScriptCore Part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
- JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
check-for-inappropriate-objc-class-names, allowing only class names prefixed with "JS".
Source/WebCore: WebCore part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
check-for-inappropriate-objc-class-names, allowing only class names prefixed with "DOM" or "Web".
Source/WebKit: WebKit part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
- WebKit.xcodeproj/project.pbxproj: Added a script build phase that invokes
check-for-inappropriate-objc-class-names, allowing only class names prefixed with "Web" or "_Web".
Source/WebKit2: WebKit2 part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
- WebKit2.xcodeproj/project.pbxproj: Added a script build phase that invokes
check-for-inappropriate-objc-class-names, allowing only class names prefixed with "WK" or "Web".
Tools: Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
- Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
Objective-C classes with names not having one of a list of prefixes
passed on the command line.
- 11:45 AM Changeset in webkit [95654] by
-
- 3 edits2 adds in trunk
<rdar://problem/9768483> REGRESSION: Crash in RenderBlock::removeFloatingObjectsBelow()
https://bugs.webkit.org/show_bug.cgi?id=68550
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObjectsBelow): Break out of the while() loop when the
floating object set is empty, which can happen if there were no floats on previous lines
(in which case, lastFloat is 0).
LayoutTests:
- fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow-expected.txt: Added.
- fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html: Added.
- 11:38 AM Changeset in webkit [95653] by
-
- 2 edits in trunk/LayoutTests
Fixed bug number in test expectations.
- platform/chromium/test_expectations.txt:
- 11:33 AM Changeset in webkit [95652] by
-
- 8 edits in trunk/Source/JavaScriptCore
MacroAssembler fixes.
https://bugs.webkit.org/show_bug.cgi?id=68494
Reviewed by Sam Weinig.
Add X86-64's 3 operand or32 to other MacroAssembler, fix load32's [const] void* mismatch
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::loadPtr):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::or32):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::load32):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::load32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::load32):
- 11:18 AM Changeset in webkit [95651] by
-
- 4 edits in trunk/Source/WebCore
[GTK] Fix build break when enabling webgl on r95593
https://bugs.webkit.org/show_bug.cgi?id=68502
Patch by ChangSeok Oh <ChangSeok Oh> on 2011-09-21
Reviewed by Martin Robinson.
Add PassOwnPtr.h to GC3DPrivate.h and remove useless one from GC3DGtk.cpp & GC3DPrivate.cpp
No tests required.
- platform/graphics/gtk/GraphicsContext3DGtk.cpp:
- platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
- platform/graphics/gtk/GraphicsContext3DPrivate.h:
- 11:14 AM Changeset in webkit [95650] by
-
- 2 edits in trunk/Source/WebKit/win
Branch builds don't launch on Windows when run against trunk WebKit
https://bugs.webkit.org/show_bug.cgi?id=68546
Reviewed by Darin Adler.
- Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily
in IDL for binary compatibility between branch and trunk.
- 11:01 AM Changeset in webkit [95649] by
-
- 3 edits2 adds in trunk
Web Inspector: clear resource agent resource cache upon resource agent's disable.
https://bugs.webkit.org/show_bug.cgi?id=67995
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
LayoutTests:
- http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt: Added.
- http/tests/inspector/network/network-disabling-check-no-memory-leak.html: Added.
- 10:58 AM Changeset in webkit [95648] by
-
- 9 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68543
Make sure that when regions change dimensions we recompute pagination slices.
Reviewed by Simon Fraser.
Source/WebCore:
Added new tests in fast/regions.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
- rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
- rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
LayoutTests:
- fast/regions/text-region-split-after-resize-expected.txt: Added.
- fast/regions/text-region-split-after-resize.html: Added.
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
- 10:37 AM Changeset in webkit [95647] by
-
- 8 edits2 adds in trunk
Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=68206
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-21
Reviewed by Tony Chang.
Source/WebCore:
Added two new wtf headers into ForwardingHeaders/wtf to make
#include <wtf/...h> cross-platform.
No new tests needed.
- ForwardingHeaders/wtf/MetaAllocator.h: Added.
- ForwardingHeaders/wtf/RedBlackTree.h: Added.
Source/WebKit/chromium:
- WebKit.gyp:
Tools:
- Scripts/webkitdirs.pm:
(determineBaseProductDir): add support for chromium-mac
- TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
- 10:10 AM Changeset in webkit [95646] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.
https://bugs.webkit.org/show_bug.cgi?id=67469
Patch by David Delaune <david.delaune@googlemail.com> on 2011-09-21
Reviewed by Brent Fulgham.
No new functionality added in this change.
- loader/icon/IconDatabase.cpp: defining CAN_THEME_URL_ICON for the WIN_CAIRO
- 10:06 AM Changeset in webkit [95645] by
-
- 10 edits2 adds in trunk
Span element gets produced using backspace/delete to merge header with paragraph
https://bugs.webkit.org/show_bug.cgi?id=68413
Reviewed by Darin Adler.
Source/WebCore:
Add p element to the list of elements to retain appearance. Also modified removeStyleFromNode
(and renamed to removeStyleFromRules) not to remove inline style declarations because
inline styles need to stay on copy.
Test: editing/deleting/merge-paragraph-from-p-with-style.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRules): Renamed from removeStyleFromNode.
- editing/EditingStyle.h:
- editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance):
(WebCore::StyledMarkupAccumulator::serializeNodes):
LayoutTests:
Add a test to remove the line break before a p element. WebKit should not preserve
the font color from the style rule but should preserve the font style from inline style declaration.
Also fix merge-paragraph-from-h6* to actually h6 instead of h1.
- editing/deleting/merge-paragraph-from-h6-expected.txt:
- editing/deleting/merge-paragraph-from-h6-with-style-expected.txt:
- editing/deleting/merge-paragraph-from-h6-with-style.html:
- editing/deleting/merge-paragraph-from-h6.html:
- editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-from-p-with-style.html: Added.
- 10:00 AM Changeset in webkit [95644] by
-
- 7 edits in trunk/LayoutTests
[flexbox] rename classnames and methods in the tests to not assume horizontal
https://bugs.webkit.org/show_bug.cgi?id=68498
Reviewed by Tony Chang.
- css3/flexbox/001.html:
- css3/flexbox/002.html:
- css3/flexbox/003.html:
- css3/flexbox/004.html:
- css3/flexbox/resources/flexbox.js:
(checkFlexBoxen):
- css3/flexbox/writing-modes.html:
- platform/mac/Skipped:
- 9:51 AM Changeset in webkit [95643] by
-
- 2 edits in trunk/LayoutTests
need rebaseline for gradient speedup in skia
https://bugs.webkit.org/show_bug.cgi?id=68531
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 9:48 AM Changeset in webkit [95642] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, move today's skipped flaky tests to test_expectations
as suggested by mrobinson.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 9:45 AM Changeset in webkit [95641] by
-
- 5 edits2 adds in trunk
Report AXValueChanged when value changes in element with role=textbox.
https://bugs.webkit.org/show_bug.cgi?id=68201
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-09-21
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/mac/accessibility/textbox-role-reports-notifications.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIATextControl):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
LayoutTests:
- platform/mac/accessibility/textbox-role-reports-notifications-expected.txt: Added.
- platform/mac/accessibility/textbox-role-reports-notifications.html: Added.
- 9:39 AM Changeset in webkit [95640] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
https://bugs.webkit.org/show_bug.cgi?id=68351
Patch by chandra shekar vallala <chandra.vallala@gmail.com> on 2011-09-21
Reviewed by Darin Fisher.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):
- 9:27 AM Changeset in webkit [95639] by
-
- 1 edit6 adds in trunk/LayoutTests
New layout tests for the JS bindings related to <track>:
e.g. TextTrack, TextTrackCue, TextTrackCueList, MutableTextTrack.
https://bugs.webkit.org/show_bug.cgi?id=68194
Reviewed by Eric Carlson.
- media/track/track-mutable-expected.txt: Added.
- media/track/track-mutable.html: Added.
- media/track/track-text-track-cue-list-expected.txt: Added.
- media/track/track-text-track-cue-list.html: Added.
- media/track/track-text-track-expected.txt: Added.
- media/track/track-text-track.html: Added.
- 9:19 AM Changeset in webkit [95638] by
-
- 1 edit in trunk/LayoutTests/platform/qt-wk2/Skipped
Actually skip the test (forgot in the previous commit). Sorry for the noise.
- 9:15 AM Changeset in webkit [95637] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] plugins/mouse-click-iframe-to-plugin.html fails since enabled in r95626
https://bugs.webkit.org/show_bug.cgi?id=68539
Unreviewed gardening.
- platform/qt-wk2/Skipped: skip the test.
- 9:13 AM Changeset in webkit [95636] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: introduce Page.enable and Page.disable
https://bugs.webkit.org/show_bug.cgi?id=68530
Otherwise protocol is violating the contract of not sending
notifications by default.
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- 8:51 AM Changeset in webkit [95635] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.
- LayoutTests/platform/chromium/test_expectations.txt:
- 8:39 AM Changeset in webkit [95634] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add minimal error handling to the DOM breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=68537
Reviewed by Yury Semikhatsky.
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
- 8:36 AM Changeset in webkit [95633] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, GTK baselines for
cross-origin-xsl-redirect-BLOCKED.html which were removed by mistake.
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.
- 8:19 AM Changeset in webkit [95632] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: make WebInspector a bit more timeline friendly.
https://bugs.webkit.org/show_bug.cgi?id=68534
I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.
Reviewed by Yury Semikhatsky.
- inspector/CodeGeneratorInspector.pm:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- 8:10 AM Changeset in webkit [95631] by
-
- 11 edits2 adds in trunk/Source
[Qt][WK2] Implement Download support in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68153
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-09-21
Reviewed by Andreas Kling.
Source/WebCore:
Refactored QNetworkReplyHandler::finish() in order to add
and use the static function QNetworkReplyHandler::errorForReply().
This will be used by our Download implementation in WebKit2 (WebProcess)
when handling ResourceError.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::errorForReply):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceRequest.h:
Source/WebKit2:
We implement the necessary functions of Download.h, and our QtFileDownloader
to handle all network communication and call the necessary functions of Download.
We use the download policy for any MIME type not supported by WebKit. This
behaves like Qt non-WebKit2 except that we don't force download when
we encounter Content-Disposition: attachment. We still use the "filename="
field for file name suggestion though.
Based on original patches by: Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>,
Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Simon Hausmann <simon.hausmann@nokia.com>
and Zalan Bujtas <zalan.bujtas@nokia.com>.
- UIProcess/API/qt/qweberror.cpp: Adding DownloadError
(QWebError::type):
- UIProcess/API/qt/qweberror.h: Adding DownloadError
- WebKit2.pro:
- WebProcess/Downloads/Download.cpp: Adding QtFileDownloader, Qt platform specific
(WebKit::Download::Download):
- WebProcess/Downloads/Download.h: Adding QtFileDownloader, Qt platform specific
- WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
- WebProcess/Downloads/qt/QtFileDownloader.cpp: Added.
(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::~QtFileDownloader):
(WebKit::QtFileDownloader::determineFilename):
(WebKit::QtFileDownloader::decidedDestination):
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::onError):
(WebKit::QtFileDownloader::cancel):
- WebProcess/Downloads/qt/QtFileDownloader.h: Added.
- 7:59 AM Changeset in webkit [95630] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip flaky media test on GTK.
- platform/gtk/Skipped: Skip media/media-blocked-by-beforeload.html
- 7:58 AM Changeset in webkit [95629] by
-
- 2 edits in trunk/Tools
garden-o-matic command should explain that it is starting a local server
https://bugs.webkit.org/show_bug.cgi?id=68486
Reviewed by Dimitri Glazkov.
In the user study, both participants didn't understand why the
garden-o-matic command appeared to hang. This patch adds an
explaination of what's going on. It also adds a confirmation prompt
before launching the browser to give the user a chance to read the
text. If that's too much of a speed bump, we can iterate.
- Scripts/webkitpy/tool/commands/gardenomatic.py:
- 7:48 AM Changeset in webkit [95628] by
-
- 2 edits in trunk/LayoutTests
Syntax error in media/audio-delete-while-step-button-clicked.html
https://bugs.webkit.org/show_bug.cgi?id=68507
Reviewed by Eric Carlson.
- media/audio-delete-while-step-button-clicked.html: Some curly
braces were missing in a try/catch statement.
- 7:28 AM Changeset in webkit [95627] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix alphabetical sorting problem
https://bugs.webkit.org/show_bug.cgi?id=68505
Reviewed by Philippe Normand.
- ewk/ewk_util.cpp: Fix wrong alphabetical sorting problem.
- 7:20 AM Changeset in webkit [95626] by
-
- 7 edits1 add in trunk
[Qt] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=56485
Tools:
Implement the KeyDown function on Qt platform.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
(WTR::getModifiers):
(WTR::EventSenderProxy::keyDown):
(buildModifierFlags):
(EventSenderProxy::keyDown):
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
LayoutTests:
Unskip passed tests.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.
- platform/qt-wk2/Skipped:
- 7:06 AM Changeset in webkit [95625] by
-
- 1 edit1 add in trunk/LayoutTests
Web Inspector: UI performance test for Resource panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68527
Reviewed by Pavel Feldman.
- inspector/performance/resources/first-open-resources.html: Added.
- 7:04 AM Changeset in webkit [95624] by
-
- 2 edits1 add in trunk/LayoutTests
Web Inspector: extend UI perf tests coverage. Elements panel opens first time.
https://bugs.webkit.org/show_bug.cgi?id=68432
Reviewed by Pavel Feldman.
- inspector/performance/resources/first-open-elements.html: Added.
- inspector/performance/resources/performance-test.js:
- 6:53 AM Changeset in webkit [95623] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip some more flaky SVG tests on GTK.
- platform/gtk/Skipped:
- 6:34 AM Changeset in webkit [95622] by
-
- 3 edits4 copies2 moves5 adds1 delete in trunk/LayoutTests
Unreviewed, fix baselines for cross-origin-xsl-redirect-BLOCKED
- http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
- platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/qt-wk2/Skipped:
- platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Removed
- platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
- platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- 6:33 AM Changeset in webkit [95621] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
https://bugs.webkit.org/show_bug.cgi?id=68240
Today we paint backgrounds in Metrics box model on hover only - should be painted at all
times for the reference. Outlining boxes is highlight is wrong since outlines are outside
the corresponding box regions. We've seen few reports on that + Firebug does not do borders
for that reason.
Reviewed by Yury Semikhatsky.
- inspector/DOMNodeHighlighter.cpp:
- inspector/DOMNodeHighlighter.h:
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
- inspector/front-end/Color.js:
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
(WebInspector.MetricsSidebarPane.prototype._updateMetrics):
- inspector/front-end/inspector.css:
(.metrics .label):
- inspector/front-end/inspector.js:
(WebInspector.buildHighlightConfig):
- 6:14 AM Changeset in webkit [95620] by
-
- 1 edit5 adds in trunk/LayoutTests
[chromium] rebaseline caused by r95567
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-mac-leopard: Added.
- platform/chromium-mac-leopard/fast: Added.
- platform/chromium-mac-leopard/fast/clip: Added.
- platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- 6:08 AM Changeset in webkit [95619] by
-
- 3 edits in trunk/Source/WebCore
Protect against misuse of EventListenerIterator.
https://bugs.webkit.org/show_bug.cgi?id=68364
Patch by Andreas Kling <kling@webkit.org> on 2011-09-21
Reviewed by Darin Adler.
In debug mode, keep track of the number of active EventListenerIterators
on an EventListenerMap, and assert that there are no iterators when the
map is being modified.
- dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::~EventListenerIterator):
- dom/EventListenerMap.h:
- 6:05 AM Changeset in webkit [95618] by
-
- 2 edits4 adds2 deletes in trunk/LayoutTests
[chromium] rebaseline caused by r95599
- fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
- platform/chromium-mac-leopard: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
- 5:52 AM Changeset in webkit [95617] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip 2 GTK flaky tests.
- platform/gtk/Skipped: Skip
http/tests/websocket/tests/hixie76/error-detect.html and
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
- 5:13 AM Changeset in webkit [95616] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unskip some cookies related layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68484
Reviewed by Csaba Osztrogonác.
Unskip some cookies related layout tests as they seems to work fine with
--iterations 1000.
- platform/qt-wk2/Skipped:
- 4:57 AM Changeset in webkit [95615] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed gardening after r95601.
- platform/qt-mac/Skipped: Paint the Qt-Mac bot green.
- 4:50 AM Changeset in webkit [95614] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: minor fixes in the DOM domain of the protocol.
https://bugs.webkit.org/show_bug.cgi?id=68517
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):
- 4:45 AM Changeset in webkit [95613] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: limit the use of "Resource" term in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=68250
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
(WebCore::InspectorResourceAgent::getResponseBody):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
- 4:39 AM Changeset in webkit [95612] by
-
- 8 edits12 deletes in trunk
Unreviewed, rolling out r95608.
http://trac.webkit.org/changeset/95608
https://bugs.webkit.org/show_bug.cgi?id=68521
breaks GTK and Windows builds. Please check EWS next time.
(Requested by philn-tp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-21
Source/WebCore:
- html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
- page/Frame.cpp:
(WebCore::Frame::pageScaleFactor):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
LayoutTests:
- fast/events/scale-and-scroll-body-expected.png: Removed.
- fast/events/scale-and-scroll-body-expected.txt: Removed.
- fast/events/scale-and-scroll-body.html: Removed.
- fast/events/scale-and-scroll-iframe-body-expected.png: Removed.
- fast/events/scale-and-scroll-iframe-body-expected.txt: Removed.
- fast/events/scale-and-scroll-iframe-body.html: Removed.
- fast/events/scale-and-scroll-iframe-window-expected.png: Removed.
- fast/events/scale-and-scroll-iframe-window-expected.txt: Removed.
- fast/events/scale-and-scroll-iframe-window.html: Removed.
- fast/events/scale-and-scroll-window-expected.png: Removed.
- fast/events/scale-and-scroll-window-expected.txt: Removed.
- fast/events/scale-and-scroll-window.html: Removed.
- 4:37 AM Changeset in webkit [95611] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: console panel's scroller is not properly aligned.
https://bugs.webkit.org/show_bug.cgi?id=68448
Reviewed by Yury Semikhatsky.
- inspector/front-end/inspector.css:
(#console-view):
(#console-messages):
(#drawer #console-messages):
- 4:25 AM Changeset in webkit [95610] by
-
- 2 edits4 adds in trunk/LayoutTests
Unreviewed, GTK baseslines for 2 new tests and skip a flaky svg test.
- platform/gtk/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
- platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
- 4:16 AM Changeset in webkit [95609] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] http/tests/security/cross-origin-xsl-redirect-BLOCKED.html fails
https://bugs.webkit.org/show_bug.cgi?id=68515
- platform/qt-wk2/Skipped: Skip http/tests/security/cross-origin-xsl-redirect-BLOCKED.html.
- 4:01 AM Changeset in webkit [95608] by
-
- 8 edits12 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.
Reviewed by Simon Fraser.
The following things are done in this patch:
- Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
- Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
- scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.
Tests: fast/events/scale-and-scroll-body.html
fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html
- html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
- page/Frame.cpp:
(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
main frame, otherwise 1.0
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.
Reviewed by Simon Fraser.
Add tests to cover the following cases:
- Scale and scroll window
- Scale and scroll document.body
- Scale and scroll iframe's contentWindow
- Scale and scroll iframe's contentDocument.body
- fast/events/scale-and-scroll-body-expected.png: Added.
- fast/events/scale-and-scroll-body-expected.txt: Added.
- fast/events/scale-and-scroll-body.html: Added.
- fast/events/scale-and-scroll-iframe-body-expected.png: Added.
- fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
- fast/events/scale-and-scroll-iframe-body.html: Added.
- fast/events/scale-and-scroll-iframe-window-expected.png: Added.
- fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
- fast/events/scale-and-scroll-iframe-window.html: Added.
- fast/events/scale-and-scroll-window-expected.png: Added.
- fast/events/scale-and-scroll-window-expected.txt: Added.
- fast/events/scale-and-scroll-window.html: Added.
- 3:16 AM Changeset in webkit [95607] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name does nothing the second time
The logic in PDFViewController::pathToPDFOnDisk that deals with constructing a unique
file name if a file of the suggested name already exists was incorrect. It was appending
the template used by mkstemps to the directory name component of the path rather than
using it as a prefix on the filename portion of the path. This resulted in a template path
like WebKitPDFs-ABCDEFXXXXXX-/foo.pdf where WebKitPDFs-ABCDEF/XXXXXX-foo.pdf was expected.
Reviewed by Jon Honeycutt.
- UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::pathToPDFOnDisk): Append the template as a new path component,
then append the suggested file name to that component.
- 2:49 AM Changeset in webkit [95606] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline, skip some flaky worker tests and 2
failing http tests.
- platform/gtk/Skipped:
- platform/gtk/editing/deleting/regional-indicators-expected.txt:
- platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
- 2:19 AM Changeset in webkit [95605] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline and skip and a11y failing test.
- platform/gtk/Skipped: Skip accessibility/aria-hidden-updates-alldescendants.html
- platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
Rebaseline after r95335.
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.
- 1:59 AM Changeset in webkit [95604] by
-
- 18 edits in trunk/Source
[Qt] Remove Qt specific code from css/SelectorChecker.cpp
https://bugs.webkit.org/show_bug.cgi?id=67702
Reviewed by Csaba Osztrogonác.
Source/WebCore:
No new tests needed.
- css/SelectorChecker.cpp: Move Qt-specific code to the Qt-specific WebPlatformStrategies.
(WebCore::SelectorChecker::determineLinkStateSlowCase):
- platform/VisitedLinkStrategy.h:
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::isLinkVisited):
Source/WebKit/qt:
- WebCoreSupport/WebPlatformStrategies.cpp: Check the Qt global history here, instead of a platform independent file.
(WebPlatformStrategies::isLinkVisited):
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
(WebPlatformStrategies::isLinkVisited):
- WebCoreSupport/WebPlatformStrategies.h: Ditto.
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::addVisitedLink):
- WebCoreSupport/PlatformStrategiesWinCE.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
(WebKit::WebPlatformStrategies::isLinkVisited):
(WebKit::WebPlatformStrategies::addVisitedLink):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
- 1:41 AM Changeset in webkit [95603] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r95566.
- platform/gtk/mathml/xHeight-expected.txt:
- 12:09 AM Changeset in webkit [95602] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Skipped list update for meter-element-repaint-on-update-value.html,
which needs windows
- platform/win/Skipped:
- 12:01 AM Changeset in webkit [95601] by
-
- 3 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
- platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
- platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
- platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Added.
- platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.
Sep 20, 2011:
- 11:31 PM WikiStart edited by
- (diff)
- 10:58 PM Changeset in webkit [95600] by
-
- 4 edits in trunk/Source/WebCore
Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
https://bugs.webkit.org/show_bug.cgi?id=68228
Reviewed by Dimitri Glazkov.
Currently style changes on forwarded shadow child triggers
Node::reattach() only for the forwarded node. But it should
invalidate whole renderers on the shadow tree because
ShadowContentElement expects its inclusions to be attached and to
create renderers in the inclusion order. But single node
reattach() violates the expectation and possibly creates
inconsistent render tree.
This change makes NodeRenderingContext to go
AttachContentForwarded, where the ShadowContentElement::attach()
happens, only during ShadowRoot::attach(), not for style-change
triggered Node::attach() on the forwarded nodes.
Note that the altering phase AttachContentLight doesn't create
renderers for the forwarded nodes. Instead of that, it possibly
triggers shadow subtree reconstruction on
NodeRenderingContext::hostChildrenChanged().
No new tests. This is a defensive change. There is no visible
difference at this time.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::isInclusionSelectorActive):
- dom/ShadowRoot.h:
- 10:41 PM Changeset in webkit [95599] by
-
- 7 edits3 adds in trunk
<meter> doesn't update rendering when its value is changed.
https://bugs.webkit.org/show_bug.cgi?id=67614
Reviewed by Dimitri Glazkov.
Source/WebCore:
It lacks repaint() when the value is changed.
For non-native appearance it works because the indicator is
implemented in shadow DOM, for native appearance, repainting should be
handled explicitly.
Test: fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didElementStateChange):
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updateFromElement):
- rendering/RenderMeter.h:
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateAnimationState):
LayoutTests:
- fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
- platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html: Added.
- 10:38 PM Changeset in webkit [95598] by
-
- 3 edits in trunk/Source/WebCore
Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=67989
Reviewed by Ryosuke Niwa.
No new tests because of no behavior change.
- rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary): Moved from RenderObject.h.
(WebCore::RenderObject::markContainingBlocksForLayout): Moved from RenderObject.h
- rendering/RenderObject.h:
- 10:23 PM Changeset in webkit [95597] by
-
- 2 edits in trunk/LayoutTests
[chromium] changed test expectations for zoom-svg-through-object-with-auto-size.html:wq
- platform/chromium/test_expectations.txt:
- 9:19 PM Changeset in webkit [95596] by
-
- 4 edits in trunk/Source/JavaScriptCore
Some Heap cleanup.
Reviewed by Beth Dakin.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::blessNewBlock): Removed blessNewBlockForSlowPath()
because it was unused; renamed blessNewBlockForFastPath() to blessNewBlock()
since there is only one now.
- heap/MarkedBlock.h: Removed ownerSet-related stuff since it was unused.
Updated mark bit overhead calculation. Deployed atomsPerBlock in one
place where we were recalculating it.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::addBlock): Updated for rename.
- 8:37 PM Changeset in webkit [95595] by
-
- 5 edits in trunk/Tools
garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
https://bugs.webkit.org/show_bug.cgi?id=68496
Reviewed by Dimitri Glazkov.
This patch adds a bunch of sorting to make sure things happen in a
predictable order in both JavaScriptCore and V8. We've talked before
about whether these two JavaScript engines should enumerate
dictionaries in the same order, but the consensus has been that they
shouldn't. Personally, I disagree with that consensus, but such is life.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- 7:22 PM Changeset in webkit [95594] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG JIT always speculates integer on modulo
https://bugs.webkit.org/show_bug.cgi?id=68485
Reviewed by Oliver Hunt.
Added support for double modulo, which is a call to fmod().
Also added support for recording the old JIT's statistics
on op_mod and propagating them along the graph. Finally,
fixed a goof in the ArithNodeFlags propagation logic that
was made obvious when I started testing ArithMod.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:49 PM Changeset in webkit [95593] by
-
- 14 edits in trunk/Source/WebCore
Support for multiple <link rel="icon"> favicon elements.
https://bugs.webkit.org/show_bug.cgi?id=65564
Patch by Rachel Blum <groby@chromium.org> on 2011-09-20
Reviewed by Darin Fisher.
No tests - purely an API change. (And API is not exposed to LayoutTests)
- dom/Document.cpp:
(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):
- dom/Document.h:
- dom/IconURL.cpp:
(WebCore::toIconIndex):
- dom/IconURL.h:
(WebCore::IconURL::IconURL):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- loader/LinkLoader.h:
- loader/icon/IconController.cpp:
(WebCore::IconController::urlsForTypes):
(WebCore::IconController::appendToIconURLs):
(WebCore::IconController::defaultURL):
- 6:48 PM Changeset in webkit [95592] by
-
- 2 edits in trunk/Tools
garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=68495
Reviewed by Dimitri Glazkov.
This patch adds an implementation of Function.prototype.bind if the browser lacks one.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
- 6:30 PM Changeset in webkit [95591] by
-
- 3 edits in trunk/Source/WebCore
[css3-flexbox] cleanup padding width calculations
https://bugs.webkit.org/show_bug.cgi?id=68490
Reviewed by Tony Chang.
No new tests. Existing tests cover the refactor.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
- 6:07 PM Changeset in webkit [95590] by
-
- 2 edits2 adds in trunk/Source/WebKit/chromium
This CL makes it possible to create a blob from Chromium.
https://bugs.webkit.org/show_bug.cgi?id=68286
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebBlob.h: Added.
- src/WebBlob.cpp: Added.
- 6:04 PM Changeset in webkit [95589] by
-
- 1 edit5 adds1 delete in trunk/LayoutTests
[chromium] rebaseline caused by r95567
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-linux-x86/fast/clip: Removed.
- platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
- 5:48 PM Changeset in webkit [95588] by
-
- 4 edits in trunk
[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781
Reviewed by Ryosuke Niwa.
Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
For http tests, since the test url is an http url, we can't resolve relative
to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
for resolving.
I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.
It turns out that there was a second use for pathToLocalResource, used by one
test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
To support this test I made the new pathToLocalResource smart enough to map
/tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
- Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
- 5:34 PM Changeset in webkit [95587] by
-
- 3 edits in trunk/Tools
Need to specify a django version, instead of using default
https://bugs.webkit.org/show_bug.cgi?id=68398
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.
- QueueStatusServer/init.py:
- QueueStatusServer/main.py:
- 5:16 PM Changeset in webkit [95586] by
-
- 3 edits in trunk/Source/WebCore
Fix clang compile errors in Web Audio
https://bugs.webkit.org/show_bug.cgi?id=68384
Reviewed by David Levin.
No new tests; no net change in functionality.
- platform/graphics/MediaPlayer.h: Forward declare (instead of including directly)
AudioSourceProvider.
- webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput): Remove unused parameter name.
- 5:05 PM Changeset in webkit [95585] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of PluginView::setBoundsSize from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68489
Reviewed by Dan Bernstein.
Remove m_boundsSize and the setter since they aren't used anywhere.
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Plugins/PluginView.h:
- 5:04 PM Changeset in webkit [95584] by
-
- 2 edits in trunk/Tools
Update committers.py with a few more contributor contacts
https://bugs.webkit.org/show_bug.cgi?id=68487
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/committers.py:
- 4:53 PM Changeset in webkit [95583] by
-
- 2 edits in trunk/Tools
Fix webkitpy unit tests after 95547 and 95549
https://bugs.webkit.org/show_bug.cgi?id=68483
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Adam Barth.
Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
- Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
parse_entries_from_file(), use StringIO and entry.reviewer_text().
While testing parse_latest_entry_from_file(), expect the correct
touched_files() list.
- 4:49 PM Changeset in webkit [95582] by
-
- 4 edits in trunk
Directory Upload: parent path can truncate first char of the correct path
https://bugs.webkit.org/show_bug.cgi?id=66695
Source/WebCore:
In some cases, if the parent path we compute ends with a separator
character like '/' or 'C:\', by adding one in an attempt to grab the
subsequent separator we actually grab a character of the real path,
which is incorrect.
Reviewed by Darin Fisher.
- html/FileInputType.cpp:
(WebCore::FileInputType::setFileList):
LayoutTests:
Add a test case for when the parent path is '/'.
Reviewed by Darin Fisher.
- fast/forms/input-file-directory-upload.html:
- 4:43 PM Changeset in webkit [95581] by
-
- 2 edits in trunk/Tools
garden-o-matic makes it hard to compare images when scroll bars appear
https://bugs.webkit.org/show_bug.cgi?id=68482
Reviewed by Eric Seidel.
Because we autoscale image width, the images rescale if we overflow
vertically and get a scrollbar. That makes it hard to compare two sets
of images. This patch reserves space for the scrollbar so we won't
have the layout change.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
- 4:31 PM Changeset in webkit [95580] by
-
- 6 edits3 adds in trunk
Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
https://bugs.webkit.org/show_bug.cgi?id=68279
Reviewed by Adam Barth.
Source/WebCore:
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::willSendRequest):
LayoutTests:
- http/tests/security/resources/cross-origin-xsl-redirect.xml:
- http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
- platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
- platform/chromium/http/tests/permissionclient/image-permissions.html:
- 4:17 PM Changeset in webkit [95579] by
-
- 2 edits in trunk/Websites/webkit.org
Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045
Fix per Daniel's review comment since I had misunderstood the code.
- team.html:
- 3:57 PM Changeset in webkit [95578] by
-
- 1 edit1 add in trunk/Websites/webkit.org
Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045
Reviewed by Daniel Bates.
Add the initial implementation of team.html. This page automatically pulls data from committers.py
There are no areas of expertise but that'll be added once the bug 68061 is fixed.
- team.html: Added.
- 3:46 PM Changeset in webkit [95577] by
-
- 7 edits2 adds in trunk
change RenderFlexibleBox to act on logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=68129
Reviewed by David Hyatt.
Source/WebCore:
This makes RenderFlexibleBox respect direction and writing-mode.
We now properly support the default flex-flow value of "row".
Test: css3/flexbox/writing-modes.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setLogicalLocationForChild):
- rendering/RenderBlock.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
(WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/resources/flexbox.js:
- css3/flexbox/writing-modes-expected.txt: Added.
- css3/flexbox/writing-modes.html: Added.
- 3:39 PM Changeset in webkit [95576] by
-
- 2 edits in trunk/Source/WebCore
Use DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object returned from
FontPlatformData::hashTableDeletedFontValue() to avoid global destructor ordering problems.
https://bugs.webkit.org/show_bug.cgi?id=67906
Patch by Marshall Greenblatt <marshall@chromium.org> on 2011-09-20
Reviewed by Adam Barth.
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
- 3:37 PM Changeset in webkit [95575] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] remove obsolete WebPermissionClient::allowImages method
https://bugs.webkit.org/show_bug.cgi?id=68380
Reviewed by Darin Fisher.
- DEPS:
- public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):
- 3:33 PM Changeset in webkit [95574] by
-
- 3 edits4 adds in trunk
Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.
Fixed the bug by special-casing html element since margins of head and body elements are special.
Tests: editing/selection/click-on-body-margin.html
editing/selection/click-on-head-margin.html
- rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries):
LayoutTests:
Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.
- editing/selection/click-on-body-margin-expected.txt: Added.
- editing/selection/click-on-body-margin.html: Added.
- editing/selection/click-on-head-margin-expected.txt: Added.
- editing/selection/click-on-head-margin.html: Added.
- 3:23 PM Changeset in webkit [95573] by
-
- 9 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=68480
De-virtualize containingBlock() and make RenderView return 0 instead
of itself to make the construction of normal loops that terminate via
a null-check possible.
Fix the only two places in the tree that needed null checks.
Eliminating RenderTableCell::containingBlock() is fine since the base class
does the same thing anyway.
Reviewed by Simon Fraser.
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- rendering/RenderObject.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
- rendering/RenderView.cpp:
- rendering/RenderView.h:
- 3:16 PM Changeset in webkit [95572] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt] QTouchWebView missing signal tests for loadProgress
https://bugs.webkit.org/show_bug.cgi?id=68442
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Chang Shu.
Added test case to check load progress signal for QTouchWebView
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 2:59 PM Changeset in webkit [95571] by
-
- 2 edits2 adds in trunk/LayoutTests
[CSSRegions] Need test case for 66198 (sliced line box rendering)
https://bugs.webkit.org/show_bug.cgi?id=68257
Patch by Alan Stearns <stearns@adobe.com> on 2011-09-20
Reviewed by David Hyatt.
- fast/regions/resources/helper.js:
(assertTopLeftMatch):
(sameTopLeft):
- fast/regions/no-split-line-box-expected.txt: Added.
- fast/regions/no-split-line-box.html: Added.
- 2:47 PM Changeset in webkit [95570] by
-
- 7 edits in trunk/Source
Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188
Reviewed by Darin Adler.
../WebCore:
Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.
- platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm:
- platform/wx/ScrollViewWx.cpp:
../WebKit/mac:
When creating the document view, make sure it's zero sized which matches the initial size
of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
size to a zero size anyway.
- WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]):
- 2:14 PM Changeset in webkit [95569] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r95565.
http://trac.webkit.org/changeset/95565
https://bugs.webkit.org/show_bug.cgi?id=68470
Broke builds (Requested by andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20
Source/WebKit2:
- GNUmakefile.am:
- Shared/API/c/WKHitTestResult.cpp: Removed.
- Shared/API/c/WKHitTestResult.h: Removed.
- UIProcess/API/C/WebKit2.h:
Tools:
- MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):
- 2:08 PM Rebaseline edited by
- example out of date (?) (diff)
- 2:01 PM Changeset in webkit [95568] by
-
- 9 edits1 add in trunk/Source
[Qt] [WK2] Implement a persistent cookie storage.
https://bugs.webkit.org/show_bug.cgi?id=65309
Reviewed by Chang Shu.
Source/WebCore:
Implement a cookie storage for the Qt port on WebKit2.
The implementation is using a SQLite database to store the cookies
and restore them. It uses a static object as CookieJar is not an
object but a set of global functions. The actual saving/restoring is on
the WebProcess side where our network stack lives.
Existing tests cover the new implementation. Unfortunately there is one
case that we can't easily simulate : login in a website, make sure that the webprocess
is not running and then going back to this website and see that we are logged.
- WebCore.pri:
- WebCore.pro:
- platform/qt/CookieJarQt.cpp:
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
(WebCore::SharedCookieJarQt::shared):
(WebCore::SharedCookieJarQt::create):
(WebCore::SharedCookieJarQt::destroy):
(WebCore::SharedCookieJarQt::getHostnamesWithCookies):
(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
(WebCore::SharedCookieJarQt::~SharedCookieJarQt):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::ensureDatabaseTable):
(WebCore::SharedCookieJarQt::loadCookies):
- platform/qt/CookieJarQt.h: Added.
Source/WebKit2:
Add parameter to the WebProcess creation to specify where cookies should be saved.
It also use the new cookie storage implementation and set it to our network stack
so cookies are used when using it.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
- 1:26 PM Changeset in webkit [95567] by
-
- 3 edits3 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68314
Make sure that the containing block loop when clipping to border-radius
terminates by checking if you hit the RenderView. Null checking isn't sufficient
for stupid historical reasons that should be fixed (i.e., the RenderView returns itself
as its own containing block, even though this should just be changed).
Reviewed by Simon Fraser and Darin Adler.
Added new test in fast/clip.
- rendering/RenderLayer.cpp:
(WebCore::inContainingBlockChain):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68314
Added some more clipping tests for overflow to make sure the right things happen
when border-radius is specified.
Reviewed by Simon Fraser and Darin Adler.
- fast/clip/overflow-border-radius-fixed-position.html: Added.
- platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
- 1:21 PM Changeset in webkit [95566] by
-
- 38 edits in trunk
MathML renderers do not override RenderObject::renderName()
https://bugs.webkit.org/show_bug.cgi?id=68461
Reviewed by Darin Adler.
Source/WebCore:
Added implementations of renderName() in MathML RenderObject subclasses.
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::renderName):
- rendering/mathml/RenderMathMLFenced.h:
(WebCore::RenderMathMLFenced::renderName):
- rendering/mathml/RenderMathMLFraction.h:
(WebCore::RenderMathMLFraction::renderName):
- rendering/mathml/RenderMathMLMath.h:
(WebCore::RenderMathMLMath::renderName):
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::renderName):
- rendering/mathml/RenderMathMLRoot.h:
(WebCore::RenderMathMLRoot::renderName):
- rendering/mathml/RenderMathMLRow.h:
(WebCore::RenderMathMLRow::renderName):
- rendering/mathml/RenderMathMLSquareRoot.h:
(WebCore::RenderMathMLSquareRoot::renderName):
- rendering/mathml/RenderMathMLSubSup.h:
(WebCore::RenderMathMLSubSup::renderName):
- rendering/mathml/RenderMathMLUnderOver.h:
(WebCore::RenderMathMLUnderOver::renderName):
LayoutTests:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/msub-base-changed-expected.txt:
- platform/mac/mathml/presentation/msub-sub-changed-expected.txt:
- platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
- platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
- platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
- platform/mac/mathml/presentation/msup-base-changed-expected.txt:
- platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/style-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.txt:
- platform/mac/mathml/xHeight-expected.txt:
- 1:16 PM Changeset in webkit [95565] by
-
- 5 edits2 copies in trunk
Source/WebKit2: Added WKHitTestResult API's.
WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.
- GNUmakefile.am:
- Shared/API/c/WKHitTestResult.cpp: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):
- Shared/API/c/WKHitTestResult.h: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
- UIProcess/API/C/WebKit2.h:
Tools: Get hover'ed element URL from HitTest.
mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.
- MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):
- 1:13 PM Changeset in webkit [95564] by
-
- 7 edits in trunk
[GTK] requestAnimationFrame support for gtk port
https://bugs.webkit.org/show_bug.cgi?id=66280
Patch by ChangSeok Oh <ChangSeok Oh> on 2011-09-20
Reviewed by Martin Robinson.
.:
- configure.ac: Add an option to enable requestAnimationFrame for gtk port.
Source/JavaScriptCore:
Let GTK port use REQUEST_ANIMATION_FRAME_TIMER.
- wtf/Platform.h:
Source/WebCore:
Add some files to build-target & activate ENABLE_REQUEST_ANIMATION_FRAME flag
when enabling requestAnimationFrame option.
fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html
- GNUmakefile.am:
- GNUmakefile.list.am:
- 1:10 PM Changeset in webkit [95563] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG JIT performs too many negative zero checks, and too many
overflow checks
https://bugs.webkit.org/show_bug.cgi?id=68430
Reviewed by Oliver Hunt.
This adds comprehensive support for deciding how to perform an
arithmetic operations based on a combination of overflow profiling,
negative zero profiling, value profiling, and a static analysis of
how the results of these operations get used.
This is a 72% speed-up on stanford-crypto-sha256-iterative, and a
2.5% speed-up on the Kraken average, a 1.4% speed-up on the V8
geomean, and neutral on SunSpider. It's also an 8.5% speed-up on
V8-crypto, because apparenty everything we do speeds up crypto.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::weaklyPredictInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
- dfg/DFGNode.h:
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::arithNodeFlagsAsString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::rawArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::arithNodeFlagsForCompare):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- 1:05 PM Changeset in webkit [95562] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.
- LayoutTests/platform/chromium/test_expectations.txt:
- 12:05 PM Changeset in webkit [95561] by
-
- 2 edits5 copies in branches/chromium/874/LayoutTests
Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556
Source/WebCore:
Reviewed by Adam Barth.
Tests: http/tests/history/back-with-fragment-change.php
http/tests/navigation/navigation-interrupted-by-fragment.html
- loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
- loader/HistoryController.cpp: Don't commit the wrong provisional item.
LayoutTests:
Reviewed by Adam Barth.
Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.
- fast/loader/page-dismissal-modal-dialogs.html:
- fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
- http/tests/history/back-with-fragment-change-expected.txt: Added.
- http/tests/history/back-with-fragment-change.php: Added.
- http/tests/history/resources/back-with-fragment-change-target.html: Added.
- http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
- http/tests/navigation/navigation-interrupted-by-fragment.html: Added.
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/7983013
- 11:58 AM Changeset in webkit [95560] by
-
- 11 edits2 adds in trunk/Source
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828
Reviewed by Adam Barth.
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
- src/FrameLoaderClientImpl.h:
- tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::~Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Equals):
(WebKit::ContextLifetimeTestWebFrameClient::~ContextLifetimeTestWebFrameClient):
(WebKit::ContextLifetimeTestWebFrameClient::reset):
(WebKit::ContextLifetimeTestWebFrameClient::didCreateScriptContext):
(WebKit::ContextLifetimeTestWebFrameClient::willReleaseScriptContext):
- tests/data/context_notifications_test.html: Added.
- tests/data/context_notifications_test_frame.html: Added.
- 11:31 AM Changeset in webkit [95559] by
-
- 15 edits3 adds in trunk/Source
Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409
Reviewed by Gavin Barraclough.
../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- heap/AllocationSpace.cpp: Added.
(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):
- heap/AllocationSpace.h: Added.
(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):
- heap/Heap.h:
(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):
../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
Adding a forwarding header.
- ForwardingHeaders/heap/AllocationSpace.h: Added.
- 11:20 AM Changeset in webkit [95558] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- WebCorePrefix.h: Removed stray text from accidental paste.
- 11:17 AM Changeset in webkit [95557] by
-
- 2 edits in trunk/LayoutTests
2011-09-20 Pavel Feldman <pfeldman@google.com>
Not reviewed: one line inspector's script-formatter.html fix.
- inspector/debugger/script-formatter.html:
- 11:09 AM Changeset in webkit [95556] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
https://bugs.webkit.org/show_bug.cgi?id=66855
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-20
Reviewed by Antonio Gomes.
Most other ports call this method somewhere when the frame is being
removed, as it performs some destruction calls which, in our case, at
least makes sure onunload events get delivered properly in
fast/frames/iframe-reparenting-adopt-node.html.
- ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Call FrameLoader::detachFromParent()
- 11:02 AM Changeset in webkit [95555] by
-
- 39 edits in trunk/Source
Removed BREWMP* platform #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68425
BREWMP* has no maintainer, and this is dead code.
Reviewed by Darin Adler.
- heap/MarkStack.h:
(JSC::::shrinkAllocation):
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/CurrentTime.cpp:
- wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
- wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastMallocSize):
- wtf/FastMalloc.h:
- wtf/MainThread.cpp:
- wtf/MathExtras.h:
- wtf/OwnPtrCommon.h:
- wtf/Platform.h:
- wtf/RandomNumber.cpp:
(WTF::randomNumber):
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
- wtf/text/WTFString.h:
- wtf/unicode/Unicode.h:
../WebCore:
- WebCorePrefix.h:
- loader/cache/CachedFont.cpp:
- platform/DragData.h:
- platform/DragImage.h:
- platform/FileSystem.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformTouchEvent.h:
- platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
- platform/Widget.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntSize.h:
- platform/graphics/WOFFFileFormat.cpp:
- platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/skia/FontCustomPlatformData.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- platform/text/TextBoundaries.cpp:
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
- plugins/PluginViewNone.cpp:
- 10:47 AM Changeset in webkit [95554] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Copy Stack Trace lacks newlines on Windows
https://bugs.webkit.org/show_bug.cgi?id=68447
Reviewed by Joseph Pecoraro.
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
- 10:44 AM Changeset in webkit [95553] by
-
- 2 edits in trunk/Source/WebCore
2011-09-20 Pavel Feldman <pfeldman@google.com>
Not reviewed: inspector sanity test fix.
- inspector/front-end/inspector.js: (WebInspector.showConsole):
- 10:15 AM Changeset in webkit [95552] by
-
- 8 edits in branches/chromium/874/Source/WebCore
Merge 95506 - [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
https://bugs.webkit.org/show_bug.cgi?id=68405
Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.
Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::create):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdate):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7982004
- 10:08 AM Changeset in webkit [95551] by
-
- 6 edits4 adds in trunk/Source
[Qt][WK2] Add stubs for FULLSCREEN_API on Qt.
https://bugs.webkit.org/show_bug.cgi?id=68444
Reviewed by Andreas Kling.
Create all the stubs necessary for enabling FULLSCREEN_API on the Qt port.
Source/WebCore:
No new tests : just stubs.
- CodeGenerators.pri:
- WebCore.pro:
- features.pri:
Source/WebKit2:
- UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Added.
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::getFullScreenRect):
- WebKit2.pro:
- WebProcess/FullScreen/qt: Added.
- WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Added.
(WebKit::WebFullScreenManagerQt::WebFullScreenManagerQt):
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManagerQt::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerQt::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerQt::beginExitFullScreenAnimation):
- WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Added.
- 9:46 AM Changeset in webkit [95550] by
-
- 3 edits4 deletes in trunk
Unreviewed, rolling out r95509.
http://trac.webkit.org/changeset/95509
https://bugs.webkit.org/show_bug.cgi?id=68446
crashes chromium fast/repaint/japanese-rl-selection-repaint-
in-regions.html on Win and Linux (Requested by dslomov on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries):
LayoutTests:
- editing/selection/click-on-body-margin-expected.txt: Removed.
- editing/selection/click-on-body-margin.html: Removed.
- editing/selection/click-on-head-margin-expected.txt: Removed.
- editing/selection/click-on-head-margin.html: Removed.
- 9:45 AM Changeset in webkit [95549] by
-
- 3 edits in trunk/Tools
Changelog class should have a method to return all entries
https://bugs.webkit.org/show_bug.cgi?id=68399
Implement ChangeLog.parse_entries_from_file(). This method returns a generator
of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
and adapt it to become a generator.
- Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
- 9:41 AM Changeset in webkit [95548] by
-
- 10 edits8 adds in trunk
Source/WebCore: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159
Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- platform/qt/KURLQt.cpp:
(WebCore::KURL::fileSystemPath):
Source/WebKit/qt: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159
Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
New test case makes sure a qrc URL will properly load a user stylesheet.
Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.
(tst_QWebPage::userStyleSheetFromQrcUrl):
- tests/qwebpage/tst_qwebpage.qrc:
Tools: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159
Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTree.qrc: Added.
- DumpRenderTree/qt/resources/user.css: Added.
(body):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
- WebKitTestRunner/qt/resources/user.css: Added.
(body):
LayoutTests: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159
Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
New platform layout test since user style sheet is testable from DRT.
Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/fast/loader/user-stylesheet-qrc-path-expected.txt: Added.
- platform/qt/fast/loader/user-stylesheet-qrc-path.html: Added.
- 9:31 AM Changeset in webkit [95547] by
-
- 3 edits in trunk/Tools
ChangeLogEntry class should contain a list of touched files
https://bugs.webkit.org/show_bug.cgi?id=68115
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Eric Seidel.
Add method to return the list of files touched in a ChangeLog entry.
- Scripts/webkitpy/common/checkout/changelog.py: Add
touched_files_regexp and touched_files() method.
- Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
unit tests for touched_files() method.
- 9:27 AM Changeset in webkit [95546] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Rebaseline expectationd and file WK68445.
- platform/chromium/test_expectations.txt:
- 9:08 AM Changeset in webkit [95545] by
-
- 2 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Export QNetworkReply in the QtWebKit QML module.
https://bugs.webkit.org/show_bug.cgi?id=68401
Reviewed by Simon Hausmann.
Add QNetworkReply in the QtWebKit module. We use the enum QNetworkReply::NetworkError
as the error code when the load fails. It is not used in the QtQuick module therefore
the QML team thinks it should belong here. Also added some auto-tests to cover the
loading errors.
- UIProcess/API/qt/qmlplugin/plugin.cpp:
(WebKit2QmlPlugin::registerTypes):
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml: Added.
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Added.
- 8:46 AM Changeset in webkit [95544] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r95526 and r95541.
http://trac.webkit.org/changeset/95526
http://trac.webkit.org/changeset/95541
https://bugs.webkit.org/show_bug.cgi?id=68443
It broke 6 tests (Requested by ossy_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20
- DumpRenderTree/qt/main.cpp:
(main):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- 8:43 AM Changeset in webkit [95543] by
-
- 16 edits in trunk/Tools
Fix patch and bug numbering in the mocktool simulation code
https://bugs.webkit.org/show_bug.cgi?id=68374
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/feeders_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
- 7:57 AM Changeset in webkit [95542] by
-
- 5 edits in trunk/Source
Source/WebCore: [Qt][Mac] Buildfix after r95513.
Forwarding headers for WebCore should be generated based on WebCore sources instead of WebKit2.
Rubber-stamped by Andras Becsi.
- DerivedSources.pro:
- WebCore.pro: Add platform/mac/DisplaySleepDisabler.cpp to SOURCES.
Source/WebKit2: [Qt][Mac] Buildfix after r95513.
Rubber-stamped by Andras Becsi.
- Scripts/generate-forwarding-headers.pl: Add mm file supporting.
- 7:22 AM Changeset in webkit [95541] by
-
- 3 edits in trunk/Tools
[Qt] Don't override default QApplication font for DRT and WTR
Revision 95526 moved the relevant code below the QApplication
constructor, to fix a potential crash, and that made the code
take effect, breaking 6 tests.
We should rely on the QWebSettings to set default fonts, and
this QApplication::setFont() is a relic from when we didn't
have that option, so we remove the code.
Reviewed by Csaba Osztrogonác.
- DumpRenderTree/qt/main.cpp:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
- 7:08 AM Changeset in webkit [95540] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix after r95523
- wtf/CheckedArithmetic.h: Added stdint.h so we can have int64_t defined.
- 7:03 AM Changeset in webkit [95539] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed.
- LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- 7:00 AM Changeset in webkit [95538] by
-
- 13 edits in trunk
Web Inspector: document Debugger.paused, introduce types for ids in Debugger domain.
https://bugs.webkit.org/show_bug.cgi?id=68363
Migrates from poorly documented "details" object to explicit parameters
containing break type and data.
Reviewed by Tony Gentilcore.
Source/WebCore:
- inspector/InjectedScriptSource.js:
():
- inspector/Inspector.json:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::pause):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerDispatcher.prototype.paused):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- 6:58 AM Changeset in webkit [95537] by
-
- 2 edits2 adds in trunk/Source/WebKit2
[Qt] QDesktopWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68280
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Andreas Kling.
Added test case to check load progress property and signal for QDesktopWebView
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml: Added.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 6:51 AM Changeset in webkit [95536] by
-
- 9 edits in trunk
Source/WebCore: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio. Remove animation
from drawer -> panel transition.
https://bugs.webkit.org/show_bug.cgi?id=68155
ConsoleView, ConsolePanel and Drawer are all Views with custom show/hide implementations
and weird DOM element containment. As a result, we have a number of cases when switching
console from full panel to drawer mode and back result in UI glitches.
For the sake of code clarity and no glitches, I'd like to sacrifice the "grow into full
screen" console animation.
Reviewed by Tony Gentilcore.
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel):
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.get statusBarItems):
(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.createFilterElement):
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.wasShown):
- inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.get visible):
(WebInspector.Drawer.prototype._constrainHeight):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._animationDuration):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._toggleConsoleButtonClicked):
(WebInspector.set attached):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
LayoutTests: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio.
https://bugs.webkit.org/show_bug.cgi?id=68155
Reviewed by Tony Gentilcore.
- inspector/console/console-dir.html:
- 6:46 AM Changeset in webkit [95535] by
-
- 14 edits1 add in trunk
Web Inspector: streamline Console's MessageType and MessageSource semantics.
https://bugs.webkit.org/show_bug.cgi?id=68342
Source/WebCore:
This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.
Reviewed by Tony Gentilcore.
- dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
- inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype.toString):
- page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
(WebCore::Console::addMessage):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):
- page/ConsoleTypes.h:
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFailSocketStream):
Source/WebKit/mac:
This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.
Reviewed by Tony Gentilcore.
- WebCoreSupport/WebChromeClient.mm:
(stringForMessageSource):
(stringForMessageType):
- WebView/WebUIDelegatePrivate.h:
LayoutTests:
This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.
Reviewed by Tony Gentilcore.
- inspector/protocol/console-agent-expected.txt:
- platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
- 6:37 AM Changeset in webkit [95534] by
-
- 3 edits in trunk/Source/WebKit/mac
Make WebViews in NSPopovers render as they would in active windows.
The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WebView
and WebHTMLView need to also observe the will order on/off screen notifications.
https://webkit.org/b/68402
rdar://problem/9754099
Reviewed by John Sullivan.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
(-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
(-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
which can be the case for NSPopovers.
(-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.
- WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
(-[WebView removeWindowObservers]): Remove order off screen notification obverser.
(-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
(-[WebView _windowWillOrderOffScreen:]): Ditto.
- 5:45 AM Changeset in webkit [95533] by
-
- 1 edit58 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new tests.
- platform/gtk/css3/bdi-element-expected.png: Added.
- platform/gtk/css3/bdi-element-expected.txt: Added.
- platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Added.
- platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
- platform/gtk/css3/unicode-bidi-isolate-basic-expected.png: Added.
- platform/gtk/css3/unicode-bidi-isolate-basic-expected.txt: Added.
- platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
- platform/gtk/fast/borders/border-image-longhand-expected.png: Added.
- platform/gtk/fast/borders/border-image-longhand-expected.txt: Added.
- platform/gtk/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/gtk/fast/borders/border-image-massive-scale-expected.txt: Added.
- platform/gtk/fast/borders/border-image-outset-expected.png: Added.
- platform/gtk/fast/borders/border-image-outset-expected.txt: Added.
- platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
- platform/gtk/fast/borders/border-image-outset-split-inline-expected.png: Added.
- platform/gtk/fast/borders/border-image-outset-split-inline-expected.txt: Added.
- platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
- platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
- platform/gtk/fast/borders/border-image-repeat-expected.png: Added.
- platform/gtk/fast/borders/border-image-repeat-expected.txt: Added.
- platform/gtk/fast/borders/border-image-scaled-expected.png: Added.
- platform/gtk/fast/borders/border-image-scaled-expected.txt: Added.
- platform/gtk/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/gtk/fast/borders/border-image-scaled-gradient-expected.txt: Added.
- platform/gtk/fast/borders/border-image-scrambled-expected.png: Added.
- platform/gtk/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/gtk/fast/borders/border-image-side-reduction-expected.png: Added.
- platform/gtk/fast/borders/border-image-side-reduction-expected.txt: Added.
- platform/gtk/fast/borders/border-image-slices-expected.png: Added.
- platform/gtk/fast/borders/border-image-slices-expected.txt: Added.
- platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
- platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
- platform/gtk/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/gtk/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/gtk/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
- platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
- platform/gtk/fast/css/line-after-floating-div-expected.png: Added.
- platform/gtk/fast/css/line-after-floating-div-expected.txt: Added.
- platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
- platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
- platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/gtk/fast/reflections/reflection-masks-outset-expected.txt: Added.
- platform/gtk/fast/text/fallback-traits-fixup-expected.png: Added.
- platform/gtk/fast/text/fallback-traits-fixup-expected.txt: Added.
- platform/gtk/fast/text/hyphenate-limit-lines-expected.png: Added.
- platform/gtk/fast/text/hyphenate-limit-lines-expected.txt: Added.
- platform/gtk/svg/custom/pattern-rotate-gaps-expected.png: Added.
- platform/gtk/svg/custom/pattern-rotate-gaps-expected.txt: Added.
- platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Added.
- platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Added.
- 5:34 AM Changeset in webkit [95532] by
-
- 2 edits in trunk/Tools
WebKitTestRunner: Provide usage if run without arguments
If WTR is run without either one or more filenames, or
a '-' to indicate server mode, we don't need to start
up the test machinery. Doing so might actually crash,
as we'll exit the application immedeatly after anyways.
Reviewed by Simon Hausmann.
- 5:25 AM Changeset in webkit [95531] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, GTK baselines for tests added in r95489 and r95488.
- platform/gtk/http/tests/security/document-all-expected.txt: Added.
- platform/gtk/http/tests/security/window-named-proto-expected.txt: Added.
- 5:14 AM Changeset in webkit [95530] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed, GTK baselines for tests added in r95461.
- platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
- platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
- platform/gtk/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
- platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
- platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
- 5:10 AM Changeset in webkit [95529] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Rebase and unskip tests introduced in r95489 and r95488.
Unreviewed gardening.
- platform/qt/Skipped:
- platform/qt/http/tests/security/document-all-expected.txt: Added.
- platform/qt/http/tests/security/window-named-proto-expected.txt: Added.
- 4:50 AM Changeset in webkit [95528] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip failing fast/files/create-blob-url-crash.html on
GTK because of bug 66045.
- platform/gtk/Skipped:
- 4:43 AM Changeset in webkit [95527] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r95178 and r95362.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 4:36 AM Changeset in webkit [95526] by
-
- 2 edits in trunk/Tools
[Qt] Don't use QFont before initializing QApplication
Could potentially result in crash.
Reviewed by Simon Hausmann.
- 3:41 AM Changeset in webkit [95525] by
-
- 4 edits in trunk/Source
[Qt] resizeToContent seems to trigger infinite resize on some pages
https://bugs.webkit.org/show_bug.cgi?id=43852
Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
InnerHeight and InnerWidth are now calculated using ScrollView::visibleContentRect
including the scrollbars (if any) instead of using ScrollView::frameRect as before.
This makes no behavior change while not using the tiled backing
store and is compliant with the W3C definition stated in the CSSOM
View Module.
Plus it will return the correct values for tiled backing store,
thus fixing the original bug report by avoiding infinite resize
events caused by wrong innerHeight and innerWidth values.
Test: innerWidth/Height are covered by existing tests. The
non-infinite resizing is covered by a new Qt autotest at
test_qgraphicswebview::windowResizeEvent()
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight): using ScrollView::visibleContentRect.
(WebCore::DOMWindow::innerWidth): using ScrollView::visibleContentRect.
Source/WebKit/qt:
Test by Luiz Agostini.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(ResizeSpy::receiveResize):
(ResizeSpy::size):
(tst_QGraphicsWebView::windowResizeEvent):
- 3:22 AM Changeset in webkit [95524] by
-
- 5 edits in trunk
Web Inspector: implement reverse mapping for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=67850
Source/WebCore:
Implement the mapping from source code to compiled code. It will be used for
setting breakpoints on source code.
Reviewed by Pavel Feldman.
- inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/debugger/compiler-source-mapping.html:
- 2:41 AM Changeset in webkit [95523] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG JIT does not speculate aggressively enough on GetById
https://bugs.webkit.org/show_bug.cgi?id=68320
Reviewed by Oliver Hunt.
This adds the ability to access properties directly, by offset.
This optimization kicks in when at the time of DFG compilation,
it appears that the given get_by_id is self-cached by the old JIT.
Two new opcodes get introduced: CheckStructure and GetByOffset.
CheckStructure performs a speculation check on the object's
structure, and returns the storage pointer. GetByOffset performs
a direct read of the field from the storage pointer. Both
CheckStructure and GetByOffset can be CSE'd, so that we can
eliminate redundant structure checks, and redundant reads of the
same field.
This is a 4% speed-up on V8, a 2% slow-down on Kraken, and
neutral on SunSpider.
- bytecode/PredictedType.cpp:
(JSC::predictionFromClassInfo):
(JSC::predictionFromStructure):
(JSC::predictionFromCell):
- bytecode/PredictedType.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::fillStorage):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::GPRTemporary::GPRTemporary):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::storageResult):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
- dfg/DFGNode.h:
(JSC::DFG::OpInfo::OpInfo):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::structure):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::storageAccessDataIndex):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- wtf/StdLibExtras.h:
(WTF::safeCast):
- 2:28 AM Changeset in webkit [95522] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: extract RawSourceCode source mapping logic to helper classes.
https://bugs.webkit.org/show_bug.cgi?id=67789
Reviewed by Pavel Feldman.
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.get uiSourceCode):
- 1:58 AM Changeset in webkit [95521] by
-
- 11 edits2 adds in trunk/Source
[GTK] WebProcess shouldn't use the GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68062
Reviewed by Martin Robinson.
Source/WebCore:
Move errors code that is common between webki1 and webkit2 to
WebCore so that it can be shared.
- GNUmakefile.list.am: Add new files to compilation.
- platform/gtk/ErrorsGtk.cpp: Added.
(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
- platform/gtk/ErrorsGtk.h: Added.
Source/WebKit/gtk:
Use WebCore API to create errors in frame loader.
- WebCoreSupport/AssertMatchingEnums.cpp:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::cancelledError):
(WebKit::FrameLoaderClient::blockedError):
(WebKit::FrameLoaderClient::cannotShowURLError):
(WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
(WebKit::FrameLoaderClient::cannotShowMIMETypeError):
(WebKit::FrameLoaderClient::fileDoesNotExistError):
(WebKit::FrameLoaderClient::pluginWillHandleLoadError):
- webkit/webkiterror.cpp:
(webkit_network_error_quark):
(webkit_policy_error_quark):
(webkit_plugin_error_quark):
Source/WebKit/gtk/po:
- POTFILES: Remove FrameLoaderGtk.cpp and add ErrorsGtk.cpp.
Source/WebKit2:
Use WebCore API to create errors in WebProcess.
- GNUmakefile.am: Don't use webkit/webkierror.h.
- WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):
- 1:36 AM Changeset in webkit [95520] by
-
- 1 edit10 adds in trunk/LayoutTests
[Qt] Add Qt specific expecteds to new tests introduced in r95461.
Unreviewed gardening.
- platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
- platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
- platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
- platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
- platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
- platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
- platform/qt/fast/table/table-row-before-after-content-around-block-expected.png: Added.
- platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
- platform/qt/fast/table/table-row-before-after-content-around-table-expected.png: Added.
- platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
- 1:05 AM Changeset in webkit [95519] by
-
- 2 edits in trunk/LayoutTests
[Qt] Two tests fail after r95488 & r95489
https://bugs.webkit.org/show_bug.cgi?id=68428
Skip the failing tests.
Unreviewed gardening.
- platform/qt/Skipped:
- 12:57 AM Changeset in webkit [95518] by
-
- 4 edits in trunk
2011-09-20 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Update NEWS and configure.ac for 1.5.90 release
Reviewed by Martin Robinson.
- configure.ac:
2011-09-20 Philippe Normand <pnormand@igalia.com>
[GTK] Update NEWS and configure.ac for 1.5.90 release
Reviewed by Martin Robinson.
- NEWS: