Timeline


and

09/26/11:

23:55 Changeset [96076] by rniwa@webkit.org
  • 2 edits
    1 move
    8 deletes in trunk/LayoutTests

dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
https://bugs.webkit.org/show_bug.cgi?id=68865

Reviewed by Kent Tamura.

Converted the test.

  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
  • editing/deleting/delete-to-end-of-paragraph.html:
  • platform/chromium-linux/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
23:43 Changeset [96075] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip two tests because they are failing after r96070.

Unreviewed gardening.

  • platform/qt/Skipped:
23:32 Changeset [96074] by dglazkov@chromium.org
  • 5 edits in trunk/Tools

garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
23:27 Changeset [96073] by commit-queue@webkit.org
  • 14 edits
    1 copy in trunk

Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Previously, the following test cases fail or crash:

  • shouldBe("new PopStateEvent('eventType', { state: object1 }).state", "object1") -> FAIL
  • new PopStateEvent('eventType', { state: document }).state -> CRASH in DRT

This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:

  • If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.

When PopStateEvent.state is called, the ScriptValue is returned.

  • If PopStateEvent is constructed with SerializedScriptValue, it is stored as

SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.

Tests: fast/events/constructors/pop-state-event-constructor.html

fast/events/fire-popstate-event.html

  • GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.

  • dom/PopStateEvent.cpp:

(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.

  • dom/PopStateEvent.h:

(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.

  • dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.

LayoutTests:

  • fast/events/constructors/pop-state-event-constructor-expected.txt:
  • fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.
23:26 Changeset [96072] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] One more unreviewed buildfix after r96005.

  • WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
23:15 Changeset [96071] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Unreviewed buildfix after r96005.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

22:50 Changeset [96070] by simon.fraser@apple.com
  • 8 edits in trunk

Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67858

Reviewed by Darin Adler.

When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.

Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.

Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).

  • page/FrameView.cpp:

(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.

  • platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches

invalidateScrollbar().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().

  • rendering/RenderScrollbarPart.cpp: Ditto.

(WebCore::RenderScrollbarPart::imageChanged): Ditto.

22:12 Changeset [96069] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

Translucent scrollbars on composited layers render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58515

Source/WebCore:

Reviewed by Sam Weinig.

Scrollbars in composited elements were getting drawn twice,
because r41203 moved the call to paintOverflowControls() out of
RenderLayer::paintLayer(), but forgot to change RenderLayerBacking::paintIntoLayer().

Test: compositing/scrollbar-painting.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

LayoutTests:

Reviewed by Sam Weinig.

Pixel test with translucent scrollbars, to test whether they get
rendered twice.

  • compositing/scrollbar-painting-expected.png: Added.
  • compositing/scrollbar-painting-expected.txt: Added.
  • compositing/scrollbar-painting.html: Added.
20:24 Changeset [96068] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860

Reviewed by Oliver Hunt.

Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.

(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.

19:36 Changeset [96067] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix WK2 build after r96014
https://bugs.webkit.org/show_bug.cgi?id=68856

Reviewed by Gustavo Noronha Silva.

Commit r96014 added inspectorBaseURL for Qt but removed
inspectorPageURL, adding it back.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):

19:18 Changeset [96066] by jamesr@google.com
  • 17 edits in trunk/Source

[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417

Source/WebCore:

Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.

Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.

  • platform/graphics/IntRect.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418

Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:
19:07 Changeset [96065] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).

  • platform/chromium/test_expectations.txt:
18:44 Changeset [96064] by adamk@chromium.org
  • 9 edits
    3 adds in trunk/Source/WebCore

[MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824

Reviewed by Darin Adler.

Implements MutationRecord as specified in the thread at
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html,
including some minor naming changes from the original proposal.

This is a small part of the MutationObserver API, see
https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug covering
this feature.

No new tests as this isn't yet exposed to the platform.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/MutationRecord.cpp: Added.

(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::MutationRecord):
(WebCore::MutationRecord::~MutationRecord):

  • dom/MutationRecord.h: Added.

(WebCore::MutationRecord::target):
(WebCore::MutationRecord::addedNodes):
(WebCore::MutationRecord::removedNodes):
(WebCore::MutationRecord::previousSibling):
(WebCore::MutationRecord::nextSibling):
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
(WebCore::MutationRecord::oldValue):
(WebCore::MutationRecord::setOldValue):

  • dom/MutationRecord.idl: Added.
18:40 Changeset [96063] by levin@chromium.org
  • 1 edit in branches/chromium/835/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

  • src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8054006

18:39 Changeset [96062] by levin@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore/platform

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

  • platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

  • platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8057001

18:36 Changeset [96061] by commit-queue@webkit.org
  • 7 edits in trunk

Implement a CloseEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68793

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/close-event-constructor.html

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKey): Just removed an extra space.
(WebCore::OptionsObject::getKeyValue): Returns an unsigned short value corresponding to the given key.

  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8EventConstructors.cpp: Added the CloseEvent constructor.
  • websockets/CloseEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled close-event-constructor.html, since now V8 has the CloseEvent constructor.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [96060] by japhet@chromium.org
  • 22 edits in trunk/Source/WebCore

Clean up CachedResource::load(). Collapse its
logic into a single callsite, taking just a
CachedResourceLoader and a ResourceLoaderOptions.

  1. Its 'incremental' parameter is redundant.
  2. With 'incremental' removed, the SecurityCheckPolicy is the only parameter difference between the CachedResource::load() variants. Making it a part of ResourceLoaderOptions removes yet another random enum that is passed around individually.
  3. We currently have to call setResourceLoaderOptions() before load() on a new CachedResource, so we should just take the ResourceLoaderOptions in load().

https://bugs.webkit.org/show_bug.cgi?id=67443

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/FrameLoaderTypes.h: Move SecurityCheckPolicy to ResourceLoaderOptions.h.
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp: Enforce SecurityCheckPolicy here instead of SubresourceLoader.
  • loader/ResourceLoaderOptions.h: Store SecurityCheckPolicy on ResourceLoaderOptions.
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::defaultCachedResourceOptions): Define the default ResourceLoaderOptions for

CachedResource loads here instead of as a default parameter on requestResource().

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData): Remove m_incremental, since its purpose

is already enforced in the data() implementation of every CachedResource that doesn't want
incremental loads.

  • loader/cache/CachedResourceRequest.h:
18:27 Changeset [96059] by dglazkov@chromium.org
  • 2 edits in trunk/Tools

garden-o-matic should be pretty in Open Sans.
https://bugs.webkit.org/show_bug.cgi?id=68845

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
18:13 Changeset [96058] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
17:57 Changeset [96057] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

editing/selection/select-bidi-run.html fails on Chromium Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=68832

Unreviewed; remove the failing test expectation because it started passing after r96016.

  • platform/chromium/test_expectations.txt:
17:55 Changeset [96056] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Skip the test added by r95964 on Qt and GTK because it has been failing
on those two platforms. The failure is tracked by the bugs 68854 and 68855.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
17:52 Changeset [96055] by dglazkov@chromium.org
  • 4 edits in trunk/Tools

garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
17:43 Changeset [96054] by commit-queue@webkit.org
  • 30 edits
    2 adds in trunk

IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
https://bugs.webkit.org/show_bug.cgi?id=68818

Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/factory-basics.html

Adds ability to enumerate IndexedDB databases within an origin.

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • storage/IDBAny.cpp:

(WebCore::IDBAny::domStringList):
(WebCore::IDBAny::set):

  • storage/IDBAny.h:
  • storage/IDBBackingStore.h:
  • storage/IDBCallbacks.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):

  • storage/IDBLevelDBCoding.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • storage/IDBRequest.h:
  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::getDatabaseNames):

  • storage/IDBSQLiteBackingStore.h:

Source/WebKit/chromium:

Adds ability to enumerate IndexedDB databases within an origin.

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):

  • src/IDBCallbacksProxy.h:
  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::getDatabaseNames):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):

  • src/WebIDBFactoryImpl.h:

LayoutTests:

Adds ability to enumerate IndexedDB databases within an origin.

  • storage/indexeddb/factory-basics-expected.txt: Added.
  • storage/indexeddb/factory-basics.html: Added.
17:40 Changeset [96053] by mihaip@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Remove failing Chromium expectations for tests that now pass.

Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.

  • platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:36 Changeset [96052] by timothy_horton@apple.com
  • 3 edits
    3 adds in trunk

<animateColor> applied to filtered ellipse does not update
https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/10154777>

Reviewed by Darin Adler.

Invalidate the filter's cache when style changes take place so that style changes are respected.

Test: svg/filters/animate-fill.svg

17:35 Changeset [96051] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Fix build after r95982
https://bugs.webkit.org/show_bug.cgi?id=68842

Reviewed by Anders Carlsson.

The patch in r95982 removed the paint() function, because it was doing
nothing (in both implementations). This patch remove the call we had
for it to fix the build.

  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::paintContent):

17:24 Changeset [96050] by cdn@chromium.org
  • 2 edits
    2 deletes in branches/chromium/835

Revert 96034 - Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText

BUG=95359
Review URL: http://codereview.chromium.org/8046025

TBR=cdn@chromium.org
Review URL: http://codereview.chromium.org/8041053

17:23 Changeset [96049] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Removed an unnecessary include in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=68834

Reviewed by Darin Fisher.

  • src/WebFrameImpl.cpp:
17:23 Changeset [96048] by mihaip@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Remove failing expectations for some ruby tests, since they were
renamed to -disabled with r94327 and thus aren't being run at all.

Add compositing/video-page-visibility.html Windows GPU baselines.

  • platform/chromium-gpu-win/compositing/video-page-visibility-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:06 Changeset [96047] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
17:03 Changeset [96046] by levin@chromium.org
  • 4 edits in trunk/Tools

watchlist: Add parsing for definition section.
https://bugs.webkit.org/show_bug.cgi?id=68850

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/watchlist/watchlist.py:
  • Scripts/webkitpy/common/watchlist/watchlistparser.py:
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
16:53 Changeset [96045] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Geoffrey Garen.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

16:45 Changeset [96044] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()

BUG=96149
Review URL: http://codereview.chromium.org/8044037

16:43 Changeset [96043] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)

BUG=96149
Review URL: http://codereview.chromium.org/8038042

16:42 Changeset [96042] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode

BUG=96149
Review URL: http://codereview.chromium.org/8037053

16:40 Changeset [96041] by mrowe@apple.com
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

16:39 Changeset [96040] by mrowe@apple.com
  • 1 copy in tags/Safari-534.51.23

New tag.

16:39 Changeset [96039] by cdn@chromium.org
  • 5 edits in branches/chromium/835/Source/WebCore

Merge 95093 - 2011-09-13 Pavel Feldman <pfeldman@google.com>

BUG=96170
Review URL: http://codereview.chromium.org/8028048

16:38 Changeset [96038] by mrowe@apple.com
  • 4 edits in branches/safari-534.51-branch/Source/WebCore

Merge r95863.

16:36 Changeset [96037] by alex@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.6

Update the release number for 1.6.0 and add the NEWS information

16:36 Changeset [96036] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)

BUG=96150
Review URL: http://codereview.chromium.org/8044036

16:35 Changeset [96035] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode

BUG=96150
Review URL: http://codereview.chromium.org/8044035

16:31 Changeset [96034] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText

BUG=95359
Review URL: http://codereview.chromium.org/8046025

16:29 Changeset [96033] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).

  • platform/chromium/test_expectations.txt:
16:26 Changeset [96032] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org>

BUG=95761
Review URL: http://codereview.chromium.org/8037052

16:23 Changeset [96031] by cdn@chromium.org
  • 1 edit
    3 copies in branches/chromium/835

Merge 95488 - Named property confusion with proto

BUG=95671
Review URL: http://codereview.chromium.org/8036045

16:21 Changeset [96030] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Set but unused variables cleanup in v8 bindings (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68079

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

LayoutTests:

  • http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.
16:20 Changeset [96029] by cdn@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/dom/Range.cpp

Merge 94512 - Unreviewed. Compile fix for r94511.

BUG=95360
Review URL: http://codereview.chromium.org/8048007

16:13 Changeset [96028] by cdn@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 94511 - Crash in Range::processAncestorsAndTheirSiblings.

BUG=95360
Review URL: http://codereview.chromium.org/8041051

16:10 Changeset [96027] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 95301 - cachedFont not getting updated for inline SVG text.

BUG=95072
Review URL: http://codereview.chromium.org/8041050

16:07 Changeset [96026] by tony@chromium.org
  • 4 edits in trunk

switch the initial value of flex-order to 0
https://bugs.webkit.org/show_bug.cgi?id=68820

Source/WebCore:

The spec changed from having an initial value of 1 to 0.

Reviewed by Ojan Vafai.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialFlexOrder):

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/flexbox/flex-order.html:
16:07 Changeset [96025] by cdn@chromium.org
  • 3 edits in branches/chromium/835/Source/WebCore/dom

Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.

BUG=93788
Review URL: http://codereview.chromium.org/8041049

16:04 Changeset [96024] by cdn@chromium.org
  • 2 edits
    3 copies in branches/chromium/835

Merge 94991 - <rdar://problem/10054615> Floats in ruby text intrude into the base

BUG=94810
Review URL: http://codereview.chromium.org/8044031

16:02 Changeset [96023] by cmarrin@apple.com
  • 9 edits in trunk

Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows

  • wtf/Platform.h:

WebKitLibraries:

Enable REQUEST_ANIMATION_FRAME for Windows

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows

  • platform/win/Skipped:
16:02 Changeset [96022] by enne@google.com
  • 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp

[chromium] Work around null render surface crash in updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=68838

Reviewed by James Robinson.

Landed directly on the Chromium 874 branch.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateCompositorResources):

16:00 Changeset [96021] by simon.fraser@apple.com
  • 3 edits in trunk/Tools

Fix WebKitTestRunner builds for Cairo, Windows and Qt.

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

  • WebKitTestRunner/win/TestInvocationWin.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

15:58 Changeset [96020] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

OfflineAudioDestinationNode must wait for thread completion in uninitialize()
https://bugs.webkit.org/show_bug.cgi?id=68725

Reviewed by Kenneth Russell.

No new tests. This fixes internal implementation details.

  • webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::uninitialize):

15:57 Changeset [96019] by alex@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/tests/testatk.c

Revert a change added by mistake to the last merge

15:53 Changeset [96018] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8041046

15:51 Changeset [96017] by cdn@chromium.org
  • 3 edits
    2 copies in branches/chromium/835

Merge 95462 - Source/WebCore: Issues with merging ruby bases.

BUG=94809
Review URL: http://codereview.chromium.org/8028045

15:50 Changeset [96016] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

editing/selection/select-bidi-run.html timeouts on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=68831

Reviewed by Enrica Casucci.

Click at (0,0) to reset click count instead of a long leapForward.

  • editing/selection/select-bidi-run.html:
15:49 Changeset [96015] by alex@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.6/Source

Merging http://trac.webkit.org/changeset/96009

15:46 Changeset [96014] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

REGRESSION (r95747): Activating the web inspector causes the web process to be killed
https://bugs.webkit.org/show_bug.cgi?id=68762

Reviewed by Anders Carlsson.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):

Tell Web process that loading resources from WebCore resources directory is OK.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):

  • UIProcess/WebProcessProxy.h:

Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):
Report what base directory Inspector has access to.

15:45 Changeset [96013] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update the test expectaion file for media related tests.
It includes updating bug numbers, removing
media/video-controls-visible-audio-only.html, and unskipping
media/media-document-audio-repaint.html.
https://bugs.webkit.org/show_bug.cgi?id=68254

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
15:45 Changeset [96012] by cdn@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 95054 - Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.

BUG=92226
Review URL: http://codereview.chromium.org/8048004

15:44 Changeset [96011] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8044030

15:34 Changeset [96010] by mihaip@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: Fix copy and paste error in r96002.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

LayoutTests: Remove test that no longer crashes (fixed by r95985).

  • platform/chromium/test_expectations.txt:
15:28 Changeset [96009] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm: add getters (but not

setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.

15:27 Changeset [96008] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Leopard build fix.

  • testing/Internals.cpp:

(WebCore::Internals::setZoomAnimatorTransform):

15:22 Changeset [96007] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726

Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):

  • storage/IDBLevelDBCoding.cpp:
15:21 Changeset [96006] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
https://bugs.webkit.org/show_bug.cgi?id=68807

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
15:19 Changeset [96005] by simon.fraser@apple.com
  • 54 edits in trunk

Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Tools:

Reviewed by Sam Weinig.

Convert DumpRenderTree to use use the repaint rects
exposed via WebKit API when generating the repaint test
overlay.

Fix WebKitTestRunner to work with repaint tests, again
using the repaint rects exposed from WK2.

In both cases, layoutTestController.display() now just
forces a display of the web view, and turns on repaint
rect tracking on the main FrameView.

Later, when pixel results are requested, the alpha overlay
that shows the repaint rects is generated using the list
of rects supplied by WebCore.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(displayWebView):

  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(paintRepaintRectOverlay):
(createBitmapContextFromWebView):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::setRepaintRects):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset):
(WTR::InjectedBundlePage::dump):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::display):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests:

Reviewed by Sam Weinig.

Update Mac results to use the new repaint rects. Differences from old results:

  • There are no longer invalidates from scrolling.
  • We no longer see the effects of AppKit rect coalescing.
  • Composting tests show the overlay now, but repaints in compositing layers do not show.

Bad results in a couple of tests are covered by bugs 68830 and 68829.

  • platform/mac/fast/repaint/4774354-expected.png:
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/border-radius-repaint-expected.png:
  • platform/mac/fast/repaint/clipped-relative-expected.png:
  • platform/mac/fast/repaint/containing-block-position-change-expected.png:
  • platform/mac/fast/repaint/control-clip-expected.png:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
  • platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
  • platform/mac/fast/repaint/flexible-box-overflow-expected.png:
  • platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/mac/fast/repaint/float-move-during-layout-expected.png:
  • platform/mac/fast/repaint/float-overflow-expected.png:
  • platform/mac/fast/repaint/float-overflow-right-expected.png:
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/mac/fast/repaint/inline-block-overflow-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/layer-child-outline-expected.png:
  • platform/mac/fast/repaint/layer-outline-expected.png:
  • platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/mac/fast/repaint/line-overflow-expected.png:
  • platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
  • platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
  • platform/mac/fast/repaint/outline-child-repaint-expected.png:
  • platform/mac/fast/repaint/outline-shrinking-expected.png:
  • platform/mac/fast/repaint/overflow-delete-line-expected.png:
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/mac/fast/repaint/scale-page-shrink-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/selection-after-remove-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/mac/fast/repaint/static-to-positioned-expected.png:
  • platform/mac/fast/repaint/table-cell-move-expected.png:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/mac/fast/repaint/text-shadow-expected.png:
  • platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
15:19 Changeset [96004] by alex@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.6

Merging http://trac.webkit.org/changeset/95996

15:16 Changeset [96003] by alex@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.6/Source/WebCore

Merging http://trac.webkit.org/changeset/95651

15:12 Changeset [96002] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Disable Chromium gesture recognizer tests that started to fail on the
Mac bots recently.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

15:10 Changeset [96001] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[Chromium] Remove DFGAliasTracker.h references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68787

Reviewed by Geoffrey Garen.

DFG/DFGAliasTracker.h was removed in r95389. Cleanup (remove) references
to that file from the gyp project files.

15:07 Changeset [96000] by commit-queue@webkit.org
  • 7 edits in trunk

Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.
Also use the correct expected result for toDataURL.jpeg.alpha.html.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
  • platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
15:00 Changeset [95999] by commit-queue@webkit.org
  • 10 edits
    2 copies in trunk

Source/WebKit2: Added WKHitTestResult API's.

WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • UIProcess/API/C/WKHitTestResult.cpp: Added.

(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):

  • UIProcess/API/C/WKHitTestResult.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2API.pri:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Tools: Get hover'ed element URL from HitTest.

mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.

  • MiniBrowser/gtk/BrowserWindow.c:

(mouseDidMoveOverElement):

14:47 Changeset [95998] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk

[CMake] Remove FindFreetype.cmake
https://bugs.webkit.org/show_bug.cgi?id=68778

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.

CMake has provided its own FindFreetype.cmake forever, so there is no
need to have another implementation in WebKit.

.:

  • Source/cmake/FindCairo.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}

instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.

  • Source/cmake/FindFreetype.cmake: Removed.
  • Source/cmake/FindPango.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}

instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.

  • Source/cmake/OptionsEfl.cmake: Remove minimum required version

check, it has never been checked and Freetype 2.1.10 from 2005 is
already > 9.0.

Source/WebCore:

No new tests, just a buildsystem change.

  • CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of

Freetype_{LIBRARIES,INCLUDE_DIRS}.

Source/WebKit/efl:

  • CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of

Freetype_{LIBRARIES,INCLUDE_DIRS}.

14:44 Changeset [95997] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix full-page rubber band overhang appearing when gesturing during a slow page load.
https://bugs.webkit.org/show_bug.cgi?id=68568

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=97243

(This also happens on Safari.)

The problem was that ScrollView::overhangAmount() was returning a full-page overhang due to contentsSize() being 0 briefly during a page load, which was then getting used by ScrollAnimatorChromiumMac.mm to update the overhang on a gesture event. This change makes the relevant logic not return an overhang if the contentsSize() is empty.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

No new tests, since this is highly timing-related.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):

14:44 Changeset [95996] by alex@webkit.org
  • 4 edits in trunk

2011-09-26 Alejandro G. Castro <alex@igalia.com>

[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797

Defined DOMAIN variable before DISTCLEANFILES because we are using
it there to identify the .pot file.

Reviewed by Martin Robinson.

  • GNUmakefile.am:

2011-09-26 Alejandro G. Castro <alex@igalia.com>

[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797

DOMAIN is already defined, we just add the value to the variable.

Reviewed by Martin Robinson.

  • GNUmakefile.am:
14:39 Changeset [95995] by levin@chromium.org
  • 1 edit
    5 adds in trunk/Tools

Add skeleton parsing for a WatchList.
https://bugs.webkit.org/show_bug.cgi?id=68823

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.

Parses the top level watch list sections -- none are defined yet -- and
throws an exception if an invalid one is listed.

  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.

Verify the exception for an invalid section in a watch list.

  • Scripts/webkitpy/common/watchlist/watchlist.py: Added.
14:35 Changeset [95994] by jschuh@chromium.org
  • 6 edits
    3 copies in branches/chromium/835

Merge 94905 - Source/WebCore: Crash due to bad data in SVGDocumentExtensions m_pendingResources
BUG=91092
Review URL: http://codereview.chromium.org/8038032

14:32 Changeset [95993] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 94864 - Source/WebCore: Assert being hit in AccessibilityRenderObject::addChildren()
BUG=84885
Review URL: http://codereview.chromium.org/8036039

14:24 Changeset [95992] by jschuh@chromium.org
  • 2 edits
    2 copies in branches/chromium/835

Merge 94716 - Changes to aria-hidden don't change VO navigation
BUG=84160
Review URL: http://codereview.chromium.org/8037036

14:17 Changeset [95991] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized readBUG=60653
Review URL: http://codereview.chromium.org/8041039

14:06 Changeset [95990] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a failing expectation to the test added by r95964 on Chromium Linux and Chromium Windows.
The failure is tracked by the bug 68832.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [95989] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]Unreviewed speculative buildfix after r95968.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

13:31 Changeset [95988] by wjmaclean@chromium.org
  • 16 edits
    1 add in trunk

[chromium] Revise zoom animator backend to use full transform instead of just scale.
https://bugs.webkit.org/show_bug.cgi?id=68535

Reviewed by Kenneth Russell.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
(WebCore::Settings::setZoomAnimatorPosition):
(WebCore::Settings::zoomAnimatorPosX):
(WebCore::Settings::zoomAnimatorPosY):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setZoomAnimatorTransform):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • testing/Internals.cpp:

(WebCore::Internals::setZoomAnimatorTransform):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

  • platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
  • platform/chromium/compositing/zoom-animator-scale-test.html:
13:28 Changeset [95987] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

Layout Test fast/animation/request-animation-frame-timestamps-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68821

Switch test to use finishJSTest(), which handles js-test-post.js loading
after the test is complete better.

  • fast/animation/request-animation-frame-timestamps-advance.html:
  • fast/animation/script-tests/request-animation-frame-timestamps-advance.js:

(window.webkitRequestAnimationFrame):

  • platform/chromium/test_expectations.txt:
13:08 Changeset [95986] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Detect the operating system in a more generic way.
https://bugs.webkit.org/show_bug.cgi?id=67482

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.

So far the buildsystem only considered Windows, Linux and Mac OS X as
valid operating systems, but any Unix (or at least the BSDs) should also
work fine.

By using the OS values CMake itself defines we can check for Unix
systems in a more generic fashion.

  • Source/CMakeLists.txt:
13:08 Changeset [95985] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68819

Reviewed by Dave Hyatt.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::scheduleRelayout): Revert to using view() instead of the RenderView
parameter of isRooted, since only the former returns 0 when the document is detached.

13:06 Changeset [95984] by vsevik@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
https://bugs.webkit.org/show_bug.cgi?id=67399

Reviewed by Pavel Feldman.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/ConsoleMessage.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):

  • inspector/front-end/inspector.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.linkifyStringAsFragment):

12:58 Changeset [95983] by demarchi@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Add virtual method to notify user when wrapping focus
https://bugs.webkit.org/show_bug.cgi?id=68699

Reviewed by Antonio Gomes.

Add a virtual method to ewk_view, so the Chrome gets notified if we
finished focusing all the items and would start over. This way the
browser can decide to handle the subsequent focus changes among its
widgets.

  • WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to

give it a chance to grab focus
(WebCore::ChromeClientEfl::canTakeFocus):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: add virtual method

(ewk_view_focus_can_cycle):

  • ewk/ewk_view.h: add focus direction enum and virtual method
12:58 Changeset [95982] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Remove an old DrawingAreaProxy::paint member function
https://bugs.webkit.org/show_bug.cgi?id=68825

Reviewed by Dan Bernstein.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/TiledDrawingAreaProxy.h:
12:57 Changeset [95981] by mihaip@chromium.org
  • 2 edits
    1 copy in trunk/LayoutTests

Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.

Previous expected result was Chromium-specific because console line
numbers were different in JSC.

Additionally, the test doesn't behave as expected for non-Chromium
ports (window size remains at 800x600). Update the baselines to use
that for now, so that we're still aware of regressions/progressions.

  • fast/dom/Window/window-resize-contents-expected.txt:
  • platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.
12:54 Changeset [95980] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 95074 - Crash in RenderScrollbarPart::imageChanged.
BUG=96444
Review URL: http://codereview.chromium.org/8028035

12:52 Changeset [95979] by inferno@chromium.org
  • 2 edits in branches/chromium/835

Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/8038026

12:51 Changeset [95978] by jer.noble@apple.com
  • 4 edits in trunk/Source

White flash when entering full-screen using element.webkitRequestFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=68481

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by existing full screen tests.

During an animation, renderers may try to paint into the FullScreenRenderer's
GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
background will cause these paints to fail. Remove this optimization in
containsPaintedContent, and taking non-composited elements into full screen will
animate correctly.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):

Source/WebKit2:

Do not re-enable screen updates after exiting compositing mode until a repaint has completed.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
(continueExitCompositingModeAfterRepaintCallback):
(-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):

12:49 Changeset [95977] by inferno@chromium.org
  • 2 edits
    3 copies in branches/chromium/835

Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8037034

12:48 Changeset [95976] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8028034

12:46 Changeset [95975] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8041034

12:43 Changeset [95974] by mihaip@chromium.org
  • 3 edits
    12 deletes in trunk

Unreviewed, rolling out r95960.
http://trac.webkit.org/changeset/95960
https://bugs.webkit.org/show_bug.cgi?id=58608

Significantly changes table border rendering

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-groove-expected.png: Removed.
  • fast/borders/border-groove-expected.txt: Removed.
  • fast/borders/border-groove.html: Removed.
  • fast/borders/border-inset-expected.png: Removed.
  • fast/borders/border-inset-expected.txt: Removed.
  • fast/borders/border-inset.html: Removed.
  • fast/borders/border-outset-expected.png: Removed.
  • fast/borders/border-outset-expected.txt: Removed.
  • fast/borders/border-outset.html: Removed.
  • fast/borders/border-ridge-expected.png: Removed.
  • fast/borders/border-ridge-expected.txt: Removed.
  • fast/borders/border-ridge.html: Removed.
12:43 Changeset [95973] by inferno@chromium.org
  • 2 edits
    3 copies in branches/chromium/835

Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8043034

12:41 Changeset [95972] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/835

Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8043033

12:38 Changeset [95971] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8044027

12:37 Changeset [95970] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8036034

12:09 Changeset [95969] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
12:01 Changeset [95968] by simon.fraser@apple.com
  • 10 edits in trunk/Source/WebKit2

Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Reviewed by Sam Weinig.

Expose WKBundlePage methods to turn on repaint rect tracking
in WebKit2, for WebKitTestRunner.

As part of the change, expose utility methods on WebPage
to get the main Frame and FrameView, which required renaming
the exisiting method that returns a WebFrame. Fix callers
of that method to handle null when necessary.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetMainFrame):
(WKBundlePageSetTracksRepaints):
(WKBundlePageIsTrackingRepaints):
(WKBundlePageResetTrackedRepaints):
(WKBundlePageCopyTrackedRepaintRects):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::findLargestFrameInFrameSet):
(WebKit::WebChromeClient::closeWindowSoon):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::frameLoadCompleted):
(WebKit::WebFrameLoaderClient::restoreViewState):
(WebKit::WebFrameLoaderClient::provisionalLoadStarted):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::isMainFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTracksRepaints):
(WebKit::WebPage::isTrackingRepaints):
(WebKit::WebPage::resetTrackedRepaints):
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::clearMainFrameName):
(WebKit::WebPage::layoutIfNeeded):
(WebKit::WebPage::mainFrameHasCustomRepresentation):
(WebKit::WebPage::mainFrame):
(WebKit::WebPage::mainFrameView):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::mainWebFrame):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

11:57 Changeset [95967] by simon.fraser@apple.com
  • 7 edits in trunk/Source

Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Reviewed by Sam Weinig.

Source/WebCore:

Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.

The repaint rects are in WebView coordinates, so we have to
unapply the scroll offset.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::setTracksRepaints):

  • page/FrameView.h:

(WebCore::FrameView::isTrackingRepaints):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::trackedRepaintRects):

Source/WebKit/mac:

Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.

  • WebView/WebView.mm:

(-[WebView setTracksRepaints:]):
(-[WebView isTrackingRepaints]):
(-[WebView resetTrackedRepaints]):
(-[WebView trackedRepaintRects]):

  • WebView/WebViewPrivate.h:
11:53 Changeset [95966] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633

Reviewed by Dave Hyatt, Darin Adler, Dimitri Glazkov.

:link, :visited and :focus are quite common. They often used as univeral selectors (including in our
default stylesheet) so we try to match them for all elements in the document. They take always the
slow matching path. In addition we match link styles twice due to visited link pseudo style generation
so the overhead is doubled. As a result substantial portion of our style matching time is spent
dealing with these pseudo classes.

This patch adds new lists to RuleSet for common pseudo class rules. The rules on the lists are only checked
if the element has approprate type and stat. ases where the rightmost pseudo class can then be rejected immediately.
We can also enable the fast path checking for the rest of the selector in many cases.

This seems to be >30% progression in selector matching performance with typical style sheets. It saves ~0.9s
when loading the full HTML5 spec.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::visitedPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):

Add a new lists, some stylistic renamings.


(WebCore::CSSStyleSelector::matchRules):

New link and focus checks.

(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):

Inline the rightmost selector tag checking, skip if unnecessary.


(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):

Common pseudo classes now match based on early filtering (though it is not a hash in this case).

(WebCore::RuleData::RuleData):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addRule):

Sort pseudo classes to new lists.


(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

Adopt to expanded fast path (this is used by querySelectorAll).

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):

Rightmost selector is now checked differently than the rest. RuleSet based selection in CSSStyleSelector
is equivalent to fastCheckRightmostSelector().


(WebCore::isFastCheckableRelation):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::isFrameFocused):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):
(WebCore::SelectorChecker::linkMatchesVisitedPseudoClass):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
(WebCore::SelectorChecker::tagMatches):

Refactor a bunch of shared checks into functions.

11:52 Changeset [95965] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt]REGRESSION(r95865): It made 4 tests crash
https://bugs.webkit.org/show_bug.cgi?id=68780

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-09-26
Reviewed by Oliver Hunt.

emitJumpSlowCaseIfNotJSCell(...) cannot be moved
away since the next load depends on it.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):

11:30 Changeset [95964] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

REGRESSION(r74971): Selection doesn't work correctly in BiDi Text
https://bugs.webkit.org/show_bug.cgi?id=57340

Reviewed by Eric Seidel.

Source/WebCore:

This patch adds the end point adjustment mechanism at bidi boundaries similar to the one NSTextView implements.

To understand the problem, suppose we have strong RTL letters "ABC" in a LTR block (visually laid out as CBA).

Per NSTextView convention, logical offsets between each letter is placed as (0)C(2)B(1)A(3). In other words,
placing the caret visually on the left of CBA yields the position inside the text node of "ABC" at offset 0.
Likewise, placing it between C and B yields ("ABC", 2), and placing it on the right of CBA yields ("ABC", 3).

Now suppose a user attempts to select the letter A by a mouse drag from the right of CBA to a point between
B and A. First, the initial mouse down places the selection's base at ("ABC", 3). Then as the mouse pointer
moves to a point on the left of A, the selection's extent is set at ("ABC", 1), selecting "BC".

To mitigate this issue, NSTextView adjusts selection base and extent under certain conditions. In the above
example, NSTextView detects user's intent and changes the selection's base to ("ABC", 0) temporarily.

This patch implements a similar trick on WebKit. We adjust the base or the extent when they're at the left
end or at the right end of a bidi run and the other end is inside of the run. In the above example, the
base position on the right of A is the right end of a bidi run and the extent position between B and A is
inside the same run (CBA), so we would adjust the base to be ("ABC", 0) as NSTextView does.

Take another example abcABC. Note offsets are assigned as (0)a(1)b(2)c(3)C(5)B(4)A(6) When the user starts
a mouse drag from the right of A to a point between B and A, we adjust the selection base to be ("abcABC", 3)
because the base is at the right end of a bidi run and the extent is in the same run. We keep the adjustment
when the mouse pointer moves to a point between C and B. However, when the mouser pointer reaches a point
between letters b and c, the selection extent is placed at ("abcABC", 2). Because the extent is outside of
the bidi run started from the selection base, we restore the original base at this point. Had we not done this,
we'll end up selecting just "c".

While this algorithm is implemented in FrameSelection::setNonDirectionalSelectionIfNeeded, this patch adds
various member functions to RenderedPosition to facilitate abstraction around inline boxes and bidi runs.

Test: editing/selection/select-bidi-run.html

  • editing/FrameSelection.cpp:

(WebCore::adjustEndpointsAtBidiBoundary): Added. Implements the endpoints adjustment algorithm.
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded): Calls adjustEndpointsAtBidiBoundary, and
restores the original base as needed.

  • editing/FrameSelection.h:
  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::prevLeafChild): Added to cache prevLeafChild of the current inline box.
(WebCore::RenderedPosition::nextLeafChild): Ditto for nextLeafChild.
(WebCore::RenderedPosition::isEquivalent): Compares two RenderedPositions considering neighboring inline boxes
so that the rightmost position in a box and the leftmost position in the following box is considered equal.
(WebCore::RenderedPosition::bidiLevelOnLeft): Added. Returns the bidi level of the run on the left. We can't
add a generic bidiLevel to this class because it'll be ambiguous at bidi boundaries.
(WebCore::RenderedPosition::bidiLevelOnRight): Ditto for the run on the right.
(WebCore::RenderedPosition::leftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::rightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun): Returns Position at the left edge of a bidi run
if RenderedPosition is at such a position. Asserts atLeftBoundaryOfBidiRun.
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun): Ditto for the right edge.

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftmostOffsetInBox): Added.
(WebCore::RenderedPosition::atRightmostOffsetInBox): Added.
(WebCore::RenderedPosition::uncachedInlineBox): Added. We can't use a static const variable because gcc thinks
reinterpret_cast<InlineBox*>(1) is not an integral value.
(WebCore::RenderedPosition::RenderedPosition):

  • editing/VisibleSelection.h:

(WebCore::VisibleSelection::visibleBase): Added.
(WebCore::VisibleSelection::visibleExtent): Added.

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

  • editing/selection/select-bidi-run-expected.txt: Added.
  • editing/selection/select-bidi-run.html: Added.
11:00 Changeset [95963] by ossy@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-resize-contents-expected.png: Added after r95897.
  • platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Added after r95897.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Updated after r95897.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated after r95897.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Updated after r95897.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated after r95897.
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.png: Added after r95857.
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt: Added after r95857.
10:52 Changeset [95962] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r95256.
http://trac.webkit.org/changeset/95256
https://bugs.webkit.org/show_bug.cgi?id=68814

Temporary CRASH calls no longer needed (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

10:45 WebKitGTK/Releasing edited by mrobinson@webkit.org
(diff)
10:36 Changeset [95961] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/68809> IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing

If wakeSyncThread is called before syncThreadMainLoop starts executing then m_syncThreadHasWorkToDo would be set
while executing the body of the sync thread loop, causing us to skip blocking on the condition variable. This would
lead to us hitting the assertion failure due to m_disabledSuddenTerminationForSyncThread being false, unless the main
thread happened to call wakeSyncThread a second time while the first loop iteration was executing.

Reviewed by Anders Carlsson.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::syncThreadMainLoop): Clear m_syncThreadHasWorkToDo to indicate that we're about to perform
all pending work.

10:34 Changeset [95960] by simon.fraser@apple.com
  • 3 edits
    12 adds in trunk

Groove/inset/outset borders show solid if the color is black.
https://bugs.webkit.org/show_bug.cgi?id=58608

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-26
Reviewed by Simon Fraser.

Source/WebCore:

Lightened the border side colors when drawing borders with styles as
Outset/Inset/Groove/Ridge.

Tests: fast/borders/border-groove.html

fast/borders/border-inset.html
fast/borders/border-outset.html
fast/borders/border-ridge.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-groove-expected.png: Added.
  • fast/borders/border-groove-expected.txt: Added.
  • fast/borders/border-groove.html: Added.
  • fast/borders/border-inset-expected.png: Added.
  • fast/borders/border-inset-expected.txt: Added.
  • fast/borders/border-inset.html: Added.
  • fast/borders/border-outset-expected.png: Added.
  • fast/borders/border-outset-expected.txt: Added.
  • fast/borders/border-outset.html: Added.
  • fast/borders/border-ridge-expected.png: Added.
  • fast/borders/border-ridge-expected.txt: Added.
  • fast/borders/border-ridge.html: Added.
10:26 April 2011 Meeting/Getting compile time under control edited by scherkus@chromium.org
(diff)
10:13 Changeset [95959] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Delete retired custom font data only on document
destruction, and not on recalc style.
https://bugs.webkit.org/show_bug.cgi?id=68805

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/custom-font-data-crash.html

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

LayoutTests:

  • fast/text/custom-font-data-crash-expected.txt: Added.
  • fast/text/custom-font-data-crash.html: Added.
10:00 Changeset [95958] by rniwa@webkit.org
  • 3 edits in trunk

chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-26
Reviewed by Ryosuke Niwa.

Add missing window.layoutTestController.dumpAsText so that test output matches expectation.

  • LayoutTests/editing/style/justify-without-enclosing-block.xhtml:
09:44 Changeset [95957] by enne@google.com
  • 4 edits
    3 adds in trunk

[chromium] Update VideoLayerChromium textures after texture resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742

Reviewed by James Robinson.

Source/WebCore:

If video textures are reclaimed (such as during a visibility change on
a tab), the dirty rect for the layer is empty and it skips out of
updating compositor resources, leaving the video textures invalid.
Instead, check the textures here to make sure they're still valid
first before early out so that they can get reupdated if necessary.

Additionally, fix a small bug in pushPropertiesTo where 1 plane RGB
videos would not get drawn because all 3 planes didn't have valid
textures.

Test: compositing/video-page-visibility.html

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::texturesValid):

  • platform/graphics/chromium/VideoLayerChromium.h:

LayoutTests:

Without this patch, this video texture is invalid.

  • compositing/video-page-visibility-expected.png: Added.
  • compositing/video-page-visibility-expected.txt: Added.
  • compositing/video-page-visibility.html: Added.
09:31 Changeset [95956] by loislo@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

Web Inspector: generic performance UI test for panel switch.
https://bugs.webkit.org/show_bug.cgi?id=68806

Reviewed by Pavel Feldman.

  • inspector/performance/resources/show-panel-elements.html: Removed.
  • inspector/performance/resources/show-panel-network.html: Removed.
  • inspector/performance/resources/show-panel.html: Added.
08:55 Changeset [95955] by aroben@apple.com
  • 4 edits in trunk/Tools

Clean up code imported from WebKitAPITest

Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
TestWebKitAPI conventions

Reviewed by David Levin.

  • TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros

and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
namespace name.

(TestWebKitAPI::WebViewDestruction::SetUp):
(TestWebKitAPI::WebViewDestruction::webViewCount):
(TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
(TestWebKitAPI::WebViewDestruction::runMessagePump):
(TestWebKitAPI::WebViewDestruction::TearDown):
(TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
Moved functionality from free functions into these new test fixtures.

  • TestWebKitAPI/win/HostWindow.cpp:
  • TestWebKitAPI/win/HostWindow.h:

Prefixed Win32 API calls with ::. Updated namespace name.

08:51 Changeset [95954] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26

  • DEPS:
08:35 WebKitGTKStableReleases edited by mrobinson@webkit.org
(diff)
08:34 WebKitGTKStableReleases created by mrobinson@webkit.org
08:29 Changeset [95953] by pfeldman@chromium.org
  • 2 edits
    1 copy
    1 add in trunk/Source/WebCore

Web Inspector: introduce protocol backwards compatibility validator.
https://bugs.webkit.org/show_bug.cgi?id=68800

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/Inspector.draft-01.json: Copied from Source/WebCore/inspector/Inspector.json.
  • inspector/validate-protocol-compatibility: Added.
08:28 WebKitGTK edited by mrobinson@webkit.org
(diff)
08:27 WebKitGTK edited by mrobinson@webkit.org
(diff)
08:26 WebKitGTK edited by mrobinson@webkit.org
(diff)
08:03 Changeset [95952] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk

Merging http://trac.webkit.org/changeset/95948.

08:01 Changeset [95951] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk

Merging http://trac.webkit.org/changeset/95940.

07:45 Changeset [95950] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68796

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26

  • platform/qt/Skipped:
07:39 Changeset [95949] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26

  • platform/qt/Skipped:
07:37 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:29 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:25 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:24 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:22 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:19 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
07:04 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
06:35 Changeset [95948] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix documentation generation by specifying the sources
directory with $(top_srcdir).

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Xan Lopez.

  • docs/GNUmakefile.am:
06:03 Changeset [95947] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Unused variable in QNetworkReplyHandler::sendNetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=68798

Patch by Andreas Kling <kling@webkit.org> on 2011-09-26
Reviewed by Noam Rosenthal.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendNetworkRequest):

05:52 Changeset [95946] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Second unreviewed build fix for r95941

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):

05:48 Changeset [95945] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for webkit builds after r95941.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):

05:16 Changeset [95944] by aroben@apple.com
  • 5 edits
    3 copies
    2 adds
    1 delete in trunk

Merge WebKitAPITest into TestWebKitAPI

This also means that our formerly-WebKitAPITest tests will be run on the bots!

I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
them more idiomatic in a separate pass.

Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
functionality (and names!)

Reviewed by Anders Carlsson.

Tools:

  • TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
  • TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
  • TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
  • TestWebKitAPI/win/main.cpp:

(main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.

  • WebKitAPITest: Removed this directory and its contents.

Source/WebKit/win:

Remove WebKitAPITest

  • WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which

formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
depended on.

05:15 Changeset [95943] by aroben@apple.com
  • 2 edits in trunk/Tools

Remove two failing WebKitAPITest tests

The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.

Reviewed by Anders Carlsson.

  • WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and

MainFrameAfterClose tests.

05:15 Changeset [95942] by caseq@chromium.org
  • 18 edits
    1 add in trunk

2011-09-26 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI.Console.prototype.get Severity): (injectedExtensionAPI.Panels.prototype.create): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.hasHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.deregisterHandler):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler): (WebInspector.ExtensionServer.prototype._handleAnchorClicked): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._registerExtension):
  • inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createCustomSetting):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: (.help-content select): (.help-content select:disabled): (.help-content option):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector._showAnchorLocation):

2011-09-26 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
05:12 Changeset [95941] by loislo@chromium.org
  • 5 edits
    3 adds in trunk

Web Inspector: Timeline: record root event for the function calls enforced by console eval.
https://bugs.webkit.org/show_bug.cgi?id=68695

In a complex web application developer might want to timeline a specific piece of code.

In this case he can do the next steps:
1) start timeline;
2) eval a command in console;
3) stop timeline.

I think it'd be nice to have a root event for the all the events that happened as the result of such eval.

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-injected-script-eval.html

  • bindings/v8/ScriptFunctionCall.cpp:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):

LayoutTests:

  • inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
  • inspector/timeline/timeline-injected-script-eval.html: Added.
  • platform/chromium/inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
  • platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt:
05:06 Changeset [95940] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

REGRESSION: Empathy crashes when switching theme
https://bugs.webkit.org/show_bug.cgi?id=68600

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_set_scroll_adjustments): use the existing
set{Horizontal,Vertical}Adjustment functions, so the code is not
duplicated
(webkit_web_view_dispose): unset the adjustments during dispose,
to avoid late adjustment change notifications hitting the
adjustment watcher

04:09 WebKitGTK/Releasing edited by carlosgc@webkit.org
(diff)
03:51 Changeset [95939] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebCore

[Texmap][Qt] Enable TextureMapperGL in platforms where BGRA is not present
https://bugs.webkit.org/show_bug.cgi?id=65473

Reviewed by Andreas Kling.

For now, swap RGBA->BGRA in software if we're in OpenGL ES 2.
We do that by iterating on the pixels and manually swapping each pixel's red and blue
values. This can be done faster with shaders, but for now this is a working solution
for platforms without BGRA support.

No new tests. Existing layout tests cover this.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::endPaint):

  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/qt/TextureMapperQt.cpp:

(WebCore::RGBA32PremultimpliedBufferQt::swapRGB):

02:29 WebKitGTK/Releasing edited by carlosgc@webkit.org
Add link to gtk-release-notes script (diff)
02:21 gtk-release-notes attached to WebKitGTK/Releasing by carlosgc@webkit.org
Script to get information about bugs fixed since a given release
02:05 Changeset [95938] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix coding style bits in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68634

Patch by Sergio Villar Senin <svillar@igalia.com> on 2011-09-26
Reviewed by Martin Robinson.

No new tests needed.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

01:48 WebKitGTK edited by carlosgc@webkit.org
Add link to releasing page (diff)
01:43 WebKitGTK/Releasing edited by carlosgc@webkit.org
(diff)
01:37 WebKitGTK/Releasing edited by carlosgc@webkit.org
(diff)
01:36 WebKitGTK/Releasing created by carlosgc@webkit.org
Documentation about how to release WebKitGtk+
00:21 Changeset [95937] by commit-queue@webkit.org
  • 4 edits
    1 copy
    2 adds in trunk

[mac] Timestamp parameter to requestAnimationFrame is busted in USE(REQUEST_ANIMATION_FRAME_TIMER) path
https://bugs.webkit.org/show_bug.cgi?id=68769

Patch by James Robinson <jamesr@chromium.org> on 2011-09-26
Reviewed by Simon Fraser.

Source/WebCore:

Convert the time parameter from double to DOMTimeStamp using convertSecondsToDOMTimeStamp rather than relying on
implicit double->long conversion, which ignores the units of the value.

Test: fast/animation/request-animation-frame-timestamps-advance.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::animationTimerFired):

LayoutTests:

Adds a test that the timestamp parameter to the requestAnimationFrame callback advances between calls.

  • fast/animation/request-animation-frame-timestamps-advance-expected.txt: Added.
  • fast/animation/request-animation-frame-timestamps-advance.html: Added.
  • fast/animation/script-tests/request-animation-frame-timestamps-advance.js: Copied from LayoutTests/fast/animation/script-tests/request-animation-frame-timestamps.js.

(busyWait):
(window.webkitRequestAnimationFrame):

  • fast/animation/script-tests/request-animation-frame-timestamps.js:

Remove the element parameter, they aren't a useful part of the test.

00:05 Changeset [95936] by mhahnenberg@apple.com
  • 84 edits in trunk/Source

Add custom vtable struct to ClassInfo struct
https://bugs.webkit.org/show_bug.cgi?id=68567

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Declared/defined the MethodTable struct and added it to the ClassInfo struct.
Also defined the CREATE_METHOD_TABLE macro to generate these method tables
succinctly where they need to be defined.

Also added to it the first function to use this macro, visitChildren.

This is part of the process of getting rid of all C++ virtual methods in JSCell.
Eventually all virtual functions in JSCell that can't easily be converted to
non-virtual functions will be put into this custom vtable structure.

  • runtime/ClassInfo.h:

Added the CREATE_METHOD_TABLE macro call as the last argument to each of the
ClassInfo structs declared in these classes. This saves us from having to visit
each s_info definition in the future when we add more methods to the MethodTable.

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • JavaScriptCore.exp:
  • runtime/Arguments.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSAPIValueWrapper.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSByteArray.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSString.cpp:
  • runtime/MathObject.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/ScopeChain.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/Structure.cpp:
  • runtime/StructureChain.cpp:

Had to make visitChildren and visitChildrenVirtual protected instead of private
because some of the subclasses of JSWrapperObject need access to JSWrapperObject's
visitChildren function pointer in their vtable since they don't provide their own
implementation. Same for RegExpObject.

  • runtime/JSWrapperObject.h:
  • runtime/RegExpObject.h:

Source/JavaScriptGlue:

Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.

  • UserObjectImp.cpp:

Source/WebCore:

No new tests.

Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.

  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSWorkerContextBase.cpp:

Changed the bindings generator to add the call to the CREATE_METHOD_TABLE macro where
necessary.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bridge/c/CRuntimeObject.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.cpp:
  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.cpp:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:

Source/WebKit/mac:

Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.

  • Plugins/Hosted/ProxyInstance.mm:
  • Plugins/Hosted/ProxyRuntimeObject.mm:

Source/WebKit2:

Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

09/25/11:

23:53 Changeset [95935] by commit-queue@webkit.org
  • 5 edits
    1 move in trunk/Source/WebCore

[EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.
https://bugs.webkit.org/show_bug.cgi?id=63502

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-09-25
Reviewed by Martin Robinson.

The gtk/GtkWidgetBackingStoreCairo.cpp is moved to the cairo/WidgetBackingStoreCairo.cpp and
some codes for EFL are added.
WidgetBackingStoreCairo creates cairo_image_surface and has a role to copy reusable area
when scrolling. So, it will be used in the WebKit2 EFL port's BackingStore.

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • platform/cairo/WidgetBackingStore.h:
  • platform/cairo/WidgetBackingStoreCairo.cpp: Renamed from Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp.

(WebCore::createSurfaceForBackingStore):
(WebCore::WidgetBackingStorePrivate::create):
(WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate):
(WebCore::WidgetBackingStore::create):
(WebCore::WidgetBackingStore::WidgetBackingStore):
(WebCore::WidgetBackingStore::~WidgetBackingStore):
(WebCore::WidgetBackingStore::cairoSurface):
(WebCore::WidgetBackingStore::scroll):

  • platform/gtk/GtkWidgetBackingStoreX11.cpp:
21:13 Changeset [95934] by abarth@webkit.org
  • 19 edits
    59 deletes in trunk

Finish removing PLATFORM(BREWMP) by removing associated code
https://bugs.webkit.org/show_bug.cgi?id=68779

Reviewed by Sam Weinig.

.:

  • Source/cmake/WebKitPackaging.cmake:
  • wscript:

Source/JavaScriptCore:

(WTF::fastMallocSize):

  • wtf/Vector.h:
  • wtf/brew: Removed.
  • wtf/brew/MainThreadBrew.cpp: Removed.
  • wtf/brew/OwnPtrBrew.cpp: Removed.
  • wtf/brew/RefPtrBrew.h: Removed.
  • wtf/brew/ShellBrew.h: Removed.
  • wtf/brew/StringBrew.cpp: Removed.
  • wtf/brew/SystemMallocBrew.h: Removed.
  • wtf/unicode/brew: Removed.
  • wtf/unicode/brew/UnicodeBrew.cpp: Removed.
  • wtf/unicode/brew/UnicodeBrew.h: Removed.

Source/WebCore:

When Geoffrey Garen removed PLATFORM(BREWMP) in
http://trac.webkit.org/changeset/95555, he did not remove all the
associated code. This completes the work started in r95555 by removing
all the code assoicated with PLATFORM(BREWMP).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/js/ScriptControllerBrew.cpp: Removed.
  • editing/brew: Removed.
  • editing/brew/EditorBrew.cpp: Removed.
  • gyp/WebCore.gyp:
  • page/brew: Removed.
  • page/brew/ChromeClientBrew.h: Removed.
  • page/brew/DragControllerBrew.cpp: Removed.
  • page/brew/EventHandlerBrew.cpp: Removed.
  • page/brew/FrameBrew.cpp: Removed.
  • platform/brew: Removed.
  • platform/brew/ClipboardBrew.cpp: Removed.
  • platform/brew/ClipboardBrew.h: Removed.
  • platform/brew/ContextMenuBrew.cpp: Removed.
  • platform/brew/ContextMenuItemBrew.cpp: Removed.
  • platform/brew/CursorBrew.cpp: Removed.
  • platform/brew/DragDataBrew.cpp: Removed.
  • platform/brew/EventLoopBrew.cpp: Removed.
  • platform/brew/FileSystemBrew.cpp: Removed.
  • platform/brew/KURLBrew.cpp: Removed.
  • platform/brew/LanguageBrew.cpp: Removed.
  • platform/brew/LocalizedStringsBrew.cpp: Removed.
  • platform/brew/LoggingBrew.cpp: Removed.
  • platform/brew/MIMETypeRegistryBrew.cpp: Removed.
  • platform/brew/PasteboardBrew.cpp: Removed.
  • platform/brew/PlatformKeyboardEventBrew.cpp: Removed.
  • platform/brew/PlatformMouseEventBrew.cpp: Removed.
  • platform/brew/PlatformTouchEventBrew.cpp: Removed.
  • platform/brew/PlatformTouchPointBrew.cpp: Removed.
  • platform/brew/PopupMenuBrew.cpp: Removed.
  • platform/brew/PopupMenuBrew.h: Removed.
  • platform/brew/SSLKeyGeneratorBrew.cpp: Removed.
  • platform/brew/ScreenBrew.cpp: Removed.
  • platform/brew/ScrollbarThemeBrew.cpp: Removed.
  • platform/brew/ScrollbarThemeBrew.h: Removed.
  • platform/brew/SearchPopupMenuBrew.cpp: Removed.
  • platform/brew/SearchPopupMenuBrew.h: Removed.
  • platform/brew/SharedBufferBrew.cpp: Removed.
  • platform/brew/SharedTimerBrew.cpp: Removed.
  • platform/brew/SoundBrew.cpp: Removed.
  • platform/brew/SystemTimeBrew.cpp: Removed.
  • platform/brew/TemporaryLinkStubs.cpp: Removed.
  • platform/brew/WidgetBrew.cpp: Removed.
  • platform/graphics/brew: Removed.
  • platform/graphics/brew/IconBrew.cpp: Removed.
  • platform/graphics/brew/ImageBrew.cpp: Removed.
  • platform/graphics/brew/IntPointBrew.cpp: Removed.
  • platform/graphics/brew/IntSizeBrew.cpp: Removed.
  • platform/network/brew: Removed.
  • platform/network/brew/DNSBrew.cpp: Removed.
  • platform/network/brew/SocketStreamError.h: Removed.
  • platform/network/brew/SocketStreamHandle.h: Removed.
  • platform/network/brew/SocketStreamHandleBrew.cpp: Removed.
  • platform/network/brew/SocketStreamHandlePrivate.h: Removed.
  • platform/text/brew: Removed.
  • platform/text/brew/TextBoundariesBrew.cpp: Removed.
  • platform/text/brew/TextBreakIteratorBrew.cpp: Removed.
  • platform/text/brew/TextCodecBrew.cpp: Removed.
  • platform/text/brew/TextCodecBrew.h: Removed.

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:

Tools:

  • Scripts/webkitpy/common/config/build.py:
  • waf/build/settings.py:
21:05 Changeset [95933] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT does not count speculation successes correctly
https://bugs.webkit.org/show_bug.cgi?id=68785

Reviewed by Geoffrey Garen.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOperations.cpp:
20:36 Changeset [95932] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG support for op_resolve_global is not enabled
https://bugs.webkit.org/show_bug.cgi?id=68786

Reviewed by Geoffrey Garen.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

20:30 Changeset [95931] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Implement a CloseEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68340

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-25
Reviewed by Oliver Hunt.

Source/WebCore:

The spec of the CloseEvent constructor is here:
http://dev.w3.org/html5/websockets/#closeevent

Test: fast/events/constructors/close-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the CloseEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for CloseEvent.
  • websockets/CloseEvent.h: Added a definition for CloseEventInit.

(WebCore::CloseEventInit::CloseEventInit):
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):

  • websockets/CloseEvent.idl: Makes CloseEvent constructible.

LayoutTests:

  • fast/dom/constructed-objects-prototypes-expected.txt: Now window has CloseEvent.
  • fast/events/constructors/close-event-constructor-expected.txt: Added.
  • fast/events/constructors/close-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped close-event-constructor.html, since V8 does not yet have the CloseEvent constructor.
19:25 Changeset [95930] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

DFG static prediction code is no longer needed and should be removed
https://bugs.webkit.org/show_bug.cgi?id=68784

Reviewed by Oliver Hunt.

This gets rid of static prediction code, and ensures that we do not
try to compile code where dynamic predictions are not available.
This is accomplished by immediately performing an OSR exit wherever
a value is retrieved for which no predictions exist.

This also adds value profiling for this on functions used for calls.

The heuristics for deciding when to optimize code are also tweaked,
since it is now profitable to optimize sooner. This may need to be
tweaked further, but this patch only makes minimal changes.

This results in a 16% speed-up on Kraken/ai-astar, leading to a 3%
overall win on Kraken. It's neutral elsewhere.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • bytecode/PredictedType.cpp:

(JSC::predictionToString):

  • bytecode/PredictedType.h:

(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::mergePredictions):

  • bytecode/PredictionTracker.h:

(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeUpdatedPrediction):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::emitBranch):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::valueOfJSConstantNode):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::predict):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

18:40 Changeset [95929] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/10177824> IconDatabase’s use of ThreadCondition leads to assertion failures in the face of spurious wakeups

It's possible for ThreadCondition::wait to return spuriously without the condition having been signaled.
When that happens we should immediately return to waiting rather than doing our normal work, as some of that
work relies on wakeSyncThread having been called to signal the condition.

Reviewed by Sam Weinig.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Note that we have work for the sync thread to do.
(WebCore::IconDatabase::syncThreadMainLoop): If we were woken with no work to do, immediately
go back to waiting on the condition variable. Otherwise, reset m_syncThreadHasWorkToDo and then
do that work. We also switch to moving m_disabledSuddenTerminationForSyncThread immediately in to
our local shouldReenableSuddenTermination variable since it can be updated by other threads while
we don't hold the lock. This makes it inappropriate to make assumptions about its value after dropping
and reacquiring the lock.

  • loader/icon/IconDatabase.h:
18:12 Changeset [95928] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/Tools

Provides a simple LRU cache class in Python.

https://bugs.webkit.org/show_bug.cgi?id=67823

Patch by Ai Makabi <makabi@google.com> on 2011-09-21
Reviewed by Tony Chang.

  • Scripts/webkitpy/common/lru_cache.py:
  • Scripts/webkitpy/common/lru_cache_unittest.py:
17:01 Changeset [95927] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT Construct opcode takes a this argument even though it's
not passed
https://bugs.webkit.org/show_bug.cgi?id=68782

Reviewed by Oliver Hunt.

This is performance-neutral, mostly. It's a slight speed-up on
v8-splay.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

16:58 Changeset [95926] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/dynamic/subtree-unrooted.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::scheduleRelayout): Replaced the check that the renderer is parented,
which was added in r21162, with a check that it is “rooted”.

LayoutTests:

  • fast/dynamic/subtree-unrooted-expected.txt: Added.
  • fast/dynamic/subtree-unrooted.html: Added.
16:40 Changeset [95925] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG tracking of the value in cachedResultRegister does not handle
op_mov correctly
https://bugs.webkit.org/show_bug.cgi?id=68781

Reviewed by Oliver Hunt.

This takes the simplest approach: it makes the old JIT dumber rather
than making the DFG JIT smarter. This is performance-neutral.

  • jit/JIT.h:

(JSC::JIT::canBeOptimized):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):

14:42 Changeset [95924] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124

Reviewed by Dan Bernstein.

Test: fast/ruby/ruby-base-merge-block-children-crash.html

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren): add a firstChild()
check to prevent empty anonymous block addition, just like
moveBlockChildren method.

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveBlockChildren): This was incorrectly
doing optimizations to see if current ruby base has only inline
children before beforeChild and then trying to take out them from
their parent anonymous blocks. The problem is those inlines could
be split and have continuations because of encountering a block
inside inline flow. In those cases, we cannot take the inline out.
So, we should just make children non-inline in the destination
block and transfer the children as it-is.

  • rendering/RenderRubyBase.h: remove unncessary functions.

LayoutTests: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124

Reviewed by Dan Bernstein.

  • fast/ruby/ruby-base-merge-block-children-crash.html: Added.
  • platform/mac/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
14:15 Changeset [95923] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove fast/workers/storage/interrupt-database.html
from GTK test_expectations since it's been skipped in r95809.

  • platform/gtk/test_expectations.txt:
12:35 Changeset [95922] by abarth@webkit.org
  • 48 edits
    9 deletes in trunk

Remove PLATFORM(HAIKU) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68774

Reviewed by Sam Weinig.

.:

  • Source/cmake/WebKitPackaging.cmake:
  • wscript:

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • JavaScriptCore.gypi:
  • gyp/JavaScriptCore.gyp:
  • heap/MachineStackMarker.cpp:
  • wtf/PageAllocation.h:
  • wtf/Platform.h:
  • wtf/StackBounds.cpp:
  • wtf/haiku: Removed.
  • wtf/haiku/MainThreadHaiku.cpp: Removed.
  • wtf/haiku/StringHaiku.cpp: Removed.
  • wtf/text/WTFString.h:

Source/WebCore:

As discussed on webkit-dev, the Haiku port has been inactive for over a
year. A year and a half ago, we discussed removing the port, but folks
said they planned to work on it more. That work does not appear to
have happened in the intervening time.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/js/ScriptControllerHaiku.cpp: Removed.
  • editing/haiku: Removed.
  • editing/haiku/EditorHaiku.cpp: Removed.
  • gyp/WebCore.gyp:
  • loader/cache/CachedFont.cpp:
  • page/EventHandler.cpp:

(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

  • page/haiku: Removed.
  • page/haiku/DragControllerHaiku.cpp: Removed.
  • page/haiku/EventHandlerHaiku.cpp: Removed.
  • page/haiku/FrameHaiku.cpp: Removed.
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:
  • platform/Widget.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/haiku: Removed.
  • platform/graphics/haiku/ColorHaiku.cpp: Removed.
  • platform/graphics/haiku/FloatPointHaiku.cpp: Removed.
  • platform/graphics/haiku/FloatRectHaiku.cpp: Removed.
  • platform/graphics/haiku/FontCacheHaiku.cpp: Removed.
  • platform/graphics/haiku/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/haiku/FontCustomPlatformData.h: Removed.
  • platform/graphics/haiku/FontHaiku.cpp: Removed.
  • platform/graphics/haiku/FontPlatformData.h: Removed.
  • platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp: Removed.
  • platform/graphics/haiku/GradientHaiku.cpp: Removed.
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: Removed.
  • platform/graphics/haiku/IconHaiku.cpp: Removed.
  • platform/graphics/haiku/ImageBufferDataHaiku.h: Removed.
  • platform/graphics/haiku/ImageBufferHaiku.cpp: Removed.
  • platform/graphics/haiku/ImageHaiku.cpp: Removed.
  • platform/graphics/haiku/IntPointHaiku.cpp: Removed.
  • platform/graphics/haiku/IntRectHaiku.cpp: Removed.
  • platform/graphics/haiku/IntSizeHaiku.cpp: Removed.
  • platform/graphics/haiku/PathHaiku.cpp: Removed.
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: Removed.
  • platform/graphics/haiku/StillImageHaiku.cpp: Removed.
  • platform/graphics/haiku/StillImageHaiku.h: Removed.
  • platform/haiku: Removed.
  • platform/haiku/ClipboardHaiku.cpp: Removed.
  • platform/haiku/ClipboardHaiku.h: Removed.
  • platform/haiku/ContextMenuHaiku.cpp: Removed.
  • platform/haiku/ContextMenuItemHaiku.cpp: Removed.
  • platform/haiku/CookieJarHaiku.cpp: Removed.
  • platform/haiku/CursorHaiku.cpp: Removed.
  • platform/haiku/DragDataHaiku.cpp: Removed.
  • platform/haiku/DragImageHaiku.cpp: Removed.
  • platform/haiku/EventLoopHaiku.cpp: Removed.
  • platform/haiku/FileSystemHaiku.cpp: Removed.
  • platform/haiku/LocalizedStringsHaiku.cpp: Removed.
  • platform/haiku/LoggingHaiku.cpp: Removed.
  • platform/haiku/MIMETypeRegistryHaiku.cpp: Removed.
  • platform/haiku/PasteboardHaiku.cpp: Removed.
  • platform/haiku/PlatformKeyboardEventHaiku.cpp: Removed.
  • platform/haiku/PlatformMouseEventHaiku.cpp: Removed.
  • platform/haiku/PlatformWheelEventHaiku.cpp: Removed.
  • platform/haiku/PopupMenuHaiku.cpp: Removed.
  • platform/haiku/PopupMenuHaiku.h: Removed.
  • platform/haiku/RenderThemeHaiku.cpp: Removed.
  • platform/haiku/RenderThemeHaiku.h: Removed.
  • platform/haiku/ScreenHaiku.cpp: Removed.
  • platform/haiku/ScrollbarThemeHaiku.cpp: Removed.
  • platform/haiku/ScrollbarThemeHaiku.h: Removed.
  • platform/haiku/SearchPopupMenuHaiku.cpp: Removed.
  • platform/haiku/SearchPopupMenuHaiku.h: Removed.
  • platform/haiku/SharedBufferHaiku.cpp: Removed.
  • platform/haiku/SharedTimerHaiku.cpp: Removed.
  • platform/haiku/SoundHaiku.cpp: Removed.
  • platform/haiku/TemporaryLinkStubs.cpp: Removed.
  • platform/haiku/WidgetHaiku.cpp: Removed.
  • platform/image-decoders/haiku: Removed.
  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Removed.
  • platform/text/UnicodeRange.h:
  • platform/text/haiku: Removed.
  • platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Removed.

Source/WebKit:

  • haiku: Removed.
  • haiku/WebCoreSupport: Removed.
  • haiku/WebCoreSupport/ChromeClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/ChromeClientHaiku.h: Removed.
  • haiku/WebCoreSupport/ContextMenuClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/ContextMenuClientHaiku.h: Removed.
  • haiku/WebCoreSupport/DragClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/DragClientHaiku.h: Removed.
  • haiku/WebCoreSupport/EditorClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/EditorClientHaiku.h: Removed.
  • haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Removed.
  • haiku/WebCoreSupport/InspectorClientHaiku.cpp: Removed.
  • haiku/WebCoreSupport/InspectorClientHaiku.h: Removed.

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:

Tools:

  • Scripts/webkitpy/common/config/build.py:
  • waf/build/settings.py:
01:16 Changeset [95921] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk

[CMake] Remove FindLibXlst.cmake
https://bugs.webkit.org/show_bug.cgi?id=68770

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-25
Reviewed by Adam Barth.

This file should have never been committed -- the library it looks for
is called libxslt, not libxlst, so it has never really been used. When
the buildsystem looked for libxslt, it used CMake's own LibXslt.cmake
instead.

  • Source/cmake/FindLibXlst.cmake: Removed.
00:03 Changeset [95920] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempted build fixes for GTK and Qt.

  • GNUmakefile.list.am:
  • WebCore.pro:

09/24/11:

23:04 Changeset [95919] by abarth@webkit.org
  • 126 edits in trunk

Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=68767

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, almost everyone has this enable turned on
and this feature is unlikely to be removed from the web platform given
its popularity.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toDOMApplicationCache):

  • dom/EventTarget.h:
  • features.pri:
  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLHtmlElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):

  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):

  • inspector/generate-inspector-idl:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::handledOnloadEvents):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::applicationCacheHost):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
(WebCore::MainResourceLoader::load):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h:
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:
  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/appcache/ManifestParser.h:
  • loader/chromium/ResourceLoaderChromium.cpp:

(WebCore::ResourceLoader::didDownloadData):

  • page/ChromeClient.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::applicationCache):

  • page/DOMWindow.h:

(WebCore::DOMWindow::optionalApplicationCache):

  • page/DOMWindow.idl:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

  • features.gypi:
  • src/ApplicationCacheHost.cpp:
  • src/ApplicationCacheHostInternal.h:
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::reachedApplicationCacheOriginQuota):

  • src/ChromeClientImpl.h:
  • src/WebDataSourceImpl.cpp:

(WebKit::WebDataSourceImpl::applicationCacheHost):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableApplicationCache):
(WebKit::WebRuntimeFeatures::isApplicationCacheEnabled):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/ChromeClientEfl.h:
  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_cache_directory_path_set):
(ewk_settings_cache_directory_path_get):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitapplicationcache.cpp:

(webkit_application_cache_get_maximum_size):
(webkit_application_cache_set_maximum_size):
(webkit_application_cache_get_database_directory_path):

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Misc/WebCache.mm:

(+[WebCache empty]):

  • WebCoreSupport/WebApplicationCache.mm:
  • WebCoreSupport/WebApplicationCacheQuotaManager.mm:

(-[WebApplicationCacheQuotaManager usage]):
(-[WebApplicationCacheQuotaManager quota]):
(-[WebApplicationCacheQuotaManager setQuota:]):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]):

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • WebView/WebView.mm:

(WebKitInitializeApplicationCachePathIfNecessary):

Source/WebKit/qt:

  • Api/qwebsecurityorigin.cpp:

(QWebSecurityOrigin::setApplicationCacheQuota):

  • Api/qwebsettings.cpp:

(QWebSettings::setOfflineWebApplicationCachePath):
(QWebSettings::offlineWebApplicationCachePath):
(QWebSettings::setOfflineWebApplicationCacheQuota):
(QWebSettings::offlineWebApplicationCacheQuota):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::clearAllApplicationCaches):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearApplicationCache):

  • WebProcess/WebProcess.h:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
19:20 Changeset [95918] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT implementation of put_by_val increments m_length instead of setting
it to index+1
https://bugs.webkit.org/show_bug.cgi?id=68766

Reviewed by Geoffrey Garen.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

15:53 Changeset [95917] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More build fixage.

  • heap/ConservativeRoots.cpp: Our system of #includes, it is chaos.
15:39 Changeset [95916] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

The DFG should not attempt to guess types in the absence of value
profiles
https://bugs.webkit.org/show_bug.cgi?id=68677

Reviewed by Oliver Hunt.

This adds the ForceOSRExit node, which is ignored by the propagator
and virtual register allocator (and hence ensuring that liveness analysis
works correctly), but forces terminateSpeculativeExecution() in the
back-end. This appears to be a slight speed-up on benchmark averages,
with ~5% swings on individual benchmarks, in both directions. But it's
never a regression on any average, and appears to be a ~1% progression
in the SunSpider average.

This also adds a bit better debugging support in the old JIT and in DFG,
as this was necessary to debug the much more frequent OSR transitions
that occur with this change.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
15:38 Changeset [95915] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Remove Chromium failing expectations for WCSS tests now that they're
been removed with r95911.

  • platform/chromium/test_expectations.txt:
15:36 Changeset [95914] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some Windows build fixage.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive): Show the compiler that all control paths
return a value. There, there, compiler. Everything's going to be OK.

  • runtime/JSCell.h:

(JSC::JSCell::setVPtr): Oops! Unrename this function.

15:35 Changeset [95913] by mihaip@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Mark an svg/ test as slow, and remove incorrect baselines for another.

  • platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:15 Changeset [95912] by ggaren@apple.com
  • 15 edits in trunk

Allocate new objects unmarked
https://bugs.webkit.org/show_bug.cgi?id=68764

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This is a pre-requisite to using the mark bit to determine object age.

~2% v8 speedup, mostly due to a 12% v8-splay speedup.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive):
(JSC::MarkedBlock::isLiveCell): These two functions are the reason for
this patch. They can now determine object liveness without relying on
newly allocated objects having their mark bits set. Each MarkedBlock
now has a state variable that tells us how to determine whether its
cells are live. (This new state variable supercedes the old one about
destructor state. The rest of this patch is just refactoring to support
the invariants of this new state variable without introducing a
performance regression.)

(JSC::MarkedBlock::didConsumeFreeList): New function for updating interal
state when a block becomes fully allocated.

(JSC::MarkedBlock::clearMarks): Folded a state change to 'Marked' into
this function because, logically, clearing all mark bits is the first
step in saying "mark bits now exactly reflect object liveness".

(JSC::MarkedBlock::markCountIsZero): Renamed from isEmpty() to clarify
that this function only tells you about the mark bits, so it's only
meaningful if you've put the mark bits into a meaningful state before
calling it.

(JSC::MarkedBlock::forEachCell): Changed to use isLive() helper function
instead of testing mark bits, since mark bits are not always the right
way to find out if an object is live anymore. (New objects are live, but
not marked.)

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock): Folded all initialization -- even
initialization when recycling an old block -- into the MarkedBlock
constructor, for simplicity.

(JSC::MarkedBlock::callDestructor): Inlined for speed. Always check for
a zapped cell before running a destructor, and always zap after
running a destructor. This does not seem to be expensive, and the
alternative just creates a too-confusing matrix of possible cell states
((zombie undestructed cell + zombie destructed cell + zapped destructed
cell) * 5! permutations for progressing through block states = "Oh my!").

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep): Maintained and expanded a pre-existing
optimization to use template specialization to constant fold lots of
branches and elide certain operations entirely during a sweep. Merged
four or five functions that were logically about sweeping into this one
function pair, so there's only one way to do things now, it's
automatically correct, and it's always fast.

(JSC::MarkedBlock::zapFreeList): Renamed this function to be more explicit
about exactly what it does, and to honor the new block state system.

  • heap/AllocationSpace.cpp:

(JSC::AllocationSpace::allocateBlock): Updated for rename.

(JSC::AllocationSpace::freeBlocks): Updated for changed interface.

(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue): Just like isEmpty() above, renamed
to clarify that this functor only tests the mark bits, so it's only
valid if you've put the mark bits into a meaningful state before
calling it.

(JSC::AllocationSpace::shrink): Updated for rename.

  • heap/AllocationSpace.h:

(JSC::AllocationSpace::canonicalizeCellLivenessData): Renamed to be a
little more specific about what we're making canonical.

(JSC::AllocationSpace::forEachCell): Updated for rename.

(JSC::AllocationSpace::forEachBlock): No need to canonicalize cell
liveness data before iterating blocks -- clients that want iterated
blocks to have valid cell lieveness data should make this call for
themselves. (And not all clients want it.)

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer): Updated for rename. Removed
obsolete comment.

  • heap/Heap.cpp:

(JSC::CountFunctor::ClearMarks::operator()): Removed call to notify...()
because clearMarks() now does that implicitly.

(JSC::Heap::destroy): Make sure to canonicalize before tear-down, since
tear-down tests cell liveness when running destructors.

(JSC::Heap::markRoots):
(JSC::Heap::collect): Moved weak reference harvesting out of markRoots()
and into collect, since it strictly depends on root marking, and does
not contribute to root marking.

(JSC::Heap::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell): No need to canonicalize cell liveness
data before iterating protected cells, since we know they're all live,
and don't need to test for it.

  • heap/Local.h:

(JSC::::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock): Updated for interface change.
(JSC::MarkedSpace::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::zapFreeList): Simplified this allocator
functionality a bit. We now track only one block -- "currentBlock" --
and rely on its internal state to know whether it has more cells to
allocate.

  • heap/Weak.h:

(JSC::Weak::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.

  • runtime/JSCell.h:

(JSC::JSCell::vptr):
(JSC::JSCell::zap):
(JSC::JSCell::isZapped):
(JSC::isZapped): Made zapping a property of JSCell, for a little abstraction.
In the future, exactly how a JSCell zaps itself will change, as the
internal representation of JSCell changes.

LayoutTests:

Reviewed by Oliver Hunt.

Made this flaky test less flaky. (Just enough to make my patch not fail.)

  • fast/dom/gc-10.html: Count objects immediately after GC to get an

exact count. Call 'reload' a few times to improve test coverage. Preload
properties in case they're lazily instantiated, which would change
object count numbers. Also, use the 'var' keyword like a good little
JavaScripter.

15:03 Changeset [95911] by abarth@webkit.org
  • 24 edits
    6 deletes in trunk

Remove ENABLE(WCSS) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68759

Reviewed by Darin Adler.

.:

  • configure.ac:

Source/WebCore:

As discussed on webkit-dev, we are removing this feature from trunk to
reduce the number of different configurations.

  • CodeGenerators.pri:
  • GNUmakefile.am:
  • WebCore.pro:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/WCSSPropertyNames.in: Removed.
  • css/WCSSValueKeywords.in: Removed.
  • features.pri:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • html/HTMLInputElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue):
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

Tools:

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:

(hasFeature):

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

LayoutTests:

  • fast/wcss: Removed.
  • fast/wcss/wap-input-format-expected.txt: Removed.
  • fast/wcss/wap-input-format.xhtml: Removed.
  • fast/wcss/wap-input-required-expected.txt: Removed.
  • fast/wcss/wap-input-required.xhtml: Removed.
14:23 Changeset [95910] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT should not eagerly initialize integer tags in the register file
https://bugs.webkit.org/show_bug.cgi?id=68763

Reviewed by Oliver Hunt.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

12:13 Changeset [95909] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added Snow Leopard-specific expected results.

  • platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
02:58 Changeset [95908] by alex@webkit.org
  • 2 edits in trunk/Tools

2011-09-24 Alejandro G. Castro <alex@igalia.com>

Fixed GTK compilation after r95878, the operator== was defined
twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
01:17 Changeset [95907] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

SVGAnimation does not support 'values' for from-to animations
https://bugs.webkit.org/show_bug.cgi?id=64859

Patch by Young Han Lee <joybro@company100.net> on 2011-09-24
Reviewed by Dirk Schulze.

If from-to animation have discrete calc-mode and have a 'keyTimes' list, values of
the keyTimes indicate the begin and the end of the animation respectively.[1][2]

When keyTimes is given, calculate the progress percentage of the animation with it
even for from-to animation.

[1] http://www.w3.org/TR/SVG/animate.html#ValueAttributes
[2] http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncValues

Source/WebCore:

Test: svg/animations/animate-from-to-keyTimes.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentForFromTo):
(WebCore::SVGAnimationElement::updateAnimation):

  • svg/SVGAnimationElement.h:

LayoutTests:

  • svg/animations/animate-from-to-keyTimes-expected.txt: Added.
  • svg/animations/animate-from-to-keyTimes.html: Added.
  • svg/animations/script-tests/animate-from-to-keyTimes.js: Added.

(sample1):
(sample2):
(executeTest):

00:00 Changeset [95906] by cfleizach@apple.com
  • 5 edits in trunk

WebKit does not expose AXPlaceholder value on password fields
https://bugs.webkit.org/show_bug.cgi?id=68745

Reviewed by Oliver Hunt.

Source/WebCore:

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:

09/23/11:

22:42 Changeset [95905] by barraclough@apple.com
  • 3 edits in trunk

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

Add cmake options to enable DFG JIT compilation for EFL port

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:
22:30 Changeset [95904] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[DRT] Include the right config file for EFL's DRT.
https://bugs.webkit.org/show_bug.cgi?id=67042

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Martin Robinson.

Ports which use CMake as their buildsystem (such as the EFL one) also
have config.h files, but they are named differently, so include the
right one depending on the buildsystem being used.

  • DumpRenderTree/config.h:
22:11 Changeset [95903] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck): Get rid of the exit-time destructor.

22:04 Changeset [95902] by barraclough@apple.com
  • 21 edits
    4 adds in trunk/Source/JavaScriptCore

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

This is the initial attempt to add JSVALUE32_64 support to DFG JIT.
It's tested on IA32 Linux EFL port currently. It still cannot run
all the test cases and benchmarks so should be turned off now.

The major work includes:
1) dealing with JSVALUE32_64 data format in DFG JIT;
2) bindings between 64-bit JS Value and 32-bit registers;
3) handling of function calls. Currently for DFG operation function
calls we follow the X86 cdecl calling convention on Linux, and the
implementation is in a naive way by pushing the arguments into stack
one by one.

The known issues include:
1) some code duplicates unnecessarily, especially in Speculative JIT
code generation, where most of the operations on SpeculataInteger /
SpeculateDouble should be identical to the JSVALUE64 code. Refactoring
is needed in the future;
2) lack of op_call and op_construct support, comparing to current
JSVALUE64 DFG;
3) currently integer speculations assume to be StrictInt32;
4) lack of JSBoolean speculations;
5) boxing and unboxing doubles could be improved;
6) DFG X86 register description is different with the baseline JIT,
the timeoutCheckRegister is used for general purpose usage;
7) calls to runtime functions with primitive double parameters (e.g.
fmod) don't work. Support needs to be added to the assembler to
implement the mechanism of passing double parameters for X86 cdecl
convention.

And there should be many other hidden bugs which should be exposed and
resolved in later debugging process.

  • CMakeListsEfl.txt:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::storeDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movsd_rm):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::tagGPR):
(JSC::DFG::GenerationInfo::payloadGPR):
(JSC::DFG::GenerationInfo::fpr):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillDouble):

  • dfg/DFGJITCodeGenerator.cpp:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::registersMatched):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::addressOfDoubleConstant):
(JSC::DFG::integerResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::setupResults):
(JSC::DFG::callOperation):
(JSC::JSValueOperand::JSValueOperand):
(JSC::JSValueOperand::~JSValueOperand):
(JSC::JSValueOperand::isDouble):
(JSC::JSValueOperand::fill):
(JSC::JSValueOperand::tagGPR):
(JSC::JSValueOperand::payloadGPR):
(JSC::JSValueOperand::fpr):
(JSC::GPRTemporary::~GPRTemporary):
(JSC::GPRTemporary::gpr):
(JSC::GPRResult2::GPRResult2):

  • dfg/DFGJITCodeGenerator32_64.cpp: Added.

(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::isStrictInt32):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
(JSC::DFG::JITCodeGenerator::emitCall):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::dataFormatString):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::tagForGlobalVar):
(JSC::DFG::JITCompiler::payloadForGlobalVar):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

  • dfg/DFGJITCompiler32_64.cpp: Added.

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
(JSC::DFG::JITCompiler::jitAssertIsCell):
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):

  • dfg/DFGJITCompilerInlineMethods.h: Added.

(JSC::DFG::JITCompiler::emitLoadTag):
(JSC::DFG::JITCompiler::emitLoadPayload):
(JSC::DFG::JITCompiler::emitLoad):
(JSC::DFG::JITCompiler::emitLoad2):
(JSC::DFG::JITCompiler::emitLoadDouble):
(JSC::DFG::JITCompiler::emitLoadInt32ToDouble):
(JSC::DFG::JITCompiler::emitStore):
(JSC::DFG::JITCompiler::emitStoreInt32):
(JSC::DFG::JITCompiler::emitStoreCell):
(JSC::DFG::JITCompiler::emitStoreBool):
(JSC::DFG::JITCompiler::emitStoreDouble):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inPair):
(JSC::DFG::ValueRecovery::tagGPR):
(JSC::DFG::ValueRecovery::payloadGPR):

  • dfg/DFGSpeculativeJIT32_64.cpp: Added.

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • runtime/JSValue.h:
21:23 Changeset [95901] by darin@apple.com
  • 6034 edits in trunk/Source

Set eol-style to native on many source files where it was unset.

20:51 Changeset [95900] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Canvas security checks show up on HTML5GamingTest benchmark
https://bugs.webkit.org/show_bug.cgi?id=68743

Reviewed by Oliver Hunt.

Prior to this patch, the canvas security checks took as much as 4% of
the time on the HTML5GamingTest benchmark:

http://craftymind.com/factory/guimark2/HTML5GamingTest.html

This patch uses a couple of AtomicStrings and shuffles around the order
of the security check to take this down to around 0.1% (which is near
the noise floor of what I can measure with my profiler).

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

20:24 Changeset [95899] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebCore: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
Return early without throwing an exception if source rectangle is out of
bounds to match the spec.

LayoutTests: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect is out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

  • fast/canvas/drawImage-with-invalid-args-expected.txt:
  • fast/canvas/drawImage-with-invalid-args.html:

This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions

  • platform/chromium/test_expectations.txt:

Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail

  • platform/mac/Skipped:

Skipping canvas/philip/tests/2d.drawImage.outsidesource.html

20:20 Changeset [95898] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Printing of notImplemented() when logging enabled.
https://bugs.webkit.org/show_bug.cgi?id=64590

Printing of notImplemented() method was enabled on Debug builds only.
Now it is enabled when logging is enabled.

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-09-23
Reviewed by Oliver Hunt.

No new tests because there is no new functionality.

  • platform/NotImplemented.h: Non-debug mode replaced with non-logging mode.
20:12 Changeset [95897] by mihaip@chromium.org
  • 3 edits
    2 adds in trunk

[Chromium] REGRESSION (r95725): Resizing a window doesn't resize the contents
https://bugs.webkit.org/show_bug.cgi?id=68730

Reviewed by James Robinson.

Source/WebCore:

Adds a missing contentsResized() call in ScrollView::setFrameRect.

Test: fast/dom/Window/window-resize-contents.html

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

LayoutTests:

Test for resizing of the window triggering resizing of contents.

  • fast/dom/Window/window-resize-contents-expected.txt: Added.
  • fast/dom/Window/window-resize-contents.html: Added.
20:12 Changeset [95896] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Detect amd64 as a valid 64-bit architecture.
https://bugs.webkit.org/show_bug.cgi?id=67481

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Oliver Hunt.

Some operating systems (generally the BSDs) use amd64 instead of x86_64
to report they're running on 64 bits, so consider it a valid value.

  • Source/CMakeLists.txt:
19:07 Changeset [95895] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

wtf/BitVector.h has a variety of bugs which manifest when the
vector grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746

Reviewed by Oliver Hunt.

Out-of-lined slow path code in BitVector so that not every user
of CodeBlock ends up having to compile it. Fixed a variety of
index computation and size computation bugs.

I have not seen these issues manifest themselves, but they are
blocking a patch that uses BitVector more aggressively.

(BitVector::BitVector):
(BitVector::operator=):
(BitVector::resize):
(BitVector::clearAll):
(BitVector::OutOfLineBits::create):
(BitVector::OutOfLineBits::destroy):
(BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(WTF::BitVector::ensureSize):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::byteCount):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::outOfLineBits):

  • wtf/CMakeLists.txt:
  • wtf/wtf.pri:
18:25 Changeset [95894] by adamk@chromium.org
  • 18 edits in trunk

Add ENABLE_MUTATION_OBSERVERS feature flag
https://bugs.webkit.org/show_bug.cgi?id=68732

Reviewed by Ojan Vafai.

This flag will guard an implementation of the "Mutation Observers" proposed in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
18:19 Changeset [95893] by mhahnenberg@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651

Reviewed by Oliver Hunt.

Added a new JSType to check whether or not something is a
NumberObject (which includes NumberPrototype) in TypeInfo::isNumberObject because there's not
currently a better way to determine whether something is indeed a NumberObject.
Also de-virtualized JSCell::getJSNumber, having it check the TypeInfo
for whether the object is a NumberObject or not. This patch is part of
the larger process of de-virtualizing JSCell.

(JSC::JSCell::getJSNumber):

  • runtime/JSCell.h:

(JSC::JSValue::getJSNumber):

  • runtime/JSType.h:
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::isNumberObject):

  • runtime/JSValue.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::getJSNumber):

  • runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

18:12 Changeset [95892] by mihaip@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Rebaseline fast/ruby/ruby-text-before-after-content.html for Chromium Mac.

Mark media/controls-right-click-on-timebar.html as flaky.

  • platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:44 Changeset [95891] by jcivelli@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Making some WebBlob methods exportable.
This is needed by the shared lib chromium build.
https://bugs.webkit.org/show_bug.cgi?id=68709

Reviewed by Darin Fisher.

  • public/WebBlob.h:
17:23 Changeset [95890] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

.: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

  • Source/autotools/symbols.filter:

Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

Tests: fast/dom/scroll-element-to-rect-centered.html

fast/dom/scroll-element-to-rect.html

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):

  • page/FrameView.h:
  • testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

  • public/WebView.h:

(WebKit::WebView::scrollFocusedNodeIntoRect):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

  • fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
  • fast/dom/scroll-element-to-rect-centered.html: Added.
  • fast/dom/scroll-element-to-rect-expected.txt: Added.
  • fast/dom/scroll-element-to-rect.html: Added.
17:07 Changeset [95889] by mihaip@chromium.org
  • 7 edits in trunk/Source

Unreviewed, rolling out r95860.
http://trac.webkit.org/changeset/95860
https://bugs.webkit.org/show_bug.cgi?id=68648

Breaks overhang rendering on Chromium Mac

Source/WebCore:

  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromium.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

Source/WebKit/chromium:

  • features.gypi:
16:43 Changeset [95888] by dino@apple.com
  • 10 edits
    6 adds in trunk

Add -webkit-filter to CSSPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=68675

Reviewed by Simon Fraser.

Add property and rudimentary parsing for -webkit-filter. The
property value isn't preserved anywhere yet. Add
stub definition for computed style.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilter):

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

New test for rudimentary parsing of -webkit-filter.
Since currently only the Apple port enables the
feature, add this new test to the platform skip lists
for GTK, QT and Chromium.

  • css3/filters/filter-property-expected.txt: Added.
  • css3/filters/filter-property.html: Added.
  • css3/filters/script-tests/TEMPLATE.html: Added.
  • css3/filters/script-tests/filter-property.js: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
16:28 Changeset [95887] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723

Reviewed by Oliver Hunt.

This adds value profiling to all forms of op_resolve in the
old JIT, and patches that information into the DFG along with
performing the appropriate type propagation.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasPrediction):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):

  • jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

16:25 Changeset [95886] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove preserves3D() from CCLayerDelegate, replacing it by setting the
value explicitly after creating a layer, or setting its delegate.
https://bugs.webkit.org/show_bug.cgi?id=68295

Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Covered by compositing/ layeout tests.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setPreserves3D):
(WebCore::LayerChromium::preserves3D):

16:24 Changeset [95885] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
Reviewed by Tony Chang.

Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.

  • editing/style/justify-without-enclosing-block-expected.txt: Added.
  • editing/style/justify-without-enclosing-block.xhtml: Added.
16:19 Changeset [95884] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

16:17 Changeset [95883] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note flaky test.

  • platform/chromium/test_expectations.txt:
16:16 Changeset [95882] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

16:14 Changeset [95881] by mrowe@apple.com
  • 1 copy in tags/Safari-535.4

New tag.

16:12 Changeset [95880] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add a few more possiblities to the test cases for xss denial.
https://bugs.webkit.org/show_bug.cgi?id=47120

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-23
Reviewed by Adam Barth.

  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Added.
  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces.html: Added.
16:11 Changeset [95879] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Implicit conversion double to float in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68722

Reviewed by Simon Fraser.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
conversions.

16:02 Changeset [95878] by commit-queue@webkit.org
  • 13 edits in trunk

[WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68556

Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.

Source/WebKit2:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

  • Shared/API/c/WKGeometry.h:

(operator==):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"

Tools:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButton):
(WTR::getModifiers):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::postEvent):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

  • platform/qt-wk2/Skipped:
15:59 Changeset [95877] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

  • parser/JSParser.cpp:

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

  • parser/SourceProviderCacheItem.h:

LayoutTests: gh@apple.com>

Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

  • fast/js/nested-functions-expected.txt: Added.
  • fast/js/nested-functions.html: Added.
  • fast/js/script-tests/nested-functions.js: Added.

(runTests.test1):
(runTests.test2):
(runTests.test3):
(runTests):

15:58 Changeset [95876] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=68724

Reviewed by Oliver Hunt.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

15:47 Changeset [95875] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Make the layout test script's kill timeout proportional to --time-out-ms
https://bugs.webkit.org/show_bug.cgi?id=68026

Patch by Lei Zhang <thestig@chromium.org> on 2011-09-23
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:45 Changeset [95874] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
https://bugs.webkit.org/show_bug.cgi?id=68737

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/combining-character-sequence-fallback-crash.html

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
number of FontData instances in the fallback list rather than the number of font families in the
font description.

LayoutTests:

  • fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
  • fast/text/combining-character-sequence-fallback-crash.html: Added.
15:44 Changeset [95873] by adamk@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove WEBWIDGET_HAS_ANIMATE_CHANGES #define
https://bugs.webkit.org/show_bug.cgi?id=68720

Reviewed by James Robinson.

References to this macro were removed in http://crrev.com/102314.

  • public/WebWidget.h:
15:41 Changeset [95872] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

15:34 Changeset [95871] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Crash in WebCore::DatabaseObserver
https://bugs.webkit.org/show_bug.cgi?id=67805

Patch by Stephen Chenney <schenney@chromium.org> on 2011-09-23
Reviewed by David Levin.

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::canEstablishDatabase): Added a check for a
null frame or page, and return false if null. Investigated
changing the fall-through return value to false but decided against
it given the way the code is used and existing default values for
related code. Reproduction and testing depends on having a document
with no frame or no page, which sometimes happens in practice but is
hard to construct explicitly.

15:28 Changeset [95870] by commit-queue@webkit.org
  • 10 edits
    4 adds
    1 delete in trunk

[Chromium] Fix CSS 3D corner anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=68087

Patch by David Reveman <reveman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Source/WebCore:

Render sharp corners more correctly by adding bounding box
edges to anti-aliasing shaders.

Test: platform/chromium/compositing/3d-corners.html

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

LayoutTests:

Add a test to check sharp corner rendering of CSS 3D transformed
elements.

  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium/compositing/3d-corners-expected.txt: Added.
  • platform/chromium/compositing/3d-corners.html: Added.
  • platform/chromium/test_expectations.txt:
15:22 Changeset [95869] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Add failing expectations for tests added by r95852.

  • platform/chromium/test_expectations.txt:
15:13 Changeset [95868] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG implementation of PutScopedVar corrupts register allocation
https://bugs.webkit.org/show_bug.cgi?id=68735

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-23
Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:10 Changeset [95867] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

Updating now-passing Layout test.

Rubber stamped by geoff garen

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
15:08 Changeset [95866] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8037003

15:05 Changeset [95865] by oliver@apple.com
  • 17 edits
    2 adds in trunk/Source

Make write barriers actually do something when enabled
https://bugs.webkit.org/show_bug.cgi?id=68717

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a basic card marking style write barrier to JSC (currently
turned off). This requires two scratch registers in the JIT
so there was some register re-arranging to satisfy that requirement.
Happily this produced a minor perf bump in sunspider (~0.5%).

Turning the barriers on causes an overall regression of around 1.5%

(JSC::MacroAssemblerX86Common::store8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movb_i8m):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotCell):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::markCellCard):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/CardSet.h: Added.

(JSC::CardSet::CardSet):
(JSC::::cardForAtom):
(JSC::::cardMarkedForAtom):
(JSC::::markCardForAtom):

  • heap/Heap.cpp:
  • heap/Heap.h:

(JSC::Heap::addressOfCardFor):
(JSC::Heap::writeBarrierFastCase):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
(JSC::MarkedBlock::offsetOfCards):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header, and fix an evaluation ordering
issue that shows up if you try to use write barriers.

  • ForwardingHeaders/heap/CardSet.h: Added.
  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

14:59 Changeset [95864] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=68077
SH4 assemblers doesn't refer to executable memory handle.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-23
Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branch8):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::executableCopy):

14:51 Changeset [95863] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

Avoid updating compositing state during paint
https://bugs.webkit.org/show_bug.cgi?id=68727

Reviewed by Simon Fraser.

We shouldn't update our compositing state in the middle of a paint. The call to
updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderLayerCompositor.h:
14:51 Changeset [95862] by inferno@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r95857.

  • platform/chromium-linux/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
14:48 Changeset [95861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.

Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

14:39 Changeset [95860] by fsamuel@chromium.org
  • 7 edits in trunk/Source

Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
https://bugs.webkit.org/show_bug.cgi?id=68648

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests because there's no change in functionality (yet).

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::paintOverhangAreas):

  • platform/chromium/ScrollbarThemeChromium.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):

Source/WebKit/chromium:

  • features.gypi:
14:35 Changeset [95859] by ojan@chromium.org
  • 8 edits in trunk

remove physical flex-flow values to match the updated spec
https://bugs.webkit.org/show_bug.cgi?id=68728

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
14:31 Changeset [95858] by aroben@apple.com
  • 1 copy in tags/Safari-535.3.1-Win

New tag

14:01 Changeset [95857] by inferno@chromium.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

Test: fast/ruby/ruby-text-before-after-content.html

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::updateBeforeAfterContent):

  • rendering/RenderRubyText.h:

LayoutTests: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

  • fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • fast/ruby/ruby-text-before-after-content-expected.txt: Added.
  • fast/ruby/ruby-text-before-after-content.html: Added.
13:32 Changeset [95856] by ojan@chromium.org
  • 5 edits in trunk/Source/WebCore

refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665

Reviewed by Tony Chang.

This is just a refactor. Just move the all the code that needs to
be flow aware into helper functions. Actually making them flow-aware
can be done in a followup patch.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:

Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:
13:25 Changeset [95855] by hyatt@apple.com
  • 7 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68719

Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
columns, when regions have a non-uniform height, we may need to push through multiple regions
in order to find one that fits.

Added an optimization for quickly noticing if regions do have a uniform height so that we can
treat them like columns and pages if so.

Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
the new tests.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::matchedEndLine):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

  • rendering/RenderFlowThread.h:

LayoutTests:

  • fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
  • fast/regions/webkit-flow-float-unable-to-push.html: Added.
  • platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
13:21 Changeset [95854] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721

Reviewed by Anders Carlsson.

Another assertion fix.

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):

13:11 Changeset [95853] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move WebHitTestResult files to Shared/ in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=68718

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
12:56 Changeset [95852] by jchaffraix@webkit.org
  • 10 edits
    47 adds in trunk

Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
Reviewed by David Hyatt.

Source/WebCore:

Move CollapsedBorderValues into RenderTable.h.
Calculate collapsed borders only once and re-use during paintObject().
Invalidate cache when cell, row, row group, col, col group or table border is changed.

Tests: fast/table/border-collapsing/cached-cell-append.html

fast/table/border-collapsing/cached-cell-remove.html
fast/table/border-collapsing/cached-change-cell-border-color.html
fast/table/border-collapsing/cached-change-cell-border-width.html
fast/table/border-collapsing/cached-change-col-border-color.html
fast/table/border-collapsing/cached-change-col-border-width.html
fast/table/border-collapsing/cached-change-colgroup-border-color.html
fast/table/border-collapsing/cached-change-colgroup-border-width.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-row-border-width.html
fast/table/border-collapsing/cached-change-table-border-color.html
fast/table/border-collapsing/cached-change-table-border-width.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
(WebCore::RenderTable::layout): Invalidate cache if layout changed.
(WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
(WebCore::RenderTable::paintObject): Use cached collapsed borders.

  • rendering/RenderTable.h:

(WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
(WebCore::RenderTable::currentBorderValue): Rename to use word "value".

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.

Rename to use word "value".
(WebCore::addBorderStyle):
(WebCore::RenderTableCell::collectBorderValues):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::sortBorderValues):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/RenderTableCell.h:

If border changed, invalidate cache.

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):

LayoutTests:

Tests for invalidating collapsed borders cache.

  • fast/table/border-collapsing/cached-cell-append-expected.png: Added.
  • fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
  • fast/table/border-collapsing/cached-cell-append.html: Added.
  • fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
  • fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
  • fast/table/border-collapsing/cached-cell-remove.html: Added.
  • fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
  • fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-col-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-col-border-width.html: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
  • fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-row-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-row-border-width.html: Added.
  • fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-table-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-table-border-width.html: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
12:48 Changeset [95851] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716

Reviewed by Darin Adler.

Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:46 Changeset [95850] by mihaip@chromium.org
  • 5 edits in trunk

update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698

Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).

Also updates layout_test code to work with that change.

Patch by Elliot Poger <epoger@google.com> on 2011-09-23
Reviewed by Mihai Parparita.

Source/WebKit/chromium:

  • DEPS:

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
12:40 Changeset [95849] by mhahnenberg@apple.com
  • 81 edits in trunk

Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404

Reviewed by Darin Adler.

.:

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

  • Source/autotools/symbols.filter:

Source/JavaScriptCore:

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):

(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):

  • debugger/DebuggerActivation.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):

  • runtime/Arguments.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):

  • runtime/Executable.h:
  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):

  • runtime/GetterSetter.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):

  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):

  • runtime/JSArray.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.h:

(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):

  • runtime/JSObject.h:

(JSC::JSObject::visitChildrenDirect):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):

  • runtime/JSWrapperObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):

  • runtime/NativeErrorConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):

  • runtime/RegExpObject.h:
  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):

  • runtime/ScopeChain.h:
  • runtime/Structure.cpp:

(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:
  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):

  • runtime/StructureChain.h:

Source/JavaScriptGlue:

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

  • UserObjectImp.cpp:

(UserObjectImp::visitChildrenVirtual):
(UserObjectImp::visitChildren):

  • UserObjectImp.h:

Source/WebCore:

No new tests.

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

  • WebCore.exp.in:
  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):

  • bridge/qt/qt_runtime.h:
  • workers/WorkerContext.h:
12:31 Changeset [95848] by andersca@apple.com
  • 3 edits
    1 delete in trunk/Source/WebKit

Axe WebImageRendererFactory
https://bugs.webkit.org/show_bug.cgi?id=68715

Reviewed by Darin Adler.

../..:

Remove WebImageRendererFactory.m from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

../../mac:

Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.

  • WebCoreSupport/WebImageRendererFactory.m: Removed.
12:24 Changeset [95847] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit

Add OVERRIDE to a bunch of virtual member functions on clients
https://bugs.webkit.org/show_bug.cgi?id=68712

Reviewed by Sam Weinig.

../..:

  • WebKit.xcodeproj/project.pbxproj:

../../mac:

  • Configurations/Base.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebDeviceOrientationClient.h:
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebGeolocationClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebPlatformStrategies.h:
12:19 Changeset [95846] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713

Reviewed by Sam Weinig.

This was causing assertion failures.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:19 Changeset [95845] by jochen@chromium.org
  • 17 edits
    4 copies in trunk/LayoutTests

Clarify wording in cross origin XSL tests and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=68683

The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.

Reviewed by Alexey Proskuryakov.

  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED.html:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
  • platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/wk2/Skipped:
12:17 Changeset [95844] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make sure to define OVERRIDE and FINAL for older builds of clang.

  • wtf/Compiler.h:
12:07 Changeset [95843] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Mark two more tests as flaky.

  • platform/chromium/test_expectations.txt:
12:07 Changeset [95842] by loislo@chromium.org
  • 2 edits
    4 copies in branches/chromium/874

Merge 95410 - Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
  • inspector/timeline/timeline-dom-content-loaded-event.html: Added.
  • inspector/timeline/timeline-load-event-expected.txt: Added.
  • inspector/timeline/timeline-load-event.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8021012

11:57 Changeset [95841] by loislo@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/inspector/front-end

Merge 95401 - Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8018012

11:52 Changeset [95840] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704

Reviewed by Oliver Hunt.

This is performance neutral, but increases coverage.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:51 Changeset [95839] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove extra space at the beginning of the last line.
https://bugs.webkit.org/show_bug.cgi?id=68710

Reviewed by Gustavo Noronha Silva.

  • platform/network/soup/SocketStreamHandleSoup.cpp:
11:41 Changeset [95838] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flaky.

  • platform/chromium/test_expectations.txt:
11:24 Changeset [95837] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-09-23 Mario Sanchez Prada <msanchez@igalia.com>

[GTK] Fix coding style issues in ResourceRequestSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68707

Reviewed by Xan Lopez.

This patch fixes some issues as reported by check-webkit-style.

  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
11:18 Changeset [95836] by mrobinson@webkit.org
  • 1370 edits
    476 copies
    30 deletes in releases/WebKitGTK/webkit-1.6

Updating WebKitGTK+ branch to to the state of the 1.5.90 release

11:15 Changeset [95835] by mihaip@chromium.org
  • 1 edit in branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php

Merge 95322 - http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

  • http/tests/history/back-with-fragment-change.php:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8018010

11:07 Changeset [95834] by andersca@apple.com
  • 18 edits in trunk/Source/WebKit2

Add OVERRIDE to overrides of virtual member functions in client classes
https://bugs.webkit.org/show_bug.cgi?id=68702

Reviewed by Darin Adler.

Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
they have been removed from their respective base classes.

  • Configurations/Base.xcconfig:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • win/WebKit2Common.vsprops:
10:46 Changeset [95833] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.

  • wtf/Platform.h:
10:46 Changeset [95832] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix the build.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside

the WTF namespace.

10:38 Changeset [95831] by ademar.reis@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit

Include MSVC2010 in the list of compilers where incremental
build is disabled (INCREMENTAL:NO).

Change suggested by Simo Falt <simo.falt@nokia.com>, already present
in the Qt-4.8 repository where the problem was identified.

  • WebCore.pri:
10:11 Changeset [95830] by jamesr@google.com
  • 2 edits in branches/chromium/874/Source/WebCore

Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558

Reviewed by Stephen White.

The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8020006

10:04 Changeset [95829] by inferno@chromium.org
  • 11 edits in branches/chromium/874

Merge 94582 - Style not propagated to anonymous boxes and anonymous
inline-blocks.
BUG=95520
Review URL: http://codereview.chromium.org/8017007

10:03 Changeset [95828] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Normalize test names.

  • inspector/performance/resources/first-open-elements.html:
  • inspector/performance/resources/first-open-resources.html:
10:01 Changeset [95827] by inferno@chromium.org
  • 5 edits
    4 copies in branches/chromium/874/LayoutTests/platform

Merge 95696 - Unreviewed. Chromium rebaselines for r95671.
BUG=95520
Review URL: http://codereview.chromium.org/8018006

09:59 Changeset [95826] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix warning seen in some 32-bit builds.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance):
Use an explicit cast for the conversion from a double to a LayoutUnit.

09:59 Changeset [95825] by inferno@chromium.org
  • 15 copies in branches/chromium/874/LayoutTests/platform

Merge 95477 - Unreviewed. Chromium Rebaselines for r95461.
BUG=95520
Review URL: http://codereview.chromium.org/8015011

09:57 Changeset [95824] by inferno@chromium.org
  • 14 edits
    3 copies in branches/chromium/874

Merge 95671 - Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
BUG=95520
Review URL: http://codereview.chromium.org/8016006

09:49 Changeset [95823] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654

Reviewed by David Hyatt.

Add OVERRIDE and FINAL macros for compilers that support them.

  • wtf/Compiler.h:
09:47 Changeset [95822] by yael.aharon@nokia.com
  • 1 edit
    1 move in trunk/LayoutTests

Fix typo in file name from http://trac.webkit.org/changeset/95813.

Unreviewed.

  • platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
  • platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
09:45 Changeset [95821] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore/dom

Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8002029

09:43 Changeset [95820] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/dom/Document.cpp

Merge 95497
BUG=95639
Review URL: http://codereview.chromium.org/8016005

09:41 Changeset [95819] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95059 - Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
BUG=95639
Review URL: http://codereview.chromium.org/8018005

09:39 Changeset [95818] by yael.aharon@nokia.com
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

  • platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
  • platform/mac/media/video-playing-and-pause-expected.txt: Added.
09:38 Changeset [95817] by inferno@chromium.org
  • 15 copies in branches/chromium/874/LayoutTests/fast/table

Merge 95461 - Child not placed correctly when beforeChild (table part)
BUG=95520
Review URL: http://codereview.chromium.org/8008019

09:31 Changeset [95816] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8015009

09:26 Changeset [95815] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/874

Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8020005

09:20 Changeset [95814] by inferno@chromium.org
  • 6 edits
    2 copies in branches/chromium/874

Merge 95489 - [V8] document.all gets confused about its prototype chain
BUG=96885
Review URL: http://codereview.chromium.org/8015008

09:19 Changeset [95813] by yael.aharon@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

  • platform/gtk/media/video-playing-and-pause-actual.txt: Added.
09:17 Changeset [95812] by inferno@chromium.org
  • 2 edits
    3 copies in branches/chromium/874

Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8002026

09:14 Changeset [95811] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8015007

09:13 Changeset [95810] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8016003

09:10 Changeset [95809] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Skip crashing test fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=68700

Unreviewed.

  • platform/gtk/Skipped:
09:09 Changeset [95808] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/874

Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8015006

08:57 Changeset [95807] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Clicking on error doesn't point on the correct line if user searched something
https://bugs.webkit.org/show_bug.cgi?id=68627

Reviewed by Yury Semikhatsky.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):

  • inspector/front-end/inspector.js:

(WebInspector._showAnchorLocationInPanel):

08:48 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
08:22 Changeset [95806] by vsevik@chromium.org
  • 4 edits
    6 adds in trunk

Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
https://bugs.webkit.org/show_bug.cgi?id=68631

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/styles/styles-redirected-css.html

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):

  • http/tests/inspector/styles/resources/styles-redirected-css.css: Added.

(div):

  • http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
  • http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
  • http/tests/inspector/styles/styles-redirected-css.html: Added.
08:08 Changeset [95805] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: XHRs requests with the same url as main resource should have correct category.
https://bugs.webkit.org/show_bug.cgi?id=68646

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

LayoutTests:

  • http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.
08:06 Changeset [95804] by jesus@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
https://bugs.webkit.org/show_bug.cgi?id=68696

Reviewed by Andreas Kling.

Instead of connecting signals and calling QtFileDownloader::onReadyRead()
on its constructor, QtFileDownloader will now handle this in start().

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):

  • WebProcess/Downloads/qt/QtFileDownloader.cpp:

(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::start):

  • WebProcess/Downloads/qt/QtFileDownloader.h:
07:59 Changeset [95803] by pfeldman@chromium.org
  • 2 edits
    3 copies in branches/chromium/874

Merge 95083 - Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

  • inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
  • inspector/debugger/debugger-pause-in-internal.html: Added.
  • inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
  • platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8017006

07:58 Changeset [95802] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update expectation for pservers-grad-14-b.svg on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=68697

Unreviewed rebaseline.

  • platform/chromium/test_expectations.txt:
07:35 Changeset [95801] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
https://bugs.webkit.org/show_bug.cgi?id=68657

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

  • inspector/front-end/inspector.js:

(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):

07:14 Changeset [95800] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Gtk] Title attribute is not respected on option elements.
https://bugs.webkit.org/show_bug.cgi?id=68615

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
Reviewed by Martin Robinson.

Set tooltip on PopupMenuGtk items created from GtkActions.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()

to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text

from client when creating a GtkAction.

07:03 Changeset [95799] by yael.aharon@nokia.com
  • 4 edits
    3 adds in trunk

[Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
https://bugs.webkit.org/show_bug.cgi?id=68589

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-playing-and-pause.html

As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
in MediaPlayerGstreamerPrivate::paused().

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::paused):

LayoutTests:

  • media/video-playing-and-pause.html: Added.
  • media/video-paint-test.js:
  • platform/qt/media/video-playing-and-pause-expected.txt: Added.
  • platform/qt/media/video-playing-and-pause-expected.png: Added.
06:48 Changeset [95798] by bulach@chromium.org
  • 1 edit
    2 moves
    4 adds
    2 deletes in trunk/LayoutTests

[chromium, gtk, qt] Rebaseline following r95726
https://bugs.webkit.org/show_bug.cgi?id=68694

Unreviewed rebaseline.

  • css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt.
  • css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt.
  • platform/chromium/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
06:17 Changeset [95797] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144

Source/WebCore:

Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFile.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
06:04 Changeset [95796] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Rebaseline following r95745, r95725

Unreviewed rebaseline.

  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
05:43 Changeset [95795] by bulach@chromium.org
  • 7 edits in trunk/LayoutTests

[chromium] Rebaseline following r95745, r95725
https://bugs.webkit.org/show_bug.cgi?id=68685

Unreviewed rebaseline.

  • platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/chromium/test_expectations.txt:
05:06 Changeset [95794] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

04:43 Changeset [95793] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r95383.
http://trac.webkit.org/changeset/95383
https://bugs.webkit.org/show_bug.cgi?id=68690

It broke WebInspector.Timeline.LoadFromFile feature.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

03:59 Changeset [95792] by loislo@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Web Inspector: UI performance test for Scripts panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68541

The test's body has dummy scripts section copied from inspector-test.jss

Reviewed by Yury Semikhatsky.

  • inspector/performance/resources/first-open-scripts.html:
03:56 Changeset [95791] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555

Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Event listeners can outlive the tref element that created them when
the tref is cloned and then garbage collected, causing a dangling pointer to the
tref. To fix this do not install event listener until the tref is inserted into the document.

Test: svg/custom/tref-clone-crash.html

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):
(WebCore::SVGTRefElement::insertedIntoDocument):

  • svg/SVGTRefElement.h:

LayoutTests:

Test that cloned tref does not cause a crash.

  • svg/custom/tref-clone-crash-expected.txt: Added.
  • svg/custom/tref-clone-crash.html: Added.
03:46 Changeset [95790] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
https://bugs.webkit.org/show_bug.cgi?id=68291

Reviewed by Tony Chang.

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

03:35 Changeset [95789] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

Crash on editing/pasteboard/drag-drop-input-in-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68686

Unreviewed, skip crashing test.

  • platform/gtk/Skipped:
02:19 Changeset [95788] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

plugins/mouse-click-iframe-to-plugin.html should not use flash plugin
https://bugs.webkit.org/show_bug.cgi?id=68601

Use the test plugin that we always have.

  • platform/qt-wk2/Skipped: Unskip the test.
  • plugins/mouse-click-iframe-to-plugin.html:
00:18 Changeset [95787] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

Source/JavaScriptCore: GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

LayoutTests: [Qt] Unreviewed gardening, update expected file after r95745.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2011-09-22

  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

09/22/11:

23:59 Changeset [95786] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676

Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

22:58 Changeset [95785] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected file after r95745.

  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
22:53 Changeset [95784] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r95764, update expected fail to expected pass.

  • ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
21:54 Changeset [95783] by tony@chromium.org
  • 5 edits
    3 adds in trunk

implement -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=67432

Reviewed by Ojan Vafai.

Source/WebCore:

flex-order can be an int (including negative), but we disallow the two
smallest values so we can put the numbers into a hash set.

Also, create two iterators: one that goes in render tree order (we use
this for the first pass and to collect the possible flex order values)
and one that goes in flex order.

Test: css3/flexbox/flex-order.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::FlexOrderHashTraits::emptyValue):
(WebCore::FlexOrderHashTraits::constructDeletedValue):
(WebCore::FlexOrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator

that goes in render tree order.

(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
(WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that

goes in flex-order order. Creating this involves sorting, so only create it once
and pass it around.

(WebCore::RenderFlexibleBox::FlexOrderIterator::first):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-order-expected.png: Added.
  • css3/flexbox/flex-order-expected.txt: Added.
  • css3/flexbox/flex-order.html: Added.
21:10 Changeset [95782] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68667

Reviewed by Simon Fraser.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
AffineTransform::yScale instead of the custom code here that seems to do
the same thing.

21:00 Changeset [95781] by dpranke@chromium.org
  • 2 edits in trunk/Tools

enable NRWT for run-webkit-tests on Lion
https://bugs.webkit.org/show_bug.cgi?id=68673

Reviewed by Eric Seidel.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

20:35 Changeset [95780] by commit-queue@webkit.org
  • 50 edits in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 6
https://bugs.webkit.org/show_bug.cgi?id=68671

Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/chromium-linux/tables/mozilla/marvin/: 9 changes
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/: 14 changes
  • platform/chromium-linux/transforms/svg-vs-css-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/: 9 changes
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/: 14 changes
  • platform/chromium-win/transforms/svg-vs-css-expected.png:
  • platform/chromium/test_expectations.txt:
20:27 Changeset [95779] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PPC build fix, part 3.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForConstructInternal):

20:21 Changeset [95778] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unneeded type conversion from background bleed code
https://bugs.webkit.org/show_bug.cgi?id=68669

Reviewed by Geoffrey Garen.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
and eliminate superflous conversion to float and use of FloatSize. Also added
a "why" comment.

20:00 Changeset [95777] by darin@apple.com
  • 6 edits in trunk/Source/WebCore

Refactor checks for antialiasing lines to share a single function
https://bugs.webkit.org/show_bug.cgi?id=68666

Reviewed by Dan Bernstein.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.

  • rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorder): Ditto.

19:41 Changeset [95776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297

Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.

No functional change, no new test needed.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:
19:40 Changeset [95775] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Adding testTracks() function to video-test.js
https://bugs.webkit.org/show_bug.cgi?id=68643

Reviewed by Eric Carlson.

  • media/video-test.js:

(testTracks):

19:28 Changeset [95774] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Make XSSAuditor extract meaningful snippet from script blocks for comparison
against the URL when checking for reflection. Avoids getting caugh up in
trailing comments.
https://bugs.webkit.org/show_bug.cgi?id=68094

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html

http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::extractCodeFragment):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.
19:27 Changeset [95773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] TouchWebView load test not running
https://bugs.webkit.org/show_bug.cgi?id=68620

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-22
Reviewed by Chang Shu.

Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
19:16 Changeset [95772] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Another PPC build fix.

  • runtime/Executable.cpp:
  • runtime/Executable.h:
18:56 Changeset [95771] by commit-queue@webkit.org
  • 55 edits
    2 moves
    1 add in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 5
https://bugs.webkit.org/show_bug.cgi?id=68608

Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/chromium-linux/css2.1/: 14 changes
  • platform/chromium-linux/editing/execCommand/5138441-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-linux/fast/: 9 changes
  • platform/chromium-win/css2.1/: 14 changes
  • platform/chromium-win/editing/execCommand/5138441-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-win/fast/: 10 changes
  • platform/chromium/test_expectations.txt:
  • platform/win-xp/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt.
  • platform/win/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
18:42 Changeset [95770] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

Add unit test for existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67080

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-22
Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.

(operator<<):
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):

18:33 WebKit Team edited by dino@apple.com
Moving me around (diff)
18:33 AddingFeatures created by dino@apple.com
Figured it was worth documenting how to add a feature
18:29 Changeset [95769] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Updated expectations and filed WK68674.

  • platform/chromium/test_expectations.txt:
18:21 WikiStart edited by dino@apple.com
Adding link to new ENABLE page (diff)
18:12 Changeset [95768] by japhet@chromium.org
  • 16 edits in trunk/Source/WebCore

Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
Instead, add a load-specific policy for showing the user authentication
challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

For resource types that always send a challenge to the embedder,
this patch doesn't change anything. For those that don't, we will
always try to continue without credentials when they are forbidden
and the platform supports it.
When continuing without credentials was initially implemented in
DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
then canceled the SubresourceLoader. This was necessary because of the
quirks of ThreadableLoader cancellation (we sever the client/loader connections
before the load actually cancels), but a simple didFail() should suffice at
the ResourceLoader layer.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconLoader.cpp: The ResourceLoader implementation of

didReceiveAuthenticationChallege means that IconLoader will now
try to continue with credentials on platforms that support it,
rather than just canceling outright. We still will never prompt
for authentication for icons.

  • loader/icon/IconLoader.h:
17:43 Changeset [95767] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Use ewk_view to navigate in history instead of ewk_history.
https://bugs.webkit.org/show_bug.cgi?id=68455

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.

BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.

This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(BackForwardItem::invoke):

17:38 Changeset [95766] by dino@apple.com
  • 13 edits in trunk

Add ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=68652

Reviewed by Simon Fraser.

  • Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
  • Source/WebCore/Configurations/FeatureDefines.xcconfig:
  • Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
  • Source/WebKit2/Configurations/FeatureDefines.xcconfig:
  • WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
  • WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
  • Tools/Scripts/build-webkit:
17:02 Changeset [95765] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make sure to update scrollbars in ScrollView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=68663

Reviewed by Sam Weinig.

Call updateScrollbars after setting the frame rect. This was previously done by the
call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
completely in http://trac.webkit.org/changeset/95725.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

16:57 Changeset [95764] by barraclough@apple.com
  • 5 edits in trunk

Function.prototype.bind.length shoudl be 1.

Rubber stamped by Olier Hunt.

Source/JavaScriptCore:

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

LayoutTests:

  • fast/js/function-bind-expected.txt:
  • fast/js/script-tests/function-bind.js:
16:24 Changeset [95763] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PPC build fix.

  • bytecode/CodeBlock.h:
16:22 Changeset [95762] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 2

16:05 Changeset [95761] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 1

15:58 Changeset [95760] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac]Unreviewed gardening.

New Qt specific results were added by r95723, but they fail on Qt-Mac platform

  • platform/qt-mac/Skipped: Skip css3/selectors3 tests.
15:49 Changeset [95759] by simon.fraser@apple.com
  • 11 edits
    1 copy
    1 add in trunk/Source/WebKit2

Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644

Reviewed by Sam Weinig.

Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.

Make some inline helper methods to create WKSize, WKPoint and WKRect
types.

  • GNUmakefile.am:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.

(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):

  • Shared/API/c/WKGeometry.h:

(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):

  • Shared/API/c/WKSharedAPICast.h:
  • Shared/APIObject.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebGeometry.h: Added.

(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2API.pri:
  • win/WebKit2.vcproj:
15:42 Changeset [95758] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582

Reviewed by Darin Adler.

This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.

When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::scratchBufferForSize):

15:35 Changeset [95757] by jonlee@apple.com
  • 4 edits in trunk/Source/WebCore

Progress control gets cropped on the bottom
https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/10069915>

Reviewed by Kent Tamura.

As it turns out the smaller control type does not get rendered either, so this patch
fixes both.

  • manual-tests/dom/progressbar.html: Altered to show both sizes of controls
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect

(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.

15:28 Changeset [95756] by hyatt@apple.com
  • 5 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68658

Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

  • rendering/RenderBlock.h:

Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.

(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.

LayoutTests:

  • fast/regions/webkit-flow-inlines-dynamic.html: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
15:13 Changeset [95755] by andersca@apple.com
  • 2 edits in trunk/Tools

EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
https://bugs.webkit.org/show_bug.cgi?id=68660

Reviewed by Adam Barth.

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseUp):

15:02 Changeset [95754] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597

Reviewed by Darin Adler.

This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).

This is a 4% win on Kraken and a 1% loss on V8.

  • bytecode/CodeBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):

14:55 Changeset [95753] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653

Reviewed by Gavin Barraclough.

Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

14:43 Changeset [95752] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that need new baselines.

  • platform/mac/Skipped:
14:22 Changeset [95751] by barraclough@apple.com
  • 58 edits
    5 adds in trunk

Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • jsc.cpp:

(GlobalObject::addFunction):

  • runtime/CommonIdentifiers.h:
  • runtime/ConstructData.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::NativeExecutable):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):

  • runtime/FunctionPrototype.h:
  • runtime/JSBoundFunction.cpp: Added.

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h: Added.

(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundFunctionStructure):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

Source/WebCore:

Test: fast/js/function-bind.html

  • bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

  • Function::create no longer requires functionStructure() to be passed.

LayoutTests:

We now pass Function.bind tests.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/function-bind-expected.txt: Added.
  • fast/js/function-bind.html: Added.
  • fast/js/mozilla/strict/15.3.4.5-expected.txt:
  • fast/js/script-tests/function-bind.js: Added.
  • ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
13:50 Changeset [95750] by hyatt@apple.com
  • 11 edits
    1 add
    1 delete in trunk

https://bugs.webkit.org/show_bug.cgi?id=68650

Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.

Reviewed by Sam Weinig.

Source/WebCore:

Covered by existing fast/regions tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.

(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.

(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.

(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.

(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.

(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.

(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.

LayoutTests:

  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
13:37 Changeset [95749] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570

Reviewed by Darin Adler.

These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.

This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):

  • rendering/RenderWidget.cpp:

Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

12:59 Changeset [95748] by rniwa@webkit.org
  • 48 edits in branches/chromium/874

Revert 93001 - Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/execCommand/16049-expected.txt:
  • editing/execCommand/5685604-1.html:
  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/query-font-size-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-expected.txt:
  • editing/execCommand/script-tests/remove-format-multiple-elements.js:
  • editing/execCommand/script-tests/toggle-text-decorations.js:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/execCommand/toggle-text-decorations-expected.txt:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/pasteboard/paste-text-with-style-2-expected.txt:
  • editing/style/apply-font-size-to-multiple-nodes-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/highlight-insert-paragraph-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/invalid-font-size-expected.txt:
  • editing/style/push-down-font-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-font-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-win/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/editing/inserting/5994480-2-expected.txt:

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/7973008

12:41 Changeset [95747] by ap@apple.com
  • 8 edits in trunk/Source/WebKit2

[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573

Reviewed by Anders Carlsson.

Re-landing with a slightly less aggressive check.

12:38 Changeset [95746] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Platform-specific results for test introduced by r95726

  • platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
12:25 Changeset [95745] by rniwa@webkit.org
  • 10 edits
    17 deletes in trunk

Unreviewed, rolling out r95335 and r95645.
http://trac.webkit.org/changeset/95335
http://trac.webkit.org/changeset/95645
https://bugs.webkit.org/show_bug.cgi?id=68649

Wrong fix (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22

Source/WebCore:

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleAddedByNode):

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

  • editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-address.html: Removed.
  • editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
  • editing/deleting/merge-paragraph-from-h6.html: Removed.
  • editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-listing.html: Removed.
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
  • editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
  • editing/deleting/merge-paragraph-into-h1.html: Removed.
  • editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-pre.html: Removed.
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
12:14 Changeset [95744] by robert@webkit.org
  • 7 edits in trunk/LayoutTests

Unreviewed, update expected results after r95726

  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
12:12 QtWebKitSecurity edited by ademar.reis@openbossa.org
(diff)
12:11 QtWebKitSecurity edited by ademar.reis@openbossa.org
(diff)
12:11 QtWebKitSecurity edited by ademar.reis@openbossa.org
(diff)
11:55 Changeset [95743] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):

  • rendering/RenderWidget.cpp:
11:51 Changeset [95742] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640

Reviewed by Gavin Barraclough.

Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:31 Changeset [95741] by hyatt@apple.com
  • 1 edit
    24 adds
    11 deletes in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=68645

Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.

Reviewed by Beth Dakin.

  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
  • fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • fast/regions/render-region-renderer-expected.txt: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/mac/fast/regions/no-split-line-box-expected.png: Added.
  • platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
11:12 Changeset [95740] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=68638

Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.

Reviewed by Dan Bernstein and Adam Roben.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

  • rendering/RenderFlowThread.h:
11:03 Changeset [95739] by nduca@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore

Merge 94587 - [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621

CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

TBR=nduca@chromium.org
Review URL: http://codereview.chromium.org/7995010

11:02 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
11:02 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:01 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:01 Changeset [95738] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=68639

Reviewed by David Hyatt.

FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):

  • page/FrameView.h:
10:56 QtWebKitPackaging edited by ademar.reis@openbossa.org
(diff)
10:54 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
10:54 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
10:53 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
10:52 Changeset [95737] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix (fixes warning about too many parens).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

10:51 Changeset [95736] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Widget::frameRect shouldn't be virtual
https://bugs.webkit.org/show_bug.cgi?id=68637

Reviewed by Sam Weinig.

Nobody overrides Widget::frameRect and nobody should.

  • platform/Widget.h:
10:48 Changeset [95735] by aroben@apple.com
  • 1 edit
    1 delete in trunk/Tools

Remove FindSafari

It isn't used or built anymore.

Fixes <http://webkit.org/b/68628>

Reviewed by Darin Adler.

  • FindSafari: Removed this directory and its contents.
10:48 Changeset [95734] by aroben@apple.com
  • 7 edits in trunk

Remove FindSafari from all our .sln files

It isn't used anymore, so there's no point in building it.

Part of <http://webkit.org/b/68628> Remove FindSafari

Reviewed by Steve Falkenburg.

Source/JavaScriptCore:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.

Tools:

  • DumpRenderTree/DumpRenderTree.sln:
  • WebKitTestRunner/WebKitTestRunner.sln:
10:47 Changeset [95733] by aroben@apple.com
  • 3 edits
    1 delete in trunk/Tools

Remove all uses of FindSafari

It isn't really needed anymore.

Fixes <http://webkit.org/b/68626>.

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
  • Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of

WebKit, but now we use WebKit.exe for that.

  • Scripts/webkitdirs.pm:

(installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
do the same thing.

(readRegistryString):
(writeRegistryString):
Moved here from old-run-webkit-tests.

10:47 Changeset [95732] by aroben@apple.com
  • 2 edits in trunk/Tools

Use the "direct object" form of system() to run WebKit.exe

This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.

Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari):

10:46 Changeset [95731] by aroben@apple.com
  • 2 edits in trunk/Tools

Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath

Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
spaces in the path to the WebKit source tree

Reviewed by John Sullivan.

  • Scripts/webkitdirs.pm:

(setupCygwinEnv):

10:46 Changeset [95730] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit/win

Add testRegExp.vcproj to WebKit.sln

Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj

Reviewed by Brian Weinstein.

  • WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it

does when built as part of JavaScriptCore.sln.

10:40 Changeset [95729] by vestbo@webkit.org
  • 23 edits in trunk

[Qt] Use same DPI for application font as rest of app in DRT and WTR

QApplication will initialize the default application font based
on the application DPI at construction time, but we then override
the application DPI using QX11Info (hard-coding it to 96 for
consistency). This hard-coding is not reflected in the application
font, so we explicitly have update the font ourselves.

The 6 test results that are updated were originally produced with
a DPI of 75, as this is the default fallback DPI when a QFont is
constructed before QApplication. This was wrong, and the results
are updated to match a DPI of 96.

Reviewed by Csaba Osztrogonác.

10:36 Changeset [95728] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
https://bugs.webkit.org/show_bug.cgi?id=68630

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/canvas/webgl/shader-deleted-by-accessor.html

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getAttachedShaders):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

  • fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
  • fast/canvas/webgl/shader-deleted-by-accessor.html: Added.
10:30 Changeset [95727] by robert@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, platform-specific results for r95721.

  • platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.
10:16 Changeset [95726] by robert@webkit.org
  • 9 edits
    11 moves
    3 adds
    11 deletes in trunk

CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
https://bugs.webkit.org/show_bug.cgi?id=47148

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startAlignedOffsetForLine):

Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html

  • rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):

  • The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the containing block's direction) when computing static distance. The container block's direction is still used in the other width and offset related calculations.
  • In the context of this function, the logicalRight value is just an element that will be used later to calculate the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft() in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get logicalLeft in computePositionedLogicalWidthUsing().

(WebCore::RenderBox::computePositionedLogicalWidth):

  • Update comments and use the container block's direction except when calculating the static distance.
  • Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):

  • Update comments and use the container block's direction except when calculating the static distance.

(WebCore::RenderBox::computePositionedLogicalHeight):

  • Update comments.

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

  • Update comments and use the container block's direction except when calculating the static distance.
  • If the containing block is RTL, always assume that values are over-constrained.

(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • Update comments.

LayoutTests:

  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: New results for CSS 2.1 reference tests. These match exactly the reference test results.
  • fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
  • platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added. New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.
  • fast/block/positioning/absolute-position-direction-strict.html: Removed.
  • fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
  • platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed. These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.
10:09 Changeset [95725] by andersca@apple.com
  • 16 edits in trunk/Source

Get rid of Widget::setBoundsSize
https://bugs.webkit.org/show_bug.cgi?id=68491

Reviewed by Sam Weinig.

This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.

Source/WebCore:

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/FrameView.cpp:

(WebCore::FrameView::create):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/Widget.cpp:
  • platform/Widget.h:

(WebCore::Widget::resize):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::refresh):

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::visibleContentRect):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):

  • rendering/RenderWidget.h:

Source/WebKit/mac:

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

  • WebView/WebFrameView.mm:
09:33 Changeset [95724] by hyatt@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=68590

Floats pushed to next page, column or region don't reposition properly if the amount of
available logical width at the new position changes. Refactor the code so that we can
run the float placement algorithm again when this happens.

Source/WebCore:

Covered by an existing regions test that exposes the issue.

Reviewed by Adam Roben.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:

LayoutTests:

Reviewed by Adam Roben.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
09:31 Changeset [95723] by ossy@webkit.org
  • 2 edits
    1532 adds in trunk/LayoutTests

[Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests.
All of them pass, they are compared to mac png results manually.

  • platform/qt/Skipped:
  • platform/qt/css3/selectors3/ [...]: Added.
09:18 Changeset [95722] by leandrogracia@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Fire TextInput events on speech input, but not set/add any inputMethod attribute.
https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

Introduce code to dispatch TextInput events when text is introduced via
the speech input feature. Handle also the cases where speech input is
started programmatically from the LayoutTestController.

Test: fast/speech/input-ontextinput-event.html

  • dom/TextEventInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests: Testing text events triggered by speech input.
https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

  • fast/speech/input-ontextinput-event-expected.txt: Added.
  • fast/speech/input-ontextinput-event.html: Added.
  • fast/speech/input-text-speechstart.html:
09:14 Changeset [95721] by robert@webkit.org
  • 3 edits
    5 adds in trunk

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.

CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793

Patch by Jason Liu <jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <robert@webkit.org>

Source/WebCore:

Test: fast/css/outline-narrowLine.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

  • fast/css/outline-narrowLine.html: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.png: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
09:08 Changeset [95720] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK]Popup drop-down menu contains extra empty spaces at beginning and
occupies whole screen when items in popup reaches the height of display device.
https://bugs.webkit.org/show_bug.cgi?id=68533

When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.

08:42 Changeset [95719] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22

  • DEPS:
07:48 Changeset [95718] by bulach@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[chromium] Rebaseline following r95715
https://bugs.webkit.org/show_bug.cgi?id=68619

Unreviewed, rebaseline.

  • platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
  • platform/chromium-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • platform/chromium-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
06:54 Changeset [95717] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Define export symbol correctly due to rename of pageScaleFactor to
frameScaleFactor.

Not reviewed. Build fix.

  • WebCore.exp.in:
06:43 Changeset [95716] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.wasShown):
(WebInspector.ConsoleView.prototype.storeScrollPositions):
(WebInspector.ConsoleView.prototype.restoreScrollPositions):
(WebInspector.ConsoleView.prototype.onResize):
(WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
(WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/inspector.js:

(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):

06:30 Changeset [95715] by hclam@chromium.org
  • 11 edits
    12 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

The following things are done in this patch:

  1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
  2. Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
  3. scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.

Tests: fast/events/scale-and-scroll-body.html

fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/Frame.cpp:

(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is

main frame, otherwise 1.0

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.

(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.

Reviewed by Simon Fraser.

Add tests to cover the following cases:

  1. Scale and scroll window
  2. Scale and scroll document.body
  3. Scale and scroll iframe's contentWindow
  4. Scale and scroll iframe's contentDocument.body
  • fast/events/scale-and-scroll-body-expected.png: Added.
  • fast/events/scale-and-scroll-body-expected.txt: Added.
  • fast/events/scale-and-scroll-body.html: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-body.html: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-window.html: Added.
  • fast/events/scale-and-scroll-window-expected.png: Added.
  • fast/events/scale-and-scroll-window-expected.txt: Added.
  • fast/events/scale-and-scroll-window.html: Added.
06:25 Changeset [95714] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666

Patch by Andreas Kling <kling@webkit.org> on 2011-09-22
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/getComputedStyle/computed-style-font.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
This function will always return a CSSValueList, as opposed to the previous
implementation which would return a CSSPrimitiveValue if there was only one family.
getCSSPropertyValue() will return the first element of the list for 1-element lists
to preserve the current behavior of getPropertyCSSValue('font-family').

(WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
(WebCore::fontSizeFromStyle): Ditto.
(WebCore::fontStyleFromStyle): Ditto.
(WebCore::fontVariantFromStyle): Ditto.
(WebCore::fontWeightFromStyle): Ditto.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
implementation of the computed 'font' property (CSSPropertyFont.)

LayoutTests:

  • fast/css/getComputedStyle/computed-style-font-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font.html: Added.
  • fast/css/getComputedStyle/script-tests/computed-style-font.js: Added.

(computedFont):
(computedFontCSSValue):

06:05 Changeset [95713] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Remove useless empty WebKit namespace.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-22
Reviewed by Xan Lopez.

  • webkit/webkitglobals.cpp:

(webkitInit):

06:01 Changeset [95712] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreivewed gardening.

  • platform/qt-wk2/Skipped: Skip new failing test introduced in r95645.
05:50 Changeset [95711] by ossy@webkit.org
  • 64 edits in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt 4.8 specific expected files after r95706.

  • platform/qt-4.8/ [...]: Updated.
05:43 Changeset [95710] by jesus@webkit.org
  • 4 edits in trunk/Source

[Qt] Redirection overflow errors have wrong error domain
https://bugs.webkit.org/show_bug.cgi?id=68612

Reviewed by Andreas Kling.

Source/WebCore:

Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::redirect):

Source/WebKit2:

Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().

  • UIProcess/API/qt/qweberror.cpp:

(QWebError::type):

05:23 Changeset [95709] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected files for new test introduced in r95671.

  • platform/qt/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/qt/fast/table/quote-text-around-iframe-expected.txt: Added.
04:50 Changeset [95708] by ossy@webkit.org
  • 8 edits in trunk/Source/WebKit2

REGRESSION(r95679): It broke everything.
https://bugs.webkit.org/show_bug.cgi?id=68611

Unreviewed rolling out r95679 and r95690, because it broke everything.

  • UIProcess/API/mac/WKView.mm:

(maybeCreateSandboxExtensionFromPasteboard):
(-[WKView performDragOperation:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::getPluginPath):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::initializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::missingPluginButtonClicked):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

04:05 Changeset [95707] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

32-bit call code clobbers the function cell tag
https://bugs.webkit.org/show_bug.cgi?id=68606

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Csaba Osztrogonác.

This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):

03:23 Changeset [95706] by ossy@webkit.org
  • 134 edits
    2 adds in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt specific expected files.

03:17 Changeset [95705] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test expectation following r95685
https://bugs.webkit.org/show_bug.cgi?id=68604

Unreviewed, update test expectation.

  • platform/chromium/test_expectations.txt:
03:05 Changeset [95704] by ossy@webkit.org
  • 13 edits
    1 add in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596

Update Qt specific expected files.

  • platform/qt/fast/css-generated-content/table-cell-before-content-expected.png:
  • platform/qt/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
02:29 Changeset [95703] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening. Typo fixes.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22

  • platform/qt/Skipped:
00:53 Changeset [95702] by jamesr@google.com
  • 15 edits in trunk/Source

Unreviewed, rolling out r95699.
http://trac.webkit.org/changeset/95699
https://bugs.webkit.org/show_bug.cgi?id=67417

Makes many chromium compositor tests crash

Source/WebCore:

  • platform/CrossThreadCopier.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(WebCore::TEST):

00:40 Changeset [95701] by philn@webkit.org
  • 11 edits
    2 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95671.

  • platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt:
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt:
  • platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
00:35 Changeset [95700] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671.
https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22

  • platform/qt/Skipped:
00:22 Changeset [95699] by jamesr@google.com
  • 15 edits in trunk/Source

[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417

Source/WebCore:

Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.

Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/graphics/IntRect.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418

Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:
Note: See TracTimeline for information about the timeline view.